[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604

--- Comment #31 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I feel like Chris makes some valid points here when he says there is no proof
that the additional changes are needed. We have tested this patch and found it
to fix the problem we had reported. Patron images don't longer overlay and
repeat.

If we change the code further - what is the bug it fixes? What should be in the
test plan?


>FTR: I have no problem undefing the entire $image_data reference. As soon as I >have time, I will submit a follow-up patch. I also inadvertently removed the >statements which short-circuit the loop in the case of no image data. That needs >to be corrected as well.

Does this mean the patch should not be used as is? 

Could the additional requested changes moved to another bug report for
attending to them later?

-- 
You are receiving this mail because:
You are watching all bug changes.