[Koha-bugs] [Bug 13779] sessionID declared twice in C4::Auth::checkauth()

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Jul 19 09:01:03 CEST 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13779

--- Comment #2 from David Cook <dcook at prosentient.com.au> ---
Created attachment 77099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77099&action=edit
Bug 13779 - sessionID declared twice in C4::Auth::checkauth()

The bug is that $sessionID is declared twice in C4::Auth::checkauth().
At the moment, this doesn't actually create a problem, because no
one seems to be using the $sessionID which is returned by checkauth(),
except in the case of opac/external/overdrive/auth.pl which skips
the second declartion as it doesn't require auth.

This patch removes the redefining of the $sessionID variable.

In terms of testing, try logging in with a username and password
and see if it works. The only risk this patch would pose is breaking
auth I would think, since nothing is actually using the return value
from checkauth() for $sessionID.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list