[Koha-bugs] [Bug 21068] NorwegianPatronDBEnable - Check for prior ModMember calls that passed 'sync'

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21068

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |benjamin.rokseth at deichman.n
                   |                            |o,
                   |                            |boutrosboutrosboutros at gmail
                   |                            |.com

--- Comment #1 from Magnus Enger <magnus at libriotech.no> ---
As far as I can tell from the code and memory this is what was supposed to
happen: 

- If NorwegianPatronDBEnable is enabled, a radio button named "sync" is added
to the member add/edit form:
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt;h=36353607b3087b2a34bb72e053c57c664d4ae117;hb=HEAD#l619
This makes it possible to turn syncing on and off for individual patrons, as
required by the Norwegian patron database. 

- The value of "sync" from the form is then stored in the database as
borrower_sync.sync:
http://schema.koha-community.org/18_05/tables/borrower_sync.html here:
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Members.pm;h=a87bdd6b8881037a9402388e2dec1582a6bca81f;hb=290341d8dbd085e9d60aa38e7c03fa840a85cb3a#l829

So the value for "sync" is passed into ModMember from the member add/edit form,
if NorwegianPatronDBEnable is enabled. 

As far as I can tell, the FIXME at
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=Koha/Patron.pm;h=9524874acaba85ed69a5e291596930f52a4b65d3;hb=HEAD#l317
that now looks like this:

# FIXME THIS IS BROKEN # $borrowersync->update( { 'sync' => $data{'sync'} } );

should look like this:

$borrowersync->update( { 'sync' => $self->sync } );

Does that make sense? 

It would be great to hear the opinions of Benjamin and/or Petter at OPL on
this, since they are the ones running this code in production. I'm adding them
to the CC list.

-- 
You are receiving this mail because:
You are watching all bug changes.