[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jul 24 01:29:51 CEST 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #36 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Note for QA (does not block signoff):
* update DB entry is not idempotent
* Last of tests and POD for the new module
* merge markers in first patch
* This change is odd and need more attention 
-    $max_holds = undef if $max_holds !~ /^\d+/;
+    $max_holds = '' if $max_holds !~ /^\d+/;

Especially because it is different than others.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list