[Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524

--- Comment #41 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #40)
> > > After that is done, the code in CanItemBeReserved could be replaced with a
> > > call to GetBranchBorrowerCircRule.
> 
> This is, I think, still a valid request/question.
> In CanItemBeReserved there are 2 Koha::CirculationRules->find
> I am wondering why we do not call Koha::CirculationRules->get_effective_rule
> instead.
> Moreover it seems that there is a mix between '*' and undef. The UI inserts
> '*' whereas these calls and the tests search for undef.
> If we use undef we will be able to add FKs
> (branchcode,categorycode,itemtype) which can be great.

And this is for bug 18887.

-- 
You are receiving this mail because:
You are watching all bug changes.