[Koha-bugs] [Bug 20469] Add item status to staff article requests form

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469

--- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Core change is now:
+sub has_waiting_or_transit_hold {
+    my ( $self ) = @_;
+    my $rs = $self->_result->reserves;
+    return Koha::Holds->_new_from_dbic($rs)->waiting_or_transit->count;
+}

But I am still not completely happy about it. Fetching a result set, wrapping
it in Koha object and searching again..

Another approach would be to get the "found => [W, T] " attribute from a class
method in Koha Holds and pass it into the DBIx call in Koha Item. Resulting in
one search. But also not very nice..

Or add something like Koha::Holds->search_waiting_or_transit({ itemnumber => $x
})->count..

What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.