[Koha-bugs] [Bug 21031] Apache Rewrite rules don't work for API when using anything but Debian package Plack configuration

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21031

--- Comment #16 from David Cook <dcook at prosentient.com.au> ---
(In reply to Marcel de Rooy from comment #15)
> QA Comment:
> Thanks David. Improving parts not touched by most users (Debian/Plack).
> 
> Just a few remarks (close to nitpicking):
> [1] A difference with the rule in shared-opac-plack is that you do not
> include the PT flag. Note that this is fine. You do not need the PT flag
> since you have the rule in a <Directory> section. (The PT flag is implied in
> per-directory contexts.)
> [2] The implicit PT may explain why you got the two additional lines in the
> apache trace. Might be possible to finetune that, but needs more Apache
> background.
> [3] The rule is a bit hybrid. As you explained, it is in the context of a
> RewriteBase with /api/. So paths are relative. But the replacement is not
> relative but absolute. No reason to change, but a relative replace without
> /api in front would have looked good to me too.

Thanks for the notes! I appreciate the feedback and it gives me food for
thought!

-- 
You are receiving this mail because:
You are watching all bug changes.