[Koha-bugs] [Bug 21134] Wrong error handling in Koha/Patron/Modification.pm hides a bug

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jul 31 18:01:33 CEST 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21134

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77342|0                           |1
        is obsolete|                            |

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 77343
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77343&action=edit
Bug 21134: Correctly throw the exception in Koha::Patron::Modification->approve

koha_1       |     # Looks like you planned 20 tests but ran 9.
koha_1       |
koha_1       | #   Failed test 'approve tests'
koha_1       | #   at t/db_dependent/Koha/Patron/Modifications.t line
259.
koha_1       | [Something went wrong]# Looks like your test exited with
255 just after 5.
koha_1       | [21:13:47] t/db_dependent/Koha/Patron/Modifications.t
.....................

"Something went wrong" should never been thrown,
Koha::Patron::Modification->approve raises $@, but it's not defined, it
should raise $_ instead

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list