From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 00:16:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 May 2018 22:16:03 +0000
Subject: [Koha-bugs] [Bug 15273] Fines Payment receipt should include all
 account lines selected for this pay
In-Reply-To: <bug-15273-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15273-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15273-70-su45pLVioq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15273

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The base is there, but it will need someone to sponsor or work on the
development.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 00:39:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 May 2018 22:39:45 +0000
Subject: [Koha-bugs] [Bug 18896] Changes to Patron's Contact Info Not Logged
 if Submitted Via OPAC
In-Reply-To: <bug-18896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18896-70-0b5vtgUCVE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18896

Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mkstephens at lancasterseminar
                   |                            |y.edu

--- Comment #1 from Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> ---
I would like to +1 this. We just had an instance when the changes submitted by
the patron in the OPAC and approved in the staff client caused some unintended
changes. It was difficult to track down what exactly had happened since there
was no log of the request or the change.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 00:50:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 May 2018 22:50:58 +0000
Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after
	allocation
In-Reply-To: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20844-70-hM36jFB4NZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

--- Comment #2 from Hugh Rundle <hughr at brimbank.vic.gov.au> ---
(In reply to Katrin Fischer from comment #1)
> Hi Hugh, 
> so this woudl be to 'reset' a hold that has been waiting already? Does this
> happen often? It sounds like someone would be stealing from the waiting
> holds shelf.

Hi Katrin

Yes, this is specifically for holds that are waiting already. It could be
missing because someone has stolen it (rare, but certainly happens sometimes in
libraries that have open shelves for waiting holds), or it may simply have been
mislaid by staff between returning it and putting it on a waiting holds shelf
(possible in a busy library). It's certainly more common that may initially
seem likely.

The other thing I've just realised would need to be either part of this
enhancement, or paired with it perhaps as a different bug, is holds that go
missing when they're in transit. i.e. the hold 'allocates' to a specific item
when returned, but the pickup is at a different library. The notification won't
be sent until it is returned at the pickup point, but it might go missing
whilst in transit: in that case (which is more common) much the same process is
needed, in that there needs to be a simple way to reverse the allocation since
that item has gone missing, but there's probably no need to send a notification
saying it got lost since there never would have been one saying it was ready to
collect.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 01:26:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 May 2018 23:26:14 +0000
Subject: [Koha-bugs] [Bug 20836] debian/control.in cleanup
In-Reply-To: <bug-20836-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20836-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20836-70-fNq9MsTzBk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20836

--- Comment #3 from Mirko Tietgen <mirko at abunchofthings.net> ---
(In reply to Tom?s Cohen Arazi from comment #2)
> I clearly don't understand this line in the koha-common section of
> debian/control:
> 
> Depends: ${misc:Depends}, ${koha:Depends},

${misc:Depends} is used by debhelper, see below for ${koha:Depends}.


> as I don't understand how koha-common pulls all its deps, which are not in
> master's debian/control. 

koha-perldeps is the same as the perl part of build-depends. It is generated by
debian/update-control. It includes all perl modules that are required, and the
non-required ones that are available in the system you run the script. So
libwww-youtube-download-perl appears or not, depending on the distribution you
build in. A build in Jessie or Stretch has it, but a build in Wheezy doesn't.

${koha:Depends} is replaced by what debian/bd-to-depends generates. Which is
everything from build-depends minus exceptions. The reason to do this is to
have a shorter file. Which means libwww-youtube-download-perl is in there too,
ever since the official packages were no longer built in Wheezy and nobody ever
complained.

First I thought the Suggests section would magically override it, but it
doesn't. Extracting the deb of koha-common 18.05.00-2 there is
Suggests: mysql-server | virtual-mysql-server, letsencrypt

That was a fun ride with a nice twist. :D


> That said, I think we should add
> libwww-youtube-download-perl to the dependencies (why is it a dependency for
> koha-perldeps and not for koha-common?) I can file a bug for that.

We made libwww-youtube-download-perl optional because it was not available for
Wheezy, which we don't support anymore. It should be mandatory now.
We should remove the useless control.in entry in "Suggests" and set it to
required in PerlDependencies.pm (does not make a difference for the packages
though).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 01:35:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 May 2018 23:35:31 +0000
Subject: [Koha-bugs] [Bug 20836] debian/control.in cleanup
In-Reply-To: <bug-20836-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20836-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20836-70-KLLv7uStgk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20836

--- Comment #4 from Mirko Tietgen <mirko at abunchofthings.net> ---
Oh, and I think the right way to have 'Suggests' for Perl modules would be to
put them in debian/list-deps %ignore and debian/control.in

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 01:48:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 May 2018 23:48:15 +0000
Subject: [Koha-bugs] [Bug 20849] New: Add the ability on staff client to
 view all fines of a guarantee on the guarantor's account
Message-ID: <bug-20849-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20849

            Bug ID: 20849
           Summary: Add the ability on staff client to view all fines of a
                    guarantee on the guarantor's account
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Currently Koha will display the outstanding fines of a guarantee on the
guarantor's account only when the amount of the fines exceed the value of the
system preference: noissueschargesguarantees.  It would be nice to have this
value displayed on the guarantor's account whenever there is a fine as to let
staff know that the guarantor's guarantees have a balance.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 01:56:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 May 2018 23:56:02 +0000
Subject: [Koha-bugs] [Bug 15766] Give label and patron card batches a
	description
In-Reply-To: <bug-15766-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15766-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15766-70-xVWbtKOrdK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--- Comment #38 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Owen Leonard from comment #37)
> Although this was marked "Failed QA," it looks like it is ready for testing
> since there are no QA comments posted after the latest patches.

Hey Owen, I am currently working on Nick and Katrin's comments so will set to
Assigned until my follow-up patch is ready.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 04:22:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 02:22:31 +0000
Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost
	status
In-Reply-To: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14697-70-T31eqMQbU5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697

Hugh Rundle <hughr at brimbank.vic.gov.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hughr at brimbank.vic.gov.au

--- Comment #7 from Hugh Rundle <hughr at brimbank.vic.gov.au> ---
I see from http://devs.bywatersolutions.com/2016/11/30/Claimed-Returned/ this
is fully funded but nothing seems to have happened. Is there an update on this?
It would be a great feature.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 05:37:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 03:37:01 +0000
Subject: [Koha-bugs] [Bug 20543] Use multi-core compression to speed up Koha
	backups
In-Reply-To: <bug-20543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20543-70-Is9De6oEge@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20543

--- Comment #8 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Jonathan Druart from comment #7)
> (In reply to M. Tompsett from comment #6)
> > It's not installed by default.
> 
> Hum? The patch adds the dependency. In debian/control, I read "koha-common
> depends on pigz"

Right, and it should add it, because it is kind of silly to have a patch that
decides which to use if pigz is installed. People would generally not read any
documentation, if there would be any, about that possibility. Because we want
this out of the box, not need to know arcane knowledge to use it. This patch is
just fine the way it is.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 05:38:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 03:38:14 +0000
Subject: [Koha-bugs] [Bug 20543] Use multi-core compression to speed up Koha
	backups
In-Reply-To: <bug-20543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20543-70-7q8Ic0ke1w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20543

--- Comment #9 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Jonathan Druart from comment #7)
> (In reply to M. Tompsett from comment #6)
> > It's not installed by default.
> 
> Hum?

If we didn't add the dependency, it isn't in debian by default. You have to
install it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 07:40:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 05:40:28 +0000
Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when
 adding on order item to existing record
In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20817-70-PdyeNLRsmG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx for the explanation!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 07:46:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 05:46:29 +0000
Subject: [Koha-bugs] [Bug 20840] Internal Server Error when clicking on
	"Details" button
In-Reply-To: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20840-70-uDSopUOdRR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Claudio, I just tried this on master and didn't get an error. Does it happen
for all your fine entries?

Can you get to the logs on your system by chance to see the exact error
message?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 07:47:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 05:47:17 +0000
Subject: [Koha-bugs] [Bug 20840] Internal Server Error when clicking on
	"Details" button
In-Reply-To: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20840-70-Az3uCwXkCq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |2696


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696
[Bug 2696] Fine payments should show what was paid for
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 07:47:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 05:47:17 +0000
Subject: [Koha-bugs] [Bug 2696] Fine payments should show what was paid for
In-Reply-To: <bug-2696-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2696-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2696-70-7r81ofpIXG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20840


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840
[Bug 20840] Internal Server Error when clicking on "Details" button
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 08:20:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 06:20:50 +0000
Subject: [Koha-bugs] [Bug 7131] way to overlay items in in marc import
In-Reply-To: <bug-7131-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7131-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7131-70-aY1wN8wJfS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7131

Hugh Rundle <hughr at brimbank.vic.gov.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20850

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 08:20:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 06:20:50 +0000
Subject: [Koha-bugs] [Bug 20850] New: Option to delete all items on bib that
 have a -1 Not-for-loan value when doing a MARC import
Message-ID: <bug-20850-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20850

            Bug ID: 20850
           Summary: Option to delete all items on bib that have a -1
                    Not-for-loan value when doing a MARC import
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: MARC Bibliographic record staging/import
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: hughr at brimbank.vic.gov.au
        QA Contact: testopia at bugs.koha-community.org

It would be nice to expand on Bug 7131 by providing an option to delete all 'on
order' items on a bib when importing. This would allow for 'overlaying' of
order items with full item records when it is not possible to assign either a
matching barcode or a matching item number in the file being imported.

This could be done by checking the Not-For-Loan value: if it is -1 then the
item is an on-order item and can safely be removed. This would obviously not
suit all library workflows and could be dangerous for some, so would need to be
either a syspref or an option to select during import, or both.

Admins or librarians could choose whether to always delete items with NFL = -1,
or only do so if they also do not have a barcode.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 08:37:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 06:37:36 +0000
Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no
 article requests are permitted
In-Reply-To: <bug-17530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17530-70-QwtyY0u0bx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530

--- Comment #27 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #26)
> (In reply to Marcel de Rooy from comment #24)
> > (In reply to Jonathan Druart from comment #23)
> > > I have not tested it, just had a quick look.
> > Thats a good start ;)
> > 
> > > 1.
> > > This:
> > >   Koha::Biblio->may_article_request
> > > shows that Koha::Biblio is not the right place to put it. Koha::Object class
> > > should not have class methods.
> > Yes, this was arbitrary. I could move it to Koha::ItemType. What do you
> > think?
> > > 4. Maybe we do not need may_article_request, but only
> > > guess_article_requestable_itemtypes?
> > See point 1.
> 
> If we remove it, there is no need to move it... I do not understand your
> point.
> 

I do not want to remove it. I read: "I could move it to Koha::ItemType". Move
is not remove?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 09:01:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 07:01:23 +0000
Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no
 article requests are permitted
In-Reply-To: <bug-17530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17530-70-AbsYEhrteS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530

--- Comment #28 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #26)
> > > 3. The cache is cleared in a very lazy way :)
> > Lazy is good enough here imo.
> 
> I do not think so, the cache is flushed every time the page is hit.

The L1 cache is cleared. I do not see the need to remove it frequently from
memcached. If we change smart rules, it is cleared (even more strict than
needed; read: programmer's lazy). This cache is just for faster presentation,
no threat for bad data or so.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 09:21:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 07:21:08 +0000
Subject: [Koha-bugs] [Bug 20851] New: Missing module in
	circ/article-request-slip.pl
Message-ID: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851

            Bug ID: 20851
           Summary: Missing module in circ/article-request-slip.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

>From 20468, comment7 by Owen Leonard:
By the way, I get an error when I try to print a slip: "Undefined subroutine
&C4::Letters::GetPreparedLetter called at
/home/vagrant/kohaclone/circ/article-request-slip.pl line 49."

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 09:23:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 07:23:28 +0000
Subject: [Koha-bugs] [Bug 20851] Missing module in
	circ/article-request-slip.pl
In-Reply-To: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20851-70-Q4aKNWzQ9S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 09:23:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 07:23:47 +0000
Subject: [Koha-bugs] [Bug 20851] Missing module in
	circ/article-request-slip.pl
In-Reply-To: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20851-70-m7wT3rkheF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 09:23:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 07:23:31 +0000
Subject: [Koha-bugs] [Bug 20851] Missing module in
	circ/article-request-slip.pl
In-Reply-To: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20851-70-qQOOm9YptA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75719
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75719&action=edit
Bug 20851: Add module to circ/article-request-slip.pl

See bug 20468, comment7.
Although the script seems to compile well, we better add the module here.
Trivial change.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 09:24:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 07:24:33 +0000
Subject: [Koha-bugs] [Bug 20851] Missing module in
	circ/article-request-slip.pl
In-Reply-To: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20851-70-7u6YOqTMki@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Moving trivial fix to SO rightaway

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 09:25:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 07:25:13 +0000
Subject: [Koha-bugs] [Bug 20468] Multiselect on staff article requests form
In-Reply-To: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20468-70-e2AcH8CTBd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Owen Leonard from comment #7)
> By the way, I get an error when I try to print a slip: "Undefined subroutine
> &C4::Letters::GetPreparedLetter called at
> /home/vagrant/kohaclone/circ/article-request-slip.pl line 49."

Could not reproduce this one.
But to be safe, added the module on bug 20851.
Not related to this report btw.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 09:26:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 07:26:20 +0000
Subject: [Koha-bugs] [Bug 20468] Multiselect on staff article requests form
In-Reply-To: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20468-70-W4wLqnfM3a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Owen Leonard from comment #6)
> I agree with Joubu. In order to be consistent with every similar interface
> in Koha the select all/clear all links should be at the top of the table,
> inside the tab. 
> 
> Ideally the multi-action button should be disabled until there is a
> selection. If not, there should at least be a warning triggered when you
> choose one of those actions. Something like, "You must select one or more
> titles."

Design failures are the worst ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 09:37:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 07:37:33 +0000
Subject: [Koha-bugs] [Bug 20468] Multiselect on staff article requests form
In-Reply-To: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20468-70-8ZYcIPnr8c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75720
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75720&action=edit
Bug 20468: (QA follow-up) Design issues

Moving selection stuff to the top.
Why does the dropdown menu act so weird ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 09:38:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 07:38:23 +0000
Subject: [Koha-bugs] [Bug 20468] Multiselect on staff article requests form
In-Reply-To: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20468-70-J4bnClJvXQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #10)
> Created attachment 75720 [details] [review]
> Bug 20468: (QA follow-up) Design issues
> 
> Moving selection stuff to the top.
> Why does the dropdown menu act so weird ?

Owen, any idea why the menu does like it does?
I remember spending too much time on it before already ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 09:44:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 07:44:09 +0000
Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance
	killer
In-Reply-To: <bug-18821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18821-70-jMgiJxCeX2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED

--- Comment #41 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA: Having another look here

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 10:04:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 08:04:58 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-cu28lzp95v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75404|0                           |1
        is obsolete|                            |

--- Comment #67 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 75722
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75722&action=edit
Bug 17656 - Update irregularities on subscription renewals

Test plan:
  - Apply this patch,
  - Launch installer/data/mysql/updatedatabase.pl
  - Launch misc/devel/update_dbix_class_files.pl

  - Create a daily subscription. i.e:
    - From: 2017-10-09, To: 2017-10-15,
    - Frequency: 1/day,
    - 7 issues,
    - test prediction pattern
    - check Wednesday and Thursday as irregularity,
    - save
  - Renew subscription from 2017-10-16
  - Check that you have the prediction pattern table on renwal page
  - Submit renewal
  - Check that irregularity and permanent_irregularity column
    have been updated.

  - Do the same for a monthly and weekly subscription

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 10:04:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 08:04:46 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-KUukLJfCJy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75403|0                           |1
        is obsolete|                            |

--- Comment #66 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 75721
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75721&action=edit
Bug 17656 - Keep irregularities during subscription renewals

When renewing a subscription, irregularities are lost. This patch
allows to keep them for monthly, daily or weekly serials ( 1 unit per issue
only).

Test plan:
  - Apply this patch,
  - Launch installer/data/mysql/updatedatabase.pl
  - Launch misc/devel/update_dbix_class_files.pl

  - Create a daily subscription. i.e:
    - From: 2017-10-09, To: 2017-10-15,
    - Frequency: 1/day,
    - 7 issues,
    - test prediction pattern
    - check Wednesday and Thursday as irregularity,
    - save
  - Edit subscription,
  - Check that Wednesday and Thursday are still checked
  - Renew subscription from 2017-10-16
  - Edit subscription,
  - Make sure that Wednesday and Thursday are still checked
    with corresponding serials

  - Do the same for a monthly and weekly subscription

Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 10:05:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 08:05:24 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-GH3MVs6yJa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75406|0                           |1
        is obsolete|                            |

--- Comment #69 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 75724
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75724&action=edit
Bug 17656 - [QA followup] Remove useless description in
subscription_daily_choice.inc and subscription_monthly_choice.inc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 10:05:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 08:05:14 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-mx8ioPAWGg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75405|0                           |1
        is obsolete|                            |

--- Comment #68 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 75723
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75723&action=edit
Bug 17656 - Fix QA comments - Make day and month names translatable, - Update
unit tests, - Fix a typo in C4/Serials.pm (GessEndDate), - rename subtype
subroutine to lengthtype - DB Change: add changes in kohastructure.sql and
Bug_17656-add-permanent-irre

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 10:05:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 08:05:35 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-KBeb7eYtLq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75407|0                           |1
        is obsolete|                            |

--- Comment #70 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 75725
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75725&action=edit
Bug 17656: Update irregularities on multi-renewals

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 10:05:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 08:05:45 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-nixgEfoY6c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75408|0                           |1
        is obsolete|                            |

--- Comment #71 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 75726
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75726&action=edit
Bug 17656: move GuessEnddate in Koha::Subscription::guess_enddate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 10:07:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 08:07:21 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-QCDm03ppsY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #72 from Alex Arnaud <alex.arnaud at biblibre.com> ---
(In reply to Koha Team Lyon 3 from comment #65)
> Just a little thing about ergonomy of "Week(s) not published" scrolldown
> list : when you tick/untick a checkbox at first time, the form jumps
> surprisingly.
> Could we avoid this ?
> 
Fixed!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 10:28:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 08:28:34 +0000
Subject: [Koha-bugs] [Bug 20825] Cannot checkout if item types at biblio
	level
In-Reply-To: <bug-20825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20825-70-Nk3UOR5iqY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 10:38:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 08:38:09 +0000
Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to
	ElasticSearch
In-Reply-To: <bug-18316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18316-70-cekXKmuYAE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #77 from Alex Arnaud <alex.arnaud at biblibre.com> ---
The patch "Bug 18316: Change search field weight field to decimal" seems to
break the ability to erase weights.

I.e
  - set weihgt to 1.25 for title,
  - save,
  - erase (empty) the weight input for title,
  - save,
  - weight is still here with the same value.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 10:38:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 08:38:16 +0000
Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to
	ElasticSearch
In-Reply-To: <bug-18316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18316-70-9cfYzdEZyM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 10:47:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 08:47:20 +0000
Subject: [Koha-bugs] [Bug 20852] New: Make "All libraries" default
 organisation for article requests
Message-ID: <bug-20852-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20852

            Bug ID: 20852
           Summary: Make "All libraries" default organisation for article
                    requests
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

At the moment the pick-up location a user selects in the OPAC will decide which
library the article request shows up for in the interface. The tabs are
organized by pick-up location.

- There is no label stating it's the pickup location in the staff interface.
- The pick-up library is not necessarily the library, that will the article
request. So for processing new article requests the workflow is not ideal, as
the library always has to switch to 'all libraries' in order to see requests
they possibly have to process.

As Koha allows article requests to be set on record level, Koha doesn't know
which libraries might be able to fill the article request. So it might be best
to optionally allow setting to "all libraries" and also adapt the note on the
dashboard accordingly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 10:53:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 08:53:09 +0000
Subject: [Koha-bugs] [Bug 20853] New: Show holding library for item level
 article requests
Message-ID: <bug-20853-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20853

            Bug ID: 20853
           Summary: Show holding library for item level article requests
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

It would be nice if more information about the item was shown for article
requests on item level. At the moment the callnumber and the barcode is shown,
but not all libraries assign unique callnumbers per item and not always
barcodes for serial issues. 

It would be nice if we could at least show the holding library for the item.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 10:59:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 08:59:10 +0000
Subject: [Koha-bugs] [Bug 20778] Unable to delete a subscription
In-Reply-To: <bug-20778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20778-70-KuHOJUc3jm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |In Discussion

--- Comment #6 from Alex Arnaud <alex.arnaud at biblibre.com> ---
(In reply to Marcel de Rooy from comment #5)
> I think we are not adding consistency in this script by removing a confirm
> from one of the js functions in a row of similar ones.
> Should you remove the other confirmation perhaps ?
> 
> If you have confirm_deletion as name, I would expect a confirm there too.

Hello Marcel,

Not sure to understand what you are expecting. If i remove the 2 others JS
confirmation (for closing and reopening), we have no more confirmation at all.
I did it for deleting because there is an other one after. So the JS one is
useless.

Other possibility is to remove the one after JS for subscription deletion.

I agree that this BZ is for fixing subscription deleting. Not for removing a
useless confirmation. So i can just do what it is expected for

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 11:14:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 09:14:08 +0000
Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance
	killer
In-Reply-To: <bug-18821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18821-70-NztENabBZ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

--- Comment #42 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Kyle M Hall from comment #35)
> I actually think a hybrid of your first and second suggestions is the best
> solution. We should use cache *and* test a date! Why do you think we will
> use too much memory? Let's assume we have 1000 simultaneous users. That's
> still a minuscule amount of memory compared to caching the marc frameworks,
> for example.

On second thought, the consumed cache may be very limited indeed.
Nice!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 11:14:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 09:14:45 +0000
Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance
	killer
In-Reply-To: <bug-18821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18821-70-bLmhKfTrk4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 11:14:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 09:14:49 +0000
Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance
	killer
In-Reply-To: <bug-18821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18821-70-pOJ30ykC4I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75634|0                           |1
        is obsolete|                            |
  Attachment #75635|0                           |1
        is obsolete|                            |

--- Comment #43 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75727
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75727&action=edit
Bug 18821: TrackLastPatronActivity is a performance killer

Test Plan:
1) Apply this patch
2) Start a new session ( a private browser window works well )
3) Note the lastseen column in the borrowers table is updated
4) Browse a few pages, not the lastseen column is not updated again
5) Close the browser window and repeat steps 2-4
6) prove t/db_dependent/Auth.t

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 11:14:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 09:14:54 +0000
Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance
	killer
In-Reply-To: <bug-18821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18821-70-dGwxvuY1LO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

--- Comment #44 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75728
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75728&action=edit
Bug 18821: Convert to using cache with date checking

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 11:15:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 09:15:00 +0000
Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance
	killer
In-Reply-To: <bug-18821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18821-70-LXVeU0nn0y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

--- Comment #45 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75729
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75729&action=edit
Bug 18821: (QA follow-up) Last tweaks for performance

[1] passing unsafe has no use since it is a scalar, removed it to unconfuse
[2] remove caching when pref is disabled
[3] caching userid removes the need for calling Patron->find each time
[4] subsequent changes in unit test
[5] cosmetic renames to move from session to daily basis (changed dev angle)

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
First call going thru Koha::Patron takes about 0.0150 sec.
Subsequent calls only use caching and take about 0.0006 sec.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 11:24:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 09:24:47 +0000
Subject: [Koha-bugs] [Bug 20778] Unable to delete a subscription
In-Reply-To: <bug-20778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20778-70-DoGDxiKvc9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Alex Arnaud from comment #6)
> Not sure to understand what you are expecting. If i remove the 2 others JS
> confirmation (for closing and reopening), we have no more confirmation at
> all. I did it for deleting because there is an other one after. So the JS
> one is useless.
> 
> Other possibility is to remove the one after JS for subscription deletion.
> 
> I agree that this BZ is for fixing subscription deleting. Not for removing a
> useless confirmation. So i can just do what it is expected for

Yeah. Consider removing the one after the JS confirm.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 11:28:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 09:28:22 +0000
Subject: [Koha-bugs] [Bug 20838] Search by group of libraries is broken
In-Reply-To: <bug-20838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20838-70-WomwOrCLq2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |BLOCKED

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA: Looking here

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 11:43:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 09:43:34 +0000
Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to
	ElasticSearch
In-Reply-To: <bug-18316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18316-70-7R3P7ZgaZX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #78 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 75730
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75730&action=edit
Bug 18316: Fix field weight validation/deletion bug

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 11:43:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 09:43:40 +0000
Subject: [Koha-bugs] [Bug 20838] Search by group of libraries is broken
In-Reply-To: <bug-20838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20838-70-dR2oO5Kw4g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 11:43:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 09:43:43 +0000
Subject: [Koha-bugs] [Bug 20838] Search by group of libraries is broken
In-Reply-To: <bug-20838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20838-70-BK1wT6Iobl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75700|0                           |1
        is obsolete|                            |

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75731
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75731&action=edit
Bug 20838: (bug 16735 follow-up) Fix search by group of libraries

In the last patches of bug 16735, we completely broke the feature!

The limit is using library_groups.id instead of branches.branchcode.

Test plan:
Create a group of library with the search feature
Search (OPAC and staff interfaces) using this limit

=> Without this patch you will see that the generated search query does
not contain branchcodes
=> With this patch applied you will see the branchcodes

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 11:43:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 09:43:48 +0000
Subject: [Koha-bugs] [Bug 20838] Search by group of libraries is broken
In-Reply-To: <bug-20838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20838-70-XOkUra11Rl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75701|0                           |1
        is obsolete|                            |

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75732
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75732&action=edit
Bug 20838: Make Koha::Library::Group->all_libraries return a list of
Koha::Libraries

Instead of a list of Koha::Library::Group
Ideally it should be a Koh::Libraries iterator

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 11:44:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 09:44:13 +0000
Subject: [Koha-bugs] [Bug 20838] Search by group of libraries is broken
In-Reply-To: <bug-20838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20838-70-YhfV5M8TnT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Test coverage of all_libraries is rather limited..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 11:44:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 09:44:25 +0000
Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to
	ElasticSearch
In-Reply-To: <bug-18316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18316-70-okesKdlCo5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 11:44:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 09:44:52 +0000
Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to
	ElasticSearch
In-Reply-To: <bug-18316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18316-70-JM3pE4DjSx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #79 from David Gustafsson <glasklas at gmail.com> ---
Ok! This should now be fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 12:19:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 10:19:14 +0000
Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons
	payments/fines
In-Reply-To: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12310-70-6yLwJYo33S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #95 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Preliminary QA:

Very brave to take this upon you !

Tiny suggestion:
.decimal-unformating
Fix spelling please. At least t => tt but what is decimal unformat btw? Better
name? Something with normalize or so??

I have the feeling that DecimalSeparators and CurrencyFormat don't really
harmonize. And yes, I can understand how problematic making changes in this
area must be..

So thousands separators come at the expense of handling both dots and commas.
Still opt for something that is more understandable.

The number of changes to be expected here would be much larger. You actually
use the new js formatting in three acq templates.
What about things like:
C4/Biblio.pm:                $subfield_value =~ s/\./,/ if
C4::Context->preference("CurrencyFormat") eq "FR";
acqui/addorderiso2709.pl:                        $price =~ s/\./,/ if
C4::Context->preference("CurrencyFormat") eq "FR";
acqui/addorderiso2709.pl:                $price =~ s/\./,/ if
C4::Context->preference("CurrencyFormat") eq "FR";
Koha/Number/Price.pm
    $format_params = {
        %$format_params,
        int_curr_symbol   => '',
        mon_thousands_sep => '',
        mon_decimal_point => '.',
    };
koha-tmpl/intranet-tmpl/prog/en/includes/format_price.inc
    [% IF Koha.Preference("CurrencyFormat") == 'FR' %]
        var default_value = {
            thousands_sep: ' ',
            decimal_point: ',',
            decimal_digits: 2
        };
And this is just to name a few; the list could probably be larger when
searching harder.
It might be impossible to make global changes but the risk of this is adding
just another approach in a few places and leaving Koha even more fragmented on
the subject?

Changing state for need of feedback or adjustments.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 12:46:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 10:46:58 +0000
Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance
	killer
In-Reply-To: <bug-18821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18821-70-per0nlJOjf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75729|0                           |1
        is obsolete|                            |

--- Comment #46 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 75733
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75733&action=edit
Bug 18821: (QA follow-up) Last tweaks for performance

[1] passing unsafe has no use since it is a scalar, removed it to unconfuse
[2] remove caching when pref is disabled
[3] caching userid removes the need for calling Patron->find each time
[4] subsequent changes in unit test
[5] cosmetic renames to move from session to daily basis (changed dev angle)

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
First call going thru Koha::Patron takes about 0.0150 sec.
Subsequent calls only use caching and take about 0.0006 sec.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 13:12:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 11:12:47 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-OgX5dYq3qr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

--- Comment #9 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 75734
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75734&action=edit
Bug 20600: (follow-up) Do not use $_ in loop

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 13:12:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 11:12:59 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-z3GISQvtB6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

--- Comment #10 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 75735
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75735&action=edit
Bug 20600: (follow-up) Remove date formatting

It is not required

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 13:14:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 11:14:37 +0000
Subject: [Koha-bugs] [Bug 20722] Searching only for an ITEMTYPECAT itemtype
	is impossible
In-Reply-To: <bug-20722-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20722-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20722-70-UtkGtukYAb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20722

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Could this be considered for backporting to 17.11?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 13:17:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 11:17:36 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-qLIOsa0a5m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

--- Comment #11 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Hi Jonathan

Thanks for your feedback.

1. OK, addressed in
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75734
2. OK, addressed in
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75735
3. Thanks for the pointer towards title-string. I have used the *_formatted
fields to allow me to display the date fields in the datatable according to the
date format set in the sysprefs. Since the data is coming in to the datatable
from an API call, I'm not sure how else I can do it. $KohaDates obviously won't
work, I couldn't get title-string to either, though, having done some research,
it appears it is used to control sorting, rather than display formatting.
4. Good point, I'll create a follow-up patch and submit it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 13:33:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 11:33:55 +0000
Subject: [Koha-bugs] [Bug 20854] New: Redirect after logout with CAS 3.0
	broken
Message-ID: <bug-20854-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20854

            Bug ID: 20854
           Summary: Redirect after logout with CAS 3.0 broken
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

There has been a change in the parameters for the logout request between CAS
2.0 und CAS 3.0:

Redirect URL parameter
CAS 2.0: url
CAS 3.0: service

The CAS module used by Koha officially only support CAS 2.0, so when you logout
from a CAS 3.0 server now, the redirect to Koha will be broken.

See here:
https://github.com/apereo/cas/blob/master/docs/cas-server-documentation/protocol/CAS-Protocol-Specification.md

Note: The url parameter defined in the former CAS 2.0 specification is not a
valid parameter in CAS 3.0 anymore. CAS Servers MUST ignore given url
parameters. A CAS client MAY provide the service parameter as described above,
as this ensures the parameter is validated against the registered service URLs
when operating in non-open mode. See 2.3.2 for details.

We are using the following 'hack' to make the redirect work correctly:

C4/Auth_with_cas.pm
$uri =~ s/\?logout\.x=1//; # We don't want to keep triggering a logout, if we
got here, the borrower is already logged out of Koha
-    print $query->redirect( $cas->logout_url(url => $uri));
+    my $logout_url = $cas->logout_url(url => $uri);
+    $logout_url =~ s/url/service/;
+    print $query->redirect( $logout_url );

We won't have time to fix this properly, but wanted to document problem and
workaround at least.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 14:06:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 12:06:53 +0000
Subject: [Koha-bugs] [Bug 20855] New: transferstoreceive.pl returns internal
	server error
Message-ID: <bug-20855-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20855

            Bug ID: 20855
           Summary: transferstoreceive.pl returns internal server error
 Change sponsored?: ---
           Product: Koha
           Version: 17.11
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lulihua at ibwya.net
        QA Contact: testopia at bugs.koha-community.org

/cgi-bin/koha/circ/transferstoreceive.pl returns internal server error on some
of branches, but works fine on other branches.
All these branches have some configuration.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 14:47:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 12:47:51 +0000
Subject: [Koha-bugs] [Bug 13049] Merge selfreg cron jobs into
	cleanup_database
In-Reply-To: <bug-13049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13049-70-kMS7oXgkmh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It looks like this change introduced a regression. Before the changes it was
possible to define the delay for unverified registrations in hours and now it's
days. It will also change what actually happens when you switch over?

With GDPR being very strict about saving data the initial feature of being able
to delete after x hours would be better.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 15:00:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 13:00:33 +0000
Subject: [Koha-bugs] [Bug 20856] New: Restore ability to delete unverified
 self registrations after x hours
Message-ID: <bug-20856-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20856

            Bug ID: 20856
           Summary: Restore ability to delete unverified self
                    registrations after x hours
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

With bug 13049 the behaviour of the  was changed, so the number of hours
defined for will be recalculated into days now (minimum 1).

It would be nice if it was possible again to give the delay in hours.

But we should at least change the help of
delete_unverified_opac_registrations.pl to point out that limitation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 15:02:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 13:02:54 +0000
Subject: [Koha-bugs] [Bug 20856] Restore ability to delete unverified self
 registrations after x hours
In-Reply-To: <bug-20856-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20856-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20856-70-6LZwQibjVA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20856

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
To be fair, there is a note:

IMPORTANT: You should no longer call this script. Please use
cleanup_database.pl with parameter --del-unv-selfreg.

Totally missed it, was only looking at the options.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 15:08:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 13:08:57 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-uJutq6NSVk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
There is a date range filter example in serials/claims.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 15:14:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 13:14:10 +0000
Subject: [Koha-bugs] [Bug 19436] Add SRU support for authorities
In-Reply-To: <bug-19436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19436-70-sdPL2Vym4v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19436

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I do not know this code but seems quite old school and error prone.

It seemed safer to not include it into 18.05.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 15:17:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 13:17:13 +0000
Subject: [Koha-bugs] [Bug 13049] Merge selfreg cron jobs into
	cleanup_database
In-Reply-To: <bug-13049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13049-70-25mMWOVNUW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049

--- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #18)
> It looks like this change introduced a regression. Before the changes it was
> possible to define the delay for unverified registrations in hours and now
> it's days. It will also change what actually happens when you switch over?
> 
> With GDPR being very strict about saving data the initial feature of being
> able to delete after x hours would be better.

I think you are being even stricter now :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 15:28:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 13:28:46 +0000
Subject: [Koha-bugs] [Bug 13049] Merge selfreg cron jobs into
	cleanup_database
In-Reply-To: <bug-13049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13049-70-rCYX6Jbge3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20856


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20856
[Bug 20856] Restore ability to delete unverified self registrations after x
hours
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 15:28:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 13:28:46 +0000
Subject: [Koha-bugs] [Bug 20856] Restore ability to delete unverified self
 registrations after x hours
In-Reply-To: <bug-20856-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20856-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20856-70-Wh5fL0FKVU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20856

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13049


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049
[Bug 13049] Merge selfreg cron jobs into cleanup_database
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 15:29:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 13:29:37 +0000
Subject: [Koha-bugs] [Bug 13049] Merge selfreg cron jobs into
	cleanup_database
In-Reply-To: <bug-13049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13049-70-BgGQ1Ds0nn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Marcel de Rooy from comment #19)
> (In reply to Katrin Fischer from comment #18)
> > It looks like this change introduced a regression. Before the changes it was
> > possible to define the delay for unverified registrations in hours and now
> > it's days. It will also change what actually happens when you switch over?
> > 
> > With GDPR being very strict about saving data the initial feature of being
> > able to delete after x hours would be better.
> 
> I think you are being even stricter now :)

Triggered by a request from a library.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 15:33:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 13:33:57 +0000
Subject: [Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all
 staff members / no specific permission
In-Reply-To: <bug-11911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11911-70-1AckkOrQpG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |release-notes-needed

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
We should highlight the change in the release notes:

Before:
members/purchase-suggestions.pl required { borrowers => 'edit_borrowers' }
suggestion/suggestion.pl required { catalogue => 1 }

After the require the new { acquisition => 'suggestions_manage' }

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 15:34:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 13:34:15 +0000
Subject: [Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all
 staff members / no specific permission
In-Reply-To: <bug-11911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11911-70-29JxztzxSy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #17)
> After the require the new { acquisition => 'suggestions_manage' }

they*

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 15:34:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 13:34:47 +0000
Subject: [Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all
 staff members / no specific permission
In-Reply-To: <bug-11911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11911-70-JFoPLhtFzs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 15:34:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 13:34:52 +0000
Subject: [Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all
 staff members / no specific permission
In-Reply-To: <bug-11911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11911-70-7bD0ffLoXV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75630|0                           |1
        is obsolete|                            |
  Attachment #75631|0                           |1
        is obsolete|                            |

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75736
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75736&action=edit
Bug 11911: Add a separate permission for managing suggestions

Without this patch only catalogue permission was required
for managing suggestions. This patch adds a new permission
in the acquisition module do manage suggestions and updates
staff user permissions accordingly.

To test:
- Make sure there is a pending suggestion
- Create a few users with different permission sets:
  - User 1: only catalogue
  - User 2: any acquisition permission
  - User 3: cataloguing permission
- Check all of them can access: /cgi-bin/koha/suggestion/suggestion.pl
- Apply the patch
- Verify all of them now have the suggestions_manage permission
- Verify everything displays correctly on:
  - intranet start page
  - patron account in staff
  - acquisition start page
  - suggestion page (try to access by URL too)
- Remove suggestions_manage for a staff user
- Repeat tests above, access should be denied/links not visible

Bonus:
- Fixes the link on the acquisition start page for late orders
  to mage the permissions of the page itself: order_receive

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 15:34:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 13:34:57 +0000
Subject: [Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all
 staff members / no specific permission
In-Reply-To: <bug-11911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11911-70-3AnX5b062p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75737
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75737&action=edit
Bug 11911: (follow-up) Hide suggestion box on acq start page if no permission

When the user is not superlibrarian or has the manage_suggestions
permission, the suggestion box on the left of the acq start page
needs to be hidden.

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 15:43:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 13:43:43 +0000
Subject: [Koha-bugs] [Bug 20726] Display acquisition details on the
 subscription detail page
In-Reply-To: <bug-20726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20726-70-kqPdU18VWL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20726

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to S?verine Queune from comment #23)
> Works as expected now :)
> 
> What do you think about the tooltip or something similar ?

Yes maybe, but I am not convinced. I would prefer to wait for another
idea/opinion.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 15:49:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 13:49:18 +0000
Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no
 article requests are permitted
In-Reply-To: <bug-17530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17530-70-gK2DQRiRTy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530

--- Comment #29 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #27)
> Move is not remove?

I suggested to remove it: "4. Maybe we do not need may_article_request, but
only guess_article_requestable_itemtypes?"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 15:52:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 13:52:47 +0000
Subject: [Koha-bugs] [Bug 20840] Internal Server Error when clicking on
	"Details" button
In-Reply-To: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20840-70-WPNUQX3R5d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
You should also see a more meaningful error in the log file.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 16:31:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 14:31:15 +0000
Subject: [Koha-bugs] [Bug 20840] Internal Server Error when clicking on
	"Details" button
In-Reply-To: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20840-70-EsmVXIvLPU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840

--- Comment #3 from Claudio <costalc at gmail.com> ---
Katrin, Jonathan

I cannot identify a more meaningful message in the log files. See a new
attached PDF with further  samples.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 16:32:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 14:32:21 +0000
Subject: [Koha-bugs] [Bug 20840] Internal Server Error when clicking on
	"Details" button
In-Reply-To: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20840-70-nwbBj4MjWa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840

--- Comment #4 from Claudio <costalc at gmail.com> ---
Created attachment 75738
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75738&action=edit
Further samples

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 16:40:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 14:40:16 +0000
Subject: [Koha-bugs] [Bug 20838] Search by group of libraries is broken
In-Reply-To: <bug-20838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20838-70-l9xduTP0lN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75739
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75739&action=edit
Bug 20838: Add 2 small tests to check ref

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 16:43:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 14:43:42 +0000
Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in
	staff client
In-Reply-To: <bug-14377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14377-70-V1WFoEg2oz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20846


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20846
[Bug 20846] Suppressed Records Still Appear in Public Lists
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 16:43:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 14:43:42 +0000
Subject: [Koha-bugs] [Bug 20846] Suppressed Records Still Appear in Public
	Lists
In-Reply-To: <bug-20846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20846-70-AkB56NF2fj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20846

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Depends on|                            |14377
            Version|17.05                       |master


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377
[Bug 14377] Indicate that a record is suppressed in staff client
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 16:44:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 14:44:47 +0000
Subject: [Koha-bugs] [Bug 20855] transferstoreceive.pl returns internal
	server error
In-Reply-To: <bug-20855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20855-70-ZBjNYMm6HN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20855

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Could you give us a step by step plan to recreate the problem?

Can you have a look at the Koha log file, you will find a more meaningful
error.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 16:46:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 14:46:39 +0000
Subject: [Koha-bugs] [Bug 20855] transferstoreceive.pl returns internal
	server error
In-Reply-To: <bug-20855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20855-70-GLyhkcbLUF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20855

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Personal note:

 98             $getransf{'itemtype'} = $itemtype->description; # FIXME Should
not it be translated_description?

may cause problem if the item type is not defined in the itemtypes table.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 16:46:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 14:46:49 +0000
Subject: [Koha-bugs] [Bug 20855] transferstoreceive.pl returns internal
	server error
In-Reply-To: <bug-20855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20855-70-a0yafRhW6T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20855

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|17.11                       |master
           Severity|minor                       |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 16:58:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 14:58:17 +0000
Subject: [Koha-bugs] [Bug 20840] Internal Server Error when clicking on
	"Details" button
In-Reply-To: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20840-70-xMzkzw8zvM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
You should have something in the log file, please double-check :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 17:13:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 15:13:21 +0000
Subject: [Koha-bugs] [Bug 20840] Internal Server Error when clicking on
	"Details" button
In-Reply-To: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20840-70-OFRR3a55ym@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840

--- Comment #6 from Claudio <costalc at gmail.com> ---
I'm so sorry Jonathan, I have not expressed myself correctly. I checked the log
files out but did not identify any meaningful message about this issue. I have
checked all log files in /var/log/koha/INSTANCE.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 17:35:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 15:35:59 +0000
Subject: [Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of
	'Available'
In-Reply-To: <bug-15505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15505-70-3SgMIhm9Sm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505

--- Comment #7 from George Williams (NEKLS) <george at nekls.org> ---
Working in a large consortium, I definitely want something like this.

If a patron looks at the OPAC and sees a title with 30 items spread around at
different locations and 20 are already checked out and there are 15 unfilled
requests on the remaining 10 items the existing message can be confusing if
you're not at a branch where a copy is actually available to be grabbed off of
the shelf.

Maybe the issue could be resolved by allowing for the wording of the wording of
the "Pending hold" message to be customized to suit the needs of the library. 
If the message that displays when there is a pending hold on an item could be
tied to an authorised value, then each library could customize the description
of the item's availability in the staff client and the OPAC to suit the needs
of their library.  If, for example, I want an item that is hold_fill_targets to
display a message that the item has a hold on it then I can change the
authorised value to read "Pending hold" but if I want it to display the same
availability as any other item on the shelf, I could change the authorised
value to read "Available."

George

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 17:59:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 15:59:37 +0000
Subject: [Koha-bugs] [Bug 20857] New: "Orders search" filters overlap the
 toolbar on the basket view
Message-ID: <bug-20857-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20857

            Bug ID: 20857
           Summary: "Orders search" filters  overlap the toolbar on the
                    basket view
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

https://screenshots.firefox.com/i7RA3SES6uYwKP2I/pro.kohadev.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 18:03:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 16:03:24 +0000
Subject: [Koha-bugs] [Bug 20857] "Orders search" filters overlap the toolbar
 on the basket view
In-Reply-To: <bug-20857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20857-70-3b26xqCORD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20857

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75740
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75740&action=edit
Bug 20857: Take the filters block into account to position the toolbar

This does not work for 2 reasons:
- additional_height is always 0, but even when moved inside the onclick
block the height is not the correct one.
- This mimicks what is done on members/memberentrygen.tt, but the way
the block is toggled is different:
  $('.filteraction').toggle();
vs
  class="toggle_element" data-element="#filters,.filteraction"
Maybe we should adjust that first

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 18:22:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 16:22:30 +0000
Subject: [Koha-bugs] [Bug 15184] Ability to duplicate existing order lines
 to create a new basket
In-Reply-To: <bug-15184-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15184-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15184-70-C3Ocvk8tHD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Do we want to create a new basket by duplicating order lines from only one
basket, or from several baskets?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 18:22:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 16:22:35 +0000
Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons
	payments/fines
In-Reply-To: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12310-70-WCRCR79mFn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

--- Comment #96 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
(In reply to Marcel de Rooy from comment #95)
> Very brave to take this upon you !

Thanks Marcel :)

> Tiny suggestion:
> .decimal-unformating
> Fix spelling please. At least t => tt

Indeed >< thanks for catching this. QA++ :)
TODO implement

> but what is decimal unformat btw?

I followed this example:
https://metacpan.org/pod/Number::Format#unformat_number($formatted)

> Better name? Something with normalize or so??

.number-normalizing 
.number-normalizer
.number-normalize
.decimal-normalizing 
.decimal-normalizer
.decimal-normalize

Which one would be good enough?
TODO wait answer, blocking question

> I have the feeling that DecimalSeparators and CurrencyFormat don't really
> harmonize. And yes, I can understand how problematic making changes in this
> area must be..
> 
> So thousands separators come at the expense of handling both dots and commas.
> Still opt for something that is more understandable.

I'm not sure to understand. Is the the current state the patch on this topic
acceptable?

> The number of changes to be expected here would be much larger. You actually
> use the new js formatting in three acq templates.
> What about things like:
> [...]
> And this is just to name a few; the list could probably be larger when
> searching harder.
> It might be impossible to make global changes but the risk of this is adding
> just another approach in a few places and leaving Koha even more fragmented
> on the subject?

I split the patch because the test plan was way too long.
http://irc.koha-community.org/koha/2018-03-30#i_2024887
http://irc.koha-community.org/koha/2018-03-30#i_2024900

When this bug and bug 18723[1] will be in master there won't be more
fragmentation than today.
And less actually.

locally: acquisitions and payments/fines will be internally less fragmented.
  as there are currently different behaviors in *successive pages* [2]
globally: the new approach replaces an existing one (I checked that it not used
elsewhere)
  see moneyFormat function.
  https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75127&action=diff

So, are these changes a step in the right direct worth of begin integrated?
TODO wait answer, blocking question


[1] which will also apply these changes to aqbudgetperiods.tt  aqbudgets.tt in
addition of the pages concerned by the bug description.

[2] a big reason of why I get the most requests to fix decimal sep issues in
these views

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 18:23:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 16:23:58 +0000
Subject: [Koha-bugs] [Bug 20783] Cannot embed some YouTube videos due to 403
	errors
In-Reply-To: <bug-20783-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20783-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20783-70-33cB7yy1wZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20783

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |juan.sieira at xercode.es

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 18:30:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 16:30:07 +0000
Subject: [Koha-bugs] [Bug 15184] Ability to duplicate existing order lines
 to create a new basket
In-Reply-To: <bug-15184-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15184-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15184-70-OIHxLGUPQb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
We can imagine

1. You are on the vendor view (/acqui/supplier.pl?booksellerid=X), click on
"New > Duplicate a basket", then you select the order lines you want to
duplicate.

or 2. You are on the basket view (/acqui/basket.pl?basketno=X), click "Add to
basket > From existing order lines"
Then you get a form/table like the one we have to search order lines
(acqui/histsearch.pl), then you select the ones you want to duplicate.

In both case we will have another view to change the values you want to modify.

We could also:
3. You are viewing an existing basket, you click on a "duplicate" link next to
one of the orders. Then you select another basket in a list. That sounds less
flexible, but could be implemented later

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 18:41:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 16:41:02 +0000
Subject: [Koha-bugs] [Bug 20468] Multiselect on staff article requests form
In-Reply-To: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20468-70-AfWHmOd888@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 18:41:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 16:41:05 +0000
Subject: [Koha-bugs] [Bug 20468] Multiselect on staff article requests form
In-Reply-To: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20468-70-VJTDxtEaR8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468

--- Comment #12 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 75741
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75741&action=edit
Bug 20468: (follow-up) Changes to checkbox/menu interactions

This patch makes a couple of minor interface changes and updates the way
checkbox change events are handled:

 - jQueryUI tabs initialization sets a variable for "active table" which
   can be re-used by functions which affect only the visible table.
 - The batch "Actions" menu is shown or hidden based on whether there
   are checked items.
 - The item selection tools are shown or hidden based on whether there
   are rows in the table.

To test, apply the patch and test various article request actions:

 - Single "process," "complete," and "cancel" operations.
 - Select all/ clear all operations on both tabs.
 - Batch operations with checked requests.
 - Process all pending requests to confirm the selection controls for
   that table are hidden.
 - Complete all processing requests to confirm the selection controls
   for that table are hidden.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 18:57:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 16:57:29 +0000
Subject: [Koha-bugs] [Bug 20840] Internal Server Error when clicking on
	"Details" button
In-Reply-To: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20840-70-8WeZw0aHkZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 18:57:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 16:57:33 +0000
Subject: [Koha-bugs] [Bug 20840] Internal Server Error when clicking on
	"Details" button
In-Reply-To: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20840-70-bgUx9WyI18@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75742
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75742&action=edit
Bug 20840: (bug 2696 follow-up) Fix biblio info fetch

There is no accountlines.biblionumber field, if the account line is
linked to an item, accountline-details.pl will explode with:
Template process failed: undef error - The method biblionumber is not
covered by tests!

Test plan:
Create a fine for a given item
Pay the fine
View the detail of the account line

=> Without this patch you get a software error
=> With this patch applied you will see the biblio's title

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 18:58:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 16:58:01 +0000
Subject: [Koha-bugs] [Bug 20840] Internal Server Error when clicking on
	"Details" button
In-Reply-To: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20840-70-dlxIUiVc2d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
           Severity|major                       |critical
           Keywords|                            |rel_18_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 18:58:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 16:58:50 +0000
Subject: [Koha-bugs] [Bug 20767] "The method is not covered by tests!"
 should give more information
In-Reply-To: <bug-20767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20767-70-KbxSxd75qY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_18_05_candidate

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
We need it to be backported to help debug!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 19:23:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 17:23:51 +0000
Subject: [Koha-bugs] [Bug 20840] Internal Server Error when clicking on
	"Details" button
In-Reply-To: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20840-70-8oVkEKnavP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 19:23:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 17:23:54 +0000
Subject: [Koha-bugs] [Bug 20840] Internal Server Error when clicking on
	"Details" button
In-Reply-To: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20840-70-1Ez0PiukYN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75742|0                           |1
        is obsolete|                            |

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 75743
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75743&action=edit
Bug 20840: (bug 2696 follow-up) Fix biblio info fetch

There is no accountlines.biblionumber field, if the account line is
linked to an item, accountline-details.pl will explode with:
Template process failed: undef error - The method biblionumber is not
covered by tests!

Test plan:
Create a fine for a given item
Pay the fine
View the detail of the account line

=> Without this patch you get a software error
=> With this patch applied you will see the biblio's title

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 19:40:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 17:40:22 +0000
Subject: [Koha-bugs] [Bug 20840] Internal Server Error when clicking on
	"Details" button
In-Reply-To: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20840-70-8DZoFROgpv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840

--- Comment #9 from Claudio <costalc at gmail.com> ---
Jonathan, finally it works for me!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 22:21:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 20:21:02 +0000
Subject: [Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of
	'Available'
In-Reply-To: <bug-15505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15505-70-n3acdL2kde@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505

--- Comment #8 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to George Williams (NEKLS) from comment #7)
> Working in a large consortium, I definitely want something like this.
> 
> If a patron looks at the OPAC and sees a title with 30 items spread around
> at different locations and 20 are already checked out and there are 15
> unfilled requests on the remaining 10 items the existing message can be
> confusing if you're not at a branch where a copy is actually available to be
> grabbed off of the shelf.
> 
> Maybe the issue could be resolved by allowing for the wording of the wording
> of the "Pending hold" message to be customized to suit the needs of the
> library.  If the message that displays when there is a pending hold on an
> item could be tied to an authorised value, then each library could customize
> the description of the item's availability in the staff client and the OPAC
> to suit the needs of their library.  If, for example, I want an item that is
> hold_fill_targets to display a message that the item has a hold on it then I
> can change the authorised value to read "Pending hold" but if I want it to
> display the same availability as any other item on the shelf, I could change
> the authorised value to read "Available."
> 
> George

I agree with George.  This feature is needed, yet, we need to do it in a way
that won't jeopardize how some libraries already use it.  If it can be setup in
a way we can tailor it, that would be great.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  1 22:58:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 20:58:05 +0000
Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to
 account page instead of back to search results
In-Reply-To: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17153-70-yYCPeERkHr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |maryse.simard at inlibro.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun  2 00:20:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 22:20:28 +0000
Subject: [Koha-bugs] [Bug 20859] New: SMS and other notification preferences
 during self registration
Message-ID: <bug-20859-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859

            Bug ID: 20859
           Summary: SMS and other notification preferences during self
                    registration
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org

Some libraries would prefer the option for patrons to choose their notification
preferences and setup their SMS information during registration.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun  2 00:25:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jun 2018 22:25:04 +0000
Subject: [Koha-bugs] [Bug 20860] New: List last e-mail address/SMS
	number/carrier sent to
Message-ID: <bug-20860-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20860

            Bug ID: 20860
           Summary: List last e-mail address/SMS number/carrier sent to
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org

It would be helpful if the notifications listed the last e-mail address or SMS
number and carrier that each notice was sent to.  That way we know if the
information was changed before/after the last failure.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun  2 09:56:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jun 2018 07:56:38 +0000
Subject: [Koha-bugs] [Bug 19835] Update MARC frameworks to Updates 23+24+25
 (Nov 2016, May and Dec 2017)
In-Reply-To: <bug-19835-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19835-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19835-70-5i3hgjyjSK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19835

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun  2 10:26:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jun 2018 08:26:24 +0000
Subject: [Koha-bugs] [Bug 19835] Update MARC frameworks to Updates 23+24+25
 (Nov 2016, May and Dec 2017)
In-Reply-To: <bug-19835-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19835-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19835-70-z7ue3szWpY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19835

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #10 from Josef Moravec <josef.moravec at gmail.com> ---
Good job Bernardo!

But I am missing the changes in codes... Could you please update value builders
too?

Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun  2 11:06:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jun 2018 09:06:10 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-gUKyRvs8Yp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dpavlin at rot13.org

--- Comment #135 from Dobrica Pavlinusic <dpavlin at rot13.org> ---
(In reply to Chris Cormack from comment #132)
> I actually find this incredibly disappointing. We could have had a working
> feature in 18.05 except for people consistently trying to scope creep it.
> Now we won't until at least 18.11 and it will probably be over specced, over
> ambitious and fragile.
> This has to stop.

I have to throw in my $0.02 here: we just implemented recall notices on
reservations using simple cron script:

https://github.com/dpavlin/Koha/blob/koha_ffzg/ffzg/recall_notices.pl

I would love to replace hard-coded values in it with circulation rules, but
currently this bug doesn't apply, and squashing some of fixes into more
manageable chunks would be great first step.

Due to our library circulation rules, OPAC parts of this patch are not
interesting to us, but I would love to have intranet part in upstream Koha so
that I can contribute cron script similar to ours. Does it make sense to split
this bug into two halfs opac and intranet?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun  2 11:12:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jun 2018 09:12:55 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-BagncLDPmN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #136 from Chris Cormack <chris at bigballofwax.co.nz> ---
While reserves might work for one use case, they won't for others. So instead
of people turning this set of patches into the mess they've made it. There
should have just been 2 different features.

We (Catalyst) are unlikely to put any more work into rebasing these for the
400th time until people figure out what they actually want. Even though we have
the feature in production already

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun  2 13:45:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jun 2018 11:45:50 +0000
Subject: [Koha-bugs] [Bug 20229] Remove problematic SQL modes
In-Reply-To: <bug-20229-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20229-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20229-70-t6FiWOdCCE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20229

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun  2 14:22:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jun 2018 12:22:14 +0000
Subject: [Koha-bugs] [Bug 19835] Update MARC frameworks to Updates 23+24+25
 (Nov 2016, May and Dec 2017)
In-Reply-To: <bug-19835-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19835-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19835-70-sKtW7XK0s0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19835

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Josef, there has been a separate bug 20700 - is that what you are missing?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun  2 23:47:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jun 2018 21:47:28 +0000
Subject: [Koha-bugs] [Bug 20840] Internal Server Error when clicking on
	"Details" button
In-Reply-To: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20840-70-1NL3M9it5E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun  2 23:47:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jun 2018 21:47:31 +0000
Subject: [Koha-bugs] [Bug 20840] Internal Server Error when clicking on
	"Details" button
In-Reply-To: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20840-70-tmQkNJQiUb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75743|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 75744
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75744&action=edit
Bug 20840: (bug 2696 follow-up) Fix biblio info fetch

There is no accountlines.biblionumber field, if the account line is
linked to an item, accountline-details.pl will explode with:
Template process failed: undef error - The method biblionumber is not
covered by tests!

Test plan:
Create a fine for a given item
Pay the fine
View the detail of the account line

=> Without this patch you get a software error
=> With this patch applied you will see the biblio's title

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun  2 23:50:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jun 2018 21:50:38 +0000
Subject: [Koha-bugs] [Bug 20851] Missing module in
	circ/article-request-slip.pl
In-Reply-To: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20851-70-fz5BRoCgcu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I don't see a sign off or a test plan. What is this supposed to fix?

Printing article request slips works without problems for me.
Can you please explain and reset to needs signoff?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun  2 23:56:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jun 2018 21:56:55 +0000
Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be
 write as description, not code
In-Reply-To: <bug-20806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20806-70-AAK8ewNwJy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think this might be related to AllowHoldItemTypeSelection that allows you to
pick an itemtype when placing the hold? Maybe we can make the visibility of the
column depend on that?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun  3 03:02:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jun 2018 01:02:15 +0000
Subject: [Koha-bugs] [Bug 19835] Update MARC frameworks to Updates 23+24+25
 (Nov 2016, May and Dec 2017)
In-Reply-To: <bug-19835-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19835-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19835-70-ctyhHDuOuC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19835

--- Comment #12 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Josef Moravec from comment #10)
> But I am missing the changes in codes... Could you please update value
> builders too?

Hi Josef, as Katrin said code changes for update 23 were fixed on Bug 20700,
plus some missing code changes from update 22.
Code changes for update 26 are in Bug 20710.

With those bugs and this I think we will be up to date :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun  3 05:30:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jun 2018 03:30:50 +0000
Subject: [Koha-bugs] [Bug 20855] transferstoreceive.pl returns internal
	server error
In-Reply-To: <bug-20855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20855-70-i5M1W2zJs5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20855

--- Comment #3 from lulihua at ibwya.net ---
Many thanks to Jonathan
Based on your hint, we found that quite a few of items in our branches with
'itype.items' as null. Eliminating all the nulls,
/cgi-bin/koha/circ/transferstoreceive.pl works fine for all branches.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun  3 09:51:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jun 2018 07:51:51 +0000
Subject: [Koha-bugs] [Bug 20520] Re-indent moremember.tt
In-Reply-To: <bug-20520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20520-70-teF3OxXi3Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun  3 09:51:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jun 2018 07:51:55 +0000
Subject: [Koha-bugs] [Bug 20520] Re-indent moremember.tt
In-Reply-To: <bug-20520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20520-70-j9yFMQI9sQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75500|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 75745
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75745&action=edit
Bug 20520: Re-indent moremember.tt

This patch reindents the template for the patron detail page,
moremember.tt:

- Trailing spaces removed
- Indentation changed to a consistent 4 spaces
- Markup indentation made more consistent

To test, view the patron detail page. There should be no visible
difference before and after the applying the patch.

HTML validation before and after the patch should return the same
results.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun  3 09:58:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jun 2018 07:58:01 +0000
Subject: [Koha-bugs] [Bug 20807] Lost items report: Improve the display of
 CSV profile errors
In-Reply-To: <bug-20807-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20807-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20807-70-iVzMZ5xgaf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20807

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun  3 09:58:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jun 2018 07:58:04 +0000
Subject: [Koha-bugs] [Bug 20807] Lost items report: Improve the display of
 CSV profile errors
In-Reply-To: <bug-20807-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20807-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20807-70-5w45FGtkOz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20807

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75513|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 75746
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75746&action=edit
Bug 20807: Lost items report: Improve the display of CSV profile errors

This patch modifies the template for the lost items report to change the
way it handles a missing CSV profile. Now, if there is a missing CSV
profile, a message is displayed with details about the profile
requirements. If the logged-in user has the right permission there is a
link to the CSV profiles page.

Since item selection is used only in conjunction with exporting results,
item selection controls are all hidden when there is no valid CSV
profile.

To test, apply the patch go to Reports -> Lost items.

 - Run the report with parameters which will return results.
 - If your system has no CSV profile for exporting lost items:
   - If you are logged in as a user with manage_csv_profiles permission:
     - You should see a message dialog instructing you to create a CSV
       profile with a link to the CSV profiles page.
   - If you are not logged in as a user with manage_csv_profiles
     permission:
     - You should see a similar message but without a link to the CSV
       profiles page.
   - In both cases, with no CSV profile defined there should be no
     checkboxes in the table of results and no "select all/clear all"
     controls.
 - If your system has a valid CSV profile for exporting lost items:
   - Checking the checkbox for one or more items in the table should
     trigger the display of an "Export selected items" link.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun  3 10:02:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jun 2018 08:02:19 +0000
Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to
 account page instead of back to search results
In-Reply-To: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17153-70-K3M4b5vmoe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Maryse, did you mean to sign off on this patch? I see that you changed the
status. Did you test and can you add your sign-off line to the patch plz?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun  3 10:08:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jun 2018 08:08:58 +0000
Subject: [Koha-bugs] [Bug 20861] New: Correct EDI permissions on some pages
Message-ID: <bug-20861-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20861

            Bug ID: 20861
           Summary: Correct EDI permissions on some pages
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

It's edi_manage not manage_edi.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun  3 10:12:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jun 2018 08:12:10 +0000
Subject: [Koha-bugs] [Bug 20861] Correct EDI permissions on some pages
In-Reply-To: <bug-20861-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20861-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20861-70-nEH2AiTnll@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20861

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun  3 10:12:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jun 2018 08:12:13 +0000
Subject: [Koha-bugs] [Bug 20861] Correct EDI permissions on some pages
In-Reply-To: <bug-20861-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20861-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20861-70-PBYvjs2h83@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20861

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 75747
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75747&action=edit
Bug 20861: Correct EDI permissions on EDI messsages

The permission for EDI is edi_manage, but 2 pages asked
for manage_edi, allowing users not to access those.

To test:
- Add edi_manage to your permissions
- Try to access the EDIFACT messages from the
  acq start page
- Verify it doesn't work
- Apply patch and try again
- You should be able to access the page now
- Try to access the other page directly (if you don't
  have EDI data):
  /cgi-bin/koha/acqui/edimsg.pl
- Verify you can access the page and don't get a
  permission error

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun  3 10:12:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jun 2018 08:12:40 +0000
Subject: [Koha-bugs] [Bug 20861] Correct EDI permissions on some pages
In-Reply-To: <bug-20861-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20861-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20861-70-BFpFGIQhsx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20861

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun  3 10:14:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jun 2018 08:14:46 +0000
Subject: [Koha-bugs] [Bug 20667] Update two-column templates with Bootstrap
 grid: Acquisitions part 1
In-Reply-To: <bug-20667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20667-70-p0pLCYD9LE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20667

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun  3 10:14:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jun 2018 08:14:50 +0000
Subject: [Koha-bugs] [Bug 20667] Update two-column templates with Bootstrap
 grid: Acquisitions part 1
In-Reply-To: <bug-20667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20667-70-J9Q6PVB0HN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20667

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74959|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 75748
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75748&action=edit
Bug 20667: Update two-column templates with Bootstrap grid: Acquisitions part 1

This patch modifies several acquisitions templates to use the Bootstrap
grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

- Acquisitions -> Home page
- Acquisitions -> Vendor search results
- Acquisitions -> Vendor -> Basket groups
  -> Edit
- Acquisitions -> EDIFACT messages
  -> View EDIFACT message

Signed-off-by: Dilan Johnpull? <dilan at calyx.net.au>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun  3 10:16:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jun 2018 08:16:04 +0000
Subject: [Koha-bugs] [Bug 20667] Update two-column templates with Bootstrap
 grid: Acquisitions part 1
In-Reply-To: <bug-20667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20667-70-oZV6DQ83h8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20667

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Found a permission problem while testing this, filed and fixed on bug 20861.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun  3 11:07:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jun 2018 09:07:49 +0000
Subject: [Koha-bugs] [Bug 20862] New: Error on cart when containing a
	deleted record
Message-ID: <bug-20862-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20862

            Bug ID: 20862
           Summary: Error on cart when containing a deleted record
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Seen on intranet:

When the cart contains the biblionumber of a deleted record, on opening the
cart an Internal server error will be shown.

This can happen, when your index is not up to date and maybe when deleting a
record after adding it in some circumstances. We should handle it more
gracefully.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun  3 11:09:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jun 2018 09:09:54 +0000
Subject: [Koha-bugs] [Bug 20863] New: Delete bib_list and intranet_bib_list
 cookies when cart is emptied out
Message-ID: <bug-20863-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20863

            Bug ID: 20863
           Summary: Delete bib_list and intranet_bib_list cookies when
                    cart is emptied out
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

When adding items to the cart, the bib_list or intranet_bib_list cookie is set.
When 'emtpy and close' is used the value of the cookie is set to /, but we
should just remove it instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun  3 11:45:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jun 2018 09:45:35 +0000
Subject: [Koha-bugs] [Bug 20864] New: Only set bibs_selected cookie when
 BrowseResultSelection is activated
Message-ID: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864

            Bug ID: 20864
           Summary: Only set bibs_selected cookie when
                    BrowseResultSelection is activated
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

The bibs_selected cookie stores the biblionumbers of entries selected in a
search result list. At the moment the cookies appears to always be set, even if
BrowseResultSelection is set to disabled.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun  3 11:45:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jun 2018 09:45:41 +0000
Subject: [Koha-bugs] [Bug 20864] Only set bibs_selected cookie when
 BrowseResultSelection is activated
In-Reply-To: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20864-70-1KOd4BqjaL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun  3 12:05:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jun 2018 10:05:32 +0000
Subject: [Koha-bugs] [Bug 20865] Remove space before : on order receive
	filters
In-Reply-To: <bug-20865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20865-70-2ZGirZc8nL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20865

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun  3 12:05:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jun 2018 10:05:19 +0000
Subject: [Koha-bugs] [Bug 20865] New: Remove space before : on order receive
	filters
Message-ID: <bug-20865-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20865

            Bug ID: 20865
           Summary: Remove space before : on order receive filters
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

When receiving an order, the summary page with the order lines allows filtering
on the left side. Each label ends with space: instead of just the colon.

Small spelling thing, easy to fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun  3 19:08:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jun 2018 17:08:46 +0000
Subject: [Koha-bugs] [Bug 20851] Missing module in
	circ/article-request-slip.pl
In-Reply-To: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20851-70-f65i9PXhNl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #3)
> I don't see a sign off or a test plan. What is this supposed to fix?
> 
> Printing article request slips works without problems for me.
> Can you please explain and reset to needs signoff?

LOL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun  3 20:37:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jun 2018 18:37:19 +0000
Subject: [Koha-bugs] [Bug 20851] Missing module in
	circ/article-request-slip.pl
In-Reply-To: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20851-70-f4mldQwlWW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
If you think my request is so silly, maybe you should epxlain it anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun  3 21:36:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jun 2018 19:36:12 +0000
Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be
 write as description, not code
In-Reply-To: <bug-20806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20806-70-lB64sGjbyi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
... which is exactly what Jonathan suggested.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 08:27:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 06:27:09 +0000
Subject: [Koha-bugs] [Bug 20851] Missing module in
	circ/article-request-slip.pl
In-Reply-To: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20851-70-2cfW1qVeyh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #5)
> If you think my request is so silly, maybe you should epxlain it anyway.

Sure :)
As mentioned in comment1 Owen got an error. And you and I did not (see also
commit message). The error comes from a missing module; might be a devbox
config issue for Owen.
But the script itself calls C4::Letters but does not load it. So it depends on
implicit loading by one of the other modules or deeper down the chain. We
should not assume it will be loaded. If one day Letters is removed elsewhere,
the script does not compile. So what does this oneliner do: add the missing
module for that reason. Which is indeed stated ultra compact in the commit msg.
No test plan needed. Back to SO.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 08:42:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 06:42:58 +0000
Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons
	payments/fines
In-Reply-To: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12310-70-Vj4qajMcTS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

--- Comment #97 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Victor Grousset/tuxayo from comment #96)
> I followed this example:
> https://metacpan.org/pod/Number::Format#unformat_number($formatted)
OK If you feel the name is good enough, keep it. No big deal. Just do not use
formating, single t :)

> > So thousands separators come at the expense of handling both dots and commas.
> > Still opt for something that is more understandable.
> I'm not sure to understand. Is the the current state the patch on this topic
> acceptable?
Would it be clearer if you would say that you c/should not use characters from
the DecimalSeparator pref also as thousands separator?


> I split the patch because the test plan was way too long.
> http://irc.koha-community.org/koha/2018-03-30#i_2024887
> http://irc.koha-community.org/koha/2018-03-30#i_2024900
> 
> When this bug and bug 18723[1] will be in master there won't be more
> fragmentation than today.
> And less actually.
> 
> locally: acquisitions and payments/fines will be internally less fragmented.
>   as there are currently different behaviors in *successive pages* [2]
> globally: the new approach replaces an existing one (I checked that it not
> used elsewhere)
>   see moneyFormat function.
>  
> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75127&action=diff
> 
> So, are these changes a step in the right direct worth of begin integrated?
> TODO wait answer, blocking question
Well, I just hope so. But willing to follow your argument. Feel free to submit
the tiny adjustments you intend to, and I will try to finish here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 09:02:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 07:02:25 +0000
Subject: [Koha-bugs] [Bug 20468] Multiselect on staff article requests form
In-Reply-To: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20468-70-ZkOA5Tmsvw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75720|0                           |1
        is obsolete|                            |
  Attachment #75741|0                           |1
        is obsolete|                            |

--- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75749&action=edit
Bug 20468: (follow-up) Changes to checkbox/menu interactions

This patch makes a couple of minor interface changes and updates the way
checkbox change events are handled:

 - jQueryUI tabs initialization sets a variable for "active table" which
   can be re-used by functions which affect only the visible table.
 - The batch "Actions" menu is shown or hidden based on whether there
   are checked items.
 - The item selection tools are shown or hidden based on whether there
   are rows in the table.

To test, apply the patch and test various article request actions:

 - Single "process," "complete," and "cancel" operations.
 - Select all/ clear all operations on both tabs.
 - Batch operations with checked requests.
 - Process all pending requests to confirm the selection controls for
   that table are hidden.
 - Complete all processing requests to confirm the selection controls
   for that table are hidden.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 09:02:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 07:02:21 +0000
Subject: [Koha-bugs] [Bug 20468] Multiselect on staff article requests form
In-Reply-To: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20468-70-f80jdrar2G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 09:03:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 07:03:30 +0000
Subject: [Koha-bugs] [Bug 20468] Multiselect on staff article requests form
In-Reply-To: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20468-70-nglMBMk25D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Merged the last two patches into the last one of Owen.
Thx Owen. Great design improvements !

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 09:09:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 07:09:56 +0000
Subject: [Koha-bugs] [Bug 19436] Add SRU support for authorities
In-Reply-To: <bug-19436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19436-70-RO9jGl9hFc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19436

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #22)
> I do not know this code but seems quite old school and error prone.
> 
> It seemed safer to not include it into 18.05.

Thx for responding now. Too bad that there was no chance for any participant on
this report to address such concerns.

@Nick: Could you push this one soon now? Let's catch these errors ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 09:32:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 07:32:29 +0000
Subject: [Koha-bugs] [Bug 13049] Merge selfreg cron jobs into
	cleanup_database
In-Reply-To: <bug-13049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13049-70-97WxTYZRkk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049

--- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #20)
> (In reply to Marcel de Rooy from comment #19)
> > (In reply to Katrin Fischer from comment #18)
> > > It looks like this change introduced a regression. Before the changes it was
> > > possible to define the delay for unverified registrations in hours and now
> > > it's days. It will also change what actually happens when you switch over?
> > > 
> > > With GDPR being very strict about saving data the initial feature of being
> > > able to delete after x hours would be better.
> > 
> > I think you are being even stricter now :)
> 
> Triggered by a request from a library.

I will try to submit some patches on bug 20819 this week. It now includes a
(pref controlled) checkbox on opac-memberentry to give consent during
selfregistration. No consent means no registration. Which makes this request
less urgent again, since you will have a consent. (But note that we could
already argue that it is not possible to "perform this contract" of
self-registration without data. Second ground of GDPR.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 09:33:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 07:33:24 +0000
Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing
 personal data in account menu and self-registration
In-Reply-To: <bug-20819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20819-70-qybmoMFhSE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|GDPR: Add a consent field   |GDPR: Add a consent field
                   |for processing personal     |for processing personal
                   |data                        |data in account menu and
                   |                            |self-registration

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 09:43:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 07:43:24 +0000
Subject: [Koha-bugs] [Bug 12027] Shibboleth authentication for staff client
In-Reply-To: <bug-12027-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12027-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12027-70-dMBv5sft0x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027

Ray Delahunty <r.delahunty at arts.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |r.delahunty at arts.ac.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 10:25:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 08:25:25 +0000
Subject: [Koha-bugs] [Bug 20866] New: ArticleRequests.t fails on existing
	requests
Message-ID: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20866

            Bug ID: 20866
           Summary: ArticleRequests.t fails on existing requests
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

Subtest search_limited fails.
# Subtest: search_limited
    1..4
    ok 1 - Koha::ArticleRequests should return all article requests
    not ok 2 - Koha::ArticleRequests->search_limited should return all article
requests for superlibrarian
    #   Failed test 'Koha::ArticleRequests->search_limited should return all
article requests for superlibrarian'
    #   at t/db_dependent/ArticleRequests.t line 216.
    #          got: '1'
    #     expected: '3'
    ok 3 - Koha::ArticleRequests should return all article requests
    not ok 4 - Koha::ArticleRequests->search_limited should not return all
article requests for restricted patron
    #   Failed test 'Koha::ArticleRequests->search_limited should not return
all article requests for restricted patron'
    #   at t/db_dependent/ArticleRequests.t line 219.
    #          got: '0'
    #     expected: '2'
    # Looks like you failed 2 tests of 4.
not ok 55 - search_limited

Can be fixed by clearing the table at the start.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 10:30:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 08:30:14 +0000
Subject: [Koha-bugs] [Bug 20866] ArticleRequests.t fails on existing requests
In-Reply-To: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20866-70-Fhrdocm4wA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20866

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 10:30:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 08:30:17 +0000
Subject: [Koha-bugs] [Bug 20866] ArticleRequests.t fails on existing requests
In-Reply-To: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20866-70-WXeBX6zLAT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20866

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75750
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75750&action=edit
Bug 20866: Fix ArticleRequests.t when table contains records

Subtest search_limited fails. Assumptions in that code may not be true.
Simple fix for now: clear the table at the start.

Test plan:
[1] Create an article request.
[2] Run t/db_dependent/ArticleRequests.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 10:33:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 08:33:37 +0000
Subject: [Koha-bugs] [Bug 20866] ArticleRequests.t fails on existing requests
In-Reply-To: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20866-70-YelzkZBhAZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20866

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |m.de.rooy at rijksmuseum.nl
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Signing off too: trivial fix

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 12:20:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 10:20:17 +0000
Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no
 article requests are permitted
In-Reply-To: <bug-17530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17530-70-u3ghSyp7sE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530

--- Comment #30 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75751
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75751&action=edit
Bug 17530: (QA follow-up) Move may_article_request to ItemType

As requested by QA, we should move may_article_request out of Biblio.

For reasons of performance removed the wrapper layer of may_article_request
in opac-search. No need to look up all item types. For readability kept
the routine in the detail scripts.

Note for running ArticleRequests.t: A possible failure on the subtest
'search_limited' is addressed on bug 20866. So you can ignore that one.
As long as the subtest for may_article_request passes.

Test plan:
See previous patches.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 12:22:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 10:22:05 +0000
Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no
 article requests are permitted
In-Reply-To: <bug-17530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17530-70-vbRtClk2xp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530

--- Comment #31 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #29)
> (In reply to Marcel de Rooy from comment #27)
> > Move is not remove?
> 
> I suggested to remove it: "4. Maybe we do not need may_article_request, but
> only guess_article_requestable_itemtypes?"

Moved to Koha::ItemType and removed in opac-search.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 12:35:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 10:35:16 +0000
Subject: [Koha-bugs] [Bug 20867] New: Ability to show membership renewal
 date on moremember.pl page.
Message-ID: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867

            Bug ID: 20867
           Summary: Ability to show membership renewal date on
                    moremember.pl page.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: amitddng135 at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Ability to show membership renewal date on moremember.pl page.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 12:41:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 10:41:15 +0000
Subject: [Koha-bugs] [Bug 20867] Ability to show membership renewal date on
 moremember.pl page.
In-Reply-To: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20867-70-oMnkuTiXSh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867

--- Comment #1 from Amit Gupta <amitddng135 at gmail.com> ---
Created attachment 75752
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75752&action=edit
Bug 20867 - Ability to show membership renewal date on  moremember.pl page

Test case:
1. Create the patron.
2. Search the patron whose date of membership is about to expire or expired.
3. Click on More->Renew patron.
4. Now membership is renewed.
4. Apply the patch.
5. Refersh the page now you will able to see the Membership renewal date.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 12:41:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 10:41:59 +0000
Subject: [Koha-bugs] [Bug 6758] Capture membership renewal date for
	reporting purposes
In-Reply-To: <bug-6758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6758-70-OfEq4Nc1bF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6758

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20867

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 12:41:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 10:41:59 +0000
Subject: [Koha-bugs] [Bug 20867] Ability to show membership renewal date on
 moremember.pl page.
In-Reply-To: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20867-70-OUUO42jDih@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |amitddng135 at gmail.com
                   |ity.org                     |
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=6758
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 12:53:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 10:53:14 +0000
Subject: [Koha-bugs] [Bug 20867] Ability to show membership renewal date on
 moremember.pl page.
In-Reply-To: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20867-70-YQ7B0h5u18@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 12:59:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 10:59:57 +0000
Subject: [Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber
In-Reply-To: <bug-9921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9921-70-6lRWB71zNn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921

paxed <pasi.kallinen at joensuu.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pasi.kallinen at joensuu.fi

--- Comment #58 from paxed <pasi.kallinen at joensuu.fi> ---
(In reply to emjhet from comment #57)
> Like the 2013 thread starter and initial commentator, I believe MARC
> designates the 001 field (Control Number) for use to uniquely identify a
> bibliographic record.

001 alone does not guarantee uniqueness. 001 and 003 together should be
globally unique. If 001 is changed, then 003 should be changed to match the org
code of the system.

You could have eg. 001 generated in your system (and 003 with your org code),
and another (imported) record with 001 from another system and the 003
containing the org code of that other system.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 13:01:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 11:01:42 +0000
Subject: [Koha-bugs] [Bug 20868] New: Making billing date mandatory when
	closing invoice
Message-ID: <bug-20868-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20868

            Bug ID: 20868
           Summary: Making billing date mandatory when closing invoice
 Change sponsored?: ---
           Product: Koha
           Version: 17.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: information at newcastle.gov.uk
        QA Contact: testopia at bugs.koha-community.org

Would it be possible to make the billing date a mandatory field before you
close an invoice for payment? Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 13:11:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 11:11:36 +0000
Subject: [Koha-bugs] [Bug 20722] Searching only for an ITEMTYPECAT itemtype
	is impossible
In-Reply-To: <bug-20722-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20722-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20722-70-2EBea4Rx8X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20722

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 13:46:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 11:46:48 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-RvjvMjTfRy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

--- Comment #13 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 75753
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75753&action=edit
Bug 20600: (follow-up) Add date range filtering

It makes more sense to be able to filter placed and updated dates by
range. This patch adds that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 13:48:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 11:48:43 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-a4Ny1xwNI7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

--- Comment #14 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Hi Jonathan

I've now added a follow-up patch to add the date range filtering. I ended up
not following the example you cited, it appears to take a very manual approach
of hiding all table rows and then showing them depending on whether they pass
the filter test. Doing some research, Datatables has an API that allows custom
filters to be defined, it felt cleaner to do this the proper Datatables way.

Anyway, thanks for your help on this! :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 13:50:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 11:50:24 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-3Bz7wm2c3D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75753|0                           |1
        is obsolete|                            |

--- Comment #15 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 75755
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75755&action=edit
Bug 20600: (follow-up) Add date range filtering

It makes more sense to be able to filter placed and updated dates by
range. This patch adds that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 14:27:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 12:27:25 +0000
Subject: [Koha-bugs] [Bug 19835] Update MARC frameworks to Updates 23+24+25
 (Nov 2016, May and Dec 2017)
In-Reply-To: <bug-19835-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19835-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19835-70-uEov9jXvMF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19835

--- Comment #13 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Bernardo Gonzalez Kriegel from comment #12)
> (In reply to Josef Moravec from comment #10)
> > But I am missing the changes in codes... Could you please update value
> > builders too?
> 
> Hi Josef, as Katrin said code changes for update 23 were fixed on Bug 20700,
> plus some missing code changes from update 22.
> Code changes for update 26 are in Bug 20710.
> 
> With those bugs and this I think we will be up to date :)



(In reply to Katrin Fischer from comment #11)
> Hi Josef, there has been a separate bug 20700 - is that what you are missing?

Yes, that's exactly what I was missing ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 14:28:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 12:28:00 +0000
Subject: [Koha-bugs] [Bug 19835] Update MARC frameworks to Updates 23+24+25
 (Nov 2016, May and Dec 2017)
In-Reply-To: <bug-19835-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19835-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19835-70-fTLlZE0Fjf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19835

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #14 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Bernardo Gonzalez Kriegel from comment #12)
> (In reply to Josef Moravec from comment #10)
> > But I am missing the changes in codes... Could you please update value
> > builders too?
> 
> Hi Josef, as Katrin said code changes for update 23 were fixed on Bug 20700,
> plus some missing code changes from update 22.
> Code changes for update 26 are in Bug 20710.
> 
> With those bugs and this I think we will be up to date :)

Thanks, then I am going to pass this one ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 14:34:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 12:34:19 +0000
Subject: [Koha-bugs] [Bug 19835] Update MARC frameworks to Updates 23+24+25
 (Nov 2016, May and Dec 2017)
In-Reply-To: <bug-19835-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19835-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19835-70-4ZQqf7FtLR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19835

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 14:34:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 12:34:22 +0000
Subject: [Koha-bugs] [Bug 19835] Update MARC frameworks to Updates 23+24+25
 (Nov 2016, May and Dec 2017)
In-Reply-To: <bug-19835-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19835-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19835-70-lpRqzphp0X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19835

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74930|0                           |1
        is obsolete|                            |
  Attachment #74931|0                           |1
        is obsolete|                            |
  Attachment #74932|0                           |1
        is obsolete|                            |
  Attachment #74933|0                           |1
        is obsolete|                            |

--- Comment #15 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 75759
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75759&action=edit
Bug 19835: Update MARC frameworks to Updates 23+24+25 (Nov 2016, May and Dec
2017)

There are a bunch of updates, summary below

1) Update 23
1.a) Bibs
New fields: 647 885
New subfields
e in 752
0 in 257 377
3 in 382
4 in 752

Changes
028 redefined
a renamed in 028
b renamed in 046
d renamed in 046

1.b) Auth
New Fields: 075 147 447 547 677 747 885
New Subfields: 0 in 377

2) Update 24
2.a) Bibs
New subfields
b in 567
g in 340
i in 370 386
0 in many fields
2 in 567
3 in 370
4 in 370 386

Changes
g renamed in 370
4 'Relationship code' -> 'Relationship' many fields
4 'Relator code'      -> 'Relationship' many fields

2.b) Auth
New subfields
i in 370 386
0 in 050 052 053 055 060 065 070 080 087
3 in 370
4 in 370 386

Changes
g in 370
4 'Relationship code' -> 'Relationship' many fields
4 'Relator code'      -> 'Relationship' in 371

3) Update 25
3.a) Bibs
New fields: 758
New subfields
r in 777
u in 777
z in 777
1 in many fields

Changes
d renamed in 111 611 711 811
s repeatable in many fields

3.b) Auth
New subfields
1 in many fields

Changes
d in 111 411 511 711
s repeatable in many fields

For more detail:
Update 23
bibs https://www.loc.gov/marc/up23bibliographic/bdapndxg.html
auth https://www.loc.gov/marc/up23authority/adapndxf.html

Update 24
bibs https://www.loc.gov/marc/up24bibliographic/bdapndxg.html
auth https://www.loc.gov/marc/up24authority/adapndxf.html

Update 25
bibs https://www.loc.gov/marc/bibliographic/bdapndxg.html
auth https://www.loc.gov/marc/authority/adapndxf.html

To test:
1) Remove all your frameworks
2) Check mandatory bibliographic and authority files load without problem
3) Check new fields/subfields

Repeatability checks on followup

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 14:34:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 12:34:27 +0000
Subject: [Koha-bugs] [Bug 19835] Update MARC frameworks to Updates 23+24+25
 (Nov 2016, May and Dec 2017)
In-Reply-To: <bug-19835-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19835-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19835-70-EJaeZYOgwo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19835

--- Comment #16 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 75760
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75760&action=edit
Bug 19835: Fix repeatability on MARC21 subfields

This followup fixes all repeatability cases, from
updates 23+24+25 and a few older ones.

To test:
0) Apply both patches
1) Remove all your frameworks
2) Check mandatory bibliographic and authority files load without problem
3) Check repeatability...

Bibs and auth frameworks checked against LOC description.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 14:34:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 12:34:30 +0000
Subject: [Koha-bugs] [Bug 19835] Update MARC frameworks to Updates 23+24+25
 (Nov 2016, May and Dec 2017)
In-Reply-To: <bug-19835-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19835-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19835-70-QuM56XmRpa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19835

--- Comment #17 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 75761
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75761&action=edit
Bug 19835: Fix MARC21 frameworks revision date

This followup updates revison number and date

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 14:34:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 12:34:34 +0000
Subject: [Koha-bugs] [Bug 19835] Update MARC frameworks to Updates 23+24+25
 (Nov 2016, May and Dec 2017)
In-Reply-To: <bug-19835-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19835-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19835-70-bgLCX38MPj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19835

--- Comment #18 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 75762
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75762&action=edit
Bug 19835: (follow-up) Correct formatting in a few places

In some places - was used insted of --, changed for
consistency with existing descriptions.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 14:38:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 12:38:42 +0000
Subject: [Koha-bugs] [Bug 20710] Update MARC21 frameworks to Update 26
	(April 2018)
In-Reply-To: <bug-20710-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20710-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20710-70-SILvb56K87@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20710

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 14:41:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 12:41:29 +0000
Subject: [Koha-bugs] [Bug 20851] Missing module in
	circ/article-request-slip.pl
In-Reply-To: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20851-70-kxxelkUs4W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75719|0                           |1
        is obsolete|                            |

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 75764
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75764&action=edit
Bug 20851: Add module to circ/article-request-slip.pl

See bug 20468, comment7.
Although the script seems to compile well, we better add the module here.
Trivial change.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 14:42:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 12:42:09 +0000
Subject: [Koha-bugs] [Bug 20851] Missing module in
	circ/article-request-slip.pl
In-Reply-To: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20851-70-eightIUwOa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
This indeed fixes the error I was getting in my devbox.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 14:47:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 12:47:24 +0000
Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing
 personal data in account menu and self-registration
In-Reply-To: <bug-20819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20819-70-LcCENbYcgM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75765
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75765&action=edit
Bug 20819: Dbrev for new table patron_consent and sysprefs

[1] We add table patron_consent.
It allows for future extension. We could e.g. save consent for newsletter etc.
[2] Add one field to borrower_modifications
Datetime the patron who self-registered, gave consent.
[3] Syspref PrivacyPolicyURL
[4] Syspref GDPR_Policy: enforced, permissive or disabled.

Test plan:
[1] Run the dbrev or do a new install.
[2] Look at the description of the new prefs in Administration.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 14:47:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 12:47:28 +0000
Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing
 personal data in account menu and self-registration
In-Reply-To: <bug-20819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20819-70-kbEhI1Cnga@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75766
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75766&action=edit
Bug 20819: DBIx schema changes

No test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 14:47:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 12:47:32 +0000
Subject: [Koha-bugs] [Bug 20859] SMS and other notification preferences
 during self registration
In-Reply-To: <bug-20859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20859-70-jXwdqXlQ2W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|17.05                       |master
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 14:47:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 12:47:32 +0000
Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing
 personal data in account menu and self-registration
In-Reply-To: <bug-20819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20819-70-EsE7yFS12l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75767
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75767&action=edit
Bug 20819: Add Koha object classes for patron consents

Introduces Koha::Patron::Consent[s] for new table.
Adds basic CRUD test.

Test plan:
Run t/db_dependent/Koha/Patron/Consents.t

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 14:48:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 12:48:39 +0000
Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing
 personal data in account menu and self-registration
In-Reply-To: <bug-20819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20819-70-RV8DkrwXJj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |
             Status|NEW                         |ASSIGNED
   Patch complexity|---                         |Small patch

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
More patches forthcoming tomorrow or so.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 14:57:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 12:57:09 +0000
Subject: [Koha-bugs] [Bug 20710] Update MARC21 frameworks to Update 26
	(April 2018)
In-Reply-To: <bug-20710-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20710-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20710-70-mPefkxaK1n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20710

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75244|0                           |1
        is obsolete|                            |

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 75769
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75769&action=edit
Bug 20710: Update MARC21 frameworks to Update 26 (April 2018)

This bug add update 26 changes.

Update 26
http://www.loc.gov/marc/bibliographic/bdapndxg.html

New subfields 377$3, 380$3, 381$3, 383$3, 730$4

Codes
    Map 007/04 'x' new
    Map 007/06 'c' renamed

No auth changes

To test:
1) Apply Bug 19835
2) Apply this patch
3) Reload marc21 bibliografic frameworks, check loads ok
4) Clean your browser cache
5) Edit a new bib record, fire 007 plugin,
    for Map, 04 position, check new 'x'
    for Map, 06 position, check renamed 'c'

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 14:57:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 12:57:05 +0000
Subject: [Koha-bugs] [Bug 20710] Update MARC21 frameworks to Update 26
	(April 2018)
In-Reply-To: <bug-20710-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20710-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20710-70-JjFJMyHzfM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20710

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 15:41:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 13:41:43 +0000
Subject: [Koha-bugs] [Bug 20861] Correct EDI permissions on some pages
In-Reply-To: <bug-20861-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20861-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20861-70-y96BJBbMNN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20861

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75747|0                           |1
        is obsolete|                            |

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 75770
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75770&action=edit
Bug 20861: Correct EDI permissions on EDI messsages

The permission for EDI is edi_manage, but 2 pages asked
for manage_edi, allowing users not to access those.

To test:
- Add edi_manage to your permissions
- Try to access the EDIFACT messages from the
  acq start page
- Verify it doesn't work
- Apply patch and try again
- You should be able to access the page now
- Try to access the other page directly (if you don't
  have EDI data):
  /cgi-bin/koha/acqui/edimsg.pl
- Verify you can access the page and don't get a
  permission error

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 15:48:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 13:48:47 +0000
Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in
	bulkmarcimport.pl
In-Reply-To: <bug-20811-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20811-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20811-70-QKqiZPkEXq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com
             Status|Needs Signoff               |In Discussion

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
What about other places?
misc/batchRepairMissingBiblionumbers.pl
I believe that has a bad ModBiblio line too.
Changing to In Discussion, until we determine whether to fix in other bug, or
creep the scope to include all bad ModBiblio calls.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 15:55:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 13:55:14 +0000
Subject: [Koha-bugs] [Bug 20838] Search by group of libraries is broken
In-Reply-To: <bug-20838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20838-70-S7FaPVnMhk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
I am having issues testing this - when I enable
"OpacAddMastheadLibraryPulldown" I don't have a list of libraries and my group
doesn't show any values

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 15:55:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 13:55:36 +0000
Subject: [Koha-bugs] [Bug 20760] Advanced Cataloging Editor - Rancor -
 AuthorisedValues are incorrectly fetched
In-Reply-To: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20760-70-RrzPCC6A48@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20760

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 75291
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75291
Bug 20760: Correctly fetch authorised values for rancor

Review of attachment 75291:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20760&attachment=75291)
-----------------------------------------------------------------

::: svc/cataloguing/framework
@@ +53,4 @@
>  }
>  
>  my $branch_limit = C4::Context->userenv ? C4::Context->userenv->{"branch"} : "";
> +my $results = Koha::AuthorisedValues->search({ branchcode => $branch_limit },{ order_by => "lib" });

Will this behave the same if branch_limit is q{}? Perhaps an if to define the
passed hashref would be safer?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 15:56:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 13:56:08 +0000
Subject: [Koha-bugs] [Bug 20760] Advanced Cataloging Editor - Rancor -
 AuthorisedValues are incorrectly fetched
In-Reply-To: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20760-70-xZlJXDN0Hg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20760

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion
                 CC|                            |mtompset at hotmail.com

--- Comment #3 from M. Tompsett <mtompset at hotmail.com> ---
Putting to In Discussion until comment #2 is answered.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 15:57:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 13:57:22 +0000
Subject: [Koha-bugs] [Bug 20726] Display acquisition details on the
 subscription detail page
In-Reply-To: <bug-20726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20726-70-fU30hzoOCy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20726

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

--- Comment #25 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Jonathan Druart from comment #24)
> (In reply to S?verine Queune from comment #23)
> > Works as expected now :)
> > 
> > What do you think about the tooltip or something similar ?
> 
> Yes maybe, but I am not convinced. I would prefer to wait for another
> idea/opinion.

It could be tooltip, or a sentence above table saying something like "All
prices are shown as price without tax / price with tax"

I have not strong opinion on the form of this help/tip, but I think it should
be here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:01:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:01:07 +0000
Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in
	bulkmarcimport.pl
In-Reply-To: <bug-20811-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20811-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20811-70-Ndh2UNXzJX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
batchRepairMissingBiblionumbers.pl uses ModBiblioMarc, not ModBiblio.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:10:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:10:23 +0000
Subject: [Koha-bugs] [Bug 20838] Search by group of libraries is broken
In-Reply-To: <bug-20838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20838-70-3AQsNx5Dfy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Nick Clemens from comment #10)
> I am having issues testing this - when I enable
> "OpacAddMastheadLibraryPulldown" I don't have a list of libraries and my
> group doesn't show any values

Right, it's another bug. I am going to deal with it on a separate bug report.
To test this one you need to use the advanced search form.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:12:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:12:27 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-VMRjwHLoHM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20875


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875
[Bug 20875] OpacAddMastheadLibraryPulldown displays an empty list
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:12:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:12:27 +0000
Subject: [Koha-bugs] [Bug 20875] New: OpacAddMastheadLibraryPulldown
 displays an empty list
Message-ID: <bug-20875-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875

            Bug ID: 20875
           Summary: OpacAddMastheadLibraryPulldown displays an empty list
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: major
          Priority: P5 - low
         Component: OPAC
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 16735

Regression from
  commit 2059f7d8016ab61172830e9b670279d3e28882b7
  Bug 16735: Migrate library search groups into the new hierarchical groups

It re-added code that was removed by bug 15758 (use of var BranchesLoop).


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735
[Bug 16735] Replace existing library search groups functionality with the new
hierarchical groups system
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:12:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:12:40 +0000
Subject: [Koha-bugs] [Bug 20838] Search by group of libraries is broken
In-Reply-To: <bug-20838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20838-70-06dBaPEyu7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20875

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:12:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:12:40 +0000
Subject: [Koha-bugs] [Bug 20875] OpacAddMastheadLibraryPulldown displays an
	empty list
In-Reply-To: <bug-20875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20875-70-fgVhzaMmQH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20838

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:13:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:13:08 +0000
Subject: [Koha-bugs] [Bug 20875] OpacAddMastheadLibraryPulldown displays an
	empty list
In-Reply-To: <bug-20875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20875-70-oyLD2P7bFA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_18_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:14:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:14:14 +0000
Subject: [Koha-bugs] [Bug 20864] Only set bibs_selected cookie when
 BrowseResultSelection is activated
In-Reply-To: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20864-70-lie5CML7h5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:18:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:18:28 +0000
Subject: [Koha-bugs] [Bug 20864] Only set bibs_selected cookie when
 BrowseResultSelection is activated
In-Reply-To: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20864-70-I1iHo5qJXU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:18:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:18:31 +0000
Subject: [Koha-bugs] [Bug 20864] Only set bibs_selected cookie when
 BrowseResultSelection is activated
In-Reply-To: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20864-70-z4yCzkQ5dE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 75771
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75771&action=edit
Bug 20864: Only set bibs_selected cookie when BrowseResultSelection is
activated

This patch adds a system preference check around the call to the
JavaScript include which sets the bibs_selected cookie. With
BrowseResultsSelection disabled, the cookie should never be set.

To test you should be using a browser with a tool for inspecting
cookies. View the cookies for your Koha domain under each of these
conditions, clearing cookies between each step:

Without the patch applied:

 - With  BrowseResultSelection enabled, search for any item. Your cookie
   tool should report that you have a bibs_selected cookie stored.
 - With BrowseResultSelection disabled, search for any item. You should
   have a bibs_selected cookie.

With the patch applied:

 - With the BrowseResultSelection system preference enabled, search for
   any item. Your cookie tool should report that you have a
   bibs_selected cookie stored.
 - With BrowseResultSelection disabled, search for any item. You should
   have no bibs_selected cookie.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:20:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:20:02 +0000
Subject: [Koha-bugs] [Bug 20757] Capture a screenshot on selenium errors
In-Reply-To: <bug-20757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20757-70-i5XXqPBx7n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20757

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:20:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:20:05 +0000
Subject: [Koha-bugs] [Bug 20757] Capture a screenshot on selenium errors
In-Reply-To: <bug-20757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20757-70-EkJmPojOxB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20757

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75465|0                           |1
        is obsolete|                            |

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 75772
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75772&action=edit
Bug 20757: Capture and upload screenshot on selenium errors

It is a real pain to debug selenium errors, especially when it is
not reproducible locally.

This patch capture a screenshot when an error occurred and upload it
using the excellent lut.im service provided by framasoft
(We could host our own later).

Test plan:
Modify a selenium script to make it fails (search for find_element)
You will see a stack trace followed by a link to framapic.org

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:20:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:20:26 +0000
Subject: [Koha-bugs] [Bug 20757] Capture a screenshot on selenium errors
In-Reply-To: <bug-20757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20757-70-JOMLPUD9aJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20757

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:27:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:27:49 +0000
Subject: [Koha-bugs] [Bug 20876] New: The form_serialized_itype cookie is
 not used and shoudl be removed
Message-ID: <bug-20876-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20876

            Bug ID: 20876
           Summary: The form_serialized_itype cookie is not used and
                    shoudl be removed
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

The form_serialized_itype cookie is not used and should be removed. Item type
limits for advanced searches are stored in the  form_serialized_lmits cookie
instead.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:29:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:29:44 +0000
Subject: [Koha-bugs] [Bug 20875] OpacAddMastheadLibraryPulldown displays an
	empty list
In-Reply-To: <bug-20875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20875-70-QPearPvBjf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:29:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:29:47 +0000
Subject: [Koha-bugs] [Bug 20875] OpacAddMastheadLibraryPulldown displays an
	empty list
In-Reply-To: <bug-20875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20875-70-AyTJlyz4qt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75773
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75773&action=edit
Bug 20875: (bug 16735 follow-up) Fix library list for
OpacAddMastheadLibraryPulldown

This patch fixes a regression introduced by
  commit 2059f7d8016ab61172830e9b670279d3e28882b7
  Bug 16735: Migrate library search groups into the new hierarchical groups

It re-added code that was removed by bug 15758 (use of var BranchesLoop).

Test plan:
- Create library search groups
- Turn OpacAddMastheadLibraryPulldown on
- At the OPAC confirm that the search box with libraries and library
groups is displayed and works correctly.
- Remove the library search group
- The dropdown list should not have the optgroup tags

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:30:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:30:02 +0000
Subject: [Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection
	Regulation)
In-Reply-To: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18081-70-R7kp1owqlY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20876


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20876
[Bug 20876] The form_serialized_itype cookie is not used and shoudl be removed
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:30:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:30:03 +0000
Subject: [Koha-bugs] [Bug 20838] Search by group of libraries is broken
In-Reply-To: <bug-20838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20838-70-Mg4Dpq8Shy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20875


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875
[Bug 20875] OpacAddMastheadLibraryPulldown displays an empty list
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:30:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:30:02 +0000
Subject: [Koha-bugs] [Bug 20876] The form_serialized_itype cookie is not
 used and shoudl be removed
In-Reply-To: <bug-20876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20876-70-flsIr7bvm5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20876

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |18081


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081
[Bug 18081] [omnibus] GDPR (General Data Protection Regulation)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:30:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:30:03 +0000
Subject: [Koha-bugs] [Bug 20875] OpacAddMastheadLibraryPulldown displays an
	empty list
In-Reply-To: <bug-20875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20875-70-r4FgcOv6UY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20838


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838
[Bug 20838] Search by group of libraries is broken
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:33:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:33:52 +0000
Subject: [Koha-bugs] [Bug 20867] Ability to show membership renewal date on
 moremember.pl page.
In-Reply-To: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20867-70-AtPqL3nilV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:33:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:33:55 +0000
Subject: [Koha-bugs] [Bug 20867] Ability to show membership renewal date on
 moremember.pl page.
In-Reply-To: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20867-70-GXGwuHIre3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75752|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 75774
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75774&action=edit
Bug 20867: Ability to show membership renewal date on moremember.pl page

Test case:
1. Create the patron.
2. Search the patron whose date of membership is about to expire or expired.
3. Click on More->Renew patron.
4. Now membership is renewed.
4. Apply the patch.
5. Refersh the page now you will able to see the Membership renewal date.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:42:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:42:10 +0000
Subject: [Koha-bugs] [Bug 20876] The form_serialized_itype cookie is not
 used and should be removed
In-Reply-To: <bug-20876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20876-70-P4dZXQPzUA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20876

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
            Summary|The form_serialized_itype   |The form_serialized_itype
                   |cookie is not used and      |cookie is not used and
                   |shoudl be removed           |should be removed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:44:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:44:31 +0000
Subject: [Koha-bugs] [Bug 18973] Auto focus the ISBN field
In-Reply-To: <bug-18973-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18973-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18973-70-XC9RVW9fWu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18973

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:44:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:44:52 +0000
Subject: [Koha-bugs] [Bug 18973] Auto focus the ISBN field
In-Reply-To: <bug-18973-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18973-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18973-70-DWBJrnWKlS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18973

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:44:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:44:57 +0000
Subject: [Koha-bugs] [Bug 18973] Auto focus the ISBN field
In-Reply-To: <bug-18973-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18973-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18973-70-C0nCxZDEyT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18973

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67068|0                           |1
        is obsolete|                            |

--- Comment #6 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 75775
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75775&action=edit
Bug 18973: Auto focus the ISBN field on Z39.50 search form in cataloguing

Signed-off-by: George <george at nekls.org>
Signed-off-by: BWS Sandboxes <ByWaterSandboxes at gmail.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:46:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:46:22 +0000
Subject: [Koha-bugs] [Bug 20876] The form_serialized_itype cookie is not
 used and should be removed
In-Reply-To: <bug-20876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20876-70-jJgxNaq79v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20876

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:46:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:46:26 +0000
Subject: [Koha-bugs] [Bug 18973] Auto focus the ISBN field
In-Reply-To: <bug-18973-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18973-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18973-70-dDFAmoeUMI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18973

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |fv at spots.school
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:46:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:46:25 +0000
Subject: [Koha-bugs] [Bug 20876] The form_serialized_itype cookie is not
 used and should be removed
In-Reply-To: <bug-20876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20876-70-Mn5mbQSVKm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20876

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 75776
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75776&action=edit
Bug 20876: The form_serialized_itype cookie is not used and should be removed

This patch removes references to a form_serialized_itype cookie which
appears in the code as part of the process of storing information used
in the generation of the "Return to the last advanced search" link.

To test, apply the patch and perform an advanced search in the OPAC
using several search options including a limit by item type. From the
search results page, follow the "Return to the last advanced search"
link. The advanced search form should appear with all the search options
you submitted before.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:50:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:50:04 +0000
Subject: [Koha-bugs] [Bug 20863] Delete bib_list and intranet_bib_list
 cookies when cart is emptied out
In-Reply-To: <bug-20863-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20863-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20863-70-qyTfrprhui@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20863

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |18081


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081
[Bug 18081] [omnibus] GDPR (General Data Protection Regulation)
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:50:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:50:04 +0000
Subject: [Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection
	Regulation)
In-Reply-To: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18081-70-rmgrzCOEEU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20863


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20863
[Bug 20863] Delete bib_list and intranet_bib_list cookies when cart is emptied
out
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:54:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:54:05 +0000
Subject: [Koha-bugs] [Bug 20863] Delete bib_list and intranet_bib_list
 cookies when cart is emptied out
In-Reply-To: <bug-20863-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20863-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20863-70-Sp3XnvPeWN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20863

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
I don't find this to be true. The delCookie function in basket.js sets the
value of the bib_list cookie to null, sets the path to /, and the expiration to
"now minus one" to make it expired.

In my test (Firefox, Windows 10), the cookie is gone after I empty the cart in
both the OPAC and staff client.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:54:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:54:32 +0000
Subject: [Koha-bugs] [Bug 20841] Barcode and description are needed in
	payment details
In-Reply-To: <bug-20841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20841-70-2FaRdKGmGR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20841

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Depends on|                            |2696


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696
[Bug 2696] Fine payments should show what was paid for
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:54:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:54:32 +0000
Subject: [Koha-bugs] [Bug 2696] Fine payments should show what was paid for
In-Reply-To: <bug-2696-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2696-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2696-70-l8OInpaxLk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20841


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20841
[Bug 20841] Barcode and description are needed in payment details
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 16:58:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 14:58:48 +0000
Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to
	Koha::Reviews
In-Reply-To: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15839-70-zRQYEOGL2z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20858

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 17:01:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 15:01:01 +0000
Subject: [Koha-bugs] [Bug 20862] Error on cart when containing a deleted
	record
In-Reply-To: <bug-20862-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20862-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20862-70-6sKdMDDP3W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20862

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I do not recreate, did you test on master?
What is the exact error message?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 17:13:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 15:13:01 +0000
Subject: [Koha-bugs] [Bug 20778] Unable to delete a subscription
In-Reply-To: <bug-20778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20778-70-GMaUXEqNu7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|In Discussion               |ASSIGNED
         Depends on|                            |19777
           Assignee|alex.arnaud at biblibre.com    |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Caused by
  commit 666a1b276097785c2a7c33e718f26f5512b3d972
  Bug 19777: Move template JavaScript to the footer: Serials, part 3


TT var used in .js


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19777
[Bug 19777] Move template JavaScript to the footer: Serials, part 3
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 17:13:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 15:13:01 +0000
Subject: [Koha-bugs] [Bug 19777] Move template JavaScript to the footer:
	Serials, part 3
In-Reply-To: <bug-19777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19777-70-qxmSECdHgL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19777

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20778


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778
[Bug 20778] Unable to delete a subscription
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 17:16:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 15:16:06 +0000
Subject: [Koha-bugs] [Bug 20778] Unable to delete a subscription
In-Reply-To: <bug-20778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20778-70-odHSnfiXmy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 17:16:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 15:16:10 +0000
Subject: [Koha-bugs] [Bug 20778] Unable to delete a subscription
In-Reply-To: <bug-20778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20778-70-PZa72veCo4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75505|0                           |1
        is obsolete|                            |

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75777
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75777&action=edit
Bug 20778: (bug 19777 follow-up) Fix subscription deletion

Caused by
  commit 666a1b276097785c2a7c33e718f26f5512b3d972
  Bug 19777: Move template JavaScript to the footer: Serials, part 3

TT vars should not be used in .js files

Test plan:
Delete a subscription, confirm you see the confirmation popup and that
the it deletes the subscription correctly after it has been confirmed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 17:22:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 15:22:38 +0000
Subject: [Koha-bugs] [Bug 20778] Unable to delete a subscription
In-Reply-To: <bug-20778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20778-70-Z5WQYi1LZR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75777|0                           |1
        is obsolete|                            |

--- Comment #10 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 75778
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75778&action=edit
Bug 20778: (bug 19777 follow-up) Fix subscription deletion

Caused by
  commit 666a1b276097785c2a7c33e718f26f5512b3d972
  Bug 19777: Move template JavaScript to the footer: Serials, part 3

TT vars should not be used in .js files

Test plan:
Delete a subscription, confirm you see the confirmation popup and that
the it deletes the subscription correctly after it has been confirmed.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 17:22:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 15:22:34 +0000
Subject: [Koha-bugs] [Bug 20778] Unable to delete a subscription
In-Reply-To: <bug-20778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20778-70-DlHMCv3ja3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 17:30:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 15:30:32 +0000
Subject: [Koha-bugs] [Bug 20862] Error on cart when containing a deleted
	record
In-Reply-To: <bug-20862-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20862-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20862-70-IRVSdH45ms@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20862

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I will try to recreate it. It was a problem with Elasticsearch not updating
automatically I think and then the deleted record remained in search results
when I added them.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 17:31:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 15:31:55 +0000
Subject: [Koha-bugs] [Bug 20863] Delete bib_list and intranet_bib_list
 cookies when cart is emptied out
In-Reply-To: <bug-20863-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20863-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20863-70-SjkkQwWVqj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20863

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx Owen, I'll retest. I was using the firefox build in tools to keep an eye on
cookies being added and updated.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 17:55:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 15:55:46 +0000
Subject: [Koha-bugs] [Bug 20760] Advanced Cataloging Editor - Rancor -
 AuthorisedValues are incorrectly fetched
In-Reply-To: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20760-70-7E7uK9voZF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20760

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I think you should "just" call C4::Koha::GetAuthorisedValues, it deals with
library limitations, and results are cached.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 18:03:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 16:03:36 +0000
Subject: [Koha-bugs] [Bug 20760] Advanced Cataloging Editor - Rancor -
 AuthorisedValues are incorrectly fetched
In-Reply-To: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20760-70-a9PhCNnCIp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20760

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75779
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75779&action=edit
[ALTERNATIVE PATCH] Bug 20760: Fill authorised values in svc framework

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 18:03:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 16:03:59 +0000
Subject: [Koha-bugs] [Bug 20760] Advanced Cataloging Editor - Rancor -
 AuthorisedValues are incorrectly fetched
In-Reply-To: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20760-70-sImCtfbCTw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20760

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I still do not see the dropdown lists but I think it's the way to go.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 18:08:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 16:08:42 +0000
Subject: [Koha-bugs] [Bug 20779] Style refresh for patron detail page
In-Reply-To: <bug-20779-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20779-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20779-70-0dl8IyYTkQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75638|0                           |1
        is obsolete|                            |

--- Comment #12 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 75780
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75780&action=edit
More polished version of buttons in line with headings

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 18:19:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 16:19:08 +0000
Subject: [Koha-bugs] [Bug 20771] Incorrect wording on branch-specific notice
	setup
In-Reply-To: <bug-20771-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20771-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20771-70-V67fesVjib@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20771

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Resolution|---                         |MOVED

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I have reported it on the koha-manual bug tracker:
https://gitlab.com/koha-community/koha-manual/issues/11

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 18:32:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 16:32:10 +0000
Subject: [Koha-bugs] [Bug 20053] Drop type attribute "text/javascript" for
 <script> elements used in OPAC templates
In-Reply-To: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20053-70-xWlPx7jabn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 18:32:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 16:32:58 +0000
Subject: [Koha-bugs] [Bug 20861] Correct EDI permissions on some pages
In-Reply-To: <bug-20861-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20861-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20861-70-RHrJ9Ta7Jo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20861

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 18:33:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 16:33:18 +0000
Subject: [Koha-bugs] [Bug 20861] Correct EDI permissions on some pages
In-Reply-To: <bug-20861-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20861-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20861-70-xhPo4uTWHc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20861

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 18:32:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 16:32:13 +0000
Subject: [Koha-bugs] [Bug 20053] Drop type attribute "text/javascript" for
 <script> elements used in OPAC templates
In-Reply-To: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20053-70-2V8WdRz5f3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74946|0                           |1
        is obsolete|                            |

--- Comment #11 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Created attachment 75781
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75781&action=edit
Bug 20053: Drop type attribute "text/javascript" in OPAC templates

This patch is a reimplementation of the original from Indranil Das Gupta
and the QA follow-up from Julian Maurice. Original test plan:

Conformance rules for HTML5 is generating warnings for <script> element
with type="text/javascript" attribute when the OPAC page is checked
with W3C Validator. This patch removes the cause of these warnings.

Test plan
=========

1/ Paste the URL to your OPAC page (if it is hosted) to W3C Validator
   and watch about 10+ warnings being generated by the validator.

2/ Apply patch and re-submit the page to the Validator. The warnings
   would be gone.

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 18:33:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 16:33:02 +0000
Subject: [Koha-bugs] [Bug 20861] Correct EDI permissions on some pages
In-Reply-To: <bug-20861-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20861-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20861-70-1npGX4T30r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20861

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75770|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75782
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75782&action=edit
Bug 20861: Correct EDI permissions on EDI messsages

The permission for EDI is edi_manage, but 2 pages asked
for manage_edi, allowing users not to access those.

To test:
- Add edi_manage to your permissions
- Try to access the EDIFACT messages from the
  acq start page
- Verify it doesn't work
- Apply patch and try again
- You should be able to access the page now
- Try to access the other page directly (if you don't
  have EDI data):
  /cgi-bin/koha/acqui/edimsg.pl
- Verify you can access the page and don't get a
  permission error

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 18:33:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 16:33:40 +0000
Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality
In-Reply-To: <bug-7736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7736-70-wVqvUqlGsh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20861


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20861
[Bug 20861] Correct EDI permissions on some pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 18:33:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 16:33:40 +0000
Subject: [Koha-bugs] [Bug 20861] Correct EDI permissions on some pages
In-Reply-To: <bug-20861-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20861-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20861-70-haDkGZEta3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20861

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |7736


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736
[Bug 7736] Edifact QUOTE and ORDER functionality
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 18:51:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 16:51:54 +0000
Subject: [Koha-bugs] [Bug 20760] Advanced Cataloging Editor - Rancor -
 AuthorisedValues are incorrectly fetched
In-Reply-To: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20760-70-kdKhRxw3qq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20760

--- Comment #7 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 75779
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75779
[ALTERNATIVE PATCH] Bug 20760: Fill authorised values in svc framework

Review of attachment 75779:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20760&attachment=75779)
-----------------------------------------------------------------

::: svc/cataloguing/framework
@@ +53,5 @@
>  }
>  
> +my $avs = C4::Koha::GetAuthorisedValues();
> +for my $av ( @$avs ) {
> +    push @{ $authorised_values->{$av->{category}} }, { value => $av->{authorised_value}, lib => $av->{lib} };

The other version had order_by lib. This uses order by category first. Perhaps
add a sort?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 19:47:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 17:47:37 +0000
Subject: [Koha-bugs] [Bug 20053] Drop type attribute "text/javascript" for
 <script> elements used in OPAC templates
In-Reply-To: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20053-70-krRgs3tmFz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 19:47:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 17:47:41 +0000
Subject: [Koha-bugs] [Bug 20053] Drop type attribute "text/javascript" for
 <script> elements used in OPAC templates
In-Reply-To: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20053-70-pzBin1iEfs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75781|0                           |1
        is obsolete|                            |

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75783
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75783&action=edit
Bug 20053: Drop type attribute "text/javascript" in OPAC templates

This patch is a reimplementation of the original from Indranil Das Gupta
and the QA follow-up from Julian Maurice. Original test plan:

Conformance rules for HTML5 is generating warnings for <script> element
with type="text/javascript" attribute when the OPAC page is checked
with W3C Validator. This patch removes the cause of these warnings.

Test plan
=========

1/ Paste the URL to your OPAC page (if it is hosted) to W3C Validator
   and watch about 10+ warnings being generated by the validator.

2/ Apply patch and re-submit the page to the Validator. The warnings
   would be gone.

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 19:49:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 17:49:41 +0000
Subject: [Koha-bugs] [Bug 20763] AllowPurchaseSuggestionBranchChoice
 triggers error opac-suggestions.pl is visited without logging in
In-Reply-To: <bug-20763-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20763-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20763-70-YcHdxgt0Q8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20763

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to master for 18.11, awesome work everybody!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 19:49:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 17:49:17 +0000
Subject: [Koha-bugs] [Bug 17561] ReserveSlip needs itemnumber for item level
 holds on same biblio
In-Reply-To: <bug-17561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17561-70-rlgxoZHdM6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #29 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to master for 18.11, awesome work everybody!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 19:49:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 17:49:58 +0000
Subject: [Koha-bugs] [Bug 20831] (Bug 9573 follow-up) Pass id as first
 parameter instead of selector
In-Reply-To: <bug-20831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20831-70-BLCzDGaVfg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20831

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to master for 18.11, awesome work everybody!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 19:50:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 17:50:29 +0000
Subject: [Koha-bugs] [Bug 20840] Internal Server Error when clicking on
	"Details" button
In-Reply-To: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20840-70-2sHeltMSGP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to master for 18.11, awesome work everybody!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 19:50:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 17:50:14 +0000
Subject: [Koha-bugs] [Bug 20838] Search by group of libraries is broken
In-Reply-To: <bug-20838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20838-70-Rdg042vFl1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to master for 18.11, awesome work everybody!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 19:50:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 17:50:51 +0000
Subject: [Koha-bugs] [Bug 20861] Correct EDI permissions on some pages
In-Reply-To: <bug-20861-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20861-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20861-70-kRJkrRbBuN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20861

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to master for 18.11, awesome work everybody!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 19:51:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 17:51:05 +0000
Subject: [Koha-bugs] [Bug 3849] Descriptions of acquisition permissions are
	unclear
In-Reply-To: <bug-3849-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3849-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3849-70-fdQdMLabC4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3849

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #20 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to master for 18.11, awesome work everybody!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 20:23:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 18:23:34 +0000
Subject: [Koha-bugs] [Bug 20866] ArticleRequests.t fails on existing requests
In-Reply-To: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20866-70-F7PBBjN9bw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20866

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|m.de.rooy at rijksmuseum.nl    |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |ASSIGNED

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
There are some problems hidden your patch actually.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 20:32:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 18:32:41 +0000
Subject: [Koha-bugs] [Bug 20866] ArticleRequests.t fails on existing requests
In-Reply-To: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20866-70-NsLwULM2Tc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20866

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75784
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75784&action=edit
[ALTERNATIVE PATH] Bug 20866: Make ArticleRequests.t pass even if table is not
empty

Previous patch from Marcel removed the data from article_requests, I do
not think it is a good idea to remove existing data, it could hide bugs.

This patch moves the count inside the subtest block in order to have the
correct value when these tests are executed.
Previous code was broken: Koha::Patron->store does not generate a
userid, and ->search_limited did not work correctly
(Koha::Patron->has_permission returned early because of the non-existing
userid, 'return unless $self->userid;');

Test plan:
[1] Create an article request.
[2] Run t/db_dependent/ArticleRequests.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 20:32:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 18:32:45 +0000
Subject: [Koha-bugs] [Bug 20647] When ILL is enabled the hover effect on the
 ILL requests button is wrong.
In-Reply-To: <bug-20647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20647-70-f0PzIPFsAs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 20:32:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 18:32:48 +0000
Subject: [Koha-bugs] [Bug 20647] When ILL is enabled the hover effect on the
 ILL requests button is wrong.
In-Reply-To: <bug-20647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20647-70-k6UA9REkW6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 75785
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75785&action=edit
Bug 20647: (alternate) When ILL is enabled the hover effect on the ILL requests
button is wrong

This alternate patch adds a new icon to the sprite image which gives
icons to the link on the staff client home page. It modifies the CSS
positioning for all the links as the new image sprite is somewhat
different.

The SVG file from which the sprite image was generated is also updated,
and the about page has been updated to give credit to the creator of the
icon.

Unrelated change: The cataloging link is moved to the second column.
Although it's probably rare for all modules to be enabled and available,
this puts the same number of links in each column.

To test, apply the patch and clear your browser cache if necessary. With
interlibrary loan enabled, view the staff client home page and confirm
that all the module links look correct, including when you hover your
mouse over them.

Confirm that the about page lists the new icon under the "licenses" tab.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 20:33:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 18:33:01 +0000
Subject: [Koha-bugs] [Bug 20866] ArticleRequests.t fails on existing requests
In-Reply-To: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20866-70-90C2JzCwt3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20866

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 20:34:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 18:34:26 +0000
Subject: [Koha-bugs] [Bug 20647] When ILL is enabled the hover effect on the
 ILL requests button is wrong.
In-Reply-To: <bug-20647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20647-70-Bc80PMLkea@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 75786
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75786&action=edit
Screenshot showing updated staff client home page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 20:37:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 18:37:14 +0000
Subject: [Koha-bugs] [Bug 20712] ILL belongs to the circulation section
In-Reply-To: <bug-20712-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20712-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20712-70-Pbhj7iCW6K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20712

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
I think ILL belongs on the main page just as much as Course Reserves do, but I
don't know how much that is.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 20:44:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 18:44:44 +0000
Subject: [Koha-bugs] [Bug 20489] Prevent DB user login
In-Reply-To: <bug-20489-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20489-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20489-70-YuIxHPKJ1n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20877

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 20:54:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 18:54:27 +0000
Subject: [Koha-bugs] [Bug 20878] New: Feature request: Add authorized value
 category for borrower category types
Message-ID: <bug-20878-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20878

            Bug ID: 20878
           Summary: Feature request: Add authorized value category for
                    borrower category types
 Change sponsored?: ---
           Product: Koha
           Version: 17.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

The categories table contains the following vales of category_type:

+---------------+
| category_type |
+---------------+
| A             |
| X             |
| I             |
| S             |
| C             |
+---------------+

I suggest that the following entries be added under authorized values:

+-------------+------------------+-------------+-------------+
| category    | authorised_value | lib         | lib_opac    |
+-------------+------------------+-------------+-------------+
| PATRON_TYPE | A                | Adult       | Adult       |
| PATRON_TYPE | X                | Othter      | Othter      |
| PATRON_TYPE | I                | Institution | Institution |
| PATRON_TYPE | S                | Staff       | Staff       |
| PATRON_TYPE | C                | Child       | Child       |
+-------------+------------------+-------------+-------------+

... It's just a convenience.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 20:59:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 18:59:31 +0000
Subject: [Koha-bugs] [Bug 20878] Feature request: Add authorized value
 category for borrower category types
In-Reply-To: <bug-20878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20878-70-cbCxnh3pcj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20878

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Barton,

what is the use case? Those are hardcoded values you are not supposed to
change, wouldn't it be confusing? It's also a problem as it would 'undo'
translations. Right now those values are translatable where used.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 21:01:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 19:01:12 +0000
Subject: [Koha-bugs] [Bug 20862] Error on cart when containing a deleted
	record
In-Reply-To: <bug-20862-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20862-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20862-70-ZHAy4w3pfm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20862

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Long error, the record listed doesn't exist in my database anymore:

 problem with :392 : Field 942 must have at least one subfield at
/usr/share/perl5/MARC/File/XML.pm line 481.

<?xml version="1.0" encoding="UTF-8"?>
<record
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xsi:schemaLocation="http://www.loc.gov/MARC21/slim
http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd"
    xmlns="http://www.loc.gov/MARC21/slim">

  <leader>01023nam a2200301   4500</leader>
  <controlfield tag="001">DAW28259733</controlfield>
  <controlfield tag="008">140801s2011    enk           001 0 eng
|</controlfield>
  <datafield tag="020" ind1=" " ind2=" ">
    <subfield code="a">0198709463 (paperback) </subfield>
  </datafield>
  <datafield tag="020" ind1=" " ind2=" ">
    <subfield code="a">9780198709466 (paperback) </subfield>
  </datafield>
  <datafield tag="040" ind1=" " ind2=" ">
    <subfield code="d">DAWSON</subfield>
    <subfield code="e">rda</subfield>
  </datafield>
  <datafield tag="050" ind1="0" ind2="4">
    <subfield code="a">KD2079</subfield>
    <subfield code="b">.C66 2011</subfield>
  </datafield>
  <datafield tag="082" ind1="0" ind2="4">
    <subfield code="a">346.42066</subfield>
    <subfield code="2">23</subfield>
  </datafield>
  <datafield tag="245" ind1="0" ind2="0">
    <subfield code="a">Blackstone's statutes on company law 2014-2015
/</subfield>
    <subfield code="c">edited by Derek French.</subfield>
  </datafield>
  <datafield tag="250" ind1=" " ind2=" ">
    <subfield code="a">18 edition.</subfield>
  </datafield>
  <datafield tag="264" ind1=" " ind2="1">
    <subfield code="a">Oxford :</subfield>
    <subfield code="b">Oxford University Press,</subfield>
    <subfield code="c">2014.</subfield>
  </datafield>
  <datafield tag="300" ind1=" " ind2=" ">
    <subfield code="a">750 pages ;</subfield>
    <subfield code="c">25 cm.</subfield>
  </datafield>
  <datafield tag="336" ind1=" " ind2=" ">
    <subfield code="a">text</subfield>
    <subfield code="2">rdacontent</subfield>
  </datafield>
  <datafield tag="337" ind1=" " ind2=" ">
    <subfield code="a">unmediated</subfield>
    <subfield code="2">rdamedia</subfield>
  </datafield>
  <datafield tag="338" ind1=" " ind2=" ">
    <subfield code="a">volume</subfield>
    <subfield code="2">rdacarrier</subfield>
  </datafield>
  <datafield tag="490" ind1="1" ind2=" ">
    <subfield code="a">Blackstone's statutes series</subfield>
  </datafield>
  <datafield tag="500" ind1=" " ind2=" ">
    <subfield code="a">Includes index.</subfield>
  </datafield>
  <datafield tag="650" ind1=" " ind2="0">
    <subfield code="a">Corporation law</subfield>
    <subfield code="z">England.</subfield>
  </datafield>
  <datafield tag="650" ind1=" " ind2="0">
    <subfield code="a">Corporation law</subfield>
    <subfield code="z">Wales.</subfield>
  </datafield>
  <datafield tag="700" ind1="1" ind2=" ">
    <subfield code="a">French, Derek,</subfield>
    <subfield code="e">editor of compilation.</subfield>
  </datafield>
  <datafield tag="830" ind1=" " ind2="0">
    <subfield code="a">Blackstones statutes.</subfield>
  </datafield>
  <datafield tag="999" ind1=" " ind2=" ">
    <subfield code="c">392</subfield>
    <subfield code="d">392</subfield>
  </datafield>
  <datafield tag="942" ind1=" " ind2=" ">
  </datafield>
  <datafield tag="773" ind1="0" ind2=" ">
    <subfield code="0">69</subfield>
    <subfield code="9">150</subfield>
    <subfield code="a">Shetter, William Z.</subfield>
    <subfield code="b">8th ed.</subfield>
    <subfield code="d">London : Routledge, 2002.</subfield>
    <subfield code="o">39999000002850</subfield>
    <subfield code="t">Dutch :</subfield>
    <subfield code="w">(OSt)3555020</subfield>
    <subfield code="x"></subfield>
    <subfield code="z">0415235014 :</subfield>
  </datafield>
</record>
GetRecordValue called with undefined record at
/home/vagrant/kohaclone/basket/basket.pl line 69.
GetMarcNotes called on undefined record at
/home/vagrant/kohaclone/basket/basket.pl line 70.
GetMarcAuthors called on undefined record at
/home/vagrant/kohaclone/basket/basket.pl line 71.
GetMarcSubjects called on undefined record at
/home/vagrant/kohaclone/basket/basket.pl line 72.
GetMarcSeries called on undefined record at
/home/vagrant/kohaclone/basket/basket.pl line 73.
GetMarcUrls called on undefined record at
/home/vagrant/kohaclone/basket/basket.pl line 74.
Can't use an undefined value as an ARRAY reference at
/home/vagrant/kohaclone/basket/basket.pl line 78.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 21:13:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 19:13:03 +0000
Subject: [Koha-bugs] [Bug 18128] 'Go to page' option for search results in
	opac and staff
In-Reply-To: <bug-18128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18128-70-4f5oNhylWr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|oleonard at myacpl.org         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 21:13:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 19:13:09 +0000
Subject: [Koha-bugs] [Bug 18078] Updating buttons for z39.50 Authority search
In-Reply-To: <bug-18078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18078-70-80yAT4AHZg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|oleonard at myacpl.org         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 21:13:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 19:13:14 +0000
Subject: [Koha-bugs] [Bug 18041] Updating buttons in Batch Item Mod and
	Deletion
In-Reply-To: <bug-18041-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18041-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18041-70-iz6EgReLAf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18041

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|oleonard at myacpl.org         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 21:13:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 19:13:20 +0000
Subject: [Koha-bugs] [Bug 18043] Updating buttons for z39.50 cataloguing
	search
In-Reply-To: <bug-18043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18043-70-aQTH5Bcb4L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18043

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|oleonard at myacpl.org         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 21:13:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 19:13:52 +0000
Subject: [Koha-bugs] [Bug 20688] Add accesskeys for hold confirmation boxes
In-Reply-To: <bug-20688-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20688-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20688-70-qICmi4ClWW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20688

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
          Component|Circulation                 |Templates

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 21:17:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 19:17:02 +0000
Subject: [Koha-bugs] [Bug 20862] Error on cart when containing a deleted
	record
In-Reply-To: <bug-20862-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20862-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20862-70-0hIBu0A5yC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20862

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It looks like a malformed record was the cause, marking invalid. Thx for
helping me figure it out!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 21:20:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 19:20:59 +0000
Subject: [Koha-bugs] [Bug 7651] Add separate permission for managing
 currencies and exchange rates
In-Reply-To: <bug-7651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7651-70-JJ9VhTGqh3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 75788
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75788&action=edit
Bug 7651: (QA follow-up) Fix warning about undefined active currency

If no active currency is defined we show a warning. This fixes
the link shown below to check the correct permission.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 21:21:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 19:21:35 +0000
Subject: [Koha-bugs] [Bug 7651] Add separate permission for managing
 currencies and exchange rates
In-Reply-To: <bug-7651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7651-70-ICyWgunh17@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx for catching this, Joubu!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 21:25:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 19:25:28 +0000
Subject: [Koha-bugs] [Bug 20876] The form_serialized_itype cookie is not
 used and should be removed
In-Reply-To: <bug-20876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20876-70-ccxc0hqSLY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20876

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75776|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 75789
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75789&action=edit
Bug 20876: The form_serialized_itype cookie is not used and should be removed

This patch removes references to a form_serialized_itype cookie which
appears in the code as part of the process of storing information used
in the generation of the "Return to the last advanced search" link.

To test, apply the patch and perform an advanced search in the OPAC
using several search options including a limit by item type. From the
search results page, follow the "Return to the last advanced search"
link. The advanced search form should appear with all the search options
you submitted before.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 21:25:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 19:25:25 +0000
Subject: [Koha-bugs] [Bug 20876] The form_serialized_itype cookie is not
 used and should be removed
In-Reply-To: <bug-20876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20876-70-4o6MGMXTRS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20876

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 21:28:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 19:28:21 +0000
Subject: [Koha-bugs] [Bug 20875] OpacAddMastheadLibraryPulldown displays an
	empty list
In-Reply-To: <bug-20875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20875-70-mJfA4eXRCC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 21:28:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 19:28:24 +0000
Subject: [Koha-bugs] [Bug 20875] OpacAddMastheadLibraryPulldown displays an
	empty list
In-Reply-To: <bug-20875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20875-70-DbIaoKKltd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75773|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 75790
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75790&action=edit
Bug 20875: (bug 16735 follow-up) Fix library list for
OpacAddMastheadLibraryPulldown

This patch fixes a regression introduced by
  commit 2059f7d8016ab61172830e9b670279d3e28882b7
  Bug 16735: Migrate library search groups into the new hierarchical groups

It re-added code that was removed by bug 15758 (use of var BranchesLoop).

Test plan:
- Create library search groups
- Turn OpacAddMastheadLibraryPulldown on
- At the OPAC confirm that the search box with libraries and library
groups is displayed and works correctly.
- Remove the library search group
- The dropdown list should not have the optgroup tags

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 21:33:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 19:33:33 +0000
Subject: [Koha-bugs] [Bug 20866] ArticleRequests.t fails on existing requests
In-Reply-To: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20866-70-QMqLe2lipK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20866

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 21:33:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 19:33:36 +0000
Subject: [Koha-bugs] [Bug 20866] ArticleRequests.t fails on existing requests
In-Reply-To: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20866-70-yE0xJGBJk5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20866

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75750|0                           |1
        is obsolete|                            |
  Attachment #75784|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 75791
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75791&action=edit
Bug 20866: Make ArticleRequests.t pass even if table is not empty

Previous patch from Marcel removed the data from article_requests, I do
not think it is a good idea to remove existing data, it could hide bugs.

This patch moves the count inside the subtest block in order to have the
correct value when these tests are executed.
Previous code was broken: Koha::Patron->store does not generate a
userid, and ->search_limited did not work correctly
(Koha::Patron->has_permission returned early because of the non-existing
userid, 'return unless $self->userid;');

Test plan:
[1] Create an article request.
[2] Run t/db_dependent/ArticleRequests.t

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 21:48:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 19:48:40 +0000
Subject: [Koha-bugs] [Bug 20851] Missing module in
	circ/article-request-slip.pl
In-Reply-To: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20851-70-FhBNi9AUOP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 21:48:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 19:48:43 +0000
Subject: [Koha-bugs] [Bug 20851] Missing module in
	circ/article-request-slip.pl
In-Reply-To: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20851-70-DHQJGaHWLF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75764|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 75792
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75792&action=edit
Bug 20851: Add module to circ/article-request-slip.pl

See bug 20468, comment7.
Although the script seems to compile well, we better add the module here.
Trivial change.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 21:49:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 19:49:08 +0000
Subject: [Koha-bugs] [Bug 20863] Delete bib_list and intranet_bib_list
 cookies when cart is emptied out
In-Reply-To: <bug-20863-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20863-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20863-70-lYV3A1XuOb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20863

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
My cookies seem to be somehow messed up, will try again later.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 21:49:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 19:49:58 +0000
Subject: [Koha-bugs] [Bug 20760] Advanced Cataloging Editor - Rancor -
 AuthorisedValues are incorrectly fetched
In-Reply-To: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20760-70-qKalnnhZ3D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20760

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to M. Tompsett from comment #7)
> Comment on attachment 75779 [details] [review]
> [ALTERNATIVE PATCH] Bug 20760: Fill authorised values in svc framework
> 
> Review of attachment 75779 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: svc/cataloguing/framework
> @@ +53,5 @@
> >  }
> >  
> > +my $avs = C4::Koha::GetAuthorisedValues();
> > +for my $av ( @$avs ) {
> > +    push @{ $authorised_values->{$av->{category}} }, { value => $av->{authorised_value}, lib => $av->{lib} };
> 
> The other version had order_by lib. This uses order by category first.
> Perhaps add a sort?

I do not see the point, read again the 3 lines you are quoting ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 21:50:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 19:50:13 +0000
Subject: [Koha-bugs] [Bug 20851] Missing module in
	circ/article-request-slip.pl
In-Reply-To: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20851-70-EoPxgyfSRw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thanks, Owen, for the sign-off and retesting.
Article slips still work for me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 21:51:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 19:51:01 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-l09PmKaFJZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 21:51:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 19:51:25 +0000
Subject: [Koha-bugs] [Bug 20760] Advanced Cataloging Editor - Rancor -
 AuthorisedValues are incorrectly fetched
In-Reply-To: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20760-70-3yY5UPQhGN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20760

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to M. Tompsett from comment #7)
> Comment on attachment 75779 [details] [review]
> [ALTERNATIVE PATCH] Bug 20760: Fill authorised values in svc framework
> 
> Review of attachment 75779 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: svc/cataloguing/framework
> @@ +53,5 @@
> >  }
> >  
> > +my $avs = C4::Koha::GetAuthorisedValues();
> > +for my $av ( @$avs ) {
> > +    push @{ $authorised_values->{$av->{category}} }, { value => $av->{authorised_value}, lib => $av->{lib} };
> 
> The other version had order_by lib. This uses order by category first.
> Perhaps add a sort?

I do not think it is needed. We are pushing into @{$hash->{$category}}, and
template site we are using the keys of this hash separately. I will not help to
sort by category.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 21:52:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 19:52:38 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-H8WlvJPhsw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

--- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I had not time to test, but wondering if this will work with our various
dateformat settings? Adding Owen to take a look :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 22:05:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 20:05:02 +0000
Subject: [Koha-bugs] [Bug 20778] Unable to delete a subscription
In-Reply-To: <bug-20778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20778-70-J1jsI07rnC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75778|0                           |1
        is obsolete|                            |

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 75793
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75793&action=edit
Bug 20778: (bug 19777 follow-up) Fix subscription deletion

Caused by
  commit 666a1b276097785c2a7c33e718f26f5512b3d972
  Bug 19777: Move template JavaScript to the footer: Serials, part 3

TT vars should not be used in .js files

Test plan:
Delete a subscription, confirm you see the confirmation popup and that
the it deletes the subscription correctly after it has been confirmed.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 22:04:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 20:04:59 +0000
Subject: [Koha-bugs] [Bug 20778] Unable to delete a subscription
In-Reply-To: <bug-20778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20778-70-iP0zlsTZug@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 22:06:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 20:06:32 +0000
Subject: [Koha-bugs] [Bug 20879] New: Shibboleth matchpoint no longer works
 after upgrade to 17.11
Message-ID: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

            Bug ID: 20879
           Summary: Shibboleth matchpoint no longer works after upgrade to
                    17.11
 Change sponsored?: ---
           Product: Koha
           Version: 17.11
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cking at uttyler.edu
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

Shibboleth authentication was working on 16.05.17, but after upgrading to
17.11.06, the OPAC returns the "Sorry, your Shibboleth identity does not match
a valid library identity.  If you have a local login..."

koha-conf:
<useshibboleth>1</useshibboleth>
 <shibboleth>
   <matchpoint>cardnumber</matchpoint>
   <mapping>
      <cardnumber is="employeeNumber"></cardnumber>
   </mapping>
 </shibboleth>


Relevant attribute from /Shibboleth.sso/Session output:
Attributes
employeeNumber: 5000120216


MySQL output:
mysql> select cardnumber,borrowernumber from borrowers where
cardnumber='5000120216';
+------------+----------------+
| cardnumber | borrowernumber |
+------------+----------------+
| 5000120216 |          12046 |
+------------+----------------+
1 row in set (0.00 sec)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 22:06:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 20:06:08 +0000
Subject: [Koha-bugs] [Bug 20867] Ability to show membership renewal date on
 moremember.pl page
In-Reply-To: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20867-70-EN3hRtFKaS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Ability to show membership  |Ability to show membership
                   |renewal date on             |renewal date on
                   |moremember.pl page.         |moremember.pl page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 23:28:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 21:28:22 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth matchpoint no longer works after
 upgrade to 17.11
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-qi9GUAu6wj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

cking at uttyler.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P1 - high

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun  4 23:32:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 21:32:26 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth matchpoint no longer works after
 upgrade to 17.11
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-TBImxaV3ro@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 00:02:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 22:02:51 +0000
Subject: [Koha-bugs] [Bug 20880] New: Upgraded 17.11 to 18.05: Malformed
 Bootstrap Theme Filenames
Message-ID: <bug-20880-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20880

            Bug ID: 20880
           Summary: Upgraded 17.11 to 18.05: Malformed Bootstrap Theme
                    Filenames
 Change sponsored?: ---
           Product: Koha
           Version: 18.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: rcmcdonald91 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

My 18.05 (from 17.11) OPAC is trying to download files like this:

'https://library.mydomain.com/opac-tmpl/bootstrap/lib/modernizr.min_18.0500000.js'

These files do not exist.

it should be:

'https://library.graa.com/opac-tmpl/bootstrap/lib/modernizr.min.js'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 00:14:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 22:14:01 +0000
Subject: [Koha-bugs] [Bug 20878] Feature request: Add authorized value
 category for borrower category types
In-Reply-To: <bug-20878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20878-70-W5ZDjjVMW6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20878

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

--- Comment #2 from Barton Chittenden <barton at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #1)
> Hi Barton,
> 
> what is the use case? Those are hardcoded values you are not supposed to
> change, wouldn't it be confusing? It's also a problem as it would 'undo'
> translations. Right now those values are translatable where used.

Katrin,

I don't have too much of a use-case for this -- occasionally, I'll write
reports that make use of category_type, but even then, I'm probably only using
one of them (querying for adult patrons, or staff or children).

I guess it would be handy to have them in a drop down, a-la

SELECT count(*), s.ccode
FROM
   statistics s
   INNER JOIN borrowers p using (borrowernumber)
   INNER JOIN categories c using (categorycode)
WHERE
   s.type in ( 'issue', 'renew' )
   AND c.category_type = <<Patron Type|PATRON_TYPE>>
GROUP BY ccode

More than anything, I find having one-character values scattered throughout the
source code to be very confusing.

The authorised_values table acts as a controlled vocabulary for Koha... from a
support perspective, we get a lot of questions of the form "What does WRDL
stand for?", "I see 'F', 'FU' and 'PAY' among my fines, is that defined
anywhere?". Those are questions that tend to linger unanswered on mailing lists
because the people who know are busy and the people who don't haven't the first
clue as to where to look. Having these in the authorised_values gives a good,
consistent place for users to look for mysterious codes found in the database.

I'm going to go ahead and close this as invalid; I hadn't taken the aspect of
translations into account... but maybe we should consider making the codes that
we use internally to Koha more human readable?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 00:16:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 22:16:37 +0000
Subject: [Koha-bugs] [Bug 20880] Upgraded 17.11 to 18.05: Malformed
 Bootstrap Theme Filenames
In-Reply-To: <bug-20880-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20880-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20880-70-CyGyIhIlF3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20880

--- Comment #1 from Christian McDonald <rcmcdonald91 at gmail.com> ---
https://library.mydomain.com/opac-tmpl/bootstrap/lib/modernizr.min.js

So much for obfuscation lol

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 01:33:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jun 2018 23:33:23 +0000
Subject: [Koha-bugs] [Bug 20880] Upgraded 17.11 to 18.05: Malformed
 Bootstrap Theme Filenames
In-Reply-To: <bug-20880-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20880-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20880-70-NxxsdANzps@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20880

--- Comment #2 from Christian McDonald <rcmcdonald91 at gmail.com> ---
For some reason, my 'apache-shared-opac.conf' was missing the following lines:

RewriteRule ^(.*)_[0-9][0-9]\.[0-9][0-9][0-9][0-9][0-9][0-9][0-9].js$ $1.js [L]
RewriteRule ^(.*)_[0-9][0-9]\.[0-9][0-9][0-9][0-9][0-9][0-9][0-9].css$ $1.css
[L]

Adding them fixed this problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 07:24:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 05:24:21 +0000
Subject: [Koha-bugs] [Bug 20880] Upgraded 17.11 to 18.05: Malformed
 Bootstrap Theme Filenames
In-Reply-To: <bug-20880-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20880-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20880-70-YT14w5k77t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20880

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID
                 CC|                            |katrin.fischer at bsz-bw.de
         Depends on|                            |12904

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Christian, this is not bug, but a feature. It removes the need to clean your
cache after updating, that when forgotten could lead to a lot of strange
issues.

See here: bug 12904

And from the release notes:

For non-package installations, the following rewrite rules will need to be
added to the apache config file:
RewriteRule ^(.)[0-9][0-9].[0-9][0-9][0-9][0-9][0-9][0-9][0-9].js$ $1.js [L]
RewriteRule ^(.)[0-9][0-9].[0-9][0-9][0-9][0-9][0-9][0-9][0-9].css$ $1.css [L]


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904
[Bug 12904] Force browser to load new JavaScript and CSS files after upgrade
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 07:24:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 05:24:21 +0000
Subject: [Koha-bugs] [Bug 12904] Force browser to load new JavaScript and
 CSS files after upgrade
In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12904-70-K7idwDxoqa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20880


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20880
[Bug 20880] Upgraded 17.11 to 18.05: Malformed Bootstrap Theme Filenames
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 07:33:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 05:33:08 +0000
Subject: [Koha-bugs] [Bug 20779] Style refresh for patron detail page
In-Reply-To: <bug-20779-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20779-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20779-70-xfRHB0xHEj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779

--- Comment #13 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Owen Leonard from comment #12)
> Created attachment 75780 [details]
> More polished version of buttons in line with headings

That looks great!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 07:33:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 05:33:38 +0000
Subject: [Koha-bugs] [Bug 20878] Feature request: Add authorized value
 category for borrower category types
In-Reply-To: <bug-20878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20878-70-HxIMn47y5g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20878

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Maybe we should add more info to the manual about those as a first step? There
is some information on the 'new report' help page, but that's hard to find.

I added a task on Taiga: 
https://tree.taiga.io/project/ldjamison-kohadocs-1805/task/559

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 09:27:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 07:27:34 +0000
Subject: [Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons
In-Reply-To: <bug-18799-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18799-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18799-70-dx8CCtKQH7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #31 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 09:49:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 07:49:33 +0000
Subject: [Koha-bugs] [Bug 20343] Show number of checkouts by itemtype in
	circulation.pl
In-Reply-To: <bug-20343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20343-70-DlBO02zJK9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20343

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #17 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.07.

Small and nice enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 10:12:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 08:12:43 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth matchpoint no longer works after
 upgrade to 17.11
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-AAXDd3i59X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 10:13:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 08:13:10 +0000
Subject: [Koha-bugs] [Bug 19610] Make koha-common.logrotate use copytruncate
In-Reply-To: <bug-19610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19610-70-p8gc9kphlb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19610

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 11:36:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 09:36:40 +0000
Subject: [Koha-bugs] [Bug 20825] Cannot checkout if item types at biblio
	level
In-Reply-To: <bug-20825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20825-70-46iAZ06Fci@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x, will be in 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 11:37:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 09:37:58 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-sVYay65amH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Signed Off                  |Patch doesn't apply

--- Comment #48 from Julian Maurice <julian.maurice at biblibre.com> ---
Sorry David, but the patch does not apply on master. Small conflict on
mappings.yaml. Could you rebase it ?
Also, could you provide a test plan ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 11:41:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 09:41:19 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-4xA2NUJ5zw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 11:48:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 09:48:16 +0000
Subject: [Koha-bugs] [Bug 20822] Can't find HOLD_SLIP template when printing
In-Reply-To: <bug-20822-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20822-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20822-70-D7lsRsdAV6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20822

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x, will be in 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 12:01:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 10:01:49 +0000
Subject: [Koha-bugs] [Bug 20652] Sort after item type search fails
In-Reply-To: <bug-20652-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20652-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20652-70-04xIOENQbB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20652

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x, will be in 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 12:06:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 10:06:22 +0000
Subject: [Koha-bugs] [Bug 20827] Can't add owner to a fund
In-Reply-To: <bug-20827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20827-70-T6BfRs4kLh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20827

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x and will be in 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 12:08:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 10:08:34 +0000
Subject: [Koha-bugs] [Bug 20791] Correct capitalization on 'Notices and
	slips' page
In-Reply-To: <bug-20791-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20791-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20791-70-GBl2xhBdhG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20791

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x and will be in 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 12:13:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 10:13:30 +0000
Subject: [Koha-bugs] [Bug 20752] Files tab in patron account is not properly
	capitalized
In-Reply-To: <bug-20752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20752-70-bjusJzxKu1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20752

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x and will be in 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 12:15:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 10:15:45 +0000
Subject: [Koha-bugs] [Bug 20774] Trivial HTML error in itemslost.tt
In-Reply-To: <bug-20774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20774-70-HdDHnQyQ67@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x and will be in 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 12:18:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 10:18:14 +0000
Subject: [Koha-bugs] [Bug 3886] Can't print receipt w/out allowing "Add or
 modify borrowers" permission
In-Reply-To: <bug-3886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3886-70-4IHpbFjkN2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3886

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x and will be in 18.05.01

Nice one killing off this old bug team :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 12:23:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 10:23:20 +0000
Subject: [Koha-bugs] [Bug 20797] If an Ill request has an associated bib
 record, the detail view should contain a link to the record
In-Reply-To: <bug-20797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20797-70-B1rENVZBkI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797

--- Comment #12 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Hi Jonathan

Further to your comment:

If "Biblio ID" is not filled, the column contains "0" with a link to
/catalogue/detail.pl?biblionumber=0

I've done some digging. It appears that, for some reason, the API response
contains a biblio_id of 0, even though the value in the database is NULL.

I've checked and there's definitely no casting of this value to an integer in
my code so I'm wondering if it's happening at a lower level. The schema
definition for the column defines it as an integer, but it's also nullable.

I'm not sure what to do about this. I can obviously work around it in the
template, but that would just be masking the problem. Any ideas?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 12:25:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 10:25:24 +0000
Subject: [Koha-bugs] [Bug 20767] "The method is not covered by tests!"
 should give more information
In-Reply-To: <bug-20767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20767-70-PGI97zrxYK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x and will be in 18.05.01

Go forth and debug all the things :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 12:32:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 10:32:09 +0000
Subject: [Koha-bugs] [Bug 20797] If an Ill request has an associated bib
 record, the detail view should contain a link to the record
In-Reply-To: <bug-20797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20797-70-Okp0LNGqBE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797

--- Comment #13 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Further to this, I think this is the problem:

https://github.com/PTFS-Europe/koha/blob/master/Koha/Object.pm#L249

If it's a numeric column, the value is being cast into an integer regardless of
whether it's populated or not.

Do you agree this is the bug?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 12:39:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 10:39:36 +0000
Subject: [Koha-bugs] [Bug 20781] 0 months is not a valid enrollment period
 and causes errors
In-Reply-To: <bug-20781-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20781-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20781-70-YeTjVFu2aY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x and will be in 18.05.01

Also skipped the second patch here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 12:41:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 10:41:23 +0000
Subject: [Koha-bugs] [Bug 20818] Missing QA manager entry in 18.05 release
	notes
In-Reply-To: <bug-20818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20818-70-Xjud9AsOce@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20818

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x and will be in 18.05.01

Credit where credit is due :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 12:43:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 10:43:30 +0000
Subject: [Koha-bugs] [Bug 20881] New: Order receiving: Price filter missing
	on_editing
Message-ID: <bug-20881-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20881

            Bug ID: 20881
           Summary: Order receiving: Price filter missing on_editing
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: pasi.kallinen at joensuu.fi
        QA Contact: testopia at bugs.koha-community.org

When the Price-filter is used on editable data, it should have the on_editing
-tag. Add it to the orderreceive.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 12:43:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 10:43:42 +0000
Subject: [Koha-bugs] [Bug 20696] Remove a few ugly "eq undef" comparisons
In-Reply-To: <bug-20696-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20696-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20696-70-r7o1lAECER@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20696

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x and will be in 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 12:43:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 10:43:43 +0000
Subject: [Koha-bugs] [Bug 20881] Order receiving: Price filter missing
	on_editing
In-Reply-To: <bug-20881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20881-70-kTGT9ORSZL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20881

paxed <pasi.kallinen at joensuu.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|oleonard at myacpl.org         |pasi.kallinen at joensuu.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 12:45:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 10:45:36 +0000
Subject: [Koha-bugs] [Bug 20881] Order receiving: Price filter missing
	on_editing
In-Reply-To: <bug-20881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20881-70-u62TnEoUQL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20881

--- Comment #1 from paxed <pasi.kallinen at joensuu.fi> ---
Created attachment 75809
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75809&action=edit
Bug 20881: Order receiving: Price filter missing on_editing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 12:45:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 10:45:44 +0000
Subject: [Koha-bugs] [Bug 20881] Order receiving: Price filter missing
	on_editing
In-Reply-To: <bug-20881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20881-70-DZJ5QLr6nD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20881

paxed <pasi.kallinen at joensuu.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 12:47:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 10:47:32 +0000
Subject: [Koha-bugs] [Bug 20761] Advanced Cataloging Editor - Rancor - Some
 js files are not fetched using Asset
In-Reply-To: <bug-20761-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20761-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20761-70-ZLroyxTiwe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20761

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x and will be in 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 12:52:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 10:52:30 +0000
Subject: [Koha-bugs] [Bug 20882] New: URI column in the items table is
 limited to 255 characters
Message-ID: <bug-20882-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20882

            Bug ID: 20882
           Summary: URI column in the items table is limited to 255
                    characters
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

This should be 'text' to match the URL colum in biblioitems

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 12:53:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 10:53:40 +0000
Subject: [Koha-bugs] [Bug 20798] Client side validation for for fund
 selection prevents adding only some records to a basket
In-Reply-To: <bug-20798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20798-70-ERMbAGXdNq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20798

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x and will be in 18.05.01

I also look forward to the followup on bug 20830

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 12:57:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 10:57:18 +0000
Subject: [Koha-bugs] [Bug 20840] Internal Server Error when clicking on
	"Details" button
In-Reply-To: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20840-70-8GMOQQG4NL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x and will be in 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 13:02:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 11:02:31 +0000
Subject: [Koha-bugs] [Bug 20763] AllowPurchaseSuggestionBranchChoice
 triggers error opac-suggestions.pl is visited without logging in
In-Reply-To: <bug-20763-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20763-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20763-70-Am2LpV1glo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20763

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x and will be in 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 13:06:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 11:06:56 +0000
Subject: [Koha-bugs] [Bug 20831] (Bug 9573 follow-up) Pass id as first
 parameter instead of selector
In-Reply-To: <bug-20831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20831-70-xzZwOgQ37K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20831

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x and will be in 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 13:17:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 11:17:46 +0000
Subject: [Koha-bugs] [Bug 3849] Descriptions of acquisition permissions are
	unclear
In-Reply-To: <bug-3849-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3849-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3849-70-78OaCpfF8a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3849

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         Resolution|---                         |FIXED

--- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Not pushing to 18.05.x as it could surprise unsuspecting librarians during a
minor update. Nice fix for 18.11 though, marking resolved.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 13:17:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 11:17:47 +0000
Subject: [Koha-bugs] [Bug 7651] Add separate permission for managing
 currencies and exchange rates
In-Reply-To: <bug-7651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7651-70-Pas4y75n4O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651
Bug 7651 depends on bug 3849, which changed state.

Bug 3849 Summary: Descriptions of acquisition permissions are unclear
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3849

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 13:19:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 11:19:39 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-uXtdbg4k0e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #73 from Josef Moravec <josef.moravec at gmail.com> ---
I went through another round of testing. Looking good now, just one (hopefully
last) issue: 
When the subscription is based on week, you can check irregularities for all
pregenerated issues - but it works only when you check weeks from first year.

Probably there should be just week numbers from 1 to 52, which could be enough.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 13:21:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 11:21:07 +0000
Subject: [Koha-bugs] [Bug 20581] Allow manual selection of custom ILL
	request statuses
In-Reply-To: <bug-20581-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20581-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20581-70-yQFrgAAHHc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

--- Comment #15 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 75810
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75810&action=edit
Bug 20581: (follow-up) Display status name

Rather than display the status code for custom statuses, we should be
displaying the name

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 13:24:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 11:24:14 +0000
Subject: [Koha-bugs] [Bug 20838] Search by group of libraries is broken
In-Reply-To: <bug-20838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20838-70-mR0mHpw4Uf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x and will be in 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 13:26:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 11:26:26 +0000
Subject: [Koha-bugs] [Bug 20861] Correct EDI permissions on some pages
In-Reply-To: <bug-20861-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20861-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20861-70-UyfLJg2nHB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20861

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x and will be in 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 13:28:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 11:28:09 +0000
Subject: [Koha-bugs] [Bug 20851] Missing module in
	circ/article-request-slip.pl
In-Reply-To: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20851-70-E3TU6IWNiy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #10)
> Thanks, Owen, for the sign-off and retesting.
> Article slips still work for me.

Thx Katrin for QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 13:42:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 11:42:12 +0000
Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields
	function
In-Reply-To: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12159-70-zNNNT8Gaoy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 13:42:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 11:42:15 +0000
Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields
	function
In-Reply-To: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12159-70-FuCtcLnclf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74791|0                           |1
        is obsolete|                            |
  Attachment #74792|0                           |1
        is obsolete|                            |

--- Comment #15 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 75811
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75811&action=edit
Bug 12159: Fix getting extended patron attributes for circ-menu

Changes:
- Replace getting preference ExtendedPatronAttributes by Koha.Preference
in templates
- Add Koha::Patron->attributes for getting patrons extended attributes
- Use this method in circ-menu.inc
- Remove getting attributes from members perl scripts

Test plan:
0) Apply the patch
1) Add some patron attributes type - with free text, authorised value,
    limited by libraries...
2) Add some values to this attributes for some patrons
3) Go through as many patron pages as you can and confirm that
attributes are shown at side panel when they shoul and are not shown
when they should not be shown

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 13:42:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 11:42:27 +0000
Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields
	function
In-Reply-To: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12159-70-q7KpBos3CN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #16 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 75812
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75812&action=edit
Bug 12159: Add tests

Test plan:
prove t/db_dependent/Koha/Patron/Attributes.t t/db_dependent/Koha/Patrons.t

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 13:49:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 11:49:10 +0000
Subject: [Koha-bugs] [Bug 17561] ReserveSlip needs itemnumber for item level
 holds on same biblio
In-Reply-To: <bug-17561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17561-70-mBVQRACNC9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #30 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x and will be in 18.05.01

Nice to see this bug squashed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 13:49:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 11:49:46 +0000
Subject: [Koha-bugs] [Bug 20866] ArticleRequests.t fails on existing requests
In-Reply-To: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20866-70-wDFG8N762I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20866

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 13:49:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 11:49:48 +0000
Subject: [Koha-bugs] [Bug 20866] ArticleRequests.t fails on existing requests
In-Reply-To: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20866-70-7BukhKfyVz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20866

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75791|0                           |1
        is obsolete|                            |

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75813
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75813&action=edit
Bug 20866: Make ArticleRequests.t pass even if table is not empty

Previous patch from Marcel removed the data from article_requests, I do
not think it is a good idea to remove existing data, it could hide bugs.

This patch moves the count inside the subtest block in order to have the
correct value when these tests are executed.
Previous code was broken: Koha::Patron->store does not generate a
userid, and ->search_limited did not work correctly
(Koha::Patron->has_permission returned early because of the non-existing
userid, 'return unless $self->userid;');

Test plan:
[1] Create an article request.
[2] Run t/db_dependent/ArticleRequests.t

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 13:49:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 11:49:55 +0000
Subject: [Koha-bugs] [Bug 20866] ArticleRequests.t fails on existing requests
In-Reply-To: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20866-70-rfiJCPADzZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20866

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75814
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75814&action=edit
Bug 20866: (QA follow-up) Use build_object and remove two tests

The unique constraint on userid is handled in TestBuilder. So let's use it.
The two tests if count==$count do not make much sense anymore when we
call ->count a few lines before. The check with search_limited is enough.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 13:50:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 11:50:20 +0000
Subject: [Koha-bugs] [Bug 20866] ArticleRequests.t fails on existing requests
In-Reply-To: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20866-70-jFkVe9BAQX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20866

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 13:53:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 11:53:07 +0000
Subject: [Koha-bugs] [Bug 20876] The form_serialized_itype cookie is not
 used and should be removed
In-Reply-To: <bug-20876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20876-70-xzZufbnJjr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20876

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 13:53:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 11:53:10 +0000
Subject: [Koha-bugs] [Bug 20876] The form_serialized_itype cookie is not
 used and should be removed
In-Reply-To: <bug-20876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20876-70-w41hB7vBNK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20876

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75789|0                           |1
        is obsolete|                            |

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75815
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75815&action=edit
Bug 20876: The form_serialized_itype cookie is not used and should be removed

This patch removes references to a form_serialized_itype cookie which
appears in the code as part of the process of storing information used
in the generation of the "Return to the last advanced search" link.

To test, apply the patch and perform an advanced search in the OPAC
using several search options including a limit by item type. From the
search results page, follow the "Return to the last advanced search"
link. The advanced search form should appear with all the search options
you submitted before.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 13:53:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 11:53:18 +0000
Subject: [Koha-bugs] [Bug 19502] Result sets limited to 10000
In-Reply-To: <bug-19502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19502-70-W7H3ehFxu5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |julian.maurice at biblibre.com
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 13:53:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 11:53:22 +0000
Subject: [Koha-bugs] [Bug 20876] The form_serialized_itype cookie is not
 used and should be removed
In-Reply-To: <bug-20876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20876-70-cqE4KErLV4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20876

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 14:16:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 12:16:19 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth matchpoint no longer works after
 upgrade to 17.11
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-QWv9FzQoR7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm currently unable to replicate this.. could you let me know if you're using
Plack or not to help narrow it down a bit.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 14:17:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 12:17:38 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth matchpoint no longer works after
 upgrade to 17.11
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-BOwBalID9q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
It may also be worth enabling debugging (SetEnv DEBUG=1) and see what pops out
in the logs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 14:58:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 12:58:46 +0000
Subject: [Koha-bugs] [Bug 20059] Option to allow checkin of non-issued items
 without setting SIP-alert
In-Reply-To: <bug-20059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20059-70-jJg729HO0F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20059

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #2 from Magnus Enger <magnus at libriotech.no> ---
Could you provide a test-plan and set the status to "Needs signoff", please?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 15:10:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 13:10:37 +0000
Subject: [Koha-bugs] [Bug 19502] Result sets limited to 10000
In-Reply-To: <bug-19502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19502-70-iQytCfyFFT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
I think we can do better than hardcoding the ES default value for
max_result_window. We can retrieve the actual setting from ES, so that anyone
can adjust this setting depending on their needs. I'm currently preparing a
patch that will do that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 15:16:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 13:16:45 +0000
Subject: [Koha-bugs] [Bug 19502] Result sets limited to 10000
In-Reply-To: <bug-19502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19502-70-0CyQidhA0i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 75816
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75816&action=edit
Bug 19502: Retrieve index.max_result_window from ES

This avoid hardcoding '10000' in two different places and allow users to
adjust this setting.

Also, this patch fixes a bug when the search return less than 10000
results

Test plan:
1. Do a search that returns 10000+ records.
2. Note the warning above the pagination buttons
3. Go to the last page, no error
4. Change the ES setting:
   curl -XPUT http://elasticsearch/koha_master_biblios/_settings -d \
     '{"index": {"max_result_window": 20000}}'
5. Do another search that returns more than 10000 but less than 20000
6. Note that the warning does not show up
7. Go to the last page, still no error

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 15:18:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 13:18:12 +0000
Subject: [Koha-bugs] [Bug 19502] Result sets limited to 10000
In-Reply-To: <bug-19502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19502-70-JDqUs0Xxp6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|julian.maurice at biblibre.com |

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Nick, can you take a look at the last patch please ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 15:49:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 13:49:02 +0000
Subject: [Koha-bugs] [Bug 20883] New: Patron userid should be exposed
Message-ID: <bug-20883-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20883

            Bug ID: 20883
           Summary: Patron userid should be exposed
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: ILL
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew.isherwood at ptfs-europe.com

Currently, when displaying a list of ILL requests, or viewing a single request,
the requester's userid is not displayed. This should be visible.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 15:49:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 13:49:26 +0000
Subject: [Koha-bugs] [Bug 20883] Patron userid should be exposed
In-Reply-To: <bug-20883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20883-70-yx0TgrLng3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20883

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ
                   |ity.org                     |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 16:04:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 14:04:23 +0000
Subject: [Koha-bugs] [Bug 20883] Patron userid should be exposed
In-Reply-To: <bug-20883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20883-70-e89xS0Z8zo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20883

--- Comment #1 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 75817
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75817&action=edit
Bug 20883: Add patron userid to display

This patch adds the display of patron userid to both the "illlist" and
"illview" pages.

Test plan (see bug 7317 for ILL deployment details):
1) Ensure you have at least one ILL request
2) Go to the main "List requests" page by clicking "ILL requests" from
the main staff interface
   TEST => Observe that you see a "Patron username" column the the
   table, containing the patron's correct userid
3) Click "Manage request" on a request
   TEST => Observe that, in the "Patron" row, you see the patron's
   correct userid in brackets (along with their name and barcode)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 16:04:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 14:04:46 +0000
Subject: [Koha-bugs] [Bug 20883] Patron userid should be exposed
In-Reply-To: <bug-20883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20883-70-CFl5tpwdHJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20883

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 16:08:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 14:08:09 +0000
Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing
 personal data in account menu and self-registration
In-Reply-To: <bug-20819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20819-70-dtQR2aEapd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75818
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75818&action=edit
Bug 20819: Add your consents tab to opac-user

This patch adds a consents tab to the OPAC user account menu. We now
add a GDPR section here, but it is open for future extensions. Think of
a newsletter checkbox for instance.

Script opac-patron-consent handles the tab. And now only includes some
GDPR code but is also written for more general use too.

Test plan:
[1] Set GDPR_Policy pref to Disabled. Verify that OPAC operates as usual.
[2] Set pref to Permissive. Try to save a consent or a refusal. Note that
    you are not logged out when saving a refusal.
[3] Set pref to Enforced. Save a refusal. You should be logged out.
    Log in again and verify that the consents tab shows a No.
    Note: a follow-up patch will add further enforcements.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 16:08:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 14:08:13 +0000
Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing
 personal data in account menu and self-registration
In-Reply-To: <bug-20819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20819-70-NmvhQkLlti@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75819
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75819&action=edit
Bug 20819: Add check in get_template_and_user to enforce GDPR

If you choose to enforce GDPR policy, a user needs to give consent for
data processing before he does something else in the OPAC while being
logged in.

Test plan:
[1] Set GDPR_Policy to Disabled or Permissive. Usual behavior.
[2] Set to Enforced. Save a refusal on your consents. Notice that
    you are logged out when saving. When you login again, all OPAC
    requests are redirected to your consents tab.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 16:08:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 14:08:18 +0000
Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing
 personal data in account menu and self-registration
In-Reply-To: <bug-20819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20819-70-xJ8ojmOk99@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75820
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75820&action=edit
Bug 20819: Add consent to self-registration process

We add a section for the GDPR consent in opac-memberentry (only for the
self-registration). Not when editing personal details.

Test plan:
[1] Enable selfregistration (with confirm) and GDPR policy.
[2] Register a new account in OPAC. Verify that the GDPR checkbox is
    required.
[3] After you submit, you should see a date in borrower_modifications
    field gdpr_proc_consent.
[4] When you confirm, verify that the consent is visible on your consents.
[5] Enable selfregistration without confirmation mail. Register again.
[6] Check your consents tab again.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 16:09:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 14:09:33 +0000
Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing
 personal data in account menu and self-registration
In-Reply-To: <bug-20819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20819-70-K5eCfDAAZ4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 16:12:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 14:12:18 +0000
Subject: [Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection
	Regulation)
In-Reply-To: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18081-70-ozXlCF0n6Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #4)
> I would prefer a patron consent field as a datetime somewhere. This helps us
> to comply to the need to prove that a patron gave consent. It should be
> added to self registration too.

Please have a look at bug 20819 now for the above.
It adds a 'your consents' tab in the OPAC account menu. And includes a consent
during self-registration. (No staff changes there.)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 16:23:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 14:23:58 +0000
Subject: [Koha-bugs] [Bug 20883] Patron userid should be exposed
In-Reply-To: <bug-20883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20883-70-Ve2YKeg81T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20883

--- Comment #2 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 75821
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75821&action=edit
Bug 20883: (follow-up) Fix column indexes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 16:28:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 14:28:48 +0000
Subject: [Koha-bugs] [Bug 20797] If an Ill request has an associated bib
 record, the detail view should contain a link to the record
In-Reply-To: <bug-20797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20797-70-yxx9gLXo7C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Andrew Isherwood from comment #13)
> Further to this, I think this is the problem:
> 
> https://github.com/PTFS-Europe/koha/blob/master/Koha/Object.pm#L249
> 
> If it's a numeric column, the value is being cast into an integer regardless
> of whether it's populated or not.
> 
> Do you agree this is the bug?

That sounds like a bug yes, can you report it and CC Tomas please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 16:33:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 14:33:30 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-ViB0aqW9mV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #17 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Katrin Fischer from comment #16)
> I had not time to test, but wondering if this will work with our various
> dateformat settings?

Filtering by date didn't work for me when the dateformat preference was set to
dmydot or metric.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 16:38:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 14:38:06 +0000
Subject: [Koha-bugs] [Bug 15836] Labels: Offer configuration option for
 splitting call number in layout definition
In-Reply-To: <bug-15836-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15836-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15836-70-6zfQl2vtuh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836

Christian Stelzenm?ller <christian.stelzenmueller at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |christian.stelzenmueller at bs
                   |                            |z-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 16:49:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 14:49:20 +0000
Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields
	function
In-Reply-To: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12159-70-qlhC9eHfR8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75822
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75822&action=edit
Bug 12159: (QA follow-up) Silencing POD warn from qa tools

*** ERROR: Spurious text after =cut at line 954 in file Koha/Patron.pm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 16:50:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 14:50:57 +0000
Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields
	function
In-Reply-To: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12159-70-jnmyM4GTNS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
FAIL Koha/Patron/Attribute.pm
forbidden pattern: Warning: The 'sub type' may be wrong is declared in a
Koha::* package (see bug 15446) (line 127)

Josef:
This is a more nasty one.
Could you consider renaming this method?
The Koha objects also use _type and it might be confusing.
What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 16:59:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 14:59:55 +0000
Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields
	function
In-Reply-To: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12159-70-pMn1XxsKYI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #18)
> FAIL Koha/Patron/Attribute.pm
> forbidden pattern: Warning: The 'sub type' may be wrong is declared in a
> Koha::* package (see bug 15446) (line 127)
> 
> Josef:
> This is a more nasty one.
> Could you consider renaming this method?
> The Koha objects also use _type and it might be confusing.
> What do you think?

It already exists.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 17:10:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 15:10:19 +0000
Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields
	function
In-Reply-To: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12159-70-fniFDmValI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
IMO we should push this one along with bug 20443 (which does not have patches
yet). Otherwise we are going to have 2 different ways to fetch patron's
attributes.
Before we only had GetBorrowerAttributes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 17:16:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 15:16:58 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth matchpoint no longer works after
 upgrade to 17.11
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-7dhLYXgFqt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=18880
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 17:16:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 15:16:58 +0000
Subject: [Koha-bugs] [Bug 18880] Regression breaks local authentication
 fallback for all external authentications
In-Reply-To: <bug-18880-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18880-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18880-70-0rhC9f3ScI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20879

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 17:19:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 15:19:14 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth matchpoint no longer works after
 upgrade to 17.11
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-gKZgoWoTid@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

--- Comment #3 from cking at uttyler.edu ---
I get the following in the opac-error log now with $debug=1.
The uninitialized value on line 86 appears to relate to this line in
get_login_shib:
 $debug and warn $matchAttribute . " value: " . $ENV{$matchAttribute};

I don't believe we are using Plack, but I'm not familiar with it either.

[Tue Jun 05 09:44:25.029248 2018] [cgi:error] [pid 189874] [client
129.114.255.234:51435] AH01215: [Tue Jun  5 09:44:25 2018] Auth.pm: koha
borrower field to match: cardnumber at
/usr/share/koha/lib/C4/Auth_with_shibboleth.pm line 166, <DATA> line 755.:
/usr/share/koha/opac/cgi-bin/opac/opac-search.pl
[Tue Jun 05 09:44:25.029403 2018] [cgi:error] [pid 189874] [client
129.114.255.234:51435] AH01215: [Tue Jun  5 09:44:25 2018] Auth.pm: shibboleth
attribute to match: employeeNumber at
/usr/share/koha/lib/C4/Auth_with_shibboleth.pm line 168, <DATA> line 755.:
/usr/share/koha/opac/cgi-bin/opac/opac-search.pl
[Tue Jun 05 09:44:25.029520 2018] [cgi:error] [pid 189874] [client
129.114.255.234:51435] AH01215: [Tue Jun  5 09:44:25 2018] Auth.pm: koha
borrower field to match: cardnumber at
/usr/share/koha/lib/C4/Auth_with_shibboleth.pm line 166, <DATA> line 755.:
/usr/share/koha/opac/cgi-bin/opac/opac-search.pl
[Tue Jun 05 09:44:25.029638 2018] [cgi:error] [pid 189874] [client
129.114.255.234:51435] AH01215: [Tue Jun  5 09:44:25 2018] Auth.pm: shibboleth
attribute to match: employeeNumber at
/usr/share/koha/lib/C4/Auth_with_shibboleth.pm line 168, <DATA> line 755.:
/usr/share/koha/opac/cgi-bin/opac/opac-search.pl
[Tue Jun 05 09:44:25.029764 2018] [cgi:error] [pid 189874] [client
129.114.255.234:51435] AH01215: [Tue Jun  5 09:44:25 2018] Auth.pm: Use of
uninitialized value in concatenation (.) or string at
/usr/share/koha/lib/C4/Auth_with_shibboleth.pm line 86, <DATA> line 755.:
/usr/share/koha/opac/cgi-bin/opac/opac-search.pl
[Tue Jun 05 09:44:25.029866 2018] [cgi:error] [pid 189874] [client
129.114.255.234:51435] AH01215: [Tue Jun  5 09:44:25 2018] Auth.pm:
employeeNumber value:  at /usr/share/koha/lib/C4/Auth_with_shibboleth.pm line
86, <DATA> line 755.: /usr/share/koha/opac/cgi-bin/opac/opac-search.pl
[Tue Jun 05 09:44:25.092226 2018] [cgi:error] [pid 189874] [client
129.114.255.234:51435] AH01215: C4::Tags external dictionary = none:
/usr/share/koha/opac/cgi-bin/opac/opac-search.pl
[Tue Jun 05 09:44:25.215447 2018] [cgi:error] [pid 189874] [client
129.114.255.234:51435] AH01215: [Tue Jun  5 09:44:25 2018] opac-search.pl: Use
of uninitialized value in concatenation (.) or string at
/usr/share/koha/lib/C4/Auth.pm line 550, <DATA> line 755.:
/usr/share/koha/opac/cgi-bin/opac/opac-search.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 17:24:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 15:24:52 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth matchpoint no longer works after
 upgrade to 17.11
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-Rg020qsE2A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17776

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I guess it comes from:
Auth.pm: employeeNumber value:  at
/usr/share/koha/lib/C4/Auth_with_shibboleth.pm line 86

 85     $debug and warn $matchAttribute . " value: " . $ENV{$matchAttribute};

See bug 17776.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 17:24:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 15:24:52 +0000
Subject: [Koha-bugs] [Bug 17776] Shibboleth Authentication is broken in plack
In-Reply-To: <bug-17776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17776-70-oVFOSwyE3e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17776

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20879

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 17:26:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 15:26:55 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth matchpoint no longer works after
 upgrade to 17.11
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-vFZho6VXT8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to cking from comment #3)
> I get the following in the opac-error log now with $debug=1.
> The uninitialized value on line 86 appears to relate to this line in
> get_login_shib:
>  $debug and warn $matchAttribute . " value: " . $ENV{$matchAttribute};
> 
> I don't believe we are using Plack, but I'm not familiar with it either.

I read to fast.
To know if you are using plack, go to the about page, tab "Server information",
line "PSGI".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 17:38:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 15:38:24 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth matchpoint no longer works after
 upgrade to 17.11
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-QNw4QAtSJS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

--- Comment #6 from cking at uttyler.edu ---
(In reply to Jonathan Druart from comment #5)
> (In reply to cking from comment #3)
> > I get the following in the opac-error log now with $debug=1.
> > The uninitialized value on line 86 appears to relate to this line in
> > get_login_shib:
> >  $debug and warn $matchAttribute . " value: " . $ENV{$matchAttribute};
> > 
> > I don't believe we are using Plack, but I'm not familiar with it either.
> 
> I read to fast.
> To know if you are using plack, go to the about page, tab "Server
> information", line "PSGI".

Ah, thanks.  No mention of PSGI in the About screen.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 17:43:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 15:43:46 +0000
Subject: [Koha-bugs] [Bug 20867] Ability to show membership renewal date on
 moremember.pl page
In-Reply-To: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20867-70-tNoOcvsTAM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
The change to the controller is not needed, you just need:

+    [% patron.date_renewed %]
+        <li><span class="label">Renewal date: </span>[% patron.date_renewed |
$KohaDates %]</li>
+    [% END %]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 18:03:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 16:03:09 +0000
Subject: [Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with
 C4::Context->temporary_directory
In-Reply-To: <bug-20727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20727-70-ZNKjAHEP3C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Do not we need to update the occurrence in updatedatabase.pl as well?

installer/data/mysql/updatedatabase.pl:my $tmp=
File::Spec->tmpdir.'/koha_upload';

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 18:04:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 16:04:29 +0000
Subject: [Koha-bugs] [Bug 20840] Internal Server Error when clicking on
	"Details" button
In-Reply-To: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20840-70-0b5KwfGEes@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_18_05_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 18:04:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 16:04:35 +0000
Subject: [Koha-bugs] [Bug 20767] "The method is not covered by tests!"
 should give more information
In-Reply-To: <bug-20767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20767-70-SYCUCsJzjz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_18_05_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 18:10:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 16:10:29 +0000
Subject: [Koha-bugs] [Bug 20880] Upgraded 17.11 to 18.05: Malformed
 Bootstrap Theme Filenames
In-Reply-To: <bug-20880-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20880-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20880-70-NZwzk9Axwa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20880

--- Comment #4 from Christian McDonald <rcmcdonald91 at gmail.com> ---
What's confusing to me is that my installation IS a packaged installation
(Debian using the stable repository).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 18:22:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 16:22:17 +0000
Subject: [Koha-bugs] [Bug 20779] Style refresh for patron detail page
In-Reply-To: <bug-20779-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20779-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20779-70-Nen3dMKJlf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 18:30:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 16:30:58 +0000
Subject: [Koha-bugs] [Bug 20668] Update two-column templates with Bootstrap
 grid: Acquisitions part 2
In-Reply-To: <bug-20668-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20668-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20668-70-KSDJoLi82H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20668

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75196|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75823
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75823&action=edit
Bug 20668: Update two-column templates with Bootstrap grid: Acquisitions part 2

This patch modifies several acquisitions templates to use the Bootstrap
grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags in the modified templates.

Staff client CSS is modified in this patch so that elements which were
styled based on the sidebar's "yui-b" class will work with <aside>.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

- I don't have EDI set up, so to test acqui/edi_ean.tt I navigate
  directly to /cgi-bin/koha/acqui/edi_ean.pl. It's only the page
  structure we're worried about.
- Acquisitions -> Orders search
- Acquisitions -> Vendor -> Invoices -> Invoice search
  - View an invoice
  - Manage invoice files (Preference AcqEnableFiles must be enabled).
- Acquisitions -> Late orders

Patch applies and operates as described.
Signed-off-by: Dilan Johnpull? <dilan at calyx.net.au>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 18:30:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 16:30:55 +0000
Subject: [Koha-bugs] [Bug 20668] Update two-column templates with Bootstrap
 grid: Acquisitions part 2
In-Reply-To: <bug-20668-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20668-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20668-70-t4aNHoydPU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20668

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 18:31:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 16:31:58 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth matchpoint no longer works after
 upgrade to 17.11
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-IEetREIla6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Well the fact that $ENV{$matchAttribute} is undefined is the root cause of the
problem. I've never seen that happen outside of the plack context though so I'm
not really sure what to advise.

Are you sure your SP is running and passing attributes through to the vhost in
apache?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 18:42:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 16:42:08 +0000
Subject: [Koha-bugs] [Bug 20468] Multiselect on staff article requests form
In-Reply-To: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20468-70-vyKOb0uIBk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
There are several "Reason for cancellation:" pop-ups, it that expected?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 18:46:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 16:46:38 +0000
Subject: [Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates
 23-26 (Nov 2016, May and Apr 2018)
In-Reply-To: <bug-20709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20709-70-yiGQh8lobF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
About the changes to
installer/data/mysql/de-DE/marcflavour/marc21/mandatory/authorities_normal_marc21.sql,
should not we added them on bug 19835?

We are going to have these files differ, again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 18:47:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 16:47:12 +0000
Subject: [Koha-bugs] [Bug 19835] Update MARC frameworks to Updates 23+24+25
 (Nov 2016, May and Dec 2017)
In-Reply-To: <bug-19835-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19835-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19835-70-Qh3riWvy2I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19835

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
RM: wait for the answer on bug 20709 comment 12 please.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 18:53:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 16:53:18 +0000
Subject: [Koha-bugs] [Bug 20867] Ability to show membership renewal date on
 moremember.pl page
In-Reply-To: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20867-70-291NXyvb9H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 18:53:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 16:53:03 +0000
Subject: [Koha-bugs] [Bug 20867] Ability to show membership renewal date on
 moremember.pl page
In-Reply-To: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20867-70-xXdjmYjEnq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75774|0                           |1
        is obsolete|                            |

--- Comment #4 from Amit Gupta <amitddng135 at gmail.com> ---
Created attachment 75824
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75824&action=edit
Bug 20867 - Ability to show membership renewal date on  moremember.pl page

Test case:
1. Create the patron.
2. Search the patron whose date of membership is about to expire or expired.
3. Click on More->Renew patron.
4. Now membership is renewed.
5. Apply the patch.
6. Reload the page now you will able to see the Membership renewal date.

Fix QA comments

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 19:28:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 17:28:41 +0000
Subject: [Koha-bugs] [Bug 20880] Upgraded 17.11 to 18.05: Malformed
 Bootstrap Theme Filenames
In-Reply-To: <bug-20880-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20880-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20880-70-NRDoIxBduo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20880

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Ok, out of my depth then. Should we reopen?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 19:42:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 17:42:59 +0000
Subject: [Koha-bugs] [Bug 20880] Upgraded 17.11 to 18.05: Malformed
 Bootstrap Theme Filenames
In-Reply-To: <bug-20880-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20880-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20880-70-ieQv1q4rU3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20880

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Christian McDonald from comment #4)
> What's confusing to me is that my installation IS a packaged installation
> (Debian using the stable repository).

When you upgraded, did apt ask you something about this file?
If you manually edited the file before the upgrade, apt asks you what you want
to do with the file: pick the one from the maintainer, keep yours, etc.
If you selected something else than picking the file provided by the package it
is expected that these lines are missing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 19:55:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 17:55:15 +0000
Subject: [Koha-bugs] [Bug 7651] Add separate permission for managing
 currencies and exchange rates
In-Reply-To: <bug-7651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7651-70-CSL9lEefhN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 19:55:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 17:55:21 +0000
Subject: [Koha-bugs] [Bug 7651] Add separate permission for managing
 currencies and exchange rates
In-Reply-To: <bug-7651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7651-70-fxx1fe6JFc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75573|0                           |1
        is obsolete|                            |
  Attachment #75574|0                           |1
        is obsolete|                            |
  Attachment #75788|0                           |1
        is obsolete|                            |

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75825
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75825&action=edit
Bug 7651: Add a new permission for managing currencies and exchange rates

At the moment staff users need parameters or parameters_remaining_permissions
in order to be able to change exchange rates for acquisition orders.

This patch adds a new separate permission currencies_manage and
updates staff users currently having those permissions to get the
new permission as well.

To test:
- Create some staff users with different permission sets
  1) superlibrarian
  2) parameters
  3) parameters_remaining_permissions
  4) manage_circ_rules, but not parmeters_remaining_permissions
  5) all acquisition permissions
- Apply patch and run database update
- Verify new permission has been added and staff users updated
  1) remains the same
  2) + 3) will have currencies_manage
  4) remains unchanged, doesn't have new permission
  5) remains the same, will have access now because of having
     the top level acquisition permission
- Verify the changed pages work correctly:
  - navigation on admin home page
    NOTE: the acquisition parameters section will now honor all
    different related permissions (edi_manage, budget_manage,...)
  - navigation on acquisition home page
  - try to access currencies page directly

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 19:55:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 17:55:27 +0000
Subject: [Koha-bugs] [Bug 7651] Add separate permission for managing
 currencies and exchange rates
In-Reply-To: <bug-7651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7651-70-YmqLyAScLV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75826
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75826&action=edit
Bug 7651: (follow-up) Correct visibility on admin sidebar

This patch corrects visibility of links to the different
acquisition pages from the admin sidebar.

It also makes a correction to the links on the acq start
page:
- Budgets = period_manage
- Funds = budget_manage

To test:
- Follow the test plan of the first patch

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 19:55:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 17:55:32 +0000
Subject: [Koha-bugs] [Bug 7651] Add separate permission for managing
 currencies and exchange rates
In-Reply-To: <bug-7651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7651-70-I1pYFzb50e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75827
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75827&action=edit
Bug 7651: (QA follow-up) Fix warning about undefined active currency

If no active currency is defined we show a warning. This fixes
the link shown below to check the correct permission.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 19:55:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 17:55:38 +0000
Subject: [Koha-bugs] [Bug 7651] Add separate permission for managing
 currencies and exchange rates
In-Reply-To: <bug-7651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7651-70-yfyyPyf313@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75828
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75828&action=edit
Bug 7651: put TT directive on a single line to help translation

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 20:09:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 18:09:50 +0000
Subject: [Koha-bugs] [Bug 19719] Add a new column for collection in the
 patron checkouts data table
In-Reply-To: <bug-19719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19719-70-QAJAHSz5SL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Do we really want to display this column for all installations?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 20:10:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 18:10:55 +0000
Subject: [Koha-bugs] [Bug 19719] Add a new column for collection in the
 patron checkouts data table
In-Reply-To: <bug-19719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19719-70-OSx2JQa4ct@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
We could display for new installations and hide on update? Not sure about the
db structure there, have to take a closer look.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 20:15:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 18:15:45 +0000
Subject: [Koha-bugs] [Bug 19719] Add a new column for collection in the
 patron checkouts data table
In-Reply-To: <bug-19719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19719-70-zvCmTyMT7U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719

--- Comment #15 from Owen Leonard <oleonard at myacpl.org> ---
Update the table's column configuration to initially hide the column?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 20:18:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 18:18:26 +0000
Subject: [Koha-bugs] [Bug 19709] Move template JavaScript to the footer:
	Labels
In-Reply-To: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19709-70-aTY4C479uc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20641


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20641
[Bug 20641] Switch single-column templates to Bootstrap grid: Various, part 2
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 20:18:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 18:18:26 +0000
Subject: [Koha-bugs] [Bug 20641] Switch single-column templates to Bootstrap
 grid: Various, part 2
In-Reply-To: <bug-20641-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20641-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20641-70-IgU7wCfbHw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20641

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19709


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709
[Bug 19709] Move template JavaScript to the footer: Labels
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 20:19:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 18:19:57 +0000
Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to
	configuration files
In-Reply-To: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20073-70-QXQsilAyKX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 20:20:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 18:20:00 +0000
Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to
	configuration files
In-Reply-To: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20073-70-9frkIQwvPQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74421|0                           |1
        is obsolete|                            |
  Attachment #74759|0                           |1
        is obsolete|                            |
  Attachment #75453|0                           |1
        is obsolete|                            |

--- Comment #44 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 75829
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75829&action=edit
Bug 20073 - Move Elasticsearch configs to yaml files and improve the default
settings.

Improvements:
1) Index settings moved from code to
etc/searchengine/elasticsearch/index_config.yaml. An alternative can be
specified in koha-conf.xml.
2) Field settings moved from code to
etc/searchengine/elasticsearch/field_config.yaml. An alternative can be
specified in koha-conf.xml.
3) mappings.yaml has been moved from admin/searchengine/elasticsearch to
etc/searchengine/elasticsearch. An alternative can be specified in
koha-conf.xml.
4) Default settings have been improved to remove punctuation from phrases used
for sorting etc.
5) State variables are used for storing configuration to avoid parsing it
multiple times.
6) A possibility to reset the fields too has been added to the reset operation
of mappings administration.
7) mappings.yaml has been moved from admin/searchengine/elasticsearch to
etc/searchengine/elasticsearch.
8) An stdno field type has been added for standard identifiers.

To test:
1) Run tests in t/Koha/SearchEngine/Elasticsearch.t
2) Clear tables search_fields and search_marc_map
3) Go to
admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1
4) Verify that admin/searchengine/elasticsearch/mappings.pl displays the
mappings properly, including ISBN and other standard number fields.
5) Index some records using the -d parameter with
misc/search_tools/rebuild_elastic_search.pl to recreate the index
6) Verify that you can find the records
7) Put
<elasticsearch_index_mappings>non_existent</elasticsearch_index_mappings> to
koha-conf.xml
8) Verify that
admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1
fails because it can't find non_existent.
9) Copy etc/searchengine/elasticsearch/mappings.yaml to a new location and make
elasticsearch_index_mappings setting in koha-conf.xml point to it.
10) Make a change in the new mappings.yaml.
11) Clear table search_fields (mappings reset doesn't do it yet, see bug 20248)
12) Go to
admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1
13) Verify that the changes you made are now visible in the mappings UI

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 20:20:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 18:20:09 +0000
Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to
	configuration files
In-Reply-To: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20073-70-h4807g2766@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073

--- Comment #45 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 75830
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75830&action=edit
Bug 20073: Remove perlcritic error

"return" statement with explicit "undef" at line 245, column 5.  See
page 199 of PBP.  (Severity: 5)

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 20:20:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 18:20:12 +0000
Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to
	configuration files
In-Reply-To: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20073-70-xuhieBao8Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073

--- Comment #46 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 75831
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75831&action=edit
Bug 20073: Move Elasticsearch yaml files back to admin directory

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 20:26:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 18:26:27 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
	Elasticsearch
In-Reply-To: <bug-19893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19893-70-ApBsQSsioZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #67 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Have we come to a conclusion here? What would be the next step? 
Should we add it to the agenda for next dev's meeting?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 20:27:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 18:27:58 +0000
Subject: [Koha-bugs] [Bug 20641] Switch single-column templates to Bootstrap
 grid: Various, part 2
In-Reply-To: <bug-20641-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20641-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20641-70-N2pltxZ19e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20641

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75300|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 75832
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75832&action=edit
Bug 20641: Switch single-column templates to Bootstrap grid: Various, part 2

This patch updates various unrelated templates to use the Bootstrap
grid. In each case, confirm that the indicated page looks correct.

 - Acquisitions -> Vendor -> Add to basket -> From a staged file.
 - Logged-in user menu (in the upper right) -> Search history.
 - With plugins disabled in koha-conf.xml, go to Tools -> Tools plugins.
 - With the EasyAnalyticalRecords system preference set to 'Display,'
   view a bibliographic record.
   - Choose Edit -> Link to host item.
   - Submit a barcode to be linked.
 - Configure a MARC subfield (e.g. 100$a) to use the
   unimarc_field_225a_bis plugin.
   From the MARC edit page, trigger the plugin and confirm that the
   page in the popup window looks correct. Confirm that changes made in
   the popup window are saved to the corresponding field in the editor.
 - Administration -> Funds -> Edit a fund.
   - Click 'Select owner.'
   - Search for a patron.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Rebased on top of Bug 19709

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 20:40:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 18:40:23 +0000
Subject: [Koha-bugs] [Bug 20501] Unhighlight in search results when the
 search terms contain the same word twice removes the word
In-Reply-To: <bug-20501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20501-70-xFuaKW0Bkt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20501

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
I cannot reproduce this problem in master. Can anyone confirm? If so please
cite another example.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 20:40:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 18:40:49 +0000
Subject: [Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates
 23-26 (Nov 2016, May and Apr 2018)
In-Reply-To: <bug-20709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20709-70-AFfU6Wv3yp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709

--- Comment #13 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Jonathan Druart from comment #12)
> About the changes to
> installer/data/mysql/de-DE/marcflavour/marc21/mandatory/
> authorities_normal_marc21.sql, should not we added them on bug 19835?
> 
> We are going to have these files differ, again.

Hi Jonathan

On master+19835+20710
en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql will have 2385
lines

On master+20709
de-DE/marcflavour/marc21/mandatory/authorities_normal_marc21.sql will have 2385
lines too

They will differ in that one is the translation of the other, but they are
basically the same file.

The only thing is that translations are made using master+19835+20710,
so they will differ (a little) until 19835 & 20710 are pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 20:46:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 18:46:57 +0000
Subject: [Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates
 23-26 (Nov 2016, May and Apr 2018)
In-Reply-To: <bug-20709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20709-70-zaSQT9QWqD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
What about other languages?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 20:49:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 18:49:19 +0000
Subject: [Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with
 C4::Context->temporary_directory
In-Reply-To: <bug-20727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20727-70-gqsKOiJQat@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 75833
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75833&action=edit
Bug 20727: Replace use of tmpdir in updatedatabase.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 20:49:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 18:49:26 +0000
Subject: [Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with
 C4::Context->temporary_directory
In-Reply-To: <bug-20727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20727-70-SzITUQ5A1i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727

--- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 75834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75834&action=edit
Bug 20727: Add use line for File::Spec in C4::Context, sort used modules

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 20:50:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 18:50:34 +0000
Subject: [Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with
 C4::Context->temporary_directory
In-Reply-To: <bug-20727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20727-70-zAMVsy3n3H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75834|0                           |1
        is obsolete|                            |

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 75835
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75835&action=edit
Bug 20727: Add use line for File::Spec in C4::Context, sort used modules

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 21:01:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 19:01:40 +0000
Subject: [Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates
 23-26 (Nov 2016, May and Apr 2018)
In-Reply-To: <bug-20709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20709-70-cstj3DuNP4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think some have translated manually, so might not be so easy to switch them
to the generated files?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 21:17:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 19:17:43 +0000
Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values
In-Reply-To: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20307-70-eWRynbPV7j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|jonathan.druart at bugs.koha-c |koha-bugs at lists.koha-commun
                   |ommunity.org                |ity.org
             Status|ASSIGNED                    |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 21:31:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 19:31:15 +0000
Subject: [Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates
 23-26 (Nov 2016, May and Apr 2018)
In-Reply-To: <bug-20709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20709-70-7HMwNzZezn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709

--- Comment #16 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Jonathan Druart from comment #14)
> What about other languages?

Not all languages that have translated sql files (marc21 project on translation
server) have custom install dirs, so is up to each language maintainer what to
do with those sql files.

It would be better if we could 'translate' sql files using the normal way, but
it's no easy task. I tried a while ago using XML files...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 22:09:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 20:09:48 +0000
Subject: [Koha-bugs] [Bug 20884] New: Stale data remaining in cache after
	koha-remove
Message-ID: <bug-20884-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20884

            Bug ID: 20884
           Summary: Stale data remaining in cache after koha-remove
 Change sponsored?: ---
           Product: Koha
           Version: 18.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jcharaoui at cmaisonneuve.qc.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net

Created attachment 75836
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75836&action=edit
0001-Restart-memcached-after-koha-remove-if-needed.patch

After running koha-remove, stale data remains in within the memcached server.

Say if an instance is deleted then recreated immediately, changed data such as
database credentials isn't loaded into the cache, resulting in strange,
difficult to troubleshoot problems.

The solution would be to flush memcached cache at the end of koha-remove.

The most straightforward method to do this is simply restart the service.

See attached patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 22:15:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 20:15:12 +0000
Subject: [Koha-bugs] [Bug 20884] Stale data remaining in cache after
	koha-remove
In-Reply-To: <bug-20884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20884-70-bMPxSu3uWH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20884

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |normal
           Assignee|koha-bugs at lists.koha-commun |jcharaoui at cmaisonneuve.qc.c
                   |ity.org                     |a
            Version|18.05                       |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 22:14:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 20:14:56 +0000
Subject: [Koha-bugs] [Bug 20884] Stale data remaining in cache after
	koha-remove
In-Reply-To: <bug-20884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20884-70-pMwiiIU0rS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20884

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Note for later, see also:
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75384

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 22:22:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 20:22:48 +0000
Subject: [Koha-bugs] [Bug 20884] Stale data remaining in cache after
	koha-remove
In-Reply-To: <bug-20884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20884-70-H4oIdkxpYz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20884

Jerome Charaoui <jcharaoui at cmaisonneuve.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 22:24:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 20:24:44 +0000
Subject: [Koha-bugs] [Bug 20884] Stale data remaining in cache after
	koha-remove
In-Reply-To: <bug-20884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20884-70-KeLloP711E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20884

--- Comment #2 from Jerome Charaoui <jcharaoui at cmaisonneuve.qc.ca> ---
Using a function like flush_cache() would indeed be better than restarting the
service.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun  5 22:31:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 20:31:11 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth matchpoint no longer works after
 upgrade to 17.11
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-SmYNX7UxJ9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

--- Comment #8 from cking at uttyler.edu ---
I must have copied the wrong log entries from the wrong timeframe.  Upon
further testing, the value is actually present.  Could LDAP being enabled throw
off the auth process for Shibboleth?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 01:04:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 23:04:33 +0000
Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
In-Reply-To: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17698-70-yNk8WrTQbS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73839|0                           |1
        is obsolete|                            |

--- Comment #51 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 75837
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75837&action=edit
Bug 17698: Make patron notes show up on staff dashboard

This patch adds a user permission for managing issue notes, and a 'noteseen'
column to the issues table.

To test:
1) Apply Bug 14224 first
2) Apply this patch, update database, rebuild schema.
3) Restart koha-common and memcached
4) Turn on AllowCheckoutNotes syspref if haven't already
5) Issue two items to two different users (one item each)
6) Log into the OPAC as one of the users and add an issue note to their
issue
7) Log out and log back into the OPAC as the other user
8) Disable Javascript
9) Refresh opac-user.pl
10) Leave a checkout note on their issue
11) Enable javascript and log into the Staff Client as a superlibrarian
user
12) Go to your user's account and edit their permissions to have
everything ticked EXCEPT circulate->manage checkout notes.
13) Go to main intranet page. There should be no message saying
'checkout notes pending'.
14) Go to circulation home page. There should be no link to Checkout notes.
15) Go back to user's permissions and tick circulate->manage checkout notes.
16) Go back to main intranet page. There should now be a message at the
bottom saying 'Checkout notes pending: 2'
17) Go to circulation home page. There should be a link to Checkout notes
with a 2 next to it. Click this link
18) Attempt to mark an checkout note as seen. This should update the status
of the checkout note to 'seen' and disable to 'mark as seen' button while
enabling the 'mark as not seen' button.
19) Test both buttons with both issues.
20) Test select all and clear all buttons
21) Confirm that buttons at the bottom are only enabled if a checkbox is
checked
22) Try selecting both issues and using the buttons at the bottom to
mark multiple issue notes at once.
23) Confirm the barcode link to the item works as expected.
24) Confirm the cardnumber link to the user works as expected.
25) Confirm all table details show correctly.

Sponsored-by: Catalyst IT

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Followed test plan, works as expected
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 01:04:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 23:04:41 +0000
Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
In-Reply-To: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17698-70-yTd2w4fF74@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73840|0                           |1
        is obsolete|                            |

--- Comment #52 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 75838
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75838&action=edit
Bug 17698: [FOLLOW-UP] Changing to Koha Objects style, adding circ sidebar

Marcel, can you please have a look at this patch. I tried to implement
the change
my @notes = $schema->resultset('Issue')->search({ 'me.note' => { '!=', undef }
}, { prefetch => [ 'borrower', { item => 'biblionumber' } ] });
to
my @notes = Koha::Checkouts->search({ 'me.note' => { '!=', undef } }, {
prefetch => [ 'borrower', { item => 'biblionumber' } ] });
but am having problems on the template side. I can access the item and
biblio information about the issue, but not the borrower information,
even though the query is definitely pulling it correctly. Any
suggestions or ideas as to why this breaks?

This patch also adds the implementation of the circSidebar.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 01:04:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 23:04:48 +0000
Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
In-Reply-To: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17698-70-gvqxr2mpwC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73841|0                           |1
        is obsolete|                            |

--- Comment #53 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 75839
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75839&action=edit
Bug 17698: [FOLLOW-UP] Koha Objects, access borrower through patron sub

See Comment 27
This is ready to be tested.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 01:04:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 23:04:54 +0000
Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
In-Reply-To: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17698-70-O4WzlyNgku@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74044|0                           |1
        is obsolete|                            |

--- Comment #54 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 75840
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75840&action=edit
Bug 17698: [FOLLOW-UP] Fixing some small issues

Fixing the comments in Comment 42

Ready to test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 01:05:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 23:05:03 +0000
Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
In-Reply-To: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17698-70-H83I8VstcL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74193|0                           |1
        is obsolete|                            |

--- Comment #55 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 75841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75841&action=edit
Bug 17698: (QA follow-up) Changes to use Asset TT plugin (bug 20538)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 01:20:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 23:20:15 +0000
Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
In-Reply-To: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17698-70-iPFK3oKvTc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 01:20:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jun 2018 23:20:20 +0000
Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
In-Reply-To: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17698-70-ceK7Y4fdh3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

--- Comment #56 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 75842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75842&action=edit
Bug 17698: [FOLLOW-UP] Rebase and schema update

Setting to signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 04:12:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 02:12:09 +0000
Subject: [Koha-bugs] [Bug 15766] Give label and patron card batches a
	description
In-Reply-To: <bug-15766-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15766-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15766-70-CWNzt94lAb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 04:12:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 02:12:14 +0000
Subject: [Koha-bugs] [Bug 15766] Give label and patron card batches a
	description
In-Reply-To: <bug-15766-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15766-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15766-70-IynmK2Dowa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

--- Comment #39 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 75843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75843&action=edit
Bug 15766: [FOLLOW-UP] Fixing layout of description button

This patch moves the 'Save' button to the toolbar as suggested. The
description textbox and 'Save' button are hidden if the batch is new and
appears when items are added.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 07:59:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 05:59:06 +0000
Subject: [Koha-bugs] [Bug 20543] Use multi-core compression to speed up Koha
	backups
In-Reply-To: <bug-20543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20543-70-bKomOAZ9Di@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20543

--- Comment #10 from Mason James <mtj at kohaaloha.com> ---
(In reply to Jonathan Druart from comment #5)
> One more deps, one more deps! :)
> 
> Maybe we should use it only if installed (and not require it?)

hi Jonathan
a single 56k dependency, for a 3x speedup in backup time (i7-2600 cpu)

why would anyone *not* want this enabled, by default?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 08:12:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 06:12:40 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth matchpoint no longer works after
 upgrade to 17.11
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-XMYsPdgKAn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
LDAP shouldn't throw off Shibboleth.. the code flow is to check for the
shibboleth session first and only after testing for that fallback to the other
authentication mechanisms.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 08:16:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 06:16:31 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth matchpoint no longer works after
 upgrade to 17.11
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-LaN8OYN3ub@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Are you seeing this line triggered in your logs at all?

http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Auth_with_shibboleth.pm;h=6b20511df5854a666ddde4a15b72643b9ff25556;hb=5f846a33abe89599fa7b9a37cb3c00632d30ec90#l111

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 08:18:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 06:18:44 +0000
Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields
	function
In-Reply-To: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12159-70-koHLs3f8wI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I agree with Jonathan here

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 09:18:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 07:18:29 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
	Elasticsearch
In-Reply-To: <bug-19893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19893-70-IcbS9L2jW0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

--- Comment #68 from Ere Maijala <ere.maijala at helsinki.fi> ---
Well, I'd try to get this in as soon as 20073 is in master (I'm just waiting
for it and will sign off when done). But that's just me again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 09:54:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 07:54:25 +0000
Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields
	function
In-Reply-To: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12159-70-t6duHSLoTW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #22 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Marcel de Rooy from comment #18)
> FAIL Koha/Patron/Attribute.pm
> forbidden pattern: Warning: The 'sub type' may be wrong is declared in a
> Koha::* package (see bug 15446) (line 127)
> 
> Josef:
> This is a more nasty one.
> Could you consider renaming this method?
> The Koha objects also use _type and it might be confusing.
> What do you think?

We could rename it of course, but isn't that the reason why the type in
Koha::Object was renamed to _type? To avoid conflicts with type accessor if
needed?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 09:55:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 07:55:08 +0000
Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields
	function
In-Reply-To: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12159-70-EirXpePoH0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #23 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Jonathan Druart from comment #20)
> IMO we should push this one along with bug 20443 (which does not have
> patches yet). Otherwise we are going to have 2 different ways to fetch
> patron's attributes.
> Before we only had GetBorrowerAttributes.

Does make sense. I'll try to look at it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 11:14:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 09:14:40 +0000
Subject: [Koha-bugs] [Bug 20885] New: Transferring an item on hold results
 in bypassing restrictions,
 actually doing the transfer and can be piled up if repeated
Message-ID: <bug-20885-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20885

            Bug ID: 20885
           Summary: Transferring an item on hold results in bypassing
                    restrictions, actually doing the transfer and can be
                    piled up if repeated
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: victor.grousset at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

The first name was ?Transferring an item on hold results in chaos?

Disclaimer: I'm not sure if what I did makes sense from a functional point of
view.

== Test plan ==
1. Add transfer restrictions
     staff:/cgi-bin/koha/admin/branch_transfer_limits.pl
     For all item types => clear all
2. Place a hold on a record
3. go to the transfer page staff:/cgi-bin/koha/circ/branchtransfers.pl
4. Try to transfer the item
5. You should see the message ?Transfer is not allowed for [...]?
   OR retry with another site to fall into your restrictions
6. But you also see the "Transferred items" table showing the transfer
     This is a bug. The transfer shouldn't have been scheduled.
7. On the same page: redo a transfer
8. You should see "Item is already at destination library."
     This is a bug. This is even worst. The transfer shouldn't have
     been actually done!
9. But wait there is more, the transfer has been add to the table.
     This is a bug. It's still scheduled anyway.
     A transfer to the same branch!
10. Redo it again and it will pile up!
11. Raise your hands and ask loudly: Why!


Tried on master the 24 of April and on version 16.11.15
To ensure that bug 19530 hadn't an influence on this.

Might be related to bug 20344

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 11:15:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 09:15:29 +0000
Subject: [Koha-bugs] [Bug 20885] Transferring an item on hold results in
 bypassing restrictions,
 actually doing the transfer and can be piled up if repeated
In-Reply-To: <bug-20885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20885-70-6lC1Pt3hcW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20885

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20344,
                   |                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19530

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 11:15:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 09:15:29 +0000
Subject: [Koha-bugs] [Bug 20344] Transferring an item while on hold results
 in a transfer where the destination is the same as the source
In-Reply-To: <bug-20344-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20344-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20344-70-BXRBsacQdi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20344

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20885

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 11:15:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 09:15:29 +0000
Subject: [Koha-bugs] [Bug 19530] Prevent multiple transfers from existing
	for one item
In-Reply-To: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19530-70-jynFymBQ9u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20885

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 11:51:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 09:51:03 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-JuCHLqAbpJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

--- Comment #18 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 75844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75844&action=edit
Bug 20600: (follow-up) Fix filtering

There was a bug whereby filtering by date would fail if the selected
date syspref was set to dmydot or metric. Rather than use the display
date value, We now use the non-display date value that is always in
a predictable ISO8601 format to construct the Date objects used
for comparison.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 11:51:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 09:51:43 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-XetdIQwS8l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #19 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Oooh, good spot Owen, thanks!

I've just attached a follow-up patch that should address this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 11:53:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 09:53:27 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-BojgfdQ1K2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

--- Comment #20 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 75845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75845&action=edit
Bug 20600: (follow-up) Remove console.log!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 11:58:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 09:58:43 +0000
Subject: [Koha-bugs] [Bug 20825] Cannot checkout if item types at biblio
	level
In-Reply-To: <bug-20825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20825-70-nLDPzqJ96C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #24 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 19943 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 12:01:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 10:01:21 +0000
Subject: [Koha-bugs] [Bug 20822] Can't find HOLD_SLIP template when printing
In-Reply-To: <bug-20822-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20822-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20822-70-AWGOhHteJ5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20822

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

--- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 18789 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 12:03:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 10:03:18 +0000
Subject: [Koha-bugs] [Bug 20652] Sort after item type search fails
In-Reply-To: <bug-20652-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20652-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20652-70-JmEzSiUSXe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20652

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 12:05:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 10:05:14 +0000
Subject: [Koha-bugs] [Bug 20652] Sort after item type search fails
In-Reply-To: <bug-20652-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20652-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20652-70-jOIRCQlbqi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20652
Bug 20652 depends on bug 19461, which changed state.

Bug 19461 Summary: Add floating toolbar to staff client catalog search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19461

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 12:05:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 10:05:14 +0000
Subject: [Koha-bugs] [Bug 19461] Add floating toolbar to staff client
 catalog search results
In-Reply-To: <bug-19461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19461-70-gBdgO6nQaA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19461

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Awesome

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 12:12:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 10:12:03 +0000
Subject: [Koha-bugs] [Bug 20652] Sort after item type search fails
In-Reply-To: <bug-20652-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20652-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20652-70-rI12fyCxdT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20652

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Bug 19461 not in 17.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 12:14:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 10:14:34 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-lRFVfcdpPJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #74 from Alex Arnaud <alex.arnaud at biblibre.com> ---
(In reply to Josef Moravec from comment #73)
> I went through another round of testing. Looking good now, just one
> (hopefully last) issue: 
> When the subscription is based on week, you can check irregularities for all
> pregenerated issues - but it works only when you check weeks from first year.
> 
> Probably there should be just week numbers from 1 to 52, which could be
> enough.

Don't understand. Can you give me an example ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 12:15:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 10:15:00 +0000
Subject: [Koha-bugs] [Bug 20886] New: Koha::Object::TO_JSON indiscriminately
 casting to integer
Message-ID: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20886

            Bug ID: 20886
           Summary: Koha::Object::TO_JSON indiscriminately casting to
                    integer
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew.isherwood at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

As noted in bug 20797 there appears to be a bug in Koha::Object::TO_JSON.
Specifically:

elsif ( _numeric_column_type( $columns_info->{$col}->{data_type} ) ) {

    # TODO: Remove once the solution for
    # https://rt.cpan.org/Ticket/Display.html?id=119904
    # is ported to whatever distro we support by that time
    $unblessed->{$col} += 0;
}

Here we are explicitly casting to an integer to workaround an upstream bug.
This works fine unless the data in question comes from a numeric type column
but is NULL, in which case it is cast to 0.

I suspect the desired behaviour here is for it to remain unaltered unless the
value is also numeric.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 12:16:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 10:16:07 +0000
Subject: [Koha-bugs] [Bug 20886] Koha::Object::TO_JSON indiscriminately
 casting to integer
In-Reply-To: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20886-70-IXY47FiAXr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20886

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #1 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
CC'ing Tomas in at JD's suggestion

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 12:16:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 10:16:41 +0000
Subject: [Koha-bugs] [Bug 20797] If an Ill request has an associated bib
 record, the detail view should contain a link to the record
In-Reply-To: <bug-20797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20797-70-h1W1RID3mx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797

--- Comment #15 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Done: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20886

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 12:17:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 10:17:03 +0000
Subject: [Koha-bugs] [Bug 20886] Koha::Object::TO_JSON indiscriminately
 casting to integer
In-Reply-To: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20886-70-mFFHXwv894@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20886

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20797


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797
[Bug 20797] If an Ill request has an associated bib record, the detail view
should contain a link to the record
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 12:17:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 10:17:03 +0000
Subject: [Koha-bugs] [Bug 20797] If an Ill request has an associated bib
 record, the detail view should contain a link to the record
In-Reply-To: <bug-20797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20797-70-Mtre5NAMl3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20886


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20886
[Bug 20886] Koha::Object::TO_JSON indiscriminately casting to integer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 12:17:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 10:17:55 +0000
Subject: [Koha-bugs] [Bug 20827] Can't add owner to a fund
In-Reply-To: <bug-20827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20827-70-LrTp9itiKW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20827

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 12:18:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 10:18:41 +0000
Subject: [Koha-bugs] [Bug 20827] Can't add owner to a fund
In-Reply-To: <bug-20827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20827-70-DktC9Vd5S4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20827

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Fridolin SOMERS from comment #6)
> Pushed to 17.11.x for 17.11.07

JS has moved inside TT file so I manually corrected the missing ";"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 12:20:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 10:20:21 +0000
Subject: [Koha-bugs] [Bug 20791] Correct capitalization on 'Notices and
	slips' page
In-Reply-To: <bug-20791-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20791-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20791-70-7fbn8gfXwe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20791

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 12:21:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 10:21:55 +0000
Subject: [Koha-bugs] [Bug 20791] Correct capitalization on 'Notices and
	slips' page
In-Reply-To: <bug-20791-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20791-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20791-70-EPktLelnG1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20791

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
I choose not to backport to 17.05.x, too minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 12:58:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 10:58:57 +0000
Subject: [Koha-bugs] [Bug 20487] AddReturn should clear items.onloan for
	unissued items
In-Reply-To: <bug-20487-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20487-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20487-70-kPhcxsWXHX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 13:13:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 11:13:44 +0000
Subject: [Koha-bugs] [Bug 20487] AddReturn should clear items.onloan for
	unissued items
In-Reply-To: <bug-20487-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20487-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20487-70-p1HM1m0z03@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Do we know how an item gets into this state in the first place?  It feels like
this solution may be hiding a bug further up the tree rather than resolving
it...?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 13:15:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 11:15:59 +0000
Subject: [Koha-bugs] [Bug 20595] EDI: Add support for LRP (Library Rotation
 Plan) for Koha with Stock Rotation enabled
In-Reply-To: <bug-20595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20595-70-AdWCnr0g0K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20595

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 13:22:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 11:22:10 +0000
Subject: [Koha-bugs] [Bug 20468] Multiselect on staff article requests form
In-Reply-To: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20468-70-FjPLkjHYN2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468

--- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #15)
> There are several "Reason for cancellation:" pop-ups, it that expected?

Yes, HandleMulti makes repeated calls here. I agree that it is not very nice.
Although you can specify a different reason per request, it is unclear which
request you are cancelling.
Taking a look if a small follow-up can make a difference..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 13:24:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 11:24:59 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-nPnhVGwxP3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #75 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Alex Arnaud from comment #74)
> (In reply to Josef Moravec from comment #73)
> > I went through another round of testing. Looking good now, just one
> > (hopefully last) issue: 
> > When the subscription is based on week, you can check irregularities for all
> > pregenerated issues - but it works only when you check weeks from first year.
> > 
> > Probably there should be just week numbers from 1 to 52, which could be
> > enough.
> 
> Don't understand. Can you give me an example ?

Here is the screenshot:

https://screenshots.firefox.com/hOUt987Krzxs6uTm/localhost

the other years weeks are not working - they do not set the checkboxes on
previewed issues

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 13:29:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 11:29:25 +0000
Subject: [Koha-bugs] [Bug 19793] Add a field for email in batch patron
	modification
In-Reply-To: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19793-70-JIhbu0Oycv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20847

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 13:29:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 11:29:25 +0000
Subject: [Koha-bugs] [Bug 20847] Add the fields to the Batch Patron
	Modification tool
In-Reply-To: <bug-20847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20847-70-T9GBPWUh5c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20847

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19793

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 13:42:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 11:42:51 +0000
Subject: [Koha-bugs] [Bug 20752] Files tab in patron account is not properly
	capitalized
In-Reply-To: <bug-20752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20752-70-3NybZZtQyn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20752

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 13:43:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 11:43:13 +0000
Subject: [Koha-bugs] [Bug 20752] Files tab in patron account is not properly
	capitalized
In-Reply-To: <bug-20752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20752-70-0q0E7UZmtR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20752

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
I choose not to push to 17.05.x, too minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 13:48:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 11:48:32 +0000
Subject: [Koha-bugs] [Bug 9573] Ability to download items lost report
In-Reply-To: <bug-9573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9573-70-lKOt2Rxmd6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20774


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774
[Bug 20774] Trivial HTML error in itemslost.tt
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 13:48:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 11:48:32 +0000
Subject: [Koha-bugs] [Bug 20774] Trivial HTML error in itemslost.tt
In-Reply-To: <bug-20774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20774-70-QaRR5YHRzb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
         Depends on|                            |9573


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573
[Bug 9573] Ability to download items lost report
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 13:49:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 11:49:16 +0000
Subject: [Koha-bugs] [Bug 20774] Trivial HTML error in itemslost.tt
In-Reply-To: <bug-20774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20774-70-m0P3q8DrQA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 9573 that is not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 13:49:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 11:49:17 +0000
Subject: [Koha-bugs] [Bug 20807] Lost items report: Improve the display of
 CSV profile errors
In-Reply-To: <bug-20807-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20807-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20807-70-eBr421CDFD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20807
Bug 20807 depends on bug 20774, which changed state.

Bug 20774 Summary: Trivial HTML error in itemslost.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 13:51:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 11:51:37 +0000
Subject: [Koha-bugs] [Bug 20468] Multiselect on staff article requests form
In-Reply-To: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20468-70-4P6hzJ4cJC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468

--- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75846&action=edit
Bug 20468: (follow-up) Cancel multiple items for same reason

The repeated prompts for cancelling multiple selected items are
confusing.
The wording is slightly adjusted. The reason is asked only once per
group of selected items.

Test plan:
Create three requests.
Select two requests and cancel (from top menu) for reason A.
Cancel third request (from item menu) for reason B.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 13:54:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 11:54:28 +0000
Subject: [Koha-bugs] [Bug 3886] Can't print receipt w/out allowing "Add or
 modify borrowers" permission
In-Reply-To: <bug-3886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3886-70-jcOgEnlRMI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3886

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #12 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 13:56:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 11:56:37 +0000
Subject: [Koha-bugs] [Bug 3886] Can't print receipt w/out allowing "Add or
 modify borrowers" permission
In-Reply-To: <bug-3886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3886-70-tzCyqRwezY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3886

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

--- Comment #13 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
I choose not to backport to 17.05.x, i focus on major and blocker bugs.

Resoooooolved ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 13:58:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 11:58:02 +0000
Subject: [Koha-bugs] [Bug 20487] AddReturn should clear items.onloan for
	unissued items
In-Reply-To: <bug-20487-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20487-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20487-70-y36NV4H8b2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487

--- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Martin Renvoize from comment #18)
> Do we know how an item gets into this state in the first place?  It feels
> like this solution may be hiding a bug further up the tree rather than
> resolving it...?

I am not suspecting a bug here. Trigger might be related to database actions
outside the interface ;) But what struck me is that checking in such an item
did not clear the onload column. I think it just should; any user would expect
it. I do not see an advantage in leaving it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 14:01:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 12:01:32 +0000
Subject: [Koha-bugs] [Bug 20767] "The method is not covered by tests!"
 should give more information
In-Reply-To: <bug-20767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20767-70-g7o9guXhGL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #13 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 14:02:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 12:02:17 +0000
Subject: [Koha-bugs] [Bug 20339] Unify MARC21 ISBN/ISSN handling in XSL
In-Reply-To: <bug-20339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20339-70-wcD2tMAkyV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20339

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72683|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 75847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75847&action=edit
Bug 20339: Unify MARC21 ISBN/ISSN handling in XSL

The code to show the ISBN and ISSN is repeated between the search results
and the detail view. Create a function to show the ISBN/ISSN, and call
that instead.

Test plan:
1) Apply patch
2) Search for any records, check that the ISBN and ISSN are shown
   correctly
3) Go to biblio detail pages, check that the ISBN and ISSN are shown
   correctly

Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi>

Signed-off-by: claude <claude.brayer at cea.fr>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 14:02:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 12:02:52 +0000
Subject: [Koha-bugs] [Bug 20339] Unify MARC21 ISBN/ISSN handling in XSL
In-Reply-To: <bug-20339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20339-70-zeIZE0sSg5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20339

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Looks solid and works as expected.. always nice to dry out some code a little
:)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 14:03:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 12:03:18 +0000
Subject: [Koha-bugs] [Bug 20339] Unify MARC21 ISBN/ISSN handling in XSL
In-Reply-To: <bug-20339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20339-70-KwFzXGUKJ1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20339

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 14:05:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 12:05:55 +0000
Subject: [Koha-bugs] [Bug 20767] "The method is not covered by tests!"
 should give more information
In-Reply-To: <bug-20767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20767-70-da6uVrFZDZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #14 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
I choose not to backport to 17.05.x, I focus on major and blocker

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 14:08:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 12:08:43 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-fuwdxZgBZX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75276|0                           |1
        is obsolete|                            |

--- Comment #21 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 75848
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75848&action=edit
Bug 20600: Add filtering of ILL requests in list

This patch adds the ability for the ILL request list in the staff
interface to be filtered by a number of criteria:

- Status
- Date placed
- Date modified
- Pickup branch
- Borrower card number

To test:
1) Apply patch
2) Ensure you have a reasonable range of ILL requests created
3) Navigate to the "View ILL requests" page
4) Choose one or more filtering criteria
5) Click "Search"
6) Observe the results are filtered to match the selected criteria
7) Click "Clear"
8) Observe your results are returned to their initial state
9) Repeat steps 4 -> 6 until you are happy.

Dates supplied by the /api/v1/illrequests API route were not conforming
to the preference specified by the dateformat syspref. This patch
addresses that.

It has been addressed as part of this bug since we are adding filtering
of requests by some date fields and, therefore, needed dates in a
predictable format.

To test:
1) Apply the patch
2) Ensure you have at least one ILL request created
3) Make a request to the /api/v1/illrequests endpoint
4) Observe that dates supplied for "placed_formatted" & "updated_formatted"
conform to your
dateformat syspref.
5) Change your date format syspref, repeat steps 3 & 4

Signed-off-by: Magnus Enger <magnus at libriotech.no>
Works as advertised. Nice enh!

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 14:08:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 12:08:47 +0000
Subject: [Koha-bugs] [Bug 15869] Change framework on overlay
In-Reply-To: <bug-15869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15869-70-ZRZu7FNlgh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 14:08:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 12:08:47 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-pmGuZWOcbu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75734|0                           |1
        is obsolete|                            |

--- Comment #22 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 75849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75849&action=edit
Bug 20600: (follow-up) Do not use $_ in loop

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 14:08:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 12:08:54 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-jeoYOOEFxn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75755|0                           |1
        is obsolete|                            |

--- Comment #24 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 75851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75851&action=edit
Bug 20600: (follow-up) Add date range filtering

It makes more sense to be able to filter placed and updated dates by
range. This patch adds that.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 14:08:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 12:08:51 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-xfQ1voMCEd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75735|0                           |1
        is obsolete|                            |

--- Comment #23 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 75850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75850&action=edit
Bug 20600: (follow-up) Remove date formatting

It is not required

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 14:08:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 12:08:59 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-ZCkuOr1fTu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75844|0                           |1
        is obsolete|                            |

--- Comment #25 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 75852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75852&action=edit
Bug 20600: (follow-up) Fix filtering

There was a bug whereby filtering by date would fail if the selected
date syspref was set to dmydot or metric. Rather than use the display
date value, We now use the non-display date value that is always in
a predictable ISO8601 format to construct the Date objects used
for comparison.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 14:09:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 12:09:03 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-HArD40b0GW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75845|0                           |1
        is obsolete|                            |

--- Comment #26 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 75853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75853&action=edit
Bug 20600: (follow-up) Remove console.log!

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 14:19:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 12:19:43 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-xW7iMWLojc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

--- Comment #27 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 75854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75854&action=edit
Bug 20600: (follow-up) Move template JavaScript to the footer

This patch moves the ILL requests template's JavaScript to the footer.

Also changed:
 - Removed unused jQuery checkboxes plugin
 - Some <input> tags have been corrected to be self-closing.
 - Title tag has been corrected
 - Table row limit of 10 has been removed in favor of accepting default
   used elsewhere.

To test, apply the patch and follow the original test plan for this bug.
Everything should work as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 14:20:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 12:20:24 +0000
Subject: [Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE
In-Reply-To: <bug-3820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3820-70-EGIyQQdmvr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820

BASE Library Consortium <baselibrary.consortium at nhs.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |baselibrary.consortium at nhs.
                   |                            |net,
                   |                            |emma.perks at heartofengland.n
                   |                            |hs.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 14:31:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 12:31:54 +0000
Subject: [Koha-bugs] [Bug 20886] Koha::Object::TO_JSON indiscriminately
 casting to integer
In-Reply-To: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20886-70-cOjQvDmI5Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20886

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Andrew Isherwood from comment #1)
> CC'ing Tomas in at JD's suggestion

You are right. Good catch!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 14:47:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 12:47:27 +0000
Subject: [Koha-bugs] [Bug 20779] Style refresh for patron detail page
In-Reply-To: <bug-20779-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20779-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20779-70-rISqHqvw3y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 14:47:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 12:47:29 +0000
Subject: [Koha-bugs] [Bug 20779] Style refresh for patron detail page
In-Reply-To: <bug-20779-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20779-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20779-70-eBFmCBjICM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75504|0                           |1
        is obsolete|                            |

--- Comment #14 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 75855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75855&action=edit
Bug 20779: Style refresh for patron detail page

This patch makes style and markup changes to the patron detail page
template in order to make the display of information somewhat more
compact and to increase the visibility of the edit controls.

To test you should enable the patronimages system preference. Apply the
patch and view the detail page for a patron.

- Check that the page looks correct and that sections like "Alternate
  address" and "Alternative contact" are empty when there is no data.
- Check that the "Manage patron image" tool works correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 14:48:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 12:48:20 +0000
Subject: [Koha-bugs] [Bug 20886] Koha::Object::TO_JSON indiscriminately
 casting to integer
In-Reply-To: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20886-70-b0CtMDnHlv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20886

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 14:49:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 12:49:25 +0000
Subject: [Koha-bugs] [Bug 20779] Style refresh for patron detail page
In-Reply-To: <bug-20779-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20779-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20779-70-SxgOGSRy69@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75435|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 15:54:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 13:54:22 +0000
Subject: [Koha-bugs] [Bug 19633] Use alphanumeric error codes in upload
In-Reply-To: <bug-19633-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19633-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19633-70-xlP0rPPSIw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19633

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75856&action=edit
Bug 19633: (QA follow-up) Really remove these ugly numbers

See BZ comment5. We now remove the numbers also from the constant names.

Test plan:
Read the changes.
Git grep "ERRCODE_"
Run t/db_dependent/Upload.t (Note: You may see one failure here; it is fixed
on bug 20727. So depends on who reaches master first.)

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 15:55:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 13:55:22 +0000
Subject: [Koha-bugs] [Bug 19633] Use alphanumeric error codes in upload
In-Reply-To: <bug-19633-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19633-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19633-70-qwgVvZ8ycV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19633

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #5)
> Ok but I would have written
> 
>   use constant UPLERR_ALREADY_EXISTS => 'UPLERR_ALREADY_EXISTS';
> instead of
>   use constant ERRCODE_1    => 'UPLERR_ALREADY_EXISTS';
> 
> or even get rid of the constant if only used once.
> 
> The goal is to make the code more readable, but when you see ERRCODE_X in
> the perl script you still do not know what it means :)

Giving in for high pressure

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 16:12:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 14:12:12 +0000
Subject: [Koha-bugs] [Bug 20886] Koha::Object::TO_JSON indiscriminately
 casting to integer
In-Reply-To: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20886-70-G1k3coEVpM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20886

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 16:13:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 14:13:24 +0000
Subject: [Koha-bugs] [Bug 20886] Koha::Object::TO_JSON indiscriminately
 casting to integer
In-Reply-To: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20886-70-tZL3Lj6dXm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20886

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 16:13:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 14:13:31 +0000
Subject: [Koha-bugs] [Bug 20886] Koha::Object::TO_JSON indiscriminately
 casting to integer
In-Reply-To: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20886-70-cHTMAP6cOf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20886

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75857&action=edit
Bug 20886: Do not cast undef to 0 (TO_JSON)

We should not cast undefined values to 0.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 16:16:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 14:16:00 +0000
Subject: [Koha-bugs] [Bug 20886] Koha::Object::TO_JSON indiscriminately
 casting to integer
In-Reply-To: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20886-70-4kiK8bID9U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20886

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Any side-effects to expect with this change?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 16:19:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 14:19:12 +0000
Subject: [Koha-bugs] [Bug 20887] New: Block immediate re-checkout on self
	check
Message-ID: <bug-20887-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20887

            Bug ID: 20887
           Summary: Block immediate re-checkout on self check
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

It would be nice if an immediate re-checkout of items on the self-checkout
station (SIP2) could be blocked.

It happens that patrons that can no longer renew items take it to the self
check to check it in and immediately check it out again. In some cases that is
not the wanted behaviour and it would be nice if we could re-checkout of items
that have been returned withhin the last x days. 

The self-check should block, on the circulation desk a nice message should be
shown.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 16:21:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 14:21:04 +0000
Subject: [Koha-bugs] [Bug 8732] Add a systempreference to allow users to
 choose to display an icon based on the marc control fields,
 or based on the koha biblio level itemtype
In-Reply-To: <bug-8732-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8732-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8732-70-SHTpI9i9eP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732

--- Comment #23 from Owen Leonard <oleonard at myacpl.org> ---
I would like to try to revive this. The merge issues don't seem very
complicated. However, I'm not sure what I should be seeing if the patch is
working. Could you attach some screenshots?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 16:30:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 14:30:00 +0000
Subject: [Koha-bugs] [Bug 20543] Use multi-core compression to speed up Koha
	backups
In-Reply-To: <bug-20543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20543-70-ziSjaHjYpA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20543

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Reducing the number of dependencies is on my long-term todo list, I am keeping
it in mind. We could add that tips to the manpage.

I am not strongly attach to it, I just wanted to get opinions on the idea. If
you all think it was a bad idea, let's add a new dependency! :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 16:37:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 14:37:26 +0000
Subject: [Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates
 23-26 (Nov 2016, May and Apr 2018)
In-Reply-To: <bug-20709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20709-70-4RyxHQA5nk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I am not sure you got my point.

This patch adds  '034', '1', 'Real World Object URI

After bug 19835 and bug 20709:
% git grep -l "'034', '1'"
installer/data/mysql/de-DE/marcflavour/marc21/mandatory/authorities_normal_marc21.sql
installer/data/mysql/de-DE/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql
installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql
installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql

We usually apply the changes done on 'en' to all other languages (not
translated), then language maintainers provide patches for the translation.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 16:47:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 14:47:52 +0000
Subject: [Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates
 23-26 (Nov 2016, May and Apr 2018)
In-Reply-To: <bug-20709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20709-70-nx4TyIZZAv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #17)
> I am not sure you got my point.
> 
> This patch adds  '034', '1', 'Real World Object URI
> 
> After bug 19835 and bug 20709:
> % git grep -l "'034', '1'"
> installer/data/mysql/de-DE/marcflavour/marc21/mandatory/
> authorities_normal_marc21.sql
> installer/data/mysql/de-DE/marcflavour/marc21/mandatory/
> marc21_framework_DEFAULT.sql
> installer/data/mysql/en/marcflavour/marc21/mandatory/
> authorities_normal_marc21.sql
> installer/data/mysql/en/marcflavour/marc21/mandatory/
> marc21_framework_DEFAULT.sql
> 
> We usually apply the changes done on 'en' to all other languages (not
> translated), then language maintainers provide patches for the translation.

That's not how we do it anymore for the frameworks. Bernardo provides po files
for translating, which is much more convenient and less error prone then
translating a gigantig sql file. So we generate the translated files from the
files in master. 

See here:
http://translate.koha-community.org/projects/marc21/

Bernardo automatically generates the files regularly and provides them here:
http://translate.koha-community.org/files/

For the frameworks it's not super bad if a field is missing, I think the new
workflow is worth it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 16:54:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 14:54:15 +0000
Subject: [Koha-bugs] [Bug 6647] Label item search should use standard
	pagination routine
In-Reply-To: <bug-6647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6647-70-1JhHnvGtSa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6647

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|cnighswonger at foundations.ed |oleonard at myacpl.org
                   |u                           |
         Depends on|                            |20641
             Status|NEW                         |ASSIGNED


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20641
[Bug 20641] Switch single-column templates to Bootstrap grid: Various, part 2
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 16:54:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 14:54:15 +0000
Subject: [Koha-bugs] [Bug 20641] Switch single-column templates to Bootstrap
 grid: Various, part 2
In-Reply-To: <bug-20641-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20641-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20641-70-AiJP6vghtc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20641

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |6647


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6647
[Bug 6647] Label item search should use standard pagination routine
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 16:59:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 14:59:13 +0000
Subject: [Koha-bugs] [Bug 6647] Label item search should use standard
	pagination routine
In-Reply-To: <bug-6647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6647-70-KFRclCw82U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6647

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 16:59:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 14:59:15 +0000
Subject: [Koha-bugs] [Bug 6647] Label item search should use standard
	pagination routine
In-Reply-To: <bug-6647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6647-70-6xWwcRiEaI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6647

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 75858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75858&action=edit
Bug 6647: Label item search should use standard pagination routine

This patch doesn't fix how pagination links are generated for the label
item search results, but it does modify the template so that the
pagination links are styled like they are on catalog search results.

To test, apply the patch and go to Tools -> Labels.

 - Open or create a label batch.
 - Click "Add items" to trigger the pop-up search window.
 - Perform a search which would return multiple results.
 - Confirm that the style of the pagination bar matches the one on the
   catalog search results page.
 - Confirm that current-page number highlighting works correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 17:00:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 15:00:37 +0000
Subject: [Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates
 23-26 (Nov 2016, May and Apr 2018)
In-Reply-To: <bug-20709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20709-70-oijBULEnVj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Fields will be missing and files will differ if language maintainers do not
provide files for their language. That sounds weird. It does not seems
difficult to provide the changes for all languages on bug 19835.

Where was the announce about this change? Where is describe the workflow? On
the koha translate list?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 17:14:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 15:14:33 +0000
Subject: [Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates
 23-26 (Nov 2016, May and Apr 2018)
In-Reply-To: <bug-20709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20709-70-HffBqqxGrk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
See first comment:
http://lists.koha-community.org/pipermail/koha-translate/2018-April/002721.html

But it's been done for a while, Bernardo might know when we started. I've
update the files a few times already. I think they are already out of sync.
Some files might also have different data because they were translted manually
and renamed/restructured/changed.

Bugzilla search:
ALL german update frameworks
bug 16601
bug 16472
bug 10964

Italian and I think ru-RU have also been updated a while ago.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 17:30:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 15:30:01 +0000
Subject: [Koha-bugs] [Bug 3030] Lost items (that are hidden) show up under
	Editions Tab
In-Reply-To: <bug-3030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3030-70-jl9K605CHa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3030

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |koha-bugs at lists.koha-commun
                   |                            |ity.org
           Hardware|PC                          |All
            Version|rel_3_0                     |master
                 CC|cookie.wolfrom at liblime.com  |

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
This is still valid.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 17:40:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 15:40:27 +0000
Subject: [Koha-bugs] [Bug 11143] Upload Patron Image only loads some images
In-Reply-To: <bug-11143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11143-70-epxAGXRjjT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11143

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 17:46:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 15:46:02 +0000
Subject: [Koha-bugs] [Bug 12328] report actions don't work in Chrome
In-Reply-To: <bug-12328-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12328-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12328-70-y49F2fMpoM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12328

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WORKSFORME

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
I can no longer reproduce this problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 17:48:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 15:48:15 +0000
Subject: [Koha-bugs] [Bug 12410] Remove useless use of cookies
In-Reply-To: <bug-12410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12410-70-6GgqKnOOZj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12410

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |koha-bugs at lists.koha-commun
                   |                            |ity.org
           Severity|normal                      |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 17:49:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 15:49:32 +0000
Subject: [Koha-bugs] [Bug 20468] Multiselect on staff article requests form
In-Reply-To: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20468-70-MwqHjQQT9p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
undefined vs null is confusing here.

Moreover cannot we display the title of the biblio in the popup?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 17:51:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 15:51:39 +0000
Subject: [Koha-bugs] [Bug 13045] not for loan items show hold option
In-Reply-To: <bug-13045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13045-70-GfSWegLBnH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13045

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 18:02:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 16:02:25 +0000
Subject: [Koha-bugs] [Bug 7335] Allow custom parameters for sorting in sql
	reports
In-Reply-To: <bug-7335-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7335-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7335-70-7NBZdidFoM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7335

Cab Vinton <bibliwho at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bibliwho at gmail.com

--- Comment #1 from Cab Vinton <bibliwho at gmail.com> ---
This is a bit kludgy, but I believe it works:

Report for patrons w/ emails:

SELECT cardnumber, surname, firstname, email, dateexpiry, dateenrolled
FROM borrowers
WHERE email IS NOT NULL AND email!= ''
ORDER BY CASE WHEN @SortOrder:=<<Search order>> = 'dateexpiry' THEN dateexpiry
              WHEN @SortOrder= 'cardnumber' THEN cardnumber
         END

Official column names have to be used rather than something more user-friendly,
but otherwise it's

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 18:02:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 16:02:39 +0000
Subject: [Koha-bugs] [Bug 7013] required format is not enforced for
	authorized values
In-Reply-To: <bug-7013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7013-70-hXLXAF05g1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7013

Cab Vinton <bibliwho at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bibliwho at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 18:03:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 16:03:12 +0000
Subject: [Koha-bugs] [Bug 7013] required format is not enforced for
	authorized values
In-Reply-To: <bug-7013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7013-70-rPhfFntRfl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7013

Cab Vinton <bibliwho at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|bibliwho at gmail.com          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 18:06:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 16:06:28 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth matchpoint no longer works after
 upgrade to 17.11
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-H12RKc06wN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

--- Comment #11 from cking at uttyler.edu ---
(In reply to Martin Renvoize from comment #10)
> Are you seeing this line triggered in your logs at all?
> 
> http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/
> Auth_with_shibboleth.pm;h=6b20511df5854a666ddde4a15b72643b9ff25556;
> hb=5f846a33abe89599fa7b9a37cb3c00632d30ec90#l111

I am not seeing that line in the log.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 18:21:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 16:21:15 +0000
Subject: [Koha-bugs] [Bug 20888] New: Allow use of boolean operator 'not' in
	item search
Message-ID: <bug-20888-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888

            Bug ID: 20888
           Summary: Allow use of boolean operator 'not' in item search
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Sometimes it's helpful to be able to exclude items from an item search, for
example 'all callnumbers starting with 9'. The item search form currently
offers 'or' and 'and', but 'not' is not an option.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 18:24:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 16:24:32 +0000
Subject: [Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates
 23-26 (Nov 2016, May and Apr 2018)
In-Reply-To: <bug-20709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20709-70-Im227tQwVB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709

--- Comment #21 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Jonathan Druart from comment #17)
> I am not sure you got my point.

May be not :)

> This patch adds  '034', '1', 'Real World Object URI
> ...
> We usually apply the changes done on 'en' to all other languages (not
> translated), then language maintainers provide patches for the translation.

Not for frameworks, or more exactly not be me.
I only check for updates/changes on EN 'default' framework, bib and auth.

Bug 10963 and Bug 10488 guarantees that you only need to add/update things once
per file, before them changes were needed on many places in the same file which
I did not do either.

But I never tried to update frameworks for other languages.

(In reply to Jonathan Druart from comment #19)
> Fields will be missing and files will differ if language maintainers do not
> provide files for their language. That sounds weird. It does not seems
> difficult to provide the changes for all languages on bug 19835.

Yes, there will be differences. But it's not easy for me to do that job.
That was the reason to introduce 'marc21' project on translation server as a
way to enable the translation of 5 sql files.

The po file for that is built in a very non standard way, and the translations
generated by an ugly script. But it's doing it's job since mid 2013.

> Where was the announce about this change? Where is describe the workflow? On
> the koha translate list?

It was made in the translation list, 5 years ago. Languages have been added
upon request. There are even languages that do not have SQL installers.

But you are quite right, there is a lack of documentation on the workflow.

Finally, I promise never to update the sql translations again until the
corresponding changes are in master :)

PS: I need to resurrect Bug 13897 or find a way to teach SQL to translate
script.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 19:23:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 17:23:52 +0000
Subject: [Koha-bugs] [Bug 19943] Koha::Biblio - Remove GetBiblioItemData
In-Reply-To: <bug-19943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19943-70-1t95tvQnvL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20889


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20889
[Bug 20889] Items marked as not for loan can be checked out
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 19:23:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 17:23:52 +0000
Subject: [Koha-bugs] [Bug 20889] New: Items marked as not for loan can be
	checked out
Message-ID: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20889

            Bug ID: 20889
           Summary: Items marked as not for loan can be checked out
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: critical
          Priority: P5 - low
         Component: Circulation
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 19943

To recreate:

1. Item type defined at item level (item-level_itypes=1)
2. Mark an item type not for loan (itemtypes.notforloan=1)
3. Checkout an item using this item type (items.itype="BK" for instance)
=> Checkout is not blocked!

I suspect
  commit 3953fdb921d7f280ffbaca813956357aa67d42ca
  Bug 19943: Remove itemtype vs itype confusion in CanBookBeIssued
to be the root of this issue. One occurrence of $item->{itemtype} has not been
replaced. In this case it refers to the biblioitem->{itemtype} value whereas we
want to use $item->{itype}. So this issue does not happen if
items.itype==biblioitem.itemtype (just in case you are not reproducing the
problem).


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943
[Bug 19943] Koha::Biblio - Remove GetBiblioItemData
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 19:24:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 17:24:03 +0000
Subject: [Koha-bugs] [Bug 20889] Items marked as not for loan can be checked
	out
In-Reply-To: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20889-70-6h158P1WtW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20889

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_18_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 19:26:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 17:26:49 +0000
Subject: [Koha-bugs] [Bug 20889] Items marked as not for loan can be checked
	out
In-Reply-To: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20889-70-2K4SStGWZX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20889

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 19:26:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 17:26:52 +0000
Subject: [Koha-bugs] [Bug 20889] Items marked as not for loan can be checked
	out
In-Reply-To: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20889-70-w9S5aGVglu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20889

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75859&action=edit
Bug 20889: Add tests - not for loan items cannot be checked out

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 19:26:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 17:26:56 +0000
Subject: [Koha-bugs] [Bug 20889] Items marked as not for loan can be checked
	out
In-Reply-To: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20889-70-EtVaiK9m8t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20889

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75860&action=edit
Bug 20889: Prevent not for loan items to be checked out

1. Item type defined at item level (item-level_itypes=1)
2. Mark an item type not for loan (itemtypes.notforloan=1)
3. Checkout an item using this item type (items.itype="BK" for instance)
=> Checkout is not blocked!

I suspect
  commit 3953fdb921d7f280ffbaca813956357aa67d42ca
  Bug 19943: Remove itemtype vs itype confusion in CanBookBeIssued
to be the root of this issue.
One occurrence of $item->{itemtype} has not been replaced.
In this case it refers to the biblioitem->{itemtype} value whereas we want to
use
$item->{itype}. So this issue does not happen if
items.itype==biblioitem.itemtype
(just in case you are not reproducing the problem).

Test plan:
Make sure not for loan items cannot be checked out

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 19:27:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 17:27:34 +0000
Subject: [Koha-bugs] [Bug 20889] Items marked as not for loan can be checked
	out
In-Reply-To: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20889-70-y35oLy5ilk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20889

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Fridolin, I would suggest you to backport the unit tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 19:37:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 17:37:45 +0000
Subject: [Koha-bugs] [Bug 15770] Number::Format issues with large numbers
In-Reply-To: <bug-15770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15770-70-sf9AL2zCge@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15770

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleisha at catalyst.net.nz

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
*** Bug 17164 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 19:37:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 17:37:45 +0000
Subject: [Koha-bugs] [Bug 17164] Software error when enrolment fee or
 reserve fee are too high (Patron categories)
In-Reply-To: <bug-17164-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17164-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17164-70-UmOvBw0Fbt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17164

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Fixed by bug 15770.

*** This bug has been marked as a duplicate of bug 15770 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 19:49:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 17:49:38 +0000
Subject: [Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber
In-Reply-To: <bug-9921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9921-70-B1Vq8ZZXDM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921

--- Comment #59 from emjhet at pa.net ---
(In reply to paxed from comment #58)
> 
> 001 alone does not guarantee uniqueness. 001 and 003 together should be
> globally unique. If 001 is changed, then 003 should be changed to match the
> org code of the system.

Indeed. That is why I referred to the original post. But as Koha has a plugin
that can be used in the 003, this field does not present a hurdle for use of
that MARC field as designed. 

The other Integrated Library Systems I have worked with did not overlay data in
the 003 field. Usually, information in that field was also automatically
transferred to the 035. Also automatically, a new number that was relevant to
our system was generated for the 001 and our institutional code was put into
the 003 field. 

Indeed, there is TRULY nothing globally unique to the 999$c. If a Koha system
permitted another Koha system to import a record in which the 999$c overlays,
there is no "003" field to designate which institution the "unique identifier"
belongs. 

This came up because I am trying to create Frameworks for my co-workers that
are not trained in cataloging but yet have to catalog. It didn't make sense
that some of our records did not have anything in the 001 field, as I was
taught that this field was essential. So I am simply trying to understand
how/why Koha differs so much from the other ILS I have used in the past and
from MARC 21 in general.

Thus, I am wondering what it is about the 999$c that permits an auto-generated
unique identifier to be created when it can not be created in the 001, and if
anything can be done to either duplicate the 999$c into the 001 or use the 001
instead of the 999$c.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 19:58:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 17:58:42 +0000
Subject: [Koha-bugs] [Bug 20889] Items marked as not for loan can be checked
	out
In-Reply-To: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20889-70-UW3kxjYboF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20889

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun  6 20:34:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 18:34:23 +0000
Subject: [Koha-bugs] [Bug 20887] Block immediate re-checkout on self check
In-Reply-To: <bug-20887-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20887-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20887-70-jYZZUf2jvu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20887

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
In some cases that is not the wanted behaviour and it would be nice if we could
_prevent_ re-checkout of items that have been returned withhin the last x days.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 01:01:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 23:01:27 +0000
Subject: [Koha-bugs] [Bug 19489] Development for fines and Fees Module -
 Detailed Description of charges in Patron Account Tab/Fines Tab
In-Reply-To: <bug-19489-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19489-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19489-70-odbCfcJAU1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489

Indranil Das Gupta <indradg at l2c2.co.in> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |indradg at l2c2.co.in

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 01:05:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 23:05:56 +0000
Subject: [Koha-bugs] [Bug 6508] Enhancement: Additional Information on the
 Fines & Charges Tab in the Patron Details of Staff Client
In-Reply-To: <bug-6508-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6508-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6508-70-IS3WfhBMfT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508

Indranil Das Gupta <indradg at l2c2.co.in> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19489

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 01:05:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 23:05:56 +0000
Subject: [Koha-bugs] [Bug 19489] Development for fines and Fees Module -
 Detailed Description of charges in Patron Account Tab/Fines Tab
In-Reply-To: <bug-19489-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19489-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19489-70-7vVDcsgOeh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489

Indranil Das Gupta <indradg at l2c2.co.in> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=6508

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 01:10:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 23:10:15 +0000
Subject: [Koha-bugs] [Bug 13652] Need the display of fine amount against
	each book
In-Reply-To: <bug-13652-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13652-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13652-70-NizgYNibJV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13652

Indranil Das Gupta <indradg at l2c2.co.in> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED
                 CC|                            |indradg at l2c2.co.in

--- Comment #3 from Indranil Das Gupta <indradg at l2c2.co.in> ---


*** This bug has been marked as a duplicate of bug 6508 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 01:10:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 23:10:15 +0000
Subject: [Koha-bugs] [Bug 6508] Enhancement: Additional Information on the
 Fines & Charges Tab in the Patron Details of Staff Client
In-Reply-To: <bug-6508-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6508-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6508-70-lgWinf7U6H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508

Indranil Das Gupta <indradg at l2c2.co.in> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vimal0212 at gmail.com

--- Comment #3 from Indranil Das Gupta <indradg at l2c2.co.in> ---
*** Bug 13652 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 01:13:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jun 2018 23:13:33 +0000
Subject: [Koha-bugs] [Bug 12960] Fee descriptions autofill with
 unnecessary/incorrect info
In-Reply-To: <bug-12960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12960-70-O7cIz1ZJcb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12960

Indranil Das Gupta <indradg at l2c2.co.in> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |indradg at l2c2.co.in

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 04:45:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 02:45:05 +0000
Subject: [Koha-bugs] [Bug 20847] Add the fields to the Batch Patron
	Modification tool
In-Reply-To: <bug-20847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20847-70-uNmkSY3EgK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20847

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |liz at catalyst.net.nz

--- Comment #1 from Liz Rea <liz at catalyst.net.nz> ---
Awesome example of a use case for this. A+!

Let's do it. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 05:05:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 03:05:25 +0000
Subject: [Koha-bugs] [Bug 14866] Make high holds work with different item
 types and number of open days
In-Reply-To: <bug-14866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14866-70-Fk6KGRLuvO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42751|0                           |1
        is obsolete|                            |

--- Comment #7 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 75861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75861&action=edit
Bug 14866: Make high holds work with different item types

This patch adds the possibility to set decreased loan periods for
high holds items in issuingrules via smart-rules.pl.

If a rule exist with a value set for a high holds item and the
decreaseLoanHighHolds syspref is active then the value of the rule
will be used instead of the syspref value.

To test:

1. Create testbranch, dump mysql as needed..

2. Apply patch

3. Update database
perl installer/data/mysql/updatedatabase.pl
misc/devel/update_dbix_class_files.pl --db_name=koha_instance
--db_user=koha_instance --db_passwd=thepassword

4. Enable decreaseLoanHighHolds sysprefs if not already active

5. Create rule for library/item in
http://your_staff_client/cgi-bin/koha/admin/smart-rules.pl
Set Decrease loan holds to your wanted value.

6. Check out an item with holds and see that the value from the rule is used
instead of the syspref

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 05:05:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 03:05:43 +0000
Subject: [Koha-bugs] [Bug 14866] Make high holds work with different item
 types and number of open days
In-Reply-To: <bug-14866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14866-70-X0z63ZbprY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58324|0                           |1
        is obsolete|                            |

--- Comment #8 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 75862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75862&action=edit
Bug 14866: Make high holds work with different item types

This patch fixes merge conflicts, fixes the indentation of the table in
smart-rules.tt and uses Koha::IssuingRules->get_effective_issuing_rule.

Keep in mind - I am sure that when the original patch for this was
written (before get_effective_issuing_rule was used), it all worked
fine. I had to add an extra line of code in my patch to get this method
to work because it was fetching the WRONG circulation rule - one that
did not have decreaseloanholds defined. I don't know if it was my patch
that is broken or the get_effective_issuing_rule method that is not
fetching the 'most specific/relevant' rule.

Sponsored-by: Region Halland

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 05:10:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 03:10:11 +0000
Subject: [Koha-bugs] [Bug 14866] Make high holds work with different item
 types and number of open days
In-Reply-To: <bug-14866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14866-70-psMtKJkXsm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75862|0                           |1
        is obsolete|                            |

--- Comment #9 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 75863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75863&action=edit
Bug 14866: [FOLLOW-UP]  Make high holds work with different item types

This patch fixes merge conflicts, fixes the indentation of the table in
smart-rules.tt and uses Koha::IssuingRules->get_effective_issuing_rule.

Keep in mind - I am sure that when the original patch for this was
written (before get_effective_issuing_rule was used), it all worked
fine. I had to add an extra line of code in my patch to get this method
to work because it was fetching the WRONG circulation rule - one that
did not have decreaseloanholds defined. I don't know if it was my patch
that is broken or the get_effective_issuing_rule method that is not
fetching the 'most specific/relevant' rule.

Sponsored-by: Region Halland

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 05:10:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 03:10:07 +0000
Subject: [Koha-bugs] [Bug 14866] Make high holds work with different item
 types and number of open days
In-Reply-To: <bug-14866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14866-70-pCRRlzCXnc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 06:00:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 04:00:30 +0000
Subject: [Koha-bugs] [Bug 17137] Omnibus: Always use SSL when referencing
 external sources
In-Reply-To: <bug-17137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17137-70-hggCsftchG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17137

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #0)
> Amazon, OpenLibrary, etc shoudl all use https if available as otherwise they
> create a mixed content error for sites using https.

Agreed. And after looking at past bugs, I don't know why we've switched between
http/https for external resources depending on whether or not Koha was on
https. Since they're external resources, there really is no harm in just using
HTTPS all the time.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 07:05:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 05:05:43 +0000
Subject: [Koha-bugs] [Bug 16653] reports/cat_issues_top.pl does not export
 "Count of checkouts" column as CSV
In-Reply-To: <bug-16653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16653-70-Tr8M9yKRsQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16653

paxed <pasi.kallinen at joensuu.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pasi.kallinen at joensuu.fi

--- Comment #1 from paxed <pasi.kallinen at joensuu.fi> ---
Encountered this today.

I guess no-one is actually using this report and saving the output to CSV.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 08:03:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 06:03:22 +0000
Subject: [Koha-bugs] [Bug 20781] 0 months is not a valid enrollment period
 and causes errors
In-Reply-To: <bug-20781-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20781-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20781-70-NNnmCgjHY4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 08:12:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 06:12:00 +0000
Subject: [Koha-bugs] [Bug 19318] Add ability to use custom file upload paths
In-Reply-To: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19318-70-s3aqgttXNC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |mirko at abunchofthings.net

--- Comment #3 from Mirko Tietgen <mirko at abunchofthings.net> ---
I tried to test, but the patch needs a rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 08:32:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 06:32:05 +0000
Subject: [Koha-bugs] [Bug 20468] Multiselect on staff article requests form
In-Reply-To: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20468-70-fiR5TNBmCA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468

--- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #18)
> undefined vs null is confusing here.
Null comes back from a cancelled prompt. And I want to differentiate between no
prompt and a cancelled prompt. I do not think it is confusing. It might need a
comment.

> Moreover cannot we display the title of the biblio in the popup?
The popup is not introduced in this report. Can we postpone that?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 08:49:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 06:49:25 +0000
Subject: [Koha-bugs] [Bug 20468] Multiselect on staff article requests form
In-Reply-To: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20468-70-CP0MlF8FeJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75846|0                           |1
        is obsolete|                            |

--- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75864&action=edit
Bug 20468: (follow-up) Cancel multiple items for same reason

The repeated prompts for cancelling multiple selected items are
confusing.
The wording is slightly adjusted. The reason is asked only once per
group of selected items.

Test plan:
Create three requests.
Select two requests and cancel (from top menu) for reason A.
Cancel third request (from item menu) for reason B.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 09:02:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 07:02:33 +0000
Subject: [Koha-bugs] [Bug 20696] Remove a few ugly "eq undef" comparisons
In-Reply-To: <bug-20696-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20696-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20696-70-3jerAtMRvM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20696

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.07.

Ugly indeed ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 09:04:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 07:04:12 +0000
Subject: [Koha-bugs] [Bug 20761] Advanced Cataloging Editor - Rancor - Some
 js files are not fetched using Asset
In-Reply-To: <bug-20761-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20761-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20761-70-rHKNVNQTHz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20761

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
         Resolution|---                         |FIXED

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 20538 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 09:10:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 07:10:49 +0000
Subject: [Koha-bugs] [Bug 19318] Add ability to use custom file upload paths
In-Reply-To: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19318-70-HIV7yOuTPk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 09:11:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 07:11:38 +0000
Subject: [Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering
 from staged file
In-Reply-To: <bug-20830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20830-70-0l0YHAKmdW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 09:12:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 07:12:20 +0000
Subject: [Koha-bugs] [Bug 20798] Client side validation for for fund
 selection prevents adding only some records to a basket
In-Reply-To: <bug-20798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20798-70-5v5XI525SW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20798

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.07.

JS code moved but change was easy to apply manually.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 09:14:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 07:14:08 +0000
Subject: [Koha-bugs] [Bug 20840] Internal Server Error when clicking on
	"Details" button
In-Reply-To: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20840-70-Gg9Uhau7o5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

--- Comment #13 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on 2696 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 09:17:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 07:17:21 +0000
Subject: [Koha-bugs] [Bug 20763] AllowPurchaseSuggestionBranchChoice
 triggers error opac-suggestions.pl is visited without logging in
In-Reply-To: <bug-20763-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20763-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20763-70-ueMpofI92e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20763

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #11 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 09:18:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 07:18:41 +0000
Subject: [Koha-bugs] [Bug 20763] AllowPurchaseSuggestionBranchChoice
 triggers error opac-suggestions.pl is visited without logging in
In-Reply-To: <bug-20763-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20763-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20763-70-gw8Dd9O5c9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20763

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

--- Comment #12 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 17829 not in 17.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 09:18:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 07:18:57 +0000
Subject: [Koha-bugs] [Bug 20706] Fix links to help files for changed file
 structure (removed numbering on files)
In-Reply-To: <bug-20706-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20706-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20706-70-cnEedznyLt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_18_05_candidate         |
         Resolution|---                         |FIXED
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 09:18:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 07:18:57 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19817-70-FOKGffBogl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817
Bug 19817 depends on bug 20706, which changed state.

Bug 20706 Summary: Fix links to help files for changed file structure (removed numbering on files)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 09:20:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 07:20:29 +0000
Subject: [Koha-bugs] [Bug 20831] (Bug 9573 follow-up) Pass id as first
 parameter instead of selector
In-Reply-To: <bug-20831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20831-70-BxF2MkkwyS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20831

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 9573 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 09:20:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 07:20:29 +0000
Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be
 write as description, not code
In-Reply-To: <bug-20806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20806-70-DzPLY50PLc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806
Bug 20806 depends on bug 20831, which changed state.

Bug 20831 Summary: (Bug 9573 follow-up) Pass id as first parameter instead of selector
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20831

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 09:22:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 07:22:04 +0000
Subject: [Koha-bugs] [Bug 20838] Search by group of libraries is broken
In-Reply-To: <bug-20838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20838-70-IlvEsPvmRS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #14 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 16735 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 09:24:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 07:24:10 +0000
Subject: [Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds
 awaiting pickup"
In-Reply-To: <bug-20724-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20724-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20724-70-Vvl4IWBGUe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
           Keywords|rel_18_05_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 09:24:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 07:24:03 +0000
Subject: [Koha-bugs] [Bug 20861] Correct EDI permissions on some pages
In-Reply-To: <bug-20861-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20861-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20861-70-7Ct10i1tEn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20861

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 09:49:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 07:49:29 +0000
Subject: [Koha-bugs] [Bug 20889] Items marked as not for loan can be checked
	out
In-Reply-To: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20889-70-sfPrnu1OL0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20889

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75860|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 75866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75866&action=edit
Bug 20889: Prevent not for loan items to be checked out

1. Item type defined at item level (item-level_itypes=1)
2. Mark an item type not for loan (itemtypes.notforloan=1)
3. Checkout an item using this item type (items.itype="BK" for instance)
=> Checkout is not blocked!

I suspect
  commit 3953fdb921d7f280ffbaca813956357aa67d42ca
  Bug 19943: Remove itemtype vs itype confusion in CanBookBeIssued
to be the root of this issue.
One occurrence of $item->{itemtype} has not been replaced.
In this case it refers to the biblioitem->{itemtype} value whereas we want to
use
$item->{itype}. So this issue does not happen if
items.itype==biblioitem.itemtype
(just in case you are not reproducing the problem).

Test plan:
Make sure not for loan items cannot be checked out

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 09:49:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 07:49:49 +0000
Subject: [Koha-bugs] [Bug 20889] Items marked as not for loan can be checked
	out
In-Reply-To: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20889-70-ClGLxu8KKc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20889

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 09:49:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 07:49:27 +0000
Subject: [Koha-bugs] [Bug 20889] Items marked as not for loan can be checked
	out
In-Reply-To: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20889-70-KIAUfHjmmC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20889

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75859|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 75865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75865&action=edit
Bug 20889: Add tests - not for loan items cannot be checked out

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 09:56:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 07:56:18 +0000
Subject: [Koha-bugs] [Bug 20875] OpacAddMastheadLibraryPulldown displays an
	empty list
In-Reply-To: <bug-20875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20875-70-U5H0MrDGtr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Needs Signoff               |Signed Off

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx Martin for catching the forgotten status change!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 10:00:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 08:00:14 +0000
Subject: [Koha-bugs] [Bug 17561] ReserveSlip needs itemnumber for item level
 holds on same biblio
In-Reply-To: <bug-17561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17561-70-ipj2pqcUgJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #31 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 10:06:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 08:06:17 +0000
Subject: [Koha-bugs] [Bug 20875] OpacAddMastheadLibraryPulldown displays an
	empty list
In-Reply-To: <bug-20875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20875-70-FEZzTvAoG9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75790|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 75867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75867&action=edit
Bug 20875: (bug 16735 follow-up) Fix library list for
OpacAddMastheadLibraryPulldown

This patch fixes a regression introduced by
  commit 2059f7d8016ab61172830e9b670279d3e28882b7
  Bug 16735: Migrate library search groups into the new hierarchical groups

It re-added code that was removed by bug 15758 (use of var BranchesLoop).

Test plan:
- Create library search groups
- Turn OpacAddMastheadLibraryPulldown on
- At the OPAC confirm that the search box with libraries and library
groups is displayed and works correctly.
- Remove the library search group
- The dropdown list should not have the optgroup tags

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 10:07:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 08:07:37 +0000
Subject: [Koha-bugs] [Bug 20875] OpacAddMastheadLibraryPulldown displays an
	empty list
In-Reply-To: <bug-20875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20875-70-ZIuBREkL49@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Simple change works as expected and doesn't break any tests.

I'd love to see an accompanying selenium (or whatever) integration test, but as
we don't yet have a clear framework for such tests I can't justifiably fail it
for not having one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 10:11:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 08:11:45 +0000
Subject: [Koha-bugs] [Bug 19453] Client side validation broken for "Fund"
	select
In-Reply-To: <bug-19453-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19453-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19453-70-ikFFO9ZGGJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19453

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
I prefer not to backport to 17.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 10:11:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 08:11:45 +0000
Subject: [Koha-bugs] [Bug 20426] Can't import all titles from a stage file
 with default values
In-Reply-To: <bug-20426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20426-70-sm8r42LmUB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426
Bug 20426 depends on bug 19453, which changed state.

Bug 19453 Summary: Client side validation broken for "Fund" select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19453

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 10:11:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 08:11:46 +0000
Subject: [Koha-bugs] [Bug 20798] Client side validation for for fund
 selection prevents adding only some records to a basket
In-Reply-To: <bug-20798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20798-70-M2vZkP3BN0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20798
Bug 20798 depends on bug 19453, which changed state.

Bug 19453 Summary: Client side validation broken for "Fund" select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19453

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 10:12:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 08:12:03 +0000
Subject: [Koha-bugs] [Bug 20426] Can't import all titles from a stage file
 with default values
In-Reply-To: <bug-20426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20426-70-hbQ5Z03fl4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 10:12:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 08:12:26 +0000
Subject: [Koha-bugs] [Bug 20798] Client side validation for for fund
 selection prevents adding only some records to a basket
In-Reply-To: <bug-20798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20798-70-egU4yRPwLl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20798

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 19453 not in 17.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 10:14:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 08:14:14 +0000
Subject: [Koha-bugs] [Bug 20827] Can't add owner to a fund
In-Reply-To: <bug-20827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20827-70-dJfVrDuiVs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20827

--- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.05.x for 17.05.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 10:14:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 08:14:36 +0000
Subject: [Koha-bugs] [Bug 19862] RoutingListAddReserves must be disabled by
	default
In-Reply-To: <bug-19862-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19862-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19862-70-Ni51mO6cOT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19862

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
           Keywords|Academy,                    |
                   |rel_18_05_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 10:14:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 08:14:47 +0000
Subject: [Koha-bugs] [Bug 20827] Can't add owner to a fund
In-Reply-To: <bug-20827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20827-70-JkS2YJxUQI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20827

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 10:16:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 08:16:34 +0000
Subject: [Koha-bugs] [Bug 20861] Correct EDI permissions on some pages
In-Reply-To: <bug-20861-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20861-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20861-70-JLpT06rqik@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20861

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.05.x for 17.05.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 10:20:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 08:20:39 +0000
Subject: [Koha-bugs] [Bug 19916] Can't search keyword or standard ID from
 Acquisitions external source / z3950
In-Reply-To: <bug-19916-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19916-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19916-70-45VGov8g3I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19916

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
             Status|Pushed to Stable            |RESOLVED

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
I choose not to backport to 17.05.x, to focus on major and +

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 10:21:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 08:21:35 +0000
Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is
	misleading
In-Reply-To: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19910-70-TOKzCMPhk3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #26 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
I choose not to backport to 17.05.x, to focus on major and +

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 10:42:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 08:42:02 +0000
Subject: [Koha-bugs] [Bug 11431] Custom notification sounds
In-Reply-To: <bug-11431-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11431-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11431-70-knth3DyDV0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 10:54:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 08:54:01 +0000
Subject: [Koha-bugs] [Bug 8685] Inventory tool fails in timeout with large
	CB files
In-Reply-To: <bug-8685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8685-70-KknuhfAo7D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685

abernaud <anne-claire.bernaudin at univ-rennes1.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anne-claire.bernaudin at univ-
                   |                            |rennes1.fr

--- Comment #16 from abernaud <anne-claire.bernaudin at univ-rennes1.fr> ---
Hello,
this is a problem for our library too (we're on Koha 16.05.11).
We'll use the workaround mentionned in Comment#14, but our IT department is not
very happy with this... However, this seems to let us upload relatively large
files of barcodes (~3000). But the upload is still very long...
We'd like to be able to upload 30 files of 3000 barcodes at the end of each
half-day of inventory. This upload is not supposed to take us a full hour (but
it will probably be the case...)

We're ready to test some improvements proposed so solve this problem !
Thanks
Anne-Claire (Rennes 1, France)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 11:14:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 09:14:46 +0000
Subject: [Koha-bugs] [Bug 20890] New: Can't locate
	Koha/Template/Plugin/String.pm error
Message-ID: <bug-20890-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20890

            Bug ID: 20890
           Summary: Can't locate Koha/Template/Plugin/String.pm error
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: mtj at kohaaloha.com
        QA Contact: testopia at bugs.koha-community.org

the full error is...

2018/06/05 18:32:52 Can't locate Koha/Template/Plugin/String.pm in @INC (you
may need to install the Koha::Template::Plugin::String module) (@INC contains:
/usr/share/koha/lib /usr/share/koha/installer /usr/share/koha/lib/installer
/etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2
/usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20
/usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20
/usr/local/lib/site_perl .) at
/usr/lib/x86_64-linux-gnu/perl5/5.20/Template/Plugins.pm line 206.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 11:37:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 09:37:56 +0000
Subject: [Koha-bugs] [Bug 16401] System preference staffClientBaseURL
 hardcoded to 'http://'
In-Reply-To: <bug-16401-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16401-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16401-70-PYkqrk5h1p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16401

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |12027


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027
[Bug 12027] Shibboleth authentication for staff client
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 11:37:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 09:37:56 +0000
Subject: [Koha-bugs] [Bug 12027] Shibboleth authentication for staff client
In-Reply-To: <bug-12027-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12027-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12027-70-l6QSVWdaOB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16401


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16401
[Bug 16401] System preference staffClientBaseURL hardcoded to 'http://'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 11:49:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 09:49:12 +0000
Subject: [Koha-bugs] [Bug 12027] Shibboleth authentication for staff client
In-Reply-To: <bug-12027-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12027-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12027-70-0mjOuJ8AjA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73152|0                           |1
        is obsolete|                            |

--- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 75868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75868&action=edit
BUG 12027 [QA Followup] - Update tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 11:50:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 09:50:11 +0000
Subject: [Koha-bugs] [Bug 20886] Koha::Object::TO_JSON indiscriminately
 casting to integer
In-Reply-To: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20886-70-lT6GAAczAT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20886

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75857|0                           |1
        is obsolete|                            |
           Assignee|jonathan.druart at bugs.koha-c |andrew.isherwood at ptfs-europ
                   |ommunity.org                |e.com
             Status|Needs Signoff               |Signed Off
                 CC|                            |andrew.isherwood at ptfs-europ
                   |                            |e.com

--- Comment #5 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 75869
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75869&action=edit
Bug 20886: (sign-off) Koha::Object::TO_JSON indiscriminately casting to integer

Works as advertised for me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 11:50:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 09:50:02 +0000
Subject: [Koha-bugs] [Bug 12027] Shibboleth authentication for staff client
In-Reply-To: <bug-12027-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12027-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12027-70-G8wkGiVcve@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027

--- Comment #34 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Another minor rebase of the last patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 11:55:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 09:55:39 +0000
Subject: [Koha-bugs] [Bug 12027] Shibboleth authentication for staff client
In-Reply-To: <bug-12027-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12027-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12027-70-0MuUMBNNMY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|18507                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18507
[Bug 18507] Shibboleth auto-provisioning - Sync
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 11:55:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 09:55:39 +0000
Subject: [Koha-bugs] [Bug 18507] Shibboleth auto-provisioning - Sync
In-Reply-To: <bug-18507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18507-70-qVdexuTurA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18507

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|12027                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027
[Bug 12027] Shibboleth authentication for staff client
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 12:16:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 10:16:08 +0000
Subject: [Koha-bugs] [Bug 20797] If an Ill request has an associated bib
 record, the detail view should contain a link to the record
In-Reply-To: <bug-20797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20797-70-3b5ABqKJ0h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797

--- Comment #16 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 75870
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75870&action=edit
Bug 20797: (follow-up) Conditionally link

We don't want to display the link to the biblio if the biblio_id is null

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 12:18:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 10:18:45 +0000
Subject: [Koha-bugs] [Bug 20797] If an Ill request has an associated bib
 record, the detail view should contain a link to the record
In-Reply-To: <bug-20797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20797-70-4rvxspos22@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797

--- Comment #17 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Can this be signed off and QA'ed in conjunction with bug 20886. With the fix
for 20886 applied, this patch now works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 12:30:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 10:30:25 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-TOoaUHhnvD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 12:30:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 10:30:14 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-JFB7UpIMot@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75854|0                           |1
        is obsolete|                            |
                 CC|                            |andrew.isherwood at ptfs-europ
                   |                            |e.com

--- Comment #28 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 75871
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75871&action=edit
Bug 20600: (sign-off) Move template JavaScript to the footer

Works great, thanks very much for that Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 12:47:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 10:47:31 +0000
Subject: [Koha-bugs] [Bug 20891] New: Lists in staff don't load when \ was
 used in the description
Message-ID: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891

            Bug ID: 20891
           Summary: Lists in staff don't load when \ was used in the
                    description
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Lists
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When someone uses \ in the description of a list, the datatable in staff won't
load and keeps processing.

Tested in 16.11

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 13:05:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 11:05:35 +0000
Subject: [Koha-bugs] [Bug 20797] If an Ill request has an associated bib
 record, the detail view should contain a link to the record
In-Reply-To: <bug-20797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20797-70-a4Yd1K03kY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Setting back to 'Needs Signoff' as it now depends on bug 20886

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 15:09:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 13:09:20 +0000
Subject: [Koha-bugs] [Bug 19524] Share patron lists between staff
In-Reply-To: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19524-70-f1bRuRjTLp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 15:09:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 13:09:23 +0000
Subject: [Koha-bugs] [Bug 19524] Share patron lists between staff
In-Reply-To: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19524-70-2AGVXG1Vk0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 75872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75872&action=edit
Bug 19524: Update database

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 15:09:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 13:09:29 +0000
Subject: [Koha-bugs] [Bug 19524] Share patron lists between staff
In-Reply-To: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19524-70-hyt8DxUgi5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 75873
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75873&action=edit
Bug 19524: Share patron lists between staff

Some libraries would like to allow arbitrary lists to be used by all
librarians with the 'manage_patron_lists' permission.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Create or find two patrons with the manage_patron_lists permission
4) Using the first patron, create two new lists, mark one of them as
   shared
5) Log in as the second patron, browse to the patron lists page
6) Note the second patron can view, add and remove patrons from
   the shared list owned by the first patron

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 15:09:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 13:09:32 +0000
Subject: [Koha-bugs] [Bug 19524] Share patron lists between staff
In-Reply-To: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19524-70-Re5zSpZKlc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 75874
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75874&action=edit
Bug 19524: Update Schema files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 15:27:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 13:27:57 +0000
Subject: [Koha-bugs] [Bug 20886] Koha::Object::TO_JSON indiscriminately
 casting to integer
In-Reply-To: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20886-70-mop3uiSuRo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20886

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 15:28:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 13:28:00 +0000
Subject: [Koha-bugs] [Bug 20886] Koha::Object::TO_JSON indiscriminately
 casting to integer
In-Reply-To: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20886-70-DyDVKUj6pu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20886

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75869|0                           |1
        is obsolete|                            |

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75875
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75875&action=edit
Bug 20886: Do not cast undef to 0 (TO_JSON)

We should not cast undefined values to 0.

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 15:28:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 13:28:28 +0000
Subject: [Koha-bugs] [Bug 20886] Koha::Object::TO_JSON indiscriminately
 casting to integer
In-Reply-To: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20886-70-xTdVW80wWo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20886

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|andrew.isherwood at ptfs-europ |jonathan.druart at bugs.koha-c
                   |e.com                       |ommunity.org
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 15:39:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 13:39:23 +0000
Subject: [Koha-bugs] [Bug 20889] Items marked as not for loan can be checked
	out
In-Reply-To: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20889-70-pw40zKlu1g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20889

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Just a description
not for loan at item type level
second time should be item level

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 15:40:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 13:40:24 +0000
Subject: [Koha-bugs] [Bug 20889] Items marked as not for loan can be checked
	out
In-Reply-To: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20889-70-8Ejius2pCe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20889

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75865|0                           |1
        is obsolete|                            |

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75876&action=edit
Bug 20889: Add tests - not for loan items cannot be checked out

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 15:40:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 13:40:28 +0000
Subject: [Koha-bugs] [Bug 20889] Items marked as not for loan can be checked
	out
In-Reply-To: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20889-70-Fo2pNrTD4B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20889

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75866|0                           |1
        is obsolete|                            |

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75877&action=edit
Bug 20889: Prevent not for loan items to be checked out

1. Item type defined at item level (item-level_itypes=1)
2. Mark an item type not for loan (itemtypes.notforloan=1)
3. Checkout an item using this item type (items.itype="BK" for instance)
=> Checkout is not blocked!

I suspect
  commit 3953fdb921d7f280ffbaca813956357aa67d42ca
  Bug 19943: Remove itemtype vs itype confusion in CanBookBeIssued
to be the root of this issue.
One occurrence of $item->{itemtype} has not been replaced.
In this case it refers to the biblioitem->{itemtype} value whereas we want to
use
$item->{itype}. So this issue does not happen if
items.itype==biblioitem.itemtype
(just in case you are not reproducing the problem).

Test plan:
Make sure not for loan items cannot be checked out

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 15:40:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 13:40:21 +0000
Subject: [Koha-bugs] [Bug 20889] Items marked as not for loan can be checked
	out
In-Reply-To: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20889-70-8UFg5Vnl1V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20889

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 15:40:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 13:40:53 +0000
Subject: [Koha-bugs] [Bug 20889] Items marked as not for loan can be checked
	out
In-Reply-To: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20889-70-9ZerkuhzVD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20889

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 15:41:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 13:41:32 +0000
Subject: [Koha-bugs] [Bug 20889] Items marked as not for loan can be checked
	out
In-Reply-To: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20889-70-Cux9hOk2Ie@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20889

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 15:50:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 13:50:11 +0000
Subject: [Koha-bugs] [Bug 19524] Share patron lists between staff
In-Reply-To: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19524-70-PBnbyr8mI1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |sandboxes at biblibre.com

--- Comment #4 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by George Williams <george at nekls.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 15:50:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 13:50:32 +0000
Subject: [Koha-bugs] [Bug 19524] Share patron lists between staff
In-Reply-To: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19524-70-6wRCuSwuB5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75872|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 15:50:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 13:50:37 +0000
Subject: [Koha-bugs] [Bug 19524] Share patron lists between staff
In-Reply-To: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19524-70-bPlu2o7Hfx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75873|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 15:50:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 13:50:43 +0000
Subject: [Koha-bugs] [Bug 19524] Share patron lists between staff
In-Reply-To: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19524-70-q7WDtQS4nv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75874|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 15:50:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 13:50:56 +0000
Subject: [Koha-bugs] [Bug 19524] Share patron lists between staff
In-Reply-To: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19524-70-lEEdGXUvEh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524

--- Comment #6 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 75879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75879&action=edit
Bug 19524: Share patron lists between staff

Some libraries would like to allow arbitrary lists to be used by all
librarians with the 'manage_patron_lists' permission.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Create or find two patrons with the manage_patron_lists permission
4) Using the first patron, create two new lists, mark one of them as
   shared
5) Log in as the second patron, browse to the patron lists page
6) Note the second patron can view, add and remove patrons from
   the shared list owned by the first patron

Signed-off-by: George Williams <george at nekls.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 15:50:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 13:50:59 +0000
Subject: [Koha-bugs] [Bug 19524] Share patron lists between staff
In-Reply-To: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19524-70-TCPGJ285Kg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524

--- Comment #7 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 75880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75880&action=edit
Bug 19524: Update Schema files

Signed-off-by: George Williams <george at nekls.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 15:50:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 13:50:52 +0000
Subject: [Koha-bugs] [Bug 19524] Share patron lists between staff
In-Reply-To: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19524-70-xfIJzQJhf0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524

--- Comment #5 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 75878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75878&action=edit
Bug 19524: Update database

Signed-off-by: George Williams <george at nekls.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 15:53:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 13:53:06 +0000
Subject: [Koha-bugs] [Bug 20892] New: wrong basketgroup link in histsearch.pl
Message-ID: <bug-20892-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20892

            Bug ID: 20892
           Summary: wrong basketgroup link in histsearch.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

When searching an order, histsearch.pl page, you see if exists the backetgroup
as a link.
This link is composed of "basketgroup.pl?booksellerid=xxx", it must also
contain "basketgroupid=xxx" and "opa=add".

See Bug 11429.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 15:53:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 13:53:18 +0000
Subject: [Koha-bugs] [Bug 20892] Wrong basketgroup link in histsearch.pl
In-Reply-To: <bug-20892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20892-70-0NDq7sKEei@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20892

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|wrong basketgroup link in   |Wrong basketgroup link in
                   |histsearch.pl               |histsearch.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 15:53:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 13:53:30 +0000
Subject: [Koha-bugs] [Bug 20892] Wrong basketgroup link in histsearch.pl
In-Reply-To: <bug-20892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20892-70-pF9FNstn9T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20892

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co
                   |ity.org                     |m
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 15:53:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 13:53:59 +0000
Subject: [Koha-bugs] [Bug 20892] Wrong basketgroup link in histsearch.pl
In-Reply-To: <bug-20892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20892-70-dBp729ZukQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20892

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20810,
                   |                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=11870,
                   |                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=11429

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 15:53:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 13:53:59 +0000
Subject: [Koha-bugs] [Bug 20810] Add filters and links in basketgroups page
In-Reply-To: <bug-20810-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20810-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20810-70-q2EhAtqOYS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20810

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20892

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 15:53:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 13:53:59 +0000
Subject: [Koha-bugs] [Bug 11870] Add more informations to histsearch.pl
	results
In-Reply-To: <bug-11870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11870-70-enCMhX2biD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20892

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 15:53:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 13:53:59 +0000
Subject: [Koha-bugs] [Bug 11429] Add a link to basketgroup in basket detail
	page
In-Reply-To: <bug-11429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11429-70-n3c3QPKn7y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11429

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20892

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 16:01:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 14:01:50 +0000
Subject: [Koha-bugs] [Bug 20892] Wrong basketgroup link in histsearch.pl
In-Reply-To: <bug-20892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20892-70-DVskTjkALk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20892

--- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 75881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75881&action=edit
Bug 20892: Correct basketgroup link in histsearch.pl

When searching an order, histsearch.pl page, you see if exists the backetgroup
as a link.
This link is composed of "basketgroup.pl?booksellerid=xxx", it must also
contain "basketgroupid=xxx" and "opa=add".

See Bug 11429 for example.

Test plan :
1) Create an order in a basket and add it to a basketgroup
2) Search for this order, you get to page histsearch.pl
3) Check clicking on basketgroup id leads to basketgroup details page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 16:01:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 14:01:47 +0000
Subject: [Koha-bugs] [Bug 20892] Wrong basketgroup link in histsearch.pl
In-Reply-To: <bug-20892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20892-70-IyAWsA8kX7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20892

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 16:02:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 14:02:50 +0000
Subject: [Koha-bugs] [Bug 20893] New: batchRebuildItemsTables.pl has
	incorrect parameter
Message-ID: <bug-20893-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20893

            Bug ID: 20893
           Summary: batchRebuildItemsTables.pl has incorrect parameter
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

umm...biblionumber only has one m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 16:05:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 14:05:05 +0000
Subject: [Koha-bugs] [Bug 20893] batchRebuildItemsTables.pl has incorrect
	parameter
In-Reply-To: <bug-20893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20893-70-kEbDIoKHLt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20893

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 16:05:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 14:05:07 +0000
Subject: [Koha-bugs] [Bug 20893] batchRebuildItemsTables.pl has incorrect
	parameter
In-Reply-To: <bug-20893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20893-70-w98ufh31iB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20893

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 75882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75882&action=edit
Bug 20893: batchRebuildItemsTables.pl has incorrect parameter

To test:
1 - run batchRebuildItemsTables.pl with a valid biblionumber
   perl /usr/share/koha/bin/batchRebuildItemsTables.pl --where
biblio.biblionumber=38483  -c
2 - Note it says 'undefined biblionumber
3 - Apply patch
4 - Do it again
5 - It works!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 16:06:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 14:06:17 +0000
Subject: [Koha-bugs] [Bug 20886] Koha::Object::TO_JSON indiscriminately
 casting to integer
In-Reply-To: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20886-70-ujgUaCw0TV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20886

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
We need Tomas's stamp on this one

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 16:10:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 14:10:44 +0000
Subject: [Koha-bugs] [Bug 8685] Inventory tool fails in timeout with large
	CB files
In-Reply-To: <bug-8685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8685-70-CTJzUPjTj6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to abernaud from comment #16)
> Hello,
> this is a problem for our library too (we're on Koha 16.05.11).
> We'll use the workaround mentionned in Comment#14, but our IT department is
> not very happy with this... However, this seems to let us upload relatively
> large files of barcodes (~3000). But the upload is still very long...
> We'd like to be able to upload 30 files of 3000 barcodes at the end of each
> half-day of inventory. This upload is not supposed to take us a full hour
> (but it will probably be the case...)
> 
> We're ready to test some improvements proposed so solve this problem !
> Thanks
> Anne-Claire (Rennes 1, France)

Hi Anne-Claire,
FYI there is a performance patch for the inventory (bug 19023) that is not part
of 16.05.x
I can take a look but I will need numbers with the last Koha version under a
Plack setup

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 16:12:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 14:12:30 +0000
Subject: [Koha-bugs] [Bug 8685] Inventory tool fails in timeout with large
	CB files
In-Reply-To: <bug-8685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8685-70-GXryaVA6lW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #17)
> FYI there is a performance patch for the inventory (bug 19023) that is not
> part of 16.05.x

Hum, forget that, bug 19023 fixed performance issues caused by bug 17249, which
is not in 16.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 16:16:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 14:16:30 +0000
Subject: [Koha-bugs] [Bug 20886] Koha::Object::TO_JSON indiscriminately
 casting to integer
In-Reply-To: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20886-70-KJOPW187aU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20886

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75875|0                           |1
        is obsolete|                            |

--- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 75883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75883&action=edit
Bug 20886: Do not cast undef to 0 (TO_JSON)

We should not cast undefined values to 0.

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
This was a bug I introduced. I think the fix is right, and if something
gets broken for this, it means it was making the wrong assumptions on
the data.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 16:30:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 14:30:50 +0000
Subject: [Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates
 23-26 (Nov 2016, May and Apr 2018)
In-Reply-To: <bug-20709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20709-70-z3tVXeLpjN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 16:30:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 14:30:57 +0000
Subject: [Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates
 23-26 (Nov 2016, May and Apr 2018)
In-Reply-To: <bug-20709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20709-70-KiEmNDn9tF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75386|0                           |1
        is obsolete|                            |
  Attachment #75387|0                           |1
        is obsolete|                            |

--- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75884&action=edit
Bug 20709: Update GERMAN MARC frameworks to Updates 23+24+25 (Nov 2016, May and
Dec 2017)

Translation of bibliographic and authority frameworks can be done
using translate.koha-community.org.

Updated and translated files will then be provided for download.

See:
http://lists.koha-community.org/pipermail/koha-translate/2018-April/002721.html

To test:
- Verify SQL is correct and frameworks load without problem

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 16:31:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 14:31:02 +0000
Subject: [Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates
 23-26 (Nov 2016, May and Apr 2018)
In-Reply-To: <bug-20709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20709-70-T48fDdCjJX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709

--- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75885&action=edit
Bug 20709: (follow-up) Update GERMAN MARC frameworks to Update 26 (April 2018)

A follow-up in line with bug 20710.

Again, the files used here have been generated automatically
from the po files on translate.koha-community.org.

To test:
- Make sure the de-DE installer can install all mandatory files cleanly.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Tested using de-DE installer, all files load Ok
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 16:39:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 14:39:16 +0000
Subject: [Koha-bugs] [Bug 20885] Transferring an item on hold results in
 bypassing restrictions,
 actually doing the transfer and can be piled up if repeated
In-Reply-To: <bug-20885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20885-70-gTFyNdzgFJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20885

--- Comment #1 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
A librarian confirmed that the test plan isn't bugus.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 16:49:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 14:49:09 +0000
Subject: [Koha-bugs] [Bug 16653] reports/cat_issues_top.pl does not export
 "Count of checkouts" column as CSV
In-Reply-To: <bug-16653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16653-70-S3QWbEqeqJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16653

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75886&action=edit
Bug 16653: Display number of checkouts when exporting 'Most-circulated items'
as CSV

reports/cat_issues_top.pl does not export "Count of checkouts" column as CSV

To replicate:

1/ Make sure that test instance has circulation in a given date range
2/ Go to Home ? Reports ? Most-circulated items
3/ Select a date range
4/ Select 'To screen into the browser' radio button, click submit.
5/ Note that Columns 'Rank/Biblioitemnumbers', 'Global' and 'Count of
checkouts' appear in screen output.
6/ Click the browser's back button
7/ Change output to 'To a file', click submit.

Without this patch:
the columns "100/", "Global" and "Total" are exported to the CSV file.
"100/" contains the rank, "Global" is still global, and the "Total" column is
empty.

With this patch patch applied, the last column is filled and the "Total" line
is removed

(This script is really dirty)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 16:49:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 14:49:05 +0000
Subject: [Koha-bugs] [Bug 16653] reports/cat_issues_top.pl does not export
 "Count of checkouts" column as CSV
In-Reply-To: <bug-16653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16653-70-Gcz3cgwRBW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16653

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 16:49:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 14:49:35 +0000
Subject: [Koha-bugs] [Bug 16653] reports/cat_issues_top.pl does not export
 "Count of checkouts" column as CSV
In-Reply-To: <bug-16653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16653-70-xuFVaBKXNq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16653

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 16:53:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 14:53:42 +0000
Subject: [Koha-bugs] [Bug 19687] Recent upgrade to 17.05.04.000
 bulkmarcimport started to fail
In-Reply-To: <bug-19687-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19687-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19687-70-uSHO2PVl4H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687

--- Comment #1 from Ian Bays <ian.bays at ptfs-europe.com> ---
Also the command line commit (after stage) has similar issues:

Undefined subroutine &C4::Items::TransformMarcToKoha called at
/usr/share/koha/lib/C4/Items.pm line 243.

/usr/share/koha/bin/commit_file.pl --batch-number 5
... importing MARC records -- please wait
Undefined subroutine &C4::Items::ModZebra called at
/usr/share/koha/lib/C4/Items.pm line 302.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 17:01:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 15:01:12 +0000
Subject: [Koha-bugs] [Bug 20890] Can't locate Koha/Template/Plugin/String.pm
	error
In-Reply-To: <bug-20890-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20890-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20890-70-w8PV0wtFns@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20890

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
More context please...

The only relevant occurrences returned by `git grep -i "use String"` would be:

koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc:[% USE String %]


Which mean you are missing something obvious :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 17:20:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 15:20:16 +0000
Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used
 in the description
In-Reply-To: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20891-70-rnidIpaU9z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 17:20:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 15:20:19 +0000
Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used
 in the description
In-Reply-To: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20891-70-P2c5BcaiUB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75887&action=edit
Bug 20891: Escape list's names in JSON

When someone uses \ in the description of a list, the datatable in staff
won't load and keeps processing.

Test plan:
- Create a list named "<script>alert('hola');</script>"
- Create another list named "k\o\h\a"
- Hit /cgi-bin/koha/virtualshelves/shelves.pl

=> Without this patch the lists will not be displayed, JSON is
malformated
=> With this patch everything is ok

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 17:21:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 15:21:05 +0000
Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used
 in the description
In-Reply-To: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20891-70-0bzwCqiAbu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 17:58:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 15:58:05 +0000
Subject: [Koha-bugs] [Bug 20894] New: Feature request: pass barcode width
 and height as parameters to /svc/barcode
Message-ID: <bug-20894-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20894

            Bug ID: 20894
           Summary: Feature request: pass barcode width and height as
                    parameters to /svc/barcode
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Web services
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

/svc/barcode does not currently accept width and height parameters, even though
GD::Barcode does. We should allow these to be passed in.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 18:03:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 16:03:45 +0000
Subject: [Koha-bugs] [Bug 20894] Feature request: pass barcode width and
 height as parameters to /svc/barcode
In-Reply-To: <bug-20894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20894-70-ss939jQDh5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20894

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20676

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 18:03:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 16:03:45 +0000
Subject: [Koha-bugs] [Bug 20676] svc/barcode should allow barcode to be
 printed without text
In-Reply-To: <bug-20676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20676-70-cYcTVQn7mC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20894

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 18:48:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 16:48:55 +0000
Subject: [Koha-bugs] [Bug 16881] Apply KohaTable and ColVis plugin on
 MARCdetail's items table
In-Reply-To: <bug-16881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16881-70-sDsoq18pp7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com

--- Comment #14 from Joy Nelson <joy at bywatersolutions.com> ---
Would this include allowing users to change the order in which the columns
display?  i.e. callnumber followed by enumeration followed by barcode, etc...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 18:56:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 16:56:45 +0000
Subject: [Koha-bugs] [Bug 20895] New: Cache for authorized values is not
	flushed
Message-ID: <bug-20895-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20895

            Bug ID: 20895
           Summary: Cache for authorized values is not flushed
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: major
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 18:59:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 16:59:55 +0000
Subject: [Koha-bugs] [Bug 16881] Apply KohaTable and ColVis plugin on
 MARCdetail's items table
In-Reply-To: <bug-16881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16881-70-wAPgNxXaWN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881

--- Comment #15 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Joy Nelson from comment #14)
> Would this include allowing users to change the order in which the columns
> display?

No, it only allows for the showing or hiding columns in place.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 19:09:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 17:09:22 +0000
Subject: [Koha-bugs] [Bug 20896] New: Move Serial enumeration to the right
	of callnumber
Message-ID: <bug-20896-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20896

            Bug ID: 20896
           Summary: Move Serial enumeration to the right of callnumber
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: joy at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Serial Enumeration is typically read together with the item's callnumber.  In
the staff side, serial enumeration is separated from the callnumber by status,
last seen and barcode columns.  It would be best if it was directly to the
right of the callnumber column.  The OPAC does show the callnumber and volume
(enumeration) side by side.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 19:11:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 17:11:40 +0000
Subject: [Koha-bugs] [Bug 20895] Cache for authorized values is not flushed
In-Reply-To: <bug-20895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20895-70-I70LKTbKDO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20895

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
It's flushed after 5 sec. The tests I was writing were wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 19:46:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 17:46:51 +0000
Subject: [Koha-bugs] [Bug 20897] New: Add generic cronjob to run plugins
 with a 'cronjob' method
Message-ID: <bug-20897-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20897

            Bug ID: 20897
           Summary: Add generic cronjob to run plugins with a 'cronjob'
                    method
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

Sometimes there are ad-hoc cronjobs that need to be setup for a site, or there
are plugins that need some regular tasks done.

I was thinking an easy solution might be to package a generic cronjob into koha
that would run daily (or whenever) to check for plugins with a cronjob method.

The plugins could allow for configuration of the job in their configure method
so that users could have control over some jobs. Could be used for emailing
reports or other things that might benefit from a user facing solution.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 20:22:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 18:22:03 +0000
Subject: [Koha-bugs] [Bug 12500] In opac-detail-view,
 "Browse results" shows indexes from the beginning upon hovering
 over the last index.
In-Reply-To: <bug-12500-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12500-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12500-70-IyiJQXjI5D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12500

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20898

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 20:22:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 18:22:03 +0000
Subject: [Koha-bugs] [Bug 20898] New: Replace OPAC detail's results browser
 with non-JavaScript version
Message-ID: <bug-20898-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20898

            Bug ID: 20898
           Summary: Replace OPAC detail's results browser with
                    non-JavaScript version
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

Created attachment 75888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75888&action=edit
Screenshot of the proposed change

The HTML generated by the OPAC detail page's results browser (enabled by the 
OpacBrowseResults system preference) could be easily done in the HTML. This
would make it easier to understand and debug, and provide the possibility of
having it work without JavaScript.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 21:25:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 19:25:42 +0000
Subject: [Koha-bugs] [Bug 20898] Replace OPAC detail's results browser with
 non-JavaScript version
In-Reply-To: <bug-20898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20898-70-hIRKTeUAUD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20898

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 75889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75889&action=edit
Wanted: help adding pagination to the pagination

Ideally the numbered links should have a forward and back as mocked up in this
screenshot. Clicking the "back" link in this example would take you to results
21-40. However, I don't know how to accomplish it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 22:03:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 20:03:34 +0000
Subject: [Koha-bugs] [Bug 19016] Add a script to fix corrupted data
In-Reply-To: <bug-19016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19016-70-Gv0aoWLOCX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19016

matthew.charlesworth at hekima.ac.ke changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |matthew.charlesworth at hekima
                   |                            |.ac.ke

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun  7 23:46:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 21:46:05 +0000
Subject: [Koha-bugs] [Bug 20897] Add generic cronjob to run plugins with a
 'cronjob' method
In-Reply-To: <bug-20897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20897-70-ICMJIs4cs1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20897

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 01:24:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jun 2018 23:24:07 +0000
Subject: [Koha-bugs] [Bug 20528] Remove the items tab from the detailed
 bibliographic view
In-Reply-To: <bug-20528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20528-70-IQLuq4eaUS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20528

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |liz at catalyst.net.nz

--- Comment #13 from Liz Rea <liz at catalyst.net.nz> ---
Maybe the items tab page really just needs a design refresh. Will have a think
about that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 05:23:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 03:23:42 +0000
Subject: [Koha-bugs] [Bug 20899] New: Patron name not showing on
	issuehistory.pl
Message-ID: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899

            Bug ID: 20899
           Summary: Patron name not showing on issuehistory.pl
 Change sponsored?: ---
           Product: Koha
           Version: 18.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: liz at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Even with the prefs set to show the name, the name doesn't seem to be showing
here since the feature for groups was pushed. 

To replicate: 

Issue an item, go to the biblio, click the circulation history for this tab.
Note that the patron's name is not showing here.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 07:18:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 05:18:19 +0000
Subject: [Koha-bugs] [Bug 20685] Modify letter template does not render
	correctly
In-Reply-To: <bug-20685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20685-70-8IDip6nDrL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20685

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 07:51:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 05:51:54 +0000
Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used
 in the description
In-Reply-To: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20891-70-Gf3m3J8Z5w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75887|0                           |1
        is obsolete|                            |

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75890&action=edit
Bug 20891: Escape list's names in JSON

When someone uses \ in the description of a list, the datatable in staff
won't load and keeps processing.

Test plan:
- Create a list named "<script>alert('hola');</script>"
- Create another list named "k\o\h\a"
- Hit /cgi-bin/koha/virtualshelves/shelves.pl

=> Without this patch the lists will not be displayed, JSON is
malformated
=> With this patch everything is ok

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 07:51:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 05:51:51 +0000
Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used
 in the description
In-Reply-To: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20891-70-NIeRsN2o5C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 07:52:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 05:52:39 +0000
Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used
 in the description
In-Reply-To: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20891-70-wTAzn4mNPc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Combining SO and QA for trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 08:24:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 06:24:59 +0000
Subject: [Koha-bugs] [Bug 19524] Share patron lists between staff
In-Reply-To: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19524-70-KZmN0yRFGs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 08:25:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 06:25:03 +0000
Subject: [Koha-bugs] [Bug 19524] Share patron lists between staff
In-Reply-To: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19524-70-nv9OTw8UNL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75878|0                           |1
        is obsolete|                            |

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75891&action=edit
Bug 19524: Update database

Signed-off-by: George Williams <george at nekls.org>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 08:25:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 06:25:08 +0000
Subject: [Koha-bugs] [Bug 19524] Share patron lists between staff
In-Reply-To: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19524-70-uhTgNb6Lbl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75879|0                           |1
        is obsolete|                            |

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75892&action=edit
Bug 19524: Share patron lists between staff

Some libraries would like to allow arbitrary lists to be used by all
librarians with the 'manage_patron_lists' permission.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Create or find two patrons with the manage_patron_lists permission
4) Using the first patron, create two new lists, mark one of them as
   shared
5) Log in as the second patron, browse to the patron lists page
6) Note the second patron can view, add and remove patrons from
   the shared list owned by the first patron

Signed-off-by: George Williams <george at nekls.org>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 08:25:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 06:25:13 +0000
Subject: [Koha-bugs] [Bug 19524] Share patron lists between staff
In-Reply-To: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19524-70-sqX0CGt1Rc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75880|0                           |1
        is obsolete|                            |

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75893&action=edit
Bug 19524: Update Schema files

Signed-off-by: George Williams <george at nekls.org>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 08:25:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 06:25:49 +0000
Subject: [Koha-bugs] [Bug 19524] Share patron lists between staff
In-Reply-To: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19524-70-fkncxCcaiU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 08:48:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 06:48:21 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-KuvJRAcTIz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #92 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA: Revisiting this one again

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 08:52:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 06:52:31 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-4GinTvv8pc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #93 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75894&action=edit
Bug 20271: (QA follow-up) Additional about cleanup

Still found references to biblios and items in script and template.

Test plan:
Check about page again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 09:01:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 07:01:23 +0000
Subject: [Koha-bugs] [Bug 20393] Remove redundant 'koha.psgi' and
	'plackup.sh' files
In-Reply-To: <bug-20393-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20393-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20393-70-QhfUNq3WV8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20393

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73392|0                           |1
        is obsolete|                            |

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 75895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75895&action=edit
Bug 20393: Remove redundant 'koha.psgi' and 'plackup.sh' files

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 09:01:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 07:01:27 +0000
Subject: [Koha-bugs] [Bug 20393] Remove redundant 'koha.psgi' and
	'plackup.sh' files
In-Reply-To: <bug-20393-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20393-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20393-70-AJbSxFK19c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20393

--- Comment #9 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 75896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75896&action=edit
Bug 20393: (QA follow-up) Remove only occurence of misc/plack/koha.psgi

Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 09:01:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 07:01:37 +0000
Subject: [Koha-bugs] [Bug 20393] Remove redundant 'koha.psgi' and
	'plackup.sh' files
In-Reply-To: <bug-20393-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20393-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20393-70-ez5VzWbL5X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20393

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 09:49:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 07:49:08 +0000
Subject: [Koha-bugs] [Bug 9082] option to notify librarians that i prefer
	phone calls
In-Reply-To: <bug-9082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9082-70-uGMSseacSw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9082

DAVID <kcclibrary2018 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kcclibrary2018 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 09:52:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 07:52:13 +0000
Subject: [Koha-bugs] [Bug 15701] Port Koha::Contrib::Tamil koha-cloud into
	Koha code base
In-Reply-To: <bug-15701-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15701-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15701-70-UQilST5IGO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15701

DAVID <kcclibrary2018 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kcclibrary2018 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 09:55:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 07:55:19 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-E43f15D7nh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75347|0                           |1
        is obsolete|                            |

--- Comment #94 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75897&action=edit
Bug 20271: (QA follow-up): rename to deleted_on and various fixes

- renamed deleted_at => deleted_on
- removed failing sql in t/db_dependent/OAI/Server.t
- removed deprecated autoincrement checks in about.pl
- fixed errors in catalogue_stats.tt and catalogue_stats.pl

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Removed the DBIx schema changes. Please keep them separated.
We missed changes for Biblioitem btw. Adding them in follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 09:55:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 07:55:25 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-a4SmfLPeNa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #95 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75898&action=edit
Bug 20271: (QA follow-up) DBIx schema changes

Please separate these changes from the other patches.
Note that Biblioitem was not in the last set of changes too.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 09:55:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 07:55:30 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-SCAfKcZyeR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75894|0                           |1
        is obsolete|                            |

--- Comment #96 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75899
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75899&action=edit
Bug 20271: (QA follow-up) Additional about cleanup

Still found references to biblios and items in script and template.

Test plan:
Check about page again.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 09:55:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 07:55:51 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-PpC5wMuOJY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #97 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Not ready yet !

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 09:55:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 07:55:47 +0000
Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be
 forbidden in list context
In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19809-70-NJYxJzwP4o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Marcel de Rooy from comment #4)
> My first feeling is that if we allow list context, we should return an empty
> list instead of undef. It would fix your if( @a ) test since  @a==0.
This doesn't need to be fixed. Empty list and undef both evaluate to a false
value in this context.

> But what would pop up again? Constructions like the one in Objects.t:
> my $patrons = {
>         foo => Koha::Patrons->find('foo'),
>         bar => 'baz',
> };
> This would generate "Odd number of elements in anonymous hash" warnings and
> mixup of hash keys and values. So we should have to add scalars again in the
> parameter hashes.
I believe that is the main reason why calls in list context were forbidden in
the first place. But this problem disappear if 'find' returns undef instead of
an empty list. 

> So the question actually becomes: Where do we want to add scalars?
Nowhere! Because we don't need to :-)

IMO 'find' is a method that should return one, only one, and always one result.
And this should not depend on the calling context.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 09:58:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 07:58:05 +0000
Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be
 forbidden in list context
In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19809-70-gDRzzaJCxT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
... and also DBIx::Class::ResultSet::find returns undef in list context. I
believe Koha::Objects::find should have the same behaviour.

https://metacpan.org/pod/DBIx::Class::ResultSet#find

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 09:58:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 07:58:14 +0000
Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be
 forbidden in list context
In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19809-70-AsXJn5tgUJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 10:02:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 08:02:35 +0000
Subject: [Koha-bugs] [Bug 20151] Search is broken when stemming has no
	language
In-Reply-To: <bug-20151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20151-70-SoFyHwnExo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20151

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #3 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to jmbroust from comment #2)
> Sorry, I can't reproduce the problem on sandbox 8.
> One point on test plan needs an explanation : 
> QueryAutoTruncate must be turned to 'automaticaly' or to "only if * is
> added' ?

2) Disable system preference QueryAutoTruncate
I mean "only if * is added"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 10:04:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 08:04:29 +0000
Subject: [Koha-bugs] [Bug 13920] API authentication system - proposal
In-Reply-To: <bug-13920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13920-70-HBvDL4tzHT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13920

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #32 from Julian Maurice <julian.maurice at biblibre.com> ---
Now that bug 20402 is in master, this can be closed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 10:26:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 08:26:44 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-Bcat412mwo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74276|0                           |1
        is obsolete|                            |

--- Comment #115 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 75900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75900&action=edit
Bug 12395: Save order line's creator

New MySQL column: aqorders.createdby

Creator's name is displayed on order's receive pages (acqui/orderreceive.pl
and acqui/parcel.pl)

On acqui/orderreceive.pl it replace the name of basket's creator
On acqui/parcel.pl, to avoid adding more data in the table of pending
orders, it is shown in a popup like MARC and Card views

Test plan:
1/ Run updatedatabase.pl
2/ Create a new order and go to the receipt page (acqui/parcel.pl)
3/ Click on "Order" link in column "More" (previously "View record")
4/ A javascript popup should appear with your name in it. Close the
popup.
5/ Click on "Receive" link
6/ Your name should appear in front of "Created by" label, to the right
of the page.

Patch updated with use of atomic update.

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 10:26:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 08:26:51 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-CXLoXFlw36@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74277|0                           |1
        is obsolete|                            |

--- Comment #116 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 75901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75901&action=edit
Bug 12395: Add unit test to check created_by is correctly set

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>
Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 10:26:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 08:26:56 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-3ztVOjEbTT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74278|0                           |1
        is obsolete|                            |

--- Comment #117 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 75902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75902&action=edit
Bug 12395: Display created_by even if firstname is missing on receiving

On receiving orders, "no name" was displayed if the firstname of creator
was not filled.
The surname should be displayed.

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>
Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 10:27:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 08:27:03 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-bbOlCsYvyR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74279|0                           |1
        is obsolete|                            |

--- Comment #118 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 75903
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75903&action=edit
Bug 12395: Make received orders table consistent with pending orders table

(links of More column)

Also change "Created by" with "Ordered by" in receive page.

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 10:27:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 08:27:08 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-GIKtVPppcG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74280|0                           |1
        is obsolete|                            |

--- Comment #119 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 75904
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75904&action=edit
Bug 12395: QA follow-up - Add class/id to body tag

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 10:27:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 08:27:14 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-bmw6cgmye8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74281|0                           |1
        is obsolete|                            |

--- Comment #120 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 75905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75905&action=edit
Bug 12395: Use standard <fieldset> + <ol> markup for showorder.tt

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 10:27:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 08:27:20 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-i6devAqcZA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74282|0                           |1
        is obsolete|                            |

--- Comment #121 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 75906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75906&action=edit
Bug 12395: (QA follow-up) Change wording for consistency and fix use CGI;

Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 10:27:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 08:27:26 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-EF7jij1frx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #122 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 75907
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75907&action=edit
Bug 12395: Add FK constraint and use patron-title.inc

Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 10:27:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 08:27:54 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-bb3Yr3awQ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #123 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Jonathan Druart from comment #114)
> 2. Why not a foreign key on aqorders.created_by (with on delete set null)?
> 
> 3. orderreceive.tt and showorder.tt must use patron-title.inc

Fixed in the last patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 10:34:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 08:34:52 +0000
Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page,
 and new column aqbasketgroups.closeddate
In-Reply-To: <bug-11708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11708-70-47i4RLFR2K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75003|0                           |1
        is obsolete|                            |

--- Comment #242 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 75908
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75908&action=edit
Bug 11708: Change aqbasketgroups.closed to closeddate

Signed-off-by: juliette levast <juliette.levast at iepg.fr>
Signed-off-by: Paola Rossi <paola.rossi at cineca.it>
Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 10:35:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 08:35:03 +0000
Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page,
 and new column aqbasketgroups.closeddate
In-Reply-To: <bug-11708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11708-70-7KLtfjHl2h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75004|0                           |1
        is obsolete|                            |

--- Comment #243 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 75909
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75909&action=edit
Bug 11708: New page for basket groups

This patch moves the code responsible for displaying a list of basket
groups into its own Perl script (acqui/basketgroups.pl), making the code
in basketgroup.pl and basketgroup.tt a little bit easier to read.
basketgroups.pl displays all basket groups in a single table (as bug
13371 for vendors) where rows are grouped by bookseller.

This patch also adds 3 columns:
- No. of ordered titles
- No. of received titles
- Date closed

It also adds a wrapper around the new DataTable() constructor to be able
to use it with the same defaults than the previous dataTable()
constructor

Test plan:
0. Create a bunch of booksellers and basketgroups
1. Go back to acquisitions home page and click on "Basket groups" link
   on the left
2. Play with the table (sort, filter) and try every possible actions
   (Edit, Close and export as PDF, View, Reopen, Export as CSV)
3. Go to a specific vendor page and click on "Basket groups" tab
4. Check that only the vendor's basket groups are displayed

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 10:35:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 08:35:50 +0000
Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page,
 and new column aqbasketgroups.closeddate
In-Reply-To: <bug-11708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11708-70-6OZ9H3bAsN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

--- Comment #244 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 10:37:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 08:37:25 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-RLVrwBH8z9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #98 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75910
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75910&action=edit
Bug 20271: (QA follow-up) Remove last occurrences of deleted_at

Trivial replace of deleted_at by deleted_on.

Test plan:
Run t/db_dependent/Koha/ItemTypes.t
Run t/db_dependent/Items_DelItemCheck.t
git grep -E "deleted_at\W"

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 10:55:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 08:55:29 +0000
Subject: [Koha-bugs] [Bug 15219] Server-side processing and pagination on
 checkouts tables
In-Reply-To: <bug-15219-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15219-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15219-70-T8PWGIuyz3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74224|0                           |1
        is obsolete|                            |

--- Comment #28 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 75911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75911&action=edit
Bug 15219: Server-side processing and pagination on checkouts tables

Some libraries have patrons with more than 1000 checkouts. Loading all
of them at once can be very long, and sometimes can cause timeout
errors.
This patch prevent that by enabling server-side processing and
pagination on checkouts tables.
This affects patron's checkouts and patron's relatives' checkouts tables
on pages circ/circulation.pl and members/moremember.pl.

As server-side processing can be useless and cumbersome with small
sets of data, a new system preference is introduced to control this
behaviour (server-side processing is disabled by default).

Additionally, this patch:
- adds a switch to turn off and on row grouping (today's checkouts vs
  previous checkouts) (on by default)
- adds "column settings" for relatives' checkouts tables
- factorize some code that was duplicated across the two DataTables
  configurations (mDataProp)

Test plan:
1. Find (or create) a patron that have at least 10 checkouts and where
   the relatives checkouts table contain at least 10 checkouts.
2. Go to the patron's detail page and check everything works fine
   in both tables (sorting, pagination, the data itself, ...)
3. Do the same on circulation page (circulation.pl)
4. Enable system preference ServerSideCheckoutsTable
5. Repeat steps 2 and 3

Signed-off-by: Eric Gosselin <eric.gosselin at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 10:55:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 08:55:35 +0000
Subject: [Koha-bugs] [Bug 15219] Server-side processing and pagination on
 checkouts tables
In-Reply-To: <bug-15219-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15219-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15219-70-QQakkDwTUs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74225|0                           |1
        is obsolete|                            |

--- Comment #29 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 75912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75912&action=edit
Bug 15219: Fix date sorting when server-side processing is disabled

Use DataTables 'columns' option instead of 'aoColumns'
This allow more control on what data is used for display, sorting,
filtering, ...

A large part of this patch is about rewording things to better match the
DataTables documentation.
The real change is that

  "mRender": renderingFunc

becomes

  "render": {
    "display": renderingFunc
  }

So the return value of renderingFunc is now only used for display (not
for filtering, sorting, ...)

Signed-off-by: Eric Gosselin <eric.gosselin at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 10:55:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 08:55:38 +0000
Subject: [Koha-bugs] [Bug 20900] New: Yet another test assumes that CPL is
	present
Message-ID: <bug-20900-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20900

            Bug ID: 20900
           Summary: Yet another test assumes that CPL is present
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

t/db_dependent/rollingloans.t

DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`koha_dev`.`items`, CONSTRAINT `items_ibfk_3` FOREIGN KEY
(`holdingbranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) [for
Statement "UPDATE items SET
itemlost_on=?,itemlost=?,onloan=?,datelastborrowed=?,holdingbranch=?,issues=?
WHERE itemnumber=?" with ParamValues: 0=undef, 1=0, 2='2011-05-30',
3='2018-06-08', 4="CPL", 5='31254', 6='862'] at
/usr/share/koha/devclone/C4/Items.pm line 2038.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 10:55:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 08:55:40 +0000
Subject: [Koha-bugs] [Bug 15219] Server-side processing and pagination on
 checkouts tables
In-Reply-To: <bug-15219-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15219-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15219-70-92YK6yq020@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219

--- Comment #30 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 75913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75913&action=edit
Bug 15219: Fix relatives issues table

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 10:55:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 08:55:54 +0000
Subject: [Koha-bugs] [Bug 20900] Yet another test assumes that CPL is present
In-Reply-To: <bug-20900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20900-70-Ai1f1p3iuW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20900

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor
           Assignee|chris at bigballofwax.co.nz    |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 10:58:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 08:58:35 +0000
Subject: [Koha-bugs] [Bug 20900] Yet another test assumes that CPL is present
In-Reply-To: <bug-20900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20900-70-RSh0oe5WFu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20900

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 10:58:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 08:58:38 +0000
Subject: [Koha-bugs] [Bug 20900] Yet another test assumes that CPL is present
In-Reply-To: <bug-20900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20900-70-RyNIY83RT3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20900

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75914&action=edit
Bug 20900: Add CPL test branch in rollingloans.t

Trivial fix.

Test plan:
Without this patch and a CPL library, run rollingsloans.t. See warns.
With this patch, no warns.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 10:58:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 08:58:55 +0000
Subject: [Koha-bugs] [Bug 20900] Yet another test assumes that CPL is present
In-Reply-To: <bug-20900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20900-70-FSM2oITwG1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20900

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 10:59:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 08:59:34 +0000
Subject: [Koha-bugs] [Bug 20900] Yet another test assumes that CPL is present
In-Reply-To: <bug-20900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20900-70-ztLdDEdT2H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20900

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
For the fast QA lane, Joubu ?
Comes from testing 20271 btw.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 11:05:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 09:05:38 +0000
Subject: [Koha-bugs] [Bug 12027] Shibboleth authentication for staff client
In-Reply-To: <bug-12027-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12027-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12027-70-cnJNORjXy3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 11:11:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 09:11:30 +0000
Subject: [Koha-bugs] [Bug 15219] Server-side processing and pagination on
 checkouts tables
In-Reply-To: <bug-15219-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15219-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15219-70-YjV3vVTJGU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #31 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Katrin Fischer from comment #27)
> 1) Releatives tab doesn't open. JavaScript error:
> Error: Syntax error, unrecognized expression: ##relatives-issues-table
Fixed in the last patch

> 2) I think most libraries will have a mix of large accounts and smaller
> ones. Could it make sense to use the server side processing when the patron
> has a certain number of checkouts (configurable)?

It makes sense, but I think than can go in a separate bug. Do you agree ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 11:17:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 09:17:24 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-Q5Po2L3Nih@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #99 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
t/db_dependent/Search.t
    not ok 44 - All records have at least one item available
    #   Failed test 'All records have at least one item available'
    #   at t/db_dependent/Search.t line 508.
    #          got: 'false'
    #     expected: 'true'

Pass on fresh db, so needs some digging..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 11:36:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 09:36:36 +0000
Subject: [Koha-bugs] [Bug 20901] New: Koha/Patrons/Import.t fails on fresh
	database
Message-ID: <bug-20901-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20901

            Bug ID: 20901
           Summary: Koha/Patrons/Import.t fails on fresh database
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

t/db_dependent/Koha/Patrons/Import.t
# Looks like you failed 58 tests of 124.

Fresh install, no optional stuff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 11:37:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 09:37:58 +0000
Subject: [Koha-bugs] [Bug 20902] New: Labels/t_Batch.t fails on fresh
	database
Message-ID: <bug-20902-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20902

            Bug ID: 20902
           Summary: Labels/t_Batch.t fails on fresh database
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

t/db_dependent/Labels/t_Batch.t
# Looks like you planned 24 tests but ran 14.
# Looks like you failed 2 tests of 14 run.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 11:41:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 09:41:21 +0000
Subject: [Koha-bugs] [Bug 20903] New: Print payment receipt on child patron
 could end with ISE
Message-ID: <bug-20903-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903

            Bug ID: 20903
           Summary: Print payment receipt on child patron could end with
                    ISE
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: josef.moravec at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

When you wan't to print a payment receipt for child patron and have only one
adult patron category defined, it ends up with internal server error.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 11:41:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 09:41:34 +0000
Subject: [Koha-bugs] [Bug 20903] Print payment receipt on child patron could
	end with ISE
In-Reply-To: <bug-20903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20903-70-4rmPw9urj3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 11:42:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 09:42:13 +0000
Subject: [Koha-bugs] [Bug 20902] Labels/t_Batch.t fails on fresh database
In-Reply-To: <bug-20902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20902-70-kadDxUnxDi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20902

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 11:42:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 09:42:50 +0000
Subject: [Koha-bugs] [Bug 20902] Labels/t_Batch.t fails on fresh database
In-Reply-To: <bug-20902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20902-70-wi1KqPZH5X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20902

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Fresh install, no optional data

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 11:42:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 09:42:24 +0000
Subject: [Koha-bugs] [Bug 20901] Koha/Patrons/Import.t fails on fresh
	database
In-Reply-To: <bug-20901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20901-70-zJhtvn4BX2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20901

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 11:52:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 09:52:13 +0000
Subject: [Koha-bugs] [Bug 12586] Record matching rules - Required match
 checks doesn't work with MARCXML
In-Reply-To: <bug-12586-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12586-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12586-70-GroLQyU3Ns@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor.grousset at biblibre.co
                   |                            |m
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 11:52:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 09:52:33 +0000
Subject: [Koha-bugs] [Bug 20903] Print payment receipt on child patron could
	end with ISE
In-Reply-To: <bug-20903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20903-70-w4AThTsV6R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903

--- Comment #1 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 75915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75915&action=edit
Bug 20903: Remove unnecessary category code parameters

Test plan:
0) Do no apply the patch
1) Have only one adults patrons category defined
2) Add a fine to child patron and pay it
3) Try to print the payment receipt (file printfeercpt.pl)
4) You see only ISE
5) Apply the patch
6) Try the printing again
7) Now you should see right receipt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 11:52:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 09:52:31 +0000
Subject: [Koha-bugs] [Bug 20903] Print payment receipt on child patron could
	end with ISE
In-Reply-To: <bug-20903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20903-70-aMgP5xxpM9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 11:54:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 09:54:57 +0000
Subject: [Koha-bugs] [Bug 20904] New: Warns from Circulation/Chargelostitem.t
Message-ID: <bug-20904-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20904

            Bug ID: 20904
           Summary: Warns from Circulation/Chargelostitem.t
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

Test passes, but warns need attention

DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. 
SQL that returns multiple rows is DEPRECATED for ->find and ->single at
/usr/share/koha/devclone/Koha/Objects.pm line 191
DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. 
SQL that returns multiple rows is DEPRECATED for ->find and ->single at
/usr/share/koha/devclone/Koha/Objects.pm line 191
t/db_dependent/Circulation/Chargelostitem.t ............. ok

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 11:59:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 09:59:17 +0000
Subject: [Koha-bugs] [Bug 20905] New: Warn from Search.t
Message-ID: <bug-20905-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20905

            Bug ID: 20905
           Summary: Warn from Search.t
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

Test passes but look at this warn from getRecords:

    ok 67 - presence of a transit does not block hold request action (bug
10741)
ERROR DECODING RECORD - Tag "50%" is not a valid tag. at /usr/share/perl5/MARC
/File/USMARC.pm line 223.
: 00295nam a22001217a 45000030004000000050017000040080041000211000018000622450
0570008050%001100137942001200148999001300160OSt20111207151138.0111207t
xxu||||| |||| 00| 0 eng d  aGanser, Helen  aA record containing a punctuation
character as a tag  aa note  2ddccBK  c214d214 at /usr/share/koha/devclone/C4/
Search.pm line 683.
    ok 68 - search for ti:punctuation returned expected number of records

A few lines later in the test, a warning_like also looks for this error.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 12:13:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 10:13:27 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-5X3JtBHfhw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #100 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Asked QA team for additional feedback; cant finish this one now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 12:19:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 10:19:07 +0000
Subject: [Koha-bugs] [Bug 10412] The ability to update Acquisitions with
 credit notes, with the option to link to an existing invoice
In-Reply-To: <bug-10412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10412-70-J8v65Pg2L4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412

Joe McGlynn <joe.mcglynn at educampus.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joe.mcglynn at educampus.ie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 13:49:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 11:49:49 +0000
Subject: [Koha-bugs] [Bug 20906] New: Prevent the tests to fail if precision
	changes
Message-ID: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906

            Bug ID: 20906
           Summary: Prevent the tests to fail if precision changes
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

On upgrade from Debian 8 to Debian 9 the resultant DBI driver update alters the
returned precision for numeric values.

This causes some of the test suit to start failing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 13:50:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 11:50:07 +0000
Subject: [Koha-bugs] [Bug 20906] Prevent the tests to fail if precision
	changes
In-Reply-To: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20906-70-bJ330dC3IS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 13:58:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 11:58:02 +0000
Subject: [Koha-bugs] [Bug 20906] Prevent the tests to fail if precision
	changes
In-Reply-To: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20906-70-4lnfd0xjEt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 75916
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75916&action=edit
Bug 20906: Prevent test failures due to precision changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 14:01:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 12:01:31 +0000
Subject: [Koha-bugs] [Bug 20903] Print payment receipt on child patron could
 end with server error
In-Reply-To: <bug-20903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20903-70-y31YwURJ9b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Print payment receipt on    |Print payment receipt on
                   |child patron could end with |child patron could end with
                   |ISE                         |server error

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 14:04:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 12:04:53 +0000
Subject: [Koha-bugs] [Bug 20120] Prevent writeoffs of more than the amount
	owed for a fee
In-Reply-To: <bug-20120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20120-70-aFXmw2W2kc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120

--- Comment #33 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 75917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75917&action=edit
Bug 20120: (QA follow-up) display correct amount in redirect

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 14:09:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 12:09:59 +0000
Subject: [Koha-bugs] [Bug 20898] Replace OPAC detail's results browser with
 non-JavaScript version
In-Reply-To: <bug-20898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20898-70-s5kxs3gmc9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20898

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 14:10:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 12:10:02 +0000
Subject: [Koha-bugs] [Bug 20898] Replace OPAC detail's results browser with
 non-JavaScript version
In-Reply-To: <bug-20898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20898-70-kOvXwhbA9h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20898

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 75918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75918&action=edit
Bug 20898 - Replace OPAC detail's results browser with non-JavaScript version

This patch moves generation of the OPAC detail page's results browser
from JavaScript to the template. This makes the template easier to
understand and easier to debug. It also makes it possible for the widget
to be completely non-dependent on JavaScript.

To test, apply the patch and regenerate the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_Bootstrap_OPAC_LESS_files).

 - Enable the OpacBrowseResults system preference and perform a search
   in the OPAC which will return multiple results.
 - Click on any title in the first page of search results.
 - On the bibliographic detail page there should be a "Browse results"
   link in the right-hand sidebar just as before.
   - Test that the "Previous," "Back to results," and "Next" links work
     correctly.
   - Click the "Browse results" link. A list of the first 20 search
     results should appear. An arrow should indicate the title you're
     viewing.
   - Click any title in the results browser. The page should correctly
     load that record.
   - Clicking the numbered links at the top of the results browser
     should do the same.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 14:11:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 12:11:40 +0000
Subject: [Koha-bugs] [Bug 20898] Replace OPAC detail's results browser with
 non-JavaScript version
In-Reply-To: <bug-20898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20898-70-iLMLVx0his@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20898

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75918|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 14:11:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 12:11:46 +0000
Subject: [Koha-bugs] [Bug 20898] Replace OPAC detail's results browser with
 non-JavaScript version
In-Reply-To: <bug-20898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20898-70-Mne2h6Z67F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20898

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 14:16:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 12:16:48 +0000
Subject: [Koha-bugs] [Bug 20898] Replace OPAC detail's results browser with
 non-JavaScript version
In-Reply-To: <bug-20898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20898-70-Y08CtKaoG6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20898

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 14:16:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 12:16:51 +0000
Subject: [Koha-bugs] [Bug 20898] Replace OPAC detail's results browser with
 non-JavaScript version
In-Reply-To: <bug-20898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20898-70-K1pgpu0eRS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20898

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 75919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75919&action=edit
Bug 20898 - Replace OPAC detail's results browser with non-JavaScript version

This patch moves generation of the OPAC detail page's results browser
from JavaScript to the template. This makes the template easier to
understand and easier to debug. It also makes it possible for the widget
to be completely non-dependent on JavaScript.

To test, apply the patch and regenerate the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_Bootstrap_OPAC_LESS_files).

 - Enable the OpacBrowseResults system preference and perform a search
   in the OPAC which will return multiple results.
 - Click on any title in the first page of search results.
 - On the bibliographic detail page there should be a "Browse results"
   link in the right-hand sidebar just as before.
   - Test that the "Previous," "Back to results," and "Next" links work
     correctly.
   - Click the "Browse results" link. A list of the first 20 search
     results should appear. An arrow should indicate the title you're
     viewing.
   - Click any title in the results browser. The page should correctly
     load that record.
   - Clicking the numbered links at the top of the results browser
     should do the same.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 15:05:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 13:05:19 +0000
Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used
 in the description
In-Reply-To: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20891-70-2gSTg7hiBx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA
                 CC|                            |nick at bywatersolutions.com

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
I took your test plant too literally, if your list name is surrounded by
quotes:
"<script>alert('hola');</script>"

it works before this patch, but not after. I think the JSON conversion doesn't
like the quotes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 15:06:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 13:06:05 +0000
Subject: [Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
In-Reply-To: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20906-70-xzc0Zdtwwu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Prevent the tests to fail   |Fix Debian 9 Test Failures
                   |if precision changes        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 15:06:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 13:06:56 +0000
Subject: [Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
In-Reply-To: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20906-70-uo6s5piYGA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
On upgrade from Debian 8 to Debian 9 the resultant Perl update means perl
strict is 'more strict' ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 15:34:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 13:34:04 +0000
Subject: [Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
In-Reply-To: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20906-70-rg26YphqGK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 75920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75920&action=edit
Bug 20906: Prevent test failures due to stricter perl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 15:35:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 13:35:28 +0000
Subject: [Koha-bugs] [Bug 10412] The ability to update Acquisitions with
 credit notes, with the option to link to an existing invoice
In-Reply-To: <bug-10412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10412-70-AKITyUbNry@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412

Charles Quain <csq at interleaf.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |csq at interleaf.ie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 15:41:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 13:41:10 +0000
Subject: [Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
In-Reply-To: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20906-70-9uIzp27qWu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 15:53:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 13:53:06 +0000
Subject: [Koha-bugs] [Bug 20851] Missing module in
	circ/article-request-slip.pl
In-Reply-To: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20851-70-41G8KerIYn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to master for 18.11, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 15:53:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 13:53:31 +0000
Subject: [Koha-bugs] [Bug 20756] OPAC "Share list" button should be styled
	with an icon
In-Reply-To: <bug-20756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20756-70-A5zN1UzPoD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to master for 18.11, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 15:53:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 13:53:41 +0000
Subject: [Koha-bugs] [Bug 20700] Update MARC21 leader/007/008 codes
In-Reply-To: <bug-20700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20700-70-2FG6zYuefj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20700

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to master for 18.11, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 15:54:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 13:54:08 +0000
Subject: [Koha-bugs] [Bug 20886] Koha::Object::TO_JSON indiscriminately
 casting to integer
In-Reply-To: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20886-70-yavAmZ46Nh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20886

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to master for 18.11, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 15:54:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 13:54:42 +0000
Subject: [Koha-bugs] [Bug 20866] ArticleRequests.t fails on existing requests
In-Reply-To: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20866-70-fVaIKW8fyk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20866

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to master for 18.11, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 15:56:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 13:56:36 +0000
Subject: [Koha-bugs] [Bug 20053] Drop type attribute "text/javascript" for
 <script> elements used in OPAC templates
In-Reply-To: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20053-70-YiaY25m4ds@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to master for 18.11, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 15:56:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 13:56:44 +0000
Subject: [Koha-bugs] [Bug 20829] 'Link to host item' gives internal server
	error
In-Reply-To: <bug-20829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20829-70-9EDcsjR7VT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20829

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to master for 18.11, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 15:56:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 13:56:23 +0000
Subject: [Koha-bugs] [Bug 20778] Unable to delete a subscription
In-Reply-To: <bug-20778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20778-70-fIu8YEDGiE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to master for 18.11, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 15:56:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 13:56:51 +0000
Subject: [Koha-bugs] [Bug 2426] Management permissions is deprecated
In-Reply-To: <bug-2426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2426-70-6jupPOCjp6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to master for 18.11, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 15:56:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 13:56:59 +0000
Subject: [Koha-bugs] [Bug 20120] Prevent writeoffs of more than the amount
	owed for a fee
In-Reply-To: <bug-20120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20120-70-k4xDOP5Gr3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #34 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to master for 18.11, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 15:57:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 13:57:15 +0000
Subject: [Koha-bugs] [Bug 20875] OpacAddMastheadLibraryPulldown displays an
	empty list
In-Reply-To: <bug-20875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20875-70-QMjOckaMAf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to master for 18.11, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 15:58:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 13:58:07 +0000
Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance
	killer
In-Reply-To: <bug-18821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18821-70-lUicSfpRJa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #47 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to master for 18.11, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 15:58:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 13:58:27 +0000
Subject: [Koha-bugs] [Bug 20889] Items marked as not for loan can be checked
	out
In-Reply-To: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20889-70-hKjJcnDW0Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20889

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to master for 18.11, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 16:13:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 14:13:18 +0000
Subject: [Koha-bugs] [Bug 20900] Yet another test assumes that CPL is present
In-Reply-To: <bug-20900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20900-70-SzyWgwuU1O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20900

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
It seems that t/db_dependent/Labels/t_Batch.t is failing as well

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 16:21:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 14:21:53 +0000
Subject: [Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
In-Reply-To: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20906-70-SpR5W3lDh3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 75921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75921&action=edit
Bug 20906: Prevent test failures due to precision changes (2)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 16:23:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 14:23:18 +0000
Subject: [Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
In-Reply-To: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20906-70-PUGPyZHuTJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm not proud of that last one.. it fixes the tests but I'd rather convert the
float for discount in the database to a decimal to match the decimal that's
used for tax_rate (which is also a percentage measured to the same accuracy..
seems odd to have them stored differently).. but that seemed over the top here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 16:23:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 14:23:26 +0000
Subject: [Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
In-Reply-To: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20906-70-62JXXHfqix@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 16:24:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 14:24:57 +0000
Subject: [Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
In-Reply-To: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20906-70-bTbUq0pKh9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Test plan.. run the affected tests against both D8 and D9 and see that they now
pass ;)

Beware, running 00_strict requires WebService::ILS::OverDrive is installed..
KohaDevBox is missing it in my experience.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 16:39:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 14:39:56 +0000
Subject: [Koha-bugs] [Bug 20886] Koha::Object::TO_JSON indiscriminately
 casting to integer
In-Reply-To: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20886-70-wH44Iwcdm3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20886

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x and will be in 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 16:41:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 14:41:31 +0000
Subject: [Koha-bugs] [Bug 20778] Unable to delete a subscription
In-Reply-To: <bug-20778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20778-70-WGBYACbSNg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_18_05_candidate         |
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x and will be in 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 17:23:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 15:23:35 +0000
Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used
 in the description
In-Reply-To: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20891-70-kGvANIJoq9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75922&action=edit
Bug 20891: Escape html then JSON

To my understanding we need to escape first html chars then to JSON.

If this patch works we will need to rethink the 'To' TT plugin.
It was originally designed to have several escape methods, but with
these changes it will not make sense to name it 'To' if used only to
escape JSON

IIRC we should keep the 2 different ways to use it:
 * [% To.json( string ) %]
 * [% string | $To %]
otherwise it will be hard to use it when called in argument of
patron-title.inc (`git grep To.json`)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 17:25:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 15:25:32 +0000
Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used
 in the description
In-Reply-To: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20891-70-X7DYsBXVvK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |In Discussion

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Good catch Nick. From trivial it is becoming a complex one now.

Last patch for discussion and review before a full rewrite of the TT plugin.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 17:36:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 15:36:33 +0000
Subject: [Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with
 C4::Context->temporary_directory
In-Reply-To: <bug-20727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20727-70-FG86eqN2yA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75667|0                           |1
        is obsolete|                            |
  Attachment #75668|0                           |1
        is obsolete|                            |
  Attachment #75669|0                           |1
        is obsolete|                            |
  Attachment #75670|0                           |1
        is obsolete|                            |
  Attachment #75833|0                           |1
        is obsolete|                            |
  Attachment #75835|0                           |1
        is obsolete|                            |

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75923&action=edit
Bug 20727: Replace usage of File::Spec->tmpdir with
Koha::UploadedFile->temporary_directory

As explained in bug 20428 use tmpdir can cause issues and it just makes sense
to standardize our temp directory in a universal way.

Test Plan:
1) Apply this patch
2) Verify you can still log in and use Koha
3) Verify the web installer still works
4) Verify EDI module can still download files via FTP
5) Verify fines.pl still runs with -o option
6) prove t/db_dependent/Plugins.t
7) prove t/db_dependent/Sitemapper.t
8) prove t/db_dependent/Templates.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 17:36:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 15:36:38 +0000
Subject: [Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with
 C4::Context->temporary_directory
In-Reply-To: <bug-20727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20727-70-FoKZcjEyA0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75924&action=edit
Bug 20727: Move temporary_directory() to C4::Context

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 17:36:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 15:36:43 +0000
Subject: [Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with
 C4::Context->temporary_directory
In-Reply-To: <bug-20727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20727-70-G5UividnUY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75925&action=edit
Bug 20727: (QA follow-up) Fix Upload.t and Plugins.t

Trivial changes.
Adding C4::Context->temporary_directory to subsequent tmpdir call in Plugins.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 17:36:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 15:36:48 +0000
Subject: [Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with
 C4::Context->temporary_directory
In-Reply-To: <bug-20727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20727-70-dlv1k9oIrC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75926&action=edit
Bug 20727: (QA follow-up) Remove a few use statements again

We do no longer need "use Koha::UploadedFile" in a few places.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 17:36:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 15:36:54 +0000
Subject: [Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with
 C4::Context->temporary_directory
In-Reply-To: <bug-20727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20727-70-NOk9z13aBa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75927&action=edit
Bug 20727: Replace use of tmpdir in updatedatabase.pl

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 17:36:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 15:36:29 +0000
Subject: [Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with
 C4::Context->temporary_directory
In-Reply-To: <bug-20727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20727-70-UKIelqnGU6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 17:36:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 15:36:58 +0000
Subject: [Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with
 C4::Context->temporary_directory
In-Reply-To: <bug-20727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20727-70-B57oz8XLE8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727

--- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75928&action=edit
Bug 20727: Add use line for File::Spec in C4::Context, sort used modules

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 17:45:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 15:45:11 +0000
Subject: [Koha-bugs] [Bug 20907] New: Improve sorting for suggestions
Message-ID: <bug-20907-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20907

            Bug ID: 20907
           Summary: Improve sorting for suggestions
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: christian.stelzenmueller at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

The suggestions from the suggestion list can currently only be sorted by "by"
in the columns "Managed by/on" and "Suggested by/on". 

It should also be sorted by date ("on").

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 18:00:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 16:00:05 +0000
Subject: [Koha-bugs] [Bug 15668] Add column configuration to the items table
 in staff detail pages
In-Reply-To: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15668-70-tCNvnJeJyz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 18:11:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 16:11:07 +0000
Subject: [Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
In-Reply-To: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20906-70-s8Ll8b9g4g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75929&action=edit
Bug 20906: Fix translatable-templates.t

>From Jenkins:
koha_1       | #   Failed test 'staff_prog templates are translatable'
koha_1       | #   at xt/author/translatable-templates.t line 87.
koha_1       | # Can't locate TmplTokenizer.pm in @INC (you may need to install
the TmplTokenizer module) (@INC contains: /kohadevbox/koha /etc/perl
/usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1
/usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5
/usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24
/usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at
./tmpl_process3.pl line 20.

On Stretch, '.' is not longer added to @INC, see bug 17717 for more info

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 18:56:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 16:56:20 +0000
Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data
In-Reply-To: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13897-70-NBHxR94zPK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37165|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 19:08:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 17:08:26 +0000
Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data
In-Reply-To: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13897-70-46HgAo2tTS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 75930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75930&action=edit
Bug 13897: C4/Installer.pm - process XML files

This patch modifies C4/Installer.pm to add support
for processing of XML files into database.
For MySQL only

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 19:12:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 17:12:40 +0000
Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data
In-Reply-To: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13897-70-O9DpedutDS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 75931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75931&action=edit
Bug 13897: Split auth framework into xml and sql files

Bug 13897: Split auth framework into xml and sql files

This patch split authorities_normal_marc21.sql contents
between three XML files and a remanent SQL file

GZIP file of patch, it's too large

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 21:38:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 19:38:26 +0000
Subject: [Koha-bugs] [Bug 20598] Accruing fines not closed out by
 longoverdue.pl if WhenLostForgiveFine is not enabled
In-Reply-To: <bug-20598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20598-70-C3EHaNw9Hd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20598

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74377|0                           |1
        is obsolete|                            |

--- Comment #2 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 75932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75932&action=edit
Bug 20598: Accruing fines not closed out by longoverdue.pl if
WhenLostForgiveFine is not enabled

Test Plan:
1) Ensure WhenLostForgiveFine is disabled
2) Create an overdue with a fine
3) Mark it lost with longoverdue.pl
4) Note it is still marked as an accruing fine
5) Apply this patch
6) Repeat steps 1-3
7) Note it is no longer an accruing fine!

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Followed the test plan and it works.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 21:38:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 19:38:24 +0000
Subject: [Koha-bugs] [Bug 20598] Accruing fines not closed out by
 longoverdue.pl if WhenLostForgiveFine is not enabled
In-Reply-To: <bug-20598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20598-70-OlzyZNLt83@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20598

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 21:43:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 19:43:13 +0000
Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to
 account page instead of back to search results
In-Reply-To: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17153-70-OKiI9wxiBL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 21:43:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 19:43:16 +0000
Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to
 account page instead of back to search results
In-Reply-To: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17153-70-Q3cPU0anqJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75714|0                           |1
        is obsolete|                            |

--- Comment #18 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 75933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75933&action=edit
Bug 17153: Login during search rebase and fix

This patch is a fresh attempt at redirecting back to search
results after logging in on opac-search.pl

To test:
- Perform an OPAC search
- Login on opac-search.pl with the search results displayed
- The page is redirected to opac-user.pl
- Log out
- Apply the patch
- Perform a new OPAC search
- Note the URL query string
- Login on opac-search.pl with the search results displayed
- The opac-search.pl page should be displayed with the correct
  query string and the page should indicate a logged in status

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Followed the test plan and the patch works.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 21:44:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 19:44:42 +0000
Subject: [Koha-bugs] [Bug 7136] Correct description of Grace period for
	subscriptions
In-Reply-To: <bug-7136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7136-70-lckm0WHX6F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7136

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 21:44:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 19:44:45 +0000
Subject: [Koha-bugs] [Bug 7136] Correct description of Grace period for
	subscriptions
In-Reply-To: <bug-7136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7136-70-KNNEtzZZX8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7136

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75352|0                           |1
        is obsolete|                            |

--- Comment #7 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 75934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75934&action=edit
Bug 7136: Correct description of Grace period for subscriptions

The grace period is used with the serialsUpdate.pl cronjob. It will
generate the next issue and set the one before to 'Late' with
an optional note.

There is on trace of a 'waiting' status for serials.

To test:
- check help file on the subscription edit form for
  the description of the 'Grace period'.

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 21:45:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 19:45:57 +0000
Subject: [Koha-bugs] [Bug 19970] Revise change of bug 19413 to work better
 for translations
In-Reply-To: <bug-19970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19970-70-8lqOXUmi4u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19970

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 21:45:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 19:45:59 +0000
Subject: [Koha-bugs] [Bug 19970] Revise change of bug 19413 to work better
 for translations
In-Reply-To: <bug-19970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19970-70-heLUzmvyn2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19970

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75707|0                           |1
        is obsolete|                            |

--- Comment #2 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 75935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75935&action=edit
Bug 19970: Revise change of bug 19413 to work better for translations

This patch changes how the submit and cancel buttons appear in the MARC
008 plugin window. The controls are now displayed as buttons in a
floating toolbar.

To test you must have MARC tag 008 configured to use the
marc21_field_008.pl plugin.

- Apply the patch and open an existing or blank record in cataloging.
- Click the plugin link next to tag 008 to trigger the popup window.
- Confirm that "Save" and "Cancel" appear correctly in a toolbar.
- Scroll down the page to confirm that the toolbar "sticks" to the top
  of the window.
- Confirm that the "Save" and "Cancel" buttons work correctly.

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Followed the test plan and the patch works.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 21:47:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 19:47:08 +0000
Subject: [Koha-bugs] [Bug 20285] Lost item refund won't always pay down lost
 item fee first
In-Reply-To: <bug-20285-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20285-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20285-70-KE1Z1MCoB8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20285

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 21:47:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 19:47:11 +0000
Subject: [Koha-bugs] [Bug 20285] Lost item refund won't always pay down lost
 item fee first
In-Reply-To: <bug-20285-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20285-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20285-70-uyzQpt77KK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20285

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72123|0                           |1
        is obsolete|                            |

--- Comment #3 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 75936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75936&action=edit
Bug 20285: Lost item refund won't always pay down lost item fee first

Due to a simple typo, the accountline passed to Koha::Account::pay from
_FixAccountForLostAndReturned is not used. That means that the credit for the
lost item fee may be applied to other fees before it is used on the lost fee
itself.

Test Plan:
1) Find a patron with existing fines
2) Ensure your settings will charge patrons for lost items
3) Check out an item to a patron with existing fees that need paid
4) Mark the item lost, charging the lost item fee
5) Return the item
6) Note the fee was refunded, but it paid down earlier fines first,
   and not the lost item fee first
7) Apply this patch set
8) Repeat steps 1 - 5
9) Note the lost item fee is the first fee to be paid off by the lost
   item fee refund

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Followed the test plan and it works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 21:53:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 19:53:07 +0000
Subject: [Koha-bugs] [Bug 16653] reports/cat_issues_top.pl does not export
 "Count of checkouts" column as CSV
In-Reply-To: <bug-16653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16653-70-2IL9sJYt0E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16653

Pierre-Luc Lapointe <pierre-luc.lapointe at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75886|0                           |1
        is obsolete|                            |

--- Comment #3 from Pierre-Luc Lapointe <pierre-luc.lapointe at inLibro.com> ---
Created attachment 75937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75937&action=edit
Bug 16653: Display number of checkouts when exporting 'Most-circulated items'
as CSV

reports/cat_issues_top.pl does not export "Count of checkouts" column as CSV

To replicate:

1/ Make sure that test instance has circulation in a given date range
2/ Go to Home ? Reports ? Most-circulated items
3/ Select a date range
4/ Select 'To screen into the browser' radio button, click submit.
5/ Note that Columns 'Rank/Biblioitemnumbers', 'Global' and 'Count of
checkouts' appear in screen output.
6/ Click the browser's back button
7/ Change output to 'To a file', click submit.

Without this patch:
the columns "100/", "Global" and "Total" are exported to the CSV file.
"100/" contains the rank, "Global" is still global, and the "Total" column is
empty.

With this patch patch applied, the last column is filled and the "Total" line
is removed

(This script is really dirty)

Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun  8 21:53:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jun 2018 19:53:26 +0000
Subject: [Koha-bugs] [Bug 16653] reports/cat_issues_top.pl does not export
 "Count of checkouts" column as CSV
In-Reply-To: <bug-16653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16653-70-8haw1FaWmb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16653

Pierre-Luc Lapointe <pierre-luc.lapointe at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pierre-luc.lapointe at inLibro
                   |                            |.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 10 12:56:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jun 2018 10:56:40 +0000
Subject: [Koha-bugs] [Bug 16767] OPAC suggestions,
 existing suggestions don't show after placing a suggestion
In-Reply-To: <bug-16767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16767-70-GILssDe2dB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16767

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Nick, did you forget about this one? :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 10 13:16:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jun 2018 11:16:14 +0000
Subject: [Koha-bugs] [Bug 9851] Ability to link orders to suggestions
In-Reply-To: <bug-9851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9851-70-NtHQaAIeeV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9851

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|way to get full records for |Ability to link orders to
                   |purchase suggestions        |suggestions

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am changing the title of this bug a little bit to make it stand out a bit
more.

If for some reason the 'order from suggestion' can't be used, like when
ordering form as staged file or using EDI, there is currently no way for the
suggestion to reach the Ordered or Available status and the patrons don't
receive notifications.

I think it would be nice if you could link an order to a suggestion after it
has been created to fix this.

If the order is status new or ordered the suggestion is moved to ordered.
If the order is available already, it's moved to available.
Notifications are generated according to status.

This workflow would also help if there are multiple suggestions for the same
record.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 10 13:20:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jun 2018 11:20:35 +0000
Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
In-Reply-To: <bug-5770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5770-70-RW5MPvml2N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|email librarian when        |Email librarian when
                   |purchase suggestion made    |purchase suggestion made

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 10 13:20:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jun 2018 11:20:43 +0000
Subject: [Koha-bugs] [Bug 19459] New suggestions sent via email
In-Reply-To: <bug-19459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19459-70-dVtDN0ZNko@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19459

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 5770 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 10 13:20:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jun 2018 11:20:43 +0000
Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
In-Reply-To: <bug-5770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5770-70-OnBWNP9MN7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 19459 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 10 13:22:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jun 2018 11:22:46 +0000
Subject: [Koha-bugs] [Bug 19358] Purchase suggestions - enhancements to
	linking to orders
In-Reply-To: <bug-19358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19358-70-J5sCbfX8Q5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19358

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=9851

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 10 13:22:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jun 2018 11:22:46 +0000
Subject: [Koha-bugs] [Bug 9851] Ability to link orders to suggestions
In-Reply-To: <bug-9851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9851-70-rR6COIvKnF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9851

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19358

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 10 13:26:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jun 2018 11:26:06 +0000
Subject: [Koha-bugs] [Bug 9776] transfering a suggestion to an other
	librarian
In-Reply-To: <bug-9776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9776-70-Dhw0dlo9Dl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9776

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think this has been resolved mostly by the fact that you now can create
orders for all accepted suggestions, while back then it was only possible to
order the ones you accepted yourselves.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 10 13:26:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jun 2018 11:26:15 +0000
Subject: [Koha-bugs] [Bug 9776] Transfering a suggestion to an other
	librarian
In-Reply-To: <bug-9776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9776-70-sXolxKZ4kY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9776

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|transfering a suggestion to |Transfering a suggestion to
                   |an other librarian          |an other librarian

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 10 13:27:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jun 2018 11:27:03 +0000
Subject: [Koha-bugs] [Bug 10568] Way to vote for purchase suggestions
In-Reply-To: <bug-10568-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10568-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10568-70-fjIIIXOzGL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10568

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|way to vote for purchase    |Way to vote for purchase
                   |suggestions                 |suggestions

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 10 13:27:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jun 2018 11:27:51 +0000
Subject: [Koha-bugs] [Bug 14049] Ability to add custom fields to OPAC
 purchase suggestion form
In-Reply-To: <bug-14049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14049-70-ZuWLYQgsCI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14049

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Personalized OPAC purchase  |Ability to add custom
                   |suggestion fields           |fields to OPAC purchase
                   |                            |suggestion form
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 10 13:29:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jun 2018 11:29:12 +0000
Subject: [Koha-bugs] [Bug 17388] Suggestion detail page marks suggestion as
 rejected and accepted
In-Reply-To: <bug-17388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17388-70-5ZoqFeLPrN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17388

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Maybe the solution here would be add 'suggestion recjected' to the history as
well? Or make it 'Changed status' instead to apply for both.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 10 13:30:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jun 2018 11:30:06 +0000
Subject: [Koha-bugs] [Bug 1884] Managing Suggestions - way to archive/clean
 up approved/rejected orders
In-Reply-To: <bug-1884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-1884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1884-70-wX9kaM5rNa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1884

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Still valid.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 10 13:31:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jun 2018 11:31:03 +0000
Subject: [Koha-bugs] [Bug 13484] Suggestions should have a foreign key
 constraint for branchcode
In-Reply-To: <bug-13484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13484-70-EDpyGiKqxf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13484

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=5334
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 10 13:31:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jun 2018 11:31:10 +0000
Subject: [Koha-bugs] [Bug 13533] Table suggestions is missing FK constraints
 / borrowernumbers are kept on deletion of patron
In-Reply-To: <bug-13533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13533-70-P8xhapmLaF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13533

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=5334

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 10 13:31:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jun 2018 11:31:10 +0000
Subject: [Koha-bugs] [Bug 5334] add explicit foreign key constraints
In-Reply-To: <bug-5334-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5334-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5334-70-bG25dQIdbG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13533

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 10 13:31:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jun 2018 11:31:03 +0000
Subject: [Koha-bugs] [Bug 5334] add explicit foreign key constraints
In-Reply-To: <bug-5334-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5334-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5334-70-PzMt5vALqF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13484

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 10 13:32:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jun 2018 11:32:05 +0000
Subject: [Koha-bugs] [Bug 13484] Suggestions should have a foreign key
 constraint for branchcode
In-Reply-To: <bug-13484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13484-70-76CibIyonl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13484

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13533

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 10 13:32:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jun 2018 11:32:05 +0000
Subject: [Koha-bugs] [Bug 13533] Table suggestions is missing FK constraints
 / borrowernumbers are kept on deletion of patron
In-Reply-To: <bug-13533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13533-70-wl1XVlOQO4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13533

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13484

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 10 13:36:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jun 2018 11:36:53 +0000
Subject: [Koha-bugs] [Bug 14814] Suggestions improvements
In-Reply-To: <bug-14814-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14814-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14814-70-H2U5L7Vq4D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14814

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Vitor, 

taking a look here:

1) It's possible to add suggestions for a patron from the patron account.

2) Still valid.

3) It's now possible to order by email from the basket.

I thin 1) is solved, 2) an 3) are still partially valid, but they shoud go on
separate bug reports. Bugs too general will be overlooked easily and those are
very different features that would have to be resolved with 2 patch sets any
way.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 10 13:40:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jun 2018 11:40:26 +0000
Subject: [Koha-bugs] [Bug 14593] Send notifications for pending staff
 actions (moderation, suggestions)
In-Reply-To: <bug-14593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14593-70-LUqeeRBsEE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14593

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19412
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 10 13:40:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jun 2018 11:40:26 +0000
Subject: [Koha-bugs] [Bug 19412] Add ability to email item suggestions
 through system preferences
In-Reply-To: <bug-19412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19412-70-nTXnJxUxIn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19412

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=14593

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 10 13:41:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jun 2018 11:41:06 +0000
Subject: [Koha-bugs] [Bug 19412] Add ability to email item suggestions
 through system preferences
In-Reply-To: <bug-19412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19412-70-1UPywZ9XRD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19412

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Should this have a different status?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 01:47:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jun 2018 23:47:32 +0000
Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search
 in staff client and OPAC
In-Reply-To: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14715-70-vqMoUWy63V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68000|0                           |1
        is obsolete|                            |

--- Comment #44 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 75938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75938&action=edit
Bug 14715: results per page setting for catalog search

Add new select field to catalog search results pages which allows user to set
number
of results to be shown per page. Setting saved in cookie "results_per_page".

To test:
1) Do a catalog search in the intranet and OPAC
2) Confirm that results automatically update upon selection of results
per page to show
3) Test for all options (20, 40, 60, 80, 100, all)

Bug 14715: syspref for results per page options

Remove the "all" option.

Add syspref [OPAC]numSearchResultsPerPage for specifying options for numbers of
results per page including [OPAC]numSearchResults.

Bug 14715: database updates

Bug 14715: Fixing pagination problems

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 01:47:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jun 2018 23:47:38 +0000
Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search
 in staff client and OPAC
In-Reply-To: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14715-70-62d2BTHXiV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68001|0                           |1
        is obsolete|                            |

--- Comment #45 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 75939
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75939&action=edit
Bug 14715: [FOLLOW-UP] Fixing qa-tools issues

and merge conflicts

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 01:47:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jun 2018 23:47:45 +0000
Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search
 in staff client and OPAC
In-Reply-To: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14715-70-rjqnxZ3fxN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68327|0                           |1
        is obsolete|                            |

--- Comment #46 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 75940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75940&action=edit
Bug 14715: [FOLLOW-UP] Removing 'all' option, fixing QA tools issues

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 01:48:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jun 2018 23:48:24 +0000
Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search
 in staff client and OPAC
In-Reply-To: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14715-70-mpEX0KNrjd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 04:55:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 02:55:00 +0000
Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search
 in staff client and OPAC
In-Reply-To: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14715-70-TGBFiUfFk3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 04:55:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 02:55:07 +0000
Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search
 in staff client and OPAC
In-Reply-To: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14715-70-cH9HTYpXB0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

--- Comment #47 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 75941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75941&action=edit
Bug 14715: [FOLLOW-UP] Rebase and fix up

I noticed that the two sysprefs initially created with this patch
weren't really being used, so I removed them. Instead I've added two new
sysprefs:
numSearchResultsDropdown
OPACnumSearchResultsDropdown
that control whether the dropdown shows or not. Otherwise the defaults
in numSearchResults and OPACnumSearchResults are used to decide number
of search results per page.

When testing:
Run updatedatabase.pl
Test with values in numSearchResults and OPACnumSearchResults. Use
original test plan in Comment 12 but test with the dropdown sysprefs off
and on.

Sponsored-by: Region Halland

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 04:56:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 02:56:38 +0000
Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search
 in staff client and OPAC
In-Reply-To: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14715-70-lu5gUutut7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

--- Comment #48 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Marcel de Rooy from comment #43)
> QA Comment:
> 
> Why do you add in catalogue/search.pl:
> +use String::Random;
> 
> + at results_per_page_options = do { my %seen; grep { !$seen{$_}++ }
> @results_per_page_options };
> Could you 'do' this without a do statement? Do you need uniq from List::More
> ?
> Is it really needed btw? Do you expect duplicate numbers in this pref..
> 

This is now gone in latest follow-up.

> results.tt
> Why are you changing the lines with respect to list counts? What is the
> relation with this patch?
> 

This seems unrelated to this patch but is no longer affected in the follow-up.

> opac-search.pl
> -$offset = ($page-1)*$results_per_page if $page>1;
> Why do you remove it ?
> 

Offset is dealt with later.

> -        ($error, $results_hashref, $facets) =
> C4::Search::pazGetRecords($query,$simple_query,\@sort_by,\@servers,
> $results_per_page,$offset,$expanded_facet,undef,$query_type,$scan);
> +        ($error, $results_hashref, $facets) =
> C4::Search::pazGetRecords($query,$simple_query,\@sort_by,\@servers,
> $results_per_page,$offset,$expanded_facet,$query_type,$scan);
> You remove a undef parameter.
> Why? Is this a bug on its own? What is the relation with this report?
> 
> Please clarify or adjust.

Have put undef param back. Not sure why this was removed initially.

Ready for testing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 08:27:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 06:27:44 +0000
Subject: [Koha-bugs] [Bug 20903] Print payment receipt on child patron could
 end with server error
In-Reply-To: <bug-20903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20903-70-dcPCVUQB4B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903

--- Comment #2 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 75915
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75915
Bug 20903: Remove unnecessary category code parameters

Review of attachment 75915:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20903&attachment=75915)
-----------------------------------------------------------------

::: members/printfeercpt.pl
@@ -60,5 @@
>  
> -if ( $patron->is_child ) {
> -    my $patron_categories = Koha::Patron::Categories->search_limited({ category_type => 'A' }, {order_by => ['categorycode']});
> -    $template->param( 'CATCODE_MULTI' => 1) if $patron_categories->count > 1;
> -    $template->param( 'catcode' => $patron_categories->next->categorycde )  if $patron_categories->count == 1;

This is the code which causes problem ('categorycde' instead of
'categorycode'). But as this code is not needed, I removed whole block of code.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 08:55:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 06:55:58 +0000
Subject: [Koha-bugs] [Bug 20546] Shelving location not displayed on checkin
In-Reply-To: <bug-20546-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20546-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20546-70-YEY9E2lUZL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20546

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 08:56:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 06:56:27 +0000
Subject: [Koha-bugs] [Bug 20546] Shelving location not displayed on checkin
In-Reply-To: <bug-20546-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20546-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20546-70-L1dfjwM2Ij@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20546

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 18276 not in 17.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 09:46:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 07:46:25 +0000
Subject: [Koha-bugs] [Bug 20908] New: Print receipts need clean up
Message-ID: <bug-20908-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20908

            Bug ID: 20908
           Summary: Print receipts need clean up
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: josef.moravec at gmail.com
        QA Contact: testopia at bugs.koha-community.org

During work on bug 20903, I realize the need of clean up of print receipts
scripts and templates...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 09:46:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 07:46:36 +0000
Subject: [Koha-bugs] [Bug 20908] Print receipts need clean up
In-Reply-To: <bug-20908-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20908-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20908-70-XMfV7CzpTN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20908

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 09:51:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 07:51:35 +0000
Subject: [Koha-bugs] [Bug 20866] ArticleRequests.t fails on existing requests
In-Reply-To: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20866-70-6LcmPkzLob@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20866

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x and will be in 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 09:54:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 07:54:38 +0000
Subject: [Koha-bugs] [Bug 20889] Items marked as not for loan can be checked
	out
In-Reply-To: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20889-70-C3STHSTX06@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20889

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_18_05_candidate         |
             Status|Pushed to Master            |Pushed to Stable

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x and will be in 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 10:06:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 08:06:10 +0000
Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance
	killer
In-Reply-To: <bug-18821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18821-70-rqZ4MsojDJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #48 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x and will be in 18.05.01

Be nice to see this performance improvement :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 10:13:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 08:13:56 +0000
Subject: [Koha-bugs] [Bug 20875] OpacAddMastheadLibraryPulldown displays an
	empty list
In-Reply-To: <bug-20875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20875-70-BOa41gmvQf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
           Keywords|rel_18_05_candidate         |

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x and will be in 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 10:17:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 08:17:50 +0000
Subject: [Koha-bugs] [Bug 20120] Prevent writeoffs of more than the amount
	owed for a fee
In-Reply-To: <bug-20120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20120-70-EHv8Ta0woP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #35 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x and will be in 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 10:20:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 08:20:37 +0000
Subject: [Koha-bugs] [Bug 20390] Elasticsearch - Mappings for UNIMARC
	(updates existing)
In-Reply-To: <bug-20390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20390-70-aIO99g7cUe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20390

claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20073


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073
[Bug 20073] Move Elasticsearch settings to configuration files
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 10:20:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 08:20:37 +0000
Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to
	configuration files
In-Reply-To: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20073-70-vmK3XZ48UG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073

claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20390


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20390
[Bug 20390] Elasticsearch - Mappings for UNIMARC (updates existing)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 11:00:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 09:00:12 +0000
Subject: [Koha-bugs] [Bug 2426] Management permissions is deprecated
In-Reply-To: <bug-2426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2426-70-qDFqRGstiz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         Resolution|---                         |FIXED

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Not pushing to 18.05.x as it could surprise unsuspecting librarians during a
minor update having this permission disappear (even though it effectively does
nothing at present).

Nice fix for 18.11, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 11:02:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 09:02:03 +0000
Subject: [Koha-bugs] [Bug 20829] 'Link to host item' gives internal server
	error
In-Reply-To: <bug-20829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20829-70-wbUj3duGE8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20829

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x and will be in 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 11:05:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 09:05:08 +0000
Subject: [Koha-bugs] [Bug 20053] Drop type attribute "text/javascript" for
 <script> elements used in OPAC templates
In-Reply-To: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20053-70-gqphKNgjo5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x and will be in 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 11:05:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 09:05:59 +0000
Subject: [Koha-bugs] [Bug 20892] Wrong basketgroup link in histsearch.pl
In-Reply-To: <bug-20892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20892-70-7RcTnVCAbv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20892

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75881|0                           |1
        is obsolete|                            |
                 CC|                            |amitddng135 at gmail.com

--- Comment #2 from Amit Gupta <amitddng135 at gmail.com> ---
Created attachment 75943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75943&action=edit
Bug 20892: Correct basketgroup link in histsearch.pl

Work OK.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 11:06:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 09:06:19 +0000
Subject: [Koha-bugs] [Bug 20892] Wrong basketgroup link in histsearch.pl
In-Reply-To: <bug-20892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20892-70-wO0qsO6qbD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20892

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 11:09:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 09:09:08 +0000
Subject: [Koha-bugs] [Bug 20656] Print summary for patron shows paid fines
 and formats payments badly
In-Reply-To: <bug-20656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20656-70-A6roZBMg9e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amitddng135 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 11:11:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 09:11:05 +0000
Subject: [Koha-bugs] [Bug 19617] Allow 'writeoff of selected'
In-Reply-To: <bug-19617-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19617-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19617-70-uYNMB8QtD8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19617

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amitddng135 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 11:19:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 09:19:02 +0000
Subject: [Koha-bugs] [Bug 20700] Update MARC21 leader/007/008 codes
In-Reply-To: <bug-20700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20700-70-k0iadFv9k3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20700

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x and will be in 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 11:21:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 09:21:17 +0000
Subject: [Koha-bugs] [Bug 20794] Don't show holds tab when user doesn't have
 circulate_remaining_permissions
In-Reply-To: <bug-20794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20794-70-CcVvwSffJf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20794

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75447|0                           |1
        is obsolete|                            |
                 CC|                            |amitddng135 at gmail.com

--- Comment #2 from Amit Gupta <amitddng135 at gmail.com> ---
Created attachment 75944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75944&action=edit
Bug 20794: Hide holds tab on details when user lacks 
circulate_remaining_permissions

Work OK

---------------
Test
If a user doesn't have circulate_remaining permissions, but has borrowers:
- checkouts tab is hidden
- details tab is visible
- holds tab on details is visible, but results in an error

The problem is that the svc/holds script requires
circulate_remaining_permissions.

To test:
- Create 2 staff users with and without circulate_remaining_permissions
  Both need borrowers permission
- Go to the details tab in a patron's account who has holds
- Verify that you get a datatables error for the staff patron without
  circulate_remaining_permissions
- Apply patch
- Verify that now the holds tab is no longer displayed for this patron

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 11:21:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 09:21:27 +0000
Subject: [Koha-bugs] [Bug 20794] Don't show holds tab when user doesn't have
 circulate_remaining_permissions
In-Reply-To: <bug-20794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20794-70-ZvtvQ6B6cn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20794

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 11:32:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 09:32:08 +0000
Subject: [Koha-bugs] [Bug 20756] OPAC "Share list" button should be styled
	with an icon
In-Reply-To: <bug-20756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20756-70-08OnYMXiEC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x and will be in 18.05.01

A minor cosmetic improvement that shouldn't confuse existing users, backported,
thanks all.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 11:34:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 09:34:02 +0000
Subject: [Koha-bugs] [Bug 20851] Missing module in
	circ/article-request-slip.pl
In-Reply-To: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20851-70-aoRofLx2dI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch has been pushed to 18.05.x and will be in 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 11:42:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 09:42:11 +0000
Subject: [Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
In-Reply-To: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20906-70-d9iBj9TR6H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
           Severity|normal                      |trivial
           Priority|P5 - low                    |P4

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 12:28:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 10:28:07 +0000
Subject: [Koha-bugs] [Bug 20832] Opac user page crash when there is an
 overdue fine and not any rental charge for a patron
In-Reply-To: <bug-20832-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20832-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20832-70-iyW461LKex@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20832

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 12:28:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 10:28:09 +0000
Subject: [Koha-bugs] [Bug 20832] Opac user page crash when there is an
 overdue fine and not any rental charge for a patron
In-Reply-To: <bug-20832-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20832-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20832-70-eB9CBxquql@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20832

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75624|0                           |1
        is obsolete|                            |

--- Comment #2 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 75945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75945&action=edit
Bug 20832: Fix opac user profile page when there is overdue fine and no rental
charge

Test plan:
0) Do not apply the patch
1) Have an overdue fine linked with specific item currently checked out
to your patron
2) Do not have any unpaid rental fees
3) Go to this patron profile in opac - page opac-user.pl
4) The page crashes with "Can't call method "get_column" on an undefined
value at
/usr/share/koha/opac/cgi-bin/opac/opac-user.pl line 217" in log
5) Apply the patch
6) Restart plack
7) The page should working and show the right amounts for fines

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 12:52:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 10:52:29 +0000
Subject: [Koha-bugs] [Bug 18639] Separate replacement cost and retail price
 fields in acquisitions
In-Reply-To: <bug-18639-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18639-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18639-70-hQmXja1oCL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639

--- Comment #8 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 75946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75946&action=edit
patch to rename field in Koha/EDI.pm

Change the column name in order creation to match schema name change

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 14:36:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 12:36:43 +0000
Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons
	payments/fines
In-Reply-To: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12310-70-6ef9EBqwaa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

--- Comment #98 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Created attachment 75947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75947&action=edit
Bug 12310: Decimal separator issues: fixes in fines

The main goal is to prevent
- x100 or /100 of the amounts
- decimal part truncation

Fixes Bug 19521 - Partial fine payment is not working with comma decimal
separator

Bonuses:
- Gets rid of the spaces, currency symbols, names (EUR)
  There is nothing specific about currency symbols is this patch.
  It just removes everything that is not a digit a minus or a separator.

It handles:
- by default comma and dot as decimal separators on the same instance
- dot or comma as thousands separators if choose to use only one of them
    as decimal separator. See DecimalSeparators syspref.
- minuses, doesn't remove them
- non-decimal values: it doesn't touch them

== Test plan ==
1. Use a translation of the staff interface if possible.
2. When you pay an existing fine (more details in the next steps if needed).
     Check that you can't enter any string except like "XX.XX" (examples in
     Annex 1) without having an issue after validation. (x100,
     truncation, etc)
3. Apply this patch
4. run ~/src/installer/data/mysql/updatedatabase.pl
5. In the manual invoice (cgi-bin/koha/members/maninvoice.pl)
6. Apply the annex 1 to the "Amount" field
7. When paying a fine (cgi-bin/koha/members/paycollect.pl)
8. Click on "Pay amount" to go to the page to pay all fines
9. Apply the annex 1 to the "Collect from patron" field
10. Click on "Pay" to go to the page to pay fine
11. Apply the annex 1 to the "Collect from patron" field
12. Go to "Create manual credit" (staff://cgi-bin/koha/members/mancredit.pl)
13. Apply the annex 1 to the "Amount" field
14. If you have ideas of stuff to try to find *regressions* from the previous
    versions, then try. You might spare librarian tears by finding something
    before it's released. (and prevent me from having bounty on my head)
15. Express your happiness. This is important, otherwise the sign off spell
won't
    work! The details of expressing your happiness depend on your culture and
    habits.

=== Annex 1: Subpart for each concerned page ===
1. Set DecimalSeparators syspref to ",."
2. Input "12,34"
3. Press the "Tab/Tabulation" key. It will unfocus the field and trigger the
     conversion. Validating the form does the same but it's a trick to test
more
     quickly by not switching to another page.
4. The value should have been converted to 12.34
5. What follows is just a list of examples. They don't have to be tried on each
     field.
6. Do the same with "12,34 EUR" and ensure that it's converted to "12,34"
7. Same with "EUR 12.34" -> "12.34"
8. "EUR 12.34?hi lyonthree" -> "12.34"
9. "123 456,7" -> "123456.7"
10. "2" -> "2"
11. "2,0" -> "2.0"
12. "-1'345.95" -> "-1345.95"
13. ",1234" -> ".1234"
14. Set DecimalSeparators syspref to ","
15. Reload the page with the form
16. "1.000" -> "1000"
17. "1.000.000,10" -> "1000000.10"
18. Set DecimalSeparators syspref to "."
19. Reload the page with the form
20. "1,000" -> "1000"
21. "1,000,000.10" -> "1000000.10"
22. Validate the form and check that the final value with the dot was
      well handled.
23. Think about Koalas and smile. ???

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 14:36:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 12:36:48 +0000
Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons
	payments/fines
In-Reply-To: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12310-70-pXPJN4PJXO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

--- Comment #99 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Created attachment 75948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75948&action=edit
Bug 12310: (follow-up) Keep the example text in fines

This puts the example text back in with the correct decimal
separator. The example uses the first char of the syspref.

TEST PLAN
---------
1) set the I18N/L10N DecimalSeparators syspref to ","
2) go to a patron's fines tab.
3) open Create manual invoice and Create manual credit tabs
4) check both tabs
   -- Example: 5.00 appears
5) apply this patch
6) reload the page and check both create tabs.
   -- Example: 5,12 appears
7) set the I18N/L10N DecimalSeparators syspref to ".,"
8) go back and check both tabs.
   -- Example: 5.12 appears (only the first separator is picked)
9) optionnal: run koha qa test tools

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 14:36:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 12:36:54 +0000
Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons
	payments/fines
In-Reply-To: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12310-70-LoXs1YUgMM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

--- Comment #100 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Created attachment 75949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75949&action=edit
Bug 12310: (QA follow-up) Prevent updatedatabase noise

Added IGNORE into the SQL statement.
TEST PLAN
---------
run the atomic update multiple times.
-- noise
apply patch
run the atomic update multiple times.
-- no noise

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 14:36:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 12:36:59 +0000
Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons
	payments/fines
In-Reply-To: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12310-70-XQLiA2gle4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

--- Comment #101 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Created attachment 75950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75950&action=edit
Bug 12310: (follow-up) Fix forgotten writeoff amount field

This is a follow up for this forgotten field.
See main patch more details.

== Test plan ==
1. Use a translation of the staff interface if possible.
2. Go to a patrons's page ? fines ? pay fines
3. Click on "Write off"
    This assumes an existing debt. Which should exists if you just
    tested the previous patches.
4. If you enter "1,50", the writeoff amount saved is only 1.
     This is the bug.
5. Apply this patch
6. run ~/src/installer/data/mysql/updatedatabase.pl
7. Refresh the page
8. Retry the write off.
     Apply the annex 1 to the "Writeoff amount" field
9. It works! \o/

=== Annex 1: Subpart for each concerned page ===
1. Set DecimalSeparators syspref to ",."
2. Input "12,34"
3. Press the "Tab/Tabulation" key. It will unfocus the field and trigger the
     conversion. Validating the form does the same but it's a trick to test
more
     quickly by not switching to another page.
4. The value should have been converted to 12.34
5. Do the same with "12,34 EUR" and ensure that it's converted to "12,34"
   Same with "EUR 12.34" -> "12.34"
6. "EUR 12.34?thanks lyonthree" -> "12.34"
7. "123 456,7" -> "123456.7"
8.. "2" -> "2"
9.. "2,0" -> "2.0"
10. "-1'345.95" -> "-1345.95"
11. ",1234" -> ".1234"
12. Set DecimalSeparators syspref to ","
13. Reload the page with the form
14. "1.000" -> "1000"
15. "1.000.000,10" -> "1000000.10"
16. Set DecimalSeparators syspref to "."
17. Reload the page with the form
18. "1,000" -> "1000"
19. "1,000,000.10" -> "1000000.10"
20. Validate the form and check that the final value with the dot was
21    well handled.
22. Think about Koalas and smile. ???

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 14:37:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 12:37:04 +0000
Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons
	payments/fines
In-Reply-To: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12310-70-peEQC0AdTh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

--- Comment #102 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Created attachment 75951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75951&action=edit
Bug 12310: (QA follow-up) Fix typo: unformating ? unformatting

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 14:37:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 12:37:09 +0000
Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons
	payments/fines
In-Reply-To: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12310-70-m8Shd2GCdr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

--- Comment #103 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Created attachment 75952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75952&action=edit
Bug 12310: (follow-up) Complete DecimalSeparators syspref description

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 14:38:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 12:38:18 +0000
Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons
	payments/fines
In-Reply-To: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12310-70-3HyEZWngTj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75130|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 14:38:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 12:38:21 +0000
Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons
	payments/fines
In-Reply-To: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12310-70-qI6w9TT8jA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75129|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 14:38:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 12:38:24 +0000
Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons
	payments/fines
In-Reply-To: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12310-70-zwAL4QqeWK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75128|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 14:38:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 12:38:27 +0000
Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons
	payments/fines
In-Reply-To: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12310-70-DMkNcoGsZl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75127|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 15:04:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 13:04:23 +0000
Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons
	payments/fines
In-Reply-To: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12310-70-klbt7h6qGS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 16:13:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 14:13:08 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-CXwyGeAs2P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #76 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 75953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75953&action=edit
Bug 17656: predication table - check all issues with same data-dow

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 16:13:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 14:13:42 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-FwgXjTx8dK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 16:15:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 14:15:55 +0000
Subject: [Koha-bugs] [Bug 10858] Browse selected biblios - OPAC
In-Reply-To: <bug-10858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10858-70-n6LsECoHmi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Patch doesn't apply
                 CC|                            |nicolas.legrand at bulac.fr

--- Comment #126 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
failed with new JS name scheme.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 16:30:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 14:30:17 +0000
Subject: [Koha-bugs] [Bug 20910] New: 773$g not displayed if $0 is present
Message-ID: <bug-20910-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20910

            Bug ID: 20910
           Summary: 773$g not displayed if $0 is present
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: MARC Bibliographic data support
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

If the $0 subfield is present (EasyAnalytics) the $g subfield is not displayed
as in other display modes. This is probably a minor mistake in the XSLT logic.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 16:33:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 14:33:48 +0000
Subject: [Koha-bugs] [Bug 11849] EasyAnalytics: consolidate display of
 analytic/bound-with analytic item links
In-Reply-To: <bug-11849-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11849-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11849-70-riqSiIvzSt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11849

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20910

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 16:33:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 14:33:48 +0000
Subject: [Koha-bugs] [Bug 5528] Analytical records support
In-Reply-To: <bug-5528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5528-70-398V7AYZxe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5528

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20910

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 16:33:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 14:33:48 +0000
Subject: [Koha-bugs] [Bug 20910] 773$g not displayed if $0 is present
In-Reply-To: <bug-20910-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20910-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20910-70-IrzIGtPDX4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20910

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=11849,
                   |                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=5528
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 16:42:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 14:42:51 +0000
Subject: [Koha-bugs] [Bug 14959] Support for Library Communications
	Framework (LCF)
In-Reply-To: <bug-14959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14959-70-B3xX9JJdAL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14959

Sally Healey <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 16:44:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 14:44:47 +0000
Subject: [Koha-bugs] [Bug 19523] Koha::Cache changes not passed to all plack
 workers with in-memory caching.
In-Reply-To: <bug-19523-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19523-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19523-70-cnA6ttCgM1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19523

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lari.taskula at jns.fi
  Attachment #69325|0                           |1
        is obsolete|                            |

--- Comment #3 from Lari Taskula <lari.taskula at jns.fi> ---
Comment on attachment 69325
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69325
Bug 19532: Some fiddly fixes

Removed patch from another bug :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 16:49:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 14:49:29 +0000
Subject: [Koha-bugs] [Bug 20897] Add generic cronjob to run plugins with a
 'cronjob' method
In-Reply-To: <bug-20897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20897-70-nM6HmvNf0C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20897

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 16:49:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 14:49:45 +0000
Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons
	payments/fines
In-Reply-To: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12310-70-I5s6RrF3Wc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75947|0                           |1
        is obsolete|                            |

--- Comment #104 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Created attachment 75954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75954&action=edit
Bug 12310: Decimal separator issues: fixes in fines

The main goal is to prevent
- x100 or /100 of the amounts
- decimal part truncation

Fixes Bug 19521 - Partial fine payment is not working with comma decimal
separator

Bonuses:
- Gets rid of the spaces, currency symbols, names (EUR)
  There is nothing specific about currency symbols is this patch.
  It just removes everything that is not a digit a minus or a separator.

It handles:
- by default comma and dot as decimal separators on the same instance
- dot or comma as thousands separators if choose to use only one of them
    as decimal separator. See DecimalSeparators syspref.
- minuses, doesn't remove them
- non-decimal values: it doesn't touch them

== Test plan ==
1. Use a translation of the staff interface if possible.
2. When you pay an existing fine (more details in the next steps if needed).
     Check that you can't enter any string except like "XX.XX" (examples in
     Annex 1) without having an issue after validation. (x100,
     truncation, etc)
3. Apply this patch
4. run ~/src/installer/data/mysql/updatedatabase.pl
5. In the manual invoice (cgi-bin/koha/members/maninvoice.pl)
6. Apply the annex 1 to the "Amount" field
7. When paying a fine (cgi-bin/koha/members/paycollect.pl)
8. Click on "Pay amount" to go to the page to pay all fines
9. Apply the annex 1 to the "Collect from patron" field
10. Click on "Pay" to go to the page to pay fine
11. Apply the annex 1 to the "Collect from patron" field
12. Go to "Create manual credit" (staff://cgi-bin/koha/members/mancredit.pl)
13. Apply the annex 1 to the "Amount" field
14. If you have ideas of stuff to try to find *regressions* from the previous
    versions, then try. You might spare librarian tears by finding something
    before it's released. (and prevent me from having bounty on my head)
15. Express your happiness. This is important, otherwise the sign off spell
won't
    work! The details of expressing your happiness depend on your culture and
    habits.

=== Annex 1: Subpart for each concerned page ===
1. Set DecimalSeparators syspref to ",."
2. Input "12,34"
3. Press the "Tab/Tabulation" key. It will unfocus the field and trigger the
     conversion. Validating the form does the same but it's a trick to test
more
     quickly by not switching to another page.
4. The value should have been converted to 12.34
5. What follows is just a list of examples. They don't have to be tried on each
     field.
6. Do the same with "12,34 EUR" and ensure that it's converted to "12,34"
7. Same with "EUR 12.34" -> "12.34"
8. "EUR 12.34?hi lyonthree" -> "12.34"
9. "123 456,7" -> "123456.7"
10. "2" -> "2"
11. "2,0" -> "2.0"
12. "-1'345.95" -> "-1345.95"
13. ",1234" -> ".1234"
14. Set DecimalSeparators syspref to ","
15. Reload the page with the form
16. "1.000" -> "1000"
17. "1.000.000,10" -> "1000000.10"
18. Set DecimalSeparators syspref to "."
19. Reload the page with the form
20. "1,000" -> "1000"
21. "1,000,000.10" -> "1000000.10"
22. Validate the form and check that the final value with the dot was
      well handled.
23. Think about Koalas and smile. ???

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 16:49:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 14:49:50 +0000
Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons
	payments/fines
In-Reply-To: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12310-70-7ZDw5tRKGP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75948|0                           |1
        is obsolete|                            |

--- Comment #105 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Created attachment 75955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75955&action=edit
Bug 12310: (follow-up) Keep the example text in fines

This puts the example text back in with the correct decimal
separator. The example uses the first char of the syspref.

TEST PLAN
---------
1) set the I18N/L10N DecimalSeparators syspref to ","
2) go to a patron's fines tab.
3) open Create manual invoice and Create manual credit tabs
4) check both tabs
   -- Example: 5.00 appears
5) apply this patch
6) reload the page and check both create tabs.
   -- Example: 5,12 appears
7) set the I18N/L10N DecimalSeparators syspref to ".,"
8) go back and check both tabs.
   -- Example: 5.12 appears (only the first separator is picked)
9) optionnal: run koha qa test tools

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 16:49:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 14:49:56 +0000
Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons
	payments/fines
In-Reply-To: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12310-70-OnMO0nRXyX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75949|0                           |1
        is obsolete|                            |

--- Comment #106 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Created attachment 75956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75956&action=edit
Bug 12310: (QA follow-up) Prevent updatedatabase noise

Added IGNORE into the SQL statement.
TEST PLAN
---------
run the atomic update multiple times.
-- noise
apply patch
run the atomic update multiple times.
-- no noise

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 16:50:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 14:50:01 +0000
Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons
	payments/fines
In-Reply-To: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12310-70-xoNRnssDLK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75950|0                           |1
        is obsolete|                            |

--- Comment #107 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Created attachment 75957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75957&action=edit
Bug 12310: (follow-up) Fix forgotten writeoff amount field

This is a follow up for this forgotten field.
See main patch more details.

== Test plan ==
1. Use a translation of the staff interface if possible.
2. Go to a patrons's page ? fines ? pay fines
3. Click on "Write off"
    This assumes an existing debt. Which should exists if you just
    tested the previous patches.
4. If you enter "1,50", the writeoff amount saved is only 1.
     This is the bug.
5. Apply this patch
6. run ~/src/installer/data/mysql/updatedatabase.pl
7. Refresh the page
8. Retry the write off.
     Apply the annex 1 to the "Writeoff amount" field
9. It works! \o/

=== Annex 1: Subpart for each concerned page ===
1. Set DecimalSeparators syspref to ",."
2. Input "12,34"
3. Press the "Tab/Tabulation" key. It will unfocus the field and trigger the
     conversion. Validating the form does the same but it's a trick to test
more
     quickly by not switching to another page.
4. The value should have been converted to 12.34
5. Do the same with "12,34 EUR" and ensure that it's converted to "12,34"
   Same with "EUR 12.34" -> "12.34"
6. "EUR 12.34?thanks lyonthree" -> "12.34"
7. "123 456,7" -> "123456.7"
8.. "2" -> "2"
9.. "2,0" -> "2.0"
10. "-1'345.95" -> "-1345.95"
11. ",1234" -> ".1234"
12. Set DecimalSeparators syspref to ","
13. Reload the page with the form
14. "1.000" -> "1000"
15. "1.000.000,10" -> "1000000.10"
16. Set DecimalSeparators syspref to "."
17. Reload the page with the form
18. "1,000" -> "1000"
19. "1,000,000.10" -> "1000000.10"
20. Validate the form and check that the final value with the dot was
21    well handled.
22. Think about Koalas and smile. ???

Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 16:50:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 14:50:04 +0000
Subject: [Koha-bugs] [Bug 20899] Patron name not showing on issuehistory.pl
In-Reply-To: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20899-70-MIFTqF2gu3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 16:50:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 14:50:08 +0000
Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons
	payments/fines
In-Reply-To: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12310-70-qWVhho8lJX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

--- Comment #108 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Created attachment 75958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75958&action=edit
Bug 12310: (QA follow-up) Fix typo: unformating ? unformatting

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 16:50:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 14:50:13 +0000
Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons
	payments/fines
In-Reply-To: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12310-70-wC1y0JLCQd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75952|0                           |1
        is obsolete|                            |

--- Comment #109 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Created attachment 75959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75959&action=edit
Bug 12310: (follow-up) Complete DecimalSeparators syspref description

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 16:54:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 14:54:15 +0000
Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used
 in the description
In-Reply-To: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20891-70-1U3jmw0726@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 17:08:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 15:08:08 +0000
Subject: [Koha-bugs] [Bug 20910] 773$g not displayed if $0 is present
In-Reply-To: <bug-20910-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20910-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20910-70-kOTIwUov9q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20910

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 75960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75960&action=edit
Bug 20910: Display 773$g when $0 is present too

This patch makes the XSLT logic add the $g subfield in the 773 display
in both the OPAC and staff interface MARC21 record detail pages.

The XSLT chooses between different ways to create the link for the
related content, but then it only adds the $g in two of the cases.
There's no obvious reason for a different display.

To test:
- Have  a record with:

=773   $tHost title $gp4.

=> SUCCESS: Notice the Detail view shows:
  In: Host title p4.

- Have another record with:

=773   $tHost title $gp4. $w100
- Enable UseControlNumber (only to cover the case):
=> SUCCESS: Notice the detail view shows
  In: Host title p4.

- Have another record with:

=773   $tHost title $gp4. $0456

=> FAIL: The Detail view doesn't show p4.
- Apply this patch
- Reload
=> SUCCESS: The Detail view displays p4.!
- Sign off :-D

Sponsored-by: Escuela de Orientacion Lacaniana

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 17:08:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 15:08:13 +0000
Subject: [Koha-bugs] [Bug 20910] 773$g not displayed if $0 is present
In-Reply-To: <bug-20910-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20910-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20910-70-NhmZLxCy1p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20910

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 75961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75961&action=edit
Bug 20910: Tidy 773 handling XSLT code

There's happiness too. You know.

Sponsored-by: Escuela de Orientacion Lacaniana

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 17:08:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 15:08:22 +0000
Subject: [Koha-bugs] [Bug 20910] 773$g not displayed if $0 is present
In-Reply-To: <bug-20910-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20910-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20910-70-A3DOLl40Oj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20910

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 17:24:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 15:24:36 +0000
Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons
	payments/fines
In-Reply-To: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12310-70-HwO3Vp7SV5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75951|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 17:31:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 15:31:32 +0000
Subject: [Koha-bugs] [Bug 20911] New: Search history page forms use 'GET'
 and this limits the number of entries that can be submitted
Message-ID: <bug-20911-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20911

            Bug ID: 20911
           Summary: Search history page forms use 'GET' and this limits
                    the number of entries that can be submitted
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Some users have lots of search history - when selecting all they create a url
that is too long for a 'GET' request. 

We should use 'POST'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 17:35:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 15:35:06 +0000
Subject: [Koha-bugs] [Bug 20911] Search history page forms use 'GET' and
 this limits the number of entries that can be submitted
In-Reply-To: <bug-20911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20911-70-aJUU1goQwS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20911

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 17:35:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 15:35:08 +0000
Subject: [Koha-bugs] [Bug 20911] Search history page forms use 'GET' and
 this limits the number of entries that can be submitted
In-Reply-To: <bug-20911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20911-70-8WEuQ3E54v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20911

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 75962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75962&action=edit
Bug 20911: Use 'POST' to submit search history forms

To test:
1 - Enable EnableOpacSearchHistory and EnableSearchHistory
2 - Do some searches
3 - View your search history in staff/opac
4 - Confirm you can delete single or multiple rows
5 - Confirm other page functionality has not changed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 17:47:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 15:47:58 +0000
Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit
	form
In-Reply-To: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20809-70-gY2kDTOiL1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 17:48:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 15:48:00 +0000
Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit
	form
In-Reply-To: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20809-70-AjOlXQLmD9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 75963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75963&action=edit
Bug 20809: Link patron image to patron image add/edit form

This patch modifies an include file so that it is possible with edit a
patron's image on any patron-related page which uses that include.

To test you must have the patronimages system preference enabled.

Apply the patch and open any patron record for viewing.

 - Hover the mouse over the patron image.

   - If the patron has a previously-defined patron image, should you see
     an "Edit" button appear. Clicking the button should display a modal
     dialog titled "Edit patron image." Test that the "Upload,"
     "Delete," and "Cancel" buttons work correctly.

   - If a patron has no patron image defined, you should see an "Add"
     button appear. Clicking the button should display a modal
     dialog titled "Edit patron image." Test that the "Upload,"
     "Delete," and "Cancel" buttons work correctly.

This process should work from any page which shows the patron sidebar:
Check out, Details, Fines, Routing lists, Circulation history, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 17:57:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 15:57:56 +0000
Subject: [Koha-bugs] [Bug 13680] Items list on edit items page separates add
 items form from header and sidebar
In-Reply-To: <bug-13680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13680-70-r9MvRgmcCW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680

--- Comment #12 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 75964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75964&action=edit
Screenshot showing views as dropdown menu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 17:58:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 15:58:20 +0000
Subject: [Koha-bugs] [Bug 13680] Items list on edit items page separates add
 items form from header and sidebar
In-Reply-To: <bug-13680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13680-70-J9JRQkuzsl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680

--- Comment #13 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 75965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75965&action=edit
Screenshot showing entry form in modal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 18:10:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 16:10:58 +0000
Subject: [Koha-bugs] [Bug 20911] Search history page forms use 'GET' and
 this limits the number of entries that can be submitted
In-Reply-To: <bug-20911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20911-70-rSxg1YRkVy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20911

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 18:11:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 16:11:00 +0000
Subject: [Koha-bugs] [Bug 20911] Search history page forms use 'GET' and
 this limits the number of entries that can be submitted
In-Reply-To: <bug-20911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20911-70-zI5LbbjNmw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20911

Jesse Maseto <jesse at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75962|0                           |1
        is obsolete|                            |

--- Comment #2 from Jesse Maseto <jesse at bywatersolutions.com> ---
Created attachment 75966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75966&action=edit
Bug 20911: Use 'POST' to submit search history forms

To test:
1 - Enable EnableOpacSearchHistory and EnableSearchHistory
2 - Do some searches
3 - View your search history in staff/opac
4 - Confirm you can delete single or multiple rows
5 - Confirm other page functionality has not changed

Signed-off-by: Ed Veal <eveal at mckinneytexas.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 18:27:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 16:27:11 +0000
Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons
	payments/fines
In-Reply-To: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12310-70-UEj1cVa6DN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |In Discussion

--- Comment #110 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Rebased and solved simple conflicts.

(In reply to Marcel de Rooy from comment #97)
> OK If you feel the name is good enough

As most active people here have more experience with the code and the English
language, I'll happily change to any suggestion. (even if I might ask for
confirmation if I feel that it's not that clear or ambiguous ^^)

> Just do not use formating, single t :)

Fixed ^^

> > > So thousands separators come at the expense of handling both dots and commas.
> > > Still opt for something that is more understandable.
> > I'm not sure to understand. Is the the current state the patch on this topic
> > acceptable?
> Would it be clearer if you would say that you c/should not use characters
> from the DecimalSeparator pref also as thousands separator?

completed: What do you think of the current version?
TODO wait answer, blocking question

Does the followups require all the fields to be retested? And put back the
patch to "Needs Signoff".
TODO wait answer, blocking question

> > When this bug and bug 18723[1] will be in master there won't be more
> > fragmentation than today.
> > And less actually.
> > 
> > locally: acquisitions and payments/fines will be internally less fragmented.
> >   as there are currently different behaviors in *successive pages* [2]
> > globally: the new approach replaces an existing one (I checked that it not
> > used elsewhere)
> >   see moneyFormat function.
> >  
> > https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75127&action=diff
> > 
> > So, are these changes a step in the right direct worth of begin integrated?
> Well, I just hope so. But willing to follow your argument. Feel free to
> submit the tiny adjustments you intend to, and I will try to finish here.

Great, I think every feedback has been addressed if I'm not mistaken :)
Thanks again for you time!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 18:37:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 16:37:01 +0000
Subject: [Koha-bugs] [Bug 13680] Items list on edit items page separates add
 items form from header and sidebar
In-Reply-To: <bug-13680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13680-70-473HhDsZ2n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680

--- Comment #14 from Christopher Brannon <cbrannon at cdalibrary.org> ---
I love it!  I'm not a cataloger, but I think it is a MASSIVE improvement as a
modal.  I would definitely go that direction.  I also like the changes with
View.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 19:25:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 17:25:22 +0000
Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display
In-Reply-To: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11375-70-1fiuzRwJsW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 19:25:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 17:25:25 +0000
Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display
In-Reply-To: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11375-70-2wUsv6yLji@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375

--- Comment #9 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 75967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75967&action=edit
Bug 11375: Improve patrons permissions display

This patch updates the patron permissions interface in order to
emphasize permission descriptions (which can be translated) over
permission code (which cannot).

The tree structure (and jQuery plugin) is removed, and permissions are
displayed in a table-like way. Sub-permissions are shown or hidden with
a link.

A free-text filter is added to the top for narrowing the list by
keyword.

To test, apply the patch and clear your browser cache if necessary.

 - Open the "Set permissions" page for any patron.
 - Confirm that the filter works correctly to show only lines which
   match your entry
   - Note that the superlibrarian line stays visible all the time. This
     is to make it clearer that sub-permissions cannot be selected if
     superlibrarian is checked.
 - Check the superlibrarain "hint" text for clarity.
 - Test the show/hide controls.
 - Test that checking a "parent" permission displays the
   sub-permissions.
 - Test that changing and saving permissions works correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 11 19:25:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 17:25:38 +0000
Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display
In-Reply-To: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11375-70-PMxTn6fhOD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 00:40:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jun 2018 22:40:22 +0000
Subject: [Koha-bugs] [Bug 20899] Patron name not showing on issuehistory.pl
In-Reply-To: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20899-70-rQBQgYJZZl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 06:00:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 04:00:09 +0000
Subject: [Koha-bugs] [Bug 20912] New: Rental Fees based on Time Period
Message-ID: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

            Bug ID: 20912
           Summary: Rental Fees based on Time Period
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: kyle at bywatersolutions.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Work to be done:
1) Add new column for daily rental fee to itemtypes
2) Add new syspref to control if daily rental fee includes holidays
3) Add code to C4::Circulation::AddIssue that will check the item's type to
determine if it has a daily rental fee
a) If it does, the rental fee will be calculated in full as "checkout length"
times "daily rental fee", less holidays if syspref is set to ignore them
4) Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 07:14:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 05:14:32 +0000
Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when
 adding/updating bibliographic records
In-Reply-To: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18138-70-p1giwB7XGY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

Hugh Rundle <hughr at brimbank.vic.gov.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hughr at brimbank.vic.gov.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 07:20:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 05:20:08 +0000
Subject: [Koha-bugs] [Bug 13680] Items list on edit items page separates add
 items form from header and sidebar
In-Reply-To: <bug-13680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13680-70-2065qxsk7E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I like the modal, but not sure about the views in the menu. I often get asked
in training on how to get to see the record after cataloguing and always point
out the normal tab as the quickest option. This would add an extra click and
make it less prominent.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 07:37:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 05:37:13 +0000
Subject: [Koha-bugs] [Bug 20913] New: allow multiple if/unless statements in
 MARC modification template actions by adding AND/OR qualifiers
Message-ID: <bug-20913-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20913

            Bug ID: 20913
           Summary: allow multiple if/unless statements in MARC
                    modification template actions by adding AND/OR
                    qualifiers
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: hughr at brimbank.vic.gov.au
        QA Contact: testopia at bugs.koha-community.org

Actions in MARC Modification templates have the following syntax:

[action] all/first [field] (plus optionally... if/unless [field] [conditional])

But there is only the option for one if/unless. This is usually enough, but
sometimes it would be useful to be able to add another qualifier linked with
and/or.

For example, libraries importing embedded items might want to apply a different
shelf location or call number depending on the home location. In this case,
they would want to do something like:

Add/Update field '952c' with value 'Animals' 
IF field '984c' matches /^(57+[0-9]+.?.*)/
AND 
IF field '952a' matches 'Main'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 09:07:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 07:07:54 +0000
Subject: [Koha-bugs] [Bug 19972] Holds to pull should honor syspref
	"item-level_itypes"
In-Reply-To: <bug-19972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19972-70-7fDBgKV5xI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972

--- Comment #15 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Oups, I should have wrote ?and confirm that a new sign off should **not** be
required?

Thanks Jonathan for still understanding ^^ and having moved the patch forward!
:D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 10:05:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 08:05:19 +0000
Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
In-Reply-To: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20664-70-ZmLaoMfTzT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74873|0                           |1
        is obsolete|                            |

--- Comment #4 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 75968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75968&action=edit
Bug 20664: Optimize retrieval of biblio and item data

Optimizes embedding of item data in MARC and fixes several bottlenecks
encountered while profiling OAI-PMH and exporting of records. There are three
ways this is accomplished:

1.) Use state variables to hold prepared SQL statements so that the preparation
is done only once.
2.) Create optimized method for fetching item fields for MARC embedding.
3.) Use the cache service more and where repeated calls are made.

Test plan:

1.) Before applying the patch, time an export_records.pl run for a set of
biblios that also have items. Run it a couple of times to account for initial
slowness and possible fluctuations. For example:

time misc/export_records.pl --record-type bibs --starting_biblionumber 960000
--ending_biblionumber 965000 --format xml --filename unoptimized.xml

2.) Apply the patch.

3.) Time the export process again with a different output file:

time misc/export_records.pl --record-type bibs --starting_biblionumber 960000
--ending_biblionumber 965000 --format xml --filename optimized.xml

4.) Verify that the optimized process is faster.

5.) Compare the resulting export files to make sure they're identical:

diff -u unoptimized.xml optimized.xml

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 10:08:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 08:08:07 +0000
Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
In-Reply-To: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20664-70-b0W8SLemHT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664

--- Comment #5 from Ere Maijala <ere.maijala at helsinki.fi> ---
Latest version fixes a mistake in the itemnumber check. Also rebased on master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 10:08:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 08:08:12 +0000
Subject: [Koha-bugs] [Bug 20885] Transferring an item on hold results in
 bypassing restrictions,
 actually doing the transfer and can be piled up if repeated
In-Reply-To: <bug-20885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20885-70-Y2HC3VOFyq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20885

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
           Priority|P5 - low                    |P4

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 12:58:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 10:58:35 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-rcEq2GztAd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #101 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Marcel de Rooy from comment #86)

> deleted_at should probably be better: deleted_on; we also have updated_on

Not sure I agree with the logic here.. I would say the field within the patron
(borrowers) table is misnamed rather than the other way around.. _on suggests
date only precision whereas _at suggests a higher precision including time.  As
the field is a datetime/timestamp rather than a simple date I'd go with _at
here personally.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 14:16:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 12:16:30 +0000
Subject: [Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR
In-Reply-To: <bug-17809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17809-70-3YPTa4RS3A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809

--- Comment #34 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
What next ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 14:39:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 12:39:01 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-Q329KiO1wD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #102 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
`installer/data/mysql/sysprefs.sql` still references deletedbiblio in the
OAI-PMH:DeletedRecord preference.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 14:51:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 12:51:40 +0000
Subject: [Koha-bugs] [Bug 13325] Add logs for budgets and funds
In-Reply-To: <bug-13325-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13325-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13325-70-CzvbYuiQql@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325

imelda.bennis at educampus.ie changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |imelda.bennis at educampus.ie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 14:53:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 12:53:18 +0000
Subject: [Koha-bugs] [Bug 10393] To add some shortcuts to acquisitions main
 screen e.g. RECEIVE SHIPMENT and the FILTER BOX
In-Reply-To: <bug-10393-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10393-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10393-70-2jeSlao2aC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10393

imelda.bennis at educampus.ie changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |imelda.bennis at educampus.ie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 14:55:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 12:55:53 +0000
Subject: [Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR
In-Reply-To: <bug-17809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17809-70-xioejdSycZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809

--- Comment #35 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Waiting for concerns on comment 31 to be addressed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 15:33:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 13:33:21 +0000
Subject: [Koha-bugs] [Bug 20914] New: Internal server error in OPAC
Message-ID: <bug-20914-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20914

            Bug ID: 20914
           Summary: Internal server error in OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: stefan.berndtsson at ub.gu.se
        QA Contact: testopia at bugs.koha-community.org

opac-user.pl tries to fetch an invalid column when calculating fines.

my $rental_fines = Koha::Account::Lines->search(
    {
        borrowernumber    => $patron->borrowernumber,
        amountoutstanding => { '>' => 0 },
        accounttype       => 'Rent',
        itemnumber        => $issue->{itemnumber}
    },
    {
        select => [ { sum => 'amountoutstanding' } ],
        as     => ['rental_fines']
    }
);
$issue->{rentalfines} = $charges->count ?
$charges->next->get_column('rental_fines') : 0;

This code fetches the column "rental_fines" into the variable "$rental_fines",
but then tries
to read that column data from a different variable ("$charges").

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 15:35:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 13:35:10 +0000
Subject: [Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
In-Reply-To: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20906-70-BZ1IqaToRs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|trivial                     |major

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Upping severity, we need it pushed ASAP

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 15:50:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 13:50:04 +0000
Subject: [Koha-bugs] [Bug 20832] Opac user page crash when there is an
 overdue fine and not any rental charge for a patron
In-Reply-To: <bug-20832-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20832-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20832-70-F6WK5tXoad@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20832

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Keywords|                            |rel_18_05_candidate
         Depends on|                            |12001

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Silly copy/paste error caused by
  commit 51aa6db46c604aa202a3d8f8e5028557480efbd5
  Bug 12001: Move GetMemberAccountRecords to the Koha namespace


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001
[Bug 12001] GetMemberAccountRecords slows down display of patron details and
checkout pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 15:50:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 13:50:04 +0000
Subject: [Koha-bugs] [Bug 12001] GetMemberAccountRecords slows down display
 of patron details and checkout pages
In-Reply-To: <bug-12001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12001-70-CqAjNz2Ui3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20832


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20832
[Bug 20832] Opac user page crash when there is an overdue fine and not any
rental charge for a patron
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 15:52:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 13:52:00 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-IDBFCV4Ady@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #103 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm going to let the _at vs _on piece pass as although I feel both set should
use _at rather than _on in the name of consistency _on is OK and switching to
_at could be done consistently at a later date.

However.. the atomicupdate is not currently idempotent... I'll convert it as a
QA followup.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 15:57:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 13:57:33 +0000
Subject: [Koha-bugs] [Bug 20832] Opac user page crash when there is an
 overdue fine and not any rental charge for a patron
In-Reply-To: <bug-20832-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20832-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20832-70-Bpw8haSGix@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20832

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |critical

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:01:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:01:19 +0000
Subject: [Koha-bugs] [Bug 20915] New: Use date --iso-8601 instead of date
 +%Y-%m-%d to be more readable an crontab friendly
Message-ID: <bug-20915-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20915

            Bug ID: 20915
           Summary: Use date --iso-8601 instead of date +%Y-%m-%d to be
                    more readable an crontab friendly
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: victor.grousset at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

Because in crontab you have to write ?date ?'+\%Y-\%m-\%d'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:02:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:02:03 +0000
Subject: [Koha-bugs] [Bug 20832] Opac user page crash when there is an
 overdue fine and not any rental charge for a patron
In-Reply-To: <bug-20832-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20832-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20832-70-j9mP2aBiiY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20832

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:02:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:02:07 +0000
Subject: [Koha-bugs] [Bug 20832] Opac user page crash when there is an
 overdue fine and not any rental charge for a patron
In-Reply-To: <bug-20832-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20832-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20832-70-2pBEfeUXvl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20832

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75945|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75969&action=edit
Bug 20832: Fix opac user profile page when there is overdue fine and no rental
charge

Test plan:
0) Do not apply the patch
1) Have an overdue fine linked with specific item currently checked out
to your patron
2) Do not have any unpaid rental fees
3) Go to this patron profile in opac - page opac-user.pl
4) The page crashes with "Can't call method "get_column" on an undefined
value at
/usr/share/koha/opac/cgi-bin/opac/opac-user.pl line 217" in log
5) Apply the patch
6) Restart plack
7) The page should working and show the right amounts for fines

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:04:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:04:08 +0000
Subject: [Koha-bugs] [Bug 20914] Internal server error in OPAC
In-Reply-To: <bug-20914-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20914-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20914-70-TKRr3uqb7U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20914

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---


*** This bug has been marked as a duplicate of bug 20832 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:04:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:04:08 +0000
Subject: [Koha-bugs] [Bug 20832] Opac user page crash when there is an
 overdue fine and not any rental charge for a patron
In-Reply-To: <bug-20832-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20832-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20832-70-eEOnk30i9t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20832

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |stefan.berndtsson at ub.gu.se

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
*** Bug 20914 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:07:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:07:48 +0000
Subject: [Koha-bugs] [Bug 20916] New: Add a staging tool to patron import
	tool
Message-ID: <bug-20916-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20916

            Bug ID: 20916
           Summary: Add a staging tool to patron import tool
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

It would be great that the tool allowed to see the batches, know what
borrowernumber was assigned, if there was a match, see a diff, etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:09:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:09:00 +0000
Subject: [Koha-bugs] [Bug 20915] Use date --iso-8601 instead of date
 +%Y-%m-%d to be more readable an crontab friendly
In-Reply-To: <bug-20915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20915-70-Z2tgWJkNI7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20915

--- Comment #1 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Created attachment 75970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75970&action=edit
Bug 20915: Use date --iso-8601 instead of date +%Y-%m-%d

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:09:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:09:27 +0000
Subject: [Koha-bugs] [Bug 20915] Use date --iso-8601 instead of date
 +%Y-%m-%d to be more readable an crontab friendly
In-Reply-To: <bug-20915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20915-70-YeSq5M0US8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20915

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:09:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:09:10 +0000
Subject: [Koha-bugs] [Bug 20915] Use date --iso-8601 instead of date
 +%Y-%m-%d to be more readable an crontab friendly
In-Reply-To: <bug-20915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20915-70-VqULIq3PLz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20915

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |victor.grousset at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:10:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:10:32 +0000
Subject: [Koha-bugs] [Bug 18213] Add language facets to Elasticsearch
In-Reply-To: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18213-70-sESfcOUOWj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73008|0                           |1
        is obsolete|                            |

--- Comment #18 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 75971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75971&action=edit
Bug 18213 - Add language facets to Elasticsearch

This patch add language as a facet to ES results - it adds
a new template plugin for languages to get the appropriate
description given an iso 639-2 code

To test:
1 - Make sure you have records with differing languages (in the MARC21 008
        field characters 35-37 or UNIMARC 101a)
2 - Apply patch
3 - Reload Elasticsearch settings:
http://localhost:8081/cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1
4 - Reindex your records
5 - Search for a phrase that will return results in several languages
6 - Verify you see factes correctly labelled for 'Language'
7 - Verify the facets work
8 - Verify both opac and staff results
9 - prove t/db_dependent/Languages.t

Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:10:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:10:40 +0000
Subject: [Koha-bugs] [Bug 18213] Add language facets to Elasticsearch
In-Reply-To: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18213-70-kaPk6udTHZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73009|0                           |1
        is obsolete|                            |

--- Comment #19 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 75972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75972&action=edit
Bug 18213 - DB Update (facet order)

Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:10:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:10:47 +0000
Subject: [Koha-bugs] [Bug 18213] Add language facets to Elasticsearch
In-Reply-To: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18213-70-bugP86V8vr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73010|0                           |1
        is obsolete|                            |

--- Comment #20 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 75973
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75973&action=edit
Bug 18213 - Add Template plugin and fix for C4/Languages

Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:10:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:10:55 +0000
Subject: [Koha-bugs] [Bug 18213] Add language facets to Elasticsearch
In-Reply-To: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18213-70-EyPfWvku9L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73011|0                           |1
        is obsolete|                            |

--- Comment #21 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 75974
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75974&action=edit
Bug 18213: (follow-up) Correctly sort facets

Previously we sorted alphabetically - that works for 1-9.
With a 10th facet category we should sort numerically

Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:11:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:11:24 +0000
Subject: [Koha-bugs] [Bug 18213] Add language facets to Elasticsearch
In-Reply-To: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18213-70-rLfFK2wK10@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |alex.arnaud at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:12:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:12:30 +0000
Subject: [Koha-bugs] [Bug 20915] Use date --iso-8601 instead of date
 +%Y-%m-%d to be more readable an crontab friendly
In-Reply-To: <bug-20915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20915-70-j8TySoO4Vi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20915

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:13:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:13:22 +0000
Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the
 logged in user library group
In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18403-70-Gx00ZJ7YmS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20899


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899
[Bug 20899] Patron name not showing on issuehistory.pl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:13:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:13:22 +0000
Subject: [Koha-bugs] [Bug 20899] Patron name not showing on issuehistory.pl
In-Reply-To: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20899-70-uxJ6fo18iF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |18403
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Caused by
  commit fa54100dffe092e606f79b15692eedaf78f42e45
  Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for
issuehistory]


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403
[Bug 18403] Hide patron information if not part of the logged in user library
group
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:14:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:14:48 +0000
Subject: [Koha-bugs] [Bug 20915] Use date --iso-8601 instead of date
 +%Y-%m-%d to be more readable and crontab friendly
In-Reply-To: <bug-20915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20915-70-EOgOSqMZhE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20915

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Use date --iso-8601 instead |Use date --iso-8601 instead
                   |of date +%Y-%m-%d to be     |of date +%Y-%m-%d to be
                   |more readable an crontab    |more readable and crontab
                   |friendly                    |friendly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:15:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:15:22 +0000
Subject: [Koha-bugs] [Bug 20899] Patron name not showing on issuehistory.pl
In-Reply-To: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20899-70-rOlyrqVQ2m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:15:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:15:25 +0000
Subject: [Koha-bugs] [Bug 20899] Patron name not showing on issuehistory.pl
In-Reply-To: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20899-70-UHwXGf2kuW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75975
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75975&action=edit
Bug 20899: Fix patron's name display

This is a follow-up for
  commit fa54100dffe092e606f79b15692eedaf78f42e45
  Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for
issuehistory]

We should use patron-title.inc to display (or hide) patron's info on the
checkout history view

Test plan:
Issue an item, go to the biblio, click the circulation history for this
tab.
Note that the patron's name is showing.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:16:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:16:10 +0000
Subject: [Koha-bugs] [Bug 20899] Patron name not showing on issuehistory.pl
In-Reply-To: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20899-70-jtU3KpS3rP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_18_05_candidate
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
            Version|18.05                       |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:15:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:15:58 +0000
Subject: [Koha-bugs] [Bug 20915] Use date --iso-8601 instead of date
 +%Y-%m-%d to be more readable and crontab friendly
In-Reply-To: <bug-20915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20915-70-aQGJEiv0z9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20915

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75970|0                           |1
        is obsolete|                            |

--- Comment #2 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Created attachment 75976
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75976&action=edit
Bug 20915: Use date --iso-8601 instead of date +%Y-%m-%d

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:17:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:17:30 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-vTFlZpX3UZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74407|0                           |1
        is obsolete|                            |

--- Comment #104 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 75977
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75977&action=edit
Bug 20271: merging delete biblio/items

The present bug merges the following tables:
deletedbiblio          -> biblio
deletedbiblioitems     -> biblioitems
deletedbiblio_metadata -> biblio_metadata
deleteditems           -> items

and adds a column deleted_at to signify time of deletion, if deleted

it replaces all occurrences of the mentioned occurences and uses
of mentioned deleted* tables

upgrade is handled by moving rows from deleted* tables to the live
ones. If all rows are moved, the corresponding tables are dropped.
If there are duplicates or conflicts (duplicate barcodes e.g.) they
reminders are left for scrutiny and table renamed to _deleted*

Test plan:

1) Make sure you have a db with at least a few deleted biblios,
   biblioitems and items.
2) Apply patch and run updatedatabase.pl
3) Make note of the db upgrade messages, if you get a message like:
   There were x deleteditems that could not be moved, please check
_deleteditems
   you should check the _deleteditems table and verify that they are
   actual conflicts
4) Click around in the web interface and make sure you can delete items
   and biblios
5) "Undelete" an item by NULLing the deleted_at column for an item
   and verify that it returns in interface (Not neccessary really)

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:17:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:17:34 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-LFdX08TwrW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74408|0                           |1
        is obsolete|                            |

--- Comment #105 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 75978
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75978&action=edit
Bug 20271: fix remaining tests

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:17:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:17:43 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-VUW6rqYWzX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74410|0                           |1
        is obsolete|                            |

--- Comment #107 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 75980
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75980&action=edit
Bug 20271: delete biblio and biblio_metadata in one go

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:17:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:17:39 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-qf14imI8R6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74409|0                           |1
        is obsolete|                            |

--- Comment #106 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 75979
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75979&action=edit
Bug 20271: update kohastructure.sql

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:17:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:17:48 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-2XnYqv5EX6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74411|0                           |1
        is obsolete|                            |

--- Comment #108 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 75981
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75981&action=edit
Bug 20271: remove comments regarding deleteditems and -biblio*

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:17:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:17:53 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-XFz13ERciB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74412|0                           |1
        is obsolete|                            |

--- Comment #109 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 75982
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75982&action=edit
Bug 20271: add atomic update

Bug 20271: disable foreign keys on deletedbiblio_metadata

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:17:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:17:50 +0000
Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets
In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18235-70-yMLoOmcFfU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #37 from Alex Arnaud <alex.arnaud at biblibre.com> ---
(In reply to Jonathan Druart from comment #35)
> Created attachment 74642 [details] [review]
> Bug 18235: Add unit tests for get_facetable_fields
> 
> rename atomic update file

Looks like this patch does not what it was named for. Atomic update file's name
is still Bug_xxxxxxx.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:17:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:17:58 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-95y3S8SmGZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74413|0                           |1
        is obsolete|                            |

--- Comment #110 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 75983
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75983&action=edit
Bug 20271: Use a single pass in the OAI-PMH provider

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:18:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:18:03 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-7LfdoDZ4Xw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74414|0                           |1
        is obsolete|                            |

--- Comment #111 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 75984
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75984&action=edit
Bug 20271: fix whitespace issues in C4::Items

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:18:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:18:08 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-OYhqxVyg3j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74415|0                           |1
        is obsolete|                            |

--- Comment #112 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 75985
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75985&action=edit
Bug 20271: print instead of warn unmovable items

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:18:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:18:12 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-g5DjjAKfsq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74416|0                           |1
        is obsolete|                            |

--- Comment #113 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 75986
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75986&action=edit
Bug 20271: atomicupdate - support mysql < 5.7 and address foreign key issues

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:18:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:18:17 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-S6lnq2i0WM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75265|0                           |1
        is obsolete|                            |

--- Comment #114 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 75987
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75987&action=edit
Bug 20271: (follow-up) DBIx schema changes

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:18:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:18:22 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-ZHkxa6VZq0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75897|0                           |1
        is obsolete|                            |

--- Comment #115 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 75988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75988&action=edit
Bug 20271: (QA follow-up): rename to deleted_on and various fixes

- renamed deleted_at => deleted_on
- removed failing sql in t/db_dependent/OAI/Server.t
- removed deprecated autoincrement checks in about.pl
- fixed errors in catalogue_stats.tt and catalogue_stats.pl

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Removed the DBIx schema changes. Please keep them separated.
We missed changes for Biblioitem btw. Adding them in follow-up.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:18:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:18:27 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-5e7y01P6Gr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75898|0                           |1
        is obsolete|                            |

--- Comment #116 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 75989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75989&action=edit
Bug 20271: (QA follow-up) DBIx schema changes

Please separate these changes from the other patches.
Note that Biblioitem was not in the last set of changes too.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:18:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:18:31 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-EbBRsIcDz6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75899|0                           |1
        is obsolete|                            |

--- Comment #117 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 75990
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75990&action=edit
Bug 20271: (QA follow-up) Additional about cleanup

Still found references to biblios and items in script and template.

Test plan:
Check about page again.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:18:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:18:36 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-kUBcNRyEdb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75910|0                           |1
        is obsolete|                            |

--- Comment #118 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 75991
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75991&action=edit
Bug 20271: (QA follow-up) Remove last occurrences of deleted_at

Trivial replace of deleted_at by deleted_on.

Test plan:
Run t/db_dependent/Koha/ItemTypes.t
Run t/db_dependent/Items_DelItemCheck.t
git grep -E "deleted_at\W"

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:18:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:18:40 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-4UxOmcss4t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #119 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 75992
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75992&action=edit
Bug 20271: (QA follow-up) Reword OAI-PMH:DeletedRecord systempref

The preference still refered to the deletedbiblio table made defunct by
this patchset.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:18:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:18:45 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-rzcQu8wVV2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #120 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 75993
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75993&action=edit
Bug 20271: (QA follow-up) Make the atomicupdate idempotent

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:19:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:19:45 +0000
Subject: [Koha-bugs] [Bug 20917] New: Improve email functionality relating
 to ILL requests
Message-ID: <bug-20917-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20917

            Bug ID: 20917
           Summary: Improve email functionality relating to ILL requests
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: ILL
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew.isherwood at ptfs-europe.com

The ILL module has the ability to send emails containing details of requests to
"partner" libraries. This functionality, though currently in the core ILL code,
is actually only required by the "FreeForm" backend. It is surfaced in the UI
as a form containing an email template and a multi-select to select the
partners who will receive the email.

The email functionality offered by ILL, though functional, is lacking in some
important respects, which this bug proposes addressing. Proposed enhancements,
which are all inter-related, are:

- Move emailing functionality from the core ILL module to the FreeForm backend
where it is actually used
- Email is sent independently of the Koha message queue, which is understood to
be undesirable, this should be addressed
- As such, there is no ability for users to specify a default message template,
using the Notices and Slips module, this should be addressed
- It is not possible for users to specify default "reply-to" addresses for all
ILL related emails, currently the ReplyToDefault syspref is used, this should
be addressed
- No message notification is sent to nominated staff when a request is
modified, this should be addressed

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:20:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:20:04 +0000
Subject: [Koha-bugs] [Bug 20917] Improve email functionality relating to ILL
	requests
In-Reply-To: <bug-20917-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20917-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20917-70-BL9uBuj0yx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20917

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ
                   |ity.org                     |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:21:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:21:04 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-WvOC4ziizi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

--- Comment #121 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm pretty happy with all this now. Well done to marcelr for the first QA run,
he did a great job and made my life much easier to get it over the finishing
line.

Please note that the manual should get a corresponding minor patch to update
the OAI reference to the  deletedbiblio table that this removes:
https://koha-community.org/manual/17.11/en/html/02_administration.html?highlight=oai

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:21:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:21:15 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-InaMLXYhLj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|m.de.rooy at rijksmuseum.nl    |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:25:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:25:13 +0000
Subject: [Koha-bugs] [Bug 20918] New: left-side navigation broken on the
 checkout history page
Message-ID: <bug-20918-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20918

            Bug ID: 20918
           Summary: left-side navigation broken on the checkout history
                    page
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: major
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 18403

commit fa54100dffe092e606f79b15692eedaf78f42e45
  Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for
issuehistory]

Removed:
-    biblionumber => $biblionumber, # required for left-side navigation


When you are on the "Checkout history" page
(/cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=42), the left-side
navigation is broken, the biblionumber is not set.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403
[Bug 18403] Hide patron information if not part of the logged in user library
group
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:25:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:25:13 +0000
Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the
 logged in user library group
In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18403-70-HLsSAWnQ9J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20918


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20918
[Bug 20918] left-side navigation broken on the checkout history page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:27:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:27:39 +0000
Subject: [Koha-bugs] [Bug 20918] left-side navigation broken on the checkout
	history page
In-Reply-To: <bug-20918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20918-70-v73XekDLzk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20918

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:27:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:27:42 +0000
Subject: [Koha-bugs] [Bug 20918] left-side navigation broken on the checkout
	history page
In-Reply-To: <bug-20918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20918-70-wj1iUGC7OR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20918

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75994
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75994&action=edit
Bug 20918: Fix left-side navigation on the checkout history page

commit fa54100dffe092e606f79b15692eedaf78f42e45
  Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for
issuehistory]

Removed:
-    biblionumber => $biblionumber, # required for left-side navigation

But did not deal with the side-effects.

Test plan:
When you are on the "Checkout history" page
(/cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=42),
the left-side navigation is broken if this patch is not applied, the
biblionumber is not set.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:29:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:29:36 +0000
Subject: [Koha-bugs] [Bug 20918] left-side navigation broken on the checkout
	history page
In-Reply-To: <bug-20918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20918-70-6TZYK4Y3gC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20918

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_18_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:31:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:31:10 +0000
Subject: [Koha-bugs] [Bug 20919] New: A Zebra query is done for each item
 when opening a record detail page
Message-ID: <bug-20919-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20919

            Bug ID: 20919
           Summary: A Zebra query is done for each item when opening a
                    record detail page
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: hagud at orex.es
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

We have figured out that koha launch a zebra query for each item of a record,
if the record have few items no problem, but if the record has hundreds of
items, the time to display goes easily over 30 seconds.

we have checked on a fresh install on debian jessie 8 with koha 17.11.6 and
18.05

the file  zebra-output.log becomes huge

We have checked from intranet interface

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:31:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:31:41 +0000
Subject: [Koha-bugs] [Bug 20919] A Zebra query is done for each item when
 opening a record detail page
In-Reply-To: <bug-20919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20919-70-tr2qFtA6dj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20919

Hugo Agud <hagud at orex.es> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:38:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:38:26 +0000
Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets
In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18235-70-oFShRFq4TI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72999|0                           |1
        is obsolete|                            |

--- Comment #38 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75995
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75995&action=edit
Bug 18235: DB changes

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:39:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:39:35 +0000
Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets
In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18235-70-ymsj6JpkBr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74642|0                           |1
        is obsolete|                            |

--- Comment #39 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 75996
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75996&action=edit
Bug 18235: Add unit tests for get_facetable_fields

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:40:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:40:10 +0000
Subject: [Koha-bugs] [Bug 18322] Add facets for ccode to zebra
In-Reply-To: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18322-70-mEhCaFTnH4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 75997
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75997&action=edit
Bug 18322: (followup) Add generated xsl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:40:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:40:35 +0000
Subject: [Koha-bugs] [Bug 18322] Add facets for ccode to zebra
In-Reply-To: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18322-70-VvJq839Xk4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:41:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:41:07 +0000
Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets
In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18235-70-A03F8MhtaT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #40 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I have amended the last 2 patches: 1. rename atomic update file and 2. remove
the line from commit message that was not related to the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:41:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:41:54 +0000
Subject: [Koha-bugs] [Bug 18322] Add facets for ccode to zebra
In-Reply-To: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18322-70-z9oV6Ge9qi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|katrin.fischer at bsz-bw.de    |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:47:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:47:30 +0000
Subject: [Koha-bugs] [Bug 20899] Patron name not showing on issuehistory.pl
In-Reply-To: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20899-70-3M5UScydM7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75975|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 75998
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75998&action=edit
Bug 20899: Fix patron's name display

This is a follow-up for
  commit fa54100dffe092e606f79b15692eedaf78f42e45
  Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for
issuehistory]

We should use patron-title.inc to display (or hide) patron's info on the
checkout history view

Test plan:
Issue an item, go to the biblio, click the circulation history for this
tab.
Note that the patron's name is showing.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:48:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:48:07 +0000
Subject: [Koha-bugs] [Bug 20899] Patron name not showing on issuehistory.pl
In-Reply-To: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20899-70-XF1p2XJiQn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Works as expected :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:50:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:50:14 +0000
Subject: [Koha-bugs] [Bug 20918] left-side navigation broken on the checkout
	history page
In-Reply-To: <bug-20918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20918-70-5on3WZYA9G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20918

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75994|0                           |1
        is obsolete|                            |

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 75999
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75999&action=edit
Bug 20918: Fix left-side navigation on the checkout history page

  commit fa54100dffe092e606f79b15692eedaf78f42e45
  Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for
issuehistory]

Removed:
-    biblionumber => $biblionumber, # required for left-side navigation

But did not deal with the side-effects.

Test plan:
When you are on the "Checkout history" page
(/cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=42),
the left-side navigation is broken if this patch is not applied, the
biblionumber is not set.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 16:51:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 14:51:00 +0000
Subject: [Koha-bugs] [Bug 20918] left-side navigation broken on the checkout
	history page
In-Reply-To: <bug-20918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20918-70-aBBW0xa63n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20918

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Needs Signoff               |Signed Off

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Good spot, signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 17:22:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 15:22:55 +0000
Subject: [Koha-bugs] [Bug 20920] New: Plack timeout because of missing
 CGI::Compile Perl dependency
Message-ID: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920

            Bug ID: 20920
           Summary: Plack timeout because of missing CGI::Compile Perl
                    dependency
 Change sponsored?: ---
           Product: Koha
           Version: 18.05
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jcharaoui at cmaisonneuve.qc.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net

Created attachment 76000
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76000&action=edit
Patch for debian/control

The Debian/Ubuntu package is missing a dependency on libcgi-compile-perl.
Without this package installed, when Plack is enabled/started, the webserver is
unresponsive and the following errors appear in the logs:

Error while loading /etc/koha/plack.psgi: Can't locate CGI/Compile.pm in @INC
(you may need to install the CGI::Compile module) (@INC contains:
/usr/share/koha/lib /us
r/share/koha/installer /usr/share/koha/lib/installer /etc/perl
/usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1
/usr/lib/x86_64-linux-gnu/perl5
/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24
/usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at
/usr/share/perl5/Plack
/App/WrapCGI.pm line 8.
BEGIN failed--compilation aborted at /usr/share/perl5/Plack/App/WrapCGI.pm line
8.
Compilation failed in require at /usr/share/perl5/Plack/App/CGIBin.pm line 6.
BEGIN failed--compilation aborted at /usr/share/perl5/Plack/App/CGIBin.pm line
6.
Compilation failed in require at /etc/koha/plack.psgi line 21.
BEGIN failed--compilation aborted at /etc/koha/plack.psgi line 21.

Attached is a patch to add this package to the debian/control file.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 17:23:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 15:23:47 +0000
Subject: [Koha-bugs] [Bug 20920] Plack timeout because of missing
 CGI::Compile Perl dependency
In-Reply-To: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20920-70-wERyOiH9eh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920

Jerome Charaoui <jcharaoui at cmaisonneuve.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 17:23:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 15:23:55 +0000
Subject: [Koha-bugs] [Bug 20892] Wrong basketgroup link in histsearch.pl
In-Reply-To: <bug-20892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20892-70-2D28iGWhYt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20892

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 17:23:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 15:23:58 +0000
Subject: [Koha-bugs] [Bug 20892] Wrong basketgroup link in histsearch.pl
In-Reply-To: <bug-20892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20892-70-G2VUdhRbuC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20892

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75943|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76001
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76001&action=edit
Bug 20892: Correct basketgroup link in histsearch.pl

When searching an order, histsearch.pl page, you see if exists the backetgroup
as a link.
This link is composed of "basketgroup.pl?booksellerid=xxx", it must also
contain "basketgroupid=xxx" and "opa=add".

See Bug 11429 for example.

Test plan :
1) Create an order in a basket and add it to a basketgroup
2) Search for this order, you get to page histsearch.pl
3) Check clicking on basketgroup id leads to basketgroup details page

Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 17:24:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 15:24:09 +0000
Subject: [Koha-bugs] [Bug 20911] Search history page forms use 'GET' and
 this limits the number of entries that can be submitted
In-Reply-To: <bug-20911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20911-70-a96Nnt37Na@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20911

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 17:28:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 15:28:53 +0000
Subject: [Koha-bugs] [Bug 20911] Search history page forms use 'GET' and
 this limits the number of entries that can be submitted
In-Reply-To: <bug-20911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20911-70-O9tuyJdhU5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20911

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 17:28:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 15:28:57 +0000
Subject: [Koha-bugs] [Bug 20911] Search history page forms use 'GET' and
 this limits the number of entries that can be submitted
In-Reply-To: <bug-20911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20911-70-OvfotGoLTU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20911

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75966|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76002
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76002&action=edit
Bug 20911: Use 'POST' to submit search history forms

To test:
1 - Enable EnableOpacSearchHistory and EnableSearchHistory
2 - Do some searches
3 - View your search history in staff/opac
4 - Confirm you can delete single or multiple rows
5 - Confirm other page functionality has not changed

Signed-off-by: Ed Veal <eveal at mckinneytexas.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 17:30:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 15:30:30 +0000
Subject: [Koha-bugs] [Bug 20760] Advanced Cataloging Editor - Rancor -
 AuthorisedValues are incorrectly fetched
In-Reply-To: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20760-70-ytNAW8pgCV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20760

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 17:31:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 15:31:28 +0000
Subject: [Koha-bugs] [Bug 20598] Accruing fines not closed out by
 longoverdue.pl if WhenLostForgiveFine is not enabled
In-Reply-To: <bug-20598-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20598-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20598-70-BcKRIBcj9R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20598

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Please provide tests to cover this change.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 17:31:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 15:31:48 +0000
Subject: [Koha-bugs] [Bug 20760] Advanced Cataloging Editor - Rancor -
 AuthorisedValues are incorrectly fetched
In-Reply-To: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20760-70-HbH1LHiJLy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20760

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 17:31:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 15:31:50 +0000
Subject: [Koha-bugs] [Bug 20760] Advanced Cataloging Editor - Rancor -
 AuthorisedValues are incorrectly fetched
In-Reply-To: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20760-70-RRHNlDAibc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20760

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75291|0                           |1
        is obsolete|                            |
  Attachment #75779|0                           |1
        is obsolete|                            |

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 76003
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76003&action=edit
Bug 20760: Fill authorised values in svc framework

To test:
 1 - Map a marc field to an authorised value in the default framework -
say 300$c -> CCODE
 2 - Open the advanced cataloguing editor
 3 - Create a new field 300$c - note there is no dropdown
 4 - browse to: /cgi-bin/koha/svc/cataloguing/framework?callback=define
 5 - Note the many instance of
Koha::Schema::ResultSet::AuthorisedValueCategory->HASH...
 6 - Apply patch
 7 - Restart memcached and plack
 8 - reload/recreate record in rancor
 9 - Note that 300$c is now a dropdown as expected
10 - repeate 4
11 - note the authorised values look correct in response

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 17:32:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 15:32:43 +0000
Subject: [Koha-bugs] [Bug 20760] Advanced Cataloging Editor - Rancor -
 AuthorisedValues are incorrectly fetched
In-Reply-To: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20760-70-X3CLdGfWif@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20760

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
I agree with Joubu, we don't need the sort and his patch is better (as usual,
*sigh*)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 17:43:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 15:43:20 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-4aavMNwWal@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #124 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #113)
>   Bug 12395: Save order line's creator
> reverts bug 20303

This one is still missing I think.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 17:43:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 15:43:51 +0000
Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields
	function
In-Reply-To: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12159-70-KmGgeiuMBo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 17:57:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 15:57:46 +0000
Subject: [Koha-bugs] [Bug 20921] New: Expose borrowernumber and branch when
 user is logged in to OPAC
Message-ID: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921

            Bug ID: 20921
           Summary: Expose borrowernumber and branch when user is logged
                    in to OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Some libraries would like the ability to trigger javascript ofr users of a
certain branch or specific borrowers.

There is currently no way to retrieve this information on the opac.

This patchset will add these two variables as attributes on the
loggedinusername span

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 17:58:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 15:58:34 +0000
Subject: [Koha-bugs] [Bug 20760] Advanced Cataloging Editor - Rancor -
 AuthorisedValues are incorrectly fetched
In-Reply-To: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20760-70-lO9SK5DRvS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20760

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76003|0                           |1
        is obsolete|                            |

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 76004
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76004&action=edit
Bug 20760: Fill authorised values in svc framework

To test:
 1 - Map a marc field to an authorised value in the default framework -
say 300$c -> CCODE
 2 - Open the advanced cataloguing editor
 3 - Create a new field 300$c - note there is no dropdown
 4 - browse to: /cgi-bin/koha/svc/cataloguing/framework?callback=define
 5 - Note the many instance of
Koha::Schema::ResultSet::AuthorisedValueCategory->HASH...
 6 - Apply patch
 7 - Restart memcached and plack
 8 - reload/recreate record in rancor
 9 - Note that 300$c is now a dropdown as expected
10 - repeate 4
11 - note the authorised values look correct in response

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 17:59:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 15:59:13 +0000
Subject: [Koha-bugs] [Bug 20760] Advanced Cataloging Editor - Rancor -
 AuthorisedValues are incorrectly fetched
In-Reply-To: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20760-70-4G9fEgxtPn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20760

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Works as expected and passes all tests. I'm happy with it and Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 18:02:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 16:02:09 +0000
Subject: [Koha-bugs] [Bug 20921] Expose borrowernumber and branch when user
 is logged in to OPAC
In-Reply-To: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20921-70-MZlgsyO7e3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 18:02:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 16:02:12 +0000
Subject: [Koha-bugs] [Bug 20921] Expose borrowernumber and branch when user
 is logged in to OPAC
In-Reply-To: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20921-70-p4webWyxN5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 76005
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76005&action=edit
Bug 20921: Add borrowernumber and branchcode as html attributes

To test:
1 - Apply patch
2 - Visit the opac
3 - Sign in
4 - You should not see any difference
5 - Inspect the element  'Welcome, {username}'
6 - Note the attributes for borrowernumber and branchcode
7 - Add to OPACUserJS:
$(document).ready(function(){
    console.log( $(".loggedinusername").attr('branchcode'));
    console.log( $(".loggedinusername").attr('borrowernumber'));
});
8 - Check the console and note you can see the info expected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 18:10:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 16:10:48 +0000
Subject: [Koha-bugs] [Bug 20922] New: Koha::Number::Price must not be used
 in updatedatabase.pl
Message-ID: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922

            Bug ID: 20922
           Summary: Koha::Number::Price must not be used in
                    updatedatabase.pl
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: critical
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

>From the koha-devel list:

http://lists.koha-community.org/pipermail/koha-devel/2018-June/044608.html

16.06.00.042

Upgrade to 16.06.00.041 done (Bug 14629 - Add aggressive ISSN matching 
feature equivalent to the aggressive ISBN matcher)
DBD::mysql::st execute failed: Unknown column 'me.p_sep_by_space' in 
'field list' [for Statement "SELECT `me`.`currency`, `me`.`symbol`, 
`me`.`isocode`, `me`.`timestamp`, `me`.`rate`, `me`.`active`, 
`me`.`archived`, `me`.`p_sep_by_space` FROM `currency` `me` WHERE ( 
`active` = ? )" with ParamValues: 0=1] at 
/usr/local/share/perl/5.24.1/DBIx/Class/Storage/DBI.pm line 1836.
DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 
'me.p_sep_by_space' in 'field list' at 
/inlibro/git/koha-csf-prod-inlibro/Koha/Objects.pm line 209

Basically, the update code uses Koha::Number::Price, which in full 
modern object mode goes for its newly added *p_sep_by_space* _in the 
18.05 code_.  But the DB doesn't have it yet (it comes with 17.12.00.022).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 18:12:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 16:12:19 +0000
Subject: [Koha-bugs] [Bug 20922] Koha::Number::Price must not be used in
 updatedatabase.pl
In-Reply-To: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20922-70-2h20NSoWpg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |4078, 13321


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078
[Bug 4078] Add the ability to customize and display the symbol for a currency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321
[Bug 13321] Fix tax and prices calculation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 18:12:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 16:12:19 +0000
Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the
 symbol for a currency
In-Reply-To: <bug-4078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4078-70-u88Jla2qbw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20922


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922
[Bug 20922] Koha::Number::Price must not be used in updatedatabase.pl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 18:12:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 16:12:19 +0000
Subject: [Koha-bugs] [Bug 13321] Fix tax and prices calculation
In-Reply-To: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13321-70-NQOGrBjYGC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20922


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922
[Bug 20922] Koha::Number::Price must not be used in updatedatabase.pl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 18:14:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 16:14:14 +0000
Subject: [Koha-bugs] [Bug 20922] Koha::Number::Price must not be used in
 updatedatabase.pl
In-Reply-To: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20922-70-e7Xu1t8cME@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76006
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76006&action=edit
Bug 20922: Remove use of Koha::Number::Price in updatedatabase.pl

Koha::Number::Format->round use Number::Format->round with a precision=2
We should use it directly instead of Koha::* modules. It will avoid the
DB entry to fail because schema changes.

>From the koha-devel list:

http://lists.koha-community.org/pipermail/koha-devel/2018-June/044608.html

16.06.00.042

Upgrade to 16.06.00.041 done (Bug 14629 - Add aggressive ISSN matching
feature equivalent to the aggressive ISBN matcher)
DBD::mysql::st execute failed: Unknown column 'me.p_sep_by_space' in
'field list' [for Statement "SELECT `me`.`currency`, `me`.`symbol`,
`me`.`isocode`, `me`.`timestamp`, `me`.`rate`, `me`.`active`,
`me`.`archived`, `me`.`p_sep_by_space` FROM `currency` `me` WHERE (
`active` = ? )" with ParamValues: 0=1] at
/usr/local/share/perl/5.24.1/DBIx/Class/Storage/DBI.pm line 1836.
DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column
'me.p_sep_by_space' in 'field list' at
/inlibro/git/koha-csf-prod-inlibro/Koha/Objects.pm line 209

Basically, the update code uses Koha::Number::Price, which in full
modern object mode goes for its newly added *p_sep_by_space* _in the
18.05 code_.  But the DB doesn't have it yet (it comes with 17.12.00.022).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 18:14:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 16:14:11 +0000
Subject: [Koha-bugs] [Bug 20922] Koha::Number::Price must not be used in
 updatedatabase.pl
In-Reply-To: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20922-70-xgYvWDTcXW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 18:14:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 16:14:42 +0000
Subject: [Koha-bugs] [Bug 19789] Remove some indirect DBIx calls from
	updatedatabase
In-Reply-To: <bug-19789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19789-70-tnuNdb7rhq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19789

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20922
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #0)
> L13526 and context: Koha::Number::Price->new( $order->{rrp} )->round;
> Only new calls seem to be fine. But might be tricky.

Done on bug 20922.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922
[Bug 20922] Koha::Number::Price must not be used in updatedatabase.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 18:14:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 16:14:42 +0000
Subject: [Koha-bugs] [Bug 20922] Koha::Number::Price must not be used in
 updatedatabase.pl
In-Reply-To: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20922-70-ImllXeI9Mp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19789


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19789
[Bug 19789] Remove some indirect DBIx calls from updatedatabase
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 18:14:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 16:14:49 +0000
Subject: [Koha-bugs] [Bug 19789] Remove some indirect DBIx calls from
	updatedatabase
In-Reply-To: <bug-19789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19789-70-FSmazj2oAD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19789

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20922
             Blocks|20922                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922
[Bug 20922] Koha::Number::Price must not be used in updatedatabase.pl
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 18:14:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 16:14:49 +0000
Subject: [Koha-bugs] [Bug 20922] Koha::Number::Price must not be used in
 updatedatabase.pl
In-Reply-To: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20922-70-gIdw2Gx78C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19789
         Depends on|19789                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19789
[Bug 19789] Remove some indirect DBIx calls from updatedatabase
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 18:17:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 16:17:52 +0000
Subject: [Koha-bugs] [Bug 20923] Merging backend status graph into main
 status graph incorrect use of grep
In-Reply-To: <bug-20923-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20923-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20923-70-61saQ4H3Hi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20923

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ
                   |ity.org                     |e.com
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 18:17:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 16:17:34 +0000
Subject: [Koha-bugs] [Bug 20923] New: Merging backend status graph into main
 status graph incorrect use of grep
Message-ID: <bug-20923-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20923

            Bug ID: 20923
           Summary: Merging backend status graph into main status graph
                    incorrect use of grep
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: ILL
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew.isherwood at ptfs-europe.com

When the Illrequest object is being constructed, it consults the status graphs
for enabled backends. These status graphs are then merged into the main graph
in order to provide the full workflow for a request.

As part of this process, the "next_actions" property is updated to reflect any
new statuses. During this, a check is performed to determine if the status
graph knows about the next status being declared by a backend status graph:

if ( grep $prev_action, @core_status_ids ) {

This is incorrect. According to http://perldoc.perl.org/functions/grep.html,
the first parameter should be a block or expression, here we are passing a
string. This malfunctions in so much as passing "REQ" with match twice in the
following array [ "REQ", "REQREV" ], this is not what we would expect.

The fix is to substitute the following line:

if ( grep /^$prev_action$/, @core_status_ids ) {

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 18:20:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 16:20:24 +0000
Subject: [Koha-bugs] [Bug 20920] Plack timeout because of missing
 CGI::Compile Perl dependency
In-Reply-To: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20920-70-41zqeaHn7i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|18.05                       |master
           Assignee|koha-bugs at lists.koha-commun |jcharaoui at cmaisonneuve.qc.c
                   |ity.org                     |a
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Keywords|                            |dependency

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 18:54:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 16:54:58 +0000
Subject: [Koha-bugs] [Bug 20921] Expose borrowernumber and branch when user
 is logged in to OPAC
In-Reply-To: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20921-70-KWEinenY8C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think we already have the branch in the source code, but in another spot.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 19:10:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 17:10:02 +0000
Subject: [Koha-bugs] [Bug 20920] Plack timeout because of missing
 CGI::Compile Perl dependency
In-Reply-To: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20920-70-niQiGpueo8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Which versions of Debian and/or Ubuntu did you test?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 19:14:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 17:14:44 +0000
Subject: [Koha-bugs] [Bug 20922] Koha::Number::Price must not be used in
 updatedatabase.pl
In-Reply-To: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20922-70-fyjBKb9udo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |philippe.blouin at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 19:19:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 17:19:30 +0000
Subject: [Koha-bugs] [Bug 20920] Plack timeout because of missing
 CGI::Compile Perl dependency
In-Reply-To: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20920-70-x5ipEZwEbn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920

--- Comment #2 from Jerome Charaoui <jcharaoui at cmaisonneuve.qc.ca> ---
Debian 9.4 (stretch)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 20:00:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 18:00:35 +0000
Subject: [Koha-bugs] [Bug 18322] Add facets for ccode to zebra
In-Reply-To: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18322-70-bXOiPagif0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67823|0                           |1
        is obsolete|                            |

--- Comment #24 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76007
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76007&action=edit
Bug 18322: Add a facet for ccode fields to Zebra

This patch adds the index definitions for zebra faceting of ccode in
koha for marc21, normarc and unimarc.

We also add lines to the templates to expose the new facet and enable
non-zebra faceting for ccode too.

Signed-off-by: David Cook <dcook at prosentient.com.au>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 20:00:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 18:00:42 +0000
Subject: [Koha-bugs] [Bug 18322] Add facets for ccode to zebra
In-Reply-To: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18322-70-cnWj32WPxZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75997|0                           |1
        is obsolete|                            |

--- Comment #25 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76008
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76008&action=edit
Bug 18322: (followup) Add generated xsl

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 20:00:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 18:00:50 +0000
Subject: [Koha-bugs] [Bug 18322] Add facets for ccode to zebra
In-Reply-To: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18322-70-Sp0leNUqAJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322

--- Comment #26 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76009
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76009&action=edit
Bug 18322: Update xslt for NORMARC and UNIMARC

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 20:02:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 18:02:13 +0000
Subject: [Koha-bugs] [Bug 18322] Add facets for ccode to zebra
In-Reply-To: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18322-70-Goyx86sKPj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #27 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Almost there. The result looks funny because it is showing codes instead of
descriptions. Take a look at C4::Search:570 and you will understand.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 20:03:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 18:03:13 +0000
Subject: [Koha-bugs] [Bug 18322] Add facets for ccode to zebra
In-Reply-To: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18322-70-u0ExHJUvTu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322

--- Comment #28 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
C4::Search:584 is a closer example.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 20:45:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 18:45:47 +0000
Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page,
 and new column aqbasketgroups.closeddate
In-Reply-To: <bug-11708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11708-70-SdMWGMs6sw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #245 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
1. aqbasketgroups.closedate is set to NOW, maybe better to use basket.closedate
(the latest)?

2. ->bookseller should be ->vendor (not blocker as we already have both in
Koha::*...)

3. a. I would not "cache" ->baskets, we already deal with the context in
Koha::Objects->search
b. ->baskets_count - no need to have it, it should be replaced with
baskets->count
=> Maybe you want to keep them for performance purpose, but is it really a
performance improvement?

5. basketgroup.tt has a [% IF booksellerid %], it should not be useful now.
We may want to display a friendly message if called without a [valid] id

6. basketgroups.tt should have JS at the bottom

7. Some links still point to basketgroup.pl?booksellerid=X without the
basketgroupid, they should be replaced right?
i.e. code related to 'sub displaybasketgroups' in basketgroup.pl should be
removed (?)

8. Are you sure you need the changes done to C4::Acquisition?

9. acqui/basketgroup.pl
+ use List::MoreUtils qw/uniq/;
=> Not needed

10. "kohaDataTable": We already have KohaTable. You are adding a 3rd way to
init a table.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 21:00:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 19:00:26 +0000
Subject: [Koha-bugs] [Bug 20922] Koha::Number::Price must not be used in
 updatedatabase.pl
In-Reply-To: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20922-70-L1KQ7YIpAu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 21:00:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 19:00:52 +0000
Subject: [Koha-bugs] [Bug 20922] Koha::Number::Price must not be used in
 updatedatabase.pl
In-Reply-To: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20922-70-nLotchdkQ3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76006|0                           |1
        is obsolete|                            |

--- Comment #2 from Blou <philippe.blouin at inlibro.com> ---
Created attachment 76010
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76010&action=edit
Bug 20922: Remove use of Koha::Number::Price in updatedatabase.pl

Koha::Number::Format->round use Number::Format->round with a precision=2
We should use it directly instead of Koha::* modules. It will avoid the
DB entry to fail because schema changes.

>From the koha-devel list:

http://lists.koha-community.org/pipermail/koha-devel/2018-June/044608.html

16.06.00.042

Upgrade to 16.06.00.041 done (Bug 14629 - Add aggressive ISSN matching
feature equivalent to the aggressive ISBN matcher)
DBD::mysql::st execute failed: Unknown column 'me.p_sep_by_space' in
'field list' [for Statement "SELECT `me`.`currency`, `me`.`symbol`,
`me`.`isocode`, `me`.`timestamp`, `me`.`rate`, `me`.`active`,
`me`.`archived`, `me`.`p_sep_by_space` FROM `currency` `me` WHERE (
`active` = ? )" with ParamValues: 0=1] at
/usr/local/share/perl/5.24.1/DBIx/Class/Storage/DBI.pm line 1836.
DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column
'me.p_sep_by_space' in 'field list' at
/inlibro/git/koha-csf-prod-inlibro/Koha/Objects.pm line 209

Basically, the update code uses Koha::Number::Price, which in full
modern object mode goes for its newly added *p_sep_by_space* _in the
18.05 code_.  But the DB doesn't have it yet (it comes with 17.12.00.022).

Signed-off-by: Blou <philippe.blouin at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 21:01:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 19:01:49 +0000
Subject: [Koha-bugs] [Bug 20922] Koha::Number::Price must not be used in
 updatedatabase.pl
In-Reply-To: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20922-70-liyP4pAE4G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922

--- Comment #3 from Blou <philippe.blouin at inlibro.com> ---
I applied the patch and upgrade from 3.0 to 17.12.00.044 with success.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 22:02:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 20:02:03 +0000
Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
In-Reply-To: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17698-70-dCobzlm271@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #57 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
1. Bad resolution conflict, permission self_checkout is re-add (I will fix)

2. The IGNORE modifier is missing in the INSERT statement (I will fix)

3. In the JS console: "ReferenceError: $ is not defined", I did not investigate
it.

4. When I hit /circ/checkout-notes.pl from the side bar, the page displays
"Checkout notes", nothing else. We should add "There is no checkout notes". (I
will fix)

5. The alert id=error is displayed then hide in JS, but it's then displayed
half a second. We should hide it by default (css)

6. I would move the "mark seen" and "mark not seen" buttons at the top of the
table

7. I would display the table on the confirmation screen as well (I will fix)

8. Cursor on "Select all" and "Clear all" links must be adjusted

9. $(".btn-xs").click(function(event){
The selector should be $("button.seen, button.notseen"), you do not want to
apply this function to all other btn-xs on the page (maybe there are only two
for now, but who knows later?)

10. html filters are missing (I will fix)

11. span element should surround translatable string, to help translators (I
will fix).

12. Important: When a note is updated, it's still marked as seen. Is it the
expected behavior?

13. What will happen when hundred of notes will be on this table? Not blocker
but we will need a "hide seen" buttons to filters the already seen notes.

14. patron-title.inc must be used to display patron's info (I will fix)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 12 22:04:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 20:04:28 +0000
Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
In-Reply-To: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17698-70-0fVXdzv1iy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

--- Comment #58 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76011
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76011&action=edit
Bug 17698: (QA follow-up) Fix minors design issues

This patch includes some changes required on comment 57:

1. Bad resolution conflict, permission self_checkout is re-add

2. The IGNORE modifier is missing in the INSERT statement

4. When I hit /circ/checkout-notes.pl from the side bar, the page displays
"Checkout notes", nothing else. We should add "There is no checkout notes".

7. I would display the table on the confirmation screen as well

10. html filters are missing

11. span element should surround translatable string, to help translators

14. patron-title.inc must be used to display patron's info

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 01:16:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 23:16:59 +0000
Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
In-Reply-To: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17698-70-dXzTpvHCn6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 01:17:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jun 2018 23:17:05 +0000
Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
In-Reply-To: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17698-70-rSmTwDjs7c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

--- Comment #59 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 76012
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76012&action=edit
Bug 17698: [FOLLOW-UP] Fixing things in Comment 57

3. In the JS console: "ReferenceError: $ is not defined", I did not
investigate it.

Where do you see this in the console? I cannot recreate on opac-user.pl
or on circ/checkout-notes.pl.

5. The alert id=error is displayed then hide in JS, but it's then
displayed half a second. We should hide it by default (css)

Fixed in this patch

6. I would move the "mark seen" and "mark not seen" buttons at the
top of the table

Fixed in this patch

8. Cursor on "Select all" and "Clear all" links must be adjusted

Fixed in this patch

9. $(".btn-xs").click(function(event){
The selector should be $("button.seen, button.notseen"), you
do not want to apply this function to all other btn-xs on
the page (maybe there are only two for now, but who knows
later?)

Fixed in this patch

12. Important: When a note is updated, it's still marked as
seen. Is it the expected behavior?

I don't see this behaviour. When a note is updated it is
marked as not seen.
opav/svc/checkout_notes:79: $issue->set({ notedate =>
dt_from_string(), note => $clean_note, noteseen => 0
})->store;

13. What will happen when hundred of notes will be on this
table? Not blocker but we will need a "hide seen" buttons to
filters the already seen notes.

Added in this patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 03:40:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 01:40:25 +0000
Subject: [Koha-bugs] [Bug 20924] New: News content textarea not showing
Message-ID: <bug-20924-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20924

            Bug ID: 20924
           Summary: News content textarea not showing
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleisha at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org

Created attachment 76013
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76013&action=edit
screenshot showing missing textarea

when adding new or editing exiting koha news item, the content textarea box
does not show.
/cgi-bin/koha/tools/koha-news.pl?op=add_form

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 03:43:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 01:43:10 +0000
Subject: [Koha-bugs] [Bug 20924] News content textarea not showing
In-Reply-To: <bug-20924-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20924-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20924-70-1UTcoQ3qaV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20924

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 03:43:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 01:43:14 +0000
Subject: [Koha-bugs] [Bug 20924] News content textarea not showing
In-Reply-To: <bug-20924-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20924-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20924-70-AjML6jOzDM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20924

--- Comment #1 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 76014
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76014&action=edit
Bug 20924: Make news content textarea show

To test:
1) Go to Tools -> News
2) Edit existing news item or add new news item
3) Notice content box is missing, can't edit news or add any content
4) Apply patch, refresh page
5) Notice textarea now shows

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 03:43:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 01:43:23 +0000
Subject: [Koha-bugs] [Bug 20924] News content textarea not showing
In-Reply-To: <bug-20924-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20924-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20924-70-PX78i8LAL7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20924

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz
                   |ity.org                     |
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 03:45:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 01:45:05 +0000
Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
In-Reply-To: <bug-14272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14272-70-XY0CXBvhi8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20924


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20924
[Bug 20924] News content textarea not showing
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 03:45:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 01:45:05 +0000
Subject: [Koha-bugs] [Bug 20924] News content textarea not showing
In-Reply-To: <bug-20924-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20924-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20924-70-eNQkZsndDd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20924

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14272


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272
[Bug 14272] Allow OPAC to show a single news item
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 03:44:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 01:44:43 +0000
Subject: [Koha-bugs] [Bug 20924] News content textarea not showing
In-Reply-To: <bug-20924-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20924-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20924-70-QlRNQfJJLE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20924

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |blocker

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 04:36:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 02:36:53 +0000
Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
In-Reply-To: <bug-14272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14272-70-jqw5Xdh8fc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 04:36:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 02:36:58 +0000
Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
In-Reply-To: <bug-14272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14272-70-sW13iOijyL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72548|0                           |1
        is obsolete|                            |
  Attachment #72549|0                           |1
        is obsolete|                            |
  Attachment #72550|0                           |1
        is obsolete|                            |
  Attachment #72551|0                           |1
        is obsolete|                            |

--- Comment #48 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 76015
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76015&action=edit
Bug 14272: Show single news item [alternative patch]

This is a new patch for this bug that shows a single news item on the
OPAC using Koha Objects (Koha::News).

To test:
1) Go to Tools -> News on staff interface, make a news item to show on
the OPAC
2) Go to OPAC
3) Notice news item shows and title cannot be clicked
4) Apply patch, refresh page
5) Notice title is now a link. Click title
6) Confirm breadcrumbs shows title of news item
7) Confirm RSS feed and OpacMainUserBlock are not visible
8) In the URL, change the news_id param to an ID that does not exist
9) Confirm that an appropriate error message shows

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 06:00:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 04:00:15 +0000
Subject: [Koha-bugs] [Bug 20926] New: Changing font color for pipes between
 list items in #moresearch
Message-ID: <bug-20926-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20926

            Bug ID: 20926
           Summary: Changing font color for pipes between list items in
                    #moresearch
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jesse at bywatersolutions.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Work to be done:,1 - Add a new system preference "MoreSearches",2 - Append the
contents of this syspref to the auto generated links in Koha

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 06:00:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 04:00:12 +0000
Subject: [Koha-bugs] [Bug 20925] New: Changing font color for pipes between
 list items in #moresearch
Message-ID: <bug-20925-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20925

            Bug ID: 20925
           Summary: Changing font color for pipes between list items in
                    #moresearch
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: kyle at bywatersolutions.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Work to be done:
1 - Add a new system preference "MoreSearches"
2 - Append the contents of this syspref to the auto generated links in Koha

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 06:45:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 04:45:18 +0000
Subject: [Koha-bugs] [Bug 20927] New: moredetail.pl crash on nonexistent
	biblionumber
Message-ID: <bug-20927-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20927

            Bug ID: 20927
           Summary: moredetail.pl crash on nonexistent biblionumber
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: pasi.kallinen at joensuu.fi
        QA Contact: testopia at bugs.koha-community.org

moredetail.pl crashes when trying to view a nonexistent biblionumber.

The case should be handled like it is done in detail.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 06:50:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 04:50:30 +0000
Subject: [Koha-bugs] [Bug 20927] moredetail.pl crash on nonexistent
	biblionumber
In-Reply-To: <bug-20927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20927-70-fMVXRfBtlJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20927

paxed <pasi.kallinen at joensuu.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|oleonard at myacpl.org         |pasi.kallinen at joensuu.fi

--- Comment #1 from paxed <pasi.kallinen at joensuu.fi> ---
Created attachment 76016
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76016&action=edit
Bug 20927: moredetail.pl crash on nonexistent biblionumber

moredetail.pl crashes when trying to view a nonexistent biblionumber.

The case should be handled like it is done in detail.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 08:29:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 06:29:53 +0000
Subject: [Koha-bugs] [Bug 20866] ArticleRequests.t fails on existing requests
In-Reply-To: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20866-70-c8Nge0IztL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20866

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
         Depends on|                            |18403


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403
[Bug 18403] Hide patron information if not part of the logged in user library
group
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 08:29:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 06:29:53 +0000
Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the
 logged in user library group
In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18403-70-nqYVoLOxvF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20866


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20866
[Bug 20866] ArticleRequests.t fails on existing requests
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 08:30:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 06:30:34 +0000
Subject: [Koha-bugs] [Bug 20866] ArticleRequests.t fails on existing requests
In-Reply-To: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20866-70-JOnDyMHQhn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20866

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 18403 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 08:33:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 06:33:45 +0000
Subject: [Koha-bugs] [Bug 20889] Items marked as not for loan can be checked
	out
In-Reply-To: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20889-70-Xrb5PIltjP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20889

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #11 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 19943 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 08:34:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 06:34:01 +0000
Subject: [Koha-bugs] [Bug 20889] Items marked as not for loan can be checked
	out
In-Reply-To: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20889-70-RJojsUDwm4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20889

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 09:01:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 07:01:07 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-vvDmHNxFZx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #125 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Jonathan Druart from comment #124)
> (In reply to Jonathan Druart from comment #113)
> >   Bug 12395: Save order line's creator
> > reverts bug 20303
> 
> This one is still missing I think.

These changes are intended. orderreceive.pl doesn't use aqbaskets.authorisedby
anymore (with those patches applied)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 09:52:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 07:52:02 +0000
Subject: [Koha-bugs] [Bug 20928] New: Checkout status not showing patron
Message-ID: <bug-20928-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20928

            Bug ID: 20928
           Summary: Checkout status not showing patron
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: stefan.berndtsson at ub.gu.se
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When looking at the item list (moredetail.pl) for a bibliographic record, there
is no "Checked out to" patron linked. 

It seems holdpatronname is no longer sent to the template "moredetail.tt". I
assume this means something has changed in how patron links are done, but the
template still seem to use the old way of doing it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 10:18:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 08:18:08 +0000
Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
In-Reply-To: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20664-70-W840SeWCH5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lari.taskula at jns.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 10:29:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 08:29:37 +0000
Subject: [Koha-bugs] [Bug 20923] Merging backend status graph into main
 status graph incorrect use of grep
In-Reply-To: <bug-20923-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20923-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20923-70-Ca2lJXj8sz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20923

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 10:30:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 08:30:37 +0000
Subject: [Koha-bugs] [Bug 20921] Expose borrowernumber and branch when user
 is logged in to OPAC
In-Reply-To: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20921-70-4gvKD2YXzR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921

paxed <pasi.kallinen at joensuu.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pasi.kallinen at joensuu.fi

--- Comment #3 from paxed <pasi.kallinen at joensuu.fi> ---
Custom HTML attributes should be prefixed with "data-" (as per the HTML5 spec)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 10:31:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 08:31:29 +0000
Subject: [Koha-bugs] [Bug 20929] New: koha-dump should not pass a --password
 argument to mysqldump
Message-ID: <bug-20929-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20929

            Bug ID: 20929
           Summary: koha-dump should not pass a --password argument to
                    mysqldump
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: solaris.smoke at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net

Created attachment 76017
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76017&action=edit
Use env variable instead of --password argument for mysqldump

koha-dump currently passes a password as a CLI argument to mysqldump, which
results in the following warning:

mysqldump: [Warning] Using a password on the command line interface can be
insecure.

Depending on how a server is configured, this results in emails being sent to
the administrator every time the cron job runs.

It's trivial to change this to pass an environment variable instead, so as not
to trigger the warning.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 10:34:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 08:34:56 +0000
Subject: [Koha-bugs] [Bug 20929] koha-dump should not pass a --password
 argument to mysqldump
In-Reply-To: <bug-20929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20929-70-dHtlKZZHcu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20929

solaris.smoke at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76017|0                           |1
        is obsolete|                            |

--- Comment #1 from solaris.smoke at gmail.com ---
Created attachment 76018
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76018&action=edit
Use env variable instead of --password argument for mysqldump (without spurious
white space changes)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 10:35:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 08:35:25 +0000
Subject: [Koha-bugs] [Bug 20929] koha-dump should not pass a --password
 argument to mysqldump
In-Reply-To: <bug-20929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20929-70-N6PY4wO9LX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20929

solaris.smoke at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76018|0                           |1
        is obsolete|                            |

--- Comment #2 from solaris.smoke at gmail.com ---
Created attachment 76019
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76019&action=edit
Use env variable instead of --password argument for mysqldump

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 11:15:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 09:15:11 +0000
Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
In-Reply-To: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20664-70-8di1kpySPO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #6 from Lari Taskula <lari.taskula at jns.fi> ---
Fails t/db_dependent/Items.t

    #   Failed test 'For OPAC, the pref OpacHiddenItems should have been take
into account. Only items with homebranch ne CPL should have been embedded'
    #   at t/db_dependent/Items.t line 631.
    #          got: '8'
    #     expected: '2'

    #   Failed test 'For OPAC, If all items are hidden, no item should have
been embedded'
    #   at t/db_dependent/Items.t line 642.
    #          got: '8'
    #     expected: '0'
    # Looks like you failed 2 tests of 7.

#   Failed test 'C4::Biblio::EmbedItemsInMarcBiblio'
#   at t/db_dependent/Items.t line 649.
Use of uninitialized value in string ne at /home/koha/kohaclone/C4/Items.pm
line 1729.
Use of uninitialized value in string ne at /home/koha/kohaclone/C4/Items.pm
line 1729.
Use of uninitialized value in string ne at /home/koha/kohaclone/C4/Items.pm
line 1729.
Use of uninitialized value in string ne at /home/koha/kohaclone/C4/Items.pm
line 1729.
Use of uninitialized value in string ne at /home/koha/kohaclone/C4/Items.pm
line 1729.
Use of uninitialized value in string ne at /home/koha/kohaclone/C4/Items.pm
line 1729.

    #   Failed test 'items.barcode is not mapped anymore, so the DB column has
not been updated'
    #   at t/db_dependent/Items.t line 726.
    #          got: undef
    #     expected: 'a barcode'
    # Looks like you failed 1 test of 4.
t/db_dependent/Items.t .. 11/14 
#   Failed test 'C4::Items::_build_default_values_for_mod_marc'
#   at t/db_dependent/Items.t line 731.
# Looks like you failed 2 tests of 14.
t/db_dependent/Items.t .. Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/14 subtests 

Test Summary Report
-------------------
t/db_dependent/Items.t (Wstat: 512 Tests: 14 Failed: 2)
  Failed tests:  10-11
  Non-zero exit status: 2

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 11:16:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 09:16:46 +0000
Subject: [Koha-bugs] [Bug 20923] Merging backend status graph into main
 status graph incorrect use of grep
In-Reply-To: <bug-20923-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20923-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20923-70-j8VNEhwxy8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20923

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20917


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20917
[Bug 20917] Improve email functionality relating to ILL requests
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 11:16:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 09:16:19 +0000
Subject: [Koha-bugs] [Bug 20923] Merging backend status graph into main
 status graph incorrect use of grep
In-Reply-To: <bug-20923-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20923-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20923-70-IPVRZ9jFrV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20923

--- Comment #1 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 76020
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76020&action=edit
Bug 20923: Fix usage of grep

This patch implements the fix described in the bug description. It is
impossible to test without the work that will be added to bug 20917.
Therefore a dependency will be added for that bug and a test plan will
be added here when that work is done.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 11:16:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 09:16:46 +0000
Subject: [Koha-bugs] [Bug 20917] Improve email functionality relating to ILL
	requests
In-Reply-To: <bug-20917-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20917-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20917-70-VMZPuE01kB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20917

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20923


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20923
[Bug 20923] Merging backend status graph into main status graph incorrect use
of grep
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 11:20:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 09:20:58 +0000
Subject: [Koha-bugs] [Bug 17989] Stricter control on source directory for
	html templates
In-Reply-To: <bug-17989-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17989-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17989-70-wkmCj3Wnqa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 11:25:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 09:25:39 +0000
Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
In-Reply-To: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20664-70-rpm05r9vfe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664

--- Comment #7 from Lari Taskula <lari.taskula at jns.fi> ---
(In reply to Lari Taskula from comment #6)
> Fails t/db_dependent/Items.t
This is due to caching parsed YAML from OpacHiddenItems. Cache does not cleared
between tests when OpacHiddenItems changes.

Instead of additionally caching parsed YAML of this system preference, would it
be better for Koha to handle YAML system preferences as parsed by default? This
would require some changes to Koha core but I guess it would benefit all
features using system preferences represented in YAML.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 11:31:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 09:31:08 +0000
Subject: [Koha-bugs] [Bug 18322] Add facets for ccode to zebra
In-Reply-To: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18322-70-6yqUYdTvCb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322

--- Comment #29 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 76021
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76021&action=edit
Bug 18322: (followup) Use authorized value labels

Rather than using the raw ccode's use the labels as defined in the
authorized values.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 11:32:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 09:32:21 +0000
Subject: [Koha-bugs] [Bug 18322] Add facets for ccode to zebra
In-Reply-To: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18322-70-x3W72C2iCg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #30 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Good spot, thanks Tom?s!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 11:38:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 09:38:32 +0000
Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
In-Reply-To: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20664-70-kmDEQLrsz5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664

--- Comment #8 from Ere Maijala <ere.maijala at helsinki.fi> ---
Thanks for the feedback. I think I'll spin that off as a separate bug and
remove the caching thing here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 11:54:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 09:54:25 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
	records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-X4BEe8nUkQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

--- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 74660
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74660
Bug 17385: Add custom export XSLT

Review of attachment 74660:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17385&attachment=74660)
-----------------------------------------------------------------

Generally looks good with a few minor code comments added for review.

::: C4/XSLT.pm
@@ +197,5 @@
>      $xslfilename ||= C4::Context->preference($xslsyspref);
>      $lang ||= C4::Languages::getlanguage();
>  
> +    if ($xslsyspref eq "XSLTCustomExport") {
> +        my $dir;

The code used to defined $dir in CustomXSLTExportList which does the same thing
is cleaner.. why not use that here too... or even factor it out and use the
same factored out routine for both to keep it DRY?

@@ +370,5 @@
>  }
>  
> +=head2 CustomXSLTExportList
> +
> + Returns list of file for custom xslt conversion

Please add accepted parameters (i.e. $opac) to the POD section and note their
required status and what they accept (string, int, etc)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 12:03:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 10:03:37 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
	records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-xex79OsoRD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Ignore the first comment in that review.. you've already changed it in the
followup.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 12:36:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 10:36:15 +0000
Subject: [Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check
 if patron is expired
In-Reply-To: <bug-17229-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17229-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17229-70-DZerOs0Ef2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |normal
                 CC|                            |victor.grousset at biblibre.co
                   |                            |m

--- Comment #16 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Changed from minor to normal as bypassing expiration check (important 
circulation rule) is bad

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 12:37:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 10:37:51 +0000
Subject: [Koha-bugs] [Bug 17247] ILS-DI HoldTitle and HoldItem should check
 if patron is debarred
In-Reply-To: <bug-17247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17247-70-Gz7qxWLAPg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17247

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor.grousset at biblibre.co
                   |                            |m
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17229

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 12:37:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 10:37:51 +0000
Subject: [Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check
 if patron is expired
In-Reply-To: <bug-17229-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17229-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17229-70-NegU1ypr70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17247

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 12:40:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 10:40:11 +0000
Subject: [Koha-bugs] [Bug 20930] New: Handle YAML type system preferences as
 parsed references
Message-ID: <bug-20930-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930

            Bug ID: 20930
           Summary: Handle YAML type system preferences as parsed
                    references
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lari.taskula at jns.fi
        QA Contact: testopia at bugs.koha-community.org

Currently, C4::Context->preference('YAMLpref') returns a string that needs to
be parsed by any code using the preference.

My suggestion is to return a parsed version instead (a hash/array ref or a
string) and using the syspref cache with the parsed value. Like this, we could:
- centralize parsing of YAML system preferences
- optimize use of system preference cache by caching the parsed version
instead. Parse once and store in cache; no need to re-parse on each call!

We could centralize this functionality into Koha::Config::SysPref->value()
(used by C4::Context->preference). Use database column systempreferences.type
with value of "yaml" to trigger this functionality in "value()"-method.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 12:41:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 10:41:26 +0000
Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
In-Reply-To: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20664-70-AiAJ1kSexD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20930

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 12:41:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 10:41:26 +0000
Subject: [Koha-bugs] [Bug 20930] Handle YAML type system preferences as
	parsed references
In-Reply-To: <bug-20930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20930-70-KEaNYTaDoK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20664

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 13:08:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 11:08:31 +0000
Subject: [Koha-bugs] [Bug 20930] Handle YAML type system preferences as
	parsed references
In-Reply-To: <bug-20930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20930-70-UipR4eAiNG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ere.maijala at helsinki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 13:21:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 11:21:18 +0000
Subject: [Koha-bugs] [Bug 20928] Checkout status not showing patron
In-Reply-To: <bug-20928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20928-70-gqo75HzK98@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20928

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |glasklas at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 13:26:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 11:26:57 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive"
	cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-jXPrcqzRGK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11983


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983
[Bug 11983] code to select patrons to purge needs to be centralized
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 13:26:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 11:26:57 +0000
Subject: [Koha-bugs] [Bug 11983] code to select patrons to purge needs to be
	centralized
In-Reply-To: <bug-11983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11983-70-BuUiAZFQTx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20271


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
[Bug 20271] Merge deleted* tables with their "alive" cousins
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 13:27:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 11:27:39 +0000
Subject: [Koha-bugs] [Bug 11983] code to select patrons to purge needs to be
	centralized
In-Reply-To: <bug-11983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11983-70-2Mxqh9Rj04@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I intend to work on this but won't do so until after 20271 is in as it will
drastically affect the code.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 14:32:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 12:32:52 +0000
Subject: [Koha-bugs] [Bug 20922] Koha::Number::Price must not be used in
 updatedatabase.pl
In-Reply-To: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20922-70-QToz1WJQyS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76010|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 76022
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76022&action=edit
Bug 20922: Remove use of Koha::Number::Price in updatedatabase.pl

Koha::Number::Format->round use Number::Format->round with a precision=2
We should use it directly instead of Koha::* modules. It will avoid the
DB entry to fail because schema changes.

>From the koha-devel list:

http://lists.koha-community.org/pipermail/koha-devel/2018-June/044608.html

16.06.00.042

Upgrade to 16.06.00.041 done (Bug 14629 - Add aggressive ISSN matching
feature equivalent to the aggressive ISBN matcher)
DBD::mysql::st execute failed: Unknown column 'me.p_sep_by_space' in
'field list' [for Statement "SELECT `me`.`currency`, `me`.`symbol`,
`me`.`isocode`, `me`.`timestamp`, `me`.`rate`, `me`.`active`,
`me`.`archived`, `me`.`p_sep_by_space` FROM `currency` `me` WHERE (
`active` = ? )" with ParamValues: 0=1] at
/usr/local/share/perl/5.24.1/DBIx/Class/Storage/DBI.pm line 1836.
DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column
'me.p_sep_by_space' in 'field list' at
/inlibro/git/koha-csf-prod-inlibro/Koha/Objects.pm line 209

Basically, the update code uses Koha::Number::Price, which in full
modern object mode goes for its newly added *p_sep_by_space* _in the
18.05 code_.  But the DB doesn't have it yet (it comes with 17.12.00.022).

Signed-off-by: Blou <philippe.blouin at inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 14:33:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 12:33:29 +0000
Subject: [Koha-bugs] [Bug 20922] Koha::Number::Price must not be used in
 updatedatabase.pl
In-Reply-To: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20922-70-JntJaW1gSO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Makes total sense and works as prescribed.. a simple patch really, passing qa.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 14:33:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 12:33:42 +0000
Subject: [Koha-bugs] [Bug 17247] ILS-DI HoldTitle and HoldItem should check
 if patron is debarred
In-Reply-To: <bug-17247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17247-70-e5ySEhUO24@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17247

--- Comment #14 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
(In reply to Jonathan Druart from comment #13)
> before:
> https://screenshots.firefox.com/vYnI1v89SSv9DA8M/pro.kohadev.org
> after:
> https://screenshots.firefox.com/CLXPhG1xjMNn4yUS/pro.kohadev.org

The screenshots expired (default 14 days) but you can set a expiration to no
limit. Or store them in bugzilla.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 14:37:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 12:37:15 +0000
Subject: [Koha-bugs] [Bug 20760] Advanced Cataloging Editor - Rancor -
 AuthorisedValues are incorrectly fetched
In-Reply-To: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20760-70-uprUvZfchI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20760

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 14:53:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 12:53:40 +0000
Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
In-Reply-To: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17698-70-SpTOIljFSN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c
                   |y.org                       |ommunity.org
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 15:01:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 13:01:27 +0000
Subject: [Koha-bugs] [Bug 20931] New: JS error "ReferenceError: $ is not
 defined" when CircSidebar is turned on
Message-ID: <bug-20931-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20931

            Bug ID: 20931
           Summary: JS error "ReferenceError: $ is not defined" when
                    CircSidebar is turned on
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 16530, 19700

If CircSidebar is set and you hit /cgi-bin/koha/circ/returns.pl, you will get
"ReferenceError: $ is not defined"


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530
[Bug 16530] Add a circ sidebar navigation menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19700
[Bug 19700] Move template JavaScript to the footer: Some circulation pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 15:01:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 13:01:27 +0000
Subject: [Koha-bugs] [Bug 19700] Move template JavaScript to the footer:
 Some circulation pages
In-Reply-To: <bug-19700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19700-70-zAliRYCFXk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19700

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20931


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20931
[Bug 20931] JS error "ReferenceError: $ is not defined" when CircSidebar is
turned on
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 15:01:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 13:01:27 +0000
Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu
In-Reply-To: <bug-16530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16530-70-zDiZ12kq4z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20931


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20931
[Bug 20931] JS error "ReferenceError: $ is not defined" when CircSidebar is
turned on
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 15:14:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 13:14:38 +0000
Subject: [Koha-bugs] [Bug 18322] Add facets for ccode to zebra
In-Reply-To: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18322-70-gqbC0PCDTM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76007|0                           |1
        is obsolete|                            |

--- Comment #31 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76023
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76023&action=edit
Bug 18322: Add a facet for ccode fields to Zebra

This patch adds the index definitions for zebra faceting of ccode in
koha for marc21, normarc and unimarc.

We also add lines to the templates to expose the new facet and enable
non-zebra faceting for ccode too.

Signed-off-by: David Cook <dcook at prosentient.com.au>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 15:14:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 13:14:47 +0000
Subject: [Koha-bugs] [Bug 18322] Add facets for ccode to zebra
In-Reply-To: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18322-70-2rLimMTQbU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76008|0                           |1
        is obsolete|                            |

--- Comment #32 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76024
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76024&action=edit
Bug 18322: (follow-up) Add generated xsl

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 15:14:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 13:14:54 +0000
Subject: [Koha-bugs] [Bug 18322] Add facets for ccode to zebra
In-Reply-To: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18322-70-edV4aoybo4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76009|0                           |1
        is obsolete|                            |

--- Comment #33 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76025
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76025&action=edit
Bug 18322: Update xslt for NORMARC and UNIMARC

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 15:15:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 13:15:05 +0000
Subject: [Koha-bugs] [Bug 18322] Add facets for ccode to zebra
In-Reply-To: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18322-70-3BJQ53vyJ4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76021|0                           |1
        is obsolete|                            |

--- Comment #34 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76026
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76026&action=edit
Bug 18322: (follow-up) Use authorized value labels

Rather than using the raw ccode's use the labels as defined in the
authorized values.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 15:15:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 13:15:35 +0000
Subject: [Koha-bugs] [Bug 18322] Add facets for ccode to zebra
In-Reply-To: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18322-70-uDeSxHzgJc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 16:16:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 14:16:25 +0000
Subject: [Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly
 with an email sent out
In-Reply-To: <bug-12556-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12556-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12556-70-vlSZvq45zv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556

BASE Library Consortium <baselibrary.consortium at nhs.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |baselibrary.consortium at nhs.
                   |                            |net

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 16:16:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 14:16:30 +0000
Subject: [Koha-bugs] [Bug 9525] group floating rules
In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9525-70-UJMdwDeIVs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525

BASE Library Consortium <baselibrary.consortium at nhs.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |baselibrary.consortium at nhs.
                   |                            |net

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 16:27:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 14:27:12 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-FEE9AqO5ea@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Merge deleted* tables with  |Merge deleted biblio,
                   |their "alive" cousins       |biblioitems,
                   |                            |biblio_metadata, and items
                   |                            |tables with their "alive"
                   |                            |cousins

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 16:43:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 14:43:18 +0000
Subject: [Koha-bugs] [Bug 20285] Lost item refund won't always pay down lost
 item fee first
In-Reply-To: <bug-20285-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20285-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20285-70-wGOwFLqxrW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20285

Chris Slone <cslone at camdencountylibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cslone at camdencountylibrary.
                   |                            |org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 16:43:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 14:43:28 +0000
Subject: [Koha-bugs] [Bug 20703] Add ability to void any credit
In-Reply-To: <bug-20703-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20703-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20703-70-dxfZAl8tAm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20703

Chris Slone <cslone at camdencountylibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cslone at camdencountylibrary.
                   |                            |org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 16:43:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 14:43:11 +0000
Subject: [Koha-bugs] [Bug 20262] Add ability to refund lost item fees
 without creating credits
In-Reply-To: <bug-20262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20262-70-l9Zag9l7F8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262

Chris Slone <cslone at camdencountylibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cslone at camdencountylibrary.
                   |                            |org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 16:43:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 14:43:44 +0000
Subject: [Koha-bugs] [Bug 2454] Improve display of credits on pay fines tab
In-Reply-To: <bug-2454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2454-70-LOJ8v862eX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454

Chris Slone <cslone at camdencountylibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cslone at camdencountylibrary.
                   |                            |org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 16:59:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 14:59:49 +0000
Subject: [Koha-bugs] [Bug 20932] New: Add multiple items should have a
 maximum number to be able to add at a time
Message-ID: <bug-20932-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20932

            Bug ID: 20932
           Summary: Add multiple items should have a maximum number to be
                    able to add at a time
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: nick at bywatersolutions.com
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

Currently, when adding items to an existing record- the option is to add item,
duplicate or add multiple items.  When the option is chosen for adding multiple
items, there is a box displayed that a quantity can be entered. If the number
is large (above 100) there is a pop-up message confirming this many.  

In addition to the pop-up, it would be helpful for a system preference to set a
maximum number for this feature -as it is with Batch Item Modification / Batch
Item Deletion.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 17:06:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 15:06:42 +0000
Subject: [Koha-bugs] [Bug 20933] New: Modifying the Advanced Prediction
 Pattern in Serials
Message-ID: <bug-20933-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20933

            Bug ID: 20933
           Summary: Modifying the Advanced Prediction Pattern in Serials
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

Within the Serials Module, when modifying the Advanced prediction pattern- the
user has to click modify pattern before making changes.  When this modification
is made, then the pattern must be saved.  Couldn't the change be made without
having to click modify?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 17:10:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 15:10:11 +0000
Subject: [Koha-bugs] [Bug 20899] Patron name not showing on issuehistory.pl
In-Reply-To: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20899-70-Aq4Px0yVIj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 17:10:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 15:10:53 +0000
Subject: [Koha-bugs] [Bug 20899] Patron name not showing on issuehistory.pl
In-Reply-To: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20899-70-UEnFlXSgMt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 17:10:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 15:10:57 +0000
Subject: [Koha-bugs] [Bug 20899] Patron name not showing on issuehistory.pl
In-Reply-To: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20899-70-kETfOw8GIa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75998|0                           |1
        is obsolete|                            |

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76027
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76027&action=edit
Bug 20899: Fix patron's name display

This is a follow-up for
  commit fa54100dffe092e606f79b15692eedaf78f42e45
  Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for
issuehistory]

We should use patron-title.inc to display (or hide) patron's info on the
checkout history view

Test plan:
Issue an item, go to the biblio, click the circulation history for this
tab.
Note that the patron's name is showing.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 17:15:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 15:15:23 +0000
Subject: [Koha-bugs] [Bug 20934] New: Biblio checkout history shows only
	current checkout
Message-ID: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934

            Bug ID: 20934
           Summary: Biblio checkout history shows only current checkout
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: josef.moravec at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

To reproduce:

1) Checkout an item to a patron

2) Go to the biblio record for this item and show checkouts history - you see
the current checkout

3) Check in the item back

4) Repeat 2), you will see there is not any checkout in checkouts history for
this biblio

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 17:20:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 15:20:48 +0000
Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the
 logged in user library group
In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18403-70-HMIcIFyDmG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20934


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934
[Bug 20934] Biblio checkout history shows only current checkout
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 17:20:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 15:20:48 +0000
Subject: [Koha-bugs] [Bug 20934] Biblio checkout history shows only current
	checkout
In-Reply-To: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20934-70-2LFYarSwSt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |18403


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403
[Bug 18403] Hide patron information if not part of the logged in user library
group
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 17:22:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 15:22:51 +0000
Subject: [Koha-bugs] [Bug 20918] left-side navigation broken on the checkout
	history page
In-Reply-To: <bug-20918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20918-70-ExNPV3UtXQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20918

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 17:23:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 15:23:47 +0000
Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
In-Reply-To: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17698-70-AhOUBFDS8T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75837|0                           |1
        is obsolete|                            |
  Attachment #75838|0                           |1
        is obsolete|                            |
  Attachment #75839|0                           |1
        is obsolete|                            |
  Attachment #75840|0                           |1
        is obsolete|                            |
  Attachment #75841|0                           |1
        is obsolete|                            |
  Attachment #75842|0                           |1
        is obsolete|                            |
  Attachment #76011|0                           |1
        is obsolete|                            |
  Attachment #76012|0                           |1
        is obsolete|                            |

--- Comment #60 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76028
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76028&action=edit
Bug 17698: Make patron notes show up on staff dashboard

This patch adds a user permission for managing issue notes, and a 'noteseen'
column to the issues table.

To test:
1) Apply Bug 14224 first
2) Apply this patch, update database, rebuild schema.
3) Restart koha-common and memcached
4) Turn on AllowCheckoutNotes syspref if haven't already
5) Issue two items to two different users (one item each)
6) Log into the OPAC as one of the users and add an issue note to their
issue
7) Log out and log back into the OPAC as the other user
8) Disable Javascript
9) Refresh opac-user.pl
10) Leave a checkout note on their issue
11) Enable javascript and log into the Staff Client as a superlibrarian
user
12) Go to your user's account and edit their permissions to have
everything ticked EXCEPT circulate->manage checkout notes.
13) Go to main intranet page. There should be no message saying
'checkout notes pending'.
14) Go to circulation home page. There should be no link to Checkout notes.
15) Go back to user's permissions and tick circulate->manage checkout notes.
16) Go back to main intranet page. There should now be a message at the
bottom saying 'Checkout notes pending: 2'
17) Go to circulation home page. There should be a link to Checkout notes
with a 2 next to it. Click this link
18) Attempt to mark an checkout note as seen. This should update the status
of the checkout note to 'seen' and disable to 'mark as seen' button while
enabling the 'mark as not seen' button.
19) Test both buttons with both issues.
20) Test select all and clear all buttons
21) Confirm that buttons at the bottom are only enabled if a checkbox is
checked
22) Try selecting both issues and using the buttons at the bottom to
mark multiple issue notes at once.
23) Confirm the barcode link to the item works as expected.
24) Confirm the cardnumber link to the user works as expected.
25) Confirm all table details show correctly.

Sponsored-by: Catalyst IT

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Followed test plan, works as expected
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Amended patch: Remove self-checkout permissions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 17:23:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 15:23:54 +0000
Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
In-Reply-To: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17698-70-vSEsjrjW6u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

--- Comment #61 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76029
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76029&action=edit
Bug 17698: (follow-up) Changing to Koha Objects style, adding circ sidebar

Marcel, can you please have a look at this patch. I tried to implement
the change
my @notes = $schema->resultset('Issue')->search({ 'me.note' => { '!=', undef }
}, { prefetch => [ 'borrower', { item => 'biblionumber' } ] });
to
my @notes = Koha::Checkouts->search({ 'me.note' => { '!=', undef } }, {
prefetch => [ 'borrower', { item => 'biblionumber' } ] });
but am having problems on the template side. I can access the item and
biblio information about the issue, but not the borrower information,
even though the query is definitely pulling it correctly. Any
suggestions or ideas as to why this breaks?

This patch also adds the implementation of the circSidebar.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 17:23:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 15:23:41 +0000
Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
In-Reply-To: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17698-70-RYDI9DM0q6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 17:24:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 15:24:00 +0000
Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
In-Reply-To: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17698-70-WpQ4jTimgy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

--- Comment #62 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76030
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76030&action=edit
Bug 17698: (follow-up) Koha Objects, access borrower through patron sub

See Comment 27
This is ready to be tested.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 17:24:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 15:24:06 +0000
Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
In-Reply-To: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17698-70-W8bn0HMaB5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

--- Comment #63 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76031
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76031&action=edit
Bug 17698: (follow-up) Fixing some small issues

Fixing the comments in Comment 42

Ready to test

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 17:24:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 15:24:13 +0000
Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
In-Reply-To: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17698-70-DeL1giSkf8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

--- Comment #64 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76032
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76032&action=edit
Bug 17698: (QA follow-up) Changes to use Asset TT plugin (bug 20538)

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 17:24:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 15:24:19 +0000
Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
In-Reply-To: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17698-70-H3v30FyeRL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

--- Comment #65 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76033
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76033&action=edit
Bug 17698: (follow-up) Rebase and schema update

Setting to signed off.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 17:24:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 15:24:25 +0000
Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
In-Reply-To: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17698-70-cMkPY4iX4I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

--- Comment #66 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76034
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76034&action=edit
Bug 17698: (QA follow-up) Fix minors design issues

This patch includes some changes required on comment 57:

1. Bad resolution conflict, permission self_checkout is re-add

2. The IGNORE modifier is missing in the INSERT statement

4. When I hit /circ/checkout-notes.pl from the side bar, the page displays
"Checkout notes", nothing else. We should add "There is no checkout notes".

7. I would display the table on the confirmation screen as well

10. html filters are missing

11. span element should surround translatable string, to help translators

14. patron-title.inc must be used to display patron's info

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 17:24:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 15:24:31 +0000
Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
In-Reply-To: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17698-70-yje8pOqgzh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

--- Comment #67 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76035
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76035&action=edit
Bug 17698: (follow-up) Fixing things in Comment 57

3. In the JS console: "ReferenceError: $ is not defined", I did not
investigate it.

Where do you see this in the console? I cannot recreate on opac-user.pl
or on circ/checkout-notes.pl.

5. The alert id=error is displayed then hide in JS, but it's then
displayed half a second. We should hide it by default (css)

Fixed in this patch

6. I would move the "mark seen" and "mark not seen" buttons at the
top of the table

Fixed in this patch

8. Cursor on "Select all" and "Clear all" links must be adjusted

Fixed in this patch

9. $(".btn-xs").click(function(event){
The selector should be $("button.seen, button.notseen"), you
do not want to apply this function to all other btn-xs on
the page (maybe there are only two for now, but who knows
later?)

Fixed in this patch

12. Important: When a note is updated, it's still marked as
seen. Is it the expected behavior?

I don't see this behaviour. When a note is updated it is
marked as not seen.
opav/svc/checkout_notes:79: $issue->set({ notedate =>
dt_from_string(), note => $clean_note, noteseen => 0
})->store;

13. What will happen when hundred of notes will be on this
table? Not blocker but we will need a "hide seen" buttons to
filters the already seen notes.

Added in this patch

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 17:24:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 15:24:37 +0000
Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
In-Reply-To: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17698-70-Te2VAKRhXF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

--- Comment #68 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76036
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76036&action=edit
Bug 17698: (QA follow-up) few more things

1. body tag was missing
2. make "Date" column sortable correctly
3. remove CDATA and type="text/javascript"
4. Handle server-side errors

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 17:24:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 15:24:43 +0000
Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
In-Reply-To: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17698-70-VWQZvqGMVd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

--- Comment #69 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76037
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76037&action=edit
Bug 17698: Do not send pending_checkout_notes from all circ scripts

It's safer to send what we need from C4::Auth it's needed from a whole
module.
The SELECT COUNT(*) query will only be done when needed (so not made
from scripts outside of circ)

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 17:26:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 15:26:48 +0000
Subject: [Koha-bugs] [Bug 20918] left-side navigation broken on the checkout
	history page
In-Reply-To: <bug-20918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20918-70-nJ2OsXXR6t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20918

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 17:26:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 15:26:50 +0000
Subject: [Koha-bugs] [Bug 20918] left-side navigation broken on the checkout
	history page
In-Reply-To: <bug-20918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20918-70-eLAltdPOnG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20918

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75999|0                           |1
        is obsolete|                            |

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76038&action=edit
Bug 20918: Fix left-side navigation on the checkout history page

commit fa54100dffe092e606f79b15692eedaf78f42e45
  Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for
issuehistory]

Removed:
-    biblionumber => $biblionumber, # required for left-side navigation

But did not deal with the side-effects.

Test plan:
When you are on the "Checkout history" page
(/cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=42),
the left-side navigation is broken if this patch is not applied, the
biblionumber is not set.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 17:27:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 15:27:02 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-I3AO4P3wBr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #77 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Hello Alex

I tested again but I don't see any change about what Joseph Moravec told about
nor about jumping checkboxes.

Am I missing something ?

Olivier

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 17:28:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 15:28:41 +0000
Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
In-Reply-To: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17698-70-N7fg24bJjB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|Academy                     |release-notes-needed

--- Comment #70 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Thanks Aleisha for your quick follow-up, very appreciated.

Take a look at the 2 last follow-ups I have attached, they fixed few more
things and remove duplication of code. You should also make sure your commit
messages fit the coding guidelines
(https://wiki.koha-community.org/wiki/Commit_messages#Examples), maybe you
should update your qa-test-tools repo, there are new checks to catch that.

This new enhancement is well polished and the code is easy to read. Congrats!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 17:35:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 15:35:56 +0000
Subject: [Koha-bugs] [Bug 20934] Biblio checkout history shows only current
	checkout
In-Reply-To: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20934-70-q8sU5gtMg8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Keywords|                            |rel_18_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 17:36:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 15:36:04 +0000
Subject: [Koha-bugs] [Bug 20934] Biblio checkout history shows only current
	checkout
In-Reply-To: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20934-70-vBJoJQXpgW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 17:38:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 15:38:38 +0000
Subject: [Koha-bugs] [Bug 10047] Cataloguing search maybe useless?
In-Reply-To: <bug-10047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10047-70-koqfv10nHB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10047

Barbara Johnson <barbara.johnson at bedfordtx.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |barbara.johnson at bedfordtx.g
                   |                            |ov

--- Comment #14 from Barbara Johnson <barbara.johnson at bedfordtx.gov> ---
Our catalogers use the cataloguing search (/cataloguing/addbooks.pl) on a daily
basis.  We're able to easily find our records at the top of the list.  We don't
really pay any attention to the records in the reservoir.  For me, the display
at cataloguing search (/cataloguing/addbooks.pl is cleaner.  It displays less
information making it easier for me to detect the records I want to work with. 
Also, I do much less scrolling since I don't have to look at a longer display
for each record that includes the items.  Personally, I don't want it to go
away.  Maybe it could be a system preference to turn on/off. Or maybe libraries
that don't want to see it could hide the buttons and links with some
css/jquery.  Just my two cents.

Barbara Johnson

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 17:47:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 15:47:02 +0000
Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records
In-Reply-To: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9302-70-ISRywfhaL9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 18:17:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 16:17:08 +0000
Subject: [Koha-bugs] [Bug 20934] Biblio checkout history shows only current
	checkout
In-Reply-To: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20934-70-0MpLMwoGib@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20899


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899
[Bug 20899] Patron name not showing on issuehistory.pl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 18:17:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 16:17:08 +0000
Subject: [Koha-bugs] [Bug 20899] Patron name not showing on issuehistory.pl
In-Reply-To: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20899-70-D9lAE2Z3E0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20934


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934
[Bug 20934] Biblio checkout history shows only current checkout
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 18:17:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 16:17:52 +0000
Subject: [Koha-bugs] [Bug 18623] Send notification on creation of manual
	invoice
In-Reply-To: <bug-18623-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18623-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18623-70-zljij5zAkt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18623

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 18:20:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 16:20:15 +0000
Subject: [Koha-bugs] [Bug 20935] New: Redesign system preferences interface
Message-ID: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

            Bug ID: 20935
           Summary: Redesign system preferences interface
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Created attachment 76039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76039&action=edit
Screenshot showing system preferences standard view

I think the system preferences page could use some work to make it more
readable. My proposal does this:

- Restructure the preferences list as a <dl>, with the preference name as the
<dt> and the description as the <dd>.
- Add a JS filter library (mark.js) to do live filtering of the page and add
search term highlighting.
- When the user has searched, show links to the sections in which results were
returned.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 18:21:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 16:21:01 +0000
Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface
In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20935-70-DIRpr7eEjz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76040
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76040&action=edit
Screenshot showing system preferences filtered using in-page filter

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 18:21:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 16:21:45 +0000
Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface
In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20935-70-hIBMvQO9oM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76041&action=edit
Screenshot showing system preferences search results

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 18:28:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 16:28:37 +0000
Subject: [Koha-bugs] [Bug 20899] Patron name not showing on issuehistory.pl
In-Reply-To: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20899-70-ImFfbUNzyV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76027|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76042&action=edit
Bug 20899: Fix patron's name display

This is a follow-up for
  commit fa54100dffe092e606f79b15692eedaf78f42e45
  Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for
issuehistory]

We should use patron-title.inc to display (or hide) patron's info on the
checkout history view

Test plan:
Issue an item, go to the biblio, click the circulation history for this
tab.
Note that the patron's name is showing.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 18:28:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 16:28:55 +0000
Subject: [Koha-bugs] [Bug 20899] Patron name not showing on issuehistory.pl
In-Reply-To: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20899-70-cuWheORAOe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Patch amended, td tag was not closed!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 18:34:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 16:34:55 +0000
Subject: [Koha-bugs] [Bug 20934] Biblio checkout history shows only current
	checkout
In-Reply-To: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20934-70-Tc5WMxlyZ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 18:34:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 16:34:59 +0000
Subject: [Koha-bugs] [Bug 20934] Biblio checkout history shows only current
	checkout
In-Reply-To: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20934-70-200tCCamj1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76043&action=edit
Bug 20934: Fix display of old checkouts in the checkout history page

Again a regression caused by
  commit fa54100dffe092e606f79b15692eedaf78f42e45
  Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for
issuehistory]

GetBiblioIssues does a union all with issues and old_issues, so we
should old_issues as well.
To make the join on the items table we need to define the item and
patron methods. For consistency the relationships have been redefined
(item instead of itemnumber, borrower instead of borrowernumber) in the
DBIx::Class definition.

This is not perfect but I think the best way to provide an easy to
backport patch.

It highlights that we need improvements in this area.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 19:14:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 17:14:45 +0000
Subject: [Koha-bugs] [Bug 20936] New: Holds History for patrons in OPAC
Message-ID: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

            Bug ID: 20936
           Summary: Holds History for patrons in OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: eveal at mckinneytexas.org
        QA Contact: testopia at bugs.koha-community.org

I think it would be very nice to add the "Hold History" for the patrons to
access in the OPAC. I don't know if the bug to add it to the staff site would
be useful or not but here it is.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919

Ed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 20:33:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 18:33:34 +0000
Subject: [Koha-bugs] [Bug 20127] Label Making Solution
In-Reply-To: <bug-20127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20127-70-JY1NfNldtO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20127

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #1)
> This sounds like extensive functionality planned. Why a plugin and not a
> solution within Koha? Because it wouldn't fit besides the existing label
> editor? Maybe it could use a part of it like the batch process? We also have
> the quick label printing where a little of that is possible, but not quite.
> But they are formatted to be changed by CSS easily.

That is correct. The solution we've come up with needs to handle label sheets
with multiple sizes of labels. We've created a plugin that generates labels
using HTML and CSS, rather than generating PDFs. I decided to go the plugin
route do to the radical difference in functionality and the ability to react to
the need for changes.

Once the plugin can be considered 'stable' I would like to get community
consideration on integrating the plugin functionality into Koha proper.

I think the biggest consideration is that all the power this label printer
plugin comes with is at the cost of simplicity. I think we'd need to keep the
existing label maker as well. I don't think there would be an easy upgrade
path.

https://github.com/bywatersolutions/koha-plugin-label-maker

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 20:40:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 18:40:48 +0000
Subject: [Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin
In-Reply-To: <bug-10659-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10659-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10659-70-FCiQ3USK7U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 20:41:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 18:41:19 +0000
Subject: [Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin
In-Reply-To: <bug-10659-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10659-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10659-70-636O4k6ItJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Mason James from comment #4)
> Hi Owen, this one looks quite good...
>  http://antenna.io/demo/jquery-bar-rating/examples/

I'm working on a solution now that uses this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 20:42:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 18:42:15 +0000
Subject: [Koha-bugs] [Bug 20847] Add the fields to the Batch Patron
	Modification tool
In-Reply-To: <bug-20847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20847-70-qX6Wjy62Ym@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20847

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 20:43:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 18:43:10 +0000
Subject: [Koha-bugs] [Bug 9181] Add patron messaging preference to Batch
 Patrons Modification tool
In-Reply-To: <bug-9181-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9181-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9181-70-00b7vjxQSk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9181

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 20:45:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 18:45:17 +0000
Subject: [Koha-bugs] [Bug 19793] Add a field for email in batch patron
	modification
In-Reply-To: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19793-70-NAyWOFWutH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 20:56:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 18:56:50 +0000
Subject: [Koha-bugs] [Bug 20937] New: PrintNoticesMaxLines is not effective
 for overdue notices with a print type specified where a patron has an email
Message-ID: <bug-20937-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20937

            Bug ID: 20937
           Summary: PrintNoticesMaxLines is not effective for overdue
                    notices with a print type specified where a patron has
                    an email
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

The logic in the script is:
if ( ( scalar(@emails_to_use) == 0 || $nomail ) && $PrintNoticesMaxLines && $j
>= $PrintNoticesMaxLines )

So if we don't pass 'nomail' and the patron has an email, the items don't get
kicked out.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 21:12:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 19:12:09 +0000
Subject: [Koha-bugs] [Bug 20937] PrintNoticesMaxLines is not effective for
 overdue notices with a print type specified where a patron has an email
In-Reply-To: <bug-20937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20937-70-elpADIuu0o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20937

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 21:12:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 19:12:12 +0000
Subject: [Koha-bugs] [Bug 20937] PrintNoticesMaxLines is not effective for
 overdue notices with a print type specified where a patron has an email
In-Reply-To: <bug-20937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20937-70-s2HaA1jKHq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20937

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 76044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76044&action=edit
Bug 20937: Truncate items for print notices when user has an email

To test:
 1 - Set PrintNotciesMaxLines to 1
 2 - Checkout 2 (or more) items to a patron and make them overdue to trigger a
notice
 3 - Make sure the patron has an email
 4 - Make sure the notice you are sending is set to 'print' as the type
 5 - Run overdue_notices.pl without the 'nomail' option
 6 - Find the message and note all items have been added
 7 - Apply patch
 8 - Clear the message queue
 9 - Re-run overdue_notices.pl
10 - Confirm the message now has only 1 item.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 22:10:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 20:10:52 +0000
Subject: [Koha-bugs] [Bug 20937] PrintNoticesMaxLines is not effective for
 overdue notices with a print type specified where a patron has an email
In-Reply-To: <bug-20937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20937-70-NmV0SpfURM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20937

Chris Slone <cslone at camdencountylibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cslone at camdencountylibrary.
                   |                            |org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 22:29:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 20:29:12 +0000
Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing
 personal data in account menu and self-registration
In-Reply-To: <bug-20819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20819-70-PCq7DtgFXG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 22:29:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 20:29:30 +0000
Subject: [Koha-bugs] [Bug 20605] Make possible to set patron's privacy from
	staff client
In-Reply-To: <bug-20605-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20605-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20605-70-x8GHbKNsk9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20605

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 13 22:29:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 20:29:37 +0000
Subject: [Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection
	Regulation)
In-Reply-To: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18081-70-MDOgPE5UUn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 00:38:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 22:38:25 +0000
Subject: [Koha-bugs] [Bug 20924] News content textarea not showing
In-Reply-To: <bug-20924-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20924-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20924-70-zLWZmjhxNW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20924

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I do not recreate the issue, works for me on master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 01:18:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 23:18:33 +0000
Subject: [Koha-bugs] [Bug 20938] New: Resetting patrons password would
 resend patron patron detail email
Message-ID: <bug-20938-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20938

            Bug ID: 20938
           Summary: Resetting patrons password would resend patron patron
                    detail email
 Change sponsored?: ---
           Product: Koha
           Version: 17.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Currently, staff can reset a patron's password in Koha.  However, it would be
nice to have Koha send an email with this password/patron details (as it does
when registering a new patron) to the patron instead of having the staff write
down and/or tell the patron the password.  Due to security it would be nice if
this was done without staff interaction with the actual password.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 01:28:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jun 2018 23:28:34 +0000
Subject: [Koha-bugs] [Bug 20939] New: Add Authorized Values for the 008 Marc
 Fields within Rancor / Advanced Editor
Message-ID: <bug-20939-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20939

            Bug ID: 20939
           Summary: Add Authorized Values for the 008 Marc Fields within
                    Rancor / Advanced Editor
 Change sponsored?: ---
           Product: Koha
           Version: 17.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

It would be nice to have authorized values for the 008/15-17 Place of
publication, reproduction or execution(MARC Code List for Countries) loaded
into the MARC bib editor? 


In addition, authorized values for 008/35-37 Language (MARC Code List for
Languages) . It also would be nice to link those to the system preference of
which languages the library currently has, as to not have them all listed.


There are other drop down lists for other authorized values, but not for place
of publication and language of the item.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 08:10:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 06:10:13 +0000
Subject: [Koha-bugs] [Bug 20940] New: It should not be possible to check out
 a deleted item
Message-ID: <bug-20940-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20940

            Bug ID: 20940
           Summary: It should not be possible to check out a deleted item
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: boutrosboutrosboutros at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

After merging deleteditems and items tables (bug #20271), we have to update
CanBookBeIssued, to return an error if the item is deleted.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 08:10:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 06:10:37 +0000
Subject: [Koha-bugs] [Bug 20940] It should not be possible to check out a
	deleted item
In-Reply-To: <bug-20940-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20940-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20940-70-xiD9sSQ7i1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20940

Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20271


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
[Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items
tables with their "alive" cousins
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 08:10:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 06:10:37 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-K0gInT7C9m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20940


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20940
[Bug 20940] It should not be possible to check out a deleted item
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 08:11:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 06:11:43 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-5wIjiF03za@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #122 from Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> ---
Thanks a lot to the QA team!

I found an issue now: we forgot to update CanBookBeIssued to check if item is
deleted. So ATM it is possible to check out a deleted book (but it cannot be
checked in again). We could either return UNKNOWN_BARCODE from CanBookBeIssued,
or add a separate error code DELETED?. Opened a new bug for this, see bug
#20940

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 08:22:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 06:22:28 +0000
Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting
	with plack
In-Reply-To: <bug-15562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15562-70-0ukbarwSXl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 09:23:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 07:23:25 +0000
Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
In-Reply-To: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20664-70-PdTzcXwYn0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75968|0                           |1
        is obsolete|                            |

--- Comment #9 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 76045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76045&action=edit
Bug 20664: Optimize retrieval of biblio and item data

Optimizes embedding of item data in MARC and fixes several bottlenecks
encountered while profiling OAI-PMH and exporting of records. There are three
ways this is accomplished:

1.) Use state variables to hold prepared SQL statements so that the preparation
is done only once.
2.) Create optimized method for fetching item fields for MARC embedding.
3.) Use the cache service more and where repeated calls are made.

Test plan:

1.) Before applying the patch, time an export_records.pl run for a set of
biblios that also have items. Run it a couple of times to account for initial
slowness and possible fluctuations. For example:

time misc/export_records.pl --record-type bibs --starting_biblionumber 960000
--ending_biblionumber 965000 --format xml --filename unoptimized.xml

2.) Apply the patch.

3.) Time the export process again with a different output file:

time misc/export_records.pl --record-type bibs --starting_biblionumber 960000
--ending_biblionumber 965000 --format xml --filename optimized.xml

4.) Verify that the optimized process is faster.

5.) Compare the resulting export files to make sure they're identical:

diff -u unoptimized.xml optimized.xml

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 09:24:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 07:24:54 +0000
Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
In-Reply-To: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20664-70-F5VAE1Jx2t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #10 from Ere Maijala <ere.maijala at helsinki.fi> ---
Latest patch removes the custom YAML caching and fixes tests to properly flush
all caches after changing the settings. Additionally fixes warnings surfaced by
the use of Modern::Perl.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 09:54:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 07:54:48 +0000
Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
In-Reply-To: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20664-70-7aPjoKCq3t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76045|0                           |1
        is obsolete|                            |

--- Comment #11 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 76046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76046&action=edit
Bug 20664: Optimize retrieval of biblio and item data

Optimizes embedding of item data in MARC and fixes several bottlenecks
encountered while profiling OAI-PMH and exporting of records. There are three
ways this is accomplished:

1.) Use state variables to hold prepared SQL statements so that the preparation
is done only once.
2.) Create optimized method for fetching item fields for MARC embedding.
3.) Use the cache service more and where repeated calls are made.

Test plan:

1.) Before applying the patch, time an export_records.pl run for a set of
biblios that also have items. Run it a couple of times to account for initial
slowness and possible fluctuations. For example:

time misc/export_records.pl --record-type bibs --starting_biblionumber 960000
--ending_biblionumber 965000 --format xml --filename unoptimized.xml

2.) Apply the patch.

3.) Time the export process again with a different output file:

time misc/export_records.pl --record-type bibs --starting_biblionumber 960000
--ending_biblionumber 965000 --format xml --filename optimized.xml

4.) Verify that the optimized process is faster.

5.) Compare the resulting export files to make sure they're identical:

diff -u unoptimized.xml optimized.xml

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 10:07:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 08:07:30 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-VTGC1pMvK4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #123 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Ack, How did I miss that!.. I'm going to give this a third pass today to make
sure I've not missed anything else :(

In related news, I've added my proposed manual update as a merge request here
https://gitlab.com/koha-community/koha-manual/merge_requests/135/diffs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 12:30:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 10:30:18 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-UjtE0eulJO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #124 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Petter Goks?yr ?sen from comment #122)
> Thanks a lot to the QA team!
> 
> I found an issue now: we forgot to update CanBookBeIssued to check if item
> is deleted. So ATM it is possible to check out a deleted book (but it cannot
> be checked in again). We could either return UNKNOWN_BARCODE from
> CanBookBeIssued, or add a separate error code DELETED?. Opened a new bug for
> this, see bug #20940

By that logic, we should also add handling to CanBookBeRenewed ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 12:33:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 10:33:46 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-WLpTKRgkLp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #125 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
:( Looks like a missed a whole swathe of issues now I dig into this.

I believe we should NOT be changing the expected return of GetItem (i.e deleted
items should not be returned from GetItem) to stay compliant with existing
functions. I can't believe I missed this in the changed test file :(.  We are
not consistently dealing with deleted_on after every invocation of GetItem
currently and as such this patchset currently introduces a fairly significant
number of untested bugs :(.

Thanks to Petter for spotting the issue that lead me to realise the extent of
my failings as QA here :(.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 12:44:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 10:44:52 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-w3Ovy6WMyG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #126 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 76047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76047&action=edit
Bug 20271: Restore original GetItem functionality

The return value of GetItem had been changed (as it would now return
deleted items as well as current items). This patch restores the
original functionality (as we've not catered for all calls to GetItem
independantly), restores the original test as well as adding a further
test to catch the correct setting of deleted_on by DelItem

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 12:45:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 10:45:54 +0000
Subject: [Koha-bugs] [Bug 20940] It should not be possible to check out a
	deleted item
In-Reply-To: <bug-20940-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20940-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20940-70-cz926jFD64@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20940

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Closing this one as I feel there's more to catch in the original bug still and
have set it back to Failed QA pending a further set of eyes looking at it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 12:46:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 10:46:52 +0000
Subject: [Koha-bugs] [Bug 20940] It should not be possible to check out a
	deleted item
In-Reply-To: <bug-20940-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20940-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20940-70-I9TPvY7UQG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20940

--- Comment #2 from Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> ---
I agree. Anyways handling it at GetItem seems like a better idea.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 13:04:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 11:04:58 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-CseZwsZvaQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #127 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 76048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76048&action=edit
Bug 20271: (QA follow-up) Restore original GetItem functionality

The return value of GetItem had been changed (as it would now return
deleted items as well as current items). This patch restores the
original functionality (as we've not catered for all calls to GetItem
independantly), restores the original test as well as adding a further
test to catch the correct setting of deleted_on by DelItem

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 13:05:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 11:05:46 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-LpNHPqaTht@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76047|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 13:10:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 11:10:42 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-JVOaXIgDhg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #128 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
C4::Items::ModItem should probably not be allowed to alter deleted_on as we
have a DelItem routine.. save a future misuse.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 13:34:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 11:34:09 +0000
Subject: [Koha-bugs] [Bug 20919] A Zebra query is done for each item when
 opening a record detail page
In-Reply-To: <bug-20919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20919-70-HXX7me8Knx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20919

Hugo Agud <hagud at orex.es> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P4
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 14:55:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 12:55:34 +0000
Subject: [Koha-bugs] [Bug 19972] Holds to pull should honor syspref
	"item-level_itypes"
In-Reply-To: <bug-19972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19972-70-p4muSGjrN0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #16 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.07.

Easy rebase conflict because JS has moved to bottom.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:01:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:01:49 +0000
Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search
	fields from UI
In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20388-70-QKfzgDUYRx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:02:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:02:20 +0000
Subject: [Koha-bugs] [Bug 20941] New: Displaying requests does not display
 request material type
Message-ID: <bug-20941-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941

            Bug ID: 20941
           Summary: Displaying requests does not display request material
                    type
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: ILL
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew.isherwood at ptfs-europe.com

I'm not sure when this crept in. At some point we switched from storing
material type in illrequests.medium to an arbitrary attribute in
illrequestattributes. However, the display end of things wasn't updated
accordingly.

As such, material type doesn't display in any of the UIs, it should!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:02:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:02:37 +0000
Subject: [Koha-bugs] [Bug 20941] Displaying requests does not display
 request material type
In-Reply-To: <bug-20941-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20941-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20941-70-JqyDQSqu33@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ
                   |ity.org                     |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:06:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:06:25 +0000
Subject: [Koha-bugs] [Bug 12586] Record matching rules - Required match
 checks doesn't work with MARCXML
In-Reply-To: <bug-12586-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12586-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12586-70-gR3kvNLYWp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|olli-antti.kivilahti at jns.fi |victor.grousset at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:08:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:08:39 +0000
Subject: [Koha-bugs] [Bug 20875] OpacAddMastheadLibraryPulldown displays an
	empty list
In-Reply-To: <bug-20875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20875-70-t5ontjskEw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
         Resolution|---                         |FIXED

--- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 16735 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:09:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:09:15 +0000
Subject: [Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin
In-Reply-To: <bug-10659-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10659-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10659-70-uWiGKaEsVQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:09:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:09:17 +0000
Subject: [Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin
In-Reply-To: <bug-10659-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10659-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10659-70-qTg30P5j7B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76049&action=edit
Bug 10659: Upgrade jQuery star ratings plugin

This patch replaces our current jQuery star ratings plugin with a newer
plugin which will be compatible with newer versions of jQuery:

http://antenna.io/demo/jquery-bar-rating/examples/

To test you should have one or more records in your catalog with star
ratings.

- Apply the patch and set the OpacStarRatings system preference
  to "results and details"
- Perform a search in the catalog which will return one or more titles
  which have ratings.
  - Confirm that the ratings appear correctly and the ratings are
    read-only.
- Open the "normal" detail page for that record.
  - Confirm that the star rating appears correctly.
  - Test setting and re-setting your star rating. Confirm that it is
    saved.
  - Confirm that the "cancel rating" link appears when you have a rating
    set, and that it disappears after you click it.
- Test that the "only details" and disabled options of the
  OpacStarRatings preference work as they should.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:09:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:09:20 +0000
Subject: [Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin
In-Reply-To: <bug-10659-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10659-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10659-70-pT4XCzL5XO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76050&action=edit
Bug 10659: (follow-up) Compiled CSS

This patch contains the compiled CSS.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:10:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:10:32 +0000
Subject: [Koha-bugs] [Bug 20617] Add 'Search Engine configuration' link to
 administration menu
In-Reply-To: <bug-20617-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20617-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20617-70-GPTaosKbR0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20617

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:12:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:12:46 +0000
Subject: [Koha-bugs] [Bug 20120] Prevent writeoffs of more than the amount
	owed for a fee
In-Reply-To: <bug-20120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20120-70-807Wnu4o58@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #36 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Patches does not apply on 17.11.x.
Can you provide a rebase ? (maybe squash commits)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:15:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:15:06 +0000
Subject: [Koha-bugs] [Bug 20671] Adding "surname" to instructions.
 import_borrowers.pl / import_borrowers.tt
In-Reply-To: <bug-20671-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20671-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20671-70-ZAt24t8JI4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20671

Cab Vinton <bibliwho at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bibliwho at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:16:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:16:46 +0000
Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines
	list
In-Reply-To: <bug-15136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15136-70-9FZyp3HzwM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136

Cab Vinton <bibliwho at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bibliwho at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:16:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:16:54 +0000
Subject: [Koha-bugs] [Bug 20829] 'Link to host item' gives internal server
	error
In-Reply-To: <bug-20829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20829-70-r8GqPZubgI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20829

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:17:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:17:52 +0000
Subject: [Koha-bugs] [Bug 16461] Add some information (branch and barcode)
 in fine description for overdue
In-Reply-To: <bug-16461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16461-70-jKOJECRNfZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16461

Cab Vinton <bibliwho at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bibliwho at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:18:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:18:27 +0000
Subject: [Koha-bugs] [Bug 16639] Split item data from description in Fines
 tab into separate columns
In-Reply-To: <bug-16639-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16639-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16639-70-HdI02RVF1Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16639

Cab Vinton <bibliwho at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bibliwho at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:22:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:22:06 +0000
Subject: [Koha-bugs] [Bug 20053] Drop type attribute "text/javascript" for
 <script> elements used in OPAC templates
In-Reply-To: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20053-70-rJTnDLJ7LK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #15 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Too much conflicts in 17.11.x.
Since its not critical, I choose not to backport

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:22:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:22:06 +0000
Subject: [Koha-bugs] [Bug 20066] Remove forbidden patterns from .inc and .tt
	files
In-Reply-To: <bug-20066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20066-70-csn8Aa0a3p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20066
Bug 20066 depends on bug 20053, which changed state.

Bug 20053 Summary: Drop type attribute "text/javascript" for <script> elements used in OPAC templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:22:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:22:49 +0000
Subject: [Koha-bugs] [Bug 20778] Unable to delete a subscription
In-Reply-To: <bug-20778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20778-70-MlUNVSjXBF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #14 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 19777 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:25:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:25:09 +0000
Subject: [Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin
In-Reply-To: <bug-10659-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10659-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10659-70-OVeqXammVq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76051&action=edit
Bug 10659: (follow-up) Add plugin information to the about page

This patch updates the about page in the staff client, replacing the
information about the jQuery Star Ratings plugin with information about
the new jQuery Bar Ratings plugin.

To test, apply the patch and go to the about page in the staff client.
Confirm that the new information appears correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:31:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:31:37 +0000
Subject: [Koha-bugs] [Bug 18330] REST API: Date-time handling
In-Reply-To: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18330-70-i7qXPqohqW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20886

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:31:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:31:37 +0000
Subject: [Koha-bugs] [Bug 20886] Koha::Object::TO_JSON indiscriminately
 casting to integer
In-Reply-To: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20886-70-1pou6CQEtb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20886

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=18330

--- Comment #11 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:32:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:32:31 +0000
Subject: [Koha-bugs] [Bug 20886] Koha::Object::TO_JSON indiscriminately
 casting to integer
In-Reply-To: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20886-70-xV24PnON8q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20886

--- Comment #12 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Is this also for 17.11.x ?
It looks similar to Bug 18330

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:32:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:32:56 +0000
Subject: [Koha-bugs] [Bug 20941] Displaying requests does not display
 request material type
In-Reply-To: <bug-20941-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20941-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20941-70-gcjVVm4Sqr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941

--- Comment #1 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 76052
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76052&action=edit
Bug 20941: Add Illrequest->getType method

This patch adds a method to the Illrequest object enabling it to return
its type, which is stored as an Illrequestattribute object

To observe broken state:

- Do not apply patch
- Ensure you have at least one Interlibrary loan created
- In OPAC view, go to "your interlibrary loan requests"
  - => TEST: Observe that the "Request type" column is not populated
  - Click on "View" for one of the requests
  - => TEST: Observer that the "Request type" row is not populated
- In Staff view, go to "ILL requests"
- Click on "Manage request" on a request
  - => TEST: Observer that the "Request type" row is not populated

To Test:

- Apply patch
- In OPAC view, go to "your interlibrary loan requests"
  - => TEST: Observe that the "Request type" column IS populated
  - Click on "View" for one of the requests
  - => TEST: Observer that the "Request type" row IS populated
- In Staff view, go to "ILL requests"
- Click on "Manage request" on a request
  - => TEST: Observer that the "Request type" row IS populated

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:33:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:33:10 +0000
Subject: [Koha-bugs] [Bug 20941] Displaying requests does not display
 request material type
In-Reply-To: <bug-20941-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20941-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20941-70-TgU5WSHgOZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:33:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:33:20 +0000
Subject: [Koha-bugs] [Bug 20941] Displaying requests does not display
 request material type
In-Reply-To: <bug-20941-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20941-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20941-70-u0G0HufBHz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |7317


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:33:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:33:20 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-KWmqEANAAY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20941


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941
[Bug 20941] Displaying requests does not display request material type
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:35:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:35:46 +0000
Subject: [Koha-bugs] [Bug 20929] koha-dump should not pass a --password
 argument to mysqldump
In-Reply-To: <bug-20929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20929-70-zbRrEa3EoM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20929

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |normal
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|koha-bugs at lists.koha-commun |solaris.smoke at gmail.com
                   |ity.org                     |
             Status|NEW                         |Needs Signoff

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
We should create a .my.cnf, but this is much better than passing the password
in the options.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:37:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:37:39 +0000
Subject: [Koha-bugs] [Bug 20700] Update MARC21 leader/007/008 codes
In-Reply-To: <bug-20700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20700-70-I6TTlUwwJq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20700

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Does not apply on 17.11..x because of
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_field_007.tt
I'm not comfortable with MARC21 so can you provide a rebase ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:47:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:47:21 +0000
Subject: [Koha-bugs] [Bug 20942] New: Add route to get patron's account
	balance
Message-ID: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942

            Bug ID: 20942
           Summary: Add route to get patron's account balance
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: new feature
          Priority: P5 - low
         Component: REST api
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:47:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:47:32 +0000
Subject: [Koha-bugs] [Bug 20942] Add route to get patron's account balance
In-Reply-To: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20942-70-NVi0fr9tUn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
         Depends on|                            |17586


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586
[Bug 17586] Add the Koha::Account->balance method
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:47:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:47:32 +0000
Subject: [Koha-bugs] [Bug 17586] Add the Koha::Account->balance method
In-Reply-To: <bug-17586-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17586-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17586-70-O3vn9qbcun@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20942


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942
[Bug 20942] Add route to get patron's account balance
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:48:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:48:29 +0000
Subject: [Koha-bugs] [Bug 20942] Add route to get patron's account balance
In-Reply-To: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20942-70-NrZ650w5RM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |15165


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165
[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:48:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:48:29 +0000
Subject: [Koha-bugs] [Bug 15165] REST API routes to list,
 edit and pay borrower's accountlines
In-Reply-To: <bug-15165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15165-70-jSe20vO8gz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20942


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942
[Bug 20942] Add route to get patron's account balance
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:50:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:50:44 +0000
Subject: [Koha-bugs] [Bug 20756] OPAC "Share list" button should be styled
	with an icon
In-Reply-To: <bug-20756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20756-70-nQQLWAEFlX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
         Resolution|---                         |FIXED

--- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Not backported to 17.11.x.
I prefer not to change the compiled CSS.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:53:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:53:12 +0000
Subject: [Koha-bugs] [Bug 20851] Missing module in
	circ/article-request-slip.pl
In-Reply-To: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20851-70-lW16yfQrXc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #14 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:54:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:54:16 +0000
Subject: [Koha-bugs] [Bug 20942] Add route to get patron's account balance
In-Reply-To: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20942-70-kcnInIF3Cb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://wiki.koha-community
                   |                            |.org/wiki/Patrons_account_l
                   |                            |ines_endpoint_RFC

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:57:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:57:21 +0000
Subject: [Koha-bugs] [Bug 20943] New: Cannot enable shibboleth and LDAP at
	the same time
Message-ID: <bug-20943-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20943

            Bug ID: 20943
           Summary: Cannot enable shibboleth and LDAP at the same time
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

In C4::Auth->checkpw the authentication methods are in an elsif loop. When both
methods are enabled the ldap loop catches the login, fails because it doesn't
have the correct information, and a shibboleth login is not passed through.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:58:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:58:27 +0000
Subject: [Koha-bugs] [Bug 20942] Add route to get patron's account balance
In-Reply-To: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20942-70-xjqKiN1oLS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com,
                   |                            |lari.taskula at jns.fi,
                   |                            |m.de.rooy at rijksmuseum.nl,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:58:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:58:46 +0000
Subject: [Koha-bugs] [Bug 20942] Add route to get patron's account balance
In-Reply-To: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20942-70-xpGMCUm7xE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76053&action=edit
Bug 20942: OpenAPI spec for /patrons/{patron_id}/account

This patch adds the OpenAPI spec for the following paths:
- /patrons/{patron_id}/account

It also adds object definitions for:
- balance
- account line

Account line is to be used on both /account/lines (when implemented)
and for embeding the outstanding lines in the balance endpoint
(/patrons/{patron_id}/account).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:58:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:58:51 +0000
Subject: [Koha-bugs] [Bug 20942] Add route to get patron's account balance
In-Reply-To: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20942-70-rIYg9gMdNo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76054&action=edit
Bug 20942: Unit tests for /patrons/{patron_id}/account

This patch adds tests for the /patrons/{patron_id}/account endpoint.
To test:

- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/patrons_accounts.t
=> FAIL: Tests should fail because the endpoint is not implemented.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:58:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:58:56 +0000
Subject: [Koha-bugs] [Bug 20942] Add route to get patron's account balance
In-Reply-To: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20942-70-DRTA3cvwrB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76055
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76055&action=edit
Bug 20942: Add route to get patron's account balance

This patch implements the /patrons/{patron_id}/account endpoint. It can
be used to get the patron's balance information, including outstanding
lines.

To test:
- Apply this patchset
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/patrons_accounts.t
=> SUCCESS: tests pass!
- Make your favourite REST testing tool (RESTer on Firefox?) do:
  GET /api/v1/patrons/{patron_id}/account
to a valid patron_id. Play with Koha's UI to add credits/payments and
notice the endpoint returns the right info following the voted RFC. [1]
- Sign off :-D

[1] https://wiki.koha-community.org/wiki/Patrons_account_lines_endpoint_RFC

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 15:59:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 13:59:24 +0000
Subject: [Koha-bugs] [Bug 20942] Add route to get patron's account balance
In-Reply-To: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20942-70-FQ4sLuxCTT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 16:11:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 14:11:10 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
	source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-A8r1CixCBh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #74 from David Gustafsson <glasklas at gmail.com> ---
I'm actively working on fixing the remaining issues and moving relevant things
from C4 into the Koha namespace. Will probably submit changes tomorrow or
beginning of next week.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 16:14:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 14:14:19 +0000
Subject: [Koha-bugs] [Bug 20944] New: Add routes to add credits and debits
 to a patron's account
Message-ID: <bug-20944-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944

            Bug ID: 20944
           Summary: Add routes to add credits and debits to a patron's
                    account
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: new feature
          Priority: P5 - low
         Component: REST api
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 16:14:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 14:14:38 +0000
Subject: [Koha-bugs] [Bug 20942] Add route to get patron's account balance
In-Reply-To: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20942-70-IZA0YIBOSP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20944


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944
[Bug 20944] Add routes to add credits and debits to a patron's account
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 16:14:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 14:14:52 +0000
Subject: [Koha-bugs] [Bug 20944] Add routes to add credits and debits to a
 patron's account
In-Reply-To: <bug-20944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20944-70-dmwr7WT4zW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://wiki.koha-community
                   |                            |.org/wiki/Patrons_account_l
                   |                            |ines_endpoint_RFC

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 16:14:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 14:14:38 +0000
Subject: [Koha-bugs] [Bug 20944] Add routes to add credits and debits to a
 patron's account
In-Reply-To: <bug-20944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20944-70-ppu4OLaYbN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
         Depends on|                            |20942


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942
[Bug 20942] Add route to get patron's account balance
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 16:16:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 14:16:06 +0000
Subject: [Koha-bugs] [Bug 20898] Replace OPAC detail's results browser with
 non-JavaScript version
In-Reply-To: <bug-20898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20898-70-e8fnBc3bSC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20898

Chris Slone <cslone at camdencountylibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cslone at camdencountylibrary.
                   |                            |org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 16:20:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 14:20:29 +0000
Subject: [Koha-bugs] [Bug 20945] New: Report params not escaped when
	downloading
Message-ID: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945

            Bug ID: 20945
           Summary: Report params not escaped when downloading
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Caused by bug 18497

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 16:22:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 14:22:58 +0000
Subject: [Koha-bugs] [Bug 20945] Report params not escaped when downloading
In-Reply-To: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20945-70-ISaa94HyEE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 16:23:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 14:23:01 +0000
Subject: [Koha-bugs] [Bug 20945] Report params not escaped when downloading
In-Reply-To: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20945-70-O6c9y7SLfv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 76056
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76056&action=edit
Bug 20945: Escape SQL parameters when constructing download links

TO test:
1 - Create a report that takes a parameter
2 - Enter a parameter containing '%'
3 - Attempt to download report, note link is misconstructed
4 - Apply patch
5 - Reload
6 - Note URL is now correct

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 16:31:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 14:31:15 +0000
Subject: [Koha-bugs] [Bug 20919] A Zebra query is done for each item when
 opening a record detail page
In-Reply-To: <bug-20919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20919-70-hVPxdeqReV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20919

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
             Status|NEW                         |ASSIGNED
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 16:37:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 14:37:55 +0000
Subject: [Koha-bugs] [Bug 20919] A Zebra query is done for each item when
 opening a record detail page
In-Reply-To: <bug-20919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20919-70-VUmR0s89nc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20919

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 16:37:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 14:37:59 +0000
Subject: [Koha-bugs] [Bug 20919] A Zebra query is done for each item when
 opening a record detail page
In-Reply-To: <bug-20919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20919-70-VujXXx8Mw0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20919

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76057
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76057&action=edit
Bug 20919: Remove unecessary search calls on the biblio detail page

There is a countanalytics flag that is set for items used in analytical
biblio records. This flag is only used in the template when 'analyze'
has been passed to the script.
In order to avoid unecessary search calls (1 per item), $analyse must be
tested.

Test plan:
0. Do not apply the patch
1. tail -f /var/log/koha/kohadev/zebra-output.log
2. Hit a bibliographic record detail page with several items
3. Notice that the log has 1 line per item:
  11:30:36-14/06 zebrasrv(32) [warn] ir_session (exception)
4. Apply the patch
5. Hit the page again
6. There is nothing in the zebra log file

If you are familiar with analytic records, confirm that you are not
allowed to remove an item that is used in analytical biblio records.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 16:39:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 14:39:40 +0000
Subject: [Koha-bugs] [Bug 20928] Checkout status not showing patron
In-Reply-To: <bug-20928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20928-70-40BQxjrusO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20928

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_18_05_candidate
           Severity|normal                      |major
             Status|NEW                         |ASSIGNED
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 16:42:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 14:42:49 +0000
Subject: [Koha-bugs] [Bug 20928] Checkout status not showing patron
In-Reply-To: <bug-20928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20928-70-DuHwP1Wlil@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20928

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |18403

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Caused by
  commit 5f80977875ff124d411f2cd89de4a944fa9c27af
  Bug 18403: Use patron-title.inc when hidepatronname is used


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403
[Bug 18403] Hide patron information if not part of the logged in user library
group
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 16:42:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 14:42:49 +0000
Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the
 logged in user library group
In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18403-70-kdi0mIiU5g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20928


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20928
[Bug 20928] Checkout status not showing patron
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 16:45:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 14:45:33 +0000
Subject: [Koha-bugs] [Bug 20928] Checkout status not showing patron
In-Reply-To: <bug-20928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20928-70-MMTPoxXjgA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20928

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 16:45:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 14:45:37 +0000
Subject: [Koha-bugs] [Bug 20928] Checkout status not showing patron
In-Reply-To: <bug-20928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20928-70-R0HU8ck1NO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20928

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76058
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76058&action=edit
Bug 20928: Fix regression - display patron's info on moredetail if item is
checked out

This patch is a follow-up of
  commit 5f80977875ff124d411f2cd89de4a944fa9c27af
  Bug 18403: Use patron-title.inc when hidepatronname is used

Test plan:
- Check an item out
- Go on the moredetail.pl page of this biblio record
Home ? Catalog ? Item details for your biblio
- Confirm that you see:
"Checkout status: Checked out to"
followed by the patron's info

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 16:45:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 14:45:29 +0000
Subject: [Koha-bugs] [Bug 20823] UNIMARC XSLT does not display 604$t
In-Reply-To: <bug-20823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20823-70-pCmXwZu0wS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #3 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
I reproduce when 604 contains only $t.
But I've seen UNIMARC 604 has $a mandatory.
Please check with 604 $a and $t.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 16:52:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 14:52:48 +0000
Subject: [Koha-bugs] [Bug 20285] Lost item refund won't always pay down lost
 item fee first
In-Reply-To: <bug-20285-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20285-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20285-70-vF1PrDsbCy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20285

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Is this really minor?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 16:56:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 14:56:34 +0000
Subject: [Koha-bugs] [Bug 20700] Update MARC21 leader/007/008 codes
In-Reply-To: <bug-20700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20700-70-KZYS6ihtxE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20700

--- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 76059
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76059&action=edit
Bug 20700: MARC21 add/update leader/007/008 codes (17.11.x version)

For Koha 17.11.x version

This add/updates some codes from updates 22 (Apr/16)
and 23 (Nov/16)

Update 22 https://www.loc.gov/marc/up22bibliographic/bdapndxg.html

Sound Recording 007/03 n (new)
Sound Recording 007/10 n (new)
Sound Recording 007/01 r (new)
Sound Recording 007/01 s (new)

Update 23 https://www.loc.gov/marc/up23bibliographic/bdapndxg.html

Leader/18 n (new)
Music 008/20 p (new), b (renamed)

To test:
1) Apply the patch
2) Clean your browser cache
3) Go to cataloguing -> new record
4) Leader plugin: check leader/18, new option 'n'
5) 007 Plugin:
a) Sound recording
        check 007/01 new 'r'
        check 007/03 new 'n'
        check 007/10 new 'n'
b) Electronic resource
        check 007/01 new 's'
6) 008 Plugin: Music, check 008/20 renamed 'b', new 'p'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 16:57:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 14:57:01 +0000
Subject: [Koha-bugs] [Bug 20285] Lost item refund won't always pay down lost
 item fee first
In-Reply-To: <bug-20285-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20285-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20285-70-2DGEZ2bYis@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20285

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Caused by bug 14826? Is this bug present in 17.11?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 16:59:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 14:59:07 +0000
Subject: [Koha-bugs] [Bug 20285] Lost item refund won't always pay down lost
 item fee first
In-Reply-To: <bug-20285-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20285-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20285-70-G3nMHAv3qF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20285

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72122|0                           |1
        is obsolete|                            |
  Attachment #75936|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76060
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76060&action=edit
Bug 20285: Unit Test

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 16:59:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 14:59:11 +0000
Subject: [Koha-bugs] [Bug 20285] Lost item refund won't always pay down lost
 item fee first
In-Reply-To: <bug-20285-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20285-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20285-70-EcXkHXUeCv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20285

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76061
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76061&action=edit
Bug 20285: Lost item refund won't always pay down lost item fee first

Due to a simple typo, the accountline passed to Koha::Account::pay from
_FixAccountForLostAndReturned is not used. That means that the credit for the
lost item fee may be applied to other fees before it is used on the lost fee
itself.

Test Plan:
1) Find a patron with existing fines
2) Ensure your settings will charge patrons for lost items
3) Check out an item to a patron with existing fees that need paid
4) Mark the item lost, charging the lost item fee
5) Return the item
6) Note the fee was refunded, but it paid down earlier fines first,
   and not the lost item fee first
7) Apply this patch set
8) Repeat steps 1 - 5
9) Note the lost item fee is the first fee to be paid off by the lost
   item fee refund

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Followed the test plan and it works as expected.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 16:59:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 14:59:23 +0000
Subject: [Koha-bugs] [Bug 20700] Update MARC21 leader/007/008 codes
In-Reply-To: <bug-20700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20700-70-9W8aFmMx6n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20700

--- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Fridolin SOMERS from comment #7)
> Does not apply on 17.11..x because of
> koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/
> marc21_field_007.tt
> I'm not comfortable with MARC21 so can you provide a rebase ?

Master has Bug 19823 applied, that's the reason.
Don't know if this needs it's own Sign/QA etc.
This new patch implements the same changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 16:59:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 14:59:02 +0000
Subject: [Koha-bugs] [Bug 20285] Lost item refund won't always pay down lost
 item fee first
In-Reply-To: <bug-20285-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20285-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20285-70-NHmo57jqGL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20285

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 17:11:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 15:11:43 +0000
Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting
	with plack
In-Reply-To: <bug-15562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15562-70-Cu5SIJeeH7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562

Jerome Charaoui <jcharaoui at cmaisonneuve.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jcharaoui at cmaisonneuve.qc.c
                   |                            |a

--- Comment #70 from Jerome Charaoui <jcharaoui at cmaisonneuve.qc.ca> ---
I found this bug report after being mentioned on IRC, and as a sysadmin working
with Koha, I'm quite interested in this. At our public College, we like to
provide an autonomous Koha instance to every student so they can work on
assignments and expriment and learn the software. The instances are regularly
thrown away and recreated.

We can do it without Plack, but it's somewhat painful to use, even more so with
recent versions. We can have up to 120 instances available at any one time on a
single server!

I was able to apply the patchset on top of master with only very few
adjustments and make it work with 5 instances. But I only did very cursory
test, just making sure login works and the catalogue search was available. I
soon hit problems, though. For example, rebuild_zebra.pl throws a segfault.

While I understand that a following the path laid out with this patch through
to the end might seem like a huge task, I would be very happy to see this
patchset maintained and improved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 17:13:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 15:13:01 +0000
Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting
	with plack
In-Reply-To: <bug-15562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15562-70-AMnhHv0PAJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562

--- Comment #71 from Jerome Charaoui <jcharaoui at cmaisonneuve.qc.ca> ---
Created attachment 76062
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76062&action=edit
bug 15562: Roll-up and rebase

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 18:32:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 16:32:09 +0000
Subject: [Koha-bugs] [Bug 18805] Add ability to use up account credits
In-Reply-To: <bug-18805-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18805-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18805-70-1Gyj33zIby@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #10 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Right now, we are able to create credits (mancredit.pl) but there's no way to
'use' the existing credit against existing outstanding (debit) lines. This is
odd in the interface and worth working on.

I don't think this should be implemented as an automatic feature in the first
place. I would rather implement a way to assign remaining credits to specific
lines, and THEN add the option to do it automatically, maybe syspref-controlled
(better by payment type ;-))

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 18:38:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 16:38:08 +0000
Subject: [Koha-bugs] [Bug 20501] Unhighlight in search results when the
 search terms contain the same word twice removes the word
In-Reply-To: <bug-20501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20501-70-LZ2DGnFukW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20501

--- Comment #3 from Phil Ringnalda <phil.ccpl at gmail.com> ---
Still present in master. How about the example from bug 5844, which fixed the
copy of jquery.highlight-3.js in koha-tmpl/opac-tmpl/ but not the copy in
koha-tmpl/intranet-tmpl/, "mag ma m"? All that's actually needed is to patch
the intranet-tmpl copy the same way.

I don't quite see how an example can actually work, unless there's some
standard set of bib records everyone has that I haven't yet run across
documentation of, though. Before I realized why it only happens in the staff
client, I was drafting a set of steps to reproduce that were going to start
with "Create a bib record with the title A is for apple and another with the
title A my name is Anna" since reproducing requires only that you have a search
which in your database will return two or more records and will have matches in
things which are displayed in the staff client search results list.

"a a" is actually a pretty good example since as long as you have two (or more)
records in your database which contain the letter "a" in any indexed field, you
will have highlights that will show the letter being removed from the DOM in
the words "Material" and "Format" and "Literary" in the line "Material type:
Book Format: print Literary form: Not fiction" even if you don't have
highlights in the author or title. Might still fail for a non-English install,
but otherwise it seems like the most likely to work in any install with any bib
records.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 18:42:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 16:42:47 +0000
Subject: [Koha-bugs] [Bug 20937] PrintNoticesMaxLines is not effective for
 overdue notices with a print type specified where a patron has an email
In-Reply-To: <bug-20937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20937-70-rfkLSBRXsL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20937

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 18:53:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 16:53:43 +0000
Subject: [Koha-bugs] [Bug 14666] adds fixed_fines for overdues
In-Reply-To: <bug-14666-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14666-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14666-70-NUkvPMfRXR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43116|0                           |1
        is obsolete|                            |

--- Comment #9 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Created attachment 76063
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76063&action=edit
Bug 14666 - add fixed_fines for overdues

- Add a overduerules.fixed_fineX for the 3 levels
- Add a column "Fixed fines" in the tools/overduerules.pl page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 18:57:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 16:57:38 +0000
Subject: [Koha-bugs] [Bug 14666] adds fixed_fines for overdues
In-Reply-To: <bug-14666-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14666-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14666-70-lcSL109QMZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor.grousset at biblibre.co
                   |                            |m

--- Comment #10 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Rebased and compared the old and new patches to check that nothing was lost or
added.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 19:18:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 17:18:41 +0000
Subject: [Koha-bugs] [Bug 20946] New: Cannot pay fines for patrons with
	credits
Message-ID: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

            Bug ID: 20946
           Summary: Cannot pay fines for patrons with credits
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

To recreate:
1 - Add a $5 credit to a patron
2 - Add a $1 fine
3 - Try to pay all fines
4 - You will be told to enter a value less than or equal to -4.00
5 - Observe you cannot do that

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 19:18:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 17:18:53 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-QLhn4gh7tt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 19:33:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 17:33:09 +0000
Subject: [Koha-bugs] [Bug 20943] Cannot enable shibboleth and LDAP at the
	same time
In-Reply-To: <bug-20943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20943-70-6m33BwmZi2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20943

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 19:33:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 17:33:20 +0000
Subject: [Koha-bugs] [Bug 20945] Report params not escaped when downloading
In-Reply-To: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20945-70-V805gDOICI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 19:38:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 17:38:06 +0000
Subject: [Koha-bugs] [Bug 16804] Searching can be broken by search terms
 containing semicolons in XSLT
In-Reply-To: <bug-16804-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16804-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16804-70-vSKjkEZnW2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 19:38:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 17:38:09 +0000
Subject: [Koha-bugs] [Bug 16804] Searching can be broken by search terms
 containing semicolons in XSLT
In-Reply-To: <bug-16804-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16804-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16804-70-quzqskc8NW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70241|0                           |1
        is obsolete|                            |

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76064
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76064&action=edit
Bug 16804 - semicolons break series search in 490

To test:

* have OPACSuppression on
* have a record with a 490 field a la:

490 _a something ;
    _v 123

* go to the opac and search for this record
* click the Series link from the detail

Without this patch, there will be no results.

With this patch, you will get relevant results (possibly the same record back)

Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 19:54:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 17:54:55 +0000
Subject: [Koha-bugs] [Bug 16804] Searching can be broken by search terms
 containing semicolons in XSLT
In-Reply-To: <bug-16804-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16804-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16804-70-aWnAfHdHM1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 20:35:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 18:35:06 +0000
Subject: [Koha-bugs] [Bug 20947] New: Navigating to moremember.pl for a
 patron who has fines on deleted items causes software error.
Message-ID: <bug-20947-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20947

            Bug ID: 20947
           Summary: Navigating to  moremember.pl  for a patron who has
                    fines on deleted items causes software error.
 Change sponsored?: ---
           Product: Koha
           Version: 17.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Note this ONLY happens in 17.11 -- earlier versions of Koha don't have this
code, and GetMemberAccountRecords does not exist in 18.05+ (per bug 12001)...
however it is a major problem in 17.11.

--

Steps to re-create:

1) Find a borrower with fines, preferably on an item that has already been
checked in.
2) Delete the item
3) Navigate to moremember.pl for that borrower. This will trigger a software
error with

Can't call method "biblio" on an undefined value at
/usr/share/koha/lib/C4/Members.pm line 767.

in the plack-error.log

Here's the code:

 750 sub GetMemberAccountRecords {
 751     my ($borrowernumber) = @_;
 752     my $dbh = C4::Context->dbh;
 753     my @acctlines;
 754     my $numlines = 0;
 755     my $strsth      = qq(
 756                         SELECT *
 757                         FROM accountlines
 758                         WHERE borrowernumber=?);
 759     $strsth.=" ORDER BY accountlines_id desc";
 760     my $sth= $dbh->prepare( $strsth );
 761     $sth->execute( $borrowernumber );
 762 
 763     my $total = 0;
 764     while ( my $data = $sth->fetchrow_hashref ) {
 765         if ( $data->{itemnumber} ) {
 766             my $item = Koha::Items->find( $data->{itemnumber} );
 767             my $biblio = $item->biblio;

The problem is that $data->{itemnumber}, (the itemnumber read from
accountlines) may point to an active item or a deleted item. If the item was
deleted, $item, as populated in

   my $item = Koha::Items->find( $data->{itemnumber} );

will be undef, and 

   my $biblio = $item->biblio;

Will throw the error message.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 20:36:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 18:36:37 +0000
Subject: [Koha-bugs] [Bug 20912] Rental Fees based on Time Period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-PvtoD7dddV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 20:36:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 18:36:40 +0000
Subject: [Koha-bugs] [Bug 20912] Rental Fees based on Time Period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-YABBVMf2Z2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76065
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76065&action=edit
Bug 20912: Update database

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 20:36:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 18:36:48 +0000
Subject: [Koha-bugs] [Bug 20912] Rental Fees based on Time Period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-IkLcoBz5kH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76066
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76066&action=edit
Bug 20912: Rental Fees based on Time Period

Some libraries would like to be able to charge a rental fee based on the
number of days and item will be checked out, as opposed to the flat fee
currently offered by Koha.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Edit an itemtype, add a daily rental fee of 1.00
4) Check an item of that itemtype out for 7 days
5) Verify the patron now has rental fee of 7.00

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 20:36:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 18:36:50 +0000
Subject: [Koha-bugs] [Bug 20912] Rental Fees based on Time Period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-9VBfWULYHa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76067&action=edit
Bug 20912: Update schema file

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 20:51:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 18:51:57 +0000
Subject: [Koha-bugs] [Bug 20912] Rental Fees based on Time Period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-YKczL6uiCq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76066|0                           |1
        is obsolete|                            |
  Attachment #76067|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76068
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76068&action=edit
Bug 20912: Rental Fees based on Time Period

Some libraries would like to be able to charge a rental fee based on the
number of days and item will be checked out, as opposed to the flat fee
currently offered by Koha.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Edit an itemtype, add a daily rental fee of 1.00
4) Check an item of that itemtype out for 7 days
5) Verify the patron now has rental fee of 7.00

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 20:52:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 18:52:04 +0000
Subject: [Koha-bugs] [Bug 20912] Rental Fees based on Time Period
In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20912-70-C9CPJjHNZe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76069&action=edit
Bug 20912: Update schema file

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 21:16:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 19:16:11 +0000
Subject: [Koha-bugs] [Bug 18497] Downloading a report passes the constructed
 SQL as a parameter
In-Reply-To: <bug-18497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18497-70-scNtOqaSIg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18497

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20945


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945
[Bug 20945] Report params not escaped when downloading
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 21:16:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 19:16:11 +0000
Subject: [Koha-bugs] [Bug 20945] Report params not escaped when downloading
In-Reply-To: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20945-70-lHwmrwmrY0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Depends on|                            |18497


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18497
[Bug 18497] Downloading a report passes the constructed SQL as a parameter
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 21:17:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 19:17:25 +0000
Subject: [Koha-bugs] [Bug 20945] Report params not escaped when downloading
In-Reply-To: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20945-70-sAbbXt0TNY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_18_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 21:28:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 19:28:39 +0000
Subject: [Koha-bugs] [Bug 20947] Navigating to moremember.pl for a patron
 who has fines on deleted items causes software error.
In-Reply-To: <bug-20947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20947-70-dymd7mmVF6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20947

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I do not recreate, I noticed that accountlines.itemnumber is set to NULL when
the item is deleted.
Can you detail a bit more the steps to recreate?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 21:54:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 19:54:55 +0000
Subject: [Koha-bugs] [Bug 19970] Revise change of bug 19413 to work better
 for translations
In-Reply-To: <bug-19970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19970-70-iAQOCp7BlH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19970

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75935|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76070&action=edit
Bug 19970: Revise change of bug 19413 to work better for translations

This patch changes how the submit and cancel buttons appear in the MARC
008 plugin window. The controls are now displayed as buttons in a
floating toolbar.

To test you must have MARC tag 008 configured to use the
marc21_field_008.pl plugin.

- Apply the patch and open an existing or blank record in cataloging.
- Click the plugin link next to tag 008 to trigger the popup window.
- Confirm that "Save" and "Cancel" appear correctly in a toolbar.
- Scroll down the page to confirm that the toolbar "sticks" to the top
  of the window.
- Confirm that the "Save" and "Cancel" buttons work correctly.

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Followed the test plan and the patch works.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 21:54:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 19:54:48 +0000
Subject: [Koha-bugs] [Bug 19970] Revise change of bug 19413 to work better
 for translations
In-Reply-To: <bug-19970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19970-70-TrbDUHR4nJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19970

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 21:55:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 19:55:50 +0000
Subject: [Koha-bugs] [Bug 19970] Revise change of bug 19413 to work better
 for translations
In-Reply-To: <bug-19970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19970-70-ydpg6KgttY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19970

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I guess it would be useful to have the result floating as well (?)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 22:39:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 20:39:26 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
	requests
In-Reply-To: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20600-70-Du5GA6pk72@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

--- Comment #29 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Well, yes it works, but I do not think it is the way to do. I still think we
should use the standard title-string sort method. I am not going to consider it
as blocker anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 22:42:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 20:42:47 +0000
Subject: [Koha-bugs] [Bug 20561] Don't allow holds when all items are
	withdrawn
In-Reply-To: <bug-20561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20561-70-09IymEMGej@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20561

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 22:42:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 20:42:27 +0000
Subject: [Koha-bugs] [Bug 20561] Don't allow holds when all items are
	withdrawn
In-Reply-To: <bug-20561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20561-70-Dyrg6PophA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20561

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76071&action=edit
Bug 20561: Improve full supplier metadata display

This patch improves the display of the extra metadata that may be
returned by an ILL supplier.

The display of the metadata has been moved from the "Toggle full
supplier metadata" link at the bottom of the page to a button on the
right of the request toolbar, labelled "Display supplier metadata".
Clicking this button opens a modal displaying the metadata.

To test:
1) Ensure ILL is enabled and you have at least one request
2) From the "View ILL requests" page, click "Manage request" on a
request
3) Click the "Display supplier metadata" button on the right of the
toolbar
4) Observe that a modal opens containing the metadata

Signed-off-by: Magnus Enger <magnus at enger.priv.no>
The modal looks good!

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 22:42:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 20:42:58 +0000
Subject: [Koha-bugs] [Bug 20561] Don't allow holds when all items are
	withdrawn
In-Reply-To: <bug-20561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20561-70-ur98HSXxQw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20561

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76071|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 22:43:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 20:43:02 +0000
Subject: [Koha-bugs] [Bug 20651] Improve display of "Toggle full supplier
	metadata"
In-Reply-To: <bug-20651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20651-70-k0PpaP7eAR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20651

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 22:43:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 20:43:07 +0000
Subject: [Koha-bugs] [Bug 20651] Improve display of "Toggle full supplier
	metadata"
In-Reply-To: <bug-20651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20651-70-cxPMjk6BF8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20651

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75655|0                           |1
        is obsolete|                            |

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76072
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76072&action=edit
Bug 20561: Improve full supplier metadata display

This patch improves the display of the extra metadata that may be
returned by an ILL supplier.

The display of the metadata has been moved from the "Toggle full
supplier metadata" link at the bottom of the page to a button on the
right of the request toolbar, labelled "Display supplier metadata".
Clicking this button opens a modal displaying the metadata.

To test:
1) Ensure ILL is enabled and you have at least one request
2) From the "View ILL requests" page, click "Manage request" on a
request
3) Click the "Display supplier metadata" button on the right of the
toolbar
4) Observe that a modal opens containing the metadata

Signed-off-by: Magnus Enger <magnus at enger.priv.no>
The modal looks good!

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 22:43:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 20:43:46 +0000
Subject: [Koha-bugs] [Bug 20651] Improve display of "Toggle full supplier
	metadata"
In-Reply-To: <bug-20651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20651-70-Rii66eCvBJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20651

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76072|0                           |1
        is obsolete|                            |

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76073
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76073&action=edit
Bug 20651: Improve full supplier metadata display

This patch improves the display of the extra metadata that may be
returned by an ILL supplier.

The display of the metadata has been moved from the "Toggle full
supplier metadata" link at the bottom of the page to a button on the
right of the request toolbar, labelled "Display supplier metadata".
Clicking this button opens a modal displaying the metadata.

To test:
1) Ensure ILL is enabled and you have at least one request
2) From the "View ILL requests" page, click "Manage request" on a
request
3) Click the "Display supplier metadata" button on the right of the
toolbar
4) Observe that a modal opens containing the metadata

Signed-off-by: Magnus Enger <magnus at enger.priv.no>
The modal looks good!

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 23:03:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 21:03:04 +0000
Subject: [Koha-bugs] [Bug 20948] New: Hold requests on detail.pl
Message-ID: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948

            Bug ID: 20948
           Summary: Hold requests on detail.pl
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

The next hold request showing on the detail.pl page next to items is useless
and should be removed or fixed.  The information for requests on an item is
misleading.  It shows the next item level hold rather than showing the next
hold it will fulfill.  I understand how this might be useful in some obscure
circumstances, but for the most part it leads staff to believe that this is the
next hold it will fill, and that is not the case.  

Case in point...we have a new item, only one in the collection.  33 next
available holds, and 1 item level hold at the very end of the list, going to a
different library.  With all the other holds ahead of it, and the fact that we
have local holds priority enabled, this looks very wrong, and leads staff to
confusion and panic.  

It might be helpful to some libraries to see that there is a specific hold on a
particular item, but around here, most libraries will view this as misleading. 
There should be a setting to change the behavior, or turn it off.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 23:06:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 21:06:30 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-XSNWDzWtwZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 23:06:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 21:06:39 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-w2CDtzpfs8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75900|0                           |1
        is obsolete|                            |
  Attachment #75901|0                           |1
        is obsolete|                            |
  Attachment #75902|0                           |1
        is obsolete|                            |
  Attachment #75903|0                           |1
        is obsolete|                            |
  Attachment #75904|0                           |1
        is obsolete|                            |
  Attachment #75905|0                           |1
        is obsolete|                            |
  Attachment #75906|0                           |1
        is obsolete|                            |
  Attachment #75907|0                           |1
        is obsolete|                            |

--- Comment #126 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76074&action=edit
Bug 12395: Save order line's creator

New MySQL column: aqorders.createdby

Creator's name is displayed on order's receive pages (acqui/orderreceive.pl
and acqui/parcel.pl)

On acqui/orderreceive.pl it replace the name of basket's creator
On acqui/parcel.pl, to avoid adding more data in the table of pending
orders, it is shown in a popup like MARC and Card views

Test plan:
1/ Run updatedatabase.pl
2/ Create a new order and go to the receipt page (acqui/parcel.pl)
3/ Click on "Order" link in column "More" (previously "View record")
4/ A javascript popup should appear with your name in it. Close the
popup.
5/ Click on "Receive" link
6/ Your name should appear in front of "Created by" label, to the right
of the page.

Patch updated with use of atomic update.

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 23:06:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 21:06:46 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-Trr7AhgFc5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #127 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76075&action=edit
Bug 12395: Add unit test to check created_by is correctly set

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>
Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 23:06:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 21:06:52 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-oPWlxbmSuD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #128 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76076&action=edit
Bug 12395: Display created_by even if firstname is missing on receiving

On receiving orders, "no name" was displayed if the firstname of creator
was not filled.
The surname should be displayed.

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>
Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 23:06:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 21:06:59 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-HO61BSKMm9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #129 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76077&action=edit
Bug 12395: Make received orders table consistent with pending orders table

(links of More column)

Also change "Created by" with "Ordered by" in receive page.

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 23:07:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 21:07:06 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-J7ae4Z20oN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #130 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76078&action=edit
Bug 12395: (QA follow-up) Add class/id to body tag

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 23:07:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 21:07:16 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-BDUSAbrm7h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #131 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76079&action=edit
Bug 12395: Use standard <fieldset> + <ol> markup for showorder.tt

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 23:07:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 21:07:25 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-jzooXlGzlw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #132 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76080&action=edit
Bug 12395: (QA follow-up) Change wording for consistency and fix use CGI;

Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 23:07:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 21:07:33 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-cnYaDbUB5S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #133 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76081&action=edit
Bug 12395: Add FK constraint and use patron-title.inc

Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 23:10:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 21:10:01 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-7KIi1gr4tE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #134 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Julian Maurice from comment #125)
> (In reply to Jonathan Druart from comment #124)
> > (In reply to Jonathan Druart from comment #113)
> > >   Bug 12395: Save order line's creator
> > > reverts bug 20303
> > 
> > This one is still missing I think.
> 
> These changes are intended. orderreceive.pl doesn't use
> aqbaskets.authorisedby anymore (with those patches applied)

Indeed! I have tested to delete the account of the creator and receive an order
and it seems ok.

The screen displays "Ordered by: " and nothing in front. Maybe we could add
something to explain why it's empty.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 23:10:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 21:10:45 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-Qu34x190Nr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #135 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Forgot the signed-off-by line, reattaching...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 23:11:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 21:11:15 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-T2VenvPOur@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76074|0                           |1
        is obsolete|                            |
  Attachment #76075|0                           |1
        is obsolete|                            |
  Attachment #76076|0                           |1
        is obsolete|                            |
  Attachment #76077|0                           |1
        is obsolete|                            |
  Attachment #76078|0                           |1
        is obsolete|                            |
  Attachment #76079|0                           |1
        is obsolete|                            |
  Attachment #76080|0                           |1
        is obsolete|                            |
  Attachment #76081|0                           |1
        is obsolete|                            |

--- Comment #136 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76082&action=edit
Bug 12395: Save order line's creator

New MySQL column: aqorders.createdby

Creator's name is displayed on order's receive pages (acqui/orderreceive.pl
and acqui/parcel.pl)

On acqui/orderreceive.pl it replace the name of basket's creator
On acqui/parcel.pl, to avoid adding more data in the table of pending
orders, it is shown in a popup like MARC and Card views

Test plan:
1/ Run updatedatabase.pl
2/ Create a new order and go to the receipt page (acqui/parcel.pl)
3/ Click on "Order" link in column "More" (previously "View record")
4/ A javascript popup should appear with your name in it. Close the
popup.
5/ Click on "Receive" link
6/ Your name should appear in front of "Created by" label, to the right
of the page.

Patch updated with use of atomic update.

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 23:11:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 21:11:23 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-vVgMsqwWEw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #137 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76083&action=edit
Bug 12395: Add unit test to check created_by is correctly set

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>
Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 23:11:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 21:11:28 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-8sYArs421j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #138 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76084&action=edit
Bug 12395: Display created_by even if firstname is missing on receiving

On receiving orders, "no name" was displayed if the firstname of creator
was not filled.
The surname should be displayed.

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>
Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 23:11:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 21:11:36 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-uAh3IKC07t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #139 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76085&action=edit
Bug 12395: Make received orders table consistent with pending orders table

(links of More column)

Also change "Created by" with "Ordered by" in receive page.

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 23:11:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 21:11:43 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-a25aPiNdBf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #140 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76086&action=edit
Bug 12395: (QA follow-up) Add class/id to body tag

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 23:11:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 21:11:50 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-iT5dLVN5ir@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #141 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76087&action=edit
Bug 12395: Use standard <fieldset> + <ol> markup for showorder.tt

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 23:11:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 21:11:56 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-uuQwOEvigM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #142 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76088&action=edit
Bug 12395: (QA follow-up) Change wording for consistency and fix use CGI;

Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 23:12:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 21:12:03 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-lZs23wFfve@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #143 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76089&action=edit
Bug 12395: Add FK constraint and use patron-title.inc

Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 23:17:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 21:17:21 +0000
Subject: [Koha-bugs] [Bug 20948] Hold requests on detail.pl
In-Reply-To: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20948-70-aM8RayZNz3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 23:20:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 21:20:16 +0000
Subject: [Koha-bugs] [Bug 15219] Server-side processing and pagination on
 checkouts tables
In-Reply-To: <bug-15219-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15219-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15219-70-7zulWYaHnK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219

--- Comment #32 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Tiny ergonomic issue when the export column is displayed:
https://screenshots.firefox.com/0gdGrGVyEBanCz8n/pro.kohadev.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 23:22:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 21:22:31 +0000
Subject: [Koha-bugs] [Bug 15219] Server-side processing and pagination on
 checkouts tables
In-Reply-To: <bug-15219-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15219-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15219-70-rpzQhsFysg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219

--- Comment #33 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #32)
> Tiny ergonomic issue when the export column is displayed:
> https://screenshots.firefox.com/0gdGrGVyEBanCz8n/pro.kohadev.org

Hum, the export column should not be displayed actually, ExportCircHistory is
off. But it is in the "column visibility" list

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 23:24:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 21:24:30 +0000
Subject: [Koha-bugs] [Bug 15219] Server-side processing and pagination on
 checkouts tables
In-Reply-To: <bug-15219-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15219-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15219-70-xyKs29dI0F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219

--- Comment #34 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
"Select all" only select visible rows. If it is expected it is confusing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 14 23:29:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jun 2018 21:29:23 +0000
Subject: [Koha-bugs] [Bug 15219] Server-side processing and pagination on
 checkouts tables
In-Reply-To: <bug-15219-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15219-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15219-70-GjFyqXts5y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 07:06:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 05:06:03 +0000
Subject: [Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to
	Koha::Patron
In-Reply-To: <bug-19936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19936-70-XOr8ZtZIms@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |liz at catalyst.net.nz

--- Comment #87 from Liz Rea <liz at catalyst.net.nz> ---
Since this patch trying to import patrons seems to be noisy, lots of

Argument "" isn't numeric in numeric eq (==) at
/usr/share/perl5/DBIx/Class/Row.pm line 1017, <$handle> line 512.

example line that has this problem, with header, private stuff removed:
cardnumber,firstname,surname,address,address2,city,zipcode,email,phone,B_phone,branchcode,patron_attributes,borrowernotes,categorycode
100000090,"borrower surname",firstname,"Po Box xxxxx","
City",,,firstname.surname at institution.co.nz,,123456,BRANCHCODE,GROUP:STAFF,,STAFF

It doesn't seem to affect the performance, patrons still get imported, but it
sure does fill up the logs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 07:48:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 05:48:28 +0000
Subject: [Koha-bugs] [Bug 20945] Report params not escaped when downloading
In-Reply-To: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20945-70-KiJXL7msLE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 10:01:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 08:01:16 +0000
Subject: [Koha-bugs] [Bug 20919] A Zebra query is done for each item when
 opening a record detail page
In-Reply-To: <bug-20919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20919-70-OtwMkJpkB7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20919

Hugo Agud <hagud at orex.es> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76057|0                           |1
        is obsolete|                            |

--- Comment #2 from Hugo Agud <hagud at orex.es> ---
Created attachment 76090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76090&action=edit
Bug 20919: Remove unecessary search calls on the biblio detail page

There is a countanalytics flag that is set for items used in analytical
biblio records. This flag is only used in the template when 'analyze'
has been passed to the script.
In order to avoid unecessary search calls (1 per item), $analyse must be
tested.

Test plan:
0. Do not apply the patch
1. tail -f /var/log/koha/kohadev/zebra-output.log
2. Hit a bibliographic record detail page with several items
3. Notice that the log has 1 line per item:
  11:30:36-14/06 zebrasrv(32) [warn] ir_session (exception)
4. Apply the patch
5. Hit the page again
6. There is nothing in the zebra log file

If you are familiar with analytic records, confirm that you are not
allowed to remove an item that is used in analytical biblio records.

Signed-off-by: Hugo Agud <hagud at orex.es>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 10:01:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 08:01:12 +0000
Subject: [Koha-bugs] [Bug 20919] A Zebra query is done for each item when
 opening a record detail page
In-Reply-To: <bug-20919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20919-70-YwY1y7QNlt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20919

Hugo Agud <hagud at orex.es> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 10:14:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 08:14:58 +0000
Subject: [Koha-bugs] [Bug 20522] Fields with only one $9 subfield are removed
In-Reply-To: <bug-20522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20522-70-P9wdUaG51u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20522

Aur?lie <aurelie.berut at enssib.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aurelie.berut at enssib.fr

--- Comment #7 from Aur?lie <aurelie.berut at enssib.fr> ---
The French Bibliographic Agency (Abes) advocates that the use of $8 is not
recommended. If a temporary sub-field for these data must be choosen, the best
is to choose a letter, as the use of letters in UNM is free - contrary to the
numbers sub-fields. It could be $y.

Context : Earlier this year, the PUC made this subfield $8 a generic to all
fields of the Unimarc B format. Its meaning is very precise: "Part of the
resource concerned by the data recorded in the field" ("Reserved for Materials
specified"); it is in practice especially applicable to certain descriptive
fields even if it may be also used for identifiers.

Do you agree with $y ?

Enssib Team

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 11:21:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 09:21:26 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-nbUgNAUFzM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #78 from Alex Arnaud <alex.arnaud at biblibre.com> ---
(In reply to Koha Team Lyon 3 from comment #77)
> Hello Alex
> 
> I tested again but I don't see any change about what Joseph Moravec told
> about nor about jumping checkboxes.
> 
> Am I missing something ?
> 
> Olivier

Hello Olivier,

The problem Joseph talked about as i understood it is that clicking a permanent
irregularity does not check all the correponding irregularities. It checks only
the first one in fact. 

My last fix works well for me but maybe i still missunderstand anything.
Joseph, can you confirm ?

For the "jumping checkboxes", i did not manage to reproduce it. Can you remind
me where and how it happens ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 11:39:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 09:39:37 +0000
Subject: [Koha-bugs] [Bug 20522] Fields with only one $9 subfield are removed
In-Reply-To: <bug-20522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20522-70-lO2l4Vr05n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20522

--- Comment #8 from Fr?d?ric Demians <frederic at tamil.fr> ---
I'm not in favor of this solution. The issue must be solved at its root rather
than fixed afterward.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 11:46:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 09:46:15 +0000
Subject: [Koha-bugs] [Bug 20920] Plack timeout because of missing
 CGI::Compile Perl dependency
In-Reply-To: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20920-70-ZZh5puWMAn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--- Comment #3 from Mirko Tietgen <mirko at abunchofthings.net> ---
libcgi-compile-perl is 'recommended' by libplack-perl, which gets it installed
on most systems. Apparently koha depends on it. Not sure why it is only
recommended by libplack-perl, but that's a different story.

The control file is not supposed to be patched, as stated in the file itself.

> # Do not manually edit "control"

CGI::Compile needs to be added to PerlDependencies.pm.
I will take care of updating the control file afterwards.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 11:47:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 09:47:05 +0000
Subject: [Koha-bugs] [Bug 20920] Plack timeout because of missing
 CGI::Compile Perl dependency
In-Reply-To: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20920-70-paFPdAtoQy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76000|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 11:49:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 09:49:18 +0000
Subject: [Koha-bugs] [Bug 20920] Plack timeout because of missing
 CGI::Compile Perl dependency
In-Reply-To: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20920-70-gvGAGNIKvc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 11:49:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 09:49:26 +0000
Subject: [Koha-bugs] [Bug 20920] Plack timeout because of missing
 CGI::Compile Perl dependency
In-Reply-To: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20920-70-fRxfZMyCHk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 11:52:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 09:52:05 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates
	(oldstable/17.11.x)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-uUPJKgJ1Ez@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Automatic debian/control    |Automatic debian/control
                   |updates (oldstable/17.05.x) |updates (oldstable/17.11.x)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 11:52:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 09:52:51 +0000
Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates
	(stable/18.05.x)
In-Reply-To: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17108-70-f5yhHdHTUY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|nick at bywatersolutions.com   |martin.renvoize at ptfs-europe
                   |                            |.com
            Summary|Automatic debian/control    |Automatic debian/control
                   |updates (stable)            |updates (stable/18.05.x)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 12:04:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 10:04:32 +0000
Subject: [Koha-bugs] [Bug 20949] New: Koha depends on Clone
Message-ID: <bug-20949-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20949

            Bug ID: 20949
           Summary: Koha depends on Clone
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mirko at abunchofthings.net
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net

The ILL and SIP modules uses Clone. So far, libclone-perl was a dependency of a
dependency, libhash-merge-perl. In Debian Buster and Ubuntu Bionic,
libhash-merge-perl depends on libclone-choose-perl instead. Same problem for
the plain Perl modules from CPAN. I file it under packaging anyway, I have to
fix one to fix the other.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 12:05:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 10:05:03 +0000
Subject: [Koha-bugs] [Bug 20949] Koha depends on Clone
In-Reply-To: <bug-20949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20949-70-FSAZ2t87Us@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20949

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
           Assignee|koha-bugs at lists.koha-commun |mirko at abunchofthings.net
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 12:05:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 10:05:36 +0000
Subject: [Koha-bugs] [Bug 18850] Clone as dependency?
In-Reply-To: <bug-18850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18850-70-ZyhbLHil8G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18850

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
                 CC|                            |mirko at abunchofthings.net
             Status|NEW                         |RESOLVED

--- Comment #1 from Mirko Tietgen <mirko at abunchofthings.net> ---


*** This bug has been marked as a duplicate of bug 20949 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 12:05:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 10:05:36 +0000
Subject: [Koha-bugs] [Bug 20949] Koha depends on Clone
In-Reply-To: <bug-20949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20949-70-HZuc1yR2C8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20949

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #1 from Mirko Tietgen <mirko at abunchofthings.net> ---
*** Bug 18850 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 12:20:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 10:20:08 +0000
Subject: [Koha-bugs] [Bug 19990] opac/opac-discharge.pl has a FIXME that can
	be fixed
In-Reply-To: <bug-19990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19990-70-0aUweXsg6s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #4 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
I see $available means discharge is validated by a librarian in staff
interface, different from $pending.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 12:37:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 10:37:17 +0000
Subject: [Koha-bugs] [Bug 20949] Koha depends on Clone
In-Reply-To: <bug-20949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20949-70-dQf7svgk64@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20949

--- Comment #2 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 76091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76091&action=edit
Bug 20949: Koha depends on Clone

Clone was not declared a dependency before. It used to be a dependency
of Hash::Merge but isn't in the recent version.

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 12:37:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 10:37:32 +0000
Subject: [Koha-bugs] [Bug 20949] Koha depends on Clone
In-Reply-To: <bug-20949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20949-70-SpBmbCKpqr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20949

--- Comment #3 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 76092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76092&action=edit
Bug 20949: Followup: debian/control

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 12:38:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 10:38:53 +0000
Subject: [Koha-bugs] [Bug 20949] Koha depends on Clone
In-Reply-To: <bug-20949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20949-70-abDwHjcnm1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20949

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #4 from Mirko Tietgen <mirko at abunchofthings.net> ---
Nothing to test really. Check patch 1 if it makes sense, see effect for
packaging in patch 2.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 12:44:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 10:44:05 +0000
Subject: [Koha-bugs] [Bug 19970] Revise change of bug 19413 to work better
 for translations
In-Reply-To: <bug-19970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19970-70-INGuHhpfPo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19970

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 12:44:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 10:44:16 +0000
Subject: [Koha-bugs] [Bug 20285] Lost item refund won't always pay down lost
 item fee first
In-Reply-To: <bug-20285-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20285-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20285-70-fWzb8lBw31@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20285

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 12:44:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 10:44:27 +0000
Subject: [Koha-bugs] [Bug 20760] Advanced Cataloging Editor - Rancor -
 AuthorisedValues are incorrectly fetched
In-Reply-To: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20760-70-BnqK7McnwJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20760

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #14 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 12:44:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 10:44:35 +0000
Subject: [Koha-bugs] [Bug 20911] Search history page forms use 'GET' and
 this limits the number of entries that can be submitted
In-Reply-To: <bug-20911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20911-70-gBFMMsL0YF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20911

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 12:44:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 10:44:43 +0000
Subject: [Koha-bugs] [Bug 20892] Wrong basketgroup link in histsearch.pl
In-Reply-To: <bug-20892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20892-70-lE8wDNCgOO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20892

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 12:45:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 10:45:05 +0000
Subject: [Koha-bugs] [Bug 20899] Patron name not showing on issuehistory.pl
In-Reply-To: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20899-70-j5FMLzKDBb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 12:45:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 10:45:15 +0000
Subject: [Koha-bugs] [Bug 20918] left-side navigation broken on the checkout
	history page
In-Reply-To: <bug-20918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20918-70-jDwXQe3rBY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20918

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 12:45:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 10:45:29 +0000
Subject: [Koha-bugs] [Bug 20922] Koha::Number::Price must not be used in
 updatedatabase.pl
In-Reply-To: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20922-70-yJCyxijVis@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 12:45:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 10:45:36 +0000
Subject: [Koha-bugs] [Bug 20832] Opac user page crash when there is an
 overdue fine and not any rental charge for a patron
In-Reply-To: <bug-20832-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20832-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20832-70-eTIuOFDm2Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20832

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 12:47:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 10:47:40 +0000
Subject: [Koha-bugs] [Bug 19990] opac/opac-discharge.pl has a FIXME that can
	be fixed
In-Reply-To: <bug-19990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19990-70-B6ybKh9Upt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990

--- Comment #5 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Fridolin SOMERS from comment #4)
> I see $available means discharge is validated by a librarian in staff
> interface, different from $pending.

Oh I think I get it now :

FIXME means 'available' template param could directly be
Koha::Patron::Discharge::is_discharged({borrowernumber => $loggedinuser}).
Because Koha::Patron::Discharge::is_discharged() looks if discharge is
validated.

Is it correct ?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 12:55:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 10:55:56 +0000
Subject: [Koha-bugs] [Bug 20950] New: Plugins: Handler.pm doesn't fail
 gracefully when running plugin
Message-ID: <bug-20950-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20950

            Bug ID: 20950
           Summary: Plugins: Handler.pm doesn't fail gracefully when
                    running plugin
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew.isherwood at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

When running a plugin that fails for some internal reason, the user doesn't
always receive a very helpful message. With the Kitchen Sink plugin (
https://github.com/bywatersolutions/koha-plugin-kitchen-sink ) I managed to
break it by trying to import C4::Members::GetMember - which doesn't exist any
more.

Running the plugin in this broken state resulted in:

run.pl: Plugin Koha::Plugin::Com::ByWaterSolutions::KitchenSink cannot be
loaded at /usr/share/koha/Koha/Plugins/Handler.pm line 72.:
/usr/share/koha/plugins/run.pl

It turns out that Koha::Plugins::Handler::run calls
Module::Load::Conditional::can_load, which was returning false, which caused
the message I saw to be output. However, Module::Load::Conditional sets a
global variable upon can_load returning false containing the reason. We should
display this (assuming we don't consider it to be a security risk).

So, in Handler.pm, we'd need to substitute in:

if ( can_load( modules => { $plugin_class => undef } ) ) {
    my $plugin = $plugin_class->new( { cgi => $cgi, enable_plugins =>
$args->{'enable_plugins'} } );
    if ( $plugin->can($plugin_method) ) {
        return $plugin->$plugin_method( $params );
    } else {
        warn "Plugin does not have method $plugin_method";
    }
} else {
    warn "Plugin $plugin_class cannot be loaded: " .
$Module::Load::Conditional::ERROR;
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 12:56:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 10:56:09 +0000
Subject: [Koha-bugs] [Bug 20951] New: Koha::Patron::Discharge is missing use
 Koha::Patron::Debarments
Message-ID: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951

            Bug ID: 20951
           Summary: Koha::Patron::Discharge is missing use
                    Koha::Patron::Debarments
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Koha::Patron::Discharge is missing use Koha::Patron::Debarments used in
discharge() method.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 12:56:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 10:56:43 +0000
Subject: [Koha-bugs] [Bug 20950] Plugins: Handler.pm doesn't fail gracefully
 when running plugin
In-Reply-To: <bug-20950-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20950-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20950-70-A6lM0gEf0y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20950

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 13:03:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 11:03:50 +0000
Subject: [Koha-bugs] [Bug 20951] Koha::Patron::Discharge is missing use
 Koha::Patron::Debarments
In-Reply-To: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20951-70-j4O0ZTaQfK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 13:03:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 11:03:53 +0000
Subject: [Koha-bugs] [Bug 20951] Koha::Patron::Discharge is missing use
 Koha::Patron::Debarments
In-Reply-To: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20951-70-VIYWigAhEN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951

--- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 76093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76093&action=edit
Bug 20951: add missing use Koha::Patron::Debarments in Koha::Patron::Discharge

Koha::Patron::Discharge was missing use Koha::Patron::Debarments used in
discharge() method.

Test plan :
1) Enable pref useDischarge
2) Go to OPAC user page
3) Go to 'ask for a discharge' tab
4) Click on 'Ask for a discharge'
5) Go to staff interface : /cgi-bin/koha/members/discharges.pl
6) Click on Allow
=> Without patch you get software error
=> With patch the discharge is validated

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 13:05:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 11:05:17 +0000
Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates
	(stable/18.05.x)
In-Reply-To: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17108-70-KA5kNTBw1v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70825|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 13:08:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 11:08:40 +0000
Subject: [Koha-bugs] [Bug 20951] Koha::Patron::Discharge is missing use
 Koha::Patron::Debarments
In-Reply-To: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20951-70-ZV7GAngdc2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |15548


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548
[Bug 15548] New patron related code should have been put to Patron instead of
Borrower
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 13:08:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 11:08:40 +0000
Subject: [Koha-bugs] [Bug 15548] New patron related code should have been
 put to Patron instead of Borrower
In-Reply-To: <bug-15548-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15548-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15548-70-c2fSqWeiGO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20951


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951
[Bug 20951] Koha::Patron::Discharge is missing use Koha::Patron::Debarments
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 13:27:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 11:27:33 +0000
Subject: [Koha-bugs] [Bug 20951] Koha::Patron::Discharge is missing use
 Koha::Patron::Debarments
In-Reply-To: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20951-70-vHiUXDG3Mu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 13:34:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 11:34:20 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates
	(oldstable/17.11.x)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-yTBc6G0Krs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

--- Comment #41 from Nightly Build Bot <nightly at abunchofthings.net> ---
Created attachment 76094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76094&action=edit
Bug 17111 - Automatic debian/control updates (oldstable/17.11.x)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 13:47:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 11:47:08 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates
	(oldstable/17.11.x)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-UJJWKLox7j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|17.05                       |17.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 13:49:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 11:49:34 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates
	(oldstable/17.11.x)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-XWH4KLsGSw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76094|0                           |1
        is obsolete|                            |

--- Comment #42 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 76095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76095&action=edit
Bug 17111 - Automatic debian/control updates (oldstable/17.11.x)

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 13:49:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 11:49:58 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates
	(oldstable/17.11.x)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-3RRL2tJ4n1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 13:50:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 11:50:10 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates
	(oldstable/17.11.x)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-r7rUNjShmG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 13:50:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 11:50:41 +0000
Subject: [Koha-bugs] [Bug 20832] Opac user page crash when there is an
 overdue fine and not any rental charge for a patron
In-Reply-To: <bug-20832-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20832-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20832-70-5z9lVSQO0d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20832

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable
           Keywords|rel_18_05_candidate         |

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.05.x for 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 13:50:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 11:50:43 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates
	(oldstable/17.11.x)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-H5cBfDiOlO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 13:52:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 11:52:18 +0000
Subject: [Koha-bugs] [Bug 20922] Koha::Number::Price must not be used in
 updatedatabase.pl
In-Reply-To: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20922-70-P4RZI88bEv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.05.x for 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 13:54:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 11:54:11 +0000
Subject: [Koha-bugs] [Bug 20918] left-side navigation broken on the checkout
	history page
In-Reply-To: <bug-20918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20918-70-sElxfzDVKy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20918

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.05.x for 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 13:54:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 11:54:21 +0000
Subject: [Koha-bugs] [Bug 20918] left-side navigation broken on the checkout
	history page
In-Reply-To: <bug-20918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20918-70-Gb3Jc5nRao@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20918

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_18_05_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 14:06:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 12:06:20 +0000
Subject: [Koha-bugs] [Bug 20899] Patron name not showing on issuehistory.pl
In-Reply-To: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20899-70-2RgUJnE4hL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_18_05_candidate         |
             Status|Pushed to Master            |Pushed to Stable

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.05.x for 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 14:07:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 12:07:10 +0000
Subject: [Koha-bugs] [Bug 20952] New: Automatic debian/control updates
 (oldoldstable/17.05.x)
Message-ID: <bug-20952-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20952

            Bug ID: 20952
           Summary: Automatic debian/control updates
                    (oldoldstable/17.05.x)
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mirko at abunchofthings.net
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net

Automatic updates for debian/control in 17.05.x

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 14:07:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 12:07:37 +0000
Subject: [Koha-bugs] [Bug 20892] Wrong basketgroup link in histsearch.pl
In-Reply-To: <bug-20892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20892-70-DiNAhICvPu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20892

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.05.x for 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 14:08:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 12:08:19 +0000
Subject: [Koha-bugs] [Bug 20952] Automatic debian/control updates
	(oldoldstable/17.05.x)
In-Reply-To: <bug-20952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20952-70-E0q3Os3fKD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20952

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17111,
                   |                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17108,
                   |                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17084
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 14:08:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 12:08:19 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates
	(oldstable/17.11.x)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-hV9b5HZTlo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20952

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 14:08:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 12:08:19 +0000
Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates
	(stable/18.05.x)
In-Reply-To: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17108-70-Jbbqi3FwaD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20952

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 14:08:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 12:08:19 +0000
Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master)
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-SMtR8lE2s3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20952

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 14:09:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 12:09:01 +0000
Subject: [Koha-bugs] [Bug 20952] Automatic debian/control updates
	(oldoldstable/17.05.x)
In-Reply-To: <bug-20952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20952-70-dKVEn5PXJX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20952

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |mirko at abunchofthings.net
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 14:09:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 12:09:16 +0000
Subject: [Koha-bugs] [Bug 20911] Search history page forms use 'GET' and
 this limits the number of entries that can be submitted
In-Reply-To: <bug-20911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20911-70-TJQfKr1pdv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20911

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.05.x for 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 14:10:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 12:10:20 +0000
Subject: [Koha-bugs] [Bug 20760] Advanced Cataloging Editor - Rancor -
 AuthorisedValues are incorrectly fetched
In-Reply-To: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20760-70-asuVlxnUcL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20760

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.05.x for 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 14:12:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 12:12:00 +0000
Subject: [Koha-bugs] [Bug 19970] Revise change of bug 19413 to work better
 for translations
In-Reply-To: <bug-19970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19970-70-TzByVwmuja@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19970

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.05.x for 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 14:13:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 12:13:49 +0000
Subject: [Koha-bugs] [Bug 20285] Lost item refund won't always pay down lost
 item fee first
In-Reply-To: <bug-20285-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20285-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20285-70-CZmqGIiFO3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20285

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.05.x for 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 14:26:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 12:26:07 +0000
Subject: [Koha-bugs] [Bug 20952] Automatic debian/control updates
	(oldoldstable/17.05.x)
In-Reply-To: <bug-20952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20952-70-JOpFJFaTHp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20952

--- Comment #1 from Nightly Build Bot <nightly at abunchofthings.net> ---
Created attachment 76096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76096&action=edit
Bug 20861: Correct EDI permissions on EDI messsages

The permission for EDI is edi_manage, but 2 pages asked
for manage_edi, allowing users not to access those.

To test:
- Add edi_manage to your permissions
- Try to access the EDIFACT messages from the
  acq start page
- Verify it doesn't work
- Apply patch and try again
- You should be able to access the page now
- Try to access the other page directly (if you don't
  have EDI data):
  /cgi-bin/koha/acqui/edimsg.pl
- Verify you can access the page and don't get a
  permission error

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 7883b19de5f24551b36bf29133b04bc71ad4d56a)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit cbeed6cf3db342e025b4d837ab135136d39a140e)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 14:38:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 12:38:10 +0000
Subject: [Koha-bugs] [Bug 20952] Automatic debian/control updates
	(oldoldstable/17.05.x)
In-Reply-To: <bug-20952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20952-70-PxwOY8C0G0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20952

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |In Discussion

--- Comment #2 from Mirko Tietgen <mirko at abunchofthings.net> ---
Erm. That did not work. ^^

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 14:39:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 12:39:13 +0000
Subject: [Koha-bugs] [Bug 20952] Automatic debian/control updates
	(oldoldstable/17.05.x)
In-Reply-To: <bug-20952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20952-70-JiHbh0Cbfy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20952

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76096|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 14:39:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 12:39:23 +0000
Subject: [Koha-bugs] [Bug 20953] New: Discharge can be requested several
	times on OPAC
Message-ID: <bug-20953-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953

            Bug ID: 20953
           Summary: Discharge can be requested several times on OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

On OPAC, a user can requested a discharge even if one is already pending.
This generates several pending discharges in staff interface that can not be
deleted.

This is because request operation leads to page 'opac-discharge.pl?op=request'
and user can refresh this page performing a new request.

Perl code must check that operation is allowed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 14:39:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 12:39:30 +0000
Subject: [Koha-bugs] [Bug 20953] Discharge can be requested several times on
	OPAC
In-Reply-To: <bug-20953-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20953-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20953-70-mpTglRM8dR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|oleonard at myacpl.org         |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 14:39:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 12:39:50 +0000
Subject: [Koha-bugs] [Bug 20953] Discharge can be requested several times on
	OPAC
In-Reply-To: <bug-20953-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20953-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20953-70-Lw1OPVav6c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20951


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951
[Bug 20951] Koha::Patron::Discharge is missing use Koha::Patron::Debarments
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 14:39:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 12:39:50 +0000
Subject: [Koha-bugs] [Bug 20951] Koha::Patron::Discharge is missing use
 Koha::Patron::Debarments
In-Reply-To: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20951-70-1kKM4oUVMx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20953


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953
[Bug 20953] Discharge can be requested several times on OPAC
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 14:40:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 12:40:14 +0000
Subject: [Koha-bugs] [Bug 20953] Discharge can be requested several times on
	OPAC
In-Reply-To: <bug-20953-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20953-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20953-70-XnowGSkc66@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953

--- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Can not be tested without Bug 20951

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 14:40:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 12:40:32 +0000
Subject: [Koha-bugs] [Bug 19990] opac/opac-discharge.pl has a FIXME that can
	be fixed
In-Reply-To: <bug-19990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19990-70-TKBYoAOWSO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20953

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 14:40:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 12:40:32 +0000
Subject: [Koha-bugs] [Bug 20953] Discharge can be requested several times on
	OPAC
In-Reply-To: <bug-20953-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20953-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20953-70-iUdsJjI6mu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19990

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 14:59:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 12:59:43 +0000
Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface
In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20935-70-2Wx47Fe5c9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 14:59:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 12:59:45 +0000
Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface
In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20935-70-jEBuz7q2P3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76097&action=edit
Bug 20935: Redesign system preferences interface

This patch proposes a new interface for system preferences. The goal is
to make the interface more readable and to give the user additional
options for finding what they need.

- Restructures the preferences list as a <dl>, with the preference name
  as the <dt> and the description as the <dd>.
- Add a JS filter library (mark.js) to do live filtering of the page and
  add search term highlighting.
- When the user has searched, show links to the sections in which
  results were returned.

To test, apply the patch and go to Administration -> System preferences.

 - Test the functionality of setting various kinds of preferences,
   including multi-selects, textareas, WYSIWYG editors, etc.
 - Test the filter form at the top of the page for narrowing in-page
   results.
   - Test both successful and unsuccessful filters.
 - Perform a system preference search.
   - Test the in-page links to the different sections.
   - Test that in-page filtering works in this case too.
 - View the licenses tab of the "About" page and check that the
   information about mark.js looks correct.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 15:00:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 13:00:45 +0000
Subject: [Koha-bugs] [Bug 19956] Adjusting fine block on SIP connected
 self-check - Coffeyville
In-Reply-To: <bug-19956-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19956-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19956-70-E9QOoL40lK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19956

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|jesse at bywatersolutions.com  |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 15:00:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 13:00:51 +0000
Subject: [Koha-bugs] [Bug 19956] Adjusting fine block on SIP connected
	self-check
In-Reply-To: <bug-19956-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19956-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19956-70-Iths6cX1cO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19956

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Adjusting fine block on SIP |Adjusting fine block on SIP
                   |connected self-check -      |connected self-check
                   |Coffeyville                 |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 15:01:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 13:01:05 +0000
Subject: [Koha-bugs] [Bug 19956] Adjusting fine block on SIP connected
	self-check
In-Reply-To: <bug-19956-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19956-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19956-70-IAVk44Foi5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19956

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 15:02:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 13:02:55 +0000
Subject: [Koha-bugs] [Bug 20954] New: Add ability to set syspref overrides
 in SIP as we can in apache
Message-ID: <bug-20954-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20954

            Bug ID: 20954
           Summary: Add ability to set syspref overrides in SIP as we can
                    in apache
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

We should be able to set system preference overrides for SIP in a similar
manner that we do in Apache. It would be great if we could specify those
overrides on both a config level, and login level basis.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 15:02:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 13:02:58 +0000
Subject: [Koha-bugs] [Bug 20954] Add ability to set syspref overrides in SIP
 as we can in apache
In-Reply-To: <bug-20954-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20954-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20954-70-oqPifHpU9R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20954

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 15:12:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 13:12:44 +0000
Subject: [Koha-bugs] [Bug 20954] Add ability to set syspref overrides in SIP
 as we can in apache
In-Reply-To: <bug-20954-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20954-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20954-70-dqfC3euihf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20954

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 15:12:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 13:12:46 +0000
Subject: [Koha-bugs] [Bug 20954] Add ability to set syspref overrides in SIP
 as we can in apache
In-Reply-To: <bug-20954-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20954-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20954-70-gFEktu7xQD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20954

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76098&action=edit
Bug 20954: Add ability to set syspref overrides in SIP as we can in apache

We should be able to set system preference overrides for SIP in a
similar manner that we do in Apache. It would be great if we could
specify those overrides on both a config level, and login level basis.

Test Plan:
 1) Apply this patch
 2) Start your SIP server
 3) Enable the syspref AllFinesNeedOverride
 4) Find or create a patron with a small fine ( less than noissuescharge )
 5) Attempt to check out an item to the patron, it should fail
 6) Add the global syspref override from the bottom of the example SIP config
file
 7) Restart your SIP server
 8) Attempt to check out an item to the patron again, this time it should work
 9) Now, add the login level syspref override section as it appears in
    the eaxmple SIP config file. Make sure to add it to the login you are using
10) Attempt to check out another item to the patron, this time is should
    again fail

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 15:14:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 13:14:09 +0000
Subject: [Koha-bugs] [Bug 19288] Holds placed on a specific item after a
 next available hold will show varied results
In-Reply-To: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19288-70-qSL4BZFZWx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 76099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76099&action=edit
Bug 19288: Only display holds if next in queue or waiting

To test:
 1 - Place a title level hold on a biblio for a patron
 2 - View the details, the item(s) has no info about holds
 3 - Place an item level hold for an item on the same biblio for another patron
 4 - View the details page, note the item indicates it is held for the
second patron
 5 - Apply patch
 6 - Refresh details, the hold is not indicated
 7 - Set the item specific hold to be priority #1
 8 - Refresh details, the hold should now be indicated
 9 - Confirm the hold
10 - Refresh details, the hold should show as waiting

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 15:14:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 13:14:06 +0000
Subject: [Koha-bugs] [Bug 19288] Holds placed on a specific item after a
 next available hold will show varied results
In-Reply-To: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19288-70-mxra1tMEff@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 15:17:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 13:17:05 +0000
Subject: [Koha-bugs] [Bug 19288] Holds placed on a specific item after a
 next available hold will show varied results
In-Reply-To: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19288-70-PSZKsQrq5r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
This patch will only show the hold if it is next in the priority list, however,
localholds priority and other settings may mean the hold triggered at checkin
is not the one listed. Would it be reasonable to only show "there is a hold on
this item" unless the hold is waiting?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 15:20:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 13:20:31 +0000
Subject: [Koha-bugs] [Bug 20952] Automatic debian/control updates
	(oldoldstable/17.05.x)
In-Reply-To: <bug-20952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20952-70-2SZmXE6mij@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20952

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 15:31:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 13:31:12 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-Rz47qoVT5C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #79 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
What I understood about Joseph comment is what follows :
Say we configure a weekly review from 01/01/2018 to 31/12/2018,if you set 52
issues as subscription length, it will be okay.
A priori, it makes sense that you will set permanent irregularities on a single
cycle/subscription (but people are strange !).
If, for some reason, you put, say, 56 issues as subscription length, you will
obtain as much checkboxes in the checkboxes lists.
In the "weeks not published" scrolldown list, you will have four extra
checkboxes (corresponding to weeks 1,2,3,4 of year 2019).
If you check one of these weeks, the corresponding checkbox will not be checked
on the fixed list and you risk not to notice this.
It's the reason why, I guess, Joseph suggests to limit the displayed list to 52
weeks (Some year may have 53 weeks according to iso numbering. may be we can
limit by end date of current year. Problem, I'm thinking that some subscription
(and numbering)  begin in the middle of the year and finish the year after like
New York Review.

as for "jumping checkboxes", It occurs in the "weeks not published" scrolldown
list and only at first checkbox checking. the second checking you do, no
problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 15:38:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 13:38:26 +0000
Subject: [Koha-bugs] [Bug 19288] Holds placed on a specific item after a
 next available hold will show varied results
In-Reply-To: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19288-70-BnVzsmPnDH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 76100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76100&action=edit
Bug 19288: [Alternate] Only show existence of item level hold unless waiting

To test:
1 - Please a biblio level hold for one patron, and an item level hold
for another on same record
2 - Note that you patron name for item lvel hold
3 - Apply patch
4 - You should now see 'There is a hold on this item' with no patron
detail
5 - Confirm hold, patron detail should be visible

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 16:22:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 14:22:07 +0000
Subject: [Koha-bugs] [Bug 20955] New: Add ability to trigger holds that
 violate holds policies (overridden holds)
Message-ID: <bug-20955-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955

            Bug ID: 20955
           Summary: Add ability to trigger holds that violate holds
                    policies (overridden holds)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Some libraries would like holds placed by staff that override holds policies to
trigger during checkin.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 16:26:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 14:26:02 +0000
Subject: [Koha-bugs] [Bug 20955] Add ability to trigger holds that violate
 holds policies (overridden holds)
In-Reply-To: <bug-20955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20955-70-o5fJzOk4eW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 16:26:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 14:26:04 +0000
Subject: [Koha-bugs] [Bug 20955] Add ability to trigger holds that violate
 holds policies (overridden holds)
In-Reply-To: <bug-20955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20955-70-nv7CmV0gHa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 76101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76101&action=edit
Bug 20955: Add systempreference to allow triggering forbidden holds

To test:
1 - Set a holds policy to allow only holds from homebranch
2 - Place a hold on an item for a patron from another branch
3 - Checkin item
4 - Hold does not trigger
5 - Apply patches and updatedatabase
6 - Check in item
7 - Hold triggers

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 16:26:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 14:26:07 +0000
Subject: [Koha-bugs] [Bug 20955] Add ability to trigger holds that violate
 holds policies (overridden holds)
In-Reply-To: <bug-20955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20955-70-vxAr15cWO5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 76102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76102&action=edit
Bug 20955: Unit tests

prove -v t/db_dependent/Holds/HoldFulfillmentPolicy.t
prove -v t/db_dependent/Reserves.t

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 16:31:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 14:31:54 +0000
Subject: [Koha-bugs] [Bug 20826] Error during initial setup
In-Reply-To: <bug-20826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20826-70-kWfXOLeBF1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20826

sowen at edzone.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sowen at edzone.net

--- Comment #4 from sowen at edzone.net ---
as per Jonathan Druart <jonathan.druart at bugs.koha-community.org>


Please comment with your info on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20826


root at Pine:~# sudo apt-get install koha-common
Reading package lists... Done
Building dependency tree
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 koha-common : Depends: libnet-oauth2-authorizationserver-perl but it is not
going to be installed
E: Unable to correct problems, you have held broken packages.
root at Pine:~#


current server:

Server information
Koha version:   17.05.05.000
OS version ('uname -a'):        Linux Pine 3.16.0-4-686-pae #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) i686
Perl interpreter:       /usr/bin/perl
Perl version:   5.020002
Perl @INC:      /usr/share/koha/lib 
/etc/perl 
/usr/local/lib/i386-linux-gnu/perl/5.20.2 
/usr/local/share/perl/5.20.2 
/usr/lib/i386-linux-gnu/perl5/5.20 
/usr/share/perl5 
/usr/lib/i386-linux-gnu/perl/5.20 
/usr/share/perl/5.20 
/usr/local/lib/site_perl 
. 
MySQL version:  mysql Ver 14.14 Distrib 5.5.60, for debian-linux-gnu (i686)
using readline 6.3
Apache version: Server version: Apache/2.4.10 (Debian)
Memcached:      Servers: undefined | Namespace: koha | Status: unknown | Config
read from: Nowhere Note that the right place to define the memcached config is
in your $KOHA_CONF file. Currently you do not have a valid memcached
configuration defined. | Effective caching method: Cache::Memory
Zebra version:  Zebra 2.0.59 (C) 1994-2014, Index Data Zebra is free software,
covered by the GNU General Public License, and you are welcome to change it
and/or distribute copies of it under certain conditions. SHA1 ID:
c00bfddbf0f3608340d61298acc61dafb167f9b2 Using ICU

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 16:41:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 14:41:48 +0000
Subject: [Koha-bugs] [Bug 20826] Error during initial setup
In-Reply-To: <bug-20826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20826-70-XGQcrIkYL0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20826

--- Comment #5 from Mirko Tietgen <mirko at abunchofthings.net> ---
1. What version of Debian are you running?

2. Could you please give the output of

apt-cache policy libnet-oauth2-authorizationserver-perl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 16:44:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 14:44:41 +0000
Subject: [Koha-bugs] [Bug 20955] Add ability to trigger holds that violate
 holds policies (overridden holds)
In-Reply-To: <bug-20955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20955-70-ThhGaLQOsm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 16:48:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 14:48:44 +0000
Subject: [Koha-bugs] [Bug 20826] Error during initial setup
In-Reply-To: <bug-20826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20826-70-YTYkrVdfpR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20826

--- Comment #6 from sowen at edzone.net ---
Distributor ID: Debian
Description:    Debian GNU/Linux 8.10 (jessie)
Release:        8.10
Codename:       jessie


output:

root at Pine:~# apt-cache policy libnet-oauth2-authorizationserver-perl
N: Unable to locate package libnet-oauth2-authorizationserver-perl
root at Pine:~#

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 17:01:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 15:01:53 +0000
Subject: [Koha-bugs] [Bug 20826] Error during initial setup
In-Reply-To: <bug-20826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20826-70-ivRJgPbAoN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20826

--- Comment #7 from Mirko Tietgen <mirko at abunchofthings.net> ---
What does your /etc/apt/sources.list* look like?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 17:03:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 15:03:42 +0000
Subject: [Koha-bugs] [Bug 20956] New: BorrowersLog is not logging permission
	changes
Message-ID: <bug-20956-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956

            Bug ID: 20956
           Summary: BorrowersLog is not logging permission changes
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

I made changes to permissions, and I can see that it is not being logged.  This
is a security issue and should be fixed immediately.  We cannot have people
changing permissions undetected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 17:05:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 15:05:25 +0000
Subject: [Koha-bugs] [Bug 20947] Navigating to moremember.pl for a patron
 who has fines on deleted items causes software error.
In-Reply-To: <bug-20947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20947-70-gwKkvwSrVg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20947

--- Comment #2 from Barton Chittenden <barton at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #1)
> I do not recreate, I noticed that accountlines.itemnumber is set to NULL
> when the item is deleted.
> Can you detail a bit more the steps to recreate?

The problem is triggered by accountlines records that have itemnumbers that
don't point to items -- I honestly don't know *how* that happened -- manual
database manipulation? Accountlines records that existed before the foreign key
constraints?

I think as a work-around, we're going to simply null accountlines.itemnumber
and set accountlines.note using

UPDATE
    accountlines
SET
    note=CONCAT(itemnumber," item deleted from system"),
    itemnumber=NULL
WHERE
    itemnumber NOT IN ( SELECT itemnumber FROM items );

I'm still open to a patch for this; but considering that the code that causes
his no longer exists in master, and that I can't reproduce this by normal means
in 17.11, I'm willing to use the workaround.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 17:46:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 15:46:35 +0000
Subject: [Koha-bugs] [Bug 18851] Use Test::DBIx::Class in tests breaks
	packaging
In-Reply-To: <bug-18851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18851-70-czlIXzIW4n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #33 from Mirko Tietgen <mirko at abunchofthings.net> ---
Fridolin: I suppose you missed that it depends on bug 18226. I could easily
apply both to 17.05.x, there is just one test to 'git add'. This would probably
fix the failing t/XSLT.t in 17.05.x (with Test::DBiX::Class but without DB, as
on the nightly server). Would you reconsider pushing to 17.05.x?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 18:07:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 16:07:31 +0000
Subject: [Koha-bugs] [Bug 18851] Use Test::DBIx::Class in tests breaks
	packaging
In-Reply-To: <bug-18851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18851-70-dKzylLjIad@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

--- Comment #34 from Mirko Tietgen <mirko at abunchofthings.net> ---
Nevermind, it fails a lot more tests afterwards. There is more missing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 18:24:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 16:24:33 +0000
Subject: [Koha-bugs] [Bug 18851] Use Test::DBIx::Class in tests breaks
	packaging
In-Reply-To: <bug-18851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18851-70-9VnMl8iywC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

--- Comment #35 from Mirko Tietgen <mirko at abunchofthings.net> ---
Ok, it is, in this order,

18285
18286
18287
18288
18289
18226
18851

No rebase needed. All tests run fine afterwards (not checked db-dependent)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 19:29:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 17:29:21 +0000
Subject: [Koha-bugs] [Bug 20826] Error during initial setup
In-Reply-To: <bug-20826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20826-70-ZAbMSU0Px4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20826

--- Comment #8 from sowen at edzone.net ---

/etc/apt/sources.list



# 

# deb cdrom:[Debian GNU/Linux 8.1.0 _Jessie_ - Official i386 NETINST Binary-1
20150606-12:58]/ jessie main

#deb cdrom:[Debian GNU/Linux 8.1.0 _Jessie_ - Official i386 NETINST Binary-1
20150606-12:58]/ jessie main

deb http://ftp.us.debian.org/debian/ jessie main
deb-src http://ftp.us.debian.org/debian/ jessie main

deb http://security.debian.org/ jessie/updates main
deb-src http://security.debian.org/ jessie/updates main

# jessie-updates, previously known as 'volatile'
deb http://ftp.us.debian.org/debian/ jessie-updates main
deb-src http://ftp.us.debian.org/debian/ jessie-updates main

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 20:26:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 18:26:43 +0000
Subject: [Koha-bugs] [Bug 20954] Add ability to set syspref overrides in SIP
 as we can in apache
In-Reply-To: <bug-20954-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20954-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20954-70-unp5Iu74Ka@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20954

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76098|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76103
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76103&action=edit
Bug 20954: Add ability to set syspref overrides in SIP as we can in apache

We should be able to set system preference overrides for SIP in a
similar manner that we do in Apache. It would be great if we could
specify those overrides on both a config level, and login level basis.

Test Plan:
 1) Apply this patch
 2) Start your SIP server
 3) Enable the syspref AllFinesNeedOverride
 4) Find or create a patron with a small fine ( less than noissuescharge )
 5) Attempt to check out an item to the patron, it should fail
 6) Add the global syspref override from the bottom of the example SIP config
file
 7) Restart your SIP server
 8) Attempt to check out an item to the patron again, this time it should work
 9) Now, add the login level syspref override section as it appears in
    the eaxmple SIP config file. Make sure to add it to the login you are using
10) Attempt to check out another item to the patron, this time is should
    again fail

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 20:57:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 18:57:13 +0000
Subject: [Koha-bugs] [Bug 20934] Biblio checkout history shows only current
	checkout
In-Reply-To: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20934-70-5Sqx4rHTJO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 20:57:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 18:57:16 +0000
Subject: [Koha-bugs] [Bug 20934] Biblio checkout history shows only current
	checkout
In-Reply-To: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20934-70-nvIYxMzqo3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76043|0                           |1
        is obsolete|                            |

--- Comment #2 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 76104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76104&action=edit
Bug 20934: Fix display of old checkouts in the checkout history page

Again a regression caused by
  commit fa54100dffe092e606f79b15692eedaf78f42e45
  Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for
issuehistory]

GetBiblioIssues does a union all with issues and old_issues, so we
should old_issues as well.
To make the join on the items table we need to define the item and
patron methods. For consistency the relationships have been redefined
(item instead of itemnumber, borrower instead of borrowernumber) in the
DBIx::Class definition.

This is not perfect but I think the best way to provide an easy to
backport patch.

It highlights that we need improvements in this area.

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
The patch works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 21:11:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 19:11:35 +0000
Subject: [Koha-bugs] [Bug 20928] Checkout status not showing patron
In-Reply-To: <bug-20928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20928-70-LDZ7oyY4Ij@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20928

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 21:11:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 19:11:38 +0000
Subject: [Koha-bugs] [Bug 20928] Checkout status not showing patron
In-Reply-To: <bug-20928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20928-70-EyN0qrQJsN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20928

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76058|0                           |1
        is obsolete|                            |

--- Comment #3 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 76105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76105&action=edit
Bug 20928: Fix regression - display patron's info on moredetail if item is
checked out

This patch is a follow-up of
  commit 5f80977875ff124d411f2cd89de4a944fa9c27af
  Bug 18403: Use patron-title.inc when hidepatronname is used

Test plan:
- Check an item out
- Go on the moredetail.pl page of this biblio record
Home ? Catalog ? Item details for your biblio
- Confirm that you see:
"Checkout status: Checked out to"
followed by the patron's info

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Followed the test plan and it works.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 21:14:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 19:14:34 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19817-70-5iZF0UsAvV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com

--- Comment #71 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
I had a bit of trouble applying the patch. I had to add member-flags.tt and
then continue applying the patch. I don't know if that's normal or not.

I went to Global system preferences and clicked on the tab for circulation.
When I clicked help, the manual was at the beginning of the sysprefs section. I
don't know if it's possible at all to point to the right sub-section? It's just
that are sooooo many system preferences...

My KohaManualLanguage is on Arabic by default. I'm guessing it's the first
language in the list, but if I don't change it will this be the default? Should
we put English by default instead of Arabic?

I also don't see the edit button mentioned in comment 7. Was that implemented
or just an idea for a future development? It could be a second patch. People
don't currently have the ability to modify from the staff interface, so it
wouldn't necessarily be a step back. More advanced users can still use their
own help files.

I wasn't able to test switching languages because my master is only installed
in English.

It's a great development! It will be much easier to translate, no need to
translate the help file, just the manual. It will also be more uniform.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 21:21:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 19:21:59 +0000
Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface
In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20935-70-PwVD42ocUz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

--- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created attachment 76106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76106&action=edit
Screenshot of the system preferences page

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 21:29:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 19:29:33 +0000
Subject: [Koha-bugs] [Bug 20867] Ability to show membership renewal date on
 moremember.pl page
In-Reply-To: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20867-70-OMFLDZad59@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 21:29:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 19:29:37 +0000
Subject: [Koha-bugs] [Bug 20867] Ability to show membership renewal date on
 moremember.pl page
In-Reply-To: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20867-70-31h8Vf55Gx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867

--- Comment #5 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 76107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76107&action=edit
Bug 20867 - Ability to show membership renewal date on moremember.pl page

Test case:
1. Create the patron.
2. Search the patron whose date of membership is about to expire or expired.
3. Click on More->Renew patron.
4. Now membership is renewed.
5. Apply the patch.
6. Reload the page now you will able to see the Membership renewal date.

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Followed the test plan and it works.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 21:31:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 19:31:17 +0000
Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface
In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20935-70-gRoO1eVIHl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com

--- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
When I apply the patch, it doesn't look the same as the screenshots. The
section headings are blue and the syspref names are almost the same as their
description. making it hard to read. I like it, but  would like the syspref
names to be at least in bold.

Also, would it be possible to keep the same indent as the first line on the 2nd
+ line of the description? For example, in my screenshot, in the description
for gist, the second line, starting at "rounded" doesn't have the same indent
as the line above. I think it makes it look messy. 

I would miss the arrows to collapse a section (when they're really long, it
saves scrolling energy). Would it still be possible to have them in this new
design? It's not the end of the world if it's not

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 21:32:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 19:32:35 +0000
Subject: [Koha-bugs] [Bug 15704] split up 264 index
In-Reply-To: <bug-15704-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15704-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15704-70-Ad2bw2TwQn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15704

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |charles.farmer at inlibro.com

--- Comment #4 from Charles Farmer <charles.farmer at inlibro.com> ---
Using the most basic record with the 'Default framework', I can't reproduce the
issue of not finding a record from its publisher.

Here's what I did:

* Since the 264's weren't visible by default in the editor, I went ahead and
made them show up by changing the properties of admin/biblio_framework.pl.
Otherwise, I had no way of adding content to those fields
* I created a new record, filled the info.
* * I also made sure to fill the other fields of 264 with garbage data, just in
case
* Rebuilt zebra
* Searched for the string I added in 264b: supercalifragilisticexpialidocious
* I'm redirected to the new record's page

Am I doing something wrong here? Why is it showing up on my master?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 21:49:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 19:49:17 +0000
Subject: [Koha-bugs] [Bug 18521] Renew and search hotkeys are swapped on
	returns page.
In-Reply-To: <bug-18521-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18521-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18521-70-qVnjhVssER@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18521

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 21:49:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 19:49:20 +0000
Subject: [Koha-bugs] [Bug 18521] Renew and search hotkeys are swapped on
	returns page.
In-Reply-To: <bug-18521-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18521-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18521-70-qnARR4D9zV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18521

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75551|0                           |1
        is obsolete|                            |

--- Comment #3 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 76108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76108&action=edit
Bug 18521 - Moving the if CAN_user_circulate_circulate_remaining_permissions
conditional block

Moving the conditional block [% IF
(CAN_user_circulate_circulate_remaining_permissions ) %] block up the
checkin-search.inc file above the CAN_user_catalogue IF conditional block fixes
this bug.

Test plan:
1. Go to the circ home page and confirm the following
keyboard shortcuts work:

Alt+q = goes to search catalog
Alt+w = goes to renew

2. Go to returns.pl and confirm the following  keyboard shortcuts work:

Alt+q = goes to renew
Alt+w = goes to search catalog

3. Apply patch

4. Restart apache2, memchached and plack

5. Confirm on the returns.pl the following keyboard shortcuts work:
Alt+q = goes to search catalog
Alt+w = goes to renew

Sponsored-By: Catalyst IT

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Followed the test plan and it works.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 22:08:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 20:08:04 +0000
Subject: [Koha-bugs] [Bug 5789] Fines don't work when items have null
	homebranch
In-Reply-To: <bug-5789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5789-70-lV7MPfYroa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5789

--- Comment #10 from Pierre-Luc Lapointe <pierre-luc.lapointe at inLibro.com> ---
Created attachment 76109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76109&action=edit
Bug 5789 - Fines don't work when items have null homebranch

When the CircControl system preference is set to 'the library the item is from'
and items.homebranch is not set,
fines.pl will stop processing witha fatal error that looks something like this:

    Use of uninitialized value $branchcode in exists at
/home/koha/kohaclone/misc/cronjobs/fines.pl line 110
    No branchcode argument passed to Koha::Calendar->new at
/home/koha/kohaclone/misc/cronjobs/fines.pl line 169.

This patch will check the value of $branchcode before it is used. If
$branchcode is undefined, a warning will
be issued and, processing will be skipped for that item, and continue for the
next item.

To test:

1) Set CircControl to  'the library the item is from'
2) Check out items and back-date them to be overdue
3) Set homebranch of one of the items to NULL
4) Run misc/cronjobs/fines.pl, note that processing stops at that item.
5) Apply patch
6) Repeat step 4. not that processing completes.
7) Check logs, you should see a warning message for the item missing its
homebranch.
8) Sign off.

Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe at inLibro.com>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 22:09:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 20:09:35 +0000
Subject: [Koha-bugs] [Bug 5789] Fines don't work when items have null
	homebranch
In-Reply-To: <bug-5789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5789-70-Jv7yvZN8Mk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5789

Pierre-Luc Lapointe <pierre-luc.lapointe at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pierre-luc.lapointe at inLibro
                   |                            |.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 22:14:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 20:14:37 +0000
Subject: [Koha-bugs] [Bug 20014] When adding to basket from a staged file
 item budgets are selected my matching on code, not id
In-Reply-To: <bug-20014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20014-70-8fdsEBHUsT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |charles.farmer at inlibro.com

--- Comment #4 from Charles Farmer <charles.farmer at inlibro.com> ---
> 975 from record:
> =975  \\$7-1$8b$cO$g8.90$hSHOES$p8.90$q1$u14.95$v14.95$yBOOK 
> 
> You will need to adjust subfield $h to the name of on of your funds that is
> duplicated

This will definitely have to be rephrased, because like Zoe Bennett, I couldn't
reproduce the issue.

I did as you said, created two budgets, with one fund that had the same code,
and yet, when I used the staged file to add items to a new basket, there was
only one budget name in the dropdown menu.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 22:36:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 20:36:26 +0000
Subject: [Koha-bugs] [Bug 20924] News content textarea not showing
In-Reply-To: <bug-20924-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20924-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20924-70-RTAdvVUapM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20924

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 22:36:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 20:36:29 +0000
Subject: [Koha-bugs] [Bug 20924] News content textarea not showing
In-Reply-To: <bug-20924-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20924-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20924-70-Lg3Ym9iJP8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20924

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76014|0                           |1
        is obsolete|                            |

--- Comment #3 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 76110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76110&action=edit
Bug 20924: Make news content textarea show

To test:
1) Go to Tools -> News
2) Edit existing news item or add new news item
3) Notice content box is missing, can't edit news or add any content
4) Apply patch, refresh page
5) Notice textarea now shows

Sponsored-by: Catalyst IT

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Followed the test plan and everything works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 23:10:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 21:10:16 +0000
Subject: [Koha-bugs] [Bug 20259] Shorter JS and CSS rewrite rule
In-Reply-To: <bug-20259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20259-70-F2i29NCerz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |charles.farmer at inlibro.com

--- Comment #4 from Charles Farmer <charles.farmer at inlibro.com> ---
Only seeing 200's on my station. Looks good.

Tested with:
Server version: Apache/2.4.18 (Ubuntu)
Server built:   2018-04-18T14:53:04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 23:26:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 21:26:40 +0000
Subject: [Koha-bugs] [Bug 20259] Shorter JS and CSS rewrite rule
In-Reply-To: <bug-20259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20259-70-Hsjit5AkLu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 15 23:26:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jun 2018 21:26:43 +0000
Subject: [Koha-bugs] [Bug 20259] Shorter JS and CSS rewrite rule
In-Reply-To: <bug-20259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20259-70-UexJnpGouF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72014|0                           |1
        is obsolete|                            |

--- Comment #5 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 76111
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76111&action=edit
Bug 20259: Shorter JS and CSS rewrite rule

Bug 20187 has changed the JS and CSS rewrite rules to :
RewriteRule ^(.*)_[0-9][0-9]\.[0-9][0-9][0-9][0-9][0-9][0-9][0-9].js$ $1.js [L]
RewriteRule ^(.*)_[0-9][0-9]\.[0-9][0-9][0-9][0-9][0-9][0-9][0-9].css$ $1.css
[L]

This patch changes this rules using [0-9]{N} and fusion in one rule.
And espaces the dot in extension js and css.

Test plan :
1) Go to intranet and opac
2) Check CSS and JS are doing well
3) Apply patch changes on our Apache configuration
4) Reload intranet and opac pages (Ctrl + F5)
5) Check CSS and JS are doing well

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 16 04:02:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jun 2018 02:02:33 +0000
Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines
	list
In-Reply-To: <bug-15136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15136-70-9y3BWBCAL9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff
   Patch complexity|Small patch                 |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 16 04:02:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jun 2018 02:02:36 +0000
Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines
	list
In-Reply-To: <bug-15136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15136-70-5ssixHAm9b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71559|0                           |1
        is obsolete|                            |
  Attachment #71560|0                           |1
        is obsolete|                            |

--- Comment #19 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 76112
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76112&action=edit
Bug 15136: Add homebranch of borrowed items to patron accounts tab

Test plan:
1 - View the accounts tab for a patron with fines
2 - Note there is no homebranch displayed to see where charges came from
3 - Apply patch
4 - Reload the page and note that you see the 'Home library' column

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 16 04:07:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jun 2018 02:07:24 +0000
Subject: [Koha-bugs] [Bug 16767] OPAC suggestions,
 existing suggestions don't show after placing a suggestion
In-Reply-To: <bug-16767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16767-70-uVPItGryHu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16767

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |WORKSFORME

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Seems to be fixed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 16 04:43:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jun 2018 02:43:19 +0000
Subject: [Koha-bugs] [Bug 20014] When adding to basket from a staged file
 item budgets are selected my matching on code, not id
In-Reply-To: <bug-20014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20014-70-Y51i1cQT4m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 76113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76113&action=edit
Budget setup

Example budgets/funds to illustrate issues

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 16 04:44:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jun 2018 02:44:13 +0000
Subject: [Koha-bugs] [Bug 20014] When adding to basket from a staged file
 item budgets are selected my matching on code, not id
In-Reply-To: <bug-20014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20014-70-3urzf7ovGq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 76114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76114&action=edit
View of double selected elements on adding to basket

View of the issue when adding from staged to basket

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 16 04:45:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jun 2018 02:45:04 +0000
Subject: [Koha-bugs] [Bug 20014] When adding to basket from a staged file
 item budgets are selected my matching on code, not id
In-Reply-To: <bug-20014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20014-70-ncBTMbUjH2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 76115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76115&action=edit
Example marc file for staging

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 16 04:48:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jun 2018 02:48:18 +0000
Subject: [Koha-bugs] [Bug 20014] When adding to basket from a staged file
 item budgets are selected my matching on code, not id
In-Reply-To: <bug-20014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20014-70-Y2WXBbppBw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Charles Farmer from comment #4)
> > 975 from record:
> > =975  \\$7-1$8b$cO$g8.90$hSHOES$p8.90$q1$u14.95$v14.95$yBOOK 
> > 
> > You will need to adjust subfield $h to the name of on of your funds that is
> > duplicated
> 
> This will definitely have to be rephrased, because like Zoe Bennett, I
> couldn't reproduce the issue.
> 
> I did as you said, created two budgets, with one fund that had the same
> code, and yet, when I used the staged file to add items to a new basket,
> there was only one budget name in the dropdown menu.

I added an example file and screenshots, I changed the fund name to show that
both are selected, the problem persists if the names are the same or different

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 16 14:49:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jun 2018 12:49:53 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-jmkdfMG6Y6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 16 14:49:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jun 2018 12:49:57 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-h0hwNz2el1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76116&action=edit
Bug 20946: Remove credits from the 'Pay fines' tab in pay.pl

This patch changes the query for outstanding account lines so it doesn't
pick credits, which don't belong to the 'Pay fines' tab, and actually break
form validation for payments.

To test:
- Add a $5 credit to a patron
- Add a $1 fine
- Go to the 'Pay fines' tab
=> FAIL: Credit is displayed
- Try to pay all fines
=> FAIL: You are told to enter a value less than or equal to -4.00
         (Observe you cannot do that)
- Apply this patch
- Reload
=> SUCCESS: Credit is not displayed
=> SUCCESS: You are able to pay all fines
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 03:30:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 01:30:47 +0000
Subject: [Koha-bugs] [Bug 6339] ExtendedPatronAttributes to allow for a
 DatePicker (JS Calendar) style field
In-Reply-To: <bug-6339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6339-70-qfcM3VEagZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6339

Hugh Rundle <hughr at brimbank.vic.gov.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20958

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 03:30:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 01:30:47 +0000
Subject: [Koha-bugs] [Bug 20958] New: Allow admins to choose data types for
 additional attributes
Message-ID: <bug-20958-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20958

            Bug ID: 20958
           Summary: Allow admins to choose data types for additional
                    attributes
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: hughr at brimbank.vic.gov.au
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Currently additional patron attributes are always strings. It would be really
useful to be able to specify what data type an additional attribute should be
when it is created, like you can specify whether it has to be unique, or is
repeatable. e.g. we might want it to be a DATE, or possibly a DATETIME, or we
may indeed want a STRING, or an INT, or a DECIMAL etc - it really depends on
what a given library is using the attributes for, and how they might want to
run reports against it.

This would be a more holistic way to deal with Bug 6339.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 07:25:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 05:25:44 +0000
Subject: [Koha-bugs] [Bug 20832] Opac user page crash when there is an
 overdue fine and not any rental charge for a patron
In-Reply-To: <bug-20832-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20832-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20832-70-tcI1gUdisk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20832

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 12001 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 07:42:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 05:42:24 +0000
Subject: [Koha-bugs] [Bug 18674] Show timezone for Perl and MySQL on the
	About Koha page
In-Reply-To: <bug-18674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18674-70-mNP75Mteeo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674

--- Comment #16 from David Cook <dcook at prosentient.com.au> ---
It's a shame this isn't backported to at least 17.05, since 17.05 and 17.11
don't have an easy way of verifying TZ settings.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 07:49:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 05:49:14 +0000
Subject: [Koha-bugs] [Bug 20922] Koha::Number::Price must not be used in
 updatedatabase.pl
In-Reply-To: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20922-70-3ppMYlyZ54@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 07:50:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 05:50:41 +0000
Subject: [Koha-bugs] [Bug 20918] left-side navigation broken on the checkout
	history page
In-Reply-To: <bug-20918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20918-70-HldSs1gJnP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20918

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 18403 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 07:51:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 05:51:31 +0000
Subject: [Koha-bugs] [Bug 20899] Patron name not showing on issuehistory.pl
In-Reply-To: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20899-70-SKfUBC2Jjv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 18403 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 07:51:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 05:51:32 +0000
Subject: [Koha-bugs] [Bug 20934] Biblio checkout history shows only current
	checkout
In-Reply-To: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20934-70-1NtF8tFIDZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934
Bug 20934 depends on bug 20899, which changed state.

Bug 20899 Summary: Patron name not showing on issuehistory.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 07:54:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 05:54:34 +0000
Subject: [Koha-bugs] [Bug 20892] Wrong basketgroup link in histsearch.pl
In-Reply-To: <bug-20892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20892-70-i9JFFgyhNQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20892

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 07:56:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 05:56:19 +0000
Subject: [Koha-bugs] [Bug 20911] Search history page forms use 'GET' and
 this limits the number of entries that can be submitted
In-Reply-To: <bug-20911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20911-70-QAuRCdZetY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20911

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 08:03:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 06:03:28 +0000
Subject: [Koha-bugs] [Bug 20760] Advanced Cataloging Editor - Rancor -
 AuthorisedValues are incorrectly fetched
In-Reply-To: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20760-70-Es0Xo0GUqc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20760

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #16 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 08:28:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 06:28:32 +0000
Subject: [Koha-bugs] [Bug 18674] Show timezone for Perl and MySQL on the
	About Koha page
In-Reply-To: <bug-18674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18674-70-7rni84Ae4e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 08:58:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 06:58:31 +0000
Subject: [Koha-bugs] [Bug 19970] Revise change of bug 19413 to work better
 for translations
In-Reply-To: <bug-19970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19970-70-ano8ualUXD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19970

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Hi, I'm not sure how to apply on 17.11.x since it does not have Asset TT plugin
(Bug 20538).
Can you provide a rebased patch ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 09:03:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 07:03:00 +0000
Subject: [Koha-bugs] [Bug 20285] Lost item refund won't always pay down lost
 item fee first
In-Reply-To: <bug-20285-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20285-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20285-70-Ctmz35ajeu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20285

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 10:18:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 08:18:15 +0000
Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting
	with plack
In-Reply-To: <bug-15562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15562-70-zmABy4yZRK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562

--- Comment #72 from David Cook <dcook at prosentient.com.au> ---
(In reply to Jerome Charaoui from comment #71)
> Created attachment 76062 [details] [review]
> bug 15562: Roll-up and rebase

What's a "roll-up and rebase"? That's a roll-up of the existing patches as
applied against a rebased branch?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 10:19:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 08:19:45 +0000
Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting
	with plack
In-Reply-To: <bug-15562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15562-70-Mal5CkzWu7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562

--- Comment #73 from David Cook <dcook at prosentient.com.au> ---
Are you still having problems with Zebra with your updated patch?

I'm super interested in this issue. I'm time poor these days, but looking
forward to any work that people do on it!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 11:31:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 09:31:04 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12395-70-0ba9HnImoL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor.grousset at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 11:36:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 09:36:24 +0000
Subject: [Koha-bugs] [Bug 20930] Handle YAML type system preferences as
	parsed references
In-Reply-To: <bug-20930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20930-70-f8YDKodt7z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 11:41:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 09:41:21 +0000
Subject: [Koha-bugs] [Bug 20956] BorrowersLog is not logging permission
	changes
In-Reply-To: <bug-20956-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20956-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20956-70-Gfv51z1CxY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 11:41:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 09:41:37 +0000
Subject: [Koha-bugs] [Bug 20958] Allow admins to choose data types for
 additional attributes
In-Reply-To: <bug-20958-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20958-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20958-70-J5PAodBwZP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20958

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 11:43:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 09:43:25 +0000
Subject: [Koha-bugs] [Bug 20943] Cannot enable shibboleth and LDAP at the
	same time
In-Reply-To: <bug-20943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20943-70-VpM13KvlQc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20943

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 11:43:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 09:43:44 +0000
Subject: [Koha-bugs] [Bug 20931] JS error "ReferenceError: $ is not defined"
 when CircSidebar is turned on
In-Reply-To: <bug-20931-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20931-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20931-70-yPUWf4DTCH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20931

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 11:44:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 09:44:02 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-VD0NFTVCua@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 11:44:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 09:44:11 +0000
Subject: [Koha-bugs] [Bug 20944] Add routes to add credits and debits to a
 patron's account
In-Reply-To: <bug-20944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20944-70-llLT1T2ioN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 12:29:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 10:29:22 +0000
Subject: [Koha-bugs] [Bug 20953] Discharge can be requested several times on
	OPAC
In-Reply-To: <bug-20953-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20953-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20953-70-3eOFM5Et9G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 12:29:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 10:29:25 +0000
Subject: [Koha-bugs] [Bug 20953] Discharge can be requested several times on
	OPAC
In-Reply-To: <bug-20953-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20953-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20953-70-zH5lhnuJFp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953

--- Comment #2 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 76117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76117&action=edit
Bug 20953: Prevent several discharge requests on OPAC

On OPAC, a user can requested a discharge even if one is already pending.
This generates several pending discharges in staff interface that can not be
deleted.

This is because request operation leads to page 'opac-discharge.pl?op=request'
and user can refresh this page performing a new request.

Perl code must check that operation is allowed.

Patch reoganised the code so that the following FIXME is obsolete :
  'FIXME looks like $available is not needed'
Patch also replaces 'op' arg test to also check undef : input->param("op") //
''

Test plan :
1) Set system preference 'useDischarge' to 'Allow'
2) Choose a patron without checkouts nor fines nor restrictions
3) Log at OPAC and go to patron page /cgi-bin/koha/opac-user.pl
4) Click on 'ask for a discharge' tab
   => You see /cgi-bin/koha/opac-discharge.pl
      with text 'What is a discharge? ...'
5) Click on 'Ask for a discharge' link
   => You see /cgi-bin/koha/opac-discharge.pl?op=request
      with text 'Your discharge request has been sent ...'
6) In a new browser tab/page, go to intranet on
/cgi-bin/koha/members/discharges.pl
   => You see one discharge requets for the patron
7) Come back to OPAC and refresh page
   => You see /cgi-bin/koha/opac-discharge.pl
   with text 'Your discharge will be available on this page within a few days.'
8) Come back to intranet and refresh /cgi-bin/koha/opac-discharge.pl
   => There is still one requets for the patron
9) Come back to OPAC and enter URL /cgi-bin/koha/opac-discharge.pl?op=get
   => You see /cgi-bin/koha/opac-discharge.pl
      with text 'Your discharge will be available on this page within a few
days.'
10) Come back to intranet and refresh /cgi-bin/koha/opac-discharge.pl
   => There is still one requets for the patron
11) Click on 'allow' on patron discharge request
12) Come back to OPAC and refresh /cgi-bin/koha/opac-discharge.pl
    => You see link 'Get your discharge'
13) enter URL /cgi-bin/koha/opac-discharge.pl?op=request
    => You see same page and no new discharge requets is created
14) Come back to intranet on patron details page
15) Remove the discharge restriction
16) Come back to OPAC and refresh /cgi-bin/koha/opac-discharge.pl
    => You see text 'What is a discharge?...'
17) enter URL /cgi-bin/koha/opac-discharge.pl?op=get
    => You see same page and no new discharge requets is created

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 12:43:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 10:43:02 +0000
Subject: [Koha-bugs] [Bug 18674] Show timezone for Perl and MySQL on the
	About Koha page
In-Reply-To: <bug-18674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18674-70-KRx9nSGV30@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674

--- Comment #17 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to David Cook from comment #16)
> It's a shame this isn't backported to at least 17.05, since 17.05 and 17.11
> don't have an easy way of verifying TZ settings.

This one needs some work to be suitable for the old stable releases. You better
talk to the release maintainers. If you need it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 13:59:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 11:59:23 +0000
Subject: [Koha-bugs] [Bug 19970] Revise change of bug 19413 to work better
 for translations
In-Reply-To: <bug-19970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19970-70-Rh0hr4lhwo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19970

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76118&action=edit
Bug 19970: (17.05.x) Revise change of bug 19413 to work better for translations

This patch changes how the submit and cancel buttons appear in the MARC
008 plugin window. The controls are now displayed as buttons in a
floating toolbar.

To test you must have MARC tag 008 configured to use the
marc21_field_008.pl plugin.

- Apply the patch and open an existing or blank record in cataloging.
- Click the plugin link next to tag 008 to trigger the popup window.
- Confirm that "Save" and "Cancel" appear correctly in a toolbar.
- Scroll down the page to confirm that the toolbar "sticks" to the top
  of the window.
- Confirm that the "Save" and "Cancel" buttons work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 14:02:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 12:02:48 +0000
Subject: [Koha-bugs] [Bug 19970] Revise change of bug 19413 to work better
 for translations
In-Reply-To: <bug-19970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19970-70-AeyoPcPpQP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19970

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76118|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 14:06:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 12:06:41 +0000
Subject: [Koha-bugs] [Bug 19970] Revise change of bug 19413 to work better
 for translations
In-Reply-To: <bug-19970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19970-70-lNBiMuNbNe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19970

--- Comment #9 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76119&action=edit
Bug 19970: (17.11.x) Revise change of bug 19413 to work better for translations

This patch changes how the submit and cancel buttons appear in the MARC
008 plugin window. The controls are now displayed as buttons in a
floating toolbar.

To test you must have MARC tag 008 configured to use the
marc21_field_008.pl plugin.

- Apply the patch and open an existing or blank record in cataloging.
- Click the plugin link next to tag 008 to trigger the popup window.
- Confirm that "Save" and "Cancel" appear correctly in a toolbar.
- Scroll down the page to confirm that the toolbar "sticks" to the top
  of the window.
- Confirm that the "Save" and "Cancel" buttons work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 14:13:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 12:13:01 +0000
Subject: [Koha-bugs] [Bug 19970] Revise change of bug 19413 to work better
 for translations
In-Reply-To: <bug-19970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19970-70-DRr63B5uSV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19970

--- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 14:59:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 12:59:54 +0000
Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for
	callnumber ranges
In-Reply-To: <bug-19915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19915-70-hhOvditkD0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915

--- Comment #18 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #17)
> Hi Nick,
> 
> I am a little confused about the need for the new classification source pull
> down on the inventory form. Some questions:
> 
> 1) Why is it needed?
We need to know which source to use for converting the callnumbers entered,
currently we test against unconverted callnumbers which doesn't work for
manyschemes, the reanges won't be returned correctly

> 2) Should we not only show the classification sources marked as 'in use'?

Good idea, I will followup

> 3) Why can't I unset it?

Even when cn_source is not set for an item it uses the default, unsetting it
shouldn't be necessary

> 4) Is it supposed to limit the search? Because when I select LOC
> classification, items are found, although they don't have a classification
> source set.

It doesn't limit the search per se, it just converts the range to the correct
values for cn_sort

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 15:01:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 13:01:33 +0000
Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for
	callnumber ranges
In-Reply-To: <bug-19915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19915-70-BzskIjC55p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 15:01:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 13:01:39 +0000
Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for
	callnumber ranges
In-Reply-To: <bug-19915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19915-70-rC1KYVJLW5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915

--- Comment #19 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 76120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76120&action=edit
Bug 19915: Only show class sources in use

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 15:25:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 13:25:03 +0000
Subject: [Koha-bugs] [Bug 20924] News content textarea not showing
In-Reply-To: <bug-20924-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20924-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20924-70-a0XHiXvidf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20924

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Maryse Simard from comment #3)
> Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
> Followed the test plan and everything works as expected.

Hi Maryse, did you recreate the issue without the patch?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 15:41:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 13:41:44 +0000
Subject: [Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to
	Koha::Patron
In-Reply-To: <bug-19936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19936-70-4LLetqWtYE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #88 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hi Liz,

I have tried with your line (with sample data, replaced "STAFF" with "S" and
"BRANCHCODE" with "CPL", I have also created the patron's attribute "GROUP").

I see these 2 lines:
Use of uninitialized value $uploadborrowers in concatenation (.) or string at
/home/vagrant/kohaclone/tools/import_borrowers.pl line 109.

CGI::param called in list context from package
CGI::Compile::ROOT::home_vagrant_kohaclone_tools_import_borrowers_2epl line
123, this can lead to vulnerabilities. See the warning in "Fetching the value
or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436.

But not the one you are referring to.
Let me know if you have more detail to provide and if you recreate on a devbox,
or with the sample data.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 15:49:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 13:49:26 +0000
Subject: [Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to
	Koha::Patron
In-Reply-To: <bug-19936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19936-70-S47T5FLwvF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #89 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Liz Rea from comment #87)
> Since this patch trying to import patrons seems to be noisy, lots of

You did not tell if you were using the UI of the command line script (I tried
with both).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 15:49:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 13:49:13 +0000
Subject: [Koha-bugs] [Bug 20700] Update MARC21 leader/007/008 codes
In-Reply-To: <bug-20700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20700-70-no4C6Ptmdj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20700

--- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Bernardo Gonzalez Kriegel from comment #9)
> (In reply to Fridolin SOMERS from comment #7)
> > Does not apply on 17.11..x because of
> > koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/
> > marc21_field_007.tt
> > I'm not comfortable with MARC21 so can you provide a rebase ?
> 
> Master has Bug 19823 applied, that's the reason.
> Don't know if this needs it's own Sign/QA etc.
> This new patch implements the same changes.

No I dont think so.
Since its string freeze I will push to 17.11.x after 17.11.07 release.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 15:52:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 13:52:12 +0000
Subject: [Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR
In-Reply-To: <bug-17809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17809-70-8CQxGFyIuD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809

--- Comment #36 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Jonathan Druart from comment #35)
> Waiting for concerns on comment 31 to be addressed.

Oh indeed.
@Mark Tompsett tell me I you can't work on rewrite.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 15:55:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 13:55:53 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11897-70-Ej8TjcAQa3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75409|0                           |1
        is obsolete|                            |

--- Comment #245 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 76121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76121&action=edit
Bug 11897: Add Stock Rotation atomic update schema.

* installer/data/mysql/atomicupdate/stockrot_tables.sql: New file.
* installer/data/mysql/kohastructure.sql (stockrotationrotas)
  (stockrotationstages, stockrotationitems): New tables.
* installer/data/mysql/sysprefs.sql: Add Stockrotation sysprefs.
* installer/data/mysql/userflags.sql: Add Stockrotaiton userflag.
* installer/data/mysql/userpermissions.sql: Add Stockrotation
  userpermissions.
* koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref:
  Add Stockrotation menu.

Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 15:56:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 13:56:00 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11897-70-ehVyYbIIwV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75410|0                           |1
        is obsolete|                            |

--- Comment #246 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 76122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76122&action=edit
Bug 11897: DO NOT PUSH: Add stock rotation schema files.

* Koha/Schema/Result/Branch.pm: New file.
* Koha/Schema/Result/Item.pm: New file.
* Koha/Schema/Result/Stockrotationitem.pm: New file.
* Koha/Schema/Result/Stockrotationrota.pm: New file.
* Koha/Schema/Result/Stockrotationstage.pm: New file.

Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 15:56:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 13:56:06 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11897-70-DkaItPrYAZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75411|0                           |1
        is obsolete|                            |

--- Comment #247 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 76123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76123&action=edit
Bug 11897: DBIX::Class::Ordered in Stockrotationstage.

* Koha/Schema/Result/Stockrotationstage.pm: Load `Ordered`, add
  grouping_column.

Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 15:56:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 13:56:12 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11897-70-1w8ZTTyO9A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75412|0                           |1
        is obsolete|                            |

--- Comment #248 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 76124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76124&action=edit
Bug 11897: Add bulk of Stockrotation module.

This commit replaces a set of about 20 commits into one large
commit.  This makes working with the module way easier from bugzilla.

As it stands the patches on this bug provide a fully functioning stock
rotation feature set for Koha.

All previous patches that added functionality were signed off, so I'm
retaining that flag.

Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 15:56:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 13:56:19 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11897-70-qsfADBBaZa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75413|0                           |1
        is obsolete|                            |

--- Comment #249 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 76125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76125&action=edit
Bug 11897: (QA follow-up) Implement review feedback.

- Update Table declarations
- Add permissions checks
- Remove unused code
- Fix language & naming
- Make templates translation friendly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 15:56:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 13:56:24 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11897-70-a3pXIs7Vaw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75414|0                           |1
        is obsolete|                            |

--- Comment #250 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 76126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76126&action=edit
Bug 11897: (follow-up) Fix rebasing issue with templates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 15:56:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 13:56:36 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11897-70-RapqKEzHlV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75416|0                           |1
        is obsolete|                            |

--- Comment #252 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 76128
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76128&action=edit
Bug 11897: (QA follow-up) Fix POD failures

- add empty pod blocks for internal object_class methods

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 15:56:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 13:56:43 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11897-70-HFwfn571Ak@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75417|0                           |1
        is obsolete|                            |

--- Comment #253 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 76129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76129&action=edit
Bug 11897: (QA follow-up) Convert cronscript to use notices

The cronscript originally used Koha::Email directly, this patch converts
it to us the C4::Letters routines.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 15:56:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 13:56:30 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11897-70-WgYAiUafZJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75415|0                           |1
        is obsolete|                            |

--- Comment #251 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 76127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76127&action=edit
Bug 11897: (QA follow-up) Fix Koha/Libraries test

- merge issues corrected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 15:56:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 13:56:55 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11897-70-HDonXxazsI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75419|0                           |1
        is obsolete|                            |

--- Comment #255 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 76131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76131&action=edit
Bug 11897: DO NOT PUSH: (follow-up) Update stock rotation schema files.

We we're missing a unique constraint on stockrationrota.title

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 15:56:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 13:56:49 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11897-70-OOTXxOyZae@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75418|0                           |1
        is obsolete|                            |

--- Comment #254 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 76130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76130&action=edit
Bug 11897: (QA follow-up) Add default notice template

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 15:57:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 13:57:01 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11897-70-ENsbk1uZyB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75420|0                           |1
        is obsolete|                            |

--- Comment #256 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 76132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76132&action=edit
Bug 11897: (QA follow-up) - Add uses of Asset tt plugin

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 15:57:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 13:57:07 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11897-70-ez8mJuUf0j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #257 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 76133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76133&action=edit
Bug 11897: (follow-up) Correct bug in referenced permission

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 15:57:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 13:57:13 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11897-70-I0KcC4SO8A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #258 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 76134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76134&action=edit
Bug 11897: (follow-up) Make permissions more consistent

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 15:57:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 13:57:20 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11897-70-F3qSbkVtnv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #259 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 76135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76135&action=edit
Bug 11897: (follow-up) Ensure rota's always come back ordered

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 15:58:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 13:58:04 +0000
Subject: [Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere
	index
In-Reply-To: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8962-70-IwEk3Yk1Wn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

--- Comment #69 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Jonathan Druart from comment #68)
> Is this only for GRS-1?
> 
> Bug 14302 - Remove GRS1 indexing related code

Nope it has started for GRS-1 but its now for DOM only.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 15:58:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 13:58:42 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11897-70-BGIlIemPG3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #260 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Fully rebased and taken account of a few pieces of customer feedback in the
followups.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 15:59:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 13:59:11 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-B8NKaq7Iel@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|kyle at bywatersolutions.com   |tomascohen at gmail.com
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 16:33:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 14:33:53 +0000
Subject: [Koha-bugs] [Bug 20959] New: Style checkin form more like the
 checkout form, with collapsed settings panel
Message-ID: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959

            Bug ID: 20959
           Summary: Style checkin form more like the checkout form, with
                    collapsed settings panel
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Created attachment 76136
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76136&action=edit
Screenshot of the revised checkin form

I think it would be nice to make the checkin page look more like the checkout
page, with a collapsed panel where settings like book drop mode can be hidden
when not in use.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 16:39:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 14:39:04 +0000
Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout
 form, with collapsed settings panel
In-Reply-To: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20959-70-0qsyvrXM95@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76137&action=edit
Screenshot showing active book drop mode setting

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 16:48:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 14:48:19 +0000
Subject: [Koha-bugs] [Bug 20924] News content textarea not showing
In-Reply-To: <bug-20924-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20924-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20924-70-iYBD4tDrlZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20924

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
I can't reproduce it too.

According to tiny mce documentation the "textareas" is the right setting for
mode:
https://www.tinymce.com/docs-3x/reference/configuration/Configuration3x at mode/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 16:50:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 14:50:12 +0000
Subject: [Koha-bugs] [Bug 20956] BorrowersLog is not logging permission
	changes
In-Reply-To: <bug-20956-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20956-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20956-70-lcIEP4IU5c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
            Version|17.05                       |master

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
It sounds more like an enhancement request.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 16:52:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 14:52:43 +0000
Subject: [Koha-bugs] [Bug 20947] Navigating to moremember.pl for a patron
 who has fines on deleted items causes software error.
In-Reply-To: <bug-20947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20947-70-WVuf3xIeoR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20947

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Could you confirm the FK is missing?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 16:58:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 14:58:51 +0000
Subject: [Koha-bugs] [Bug 20928] Checkout status not showing patron
In-Reply-To: <bug-20928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20928-70-zTNhWHILRO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20928

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 16:59:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 14:59:33 +0000
Subject: [Koha-bugs] [Bug 20928] Checkout status not showing patron
In-Reply-To: <bug-20928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20928-70-SFcJS7FiyV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20928

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 16:59:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 14:59:36 +0000
Subject: [Koha-bugs] [Bug 20928] Checkout status not showing patron
In-Reply-To: <bug-20928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20928-70-I9791XjoUr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20928

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76105|0                           |1
        is obsolete|                            |

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76138
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76138&action=edit
Bug 20928: Fix regression - display patron's info on moredetail if item is
checked out

This patch is a follow-up of
  commit 5f80977875ff124d411f2cd89de4a944fa9c27af
  Bug 18403: Use patron-title.inc when hidepatronname is used

Test plan:
- Check an item out
- Go on the moredetail.pl page of this biblio record
Home ? Catalog ? Item details for your biblio
- Confirm that you see:
"Checkout status: Checked out to"
followed by the patron's info

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Followed the test plan and it works.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 17:02:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 15:02:44 +0000
Subject: [Koha-bugs] [Bug 20948] Hold requests on detail.pl
In-Reply-To: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20948-70-ExvmJ5Xtni@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Does it concern 17.05 only?

I do not understand what you are referring to on master, can you provide
screenshots?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 17:11:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 15:11:18 +0000
Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout
 form, with collapsed settings panel
In-Reply-To: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20959-70-1M60URzoEv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 17:11:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 15:11:21 +0000
Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout
 form, with collapsed settings panel
In-Reply-To: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20959-70-LCPHDvcgNl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76139&action=edit
Bug 20959: Style checkin form more like the checkout form, with collapsed
settings panel

This patch modifies the structure of the checkin form so that settings
(Specify return date, book drop mode, forgive overdue charges) are in a
collapsed panel when inactive. The style of the barcode field and the
mode notification messages has been changed to reduce the vertical
motion of the form when selecting options.

Some class names have been changed in circulation.tt and circulation.js
to make them appropriate for use on both forms.

To test, apply the patch and clear your browser cache if necessary.

 - View the checkin page. The "checkin settings" panel should be
   collapsed by default.
 - Confirm that the settings panel collapses and expands as it should.
 - Confirm that selecting "Forgive overdue charges" or "Book drop mode"
   trigger the display of the correct message and that the style of the
   barcode field is changed.
 - Confirm that after submitting a barcode for check-in, the
   settings panel stays open and your selected settings are still
   selected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 17:24:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 15:24:27 +0000
Subject: [Koha-bugs] [Bug 20934] Biblio checkout history shows only current
	checkout
In-Reply-To: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20934-70-dqXG1c9veW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 17:33:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 15:33:40 +0000
Subject: [Koha-bugs] [Bug 20698] Remove obsolete template: transfer-slip.tt
In-Reply-To: <bug-20698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20698-70-pqQLx8KFRb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20698

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 17:33:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 15:33:43 +0000
Subject: [Koha-bugs] [Bug 20698] Remove obsolete template: transfer-slip.tt
In-Reply-To: <bug-20698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20698-70-6SHIkz0bXJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20698

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76140&action=edit
Bug 20698 - Remove obsolete template: transfer-slip.tt

This patch removes an unused template file, circ/transfer-slip.tt. Its
use was removed by Bug 7001:

http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a9ded4fa008668df8c485fbbc76efa3cc9cc00d7#patch12

To test, apply the patch and confirm that the file has been removed.
Confirm that no references to the template exist in the codebase.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 17:41:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 15:41:45 +0000
Subject: [Koha-bugs] [Bug 20953] Discharge can be requested several times on
	OPAC
In-Reply-To: <bug-20953-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20953-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20953-70-OSVAqu611W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at univ-lyon3.fr
             Status|Needs Signoff               |Failed QA

--- Comment #3 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Hello,
Tested on a sandbobx (biblibre sandbox n?1)
At step n?11, there's an error when clicking on "allow" :

Software error:
Undefined subroutine &Koha::Patron::Debarments::AddDebarment called at
/home/koha/src/Koha/Patron/Discharge.pm line 85.
For help, please send mail to the webmaster ([no address given]), giving this
error message and the time and date of the error.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 17:53:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 15:53:14 +0000
Subject: [Koha-bugs] [Bug 20934] Biblio checkout history shows only current
	checkout
In-Reply-To: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20934-70-HLRciPAjH0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 17:53:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 15:53:17 +0000
Subject: [Koha-bugs] [Bug 20934] Biblio checkout history shows only current
	checkout
In-Reply-To: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20934-70-V26wYDkXvQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76104|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76141&action=edit
Bug 20934: Fix display of old checkouts in the checkout history page

Again a regression caused by
  commit fa54100dffe092e606f79b15692eedaf78f42e45
  Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for
issuehistory]

GetBiblioIssues does a union all with issues and old_issues, so we
should old_issues as well.
To make the join on the items table we need to define the item and
patron methods. For consistency the relationships have been redefined
(item instead of itemnumber, borrower instead of borrowernumber) in the
DBIx::Class definition.

This is not perfect but I think the best way to provide an easy to
backport patch.

It highlights that we need improvements in this area.

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
The patch works as expected.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 17:53:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 15:53:21 +0000
Subject: [Koha-bugs] [Bug 20934] Biblio checkout history shows only current
	checkout
In-Reply-To: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20934-70-syWlEVytUC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76142&action=edit
Bug 20934: (QA follow-up) Fix pod in Koha::Old::Checkout

Test plan:
Run qa tools - it shouldn't complain about pod levels

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 17:53:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 15:53:24 +0000
Subject: [Koha-bugs] [Bug 20934] Biblio checkout history shows only current
	checkout
In-Reply-To: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20934-70-5CrJySwyq9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76143
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76143&action=edit
Bug 20934: (QA follow-up) Fix showing number of records in checkout history

Test plan:
0) Do not apply this patch
1) Go to biblio checkout history page (issuehistory.pl)
2) You'll see something like "Checked out ARRAY(0xf830378) times"
3) Apply this patch
4) Now you should see number of checkout history records

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 17:55:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 15:55:45 +0000
Subject: [Koha-bugs] [Bug 20934] Biblio checkout history shows only current
	checkout
In-Reply-To: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20934-70-CUUGoDjKjO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934

--- Comment #6 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Jonathan Druart from comment #1)
> 
> This is not perfect but I think the best way to provide an easy to
> backport patch.
> 
> It highlights that we need improvements in this area.

Maybe not perfect, but fixing the bug ;) Hope some thing will be fixed during
merging issues and oldissues in future...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 18:00:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 16:00:42 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11897-70-0e2TrTpL7Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #261 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 76144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76144&action=edit
Bug 11897: (follow-up) Default to 'replyto' and fallback on 'from'

In recent koha's, branchemail isn't necessarily an email address the
branch has access to. Reply-to however should always be accessible and
as such this patch uses that in preference to 'From'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 18:38:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 16:38:03 +0000
Subject: [Koha-bugs] [Bug 20948] Hold requests on detail.pl
In-Reply-To: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20948-70-DIalwx26n1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948

--- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> ---
Created attachment 76145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76145&action=edit
Misleading Hold Info

Screenshot of misleading hold.  Shows the only item-level hold in the 35
current holds.  This is not who the item will be going to when checked in. 
Would prefer to not show this information if it is meaningless to us.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 19:11:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 17:11:58 +0000
Subject: [Koha-bugs] [Bug 20948] Hold requests on detail.pl
In-Reply-To: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20948-70-fSgG353Mjc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948

--- Comment #3 from Christopher Brannon <cbrannon at cdalibrary.org> ---
I realize that it may be impossible to display next available holds, but if
there are next available holds and local hold priorities, I fail to see how
showing the next item level hold helps.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 19:36:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 17:36:48 +0000
Subject: [Koha-bugs] [Bug 20960] New: System preference
 'automatic_item_modification_by_age_configuration' does not appear in staff
 client.
Message-ID: <bug-20960-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20960

            Bug ID: 20960
           Summary: System preference
                    'automatic_item_modification_by_age_configuration'
                    does not appear in staff client.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

The system preference 'automatic_item_modification_by_age_configuration', used
in  misc/cronjobs/automatic_item_modification_by_age.pl, does not show in a
system preference search.

I think this is because it's missing from 

./koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/*.pref

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 20:28:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 18:28:33 +0000
Subject: [Koha-bugs] [Bug 20943] Cannot enable shibboleth and LDAP at the
	same time
In-Reply-To: <bug-20943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20943-70-Ud3Y5lBsk6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20943

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Interesting. Has that changed in recent versions? We have a library using
Shibboleth and LDAP with 16.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 20:38:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 18:38:36 +0000
Subject: [Koha-bugs] [Bug 17869] Don't show pick-up library for list of
 holds in OPAC account when there is only one branch
In-Reply-To: <bug-17869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17869-70-KRtItfgs5J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76146&action=edit
Bug 17869: Don't show pick-up library for list of holds in OPAC account when
there is only one branch

This patch modifies the user summary page in the OPAC so that the
"pick up location" column isn't shown in the table of holds if there is
only one library defined.

To test, apply the patch and log into the OPAC as a user with one or
more holds.

 - In a system with more than one library defined the "Holds" tab of
   opac-user.pl should show a "Pick up location" column.

 - In a system with only one library defined there should be now "Pick
   up location" column.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 20:38:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 18:38:32 +0000
Subject: [Koha-bugs] [Bug 17869] Don't show pick-up library for list of
 holds in OPAC account when there is only one branch
In-Reply-To: <bug-17869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17869-70-0lJ59wAnXR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 20:48:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 18:48:27 +0000
Subject: [Koha-bugs] [Bug 20259] Shorter JS and CSS rewrite rule
In-Reply-To: <bug-20259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20259-70-7nYpKvOXaU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 20:48:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 18:48:32 +0000
Subject: [Koha-bugs] [Bug 20259] Shorter JS and CSS rewrite rule
In-Reply-To: <bug-20259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20259-70-0MpAmQQXbJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76111|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76147&action=edit
Bug 20259: Shorter JS and CSS rewrite rule

Bug 20187 has changed the JS and CSS rewrite rules to :
RewriteRule ^(.*)_[0-9][0-9]\.[0-9][0-9][0-9][0-9][0-9][0-9][0-9].js$ $1.js [L]
RewriteRule ^(.*)_[0-9][0-9]\.[0-9][0-9][0-9][0-9][0-9][0-9][0-9].css$ $1.css
[L]

This patch changes this rules using [0-9]{N} and fusion in one rule.
And espaces the dot in extension js and css.

Test plan :
1) Go to intranet and opac
2) Check CSS and JS are doing well
3) Apply patch changes on our Apache configuration
4) Reload intranet and opac pages (Ctrl + F5)
5) Check CSS and JS are doing well

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 20:54:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 18:54:14 +0000
Subject: [Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong
	content type
In-Reply-To: <bug-16111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16111-70-cAUvBU3ASE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49629|0                           |1
        is obsolete|                            |

--- Comment #16 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76148&action=edit
Bug 16111 [Revised] RSS feed for OPAC search results has wrong content type

This patch fixing handling of OPAC search results feeds by correcting
parameters passed to the script and making format checks consistent in
the script.

This patch also removes altogether references to a separate "atom"
formatted feed, because the template for that feed displays no content
(and never has).

To test, apply the patch and perform a search in the OPAC.

- Click the RSS link and confirm that the browser displays a feed with
  no errors. In Chrome the feed should display a "document tree" view.
- Using the browser's developer console, verify that the content-type of
  the document is defined as "text/xml."
- Validate the resulting feed at https://validator.w3.org/feed/ and
  confirm that it is valid.

Revision adds suggestion from QA to accept the old 'rss2' parameter and
treat it like an 'rss' parameter. Also changed: Corrected another place
where 'rss2' was used in the template.

Signed-off-by: Magnus Enger <magnus at librietech.no>
Before the patch:
- RSS is served with content-type text/html
- The link from the RSS icon ona search page looks like
  opac-search.pl?idx=kw&q=perl&count=50&sort_by=acqdate_dsc&format=rss2

After applying the patch:
- RSS is served as text/xml
- The RSS link leads to
  opac-search.pl?idx=kw&q=perl&count=50&sort_by=acqdate_dsc&format=rss
  But the old link with format=rss2 still works

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 20:54:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 18:54:10 +0000
Subject: [Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong
	content type
In-Reply-To: <bug-16111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16111-70-m4Ts03kwkW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 21:07:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 19:07:36 +0000
Subject: [Koha-bugs] [Bug 15315] Non-XSLT detail view still uses Greybox for
	MARC preview
In-Reply-To: <bug-15315-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15315-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15315-70-surWaH3MZ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15315

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 21:07:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 19:07:36 +0000
Subject: [Koha-bugs] [Bug 8290] Replace usage of Greybox modals with
	Bootstrap modals
In-Reply-To: <bug-8290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8290-70-qpaiInCvVy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290
Bug 8290 depends on bug 15315, which changed state.

Bug 15315 Summary: Non-XSLT detail view still uses Greybox for MARC preview
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15315

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 21:09:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 19:09:04 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-PWrxGL6W7b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #236 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Is there a plan to avoid never-ending rebases?


(In reply to Alex Arnaud from comment #194)
> > Comment 164 - How can we open issue on http://git.biblibre.com/biblibre/koha-mana
> We plan to move Mana server sources on Koha community repository
> 
> > Comment 164 - I'd like a more complete README to run the server and the tests.
> http://git.biblibre.com/biblibre/koha-mana/blob/master/README.md. Need to be
> completed

What about these two points?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 21:10:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 19:10:27 +0000
Subject: [Koha-bugs] [Bug 18236] Add classes to material type icons on
 result lists and detail pages
In-Reply-To: <bug-18236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18236-70-yP67U6RhuG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70571|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 21:21:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 19:21:45 +0000
Subject: [Koha-bugs] [Bug 20933] Modifying the Advanced Prediction Pattern
	in Serials
In-Reply-To: <bug-20933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20933-70-lF96a1vgEc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20933

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 21:26:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 19:26:50 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19817-70-iFBBntM7Dv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #72 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Caroline Cyr La Rose from comment #71)
> I had a bit of trouble applying the patch. I had to add member-flags.tt and
> then continue applying the patch. I don't know if that's normal or not.

Yes, conflict. I am going to re-attached a rebased version of these patches.

> I went to Global system preferences and clicked on the tab for circulation.
> When I clicked help, the manual was at the beginning of the sysprefs
> section. I don't know if it's possible at all to point to the right
> sub-section? It's just that are sooooo many system preferences...

It should be the same behaviour as prior to the patch. We can imagine a link
close to each pref to point to the dedicated section of the manual.
TODO later ;)

> My KohaManualLanguage is on Arabic by default. I'm guessing it's the first
> language in the list, but if I don't change it will this be the default?
> Should we put English by default instead of Arabic?

I guess you did not execute the updatedatabase.pl script. The default value is
"en".

> I also don't see the edit button mentioned in comment 7. Was that
> implemented or just an idea for a future development? It could be a second
> patch. People don't currently have the ability to modify from the staff
> interface, so it wouldn't necessarily be a step back. More advanced users
> can still use their own help files.

The original plan was to provide a full help system, local editing (on top of
git repository), etc.
I have asked several time on the mailing lists and during IRC meetings to get
feedbacks and ideas. I did not get answers and I am no longer willing to
provide such enhancements. Maybe later...

> I wasn't able to test switching languages because my master is only
> installed in English.

You can install a couple with:
  sudo koha-translate --install fr-CA --dev kohadev
  sudo koha-translate --install it-IT --dev kohadev

> It's a great development! It will be much easier to translate, no need to
> translate the help file, just the manual. It will also be more uniform.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 21:26:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 19:26:52 +0000
Subject: [Koha-bugs] [Bug 18236] Add classes to material type icons on
 result lists and detail pages
In-Reply-To: <bug-18236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18236-70-4mlrCMfJod@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 21:26:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 19:26:55 +0000
Subject: [Koha-bugs] [Bug 18236] Add classes to material type icons on
 result lists and detail pages
In-Reply-To: <bug-18236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18236-70-PbMsXwsuaY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70571|0                           |1
        is obsolete|                            |
  Attachment #70653|0                           |1
        is obsolete|                            |

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76149&action=edit
Bug-18236: Add classes to material type

Test plan:
1. Open a list of results
2. Use fn+f12 to inspect element
3. Without patch it should show that the image class is 'materialtype'
4. With patch the class should have changed
-Books = mt_icon_book
-Kit = mt_icon_kit
-Continuous resource = mt_icon_cresource
-Mixed material = mixmaterial
-Computer files = mt_icon_computer
-Map = mt_icon_map
-Score = mt_icon_score
-Music = mt_icon_music
OR
1. Try using the classes in css to change the style

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 21:26:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 19:26:58 +0000
Subject: [Koha-bugs] [Bug 18236] Add classes to material type icons on
 result lists and detail pages
In-Reply-To: <bug-18236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18236-70-747DKZvLXu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76150&action=edit
Bug-18236: Add classes to material type

Test plan:
-Following the test plan above, the class should still have
'materialtype' but also the new class:
    Books = mt_icon_BK
    Kit = mt_icon_MX
    Article = mt_icon_AR
    Mixed material = mt_icon_MX
    Computer files = mt_icon_CF
    Map = mt_icon_MP
    Music = mt_icon_MU
    Sound = mt_icon_MU
    Score = mt_icon_PR
    Visual material = mt_icon_VM

-When viewing the details of a record, the material type img should also have
the
same changes
-Check that the material type classes in the results page is the same as
the details page

Notes
-The class names have changed from the previous patch in accordance to
$materialTypeCode in MARC21slim2intranetDetail.xsl

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 21:27:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 19:27:26 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19817-70-WrxS7dgjVL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75370|0                           |1
        is obsolete|                            |
  Attachment #75371|0                           |1
        is obsolete|                            |
  Attachment #75372|0                           |1
        is obsolete|                            |
  Attachment #75373|0                           |1
        is obsolete|                            |
  Attachment #75374|0                           |1
        is obsolete|                            |
  Attachment #75375|0                           |1
        is obsolete|                            |
  Attachment #75376|0                           |1
        is obsolete|                            |
  Attachment #75377|0                           |1
        is obsolete|                            |

--- Comment #73 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76151&action=edit
Bug 19817: Redirect to the online manual

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 21:27:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 19:27:31 +0000
Subject: [Koha-bugs] [Bug 18236] Add classes to material type icons on
 result lists and detail pages
In-Reply-To: <bug-18236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18236-70-2OTl2YIrLi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |jwayway at hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 21:27:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 19:27:33 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19817-70-8bPCQJHSLS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #74 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76152&action=edit
Bug 19817: Remove local help files + edit help feature

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 21:27:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 19:27:38 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19817-70-mnyMCgXNla@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #75 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76153&action=edit
Bug 19817: Make the location of the manual configurable - KohaManualBaseURL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 21:27:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 19:27:44 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19817-70-6AkapgaqhA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #76 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76154&action=edit
Bug 19817: Move code to Koha::Manual to make it testable and reusable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 21:27:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 19:27:49 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19817-70-DXayBJfPMx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #77 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76155&action=edit
Bug 19817: Add pref KohaManualLanguage

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 21:27:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 19:27:55 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19817-70-4C92G8VO6R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #78 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76156&action=edit
Bug 19817: Open the manual in a new window, not a popup

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 21:28:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 19:28:00 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19817-70-w49KHgoFuu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #79 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76157&action=edit
Bug 19817: Use the language from the interface if valid

Use the UI language for the manual, if exists. Use the pref as a
fallback.

With the call to get_template_and_user the value of preferred_language
switched from 'es' (spanish) to 'en' from one click to another (??)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 21:28:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 19:28:05 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19817-70-5K9M8wcM4b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #80 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76158&action=edit
Bug 19817: use https instead of http

the https version was not working when I wrote the first patches

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 21:42:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 19:42:02 +0000
Subject: [Koha-bugs] [Bug 7867] Use consistent terminology for username and
	password
In-Reply-To: <bug-7867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7867-70-rBImQPthAc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org
            Summary|Staff and OPAC areas lack   |Use consistent terminology
                   |consistency                 |for username and password

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 22:09:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 20:09:27 +0000
Subject: [Koha-bugs] [Bug 20220] Move template JavaScript to the footer:
	Holds
In-Reply-To: <bug-20220-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20220-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20220-70-xH5nZ4Ml0z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20220

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 22:09:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 20:09:31 +0000
Subject: [Koha-bugs] [Bug 20220] Move template JavaScript to the footer:
	Holds
In-Reply-To: <bug-20220-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20220-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20220-70-l81nOSQHcz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20220

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75257|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76159&action=edit
Bug 20220: Move template JavaScript to the footer: Holds

This patch modifies the holds template so that JavaScript is included in
the footer.

To test, apply the patch and initiate the process of placing a hold.
Throughout the process JavaScript-based interactions should work: Patron
autocomplete, datepickers, DataTables, cancel confirmations, etc.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 22:31:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 20:31:07 +0000
Subject: [Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong
	content type
In-Reply-To: <bug-16111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16111-70-eBmG36cl4i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I am sorry but we are doing something very wrong here.
The POC patch shows that it is very easy to support atom, whereas the "Revised"
patch is removing all this code.

I would suggest to:
1. Fix the content type for rss
2. Fix the rss2 vs rss and keep support for rss2
3. Add the support for atom

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 22:36:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 20:36:49 +0000
Subject: [Koha-bugs] [Bug 20960] System preference
 'automatic_item_modification_by_age_configuration' does not appear in staff
 client.
In-Reply-To: <bug-20960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20960-70-1vhNKoGBot@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20960

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It's a tool, not a system preference.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 22:41:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 20:41:05 +0000
Subject: [Koha-bugs] [Bug 20960] System preference
 'automatic_item_modification_by_age_configuration' does not appear in staff
 client.
In-Reply-To: <bug-20960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20960-70-shGSbBCNut@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20960

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Should explain that a little more, the configuration is set in its own tool and
then added to the systempreferences table for storage. Once you have set the
first rule, it will appear on the 'local use' tab. This is a trick similar to
the one used by the 'did you see' feature. It's intentional it's not showing up
in search as you are not supposed to edit the rules by hand.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 22:43:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 20:43:07 +0000
Subject: [Koha-bugs] [Bug 20956] BorrowersLog is not logging permission
	changes
In-Reply-To: <bug-20956-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20956-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20956-70-pp7PRF2klf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20813
           Severity|major                       |enhancement
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I agree with both Christopher and Jonathan. We never logged permissions and
this has never come up before, so I would also classify this as an enhancement.
But at the same time I think it would be a very good and valuable addition.
Currently there is some work done on permissions, we might want to wait for bug
20813 before implementing this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 22:43:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 20:43:07 +0000
Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system
In-Reply-To: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20813-70-olBCZCLiuA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20956

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 22:44:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 20:44:59 +0000
Subject: [Koha-bugs] [Bug 20951] Koha::Patron::Discharge is missing use
 Koha::Patron::Debarments
In-Reply-To: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20951-70-gmU32cnfRr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Keywords|                            |rel_18_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 22:51:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 20:51:39 +0000
Subject: [Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong
	content type
In-Reply-To: <bug-16111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16111-70-lGCNxdvD6W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76161&action=edit
Bug 16111: Fix atom support

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 22:51:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 20:51:45 +0000
Subject: [Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong
	content type
In-Reply-To: <bug-16111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16111-70-c0Xyly7XX9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76162&action=edit
Bug 16111: Remove 'rss2' which should be 'rss' or 'atom'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 22:51:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 20:51:33 +0000
Subject: [Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong
	content type
In-Reply-To: <bug-16111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16111-70-u2laUqiLSF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49837|0                           |1
        is obsolete|                            |

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76160&action=edit
Bug 16111: Fix content type for RSS feed

Test plan:
GET
http://catalogue/cgi-bin/koha/opac-search.pl?idx=kw&q=perl&count=50&sort_by=acqdate_dsc&format=rss2

=> Without this patch it returns content type text/html
=> With this patch it returns text/xml

GET
http://catalogue/cgi-bin/koha/opac-search.pl?idx=kw&q=perl&count=50&sort_by=acqdate_dsc&format=rss
=> Without this patch it does not work
=> With this patch it returns text/xml

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 22:53:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 20:53:20 +0000
Subject: [Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong
	content type
In-Reply-To: <bug-16111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16111-70-bm6LR89DEJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Do whatever you want, but my opinion would be to not remove code that could be
fixed easily. To fix the original issue, it's a 3-lines patch ( Bug 16111: Fix
content type for RSS feed ).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 22:53:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 20:53:31 +0000
Subject: [Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong
	content type
In-Reply-To: <bug-16111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16111-70-E1J3yHVtTF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 22:56:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 20:56:33 +0000
Subject: [Koha-bugs] [Bug 20460] Staff can only change password through the
 change password button if patron hits failedloginattempts
In-Reply-To: <bug-20460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20460-70-9voJvpQ7Hp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20460

--- Comment #1 from Agnes Rivers-Moore <arm at hanover.ca> ---
I agree, staff need both the information that it's locked, and also need a
reminder to use the Change Password button - at least until that is fixed.
Why does edit - change password not work? Is this intended behaviour?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 23:05:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 21:05:06 +0000
Subject: [Koha-bugs] [Bug 19709] Move template JavaScript to the footer:
	Labels
In-Reply-To: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19709-70-HtdoOsfDuW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75253|0                           |1
        is obsolete|                            |

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76163&action=edit
Bug 19709: Move template JavaScript to the footer: Labels

This patch modifies the staff client label creator templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

This patch also modifies the templates to use the Bootstrap grid instead
of YUI, and removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and test the following interactions:

- Creating and managing layouts
- Creating and managing batches
- Creating and managing templates
- Creating and managing printer profiles
- Creating quick spine labels

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 23:05:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 21:05:35 +0000
Subject: [Koha-bugs] [Bug 20641] Switch single-column templates to Bootstrap
 grid: Various, part 2
In-Reply-To: <bug-20641-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20641-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20641-70-BUT6nTmvTy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20641

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75832|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76164
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76164&action=edit
Bug 20641: Switch single-column templates to Bootstrap grid: Various, part 2

This patch updates various unrelated templates to use the Bootstrap
grid. In each case, confirm that the indicated page looks correct.

 - Acquisitions -> Vendor -> Add to basket -> From a staged file.
 - Logged-in user menu (in the upper right) -> Search history.
 - With plugins disabled in koha-conf.xml, go to Tools -> Tools plugins.
 - With the EasyAnalyticalRecords system preference set to 'Display,'
   view a bibliographic record.
   - Choose Edit -> Link to host item.
   - Submit a barcode to be linked.
 - Configure a MARC subfield (e.g. 100$a) to use the
   unimarc_field_225a_bis plugin.
   From the MARC edit page, trigger the plugin and confirm that the
   page in the popup window looks correct. Confirm that changes made in
   the popup window are saved to the corresponding field in the editor.
 - Administration -> Funds -> Edit a fund.
   - Click 'Select owner.'
   - Search for a patron.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 23:05:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 21:05:43 +0000
Subject: [Koha-bugs] [Bug 19709] Move template JavaScript to the footer:
	Labels
In-Reply-To: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19709-70-KJmKgEGQCN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 23:05:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 21:05:53 +0000
Subject: [Koha-bugs] [Bug 20641] Switch single-column templates to Bootstrap
 grid: Various, part 2
In-Reply-To: <bug-20641-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20641-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20641-70-T9ZmINtOvX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20641

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 23:17:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 21:17:11 +0000
Subject: [Koha-bugs] [Bug 20650] Switch single-column templates to Bootstrap
 grid: Various, part 3
In-Reply-To: <bug-20650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20650-70-LgQlzJckOI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20650

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Owen, I think doc-head-open is missing from patroncards/print.tt, could you
confirm?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 23:19:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 21:19:49 +0000
Subject: [Koha-bugs] [Bug 20924] News content textarea not showing
In-Reply-To: <bug-20924-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20924-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20924-70-AZYxTQGSvY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20924

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|blocker                     |normal

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Lowering severity, waiting for Aleisha's answer.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 23:29:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 21:29:56 +0000
Subject: [Koha-bugs] [Bug 20951] Koha::Patron::Discharge is missing use
 Koha::Patron::Debarments
In-Reply-To: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20951-70-mFEDJA0vyh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I can't reproduce the problem. I have tried discharging from the patron account
as well as discharging using the link from the dashboard and the 'allow'
button.

Similar to bug 20851?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 23:37:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 21:37:06 +0000
Subject: [Koha-bugs] [Bug 20945] Report params not escaped when downloading
In-Reply-To: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20945-70-w4RFVL8JMM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I've been testing with the following SQL:

select * from borrowers where firstname like <<TEST|Asort1>> and surname like
<<surname>>

Asort1 has a % in my test. But I can download fine in all formats and the URL
looks like this:

cgi-bin/koha/reports/guided_reports.pl?reports=2&phase=Run+this+report&param_name=TEST|Asort1&sql_params=%25&param_name=surname&sql_params=%25

Can you explain more about the problem? What am I missing?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 23:42:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 21:42:58 +0000
Subject: [Koha-bugs] [Bug 20931] JS error "ReferenceError: $ is not defined"
 when CircSidebar is turned on
In-Reply-To: <bug-20931-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20931-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20931-70-mj9B8abVwu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20931

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I can confirm the error, but haven't been able to locate the mistake in the
code yet. Only thing I notice is some errors from the validator - 2 stay </div>
tags.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 23:44:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 21:44:13 +0000
Subject: [Koha-bugs] [Bug 20931] JS error "ReferenceError: $ is not defined"
 when CircSidebar is turned on
In-Reply-To: <bug-20931-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20931-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20931-70-F9bEZX0OJ3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20931

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oleonard at myacpl.org

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Ah, I think the JavaScript for navbar needs to be moved to the bottom.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 23:45:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 21:45:34 +0000
Subject: [Koha-bugs] [Bug 20925] Changing font color for pipes between list
 items in #moresearch
In-Reply-To: <bug-20925-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20925-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20925-70-cpONHK0RkP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20925

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 20926 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 23:45:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 21:45:34 +0000
Subject: [Koha-bugs] [Bug 20926] Changing font color for pipes between list
 items in #moresearch
In-Reply-To: <bug-20926-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20926-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20926-70-EcVJESoMfI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20926

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 20925 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 23:46:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 21:46:19 +0000
Subject: [Koha-bugs] [Bug 20925] Changing font color for pipes between list
 items in #moresearch
In-Reply-To: <bug-20925-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20925-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20925-70-Fa6BiawByO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20925

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Kyle, I don't understand this one, can you please explain?
Why not use CSS if this is just about changing color on something?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 23:50:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 21:50:27 +0000
Subject: [Koha-bugs] [Bug 20925] Changing font color for pipes between list
 items in #moresearch
In-Reply-To: <bug-20925-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20925-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20925-70-Y0Fp3oY9oi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20925

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|NEW                         |RESOLVED

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Actually, you can already change the color with CSS. Here are the relevant
statements:

#moresearches li::after {
    content: " | ";
    color: red;
}

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 18 23:53:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 21:53:43 +0000
Subject: [Koha-bugs] [Bug 20921] Expose borrowernumber and branch when user
 is logged in to OPAC
In-Reply-To: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20921-70-wRSdiBov4c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It's a class in the <body> tag:

<body ID="advsearch" class="branch-CPL scrollto" >

branch-CPL represents the branch of the currently logged in user. 

Maybe it would be cleaner to also add the borrowernumber there? Also the use of
custom attributes appears strange to me - why use class for the username but
then 2 attributes?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 00:00:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 22:00:58 +0000
Subject: [Koha-bugs] [Bug 20889] Items marked as not for loan can be checked
	out
In-Reply-To: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20889-70-ZdJVgfL3Xj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20889

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There still seems something off - if the user has a restriction and you use the
'temporary override' you can check out the item still. Even when
AllowNotForLoanOverride doesn't allow that. Separate bug?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 00:03:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 22:03:02 +0000
Subject: [Koha-bugs] [Bug 20896] Move Serial enumeration to the right of
	callnumber
In-Reply-To: <bug-20896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20896-70-eQqIYqiNct@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20896

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 00:04:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 22:04:53 +0000
Subject: [Koha-bugs] [Bug 20893] batchRebuildItemsTables.pl has incorrect
	parameter
In-Reply-To: <bug-20893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20893-70-jRVsODw26t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20893

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 00:04:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 22:04:57 +0000
Subject: [Koha-bugs] [Bug 20893] batchRebuildItemsTables.pl has incorrect
	parameter
In-Reply-To: <bug-20893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20893-70-F5EIwTPg1d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20893

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75882|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 76165
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76165&action=edit
Bug 20893: batchRebuildItemsTables.pl has incorrect parameter

To test:
1 - run batchRebuildItemsTables.pl with a valid biblionumber
   perl /usr/share/koha/bin/batchRebuildItemsTables.pl --where
biblio.biblionumber=38483  -c
2 - Note it says 'undefined biblionumber
3 - Apply patch
4 - Do it again
5 - It works!

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 00:06:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 22:06:32 +0000
Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used
 in the description
In-Reply-To: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20891-70-lCM4xeiTic@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think we had similar problems on patron search - anything we could pick from
there?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 00:07:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 22:07:55 +0000
Subject: [Koha-bugs] [Bug 20867] Ability to show membership renewal date on
 moremember.pl page
In-Reply-To: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20867-70-3ZcmtywuOc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75824|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 00:11:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 22:11:04 +0000
Subject: [Koha-bugs] [Bug 20867] Ability to show membership renewal date on
 moremember.pl page
In-Reply-To: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20867-70-yQFXT5hPDX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 00:11:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 22:11:08 +0000
Subject: [Koha-bugs] [Bug 20867] Ability to show membership renewal date on
 moremember.pl page
In-Reply-To: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20867-70-x5yNXQ4ovt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76107|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 76166
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76166&action=edit
Bug 20867: Ability to show membership renewal date on moremember.pl page

Test case:
1. Create the patron.
2. Search the patron whose date of membership is about to expire or expired.
3. Click on More->Renew patron.
4. Now membership is renewed.
5. Apply the patch.
6. Reload the page now you will able to see the Membership renewal date.

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Followed the test plan and it works.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 00:24:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 22:24:13 +0000
Subject: [Koha-bugs] [Bug 20956] BorrowersLog is not logging permission
	changes
In-Reply-To: <bug-20956-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20956-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20956-70-NH6u9JdB7g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20813


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813
[Bug 20813] Revamp user permissions system
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 00:24:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 22:24:13 +0000
Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system
In-Reply-To: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20813-70-TZF0vJZJQC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20956


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956
[Bug 20956] BorrowersLog is not logging permission changes
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 00:25:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 22:25:26 +0000
Subject: [Koha-bugs] [Bug 20956] BorrowersLog is not logging permission
	changes
In-Reply-To: <bug-20956-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20956-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20956-70-6FCKBy9jQN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956

--- Comment #3 from Christopher Brannon <cbrannon at cdalibrary.org> ---
I'm fine with waiting.  Added dependency.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 01:03:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jun 2018 23:03:39 +0000
Subject: [Koha-bugs] [Bug 20961] New: cn_sort for DDC callnumbers should
 between 1 and 99 should be formatted as 001.* - 099.*
Message-ID: <bug-20961-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20961

            Bug ID: 20961
           Summary: cn_sort for DDC callnumbers should between 1 and 99
                    should be formatted as 001.* - 099.*
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

The documentation for C4::ClassSortRoutine::GetClassSortKey says

* Concatenates class and item part.
* Converts to uppercase.
* Removes leading and trailing whitespace and '/'
* Separates alphabetic prefix from the rest of the call number
* Splits into tokens on whitespaces and periods.
* Leaves first digit group as is.
...

9.1 => 9_100000000000000
80.1 => 80_100000000000000
700.1 => 700_100000000000000

when sorted ascending by cn_sort are

700.1 => 700_100000000000000
80.1 =>  80_100000000000000
9.1 => 9_100000000000000

however, DDC classes are formatted

000 ? Computer science, information & general works
100 ? Philosophy and psychology
200 ? Religion
300 ? Social sciences
400 ? Language
500 ? Pure Science
600 ? Technology
700 ? Arts & recreation
800 ? Literature
900 ? History & geography

000 is sub-divided into the hundreds group

000 Computer science, knowledge & systems
010 Bibliographies
020 Library & information sciences
...

and sub-sub-divided into the thousands groups...

000 Computer science, information & general works
001 Knowledge
002 The book
003 Systems
...

As such, '* Leaves first digit group as is.', should read

* the first digit group should be 3 characters wide, 0-padded

I.e. the  value of cn_sort for callnumber 1.1 should be 001_100000000000000,

so that the examples above sort

009_100000000000000
080_100000000000000
700_100000000000000

See discussion here:
http://lists.koha-community.org/pipermail/koha-devel/2018-June/044623.html

And the summary of DDC 23 here:

https://www.oclc.org/content/dam/oclc/dewey/DDC%2023_Summaries.pdf

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 02:10:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 00:10:12 +0000
Subject: [Koha-bugs] [Bug 18674] Show timezone for Perl and MySQL on the
	About Koha page
In-Reply-To: <bug-18674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18674-70-5cvmaW2EcN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674

--- Comment #18 from David Cook <dcook at prosentient.com.au> ---
(In reply to Tom?s Cohen Arazi from comment #17)
> (In reply to David Cook from comment #16)
> > It's a shame this isn't backported to at least 17.05, since 17.05 and 17.11
> > don't have an easy way of verifying TZ settings.
> 
> This one needs some work to be suitable for the old stable releases. You
> better talk to the release maintainers. If you need it.

In that case, I'd say reverting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18299 for 17.05 and
17.11 might be a better idea.

I ended up just copying admin/env_tz_test.pl from an older version of Koha and
ran that instead for the setup of the timezone and then deleted it again.

I imagine anyone who needs to check for 17.05 and 17.11 would just do the same
thing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 02:37:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 00:37:10 +0000
Subject: [Koha-bugs] [Bug 20528] Remove the items tab from the detailed
 bibliographic view
In-Reply-To: <bug-20528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20528-70-5HLEWUcJai@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20528

Hugh Rundle <hughr at brimbank.vic.gov.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hughr at brimbank.vic.gov.au

--- Comment #14 from Hugh Rundle <hughr at brimbank.vic.gov.au> ---
The functionality in the items tab is definitely not redundant.

However, it *is* pretty confusing that clicking on the barcode and clicking on
'edit item' take you to two completely different places.

It feels like 'click on barcode' is supposed to take the user to somewhere
useful for circ changes (e.g. changing a item statuses) and clicking on 'edit'
is more designed for cataloguing changes (e.g. updating a call number).
However, this isn't actually consistent: you can't change a Not-For-Loan status
in "Items", for example, which doesn't seem to be very logical.

So I don't have a big problem with removing the tab, as long as there is no
loss of *ease*, and the functional separation between "things circ staff might
need to update" and "things cataloguing staff might need to update" is still
there: i.e. forcing everyone to go into the cataloguing module to update an
item status would be bad, not least because it means all circ staff would need
access to cataloguing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 07:05:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 05:05:39 +0000
Subject: [Koha-bugs] [Bug 20962] New: Overhaul to notices
Message-ID: <bug-20962-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20962

            Bug ID: 20962
           Summary: Overhaul to notices
 Change sponsored?: Sponsored
           Product: Koha
           Version: unspecified
          Hardware: All
               URL: https://wiki.koha-community.org/wiki/Notices_Overhaul_
                    RFC
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: hughr at brimbank.vic.gov.au
        QA Contact: testopia at bugs.koha-community.org
          Deadline: 2018-11-01

Currently notices are run using effectively two separate systems. Overdue
notices run using their own cron job, whilst everything else is either queued
by the advance_notices cron or directly added to the message queue.
Additionally, print overdues are treated differently to other overdues. This
means the options available for print overdues considerably lag those available
for other notice types, and there are confusing discrepencies between overdues,
other notices, and print overdues and everything else.

Note that this enhancement is primarily aimed at modernising the way paper
(postal) notices are managed, but as part of that it moves overdues under the
same structure as other notices.

# Step 1 - Move Overdues into member messaging preferences
This should allow patrons (or staff on behalf of patrons) to:

  1. Select one or more notification methods (SMS, email etc)
  2. Choose not to be notified about Overdues at all
  3. Choose to receive a digest for overdues

# Step 2 - Enable 'postal' as a specific option rather than simply a
fallback,for all notice types

# Step 3 - option to process all print notices together

# Step 4 - extend <item> tags to other circulation notices

# Step 5 - Allow for 'digesting' of all notices in queue regardless of type

# Step 6 - Allow circulation notices to be created for any item status change

More detail is provided in the RFC - once we have community feedback the
details may change slightly.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 07:23:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 05:23:13 +0000
Subject: [Koha-bugs] [Bug 20953] Discharge can be requested several times on
	OPAC
In-Reply-To: <bug-20953-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20953-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20953-70-iJwNjolLKr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #4 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Koha Team Lyon 3 from comment #3)
> Hello,
> Tested on a sandbobx (biblibre sandbox n?1)
> At step n?11, there's an error when clicking on "allow" :
> 
> Software error:
> Undefined subroutine &Koha::Patron::Debarments::AddDebarment called at
> /home/koha/src/Koha/Patron/Discharge.pm line 85.
> For help, please send mail to the webmaster ([no address given]), giving
> this error message and the time and date of the error.

You need to apply also Bug 20951 to be able to run test plan

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 07:56:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 05:56:05 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-g27bJwqINg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #129 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Apart from the other issues that still need fixing, is there a way we could run
a performance test on this? I know we got libraries around with many years
(10+) of circulation data in these tables. Could this chance cause performance
issues?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 08:06:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 06:06:25 +0000
Subject: [Koha-bugs] [Bug 20962] Overhaul to notices
In-Reply-To: <bug-20962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20962-70-NxtJZPTwmI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20962

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Some comments on this:

>  2. Choose not to be notified about Overdues at all

Please make this optional. I think it would be a problem for libraries here as
I already often have to assure libraries that this is one notice they can't
decide about. The other notices are ok, but overdues especially when connected
with fines are a different thing.

>  3. Choose to receive a digest for overdues

How would a digest option work? The other digests are for emails that would be
send for one item each without the digest option, which we don't do for
overdues right now?

For some of the other enhancements I think it would be good to break them out
into separate bugs. The bigger the patch set, the harder it is to integrate.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 08:15:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 06:15:50 +0000
Subject: [Koha-bugs] [Bug 20951] Koha::Patron::Discharge is missing use
 Koha::Patron::Debarments
In-Reply-To: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20951-70-BT5V5LcVOz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 08:15:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 06:15:54 +0000
Subject: [Koha-bugs] [Bug 20951] Koha::Patron::Discharge is missing use
 Koha::Patron::Debarments
In-Reply-To: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20951-70-SLmf8cJuzV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76093|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 76167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76167&action=edit
Bug 20951: add missing use Koha::Patron::Debarments in Koha::Patron::Discharge

Koha::Patron::Discharge was missing use Koha::Patron::Debarments used in
discharge() method.

Test plan :
1) Enable pref useDischarge
2) Go to OPAC user page
3) Go to 'ask for a discharge' tab
4) Click on 'Ask for a discharge'
5) Go to staff interface : /cgi-bin/koha/members/discharges.pl
6) Click on Allow
=> Without patch you get software error
=> With patch the discharge is validated

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

https://bugs.koha-community.org/show_bug.cgi?id=20953

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 08:21:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 06:21:33 +0000
Subject: [Koha-bugs] [Bug 20962] Overhaul to notices
In-Reply-To: <bug-20962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20962-70-zjoHGjOfqx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20962

Hugh Rundle <hughr at brimbank.vic.gov.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |danield at brimbank.vic.gov.au

--- Comment #2 from Hugh Rundle <hughr at brimbank.vic.gov.au> ---
Thanks Katrin

(In reply to Katrin Fischer from comment #1)
> Some comments on this:
> 
> >  2. Choose not to be notified about Overdues at all
> 
> Please make this optional. 

Do you mean use a syspref to make it optional to allow patrons to choose not to
be notified? I don't have a problem with that, it's just at the moment there is
no option to *allow* patrons to choose not to be notified. I personally think
it's weird that they wouldn't want to get overdue notices, but we have had more
than one request from patrons re this.

> 
> >  3. Choose to receive a digest for overdues
> 
> How would a digest option work? The other digests are for emails that would
> be send for one item each without the digest option, which we don't do for
> overdues right now?

Hmm, you're right, I think I've confused this with digesting the different
levels of notice. e.g. if we have a level 1 overdue at 7 days, then level 2 at
21 days etc, we ideally want to be able to batch those together into different
sections within one notice.


> For some of the other enhancements I think it would be good to break them
> out into separate bugs. The bigger the patch set, the harder it is to
> integrate.

Yes, I agree this should all be separate bugs, but at the moment it's an RFC so
I didn't want to create a mess of bugs that may end up changing a lot.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 08:24:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 06:24:52 +0000
Subject: [Koha-bugs] [Bug 20962] Overhaul to notices
In-Reply-To: <bug-20962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20962-70-HHsMzJEPVF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20962

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Basically a way to not have the overdues notices show up in the configuration
table in the OPAC (and maybe also in staff?). Maybe it could be generalized to
have a multi-select preference for all notices. So libraries not providing
holds can also hide the holds notice etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 08:32:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 06:32:42 +0000
Subject: [Koha-bugs] [Bug 20962] Overhaul to notices
In-Reply-To: <bug-20962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20962-70-Tw6ERTbpo1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20962

--- Comment #4 from Hugh Rundle <hughr at brimbank.vic.gov.au> ---
Ah, I realise what I did re digests.

The important thing here isn't overdues, it's "hold filled" - especially for
print notices. 

At the moment you can't digest hold filled notices, which might make sense for
SMS or email notices that go out immediately, but is a pain for print notices
when a large number of holds become available for the same patron all on the
same day.

There is more detail for this proposal in the RFC - link is at URL listed on
this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 08:59:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 06:59:50 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-tkegG2aYOD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #130 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
That'll be interesting to test.. the db update is certainly going to be painful
at the very least.. it would be good to see if there's anything we could do
about that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 09:50:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 07:50:36 +0000
Subject: [Koha-bugs] [Bug 18655] Unimarc field 210c fails on importing
 fields with a simple quote
In-Reply-To: <bug-18655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18655-70-OQmQRq3s0L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 09:50:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 07:50:39 +0000
Subject: [Koha-bugs] [Bug 18655] Unimarc field 210c fails on importing
 fields with a simple quote
In-Reply-To: <bug-18655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18655-70-bxYesTcsqY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655

--- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 76168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76168&action=edit
Bug 18655: Correct the choose link in unimarc_field_210c value builder

- Link 'choose' is now a button.
- It doesn't call directly javascript anymore (use of listener).
- field to load stored in html on the page (less escaping needed).

Test plan :
1) Use UNIMARC catalog
2) Define unimarc_field_210c value builder on 210$c
3) Define an autority type EDITORS with heading on 200$b
4) Create an autority of this type with a single quote in heading, ie :
l'avenir
5) Index this new autority
6) Edit a biblio record and launch 210$c value builder
7) Search for new autority
8) Click on 'Choose'
=> Heading should be pasted in 210$c

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 09:53:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 07:53:30 +0000
Subject: [Koha-bugs] [Bug 20889] Items marked as not for loan can be checked
	out
In-Reply-To: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20889-70-KIexOjhf2T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20889

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Ack, there are sooo many combinations ;).

A new bug I reckon as this one is pushed and closed please Katrin :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 10:07:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 08:07:29 +0000
Subject: [Koha-bugs] [Bug 20963] New: Can check out not for loan items when
 temporarily overriding restriction
Message-ID: <bug-20963-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20963

            Bug ID: 20963
           Summary: Can check out not for loan items when temporarily
                    overriding restriction
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

If the user has a restriction (for example DISCHARGE) and you use the
'temporary override' button, it's possible to check out items with not for loan
itemtypes. Even when AllowNotForLoanOverride is set to not allow override.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 10:08:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 08:08:11 +0000
Subject: [Koha-bugs] [Bug 20889] Items marked as not for loan can be checked
	out
In-Reply-To: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20889-70-z5W47HsI8O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20889

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20963

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
You are right ;) Bug 20963

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 10:08:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 08:08:11 +0000
Subject: [Koha-bugs] [Bug 20963] Can check out not for loan items when
 temporarily overriding restriction
In-Reply-To: <bug-20963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20963-70-tLofpf32W9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20963

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20889

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 10:18:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 08:18:16 +0000
Subject: [Koha-bugs] [Bug 20961] cn_sort for DDC callnumbers should between
 1 and 99 should be formatted as 001.* - 099.*
In-Reply-To: <bug-20961-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20961-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20961-70-oSleH7xpVL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20961

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Given the conversation that took place in that email thread, do we actually
need to add a new sort class for this rather than changing the existing one's
behaviour to give the least surprise to users?  Or perhaps create a new UDC.pm
class which is simply a copy of the current Dewey one before altering the
behaviour of Dewey at the very least?

Universal Decimal Classification / UDC being effectively what the current
Dewey.pm acts correctly for UDC sorting...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 11:38:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 09:38:58 +0000
Subject: [Koha-bugs] [Bug 18783] Allow automatic claims for serials
In-Reply-To: <bug-18783-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18783-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18783-70-wGbaK66C4A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Needs rebase.
For example serials/subscription-add.pl has been modified by Bug 20461

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 12:11:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 10:11:28 +0000
Subject: [Koha-bugs] [Bug 13325] Add logs for budgets and funds
In-Reply-To: <bug-13325-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13325-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13325-70-FbEM0bxj71@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325

Joe McGlynn <joe.mcglynn at educampus.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joe.mcglynn at educampus.ie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 14:13:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 12:13:03 +0000
Subject: [Koha-bugs] [Bug 20964] New: search_patrons_to_anonymise selects
 different user than GetBorrowersWithIssuesHistoryOlderThan did.
Message-ID: <bug-20964-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20964

            Bug ID: 20964
           Summary: search_patrons_to_anonymise selects different user
                    than GetBorrowersWithIssuesHistoryOlderThan did.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

Bug 16966 sought to move the patron selection routines from
GetBorrowersWithIssuesHistoryOlderThan in C4 to a dbic centric query in
Koha::Patrons.

However, in do so, the resultant query was changed in such a way that rather
than filtering patrons to anonymise by their home branch you are actually
filtering by patrons who have ever had an biblio issued to them from a
particular branch.

This is a surprising and unexpected change in functionality for users upgrading
to 17.05.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 14:13:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 12:13:50 +0000
Subject: [Koha-bugs] [Bug 20964] search_patrons_to_anonymise selects
 different user than GetBorrowersWithIssuesHistoryOlderThan did.
In-Reply-To: <bug-20964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20964-70-vM0uw1VSjD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20964

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_17_11_candidate,
                   |                            |rel_18_05_candidate

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 14:19:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 12:19:29 +0000
Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all
	libraries
In-Reply-To: <bug-8137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8137-70-oepCyrlZmi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137

--- Comment #28 from Alex Arnaud <alex.arnaud at biblibre.com> ---
(In reply to Lucie Gay from comment #26)
> the priority rule is applied except for the loan period, it's the one define
> in the more permissive rule which is taken into account.

Hello Lucie,

What do you mean by "except for the loan period" ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 14:22:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 12:22:07 +0000
Subject: [Koha-bugs] [Bug 20964] search_patrons_to_anonymise selects
 different user than GetBorrowersWithIssuesHistoryOlderThan did.
In-Reply-To: <bug-20964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20964-70-rU36RNhxND@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20964

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 76169
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76169&action=edit
Bug 20964: Restore original filtering behaviour after bug 16966

Bug 16966 altered the filter criteria of the anonymise selection, this
patch restores the original behaviour.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 14:22:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 12:22:23 +0000
Subject: [Koha-bugs] [Bug 20964] search_patrons_to_anonymise selects
 different user than GetBorrowersWithIssuesHistoryOlderThan did.
In-Reply-To: <bug-20964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20964-70-lt84BsOsbm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20964

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 14:25:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 12:25:54 +0000
Subject: [Koha-bugs] [Bug 18784] Add 'auto claim' option to subscription
	batch edit tool
In-Reply-To: <bug-18784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18784-70-mPUVHDkqQf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #4 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Patch is missing a closing HTML tag </li>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 14:27:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 12:27:34 +0000
Subject: [Koha-bugs] [Bug 20964] search_patrons_to_anonymise selects
 different user than GetBorrowersWithIssuesHistoryOlderThan did.
In-Reply-To: <bug-20964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20964-70-AseyfjcAnu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20964

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I take that back.. it's not a change of behaviour... but a counter-intuitive
behaviour to start with :(

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 14:28:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 12:28:51 +0000
Subject: [Koha-bugs] [Bug 20931] JS error "ReferenceError: $ is not defined"
 when CircSidebar is turned on
In-Reply-To: <bug-20931-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20931-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20931-70-bqrMxzS0nV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20931

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Katrin Fischer from comment #2)
> Ah, I think the JavaScript for navbar needs to be moved to the bottom.

It needs to be moved to a separate JS file or a JS file which is already
included on the affected pages. It's on my to-do list but someone else can take
it if they want.

As far as I know it's only a cosmetic issue -- the highlighting of the current
page won't work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 14:33:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 12:33:19 +0000
Subject: [Koha-bugs] [Bug 20964] search_patrons_to_anonymise selects
 different user than GetBorrowersWithIssuesHistoryOlderThan did.
In-Reply-To: <bug-20964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20964-70-kzpOtC2AIq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20964

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_17_11_candidate,        |
                   |rel_18_05_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 14:33:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 12:33:31 +0000
Subject: [Koha-bugs] [Bug 20921] Expose borrowernumber and branch when user
 is logged in to OPAC
In-Reply-To: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20921-70-Zcgel9H26a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to paxed from comment #3)
> Custom HTML attributes should be prefixed with "data-" (as per the HTML5
> spec)

I agree with this. I think it makes sense to add data- attributes for branch
and borrowernumber even with the branch information in a class.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 14:35:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 12:35:13 +0000
Subject: [Koha-bugs] [Bug 20964] search_patrons_to_anonymise selects
 different user than GetBorrowersWithIssuesHistoryOlderThan did.
In-Reply-To: <bug-20964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20964-70-LgW81KzWvg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20964

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|Needs Signoff               |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 14:36:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 12:36:04 +0000
Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system
In-Reply-To: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20813-70-Yymdi3o3i1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
I'm changing this to "patch doesn't apply" because the attached patch didn't
work correctly and Kyle said it was probably a rebase issue. I'm not
comfortable signing off based on the original code because of how behind master
it is.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 14:46:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 12:46:31 +0000
Subject: [Koha-bugs] [Bug 20963] Can check out not for loan items when
 temporarily overriding restriction
In-Reply-To: <bug-20963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20963-70-2XtSTaMtdJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20963

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
This sounds like a long standing bug.

It will be hard to deal with that bug, the permission { circulate =>
force_checkout } allows to force the checkout if the patron has a restriction. 

When the forceallow flag is set, all other Allow*Override prefs are bypassed.

I guess we should deal with the permissions differently than the Allow*Override
prefs.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 14:50:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 12:50:10 +0000
Subject: [Koha-bugs] [Bug 20650] Switch single-column templates to Bootstrap
 grid: Various, part 3
In-Reply-To: <bug-20650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20650-70-gzFKxK6cN0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20650

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76170
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76170&action=edit
Bug 20650: (follow-up) Add missing include file

This patch adds a missing include of doc-head-open.inc.

To test, apply the patch and export a batch of patron cards. The modal
view for downloading the card batch PDF should work correctly.
Validating the iframe's source should show no relevant errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 14:53:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 12:53:14 +0000
Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used
 in the description
In-Reply-To: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20891-70-150Qtf8hzG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #7)
> I think we had similar problems on patron search - anything we could pick
> from there?

We are using the same code for lists and patrons, so I supposed patron's result
will explode if '\' is contained in the surname/firstname, which certainly does
not exist in a production DB :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 15:02:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 13:02:05 +0000
Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used
 in the description
In-Reply-To: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20891-70-Xb8023QwD5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #8)
> (In reply to Katrin Fischer from comment #7)
> > I think we had similar problems on patron search - anything we could pick
> > from there?
> 
> We are using the same code for lists and patrons, so I supposed patron's
> result will explode if '\' is contained in the surname/firstname, which
> certainly does not exist in a production DB :)

Actually, we had a lot of issues with patron search on migrating a lot of
libraries recently. You never know what is in the data you get and it's hard to
debug the JSON errors in some cases.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 15:05:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 13:05:01 +0000
Subject: [Koha-bugs] [Bug 20965] Batch patron anonymization logic is flawed
In-Reply-To: <bug-20965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20965-70-dOezlxpJ7l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20965

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P3
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 15:04:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 13:04:48 +0000
Subject: [Koha-bugs] [Bug 20965] New: Batch patron anonymization logic is
	flawed
Message-ID: <bug-20965-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20965

            Bug ID: 20965
           Summary: Batch patron anonymization logic is flawed
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

There are two issues here:

1) The tool suggests you can limit by library and checkout date but in fact,
the library is not the patrons' library but the library the items were issued
at. This is not clear from the UI.

2) When it comes to the actual anonymisation, although we've got a filtered
list of Patrons by issues before X and at Library, we then delete ALL issues
before X by any of the Patrons selected by the previous query, regardless of
which library the checkout took place and thus we ignore the selected Library.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 15:05:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 13:05:46 +0000
Subject: [Koha-bugs] [Bug 20650] Switch single-column templates to Bootstrap
 grid: Various, part 3
In-Reply-To: <bug-20650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20650-70-IPv2t5DTfB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20650

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 15:05:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 13:05:46 +0000
Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests
 periods overlap with existing reserves
In-Reply-To: <bug-15261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15261-70-Lg2CI7KbnS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #55 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Oups, looks like patch makes a lot of unwanted changes in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 15:05:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 13:05:51 +0000
Subject: [Koha-bugs] [Bug 20650] Switch single-column templates to Bootstrap
 grid: Various, part 3
In-Reply-To: <bug-20650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20650-70-TAllT7IRZ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20650

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75301|0                           |1
        is obsolete|                            |
  Attachment #76170|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76171&action=edit
Bug 20650: Switch single-column templates to Bootstrap grid: Various, part 3

This patch updates various unrelated templates to use the Bootstrap
grid. In each case, confirm that the indicated page looks correct.

This patch also corrects a couple of capitalization errors and removes
an unused template: virtualshelves/merge.tt.

 - Tools -> Patron card creator -> Manage -> Card batches
   - Export a batch
   - The pages inside the modal window should look correct: Both the "X
     batch(es) to export" screen and the "download exported batch(es)"
     one.

 - Tools -> Patron lists -> Edit list
   - The patron list add/edit form should look correct.

 - Disable plugins in koha-conf.xml.
   - Tools -> Plugins
   - The "Plugins disabled" page should look correct.

 - Enable plugins in koha-conf.xml
   - Tools -> Plugins -> Upload plugins.
     - This page should look correct.

 - Tools
   - The tools home page should show three columns: Patrons and
     Circulation, Catalog, Additional tools.
   - At viewport width below 768 pixels content should reflow into one
     column.

 - virtualshelves/merge.tt has been removed as it is unused. Search the
   codebase for references to it. There should be none.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 15:05:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 13:05:56 +0000
Subject: [Koha-bugs] [Bug 20650] Switch single-column templates to Bootstrap
 grid: Various, part 3
In-Reply-To: <bug-20650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20650-70-qbJwg4BvbO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20650

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76172
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76172&action=edit
Bug 20650: (follow-up) Add missing include file

This patch adds a missing include of doc-head-open.inc.

To test, apply the patch and export a batch of patron cards. The modal
view for downloading the card batch PDF should work correctly.
Validating the iframe's source should show no relevant errors.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 15:06:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 13:06:01 +0000
Subject: [Koha-bugs] [Bug 20650] Switch single-column templates to Bootstrap
 grid: Various, part 3
In-Reply-To: <bug-20650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20650-70-u5jhvbZbVz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20650

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76173
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76173&action=edit
Bug 20650: Remove unused virtualshelves/merge.tt

Committed by Jonathan Druart, get out from first patch of this patchset.

It's a follow-up of bug 4019 which removed virtualshelves/merge.pl

Moving this change to its own commit to make it clear in the git log and
easier to backport if needed.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 15:20:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 13:20:22 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11897-70-mLtSH9P3GV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #262 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Martin Renvoize from comment #260)
> Fully rebased and taken account of a few pieces of customer feedback in the
> followups.

Do they test on top of master? Should not we add their signed-off-by lines?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 15:20:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 13:20:28 +0000
Subject: [Koha-bugs] [Bug 19502] Result sets limited to 10000
In-Reply-To: <bug-19502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19502-70-FYRVj6O0UC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

--- Comment #8 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Comment on attachment 74587
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74587
Bug 19520: (follow-up) Pass parameters to avoid making templates depend on
search engine

Review of attachment 74587:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19502&attachment=74587)
-----------------------------------------------------------------

::: catalogue/search.pl
@@ +677,4 @@
>                                  last_page_offset => $last_page_offset,
>                                  previous_page_offset => $previous_page_offset) unless $pages < 2;
>              $template->param(   next_page_offset => $next_page_offset) unless $pages eq $current_page_number;
> +            warn "topage $hits_to_paginate";

Debug thing ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 15:23:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 13:23:04 +0000
Subject: [Koha-bugs] [Bug 20965] Batch patron anonymization logic is flawed
In-Reply-To: <bug-20965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20965-70-Bp6bSpwBhS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20965

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I think the feature should allow the Patron selection (for deletion or
anonymization) in a first step (and filtering by branch should be te patrons
home branch, not where the issues happened) and then proceed to a second step
where you can select whether all issues (before the previously selected date)
are anonymised regardless of checkout branch or whether the issues should be
limited to the selected branch..

I'm not even sure if/when the second step would ever be required?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 15:32:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 13:32:44 +0000
Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used
 in the description
In-Reply-To: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20891-70-LZ2X3X6YtO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #9)
> (In reply to Jonathan Druart from comment #8)
> > (In reply to Katrin Fischer from comment #7)
> > > I think we had similar problems on patron search - anything we could pick
> > > from there?
> > 
> > We are using the same code for lists and patrons, so I supposed patron's
> > result will explode if '\' is contained in the surname/firstname, which
> > certainly does not exist in a production DB :)
> 
> Actually, we had a lot of issues with patron search on migrating a lot of
> libraries recently. You never know what is in the data you get and it's hard
> to debug the JSON errors in some cases.

open the web dev console, get the answer from the server, copy/paste it on a
JSON validator website, and you will know exactly where the problem is.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 15:47:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 13:47:29 +0000
Subject: [Koha-bugs] [Bug 20794] Don't show holds tab when user doesn't have
 circulate_remaining_permissions
In-Reply-To: <bug-20794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20794-70-p6sjI8xSuh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20794

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I have no idea if the permissions are ok but this patch makes sense as a quick
fix at least.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 15:48:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 13:48:16 +0000
Subject: [Koha-bugs] [Bug 20794] Don't show holds tab when user doesn't have
 circulate_remaining_permissions
In-Reply-To: <bug-20794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20794-70-rNmsSLXXcG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20794

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 15:48:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 13:48:20 +0000
Subject: [Koha-bugs] [Bug 20794] Don't show holds tab when user doesn't have
 circulate_remaining_permissions
In-Reply-To: <bug-20794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20794-70-a1aKBVnbxW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20794

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75944|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76174
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76174&action=edit
Bug 20794: Hide holds tab on details when user lacks
circulate_remaining_permissions

If a user doesn't have circulate_remaining permissions, but has borrowers:
- checkouts tab is hidden
- details tab is visible
- holds tab on details is visible, but results in an error

The problem is that the svc/holds script requires
circulate_remaining_permissions.

To test:
- Create 2 staff users with and without circulate_remaining_permissions
  Both need borrowers permission
- Go to the details tab in a patron's account who has holds
- Verify that you get a datatables error for the staff patron without
  circulate_remaining_permissions
- Apply patch
- Verify that now the holds tab is no longer displayed for this patron

Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 15:48:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 13:48:38 +0000
Subject: [Koha-bugs] [Bug 20794] Don't show holds tab when user doesn't have
 circulate_remaining_permissions
In-Reply-To: <bug-20794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20794-70-XmqROw9NCd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20794

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 15:48:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 13:48:46 +0000
Subject: [Koha-bugs] [Bug 20794] Don't show holds tab when user doesn't have
 circulate_remaining_permissions
In-Reply-To: <bug-20794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20794-70-jpc16pmAA1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20794

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 15:53:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 13:53:37 +0000
Subject: [Koha-bugs] [Bug 20965] Batch patron anonymization logic is flawed
In-Reply-To: <bug-20965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20965-70-BnAGQJkgfp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20965

Janet McGowan <janet.mcgowan at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |janet.mcgowan at ptfs-europe.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 15:54:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 13:54:08 +0000
Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing
 of required indexes
In-Reply-To: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19482-70-GKQxoF8J68@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alex.arnaud at biblibre.com
         QA Contact|                            |alex.arnaud at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 16:00:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 14:00:14 +0000
Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing
 of required indexes
In-Reply-To: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19482-70-KfOwE5Ehib@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482

--- Comment #16 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Comment on attachment 72879
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72879
Bug 19482 - Add support for defining 'mandatory' mappings

Review of attachment 72879:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19482&attachment=72879)
-----------------------------------------------------------------

::: Koha/SearchEngine/Elasticsearch.pm
@@ +286,5 @@
>          while ( my ( $field_name, $data ) = each %$fields ) {
>              my $field_type = $data->{type};
>              my $field_label = $data->{label};
> +            my $field_mandatory = $data->{mandatory};
> +            warn $field_mandatory;

Debug thing?

:::
koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt
@@ +143,3 @@
>                        <td>
> +                        [% IF is_readonly %]
> +                            <input type="text" name="search_field_type" value="[% search_field.type FILTER ucfirst%]" [% is_readonly %] />

Maybe this readonly input should be sized? This cause the input is larger than
the selects and so expand the "Type" column. Or maybe use a <label> as
suggested by David

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 16:00:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 14:00:42 +0000
Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing
 of required indexes
In-Reply-To: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19482-70-1okrBKQ2xM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 16:20:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 14:20:42 +0000
Subject: [Koha-bugs] [Bug 20947] Navigating to moremember.pl for a patron
 who has fines on deleted items causes software error.
In-Reply-To: <bug-20947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20947-70-CFw56Igq6o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20947

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #3)
> Could you confirm the FK is missing?

Indeed, the foreign key appears to be missing on the affected site

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 16:28:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 14:28:45 +0000
Subject: [Koha-bugs] [Bug 20947] Navigating to moremember.pl for a patron
 who has fines on deleted items causes software error.
In-Reply-To: <bug-20947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20947-70-2wWEe3chZP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20947

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
It's not a new constraint, no idea how it could be possible.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 16:33:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 14:33:50 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11897-70-MUTdc010Xm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

--- Comment #263 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
The whole set should apply atop master.

I have two sets of customers currently testing and feeding back on it and hope
to add them as signoffs once they're happy.  But a further SO would be great if
I can find someone to do it..

In the meantime I'd be interested in some QA/Const cutive Critisism on the Cron
script as that was somewhat rush changed to try and make it for 18.05.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 16:34:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 14:34:25 +0000
Subject: [Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
In-Reply-To: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20906-70-n8vHeu9jDb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75920|0                           |1
        is obsolete|                            |

--- Comment #10 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76176
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76176&action=edit
Bug 20906: Prevent test failures due to stricter perl

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 16:34:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 14:34:32 +0000
Subject: [Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
In-Reply-To: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20906-70-NHnB2XCcUh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75921|0                           |1
        is obsolete|                            |

--- Comment #11 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76177
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76177&action=edit
Bug 20906: Prevent test failures due to precision changes (2)

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 16:34:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 14:34:40 +0000
Subject: [Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
In-Reply-To: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20906-70-0nz28MYXzx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75929|0                           |1
        is obsolete|                            |

--- Comment #12 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76178
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76178&action=edit
Bug 20906: Fix translatable-templates.t

>From Jenkins:
koha_1       | #   Failed test 'staff_prog templates are translatable'
koha_1       | #   at xt/author/translatable-templates.t line 87.
koha_1       | # Can't locate TmplTokenizer.pm in @INC (you may need to install
the TmplTokenizer module) (@INC contains: /kohadevbox/koha /etc/perl
/usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1
/usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5
/usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24
/usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at
./tmpl_process3.pl line 20.

On Stretch, '.' is not longer added to @INC, see bug 17717 for more info

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 16:34:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 14:34:18 +0000
Subject: [Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
In-Reply-To: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20906-70-ftbEKLu4ZM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75916|0                           |1
        is obsolete|                            |

--- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76175
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76175&action=edit
Bug 20906: Prevent test failures due to precision changes

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 16:34:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 14:34:50 +0000
Subject: [Koha-bugs] [Bug 19617] Allow 'writeoff of selected'
In-Reply-To: <bug-19617-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19617-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19617-70-FRLRE9418q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19617

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
CONFLICT (content): Merge conflict in members/pay.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 16:35:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 14:35:12 +0000
Subject: [Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
In-Reply-To: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20906-70-xv2o6PQjCN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 16:40:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 14:40:43 +0000
Subject: [Koha-bugs] [Bug 20961] cn_sort for DDC callnumbers should between
 1 and 99 should be formatted as 001.* - 099.*
In-Reply-To: <bug-20961-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20961-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20961-70-ATwZqZc4NY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20961

--- Comment #2 from Barton Chittenden <barton at bywatersolutions.com> ---
(In reply to Martin Renvoize from comment #1)
> Given the conversation that took place in that email thread, do we actually
> need to add a new sort class for this rather than changing the existing
> one's behaviour to give the least surprise to users?  Or perhaps create a
> new UDC.pm class which is simply a copy of the current Dewey one before
> altering the behaviour of Dewey at the very least?
> 
> Universal Decimal Classification / UDC being effectively what the current
> Dewey.pm acts correctly for UDC sorting...

I think the second option -- 

- Create a UDC cn_source / UDC.pm that retains the current behavior of Dewey.pm
- Update Dewey.pm to 0-pad the digits before the decimal point

is the way to go, although this will require some care, because cn_source is
used widely in Koha -- there are tests for 'ddc' in xslt files, Koha/EDI.pm,
and C4/Labels/Label.pm.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 16:48:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 14:48:46 +0000
Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display
In-Reply-To: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11375-70-cPKkqMp2nI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375

S?verine Queune <severine.queune at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |severine.queune at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 16:49:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 14:49:59 +0000
Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit
	form
In-Reply-To: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20809-70-slFlfL4UJi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809

S?verine Queune <severine.queune at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |severine.queune at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 16:52:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 14:52:00 +0000
Subject: [Koha-bugs] [Bug 20810] Add filters and links in basketgroups page
In-Reply-To: <bug-20810-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20810-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20810-70-qw1iiynZxW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20810

S?verine Queune <severine.queune at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |severine.queune at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 16:56:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 14:56:46 +0000
Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface
In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20935-70-vFQE2W4stO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

S?verine Queune <severine.queune at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |severine.queune at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 16:57:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 14:57:05 +0000
Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout
 form, with collapsed settings panel
In-Reply-To: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20959-70-I1Lbodz0Sx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959

S?verine Queune <severine.queune at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |severine.queune at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 16:58:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 14:58:14 +0000
Subject: [Koha-bugs] [Bug 20898] Replace OPAC detail's results browser with
 non-JavaScript version
In-Reply-To: <bug-20898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20898-70-OIbK5Ud8Fd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20898

S?verine Queune <severine.queune at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |severine.queune at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 16:59:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 14:59:01 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-qEo7ZUGEMr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

S?verine Queune <severine.queune at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |severine.queune at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 17:13:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 15:13:30 +0000
Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used
 in the description
In-Reply-To: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20891-70-DtF4AJlwrJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The number of patrons in this libraries is so big that the answer is cut off in
the developer tools in the browser... so you have to page until you can limit
it to the right 'area'. I am open for ideas ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 17:16:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 15:16:12 +0000
Subject: [Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
In-Reply-To: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20906-70-5rn40agBMj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |
             Status|Signed Off                  |Passed QA

--- Comment #13 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
This is simple enough to skip other QA step. It was written by two QA team
members...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 17:51:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 15:51:33 +0000
Subject: [Koha-bugs] [Bug 20943] Cannot enable shibboleth and LDAP at the
	same time
In-Reply-To: <bug-20943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20943-70-yqFD1x9QSE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20943

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #1)
> Interesting. Has that changed in recent versions? We have a library using
> Shibboleth and LDAP with 16.11

It may be specific to the LDAP setup with 'auth_by_bind' activated - I think we
are seeing the connection refused so login failed as we don't have good
user/pass info for auth_by_bind

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 17:55:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 15:55:26 +0000
Subject: [Koha-bugs] [Bug 20947] Navigating to moremember.pl for a patron
 who has fines on deleted items causes software error.
In-Reply-To: <bug-20947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20947-70-WpH32V1NZW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20947

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WORKSFORME

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #5)
> It's not a new constraint, no idea how it could be possible.

We suspect these sites were either original liblime dbs or created using
outdated info.

Closing this bug out as it shouldn't occur without bad tables

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 18:28:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 16:28:29 +0000
Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors
	to a record
In-Reply-To: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14570-70-av1AEQpfk0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #79 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Some more QA comments, I have not checked if previous requests have been
addressed.

1. Bug - add or edit a patron and add 2 fathers, one from an existing patron
and the other not. Only 1 is saved.

2. On the edit patron view, the "Delete" checkbox does not have the correct
label (i.e. when you click on it, it will not check/uncheck the checkbox).
(related to comment 52, 2/)

3.
a. It is not clear to me why you removed the contact* fields from the borrowers
table. It looks like they were also used when no guarantor existed.
b. Moreover `git grep contactfirstname|grep -v altcontactfirstname` returns
occurrences that should be removed (if we really want to remove them)
c. The fields are not removed from borrowermodification and deletedborrowers
(from the atomic update)

d. IMPORTANT - Should not we finally keep these fields and force the guarantors
to be existing patrons? We could have only 1 "contact" and several guarantors.
It seems that it will simplify a lot the code (for instance
Koha::Patron->guarantors would return Koha::Patrons, and
Koha::Patron::Relationship[s] would stay simple Koha::Object[s])

4. Should not the table name "relationships" be more specific?
("borrower_relationships"?)

5. add_guarantors should be moved to Koha::Patron

6. Koha::Patron->siblings is weird, we should not need to refetch the patron
list.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 18:29:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 16:29:24 +0000
Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors
	to a record
In-Reply-To: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14570-70-6crveZEQSi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 18:51:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 16:51:05 +0000
Subject: [Koha-bugs] [Bug 20966] New: Add column configuration to table of
 orders in a basket
Message-ID: <bug-20966-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20966

            Bug ID: 20966
           Summary: Add column configuration to table of orders in a
                    basket
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

I think we should remove the "show all details" checkbox from acqui/basket.pl
and replace it with DataTables column configuration.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 19:26:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 17:26:29 +0000
Subject: [Koha-bugs] [Bug 20966] Add column configuration to table of orders
	in a basket
In-Reply-To: <bug-20966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20966-70-rqYxKeqMaV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20966

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 19:26:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 17:26:32 +0000
Subject: [Koha-bugs] [Bug 20966] Add column configuration to table of orders
	in a basket
In-Reply-To: <bug-20966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20966-70-y34eCU90Ij@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20966

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76179
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76179&action=edit
Bug 20966: Add column configuration to table of orders in a basket

This patch adds column configuration to the table of orders in a basket.
It replaces the "Show all details" checkbox which previously was used to
show the hidden "tax included" columns. Now those columns are hidden by
default in the columns configuration file.

To test, apply the patch and view a basket with multiple orders. Test
all DataTables functionality (paging, sorting, filtering) including
showing and hiding columns.

Test with both an open and a closed basket.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 20:12:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 18:12:56 +0000
Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating
 patron category based on status
In-Reply-To: <bug-17168-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17168-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17168-70-YT9jBf9jtx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I intend on writing a much more generic 'filter_by' method for the
Koha::Patrons class which could easily be shared between bulk deletions, bulk
anonymizations and this bulk category change enhancement along with some others
down the line.. it seems somewhat crazy to add a method for each type of
filtering (feels like we're backing ourselves into the same position we ended
up in C4)..

I'll submit that against bug 11983 which I've adopted.. and likely build a
small tree of bugs hanging off it that could use this..

Obviously this is just my opinionated ramblings, but thought it worth
highlighting the intention to write similar code.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 20:21:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 18:21:20 +0000
Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating
 patron category based on status
In-Reply-To: <bug-17168-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17168-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17168-70-lbhL9sVrLf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168

--- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
As a hint at where I'm going with it.. I had to throw something together
quickly for customers to satisfy GDPR
https://gist.github.com/mrenvoize/a0c37b1350d1fe532143784dee124b80.. It's
basically pulling out the construction of the $where and $attr 'select' clause
that I'm looking to put in a `filter_by` method

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 20:54:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 18:54:35 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-EOLtXYIaNy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #85 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
1. Maybe add a ref to OneClickdigital in the pref?
 "No system preferences matched your search for: OneClickdigital"
(not blocking)

2. Found 241+ results in the library's RecordedBooks collection
"+" ?

3. /opac-tmpl/lib/jquery/plugins/themes/classic/throbber.gif
must be using [% theme %]/[% interface %]

4. In the checkout list there is a link .epub (below "downloads"), but it
downloads a .acsm file (??) Is it expected?

5. expires.toLocaleString() does not work what you are expecting, the date is
always displayed in the same format (do not depend on dateformat)

6. https://screenshots.firefox.com/C5OmithULkvMQtTe/catalogue.kohadev.org
"Check out" and "Place hold" button are too close and not well styled (not
blocking)

7. Place hold, hit cgi-bin/koha/opac-user.pl, cancel the hold. The hold is
still listed (not blocking)

8. /cgi-bin/koha/opac-recordedbooks-search.pl?q=d
click on an image,
https://carnegiestoutia.oneclickdigital.com/#titles/9781470360603 => "Your
connection is not secure", awesome...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 20:55:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 18:55:23 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-b8I3GYyXuE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73708|0                           |1
        is obsolete|                            |
  Attachment #73709|0                           |1
        is obsolete|                            |
  Attachment #73710|0                           |1
        is obsolete|                            |
  Attachment #73711|0                           |1
        is obsolete|                            |
  Attachment #73712|0                           |1
        is obsolete|                            |
  Attachment #73713|0                           |1
        is obsolete|                            |
  Attachment #73714|0                           |1
        is obsolete|                            |
  Attachment #73715|0                           |1
        is obsolete|                            |
  Attachment #73716|0                           |1
        is obsolete|                            |
  Attachment #73717|0                           |1
        is obsolete|                            |
  Attachment #73718|0                           |1
        is obsolete|                            |
  Attachment #73725|0                           |1
        is obsolete|                            |

--- Comment #86 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76180
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76180&action=edit
Bug 17602: Koha::ExternalContent->koha_patron() will retutn undef rather than
die if user not logged in

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 20:55:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 18:55:33 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-kMdshDvc85@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #87 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76181
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76181&action=edit
Bug 17602: RecordedBooks Integration to Koha

This patch introduces the required sysprefs and
Koha::ExternalContent::RecordedBooks

Koha::ExternalContent::RecordedBooks - a wrapper around
WebService::ILS::RecordedBooks::PartnerPatron

RecordedBooks* sysprefs

Nothing functional to test with this patch yet.
But you can run the tests that come with it

 t/db_dependent/Koha_ExternalContent_RecordedBooks.t

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 20:55:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 18:55:41 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-U34fUSyvLo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #88 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76182
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76182&action=edit
Bug 17602: OPAC integration of RecordedBooks

Add RecordedBooks to the users page in the public interface

To Test:
1/ Apply all 3 patches
2/ Set the sysprefs to valid values (you will need a test account with
RecordedBooks)
3/ Try a search
4/ Login to the OPAC, try to place a hold, or check an item out
5/ Check the opac-user page, see if your items are showing on the
oneclickdigital tab

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 20:55:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 18:55:48 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-V9UXDOXIdz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #89 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76183
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76183&action=edit
Bug 17602 follow-up: t/Koha_ExternalContent_RecordedBooks.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 20:55:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 18:55:56 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-dwaG1LfIHr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #90 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76184&action=edit
Bug 17602: Ease translation

Use String.format() to make translation easier

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 20:56:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 18:56:01 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-wJHuBUvMr4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #91 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76185
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76185&action=edit
Bug 17602: Handle '60+' if there are more than 60 results

The service returns "60+" if there are more than 60 results.
Without this patch the "Found %s results in RecordedBooks collection"
line is removed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 20:56:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 18:56:07 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-KPwW0WnmPy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #92 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76186&action=edit
Bug 17602: Adapt test plan to make the tests pass

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 20:56:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 18:56:13 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-6zwUOBIF5m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #93 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76187
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76187&action=edit
Bug 17602: Fix few minor QA issues

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 20:56:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 18:56:21 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-5YxsrnWnCm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #94 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76188
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76188&action=edit
Bug 17602: Translations rework

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 20:56:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 18:56:29 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-JX3oHr0EM5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #95 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76189&action=edit
Bug 17602: fix RecordedBooks results pagination

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 20:56:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 18:56:45 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-mfsX9botzj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #97 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76191&action=edit
Bug 17602: (follow-up) Adjust js paths to use version add spinner

Also included recompiled version of opac.css that we forgot.

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 20:56:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 18:56:54 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-8N33LkELFq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #98 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76192&action=edit
Bug 17602: update compiled opac.css

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 20:57:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 18:57:01 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-Ic1qMVB9px@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #99 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76193&action=edit
Bug 17602: Use Asset TT plugin and fix indentation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 20:56:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 18:56:36 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-qIhZ7R9GXQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #96 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76190
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76190&action=edit
Bug 17602: Removed unused param to RecordedBooks API

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 21:04:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 19:04:20 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-Cd68O6Z4Yg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #100 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Please keep changes to opac.css in a separated patch to ease rebases.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 21:07:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 19:07:57 +0000
Subject: [Koha-bugs] [Bug 20951] Koha::Patron::Discharge is missing use
 Koha::Patron::Debarments
In-Reply-To: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20951-70-9d6vUtL7om@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76167|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76194&action=edit
Bug 20951: add missing use Koha::Patron::Debarments in Koha::Patron::Discharge

Koha::Patron::Discharge was missing use Koha::Patron::Debarments used in
discharge() method.

Test plan :
1) Enable pref useDischarge
2) Go to OPAC user page
3) Go to 'ask for a discharge' tab
4) Click on 'Ask for a discharge'
5) Go to staff interface : /cgi-bin/koha/members/discharges.pl
6) Click on Allow
=> Without patch you get software error
=> With patch the discharge is validated

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 21:07:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 19:07:53 +0000
Subject: [Koha-bugs] [Bug 20951] Koha::Patron::Discharge is missing use
 Koha::Patron::Debarments
In-Reply-To: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20951-70-ucajXecTGe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 21:34:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 19:34:37 +0000
Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system
In-Reply-To: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20813-70-zwV7rXP9P9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Kyle, would you be ok to make this dependent on some patches in PQA when
rebasing?

bug 11911 - new permission for managing suggestions
bug 7651 - new permission for managing currencies

Both are adding new permissions. I am keen on resolving as many permission bugs
as possible this release and would be happy to help with this one to have a
better foundation.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 21:37:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 19:37:04 +0000
Subject: [Koha-bugs] [Bug 20921] Expose borrowernumber and branch when user
 is logged in to OPAC
In-Reply-To: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20921-70-qCRZRLqjm3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Talked to Owen on IRC - all things cleared up. I think only thing missing here
is adding the data- prefix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 21:38:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 19:38:31 +0000
Subject: [Koha-bugs] [Bug 20943] Cannot enable shibboleth and LDAP at the
	same time
In-Reply-To: <bug-20943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20943-70-dlQJa8yE3M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20943

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I was hoping to help narrow it down with the version comment - but not sure
what setup we are using :(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 21:42:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 19:42:35 +0000
Subject: [Koha-bugs] [Bug 20963] Can check out not for loan items when
 temporarily overriding restriction
In-Reply-To: <bug-20963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20963-70-NbL9RuoiDD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20963

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think it's a mistake in the logic, the override for restriction should just
allow you to 'unlock' the circulation, not override all other rules. But yeah,
probably not an easy fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 22:42:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 20:42:07 +0000
Subject: [Koha-bugs] [Bug 19086] Multiple cross-site scripting
	vulnerabilities
In-Reply-To: <bug-19086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19086-70-7ai4DA90L5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19086

--- Comment #45 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Interesting thing: on bug 13618 it was decided to not escape the patron's
messages. So maybe this will be be considered as a bug by some libraries.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 23:03:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 21:03:54 +0000
Subject: [Koha-bugs] [Bug 20881] Order receiving: Price filter missing
	on_editing
In-Reply-To: <bug-20881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20881-70-B1TAjyfEjD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20881

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|trivial                     |normal
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This is quite a problem working with comma-separated decimals, upping severity
a bit.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 23:05:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 21:05:52 +0000
Subject: [Koha-bugs] [Bug 20881] Order receiving: Price filter missing
	on_editing
In-Reply-To: <bug-20881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20881-70-rrCuKNn7Yq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20881

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 23:05:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 21:05:56 +0000
Subject: [Koha-bugs] [Bug 20881] Order receiving: Price filter missing
	on_editing
In-Reply-To: <bug-20881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20881-70-KvPgq4Anqq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20881

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75809|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 76195
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76195&action=edit
Bug 20881: Order receiving: Price filter missing on_editing

When the Price-filter is used on editable data, it should have the
on_editing -tag. Add it to the orderreceive.tt

Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

To test:
- Set CurrencyFormat to FR
- Create a basket with orders in acq
- Close it
- Receive shipment and pick order line to receive
- On this screen verify that the actual cost appears as comma-separated
- Apply patch
- Refresh page
- Verify that the actual cost now appears .-separated

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 23:10:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 21:10:52 +0000
Subject: [Koha-bugs] [Bug 20962] Overhaul to notices
In-Reply-To: <bug-20962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20962-70-YTNdvd3FX1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20962

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
<item> is going to be deprecated, you should use the TT syntax for notice
instead.
It basically means there will certainly no need to dev anything to support that
(apart of adapting the template to your needs).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 23:13:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 21:13:42 +0000
Subject: [Koha-bugs] [Bug 20864] Only set bibs_selected cookie when
 BrowseResultSelection is activated
In-Reply-To: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20864-70-zMJo9NiusX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 23:13:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 21:13:46 +0000
Subject: [Koha-bugs] [Bug 20864] Only set bibs_selected cookie when
 BrowseResultSelection is activated
In-Reply-To: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20864-70-Hn3WTzBa4s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75771|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 76196
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76196&action=edit
Bug 20864: Only set bibs_selected cookie when BrowseResultSelection is
activated

This patch adds a system preference check around the call to the
JavaScript include which sets the bibs_selected cookie. With
BrowseResultsSelection disabled, the cookie should never be set.

To test you should be using a browser with a tool for inspecting
cookies. View the cookies for your Koha domain under each of these
conditions, clearing cookies between each step:

Without the patch applied:

 - With  BrowseResultSelection enabled, search for any item. Your cookie
   tool should report that you have a bibs_selected cookie stored.
 - With BrowseResultSelection disabled, search for any item. You should
   have a bibs_selected cookie.

With the patch applied:

 - With the BrowseResultSelection system preference enabled, search for
   any item. Your cookie tool should report that you have a
   bibs_selected cookie stored.
 - With BrowseResultSelection disabled, search for any item. You should
   have no bibs_selected cookie.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 23:18:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 21:18:03 +0000
Subject: [Koha-bugs] [Bug 20967] New: 'Add to cart' button in intranet
	doesn't work
Message-ID: <bug-20967-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20967

            Bug ID: 20967
           Summary: 'Add to cart' button in intranet doesn't work
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

To test:
- In intranet, check several search results
- Click 'Add to cart' button on top of the results list
- Nothing will happen

There is a JavaScript error:
ReferenceError: getContextBiblioNumbers is not defined[Learn More]

Adding single entries using the link in the search entry itself still works
alright.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 23:23:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 21:23:19 +0000
Subject: [Koha-bugs] [Bug 13680] Items list on edit items page separates add
 items form from header and sidebar
In-Reply-To: <bug-13680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13680-70-vZ3b3U17VB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680

Heather <heather_hernandez at nps.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |heather_hernandez at nps.gov

--- Comment #16 from Heather <heather_hernandez at nps.gov> ---
I'm just looking at this for the first time, and I am a cataloger.:)  I would
love ANYTHING that gets me away from scrolling down through 200+ items to add
an item!!!

I can live with the modal--I often copy from an existing item in the table &
paste into the new item, and with the model I'd simply do that from another
browser tab, easy-peasy.

My dream is that the "Actions" buttons (on the items in the item table) would
have a "Duplicate" action that would allow me to clone an item that duplicated
that item exactly except for $d and $p and I could then add a new barcode, edit
the $h and/or $t and be done.  Until then, this modal add item is a HUGE
improvement.  (Now, if I could get that "Duplicate" in the "Actions" button and
launch that new item modal like this, I'd be living the dream!)

I like the "View" button.  I'm most often going directly from item editing to
bib record editing (with Advanced Editor/Rancor), so don't mind one more click
to get to "Normal."  (I edit items first then go to Rancor because starting
with Rancor then "Edit items" opens editing the items another tab, which I find
annoying--I'd prefer it staying in the same tab.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 23:23:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 21:23:20 +0000
Subject: [Koha-bugs] [Bug 20863] Delete bib_list and intranet_bib_list
 cookies when cart is emptied out
In-Reply-To: <bug-20863-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20863-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20863-70-Y3I4Yln5Yz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20863

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Retested: In staff it worked nicely (apart from bug 20967 found), but in the
OPAC  the bib_selected cookie remained with a value of %5B%5D after emptying
the cart.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 23:29:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 21:29:15 +0000
Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be
 write as description, not code
In-Reply-To: <bug-20806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20806-70-WpInvkVzMp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Failed QA

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think with the change to "Requested item type" the patch makes sense to me.
Only thing I'd is a check for the AllowHoldItemTypeSelection system preference
to decide about showing it or not.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 23:42:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 21:42:40 +0000
Subject: [Koha-bugs] [Bug 20702] Bind results of GetHostItemsInfo to the
 EasyAnalyticalRecords pref
In-Reply-To: <bug-20702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20702-70-S3xj118YCu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20702

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75195|0                           |1
        is obsolete|                            |

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 76198
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76198&action=edit
Bug 20702: Bind results of GetHostItemsInfo to the EasyAnalyticalRecords pref

Triggered by the finding on bug 20697.
The three calls of GetHostItemsInfo should be controlled by the pref. This
patch makes the sub return an empty list when the pref is disabled.

The patch simplifies the sub by merging the two identical foreach loops
depending on the field number in MARC21/UNIMARC.

Will add a unit test on a follow-up patch.

Test plan:
See next patch.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 23:42:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 21:42:36 +0000
Subject: [Koha-bugs] [Bug 20702] Bind results of GetHostItemsInfo to the
 EasyAnalyticalRecords pref
In-Reply-To: <bug-20702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20702-70-CztXHXQpx0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20702

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75194|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 76197
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76197&action=edit
Bug 20702: Add unit tests for GetHostItemsInfo

Unfortunately, we did not have unit tests yet.
Adding some simple tests that test basic operation of the sub when the
pref is enabled/disabled and for MARC21/UNIMARC.

Test plan:
[1] Run t/db_dependent/Items/GetHostItemsInfo.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 23:43:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 21:43:28 +0000
Subject: [Koha-bugs] [Bug 20702] Bind results of GetHostItemsInfo to the
 EasyAnalyticalRecords pref
In-Reply-To: <bug-20702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20702-70-0BQ8s3OhUW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20702

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 23:46:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 21:46:15 +0000
Subject: [Koha-bugs] [Bug 20501] Unhighlight in search results when the
 search terms contain the same word twice removes the word
In-Reply-To: <bug-20501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20501-70-jDSjt27e9s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20501

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I can reproduce this: I searched for "the the". Unhighlighting removes the
first occurrence of the word in the result list. (intranet only)

>From the sample data:
        The ideas behind the chess openings / Reuben Fine. 
Turns into:
        ideas behind the chess openings / Reuben Fine.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 19 23:54:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 21:54:49 +0000
Subject: [Koha-bugs] [Bug 19799] Changing language on OPAC redirects back to
	homepage
In-Reply-To: <bug-19799-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19799-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19799-70-qNbrypMEqb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19799

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This seems to work alright in my devbox on master. Could someone confirm for
18.05?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 00:18:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 22:18:37 +0000
Subject: [Koha-bugs] [Bug 19719] Add a new column for collection in the
 patron checkouts data table
In-Reply-To: <bug-19719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19719-70-KwqHNvJ5YP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719

--- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 76199
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76199&action=edit
Bug 19719: (follow-up) Add database update to keep collection column hidden

For existing installations we want to keep the current behaviour.
This patch adds the column configuration to hide the collection
column from the details and checkouts tabs until toggled.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 00:19:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 22:19:07 +0000
Subject: [Koha-bugs] [Bug 19719] Add a new column for collection in the
 patron checkouts data table
In-Reply-To: <bug-19719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19719-70-y8CYnYCWR7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719

--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Proposed a database update :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 00:21:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 22:21:27 +0000
Subject: [Koha-bugs] [Bug 20962] Overhaul to notices
In-Reply-To: <bug-20962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20962-70-NPdi2Lan28@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20962

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 00:25:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 22:25:29 +0000
Subject: [Koha-bugs] [Bug 20962] Overhaul to notices
In-Reply-To: <bug-20962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20962-70-TDb78JosGB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20962

--- Comment #6 from Lisette <lisetteslatah at gmail.com> ---
(In reply to Hugh Rundle from comment #0)
> 
> # Step 3 - option to process all print notices together
> 

It would be great if this could use the hierarchical groups function added in
bug 16735 so that groups/districts in consortia could benefit from this
enhancement. 
Lisette Scheer

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 01:39:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 23:39:11 +0000
Subject: [Koha-bugs] [Bug 20921] Expose borrowernumber and branch when user
 is logged in to OPAC
In-Reply-To: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20921-70-FK233PwFmn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 01:39:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jun 2018 23:39:14 +0000
Subject: [Koha-bugs] [Bug 20921] Expose borrowernumber and branch when user
 is logged in to OPAC
In-Reply-To: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20921-70-wzasCXJneQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76005|0                           |1
        is obsolete|                            |

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 76200
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76200&action=edit
Bug 20921: Add borrowernumber and branchcode as html attributes

To test:
1 - Apply patch
2 - Visit the opac
3 - Sign in
4 - You should not see any difference
5 - Inspect the element  'Welcome, {username}'
6 - Note the attributes for borrowernumber and branchcode
7 - Add to OPACUserJS:
$(document).ready(function(){
    console.log( $(".loggedinusername").attr('data-branchcode'));
    console.log( $(".loggedinusername").attr('data-borrowernumber'));
});
8 - Check the console and note you can see the info expected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 02:19:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 00:19:43 +0000
Subject: [Koha-bugs] [Bug 20945] Report params not escaped when downloading
In-Reply-To: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20945-70-c594xl5bbf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Ah, I don't see it in Chrome, but I do in Firefox, what browser are you using?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 08:14:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 06:14:42 +0000
Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
In-Reply-To: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20664-70-RqimIoHpf1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76046|0                           |1
        is obsolete|                            |

--- Comment #12 from Ere Maijala <ere.maijala at helsinki.fi> ---
Comment on attachment 76046
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76046
Bug 20664: Optimize retrieval of biblio and item data

I need to come up with a better mechanism for avoiding unnecessary query
preparation since statements cached in state variables may become stale.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 08:33:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 06:33:27 +0000
Subject: [Koha-bugs] [Bug 20945] Report params not escaped when downloading
In-Reply-To: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20945-70-LH6TowOZ9r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Firefox - maybe a different version? But it trying to be smart could explain.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 08:39:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 06:39:23 +0000
Subject: [Koha-bugs] [Bug 18268] Notices no longer sent;
 resending when Patron Messaging Preference changed
In-Reply-To: <bug-18268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18268-70-xS9aHSrdnB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18268

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |WONTFIX
             Status|NEW                         |RESOLVED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Christopher, I am sorry, but 3.22 is end of life and doesn't receive any bug
fixes or updates any more. It's hard to tell what might have gone wrong there,
so not sure how to test this in newer versions. If you find there is still a
problem in 17.05 upwards, please reopen.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 10:33:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 08:33:47 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-BIK1TW7tuw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #131 from Benjamin Rokseth <benjamin.rokseth at deichman.no> ---
Hi, regarding performance and db update/migrate:
we have it in production now and tested quite abit up front.

db migrate took ~40sec as I recall (1,5M items and 400k biblios) which is far
less than the updates of statistics column took, for instance. We had 830
duplicate items that could not be moved. 

regarding performance there is nothing in this patchset that will degrade
performance, unless, say, you have a report query for all items, which now
would need to add 'WHERE deleted_on IS NULL' not to include deleted items

on the other hand, union queries of items and deleteditems are no longer
neccessary so statistical queries will be faster

When we move on to merge issues and reserves, the question is more relevant, as
10 years of checkout history might lead to 100M+ rows, but still, MySql is
capable of billions, and at that point its more a matter of indexes, RAM and
physics.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 10:35:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 08:35:38 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates
	(oldstable/17.11.x)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-hOT0p8J99l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 10:36:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 08:36:09 +0000
Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates
	(oldstable/17.11.x)
In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17111-70-vtk0KU55hC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76095|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 10:48:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 08:48:49 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-7k0xvBPT4O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #132 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Benjamin, you are right, I was mostly thinking about issues/old_issues. But
another question: When we moved marcxml we managed to add a nice conversion
tool for the reports that seems to work quite well. Could we do the same for
those tables? I think detecting the problematic reports and highlighting them
should be no issue, converting might be harder.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 12:37:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 10:37:40 +0000
Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests
 periods overlap with existing reserves
In-Reply-To: <bug-15261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15261-70-OyoFdCUNoB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #56 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Oups there is an obsolete : use C4::Branch in
t/db_dependent/Circulation/CanBookBeIssued.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 12:38:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 10:38:03 +0000
Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests
 periods overlap with existing reserves
In-Reply-To: <bug-15261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15261-70-xzX63RStmA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 13:46:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 11:46:31 +0000
Subject: [Koha-bugs] [Bug 20968] New: Plugins: Add hooks to enable plugin
 integration into catalogue
Message-ID: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

            Bug ID: 20968
           Summary: Plugins: Add hooks to enable plugin integration into
                    catalogue
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew.isherwood at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

This bug will add Koha Plugin hooks into catalogue related code allowing
integration into areas such as
koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 13:46:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 11:46:46 +0000
Subject: [Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin
 integration into catalogue
In-Reply-To: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20968-70-HA75mkRWOV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ
                   |ity.org                     |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 13:47:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 11:47:37 +0000
Subject: [Koha-bugs] [Bug 20898] Replace OPAC detail's results browser with
 non-JavaScript version
In-Reply-To: <bug-20898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20898-70-m859sSPSdG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20898

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75889|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 13:51:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 11:51:54 +0000
Subject: [Koha-bugs] [Bug 20945] Report params not escaped when downloading
In-Reply-To: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20945-70-S8UlYit4ai@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #4)
> Firefox - maybe a different version? But it trying to be smart could explain.

My version: 61.0b13

Just to check, that URL you pasted is the report url, I meant the URL of the
download links.

To download as tab I get:
http://localhost:8081/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Export&format=tab&report_id=13&reportname=Test&sql_params=%25&param_name=Enter|Asort1

Versus the report URL:
http://localhost:8081/cgi-bin/koha/reports/guided_reports.pl?reports=13&phase=Run+this+report&param_name=Enter%7CAsort1&sql_params=%2525#

Notice the param changes from:
%2525 in the report URL
to
%25 in the download URL

This has the effect of running the report with param as '%' when downloading
(because it translates %25 as an html code)

The results will download, however, they will include all the barcodes, instead
of the limited set it should be

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 14:05:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 12:05:13 +0000
Subject: [Koha-bugs] [Bug 20967] 'Add to cart' button in intranet doesn't
	work
In-Reply-To: <bug-20967-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20967-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20967-70-Bd02rRsE2r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20967

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
I cannot reproduce this bug. I tried in Firefox, Chrome, and Opera on Windows
10.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 14:07:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 12:07:34 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
	source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-sOqz91YzYU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75118|0                           |1
        is obsolete|                            |

--- Comment #75 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 76201
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76201&action=edit
Bug 14957 - Rule based permission for MARC fields

Change "MARC permissions" to "MARC merge rules" since
this is more descriptive of the feature provided.

Update help page to reflect changes since large refactorization.

Replace outdated tests with up to date tests.

Improve rules admin UI adding "preset" setting.

Move large part of added C4::Biblio code into Koha:: namespace.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 14:10:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 12:10:24 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
	source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-UbVKSc2R7g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76201|0                           |1
        is obsolete|                            |

--- Comment #76 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 76202
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76202&action=edit
Bug 14957 - Rule based permission for MARC fields

Add a rule based permission system for MARC field modifications.

Test plan:
    1. Apply this patch
    2. Run updatedatabase.pl
    3. Log in to staff client
    4. Enable new syspref MARCPermissions
    5. You should see a new link "MARC field permissions" in the "Catalog"
       section under "Koha administrtion".
    6. Go to the "MARC field permissions" page
    7. Next to the page heading ("Manage MARC field permissions") there is a
       button with a question mark, click this for more information about the
       rule system.
    8. Add desired rules to the rule table, press the +-button to add.
    9. Clicking the pen-icon (edit) should allow you to edit corresponding
rule.
    10. Clicking the x-icon should remove corresponding rule after
confirmation.
    11. Selecting one or more rules followed by clicking the trash-icon
        should remove all selected rules after confirmation.
    12. To test your rules, import or in other way modify a record.
    13. Check that the record was modified as defined by your rules.

Sponsored-by: Halland County Library
Sponsored-by: Catalyst IT
Sponsored-by: Gothenbug University Library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 14:10:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 12:10:30 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
	source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-gYoSZOWlpF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #77 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 76203
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76203&action=edit
Bug 14957 - Rule based permission for MARC fields

Change "MARC permissions" to "MARC merge rules" since
this is more descriptive of the feature provided.

Update help page to reflect changes since large refactorization.

Replace outdated tests with up to date tests.

Improve rules admin UI adding "preset" setting.

Move large part of added C4::Biblio code into Koha:: namespace.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 14:10:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 12:10:55 +0000
Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface
In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20935-70-6jVCyBnaWA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Caroline Cyr La Rose from comment #5)
> When I apply the patch, it doesn't look the same as the screenshots.

Did you clear your browser cache? That could explain the difference in what you
see.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 14:11:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 12:11:38 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
	source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-QbwVTTaQF4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76202|0                           |1
        is obsolete|                            |
  Attachment #76203|0                           |1
        is obsolete|                            |

--- Comment #78 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 76204
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76204&action=edit
Bug 14957 - Rule based permission for MARC fields

Add a rule based permission system for MARC field modifications.

Test plan:
    1. Apply this patch
    2. Run updatedatabase.pl
    3. Log in to staff client
    4. Enable new syspref MARCPermissions
    5. You should see a new link "MARC field permissions" in the "Catalog"
       section under "Koha administrtion".
    6. Go to the "MARC field permissions" page
    7. Next to the page heading ("Manage MARC field permissions") there is a
       button with a question mark, click this for more information about the
       rule system.
    8. Add desired rules to the rule table, press the +-button to add.
    9. Clicking the pen-icon (edit) should allow you to edit corresponding
rule.
    10. Clicking the x-icon should remove corresponding rule after
confirmation.
    11. Selecting one or more rules followed by clicking the trash-icon
        should remove all selected rules after confirmation.
    12. To test your rules, import or in other way modify a record.
    13. Check that the record was modified as defined by your rules.

Sponsored-by: Halland County Library
Sponsored-by: Catalyst IT
Sponsored-by: Gothenbug University Library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 14:11:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 12:11:43 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
	source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-jKn6Z8K3Xa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #79 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 76205
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76205&action=edit
Bug 14957 - Refactor and fix tests and documention

Change "MARC permissions" to "MARC merge rules" since
this is more descriptive of the feature provided.

Update help page to reflect changes since large refactorization.

Replace outdated tests with up to date tests.

Improve rules admin UI adding "preset" setting.

Move large part of added C4::Biblio code into Koha:: namespace.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 14:12:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 12:12:36 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
	source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-7ugvHIZ3SN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #81 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 76207
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76207&action=edit
Bug 14957 - Refactor and fix tests and documentation

Change "MARC permissions" to "MARC merge rules" since
this is more descriptive of the feature provided.

Update help page to reflect changes since large refactorization.

Replace outdated tests with up to date tests.

Improve rules admin UI adding "preset" setting.

Move large part of added C4::Biblio code into Koha:: namespace.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 14:12:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 12:12:31 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
	source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-qchmk3GBes@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76204|0                           |1
        is obsolete|                            |

--- Comment #80 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 76206
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76206&action=edit
Bug 14957 - Rule based permission for MARC fields

Add a rule based permission system for MARC field modifications.

Test plan:
    1. Apply this patch
    2. Run updatedatabase.pl
    3. Log in to staff client
    4. Enable new syspref MARCPermissions
    5. You should see a new link "MARC field permissions" in the "Catalog"
       section under "Koha administrtion".
    6. Go to the "MARC field permissions" page
    7. Next to the page heading ("Manage MARC field permissions") there is a
       button with a question mark, click this for more information about the
       rule system.
    8. Add desired rules to the rule table, press the +-button to add.
    9. Clicking the pen-icon (edit) should allow you to edit corresponding
rule.
    10. Clicking the x-icon should remove corresponding rule after
confirmation.
    11. Selecting one or more rules followed by clicking the trash-icon
        should remove all selected rules after confirmation.
    12. To test your rules, import or in other way modify a record.
    13. Check that the record was modified as defined by your rules.

Sponsored-by: Halland County Library
Sponsored-by: Catalyst IT
Sponsored-by: Gothenbug University Library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 14:15:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 12:15:07 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
	source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-9ERt22IezP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76205|0                           |1
        is obsolete|                            |
  Attachment #76206|0                           |1
        is obsolete|                            |

--- Comment #82 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 76208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76208&action=edit
Bug 14957 - Rule based permission for MARC fields

Add a rule based permission system for MARC field modifications.

Test plan:
    1. Apply this patch
    2. Run updatedatabase.pl
    3. Log in to staff client
    4. Enable new syspref MARCPermissions
    5. You should see a new link "MARC field permissions" in the "Catalog"
       section under "Koha administrtion".
    6. Go to the "MARC field permissions" page
    7. Next to the page heading ("Manage MARC field permissions") there is a
       button with a question mark, click this for more information about the
       rule system.
    8. Add desired rules to the rule table, press the +-button to add.
    9. Clicking the pen-icon (edit) should allow you to edit corresponding
rule.
    10. Clicking the x-icon should remove corresponding rule after
confirmation.
    11. Selecting one or more rules followed by clicking the trash-icon
        should remove all selected rules after confirmation.
    12. To test your rules, import or in other way modify a record.
    13. Check that the record was modified as defined by your rules.

Sponsored-by: Halland County Library
Sponsored-by: Catalyst IT
Sponsored-by: Gothenbug University Library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 14:15:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 12:15:16 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
	source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-T3Hy7ZvlkZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76207|0                           |1
        is obsolete|                            |

--- Comment #83 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 76209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76209&action=edit
Bug 14957 - Refactor and fix tests and documentation

Change "MARC permissions" to "MARC merge rules" since
this is more descriptive of the feature provided.

Update help page to reflect changes since large refactorization.

Replace outdated tests with up to date tests.

Improve rules admin UI adding "preset" setting.

Move large part of added C4::Biblio code into Koha:: namespace.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 14:16:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 12:16:07 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
	source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-T1q2t41Mph@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #84 from David Gustafsson <glasklas at gmail.com> ---
Sorry about the many attachments, had some issues adding the latest patch. Now
everything should be in order.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 14:17:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 12:17:02 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
	source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-W2nM3z7K6p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 14:23:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 12:23:18 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
	source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-Lro9ahWeVp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #85 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 76210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76210&action=edit
Bug 14957 - Remove exports of removed subroutines

Remove exports of subroutines previously removed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 14:27:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 12:27:58 +0000
Subject: [Koha-bugs] [Bug 20969] New: Use modal to add and edit notes from
	basket
Message-ID: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969

            Bug ID: 20969
           Summary: Use modal to add and edit notes from basket
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

Created attachment 76211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76211&action=edit
Screenshot showing note edit form in modal

When looking at orders in a basket, each order has links to add or edit vendor
and internal notes. I propose that we move a copy of the notes edit form to the
basket template so that a modal can be used to edit notes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 14:40:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 12:40:57 +0000
Subject: [Koha-bugs] [Bug 20969] Use modal to add and edit notes from basket
In-Reply-To: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20969-70-kiiGtZV1J8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 14:41:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 12:41:00 +0000
Subject: [Koha-bugs] [Bug 20969] Use modal to add and edit notes from basket
In-Reply-To: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20969-70-QicC0aXIN5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76212&action=edit
Bug 20969: Use modal to add and edit notes from basket

This patch modifies the acquisitions basket page so that links to add or
edit vendor or internal notes trigger a modal with the notes edit form
instead of redirecting to a different page. This is a markup change only
-- The form still submits to modordernotes.pl.

To test, apply the patch and view a basket in acquisitions which has
multiple orders. Test various note controls:  Add internal note, Add
vendor note, Edit internal note, edit vendor note.

Confirm that the operations work correctly with multiple orders in the
basket.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 15:43:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 13:43:30 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-a7OtFRpAwP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14919, 20806


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919
[Bug 14919] Holds history for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806
[Bug 20806] Item type in holds history table should be write as description,
not code
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 15:43:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 13:43:30 +0000
Subject: [Koha-bugs] [Bug 14919] Holds history for patrons
In-Reply-To: <bug-14919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14919-70-HqtPifit6i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20936


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936
[Bug 20936] Holds History for patrons in OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 15:43:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 13:43:30 +0000
Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be
 write as description, not code
In-Reply-To: <bug-20806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20806-70-hq21ljBVsp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20936


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936
[Bug 20936] Holds History for patrons in OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 15:44:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 13:44:03 +0000
Subject: [Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin
 integration into catalogue
In-Reply-To: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20968-70-UPiQr26VBh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 15:52:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 13:52:13 +0000
Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface
In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20935-70-e7StnoyiIg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 15:53:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 13:53:09 +0000
Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout
 form, with collapsed settings panel
In-Reply-To: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20959-70-SydPuq9PIn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 15:53:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 13:53:30 +0000
Subject: [Koha-bugs] [Bug 20966] Add column configuration to table of orders
	in a basket
In-Reply-To: <bug-20966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20966-70-l6rYH1LloJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20966

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 15:53:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 13:53:52 +0000
Subject: [Koha-bugs] [Bug 20969] Use modal to add and edit notes from basket
In-Reply-To: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20969-70-BMhqwoK7E1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 15:55:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 13:55:12 +0000
Subject: [Koha-bugs] [Bug 20949] Koha depends on Clone
In-Reply-To: <bug-20949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20949-70-Xu2AhBhRTg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20949

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 15:57:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 13:57:39 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-cNFY4MROxp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 17:50:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 15:50:22 +0000
Subject: [Koha-bugs] [Bug 15773] Checkboxes do not work correctly when
 creating a new subfield for an authority framework
In-Reply-To: <bug-15773-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15773-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15773-70-y1JmQMfKS3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15773

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
*** Bug 15771 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 17:50:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 15:50:22 +0000
Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
In-Reply-To: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13618-70-AY11C6RJp1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|15771                       |
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=15771


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15771
[Bug 15771] CGI::escapeHTML should not be used anymore
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 17:50:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 15:50:22 +0000
Subject: [Koha-bugs] [Bug 15771] CGI::escapeHTML should not be used anymore
In-Reply-To: <bug-15771-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15771-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15771-70-YQ78sqfS6T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15771

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|BLOCKED                     |RESOLVED
         Depends on|13618                       |
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13618

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Occurrences of CGI::escapeHTML have been removed by bug 15773.

*** This bug has been marked as a duplicate of bug 15773 ***


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
[Bug 13618] Prevent XSS in the Staff Client and the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 17:54:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 15:54:29 +0000
Subject: [Koha-bugs] [Bug 20130] matching authorities the difference shows
	biblionumber
In-Reply-To: <bug-20130-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20130-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20130-70-sljugsdOXl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20130

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE
                 CC|                            |joy at bywatersolutions.com

--- Comment #1 from Joy Nelson <joy at bywatersolutions.com> ---
This is a duplicate of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16954

*** This bug has been marked as a duplicate of bug 16954 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 17:54:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 15:54:29 +0000
Subject: [Koha-bugs] [Bug 16954] Add the diff view to authorities in staged
	MARC records
In-Reply-To: <bug-16954-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16954-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16954-70-EFwCZ90Nht@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16954

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hagud at orex.es

--- Comment #5 from Joy Nelson <joy at bywatersolutions.com> ---
*** Bug 20130 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 18:00:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 16:00:08 +0000
Subject: [Koha-bugs] [Bug 15771] CGI::escapeHTML should not be used anymore
In-Reply-To: <bug-15771-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15771-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15771-70-tpBm4Dv6Xp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15771
Bug 15771 depends on bug 15754, which changed state.

Bug 15754 Summary: html tags displayed when editing frameworks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15754

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |CLOSED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 18:00:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 16:00:08 +0000
Subject: [Koha-bugs] [Bug 15754] html tags displayed when editing frameworks
In-Reply-To: <bug-15754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15754-70-kyayURpvxD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15754

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|BLOCKED                     |CLOSED

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
With bug 15773 we do not longer need these patches for bug 13618.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 18:00:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 16:00:45 +0000
Subject: [Koha-bugs] [Bug 20970] New: Reformat basket information on
 acquisitions basket page
Message-ID: <bug-20970-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970

            Bug ID: 20970
           Summary: Reformat basket information on acquisitions basket
                    page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

Created attachment 76213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76213&action=edit
GIF showing new forms interaction

I'd like to propose a couple of minor changes to the way information and forms
are displayed on the acquisitions basket view page:

- Hide form controls until the user clicks a link
- Move some information into the second column to make it a little more
balanced.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 18:02:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 16:02:51 +0000
Subject: [Koha-bugs] [Bug 17625] 245f and 245g are not mapped to subtitle in
 Keyword to MARC mapping
In-Reply-To: <bug-17625-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17625-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17625-70-EUDRx6zmfk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17625

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 18:12:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 16:12:06 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-e6PztJDlDA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 18:16:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 16:16:07 +0000
Subject: [Koha-bugs] [Bug 20970] Reformat basket information on acquisitions
	basket page
In-Reply-To: <bug-20970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20970-70-KKMJMBEBio@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 18:16:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 16:16:09 +0000
Subject: [Koha-bugs] [Bug 20970] Reformat basket information on acquisitions
	basket page
In-Reply-To: <bug-20970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20970-70-3wYkI5vf6C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76214&action=edit
Bug 20970: Reformat basket information on acquisitions basket page

This patch reformats the display of information on the acquisitions
basket page, hiding form controls until they are triggered. Some basket
information is now in the second column in order to balance the two
columns better.

The "Library" label has been replaced with the more precise "Managing
library."

Unrelated change: Removed script type attributes.

To test, apply the patch and view a basket in acquisitions. Test these
processes:

- Adding and removing managing users
- Setting and changing managing library
- Setting and changing basket group

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 18:26:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 16:26:57 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-N1yWQcLwcP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 18:40:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 16:40:42 +0000
Subject: [Koha-bugs] [Bug 20848] Add the ability to batch renew or easily
 renew relative checkouts attached to the guarantor
In-Reply-To: <bug-20848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20848-70-NKKlHGk6at@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20848

Taneyhills Library <taneyhills at suddenlinkmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |taneyhills at suddenlinkmail.c
                   |                            |om

--- Comment #1 from Taneyhills Library <taneyhills at suddenlinkmail.com> ---
Kelly created this thread in response to my help ticket. Renewing items for
family accounts is indeed a time consuming process.

Yes, the Relative's Checkouts tab is helpful for viewing which accounts have
items that need renewing, but to execute the renewal you still have to go to
each account to renew individually, then navigate back and forth between
guarantor's and guarantees' accounts to make sure you got everybody. This is
challenging for some of my less capable front desk volunteers, and even for
professional staff when it's busy at the desk. Inevitably a family member's
account gets overlooked, resulting in late fines, etc.

Further complicating matters is the fact that spouses are not linked to the
guarantor like child guarantees are. Their checkouts do not show up on the
Relative's Checkouts tab at all.

I would LOVE to see family accounts streamlined in some way that makes item
renewal easier. Maybe making all items on linked accounts (for children AND
spouses) viewable and renewable on a single page.

This is only one change I would like to see for family accounts. Please see my
comments on related thread
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20847

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 18:49:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 16:49:53 +0000
Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
In-Reply-To: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13618-70-HewLuTKjcS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|https://github.com/joubu/Ko |https://gitlab.com/joubu/Ko
                   |ha/tree/bug_13618           |ha/tree/bug_13618
             Status|ASSIGNED                    |Needs Signoff

--- Comment #217 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Patches have been rebased, adjusted for master and push to
https://gitlab.com/joubu/Koha/tree/bug_13618

They do not deal with performance issues but are ready to be tested (to catch
missing .raw)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 18:51:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 16:51:17 +0000
Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
In-Reply-To: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13618-70-bSsQ42MXSk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59983|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 18:51:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 16:51:21 +0000
Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
In-Reply-To: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13618-70-MCAGo0mtKU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59984|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 18:51:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 16:51:23 +0000
Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
In-Reply-To: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13618-70-JcqQc4Z2kc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59987|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 18:52:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 16:52:41 +0000
Subject: [Koha-bugs] [Bug 13655] Can't save organisation type patron without
 entering userid/password
In-Reply-To: <bug-13655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13655-70-K11NhNjGTr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13655

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
ping Josef?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 19:12:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 17:12:27 +0000
Subject: [Koha-bugs] [Bug 20931] JS error "ReferenceError: $ is not defined"
 when CircSidebar is turned on
In-Reply-To: <bug-20931-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20931-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20931-70-F2xgZ3gcgM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20931

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 19:27:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 17:27:18 +0000
Subject: [Koha-bugs] [Bug 20847] Add the fields to the Batch Patron
	Modification tool
In-Reply-To: <bug-20847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20847-70-XGzAYeN2Ub@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20847

Taneyhills Library <taneyhills at suddenlinkmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |taneyhills at suddenlinkmail.c
                   |                            |om

--- Comment #2 from Taneyhills Library <taneyhills at suddenlinkmail.com> ---
Being able to quickly modify phone number, email address, physical address,
expiration date, and status from "new" to "renew" would greatly improve our
work flow at the front desk. Currently we have to go to each account
individually to edit these fields, which increases the chance of mistakes or of
someone's account getting overlooked.

Honestly, I would love to see a head to toe streamlining of family accounts.
(Please see my comments on item renewals (
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20848 ).

We are a small library so we have a six item limit on library cards. Families
who come in with many children and many cards are challenging for our front
desk staff. The families think of themselves as a single unit, so they want to
renew ALL of their items or to know quickly what books are checked out on
everyone's cards. But we have to go to each account individually to do these
things, which takes time and leads to mistakes.

Paying fines on family accounts, for example, is problematic because we have to
go to each account for the individual amounts owed, then total them up on
paper, then remember to go to each account after payment to clear the fines.

Some of our patrons talk about other libraries they have been to that issue ONE
card to a family, and everyone in the family uses that single account. We have
considered this, but have reasons for not wanting to adopt that format at our
library (mainly how it would affect circulation stats). But streamlining family
accounts in KOHA, and linking family members so that some of these tasks I've
mentioned are one-click, would be an absolute godsend.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 19:33:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 17:33:05 +0000
Subject: [Koha-bugs] [Bug 20931] JS error "ReferenceError: $ is not defined"
 when CircSidebar is turned on
In-Reply-To: <bug-20931-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20931-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20931-70-j4Y1DzuMDJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20931

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76215&action=edit
Bug 20931: JS error "ReferenceError: $ is not defined" when CircSidebar is
turned on

This patch reorganizes the way sidebar menus get highlighted based on
the current page. A global function is added to handle most cases.
Individual menu-handling scripts have been modified to handle only the
edge cases which aren't covered by the global one.

A new class is added to the global CSS file so that highlighted menu
links can be custom-styled.

To test, apply the patch and clear your cache if necessary.

View various pages to confirm that current-page-highlighting in the
sidebar menu is working correctly and that there are no JS errors in the
browser console. For example:

 - Administration -> Currencies and exchange rates.
 - Acquisitions -> Invoices
 - Tools -> Patron lists
 - Tools -> Export

And with CircSidebar turned on test various circulation pages, e.g.

 - Circulation -> Set library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 19:33:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 17:33:01 +0000
Subject: [Koha-bugs] [Bug 20931] JS error "ReferenceError: $ is not defined"
 when CircSidebar is turned on
In-Reply-To: <bug-20931-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20931-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20931-70-Ixkojs3CVE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20931

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 19:37:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 17:37:36 +0000
Subject: [Koha-bugs] [Bug 20890] Can't locate Koha/Template/Plugin/String.pm
	error
In-Reply-To: <bug-20890-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20890-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20890-70-OLr2sXqnji@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20890

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 19:38:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 17:38:53 +0000
Subject: [Koha-bugs] [Bug 8634] Themes should be user-selectable
In-Reply-To: <bug-8634-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8634-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8634-70-sCFncL95Cw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8634

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 19:56:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 17:56:00 +0000
Subject: [Koha-bugs] [Bug 20948] Hold requests on detail.pl
In-Reply-To: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20948-70-LZm3gHsYrK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948

--- Comment #4 from Lisette <lisetteslatah at gmail.com> ---
Created attachment 76216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76216&action=edit
Misleading Hold Info - In Transit

I noticed today that there is also misleading hold info on the 'Holds' table on
moremembers.pl and circulation.pl. It will list "In Transit from X branch since
Y" even if that patron is not the next patron. This also only happens with item
level holds. 
I'm happy to fill out a different bug, but I thought it might be related based
on how the information is getting pulled. 
Lisette Scheer

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 20:23:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 18:23:37 +0000
Subject: [Koha-bugs] [Bug 17625] 245f and 245g are not mapped to subtitle in
 Keyword to MARC mapping
In-Reply-To: <bug-17625-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17625-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17625-70-fkfuvUKkQt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17625

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Just an idea - have you checked the visilibity settings in the framework
configuration for those 2 fields?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 20:29:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 18:29:38 +0000
Subject: [Koha-bugs] [Bug 20920] Plack timeout because of missing
 CGI::Compile Perl dependency
In-Reply-To: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20920-70-uvF5NjCumG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920

--- Comment #4 from Jerome Charaoui <jcharaoui at cmaisonneuve.qc.ca> ---
Created attachment 76217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76217&action=edit
bug 20920: patch to PerlDependencies.pm adding CGI::Compile

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 20:30:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 18:30:09 +0000
Subject: [Koha-bugs] [Bug 20920] Plack timeout because of missing
 CGI::Compile Perl dependency
In-Reply-To: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20920-70-S7P4fUQevS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920

Jerome Charaoui <jcharaoui at cmaisonneuve.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 20:36:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 18:36:17 +0000
Subject: [Koha-bugs] [Bug 17625] 245f and 245g are not mapped to subtitle in
 Keyword to MARC mapping
In-Reply-To: <bug-17625-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17625-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17625-70-5MsUDAc8Gl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17625

--- Comment #3 from Joy Nelson <joy at bywatersolutions.com> ---
Hi Katrin, They are set to show in the frameworks.  In the xslt it appears the
f subfield was removed by bug 13881?  I'm planning on submitting a patch for
this.  Can you think of anything else that I might be missing?

-joy  


(In reply to Katrin Fischer from comment #2)
> Just an idea - have you checked the visilibity settings in the framework
> configuration for those 2 fields?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 20:36:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 18:36:05 +0000
Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting
	with plack
In-Reply-To: <bug-15562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15562-70-SkGnBBSE3s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562

--- Comment #74 from Jerome Charaoui <jcharaoui at cmaisonneuve.qc.ca> ---
(In reply to David Cook from comment #72)
> What's a "roll-up and rebase"? That's a roll-up of the existing patches as
> applied against a rebased branch?

Yes. I've combined the previous patches and rebased them on top of the current
master.

(In reply to David Cook from comment #73)
> Are you still having problems with Zebra with your updated patch?

Yeah, I wasn't able to fix that problem with rebuild_zebra.pl, which is quite a
blocker for me. I suspect many scripts like this one would need patching for
this to work correctly across the code base.

I've had more success with the patch proposed in bug 20630, which doesn't
require patching the application code, and hence all support scripts like
rebuild_zebra.pl work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 20:47:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 18:47:21 +0000
Subject: [Koha-bugs] [Bug 17625] 245f and 245g are not mapped to subtitle in
 Keyword to MARC mapping
In-Reply-To: <bug-17625-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17625-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17625-70-PvgQQrw4Fv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17625

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |Ah

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Ah right, I think the keywords to marc mapping doesn't work on the xslt detail
view?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 20:53:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 18:53:38 +0000
Subject: [Koha-bugs] [Bug 20630] An attempt at multitenancy with Mojolicious
In-Reply-To: <bug-20630-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20630-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20630-70-qA2IhPHNie@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20630

Jerome Charaoui <jcharaoui at cmaisonneuve.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jcharaoui at cmaisonneuve.qc.c
                   |                            |a

--- Comment #3 from Jerome Charaoui <jcharaoui at cmaisonneuve.qc.ca> ---
Created attachment 76218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76218&action=edit
bug 20630: Various improvements

Thank you for this patch. I've done some testing with it and it appears to work
great. Compared to Plack, this method is much more efficient and less
memory-hungry when running multiple instances. I'm currently using it to run 20
instances on a VM with 4GB of RAM, and will soon test with 120 instances on the
same host. I'll be sure to report any further issues and results here.

In the mean time, I'd like to share a patch which applies on top of the initial
one, improving it in the following ways:

* Use absolute paths instead of relative paths to allow deployment in the
context of (real-world) package-based installations
* Read a configuration file for the Mojo app
* Provide a systemd service for running the app using the optimized hypnotoad
server
* Provide a catch-all route for general 404 errors
* Add headers to instruct clients to cache static resources

I'm absolutely new to Mojolicious deployments so there might be better ways to
achieve these goals but I thought it would probably be better to share this
than let it soak in my local repository.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 21:15:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 19:15:26 +0000
Subject: [Koha-bugs] [Bug 20630] An attempt at multitenancy with Mojolicious
In-Reply-To: <bug-20630-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20630-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20630-70-9DegEqHrRA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20630

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 21:40:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 19:40:47 +0000
Subject: [Koha-bugs] [Bug 13655] Can't save organisation type patron without
 entering userid/password
In-Reply-To: <bug-13655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13655-70-aVnFaU6e2B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13655

--- Comment #11 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76219&action=edit
Screencast

Sorry, for delay. This is what I mean

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 22:52:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 20:52:00 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth matchpoint no longer works after
 upgrade to 17.11
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-8MRw5NBdh9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

--- Comment #12 from cking at uttyler.edu ---
>From what I'm seeing in the logs:
1. It starts shibboleth validation
(https://github.com/Koha-Community/Koha/blob/7f2ffda09f04adf0cfe244b48a09fb130752f330/C4/Auth.pm#L946)
with $shib = 1 and $shib_login = 5000120216
2. Within the call to checkpw, it first hits elseif ($ldap) and userid and
password are empty
(https://github.com/Koha-Community/Koha/blob/7f2ffda09f04adf0cfe244b48a09fb130752f330/C4/Auth.pm#L1776)
3. Builds the principal_name as [empty userid]@domain.edu
(https://github.com/Koha-Community/Koha/blob/7f2ffda09f04adf0cfe244b48a09fb130752f330/C4/Auth_with_ldap.pm#L146)
4. Fails LDAP bind with invalid principal name and empty password
(https://github.com/Koha-Community/Koha/blob/7f2ffda09f04adf0cfe244b48a09fb130752f330/C4/Auth_with_ldap.pm#L169)
with "LDAP error #48: LDAP_INAPPROPRIATE_AUTH The server requires the client
which had attempted to bind anonymously or without supplying credentials to
provide some form of credentials"
5. Back in checkpw
(https://github.com/Koha-Community/Koha/blob/7f2ffda09f04adf0cfe244b48a09fb130752f330/C4/Auth.pm#L1778),
retval is 0.
6. I do not make it into this elseif block
(https://github.com/Koha-Community/Koha/blob/7f2ffda09f04adf0cfe244b48a09fb130752f330/C4/Auth.pm#L1801)
7. The next error in the log is an uninitialized value in subroutine entry at
https://github.com/Koha-Community/Koha/blob/7f2ffda09f04adf0cfe244b48a09fb130752f330/C4/Auth.pm#L1911
8. And then
https://github.com/Koha-Community/Koha/blob/7f2ffda09f04adf0cfe244b48a09fb130752f330/C4/Auth.pm#L1159

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 00:41:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 22:41:32 +0000
Subject: [Koha-bugs] [Bug 13420] Holdings table sorting on volume
	information incorrect
In-Reply-To: <bug-13420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13420-70-H74EdBNZeY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420

emjhet at pa.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |emjhet at pa.net

--- Comment #10 from emjhet at pa.net ---
This is a pet peeve of mine. If a missed serial is donated at a later date, I
never get to see my serials in sequential order, because sorting by Vol
replicates what is seen above, while sorting by call number alphabetizes them
so all Aprils (regardless of year) are before all the Novembers. The only way
they are in order is if my barcodes are in order; that only happens if no
issues are missed or go walking.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 00:44:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 22:44:30 +0000
Subject: [Koha-bugs] [Bug 17685] Allow to receive double issues in serials
In-Reply-To: <bug-17685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17685-70-O1cK0ZX1kv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17685

emjhet at pa.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |emjhet at pa.net

--- Comment #4 from emjhet at pa.net ---
Any progress?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 01:50:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2018 23:50:55 +0000
Subject: [Koha-bugs] [Bug 5276] subscription end date shouldn't be required
 / allow indefinite subscriptions
In-Reply-To: <bug-5276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5276-70-kBUVjl8KiJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5276

emjhet at pa.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |emjhet at pa.net

--- Comment #2 from emjhet at pa.net ---
I agree. I would like to do away with the subscription expiration date and the
published on information.

Somehow a few of my serials were added either when a subscription expiration
date was not necessary (or I figured out, briefly, how to get away with not
adding one) and I wish I could get my other subscriptions to do the same.

I would also like to be able to fill in the following fields in the
subscription (one time) rather than fill them in for each and every item:
Collection code, Source of acquisition, and Shelving control no.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 08:59:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 06:59:51 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-DEghmsAxFC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #133 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I've done another round of testing and I'm reasonably happy that everything is
caught now.. though I was happy the first time.. Hoping to get another pair of
QA eye's on it and awaiting a followup with at least a warning during the
update database about reports needing to change if not a more thorough handling
to convert the simple cases automagically.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 09:28:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 07:28:56 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth matchpoint no longer works after
 upgrade to 17.11
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-BaUqiAsqci@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 76220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76220&action=edit
Bug 20879: Fix regression in shibboleth when ldap enabled

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 09:29:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 07:29:50 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth matchpoint no longer works after
 upgrade to 17.11
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-U5CTvYLUh9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Very well sleuthed!

Could you try out the patch attached and let me know if it resolves the problem
for you?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 09:42:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 07:42:12 +0000
Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests
 periods overlap with existing reserves
In-Reply-To: <bug-15261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15261-70-PF6mTKrt06@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #57 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Fridolin SOMERS from comment #55)
> Oups, looks like patch makes a lot of unwanted changes in
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref

Oh I found it :
Tabs instead of 4 spaces in many places.
This brakes the file which is a YAML.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 09:42:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 07:42:43 +0000
Subject: [Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used
 in the description
In-Reply-To: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20891-70-vLFGNMWxKT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
We have checked recent migration scripts that we adapted for several problems
with patron search. Problematic are afawk: backslash, double quotes,
non-printable and for some reason we also have \x11 to ae in there, but not
sure if that was just a presentation problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 09:48:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 07:48:48 +0000
Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests
 periods overlap with existing reserves
In-Reply-To: <bug-15261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15261-70-F7V86J77ol@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72956|0                           |1
        is obsolete|                            |

--- Comment #58 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 76221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76221&action=edit
Bug 15261: Verify if checkouts/reserves requests periods overlap...

... with existing reserves

When checking out or placing hold, we should check if an existing
reserve whose period overlap exists.

A user place an hold from opac whose requested period overlap an
existing reserve period => prevent reserve,

A librarian place an hold from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation),

A librarian make a checkout from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation).

Test plan:

Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture
  PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod

1 (staff side):
Place a hold on title (which has only one items) level with start date
and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are warned about an existing reserve

2 (staff side):
Place a hold on title (which has more than one items) level with start
date and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are NOT warned about an existing reserve. Because it remains
at least one item not reserved.

3 (staff side):
Place a hold on item level with start date and expiration date.
Place another hold on item level with period overlaping this reserve.
Check you are warned about an existing reserve.

4 (opac side):
Do the same than for staff side. Instead of a warn, reserve is
prevented.

5:
Place a hold on title (which has only one items) level with start date
and expiration date.
Try to checkout the unique item from this title with period overlaping
the reserve period.
Check you are warned about an existing reserve

6:
Place a hold on title (which has more than one items) level with start
date and expiration date.
Checkout an item from this title with period overlaping the reserve
period.
Check you are NOT warned about an existing reserve.

7:
Place a hold on item level with start date and expiration date.
Checkout this item period overlaping the reserve period.
Check you are warned about an existing reserve

Rabased on master
Rebased on master (2016-06-23)
Rebased on master (2017-03-23)
Rebased on master (2018-03-15)

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>
Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 09:48:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 07:48:56 +0000
Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests
 periods overlap with existing reserves
In-Reply-To: <bug-15261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15261-70-i3vHBMeqYi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72957|0                           |1
        is obsolete|                            |

--- Comment #59 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 76222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76222&action=edit
Bug 15261 - Check reserves while renewing an issue

Test plan:

  - Create an issue (i.e from 15/09/2017 to 04/10/2017),
  - place a reserve on the same item from 05/10/2017 to 30/10/2017),
  - enable PreventCheckoutOnSameReservePeriod,
  - Check that you are not able to renew the issue.

Rebased (2018-03-15)
Rebased-by: Alex Arnaud <alex.arnaud at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 09:50:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 07:50:37 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth in combination with LDAP as an
 alternative no longer works after upgrade to 17.11
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-Wn2GSPQpcS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Shibboleth matchpoint no    |Shibboleth in combination
                   |longer works after upgrade  |with LDAP as an alternative
                   |to 17.11                    |no longer works after
                   |                            |upgrade to 17.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 10:02:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 08:02:39 +0000
Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests
 periods overlap with existing reserves
In-Reply-To: <bug-15261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15261-70-hlwbYE6Saj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #60 from Alex Arnaud <alex.arnaud at biblibre.com> ---
(In reply to Fridolin SOMERS from comment #57)
> (In reply to Fridolin SOMERS from comment #55)
> > Oups, looks like patch makes a lot of unwanted changes in
> > koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
> 
> Oh I found it :
> Tabs instead of 4 spaces in many places.
> This brakes the file which is a YAML.

I have rebased the patches and removed unwanted changes on circulation.pref

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 10:25:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 08:25:08 +0000
Subject: [Koha-bugs] [Bug 20971] New: additem Corrupted storable string
Message-ID: <bug-20971-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20971

            Bug ID: 20971
           Summary: additem Corrupted storable string
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: pasi.kallinen at joensuu.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Sometimes additem.pl will complain about "Storable::thaw failed to thaw
LastCreatedItem-cookie.", see bug 14844. Now, actually fix the bug.

The bug is caused by trying to URI (un)escape MARC::Record, binary data.
We'll use a base64 url-safe version instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 10:26:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 08:26:47 +0000
Subject: [Koha-bugs] [Bug 20971] additem Corrupted storable string
In-Reply-To: <bug-20971-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20971-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20971-70-Zh2jGBrPp1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20971

paxed <pasi.kallinen at joensuu.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at joensuu.fi
                   |ity.org                     |

--- Comment #1 from paxed <pasi.kallinen at joensuu.fi> ---
Created attachment 76223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76223&action=edit
Perl script to demonstrate uri (un)escape problem and base64url correctness

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 10:28:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 08:28:33 +0000
Subject: [Koha-bugs] [Bug 20971] additem Corrupted storable string
In-Reply-To: <bug-20971-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20971-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20971-70-oiknTU9It4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20971

--- Comment #2 from paxed <pasi.kallinen at joensuu.fi> ---
Created attachment 76224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76224&action=edit
Bug 20971: additem Corrupted storable string

Sometimes additem.pl will complain about "Storable::thaw failed to
thaw LastCreatedItem-cookie.", see bug 14844. Now, actually fix the bug.

The bug is caused by trying to URI (un)escape MARC::Record, binary data.
We'll use a base64 url-safe version instead.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 10:29:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 08:29:06 +0000
Subject: [Koha-bugs] [Bug 14844] Corrupted storable string. When
 adding/editing an Item, cookie LastCreatedItem might be corrupted.
In-Reply-To: <bug-14844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14844-70-EfT9VolJzn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14844

paxed <pasi.kallinen at joensuu.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20971

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 10:29:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 08:29:06 +0000
Subject: [Koha-bugs] [Bug 20971] additem Corrupted storable string
In-Reply-To: <bug-20971-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20971-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20971-70-aUIM0MUWiV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20971

paxed <pasi.kallinen at joensuu.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=14844

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 10:41:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 08:41:15 +0000
Subject: [Koha-bugs] [Bug 8937] Translation process removes CDATA in HTML
In-Reply-To: <bug-8937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8937-70-utyirfE13m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8937

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor.grousset at biblibre.co
                   |                            |m
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20286

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 10:41:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 08:41:15 +0000
Subject: [Koha-bugs] [Bug 20286] Subscribing to a search via rss goes to an
	empty page
In-Reply-To: <bug-20286-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20286-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20286-70-ftu7f3jlda@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20286

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=8937

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 10:44:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 08:44:32 +0000
Subject: [Koha-bugs] [Bug 20972] New: If ISBN has 10 numbers only the first
 9 numbers are used
Message-ID: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972

            Bug ID: 20972
           Summary: If ISBN has 10 numbers only the first 9 numbers are
                    used
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: johan.larsson at ub.gu.se
        QA Contact: testopia at bugs.koha-community.org

If ISBN has 10 numbers only the first 9 numbers are being added to the
Edifact-message (PIA+5+3540556753:IB') 

The bug is located in Koha/Edifact/Order.pm

     elsif ( $isbn_field =~ m/(\d{9})[Xx\d]/ ) {
         $product_id   = $1; 
         $product_code = 'IB';
     }

product_id will only get the first 9 chars in the regular expression because of
the placement on the parenthesis. 

The solution to this is to move the right parenthesis like below:
     elsif ( $isbn_field =~ m/(\d{9}[Xx\d])/ ) {
         $product_id   = $1; 
         $product_code = 'IB';
     }

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 11:10:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 09:10:10 +0000
Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to
	configuration files
In-Reply-To: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20073-70-SRtlpiQRsa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073

--- Comment #47 from Ere Maijala <ere.maijala at helsinki.fi> ---
Could we get this back into master soon?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 11:11:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 09:11:14 +0000
Subject: [Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9
	numbers are used
In-Reply-To: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20972-70-aTH7whpBSl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972

--- Comment #1 from Johan Larsson <johan.larsson at ub.gu.se> ---
Created attachment 76225
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76225&action=edit
Bug 20972: If ISBN has 10 numbers only the first 9 numbers are used

If ISBN has 10 numbers only the first 9 numbers are being added to the
Edifact-message (PIA+5+3540556753:IB')

This is caused by wrong positioning of capturing parentheses in a regular
expression.

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 11:16:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 09:16:50 +0000
Subject: [Koha-bugs] [Bug 20973] New: Article requests: Can't tell which
 library filled an article request
Message-ID: <bug-20973-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20973

            Bug ID: 20973
           Summary: Article requests: Can't tell which library filled an
                    article request
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com,
                    kyle at bywatersolutions.com

In a multi branch setting any library might fill an article request, but at the
moment only the pick-up library is stored. There is no way to tell which
library actually filled the request which is important for statistics.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 11:27:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 09:27:03 +0000
Subject: [Koha-bugs] [Bug 8937] Translation process removes CDATA in HTML
In-Reply-To: <bug-8937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8937-70-ZttWTawVnp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8937

--- Comment #2 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
== Reproduice ==
1. opac: switch to english language
2. opac: Search for something that returns multiple results
3. open rss feed
4. See that the author name and "place hold" link show
     Optional: Right click ? page source ? see that multiple CDATA section are
there
5. Translate & switch to another language than english
6. open rss feed
7. See that only the titles show. Nor the author name nor the "place hold" link
     This is the bug.
     Optional: Right click ? page source ? see that only one CDATA section is
there

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 11:45:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 09:45:51 +0000
Subject: [Koha-bugs] [Bug 8937] Translation process removes CDATA in RSS XML
In-Reply-To: <bug-8937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8937-70-w3r3zYhVLB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8937

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Translation process removes |Translation process removes
                   |CDATA in HTML               |CDATA in RSS XML

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 12:04:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 10:04:34 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth in combination with LDAP as an
 alternative no longer works after upgrade to 17.11
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-pF3ax0F6pH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 12:04:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 10:04:59 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth in combination with LDAP as an
 alternative no longer works after upgrade to 17.11
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-PyFZy20Ro4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
*** Bug 20943 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 12:04:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 10:04:59 +0000
Subject: [Koha-bugs] [Bug 20943] Cannot enable shibboleth and LDAP at the
	same time
In-Reply-To: <bug-20943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20943-70-znXwpYal1x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20943

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---


*** This bug has been marked as a duplicate of bug 20879 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 12:06:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 10:06:39 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth in combination with LDAP as an
 alternative no longer works after upgrade to 17.11
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-Gtc3uW7hiX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I think this may well also affect CAS with LDAP as an alternative.. I've
notified Matthias to take a look.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 12:09:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 10:09:16 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth in combination with LDAP as an
 alternative no longer works after upgrade to 17.11
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-GHC7AVNkfQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

--- Comment #17 from Nick Clemens <nick at bywatersolutions.com> ---
Affects 17.05 as well

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 12:10:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 10:10:19 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth in combination with LDAP as an
 alternative no longer works after upgrade to 17.11
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-mw42FmrPBd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76220|0                           |1
        is obsolete|                            |

--- Comment #18 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 76226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76226&action=edit
Bug 20879: Fix regression in shibboleth when ldap enabled

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 12:10:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 10:10:16 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth in combination with LDAP as an
 alternative no longer works after upgrade to 17.11
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-adZnRPRm0T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 14:08:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 12:08:02 +0000
Subject: [Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9
	numbers are used
In-Reply-To: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20972-70-zlaSMmUUiP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |colin.campbell at ptfs-europe.
                   |                            |com,
                   |                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 14:44:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 12:44:15 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-YRyP4qt6ae@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73743|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 15:20:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 13:20:21 +0000
Subject: [Koha-bugs] [Bug 11983] code to select patrons to purge needs to be
	centralized
In-Reply-To: <bug-11983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11983-70-C0ARYU3fDR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 76227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76227&action=edit
Bug 11983: Centralised Koha::Patrons method OPTION 1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 15:20:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 13:20:58 +0000
Subject: [Koha-bugs] [Bug 11983] code to select patrons to purge needs to be
	centralized
In-Reply-To: <bug-11983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11983-70-dD8NLzbeZX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 76228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76228&action=edit
Bug 11983: Centralised Koha::Patrons method OPTION 2

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 15:21:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 13:21:49 +0000
Subject: [Koha-bugs] [Bug 11983] code to select patrons to purge needs to be
	centralized
In-Reply-To: <bug-11983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11983-70-touoSPVbHu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Feedback wanted on just the Koha::Patrons method options here before I write
the associated tests and hook the code up to the scripts and tools.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 15:22:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 13:22:06 +0000
Subject: [Koha-bugs] [Bug 11983] code to select patrons to purge needs to be
	centralized
In-Reply-To: <bug-11983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11983-70-A1H3M48PoF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 15:22:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 13:22:22 +0000
Subject: [Koha-bugs] [Bug 11983] code to select patrons to purge needs to be
	centralized
In-Reply-To: <bug-11983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11983-70-JLaTaFpdDA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 15:22:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 13:22:36 +0000
Subject: [Koha-bugs] [Bug 11983] code to select patrons to purge needs to be
	centralized
In-Reply-To: <bug-11983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11983-70-oVzuv0w87p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 15:22:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 13:22:45 +0000
Subject: [Koha-bugs] [Bug 11983] code to select patrons to purge needs to be
	centralized
In-Reply-To: <bug-11983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11983-70-rdGJGCDlKA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |colin.campbell at ptfs-europe.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 15:22:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 13:22:55 +0000
Subject: [Koha-bugs] [Bug 11983] code to select patrons to purge needs to be
	centralized
In-Reply-To: <bug-11983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11983-70-kIbFecNzOT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew.isherwood at ptfs-europ
                   |                            |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 15:34:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 13:34:10 +0000
Subject: [Koha-bugs] [Bug 20974] New: Remove files left behind after
	removing Solr
Message-ID: <bug-20974-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20974

            Bug ID: 20974
           Summary: Remove files left behind after removing Solr
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: nick at bywatersolutions.com
        Depends on: 12538

Three OPAC template files were left behind when Solr support was removed:

opac-tmpl/bootstrap/en/includes/search/facets.inc
opac-tmpl/bootstrap/en/includes/search/page-numbers.inc
opac-tmpl/bootstrap/en/includes/search/resort_form.inc

Originally added by Bug 8233, "SearchEngine: Add a Koha::SearchEngine module"
http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=623f3a2c84fea04e4ad6203db49f6fdd6cfc62cd


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538
[Bug 12538] Solr removal
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 15:34:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 13:34:10 +0000
Subject: [Koha-bugs] [Bug 12538] Solr removal
In-Reply-To: <bug-12538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12538-70-o7Ei5B1wOh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20974


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20974
[Bug 20974] Remove files left behind after removing Solr
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 15:41:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 13:41:44 +0000
Subject: [Koha-bugs] [Bug 20974] Remove files left behind after removing Solr
In-Reply-To: <bug-20974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20974-70-0LtGlvoLJI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20974

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 15:41:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 13:41:47 +0000
Subject: [Koha-bugs] [Bug 20974] Remove files left behind after removing Solr
In-Reply-To: <bug-20974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20974-70-F5MJ37ikPa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20974

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76229&action=edit
Bug 20974: Remove files left behind after removing Solr

Some files were left behind when Bug 12538 removed support for Solr.
This patch removes them.

To test, apply the patch and fail to observe the existence of these
files:

koha-tmpl/opac-tmpl/bootstrap/en/includes/search/facets.inc
koha-tmpl/opac-tmpl/bootstrap/en/includes/search/page-numbers.inc
koha-tmpl/opac-tmpl/bootstrap/en/includes/search/resort_form.inc

Perform a search in the OPAC to confirm that nothing broke.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 15:53:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 13:53:46 +0000
Subject: [Koha-bugs] [Bug 20460] Staff can only change password through the
 change password button if patron hits failedloginattempts
In-Reply-To: <bug-20460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20460-70-aIaual0Zn5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20460

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:01:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 14:01:46 +0000
Subject: [Koha-bugs] [Bug 20975] New: Improve auto escaping performance
Message-ID: <bug-20975-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20975

            Bug ID: 20975
           Summary: Improve auto escaping performance
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: major
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 13618

On bug 13618 we are trying to get rid of XSS issues with a global solution.

Using Template::Stash::AutoEscaping we are going to apply a html filter to all
of our template variables. The problem is that we can have thousands of
variables displayed (and so escaped).


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
[Bug 13618] Prevent XSS in the Staff Client and the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:01:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 14:01:46 +0000
Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
In-Reply-To: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13618-70-q7pGe9rO6X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20975


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20975
[Bug 20975] Improve auto escaping performance
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:03:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 14:03:41 +0000
Subject: [Koha-bugs] [Bug 20975] Improve auto escaping performance
In-Reply-To: <bug-20975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20975-70-lsKlEYdGJN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20975

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76230&action=edit
AutoEscaping - no filter

for x in 1 2 3 4 5; do time perl benchmark_AutoEscaping.pl; done
perl benchmark_AutoEscaping.pl  0.20s user 0.00s system 98% cpu 0.208 total
perl benchmark_AutoEscaping.pl  0.19s user 0.02s system 98% cpu 0.214 total
perl benchmark_AutoEscaping.pl  0.18s user 0.02s system 98% cpu 0.204 total
perl benchmark_AutoEscaping.pl  0.18s user 0.02s system 98% cpu 0.202 total
perl benchmark_AutoEscaping.pl  0.18s user 0.02s system 97% cpu 0.205 total

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:03:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 14:03:46 +0000
Subject: [Koha-bugs] [Bug 20975] Improve auto escaping performance
In-Reply-To: <bug-20975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20975-70-SgtDNOfxxP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20975

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76231&action=edit
AutoEscaping - TT html filters

for x in 1 2 3 4 5; do time perl benchmark_AutoEscaping.pl; done
perl benchmark_AutoEscaping.pl  0.30s user 0.09s system 95% cpu 0.414 total
perl benchmark_AutoEscaping.pl  0.27s user 0.02s system 97% cpu 0.295 total
perl benchmark_AutoEscaping.pl  0.28s user 0.02s system 99% cpu 0.307 total
perl benchmark_AutoEscaping.pl  0.30s user 0.02s system 98% cpu 0.320 total
perl benchmark_AutoEscaping.pl  0.27s user 0.02s system 99% cpu 0.290 total

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:03:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 14:03:54 +0000
Subject: [Koha-bugs] [Bug 20975] Improve auto escaping performance
In-Reply-To: <bug-20975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20975-70-xisnEQJgdG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20975

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76232
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76232&action=edit
AutoEscaping - Template::Stash::AutoEscaping (escape all)

for x in 1 2 3 4 5; do time perl benchmark_AutoEscaping.pl; done
perl benchmark_AutoEscaping.pl  9.67s user 5.08s system 99% cpu 14.837 total
perl benchmark_AutoEscaping.pl  9.00s user 4.10s system 99% cpu 13.167 total
perl benchmark_AutoEscaping.pl  9.24s user 4.97s system 99% cpu 14.263 total
perl benchmark_AutoEscaping.pl  9.91s user 4.19s system 99% cpu 14.188 total
perl benchmark_AutoEscaping.pl  8.86s user 4.44s system 99% cpu 13.347 total

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:03:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 14:03:59 +0000
Subject: [Koha-bugs] [Bug 20975] Improve auto escaping performance
In-Reply-To: <bug-20975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20975-70-9b9xEtJgEc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20975

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76233&action=edit
AutoEscaping - Do not escape using ignore_escape

The variable are not escaped (let's suppose it's what we want)

for x in 1 2 3 4 5; do time perl benchmark_AutoEscaping.pl; done
perl benchmark_AutoEscaping.pl  7.37s user 4.12s system 99% cpu 11.557 total
perl benchmark_AutoEscaping.pl  7.15s user 4.24s system 99% cpu 11.438 total
perl benchmark_AutoEscaping.pl  6.99s user 3.70s system 99% cpu 10.751 total
perl benchmark_AutoEscaping.pl  6.32s user 3.76s system 99% cpu 10.120 total
perl benchmark_AutoEscaping.pl  6.32s user 3.71s system 99% cpu 10.057 total

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:04:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 14:04:05 +0000
Subject: [Koha-bugs] [Bug 20975] Improve auto escaping performance
In-Reply-To: <bug-20975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20975-70-7sqSj5Adkn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20975

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76234&action=edit
AutoEscaping - Do not escape using .raw

Same as before, vars will not be escaped

for x in 1 2 3 4 5; do time perl benchmark_AutoEscaping.pl; done
perl benchmark_AutoEscaping.pl  7.43s user 3.92s system 99% cpu 11.400 total
perl benchmark_AutoEscaping.pl  6.56s user 3.75s system 99% cpu 10.377 total
perl benchmark_AutoEscaping.pl  6.11s user 4.08s system 99% cpu 10.233 total
perl benchmark_AutoEscaping.pl  7.02s user 3.93s system 99% cpu 10.984 total
perl benchmark_AutoEscaping.pl  6.91s user 3.70s system 99% cpu 10.664 total

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:04:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 14:04:11 +0000
Subject: [Koha-bugs] [Bug 20975] Improve auto escaping performance
In-Reply-To: <bug-20975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20975-70-hCdDtfsbf2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20975

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76235&action=edit
AutoEscaping - Koha::Template::AutoEscaping

for x in 1 2 3 4 5; do time perl benchmark_AutoEscaping.pl; done
perl benchmark_AutoEscaping.pl  0.34s user 0.07s system 96% cpu 0.425 total
perl benchmark_AutoEscaping.pl  0.35s user 0.04s system 99% cpu 0.387 total
perl benchmark_AutoEscaping.pl  0.35s user 0.04s system 99% cpu 0.396 total
perl benchmark_AutoEscaping.pl  0.50s user 0.03s system 99% cpu 0.532 total
perl benchmark_AutoEscaping.pl  0.38s user 0.02s system 99% cpu 0.400 total

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:07:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 14:07:12 +0000
Subject: [Koha-bugs] [Bug 20460] Staff can only change password through the
 change password button if patron hits failedloginattempts
In-Reply-To: <bug-20460-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20460-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20460-70-JuRPuLgDMr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20460

Sally Healey <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:08:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 14:08:21 +0000
Subject: [Koha-bugs] [Bug 20975] Improve auto escaping performance
In-Reply-To: <bug-20975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20975-70-5XW1UvCRJI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20975

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |In Discussion

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Koha::Template::AutoEscaping is a naive adaptation of
Template::Stash::AutoEscaping. I have tried to simplify the code to remove what
will not be useful for us.

The performances are good, I guess it helps to avoid 1 object creation
(::Escaped::HTML) by variable.

But... it does not work. If you are applying the last patch on top of bug 13618
you will notice that variables are double-escaped.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:10:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 14:10:30 +0000
Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
In-Reply-To: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13618-70-95Pzt7z1Wf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618

--- Comment #218 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #217)
> Patches have been rebased, adjusted for master and push to
> https://gitlab.com/joubu/Koha/tree/bug_13618
> 
> They do not deal with performance issues but are ready to be tested (to
> catch missing .raw)

No need to test if we do not have a solution on bug 20975.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:20:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 14:20:51 +0000
Subject: [Koha-bugs] [Bug 20881] Order receiving: Price filter missing
	on_editing
In-Reply-To: <bug-20881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20881-70-tHEpFLgK9V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20881

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76195|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76236&action=edit
Bug 20881: Order receiving: Price filter missing on_editing

When the Price-filter is used on editable data, it should have the
on_editing -tag. Add it to the orderreceive.tt

Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

To test:
- Set CurrencyFormat to FR
- Create a basket with orders in acq
- Close it
- Receive shipment and pick order line to receive
- On this screen verify that the actual cost appears as comma-separated
- Apply patch
- Refresh page
- Verify that the actual cost now appears .-separated

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:20:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 14:20:45 +0000
Subject: [Koha-bugs] [Bug 20881] Order receiving: Price filter missing
	on_editing
In-Reply-To: <bug-20881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20881-70-W3xk5hdy3e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20881

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:22:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 14:22:37 +0000
Subject: [Koha-bugs] [Bug 20881] Order receiving: Price filter missing
	on_editing
In-Reply-To: <bug-20881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20881-70-3T8EbIwwjw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20881

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20976

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:22:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 14:22:37 +0000
Subject: [Koha-bugs] [Bug 20976] New: Add test to catch missing on_editing
	flag
Message-ID: <bug-20976-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20976

            Bug ID: 20976
           Summary: Add test to catch missing on_editing flag
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

see bug 20881, we should add a test (QA scripts or t?) to catch:

  git grep "input type.*Price" | grep -v on_editing

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:31:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 14:31:02 +0000
Subject: [Koha-bugs] [Bug 14222] sort holds in OPAC by priority
In-Reply-To: <bug-14222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14222-70-HZ1oiOgvUc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14222

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:31:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 14:31:43 +0000
Subject: [Koha-bugs] [Bug 14222] Sort holds in OPAC by priority
In-Reply-To: <bug-14222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14222-70-MMU7yDOZhr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14222

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|sort holds in OPAC by       |Sort holds in OPAC by
                   |priority                    |priority

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:35:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 14:35:14 +0000
Subject: [Koha-bugs] [Bug 13153] Waiting hold checked in at different
 library doesn't re-route item to correct library
In-Reply-To: <bug-13153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13153-70-oPPeZaf2OS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153

Martha Fuerst <mfuerst at hmcpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mfuerst at hmcpl.org

--- Comment #20 from Martha Fuerst <mfuerst at hmcpl.org> ---
Bug bump?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:39:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 14:39:17 +0000
Subject: [Koha-bugs] [Bug 14222] Sort holds in OPAC by priority
In-Reply-To: <bug-14222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14222-70-u5c1x9xUOy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14222

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:39:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 14:39:20 +0000
Subject: [Koha-bugs] [Bug 14222] Sort holds in OPAC by priority
In-Reply-To: <bug-14222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14222-70-33Y2eieyxq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14222

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76237&action=edit
Bug 14222: Sort holds in OPAC by priority

This patch modifies the markup of the users's holds table in the OPAC so
that if hold priority is displayed, the table will be sorted by that
number.

To test, apply the patch and set the OPACShowHoldQueueDetails system
preference to "Show priority level" or "Show holds and their priority
level."

 - Log in to the OPAC as a user who has multiple holds with various
   priorities. Include priorities which could be sorted incorrectly
   using a text sort, e.g. 1, 10.
 - View the holds tab on the "your summary" page. Confirm that the
   priority column is sorted by default with the lowest priority holds
   first.
 - Set the  OPACShowHoldQueueDetails preference to "Show holds" and
   confirm that the holds table still displays correctly, sorted by
   "Placed on" ascending.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:48:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 14:48:07 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-puSvNdyyBE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #237 from Alex Arnaud <alex.arnaud at biblibre.com> ---
(In reply to Jonathan Druart from comment #236)
> Is there a plan to avoid never-ending rebases?
> 
> 
> (In reply to Alex Arnaud from comment #194)
> > > Comment 164 - How can we open issue on http://git.biblibre.com/biblibre/koha-mana
> > We plan to move Mana server sources on Koha community repository
> > 
> > > Comment 164 - I'd like a more complete README to run the server and the tests.
> > http://git.biblibre.com/biblibre/koha-mana/blob/master/README.md. Need to be
> > completed
> 
> What about these two points?

I think only the second point needs an answer. What do you miss on the README
file?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:51:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 14:51:16 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-P0hm3mG3X3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #238 from Alex Arnaud <alex.arnaud at biblibre.com> ---
(In reply to Jonathan Druart from comment #236)
> Is there a plan to avoid never-ending rebases?
> 
Make QA and push? :p

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 17:11:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 15:11:11 +0000
Subject: [Koha-bugs] [Bug 20977] New: Javascript vars used in
 confirm_deletion in catalog.js do not match strings in catalog-strings.inc
Message-ID: <bug-20977-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977

            Bug ID: 20977
           Summary: Javascript vars used in confirm_deletion in catalog.js
                    do not match strings in catalog-strings.inc
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

The naming mismatch can cause javascript errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 17:11:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 15:11:16 +0000
Subject: [Koha-bugs] [Bug 20977] Javascript vars used in confirm_deletion in
 catalog.js do not match strings in catalog-strings.inc
In-Reply-To: <bug-20977-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20977-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20977-70-yllYU0UTOA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 17:11:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 15:11:28 +0000
Subject: [Koha-bugs] [Bug 20977] Javascript vars used in confirm_deletion in
 catalog.js do not match strings in catalog-strings.inc
In-Reply-To: <bug-20977-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20977-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20977-70-AI4pANR3qd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 17:12:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 15:12:42 +0000
Subject: [Koha-bugs] [Bug 20977] Javascript vars used in confirm_deletion in
 catalog.js do not match strings in catalog-strings.inc
In-Reply-To: <bug-20977-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20977-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20977-70-4zfapx4TsV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76238&action=edit
Bug 20977: Javascript vars used in confirm_deletion in catalog.js do not match
strings in catalog-strings.inc

The naming mismatch can cause javascript errors.

Test Plan:
1) Confirm the string vars used in catalog.js match the ones in
   catalog-strings.inc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 17:14:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 15:14:41 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11897-70-cmC842ITIt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #264 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I have now submitted a merge request for the koha-manual to accompany this bug:
https://gitlab.com/koha-community/koha-manual/merge_requests/136/diffs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 17:27:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 15:27:36 +0000
Subject: [Koha-bugs] [Bug 20978] New: Add Koha::Account::add_credit
Message-ID: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

            Bug ID: 20978
           Summary: Add Koha::Account::add_credit
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

There's code spread in several controller scripts that directly inserts account
lines on the DB, with hardcoded values that only exist on the forms data comes
from (mancredit.pl, maninvoice, etc).

There should be a high-level function to deal with credits with a simple set of
valid values.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 17:28:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 15:28:49 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-SIxVcrKeIK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20944


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944
[Bug 20944] Add routes to add credits and debits to a patron's account
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 17:28:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 15:28:49 +0000
Subject: [Koha-bugs] [Bug 20944] Add routes to add credits and debits to a
 patron's account
In-Reply-To: <bug-20944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20944-70-EDPFw3g8i0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20978


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978
[Bug 20978] Add Koha::Account::add_credit
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 17:29:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 15:29:53 +0000
Subject: [Koha-bugs] [Bug 13655] Can't save organisation type patron without
 entering userid/password
In-Reply-To: <bug-13655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13655-70-1x3ZNblp7t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13655

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76239&action=edit
Bug 13655: Same fix for partial edit

Test plan:
- Create an organisation with surname='xxx'
userid will be autogenerated with 'xxx''
- Edit the surname with 'yyy'
userid will be unchanged, 'xxx'
- Parial edit and blank userid
userid will be autogenerated with 'yyy'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 17:31:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 15:31:03 +0000
Subject: [Koha-bugs] [Bug 13655] Can't save organisation type patron without
 entering userid/password
In-Reply-To: <bug-13655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13655-70-8iZBuudxif@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13655

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Indeed, thanks Josef!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 17:31:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 15:31:44 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11897-70-GG4W0QBkk6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Manual

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 17:34:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 15:34:53 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-dpL4RC59j8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #239 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I can get back to this one when the documentation to test locally (server too)
will be completed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 17:42:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 15:42:15 +0000
Subject: [Koha-bugs] [Bug 11983] code to select patrons to purge needs to be
	centralized
In-Reply-To: <bug-11983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11983-70-vA3iG8Rcyk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
IMO Option 1 will be hard to maintain, and is not very readable.

Option 2 is more verbose but clearer. See also Koha/Virtualshelves.pm for
existing examples.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 18:07:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 16:07:49 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-25sb17gk30@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76241&action=edit
Bug 20978: Add Koha::Account::add_credit

This patch adds:
- Koha::Account::add_credit
- A single source of truth for accounttype and offset_type values

To test:
- Apply the first patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Account.t
=> FAIL: Tests fail!
- Apply this patch
- Run:
 k$ prove t/db_dependent/Koha/Account.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 18:07:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 16:07:41 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-kEIi3opkuY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76240
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76240&action=edit
Bug 20978: Unit tests

This patch adds unit tests for Koha::Account::add_credit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 18:08:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 16:08:13 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-aF0kxLOlHF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 18:22:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 16:22:00 +0000
Subject: [Koha-bugs] [Bug 20979] Error message when deleting bib attached to
	order
In-Reply-To: <bug-20979-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20979-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20979-70-jOtHRlVtx2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20979

Donna <bwsdonna at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bwsdonna at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 18:21:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 16:21:49 +0000
Subject: [Koha-bugs] [Bug 20979] New: Error message when deleting bib
	attached to order
Message-ID: <bug-20979-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20979

            Bug ID: 20979
           Summary: Error message when deleting bib attached to order
 Change sponsored?: ---
           Product: Koha
           Version: 17.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: bwsdonna at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Discovered as a result of bug 20977.  When deleting an empty bib, error
messages pops up "1 order(s) are using this record. You need order managing
permissions to delete this record." even though user has superlibrarian
permissions.  Prevents the deletion of the bib record.

Item was received, and in a closed basket, and closed budget. All items were
deleted, but bib cannot be.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 18:29:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 16:29:35 +0000
Subject: [Koha-bugs] [Bug 17649] Create only one message per borrower and
	overdue level
In-Reply-To: <bug-17649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17649-70-65Ffwhrcq6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17649

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |victor.grousset at biblibre.co
                   |                            |m

--- Comment #7 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Conflict in misc/cronjobs/overdue_notices.pl

<<<<<<< c967e010c0110e562c4cc71bc5d18837a2a956a0
    AND issues.branchcode = ?
    AND items.itemlost = 0
||||||| merged common ancestors
    AND issues.branchcode = ?
=======
>>>>>>> Bug 17649 Only one message per borrower and overdue level


Should be simple to solve.

But why AND issues.branchcode = ? is removed in this patch?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 18:29:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 16:29:27 +0000
Subject: [Koha-bugs] [Bug 7547] printing a sorted cart
In-Reply-To: <bug-7547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7547-70-GGH7YN5zna@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 18:36:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 16:36:03 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-jH0RsGG0N1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76242&action=edit
Bug 20978: (follow-up) Another use case from C4::Circulation

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 19:07:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 17:07:49 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-3ZGRIu1zbj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle.m.hall at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 19:08:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 17:08:20 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-1R5ymvkFiQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 19:16:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 17:16:38 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-UVUMZHqEYA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76240|0                           |1
        is obsolete|                            |

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76243&action=edit
Bug 20978: Unit tests

This patch adds unit tests for Koha::Account::add_credit.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 19:16:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 17:16:45 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-WkGAwIpz1l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76241|0                           |1
        is obsolete|                            |

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76244&action=edit
Bug 20978: Add Koha::Account::add_credit

This patch adds:
- Koha::Account::add_credit
- A single source of truth for accounttype and offset_type values

To test:
- Apply the first patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Account.t
=> FAIL: Tests fail!
- Apply this patch
- Run:
 k$ prove t/db_dependent/Koha/Account.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 19:16:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 17:16:51 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-0Og1pzsp3y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76242|0                           |1
        is obsolete|                            |

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76245&action=edit
Bug 20978: (follow-up) Another use case from C4::Circulation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 19:28:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 17:28:02 +0000
Subject: [Koha-bugs] [Bug 20980] New: Manual credit offsets are stored as
	debits
Message-ID: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980

            Bug ID: 20980
           Summary: Manual credit offsets are stored as debits
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

mancredit.pl calls C4::Accounts::manualinvoice, which records debits. This
leads to:

- account_offsets.type = 'Manual Debit'
- account_offsets.credit_id = NULL
- account_offsets.debit_id = accountlines_id

So we need to:
- Add 'Manual Credit' offset type
- Make sure accountlines_id is stored in credit_id column instead of debit_id
- Fix existing offsets.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 19:28:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 17:28:23 +0000
Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
In-Reply-To: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20980-70-bzJ9Eo70Ox@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
         Depends on|                            |14826, 20978


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826
[Bug 14826] Store account offsets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978
[Bug 20978] Add Koha::Account::add_credit
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 19:28:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 17:28:23 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-XTvTcolIoi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20980


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980
[Bug 20980] Manual credit offsets are stored as debits
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 19:28:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 17:28:23 +0000
Subject: [Koha-bugs] [Bug 14826] Store account offsets
In-Reply-To: <bug-14826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14826-70-3f2AOXT5PY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20980


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980
[Bug 20980] Manual credit offsets are stored as debits
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 20:13:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 18:13:24 +0000
Subject: [Koha-bugs] [Bug 7547] printing a sorted cart
In-Reply-To: <bug-7547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7547-70-QK0nXjeZGl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76246
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76246&action=edit
Bug 7547: printing a sorted cart

This patch adds a DataTables-generated print button to the OPAC cart. To
make that process easier, the DataTables plugin has been upgraded to the
latest version (1.10.18) with the Buttons plugin included.

Changes to the OPAC LESS file style the DataTables button to look like
the static version.

Other templates in the OPAC which use the DataTables plugin have been
modified to use up-to-date option names.

To test, apply the patch and add several titles to the cart.

 - Open the cart
 - Re-sort the cart using something other than the default sort
 - Click the 'Print' button.
   - A print view should open in a separate window, sorted correctly,
     and automatically show the print dialog.
 - Click the cart's 'More details' button and click the print button.
   - This should trigger the print dialog directly.

 - Test DataTables sorting on other modified pages:
    - Bibliographic detail page (holdings table)
    - Course reserves (table of courses)
      - Course details (table of titles)
    - Full subscription history
      - Detail page for a subscription -> More details -> Full history
    - Most popular
    - Purchase suggestions
    - Self checkouts
    - Tag cloud
    - Your fines
    - Your interlibrary loan requests
    - Your reading history
    - Your search history
    - Your search IDREF for ppn (I don't know how to test this)

The DataTables plugin is removed from "Your routing lists" and Self
check-in because it is unused.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 20:13:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 18:13:19 +0000
Subject: [Koha-bugs] [Bug 7547] printing a sorted cart
In-Reply-To: <bug-7547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7547-70-Y92PpjtuZt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 20:21:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 18:21:11 +0000
Subject: [Koha-bugs] [Bug 20417] Remove OpacCloud system preference and
	feature
In-Reply-To: <bug-20417-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20417-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20417-70-0D0PX59YbI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20417

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 20:36:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 18:36:40 +0000
Subject: [Koha-bugs] [Bug 16627] Show library and date of patron requests
	for update
In-Reply-To: <bug-16627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16627-70-UdoWaxdQaT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16627

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Patron Update Organization  |Show library and date of
                   |                            |patron requests for update

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 20:40:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 18:40:52 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth in combination with LDAP as an
 alternative no longer works after upgrade to 17.11
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-BzFcal9tM9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

--- Comment #19 from cking at uttyler.edu ---
Applied the patch and tested LDAP and Shibboleth logins, logoffs, etc. All seem
to be working as expected now.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 20:51:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 18:51:08 +0000
Subject: [Koha-bugs] [Bug 20981] New: Organization name missing from patron
 search results
Message-ID: <bug-20981-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20981

            Bug ID: 20981
           Summary: Organization name missing from patron search results
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
            Blocks: 18403

If I search for patrons limited by an institutional patron category, none of
the results show a name. git bisect says this bug was introduced by Bug 18403,
Use patron-title.inc when hidepatronname is used.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403
[Bug 18403] Hide patron information if not part of the logged in user library
group
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 20:51:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 18:51:08 +0000
Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the
 logged in user library group
In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18403-70-xHiQSqGfUT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20981


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20981
[Bug 20981] Organization name missing from patron search results
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 22:28:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 20:28:31 +0000
Subject: [Koha-bugs] [Bug 20981] Organization name missing from patron
	search results
In-Reply-To: <bug-20981-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20981-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20981-70-0AWykjWrle@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20981

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
             Blocks|18403                       |
             Status|NEW                         |ASSIGNED
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Depends on|                            |18403


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403
[Bug 18403] Hide patron information if not part of the logged in user library
group
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 22:28:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 20:28:31 +0000
Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the
 logged in user library group
In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18403-70-fJ5rwyrQYY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20981
         Depends on|20981                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20981
[Bug 20981] Organization name missing from patron search results
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 22:39:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 20:39:53 +0000
Subject: [Koha-bugs] [Bug 20981] Organization name missing from patron
	search results
In-Reply-To: <bug-20981-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20981-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20981-70-fTqNSoizOe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20981

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 22:39:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 20:39:57 +0000
Subject: [Koha-bugs] [Bug 20981] Organization name missing from patron
	search results
In-Reply-To: <bug-20981-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20981-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20981-70-pcTw2Lj89G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20981

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76247
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76247&action=edit
Bug 20981: Fix organization name when displaying patron's info

Caused by bug 18403.
>From patron-title.inc, we need a IF instead of UNLESS.

Test plan:
Create organizations
Search for patrons
=> Without this patch the "Name" column is empty for organizations
=> With this patch applied you will see the surname (and othernames if
exists)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 22:47:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 20:47:15 +0000
Subject: [Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9
	numbers are used
In-Reply-To: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20972-70-goOd3fT1at@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |7736
             Status|NEW                         |Needs Signoff
            Version|17.05                       |master
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736
[Bug 7736] Edifact QUOTE and ORDER functionality
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 22:47:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 20:47:15 +0000
Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality
In-Reply-To: <bug-7736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7736-70-NDo7d5S0Fm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20972


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972
[Bug 20972] If ISBN has 10 numbers only the first 9 numbers are used
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 22:52:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 20:52:14 +0000
Subject: [Koha-bugs] [Bug 17893] Move JavaScript to the footer on staff
 client catalog pages
In-Reply-To: <bug-17893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17893-70-G5PVYXkH5P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20977


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977
[Bug 20977] Javascript vars used in confirm_deletion in catalog.js do not match
strings in catalog-strings.inc
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 22:52:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 20:52:14 +0000
Subject: [Koha-bugs] [Bug 20977] Javascript vars used in confirm_deletion in
 catalog.js do not match strings in catalog-strings.inc
In-Reply-To: <bug-20977-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20977-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20977-70-UlOimqoxms@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17893
             Status|NEW                         |Needs Signoff
          Component|Architecture, internals,    |Templates
                   |and plumbing                |
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893
[Bug 17893] Move JavaScript to the footer on staff client catalog pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 23:08:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 21:08:16 +0000
Subject: [Koha-bugs] [Bug 20979] Error message when deleting bib attached to
	order
In-Reply-To: <bug-20979-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20979-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20979-70-8OJYpSGYbe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20979

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 23:08:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 21:08:21 +0000
Subject: [Koha-bugs] [Bug 20979] Error message when deleting bib attached to
	order
In-Reply-To: <bug-20979-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20979-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20979-70-UeIgt72J2P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20979

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76248&action=edit
Bug 20979: Fix confirm deletion popup when deleting a biblio

When deleting an empty bib, error messages pops up "1 order(s) are
using this record. You need order managing permissions to delete this
record." even though user has superlibrarian permissions.  Prevents the
deletion of the bib record.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 23:09:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 21:09:32 +0000
Subject: [Koha-bugs] [Bug 20979] Error message when deleting bib attached to
	order
In-Reply-To: <bug-20979-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20979-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20979-70-sknJeokTcn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20979

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
            Version|17.11                       |master
         Depends on|                            |20977, 17893

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Maybe caused by bug 17893.
You need the patch from bug 20977 to test.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893
[Bug 17893] Move JavaScript to the footer on staff client catalog pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977
[Bug 20977] Javascript vars used in confirm_deletion in catalog.js do not match
strings in catalog-strings.inc
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 23:09:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 21:09:32 +0000
Subject: [Koha-bugs] [Bug 17893] Move JavaScript to the footer on staff
 client catalog pages
In-Reply-To: <bug-17893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17893-70-w35FqukA7D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20979


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20979
[Bug 20979] Error message when deleting bib attached to order
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 23:09:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2018 21:09:32 +0000
Subject: [Koha-bugs] [Bug 20977] Javascript vars used in confirm_deletion in
 catalog.js do not match strings in catalog-strings.inc
In-Reply-To: <bug-20977-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20977-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20977-70-8H7elbdgUW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20979


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20979
[Bug 20979] Error message when deleting bib attached to order
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 02:14:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 00:14:04 +0000
Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
In-Reply-To: <bug-20582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20582-70-EeSVsmFMsH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582

--- Comment #15 from David Cook <dcook at prosentient.com.au> ---
Any progress on this one in the Koha community?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 04:08:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 02:08:14 +0000
Subject: [Koha-bugs] [Bug 20924] News content textarea not showing
In-Reply-To: <bug-20924-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20924-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20924-70-zokeBpPE6A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20924

--- Comment #7 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
I can still reproduce this, but it must be something on my side.

getting heaps of errors like this in the console: Loading failed for the
<script> with source
?http://localhost:8081/intranet-tmpl/lib/tiny_mce/langs/en.js?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 04:24:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 02:24:11 +0000
Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
In-Reply-To: <bug-14272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14272-70-i8wJ0IJMLI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272
Bug 14272 depends on bug 20924, which changed state.

Bug 20924 Summary: News content textarea not showing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20924

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |RESOLVED
         Resolution|---                         |WORKSFORME

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 04:24:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 02:24:11 +0000
Subject: [Koha-bugs] [Bug 20924] News content textarea not showing
In-Reply-To: <bug-20924-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20924-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20924-70-T84XMatduB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20924

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |RESOLVED
         Resolution|---                         |WORKSFORME

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 04:33:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 02:33:20 +0000
Subject: [Koha-bugs] [Bug 20265] Add syspref to hide news published date
In-Reply-To: <bug-20265-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20265-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20265-70-wAzE8Um54d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20265

--- Comment #7 from Dilan Johnpull? <dilan at calyx.net.au> ---
Hi Katrin, 

I can definitely make the changes to the patch file but I think I'd like to
first hear others' opinions on this feature and whether it is worth
implementing.

Calyx always removes the date from our clients' OPACs unless otherwise
requested so we figured this might be a neat little preference to have,
especially for those who are less code savvy and choose to use Koha without any
CSS modifications.

Thanks for the feedback and apologies for the late reply.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 04:35:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 02:35:44 +0000
Subject: [Koha-bugs] [Bug 20265] Add syspref to hide news published date
In-Reply-To: <bug-20265-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20265-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20265-70-T7ao5YxS9z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20265

--- Comment #8 from Dilan Johnpull? <dilan at calyx.net.au> ---
Just generally asking everyone, is a system preference for suppressing the
published date of news items desirable?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 07:07:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 05:07:22 +0000
Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
In-Reply-To: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20980-70-s2ebvxsbxk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 07:11:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 05:11:51 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-Ap1z3nphsw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 07:38:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 05:38:32 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
	source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-cenJJ8hlP3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #86 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi David, thank you for your work on this!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 07:40:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 05:40:39 +0000
Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to
	configuration files
In-Reply-To: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20073-70-K5F3sAF1rf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #48 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There were only bug fixes pushed for a bit of time after the new release to
ease backporting, but I think pushing enh will happen soon now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 07:43:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 05:43:53 +0000
Subject: [Koha-bugs] [Bug 20265] Add syspref to hide news published date
In-Reply-To: <bug-20265-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20265-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20265-70-D7b8MKYMoR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20265

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |In Discussion

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Maybe another idea: There is already a system preference for hiding the author
- in this case CSS doesn't work, because of data privacy/personal information.
Maybe it could be changed to be a multi-select preference, where you pick what
to display.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 07:46:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 05:46:15 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth in combination with LDAP as an
 alternative no longer works after upgrade to 17.11
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-AgZKyJzhP4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
As LDAP/Shibboleth are so hard to test I suggest counting cking's test as a
sign-off and Nick for QA. Would that be agreeable?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 07:50:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 05:50:22 +0000
Subject: [Koha-bugs] [Bug 20981] Organization name missing from patron
	search results
In-Reply-To: <bug-20981-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20981-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20981-70-YXzOgL1XBm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20981

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_18_05_candidate
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 07:52:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 05:52:48 +0000
Subject: [Koha-bugs] [Bug 20983] New: Show 'organisation name' instead of
 'surname' on patron form for organisations
Message-ID: <bug-20983-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20983

            Bug ID: 20983
           Summary: Show 'organisation name' instead of 'surname' on
                    patron form for organisations
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Organisations don't have a surname... we could make this a little nicer:

When adding a new patron with a patron category of type 'organisation' some
form fields are hidden. The firstname is hidden, surname is the first form
field.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 07:56:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 05:56:21 +0000
Subject: [Koha-bugs] [Bug 20981] Organization name missing from patron
	search results
In-Reply-To: <bug-20981-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20981-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20981-70-rhNcz5Su0Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20981

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76247|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 76249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76249&action=edit
Bug 20981: Fix organization name when displaying patron's info

Caused by bug 18403.
>From patron-title.inc, we need a IF instead of UNLESS.

Test plan:
Create organizations
Search for patrons
=> Without this patch the "Name" column is empty for organizations
=> With this patch applied you will see the surname (and othernames if
exists)

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 07:56:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 05:56:17 +0000
Subject: [Koha-bugs] [Bug 20981] Organization name missing from patron
	search results
In-Reply-To: <bug-20981-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20981-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20981-70-yOEUscZH1u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20981

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 07:57:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 05:57:38 +0000
Subject: [Koha-bugs] [Bug 20981] Organization name missing from patron
	search results
In-Reply-To: <bug-20981-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20981-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20981-70-whoLHWDggu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20981

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Moving to past QA - Martin, can you take this for 18.05.01 please? Changes a
template, but no text changes, so should be ok for translations.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 08:10:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 06:10:02 +0000
Subject: [Koha-bugs] [Bug 20967] 'Add to cart' button in intranet doesn't
	work
In-Reply-To: <bug-20967-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20967-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20967-70-UdGCOKWfiw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20967

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Retested... it fixed itself.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 08:18:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 06:18:02 +0000
Subject: [Koha-bugs] [Bug 13655] Can't save organisation type patron without
 entering userid/password
In-Reply-To: <bug-13655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13655-70-V6RbupRUXa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13655

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76239|0                           |1
        is obsolete|                            |

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 76251
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76251&action=edit
Bug 13655: Same fix for partial edit

Test plan:
- Create an organisation with surname='xxx'
userid will be autogenerated with 'xxx''
- Edit the surname with 'yyy'
userid will be unchanged, 'xxx'
- Parial edit and blank userid
userid will be autogenerated with 'yyy'

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 08:18:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 06:18:14 +0000
Subject: [Koha-bugs] [Bug 13655] Can't save organisation type patron without
 entering userid/password
In-Reply-To: <bug-13655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13655-70-L0wMneSDmg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13655

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 08:17:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 06:17:58 +0000
Subject: [Koha-bugs] [Bug 13655] Can't save organisation type patron without
 entering userid/password
In-Reply-To: <bug-13655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13655-70-NjJuwyl4RM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13655

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74192|0                           |1
        is obsolete|                            |

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 76250
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76250&action=edit
Bug 13655: Allow creation of organisations without entering userid

See comment 1 of the bug report for defails of the issue.

Test plan:
Good luck (you will need to test all combinations (category type eq and
ne 'I'), then quick edition and partial edit)

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 08:18:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 06:18:26 +0000
Subject: [Koha-bugs] [Bug 13655] Can't save organisation type patron without
 entering userid/password
In-Reply-To: <bug-13655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13655-70-CXUEqMXYr9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13655

--- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Retested! Josef, can you take another look for QA?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 08:23:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 06:23:13 +0000
Subject: [Koha-bugs] [Bug 17869] Don't show pick-up library for list of
 holds in OPAC account when there is only one branch
In-Reply-To: <bug-17869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17869-70-ICZ8mFS8Ln@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 08:23:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 06:23:17 +0000
Subject: [Koha-bugs] [Bug 17869] Don't show pick-up library for list of
 holds in OPAC account when there is only one branch
In-Reply-To: <bug-17869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17869-70-3UCHVizcc4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76146|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 76252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76252&action=edit
Bug 17869: Don't show pick-up library for list of holds in OPAC account when
there is only one branch

This patch modifies the user summary page in the OPAC so that the
"pick up location" column isn't shown in the table of holds if there is
only one library defined.

To test, apply the patch and log into the OPAC as a user with one or
more holds.

 - In a system with more than one library defined the "Holds" tab of
   opac-user.pl should show a "Pick up location" column.

 - In a system with only one library defined there should be now "Pick
   up location" column.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 08:23:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 06:23:39 +0000
Subject: [Koha-bugs] [Bug 17869] Don't show pick-up library for list of
 holds in OPAC account when there is only one branch
In-Reply-To: <bug-17869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17869-70-iRAtms4ZcN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx, Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 08:27:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 06:27:33 +0000
Subject: [Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result
 lists and detail pages
In-Reply-To: <bug-14716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14716-70-TYEz7NnGqL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16804

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 08:27:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 06:27:33 +0000
Subject: [Koha-bugs] [Bug 16804] Searching can be broken by search terms
 containing semicolons in XSLT
In-Reply-To: <bug-16804-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16804-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16804-70-ZuQjtXDEhr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=14716

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Why "* have OPACSuppression on"?

Would like to test if bug 14716 also resolves the issue - might be the nicer
global fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 08:31:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 06:31:31 +0000
Subject: [Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result
 lists and detail pages
In-Reply-To: <bug-14716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14716-70-24FxuawjqM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716

--- Comment #48 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Back on testing this - continueing later.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 08:53:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 06:53:26 +0000
Subject: [Koha-bugs] [Bug 17649] Create only one message per borrower and
	overdue level
In-Reply-To: <bug-17649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17649-70-ctHU98f7dp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17649

--- Comment #8 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Hello Victor,
it 's not removed, it's related to "--all_in_one" option :
$overduequery.= " AND issues.branchcode = ?" unless $all_in_one;

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 09:05:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 07:05:21 +0000
Subject: [Koha-bugs] [Bug 13655] Can't save organisation type patron without
 entering userid/password
In-Reply-To: <bug-13655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13655-70-fsKlqpdYBW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13655

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 09:05:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 07:05:25 +0000
Subject: [Koha-bugs] [Bug 13655] Can't save organisation type patron without
 entering userid/password
In-Reply-To: <bug-13655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13655-70-9t1MrqToQ3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13655

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76250|0                           |1
        is obsolete|                            |
  Attachment #76251|0                           |1
        is obsolete|                            |

--- Comment #17 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76253&action=edit
Bug 13655: Allow creation of organisations without entering userid

See comment 1 of the bug report for defails of the issue.

Test plan:
Good luck (you will need to test all combinations (category type eq and
ne 'I'), then quick edition and partial edit)

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 09:05:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 07:05:29 +0000
Subject: [Koha-bugs] [Bug 13655] Can't save organisation type patron without
 entering userid/password
In-Reply-To: <bug-13655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13655-70-cjINv1iCjG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13655

--- Comment #18 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76254
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76254&action=edit
Bug 13655: Same fix for partial edit

Test plan:
- Create an organisation with surname='xxx'
userid will be autogenerated with 'xxx''
- Edit the surname with 'yyy'
userid will be unchanged, 'xxx'
- Parial edit and blank userid
userid will be autogenerated with 'yyy'

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 09:12:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 07:12:01 +0000
Subject: [Koha-bugs] [Bug 17649] Create only one message per borrower and
	overdue level
In-Reply-To: <bug-17649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17649-70-7gXtgWy15U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17649

--- Comment #9 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Indeed, it was just moved bellow :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 09:41:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 07:41:02 +0000
Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
In-Reply-To: <bug-20582-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20582-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20582-70-CpjQyt4DqM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582

--- Comment #16 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Martin Renvoize from comment #14)
> This really isn't required as you're using Mojo::Base below which turns on
> pretty much all the useful stuff from Modern::Perl and is more stable in
> it's actions...

If it doesn't do any harm I'd say we should keep using Modern::Perl for
consistency, but it's not a strong opinion.


(In reply to David Cook from comment #15)
> Any progress on this one in the Koha community?

The bug status is Needs Signoff, which means it's waiting for testers ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 10:35:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 08:35:02 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-4LC5kG8i6D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #134 from Josef Moravec <josef.moravec at gmail.com> ---
I started to look in to it too now

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 10:37:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 08:37:24 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-G8QyQ4TXIo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #135 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76255
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76255&action=edit
Bug 20271: (QA follow-up) Fix catalogue statistics in reports module

Test plan:
1) Have some deleted and some not deleted items
2) Use catalogue statistics in reports module and try to filter
total/deleted items
--> without this patch the deleted options returns not deleted items and
total returns deleted items
--> with this patch you should be able to filter the results to deleted,
    not deleted and all items and everyone of this filter should work

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 12:06:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 10:06:57 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-kN6M5s8lqV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75977|0                           |1
        is obsolete|                            |
  Attachment #75978|0                           |1
        is obsolete|                            |
  Attachment #75979|0                           |1
        is obsolete|                            |
  Attachment #75980|0                           |1
        is obsolete|                            |
  Attachment #75981|0                           |1
        is obsolete|                            |
  Attachment #75982|0                           |1
        is obsolete|                            |
  Attachment #75983|0                           |1
        is obsolete|                            |
  Attachment #75984|0                           |1
        is obsolete|                            |
  Attachment #75985|0                           |1
        is obsolete|                            |
  Attachment #75986|0                           |1
        is obsolete|                            |
  Attachment #75987|0                           |1
        is obsolete|                            |
  Attachment #75988|0                           |1
        is obsolete|                            |
  Attachment #75989|0                           |1
        is obsolete|                            |
  Attachment #75990|0                           |1
        is obsolete|                            |
  Attachment #75991|0                           |1
        is obsolete|                            |
  Attachment #75992|0                           |1
        is obsolete|                            |
  Attachment #75993|0                           |1
        is obsolete|                            |
  Attachment #76048|0                           |1
        is obsolete|                            |
  Attachment #76255|0                           |1
        is obsolete|                            |

--- Comment #136 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76256
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76256&action=edit
Bug 20271: merging delete biblio/items

The present bug merges the following tables:
deletedbiblio          -> biblio
deletedbiblioitems     -> biblioitems
deletedbiblio_metadata -> biblio_metadata
deleteditems           -> items

and adds a column deleted_at to signify time of deletion, if deleted

it replaces all occurrences of the mentioned occurences and uses
of mentioned deleted* tables

upgrade is handled by moving rows from deleted* tables to the live
ones. If all rows are moved, the corresponding tables are dropped.
If there are duplicates or conflicts (duplicate barcodes e.g.) they
reminders are left for scrutiny and table renamed to _deleted*

Test plan:

1) Make sure you have a db with at least a few deleted biblios,
   biblioitems and items.
2) Apply patch and run updatedatabase.pl
3) Make note of the db upgrade messages, if you get a message like:
   There were x deleteditems that could not be moved, please check
_deleteditems
   you should check the _deleteditems table and verify that they are
   actual conflicts
4) Click around in the web interface and make sure you can delete items
   and biblios
5) "Undelete" an item by NULLing the deleted_at column for an item
   and verify that it returns in interface (Not neccessary really)

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 12:07:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 10:07:03 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-7M6kGpenij@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #137 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76257&action=edit
Bug 20271: fix remaining tests

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 12:07:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 10:07:09 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-flh4KLA8Eq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #138 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76258&action=edit
Bug 20271: update kohastructure.sql

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 12:07:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 10:07:14 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-UJLiH0xq4X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #139 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76259
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76259&action=edit
Bug 20271: delete biblio and biblio_metadata in one go

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 12:06:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 10:06:53 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-eiRmwKFfn7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 12:07:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 10:07:20 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-MCrV8YIjpO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #140 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76260
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76260&action=edit
Bug 20271: remove comments regarding deleteditems and -biblio*

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 12:07:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 10:07:25 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-Yf29J2JYXC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #141 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76261
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76261&action=edit
Bug 20271: add atomic update

Bug 20271: disable foreign keys on deletedbiblio_metadata

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 12:07:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 10:07:36 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-mVsNAp7dIX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #143 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76263
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76263&action=edit
Bug 20271: fix whitespace issues in C4::Items

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 12:07:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 10:07:31 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-sbwRwjZxT7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #142 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76262
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76262&action=edit
Bug 20271: Use a single pass in the OAI-PMH provider

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 12:07:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 10:07:42 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-an03RviToJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #144 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76264
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76264&action=edit
Bug 20271: print instead of warn unmovable items

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 12:07:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 10:07:47 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-LQHakAH6RU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #145 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76265&action=edit
Bug 20271: atomicupdate - support mysql < 5.7 and address foreign key issues

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 12:07:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 10:07:52 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-uTX2A2AobM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #146 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76266
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76266&action=edit
Bug 20271: (follow-up) DBIx schema changes

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 12:07:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 10:07:59 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-dECMoO1Hy6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #147 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76267&action=edit
Bug 20271: (QA follow-up): rename to deleted_on and various fixes

- renamed deleted_at => deleted_on
- removed failing sql in t/db_dependent/OAI/Server.t
- removed deprecated autoincrement checks in about.pl
- fixed errors in catalogue_stats.tt and catalogue_stats.pl

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Removed the DBIx schema changes. Please keep them separated.
We missed changes for Biblioitem btw. Adding them in follow-up.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 12:08:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 10:08:04 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-M3WfnLWqek@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #148 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76268&action=edit
Bug 20271: (QA follow-up) DBIx schema changes

Please separate these changes from the other patches.
Note that Biblioitem was not in the last set of changes too.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 12:08:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 10:08:09 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-4cPsHkThPA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #149 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76269&action=edit
Bug 20271: (QA follow-up) Additional about cleanup

Still found references to biblios and items in script and template.

Test plan:
Check about page again.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 12:08:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 10:08:15 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-TZbnFS08uS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #150 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76270&action=edit
Bug 20271: (QA follow-up) Remove last occurrences of deleted_at

Trivial replace of deleted_at by deleted_on.

Test plan:
Run t/db_dependent/Koha/ItemTypes.t
Run t/db_dependent/Items_DelItemCheck.t
git grep -E "deleted_at\W"

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 12:08:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 10:08:20 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-r228UVc0G4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #151 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76271&action=edit
Bug 20271: (QA follow-up) Reword OAI-PMH:DeletedRecord systempref

The preference still refered to the deletedbiblio table made defunct by
this patchset.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 12:08:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 10:08:26 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-Fkx1SusJof@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #152 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76272&action=edit
Bug 20271: (QA follow-up) Make the atomicupdate idempotent

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 12:08:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 10:08:31 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-8Xi7tWFEHm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #153 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76273
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76273&action=edit
Bug 20271: (QA follow-up) Restore original GetItem functionality

The return value of GetItem had been changed (as it would now return
deleted items as well as current items). This patch restores the
original functionality (as we've not catered for all calls to GetItem
independantly), restores the original test as well as adding a further
test to catch the correct setting of deleted_on by DelItem

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 12:08:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 10:08:36 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-Rs1UsMHeFR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #154 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76274
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76274&action=edit
Bug 20271: (QA follow-up) Fix catalogue statistics in reports module

Test plan:
1) Have some deleted and some not deleted items
2) Use catalogue statistics in reports module and try to filter
total/deleted items
--> without this patch the deleted options returns not deleted items and
total returns deleted items
--> with this patch you should be able to filter the results to deleted,
    not deleted and all items and everyone of this filter should work

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 12:08:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 10:08:42 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-G3aHLiDygx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #155 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76275
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76275&action=edit
Bug 20271: (QA follow-up) Zebra should not index deleted record when doing full
reindex

Test plan:
Run koha-rebuild-zebra -f [instance]
--> without patch the deleted records are indexed and shown when
searching
--> with this patch the deleted records are not indexed

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 12:08:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 10:08:47 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-zxIP9iPWa9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #156 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76276
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76276&action=edit
Bug 20271: (QA follow-up) Does not return deleted record in GetMarcBiblio

Test plan:
Go to url /cgi-bin/koha/catalogue/detail.pl?biblionumber=[deleted
biblionumber]
--> without patch you see the deleted record
--> with patch you should see message "The record you requested does not
exist"

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 12:08:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 10:08:53 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-h9lW4ebt8S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #157 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76277
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76277&action=edit
Bug 20271: (QA follow-up): Fix test ModBiblioMarc

Test plan:
prove t/db_dependent/Biblio/ModBiblioMarc.t

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 12:10:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 10:10:04 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-UcHtCzI21r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #158 from Josef Moravec <josef.moravec at gmail.com> ---
If somebody could test my follow-ups (last 4) and confirm they are ok, it would
be great ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 14:49:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 12:49:20 +0000
Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values
In-Reply-To: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20307-70-ZB5yfP7A7A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Is there any work yet planned or done on this?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 14:55:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 12:55:16 +0000
Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values
In-Reply-To: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20307-70-kqzYKj7sQz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307

Christian Stelzenm?ller <christian.stelzenmueller at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |christian.stelzenmueller at bs
                   |                            |z-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:09:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 13:09:57 +0000
Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values
In-Reply-To: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20307-70-LV80RXY7fO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #1)
> Is there any work yet planned or done on this?

I have started something, but we need bug 15799 first (move the last
C4::Koha::GetAuthorisedValues to Koha::AuthorisedValues)

There are local patches (very wip) on my laptop, but I have no idea when I will
get back to it. The rewrite/move patches are to slow to get pushed and need too
much work to rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:16:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 13:16:54 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth in combination with LDAP as an
 alternative no longer works after upgrade to 17.11
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-ZZ38D8RnUB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #20)
> As LDAP/Shibboleth are so hard to test I suggest counting cking's test as a
> sign-off and Nick for QA. Would that be agreeable?

Yes please :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:17:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 13:17:12 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth in combination with LDAP as an
 alternative no longer works
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-dt1qq5KzHX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Shibboleth in combination   |Shibboleth in combination
                   |with LDAP as an alternative |with LDAP as an alternative
                   |no longer works after       |no longer works
                   |upgrade to 17.11            |
            Version|17.11                       |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:27:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 13:27:35 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-KMLXd9kFOl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76243|0                           |1
        is obsolete|                            |

--- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76278
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76278&action=edit
Bug 20978: Unit tests

This patch adds unit tests for Koha::Account::add_credit.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:27:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 13:27:26 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth in combination with LDAP as an
 alternative no longer works
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-pn2zsavjMD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:27:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 13:27:58 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-rEmnV2BB8P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76244|0                           |1
        is obsolete|                            |

--- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76279
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76279&action=edit
Bug 20978: Add Koha::Account::add_credit

This patch adds:
- Koha::Account::add_credit
- A single source of truth for accounttype and offset_type values

To test:
- Apply the first patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Account.t
=> FAIL: Tests fail!
- Apply this patch
- Run:
 k$ prove t/db_dependent/Koha/Account.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:28:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 13:28:38 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-UvDtIJnyZP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76245|0                           |1
        is obsolete|                            |

--- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76280
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76280&action=edit
Bug 20978: (follow-up) Another use case from C4::Circulation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:49:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 13:49:24 +0000
Subject: [Koha-bugs] [Bug 20934] Biblio checkout history shows only current
	checkout
In-Reply-To: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20934-70-sYNJURH1XZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:49:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 13:49:39 +0000
Subject: [Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
In-Reply-To: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20906-70-k25r78LhZs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #14 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:49:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 13:49:55 +0000
Subject: [Koha-bugs] [Bug 20928] Checkout status not showing patron
In-Reply-To: <bug-20928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20928-70-YoZWqH0lzx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20928

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:50:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 13:50:08 +0000
Subject: [Koha-bugs] [Bug 20951] Koha::Patron::Discharge is missing use
 Koha::Patron::Debarments
In-Reply-To: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20951-70-K8KvmEMgvN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11.x

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:50:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 13:50:17 +0000
Subject: [Koha-bugs] [Bug 13655] Can't save organisation type patron without
 entering userid/password
In-Reply-To: <bug-13655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13655-70-97RoytkNxx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13655

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #19 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:50:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 13:50:27 +0000
Subject: [Koha-bugs] [Bug 20981] Organization name missing from patron
	search results
In-Reply-To: <bug-20981-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20981-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20981-70-PCsTYBRwMj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20981

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:50:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 13:50:43 +0000
Subject: [Koha-bugs] [Bug 20794] Don't show holds tab when user doesn't have
 circulate_remaining_permissions
In-Reply-To: <bug-20794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20794-70-NqWQzFu1Oy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20794

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:50:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 13:50:57 +0000
Subject: [Koha-bugs] [Bug 20259] Shorter JS and CSS rewrite rule
In-Reply-To: <bug-20259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20259-70-kk5xAfijBl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:51:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 13:51:08 +0000
Subject: [Koha-bugs] [Bug 20702] Bind results of GetHostItemsInfo to the
 EasyAnalyticalRecords pref
In-Reply-To: <bug-20702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20702-70-h2ckMS34GH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20702

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:51:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 13:51:34 +0000
Subject: [Koha-bugs] [Bug 20881] Order receiving: Price filter missing
	on_editing
In-Reply-To: <bug-20881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20881-70-g7JgyLvze4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20881

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:52:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 13:52:09 +0000
Subject: [Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9
	numbers are used
In-Reply-To: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20972-70-h9FYpnGXo6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76225|0                           |1
        is obsolete|                            |

--- Comment #2 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 76281
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76281&action=edit
Signed off patch correcting ISBN extraction

Signed off patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:52:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 13:52:16 +0000
Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits
In-Reply-To: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18072-70-Njvpc346Ib@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67049|0                           |1
        is obsolete|                            |
  Attachment #67050|0                           |1
        is obsolete|                            |
  Attachment #67051|0                           |1
        is obsolete|                            |
  Attachment #67052|0                           |1
        is obsolete|                            |
  Attachment #67053|0                           |1
        is obsolete|                            |
  Attachment #67054|0                           |1
        is obsolete|                            |
  Attachment #67209|0                           |1
        is obsolete|                            |

--- Comment #32 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76282
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76282&action=edit
Bug 18072: Add Koha objects for Branch Transfer Limit

This patch also fixes documentation in Koha/Item/Transfer.pm and
Koha/Item/Transfers.pm.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:52:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 13:52:24 +0000
Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits
In-Reply-To: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18072-70-xeOdDtaUt5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072

--- Comment #33 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76283
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76283&action=edit
Bug 18072: Add deprecation warning to C4::Circulation Branch Transfer Limit
functions

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:52:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 13:52:28 +0000
Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits
In-Reply-To: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18072-70-rsyRaFC182@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072

--- Comment #34 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76284
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76284&action=edit
Bug 18072: Add Koha::Item->can_be_transferred

This patch adds a new method Koha::Item->can_be_transferred.

Includes unit test.

To test:
1. prove t/db_dependent/Koha/Items.t

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:52:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 13:52:31 +0000
Subject: [Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9
	numbers are used
In-Reply-To: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20972-70-cHp5oEb9yM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:52:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 13:52:32 +0000
Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits
In-Reply-To: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18072-70-iByMredRY8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072

--- Comment #35 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76285
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76285&action=edit
Bug 18072: (QA-follow-up) let Koha::Item->can_be_transferred take HASHref as
param

This patch changes Koha::Item->can_be_transferred to accept a HASHref as
follows:
$item->can_be_transferred({ to => $library, from => $library2 })

To test:
1. prove t/db_dependent/Koha/Items.t

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:52:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 13:52:36 +0000
Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits
In-Reply-To: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18072-70-SV06XA9DPw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072

--- Comment #36 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76286&action=edit
Bug 18072: Add Koha::Biblio->can_be_transferred

This patch adds a new method Koha::Biblio->can_be_transferred. The method
checks
if at least one of the item of that biblio can be transferred to desired
location.

This method will be useful for building a smarter pickup location list for
holds,
because we will be able to hide those libraries to which none of the items of
this biblio can be transferred to due to branch transfer limits (see Bug 7614).

To test:
1. prove t/db_dependent/Koha/Biblios.t

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:52:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 13:52:39 +0000
Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits
In-Reply-To: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18072-70-TcbSVkrTy1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072

--- Comment #37 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76287
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76287&action=edit
Bug 18072: (QA followup) Remove warning from tests

This patch removes a warning from Items.t due to bad parameters. It also
makes the tests use Test::Exception.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:52:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 13:52:43 +0000
Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits
In-Reply-To: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18072-70-0KivpfbXFg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072

--- Comment #38 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76288
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76288&action=edit
Bug 18072: Only accept Koha::Library in parameters

I do not think we should allowed branchode and Koha::Library objects, it
adds confusion in callers (we never know if we have a branchcode of a
library object).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:53:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 13:53:32 +0000
Subject: [Koha-bugs] [Bug 20259] Shorter JS and CSS rewrite rule
In-Reply-To: <bug-20259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20259-70-B3SSKWwX7k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259

--- Comment #8 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
If I understand correctly: The good thing is that people can keep the old rule
without issue so they won't have to change the RewriteRules for 18.05 and 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:53:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 13:53:38 +0000
Subject: [Koha-bugs] [Bug 20864] Only set bibs_selected cookie when
 BrowseResultSelection is activated
In-Reply-To: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20864-70-8gSCL5po7B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hum yes, "commons.js" was certainly not the best name. Maybe the test must be
moved to common.js, but not blocker for this quick fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:55:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 13:55:55 +0000
Subject: [Koha-bugs] [Bug 20864] Only set bibs_selected cookie when
 BrowseResultSelection is activated
In-Reply-To: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20864-70-WfYUESOIxB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:55:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 13:55:59 +0000
Subject: [Koha-bugs] [Bug 20864] Only set bibs_selected cookie when
 BrowseResultSelection is activated
In-Reply-To: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20864-70-9FXFsffufh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76196|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76289
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76289&action=edit
Bug 20864: Only set bibs_selected cookie when BrowseResultSelection is
activated

This patch adds a system preference check around the call to the
JavaScript include which sets the bibs_selected cookie. With
BrowseResultsSelection disabled, the cookie should never be set.

To test you should be using a browser with a tool for inspecting
cookies. View the cookies for your Koha domain under each of these
conditions, clearing cookies between each step:

Without the patch applied:

 - With  BrowseResultSelection enabled, search for any item. Your cookie
   tool should report that you have a bibs_selected cookie stored.
 - With BrowseResultSelection disabled, search for any item. You should
   have a bibs_selected cookie.

With the patch applied:

 - With the BrowseResultSelection system preference enabled, search for
   any item. Your cookie tool should report that you have a
   bibs_selected cookie stored.
 - With BrowseResultSelection disabled, search for any item. You should
   have no bibs_selected cookie.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 16:02:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 14:02:35 +0000
Subject: [Koha-bugs] [Bug 5789] Fines don't work when items have null
	homebranch
In-Reply-To: <bug-5789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5789-70-nFcOeXTnRX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5789

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20509
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
If we consider that it is a data migration issue I think we should start
writing a script to catch them.

See also bug 20509.

We cannot deal everywhere with such inconsistency, and if we do it in this
script, we need to do it everywhere else.

I would prefer to see a misc script searching for any kinds of data
inconsistency in DB. We will then improve it incrementally.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 16:02:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 14:02:35 +0000
Subject: [Koha-bugs] [Bug 20509] Data consistency - authority types
In-Reply-To: <bug-20509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20509-70-GKQZEb9HvN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20509

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=5789

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 16:04:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 14:04:38 +0000
Subject: [Koha-bugs] [Bug 11176] Purchase suggestions should respect the
 'active' switch on budgets
In-Reply-To: <bug-11176-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11176-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11176-70-DTib7aAU8O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11176

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|marjorie.barry-vila at collect |
                   |o.ca                        |
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 16:04:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 14:04:46 +0000
Subject: [Koha-bugs] [Bug 11176] Purchase suggestions should respect the
 'active' switch on budgets
In-Reply-To: <bug-11176-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11176-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11176-70-qfypyuldKo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11176

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 16:05:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 14:05:15 +0000
Subject: [Koha-bugs] [Bug 20259] Shorter JS and CSS rewrite rule
In-Reply-To: <bug-20259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20259-70-gC7F183YWc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Victor Grousset/tuxayo from comment #8)
> If I understand correctly: The good thing is that people can keep the old
> rule without issue so they won't have to change the RewriteRules for 18.05
> and 18.11

Yes, they are similar but one is easier to read.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 16:05:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 14:05:26 +0000
Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits
In-Reply-To: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18072-70-sfbvwJ0SwI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #39 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #31)
> (In reply to Jonathan Druart from comment #30)
> > Created attachment 67209 [details] [review] [review]
> > Bug 18072: Only accept Koha::Library in parameters
> > 
> > I do not think we should allowed branchode and Koha::Library objects, it
> > adds confusion in callers (we never know if we have a branchcode of a
> > library object).
> 
> Does this patch make sense?

Yes, yes it does ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 16:08:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 14:08:40 +0000
Subject: [Koha-bugs] [Bug 20257] Holds - Branch Transfer Limits
In-Reply-To: <bug-20257-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20257-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20257-70-tiybudjGyE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20257

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #1)
> I think this is a possible duplicate to some other existing bug reports
> concerning the branch transfer limits:
> 
> Bug 7614 - Branch transfer limit and holds 
> Bug 11020 - Transfer limits should be checked when placing a
> hold/reservation in Staff client
> Bug 10993 - Transfer limits should be checked when placing a
> hold/reservation in OPAC
> 
> Kyle, can you please check and mark duplicate if it fits? The other bugs
> have patches, but not sure if something can be salvaged from there.
> Discussion might still be interesting.

Thanks for letting me know! It definitely appears worth picking back up on some
of those!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 16:15:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 14:15:10 +0000
Subject: [Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9
	numbers are used
In-Reply-To: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20972-70-tX2fpxqnDu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972

--- Comment #3 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 76290
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76290&action=edit
Add a test case for this to Ediorder.t

Add a test for this bug and ensure routine is correctly distinguishing 10
character ISBNs from 13 digit EANs

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 16:42:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 14:42:27 +0000
Subject: [Koha-bugs] [Bug 18521] Renew and search hotkeys are swapped on
	returns page.
In-Reply-To: <bug-18521-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18521-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18521-70-TmOsVgle5n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18521

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76108|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76291
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76291&action=edit
Bug 18521: Fix key binding in the header

Moving the conditional block [% IF
(CAN_user_circulate_circulate_remaining_permissions ) %] block up the
checkin-search.inc file above the CAN_user_catalogue IF conditional block fixes
this bug.

Test plan:
1. Go to the circ home page and confirm the following
keyboard shortcuts work:

Alt+q = goes to search catalog
Alt+w = goes to renew

2. Go to returns.pl and confirm the following  keyboard shortcuts work:

Alt+q = goes to renew
Alt+w = goes to search catalog

3. Apply patch

4. Restart apache2, memchached and plack

5. Confirm on the returns.pl the following keyboard shortcuts work:
Alt+q = goes to search catalog
Alt+w = goes to renew

Sponsored-By: Catalyst IT

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Followed the test plan and it works.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 16:42:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 14:42:24 +0000
Subject: [Koha-bugs] [Bug 18521] Renew and search hotkeys are swapped on
	returns page.
In-Reply-To: <bug-18521-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18521-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18521-70-up0sCOpqft@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18521

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 16:44:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 14:44:20 +0000
Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits
In-Reply-To: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18072-70-ymIauMt6Qc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 16:44:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 14:44:23 +0000
Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits
In-Reply-To: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18072-70-j8QSUNYLCH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76282|0                           |1
        is obsolete|                            |
  Attachment #76283|0                           |1
        is obsolete|                            |
  Attachment #76284|0                           |1
        is obsolete|                            |
  Attachment #76285|0                           |1
        is obsolete|                            |
  Attachment #76286|0                           |1
        is obsolete|                            |
  Attachment #76287|0                           |1
        is obsolete|                            |
  Attachment #76288|0                           |1
        is obsolete|                            |

--- Comment #40 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76292
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76292&action=edit
Bug 18072: Add Koha objects for Branch Transfer Limit

This patch also fixes documentation in Koha/Item/Transfer.pm and
Koha/Item/Transfers.pm.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 16:44:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 14:44:32 +0000
Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits
In-Reply-To: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18072-70-P8R9LiXnjB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072

--- Comment #41 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76293
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76293&action=edit
Bug 18072: Add deprecation warning to C4::Circulation Branch Transfer Limit
functions

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 16:44:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 14:44:36 +0000
Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits
In-Reply-To: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18072-70-Kk9cWb97iz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072

--- Comment #42 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76294
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76294&action=edit
Bug 18072: Add Koha::Item->can_be_transferred

This patch adds a new method Koha::Item->can_be_transferred.

Includes unit test.

To test:
1. prove t/db_dependent/Koha/Items.t

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 16:44:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 14:44:41 +0000
Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits
In-Reply-To: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18072-70-drLfPOhxuL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072

--- Comment #43 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76295&action=edit
Bug 18072: (QA-follow-up) let Koha::Item->can_be_transferred take HASHref as
param

This patch changes Koha::Item->can_be_transferred to accept a HASHref as
follows:
$item->can_be_transferred({ to => $library, from => $library2 })

To test:
1. prove t/db_dependent/Koha/Items.t

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 16:44:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 14:44:45 +0000
Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits
In-Reply-To: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18072-70-QPVy7mAXRd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072

--- Comment #44 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76296
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76296&action=edit
Bug 18072: Add Koha::Biblio->can_be_transferred

This patch adds a new method Koha::Biblio->can_be_transferred. The method
checks
if at least one of the item of that biblio can be transferred to desired
location.

This method will be useful for building a smarter pickup location list for
holds,
because we will be able to hide those libraries to which none of the items of
this biblio can be transferred to due to branch transfer limits (see Bug 7614).

To test:
1. prove t/db_dependent/Koha/Biblios.t

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 16:44:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 14:44:49 +0000
Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits
In-Reply-To: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18072-70-tbCg8wYUeY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072

--- Comment #45 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76297
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76297&action=edit
Bug 18072: (QA followup) Remove warning from tests

This patch removes a warning from Items.t due to bad parameters. It also
makes the tests use Test::Exception.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 16:44:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 14:44:53 +0000
Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits
In-Reply-To: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18072-70-CrZoLGttQ1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072

--- Comment #46 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76298
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76298&action=edit
Bug 18072: Only accept Koha::Library in parameters

I do not think we should allowed branchode and Koha::Library objects, it
adds confusion in callers (we never know if we have a branchcode of a
library object).

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 16:45:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 14:45:17 +0000
Subject: [Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits
In-Reply-To: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18072-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18072-70-qIODWjHFnk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 16:56:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 14:56:50 +0000
Subject: [Koha-bugs] [Bug 16804] Searching can be broken by search terms
 containing semicolons in XSLT
In-Reply-To: <bug-16804-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16804-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16804-70-ItlFM6gyOV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804

--- Comment #11 from Joy Nelson <joy at bywatersolutions.com> ---
Katrin,
I did a retest to confirm.  This patch will fix if opac suppress if ON or OFF.  

joy

(In reply to Katrin Fischer from comment #10)
> Why "* have OPACSuppression on"?
> 
> Would like to test if bug 14716 also resolves the issue - might be the nicer
> global fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 17:46:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 15:46:40 +0000
Subject: [Koha-bugs] [Bug 15836] Labels: Offer configuration option for
 splitting call number in layout definition
In-Reply-To: <bug-15836-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15836-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15836-70-JHuaq3S6K5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
           Assignee|cnighswonger at foundations.ed |jonathan.druart at bugs.koha-c
                   |u                           |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 17:48:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 15:48:55 +0000
Subject: [Koha-bugs] [Bug 15836] Labels: Offer configuration option for
 splitting call number in layout definition
In-Reply-To: <bug-15836-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15836-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15836-70-64uQB4giqw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 17:56:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 15:56:54 +0000
Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout
 form, with collapsed settings panel
In-Reply-To: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20959-70-uU3JfruGxI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959

Sally Healey <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 17:57:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 15:57:21 +0000
Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
In-Reply-To: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20980-70-qAWPDIL25V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76300&action=edit
Bug 20980: Make mancredit.pl use Koha::Account::add_credit

This patch makes creating a manual credit from the UI record the account
offset as 'Manual Credit', and properly set account_offsets.credit_id
instead of account_offsets.debit_id.

To test:
- Create a manual credit (of 'Credit' type) for a known patron (acevedo?)
- Run:
  $ sudo koha-mysql kohadev
  > SELECT * FROM account_offsets;
=> FAIL: The account offset for the manual credit has type=Manual Debit,
    credit_id=NULL and debit_id=accountlines_id
- Run the atomic update:
  $ updatedatabase
- Run:
  $ sudo koha-mysql kohadev
  > SELECT * FROM account_offsets;
=> SUCCESS: The account offset has been corrected and now has
type=Manual Credit, credit_id=accountlines_id and debit_id=NULL
- Create a new manual credit (of 'Forgiven' type) for a known patron
- Run:
  $ sudo koha-mysql kohadev
  > SELECT * FROM account_offsets;
=> SUCCESS: The account offset has been stored correctly as a credit!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 17:57:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 15:57:27 +0000
Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
In-Reply-To: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20980-70-9IRyDdB0ZS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76301
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76301&action=edit
Bug 20980: (follow-up) Only use UpdateStats for 'payment' and 'writeoff'

This patch makes Koha::Account::add_credit record statistics logs
(through C4::Stats::UpdateStats) only for the 'payment' and 'writeoff'
credit types.

Both credit types are whitelisted in UpdateStats, so we keep the current
behaviour. Another option would've been to add new account types to the
white list, but with the account offsets it seems that using the
statistics table for account changes won't be useful for too long, as
offsets contain the same (and more) information.

To test:
- Apply the patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Account.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 17:57:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 15:57:14 +0000
Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
In-Reply-To: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20980-70-aen3PFlWat@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76299
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76299&action=edit
Bug 20980: Add 'Manual Credit' and fix existing offsets

This patch adds a new offset type 'Manual Credit'. And adds an atomic
update for fixing existing offsets.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 17:58:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 15:58:35 +0000
Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
In-Reply-To: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20980-70-LvBTedRjAG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 17:58:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 15:58:55 +0000
Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
In-Reply-To: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20980-70-VZujuzVwD3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 19:37:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 17:37:07 +0000
Subject: [Koha-bugs] [Bug 15836] Labels: Offer configuration option for
 splitting call number in layout definition
In-Reply-To: <bug-15836-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15836-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15836-70-Icokje9TRx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836

Chris Nighswonger <cnighswonger at foundations.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cnighswonger at foundations.ed
                   |                            |u

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 19:46:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 17:46:28 +0000
Subject: [Koha-bugs] [Bug 17625] 245f and 245g are not mapped to subtitle in
 Keyword to MARC mapping
In-Reply-To: <bug-17625-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17625-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17625-70-wdpI86FPUh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17625

--- Comment #5 from Joy Nelson <joy at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #4)
> Ah right, I think the keywords to marc mapping doesn't work on the xslt
> detail view?

I verified that.  The Keyword to Marc mapping is for non xslt display. I'll
change the title on this bug.  The issue I'm having is indeed with XSLT

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 19:46:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 17:46:44 +0000
Subject: [Koha-bugs] [Bug 17625] 245f and 245g are not mapped to subtitle in
	XSLT
In-Reply-To: <bug-17625-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17625-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17625-70-5tQ83KkLJP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17625

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|245f and 245g are not       |245f and 245g are not
                   |mapped to subtitle in       |mapped to subtitle in XSLT
                   |Keyword to MARC mapping     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 20:10:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 18:10:04 +0000
Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to
	configuration files
In-Reply-To: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20073-70-1a0HN38wyu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #49 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to aster for 18.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 20:10:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 18:10:29 +0000
Subject: [Koha-bugs] [Bug 20456] Remove the
	C4::Serials::GetSubscriptionsFromBorrower
In-Reply-To: <bug-20456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20456-70-gOar1gUjgC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #15 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 20:10:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 18:10:56 +0000
Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to
	configuration files
In-Reply-To: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20073-70-O0tmbVJpDs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073

--- Comment #50 from Nick Clemens <nick at bywatersolutions.com> ---
Squashed 1st and 3rd patches on push

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 20:11:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 18:11:33 +0000
Subject: [Koha-bugs] [Bug 19820] Add unsafe param to GetMarcSubfieldStructure
In-Reply-To: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19820-70-1ymKZmXgO9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19820

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #15 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 20:11:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 18:11:55 +0000
Subject: [Koha-bugs] [Bug 20339] Unify MARC21 ISBN/ISSN handling in XSL
In-Reply-To: <bug-20339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20339-70-gkIyhJysHQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20339

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 20:12:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 18:12:32 +0000
Subject: [Koha-bugs] [Bug 18973] Auto focus the ISBN field
In-Reply-To: <bug-18973-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18973-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18973-70-DWtXMrqA9Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18973

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 20:12:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 18:12:15 +0000
Subject: [Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with
 C4::Context->temporary_directory
In-Reply-To: <bug-20727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20727-70-Jy3xpVKHPm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #23 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 20:12:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 18:12:51 +0000
Subject: [Koha-bugs] [Bug 20876] The form_serialized_itype cookie is not
 used and should be removed
In-Reply-To: <bug-20876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20876-70-uewJ6CedOW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20876

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 20:23:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 18:23:25 +0000
Subject: [Koha-bugs] [Bug 19820] Add unsafe param to GetMarcSubfieldStructure
In-Reply-To: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19820-70-VAQP0TzpVi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19820

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |CLOSED
         Resolution|---                         |FIXED

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Let's stay on the safe side and do not backport this one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 20:23:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 18:23:26 +0000
Subject: [Koha-bugs] [Bug 7923] Performance omnibus
In-Reply-To: <bug-7923-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7923-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7923-70-POtSzOhEhX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923
Bug 7923 depends on bug 19820, which changed state.

Bug 19820 Summary: Add unsafe param to GetMarcSubfieldStructure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19820

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |CLOSED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 21:01:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 19:01:50 +0000
Subject: [Koha-bugs] [Bug 17625] 245f and 245g are not mapped to subtitle in
	XSLT
In-Reply-To: <bug-17625-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17625-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17625-70-voV0PZap8y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17625

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 21:01:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 19:01:54 +0000
Subject: [Koha-bugs] [Bug 17625] 245f and 245g are not mapped to subtitle in
	XSLT
In-Reply-To: <bug-17625-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17625-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17625-70-VymnwUdQFh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17625

--- Comment #6 from Joy Nelson <joy at bywatersolutions.com> ---
Created attachment 76302
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76302&action=edit
Bug 17625: adding subfields f and g to XSLT display

Adding 245$f and 245$g to the Results and Detail pages on OPAC and staff side

Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 21:18:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 19:18:14 +0000
Subject: [Koha-bugs] [Bug 17625] 245f and 245g are not mapped to subtitle in
	XSLT
In-Reply-To: <bug-17625-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17625-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17625-70-s5ZXkiClFi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17625

--- Comment #7 from Joy Nelson <joy at bywatersolutions.com> ---
To test:
This patch updates the display of the title subfields in the
XSLT display in the staff and OPAC.

Display includes added subfields f and g

To test:

* Have a title or two with 245 subfields f and g already in the record.
* Verify on OPAC and Staff side that subfields f and g do not appear in search
results or Details Display
* Apply the patch
* Search the opac for title used above
* Verify subfields f and g display properly
* Click a title 
* Make sure the fields display properly
* Repeat for a few more titles
* Repeat in the Staff Client

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 21:18:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 19:18:51 +0000
Subject: [Koha-bugs] [Bug 17625] 245f and 245g are not displayed in XSLT
In-Reply-To: <bug-17625-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17625-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17625-70-mBCV0o4ABQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17625

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|245f and 245g are not       |245f and 245g are not
                   |mapped to subtitle in XSLT  |displayed in XSLT

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 21:21:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 19:21:55 +0000
Subject: [Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9
	numbers are used
In-Reply-To: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20972-70-iZmU4mWTFS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx for the quick sign-off and tests, Colin!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 21:26:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 19:26:52 +0000
Subject: [Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9
	numbers are used
In-Reply-To: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20972-70-0IlUgGQ0CV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 76303
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76303&action=edit
Bug 20972: If ISBN has 10 numbers only the first 9 numbers are used

If ISBN has 10 numbers only the first 9 numbers are being added to the
Edifact-message (PIA+5+3540556753:IB')

This is caused by wrong positioning of capturing parentheses in a regular
expression.

Sponsored-by: Gothenburg University Library
Signed-off-by: Colin Campbell <colin.campbell at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 21:26:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 19:26:56 +0000
Subject: [Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9
	numbers are used
In-Reply-To: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20972-70-YvKjBDvr5R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 76304
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76304&action=edit
Bug 20972: Add a testcase for bug 20972

Ensure all 10 characters of ISBN are preserved

And that ISBNs and EANs are correctly identidied in the PIA segment

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 21:27:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 19:27:34 +0000
Subject: [Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9
	numbers are used
In-Reply-To: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20972-70-HRKfqe9iDL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 21:27:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 19:27:36 +0000
Subject: [Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9
	numbers are used
In-Reply-To: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20972-70-nsls7IpeHo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76281|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 21:27:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 19:27:39 +0000
Subject: [Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9
	numbers are used
In-Reply-To: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20972-70-rlplRQk3ii@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76290|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 21:33:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 19:33:32 +0000
Subject: [Koha-bugs] [Bug 20927] moredetail.pl crash on nonexistent
	biblionumber
In-Reply-To: <bug-20927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20927-70-OIPT1gO0Wj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20927

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 21:33:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 19:33:35 +0000
Subject: [Koha-bugs] [Bug 20927] moredetail.pl crash on nonexistent
	biblionumber
In-Reply-To: <bug-20927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20927-70-CasQe16OhR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20927

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76016|0                           |1
        is obsolete|                            |

--- Comment #2 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 76305
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76305&action=edit
Bug 20927: moredetail.pl crash on nonexistent biblionumber

moredetail.pl crashes when trying to view a nonexistent biblionumber.

The case should be handled like it is done in detail.pl.

Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi>
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 21:46:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 19:46:55 +0000
Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
In-Reply-To: <bug-14272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14272-70-ugGCmFk2XS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |charles.farmer at inlibro.com

--- Comment #49 from Charles Farmer <charles.farmer at inlibro.com> ---
Should I refrain from signing this off if the lingering issue mentionned in
comment#2 is still reproducible?

I feel like it shouldn't be too hard to add a method like
Koha::News::is_displayable that would filter the array from the search method,
and return only what's acceptable for the given interface/lang.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 21:49:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 19:49:09 +0000
Subject: [Koha-bugs] [Bug 17886] Don't show option to add to existing list
 if there are no lists
In-Reply-To: <bug-17886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17886-70-xoRLJlqWup@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 21:49:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 19:49:12 +0000
Subject: [Koha-bugs] [Bug 17886] Don't show option to add to existing list
 if there are no lists
In-Reply-To: <bug-17886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17886-70-pri4AJTAhy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75640|0                           |1
        is obsolete|                            |

--- Comment #12 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 76306
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76306&action=edit
Bug 17886: Don't show option to add to existing list if there are no lists

This patch modifies the page for adding a title to a list so that the
"Add to existing list" option doesn't appear if there are no lists
defined.

TEST PLAN
---------
1) Make sure no lists exist at all.
2) Make there is at least one findable biblio record entered
3) Find that biblio record in the OPAC
4) Click 'Save to your lists'
   -- Notice that the whole save to list section is there.
5) Apply this patch
6) Click 'Cancel'
7) Click 'Save to your lists'
   -- Notice you can only add now, which makes sense.
8) Run koha qa test tools.

Perform the same tests in the staff client.

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Followed the test plan and the patch works.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 22:18:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 20:18:54 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-UUB8vjyv58@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

Pierre-Luc Lapointe <pierre-luc.lapointe at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pierre-luc.lapointe at inLibro
                   |                            |.com

--- Comment #2 from Pierre-Luc Lapointe <pierre-luc.lapointe at inLibro.com> ---
I tested the patch and the credit is not displayed (like intended).
However, the credit is still considered in the balance, so it still shows
"Total due: -4.00". When trying to pay all fines, the message "You must pay a
value less than or equal to -4.00" still shows up and and the payment cannot be
done.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 22:25:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 20:25:15 +0000
Subject: [Koha-bugs] [Bug 18088] Software error additem.pl Can't call method
 subfield error. Can't add items.
In-Reply-To: <bug-18088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18088-70-hRHcu3KtKn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18088

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Is items.barcode mapped to a MARC field in your frameworks? You can check on
the Koha 2 MARC configuration page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 22:29:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 20:29:35 +0000
Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
In-Reply-To: <bug-14272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14272-70-Hd1a8AZtlR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272

--- Comment #50 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 76307
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76307&action=edit
Bug 14272: (follow-up) only display news available for a particular opac lang
[alternative patch]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 22:33:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 20:33:42 +0000
Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines
	list
In-Reply-To: <bug-15136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15136-70-3bvneRZzqx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 22:33:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 20:33:46 +0000
Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines
	list
In-Reply-To: <bug-15136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15136-70-fZC2DEUm2P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76112|0                           |1
        is obsolete|                            |

--- Comment #20 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 76308
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76308&action=edit
Bug 15136: Add homebranch of borrowed items to patron accounts tab

Test plan:
1 - View the accounts tab for a patron with fines
2 - Note there is no homebranch displayed to see where charges came from
3 - Apply patch
4 - Reload the page and note that you see the 'Home library' column

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Followed the test plan and it works.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 22:39:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 20:39:50 +0000
Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
In-Reply-To: <bug-14272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14272-70-qZnsOlYwNM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272

--- Comment #51 from Charles Farmer <charles.farmer at inlibro.com> ---
Went with the path of least resistance: search query now filters based on the
news_lang retrieved earlier in the script.

This should avoid retrieving news marked 'slip' or 'koha', and even those in
other languages than the one currently displayed.

Also removed a lingering variable, koha_news_count, that was not used anymore,
and not even passed to the template.

Test plan for this follow-up patch:

1) Make sure you have news from all different Location to display. At minimum,
you should have the 'koha', 'slip' and 'en' locations readily available.
1.1) If you don't, create them at <intranet
url>/cgi-bin/koha/tools/koha-news.pl
2) Apply patch "Bug 14272: Show single news item [alternative patch]"
3) Visit the OPAC
4) Click on the news' title
4.1) Not seeing any news? Go back to 1.1
5) Change the news_id parameter in the URL for another news that you've just
created
5.1) You should be able to display any news, even those which you shouldn't
have access to
6) Apply (follow-up) patch
7) Repeat 3) to 5), but this time, you should see an error message

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 22:42:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 20:42:31 +0000
Subject: [Koha-bugs] [Bug 20984] New: MARC21 subfield 300f - Type of Unit
 does not display
Message-ID: <bug-20984-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20984

            Bug ID: 20984
           Summary: MARC21 subfield 300f - Type of Unit  does not display
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: joy at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

In the search results list and details pages, the 300$f subfield does not
display.  This contains the "Type of Unit".  Subfield g appears which contains
the size of the unit.  Knowing something is  21 x 35 cm big is great, but
knowing it is a Box 21 x 35 cm is better!  Especially for sites with special
collections or archives where this information is helpful in retrieval from the
stacks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 22:49:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 20:49:52 +0000
Subject: [Koha-bugs] [Bug 20984] MARC21 subfield 300f - Type of Unit does
	not display
In-Reply-To: <bug-20984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20984-70-6UCxSn9R72@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20984

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 22:49:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 20:49:54 +0000
Subject: [Koha-bugs] [Bug 20984] MARC21 subfield 300f - Type of Unit does
	not display
In-Reply-To: <bug-20984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20984-70-a7kNNiy9oj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20984

--- Comment #1 from Joy Nelson <joy at bywatersolutions.com> ---
Created attachment 76309
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76309&action=edit
Bug 20984: Add 300$f to display

Adding Type of Unit (300$f) to the Opac details and staff side searches results
and details display

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 23:00:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 21:00:04 +0000
Subject: [Koha-bugs] [Bug 20921] Expose borrowernumber and branch when user
 is logged in to OPAC
In-Reply-To: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20921-70-twAv8JDKJV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 23:00:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 21:00:09 +0000
Subject: [Koha-bugs] [Bug 20921] Expose borrowernumber and branch when user
 is logged in to OPAC
In-Reply-To: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20921-70-MjFHusJrf5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76200|0                           |1
        is obsolete|                            |

--- Comment #8 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 76310
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76310&action=edit
Bug 20921: Add borrowernumber and branchcode as html attributes

To test:
1 - Apply patch
2 - Visit the opac
3 - Sign in
4 - You should not see any difference
5 - Inspect the element  'Welcome, {username}'
6 - Note the attributes for borrowernumber and branchcode
7 - Add to OPACUserJS:
$(document).ready(function(){
    console.log( $(".loggedinusername").attr('data-branchcode'));
    console.log( $(".loggedinusername").attr('data-borrowernumber'));
});
8 - Check the console and note you can see the info expected

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Followed the test plan and it works.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 23:06:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 21:06:37 +0000
Subject: [Koha-bugs] [Bug 20985] New: CanBookBeReserved and
 CanItemBeReserved should check 'On shelf holds allowed' policy
Message-ID: <bug-20985-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985

            Bug ID: 20985
           Summary: CanBookBeReserved and CanItemBeReserved should check
                    'On shelf holds allowed' policy
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Via ILSDI we use the routines mentioned above to determine holdability,
however, neither of these routines check on shelf hold policies

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 23:07:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 21:07:09 +0000
Subject: [Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is
	impossible
In-Reply-To: <bug-19945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19945-70-Y88myBDHb4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA
                 CC|                            |nick at bywatersolutions.com

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
I don't think the second patch is quite right - CanBookBeReserved calls
CanItemBeReserved, but it might not be correct for a specific item

Set a rule for 'No Holds Allowed' for an itemtype
Find a bib with no items or create on
Add an item with the disallowed item type
Attempt hold on item via ILSDI - Not allowed
Add a second item with a holdable itemtype
Attempt hold on the original unholdable item via ILSDI - Allowed?

I think the call in 'Hold Item' to CanBookBeReserved is the extraneous one
unless I missed something

I also note that neither of the routines mentioned check for 'On shelf holds
allowed' policy - filed as bug 20985

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 23:23:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 21:23:37 +0000
Subject: [Koha-bugs] [Bug 14222] Sort holds in OPAC by priority
In-Reply-To: <bug-14222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14222-70-tS54cOb7hz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14222

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 23:23:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 21:23:40 +0000
Subject: [Koha-bugs] [Bug 14222] Sort holds in OPAC by priority
In-Reply-To: <bug-14222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14222-70-6GIqcAOeNB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14222

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76237|0                           |1
        is obsolete|                            |

--- Comment #3 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 76311
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76311&action=edit
Bug 14222: Sort holds in OPAC by priority

This patch modifies the markup of the users's holds table in the OPAC so
that if hold priority is displayed, the table will be sorted by that
number.

To test, apply the patch and set the OPACShowHoldQueueDetails system
preference to "Show priority level" or "Show holds and their priority
level."

 - Log in to the OPAC as a user who has multiple holds with various
   priorities. Include priorities which could be sorted incorrectly
   using a text sort, e.g. 1, 10.
 - View the holds tab on the "your summary" page. Confirm that the
   priority column is sorted by default with the lowest priority holds
   first.
 - Set the  OPACShowHoldQueueDetails preference to "Show holds" and
   confirm that the holds table still displays correctly, sorted by
   "Placed on" ascending.

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Followed the test plan and the patch works.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 23:28:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 21:28:18 +0000
Subject: [Koha-bugs] [Bug 20931] JS error "ReferenceError: $ is not defined"
 when CircSidebar is turned on
In-Reply-To: <bug-20931-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20931-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20931-70-Y0PlzkLpeC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20931

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |charles.farmer at inlibro.com

--- Comment #5 from Charles Farmer <charles.farmer at inlibro.com> ---
Could reproduce, and went through most pages in the sidebar: the ones I visited
were indeed highlighted as active, and the '$' error went away after applying
patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 23:29:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 21:29:50 +0000
Subject: [Koha-bugs] [Bug 20931] JS error "ReferenceError: $ is not defined"
 when CircSidebar is turned on
In-Reply-To: <bug-20931-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20931-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20931-70-TGqWgFWrf9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20931

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 23:29:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 21:29:52 +0000
Subject: [Koha-bugs] [Bug 20931] JS error "ReferenceError: $ is not defined"
 when CircSidebar is turned on
In-Reply-To: <bug-20931-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20931-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20931-70-lsM7VWCqWh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20931

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76215|0                           |1
        is obsolete|                            |

--- Comment #6 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 76312
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76312&action=edit
Bug 20931: JS error "ReferenceError: $ is not defined" when CircSidebar is
turned on

This patch reorganizes the way sidebar menus get highlighted based on
the current page. A global function is added to handle most cases.
Individual menu-handling scripts have been modified to handle only the
edge cases which aren't covered by the global one.

A new class is added to the global CSS file so that highlighted menu
links can be custom-styled.

To test, apply the patch and clear your cache if necessary.

View various pages to confirm that current-page-highlighting in the
sidebar menu is working correctly and that there are no JS errors in the
browser console. For example:

 - Administration -> Currencies and exchange rates.
 - Acquisitions -> Invoices
 - Tools -> Patron lists
 - Tools -> Export

And with CircSidebar turned on test various circulation pages, e.g.

 - Circulation -> Set library

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 23:47:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 21:47:06 +0000
Subject: [Koha-bugs] [Bug 19039] Results of virtual shelves (lists) not
	sortable by date
In-Reply-To: <bug-19039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19039-70-HILnGjfUcS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 23:47:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 21:47:09 +0000
Subject: [Koha-bugs] [Bug 19039] Results of virtual shelves (lists) not
	sortable by date
In-Reply-To: <bug-19039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19039-70-YlBWDMvoFh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039

--- Comment #1 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 76313
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76313&action=edit
Bug 19039: Results of virtual shelves (lists) not sortable by date

In the staff client, when viewing the content of a list, it can be sorted by
'title', 'author' or 'call number' but not by 'date added'.

Test plan:
1) In the staff client, view a list containing several items
2) Notice that you can't sort by 'date added'
3) Apply the patch
4) Repeat step 1
5) The list can now be sorted by 'date added'

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 23:48:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 21:48:23 +0000
Subject: [Koha-bugs] [Bug 19039] Results of virtual shelves (lists) not
	sortable by date
In-Reply-To: <bug-19039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19039-70-G5w9hROLWY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com,
                   |                            |maryse.simard at inlibro.com,
                   |                            |philippe.blouin at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 23:48:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 21:48:41 +0000
Subject: [Koha-bugs] [Bug 20697] Remove some Host-Item-Number noise from
 zebra-output.log when EasyAnalyticalRecords is not used
In-Reply-To: <bug-20697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20697-70-RYom3GVqc6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20697

--- Comment #6 from Charles Farmer <charles.farmer at inlibro.com> ---
That's perfect. I was able to reproduce and confirm that your patch fixes the
issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 23:49:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 21:49:08 +0000
Subject: [Koha-bugs] [Bug 20697] Remove some Host-Item-Number noise from
 zebra-output.log when EasyAnalyticalRecords is not used
In-Reply-To: <bug-20697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20697-70-KrDOWi1UEB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20697

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 23:49:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 21:49:11 +0000
Subject: [Koha-bugs] [Bug 20697] Remove some Host-Item-Number noise from
 zebra-output.log when EasyAnalyticalRecords is not used
In-Reply-To: <bug-20697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20697-70-LLwIlGY16z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20697

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75002|0                           |1
        is obsolete|                            |

--- Comment #7 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 76314
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76314&action=edit
Bug 20697: Bind calling GetAnalyticsCount to pref EasyAnalyticalRecords

If you do not use the EasyAnalyticalRecords feature (introduced with
bug 5528), you will have a lot of warnings in zebra-output.log like:

zebrasrv(1096) [request] Search biblios ERROR 114 1 1+0 RPN @attrset Bib-1
@attr 1=8911 259186

They come from C4::Items::GetAnalyticsCount called by catalogue/detail.pl.
This sub starts a Zebra search on index 'hi' (Host-Item-Number).
If you do not use this field at all (related to 773$9 in MARC21), Zebra
returns an Unsupported Use attribute error (114).

In making this change, I added one minor change:
[1] Remove the commented GetAnalyticsCount in additem.pl and correcting
    indentation in that loop (removing tabs). So no change at all there.

NOTE: I will propose to bind the GetHostItemsInfo call in detail.pl and two
other scripts to this preference too on report 20702.

Test plan:
[1] If you use EasyAnalytics, verify that there is no change.
[2] If you do not, check the zebra-output.log. You should no longer see
    searches for Host-Item-Number with 1=8911. (As well as ERROR 114 on
    this index.)

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 23:57:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 21:57:58 +0000
Subject: [Koha-bugs] [Bug 20986] New: MARC21 Supplement and Index Textual
 Holdings don't display
Message-ID: <bug-20986-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986

            Bug ID: 20986
           Summary: MARC21 Supplement and Index Textual Holdings don't
                    display
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: MARC Bibliographic data support
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: joy at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Koha currently only displays the 866 Textual Holdings tag.  It does not display
the 867 Supplements or 868 Indexes Textual Holdings data.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 00:02:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 22:02:43 +0000
Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to
	configuration files
In-Reply-To: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20073-70-XBurOv6fDR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073

--- Comment #51 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 76315
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76315&action=edit
Bug 20073: (RM follow-up) Remove atomicupdate

D'oh

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 00:03:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 22:03:31 +0000
Subject: [Koha-bugs] [Bug 20744] Replace staff client header Koha logo gif
 with transparent png
In-Reply-To: <bug-20744-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20744-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20744-70-4usxUG9ii7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20744

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 00:03:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 22:03:52 +0000
Subject: [Koha-bugs] [Bug 20867] Ability to show membership renewal date on
 moremember.pl page
In-Reply-To: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20867-70-qpitWa7kcm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 00:04:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 22:04:09 +0000
Subject: [Koha-bugs] [Bug 18521] Renew and search hotkeys are swapped on
	returns page.
In-Reply-To: <bug-18521-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18521-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18521-70-vLxbvCUnzS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18521

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11.x

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 00:04:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 22:04:23 +0000
Subject: [Koha-bugs] [Bug 20864] Only set bibs_selected cookie when
 BrowseResultSelection is activated
In-Reply-To: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20864-70-1iemioNeGR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 00:04:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 22:04:38 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth in combination with LDAP as an
 alternative no longer works
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-5biWxh3pRD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #22 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 00:05:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 22:05:16 +0000
Subject: [Koha-bugs] [Bug 20676] svc/barcode should allow barcode to be
 printed without text
In-Reply-To: <bug-20676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20676-70-7YI4tS2wpO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 00:04:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 22:04:57 +0000
Subject: [Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9
	numbers are used
In-Reply-To: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20972-70-zQZAdETUOo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 00:24:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 22:24:47 +0000
Subject: [Koha-bugs] [Bug 20986] MARC21 Supplement and Index Textual
 Holdings don't display
In-Reply-To: <bug-20986-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20986-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20986-70-zwv9iJJWrA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 00:24:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 22:24:49 +0000
Subject: [Koha-bugs] [Bug 20986] MARC21 Supplement and Index Textual
 Holdings don't display
In-Reply-To: <bug-20986-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20986-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20986-70-eIH6M0JVch@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986

--- Comment #1 from Joy Nelson <joy at bywatersolutions.com> ---
Created attachment 76316
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76316&action=edit
Bug 20986 Add 867 and 868 holdings display

Add line breaks in the 866 Holdings display in the OPAC details and Staff
details page.  Add 867 and 868 textual holdings with line breaks in the OPAC
and Staff details display.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 00:26:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2018 22:26:43 +0000
Subject: [Koha-bugs] [Bug 20986] MARC21 Supplement and Index Textual
 Holdings don't display
In-Reply-To: <bug-20986-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20986-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20986-70-hqgRSdfNT4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986

--- Comment #2 from Joy Nelson <joy at bywatersolutions.com> ---
Test plan

* Create a big with multiple 866, 867 and 868 tags
* Note that the display in OPAC and Staff Details pages does not contain 867,
868 textual holdings and the 866 tags are run together on one line
* Apply the patch
* Now the 867 and 868 tags display
* Additionally the 866,867 and 868 are displayed one per line

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 09:13:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2018 07:13:54 +0000
Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
In-Reply-To: <bug-20287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20287-70-Ikc2k6yt7f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

--- Comment #11 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Jonathan

Pattern
=======
I'm not sure about the pattern you are using in ->store. Take a look here:

http://search.cpan.org/dist/DBIx-Class/lib/DBIx/Class/Storage.pm#txn_do

Basically, txn_do is encapsulating the exception you are raising, and so the
behaviour is not the expected one.

Failure in Object.t
===================
Regarding the failure in Object.t, I agree we should pick a more simple object
(I guess Koha::Patron was the first we introduced and was pretty simple until
this patchset).

Exceptions
==========
On bug 20590 we introduced Koha::Exceptions::Exception->full_message (which
should be moved into the implementing class (in the case you implemented,
Koha::Exceptions::Object) but the way it is implemented works for the use case
you wrote, but not for Koha::Object->store.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 10:49:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2018 08:49:33 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-GRTjKCtlO3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76318
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76318&action=edit
Bug 20946: Use K::Account->outstanding_debits in pay.pl and paycollect.pl

This patch changes the how account lines are fetched (using
Koha::Account->outstanding_debits) so credits are not picked.

To test:
- Add a $5 credit to a patron
- Add a $1 fine
- Go to the 'Pay fines' tab
=> FAIL: Credit is displayed
- Try to pay all fines
=> FAIL: You are told to enter a value less than or equal to -4.00
         (Observe you cannot do that)
- Apply this patch
- Reload
=> SUCCESS: Credit is not displayed
=> SUCCESS: You are able to pay all fines
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 10:49:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2018 08:49:26 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-ofkIExzgrA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76116|0                           |1
        is obsolete|                            |

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76317
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76317&action=edit
Bug 20946: Add Koha::Account::outstanding_debits

This patch adds a handy method that returns the total for outstanding
debits (i.e. those that haven't been canceled with credits), and the
corresponding Koha::Account::Line objects.

Unit tests are added.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Account.t
=> SUCCESS: tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 10:50:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2018 08:50:40 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-xN8T2f7igM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Pierre-Luc Lapointe from comment #2)
> I tested the patch and the credit is not displayed (like intended).
> However, the credit is still considered in the balance, so it still shows
> "Total due: -4.00". When trying to pay all fines, the message "You must pay
> a value less than or equal to -4.00" still shows up and and the payment
> cannot be done.

I took a shortcut and missed that. The latest patches implement it as I think
it should be (until we use the API for this of course).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 10:51:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2018 08:51:08 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-8MJbfminhl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 10:55:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2018 08:55:36 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-6WX6aFbZd7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76278|0                           |1
        is obsolete|                            |

--- Comment #10 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76319
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76319&action=edit
Bug 20978: Unit tests

This patch adds unit tests for Koha::Account::add_credit.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 10:55:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2018 08:55:44 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-zomrDw7aYr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76279|0                           |1
        is obsolete|                            |

--- Comment #11 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76320
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76320&action=edit
Bug 20978: Add Koha::Account::add_credit

This patch adds:
- Koha::Account::add_credit
- A single source of truth for accounttype and offset_type values

To test:
- Apply the first patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Account.t
=> FAIL: Tests fail!
- Apply this patch
- Run:
 k$ prove t/db_dependent/Koha/Account.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 10:55:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2018 08:55:52 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-wbVzXTEoCE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76280|0                           |1
        is obsolete|                            |

--- Comment #12 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76321
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76321&action=edit
Bug 20978: (follow-up) Another use case from C4::Circulation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 10:57:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2018 08:57:16 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-3yBl6C4di3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20946

--- Comment #13 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
I rebased on top of bug 20946, which is more urgent as it affects the stable
branches.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946
[Bug 20946] Cannot pay fines for patrons with credits
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 10:57:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2018 08:57:16 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-T2pQ4mJxUc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20978


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978
[Bug 20978] Add Koha::Account::add_credit
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 10:58:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2018 08:58:44 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14825-70-qWyLUHB8gi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20978
                 CC|                            |tomascohen at gmail.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978
[Bug 20978] Add Koha::Account::add_credit
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 10:58:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2018 08:58:44 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-KnaWLWv4us@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14825


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 12:49:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2018 10:49:43 +0000
Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
In-Reply-To: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20980-70-cHhhVqm15Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76299|0                           |1
        is obsolete|                            |

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76322
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76322&action=edit
Bug 20980: Add 'Manual Credit' and fix existing offsets

This patch adds a new offset type 'Manual Credit'. And adds an atomic
update for fixing existing offsets.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 12:49:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2018 10:49:56 +0000
Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
In-Reply-To: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20980-70-OBSJCBZCx5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76301|0                           |1
        is obsolete|                            |

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76324
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76324&action=edit
Bug 20980: (follow-up) Only use UpdateStats for 'payment' and 'writeoff'

This patch makes Koha::Account::add_credit record statistics logs
(through C4::Stats::UpdateStats) only for the 'payment' and 'writeoff'
credit types.

Both credit types are whitelisted in UpdateStats, so we keep the current
behaviour. Another option would've been to add new account types to the
white list, but with the account offsets it seems that using the
statistics table for account changes won't be useful for too long, as
offsets contain the same (and more) information.

To test:
- Apply the patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Account.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 12:50:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2018 10:50:02 +0000
Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
In-Reply-To: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20980-70-lpqXM003a8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980

--- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76325
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76325&action=edit
Bug 20980: (follow-up) Offset name consistency

This patch makes 'credit' account types generate 'Manual Credit' offset.
The original patch used 'Payment' but I think the code wants to
distinguish between payments and manually added credits (otherwise they
would've picked the same accounttype value, and they don't.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 12:49:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2018 10:49:50 +0000
Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
In-Reply-To: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20980-70-6iV1W5tI5G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76300|0                           |1
        is obsolete|                            |

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76323
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76323&action=edit
Bug 20980: Make mancredit.pl use Koha::Account::add_credit

This patch makes creating a manual credit from the UI record the account
offset as 'Manual Credit', and properly set account_offsets.credit_id
instead of account_offsets.debit_id.

To test:
- Create a manual credit (of 'Credit' type) for a known patron (acevedo?)
- Run:
  $ sudo koha-mysql kohadev
  > SELECT * FROM account_offsets;
=> FAIL: The account offset for the manual credit has type=Manual Debit,
    credit_id=NULL and debit_id=accountlines_id
- Run the atomic update:
  $ updatedatabase
- Run:
  $ sudo koha-mysql kohadev
  > SELECT * FROM account_offsets;
=> SUCCESS: The account offset has been corrected and now has
type=Manual Credit, credit_id=accountlines_id and debit_id=NULL
- Create a new manual credit (of 'Forgiven' type) for a known patron
- Run:
  $ sudo koha-mysql kohadev
  > SELECT * FROM account_offsets;
=> SUCCESS: The account offset has been stored correctly as a credit!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 13:48:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2018 11:48:41 +0000
Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
In-Reply-To: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20980-70-ZD9OAswg7A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Just pointing out... we do have rules about capitalization:
Manuel Credit should be Manuel credit (and possibly should actually be a
code... but that's another story)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 14:04:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2018 12:04:00 +0000
Subject: [Koha-bugs] [Bug 7547] Printing a sorted cart
In-Reply-To: <bug-7547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7547-70-3iqVyj79RI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|printing a sorted cart      |Printing a sorted cart

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 11:20:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2018 09:20:27 +0000
Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA
In-Reply-To: <bug-18309-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18309-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18309-70-KIJ9CtP02a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309

--- Comment #23 from Fran?ois Pichenot <fpichenot at ville-roubaix.fr> ---
Hi Laurent,

Thank you very much and sorry for the late reply...


> 009 ARK perennial identifier of the record [obsolete since version 2007]
> ARK = Archival Resource Key / This is a Bnf Specific Zone
> . See ARK specifications: http://www.cdlib.org/inside/diglib/ark/arkspec.pdf
> [accessed October 10, 2006]
> ex: 009http: //catalogue.bnf.fr/ark: / 12148 / cb375475483
BnF doesn't use 009 anymore (since 2016, see
http://www.bnf.fr/documents/unimarc_b_recap_modif.pdf p.6).
But 009 seems to be useful to store Sudoc PPN (as 035 is a repeatable field),
so I added it.

> Add the following subfield: $ 010 9 which is a field put forward by the ABES as part of the Sudoc network. The information of Sudoc is the following
> UNIMARC / Bibliographic
> Field 010: export of subfield $ 9 (repeatable): "ISBN of a serial delivery"
> This Sudoc-specific subfield is likely to be present in periodical records. It contains the ISBN of a periodical delivery > when it is processed in the Sudoc in the collector's state under the note of the periodical concerned.
OK

> Block 181 except that the $ 181 a must be repeatable
OK

> Block 183 = 183 $ P sub-field specific to ABES and Sudoc network 
183 $P doesn't appear in Sudoc exchange format (see
http://www.abes.fr/Media/Fichiers/Sudoc-Fichiers/Produire-dans-le-Sudoc/Format-d-echange-des-donnees-bibliographiques)

> 183 $ 8 under IFLA specific field obviously missing
OK

> Block 219 = OK but specific to Sudoc of ABES;
This field is included in BnF exchange format (see
http://www.bnf.fr/documents/unimarc_b_recap_modif.pdf p22) but not appears in
Sudoc exchange format. So I correct the field tag.

> Attention misses $ 219 $ 6 and $ 7, under fields reserved for cataloging documents with non-Latin characters. Also note that $ 219 $ P $ r $ s and $ 6 and $ 7 are non-repeatable subfields (to be corrected)
This is not included in an exchange format.

> Block 231 new since 2017: does not exist at Bnf and ABES Sudoc
> All sub fields are repeatable so correct
OK

> Block 283 new since 2017: does not exist at BnF and ABES Sudoc
> Lack $ 8Material specific, repeatable
OK

> Bloc 338 new 2017: does not exist at BnF and ABES Sudoc
> Be careful and correct: $ b, $ c and $ e are repeatable!
OK

> Block 915 specific to ABES Sudoc
> Be careful the $ a and $ b are repeatable (to correct)
OK

> Block 916 no longer exists at ABES Sudoc (to be deleted? if it do not exist in IFLA)
Are you sure ? 916 still appears in Sudoc exchange format (see
http://www.abes.fr/Media/Fichiers/Sudoc-Fichiers/Produire-dans-le-Sudoc/Format-d-echange-des-donnees-bibliographiques
p.71)

> Bloc 918 specific to the BNF
Are you sure ? 918 still appears in Sudoc exchange format (see
http://www.abes.fr/Media/Fichiers/Sudoc-Fichiers/Produire-dans-le-Sudoc/Format-d-echange-des-donnees-bibliographiques
p.71)

> Field 930
> Missing subfield $ j "PEB code" that is specific to ABES Sudoc / non-repeatable
> Missing subfield $ v "Copy status code" that is specific to ABES Sudoc / non-repeatable
> Missing subfield $ Z "Shared Conservation Plan Code" that is specific to ABES Sudoc / Repeatable
> Missing the subfield $ p "Conservation pole or associated pole in the context of a PCPP" that is specific to the ABES Sudoc / non-repeatable
OK

> Add the entire block 931 (Sudoc block of the abes) that is missing in the document is $ 5, $ 2, $ a, $ b, $ c, $ d, $ e, $ g, $ h, $ i, $ l, $ v / all are non-repeatable / for labels see http://documentation.abes.fr/sudoc/formats/loc/zones/931.htm
OK


> This comment deals with the 932 that was proposed to delete
> Why remove the 932 zone that seems useful for the ABES (sudoc)
This field is not included in Sudoc exchange format (see
http://www.abes.fr/Media/Fichiers/Sudoc-Fichiers/Produire-dans-le-Sudoc/Format-d-echange-des-donnees-bibliographiques)

> All block 955 (used by ABES sudoc) is to be reviewed because it lacks subfields like this: $ =, $ 0, $ 1, $ 2, $ 3, $ 4, 
Field conformed to Sudoc exchange format (see
http://www.abes.fr/Media/Fichiers/Sudoc-Fichiers/Produire-dans-le-Sudoc/Format-d-echange-des-donnees-bibliographiques
p72)

> Block 956
Field conformed to Sudoc exchange format (see
http://www.abes.fr/Media/Fichiers/Sudoc-Fichiers/Produire-dans-le-Sudoc/Format-d-echange-des-donnees-bibliographiques
p72)


> Block 957
> All block 957 (used by Sudoc of ABES) is to be reviewed because it lacks subfields like this: $ -, $ 0, $ 1, $ 2, $ 3, $ 4, $ 7, $ n, $ p, $ q / them $ 1, $ 2, $ 3, $ 4 and $ 7 are non-repeatable unlike others
> Remove $ h, $ i, $ j, $ r, $ w, and $ z
> http://documentation.abes.fr/sudoc/formats/loc/zones/957.htm
Field conformed to 

*Commentary 16
Block 958 = OK

> Bloc 959 has just been added by Sudoc ABES
> Any good but addition of a $ r that does not exist at the level of the ABES?
959 $r occurs in Sudoc exchange format (see
http://www.abes.fr/Media/Fichiers/Sudoc-Fichiers/Produire-dans-le-Sudoc/Format-d-echange-des-donnees-bibliographiques)

> Not found the 987 where does it come from?
BnF exchange format : http://www.bnf.fr/documents/UNIMARC(B)_conversion.pdf
p.59

> Block 990 $ has repeatable!
OK

> Block 991 All good except $ b and $ c repeatable
OK

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 11:49:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2018 09:49:49 +0000
Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA
In-Reply-To: <bug-18309-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18309-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18309-70-qKBN2LY6RP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309

Fran?ois Pichenot <fpichenot at ville-roubaix.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72825|0                           |1
        is obsolete|                            |

--- Comment #24 from Fran?ois Pichenot <fpichenot at ville-roubaix.fr> ---
Created attachment 76326
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76326&action=edit
Bug 18309: Unimarc update from IFLA - Unimarc Biblio (French)

- corrections suggested by Laurent integrated,
    - 'unimarc_182c' values corrected,
    - 'unimarc_183a' values conformed to
http://multimedia.bnf.fr/unimarcb_trad/RDA-FR-types-supports.pdf

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 11:55:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2018 09:55:26 +0000
Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA
In-Reply-To: <bug-18309-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18309-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18309-70-Vq3DkmwOY7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309

Fran?ois Pichenot <fpichenot at ville-roubaix.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72855|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 12:05:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2018 10:05:14 +0000
Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA
In-Reply-To: <bug-18309-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18309-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18309-70-2VqPivT5DE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309

--- Comment #25 from Fran?ois Pichenot <fpichenot at ville-roubaix.fr> ---
Created attachment 76327
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76327&action=edit
Unimarc biblio (French) default export

You can check the correctness of the French Unimarc biblio framework with this
export.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 12:09:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2018 10:09:13 +0000
Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA
In-Reply-To: <bug-18309-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18309-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18309-70-WR8juz9NBg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309

--- Comment #26 from Fran?ois Pichenot <fpichenot at ville-roubaix.fr> ---
TO DO on unimarc biblio :
- checking if (sub)fields are mandatory or repeatable.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 17:18:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2018 15:18:59 +0000
Subject: [Koha-bugs] [Bug 20987] New: Attach existing item to order/basket
Message-ID: <bug-20987-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20987

            Bug ID: 20987
           Summary: Attach existing item to order/basket
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: new feature
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: giuseppe.angilella at ct.infn.it
        QA Contact: testopia at bugs.koha-community.org

It would be helpful to associate existing items to an order. Usually, when an
order is added to a basket, a new item is created. I would like to have the
possibility to "attach" existing items to orders/baskets. Existing information
such as price, replacement price, source of acquisition should be used to
populate the order.

(Motivation: I've started using Koha's Acquisition module in my library only
much after using Koha to catalogue records and circulate items. I would like to
reconstruct past acquisitions in a consistent way, at least for those items for
which acquisition details are available.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 17:19:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2018 15:19:18 +0000
Subject: [Koha-bugs] [Bug 20987] Attach existing item to order/basket
In-Reply-To: <bug-20987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20987-70-pap04MeSxb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20987

giuseppe.angilella at ct.infn.it changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |giuseppe.angilella at ct.infn.
                   |                            |it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 23:46:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2018 21:46:40 +0000
Subject: [Koha-bugs] [Bug 16488] UNIMARC to MARC21 xslt to be used in z39.50
 import sources
In-Reply-To: <bug-16488-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16488-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16488-70-4BKTOY8bye@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16488

Serhij Dubyk <dubyk at ukr.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dubyk at ukr.net

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 01:31:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2018 23:31:12 +0000
Subject: [Koha-bugs] [Bug 13153] Waiting hold checked in at different
 library doesn't re-route item to correct library
In-Reply-To: <bug-13153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13153-70-q1ui4RSTUq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153

--- Comment #21 from Hugh Rundle <hughr at brimbank.vic.gov.au> ---
(In reply to Martha Fuerst from comment #20)
> Bug bump?

Just confirming that we applied this patch on 16.11 in a 5-branch library
service several months ago and it appears to have fixed the substantive
problem.

Would be great to do the pop-up message cleanup for 18.11 but maybe that should
be split into a new bug?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 08:33:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 06:33:05 +0000
Subject: [Koha-bugs] [Bug 15395] Internationalization: plural forms, context,
	and more
In-Reply-To: <bug-15395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15395-70-t0jev3iYwT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

--- Comment #89 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76328
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76328&action=edit
Bug 15395: Keep JS translations separated from others

It saves the browser from downloading a whole ~1Mib JSON file where 99%
of it will only be used on the server side.
The downside of this is that if the same strings appear in templates and
in JS files, they will have to be translated twice.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 08:33:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 06:33:15 +0000
Subject: [Koha-bugs] [Bug 15395] Internationalization: plural forms, context,
	and more
In-Reply-To: <bug-15395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15395-70-SbASsIH74d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

--- Comment #90 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76329
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76329&action=edit
Bug 15395: Extract strings from TT BLOCKs too

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 08:33:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 06:33:25 +0000
Subject: [Koha-bugs] [Bug 15395] Internationalization: plural forms, context,
	and more
In-Reply-To: <bug-15395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15395-70-SO0EwBsB5J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

--- Comment #91 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76330
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76330&action=edit
Bug 15395: Fix translation when text contains non-ASCII characters

msgid, msgid_plural and msgctxt need to be utf8-encoded

Also, remove call to Locale::Messages->select_package which is not
needed anymore

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 08:39:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 06:39:00 +0000
Subject: [Koha-bugs] [Bug 7547] Printing a sorted cart
In-Reply-To: <bug-7547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7547-70-3aI4hQ28AW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This seems to work well, but I want to check the other changed pages still. 

Something I notices on the printout is that the printing runs into the
footers/headers in Firefox and there is only very little to no margin on the
left and right. Not sure if we can do something about this, seems similar with
the existing print feature.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:07:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:07:08 +0000
Subject: [Koha-bugs] [Bug 19353] Make possible to have custom XSL template
 for marcxml and marc21 metadata prefixes in OAI server
In-Reply-To: <bug-19353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19353-70-IeZvsOUsT6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72553|0                           |1
        is obsolete|                            |
  Attachment #72554|0                           |1
        is obsolete|                            |

--- Comment #6 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76331
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76331&action=edit
Bug 19353: Add test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:07:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:07:14 +0000
Subject: [Koha-bugs] [Bug 19353] Make possible to have custom XSL template
 for marcxml and marc21 metadata prefixes in OAI server
In-Reply-To: <bug-19353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19353-70-oXk8Bj8H8a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353

--- Comment #7 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76332
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76332&action=edit
Bug 19353: Ability to use xsl template on marc21 and marcxml metadataprefixes
in OAI provider

Test plan:
0) apply the patchset
1) setup oai server with oaiconf file defining xsl_file for metadata
format marcxml or marc21
2) play with your oai and confirm that records are transformed as
expected
3) prove t/db_dependent/OAI/Server.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:07:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:07:51 +0000
Subject: [Koha-bugs] [Bug 19353] Make possible to have custom XSL template
 for marcxml and marc21 metadata prefixes in OAI server
In-Reply-To: <bug-19353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19353-70-2PBRk1DqFG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353

--- Comment #8 from Josef Moravec <josef.moravec at gmail.com> ---
Just rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:17:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:17:16 +0000
Subject: [Koha-bugs] [Bug 20988] New: Internationalization: wrap all
 translatable text inside t() calls
Message-ID: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

            Bug ID: 20988
           Summary: Internationalization: wrap all translatable text
                    inside t() calls
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: julian.maurice at biblibre.com
          Reporter: julian.maurice at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr
        Depends on: 15395

Bug 15395's Koha::I18n is working well, but it is basically useless until we
wrap all the translatable strings inside __*() calls (or t*() calls inside
templates).
This bug aims to do that.

I wrote a little tool to automatically find and replace translatable text by
the corresponding call. It can be found here :
https://github.com/jajm/koha-i18n.

This bug will hold a few patches that will make koha-i18n work better and I'll
try to attach all the changes it does.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
[Bug 15395] Internationalization: plural forms, context, and more
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:17:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:17:16 +0000
Subject: [Koha-bugs] [Bug 15395] Internationalization: plural forms, context,
	and more
In-Reply-To: <bug-15395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15395-70-5ACBqi2MY6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20988


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988
[Bug 20988] Internationalization: wrap all translatable text inside t() calls
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:20:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:20:26 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-Va9hZ5jwec@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76333
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76333&action=edit
Bug 20988: Modify templates so that they can be parsed as HTML

This is required for koha-i18n [1] to work correctly

[1] https://github.com/jajm/koha-i18n

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:20:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:20:50 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-g7oSOVsq3z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #2 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76334
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76334&action=edit
Bug 20988: Allow to create po for all languages at once

This is required for the script that comes with koha-i18n, which creates
the new PO files and fill them with existing translations.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:21:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:21:11 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-duD1x2b91X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76335
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76335&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/includes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:21:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:21:23 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-vvlf5p1QLD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #4 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76336
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76336&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/help

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:21:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:21:34 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-PvICyx77Ef@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76337
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76337&action=edit
Bug 20988:
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:21:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:21:40 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-DtQi8xYcC0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76338
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76338&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:21:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:21:48 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-XuuoX8oVul@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76339
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76339&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/acqui

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:21:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:21:58 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-gWInsZ1LRJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76340
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76340&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/admin

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:22:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:22:03 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-3uVU8XTLXZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #9 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76341
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76341&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/authorities

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:22:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:22:08 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-DBIr9JEdkI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #10 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76342
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76342&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/basket

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:22:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:22:14 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-h8qdhG0tZf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76343
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76343&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:22:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:22:20 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-G2rSg1lTCd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #12 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76344&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:22:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:22:27 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-rOn5klffpQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #13 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76345
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76345&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/circ

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:22:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:22:32 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-7CWCdOG2ox@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #14 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76346&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/clubs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:22:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:22:36 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-2S0nEzg8dW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #15 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76347
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76347&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:22:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:22:42 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-lohg7RAW9n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #16 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76348&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/labels

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:22:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:22:48 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-kRZFhjAt8V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #17 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76349&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/members

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:22:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:22:52 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-M0TYxZmpbo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #18 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76350
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76350&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:22:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:22:58 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-JBsvKMWvom@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #19 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76351
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76351&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:23:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:23:03 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-rW6dvNhVpK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #20 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76352
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76352&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/patroncards

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:23:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:23:07 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-wyFZAeCaH8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #21 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76353
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76353&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/plugins

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:23:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:23:12 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-jPjRHV4bJs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #22 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76354
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76354&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/installer

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:23:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:23:23 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-en6PWQjnLE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #24 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76356
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76356&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/rotating_collections

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:23:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:23:31 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-lQ8XJ7TdG9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #25 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76357
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76357&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/serials

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:23:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:23:18 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-tEEI48kSZa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #23 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76355
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76355&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/reports

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:23:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:23:43 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-XvUcEIPW53@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #27 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76359
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76359&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:23:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:23:48 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-dKP7bM5Ex4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #28 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76360
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76360&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:23:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:23:55 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-025QNZD8xy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #29 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76361
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76361&action=edit
Bug 20988: koha-tmpl/opac-tmpl/bootstrap/en/includes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:23:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:23:39 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-qCB6p2z7bO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #26 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76358&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules/tools

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:24:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:24:07 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-UsFVX6uzlk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #30 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76362
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76362&action=edit
Bug 20988: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:24:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:24:14 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-iKK9JpTzdD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #31 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76363
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76363&action=edit
Bug 20988: koha-tmpl/opac-tmpl/bootstrap/en/modules

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:24:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:24:22 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-MdaCDvCxba@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #32 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76364
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76364&action=edit
Bug 20988: koha-tmpl/intranet-tmpl/prog/en/modules

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:45:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:45:24 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-Zq6ivo2W2Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #33 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76365
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76365&action=edit
Bug 20988: Add a sample of a translated PO file

PO files are too big to be attached on Bugzilla, so here's a gzipped
version of misc/translator/po/fr-FR-messages.po as generated by
create-messages.sh (found in https://github.com/jajm/koha-i18n)

After applying the patch, run
  gunzip misc/translator/po/fr-FR-messages.po.gz

A few numbers about this PO file:
- Number of messages: 14178
- Number of translated messages: 13631
- Number of non-fuzzy translated messages: 9720

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:48:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:48:49 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-mWhzmHHKkC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #34 from Julian Maurice <julian.maurice at biblibre.com> ---
All theses patches (except the first two) were generated with the following
commands:

  koha-i18n --in-place koha-tmpl/**/en/**/*.tt koha-tmpl/**/en/**/*.inc  #
might 
be a zsh'ism, haven't tried with bash
  cd misc/translator &&
$GOPATH/src/github.com/jajm/koha-i18n/scripts/create-messages.sh

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:54:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 07:54:46 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-0Jp2MJ1GWi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #35 from Julian Maurice <julian.maurice at biblibre.com> ---
Test plan:

1. Apply bug 15395
2. Apply the first two patches of this bug
3. Install koha-i18n (see the README)
4. Run koha-i18n on all .tt and .inc files
5. cd to misc/translator and run
$GOPATH/src/github.com/jajm/koha-i18n/scripts/create-messages.sh
6. Run ./translate install fr-FR  # or any available language
7. Reload starman
8. Go to Koha with your browser, switch language to fr-FR and check that the
strings translated in misc/translator/fr-FR-messages.po are translated in the
interface.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 11:03:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 09:03:08 +0000
Subject: [Koha-bugs] [Bug 17705] Payments with cards through payment terminal
In-Reply-To: <bug-17705-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17705-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17705-70-h6Q1IAMndk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17705

--- Comment #11 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76367&action=edit
Bug 17705: payments using payment terminal

This patch expects already installed and configured payment terminal,
e.g Ingenico, provided by GPE (Global Payments Europe). This piece of
code already acquired an official certification in GPE Headquarter,
Prague, Czech Republic. Bank accounts connected to banks KB or CSOB
should work perfectly. Other banks will probably require additional
certifications and changes in the code.

Test plan
1) Appy this patch
2) Connect and/or start terminal device
3) Go to administration setting and look for "PosTerminal" items
4) Setup desired values (IP and port)
5) Make patron to pay a single fine (eg. lost book)
6) Tick the box "Pay by card" and confirm the payment
7) Popup window will raise displaying transaction status
8) Let the patron pay his amount using the terminal
9) When transaction finishes, close popup window
10) Optional: try to refund an amount by clicking "Refund to card"
button within fines overview (members/boraccount.pl). Steps 7-9 will
repeat accordingly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 11:03:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 09:03:12 +0000
Subject: [Koha-bugs] [Bug 17705] Payments with cards through payment terminal
In-Reply-To: <bug-17705-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17705-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17705-70-6NKyJvOU3X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17705

--- Comment #12 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76368
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76368&action=edit
Bug 17705: Update Schema

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 11:03:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 09:03:04 +0000
Subject: [Koha-bugs] [Bug 17705] Payments with cards through payment terminal
In-Reply-To: <bug-17705-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17705-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17705-70-i1AY3WC7ti@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17705

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64526|0                           |1
        is obsolete|                            |
  Attachment #64527|0                           |1
        is obsolete|                            |
  Attachment #64528|0                           |1
        is obsolete|                            |
  Attachment #64529|0                           |1
        is obsolete|                            |
  Attachment #64613|0                           |1
        is obsolete|                            |

--- Comment #10 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76366&action=edit
Bug 17705: Database structure update

This patch creates neccessary table and updates systempreferences.

Test plan:
1) Apply the patch
2) Check the presence of pos_terminal_transactions table
3) Observe new systempreferences' values
   - PosTerminalIP
   - PosTerminalPort
   - PosTerminalCurrencyCode

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 11:15:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 09:15:31 +0000
Subject: [Koha-bugs] [Bug 17705] Payments with cards through payment terminal
In-Reply-To: <bug-17705-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17705-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17705-70-pwKA1Qzuil@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17705

--- Comment #13 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 76367
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76367
Bug 17705: payments using payment terminal

Review of attachment 76367:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17705&attachment=76367)
-----------------------------------------------------------------

Radek, I just rebased your patches and have some comments on this patch:

::: Koha/PosTerminal/Client.pm
@@ +15,5 @@
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with Koha; if not, see <http://www.gnu.org/licenses>.
> +

use Modern::Perl;

@@ +19,5 @@
> +
> +use IO::Socket::INET;
> +use IO::Socket::Timeout;
> +use Koha::PosTerminal::Message;
> +use Errno qw(ETIMEDOUT EWOULDBLOCK);

You are adding some new dependencies here, you should add them to
C4/Installer/PerlDependecies.pm, are they all available also for Debian in
needed versions?

::: Koha/PosTerminal/Message.pm
@@ +17,5 @@
> +# You should have received a copy of the GNU General Public License
> +# along with Koha; if not, see <http://www.gnu.org/licenses>.
> +
> +use strict;
> +use warnings;

use Modern::Perl;

@@ +22,5 @@
> +
> +use Digest::CRC;
> +use Koha::PosTerminal::Message::Header;
> +use Koha::PosTerminal::Message::Field;
> +use Data::Dumper qw( Dumper );

Don't forget to remove debug printing;

@@ +178,5 @@
> +        else {
> +            $self->setValid(0);
> +        }
> +    }
> +#    print Dumper($self);

Don't forget to remove debug printing;

@@ +221,5 @@
> +    my $msg = $self->getHeader()->dumpObject();
> +
> +    $msg .= "data:\n";
> +#    print Dumper($self);
> +#die();

Don't forget to remove debug printing;

::: Koha/PosTerminal/Message/Field.pm
@@ +17,5 @@
> +# You should have received a copy of the GNU General Public License
> +# along with Koha; if not, see <http://www.gnu.org/licenses>.
> +
> +use strict;
> +use warnings;

use Modern::Perl;

::: Koha/PosTerminal/Message/Header.pm
@@ +17,5 @@
> +# You should have received a copy of the GNU General Public License
> +# along with Koha; if not, see <http://www.gnu.org/licenses>.
> +
> +use strict;
> +use warnings;

use Modern::Perl;

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
@@ +75,5 @@
>            [% IF ( account.payment ) %]
>              <a href="boraccount.pl?action=reverse&amp;accountlines_id=[% account.accountlines_id %]&amp;borrowernumber=[% account.borrowernumber %]" class="btn btn-default btn-xs"><i class="fa fa-undo"></i> Reverse</a>
>              <a href="boraccount.pl?action=void&amp;accountlines_id=[% account.accountlines_id %]&amp;borrowernumber=[% account.borrowernumber %]" class="btn btn-default btn-xs"><i class="fa fa-ban"></i> Void</a>
> +            [% IF (account.amountoutstanding+0 + account.amount+0 != 0 ) %]
> +            <a href="boraccount.pl?action=reverse&amp;accountlines_id=[% account.accountlines_id %]&amp;borrowernumber=[% account.borrowernumber %]" class="btn btn-default btn-xs" onclick="refundPayment(this.href, [% account.accountlines_id %], [% -1*account.amount %]);return false;"><i class="fa fa-undo"></i> Refund to card</a>

Do not use onclick parameter

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
@@ +46,4 @@
>  [% END %]
>  
>  [% IF ( pay_individual ) %]
> +    <form name="payindivfine" id="payindivfine" method="post" onsubmit="return makePayment(this);" action="/cgi-bin/koha/members/paycollect.pl">

Do not use onsubmit parameter

@@ +105,5 @@
> +    <li>
> +        <label for="bycard">Pay by card: </label>
> +        <input type="checkbox" name="bycard" id="bycard" value="1"/>
> +    </li>
> +[% END %]

Consider using PAYMENT_TYPE authorised value

::: svc/pos_terminal
@@ +160,5 @@
> +
> +    # send abort message
> +    my $abort = new Koha::PosTerminal::Message(Koha::PosTerminal::Message::DIR_SENT);
> +    my $hdrAbort = $abort->getHeader();
> +die(Dumper($transaction ? $transaction->getHeader() : "BUBU"));

What does "BUBU" mean? :D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 11:15:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 09:15:43 +0000
Subject: [Koha-bugs] [Bug 17705] Payments with cards through payment terminal
In-Reply-To: <bug-17705-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17705-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17705-70-35iixFilye@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17705

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 11:15:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 09:15:54 +0000
Subject: [Koha-bugs] [Bug 17705] Payments with cards through payment terminal
In-Reply-To: <bug-17705-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17705-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17705-70-9hqJQCw1Ze@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17705

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 12:10:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 10:10:51 +0000
Subject: [Koha-bugs] [Bug 20903] Print payment receipt on child patron could
 end with server error
In-Reply-To: <bug-20903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20903-70-Fuf26zZcVl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Raising severity as this generates ISE.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 12:57:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 10:57:15 +0000
Subject: [Koha-bugs] [Bug 20903] Print payment receipt on child patron could
 end with server error
In-Reply-To: <bug-20903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20903-70-wW1AlwPDF8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_18_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 13:30:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 11:30:24 +0000
Subject: [Koha-bugs] [Bug 19902] Add column configuration to bibliographic
 record checkouts history table
In-Reply-To: <bug-19902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19902-70-mvi4fhbyRl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19902

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76369
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76369&action=edit
Bug 19902: (follow-up) Deal with patron column regarding on
intranetreadinghistory setting

Test plan:
Try it with intranetreadinghistory allowed and not allowed and it should
still work in both cases

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 13:30:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 11:30:20 +0000
Subject: [Koha-bugs] [Bug 19902] Add column configuration to bibliographic
 record checkouts history table
In-Reply-To: <bug-19902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19902-70-Ua3GF7SrAW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19902

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 13:30:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 11:30:59 +0000
Subject: [Koha-bugs] [Bug 19902] Add column configuration to bibliographic
 record checkouts history table
In-Reply-To: <bug-19902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19902-70-oi298mvNZq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19902

--- Comment #6 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Jonathan Druart from comment #4)
> Turn off intranetreadinghistory
> => boom!

Thanks for catching this!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 13:55:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 11:55:17 +0000
Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be
 write as description, not code
In-Reply-To: <bug-20806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20806-70-evYIi7IHy5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 13:55:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 11:55:22 +0000
Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be
 write as description, not code
In-Reply-To: <bug-20806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20806-70-lahy5EIvdu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75625|0                           |1
        is obsolete|                            |

--- Comment #8 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76370&action=edit
Bug 20806: Add item type description holds history page

Test plan:

0) Do not apply the patch
1) Set AllowHoldItemTypeSelection to Allow
2) Place some hold for a patron, some with specific item type and some
without item type
3) On holds history page you should see blank or item type code in item
type column
4) Apply the patch
5) Now you should see description in item type column
6) Set AllowHoldItemTypeSelection to Don't Allow
7) You shold not see the item type column, but column visibility
settings should continue working ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 13:56:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 11:56:36 +0000
Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be
 write as description, not code
In-Reply-To: <bug-20806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20806-70-gbtFqebFoX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806

--- Comment #9 from Josef Moravec <josef.moravec at gmail.com> ---
Thanks all for comments/suggestions. I added the check of
AllowHoldItemTypeSelection system preference

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 14:07:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 12:07:30 +0000
Subject: [Koha-bugs] [Bug 19502] Result sets limited to 10000
In-Reply-To: <bug-19502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19502-70-DB3IdAYc7t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

--- Comment #9 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Alex Arnaud from comment #8)
> Debug thing ?

Yes. It can be removed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 14:15:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 12:15:23 +0000
Subject: [Koha-bugs] [Bug 19502] Result sets limited to 10000
In-Reply-To: <bug-19502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19502-70-l9R6poxtOx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

--- Comment #10 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76371&action=edit
Bug 19502: Remove debug warn

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 14:15:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 12:15:27 +0000
Subject: [Koha-bugs] [Bug 19502] Result sets limited to 10000
In-Reply-To: <bug-19502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19502-70-S7OnKBweeM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

--- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76372&action=edit
Bug 19502: Add POD for max_result_window

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 14:33:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 12:33:17 +0000
Subject: [Koha-bugs] [Bug 18720] Get rid of "die" in favor of exceptions in
 C4::Acquisition::GetBasketAsCsv
In-Reply-To: <bug-18720-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18720-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18720-70-0FfhBxyjA3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18720

--- Comment #1 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76373
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76373&action=edit
Bug 18720: Use exception instead of die in GetBasketAsCsv

Test plan:
prove t/db_dependent/Acquisition/GetBasketAsCSV.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 14:33:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 12:33:14 +0000
Subject: [Koha-bugs] [Bug 18720] Get rid of "die" in favor of exceptions in
 C4::Acquisition::GetBasketAsCsv
In-Reply-To: <bug-18720-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18720-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18720-70-VspVGS6Y19@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18720

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 14:45:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 12:45:03 +0000
Subject: [Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin
 integration into catalogue
In-Reply-To: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20968-70-wwCNrqvc6S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #1 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 76374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76374&action=edit
Add hooks into cat-toolbar.inc to display buttons

This commit adds hooks into cat-toolbar.inc to allow the display of
arbitrary buttons as supplied by plugins within the
intranet_catalog_biblio_enhancements class that provide the method
get_toolbar_button

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 14:50:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 12:50:11 +0000
Subject: [Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin
 integration into catalogue
In-Reply-To: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20968-70-Sgf3eK9q6e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #2 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 76375
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76375&action=edit
Bug 20968: Add hooks into cat-toolbar.inc to display buttons

This commit adds hooks into cat-toolbar.inc to allow the display of
arbitrary buttons as supplied by plugins within the
intranet_catalog_biblio_enhancements class that provide the method
get_toolbar_button

To test:

1) Download the plugin from
https://github.com/PTFS-Europe/cla-permissions-check-plugin
2) Follow the installation instructions from:
https://github.com/PTFS-Europe/cla-permissions-check-plugin
3) TEST: Observe that the "CLA Check Permissions" button takes the user
to the Check Permissions page and a modal displays containing the
results of the query
4) Remove the API key from the plugin "Configuration" page
5) TEST: Ensure that the "CLA Check Permissions" button takes the user
to the Check Permissions page and message displays informing the user
that "Did not receive required request parameters"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 14:50:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 12:50:33 +0000
Subject: [Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin
 integration into catalogue
In-Reply-To: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20968-70-YhjctjVpuo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76374|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 14:50:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 12:50:56 +0000
Subject: [Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin
 integration into catalogue
In-Reply-To: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20968-70-zdN8CKHtzb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 14:52:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 12:52:36 +0000
Subject: [Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin
 integration into catalogue
In-Reply-To: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20968-70-Ax1bxMOo5a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 14:59:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 12:59:38 +0000
Subject: [Koha-bugs] [Bug 16653] reports/cat_issues_top.pl does not export
 "Count of checkouts" column as CSV
In-Reply-To: <bug-16653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16653-70-Z9qMz8fCs5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16653

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75937|0                           |1
        is obsolete|                            |

--- Comment #4 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76376&action=edit
Bug 16653: Display number of checkouts when exporting 'Most-circulated items'
as CSV

reports/cat_issues_top.pl does not export "Count of checkouts" column as CSV

To replicate:

1/ Make sure that test instance has circulation in a given date range
2/ Go to Home ? Reports ? Most-circulated items
3/ Select a date range
4/ Select 'To screen into the browser' radio button, click submit.
5/ Note that Columns 'Rank/Biblioitemnumbers', 'Global' and 'Count of
checkouts' appear in screen output.
6/ Click the browser's back button
7/ Change output to 'To a file', click submit.

Without this patch:
the columns "100/", "Global" and "Total" are exported to the CSV file.
"100/" contains the rank, "Global" is still global, and the "Total" column is
empty.

With this patch patch applied, the last column is filled and the "Total" line
is removed

(This script is really dirty)

Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe at inLibro.com>

(Yes it is)

Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 14:59:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 12:59:43 +0000
Subject: [Koha-bugs] [Bug 16653] reports/cat_issues_top.pl does not export
 "Count of checkouts" column as CSV
In-Reply-To: <bug-16653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16653-70-u8WGDAhdu3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16653

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76377&action=edit
Bug 16653: (QA follow-up) Avoid a warning and remove unused variables

Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 14:59:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 12:59:56 +0000
Subject: [Koha-bugs] [Bug 16653] reports/cat_issues_top.pl does not export
 "Count of checkouts" column as CSV
In-Reply-To: <bug-16653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16653-70-Oic6zoeNHw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16653

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 15:04:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 13:04:27 +0000
Subject: [Koha-bugs] [Bug 20893] batchRebuildItemsTables.pl has incorrect
	parameter
In-Reply-To: <bug-20893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20893-70-x24onTR9WI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20893

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76165|0                           |1
        is obsolete|                            |

--- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 76378
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76378&action=edit
Bug 20893: batchRebuildItemsTables.pl has incorrect parameter

To test:
1 - run batchRebuildItemsTables.pl with a valid biblionumber
   perl /usr/share/koha/bin/batchRebuildItemsTables.pl --where
biblio.biblionumber=38483  -c
2 - Note it says 'undefined biblionumber
3 - Apply patch
4 - Do it again
5 - It works!

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 15:05:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 13:05:34 +0000
Subject: [Koha-bugs] [Bug 20893] batchRebuildItemsTables.pl has incorrect
	parameter
In-Reply-To: <bug-20893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20893-70-FoS9FHJLVg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20893

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Signed Off                  |Passed QA

--- Comment #4 from Julian Maurice <julian.maurice at biblibre.com> ---
This was broken by bug 19040.
The fix needs to be backported in 18.05.x and 17.11.x

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 15:49:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 13:49:15 +0000
Subject: [Koha-bugs] [Bug 20984] MARC21 subfield 300f - Type of Unit does
	not display
In-Reply-To: <bug-20984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20984-70-j3CYqTe1IJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20984

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |joy at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 15:50:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 13:50:06 +0000
Subject: [Koha-bugs] [Bug 20989] New: Hold Notes to be added later
Message-ID: <bug-20989-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20989

            Bug ID: 20989
           Summary: Hold Notes to be added later
 Change sponsored?: ---
           Product: Koha
           Version: 17.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fiona.borthwick at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Currently it is only possible to add a Hold Note at the time of creating the
hold. It would be nice if notes could be added at a later stage.

A few of our customers have asked for this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 15:51:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 13:51:16 +0000
Subject: [Koha-bugs] [Bug 20868] Making billing date mandatory when closing
	invoice
In-Reply-To: <bug-20868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20868-70-76517d15Cr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20868

Fiona Borthwick <fiona.borthwick at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fiona.borthwick at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:00:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 14:00:15 +0000
Subject: [Koha-bugs] [Bug 20390] Elasticsearch - Mappings for UNIMARC
	(updates existing)
In-Reply-To: <bug-20390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20390-70-UGH2i4BzKG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20390

claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #11 from claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> ---
20073 had been reverted, so I was waiting for its push, it now ok so 20390
applies now. Thanks Nick !

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:01:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 14:01:31 +0000
Subject: [Koha-bugs] [Bug 20990] New: Add Koha::Account::outstanding_credits
Message-ID: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990

            Bug ID: 20990
           Summary: Add Koha::Account::outstanding_credits
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

This will be handy for the /patrons/{patron_id}/account endpoint.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:02:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 14:02:41 +0000
Subject: [Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits
In-Reply-To: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20990-70-tlQOh4DNpX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:11:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 14:11:24 +0000
Subject: [Koha-bugs] [Bug 20585] Label surname as name for organisation type
	patrons
In-Reply-To: <bug-20585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20585-70-doV8Y5iVju@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20585

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:15:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 14:15:05 +0000
Subject: [Koha-bugs] [Bug 20585] Label surname as name for organisation type
	patrons
In-Reply-To: <bug-20585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20585-70-kdGNpCWO1C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20585

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76379
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76379&action=edit
Bug 20585: Label surname as name for organisation type patrons

This patch modifies the patron edit page so that the label for an
organization name is "Name" instead of "Surname."

To test, apply the patch and edit both an institutional patron and a
regular patron. Confirm that the name/surname label is correct in each
case.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:15:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 14:15:02 +0000
Subject: [Koha-bugs] [Bug 20585] Label surname as name for organisation type
	patrons
In-Reply-To: <bug-20585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20585-70-CS5Mm23wxM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20585

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:18:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 14:18:02 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
	Elasticsearch
In-Reply-To: <bug-19893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19893-70-JyfXSlwv20@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:18:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 14:18:07 +0000
Subject: [Koha-bugs] [Bug 20983] Show 'organisation name' instead of
 'surname' on patron form for organisations
In-Reply-To: <bug-20983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20983-70-oeUGmIg8Sf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20983

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---


*** This bug has been marked as a duplicate of bug 20585 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:18:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 14:18:07 +0000
Subject: [Koha-bugs] [Bug 20585] Label surname as name for organisation type
	patrons
In-Reply-To: <bug-20585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20585-70-bxCAmpcD3w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20585

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
*** Bug 20983 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:18:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 14:18:14 +0000
Subject: [Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits
In-Reply-To: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20990-70-zWQkl0ieja@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:18:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 14:18:17 +0000
Subject: [Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits
In-Reply-To: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20990-70-59hOlPql4M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76380
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76380&action=edit
Bug 20990: Unit tests for Koha::Account->outstanding_credits

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:18:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 14:18:22 +0000
Subject: [Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits
In-Reply-To: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20990-70-GbGJz2tAV5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76381&action=edit
Bug 20990: Add Koha::Account->outstanding_credits

This patch adds a method that retrieves (for a patron's account) the
outstanding credits (i.e. those that haven't been applied to any debit.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Account.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:21:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 14:21:57 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-mW6pxHZG1p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20942


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942
[Bug 20942] Add route to get patron's account balance
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:21:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 14:21:57 +0000
Subject: [Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits
In-Reply-To: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20990-70-d2kCVKEgqs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20942


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942
[Bug 20942] Add route to get patron's account balance
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:21:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 14:21:57 +0000
Subject: [Koha-bugs] [Bug 20942] Add route to get patron's account balance
In-Reply-To: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20942-70-OatCNUCuZy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20990, 20946


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946
[Bug 20946] Cannot pay fines for patrons with credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990
[Bug 20990] Add Koha::Account::outstanding_credits
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:36:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 14:36:25 +0000
Subject: [Koha-bugs] [Bug 12500] In opac-detail-view,
 "Browse results" shows indexes from the beginning upon hovering
 over the last index.
In-Reply-To: <bug-12500-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12500-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12500-70-NmWpLR2vLa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12500

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
I hope that Bug 20898 will make this bug obsolete.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:38:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 14:38:25 +0000
Subject: [Koha-bugs] [Bug 17137] Omnibus: Always use SSL when referencing
 external sources
In-Reply-To: <bug-17137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17137-70-kXPD7bVAnz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17137

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
All dependent bugs are marked fixed, so I think this bug is ready to be closed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:53:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 14:53:53 +0000
Subject: [Koha-bugs] [Bug 20559] Occurrences of loading-small.gif still exist
In-Reply-To: <bug-20559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20559-70-xmdkN1ThUU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:58:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 14:58:45 +0000
Subject: [Koha-bugs] [Bug 20930] Handle YAML type system preferences as
	parsed references
In-Reply-To: <bug-20930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20930-70-r3GpE0KOyN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930

--- Comment #1 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 76382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76382&action=edit
Bug 20930: Dump and load system preferences of YAML/JSON type

Currently, C4::Context->preference('YAMLpref') returns a string that needs to
be
parsed by any code using the preference.

My suggestion is to return a parsed version instead (a hash/array ref or a
string)
and using the syspref cache with the parsed value. Like this, we could:
- centralize parsing of YAML system preferences
- optimize use of system preference cache by caching the parsed version
instead.
  Parse once and store in cache; no need to re-parse on each call!

We can centralize this functionality into Koha::Config::SysPref->value() (used
by
C4::Context->preference). Use database column systempreferences.type with value
of
"YAML" to trigger this functionality in "value()"-method.

To test:
1. prove t/db_dependent/Context.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:58:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 14:58:57 +0000
Subject: [Koha-bugs] [Bug 20930] Handle YAML type system preferences as
	parsed references
In-Reply-To: <bug-20930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20930-70-0RNFCLISGA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930

--- Comment #2 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 76383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76383&action=edit
Bug 20930: First example - Change OpacHiddenItems to type YAML

To test:
1. prove t/db_dependent/Items.t
2. Check that desired items are still hidden in OPAC by using
   OpacHiddenItems as documented here:
   https://wiki.koha-community.org/wiki/OpacHiddenItems

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:59:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 14:59:11 +0000
Subject: [Koha-bugs] [Bug 20930] Handle YAML type system preferences as
	parsed references
In-Reply-To: <bug-20930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20930-70-9ohlbKM2Cr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930

--- Comment #3 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 76384
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76384&action=edit
Bug 20930: Display human readable errors in preferences page

Displays human readable error when YAML/JSON preference has invalid syntax.

If multiple preferences are modified at the same time, notifies librarian of
the
preferences that were saved and the ones that had errors.

To test:
1. Apply patches
2. Write invalid YAML syntax to OpacHiddenItems system preference
3. Observe "Error; Preference OpacHiddenItems has invalid syntax" error
4. Write valid YAML syntax to OpacHiddenItems system preference
5. Observe "Saved preference OpacHiddenItems" message
6. Test steps 2-5 for both single preference modification and together
   with other system preferences.

---
invalid:
yaml syntax

---
valid:
  yaml: syntax

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:59:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 14:59:25 +0000
Subject: [Koha-bugs] [Bug 20930] Handle YAML type system preferences as
	parsed references
In-Reply-To: <bug-20930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20930-70-PNC6aSQvxr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 17:03:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 15:03:43 +0000
Subject: [Koha-bugs] [Bug 20559] Occurrences of loading-small.gif still exist
In-Reply-To: <bug-20559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20559-70-9NjILO5gt1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 17:03:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 15:03:46 +0000
Subject: [Koha-bugs] [Bug 20559] Occurrences of loading-small.gif still exist
In-Reply-To: <bug-20559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20559-70-jtLx75HQ8F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76385
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76385&action=edit
Bug 20559: Occurrences of loading-small.gif still exist

This patch removes some leftover references to a file which no longer
exists. In the OPAC, loading-small.gif was included in CSS which was
never used. In the staff client, loading-small.gif should have been
corrected to spinner-small.gif.

To test, apply the patch and go to Tools -> Batch record modification.

 - Submit a batch of records to modify
 - In the table of titles which will be modified, click the 'Show MARC'
   button.
   - The modal preview window should show "Loading" and an animated
     spinner before the MARC record is loaded.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 17:03:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 15:03:49 +0000
Subject: [Koha-bugs] [Bug 20559] Occurrences of loading-small.gif still exist
In-Reply-To: <bug-20559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20559-70-2slwiBLKz5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76386
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76386&action=edit
Bug 20559: Compiled CSS

This patch contains the compiled OPAC CSS.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 17:04:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 15:04:37 +0000
Subject: [Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type
 system preferences
In-Reply-To: <bug-20930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20930-70-kcZ1Audyya@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Handle YAML type system     |Validate and cache parsed
                   |preferences as parsed       |YAML/JSON type system
                   |references                  |preferences

--- Comment #4 from Lari Taskula <lari.taskula at jns.fi> ---
Changed Bug title 

from "Handle YAML type system preferences as parsed references" 
to "Validate and cache parsed YAML/JSON type system preferences" 

as this now also adds syntax validation for librarians, so that it is no longer
possible to store invalid YAML system preferences.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 17:07:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 15:07:38 +0000
Subject: [Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type
 system preferences
In-Reply-To: <bug-20930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20930-70-QNx80DcOPV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930

--- Comment #5 from Lari Taskula <lari.taskula at jns.fi> ---
Also fyi, these patches do not automatically change the functionality for all
YAML/JSON type system preferences.

The type (systempreferences.type) needs to be YAML before this applies for the
preference.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 17:11:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 15:11:58 +0000
Subject: [Koha-bugs] [Bug 16970] In OPAC Search results,
 <Limit to current available items> hides a record if some of its
 items are available and others unavailable
In-Reply-To: <bug-16970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16970-70-iLg7UGm2FL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16970

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Hardware|PC                          |All
                 OS|Windows                     |All
            Version|3.22                        |master
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Confirmed in master. A title with multiple items, one of which is checked out,
is hidden from search results when the 'Limit to available' filter is applied.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 17:32:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 15:32:03 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15326-70-rQ9t2wgSI0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70866|0                           |1
        is obsolete|                            |
  Attachment #70867|0                           |1
        is obsolete|                            |
  Attachment #70868|0                           |1
        is obsolete|                            |
  Attachment #70869|0                           |1
        is obsolete|                            |
  Attachment #70870|0                           |1
        is obsolete|                            |
  Attachment #70871|0                           |1
        is obsolete|                            |

--- Comment #29 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76387
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76387&action=edit
Bug 15326: Add CMS feature

INCOMPLETE - For evaluation purposes only!

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 17:32:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 15:32:08 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15326-70-wCSG5xg3XC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

--- Comment #30 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76388
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76388&action=edit
Bug 15326: (follow-up) Add CMS feature

This patch builds on Martin Persson's patch. I made a few changes that
improve the patch and make this feature functional.
The only thing I am not completely satisfied with (and doesn't reliably
work) is the navigation for the CMS pages on both the staff side and the
OPAC side. This needs work. Otherwise the CMS feature works.

- Make sure you update database after applying patch
- After adding a few pages, confirm that filtering results works (play
 with different combinations of display location, library and language)
- Confirm that pages with specific locations ONLY show up in those
locations, i.e. OPAC pages can only be accessed in OPAC and staff interface
pages can only be accessed on staff client
- Confirm that table is showing correct data, particularly language,
location and library
- Confirm that if page has not been published and user does not have
permission to edit pages, page content will not display on OPAC side. On
staff side, a message will show saying that page has not been published
- Confirm pagination for table shows and works
- Confirm deleting pages works as expected (confirm message before
delete)
- Confirm link title must be unique when adding new pages
- Confirm that editing the details of an existing page works
- Confirm that adding a child page will only work if the location of
child page matches location of parent page, i.e., if parent page is an
OPAC page then child page must also be OPAC page. if parent page is in
all locations then child page can be in all or either interface(s)
- Confirm Select All/Clear All toggle works
- Confirm viewing of CMS pages in OPAC and in staff client works and
looks nice

Sponsored-by: Region Halland

Bug 15326: [FOLLOW-UP] Many fixes

This patch:
- moves action buttons into a dropdown, adds a delete button to dropdown
- fixes the tests (they should now all pass)
- fixes qa tool problems
- removes the Koha::CmsPages->remove() method (unnecessary)
- makes changes to the Koha::CmsPages->add() method (now simpler, easier
to test)

This is now ready to test.

Sponsored-by: Catalyst IT

Bug 15326: [FOLLOW-UP] More fixes

This patch removes the t/Pages.t file because it isn't required, and
other unused methods.

This patch is ready to test. The appropriate tests are in
t/db_dependent/Pages.t

Bug 15326: [FOLLOW-UP] adding and editing fixes

Sorry, did not see the second half of your comment. This patch should
fix the adding and editing issues in Comment 16.

Bug 15326: [FOLLOW-UP] Fixing library field in form, opac publishing

Fixes issues from Comment 19, please test

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 17:32:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 15:32:13 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15326-70-c06mZLRctO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

--- Comment #31 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76389
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76389&action=edit
Bug 15326: (follow-up) utf8 to utf8mb4

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 17:32:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 15:32:18 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15326-70-OA7cm5HoaS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

--- Comment #32 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76390&action=edit
Bug 15326: (follow-up) Move js to footer, use Asset plugin

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 17:32:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 15:32:23 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15326-70-wEVBp8PC9M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

--- Comment #33 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76391
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76391&action=edit
Bug 15326: (follow-up) Don't make links to unpublished pages in opac

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 17:32:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 15:32:28 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15326-70-hjVmKuW70F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

--- Comment #34 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76392
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76392&action=edit
Bug 15326: (follow-up) Fix tools menu highlighting

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 17:42:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 15:42:23 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15326-70-Gl6zhsK4Pf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #35 from Josef Moravec <josef.moravec at gmail.com> ---
I squashed the original patches for better readability, but then added 4 new
follow-ups ;) I tried to reflect the last changes in codebase and coding
guidelines. (things are changing quickly).

Note for QA: the feature is working OK, but there are definitely some areas
where the code could be improved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 18:18:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 16:18:59 +0000
Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
In-Reply-To: <bug-20287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20287-70-LSUiLyELzN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Tom?s Cohen Arazi from comment #11)
> Jonathan
> 
> Pattern
> =======
> I'm not sure about the pattern you are using in ->store. Take a look here:
> 
> http://search.cpan.org/dist/DBIx-Class/lib/DBIx/Class/Storage.pm#txn_do
> 
> Basically, txn_do is encapsulating the exception you are raising, and so the
> behaviour is not the expected one.

I am not sure to understand your point here,
Koha::Exceptions::Object::FKConstraint is raised and correctly propagated.

> Failure in Object.t
> ===================
> Regarding the failure in Object.t, I agree we should pick a more simple
> object (I guess Koha::Patron was the first we introduced and was pretty
> simple until this patchset).

I have added a new commit ("Use more simple object for Object.t")

> Exceptions
> ==========
> On bug 20590 we introduced Koha::Exceptions::Exception->full_message (which
> should be moved into the implementing class (in the case you implemented,
> Koha::Exceptions::Object) but the way it is implemented works for the use
> case you wrote, but not for Koha::Object->store.

I think these patches highlight that the our exception system need to be
reworked a bit and I think it's outside the scope of this bug. We should
address it ASAP, once this pushed.
See also new commit "Test exception DuplicateID for Koha::Patron->store"

Remote branch has been rebased and the 2 commits added.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 19:05:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 17:05:35 +0000
Subject: [Koha-bugs] [Bug 20927] moredetail.pl crash on nonexistent
	biblionumber
In-Reply-To: <bug-20927-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20927-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20927-70-xouFRf9fbn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20927

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20661,
                   |                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20351
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I would recommend to use output_and_exit_if_error (introduced by bug 18043).

You can find examples on bug 20661 and bug 20351.

I was waiting for these patches to get attention before continuing in this
direction (and so apply the method to other modules).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 19:05:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 17:05:35 +0000
Subject: [Koha-bugs] [Bug 20351] Implement blocking errors for serials
	scripts
In-Reply-To: <bug-20351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20351-70-lgcCsxeIzE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20351

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20927

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 19:05:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 17:05:35 +0000
Subject: [Koha-bugs] [Bug 20661] Implement blocking errors for circulation
	scripts
In-Reply-To: <bug-20661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20661-70-HX9Zy4BJhh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20661

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20927

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 19:07:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 17:07:25 +0000
Subject: [Koha-bugs] [Bug 5789] Fines don't work when items have null
	homebranch
In-Reply-To: <bug-5789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5789-70-IARNgjk6Pn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5789

--- Comment #12 from Saiful Amin <saiful at semanticconsulting.com> ---
(In reply to Jonathan Druart from comment #11)
> If we consider that it is a data migration issue I think we should start
> writing a script to catch them.
> 
> See also bug 20509.
> 
> We cannot deal everywhere with such inconsistency, and if we do it in this
> script, we need to do it everywhere else.
> 
> I would prefer to see a misc script searching for any kinds of data
> inconsistency in DB. We will then improve it incrementally.

Separate script idea to check data inconsistency is good one. It will save lot
of time in fixing issues, such as missing foreign keys.

I still don't think scripts should break on missing/bad data. For example, I've
observed that bulkmarcimport.pl breaks if 245$c contains Arabic date. Ideally,
it should warn and skip the record if it can't process the data. I'm not sure
if this is by design.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 19:10:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 17:10:10 +0000
Subject: [Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
In-Reply-To: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20906-70-izz5oRnbMt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.05.x for 18.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 19:16:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 17:16:26 +0000
Subject: [Koha-bugs] [Bug 5789] Fines don't work when items have null
	homebranch
In-Reply-To: <bug-5789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5789-70-bXHN4vE8sG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5789

--- Comment #13 from Saiful Amin <saiful at semanticconsulting.com> ---
(In reply to Saiful Amin from comment #12)
> I still don't think scripts should break on missing/bad data. For example,
> I've observed that bulkmarcimport.pl breaks if 245$c contains Arabic date.
> Ideally, it should warn and skip the record if it can't process the data.
> I'm not sure if this is by design.

My bad. That's tag 260$c (not 245$c) that breaks batch import. I'll probably
add a separate bug for that if it doesn't exist.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 19:20:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 17:20:38 +0000
Subject: [Koha-bugs] [Bug 20928] Checkout status not showing patron
In-Reply-To: <bug-20928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20928-70-ttMYg8Ty3P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20928

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_18_05_candidate         |
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.05.x for 18.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 19:22:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 17:22:17 +0000
Subject: [Koha-bugs] [Bug 20951] Koha::Patron::Discharge is missing use
 Koha::Patron::Debarments
In-Reply-To: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20951-70-klQlgKeOso@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
           Keywords|rel_18_05_candidate         |

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.05.x for 18.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 19:24:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 17:24:52 +0000
Subject: [Koha-bugs] [Bug 11181] Koha geolocalization of OPAC users for
 better sort results
In-Reply-To: <bug-11181-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11181-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11181-70-SU3yg91pBR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11181

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 19:27:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 17:27:11 +0000
Subject: [Koha-bugs] [Bug 13655] Can't save organisation type patron without
 entering userid/password
In-Reply-To: <bug-13655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13655-70-NeIcEWukLp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13655

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.05.x for 18.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 19:27:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 17:27:38 +0000
Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
In-Reply-To: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20980-70-XOLavEqTei@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980

--- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Katrin Fischer from comment #8)
> Just pointing out... we do have rules about capitalization:
> Manuel Credit should be Manuel credit (and possibly should actually be a
> code... but that's another story)

I agree with you. I'm willing to file a new bug and provide patches to fix this
if this patchset moves.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 19:32:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 17:32:20 +0000
Subject: [Koha-bugs] [Bug 20981] Organization name missing from patron
	search results
In-Reply-To: <bug-20981-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20981-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20981-70-qTNeaOvL9B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20981

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_18_05_candidate         |
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.05.x for 18.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 19:33:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 17:33:33 +0000
Subject: [Koha-bugs] [Bug 20881] Order receiving: Price filter missing
	on_editing
In-Reply-To: <bug-20881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20881-70-tS4cgsIbd1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20881

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.05.x for 18.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 19:36:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 17:36:08 +0000
Subject: [Koha-bugs] [Bug 20794] Don't show holds tab when user doesn't have
 circulate_remaining_permissions
In-Reply-To: <bug-20794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20794-70-lDuDt1Nyve@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20794

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.05.x for 18.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 19:42:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 17:42:21 +0000
Subject: [Koha-bugs] [Bug 20259] Shorter JS and CSS rewrite rule
In-Reply-To: <bug-20259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20259-70-D4MbRM43F5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20259

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         Resolution|---                         |FIXED

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm not going to backport this to 18.05.x, save surprising users having to
intervene during package upgrades, especially as the rule change is a cosmetic
one for server administrators only.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 20:02:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 18:02:42 +0000
Subject: [Koha-bugs] [Bug 20942] Add route to get patron's account balance
In-Reply-To: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20942-70-mhxMU5GNxz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76393&action=edit
Bug 20942: Split debit and credit lines

This patch splits the balance to match this object schema:

{
    balance             => #,
    outstanding_credits => {
        total => #,
        lines => [ credit_line_1, ..., credit_line_n ]
    },
    outstanding_debits  => {
        total => #,
        lines => [ debit_line_1, ..., debit_line_m ]
    }
}

This change is made to ease usage from the UI. Also because the
outstanding credits need to be applied to outstanding debits in order to
the balance value to make sense. So we still need to have each total.

Tests are added for this change, and the schema files are adjusted as
well.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/patrons_accounts.t
=> SUCCESS: Tests pass!
- Sign off :-D

staff_id is changed into user_id as voted on the dev meeting the RFC got
approved.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 20:30:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 18:30:11 +0000
Subject: [Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits
In-Reply-To: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20990-70-wgoq5J3SXN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20978


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978
[Bug 20978] Add Koha::Account::add_credit
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 20:30:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 18:30:11 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-Uxx1ZEcWGh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20990


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990
[Bug 20990] Add Koha::Account::outstanding_credits
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 20:32:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 18:32:43 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-XO7h3K5jQ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 20:32:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 18:32:47 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-neH064a7cx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76317|0                           |1
        is obsolete|                            |
  Attachment #76318|0                           |1
        is obsolete|                            |

--- Comment #6 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76394&action=edit
Bug 20946: Add Koha::Account::outstanding_debits

This patch adds a handy method that returns the total for outstanding
debits (i.e. those that haven't been canceled with credits), and the
corresponding Koha::Account::Line objects.

Unit tests are added.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Account.t
=> SUCCESS: tests pass!
- Sign off :-D

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 20:32:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 18:32:53 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-cGzx9YhIu1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

--- Comment #7 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76395
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76395&action=edit
Bug 20946: Use K::Account->outstanding_debits in pay.pl and paycollect.pl

This patch changes the how account lines are fetched (using
Koha::Account->outstanding_debits) so credits are not picked.

To test:
- Add a $5 credit to a patron
- Add a $1 fine
- Go to the 'Pay fines' tab
=> FAIL: Credit is displayed
- Try to pay all fines
=> FAIL: You are told to enter a value less than or equal to -4.00
         (Observe you cannot do that)
- Apply this patch
- Reload
=> SUCCESS: Credit is not displayed
=> SUCCESS: You are able to pay all fines
- Sign off :-D

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 20:37:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 18:37:00 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-6HSKLLBr5m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 20:37:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 18:37:04 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-AcQ90RPLQN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76319|0                           |1
        is obsolete|                            |
  Attachment #76320|0                           |1
        is obsolete|                            |
  Attachment #76321|0                           |1
        is obsolete|                            |

--- Comment #14 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76396&action=edit
Bug 20978: Unit tests

This patch adds unit tests for Koha::Account::add_credit.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 20:37:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 18:37:09 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-aKt19P9xLs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

--- Comment #15 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76397
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76397&action=edit
Bug 20978: Add Koha::Account::add_credit

This patch adds:
- Koha::Account::add_credit
- A single source of truth for accounttype and offset_type values

To test:
- Apply the first patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Account.t
=> FAIL: Tests fail!
- Apply this patch
- Run:
 k$ prove t/db_dependent/Koha/Account.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 20:37:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 18:37:15 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-Xcnsq5Fx65@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

--- Comment #16 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76398&action=edit
Bug 20978: (follow-up) Another use case from C4::Circulation

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 20:42:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 18:42:49 +0000
Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
In-Reply-To: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20980-70-Erx8CKLU8i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20990


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990
[Bug 20990] Add Koha::Account::outstanding_credits
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 20:42:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 18:42:49 +0000
Subject: [Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits
In-Reply-To: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20990-70-AppRoHFUM7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20980


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980
[Bug 20980] Manual credit offsets are stored as debits
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 20:48:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 18:48:10 +0000
Subject: [Koha-bugs] [Bug 15287] Use font-awesome on the OPAC
In-Reply-To: <bug-15287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15287-70-XgacThlvtv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15287

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 20:48:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 18:48:13 +0000
Subject: [Koha-bugs] [Bug 15287] Use font-awesome on the OPAC
In-Reply-To: <bug-15287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15287-70-llo15kVo3Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15287

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76399&action=edit
Bug 15287: Use font-awesome on the OPAC

This patch replaces Bootstrap's glyphicons with Font Awesome icons.

To test, apply the patch and clear your browser cache and regenerate the
OPAC CSS from the LESS file if necessary. Check these icons and confirm
they look correct:

- Cart and Lists icons in the OPAC header
- User icon in the header when the browser window is narrow
- Languages menu when multiple languages are installed and
  the OpacLangSelectorMode system preference is "top" or "both top and
  footer."
- Set the  SuspendHoldsOpac system preference to "allow" and log in to
  the OPAC as a user who has one or more holds.
  - Check the appearance of the "suspend" and "resume" buttons both in
    the table of holds and at the bottom.
- With one or more clubs defined, log in to the OPAC and check the "Clubs"
  tab on the user summary page. The "Enroll" and "Cancel enrollment"
  buttons should look correct.
- On the "your messaging" tab in the OPAC, the "Digests only" information
  icon should look correct.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 20:48:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 18:48:16 +0000
Subject: [Koha-bugs] [Bug 15287] Use font-awesome on the OPAC
In-Reply-To: <bug-15287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15287-70-387z4TnaFh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15287

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76400
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76400&action=edit
Bug 15287: Compiled CSS

This patch contains the compiled CSS.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 20:50:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 18:50:53 +0000
Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
In-Reply-To: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20980-70-BIWbOULsxN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 20:50:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 18:50:58 +0000
Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
In-Reply-To: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20980-70-VQRKlIxZew@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76322|0                           |1
        is obsolete|                            |
  Attachment #76323|0                           |1
        is obsolete|                            |
  Attachment #76324|0                           |1
        is obsolete|                            |
  Attachment #76325|0                           |1
        is obsolete|                            |

--- Comment #10 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76401&action=edit
Bug 20980: Add 'Manual Credit' and fix existing offsets

This patch adds a new offset type 'Manual Credit'. And adds an atomic
update for fixing existing offsets.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 20:51:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 18:51:03 +0000
Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
In-Reply-To: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20980-70-frrwC0Pbbh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980

--- Comment #11 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76402
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76402&action=edit
Bug 20980: Make mancredit.pl use Koha::Account::add_credit

This patch makes creating a manual credit from the UI record the account
offset as 'Manual Credit', and properly set account_offsets.credit_id
instead of account_offsets.debit_id.

To test:
- Create a manual credit (of 'Credit' type) for a known patron (acevedo?)
- Run:
  $ sudo koha-mysql kohadev
  > SELECT * FROM account_offsets;
=> FAIL: The account offset for the manual credit has type=Manual Debit,
    credit_id=NULL and debit_id=accountlines_id
- Run the atomic update:
  $ updatedatabase
- Run:
  $ sudo koha-mysql kohadev
  > SELECT * FROM account_offsets;
=> SUCCESS: The account offset has been corrected and now has
type=Manual Credit, credit_id=accountlines_id and debit_id=NULL
- Create a new manual credit (of 'Forgiven' type) for a known patron
- Run:
  $ sudo koha-mysql kohadev
  > SELECT * FROM account_offsets;
=> SUCCESS: The account offset has been stored correctly as a credit!
- Sign off :-D

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 20:51:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 18:51:06 +0000
Subject: [Koha-bugs] [Bug 20354] Add ability for patrons to set theirs
	preferred currency
In-Reply-To: <bug-20354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20354-70-9WsOpn4d7H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20354

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 20:51:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 18:51:09 +0000
Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
In-Reply-To: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20980-70-VwXUflRJMM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980

--- Comment #12 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76403
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76403&action=edit
Bug 20980: (follow-up) Only use UpdateStats for 'payment' and 'writeoff'

This patch makes Koha::Account::add_credit record statistics logs
(through C4::Stats::UpdateStats) only for the 'payment' and 'writeoff'
credit types.

Both credit types are whitelisted in UpdateStats, so we keep the current
behaviour. Another option would've been to add new account types to the
white list, but with the account offsets it seems that using the
statistics table for account changes won't be useful for too long, as
offsets contain the same (and more) information.

To test:
- Apply the patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Account.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 20:51:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 18:51:14 +0000
Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
In-Reply-To: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20980-70-UFJbN4vi5h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980

--- Comment #13 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76404
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76404&action=edit
Bug 20980: (follow-up) Offset name consistency

This patch makes 'credit' account types generate 'Manual Credit' offset.
The original patch used 'Payment' but I think the code wants to
distinguish between payments and manually added credits (otherwise they
would've picked the same accounttype value, and they don't.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 20:53:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 18:53:31 +0000
Subject: [Koha-bugs] [Bug 18911] Option to set preferred language in OPAC
In-Reply-To: <bug-18911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18911-70-7hnP1L81XU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18911

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 20:58:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 18:58:04 +0000
Subject: [Koha-bugs] [Bug 19109] Layout in masthead search inconsistent when
 narrowing and then restoring browser window.
In-Reply-To: <bug-19109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19109-70-9oSM7PS5mh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19109

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Layout in masthead search   |Layout in masthead search
                   |breaks when narrowing and   |inconsistent when narrowing
                   |then restoring browser      |and then restoring browser
                   |window.                     |window.
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 20:59:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 18:59:45 +0000
Subject: [Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits
In-Reply-To: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20990-70-DnhVAzTvJG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 20:59:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 18:59:49 +0000
Subject: [Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits
In-Reply-To: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20990-70-lmeIq6axA2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76380|0                           |1
        is obsolete|                            |
  Attachment #76381|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76405&action=edit
Bug 20990: Unit tests for Koha::Account->outstanding_credits

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 20:59:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 18:59:53 +0000
Subject: [Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits
In-Reply-To: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20990-70-V8Dkv6uV6J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76406
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76406&action=edit
Bug 20990: Add Koha::Account->outstanding_credits

This patch adds a method that retrieves (for a patron's account) the
outstanding credits (i.e. those that haven't been applied to any debit.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Account.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 20:59:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 18:59:58 +0000
Subject: [Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits
In-Reply-To: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20990-70-JRnxnzcWiZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76407
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76407&action=edit
Bug 20990: (follow-up) Fix test description

Test plan:
prove -v t/db_dependent/Koha/Account.t
--> Test message of first test of subtest outtanding_credits correctly says
"Outstanding credits total..."

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 21:00:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 19:00:21 +0000
Subject: [Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits
In-Reply-To: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20990-70-AKkDrQrFmN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         Depends on|20978                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978
[Bug 20978] Add Koha::Account::add_credit
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 21:00:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 19:00:21 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-ml8XtbPjmh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|20990                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990
[Bug 20990] Add Koha::Account::outstanding_credits
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 21:03:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 19:03:37 +0000
Subject: [Koha-bugs] [Bug 14222] Sort holds in OPAC by priority
In-Reply-To: <bug-14222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14222-70-NXLSOEIPk4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14222

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 21:03:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 19:03:42 +0000
Subject: [Koha-bugs] [Bug 14222] Sort holds in OPAC by priority
In-Reply-To: <bug-14222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14222-70-pxQ79t17nJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14222

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76311|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76408
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76408&action=edit
Bug 14222: Sort holds in OPAC by priority

This patch modifies the markup of the users's holds table in the OPAC so
that if hold priority is displayed, the table will be sorted by that
number.

To test, apply the patch and set the OPACShowHoldQueueDetails system
preference to "Show priority level" or "Show holds and their priority
level."

 - Log in to the OPAC as a user who has multiple holds with various
   priorities. Include priorities which could be sorted incorrectly
   using a text sort, e.g. 1, 10.
 - View the holds tab on the "your summary" page. Confirm that the
   priority column is sorted by default with the lowest priority holds
   first.
 - Set the  OPACShowHoldQueueDetails preference to "Show holds" and
   confirm that the holds table still displays correctly, sorted by
   "Placed on" ascending.

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Followed the test plan and the patch works.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 21:03:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 19:03:56 +0000
Subject: [Koha-bugs] [Bug 14222] Sort holds in OPAC by priority
In-Reply-To: <bug-14222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14222-70-EcfSDVBSTl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14222

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 21:06:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 19:06:27 +0000
Subject: [Koha-bugs] [Bug 16919] Problems with cart
In-Reply-To: <bug-16919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16919-70-lEV5ZL7kNn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16919

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
I would be curious to see if anyone can reproduce this bug in master now. I
can't.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 21:06:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 19:06:42 +0000
Subject: [Koha-bugs] [Bug 16919] Problems with cart
In-Reply-To: <bug-16919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16919-70-ypxKnIN2QT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16919

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 21:18:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 19:18:36 +0000
Subject: [Koha-bugs] [Bug 20942] Add route to get patron's account balance
In-Reply-To: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20942-70-iZ2TtOzFT2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 21:18:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 19:18:39 +0000
Subject: [Koha-bugs] [Bug 20942] Add route to get patron's account balance
In-Reply-To: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20942-70-WnLOTNGc2g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76053|0                           |1
        is obsolete|                            |
  Attachment #76054|0                           |1
        is obsolete|                            |
  Attachment #76055|0                           |1
        is obsolete|                            |
  Attachment #76393|0                           |1
        is obsolete|                            |

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76409
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76409&action=edit
Bug 20942: OpenAPI spec for /patrons/{patron_id}/account

This patch adds the OpenAPI spec for the following paths:
- /patrons/{patron_id}/account

It also adds object definitions for:
- balance
- account line

Account line is to be used on both /account/lines (when implemented)
and for embeding the outstanding lines in the balance endpoint
(/patrons/{patron_id}/account).

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 21:18:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 19:18:44 +0000
Subject: [Koha-bugs] [Bug 20942] Add route to get patron's account balance
In-Reply-To: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20942-70-zogOr1QYal@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942

--- Comment #6 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76410
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76410&action=edit
Bug 20942: Unit tests for /patrons/{patron_id}/account

This patch adds tests for the /patrons/{patron_id}/account endpoint.
To test:

- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/patrons_accounts.t
=> FAIL: Tests should fail because the endpoint is not implemented.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 21:18:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 19:18:49 +0000
Subject: [Koha-bugs] [Bug 20942] Add route to get patron's account balance
In-Reply-To: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20942-70-mVWTrhp3Bk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942

--- Comment #7 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76411&action=edit
Bug 20942: Add route to get patron's account balance

This patch implements the /patrons/{patron_id}/account endpoint. It can
be used to get the patron's balance information, including outstanding
lines.

To test:
- Apply this patchset
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/patrons_accounts.t
=> SUCCESS: tests pass!
- Make your favourite REST testing tool (RESTer on Firefox?) do:
  GET /api/v1/patrons/{patron_id}/account
to a valid patron_id. Play with Koha's UI to add credits/payments and
notice the endpoint returns the right info following the voted RFC. [1]
- Sign off :-D

[1] https://wiki.koha-community.org/wiki/Patrons_account_lines_endpoint_RFC

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 21:18:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 19:18:54 +0000
Subject: [Koha-bugs] [Bug 20942] Add route to get patron's account balance
In-Reply-To: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20942-70-SpUwJhTjM6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942

--- Comment #8 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76412
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76412&action=edit
Bug 20942: Split debit and credit lines

This patch splits the balance to match this object schema:

{
    balance             => #,
    outstanding_credits => {
        total => #,
        lines => [ credit_line_1, ..., credit_line_n ]
    },
    outstanding_debits  => {
        total => #,
        lines => [ debit_line_1, ..., debit_line_m ]
    }
}

This change is made to ease usage from the UI. Also because the
outstanding credits need to be applied to outstanding debits in order to
the balance value to make sense. So we still need to have each total.

Tests are added for this change, and the schema files are adjusted as
well.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/patrons_accounts.t
=> SUCCESS: Tests pass!
- Sign off :-D

staff_id is changed into user_id as voted on the dev meeting the RFC got
approved.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 21:43:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 19:43:54 +0000
Subject: [Koha-bugs] [Bug 10348] Show number of items on tab headings in the
	staff client
In-Reply-To: <bug-10348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10348-70-uN6MFWviii@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10348

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 21:57:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 19:57:06 +0000
Subject: [Koha-bugs] [Bug 20921] Expose borrowernumber and branch when user
 is logged in to OPAC
In-Reply-To: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20921-70-zIbp2t4WH7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 21:57:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 19:57:10 +0000
Subject: [Koha-bugs] [Bug 20921] Expose borrowernumber and branch when user
 is logged in to OPAC
In-Reply-To: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20921-70-CHp6IykhXz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76310|0                           |1
        is obsolete|                            |

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76413
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76413&action=edit
Bug 20921: Add borrowernumber and branchcode as html attributes

To test:
1 - Apply patch
2 - Visit the opac
3 - Sign in
4 - You should not see any difference
5 - Inspect the element  'Welcome, {username}'
6 - Note the attributes for borrowernumber and branchcode
7 - Add to OPACUserJS:
$(document).ready(function(){
    console.log( $(".loggedinusername").attr('data-branchcode'));
    console.log( $(".loggedinusername").attr('data-borrowernumber'));
});
8 - Check the console and note you can see the info expected

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Followed the test plan and it works.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 21:57:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 19:57:16 +0000
Subject: [Koha-bugs] [Bug 20921] Expose borrowernumber and branch when user
 is logged in to OPAC
In-Reply-To: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20921-70-Sb1lAZ6wxP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76414&action=edit
Bug 20921: Fix opac_auth for selenium

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 21:57:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 19:57:22 +0000
Subject: [Koha-bugs] [Bug 20921] Expose borrowernumber and branch when user
 is logged in to OPAC
In-Reply-To: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20921-70-hE6QjTZGPV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76415&action=edit
Bug 20921: Add selenium tests for .loggedinusername

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 21:58:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 19:58:08 +0000
Subject: [Koha-bugs] [Bug 20921] Expose borrowernumber and branch when user
 is logged in to OPAC
In-Reply-To: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20921-70-BBGVQRqAmw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|oleonard at myacpl.org         |nick at bywatersolutions.com

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I am not sure it makes sense to have borrowernumber and branchcode at
loggedinusername level. Maybe we should rename it "loggedinuser"?
Can be done later.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 22:10:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 20:10:23 +0000
Subject: [Koha-bugs] [Bug 20931] JS error "ReferenceError: $ is not defined"
 when CircSidebar is turned on
In-Reply-To: <bug-20931-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20931-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20931-70-VMfZm6s1Xs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20931

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76312|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76416
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76416&action=edit
Bug 20931: JS error "ReferenceError: $ is not defined" when CircSidebar is
turned on

This patch reorganizes the way sidebar menus get highlighted based on
the current page. A global function is added to handle most cases.
Individual menu-handling scripts have been modified to handle only the
edge cases which aren't covered by the global one.

A new class is added to the global CSS file so that highlighted menu
links can be custom-styled.

To test, apply the patch and clear your cache if necessary.

View various pages to confirm that current-page-highlighting in the
sidebar menu is working correctly and that there are no JS errors in the
browser console. For example:

 - Administration -> Currencies and exchange rates.
 - Acquisitions -> Invoices
 - Tools -> Patron lists
 - Tools -> Export

And with CircSidebar turned on test various circulation pages, e.g.

 - Circulation -> Set library

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 22:10:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 20:10:18 +0000
Subject: [Koha-bugs] [Bug 20931] JS error "ReferenceError: $ is not defined"
 when CircSidebar is turned on
In-Reply-To: <bug-20931-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20931-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20931-70-EH3LWj3DKd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20931

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 22:11:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 20:11:10 +0000
Subject: [Koha-bugs] [Bug 10348] Show number of items on tab headings in the
	staff client
In-Reply-To: <bug-10348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10348-70-fFMEwqbRmQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10348

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 22:11:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 20:11:13 +0000
Subject: [Koha-bugs] [Bug 10348] Show number of items on tab headings in the
	staff client
In-Reply-To: <bug-10348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10348-70-rnHNpcxxqV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10348

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76417
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76417&action=edit
Bug 10348: Show number of items on tab headings in the staff client

This patch uses Template Toolkit's size() method to add a count to
the bibliographic detail page's holdings and images tabs.

To test, apply the patch and view the detail page for a record in
the staff client. Check under the following conditions:

- The SeparateHoldings system preference is set to "Don't separate"
  - The holdings tab should show the correct item count.
- The SeparateHoldings system preference is set to "Separate"
  - The "[Library] holdings" tab and "Other holdings" tabs should
    have the correct item counts.
- With LocalCoverImages enabled the "Images" tab should show the
  correct count of attached images. Test with zero or more attached
  images.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 22:15:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 20:15:22 +0000
Subject: [Koha-bugs] [Bug 15265] Instagram and pintrest
In-Reply-To: <bug-15265-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15265-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15265-70-982EveyU6C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15265

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
*** Bug 10583 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 22:15:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 20:15:22 +0000
Subject: [Koha-bugs] [Bug 10583] add pinterest to social networks
In-Reply-To: <bug-10583-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10583-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10583-70-PTrByjqmC0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10583

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---


*** This bug has been marked as a duplicate of bug 15265 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 22:16:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 20:16:22 +0000
Subject: [Koha-bugs] [Bug 15265] Add Instagram and Pinterest to social media
	links
In-Reply-To: <bug-15265-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15265-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15265-70-HcTaJ8r2db@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15265

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Instagram and pintrest      |Add Instagram and Pinterest
                   |                            |to social media links

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 22:18:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 20:18:48 +0000
Subject: [Koha-bugs] [Bug 7547] Printing a sorted cart
In-Reply-To: <bug-7547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7547-70-uYONsX2PWF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 22:18:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 20:18:54 +0000
Subject: [Koha-bugs] [Bug 7547] Printing a sorted cart
In-Reply-To: <bug-7547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7547-70-PcaEjNGiUI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76246|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 76418
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76418&action=edit
Bug 7547: printing a sorted cart

This patch adds a DataTables-generated print button to the OPAC cart. To
make that process easier, the DataTables plugin has been upgraded to the
latest version (1.10.18) with the Buttons plugin included.

Changes to the OPAC LESS file style the DataTables button to look like
the static version.

Other templates in the OPAC which use the DataTables plugin have been
modified to use up-to-date option names.

To test, apply the patch and add several titles to the cart.

 - Open the cart
 - Re-sort the cart using something other than the default sort
 - Click the 'Print' button.
   - A print view should open in a separate window, sorted correctly,
     and automatically show the print dialog.
 - Click the cart's 'More details' button and click the print button.
   - This should trigger the print dialog directly.

 - Test DataTables sorting on other modified pages:
    - Bibliographic detail page (holdings table)
    - Course reserves (table of courses)
      - Course details (table of titles)
    - Full subscription history
      - Detail page for a subscription -> More details -> Full history
    - Most popular
    - Purchase suggestions
    - Self checkouts
    - Tag cloud
    - Your fines
    - Your interlibrary loan requests
    - Your reading history
    - Your search history
    - Your search IDREF for ppn (I don't know how to test this)

The DataTables plugin is removed from "Your routing lists" and Self
check-in because it is unused.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 22:19:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 20:19:30 +0000
Subject: [Koha-bugs] [Bug 5789] Fines don't work when items have null
	homebranch
In-Reply-To: <bug-5789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5789-70-QTenT31Oa2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5789

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Saiful Amin from comment #13)
> (In reply to Saiful Amin from comment #12)
> > I still don't think scripts should break on missing/bad data. For example,
> > I've observed that bulkmarcimport.pl breaks if 245$c contains Arabic date.
> > Ideally, it should warn and skip the record if it can't process the data.
> > I'm not sure if this is by design.
> 
> My bad. That's tag 260$c (not 245$c) that breaks batch import. I'll probably
> add a separate bug for that if it doesn't exist.

Please do!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 22:24:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 20:24:17 +0000
Subject: [Koha-bugs] [Bug 20683] Update German web installer for 18.05
In-Reply-To: <bug-20683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20683-70-0jKul0hTY5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20683

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Someone, please?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 22:45:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 20:45:54 +0000
Subject: [Koha-bugs] [Bug 20585] Label surname as name for organisation type
	patrons
In-Reply-To: <bug-20585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20585-70-WGEElq7QqU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20585

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
With the patch surname will always be required for organisation type patrons,
which makes sense.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 23:03:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 21:03:50 +0000
Subject: [Koha-bugs] [Bug 20585] Label surname as name for organisation type
	patrons
In-Reply-To: <bug-20585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20585-70-RM5BQ3ooqq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20585

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 23:03:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 21:03:54 +0000
Subject: [Koha-bugs] [Bug 20585] Label surname as name for organisation type
	patrons
In-Reply-To: <bug-20585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20585-70-zyBlyS9szf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20585

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76379|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 76419
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76419&action=edit
Bug 20585: Label surname as name for organisation type patrons

This patch modifies the patron edit page so that the label for an
organization name is "Name" instead of "Surname."

To test, apply the patch and edit both an institutional patron and a
regular patron. Confirm that the name/surname label is correct in each
case.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 23:05:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 21:05:25 +0000
Subject: [Koha-bugs] [Bug 19902] Add column configuration to bibliographic
 record checkouts history table
In-Reply-To: <bug-19902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19902-70-f7EuIdJXgV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19902

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 23:05:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 21:05:30 +0000
Subject: [Koha-bugs] [Bug 19902] Add column configuration to bibliographic
 record checkouts history table
In-Reply-To: <bug-19902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19902-70-HFNFgw3BCF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19902

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75642|0                           |1
        is obsolete|                            |
  Attachment #76369|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76420
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76420&action=edit
Bug 19902: Add column settings to bibliographic record checkouts history table

Test plan:
0) Apply the patch
1) Go to administration -> Configure columns, note there is new
checkoutshistory-table in Catalogue section
2) Make some configuration in this table settings
3) Go to detail of any record -> Checkout history
4) The columns should be visible according to your configuration from
step 2
5) Play with Column visibility, to ensure it does work as it should

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Fixed a minor typo during signoff.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 23:05:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 21:05:36 +0000
Subject: [Koha-bugs] [Bug 19902] Add column configuration to bibliographic
 record checkouts history table
In-Reply-To: <bug-19902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19902-70-ZcUa5P24v7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19902

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76421
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76421&action=edit
Bug 19902: (follow-up) Deal with patron column regarding on
intranetreadinghistory setting

Test plan:
Try it with intranetreadinghistory allowed and not allowed and it should
still work in both cases

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 23:09:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 21:09:08 +0000
Subject: [Koha-bugs] [Bug 20969] Use modal to add and edit notes from basket
In-Reply-To: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20969-70-1858gUDPTy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
1) Would it be possible to put the focus in the new input field after clicking
on the link? I think it would improve usability to immediately allow typing the
note instead of having to click again. But I notice it's the same for the
message modal on the patron record.

2) Do you plan on changing the links on the parcel.pl page too? (new bug?)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 23:10:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 21:10:28 +0000
Subject: [Koha-bugs] [Bug 20969] Use modal to add and edit notes from basket
In-Reply-To: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20969-70-Ci3561MbkS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 23:10:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 21:10:32 +0000
Subject: [Koha-bugs] [Bug 20969] Use modal to add and edit notes from basket
In-Reply-To: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20969-70-m0IcQwYGdF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76212|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 76422
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76422&action=edit
Bug 20969: Use modal to add and edit notes from basket

This patch modifies the acquisitions basket page so that links to add or
edit vendor or internal notes trigger a modal with the notes edit form
instead of redirecting to a different page. This is a markup change only
-- The form still submits to modordernotes.pl.

To test, apply the patch and view a basket in acquisitions which has
multiple orders. Test various note controls:  Add internal note, Add
vendor note, Edit internal note, edit vendor note.

Confirm that the operations work correctly with multiple orders in the
basket.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 23:15:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 21:15:37 +0000
Subject: [Koha-bugs] [Bug 20945] Report params not escaped when downloading
In-Reply-To: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20945-70-dfu5vRPHJs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 23:15:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 21:15:42 +0000
Subject: [Koha-bugs] [Bug 20945] Report params not escaped when downloading
In-Reply-To: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20945-70-eNfa3OduKw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76056|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 76423
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76423&action=edit
Bug 20945: Escape SQL parameters when constructing download links

TO test:
1 - Create a report that takes a parameter
2 - Enter a parameter containing '%'
3 - Attempt to download report, note link is misconstructed
4 - Apply patch
5 - Reload
6 - Note URL is now correct

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 23:34:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 21:34:13 +0000
Subject: [Koha-bugs] [Bug 20991] New: Error will reset category when editing
	a patron
Message-ID: <bug-20991-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20991

            Bug ID: 20991
           Summary: Error will reset category when editing a patron
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

- Edit an existing patron
- Change the patron category to a category that triggers the error that the
user is not in the right age range for that new category
- Save, error is triggered
- Scroll down - the patron category has been reset

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 23:40:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 21:40:27 +0000
Subject: [Koha-bugs] [Bug 20903] Print payment receipt on child patron could
 end with server error
In-Reply-To: <bug-20903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20903-70-JTvYlooxcZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 23:40:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 21:40:31 +0000
Subject: [Koha-bugs] [Bug 20903] Print payment receipt on child patron could
 end with server error
In-Reply-To: <bug-20903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20903-70-BiHlgioTgm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75915|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 76424
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76424&action=edit
Bug 20903: Remove unnecessary category code parameters

Test plan:
0) Do no apply the patch
1) Have only one adults patrons category defined
2) Add a fine to child patron and pay it
3) Try to print the payment receipt (file printfeercpt.pl)
4) You see only ISE
5) Apply the patch
6) Try the printing again
7) Now you should see right receipt

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 23:59:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 21:59:08 +0000
Subject: [Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result
 lists and detail pages
In-Reply-To: <bug-14716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14716-70-DId7SyXvcB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716

--- Comment #49 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Signing off for MARC21 - maybe someone else could take a look for UNIMARC?
Also tested that this fixes bug 16804. I prefer this solution.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 00:01:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 22:01:46 +0000
Subject: [Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result
 lists and detail pages
In-Reply-To: <bug-14716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14716-70-ZlCjGp2hZt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 00:01:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 22:01:54 +0000
Subject: [Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result
 lists and detail pages
In-Reply-To: <bug-14716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14716-70-7LgPEoB7hu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74804|0                           |1
        is obsolete|                            |

--- Comment #50 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 76425
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76425&action=edit
Bug 14716: URI-encode URLs in MARC21 xsl templates.

https://bugs.koha-community.org/show_bug.cgi?id=14716

Test plan:

1. Catalog a record with series name "Series & more"
2. Find the record
3. Make sure clicking the "Series & more" link works and the ampersand is
properly encoded in the URL.
4. Also try the attached test records and make sure their links work.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 00:05:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 22:05:33 +0000
Subject: [Koha-bugs] [Bug 16804] Searching can be broken by search terms
 containing semicolons in XSLT
In-Reply-To: <bug-16804-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16804-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16804-70-K17YwCpX3o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I feel bug 18304 could be the better solution here. I tested it also fixes the
issue. Linking both bugs for now using 'see also'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 00:06:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 22:06:58 +0000
Subject: [Koha-bugs] [Bug 16804] Searching can be broken by search terms
 containing semicolons in XSLT
In-Reply-To: <bug-16804-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16804-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16804-70-vf1hqbj5Ch@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804

--- Comment #13 from Joy Nelson <joy at bywatersolutions.com> ---
Can you verify the bug number Katrin? 18304 is an email issue.

(In reply to Katrin Fischer from comment #12)
> I feel bug 18304 could be the better solution here. I tested it also fixes
> the issue. Linking both bugs for now using 'see also'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 00:07:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 22:07:38 +0000
Subject: [Koha-bugs] [Bug 16804] Searching can be broken by search terms
 containing semicolons in XSLT
In-Reply-To: <bug-16804-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16804-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16804-70-gCQthd3e7j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Sorry, too late here: bug 14716

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 00:11:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 22:11:06 +0000
Subject: [Koha-bugs] [Bug 16804] Searching can be broken by search terms
 containing semicolons in XSLT
In-Reply-To: <bug-16804-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16804-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16804-70-dYKQKvnjdi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804

--- Comment #15 from Liz Rea <liz at catalyst.net.nz> ---
That's funny, my original solution was basically that url-encode one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 00:16:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 22:16:49 +0000
Subject: [Koha-bugs] [Bug 16804] Searching can be broken by search terms
 containing semicolons in XSLT
In-Reply-To: <bug-16804-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16804-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16804-70-AF72hdALRZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804

--- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Not quite, this is using an exslt function that can do more than the self
implemented url-encode that was tried before. Especially original script like
Hebrew and Chinese. Try adding a subject ?? (Japan) in 653. It will work with
the new solution, but not with the last one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 00:18:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2018 22:18:53 +0000
Subject: [Koha-bugs] [Bug 16804] Searching can be broken by search terms
 containing semicolons in XSLT
In-Reply-To: <bug-16804-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16804-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16804-70-bbMZgBu4F8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|liz at catalyst.net.nz         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 05:17:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 03:17:55 +0000
Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred
 patrons when issuing rules 'fine days = 0'
In-Reply-To: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14784-70-8Ghx4YMB2X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amitddng135 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 05:19:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 03:19:46 +0000
Subject: [Koha-bugs] [Bug 20979] Error message when deleting bib attached to
	order
In-Reply-To: <bug-20979-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20979-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20979-70-o7nRnDWcxN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20979

Amit Gupta <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amitddng135 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 07:51:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 05:51:35 +0000
Subject: [Koha-bugs] [Bug 20992] New: asd
Message-ID: <bug-20992-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20992

            Bug ID: 20992
           Summary: asd
 Change sponsored?: ---
           Product: Koha
           Version: 17.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: maskedman42 at yahoo.com
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

Created attachment 76426
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76426&action=edit
asd

asd

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 07:52:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 05:52:35 +0000
Subject: [Koha-bugs] [Bug 20993] New: asd
Message-ID: <bug-20993-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20993

            Bug ID: 20993
           Summary: asd
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: maskedman42 at yahoo.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 76427
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76427&action=edit
asd

asd

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 07:53:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 05:53:35 +0000
Subject: [Koha-bugs] [Bug 20993] SPAM
In-Reply-To: <bug-20993-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20993-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20993-70-PJTXkhrrL0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20993

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|asd                         |SPAM

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 07:59:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 05:59:51 +0000
Subject: [Koha-bugs] [Bug 18521] Renew and search hotkeys are swapped on
	returns page.
In-Reply-To: <bug-18521-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18521-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18521-70-6V3LUTZf6T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18521

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Assignee|koha-bugs at lists.koha-commun |alexbuckley at catalyst.net.nz
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 08:00:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 06:00:27 +0000
Subject: [Koha-bugs] [Bug 20969] Use modal to add and edit notes from basket
In-Reply-To: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20969-70-Fi903E6HlC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 08:02:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 06:02:31 +0000
Subject: [Koha-bugs] [Bug 17886] Don't show option to add to existing list
 if there are no lists in staff
In-Reply-To: <bug-17886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17886-70-cWHwPPvot6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|Don't show option to add to |Don't show option to add to
                   |existing list if there are  |existing list if there are
                   |no lists                    |no lists in staff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 08:09:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 06:09:42 +0000
Subject: [Koha-bugs] [Bug 20994] New: Fix capitalization on OPAC result list
 "Save to Lists"
Message-ID: <bug-20994-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20994

            Bug ID: 20994
           Summary: Fix capitalization on OPAC result list "Save to Lists"
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: trivial
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

On the OPAC result list it reds "Save to Lists" when it should be "Save to
lists".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 08:10:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 06:10:59 +0000
Subject: [Koha-bugs] [Bug 20992] asd
In-Reply-To: <bug-20992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20992-70-xxhsaqCLvD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20992

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 08:11:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 06:11:09 +0000
Subject: [Koha-bugs] [Bug 17886] Don't show option to add to existing list
 if there are no lists in staff
In-Reply-To: <bug-17886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17886-70-UBbSdrJchc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
OPAC seems to be ok in my tests. If there is still an issue I suggest solving
it with a separate bug and patch to have this moving on.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 08:11:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 06:11:58 +0000
Subject: [Koha-bugs] [Bug 17886] Don't show option to add to existing list
 if there are no lists in staff
In-Reply-To: <bug-17886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17886-70-kjVgJjsy9f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 08:12:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 06:12:02 +0000
Subject: [Koha-bugs] [Bug 17886] Don't show option to add to existing list
 if there are no lists in staff
In-Reply-To: <bug-17886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17886-70-a21oIA56Os@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76306|0                           |1
        is obsolete|                            |

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 76428
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76428&action=edit
Bug 17886: Don't show option to add to existing list if there are no lists

This patch modifies the page for adding a title to a list so that the
"Add to existing list" option doesn't appear if there are no lists
defined.

TEST PLAN
---------
1) Make sure no lists exist at all.
2) Make there is at least one findable biblio record entered
3) Find that biblio record in the OPAC
4) Click 'Save to your lists'
   -- Notice that the whole save to list section is there.
5) Apply this patch
6) Click 'Cancel'
7) Click 'Save to your lists'
   -- Notice you can only add now, which makes sense.
8) Run koha qa test tools.

Perform the same tests in the staff client.

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Followed the test plan and the patch works.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 08:12:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 06:12:56 +0000
Subject: [Koha-bugs] [Bug 20992] asd
In-Reply-To: <bug-20992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20992-70-4rFGiwTzum@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20992

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76426|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 08:14:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 06:14:28 +0000
Subject: [Koha-bugs] [Bug 20992] SPAM
In-Reply-To: <bug-20992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20992-70-7Lqnqew3fX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20992

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|asd                         |SPAM

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 08:14:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 06:14:56 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-gLXMAmz2KI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

paxed <pasi.kallinen at joensuu.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pasi.kallinen at joensuu.fi

--- Comment #36 from paxed <pasi.kallinen at joensuu.fi> ---
Unfortunately quite a lot of the messages are split in multiple parts, making
translation very hard:

[% t('Warning: This file is version') %] [% message.upload_version %][% t(',
but I only know how to import version') %] [% message.current_version %][% t('.
I\'ll try my best.') %]


Currently they're much better, with placeholders:

"Warning: This file is version %s, but I only know how to import version %s. "

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 08:15:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 06:15:11 +0000
Subject: [Koha-bugs] [Bug 20138] SPAM
In-Reply-To: <bug-20138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20138-70-HF51SyjrzE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20138

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 08:15:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 06:15:20 +0000
Subject: [Koha-bugs] [Bug 20993] SPAM
In-Reply-To: <bug-20993-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20993-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20993-70-pI6FoyVf8s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20993

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 08:22:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 06:22:14 +0000
Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to
 account page instead of back to search results
In-Reply-To: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17153-70-6fRKxeBi8n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 08:22:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 06:22:18 +0000
Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to
 account page instead of back to search results
In-Reply-To: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17153-70-QwaTghhoON@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75933|0                           |1
        is obsolete|                            |

--- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 76429
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76429&action=edit
Bug 17153: Login during search rebase and fix

This patch is a fresh attempt at redirecting back to search
results after logging in on opac-search.pl

To test:
- Perform an OPAC search
- Login on opac-search.pl with the search results displayed
- The page is redirected to opac-user.pl
- Log out
- Apply the patch
- Perform a new OPAC search
- Note the URL query string
- Login on opac-search.pl with the search results displayed
- The opac-search.pl page should be displayed with the correct
  query string and the page should indicate a logged in status

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Followed the test plan and the patch works.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 08:23:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 06:23:05 +0000
Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to
 account page instead of back to search results
In-Reply-To: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17153-70-U05kLGyPrA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76429|0                           |1
        is obsolete|                            |

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 76430
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76430&action=edit
Bug 17153: Redirect to search when logging in from search

This patch is a fresh attempt at redirecting back to search
results after logging in on opac-search.pl

To test:
- Perform an OPAC search
- Login on opac-search.pl with the search results displayed
- The page is redirected to opac-user.pl
- Log out
- Apply the patch
- Perform a new OPAC search
- Note the URL query string
- Login on opac-search.pl with the search results displayed
- The opac-search.pl page should be displayed with the correct
  query string and the page should indicate a logged in status

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Followed the test plan and the patch works.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 08:25:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 06:25:20 +0000
Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to
 account page instead of back to search results
In-Reply-To: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17153-70-iIQLom8GuP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

--- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Please always describe your change in your subject line :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 08:29:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 06:29:06 +0000
Subject: [Koha-bugs] [Bug 20467] Add ability to batch add items to a course
In-Reply-To: <bug-20467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20467-70-YhBsebKKnt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 08:29:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 06:29:30 +0000
Subject: [Koha-bugs] [Bug 20467] Add ability to batch add items to a course
In-Reply-To: <bug-20467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20467-70-i8nxGM50Uy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467

--- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Back on this, will fix patch subjects.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 08:52:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 06:52:59 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-2DyqNoyEuS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #37 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to paxed from comment #36)
> Unfortunately quite a lot of the messages are split in multiple parts,
> making translation very hard:
> 
> [% t('Warning: This file is version') %] [% message.upload_version %][% t(',
> but I only know how to import version') %] [% message.current_version %][%
> t('. I\'ll try my best.') %]
> 
> 
> Currently they're much better, with placeholders:
> 
> "Warning: This file is version %s, but I only know how to import version %s.
> "

I agree. There's still some manual work, the goal of this bug is to reduce it
to a minimum.

This particular example should be

[% tx('Warning: This file is version {upload_version} but I only know how to
import {current_version}. I\'ll try my best.', { upload_version =
upload_version, current_version = current_version) %]

I'm not sure we can accomplish that easily with an automated tool. It's
probably easier to run the tool and fix manually the problematic ones.

But please note that, unlike actual PO files, the one attached doesn't contain
strings like this:

"%s %s %s &nbsp; %s %s - %s %s %s - %s%s %s- %s%s %s - %s%s %sEdition: %s%s "
"%s ; %s%s %s - %s%s %s ; %s%s %s "


Also, I attached all the changes to this one bug, but that doesn't mean we
should do it all at once. We can take the safer way of changing one template
file at a time (or one module at a time). It will certainly be easier to
rebase/test/review.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 09:23:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 07:23:37 +0000
Subject: [Koha-bugs] [Bug 19502] Result sets limited to 10000
In-Reply-To: <bug-19502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19502-70-hbY2mFYOud@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |alex.arnaud at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 09:45:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 07:45:22 +0000
Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance
	killer
In-Reply-To: <bug-18821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18821-70-Fvfdp88Dyv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #49 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 09:47:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 07:47:40 +0000
Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance
	killer
In-Reply-To: <bug-18821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18821-70-lIWQDb9TdD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

--- Comment #50 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.05.x for 17.05.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 09:48:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 07:48:50 +0000
Subject: [Koha-bugs] [Bug 20922] Koha::Number::Price must not be used in
 updatedatabase.pl
In-Reply-To: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20922-70-9hYfdDEDiV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922

--- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.05.x for 17.05.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 10:30:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 08:30:15 +0000
Subject: [Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is
	impossible
In-Reply-To: <bug-19945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19945-70-tHzJ8cSrby@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945

--- Comment #7 from Alex Arnaud <alex.arnaud at biblibre.com> ---
(In reply to Nick Clemens from comment #6)
> I don't think the second patch is quite right - CanBookBeReserved calls
> CanItemBeReserved, but it might not be correct for a specific item
> 
> Set a rule for 'No Holds Allowed' for an itemtype
> Find a bib with no items or create on
> Add an item with the disallowed item type
> Attempt hold on item via ILSDI - Not allowed
> Add a second item with a holdable itemtype
> Attempt hold on the original unholdable item via ILSDI - Allowed?
> 
> I think the call in 'Hold Item' to CanBookBeReserved is the extraneous one
> unless I missed something
> 
> I also note that neither of the routines mentioned check for 'On shelf holds
> allowed' policy - filed as bug 20985

I agree. For further, it seems to me that HoldItem should call
CanItemBeReserved only, even though it may not be the point of this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 12:33:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 10:33:37 +0000
Subject: [Koha-bugs] [Bug 20995] New: Add request ID to OPAC ILL requests
	display table
Message-ID: <bug-20995-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20995

            Bug ID: 20995
           Summary: Add request ID to OPAC ILL requests display table
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: ILL
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew.isherwood at ptfs-europe.com

Currently when an OPAC user is viewing the table of their ILL requests, they do
not see the request ID. This is commonly used for referring to requests, so we
should add it to this view and the individual request view.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 12:33:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 10:33:54 +0000
Subject: [Koha-bugs] [Bug 20995] Add request ID to OPAC ILL requests display
	table
In-Reply-To: <bug-20995-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20995-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20995-70-mQU5zEvLZF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20995

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ
                   |ity.org                     |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 12:39:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 10:39:47 +0000
Subject: [Koha-bugs] [Bug 20995] Add request ID to OPAC ILL requests display
	table
In-Reply-To: <bug-20995-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20995-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20995-70-ETIXcytCHf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20995

--- Comment #1 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 76431
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76431&action=edit
Bug 20995: Add Request ID to table and request view

This patch adds the display of Request ID to the OPAC views of all a
user's requests and the individual request.

To test:

1) Ensure you have ILL enabled
2) Log into the OPAC as a user with at least one request
3) Go to the "your interlibrary loan requests" page
4) TEST: Ensure that Request ID is displayed as the first column in the
table
5) Click the "View" button on a request
6) TEST: Ensure that Request ID is displayed along with all the other
request information

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 12:40:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 10:40:21 +0000
Subject: [Koha-bugs] [Bug 20995] Add request ID to OPAC ILL requests display
	table
In-Reply-To: <bug-20995-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20995-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20995-70-oHEMFneyyp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20995

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |7317
             Status|ASSIGNED                    |Needs Signoff


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 12:40:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 10:40:21 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-6lNgWWF60y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20995


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20995
[Bug 20995] Add request ID to OPAC ILL requests display table
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 12:48:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 10:48:36 +0000
Subject: [Koha-bugs] [Bug 20996] New: Fix API response time on ILL request
	endpoint
Message-ID: <bug-20996-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996

            Bug ID: 20996
           Summary: Fix API response time on ILL request endpoint
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: ILL
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew.isherwood at ptfs-europe.com

A bug has crept into the /api/v1/illrequests API endpoint causing a GET on this
route to take an unreasonably long time to respond, even with a few queries.
This never used to be the case so either we're fetching something that we
didn't before and that's slowing things down, or there's an actual bug.

For example, a query on my dev server with 6 requests takes 2.76 seconds to
respond. This is clearly an unreasonably long time and will almost certainly
increase as more requests are added.

We need to investigate the source of the slowdown and address it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 12:49:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 10:49:12 +0000
Subject: [Koha-bugs] [Bug 20996] Fix API response time on ILL request
	endpoint
In-Reply-To: <bug-20996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20996-70-B4kNtaghi0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ
                   |ity.org                     |e.com
         Depends on|                            |7317


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 12:49:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 10:49:12 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-AsD2y3mfDz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20996


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
[Bug 20996] Fix API response time on ILL request endpoint
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 13:24:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 11:24:56 +0000
Subject: [Koha-bugs] [Bug 20996] Fix API response time on ILL request
	endpoint
In-Reply-To: <bug-20996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20996-70-7nXEvM1bms@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 13:33:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 11:33:29 +0000
Subject: [Koha-bugs] [Bug 20996] Fix API response time on ILL request
	endpoint
In-Reply-To: <bug-20996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20996-70-mf2qjC53w9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996

Benjamin Rokseth <benjamin.rokseth at deichman.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |benjamin.rokseth at deichman.n
                   |                            |o

--- Comment #1 from Benjamin Rokseth <benjamin.rokseth at deichman.no> ---
Hi,
db design at least partly to blame. At least a quick fix would be to create an
index on illrequestattributes

CREATE INDEX `illrequestattributes_type_value` ON
illrequestattributes(type,value(32));

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 14:03:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 12:03:57 +0000
Subject: [Koha-bugs] [Bug 15972] Make it possible to include additional
 title information in notices (such as 245$b)
In-Reply-To: <bug-15972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15972-70-awNLXWWtth@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15972

Hugh Rundle <koha at hughr.me> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at hughr.me

--- Comment #3 from Hugh Rundle <koha at hughr.me> ---
Katrin are you suggesting allowing the use of `subtitle` in notices like you
can use it in page templates, allowing each library to decide which subfields
it wants to have available?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:09:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 13:09:18 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-ln5UMwLGd3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:09:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 13:09:22 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-bUV7VnW7tj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76394|0                           |1
        is obsolete|                            |
  Attachment #76395|0                           |1
        is obsolete|                            |

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76432
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76432&action=edit
Bug 20946: Add Koha::Account::outstanding_debits

This patch adds a handy method that returns the total for outstanding
debits (i.e. those that haven't been canceled with credits), and the
corresponding Koha::Account::Line objects.

Unit tests are added.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Account.t
=> SUCCESS: tests pass!
- Sign off :-D

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:09:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 13:09:31 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-d5v124M405@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76433
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76433&action=edit
Bug 20946: Use K::Account->outstanding_debits in pay.pl and paycollect.pl

This patch changes the how account lines are fetched (using
Koha::Account->outstanding_debits) so credits are not picked.

To test:
- Add a $5 credit to a patron
- Add a $1 fine
- Go to the 'Pay fines' tab
=> FAIL: Credit is displayed
- Try to pay all fines
=> FAIL: You are told to enter a value less than or equal to -4.00
         (Observe you cannot do that)
- Apply this patch
- Reload
=> SUCCESS: Credit is not displayed
=> SUCCESS: You are able to pay all fines
- Sign off :-D

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:09:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 13:09:35 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-54EbXwrvkc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76434
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76434&action=edit
Bug 20946: Reduce number of db calls

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:14:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 13:14:03 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-hTT3Ko0CSJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76434|0                           |1
        is obsolete|                            |

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76435
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76435&action=edit
Bug 20946: Reduce number of db calls

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:15:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 13:15:53 +0000
Subject: [Koha-bugs] [Bug 20507] Shelf browser does not update image sources
	when paging
In-Reply-To: <bug-20507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20507-70-cjP7qP24ov@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76436
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76436&action=edit
Bug 20507: Shelf browser does not update image sources when paging

This patch updates the shelfbrowser include so that the system
preference check for Coce will function correctly.

To test, apply the patch and test the OPAC shelf browser with each of
the enhanced content options enabled: Coce, Amazon, Google. In each
case, page through the shelf browser to confirm that covers load
correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:15:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 13:15:50 +0000
Subject: [Koha-bugs] [Bug 20507] Shelf browser does not update image sources
	when paging
In-Reply-To: <bug-20507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20507-70-Y57Vzl3GEZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:21:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 13:21:18 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-HlAKp9bF1z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76437&action=edit
Bug 20946: Additional unit tests for 0 lines edge case

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:42:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 13:42:31 +0000
Subject: [Koha-bugs] [Bug 15972] Make it possible to include additional
 title information in notices (such as 245$b)
In-Reply-To: <bug-15972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15972-70-Vspl73d7XG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15972

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Hugh, I think that would be nice. The other idea would be to be able to
specify MARC fields to pull in, but it might get much more complicated to
handle.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:44:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 13:44:03 +0000
Subject: [Koha-bugs] [Bug 20969] Use modal to add and edit notes from basket
In-Reply-To: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20969-70-QT07zO1IDH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:44:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 13:44:05 +0000
Subject: [Koha-bugs] [Bug 20969] Use modal to add and edit notes from basket
In-Reply-To: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20969-70-nwM8UfGs3g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76438&action=edit
Bug 20969: (follow-up) Move focus to textarea whe modal is shown

This follow-up adds code to move the mouse cursor to the modal window's
textarea when the modal is displayed.

To test, apply the patch and test the process of adding/editing notes on
an order. Confirm that the focus moves to the textarea when the note
editor modal window is shown.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:46:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 13:46:11 +0000
Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface
In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20935-70-uW4MpjEnAI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:46:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 13:46:25 +0000
Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout
 form, with collapsed settings panel
In-Reply-To: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20959-70-7ALK61pptJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:46:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 13:46:42 +0000
Subject: [Koha-bugs] [Bug 20966] Add column configuration to table of orders
	in a basket
In-Reply-To: <bug-20966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20966-70-goinjCvKqQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20966

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:47:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 13:47:14 +0000
Subject: [Koha-bugs] [Bug 20970] Reformat basket information on acquisitions
	basket page
In-Reply-To: <bug-20970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20970-70-D6Xjs5Vb3T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:48:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 13:48:23 +0000
Subject: [Koha-bugs] [Bug 20647] When ILL is enabled the hover effect on the
 ILL requests button is wrong.
In-Reply-To: <bug-20647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20647-70-K4wgvtBWH6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|martin.renvoize at ptfs-europe |oleonard at myacpl.org
                   |.com                        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:49:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 13:49:28 +0000
Subject: [Koha-bugs] [Bug 16575] Irregular behaviour using window.print()
 followed by window.location.href=
In-Reply-To: <bug-16575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16575-70-EYCjsD6JWy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|dcook at prosentient.com.au    |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:52:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 13:52:37 +0000
Subject: [Koha-bugs] [Bug 20962] Overhaul to notices
In-Reply-To: <bug-20962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20962-70-3CUt6CjyWZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20962

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |george at nekls.org

--- Comment #7 from George Williams (NEKLS) <george at nekls.org> ---
# Step 3 - option to process all print notices together:

We operate a library consortium that has 44 libraries and 51 library branches. 
1 of those libraries is a district with 4 branches and they would like to be
able to process all print notices at their headquarters branch.  Another of
those libraries is a school distict with 5 branches and they would like to
process all print notices at each separate branch.  Work on #3 that can offer
the flexibility to accommodate that scenario would be welcomed and it would
probably solve Lisette's situation as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:59:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 13:59:18 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-sY1IOIA5RO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:59:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 13:59:48 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-LwV2No0bze@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76396|0                           |1
        is obsolete|                            |
  Attachment #76397|0                           |1
        is obsolete|                            |
  Attachment #76398|0                           |1
        is obsolete|                            |

--- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76439&action=edit
Bug 20978: Unit tests

This patch adds unit tests for Koha::Account::add_credit.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:59:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 13:59:59 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-Thynjfws1g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

--- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76440&action=edit
Bug 20978: Add Koha::Account::add_credit

This patch adds:
- Koha::Account::add_credit
- A single source of truth for accounttype and offset_type values

To test:
- Apply the first patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Account.t
=> FAIL: Tests fail!
- Apply this patch
- Run:
 k$ prove t/db_dependent/Koha/Account.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:00:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 14:00:03 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-7N9dkhRHLA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

--- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76441
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76441&action=edit
Bug 20978: (follow-up) Another use case from C4::Circulation

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:17:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 14:17:16 +0000
Subject: [Koha-bugs] [Bug 18412] Show list price in foreign currency in
	acquisitions
In-Reply-To: <bug-18412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18412-70-iUITzUJv2l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18412

imelda.bennis at educampus.ie changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |imelda.bennis at educampus.ie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:22:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 14:22:58 +0000
Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
In-Reply-To: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20980-70-834T2n9Wsp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:23:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 14:23:02 +0000
Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
In-Reply-To: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20980-70-mfkLWcTBzS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76401|0                           |1
        is obsolete|                            |
  Attachment #76402|0                           |1
        is obsolete|                            |
  Attachment #76403|0                           |1
        is obsolete|                            |
  Attachment #76404|0                           |1
        is obsolete|                            |

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76442
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76442&action=edit
Bug 20980: Add 'Manual Credit' and fix existing offsets

This patch adds a new offset type 'Manual Credit'. And adds an atomic
update for fixing existing offsets.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:23:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 14:23:11 +0000
Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
In-Reply-To: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20980-70-v4WAIN3vfz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980

--- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76443
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76443&action=edit
Bug 20980: Make mancredit.pl use Koha::Account::add_credit

This patch makes creating a manual credit from the UI record the account
offset as 'Manual Credit', and properly set account_offsets.credit_id
instead of account_offsets.debit_id.

To test:
- Create a manual credit (of 'Credit' type) for a known patron (acevedo?)
- Run:
  $ sudo koha-mysql kohadev
  > SELECT * FROM account_offsets;
=> FAIL: The account offset for the manual credit has type=Manual Debit,
    credit_id=NULL and debit_id=accountlines_id
- Run the atomic update:
  $ updatedatabase
- Run:
  $ sudo koha-mysql kohadev
  > SELECT * FROM account_offsets;
=> SUCCESS: The account offset has been corrected and now has
type=Manual Credit, credit_id=accountlines_id and debit_id=NULL
- Create a new manual credit (of 'Forgiven' type) for a known patron
- Run:
  $ sudo koha-mysql kohadev
  > SELECT * FROM account_offsets;
=> SUCCESS: The account offset has been stored correctly as a credit!
- Sign off :-D

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:23:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 14:23:15 +0000
Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
In-Reply-To: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20980-70-MExJzWQEtH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76444
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76444&action=edit
Bug 20980: (follow-up) Only use UpdateStats for 'payment' and 'writeoff'

This patch makes Koha::Account::add_credit record statistics logs
(through C4::Stats::UpdateStats) only for the 'payment' and 'writeoff'
credit types.

Both credit types are whitelisted in UpdateStats, so we keep the current
behaviour. Another option would've been to add new account types to the
white list, but with the account offsets it seems that using the
statistics table for account changes won't be useful for too long, as
offsets contain the same (and more) information.

To test:
- Apply the patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Account.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:23:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 14:23:18 +0000
Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
In-Reply-To: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20980-70-EOtok5YtLu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980

--- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76445&action=edit
Bug 20980: (follow-up) Offset name consistency

This patch makes 'credit' account types generate 'Manual Credit' offset.
The original patch used 'Payment' but I think the code wants to
distinguish between payments and manually added credits (otherwise they
would've picked the same accounttype value, and they don't.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:27:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 14:27:26 +0000
Subject: [Koha-bugs] [Bug 20647] When ILL is enabled the hover effect on the
 ILL requests button is wrong.
In-Reply-To: <bug-20647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20647-70-zJ4kKukv6H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Looks much nicer than my fix ?.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:32:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 14:32:14 +0000
Subject: [Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits
In-Reply-To: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20990-70-VHseQ1QMmi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76405|0                           |1
        is obsolete|                            |
  Attachment #76406|0                           |1
        is obsolete|                            |
  Attachment #76407|0                           |1
        is obsolete|                            |

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76446&action=edit
Bug 20990: Unit tests for Koha::Account->outstanding_credits

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:32:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 14:32:11 +0000
Subject: [Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits
In-Reply-To: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20990-70-VACP8tetuB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:32:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 14:32:22 +0000
Subject: [Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits
In-Reply-To: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20990-70-xpGfiXgM6D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76447
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76447&action=edit
Bug 20990: Add Koha::Account->outstanding_credits

This patch adds a method that retrieves (for a patron's account) the
outstanding credits (i.e. those that haven't been applied to any debit.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Account.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:32:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 14:32:25 +0000
Subject: [Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits
In-Reply-To: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20990-70-Qfbt1o5NIF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76448
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76448&action=edit
Bug 20990: (follow-up) Fix test description

Test plan:
prove -v t/db_dependent/Koha/Account.t
--> Test message of first test of subtest outtanding_credits correctly says
"Outstanding credits total..."

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:32:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 14:32:28 +0000
Subject: [Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits
In-Reply-To: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20990-70-kfVl5Lq2ij@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76449
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76449&action=edit
Bug 20990: Make same changes that were made to outstanding_debits

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:37:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 14:37:23 +0000
Subject: [Koha-bugs] [Bug 19617] Allow 'writeoff of selected'
In-Reply-To: <bug-19617-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19617-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19617-70-TZYGpcjIgL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19617

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:37:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 14:37:27 +0000
Subject: [Koha-bugs] [Bug 19617] Allow 'writeoff of selected'
In-Reply-To: <bug-19617-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19617-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19617-70-aFtbLiyUPH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19617

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75702|0                           |1
        is obsolete|                            |

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76450
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76450&action=edit
Bug 19617: Allow 'writeoff of selected'

This patch adds a writeoff equivilent to 'Pay selected'

Test Plan:
1) Apply this patch
2) Find a patron with fines
3) On the "Pay fines" tab, select one or more fines and use the
   "Write off selected" button.
4) Note the fine amount you used was written off for those fines.

Signed-off-by: Kyle M Hall <kyle at bywatetsolutions.com>

Signed-off-by: Martha Fuerst <mfuerst at hmcpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:51:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 14:51:15 +0000
Subject: [Koha-bugs] [Bug 20997] New: Add Koha::Account::Line::apply
Message-ID: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997

            Bug ID: 20997
           Summary: Add Koha::Account::Line::apply
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

There should be a method to apply a credit to a debit.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:55:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 14:55:31 +0000
Subject: [Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
In-Reply-To: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20997-70-qbDryYNVsz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20944


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944
[Bug 20944] Add routes to add credits and debits to a patron's account
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:55:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 14:55:31 +0000
Subject: [Koha-bugs] [Bug 20944] Add routes to add credits and debits to a
 patron's account
In-Reply-To: <bug-20944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20944-70-8Xal7U6mnz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20997


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997
[Bug 20997] Add Koha::Account::Line::apply
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:55:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 14:55:48 +0000
Subject: [Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
In-Reply-To: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20997-70-8UQLLn4jpr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:56:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 14:56:18 +0000
Subject: [Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
In-Reply-To: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20997-70-1RMXL4YRkk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76451
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76451&action=edit
Bug 20997: Add unit tests for Koha::Account::Line::apply

This patch adds unit tests for the mentioned method.

To test:
- Apply this patch
- Run:
  $ khell
 k$ prove t/db_dependent/Koha/Account/Lines.t
=> FAIL: The method is not already implemented!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:56:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 14:56:30 +0000
Subject: [Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
In-Reply-To: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20997-70-4uLV7washp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76452
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76452&action=edit
Bug 20997: Add Koha::Account::Line::apply method

This patch implements the ->apply() method for account lines.
It will only work on credit lines, and raise an exception otherwise.

It implements ->is_credit() as well.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Account/Lines.t
=> SUCCESS: Tests pass!
- Check all use cases are covered by the tests
- Sign off :-D

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:56:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 14:56:52 +0000
Subject: [Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
In-Reply-To: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20997-70-em4orLSRD6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 17:01:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 15:01:49 +0000
Subject: [Koha-bugs] [Bug 20998] New: Non superlibrarians cannot search for
 patrons using the quicksearch at the top
Message-ID: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998

            Bug ID: 20998
           Summary: Non superlibrarians cannot search for patrons using
                    the quicksearch at the top
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

To recreate:
1 - Enable 'IndependentBranches'
2 - Setup a patron with all permissions, but not a superlibrarian
3 - Login to staff client as that patron
4 - Click 'Patrons' in the toolbar and try a search
5 - Internal server error

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 17:04:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 15:04:28 +0000
Subject: [Koha-bugs] [Bug 20998] Non superlibrarians cannot search for
 patrons using the quicksearch at the top
In-Reply-To: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20998-70-HcHmPZjSkZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 17:04:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 15:04:32 +0000
Subject: [Koha-bugs] [Bug 20998] Non superlibrarians cannot search for
 patrons using the quicksearch at the top
In-Reply-To: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20998-70-1WJsbOVUa8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 76453
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76453&action=edit
Bug 20998: Only perform quicksearch if patron found with cardnumber

This patch makes sure we have a patron before we try to access their
branchcode and allows search to work

To recreate:
1 - Enable 'IndependentBranches'
2 - Setup a patron with all permissions, but not a superlibrarian
3 - Login to staff client as that patron
4 - Click 'Patrons' in the toolbar and try a search
5 - Internal server error
6 - Apply patch
7 - Try the search again
8 - Success!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 17:06:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 15:06:06 +0000
Subject: [Koha-bugs] [Bug 10675] Remove spinelabel.css?
In-Reply-To: <bug-10675-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10675-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10675-70-Gy4nFNTCpR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10675

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
I think it's good to have default styling always in place. intranetusercss can
be used to override whatever is in spinelabel.css. In my opinion this bug would
be WONTFIX.

On the other hand, we could add a new system preference which was specifically
for spine label CSS. If that's what is wanted the title of the bug should be
revised.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 17:08:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 15:08:06 +0000
Subject: [Koha-bugs] [Bug 20998] Non superlibrarians cannot search for
 patrons using the quicksearch at the top
In-Reply-To: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20998-70-ajbnf5155X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |
                 CC|                            |barton at bywatersolutions.com
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 17:12:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 15:12:53 +0000
Subject: [Koha-bugs] [Bug 20999] New: Remove invalid 'style="block"' from
	OPAC templates
Message-ID: <bug-20999-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20999

            Bug ID: 20999
           Summary: Remove invalid 'style="block"' from OPAC templates
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

There are a few instances of the invalid 'style="block"' attribute in the OPAC
templates. They should be removed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 17:22:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 15:22:21 +0000
Subject: [Koha-bugs] [Bug 20903] Print payment receipt on child patron could
 end with server error
In-Reply-To: <bug-20903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20903-70-WzHlSVUvTl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 17:22:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 15:22:26 +0000
Subject: [Koha-bugs] [Bug 20903] Print payment receipt on child patron could
 end with server error
In-Reply-To: <bug-20903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20903-70-mfZpB3kvUz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76424|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76454
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76454&action=edit
Bug 20903: Remove unnecessary category code parameters

Test plan:
0) Do no apply the patch
1) Have only one adults patrons category defined
2) Add a fine to child patron and pay it
3) Try to print the payment receipt (file printfeercpt.pl)
4) You see only ISE
5) Apply the patch
6) Try the printing again
7) Now you should see right receipt

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 17:23:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 15:23:48 +0000
Subject: [Koha-bugs] [Bug 20903] Print payment receipt on child patron could
 end with server error
In-Reply-To: <bug-20903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20903-70-uF14TBcOpw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19921
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Caused by
  commit 585453fe20417779be84258b60d3d652d8e170e1
  Bug 19921: Fix update child when only one adult patron category exist


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921
[Bug 19921] Error when updating child to adult patron on system with only one
adult patron category
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 17:23:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 15:23:48 +0000
Subject: [Koha-bugs] [Bug 19921] Error when updating child to adult patron
 on system with only one adult patron category
In-Reply-To: <bug-19921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19921-70-3BbkiLsc3q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20903


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903
[Bug 20903] Print payment receipt on child patron could end with server error
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 17:26:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 15:26:36 +0000
Subject: [Koha-bugs] [Bug 21000] New: debian/build-git-snapshot script
 ignores --distribution
Message-ID: <bug-21000-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21000

            Bug ID: 21000
           Summary: debian/build-git-snapshot script ignores
                    --distribution
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jcharaoui at cmaisonneuve.qc.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: mirko at abunchofthings.net

Calling debian/build-git-snapshot with the --distribution switch has no effect.
It seems that the variable isn't passed to the adjust_debian_changelog()
function.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 17:37:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 15:37:50 +0000
Subject: [Koha-bugs] [Bug 20998] Non superlibrarians cannot search for
 patrons using the quicksearch at the top
In-Reply-To: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20998-70-wpcCOKXb97@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76456
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76456&action=edit
Bug 20998: Simplify the conditional statement

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 17:37:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 15:37:47 +0000
Subject: [Koha-bugs] [Bug 20998] Non superlibrarians cannot search for
 patrons using the quicksearch at the top
In-Reply-To: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20998-70-HydfkQq8DP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76453|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76455
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76455&action=edit
Bug 20998: Only perform quicksearch if patron found with cardnumber

This patch makes sure we have a patron before we try to access their
branchcode and allows search to work

To recreate:
1 - Enable 'IndependentBranches'
2 - Setup a patron with all permissions, but not a superlibrarian
3 - Login to staff client as that patron
4 - Click 'Patrons' in the toolbar and try a search
5 - Internal server error
6 - Apply patch
7 - Try the search again
8 - Success!

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 17:38:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 15:38:07 +0000
Subject: [Koha-bugs] [Bug 20998] Non superlibrarians cannot search for
 patrons using the quicksearch at the top
In-Reply-To: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20998-70-JUm6ekQu9I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |critical
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Keywords|                            |rel_18_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 17:39:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 15:39:23 +0000
Subject: [Koha-bugs] [Bug 20998] Non superlibrarians cannot search for
 patrons using the quicksearch at the top
In-Reply-To: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20998-70-3Q9ZUHyIsX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17829

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Upping severity, that's clearly critical for installations with
IndependentBranches.
I have added a follow-up to simplify the conditional statement.

Caused by
  commit 2b90ea2cb0e5e976de7ddef0151ae83d8ac578e6
  Bug 17829: Move GetMember to Koha::Patron


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829
[Bug 17829] Move GetMember to Koha::Patron
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 17:39:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 15:39:23 +0000
Subject: [Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron
In-Reply-To: <bug-17829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17829-70-CUjhyUQZMM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20998


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998
[Bug 20998] Non superlibrarians cannot search for patrons using the quicksearch
at the top
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 18:05:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 16:05:26 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
	source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-3yhAKv4svh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #87 from David Gustafsson <glasklas at gmail.com> ---
Thanks. Since this is a rather big change there probably are some minor
undiscovered issues with the current patch and we are still running with the
prior version in production. The tests are pretty exhaustive though, so I would
be surprised if there are any major undiscovered problems. Usability and
documentation is probably where there is still most room for improvement and
some feedback would be useful to improve on those. But should more or less be
ready for sign-off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 18:07:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 16:07:12 +0000
Subject: [Koha-bugs] [Bug 20991] Error will reset category when editing a
	patron
In-Reply-To: <bug-20991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20991-70-CPaFgbqJIb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20991

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 18:07:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 16:07:15 +0000
Subject: [Koha-bugs] [Bug 20991] Error will reset category when editing a
	patron
In-Reply-To: <bug-20991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20991-70-XSrehrq30F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20991

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76457
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76457&action=edit
Bug 20991: Do not lost patron's category when editing a patron

If there is an error in the edit patron form the patron's category is
lost.
This seems to be a long standing bug.

Test plan:
- Edit an existing patron
- Change the patron category to a category that triggers the error that
the user is not in the right age range for that new category
- Save, error is triggered
=> Without this patch the patron category has been reset

You should also test different ways to edit/add a patron (quick add,
step 1)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 18:07:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 16:07:31 +0000
Subject: [Koha-bugs] [Bug 20991] Error will reset category when editing a
	patron
In-Reply-To: <bug-20991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20991-70-lu4kCq4uGK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20991

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 18:13:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 16:13:20 +0000
Subject: [Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved
 should check 'On shelf holds allowed' policy
In-Reply-To: <bug-20985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20985-70-LCaOiXlhGb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19297

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 18:13:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 16:13:20 +0000
Subject: [Koha-bugs] [Bug 19297] Standardize "can place hold" calculations
In-Reply-To: <bug-19297-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19297-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19297-70-3a3BUdkdYD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19297

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20985

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 18:27:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 16:27:56 +0000
Subject: [Koha-bugs] [Bug 20999] Remove invalid 'style="block"' from OPAC
	templates
In-Reply-To: <bug-20999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20999-70-wlPKg3d5Mi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20999

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 18:27:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 16:27:59 +0000
Subject: [Koha-bugs] [Bug 20999] Remove invalid 'style="block"' from OPAC
	templates
In-Reply-To: <bug-20999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20999-70-ZrAGnvmEIh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20999

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76458
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76458&action=edit
Bug 20999: Remove invalid 'style="block"' from OPAC templates

This patch removes an invalid attribute from OPAC template markup. There
should be no visible change to the OPAC.

To test, apply the patch and confirm that the following pages still look
correct when using various cover image sources: Coce, Amazon, Google:

 - Bibliographic detail page (opac-detail.pl)
   - The shelf browser
 - Catalog search results
 - Recent comments

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 18:31:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 16:31:07 +0000
Subject: [Koha-bugs] [Bug 21001] New: OpenLibrary book covers broken
Message-ID: <bug-21001-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21001

            Bug ID: 21001
           Summary: OpenLibrary book covers broken
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

OpenLibrary book covers don't appear on the search results or detail page in
the OPAC. The console shows an error, "SyntaxError: missing ) after argument
list books:1:16246"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 18:56:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 16:56:31 +0000
Subject: [Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
In-Reply-To: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20997-70-ItZlRtRu82@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20978
                 CC|                            |josef.moravec at gmail.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978
[Bug 20978] Add Koha::Account::add_credit
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 18:56:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 16:56:31 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-mgDjveKSxP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20997


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997
[Bug 20997] Add Koha::Account::Line::apply
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 18:59:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 16:59:36 +0000
Subject: [Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
In-Reply-To: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20997-70-O9hhgcgDBI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 18:59:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 16:59:43 +0000
Subject: [Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
In-Reply-To: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20997-70-vaaWHfw6Tv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76451|0                           |1
        is obsolete|                            |
  Attachment #76452|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76459
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76459&action=edit
Bug 20997: Add unit tests for Koha::Account::Line::apply

This patch adds unit tests for the mentioned method.

To test:
- Apply this patch
- Run:
  $ khell
 k$ prove t/db_dependent/Koha/Account/Lines.t
=> FAIL: The method is not already implemented!

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 18:59:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 16:59:51 +0000
Subject: [Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
In-Reply-To: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20997-70-TDPQ1oNymg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76460
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76460&action=edit
Bug 20997: Add Koha::Account::Line::apply method

This patch implements the ->apply() method for account lines.
It will only work on credit lines, and raise an exception otherwise.

It implements ->is_credit() as well.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Account/Lines.t
=> SUCCESS: Tests pass!
- Check all use cases are covered by the tests
- Sign off :-D

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 19:13:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 17:13:44 +0000
Subject: [Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
In-Reply-To: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20997-70-fl4ruBTEr5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76461
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76461&action=edit
Bug 20997: (follow-up) Add Koha::Account::Line->is_debit method

Test plan:
1) Apply this patch
2) prove t/db_dependent/Koha/Account/Lines.t
=> Test should pass

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 19:24:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 17:24:41 +0000
Subject: [Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
In-Reply-To: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20997-70-v4ITAv4vzk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76461|0                           |1
        is obsolete|                            |

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76462
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76462&action=edit
Bug 20997: (follow-up) Add Koha::Account::Line->is_debit method

Test plan:
1) Apply this patch
2) prove t/db_dependent/Koha/Account/Lines.t
=> Test should pass

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 19:34:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 17:34:09 +0000
Subject: [Koha-bugs] [Bug 21002] New: Add Koha::Account::add_debit
Message-ID: <bug-21002-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002

            Bug ID: 21002
           Summary: Add Koha::Account::add_debit
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

There should be a high-level method for creating new debits, similar to
Koha::Account::add_credit.

It will handle creating the line, and the offset.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 19:34:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 17:34:27 +0000
Subject: [Koha-bugs] [Bug 21000] debian/build-git-snapshot script ignores
	--distribution
In-Reply-To: <bug-21000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21000-70-KlcowbcwVE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21000

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 19:36:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 17:36:21 +0000
Subject: [Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
In-Reply-To: <bug-21002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21002-70-idfZlS7TOr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 19:36:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 17:36:50 +0000
Subject: [Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
In-Reply-To: <bug-21002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21002-70-D7bMUWr70k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20978


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978
[Bug 20978] Add Koha::Account::add_credit
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 19:36:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 17:36:50 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-oMcN5uEqCi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |21002


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002
[Bug 21002] Add Koha::Account::add_debit
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 19:38:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 17:38:08 +0000
Subject: [Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
In-Reply-To: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20997-70-GKgKNqv7Cc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 19:38:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 17:38:12 +0000
Subject: [Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
In-Reply-To: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20997-70-p6OJ8ndTFK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76459|0                           |1
        is obsolete|                            |
  Attachment #76460|0                           |1
        is obsolete|                            |
  Attachment #76462|0                           |1
        is obsolete|                            |

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76463
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76463&action=edit
Bug 20997: Add unit tests for Koha::Account::Line::apply

This patch adds unit tests for the mentioned method.

To test:
- Apply this patch
- Run:
  $ khell
 k$ prove t/db_dependent/Koha/Account/Lines.t
=> FAIL: The method is not already implemented!

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 19:38:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 17:38:20 +0000
Subject: [Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
In-Reply-To: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20997-70-kk63eTMJMC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76464
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76464&action=edit
Bug 20997: Add Koha::Account::Line::apply method

This patch implements the ->apply() method for account lines.
It will only work on credit lines, and raise an exception otherwise.

It implements ->is_credit() as well.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Account/Lines.t
=> SUCCESS: Tests pass!
- Check all use cases are covered by the tests
- Sign off :-D

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 19:38:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 17:38:23 +0000
Subject: [Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
In-Reply-To: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20997-70-0gRju5ARRH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76465
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76465&action=edit
Bug 20997: (follow-up) Add Koha::Account::Line->is_debit method

Test plan:
1) Apply this patch
2) prove t/db_dependent/Koha/Account/Lines.t
=> Test should pass

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 19:50:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 17:50:11 +0000
Subject: [Koha-bugs] [Bug 20998] Non superlibrarians cannot search for
 patrons using the quicksearch at the top
In-Reply-To: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20998-70-zOfPJQK0wb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76455|0                           |1
        is obsolete|                            |
  Attachment #76456|0                           |1
        is obsolete|                            |

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76466
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76466&action=edit
Bug 20998: Only perform quicksearch if patron found with cardnumber

This patch makes sure we have a patron before we try to access their
branchcode and allows search to work

To recreate:
1 - Enable 'IndependentBranches'
2 - Setup a patron with all permissions, but not a superlibrarian
3 - Login to staff client as that patron
4 - Click 'Patrons' in the toolbar and try a search
5 - Internal server error
6 - Apply patch
7 - Try the search again
8 - Success!

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 19:50:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 17:50:15 +0000
Subject: [Koha-bugs] [Bug 20998] Non superlibrarians cannot search for
 patrons using the quicksearch at the top
In-Reply-To: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20998-70-VJB7hhptpS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76467
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76467&action=edit
Bug 20998: Simplify the conditional statement

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 19:50:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 17:50:07 +0000
Subject: [Koha-bugs] [Bug 20998] Non superlibrarians cannot search for
 patrons using the quicksearch at the top
In-Reply-To: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20998-70-q7hKRs62mq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 22:45:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 20:45:03 +0000
Subject: [Koha-bugs] [Bug 10675] Remove spinelabel.css?
In-Reply-To: <bug-10675-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10675-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10675-70-oZEQ3yhvco@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10675

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|NEW                         |RESOLVED

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Agreed :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 22:58:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 20:58:31 +0000
Subject: [Koha-bugs] [Bug 21003] New: Don't show warning when editing a
	reserve item
Message-ID: <bug-21003-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21003

            Bug ID: 21003
           Summary: Don't show warning when editing a reserve item
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Course reserves
          Assignee: kyle at bywatersolutions.com
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

When editing an item in a course reserve, the following message always
displays:

This course already has this item on reserve.

This appears out of place and should not display on edting.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 22:58:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 20:58:31 +0000
Subject: [Koha-bugs] [Bug 20467] Add ability to batch add items to a course
In-Reply-To: <bug-20467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20467-70-hVz27UvuFy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=21003

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 23:00:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 21:00:28 +0000
Subject: [Koha-bugs] [Bug 20467] Add ability to batch add items to a course
In-Reply-To: <bug-20467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20467-70-DsxA88HrwY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467

--- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I've filed bug 21003 for the superfluous message about the existing item. It
makes no sense when editing a reserve item.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 23:08:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 21:08:04 +0000
Subject: [Koha-bugs] [Bug 20467] Add ability to batch add items to a course
In-Reply-To: <bug-20467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20467-70-KGmZgZF8LG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73239|0                           |1
        is obsolete|                            |

--- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 76468
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76468&action=edit
Bug 20467: Add ability to batch add items to a course

Some librarians have requested the ability to batch add items to a
course using the same settings for all items.

Test Plan:
1) Apply this patch
2) Create a new course
3) Click the new 'Batch add reserves' button
4) Enter some valid and invalid barcodes in the text box, add some settings
5) Submit the batch, note the results list added items and invalid barcodes
6) Note the valid items were added to the course

Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Maksim Sen <maksim.sen at inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 23:08:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 21:08:08 +0000
Subject: [Koha-bugs] [Bug 20467] Add ability to batch add items to a course
In-Reply-To: <bug-20467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20467-70-cjfgQobQ5R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467

--- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 76469
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76469&action=edit
Bug 20467: (QA follow-up) Add Branches plugin to template

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 23:08:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 21:08:13 +0000
Subject: [Koha-bugs] [Bug 20467] Add ability to batch add items to a course
In-Reply-To: <bug-20467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20467-70-3h7do1XpLl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467

--- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 76470
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76470&action=edit
Bug 20467: (QA follow-up)  Filter barcodes, remove selector code, use template
plugins

Removes selector code as batch changes cannot have a previous selection.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 23:08:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 21:08:17 +0000
Subject: [Koha-bugs] [Bug 20467] Add ability to batch add items to a course
In-Reply-To: <bug-20467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20467-70-ZsPcQ685ke@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73705|0                           |1
        is obsolete|                            |

--- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 76471
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76471&action=edit
Bug 20467: Remove useless use statements

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 23:08:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 21:08:21 +0000
Subject: [Koha-bugs] [Bug 20467] Add ability to batch add items to a course
In-Reply-To: <bug-20467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20467-70-WaI56abLP9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467

--- Comment #30 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 76472
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76472&action=edit
Bug 20467: (QA follow-up) Display error if no or invalid course id is passed

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 23:44:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 21:44:43 +0000
Subject: [Koha-bugs] [Bug 20991] Error will reset category when editing a
	patron
In-Reply-To: <bug-20991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20991-70-OQt6VTScWG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20991

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 23:44:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 21:44:47 +0000
Subject: [Koha-bugs] [Bug 20991] Error will reset category when editing a
	patron
In-Reply-To: <bug-20991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20991-70-yaxKg2zb19@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20991

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76457|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 76473
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76473&action=edit
Bug 20991: Do not lost patron's category when editing a patron

If there is an error in the edit patron form the patron's category is
lost.
This seems to be a long standing bug.

Test plan:
- Edit an existing patron
- Change the patron category to a category that triggers the error that
the user is not in the right age range for that new category
- Save, error is triggered
=> Without this patch the patron category has been reset

You should also test different ways to edit/add a patron (quick add,
step 1)

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 23:48:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 21:48:43 +0000
Subject: [Koha-bugs] [Bug 20969] Use modal to add and edit notes from basket
In-Reply-To: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20969-70-3lu0Dwaz00@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76438|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 76474
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76474&action=edit
Bug 20969: (follow-up) Move focus to textarea whe modal is shown

This follow-up adds code to move the mouse cursor to the modal window's
textarea when the modal is displayed.

To test, apply the patch and test the process of adding/editing notes on
an order. Confirm that the focus moves to the textarea when the note
editor modal window is shown.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 23:49:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 21:49:57 +0000
Subject: [Koha-bugs] [Bug 20969] Use modal to add and edit notes from basket
In-Reply-To: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20969-70-cSIE74p06Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx, Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 23:50:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 21:50:54 +0000
Subject: [Koha-bugs] [Bug 21004] New: Use modal to add and edit notes on
 receiving orders/shipments page
Message-ID: <bug-21004-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21004

            Bug ID: 21004
           Summary: Use modal to add and edit notes on receiving
                    orders/shipments page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

See bug 20969, but for parcel.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 23:51:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 21:51:13 +0000
Subject: [Koha-bugs] [Bug 21004] Use modal to add and edit notes on
 receiving orders/shipments page
In-Reply-To: <bug-21004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21004-70-EhHSFXAuOW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21004

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20969

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 23:51:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 21:51:13 +0000
Subject: [Koha-bugs] [Bug 20969] Use modal to add and edit notes from basket
In-Reply-To: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20969-70-3nkofAYolx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=21004

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 00:00:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 22:00:49 +0000
Subject: [Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
In-Reply-To: <bug-21002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21002-70-RBFPTujikF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14825


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 00:00:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 22:00:49 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14825-70-H9agjW8rNA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |21002


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002
[Bug 21002] Add Koha::Account::add_debit
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 00:25:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 22:25:45 +0000
Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for
	callnumber ranges
In-Reply-To: <bug-19915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19915-70-k74HDTofjM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915

Eric Phetteplace <ephetteplace at cca.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ephetteplace at cca.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 00:32:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2018 22:32:57 +0000
Subject: [Koha-bugs] [Bug 20467] Add ability to batch add items to a course
In-Reply-To: <bug-20467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20467-70-odnZouCDzs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 02:18:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 00:18:05 +0000
Subject: [Koha-bugs] [Bug 21005] New: Report wizards fatal errors if no
 radio buttons selected
Message-ID: <bug-21005-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21005

            Bug ID: 21005
           Summary: Report wizards fatal errors if no radio buttons
                    selected
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org

Some report wizards have radio buttons selected by default and some do not.

If someone tries to run a report wizard that has no radio buttons selected,
fatal errors are generated.

This can be fixed just be pre-selecting radio buttons on those reports without
them.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 04:58:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 02:58:49 +0000
Subject: [Koha-bugs] [Bug 21006] New: GetMarcBiblio is slow for records with
	many bibs
Message-ID: <bug-21006-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006

            Bug ID: 21006
           Summary: GetMarcBiblio is slow for records with many bibs
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: nick at bywatersolutions.com
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Some libraries have serials that have large numbers of items attached to the
record, this can create problems when exporting/harvesting the records.

One of the problems seems to be GetMarcBiblio which makes several db requests
per item, many of these can be removed by adding a GetMarcItems routine to
fetch several items rather than iterating over each biblionumber

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 04:59:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 02:59:53 +0000
Subject: [Koha-bugs] [Bug 21006] GetMarcBiblio is slow for records with many
	bibs
In-Reply-To: <bug-21006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21006-70-lf6VsN8nO7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 76475
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76475&action=edit
Bug 21006: Add GetMarcItems method and refactor GetMarcBiblio

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 04:59:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 02:59:51 +0000
Subject: [Koha-bugs] [Bug 21006] GetMarcBiblio is slow for records with many
	bibs
In-Reply-To: <bug-21006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21006-70-2ldtbFEdmn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 05:04:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 03:04:08 +0000
Subject: [Koha-bugs] [Bug 21006] GetMarcBiblio is slow for records with many
	bibs
In-Reply-To: <bug-21006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21006-70-k7DggenukJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |kyle at bywatersolutions.com,
                   |                            |m.de.rooy at rijksmuseum.nl,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 10:54:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 08:54:50 +0000
Subject: [Koha-bugs] [Bug 20702] Bind results of GetHostItemsInfo to the
 EasyAnalyticalRecords pref
In-Reply-To: <bug-20702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20702-70-GWUJ9r0Dxm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20702

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.05.x for 18.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 10:59:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 08:59:15 +0000
Subject: [Koha-bugs] [Bug 20697] Remove some Host-Item-Number noise from
 zebra-output.log when EasyAnalyticalRecords is not used
In-Reply-To: <bug-20697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20697-70-wwhEEDK2eY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20697

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76314|0                           |1
        is obsolete|                            |

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 76476
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76476&action=edit
Bug 20697: Bind calling GetAnalyticsCount to pref EasyAnalyticalRecords

If you do not use the EasyAnalyticalRecords feature (introduced with
bug 5528), you will have a lot of warnings in zebra-output.log like:

zebrasrv(1096) [request] Search biblios ERROR 114 1 1+0 RPN @attrset Bib-1
@attr 1=8911 259186

They come from C4::Items::GetAnalyticsCount called by catalogue/detail.pl.
This sub starts a Zebra search on index 'hi' (Host-Item-Number).
If you do not use this field at all (related to 773$9 in MARC21), Zebra
returns an Unsupported Use attribute error (114).

In making this change, I added one minor change:
[1] Remove the commented GetAnalyticsCount in additem.pl and correcting
    indentation in that loop (removing tabs). So no change at all there.

NOTE: I will propose to bind the GetHostItemsInfo call in detail.pl and two
other scripts to this preference too on report 20702.

Test plan:
[1] If you use EasyAnalytics, verify that there is no change.
[2] If you do not, check the zebra-output.log. You should no longer see
    searches for Host-Item-Number with 1=8911. (As well as ERROR 114 on
    this index.)

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 11:00:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 09:00:12 +0000
Subject: [Koha-bugs] [Bug 20697] Remove some Host-Item-Number noise from
 zebra-output.log when EasyAnalyticalRecords is not used
In-Reply-To: <bug-20697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20697-70-cwAWkgcxgd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20697

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Looks good to me and tests all still pass.. passing QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 11:05:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 09:05:00 +0000
Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to
	configuration files
In-Reply-To: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20073-70-uaeN6X0SF7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #52 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement, not back porting to 18.05.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 11:05:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 09:05:01 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
	Elasticsearch
In-Reply-To: <bug-19893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19893-70-Dp9dlUBvRM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Bug 19893 depends on bug 20073, which changed state.

Bug 20073 Summary: Move Elasticsearch settings to configuration files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 11:05:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 09:05:02 +0000
Subject: [Koha-bugs] [Bug 20244] Elasticsearch - Indexing improvements
In-Reply-To: <bug-20244-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20244-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20244-70-tIpA5IPECF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20244
Bug 20244 depends on bug 20073, which changed state.

Bug 20073 Summary: Move Elasticsearch settings to configuration files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 11:05:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 09:05:02 +0000
Subject: [Koha-bugs] [Bug 20390] Elasticsearch - Mappings for UNIMARC
	(updates existing)
In-Reply-To: <bug-20390-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20390-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20390-70-wzs1xwKwdQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20390
Bug 20390 depends on bug 20073, which changed state.

Bug 20073 Summary: Move Elasticsearch settings to configuration files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 11:06:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 09:06:47 +0000
Subject: [Koha-bugs] [Bug 20400] Add routing list tab to the patron account
	in OPAC
In-Reply-To: <bug-20400-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20400-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20400-70-IwQMlHvD8U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 11:06:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 09:06:48 +0000
Subject: [Koha-bugs] [Bug 20456] Remove the
	C4::Serials::GetSubscriptionsFromBorrower
In-Reply-To: <bug-20456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20456-70-GbKHzJARBL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456
Bug 20456 depends on bug 20400, which changed state.

Bug 20400 Summary: Add routing list tab to the patron account in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 11:31:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 09:31:18 +0000
Subject: [Koha-bugs] [Bug 20456] Remove the
	C4::Serials::GetSubscriptionsFromBorrower
In-Reply-To: <bug-20456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20456-70-gT8zoFQ1H7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.05.x for 18.05.02

Thanks guys, I've made the decision to port this one back as it only just
missed the 18.05.00 release due to string changes and doesn't fundamentally
change functionality but rather tidies up code.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 11:32:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 09:32:15 +0000
Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to
	configuration files
In-Reply-To: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20073-70-kgpiRdzF3v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |glasklas at gmail.com

--- Comment #53 from David Gustafsson <glasklas at gmail.com> ---
Great!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 11:33:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 09:33:10 +0000
Subject: [Koha-bugs] [Bug 19820] Add unsafe param to GetMarcSubfieldStructure
In-Reply-To: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19820-70-ebHRucRAV2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19820

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Agreed, lets not backport this one :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 11:37:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 09:37:50 +0000
Subject: [Koha-bugs] [Bug 20339] Unify MARC21 ISBN/ISSN handling in XSL
In-Reply-To: <bug-20339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20339-70-rRZZnj1gIj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20339

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |CLOSED

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement, not backporting for 18.05.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 12:04:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 10:04:54 +0000
Subject: [Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with
 C4::Context->temporary_directory
In-Reply-To: <bug-20727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20727-70-CqlHcTwqsh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Architectural enhancement, not backporting for 18.05.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 12:05:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 10:05:42 +0000
Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background
 jobs run in Plack mode
In-Reply-To: <bug-17240-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17240-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17240-70-4eliTbvBLb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17240

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55137|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 12:06:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 10:06:04 +0000
Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background
 jobs run in Plack mode
In-Reply-To: <bug-17240-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17240-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17240-70-YIhDAKekUa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17240

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63862|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 12:06:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 10:06:07 +0000
Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background
 jobs run in Plack mode
In-Reply-To: <bug-17240-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17240-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17240-70-5KzsJYYN0l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17240

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58461|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 12:06:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 10:06:11 +0000
Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background
 jobs run in Plack mode
In-Reply-To: <bug-17240-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17240-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17240-70-PbqUspvOzP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17240

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55257|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 12:06:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 10:06:15 +0000
Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background
 jobs run in Plack mode
In-Reply-To: <bug-17240-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17240-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17240-70-jt0o3thudG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17240

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55138|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 12:07:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 10:07:14 +0000
Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background
 jobs run in Plack mode
In-Reply-To: <bug-17240-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17240-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17240-70-EfGh6vwDgH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17240

--- Comment #18 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 76477
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76477&action=edit
Bug 17240: (prepare) Allow processes that rely on background jobs run in Plack
mode

This adds prepares the main one by adding method "is_psgi" to C4::Context and
using it in C4::Auth for all templates.
It is used by about.pl and Koha::AuthUtils.

Test plan :
- On a Koha running with Plack
- Go to about.pl
- Look at line "PGSI:"
=> You should see "Plack"
- Enable CAS authentication
- Go to OPAC auth page
- Look at the CAS link
=> You see the current page in this URL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 12:07:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 10:07:32 +0000
Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background
 jobs run in Plack mode
In-Reply-To: <bug-17240-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17240-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17240-70-iQPfZH2Um0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17240

--- Comment #19 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 76478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76478&action=edit
Bug 17240: Allow processes that rely on background jobs run in Plack mode

Since Plack mode (PSGI), the processes running with background jobs are broken.

Bug 15218 corrected by using CGI mode for concerned pages.

This patch proposes to allow running those pages in PSGI mode by disabling
background jobs when PSGI is used.

Script are running so faster with Plack, there are less chances that the
process will end in HTTP timeout.

Test plan :
 - on a Koha running with plack
 - revert Bug 15218 changes
 - test processes on pages :
     offline_circ/process_koc.pl
     tools/batchMod-edit.pl
     tools/batch_record_modification.pl
     tools/manage-marc-import.pl
     tools/stage-marc-import.pl
     tools/upload-images.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 12:07:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 10:07:48 +0000
Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background
 jobs run in Plack mode
In-Reply-To: <bug-17240-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17240-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17240-70-v3SUDhzKGh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17240

--- Comment #20 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 76479
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76479&action=edit
Bug 17240: (followup 1) Allow processes that rely on background jobs run in
Plack mode

Followup
If not running in background mode, some calls are made on $job var.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 12:08:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 10:08:04 +0000
Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background
 jobs run in Plack mode
In-Reply-To: <bug-17240-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17240-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17240-70-YyhelAwYwN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17240

--- Comment #21 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 76480
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76480&action=edit
Bug 17240: (followup 2) Allow processes that rely on background jobs run in
Plack mode

Followup 2
If not running in background mode, some calls are made on $job var in
tools/batch_record_modification.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 12:08:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 10:08:22 +0000
Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background
 jobs run in Plack mode
In-Reply-To: <bug-17240-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17240-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17240-70-QRBBCfSYAQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17240

--- Comment #22 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 76481
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76481&action=edit
Bug 17240: (followup 3) Allow processes that rely on background jobs run in
Plack mode

Followup 3
If not running in background mode, items are not displayed in result page in
tools/batchMod.pl.
Also the number of items and fields are missing in message.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 12:08:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 10:08:37 +0000
Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background
 jobs run in Plack mode
In-Reply-To: <bug-17240-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17240-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17240-70-6kcnLIuwZ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17240

--- Comment #23 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 76482
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76482&action=edit
Bug 17240: (followup 4) Allow processes that rely on background jobs run in
Plack mode

Items batch deletion failed because after action, unlike batch modification,
items are not displayed so code must not call BuildItemsData().

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 12:12:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 10:12:27 +0000
Subject: [Koha-bugs] [Bug 18973] Auto focus the ISBN field
In-Reply-To: <bug-18973-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18973-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18973-70-gOSHgMv2fn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18973

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         Resolution|---                         |FIXED

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement, not backporting for 18.05.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 12:26:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 10:26:28 +0000
Subject: [Koha-bugs] [Bug 20876] The form_serialized_itype cookie is not
 used and should be removed
In-Reply-To: <bug-20876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20876-70-gpyhU4OBaW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20876

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.05.x for 18.05.02

With GDPR wipping everyone up into a frenzy at the moment, this one seemed
pertinent to backport.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 12:29:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 10:29:14 +0000
Subject: [Koha-bugs] [Bug 20676] svc/barcode should allow barcode to be
 printed without text
In-Reply-To: <bug-20676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20676-70-6ppOuzOm5b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement, not backporting for 18.05.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 12:32:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 10:32:40 +0000
Subject: [Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9
	numbers are used
In-Reply-To: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20972-70-rl7xyUnhkq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.05.x for 18.05.02

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 12:36:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 10:36:00 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth in combination with LDAP as an
 alternative no longer works
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-oxrHX1yq84@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.05.x for 18.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 12:38:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 10:38:32 +0000
Subject: [Koha-bugs] [Bug 20864] Only set bibs_selected cookie when
 BrowseResultSelection is activated
In-Reply-To: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20864-70-G1GurJiUDr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.05.x for 18.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 12:43:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 10:43:55 +0000
Subject: [Koha-bugs] [Bug 18521] Renew and search hotkeys are swapped on
	returns page.
In-Reply-To: <bug-18521-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18521-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18521-70-x22oCSo2m7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18521

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.05.x for 18.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 12:51:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 10:51:57 +0000
Subject: [Koha-bugs] [Bug 20867] Ability to show membership renewal date on
 moremember.pl page
In-Reply-To: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20867-70-wzHjXYPkrZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pushed to 18.05.x for 18.05.02

Trivial enhancement I'm treating as a bugfix, backported, thanks Amit.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 12:54:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 10:54:34 +0000
Subject: [Koha-bugs] [Bug 20744] Replace staff client header Koha logo gif
 with transparent png
In-Reply-To: <bug-20744-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20744-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20744-70-THvlzxwOum@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20744

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Enhancement, won't be backported.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 13:13:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 11:13:09 +0000
Subject: [Koha-bugs] [Bug 21006] GetMarcBiblio is slow for records with many
	items
In-Reply-To: <bug-21006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21006-70-qLXjDka4kC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|GetMarcBiblio is slow for   |GetMarcBiblio is slow for
                   |records with many bibs      |records with many items

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 13:15:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 11:15:27 +0000
Subject: [Koha-bugs] [Bug 17921] Shelf Browser does not take OpacSuppression
 or OpacHiddenItems into consideration
In-Reply-To: <bug-17921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17921-70-1Vlefnc9YK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17921

Lucy Vaux-Harvey <lucy.vaux-harvey at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucy.vaux-harvey at ptfs-europ
                   |                            |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 13:56:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 11:56:01 +0000
Subject: [Koha-bugs] [Bug 21004] Use modal to add and edit notes on
 receiving orders/shipments page
In-Reply-To: <bug-21004-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21004-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21004-70-T47tsB3Rj5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21004

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 14:18:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 12:18:31 +0000
Subject: [Koha-bugs] [Bug 20585] Label surname as name for organisation type
	patrons
In-Reply-To: <bug-20585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20585-70-am6VQ2ahHy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20585

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 14:19:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 12:19:37 +0000
Subject: [Koha-bugs] [Bug 20585] Label surname as name for organisation type
	patrons
In-Reply-To: <bug-20585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20585-70-MT37rRgqZf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20585

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76419|0                           |1
        is obsolete|                            |

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76483
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76483&action=edit
Bug 20585: Label surname as name for organisation type patrons

This patch modifies the patron edit page so that the label for an
organization name is "Name" instead of "Surname."

To test, apply the patch and edit both an institutional patron and a
regular patron. Confirm that the name/surname label is correct in each
case.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 14:19:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 12:19:34 +0000
Subject: [Koha-bugs] [Bug 20585] Label surname as name for organisation type
	patrons
In-Reply-To: <bug-20585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20585-70-eOhz9usvaM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20585

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 14:28:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 12:28:32 +0000
Subject: [Koha-bugs] [Bug 20520] Re-indent moremember.tt
In-Reply-To: <bug-20520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20520-70-IiI36DbwKt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75745|0                           |1
        is obsolete|                            |

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76484
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76484&action=edit
Bug 20520: Re-indent moremember.tt

This patch reindents the template for the patron detail page,
moremember.tt:

- Trailing spaces removed
- Indentation changed to a consistent 4 spaces
- Markup indentation made more consistent

To test, view the patron detail page. There should be no visible
difference before and after the applying the patch.

HTML validation before and after the patch should return the same
results.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 14:28:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 12:28:45 +0000
Subject: [Koha-bugs] [Bug 20520] Re-indent moremember.tt
In-Reply-To: <bug-20520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20520-70-P9rgDHJope@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520

--- Comment #9 from Owen Leonard <oleonard at myacpl.org> ---
Rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 14:53:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 12:53:20 +0000
Subject: [Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin
 integration into catalogue
In-Reply-To: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20968-70-MD0Q1bq2DB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 14:54:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 12:54:09 +0000
Subject: [Koha-bugs] [Bug 21006] GetMarcBiblio is slow for records with many
	items
In-Reply-To: <bug-21006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21006-70-JC1hIJriVJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Could you provide a patch with only the relevant changes (i.e. without
indentation changes)?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 14:57:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 12:57:59 +0000
Subject: [Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin
 integration into catalogue
In-Reply-To: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20968-70-uHOMZGTzF8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
I see a few issues the shouldn't be hard to resolve:
1) Unit tests ( they are super simple, but should be there anyway )
2) Why test for the method intranet_catalog_biblio_enhancements, but then call
the method get_toolbar_button? A) You can check for the method
get_toolbar_button directly, and B) You are calling get_toolbar_button twice
per plugin, which seems like waste of cycles.
3) After resolving 1 and 2, could you also make pull request to the kitchen
sink plugin (https://github.com/bywatersolutions/koha-plugin-kitchen-sink) to
add an example to it? That plugin is basically out documentation for the plugin
system's functionality at this time.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 14:58:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 12:58:47 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-h0ci3VfoAc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73704|0                           |1
        is obsolete|                            |

--- Comment #6 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 76485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76485&action=edit
Bug 20447: MARC Holdings support

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:00:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:00:23 +0000
Subject: [Koha-bugs] [Bug 20898] Replace OPAC detail's results browser with
 non-JavaScript version
In-Reply-To: <bug-20898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20898-70-CNbdyfnIRS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20898

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75919|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76486&action=edit
Bug 20898 - Replace OPAC detail's results browser with non-JavaScript version

This patch moves generation of the OPAC detail page's results browser
from JavaScript to the template. This makes the template easier to
understand and easier to debug. It also makes it possible for the widget
to be completely non-dependent on JavaScript.

To test, apply the patch and regenerate the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_Bootstrap_OPAC_LESS_files).

 - Enable the OpacBrowseResults system preference and perform a search
   in the OPAC which will return multiple results.
 - Click on any title in the first page of search results.
 - On the bibliographic detail page there should be a "Browse results"
   link in the right-hand sidebar just as before.
   - Test that the "Previous," "Back to results," and "Next" links work
     correctly.
   - Click the "Browse results" link. A list of the first 20 search
     results should appear. An arrow should indicate the title you're
     viewing.
   - Click any title in the results browser. The page should correctly
     load that record.
   - Clicking the numbered links at the top of the results browser
     should do the same.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:02:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:02:13 +0000
Subject: [Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin
 integration into catalogue
In-Reply-To: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20968-70-NTussUFrRk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
4) I forgot to make explicit that it seems like the method
intranet_catalog_biblio_enhancements is not really necessary and should be
removed and replaced with a GetPlugins call for get_toolbar_button instead.

5) Can you make the method names a bit more explicit? I think
get_opac_toolbar_button would be better than get_toolbar_button so future
developers have a bit better an idea what it does without further research.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:09:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:09:25 +0000
Subject: [Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin
 integration into catalogue
In-Reply-To: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20968-70-GKzv0DkoOa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
On further inspection, I go with something even more specific,
get_opac_catalog_toolbar_button, which completely disambiguates where this
button will appear.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:10:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:10:15 +0000
Subject: [Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin
In-Reply-To: <bug-10659-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10659-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10659-70-TGiYRhtBEH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76049|0                           |1
        is obsolete|                            |
  Attachment #76050|0                           |1
        is obsolete|                            |
  Attachment #76051|0                           |1
        is obsolete|                            |

--- Comment #9 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76487&action=edit
Bug 10659: Upgrade jQuery star ratings plugin

This patch replaces our current jQuery star ratings plugin with a newer
plugin which will be compatible with newer versions of jQuery:

http://antenna.io/demo/jquery-bar-rating/examples/

To test you should have one or more records in your catalog with star
ratings.

- Apply the patch and set the OpacStarRatings system preference
  to "results and details"
- Perform a search in the catalog which will return one or more titles
  which have ratings.
  - Confirm that the ratings appear correctly and the ratings are
    read-only.
- Open the "normal" detail page for that record.
  - Confirm that the star rating appears correctly.
  - Test setting and re-setting your star rating. Confirm that it is
    saved.
  - Confirm that the "cancel rating" link appears when you have a rating
    set, and that it disappears after you click it.
- Test that the "only details" and disabled options of the
  OpacStarRatings preference work as they should.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:10:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:10:18 +0000
Subject: [Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin
In-Reply-To: <bug-10659-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10659-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10659-70-zFnI0m0qWq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659

--- Comment #10 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76488&action=edit
Bug 10659: (follow-up) Add plugin information to the about page

This patch updates the about page in the staff client, replacing the
information about the jQuery Star Ratings plugin with information about
the new jQuery Bar Ratings plugin.

To test, apply the patch and go to the about page in the staff client.
Confirm that the new information appears correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:10:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:10:21 +0000
Subject: [Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin
In-Reply-To: <bug-10659-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10659-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10659-70-1SwA9Kzuti@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659

--- Comment #11 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76489&action=edit
Bug 10659: (follow-up) Compiled CSS

This patch contains the compiled CSS.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:15:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:15:40 +0000
Subject: [Koha-bugs] [Bug 21006] GetMarcBiblio is slow for records with many
	items
In-Reply-To: <bug-21006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21006-70-uFu9amJI0l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76475|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 76490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76490&action=edit
Bug 21006: Add GetMarcItems method and refactor GetMarcBiblio

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:18:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:18:05 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-9bZbgYHLTa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:18:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:18:59 +0000
Subject: [Koha-bugs] [Bug 7547] Printing a sorted cart
In-Reply-To: <bug-7547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7547-70-zyKCPyuWo7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |josef.moravec at gmail.com
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:20:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:20:35 +0000
Subject: [Koha-bugs] [Bug 7547] Printing a sorted cart
In-Reply-To: <bug-7547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7547-70-fvkfy4E4Cu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76418|0                           |1
        is obsolete|                            |

--- Comment #10 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76491&action=edit
Bug 7547: printing a sorted cart

This patch adds a DataTables-generated print button to the OPAC cart. To
make that process easier, the DataTables plugin has been upgraded to the
latest version (1.10.18) with the Buttons plugin included.

Changes to the OPAC LESS file style the DataTables button to look like
the static version.

Other templates in the OPAC which use the DataTables plugin have been
modified to use up-to-date option names.

To test, apply the patch and add several titles to the cart.

 - Open the cart
 - Re-sort the cart using something other than the default sort
 - Click the 'Print' button.
   - A print view should open in a separate window, sorted correctly,
     and automatically show the print dialog.
 - Click the cart's 'More details' button and click the print button.
   - This should trigger the print dialog directly.

 - Test DataTables sorting on other modified pages:
    - Bibliographic detail page (holdings table)
    - Course reserves (table of courses)
      - Course details (table of titles)
    - Full subscription history
      - Detail page for a subscription -> More details -> Full history
    - Most popular
    - Purchase suggestions
    - Self checkouts
    - Tag cloud
    - Your fines
    - Your interlibrary loan requests
    - Your reading history
    - Your search history
    - Your search IDREF for ppn (I don't know how to test this)

The DataTables plugin is removed from "Your routing lists" and Self
check-in because it is unused.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:20:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:20:40 +0000
Subject: [Koha-bugs] [Bug 7547] Printing a sorted cart
In-Reply-To: <bug-7547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7547-70-TYe86rcDP2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547

--- Comment #11 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76492&action=edit
Bug 7547: (QA follow-up) Make button background transparent for consistency

Test plan:
Add some records to cart in opac and show the cart, look at the print
button/link
--> without patch it has darker background than other buttons
--> with this patch it has the same background

Note: tested wir firefox 45, firefox 60 and chromium 66

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:20:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:20:31 +0000
Subject: [Koha-bugs] [Bug 7547] Printing a sorted cart
In-Reply-To: <bug-7547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7547-70-Ix1ytqA1KP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:37:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:37:28 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-98RHTCxlve@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:37:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:37:32 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-kBejCD6QEX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76256|0                           |1
        is obsolete|                            |
  Attachment #76257|0                           |1
        is obsolete|                            |
  Attachment #76258|0                           |1
        is obsolete|                            |
  Attachment #76259|0                           |1
        is obsolete|                            |
  Attachment #76260|0                           |1
        is obsolete|                            |
  Attachment #76261|0                           |1
        is obsolete|                            |
  Attachment #76262|0                           |1
        is obsolete|                            |
  Attachment #76263|0                           |1
        is obsolete|                            |
  Attachment #76264|0                           |1
        is obsolete|                            |
  Attachment #76265|0                           |1
        is obsolete|                            |
  Attachment #76266|0                           |1
        is obsolete|                            |
  Attachment #76267|0                           |1
        is obsolete|                            |
  Attachment #76268|0                           |1
        is obsolete|                            |
  Attachment #76269|0                           |1
        is obsolete|                            |
  Attachment #76270|0                           |1
        is obsolete|                            |
  Attachment #76271|0                           |1
        is obsolete|                            |
  Attachment #76272|0                           |1
        is obsolete|                            |
  Attachment #76273|0                           |1
        is obsolete|                            |
  Attachment #76274|0                           |1
        is obsolete|                            |
  Attachment #76275|0                           |1
        is obsolete|                            |
  Attachment #76276|0                           |1
        is obsolete|                            |
  Attachment #76277|0                           |1
        is obsolete|                            |

--- Comment #159 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76493&action=edit
Bug 20271: merging delete biblio/items

The present bug merges the following tables:
deletedbiblio          -> biblio
deletedbiblioitems     -> biblioitems
deletedbiblio_metadata -> biblio_metadata
deleteditems           -> items

and adds a column deleted_at to signify time of deletion, if deleted

it replaces all occurrences of the mentioned occurences and uses
of mentioned deleted* tables

upgrade is handled by moving rows from deleted* tables to the live
ones. If all rows are moved, the corresponding tables are dropped.
If there are duplicates or conflicts (duplicate barcodes e.g.) they
reminders are left for scrutiny and table renamed to _deleted*

Test plan:

1) Make sure you have a db with at least a few deleted biblios,
   biblioitems and items.
2) Apply patch and run updatedatabase.pl
3) Make note of the db upgrade messages, if you get a message like:
   There were x deleteditems that could not be moved, please check
_deleteditems
   you should check the _deleteditems table and verify that they are
   actual conflicts
4) Click around in the web interface and make sure you can delete items
   and biblios
5) "Undelete" an item by NULLing the deleted_at column for an item
   and verify that it returns in interface (Not neccessary really)

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:37:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:37:38 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-ZwdaHSq9MH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #160 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76494
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76494&action=edit
Bug 20271: fix remaining tests

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:37:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:37:43 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-11y8Ylik3s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #161 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76495&action=edit
Bug 20271: update kohastructure.sql

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:37:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:37:49 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-RJUV1kE1DZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #162 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76496&action=edit
Bug 20271: delete biblio and biblio_metadata in one go

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:37:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:37:54 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-J4W45NpE39@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #163 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76497&action=edit
Bug 20271: remove comments regarding deleteditems and -biblio*

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:37:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:37:59 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-9m2OPWoBxD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #164 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76498&action=edit
Bug 20271: add atomic update

Bug 20271: disable foreign keys on deletedbiblio_metadata

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:38:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:38:05 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-NbIJhbWxqQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #165 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76499&action=edit
Bug 20271: Use a single pass in the OAI-PMH provider

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:38:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:38:10 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-TEAXugI9cY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #166 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76500&action=edit
Bug 20271: fix whitespace issues in C4::Items

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:38:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:38:15 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-QC7U1nUKiI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #167 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76501&action=edit
Bug 20271: print instead of warn unmovable items

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:38:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:38:21 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-mGhp91PFVJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #168 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76502
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76502&action=edit
Bug 20271: atomicupdate - support mysql < 5.7 and address foreign key issues

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:38:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:38:26 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-xKtiBNhIbm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #169 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76503
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76503&action=edit
Bug 20271: (follow-up) DBIx schema changes

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:38:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:38:32 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-czwkS4KfwB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #170 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76504
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76504&action=edit
Bug 20271: (QA follow-up): rename to deleted_on and various fixes

- renamed deleted_at => deleted_on
- removed failing sql in t/db_dependent/OAI/Server.t
- removed deprecated autoincrement checks in about.pl
- fixed errors in catalogue_stats.tt and catalogue_stats.pl

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Removed the DBIx schema changes. Please keep them separated.
We missed changes for Biblioitem btw. Adding them in follow-up.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:38:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:38:37 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-G9kB9vCHRt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #171 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76505
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76505&action=edit
Bug 20271: (QA follow-up) DBIx schema changes

Please separate these changes from the other patches.
Note that Biblioitem was not in the last set of changes too.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:38:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:38:43 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-blYm5n5GZ5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #172 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76506
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76506&action=edit
Bug 20271: (QA follow-up) Additional about cleanup

Still found references to biblios and items in script and template.

Test plan:
Check about page again.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:38:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:38:48 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-WbdbHkQGZ4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #173 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76507&action=edit
Bug 20271: (QA follow-up) Remove last occurrences of deleted_at

Trivial replace of deleted_at by deleted_on.

Test plan:
Run t/db_dependent/Koha/ItemTypes.t
Run t/db_dependent/Items_DelItemCheck.t
git grep -E "deleted_at\W"

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:38:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:38:53 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-p260L7oH0r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #174 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76508
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76508&action=edit
Bug 20271: (QA follow-up) Reword OAI-PMH:DeletedRecord systempref

The preference still refered to the deletedbiblio table made defunct by
this patchset.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:38:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:38:59 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-58q96GlHWz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #175 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76509&action=edit
Bug 20271: (QA follow-up) Make the atomicupdate idempotent

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:39:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:39:05 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-Ek2ncRR80r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #176 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76510
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76510&action=edit
Bug 20271: (QA follow-up) Restore original GetItem functionality

The return value of GetItem had been changed (as it would now return
deleted items as well as current items). This patch restores the
original functionality (as we've not catered for all calls to GetItem
independantly), restores the original test as well as adding a further
test to catch the correct setting of deleted_on by DelItem

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:39:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:39:10 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-vMFTAIGy0W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #177 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76511
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76511&action=edit
Bug 20271: (QA follow-up) Fix catalogue statistics in reports module

Test plan:
1) Have some deleted and some not deleted items
2) Use catalogue statistics in reports module and try to filter
total/deleted items
--> without this patch the deleted options returns not deleted items and
total returns deleted items
--> with this patch you should be able to filter the results to deleted,
    not deleted and all items and everyone of this filter should work

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:39:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:39:16 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-YI8Totupum@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #178 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76512
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76512&action=edit
Bug 20271: (QA follow-up) Zebra should not index deleted record when doing full
reindex

Test plan:
Run koha-rebuild-zebra -f [instance]
--> without patch the deleted records are indexed and shown when
searching
--> with this patch the deleted records are not indexed

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:39:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:39:21 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-5QmHL51RdW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #179 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76513&action=edit
Bug 20271: (QA follow-up) Does not return deleted record in GetMarcBiblio

Test plan:
Go to url /cgi-bin/koha/catalogue/detail.pl?biblionumber=[deleted
biblionumber]
--> without patch you see the deleted record
--> with patch you should see message "The record you requested does not
exist"

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:39:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:39:27 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-11mKfQTi8B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #180 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76514&action=edit
Bug 20271: (QA follow-up): Fix test ModBiblioMarc

Test plan:
prove t/db_dependent/Biblio/ModBiblioMarc.t

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:40:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:40:23 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-MIxyC1Vy9r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #181 from Josef Moravec <josef.moravec at gmail.com> ---
Rebased on master, there was conflict in C4/Items.pm because of bug 20702

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:55:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:55:06 +0000
Subject: [Koha-bugs] [Bug 21001] OpenLibrary book covers broken
In-Reply-To: <bug-21001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21001-70-qoAF1KMDaI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21001

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I suspect a bug on their side:

The answer of:
https://openlibrary.org/api/books?bibkeys=ISBN%3A067002662X%2CISBN%3A1847727808%2CISBN%3A1780335792&callback=KOHA.OpenLibrary.olCallBack&jscmd=data

is:
KOHA.OpenLibrary.olCallBack(KOHA.OpenLibrary.olCallBack({"ISBN:067002662X":
{"publish_date": "2013", [SKIP]

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:56:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 13:56:23 +0000
Subject: [Koha-bugs] [Bug 17921] Shelf Browser does not take OpacSuppression
 or OpacHiddenItems into consideration
In-Reply-To: <bug-17921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17921-70-YMlly2FUz6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17921

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:02:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 14:02:33 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20978-70-vlvcmRxAkS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978

--- Comment #20 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76515&action=edit
Bug 20978: (follow-up) POD completeness

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:04:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 14:04:59 +0000
Subject: [Koha-bugs] [Bug 20998] Non superlibrarians cannot search for
 patrons using the quicksearch at the top
In-Reply-To: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20998-70-lI5Qqhlyrr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:07:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 14:07:30 +0000
Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to
	configuration files
In-Reply-To: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20073-70-DrwofoN7XF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

--- Comment #54 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Nick, DBIC schema has not been updated.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:18:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 14:18:01 +0000
Subject: [Koha-bugs] [Bug 17869] Don't show pick-up library for list of
 holds in OPAC account when there is only one branch
In-Reply-To: <bug-17869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17869-70-MISNccPLSJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76252|0                           |1
        is obsolete|                            |

--- Comment #11 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76516&action=edit
Bug 17869: Don't show pick-up library for list of holds in OPAC account when
there is only one branch

This patch modifies the user summary page in the OPAC so that the
"pick up location" column isn't shown in the table of holds if there is
only one library defined.

To test, apply the patch and log into the OPAC as a user with one or
more holds.

 - In a system with more than one library defined the "Holds" tab of
   opac-user.pl should show a "Pick up location" column.

 - In a system with only one library defined there should be now "Pick
   up location" column.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:18:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 14:18:20 +0000
Subject: [Koha-bugs] [Bug 17869] Don't show pick-up library for list of
 holds in OPAC account when there is only one branch
In-Reply-To: <bug-17869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17869-70-xJtJh40Xai@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:17:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 14:17:57 +0000
Subject: [Koha-bugs] [Bug 17869] Don't show pick-up library for list of
 holds in OPAC account when there is only one branch
In-Reply-To: <bug-17869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17869-70-Luj2zGnmtK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:20:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 14:20:49 +0000
Subject: [Koha-bugs] [Bug 20998] Non superlibrarians cannot search for
 patrons using the quicksearch at the top
In-Reply-To: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20998-70-lMnjv4Wibr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76466|0                           |1
        is obsolete|                            |

--- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76517&action=edit
Bug 20998: Only perform quicksearch if patron found with cardnumber

This patch makes sure we have a patron before we try to access their
branchcode and allows search to work

To recreate:
1 - Enable 'IndependentBranches'
2 - Setup a patron with all permissions, but not a superlibrarian
3 - Login to staff client as that patron
4 - Click 'Patrons' in the toolbar and try a search
5 - Internal server error
6 - Apply patch
7 - Try the search again
8 - Success!

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:20:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 14:20:54 +0000
Subject: [Koha-bugs] [Bug 20998] Non superlibrarians cannot search for
 patrons using the quicksearch at the top
In-Reply-To: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20998-70-hJJBcMPFb5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76467|0                           |1
        is obsolete|                            |

--- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76518&action=edit
Bug 20998: Simplify the conditional statement

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:21:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 14:21:17 +0000
Subject: [Koha-bugs] [Bug 20998] Non superlibrarians cannot search for
 patrons using the quicksearch at the top
In-Reply-To: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20998-70-y54KYNj75F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:22:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 14:22:44 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-9P9noqWGfW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|Trivial patch               |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:22:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 14:22:47 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-GSLs2wvM21@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

--- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 76519
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76519&action=edit
Bug 20946: (RM follow-up) Additional tests and fix addition to undef

Added a few tests with credit lines and found we got warnings, adjusted
the routine to avoid this

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:33:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 14:33:04 +0000
Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to
	configuration files
In-Reply-To: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20073-70-M3xaVPceHA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073

--- Comment #55 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 76520
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76520&action=edit
Bug 20073: (RM follow-up) Update schema files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:43:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 14:43:08 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-kVyCukS0CA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76521&action=edit
Bug 20946: Avoid summing the list twice

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:49:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 14:49:04 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-4nEiwm1P4s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #182 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Quick test:
- check an item out, then check it in
- delete the item

1. on /members/readingrec.pl?borrowernumber=51
a) before "This patron has no circulation history."
b) after we see a table with all item's info

2. on /catalogue/issuehistory.pl?biblionumber=42
a) before "Amy's diary, by Lee has never been checked out."
b) after "Checked out 1 times" with the table (and a barcode with a link to the
item)

Same if we remove the bibliographic record.

3. Perform a search, /catalogue/search.pl?q=d
the search result will display "1 item, 1 available" in the "Location" column
whereas there are no more items for this bibliographic record.

I did not see anything about these changes in the previous comments, and it
seems that we lack a proper test plan.

What about acquisition module? Fines? Authority ("used in X"), etc?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:51:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 14:51:29 +0000
Subject: [Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin
 integration into catalogue
In-Reply-To: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20968-70-CimBQmdcMd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #6 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Hi Kyle

Many thanks for this feedback, very helpful indeed.

1) Yes indeed, I completely overlooked tests, I'll address this.
2) Good point, well spotted. I'll fix this.
3) Yes, will do
4) I'm not clear whether you're suggesting we should ditch the
intranet_catalog_biblio_enhancements method entirely. I don't think we can do
this as we need to be able to test in plugins-home.pl/.tt for plugins that are
within this class. If you just meant I should drop it from detail.pm as
mentioned in 2), yes, I will do this.
5) Yes, good idea, will do

Thanks again. I'll update here once this is all done.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:58:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 14:58:57 +0000
Subject: [Koha-bugs] [Bug 18580] Account-pay does not apply credits / clear
 old fines as did recordpayment
In-Reply-To: <bug-18580-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18580-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18580-70-8Qp9MAXTOV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18580

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20997
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:58:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 14:58:57 +0000
Subject: [Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
In-Reply-To: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20997-70-iqTTkx6tmS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=18580

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:59:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 14:59:57 +0000
Subject: [Koha-bugs] [Bug 21006] GetMarcBiblio is slow for records with many
	items
In-Reply-To: <bug-21006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21006-70-mpxfW4T0C2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
just to add, testing with a bib with 50,000 items I saw the time for a call to
GetMarcBiblio (with embed_items) go from ~135 seconds to ~18 seconds

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 17:16:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 15:16:39 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-EOsvvMW9ko@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76519|0                           |1
        is obsolete|                            |
  Attachment #76521|0                           |1
        is obsolete|                            |

--- Comment #15 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76522&action=edit
Bug 20946: (RM follow-up) Additional tests and fix addition to undef

Added a few tests with credit lines and found we got warnings, adjusted
the routine to avoid this

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 17:22:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 15:22:27 +0000
Subject: [Koha-bugs] [Bug 20554] New OPAC CSS
In-Reply-To: <bug-20554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20554-70-kdXoNp5YF3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74716|0                           |1
        is obsolete|                            |
  Attachment #74717|0                           |1
        is obsolete|                            |

--- Comment #12 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76523
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76523&action=edit
Bug 20554: (follow-up) Add local font files and add method for loading them

This patch adds local copies of the font files specified in the original
patch. A new JavaScript file has been added, fontfaceobserver.min.js,
which helps gracefully load font assets.

https://github.com/bramstein/fontfaceobserver

Information about the new assets has been added to the about page.

When using web fonts, there can be a delay, while the browser loads the
font files, between the time the page loads and the time the fonts
render. Font Face Observer allows us to specify a default font for the
initial page render, and then apply the web font after it has loaded.

To test, apply the patch and regenerate the OPAC css. View any page in
the OPAC and confirm that the custom font renders properly.

View the About page in the staff client and confirm that the new license
information looks correct.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 17:22:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 15:22:31 +0000
Subject: [Koha-bugs] [Bug 20554] New OPAC CSS
In-Reply-To: <bug-20554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20554-70-w1yOLN4l80@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554

--- Comment #13 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76524
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76524&action=edit
Bug 20554: (follow-up) Compiled CSS

This patch includes the compiled CSS.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 17:23:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 15:23:09 +0000
Subject: [Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits
In-Reply-To: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20990-70-mpEZTLF876@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 17:23:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 15:23:14 +0000
Subject: [Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits
In-Reply-To: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20990-70-9DmMueqimc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76449|0                           |1
        is obsolete|                            |

--- Comment #10 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76525
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76525&action=edit
Bug 20990: Make same changes that were made to outstanding_debits

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 17:27:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 15:27:11 +0000
Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout
 form, with collapsed settings panel
In-Reply-To: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20959-70-59apiYYkib@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 17:27:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 15:27:15 +0000
Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout
 form, with collapsed settings panel
In-Reply-To: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20959-70-Qu0RAzJQEl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76139|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76526
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76526&action=edit
Bug 20959: Style checkin form more like the checkout form, with collapsed
settings panel

This patch modifies the structure of the checkin form so that settings
(Specify return date, book drop mode, forgive overdue charges) are in a
collapsed panel when inactive. The style of the barcode field and the
mode notification messages has been changed to reduce the vertical
motion of the form when selecting options.

Some class names have been changed in circulation.tt and circulation.js
to make them appropriate for use on both forms.

To test, apply the patch and clear your browser cache if necessary.

 - View the checkin page. The "checkin settings" panel should be
   collapsed by default.
 - Confirm that the settings panel collapses and expands as it should.
 - Confirm that selecting "Forgive overdue charges" or "Book drop mode"
   trigger the display of the correct message and that the style of the
   barcode field is changed.
 - Confirm that after submitting a barcode for check-in, the
   settings panel stays open and your selected settings are still
   selected.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 17:41:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 15:41:33 +0000
Subject: [Koha-bugs] [Bug 20792] Can't go to patron record with
	TranslateNotices active
In-Reply-To: <bug-20792-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20792-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20792-70-phUyAuzMhN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20792

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 17:42:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 15:42:58 +0000
Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface
In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20935-70-EyJHoRpcRS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

--- Comment #7 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 76097
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76097
Bug 20935: Redesign system preferences interface

Review of attachment 76097:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20935&attachment=76097)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt
@@ +156,5 @@
> +        </div> <!-- /.col-sm-10.col-sm-push-2 -->
> +
> +        <div class="col-sm-2 col-sm-pull-10">
> +            <aside>
> +                [% INCLUDE 'admin-menu.inc' %]

should be prefs-menu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 17:44:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 15:44:18 +0000
Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface
In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20935-70-z9IRw5d1qW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #8 from Josef Moravec <josef.moravec at gmail.com> ---
Also, the "Local use" preferences are not addressed in this patch

But great work Owen, I like this style!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 17:50:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 15:50:26 +0000
Subject: [Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin
 integration into catalogue
In-Reply-To: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20968-70-pYBcHbBQli@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #7 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Hi Kyle

Looking at 1), I'm not sure writing tests for this tiny amount of core
integration is even possible. All we're doing is populating a template
parameter under a certain condition, I don't think we can meaningfully test
that.

Any thoughts?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 17:52:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 15:52:22 +0000
Subject: [Koha-bugs] [Bug 10348] Show number of items on tab headings in the
	staff client
In-Reply-To: <bug-10348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10348-70-JsGjkXWc8k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10348

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 17:52:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 15:52:26 +0000
Subject: [Koha-bugs] [Bug 10348] Show number of items on tab headings in the
	staff client
In-Reply-To: <bug-10348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10348-70-jPD9FtxmXW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10348

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76417|0                           |1
        is obsolete|                            |

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76527
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76527&action=edit
Bug 10348: Show number of items on tab headings in the staff client

This patch uses Template Toolkit's size() method to add a count to
the bibliographic detail page's holdings and images tabs.

To test, apply the patch and view the detail page for a record in
the staff client. Check under the following conditions:

- The SeparateHoldings system preference is set to "Don't separate"
  - The holdings tab should show the correct item count.
- The SeparateHoldings system preference is set to "Separate"
  - The "[Library] holdings" tab and "Other holdings" tabs should
    have the correct item counts.
- With LocalCoverImages enabled the "Images" tab should show the
  correct count of attached images. Test with zero or more attached
  images.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 17:59:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 15:59:16 +0000
Subject: [Koha-bugs] [Bug 21007] New: Add new patron column for date of last
 successful login attempt
Message-ID: <bug-21007-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21007

            Bug ID: 21007
           Summary: Add new patron column for date of last successful
                    login attempt
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: bibliwho at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

The (deleted)borrowers tables includes a column for failed login attempts
(login_attempts).

A similar column for date of last successful login would help libraries
identify which patrons are & are not taking advantage of the extra features
available through their personal accounts.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 17:59:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 15:59:35 +0000
Subject: [Koha-bugs] [Bug 20559] Occurrences of loading-small.gif still exist
In-Reply-To: <bug-20559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20559-70-7Qpi2RavCW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 17:59:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 15:59:38 +0000
Subject: [Koha-bugs] [Bug 20559] Occurrences of loading-small.gif still exist
In-Reply-To: <bug-20559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20559-70-Csb3rorVh7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76385|0                           |1
        is obsolete|                            |
  Attachment #76386|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76528
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76528&action=edit
Bug 20559: Occurrences of loading-small.gif still exist

This patch removes some leftover references to a file which no longer
exists. In the OPAC, loading-small.gif was included in CSS which was
never used. In the staff client, loading-small.gif should have been
corrected to spinner-small.gif.

To test, apply the patch and go to Tools -> Batch record modification.

 - Submit a batch of records to modify
 - In the table of titles which will be modified, click the 'Show MARC'
   button.
   - The modal preview window should show "Loading" and an animated
     spinner before the MARC record is loaded.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 17:59:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 15:59:42 +0000
Subject: [Koha-bugs] [Bug 20559] Occurrences of loading-small.gif still exist
In-Reply-To: <bug-20559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20559-70-dgNXoqynBK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76529
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76529&action=edit
Bug 20559: Compiled CSS

This patch contains the compiled OPAC CSS.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 18:04:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 16:04:37 +0000
Subject: [Koha-bugs] [Bug 21006] GetMarcBiblio is slow for records with many
	items
In-Reply-To: <bug-21006-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21006-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21006-70-RhOllSl6Uc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
After a quick look at the code, to test later:
If item type at biblio level (item-level_itypes=0) then 952$y will not contain
biblioitem.itemtype.

However I am not sure this make sense...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 18:17:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 16:17:16 +0000
Subject: [Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin
 integration into catalogue
In-Reply-To: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20968-70-BWzP36IRV6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #8 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 76530
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76530&action=edit
Bug 20968: (follow-up) Respond to feedback

This patch:

- Removes the unecessary testing for
intranet_catalog_biblio_enhancements method in detail.pl
- Renames get_toolbar_button to get_intranet_catalog_toolbar_button

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 18:23:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 16:23:24 +0000
Subject: [Koha-bugs] [Bug 21007] Add new patron column for date of last
 successful login attempt
In-Reply-To: <bug-21007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21007-70-UQqodapp7K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21007

--- Comment #1 from Cab Vinton <bibliwho at gmail.com> ---
I just noticed that there is a lastseen column, but it's not clear to me what
this is supposed to track.

A report I ran in our system shows 5,900 null values & 250 '0000-00-00
00:00:00' values.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 19:24:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 17:24:58 +0000
Subject: [Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin
 integration into catalogue
In-Reply-To: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20968-70-aRxkG7LdDZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76531
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76531&action=edit
Bug 20968: Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 19:25:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 17:25:06 +0000
Subject: [Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin
 integration into catalogue
In-Reply-To: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20968-70-klzEXa4ENd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76532
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76532&action=edit
Bug 20968: Rename method get_intranet_catalog_toolbar_button to
intranet_catalog_biblio_enhancements_toolbar_button

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 19:29:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 17:29:13 +0000
Subject: [Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin
 integration into catalogue
In-Reply-To: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20968-70-IarGbWEMrc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
> 4) I'm not clear whether you're suggesting we should ditch the
> intranet_catalog_biblio_enhancements method entirely. I don't think we can
> do this as we need to be able to test in plugins-home.pl/.tt for plugins
> that are within this class. If you just meant I should drop it from
> detail.pm as mentioned in 2), yes, I will do this.

I didn't fully understand it's purpose at first. What you've done in the
followup is excellent.

I've added to more patches for you, one that add's those unit tests, and
another that renames get_intranet_catalog_toolbar_button to
intranet_catalog_biblio_enhancements_toolbar_button

I know that's quite wordy, but it keeps the naming convention to be in line
with the naming convention for the opac payment methods.

If you these followups work for you, I think we'll be good to go! Just sign off
on my patches, I'll sign off on yours and we can let someone else QA. Once it's
passed qa, I'll add those methods to the Kitchen Sink plugin as well!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 19:33:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 17:33:31 +0000
Subject: [Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin
 integration into catalogue
In-Reply-To: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20968-70-zuOCK65703@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Apologies for all the typos in my last reply. It's just one of those days I
guess ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 19:39:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 17:39:35 +0000
Subject: [Koha-bugs] [Bug 21008] New: pay.pl and paycollect.pl pass unused
 (and expensive) data to templates
Message-ID: <bug-21008-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008

            Bug ID: 21008
           Summary: pay.pl and paycollect.pl pass unused (and expensive)
                    data to templates
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

After bug 18789, both controller scripts log warnings due to and attribute not
existing in the unblessed patron object.

Trying to fix that warning I found that the populated variables weren't
actually used on the templates at all! They should be removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 19:39:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 17:39:41 +0000
Subject: [Koha-bugs] [Bug 21008] pay.pl and paycollect.pl pass unused (and
 expensive) data to templates
In-Reply-To: <bug-21008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21008-70-pCAMKF2HmP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |18789


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789
[Bug 18789] Send a Koha::Patron object to the templates
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 19:39:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 17:39:41 +0000
Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates
In-Reply-To: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18789-70-WtJg5q1VcB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |21008


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008
[Bug 21008] pay.pl and paycollect.pl pass unused (and expensive) data to
templates
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 19:42:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 17:42:26 +0000
Subject: [Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
In-Reply-To: <bug-21008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21008-70-wIqzcUoOIR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|pay.pl and paycollect.pl    |pay.pl and paycollect.pl
                   |pass unused (and expensive) |raise warning
                   |data to templates           |

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
They are used, in patron-search.inc. Still needs fixing.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 19:52:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 17:52:43 +0000
Subject: [Koha-bugs] [Bug 21009] New: Item URIs longer than 255 bytes are
 silently truncated
Message-ID: <bug-21009-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21009

            Bug ID: 21009
           Summary: Item URIs longer than 255 bytes are silently truncated
 Change sponsored?: ---
           Product: Koha
           Version: 17.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: paul at flo.org
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When creating an item in the staff client Koha does not complain if I paste in
(or type) a URI that is longer than 255 bytes.

When I save the item, the URI is silently truncated to 255 bytes.

Here's a sample URI, 500 bytes long, that you can use to reproduce the bug:

http://example.com/harumvelitiustovelitofficiaquisnihilconsecteturisteeumautempraesentiumnamplaceatexcepturiautdolorplaceatvoluptatumvoluptatibussedetquamminimailloporropossimusnecessitatibusharumdolorumvoluptasveritatisetsuntsintsedlaboretemporaquasquietvoluptasexplicabosuntautdeseruntquisestvoluptatemveroveronecessitatibusrecusandaedebitiscumquemagnialiquamvoluptatenequeconsequaturnumquamomnisdignissimosaccusantiumquoutquodutsuscipitautemquiaomnisdelenitipraesentiumenimtotamidlaborumitaqueporr

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 19:54:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 17:54:47 +0000
Subject: [Koha-bugs] [Bug 20882] URI column in the items table is limited to
 255 characters
In-Reply-To: <bug-20882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20882-70-um9MX4yNN7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20882

Paul Hoffman <paul at flo.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=21009

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 19:54:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 17:54:47 +0000
Subject: [Koha-bugs] [Bug 21009] Item URIs longer than 255 bytes are
	silently truncated
In-Reply-To: <bug-21009-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21009-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21009-70-ETRaC9xYZV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21009

Paul Hoffman <paul at flo.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20882

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 19:59:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 17:59:54 +0000
Subject: [Koha-bugs] [Bug 17921] Shelf Browser does not take OpacSuppression
 or OpacHiddenItems into consideration
In-Reply-To: <bug-17921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17921-70-xBCZnga79H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17921

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 20:25:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 18:25:22 +0000
Subject: [Koha-bugs] [Bug 21010] New: Add a script to search for data
	inconsistencies
Message-ID: <bug-21010-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21010

            Bug ID: 21010
           Summary: Add a script to search for data inconsistencies
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 20:26:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 18:26:15 +0000
Subject: [Koha-bugs] [Bug 20509] Data consistency - authority types
In-Reply-To: <bug-20509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20509-70-rSFhg6P3Qf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20509

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |21010


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21010
[Bug 21010] Add a script to search for data inconsistencies
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 20:26:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 18:26:15 +0000
Subject: [Koha-bugs] [Bug 21010] Add a script to search for data
	inconsistencies
In-Reply-To: <bug-21010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21010-70-9CTvZaYqEi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21010

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20509


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20509
[Bug 20509] Data consistency - authority types
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 20:28:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 18:28:51 +0000
Subject: [Koha-bugs] [Bug 21011] New: Data inconsistencies -
 items.holdingbranch | items.homebranch
Message-ID: <bug-21011-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21011

            Bug ID: 21011
           Summary: Data inconsistencies - items.holdingbranch |
                    items.homebranch
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

>From bug 5789: scripts can fail if items.homebranch and/or items.holdingbranch
is not defined

We could provide a script to help people catching these migration issues.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 20:29:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 18:29:17 +0000
Subject: [Koha-bugs] [Bug 5789] Fines don't work when items have null
	homebranch
In-Reply-To: <bug-5789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5789-70-ifkBs5wEsj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5789

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #11)
> I would prefer to see a misc script searching for any kinds of data
> inconsistency in DB. We will then improve it incrementally.

I am going to provide a patch on bug 21010.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 20:34:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 18:34:45 +0000
Subject: [Koha-bugs] [Bug 21011] Data inconsistencies - items.holdingbranch
 | items.homebranch
In-Reply-To: <bug-21011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21011-70-I9xUawvvJB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21011

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 20:34:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 18:34:48 +0000
Subject: [Koha-bugs] [Bug 21011] Data inconsistencies - items.holdingbranch
 | items.homebranch
In-Reply-To: <bug-21011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21011-70-tQJz9S4yXU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21011

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76533
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76533&action=edit
Bug 21011: Search for items with not defined homebranch and/or holdingbranch

>From bug 5789: scripts can fail if items.homebranch and/or
items.holdingbranch is not defined

This script will help people catching these migration issues.

Test plan:
Update your items table to set some homebranch or holdingbranch to NULL
Run this script
It will display the different items with not defined values in these
fields.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 20:35:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 18:35:11 +0000
Subject: [Koha-bugs] [Bug 21010] Add a script to search for data
	inconsistencies
In-Reply-To: <bug-21010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21010-70-s5LhCpGInQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21010

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |21011


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21011
[Bug 21011] Data inconsistencies - items.holdingbranch | items.homebranch
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 20:35:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 18:35:11 +0000
Subject: [Koha-bugs] [Bug 21011] Data inconsistencies - items.holdingbranch
 | items.homebranch
In-Reply-To: <bug-21011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21011-70-CxsVKmSs6t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21011

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |21010


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21010
[Bug 21010] Add a script to search for data inconsistencies
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 20:38:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 18:38:51 +0000
Subject: [Koha-bugs] [Bug 20509] Data consistency - authority types
In-Reply-To: <bug-20509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20509-70-T5Um6G0i6C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20509

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 20:38:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 18:38:55 +0000
Subject: [Koha-bugs] [Bug 20509] Data consistency - authority types
In-Reply-To: <bug-20509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20509-70-rr8385EZX1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20509

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76534
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76534&action=edit
Bug 20509: Search for not defined authority codes

This patch adds a new check in
misc/maintenance/search_for_data_inconsistencies.pl to search for not
defined authority codes.

Test plan:
Set some auth_header.authtypecode to not defined authority codes in Koha
(UPDATE auth_header SET authtypecode="XXX" WHERE authid=42;)
Then run `misc/maintenance/search_for_data_inconsistencies.pl`

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 20:39:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 18:39:33 +0000
Subject: [Koha-bugs] [Bug 20509] Data consistency - authority types
In-Reply-To: <bug-20509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20509-70-uFCLIJmznx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20509

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |21011

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Need patch from bug 21011 to apply correctly.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21011
[Bug 21011] Data inconsistencies - items.holdingbranch | items.homebranch
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 20:39:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 18:39:33 +0000
Subject: [Koha-bugs] [Bug 21011] Data inconsistencies - items.holdingbranch
 | items.homebranch
In-Reply-To: <bug-21011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21011-70-G9rnEuq9xh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21011

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20509


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20509
[Bug 20509] Data consistency - authority types
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 20:46:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 18:46:20 +0000
Subject: [Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
In-Reply-To: <bug-21008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21008-70-Sd70WOv0nJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Which variables?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 21:00:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 19:00:18 +0000
Subject: [Koha-bugs] [Bug 10348] Show number of items on tab headings in the
	staff client
In-Reply-To: <bug-10348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10348-70-tUKWip6GZK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10348

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 21:00:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 19:00:21 +0000
Subject: [Koha-bugs] [Bug 10348] Show number of items on tab headings in the
	staff client
In-Reply-To: <bug-10348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10348-70-K84GmIsb7B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10348

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76527|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76535&action=edit
Bug 10348: Show number of items on tab headings in the staff client

This patch uses Template Toolkit's size() method to add a count to
the bibliographic detail page's holdings and images tabs.

To test, apply the patch and view the detail page for a record in
the staff client. Check under the following conditions:

- The SeparateHoldings system preference is set to "Don't separate"
  - The holdings tab should show the correct item count.
- The SeparateHoldings system preference is set to "Separate"
  - The "[Library] holdings" tab and "Other holdings" tabs should
    have the correct item counts.
- With LocalCoverImages enabled the "Images" tab should show the
  correct count of attached images. Test with zero or more attached
  images.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 21:06:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 19:06:04 +0000
Subject: [Koha-bugs] [Bug 20942] Add route to get patron's account balance
In-Reply-To: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20942-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20942-70-W0vxC5LvoI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
General question: cannot we have only one of $to_api_mapping and
$to_model_mapping, and generate the other one? It seems that we are duplicating
the information.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 21:19:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 19:19:24 +0000
Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface
In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20935-70-dnZhqSqfmB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
* I would not add the alert box when nothing is found

* Left navigation is replaced by the admin one, instead of the pref specific
one (prefs-menu.inc vs admin-menu.inc), I do not think it's expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 21:33:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 19:33:55 +0000
Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout
 form, with collapsed settings panel
In-Reply-To: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20959-70-Bm42pCa8EZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I have the "Checkin" button at the bottom of the barcode input.

https://screenshots.firefox.com/FK6HtuCBLyx28NEA/pro.kohadev.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 22:12:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 20:12:45 +0000
Subject: [Koha-bugs] [Bug 8169] No LCCN field on Z39.50 search
In-Reply-To: <bug-8169-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8169-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8169-70-qXK0TFTykX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8169

Laura Horgan <horganl at middlesex.mass.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |horganl at middlesex.mass.edu

--- Comment #7 from Laura Horgan <horganl at middlesex.mass.edu> ---
I also would find LC card number helpful as well as a way to add format and
publication date to the z39.50 search options.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 22:27:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 20:27:14 +0000
Subject: [Koha-bugs] [Bug 21011] Data inconsistencies - items.holdingbranch
 | items.homebranch
In-Reply-To: <bug-21011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21011-70-NazvBDroZ1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21011

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 22:27:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 20:27:19 +0000
Subject: [Koha-bugs] [Bug 21011] Data inconsistencies - items.holdingbranch
 | items.homebranch
In-Reply-To: <bug-21011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21011-70-De0NEHCAFB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21011

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76533|0                           |1
        is obsolete|                            |

--- Comment #2 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76536
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76536&action=edit
Bug 21011: Search for items with not defined homebranch and/or holdingbranch

>From bug 5789: scripts can fail if items.homebranch and/or
items.holdingbranch is not defined

This script will help people catching these migration issues.

Test plan:
Update your items table to set some homebranch or holdingbranch to NULL
Run this script
It will display the different items with not defined values in these
fields.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 22:27:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 20:27:23 +0000
Subject: [Koha-bugs] [Bug 21011] Data inconsistencies - items.holdingbranch
 | items.homebranch
In-Reply-To: <bug-21011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21011-70-92BVDKQEQT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21011

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76537&action=edit
Bug 21011: (follow-up) Fix pod, fix missing homebranch condition, change mode
to executable

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 22:32:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 20:32:50 +0000
Subject: [Koha-bugs] [Bug 20509] Data consistency - authority types
In-Reply-To: <bug-20509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20509-70-AtcmSKKspB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20509

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 22:32:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 20:32:55 +0000
Subject: [Koha-bugs] [Bug 20509] Data consistency - authority types
In-Reply-To: <bug-20509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20509-70-3pKFaMu6df@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20509

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76534|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76538&action=edit
Bug 20509: Search for not defined authority codes

This patch adds a new check in
misc/maintenance/search_for_data_inconsistencies.pl to search for not
defined authority codes.

Test plan:
Set some auth_header.authtypecode to not defined authority codes in Koha
(UPDATE auth_header SET authtypecode="XXX" WHERE authid=42;)
Then run `misc/maintenance/search_for_data_inconsistencies.pl`

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 22:42:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 20:42:47 +0000
Subject: [Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
In-Reply-To: <bug-21008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21008-70-8nQ33GjPvE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #2)
> Which variables?

1- $b_ref->{extendedattributes}

The other scripts set $template->param( extendedattributes => ... );

2- CATCODE_MULTI

I made a mistake on this one, as it is used in patron-search.inc. But the
current logic prevents it to be populated.

3- catcode

Same as 2.

I really think this should all be moved into using the global $patron object.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 22:43:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 20:43:08 +0000
Subject: [Koha-bugs] [Bug 20991] Error will reset category when editing a
	patron
In-Reply-To: <bug-20991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20991-70-erjDIFqXwy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20991

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 22:43:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 20:43:12 +0000
Subject: [Koha-bugs] [Bug 20991] Error will reset category when editing a
	patron
In-Reply-To: <bug-20991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20991-70-mGOCqSUnEs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20991

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76473|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 76539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76539&action=edit
Bug 20991: Do not lost patron's category when editing a patron

If there is an error in the edit patron form the patron's category is
lost.
This seems to be a long standing bug.

Test plan:
- Edit an existing patron
- Change the patron category to a category that triggers the error that
the user is not in the right age range for that new category
- Save, error is triggered
=> Without this patch the patron category has been reset

You should also test different ways to edit/add a patron (quick add,
step 1)

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 22:43:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2018 20:43:26 +0000
Subject: [Koha-bugs] [Bug 20991] Error will reset category when editing a
	patron
In-Reply-To: <bug-20991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20991-70-cluOAQxKHe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20991

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 07:48:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 05:48:49 +0000
Subject: [Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
In-Reply-To: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20906-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20906-70-zHSIF8QiG2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #16 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x, will be in v17.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 07:50:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 05:50:10 +0000
Subject: [Koha-bugs] [Bug 20928] Checkout status not showing patron
In-Reply-To: <bug-20928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20928-70-Ftb3IjNMCV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20928

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 18403 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 07:50:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 05:50:37 +0000
Subject: [Koha-bugs] [Bug 20951] Koha::Patron::Discharge is missing use
 Koha::Patron::Debarments
In-Reply-To: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20951-70-CLbc1qcxVv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 08:38:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 06:38:45 +0000
Subject: [Koha-bugs] [Bug 21012] New: Inventory does not show proper
 shelving locations for the selected library
Message-ID: <bug-21012-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21012

            Bug ID: 21012
           Summary: Inventory does not show proper shelving locations for
                    the selected library
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: theod at lib.auth.gr
        QA Contact: testopia at bugs.koha-community.org

It seems that in the Inventory tool, after choosing a library in the "Select
items you want to check" area, the Shelving location dropdown list is not
updated accordingly also to show the relevant shelving locations of the chosen
library.

(That of course implies that there are some shelving locations that are
restricted to only some libraries. Shelving locations with no library
restrictions are of course shown here regardless of the chosen library)

In case that this was 'by design', for consistency the user should not be able
to choose a library either and be restricted to run the tool only for his/hers
home library. 

So, my point is that if one can choose another library then he/she should see
the appropriate shelving locations for that library (in addition to the ones
that are available to all) or else that part of the tool is not usable.

Testing plan:
1/ Create a shelving location SL1 that is only available to branch A
2/ Create a shelving location SL2 that is only available to branch B
3/ (optionally) Create a shelving location SL3 with no branch restriction
4/ Assign user U1 to branch A
5/ If you go to Tools->Inventory, in the "Select items you want to check" area
you will see only SL1 and SL3 regardless of the library selected. 
The 'proper' behavior would be to see SL1/SL3 if you choose branch A and
SL2/SL3 if you choose branch B

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 08:40:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 06:40:02 +0000
Subject: [Koha-bugs] [Bug 21012] Inventory filters do not show proper
 shelving locations in dropdown for the selected library
In-Reply-To: <bug-21012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21012-70-5uqnm8bR9d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21012

Theodoros Theodoropoulos <theod at lib.auth.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Inventory does not show     |Inventory filters do not
                   |proper shelving locations   |show proper shelving
                   |for the selected library    |locations in dropdown for
                   |                            |the selected library

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 08:42:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 06:42:55 +0000
Subject: [Koha-bugs] [Bug 21012] Inventory filters do not show proper
 shelving locations in dropdown for the selected library
In-Reply-To: <bug-21012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21012-70-ihmqvizqNY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21012

Theodoros Theodoropoulos <theod at lib.auth.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P4

--- Comment #1 from Theodoros Theodoropoulos <theod at lib.auth.gr> ---
Clarification: 
The aforementioned "Select items you want to check" area was used in previous
Koha versions and has been replaced by "Item location filters"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 08:55:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 06:55:42 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-4jfBlcVlEp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #38 from paxed <pasi.kallinen at joensuu.fi> ---
BTW, my take on reducing the number of TT placeholders is in bug 12221

(In reply to Julian Maurice from comment #37)
> 
> But please note that, unlike actual PO files, the one attached doesn't
> contain strings like this:
> 
> "%s %s %s &nbsp; %s %s - %s %s %s - %s%s %s- %s%s %s - %s%s %sEdition: %s%s "
> "%s ; %s%s %s - %s%s %s ; %s%s %s "
>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 08:56:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 06:56:50 +0000
Subject: [Koha-bugs] [Bug 20951] Koha::Patron::Discharge is missing use
 Koha::Patron::Debarments
In-Reply-To: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20951-70-J8g0Z8YNSM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951

--- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 08:56:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 06:56:28 +0000
Subject: [Koha-bugs] [Bug 20951] Koha::Patron::Discharge is missing use
 Koha::Patron::Debarments
In-Reply-To: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20951-70-OFRMkiJXUP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Katrin Fischer from comment #2)
> I can't reproduce the problem. I have tried discharging from the patron
> account as well as discharging using the link from the dashboard and the
> 'allow' button.
> 
> Similar to bug 20851?

I should have mentioned I'm in Plack env.
I see the explanation in Bug 20851. I think each module should explicitly call
use on the modules they need.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 09:04:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 07:04:53 +0000
Subject: [Koha-bugs] [Bug 13655] Can't save organisation type patron without
 entering userid/password
In-Reply-To: <bug-13655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13655-70-XavJlHcSsu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13655

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
         Resolution|---                         |FIXED

--- Comment #21 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 19936 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 09:08:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 07:08:34 +0000
Subject: [Koha-bugs] [Bug 20881] Order receiving: Price filter missing
	on_editing
In-Reply-To: <bug-20881-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20881-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20881-70-xMhmghb0Ry@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20881

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
         Depends on|                            |13352

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.08


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352
[Bug 13352] Editing amount in Acquisitions budget causes error due to
formatting
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 09:08:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 07:08:34 +0000
Subject: [Koha-bugs] [Bug 13352] Editing amount in Acquisitions budget
 causes error due to formatting
In-Reply-To: <bug-13352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13352-70-GrsZ2D0PqK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20881


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20881
[Bug 20881] Order receiving: Price filter missing on_editing
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 09:09:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 07:09:02 +0000
Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable
 text inside t() calls
In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20988-70-h2kUnVDNX1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #39 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to paxed from comment #38)
> BTW, my take on reducing the number of TT placeholders is in bug 12221

I wasn't aware of this bug, thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 09:09:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 07:09:05 +0000
Subject: [Koha-bugs] [Bug 21012] Inventory filters do not show proper
 shelving locations in dropdown for the selected library
In-Reply-To: <bug-21012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21012-70-A6e6XZmzHO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21012

Theodoros Theodoropoulos <theod at lib.auth.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from Theodoros Theodoropoulos <theod at lib.auth.gr> ---
I have been testing with 16.11 and the bug was there. Also, I couldn't find a
relevant bugzilla case (open or closed), so I created one.

HOWEVER, it seems that the behavior was fixed in some of the latest Koha
versions (tried with a demo 18.05).

Closing case as the bug was fixed at some point :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 09:30:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 07:30:53 +0000
Subject: [Koha-bugs] [Bug 20794] Don't show holds tab when user doesn't have
 circulate_remaining_permissions
In-Reply-To: <bug-20794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20794-70-crO0WfjhEs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20794

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 09:32:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 07:32:55 +0000
Subject: [Koha-bugs] [Bug 20697] Remove some Host-Item-Number noise from
 zebra-output.log when EasyAnalyticalRecords is not used
In-Reply-To: <bug-20697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20697-70-GgvKECcNsk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20697

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 10:10:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 08:10:50 +0000
Subject: [Koha-bugs] [Bug 9566] Only run analytics code if analytics are
	enabled
In-Reply-To: <bug-9566-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9566-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9566-70-bfKdwxRDuz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9566

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #5 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---


*** This bug has been marked as a duplicate of bug 20702 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 10:10:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 08:10:50 +0000
Subject: [Koha-bugs] [Bug 20702] Bind results of GetHostItemsInfo to the
 EasyAnalyticalRecords pref
In-Reply-To: <bug-20702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20702-70-T4DqXcddI5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20702

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #14 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
*** Bug 9566 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 10:11:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 08:11:37 +0000
Subject: [Koha-bugs] [Bug 9566] Only run analytics code if analytics are
	enabled
In-Reply-To: <bug-9566-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9566-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9566-70-Kfx3NBaVOC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9566

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Solved at laaaaaaaaast, it will improve performance for records with a huge
number of items. Thanks to all of you

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 10:23:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 08:23:28 +0000
Subject: [Koha-bugs] [Bug 20702] Bind results of GetHostItemsInfo to the
 EasyAnalyticalRecords pref
In-Reply-To: <bug-20702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20702-70-3qTc7xXOWo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20702

--- Comment #15 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.08

I hope Bug 20697 will be pushed soon to be in same release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 10:37:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 08:37:00 +0000
Subject: [Koha-bugs] [Bug 20456] Remove the
	C4::Serials::GetSubscriptionsFromBorrower
In-Reply-To: <bug-20456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20456-70-jXMLeEM2ro@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
         Resolution|---                         |FIXED
             Status|Pushed to Stable            |RESOLVED

--- Comment #17 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 20400 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 10:40:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 08:40:37 +0000
Subject: [Koha-bugs] [Bug 20876] The form_serialized_itype cookie is not
 used and should be removed
In-Reply-To: <bug-20876-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20876-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20876-70-L2r10ewcQy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20876

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.08

Same has 18.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 10:44:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 08:44:52 +0000
Subject: [Koha-bugs] [Bug 20972] If ISBN has 10 numbers only the first 9
	numbers are used
In-Reply-To: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20972-70-Zbx4H2jIQC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20972

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.08

Regular expression are a curse, they can be hell or heaven :D

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 10:46:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 08:46:07 +0000
Subject: [Koha-bugs] [Bug 20879] Shibboleth in combination with LDAP as an
 alternative no longer works
In-Reply-To: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20879-70-UQlFxHRd3w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #24 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.11.x for 17.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 10:51:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 08:51:26 +0000
Subject: [Koha-bugs] [Bug 20864] Only set bibs_selected cookie when
 BrowseResultSelection is activated
In-Reply-To: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20864-70-rU2W8MWgp3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19290
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19290
[Bug 19290] Browse selected biblios - Staff
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 10:51:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 08:51:26 +0000
Subject: [Koha-bugs] [Bug 19290] Browse selected biblios - Staff
In-Reply-To: <bug-19290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19290-70-iO2H5Bc3Z6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19290

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20864


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864
[Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is
activated
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 10:52:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 08:52:09 +0000
Subject: [Koha-bugs] [Bug 20864] Only set bibs_selected cookie when
 BrowseResultSelection is activated
In-Reply-To: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20864-70-QKx6NrHkGk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 19290 not in 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 10:52:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 08:52:17 +0000
Subject: [Koha-bugs] [Bug 20864] Only set bibs_selected cookie when
 BrowseResultSelection is activated
In-Reply-To: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20864-70-QXhwBADXa1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 13:31:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 11:31:36 +0000
Subject: [Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin
 integration into catalogue
In-Reply-To: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20968-70-OB2Qe4un5l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76532|0                           |1
        is obsolete|                            |

--- Comment #13 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 76540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76540&action=edit
Bug 20968: Rename method get_intranet_catalog_toolbar_button to
intranet_catalog_biblio_enhancements_toolbar_button

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 13:31:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 11:31:48 +0000
Subject: [Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin
 integration into catalogue
In-Reply-To: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20968-70-GPsXJ9H5nw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76531|0                           |1
        is obsolete|                            |

--- Comment #14 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 76541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76541&action=edit
Bug 20968: Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 13:34:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 11:34:08 +0000
Subject: [Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin
 integration into catalogue
In-Reply-To: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20968-70-01XtltKM3D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #15 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Hi Kyle

Perfect, thanks very much for that.

I've tested and signed off (I think) your patches.

Cheers

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 14:52:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 12:52:24 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-DbMfEfLPrr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76485|0                           |1
        is obsolete|                            |

--- Comment #7 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 76542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76542&action=edit
Bug 20447: MARC Holdings support

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 15:20:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 13:20:57 +0000
Subject: [Koha-bugs] [Bug 20559] Occurrences of loading-small.gif still exist
In-Reply-To: <bug-20559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20559-70-S4ypZQsGuJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 15:21:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 13:21:05 +0000
Subject: [Koha-bugs] [Bug 20559] Occurrences of loading-small.gif still exist
In-Reply-To: <bug-20559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20559-70-F5uCqoLQpK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76544&action=edit
Bug 20559: Compiled CSS

This patch contains the compiled OPAC CSS.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 15:21:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 13:21:01 +0000
Subject: [Koha-bugs] [Bug 20559] Occurrences of loading-small.gif still exist
In-Reply-To: <bug-20559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20559-70-H3Ryz1UaSO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76528|0                           |1
        is obsolete|                            |
  Attachment #76529|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76543
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76543&action=edit
Bug 20559: Occurrences of loading-small.gif still exist

This patch removes some leftover references to a file which no longer
exists. In the OPAC, loading-small.gif was included in CSS which was
never used. In the staff client, loading-small.gif should have been
corrected to spinner-small.gif.

To test, apply the patch and go to Tools -> Batch record modification.

 - Submit a batch of records to modify
 - In the table of titles which will be modified, click the 'Show MARC'
   button.
   - The modal preview window should show "Loading" and an animated
     spinner before the MARC record is loaded.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 15:27:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 13:27:02 +0000
Subject: [Koha-bugs] [Bug 20509] Data consistency - authority types
In-Reply-To: <bug-20509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20509-70-QcYJL7WUl2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20509

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 15:33:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 13:33:50 +0000
Subject: [Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
In-Reply-To: <bug-21008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21008-70-6rkjNHuks6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76545&action=edit
Bug 21008: Use patron object to get category_type

This patch makes borrower_add_additional_fields() in both pay.pl and
paycollect.pl use the right object to pick the category_type.

It also populates the extendedattributes template variable in pay.pl
which was missed by a change.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 15:37:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 13:37:24 +0000
Subject: [Koha-bugs] [Bug 21013] New: Missing itemtype for checkut makes
 patron summary print explode
Message-ID: <bug-21013-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21013

            Bug ID: 21013
           Summary: Missing itemtype for checkut makes patron summary
                    print explode
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

If there is a checkout on the patron account for an item without item type
(item level itemtypes), then the 'print summary' will explode into an Internal
server error.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 15:38:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 13:38:19 +0000
Subject: [Koha-bugs] [Bug 17075] Items' subfields do not obey the mandatory
	flag
In-Reply-To: <bug-17075-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17075-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17075-70-q7EIYfpSeM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17075

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Why is this marked blocked?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 15:55:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 13:55:04 +0000
Subject: [Koha-bugs] [Bug 17075] Items' subfields do not obey the mandatory
	flag
In-Reply-To: <bug-17075-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17075-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17075-70-DWj0soproe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17075

--- Comment #2 from Claudio <costalc at gmail.com> ---
This bug might be an error of mine. It works fine now (18.05).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 15:55:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 13:55:59 +0000
Subject: [Koha-bugs] [Bug 17075] Items' subfields do not obey the mandatory
	flag
In-Reply-To: <bug-17075-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17075-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17075-70-v3GkWlwBL3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17075

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |RESOLVED
         Resolution|---                         |WORKSFORME

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx for the quick reply, marking WORKSFORME

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 16:01:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 14:01:39 +0000
Subject: [Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
In-Reply-To: <bug-21008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21008-70-rWGNHlUE3m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76546&action=edit
Bug 21008: Use Koha::Patron->is_child

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 16:29:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 14:29:16 +0000
Subject: [Koha-bugs] [Bug 20900] Yet another test assumes that CPL is present
In-Reply-To: <bug-20900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20900-70-OBaKeM3qYu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20900

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 16:42:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 14:42:14 +0000
Subject: [Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
In-Reply-To: <bug-21008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21008-70-K6duQ0mGU0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76546|0                           |1
        is obsolete|                            |

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76547
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76547&action=edit
Bug 21008: Use Koha::Patron->is_child

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Edit: I removed the category parameter as it is not really used.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 16:49:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 14:49:35 +0000
Subject: [Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
In-Reply-To: <bug-21008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21008-70-Ih0VliQOEC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 17:01:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 15:01:00 +0000
Subject: [Koha-bugs] [Bug 20468] Multiselect on staff article requests form
In-Reply-To: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20468-70-DG9JsZrXIV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Marcel, (last patch) could not we use only null (instead of undefined vs null)?

There is also a tiny ergonomic issue, hit /circ/article-requests.pl, click the
"processing" tab. There are the "select all" and "clear all" links, if the
table is empty and you click on one of them they will disappear.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 17:28:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 15:28:27 +0000
Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface
In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20935-70-AL7HQTCbkT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 17:28:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 15:28:31 +0000
Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface
In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20935-70-zEMYckjsqH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76097|0                           |1
        is obsolete|                            |

--- Comment #10 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76548&action=edit
Bug 20935: Redesign system preferences interface

This patch proposes a new interface for system preferences. The goal is
to make the interface more readable and to give the user additional
options for finding what they need.

- Restructures the preferences list as a <dl>, with the preference name
  as the <dt> and the description as the <dd>.
- Add a JS filter library (mark.js) to do live filtering of the page and
  add search term highlighting.
- When the user has searched, show links to the sections in which
  results were returned.

To test, apply the patch and go to Administration -> System preferences.

 - Test the functionality of setting various kinds of preferences,
   including multi-selects, textareas, WYSIWYG editors, etc.
 - Test the filter form at the top of the page for narrowing in-page
   results.
   - Test both successful and unsuccessful filters.
 - Perform a system preference search.
   - Test the in-page links to the different sections.
   - Test that in-page filtering works in this case too.
 - View the licenses tab of the "About" page and check that the
   information about mark.js looks correct.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 17:32:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 15:32:51 +0000
Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface
In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20935-70-gfn2IzloHc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935

--- Comment #11 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Josef Moravec from comment #8)
> Also, the "Local use" preferences are not addressed in this patch

The local use tab wasn't updated in the last round of interface changes, so I
didn't think it was a priority.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 18:11:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 16:11:09 +0000
Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout
 form, with collapsed settings panel
In-Reply-To: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20959-70-L35jAHhlzE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Tomas tested on Ubuntu 18.04 + 1080p, with chrome, chromium and FF:

https://snag.gy/LGTqCl.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 18:53:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 16:53:04 +0000
Subject: [Koha-bugs] [Bug 16544] Changes to circ rules should be logged.
In-Reply-To: <bug-16544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16544-70-nv6kqzRGIQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16544

Jessica Ofsa <jofsa at vt.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jofsa at vt.edu

--- Comment #1 from Jessica Ofsa <jofsa at vt.edu> ---
Changes to circ and fine rules should be logged for troubleshooting and
accountability. Because we have the ability to completely overwrite a library's
lending rules using the clone feature, a backup/log should be kept.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 19:54:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 17:54:27 +0000
Subject: [Koha-bugs] [Bug 16251] Material type is not correctly set for
	Rancor 008 widget
In-Reply-To: <bug-16251-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16251-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16251-70-8WhyIxaV4y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16251

Jana Doyle <jdoyle at vt.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jdoyle at vt.edu

--- Comment #1 from Jana Doyle <jdoyle at vt.edu> ---
The widget needs to add a selected="selected" parameter to the select tag based
on the value in the physical description field in the 007 (and similar fix for
the 008). Otherwise the browser selects the first value by default, which is
usually not the correct value.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 19:55:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 17:55:15 +0000
Subject: [Koha-bugs] [Bug 16251] Material type is not correctly set for
	Rancor 008 widget
In-Reply-To: <bug-16251-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16251-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16251-70-pG7j55ZNmb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16251

Jana Doyle <jdoyle at vt.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P1 - high
           Severity|minor                       |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 20:34:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 18:34:43 +0000
Subject: [Koha-bugs] [Bug 9411] Multiple uses of javascript eval on ajax
 responses in acq.js
In-Reply-To: <bug-9411-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9411-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9411-70-S5wMLVv7yf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9411

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|Failed QA                   |RESOLVED

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---


*** This bug has been marked as a duplicate of bug 4439 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 20:34:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 18:34:43 +0000
Subject: [Koha-bugs] [Bug 4439] two acq webservices should use C4::Service
In-Reply-To: <bug-4439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4439-70-gYZwwYZ9s5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4439

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hugh at davenport.net.nz

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
*** Bug 9411 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 21:00:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 19:00:43 +0000
Subject: [Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
In-Reply-To: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20997-70-93bjwr5NBm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997

--- Comment #10 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76549&action=edit
Bug 20997: Add new offset type

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 21:00:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 19:00:47 +0000
Subject: [Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
In-Reply-To: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20997-70-UcYrwpVKWs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997

--- Comment #11 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76550&action=edit
Bug 20997: ->apply should be applied to Koha::Account::Lines

This patch makes ->apply get passed an object set class instead of
single account lines.

The change is fully covered by tests.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 21:00:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 19:00:51 +0000
Subject: [Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
In-Reply-To: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20997-70-6GKmzr7N7p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997

--- Comment #12 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76551
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76551&action=edit
Bug 20997: (follow-up) Minor POD fixes

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 21:01:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 19:01:25 +0000
Subject: [Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
In-Reply-To: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20997-70-PApGQpPOKh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 21:20:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 19:20:56 +0000
Subject: [Koha-bugs] [Bug 20278] Cancel Hold alert in OPAC provides
	confusing options
In-Reply-To: <bug-20278-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20278-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20278-70-Djq68qLUjj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20278

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 21:21:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 19:21:07 +0000
Subject: [Koha-bugs] [Bug 20278] Cancel Hold alert in OPAC provides
	confusing options
In-Reply-To: <bug-20278-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20278-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20278-70-sy67g38Tul@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20278

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 23:51:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 21:51:03 +0000
Subject: [Koha-bugs] [Bug 21014] New: Availability of hidden items showing
	in OPAC
Message-ID: <bug-21014-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21014

            Bug ID: 21014
           Summary: Availability of hidden items showing in OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 76552
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76552&action=edit
Availability of withdrawn item is displayed

Can someone try this and confirm or invalidate this as a bug? 

If I have two items on one record, one of which is hidden as per
OpacHiddenItems, the availability still shows in the OPAC results list.

Here are the steps I'm following:

1- Go to Administration > Global system preferences
2- Search for OpacHiddenItems
3- Add the following value to OpacHiddenItems: withdrawn: [1]
4- Save your system preferences
5- In the search bar at the top, click on the "Search catalog" tab
6- Search for anything
7- Find a record with two items, or add an item to a record
8- Add the withdrawn status to one of the two items, the other has to be
available
9- Go to OPAC
10- Search for the record (a broad search to make sure you get to the results
list, not the record details)
11- Check the availability of the items <-- for me, here, it says 1 available
and 1 withdrawn (see screen capture opachiddenitems1.png)
12- Click on the title to open the record details
13- Check the items <-- there should be only one, the withdrawn item is hidden
(see screen capture opachiddenitems2.png)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 23:51:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 21:51:26 +0000
Subject: [Koha-bugs] [Bug 21014] Availability of hidden items showing in OPAC
In-Reply-To: <bug-21014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21014-70-8Fi9GZaNXo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21014

--- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created attachment 76553
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76553&action=edit
Item is hidden in record details

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 01:48:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 23:48:00 +0000
Subject: [Koha-bugs] [Bug 19990] opac/opac-discharge.pl has a FIXME that can
	be fixed
In-Reply-To: <bug-19990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19990-70-ivPLmxJAuk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 01:48:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2018 23:48:04 +0000
Subject: [Koha-bugs] [Bug 19990] opac/opac-discharge.pl has a FIXME that can
	be fixed
In-Reply-To: <bug-19990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19990-70-0uNOeHIpnm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990

--- Comment #6 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 76554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76554&action=edit
Bug 19990: Removing unnecessary variable from opac/opac-discharge.pl

To test:
1) Ensure useDischarge syspref is enabled
2) Go to OPAC, click ask for a discharge
3) Go to staff side homepage, click 'Discharge requests pending'
4) Allow Discharge
5) Go to the user's page and remove the discharge restriction
6) Apply patch and repeat steps 2-4, ensuring that all behaviour stays
the same

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 05:02:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 03:02:59 +0000
Subject: [Koha-bugs] [Bug 20464] On public reports,
 the behavior of cache-expiry 0 is confusing to users
In-Reply-To: <bug-20464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20464-70-dynV8M9t8n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20464

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |liz at catalyst.net.nz
             Status|NEW                         |In Discussion

--- Comment #1 from Liz Rea <liz at catalyst.net.nz> ---
This setting seems to be gone in Master.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 05:03:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 03:03:25 +0000
Subject: [Koha-bugs] [Bug 20464] On public reports,
 the behavior of cache-expiry 0 is confusing to users
In-Reply-To: <bug-20464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20464-70-b6z2PBbCg7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20464

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |ASSIGNED

--- Comment #2 from Liz Rea <liz at catalyst.net.nz> ---
Oh I lie, you have to have the caching turned on. ignore that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 08:58:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 06:58:40 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-r139RPz5oE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #183 from Josef Moravec <josef.moravec at gmail.com> ---
I do a retest:

(In reply to Jonathan Druart from comment #182)
> Quick test:
> - check an item out, then check it in
> - delete the item
> 
> 1. on /members/readingrec.pl?borrowernumber=51
> a) before "This patron has no circulation history."
> b) after we see a table with all item's info

The same for me, you are right

> 2. on /catalogue/issuehistory.pl?biblionumber=42
> a) before "Amy's diary, by Lee has never been checked out."
> b) after "Checked out 1 times" with the table (and a barcode with a link to
> the item)

You are right

> 
> Same if we remove the bibliographic record.
>

True

> 
> 3. Perform a search, /catalogue/search.pl?q=d
> the search result will display "1 item, 1 available" in the "Location"
> column whereas there are no more items for this bibliographic record.

When I delete an item, it can not be anymore seen in search results - so ok for
me.

> I did not see anything about these changes in the previous comments, and it
> seems that we lack a proper test plan.
>
> What about acquisition module? Fines? Authority ("used in X"), etc?

Authority "used in X records" is done by search engine, so  when it works, it
gets the correct number - I just tested it and it is ok when i remove record
with authority linked.

Fines linked with items remains linked and show the name of item in description
- but it is the question if we do wan't to show it or not then - it could be
useful information even if the item/biblio no longer "exists".

So I agree, there is more things to test and it is not easy to find all places
which should be tested...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 10:11:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 08:11:02 +0000
Subject: [Koha-bugs] [Bug 21015] New: Members.pm slow because it loads twice
	Koha::Schema
Message-ID: <bug-21015-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21015

            Bug ID: 21015
           Summary: Members.pm slow because it loads twice Koha::Schema
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Database
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: j.kylmala at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Koha/C4/Members.pm currently loads by itself Koha::Schema using "use
Koha::Schema" even though this is not required as we could use Koha::Database
that has already done that (another further issue is why does Koha::Database
load all the classes in Koha/Schema/Result/ when it could just load the ones
that are needed).

Loading the Koha::Schema takes for me around 2 seconds on my machine so it
would be quite a big performance boost to remove it. I got a 30% faster load
time on cgi-bin/koha/members/moremember.pl with a patch I made. I will attach
it here but be warned: I have not run any tests and I don't know if it has even
syntax errors because I'm doing the patch on a machine without a proper
development environment.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 10:24:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 08:24:30 +0000
Subject: [Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin
 integration into catalogue
In-Reply-To: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20968-70-6K62hZlFLD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #16 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 76555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76555&action=edit
Bug 20968: (follow-up) Replace tabs with spaces

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 10:32:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 08:32:44 +0000
Subject: [Koha-bugs] [Bug 21015] Members.pm slow because it loads twice
	Koha::Schema
In-Reply-To: <bug-21015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21015-70-3vJnPBkk5G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21015

j.kylmala at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |j.kylmala at gmail.com
                   |ity.org                     |

--- Comment #1 from j.kylmala at gmail.com ---
Created attachment 76556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76556&action=edit
Bug 21015: fix performance issue with C4::Members

This is the proposed patch but please run the tests as I have not done so
(yet).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 11:35:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 09:35:15 +0000
Subject: [Koha-bugs] [Bug 20647] When ILL is enabled the hover effect on the
 ILL requests button is wrong.
In-Reply-To: <bug-20647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20647-70-To7REQ6jZ0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75456|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 75456
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75456
Bug 20647: Correct hover effect for Ill module

Obsoleting my patch.. Owens is much nicer.. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 11:37:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 09:37:55 +0000
Subject: [Koha-bugs] [Bug 20647] When ILL is enabled the hover effect on the
 ILL requests button is wrong.
In-Reply-To: <bug-20647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20647-70-gpETahTC7Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75785|0                           |1
        is obsolete|                            |

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 76557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76557&action=edit
Bug 20647: (alternate) When ILL is enabled the hover effect on the ILL requests
button is wrong

This alternate patch adds a new icon to the sprite image which gives
icons to the link on the staff client home page. It modifies the CSS
positioning for all the links as the new image sprite is somewhat
different.

The SVG file from which the sprite image was generated is also updated,
and the about page has been updated to give credit to the creator of the
icon.

Unrelated change: The cataloging link is moved to the second column.
Although it's probably rare for all modules to be enabled and available,
this puts the same number of links in each column.

To test, apply the patch and clear your browser cache if necessary. With
interlibrary loan enabled, view the staff client home page and confirm
that all the module links look correct, including when you hover your
mouse over them.

Confirm that the about page lists the new icon under the "licenses" tab.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 11:38:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 09:38:39 +0000
Subject: [Koha-bugs] [Bug 20647] When ILL is enabled the hover effect on the
 ILL requests button is wrong.
In-Reply-To: <bug-20647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20647-70-QaRSljgxct@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Signing off, works as expected..  :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 11:42:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 09:42:08 +0000
Subject: [Koha-bugs] [Bug 20945] Report params not escaped when downloading
In-Reply-To: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20945-70-2FdkPPr6nQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76423|0                           |1
        is obsolete|                            |

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 76558
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76558&action=edit
Bug 20945: Escape SQL parameters when constructing download links

TO test:
1 - Create a report that takes a parameter
2 - Enter a parameter containing '%'
3 - Attempt to download report, note link is misconstructed
4 - Apply patch
5 - Reload
6 - Note URL is now correct

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 11:42:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 09:42:50 +0000
Subject: [Koha-bugs] [Bug 20945] Report params not escaped when downloading
In-Reply-To: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20945-70-fwW8o5NOrB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Trivial fix that works as expected, Passed QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 11:54:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 09:54:48 +0000
Subject: [Koha-bugs] [Bug 21016] New: Plugins: Expand usage of opac_js
 method, or create intranet_js
Message-ID: <bug-21016-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21016

            Bug ID: 21016
           Summary: Plugins: Expand usage of opac_js method, or create
                    intranet_js
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew.isherwood at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

There is an opac_js method which gives the opportunity for a plugin to return
some Javascript to be embedded in the OPAC. I propose that we either make this
method more generic, perhaps, plugin_js, so it can reasonably be used for JS
for either the OPAC or intranet, or we add an intranet_js method for embedding
JS in plugins that touch the staff client.

I suspect there's a use case for a plugin wanting to return different JS for
the OPAC and staff client, so the latter idea might be preferable.

The inspiration for this proposal is the CLA Check Permissions plugin (Bug
20968), the current workflow is a bit clunky with the button on the Bib toolbar
taking the user to a page generated by the plugin, on which the main Javascript
is run, opening a modal. The plugin has no use for the additional page, but is
necessary to run the Javascript. The proposal would allow us to run the
Javascript directly in the Bib view, which would make for a better UX.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 11:55:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 09:55:51 +0000
Subject: [Koha-bugs] [Bug 21016] Plugins: Expand usage of opac_js method,
 or create intranet_js
In-Reply-To: <bug-21016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21016-70-tUYEG5objv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21016

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew.isherwood at ptfs-europ
                   |                            |e.com,
                   |                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 11:59:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 09:59:00 +0000
Subject: [Koha-bugs] [Bug 21017] New: Plugins: Allow for post-install
	configure flag
Message-ID: <bug-21017-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21017

            Bug ID: 21017
           Summary: Plugins: Allow for post-install configure flag
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew.isherwood at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

Some plugins, such as the CLA Check Permissions plugin, require configuring
before they can be used.

I propose a flag, probably in the plugin's $metadata hashref that indicates
whether the plugin should redirect the user to the configure page immediately
after installation.

This would provide better UX, particularly with plugins that where it's not
immediately obvious that configuration is required before use

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 11:59:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 09:59:22 +0000
Subject: [Koha-bugs] [Bug 21017] Plugins: Allow for post-install configure
	flag
In-Reply-To: <bug-21017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21017-70-sRekXLvyrB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21017

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew.isherwood at ptfs-europ
                   |                            |e.com,
                   |                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 13:06:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 11:06:51 +0000
Subject: [Koha-bugs] [Bug 21018] New: OPAC Resource URL Broken if Tracklinks
	is enabled
Message-ID: <bug-21018-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018

            Bug ID: 21018
           Summary: OPAC Resource URL Broken if Tracklinks is enabled
 Change sponsored?: ---
           Product: Koha
           Version: 17.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: mkpelletier at gmail.com
        QA Contact: testopia at bugs.koha-community.org

With Tracklinks enabled in configuration (anonymous or otherwise), URI's in
952u return a koha 404 error.  However, if the link is also recorded in 856u,
the 952u link works. As soon as you turn off tracklinks, 952u URI's function
normally.

I tested the above only on https URI's. Perhaps this is related to #18714
earlier marked as invalid?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 13:28:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 11:28:33 +0000
Subject: [Koha-bugs] [Bug 20945] Report params not escaped when downloading
In-Reply-To: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20945-70-AMrucKpyNn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Any good reasons to not escape param_name as well?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 14:10:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 12:10:16 +0000
Subject: [Koha-bugs] [Bug 9557] Koha does not include EANs from MARC records
 in Syndetics links on OPAC pages
In-Reply-To: <bug-9557-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9557-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9557-70-QmoBrdZvqx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9557

Cab Vinton <bibliwho at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bibliwho at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 14:20:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 12:20:42 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-YztRtLxe3i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 14:20:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 12:20:47 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-CIjDMZ55cw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23168|0                           |1
        is obsolete|                            |

--- Comment #40 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76559&action=edit
Bug 7376 Transfer limits should be checked at check-in

Test case:
* UseBranchTransferLimits must be set
* define your branch transfer limit. Refuse transfers from libraryA to libraryB
* checkout a book owned by libraryB, from libraryB, with a librarian located at
libraryB
* move the librarian to libraryA ("Set Library" link top/right)
* check-in the book => it's possible whatever your setup

After the patch, the behaviour respect the branch transfer limit parameter: you
can check-in if you accept transfers, you can't if you refuse them.

(Note: IndependantBranches must be OFF, otherwise it's not possible to do the
checkin whatever the branch transfer limits)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 14:21:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 12:21:15 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-UtdRZu5joJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|olli-antti.kivilahti at jns.fi |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #41 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Original patch rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 14:27:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 12:27:29 +0000
Subject: [Koha-bugs] [Bug 21019] New: Borrower address not shown on reserve
 pop-up on returns.pl
Message-ID: <bug-21019-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21019

            Bug ID: 21019
           Summary: Borrower address not shown on reserve pop-up on
                    returns.pl
 Change sponsored?: ---
           Product: Koha
           Version: 17.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Bug 17829 changed the variable for address from 'address' to 'boraddress' which
is not used in the template

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 14:28:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 12:28:01 +0000
Subject: [Koha-bugs] [Bug 21019] Borrower address not shown on reserve
 pop-up on returns.pl
In-Reply-To: <bug-21019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21019-70-5484bUOuzh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21019

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17829
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m,
                   |                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829
[Bug 17829] Move GetMember to Koha::Patron
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 14:28:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 12:28:01 +0000
Subject: [Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron
In-Reply-To: <bug-17829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17829-70-omTutTlD7A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |21019


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21019
[Bug 21019] Borrower address not shown on reserve pop-up on returns.pl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 14:35:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 12:35:47 +0000
Subject: [Koha-bugs] [Bug 10503] incorrect initialization parameters passed
 to Memoize::Memcached
In-Reply-To: <bug-10503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10503-70-Gwz0OfdjJ4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10503

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
No longer valid.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 14:45:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 12:45:12 +0000
Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout
 form, with collapsed settings panel
In-Reply-To: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20959-70-9NT8rdiQV8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 14:45:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 12:45:15 +0000
Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout
 form, with collapsed settings panel
In-Reply-To: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20959-70-THtNHSmsc5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76526|0                           |1
        is obsolete|                            |

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76560&action=edit
Bug 20959: Style checkin form more like the checkout form, with collapsed
settings panel

This patch modifies the structure of the checkin form so that settings
(Specify return date, book drop mode, forgive overdue charges) are in a
collapsed panel when inactive. The style of the barcode field and the
mode notification messages has been changed to reduce the vertical
motion of the form when selecting options.

Some class names have been changed in circulation.tt and circulation.js
to make them appropriate for use on both forms.

To test, apply the patch and clear your browser cache if necessary.

 - View the checkin page. The "checkin settings" panel should be
   collapsed by default.
 - Confirm that the settings panel collapses and expands as it should.
 - Confirm that selecting "Forgive overdue charges" or "Book drop mode"
   trigger the display of the correct message and that the style of the
   barcode field is changed.
 - Confirm that after submitting a barcode for check-in, the
   settings panel stays open and your selected settings are still
   selected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 14:48:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 12:48:34 +0000
Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout
 form, with collapsed settings panel
In-Reply-To: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20959-70-LPsNM8IgJP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76526|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 14:48:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 12:48:39 +0000
Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout
 form, with collapsed settings panel
In-Reply-To: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20959-70-dwMoeweXIN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76560|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 14:51:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 12:51:24 +0000
Subject: [Koha-bugs] [Bug 21016] Plugins: Expand usage of opac_js method,
 or create intranet_js
In-Reply-To: <bug-21016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21016-70-PzSDOEUAZP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21016

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
I would *definitely* say we would want separate intranet_js *AND* intranet_head
methods to keep parity with the opac feature. It also makes sense to have
separate methods instead of re-using the opac ones.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 14:54:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 12:54:01 +0000
Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout
 form, with collapsed settings panel
In-Reply-To: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20959-70-iAwvOeClGD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 14:54:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 12:54:04 +0000
Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout
 form, with collapsed settings panel
In-Reply-To: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20959-70-B3M56PDnXn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76561
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76561&action=edit
Bug 20959: (follow-up) Prevent checkin button from wrapping

This follow-up wraps the checkin form in a div to prevent the button
from wrapping to the line below the input.

To test, apply the patch and clear your browser cache if necessary.

View the checkin page to confirm that there isn't a layout problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 14:56:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 12:56:40 +0000
Subject: [Koha-bugs] [Bug 21019] Borrower address not shown on reserve
 pop-up on returns.pl
In-Reply-To: <bug-21019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21019-70-rNRydTi8Qb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21019

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 14:56:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 12:56:43 +0000
Subject: [Koha-bugs] [Bug 21019] Borrower address not shown on reserve
 pop-up on returns.pl
In-Reply-To: <bug-21019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21019-70-3g2Iqc43d6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21019

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76562&action=edit
Bug 21019: Fix display of patron's address on reserve pop-up on returns.pl

Caused by
  commit 2b90ea2cb0e5e976de7ddef0151ae83d8ac578e6
  Bug 17829: Move GetMember to Koha::Patron

address variable has been replaced by boraddress (wrong resolution
conflict?)

It does not affect master (thanks bug 18789)

Test plan:
Confirm the address of the patron with a hold placed on the item is now
displayed when this item is checked in

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 14:58:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 12:58:30 +0000
Subject: [Koha-bugs] [Bug 21020] New: Return branch not set for transfer
	when using SIP
Message-ID: <bug-21020-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020

            Bug ID: 21020
           Summary: Return branch not set for transfer when using SIP
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

Bug 17680 replace GetItemIssue with a call to the Issue object - the code in
/C4/SIP/ILS/Transaction/Checkin.pm expects item information

I think line 97:
        $self->{item}->destination_loc($iteminformation->{homebranch});
Should be:
        $self->{item}->destination_loc($iteminformation->item->homebranch);

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 14:58:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 12:58:33 +0000
Subject: [Koha-bugs] [Bug 21019] Borrower address not shown on reserve
 pop-up on returns.pl
In-Reply-To: <bug-21019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21019-70-t76g1GGLJG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21019

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 14:59:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 12:59:07 +0000
Subject: [Koha-bugs] [Bug 21020] Return branch not set for transfer when
	using SIP
In-Reply-To: <bug-21020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21020-70-777UBhoXG2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17680
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |kyle at bywatersolutions.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680
[Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 14:59:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 12:59:07 +0000
Subject: [Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with
 Koha::Checkouts
In-Reply-To: <bug-17680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17680-70-TB6fP3AIbX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |21020


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020
[Bug 21020] Return branch not set for transfer when using SIP
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 15:08:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 13:08:36 +0000
Subject: [Koha-bugs] [Bug 21020] Return branch not set for transfer when
	using SIP
In-Reply-To: <bug-21020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21020-70-AgZ0F83t6e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 15:08:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 13:08:40 +0000
Subject: [Koha-bugs] [Bug 21020] Return branch not set for transfer when
	using SIP
In-Reply-To: <bug-21020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21020-70-noSCEQTgTU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76563
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76563&action=edit
Bug 21020: Fix return branch on transfer - SIP

Caused by
  commit 546379cc92b733cb29a0b70247a72c770afdad26
  Bug 17680: C4::Circulation - Remove GetItemIssue, simple calls

Since this commit AddReturn return a Koha::Issue object, not a hashref
with item's info.

Test plan:
?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 15:08:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 13:08:51 +0000
Subject: [Koha-bugs] [Bug 21020] Return branch not set for transfer when
	using SIP
In-Reply-To: <bug-21020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21020-70-Q6sKg5OHdA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 15:14:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 13:14:18 +0000
Subject: [Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is
	enabled
In-Reply-To: <bug-21018-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21018-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21018-70-x8zNer8YYI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Depends on|                            |19847


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19847
[Bug 19847] tracklinks.pl accepts any url from a parameter for proxying
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 15:14:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 13:14:18 +0000
Subject: [Koha-bugs] [Bug 19847] tracklinks.pl accepts any url from a
 parameter for proxying
In-Reply-To: <bug-19847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19847-70-6tfkVbefMa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19847

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |21018


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018
[Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 15:14:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 13:14:32 +0000
Subject: [Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is
	enabled
In-Reply-To: <bug-21018-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21018-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21018-70-rLuNafnUOV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|17.11                       |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 15:16:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 13:16:45 +0000
Subject: [Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin
 integration into catalogue
In-Reply-To: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20968-70-9vB4VjagCl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 15:17:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 13:17:06 +0000
Subject: [Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin
 integration into catalogue
In-Reply-To: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20968-70-hanTpYG3XV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 15:17:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 13:17:09 +0000
Subject: [Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin
 integration into catalogue
In-Reply-To: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20968-70-12yBAiuiHm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76375|0                           |1
        is obsolete|                            |
  Attachment #76530|0                           |1
        is obsolete|                            |
  Attachment #76540|0                           |1
        is obsolete|                            |
  Attachment #76541|0                           |1
        is obsolete|                            |
  Attachment #76555|0                           |1
        is obsolete|                            |

--- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76564&action=edit
Bug 20968: Add hooks into cat-toolbar.inc to display buttons

This commit adds hooks into cat-toolbar.inc to allow the display of
arbitrary buttons as supplied by plugins within the
intranet_catalog_biblio_enhancements class that provide the method
get_toolbar_button

To test:

1) Download the plugin from
https://github.com/PTFS-Europe/cla-permissions-check-plugin
2) Follow the installation instructions from:
https://github.com/PTFS-Europe/cla-permissions-check-plugin
3) TEST: Observe that the "CLA Check Permissions" button takes the user
to the Check Permissions page and a modal displays containing the
results of the query
4) Remove the API key from the plugin "Configuration" page
5) TEST: Ensure that the "CLA Check Permissions" button takes the user
to the Check Permissions page and message displays informing the user
that "Did not receive required request parameters"

https://bugs.koha-community.org/show_bug.cgi?id=20968

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 15:17:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 13:17:16 +0000
Subject: [Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin
 integration into catalogue
In-Reply-To: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20968-70-MV60I4BQRo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76565
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76565&action=edit
Bug 20968: (follow-up) Respond to feedback

This patch:

- Removes the unecessary testing for
intranet_catalog_biblio_enhancements method in detail.pl
- Renames get_toolbar_button to get_intranet_catalog_toolbar_button

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 15:17:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 13:17:19 +0000
Subject: [Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin
 integration into catalogue
In-Reply-To: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20968-70-b2ASiL8NcX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76566
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76566&action=edit
Bug 20968: Add unit tests

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 15:17:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 13:17:22 +0000
Subject: [Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin
 integration into catalogue
In-Reply-To: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20968-70-t9mgq0cB2t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76567&action=edit
Bug 20968: Rename method get_intranet_catalog_toolbar_button to
intranet_catalog_biblio_enhancements_toolbar_button

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 15:17:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 13:17:25 +0000
Subject: [Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin
 integration into catalogue
In-Reply-To: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20968-70-CsfZoa5VIu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 76568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76568&action=edit
Bug 20968: (follow-up) Replace tabs with spaces

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 15:31:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 13:31:29 +0000
Subject: [Koha-bugs] [Bug 21020] Return branch not set for transfer when
	using SIP
In-Reply-To: <bug-21020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21020-70-T7R7qyEAIA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Jonathan, shouldn't "$issue->issue->homebranch" be "$issue->item->homebranch"?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 15:33:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 13:33:35 +0000
Subject: [Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is
	enabled
In-Reply-To: <bug-21018-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21018-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21018-70-ArK3kLYAb4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 15:33:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 13:33:39 +0000
Subject: [Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is
	enabled
In-Reply-To: <bug-21018-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21018-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21018-70-pafCe8DMuy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76569&action=edit
Bug 21018: Fix TrackClicks for 952$u

Caused by
  commit 51b6cf2aafbfb45b9fcb072403b986fe3c2add53
  Bug 19847: Track links within the records and 404 for others

We should also accept uri stored in items.uri (952$u)

Test plan:
- Turn on TrackClicks
- Defined uri for some items
- At the OPAC click on the link (from opac-detail.pl)
=> Without this patch you will get 404 (redirected from tracklinks.pl)
=> With this patch applied you will be redirected correctly and the
linktracker will be filled correctly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 15:34:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 13:34:47 +0000
Subject: [Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is
	enabled
In-Reply-To: <bug-21018-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21018-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21018-70-Mg4ISFBym8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Severity|minor                       |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 15:35:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 13:35:27 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
	Elasticsearch
In-Reply-To: <bug-19893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19893-70-YZWLVsuw59@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

--- Comment #69 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Bug 20073 is now in.. I like the look of this one and will devote a bit of time
to help QA it if we get a signoff soon.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 15:39:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 13:39:36 +0000
Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout
 form, with collapsed settings panel
In-Reply-To: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20959-70-hs6Vw5Ht8b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Still not: https://screenshots.firefox.com/fqd4mfODVhwLxDXI/pro.kohadev.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 15:40:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 13:40:57 +0000
Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout
 form, with collapsed settings panel
In-Reply-To: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20959-70-oYxqz6h4wn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #8)
> Still not: https://screenshots.firefox.com/fqd4mfODVhwLxDXI/pro.kohadev.org

Well yes, it fixed the position of the button.
But now the messages on the right (settings) overlap the button.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 15:43:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 13:43:01 +0000
Subject: [Koha-bugs] [Bug 21021] New: when editing a rule in the french
 issuing rules interface,
 on shelf holds parameter is systematically set to yes
Message-ID: <bug-21021-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21021

            Bug ID: 21021
           Summary: when editing a rule in the french issuing rules
                    interface, on shelf holds parameter is systematically
                    set to yes
 Change sponsored?: ---
           Product: Koha
           Version: 16.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: koha at univ-lyon3.fr
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

The problem occurs on koha 16.11 in the french interface (not in thr english
one).

Whatever rule you edit in the issuing rules (french interface), the current
value of on shelf holds is not kept : it's systematically positionned to yes (I
suppose because it's the first item of the scrolling list). So, if you don't
pay attention to this, when modifying an other parameter you risk to change
this reservation rule without being aware of.

Olivier Crouzet

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 15:43:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 13:43:18 +0000
Subject: [Koha-bugs] [Bug 21021] when editing a rule in the french issuing
 rules interface, on shelf holds parameter is systematically set to yes
In-Reply-To: <bug-21021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21021-70-g0mUApHz7J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21021

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at univ-lyon3.fr
           Priority|P5 - low                    |P1 - high

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 15:44:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 13:44:10 +0000
Subject: [Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return
 results alphabetically
In-Reply-To: <bug-18635-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18635-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18635-70-fZGSJSnGKV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #12)
> Nick,
> What are you doing here?!
> Deleting tests without further notice?
> 
> Failed QA

Which tests are missing? Maybe as_list, is it what you meant?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 15:46:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 13:46:18 +0000
Subject: [Koha-bugs] [Bug 6828] Add Admin Dashboard for staff users.
In-Reply-To: <bug-6828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6828-70-6y73YZNqYw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828

--- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Cab Vinton from comment #18)
> This still seems like a really neat idea.
> 
> It's been 5 years + since the idea first came up.
> 
> Is this still in the works?

Did you test the rebase patches?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 15:49:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 13:49:17 +0000
Subject: [Koha-bugs] [Bug 6262] Remove overdues report warning label on
 circulation start page
In-Reply-To: <bug-6262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6262-70-r7sNhSi0LU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6262

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Fixed by 20322

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 15:54:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 13:54:57 +0000
Subject: [Koha-bugs] [Bug 10102] don't show empty novelist tab if no data
In-Reply-To: <bug-10102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10102-70-VNwAukjMuI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10102

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
In my tests this has been resolved--presumably on the Novelist side of things.
If anyone finds otherwise please re-open with additional details.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:00:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 14:00:04 +0000
Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an
	invoice
In-Reply-To: <bug-19166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19166-70-6vhE1YtzjX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #62 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
QA Comment:

Acquisitions is one of the few places where we're fairly consistent with table
names (i.e. they have a prepended aq_).. did we want to follow that convention
through here too?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:02:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 14:02:02 +0000
Subject: [Koha-bugs] [Bug 18031] Update bootstrap in opac
In-Reply-To: <bug-18031-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18031-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18031-70-qRkLOqDO3s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18031

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---


*** This bug has been marked as a duplicate of bug 20168 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:02:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 14:02:03 +0000
Subject: [Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to
	bootstrap v4
In-Reply-To: <bug-20168-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20168-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20168-70-Gob5nTagtn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
*** Bug 18031 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:02:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 14:02:06 +0000
Subject: [Koha-bugs] [Bug 21022] New: Exceptions should skip stringifying if
 message manually passed
Message-ID: <bug-21022-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022

            Bug ID: 21022
           Summary: Exceptions should skip stringifying if message
                    manually passed
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Bug 20590 introduced a way to create more useful and testable exception
messages. But we should still be allowed to pass manual messages, because we
might not have all the information we need to build the stringified version
like it proposed. Notably on Koha::Object->store, in which we parse the DBI
warning.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:02:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 14:02:03 +0000
Subject: [Koha-bugs] [Bug 18029] Use templates for generating pagination in
	opac
In-Reply-To: <bug-18029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18029-70-uuYBcjUw2Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18029
Bug 18029 depends on bug 18031, which changed state.

Bug 18031 Summary: Update bootstrap in opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18031

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:02:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 14:02:20 +0000
Subject: [Koha-bugs] [Bug 21022] Exceptions should skip stringifying if
 message manually passed
In-Reply-To: <bug-21022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21022-70-q40KUTs5zp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20590
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20590
[Bug 20590] Koha::Exceptions does not stringify the exceptions
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:02:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 14:02:20 +0000
Subject: [Koha-bugs] [Bug 20590] Koha::Exceptions does not stringify the
	exceptions
In-Reply-To: <bug-20590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20590-70-m1XA0wEbUJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20590

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |21022


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022
[Bug 21022] Exceptions should skip stringifying if message manually passed
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:02:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 14:02:38 +0000
Subject: [Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to
	bootstrap v4
In-Reply-To: <bug-20168-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20168-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20168-70-w1Misv7vPi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Elias from comment #0)
> I'm currently working on updating the bootstrap template to bootstrap v4.

Is this something you're still working on?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:08:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 14:08:24 +0000
Subject: [Koha-bugs] [Bug 21021] when editing a rule in the french issuing
 rules interface, on shelf holds parameter is systematically set to yes
In-Reply-To: <bug-21021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21021-70-ZvisLit0ML@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21021

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
It's an issue in the translation:
"Si tout est indisponible"
vs
"Si tous indisponibles"

The correct option is selected if the text for the option is the same as the
text in the cell above.

Note that it's fixed on master.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:09:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 14:09:43 +0000
Subject: [Koha-bugs] [Bug 21020] Return branch not set for transfer when
	using SIP
In-Reply-To: <bug-21020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21020-70-i99h8QgmY6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76563|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76570&action=edit
Bug 21020: Fix return branch on transfer - SIP

Caused by
  commit 546379cc92b733cb29a0b70247a72c770afdad26
  Bug 17680: C4::Circulation - Remove GetItemIssue, simple calls

Since this commit AddReturn return a Koha::Issue object, not a hashref
with item's info.

Test plan:
?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:10:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 14:10:11 +0000
Subject: [Koha-bugs] [Bug 21020] Return branch not set for transfer when
	using SIP
In-Reply-To: <bug-21020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21020-70-fzHzZieqe5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Kyle M Hall from comment #2)
> Jonathan, shouldn't "$issue->issue->homebranch" be
> "$issue->item->homebranch"?

Whoops, yes of course! Thanks for catching that :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:18:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 14:18:02 +0000
Subject: [Koha-bugs] [Bug 21022] Exceptions should skip stringifying if
 message manually passed
In-Reply-To: <bug-21022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21022-70-F32LCPQV4c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76571&action=edit
Bug 21022: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:18:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 14:18:00 +0000
Subject: [Koha-bugs] [Bug 13245] Send Cart via Email corrupts some Unicode
	characters
In-Reply-To: <bug-13245-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13245-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13245-70-HxlFXiv4ZP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13245

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #21 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Pongtawat from comment #18)

> However, I leave this bug open since Filippos add another problem with send
> cart here.

I don't know what problem this refers to. If anyone knows, please open a new
bug for it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:18:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 14:18:09 +0000
Subject: [Koha-bugs] [Bug 21022] Exceptions should skip stringifying if
 message manually passed
In-Reply-To: <bug-21022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21022-70-MedVUkRJ6U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76572&action=edit
Bug 21022: Use passed message if present

This patch makes 'full_message' use the passed exception message instead
of trying to build it from the parameters. This is particularly useful
for some situations in which we don't have all the information but would
like to keep using the same exception.

To test:
- Apply this patchset
- Run:
  $ kshell
 k$ prove t/Koha/Exceptions.t
=> SUCCESS: Tests pass!
- Sign off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:18:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 14:18:19 +0000
Subject: [Koha-bugs] [Bug 21022] Exceptions should skip stringifying if
 message manually passed
In-Reply-To: <bug-21022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21022-70-GKEJurTNWv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76573&action=edit
Bug 21022: (follow-up) Move overloaded full_message method to subclass

We shouldn't have it overloaded on the base class, as it could get huge
and difficult to find things, and read.

This patch moves things to Koha::Exceptions::Object. We should overload
the full_message method on each exceptions class, as needed.

To test:
- Run:
  $ kshell
 k$ prove t/Koha/Exceptions.t
=> SUCCESS: Tests still pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:18:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 14:18:41 +0000
Subject: [Koha-bugs] [Bug 21022] Exceptions should skip stringifying if
 message manually passed
In-Reply-To: <bug-21022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21022-70-tMVAxCico2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:27:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 14:27:50 +0000
Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an
	invoice
In-Reply-To: <bug-19166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19166-70-ARkIPAc6Ma@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|katrin.fischer at bsz-bw.de    |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:29:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 14:29:44 +0000
Subject: [Koha-bugs] [Bug 21020] Return branch not set for transfer when
	using SIP
In-Reply-To: <bug-21020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21020-70-4ofOypydGB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76570|0                           |1
        is obsolete|                            |

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 76574
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76574&action=edit
Bug 21020: Fix return branch on transfer - SIP

Caused by
  commit 546379cc92b733cb29a0b70247a72c770afdad26
  Bug 17680: C4::Circulation - Remove GetItemIssue, simple calls

Since this commit AddReturn return a Koha::Issue object, not a hashref
with item's info.

Test plan:
1 - Enable SIP server on your test instance
   For kohadevbox:
   cp /etc/koha/SIPConfig.xml /etc/koha/sites/kohadev/
   create patron with user/pass term1/term1 and grant circulation
   privileges
2 - enable AutomaticItemReturn
3 - Checkin an item which will generate a transfer via SIP2:
   perl /home/vagrant/kohaclone/misc/sip_cli_emulator.pl -a localhost -p
   6001 -su term1 -sp term1 -l LPL --item {BARCODE} -m checkin -t
   CR
4 - Note no CT field
5 - Apply patch
6 - Repeate checkin via SIP2
7 - Transfer destination is correctly returned in CT

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:29:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 14:29:41 +0000
Subject: [Koha-bugs] [Bug 21020] Return branch not set for transfer when
	using SIP
In-Reply-To: <bug-21020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21020-70-nZ7AyNfns4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:36:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 14:36:27 +0000
Subject: [Koha-bugs] [Bug 21022] Exceptions should skip stringifying if
 message manually passed
In-Reply-To: <bug-21022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21022-70-r7cGne2r3p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20287


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287
[Bug 20287] Move AddMember and ModMember to Koha::Patron
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:36:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 14:36:27 +0000
Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
In-Reply-To: <bug-20287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20287-70-MMcYAWT84Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |21022


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022
[Bug 21022] Exceptions should skip stringifying if message manually passed
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:41:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 14:41:33 +0000
Subject: [Koha-bugs] [Bug 20223] Merge members-menu and circ-menu inc files
In-Reply-To: <bug-20223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20223-70-is8xoUnwCn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20223

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:41:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 14:41:36 +0000
Subject: [Koha-bugs] [Bug 20223] Merge members-menu and circ-menu inc files
In-Reply-To: <bug-20223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20223-70-wrDlx59KMq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20223

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76575
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76575&action=edit
Bug 20223: Merge members-menu and circ-menu inc files

This patch removes members-menu.inc and replaces the last functional use
of it with a call to circ-menu.inc.

An invalid use of members-menu.inc has been removed from member.tt.

To test, apply the patch and open a patron record for editing. The
sidebar menu should look correct and all sidebar links should work
correctly.

View the patrons home page and confirm that nothing has broken.

Search the Koha codebase for references to members-menu.inc. There
should be none.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:49:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 14:49:34 +0000
Subject: [Koha-bugs] [Bug 6828] Add Admin Dashboard for staff users.
In-Reply-To: <bug-6828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6828-70-qBrsnMPo8r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828

--- Comment #23 from Cab Vinton <bibliwho at gmail.com> ---
(In reply to Jonathan Druart from comment #22)
> (In reply to Cab Vinton from comment #18)

> Did you test the rebase patches?

If this is really directed at me, No.

Just a humble librarian who has no idea how to test patches, etc.

Willing to consider a career change, however ;-)

Cab

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:51:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 14:51:44 +0000
Subject: [Koha-bugs] [Bug 21023] Remove warning in
 t/db_dependent/Circulation/Chargelostitem.t
In-Reply-To: <bug-21023-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21023-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21023-70-Aw9hc2uUb6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21023

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:51:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 14:51:38 +0000
Subject: [Koha-bugs] [Bug 21023] New: Remove warning in
 t/db_dependent/Circulation/Chargelostitem.t
Message-ID: <bug-21023-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21023

            Bug ID: 21023
           Summary: Remove warning in
                    t/db_dependent/Circulation/Chargelostitem.t
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

To reproduce:
- Run:
  $ kshell
 k$ prove t/db_dependent/Circulation/Chargelostitem.t
=> FAIL: Warning is displayed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:54:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 14:54:00 +0000
Subject: [Koha-bugs] [Bug 21023] Remove warning in
 t/db_dependent/Circulation/Chargelostitem.t
In-Reply-To: <bug-21023-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21023-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21023-70-tIYtctKHio@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21023

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:54:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 14:54:04 +0000
Subject: [Koha-bugs] [Bug 21023] Remove warning in
 t/db_dependent/Circulation/Chargelostitem.t
In-Reply-To: <bug-21023-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21023-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21023-70-pIN6Tvp3Tb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21023

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76576
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76576&action=edit
Bug 21023: Remove warning in t/db_dependent/Circulation/Chargelostitem.t

To test:
- Run:
  $ kshell
 k$ prove t/db_dependent/Circulation/Chargelostitem.t
=> FAIL: Warning is displayed
- Apply this patch
- Run:
 k$ prove t/db_dependent/Circulation/Chargelostitem.t
=> SUCCESS: Tests pass! No warning!
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:57:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 14:57:34 +0000
Subject: [Koha-bugs] [Bug 6828] Add Admin Dashboard for staff users.
In-Reply-To: <bug-6828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6828-70-pTvJFWB2bC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
There are sandboxes to test patches without any technical skills. Wrong answer
;)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 17:17:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 15:17:25 +0000
Subject: [Koha-bugs] [Bug 15524] Set limit on maximum possible holds per
 patron by category
In-Reply-To: <bug-15524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15524-70-BkonKru0Yo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Passed QA

--- Comment #39 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #38)
> Kyle,
> 
> Go to "Default checkout, hold and return policy", you do not see "Total
> holds allowed", fill the other fields, save: default_circ_rules.holdallowed
> is filled.
> We could add it to the interface and make it configurable, do not you think?

holdallowed doesn't define how many holds may be placed, it defines what items
a patron may place holds on. It's already revealed in the rules editor!

> 
> Also if we add "max_holds", maybe we should rename "holdallowed" then.

Again, not the same thing.

> 
> After that is done, the code in CanItemBeReserved could be replaced with a
> call to GetBranchBorrowerCircRule.
> 
> Without these changes we add more confusion to the code in my opinion.
> 
> I will not have the time to provide such change before the release.
> 
> Setting to in discussion to get other QAer opinions on these patches.
> 
> Feel free to provide a patch if you think my requests make sense to you.

I think your comment is based on a fundamental misunderstanding of what
holdallowed does. If I'm wrong let me know!

We could definitely add max_holds to the default_circ_rules table, but that
should be done on another bug as it is out of scope for this one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 17:32:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 15:32:10 +0000
Subject: [Koha-bugs] [Bug 20590] Koha::Exceptions does not stringify the
	exceptions
In-Reply-To: <bug-20590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20590-70-46bcdqXcpw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20590

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 17:44:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 15:44:51 +0000
Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an
	invoice
In-Reply-To: <bug-19166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19166-70-XRIHpnNijL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

--- Comment #63 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Encumber is a really odd term.. I'm wondering where it came from.. even as a
native english speaker I can't entirely work out what it means in this context.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 17:50:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 15:50:11 +0000
Subject: [Koha-bugs] [Bug 20216] Editing itemtypes does not pull existing
 values correctly
In-Reply-To: <bug-20216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20216-70-qbN8C6y3tQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20216

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Frido, I think I missed this one, needed for 17.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 17:50:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 15:50:52 +0000
Subject: [Koha-bugs] [Bug 20216] Editing itemtypes does not pull existing
 values correctly
In-Reply-To: <bug-20216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20216-70-3SNzKH9xrD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20216

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
                 CC|                            |tomascohen at gmail.com
         Resolution|FIXED                       |---

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 17:51:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 15:51:00 +0000
Subject: [Koha-bugs] [Bug 20216] Editing itemtypes does not pull existing
 values correctly
In-Reply-To: <bug-20216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20216-70-otAq4KEQZI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20216

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 17:51:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 15:51:16 +0000
Subject: [Koha-bugs] [Bug 20216] Editing itemtypes does not pull existing
 values correctly
In-Reply-To: <bug-20216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20216-70-pUdO3TftDN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20216

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 17:51:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 15:51:24 +0000
Subject: [Koha-bugs] [Bug 20216] Editing itemtypes does not pull existing
 values correctly
In-Reply-To: <bug-20216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20216-70-bCp0L1agcd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20216

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 17:51:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 15:51:07 +0000
Subject: [Koha-bugs] [Bug 20216] Editing itemtypes does not pull existing
 values correctly
In-Reply-To: <bug-20216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20216-70-PnHTij1RVk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20216

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 17:55:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 15:55:11 +0000
Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an
	invoice
In-Reply-To: <bug-19166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19166-70-UTtdyAYayq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

--- Comment #64 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I take that last comment back.. once I found the right accounting book to read
it made a lot more sense.. though I'm not sure how well it translates to
credits.. 'encumbered' tends to mean 'committed to paying', but a credit it
sorta the opposite.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 18:49:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 16:49:34 +0000
Subject: [Koha-bugs] [Bug 10562] Improve Leader06 Type Labels in
 MARC21slim2OPACResults.xsl
In-Reply-To: <bug-10562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10562-70-YxzbncCW7q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10562

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 76577
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76577&action=edit
Bug 10562: Improve Leader06 Type Labels in MARC21slim2OPACResults.xsl

This patch takes the suggestions in Bug 10562 and implements those
changes in MARC21slim2OPACResults.xsl. This patch also makes the
following changes:

 - De-duplicate famfamfam icons: Remove the /silk subdirectory and move
   non-duplicates to famfamfam/; Correct paths to these images in
   templates and CSS
 - Improve the granularity of some material type icon choices: Show
   "Film," "Picture," or "Object" instead of "Visual material."
 - Remove unnecessary title attributes from material type images
 - Implement the kind of changes made in Bug 18235, "Add classes to
   material type icons on result lists and detail pages"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 18:49:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 16:49:31 +0000
Subject: [Koha-bugs] [Bug 10562] Improve Leader06 Type Labels in
 MARC21slim2OPACResults.xsl
In-Reply-To: <bug-10562-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10562-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10562-70-mU7PPjTWz7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10562

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 18:50:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 16:50:22 +0000
Subject: [Koha-bugs] [Bug 11025] Display UNIMARC fields having $5 subfield
 with related items
In-Reply-To: <bug-11025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11025-70-5OuFd3JXe9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11025

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 18:51:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 16:51:28 +0000
Subject: [Koha-bugs] [Bug 20410] Remove OpacGroupResults system preference
	and feature
In-Reply-To: <bug-20410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20410-70-8Wdca0ZSY6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20410

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 18:52:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 16:52:49 +0000
Subject: [Koha-bugs] [Bug 20414] Remove COinSinOPACResults system preference
 and make it always on
In-Reply-To: <bug-20414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20414-70-NwBzEctMBa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20414

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 18:55:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 16:55:33 +0000
Subject: [Koha-bugs] [Bug 20409] Remove OpacBrowseResults system preference
 and make it always on
In-Reply-To: <bug-20409-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20409-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20409-70-7FdORtyrGX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20409

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
See also Bug 20898.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 18:55:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 16:55:42 +0000
Subject: [Koha-bugs] [Bug 6828] Add Admin Dashboard for staff users.
In-Reply-To: <bug-6828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6828-70-FlZ7Kkhz8o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828

--- Comment #25 from Cab Vinton <bibliwho at gmail.com> ---
(In reply to Jonathan Druart from comment #24)
> There are sandboxes to test patches without any technical skills. Wrong
> answer ;)

Ah, not familiar w/ those. Think this would be a great training session for the
Koha libraries in New England. Will contact our friends at ByWater & see if
they have or know of anyone in our neck of the woods.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 19:08:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 17:08:16 +0000
Subject: [Koha-bugs] [Bug 21009] Item URIs longer than 255 bytes are
	silently truncated
In-Reply-To: <bug-21009-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21009-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21009-70-omST0whB8V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21009

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
            Version|17.11                       |master
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
             Status|NEW                         |ASSIGNED

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I do not know if I am going to address you concern here but I found a bug.

There is a "max length" value you can defined at framework level, to limit the
size of the input. But it is not taken into account on the add/edit item form.

It is a regression that has been introduced by
  commit 47d2de9c024bfb93d56184f298f334b20685cd86
  Bug 12176: Remove HTML from additem.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 19:12:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 17:12:55 +0000
Subject: [Koha-bugs] [Bug 21009] Item URIs longer than 255 bytes are
	silently truncated
In-Reply-To: <bug-21009-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21009-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21009-70-ZxdLSAUmya@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21009

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 19:12:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 17:12:58 +0000
Subject: [Koha-bugs] [Bug 21009] Item URIs longer than 255 bytes are
	silently truncated
In-Reply-To: <bug-21009-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21009-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21009-70-O8giXJQ634@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21009

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76578
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76578&action=edit
Bug 21009: Fix max length of inputs on editing/adding items

There is a "max length" value you can define at framework level to
limit the size of the input. But it is not taken into account on the
add/edit item form.

It is a regression that has been introduced by
  commit 47d2de9c024bfb93d56184f298f334b20685cd86
  Bug 12176: Remove HTML from additem.pl

max_length vs maxlength

Test plan:
- Define a maximum length for an item subfield
- Add or edit an item
=> Without this patch the maxlength attribute of the inputs are not
defined (maxlength="")
=> With this fix you will see the maxlength attributes correctly set
with the value you defined in the framework

Note:
We could/should set this value to the size of the DB column when mapped
For instance 952$u is mapped with items.uri, which is a varchar(255).
This length restriction should done at framework level

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 19:20:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 17:20:36 +0000
Subject: [Koha-bugs] [Bug 21000] debian/build-git-snapshot script ignores
	--distribution
In-Reply-To: <bug-21000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21000-70-RXtWdCY7pr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21000

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
There is a colision with debug:

 41     'distribution|D=s'  => \$distribution,

 46     'debug|d'           => \$debug,

It works with the long option name (--distribution)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 19:21:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 17:21:21 +0000
Subject: [Koha-bugs] [Bug 21000] debian/build-git-snapshot script ignores -D
In-Reply-To: <bug-21000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21000-70-UJtOEmRsAl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21000

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|debian/build-git-snapshot   |debian/build-git-snapshot
                   |script ignores              |script ignores -D
                   |--distribution              |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 19:24:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 17:24:47 +0000
Subject: [Koha-bugs] [Bug 20901] Koha/Patrons/Import.t fails on fresh
	database
In-Reply-To: <bug-20901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20901-70-YGrmcxHRVf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20901

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 19:24:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 17:24:35 +0000
Subject: [Koha-bugs] [Bug 20902] Labels/t_Batch.t fails on fresh database
In-Reply-To: <bug-20902-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20902-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20902-70-VUXBmNvGYd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20902

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Severity|normal                      |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 19:29:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 17:29:27 +0000
Subject: [Koha-bugs] [Bug 20864] Only set bibs_selected cookie when
 BrowseResultSelection is activated
In-Reply-To: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20864-70-g2uwDqBuTI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Bad one, there is a JS error on the search result, which breaks all JS
functionalities (add to basket, list, etc.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 19:56:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 17:56:41 +0000
Subject: [Koha-bugs] [Bug 21024] New: JS error on search result breaks JS
	functionalities
Message-ID: <bug-21024-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024

            Bug ID: 21024
           Summary: JS error on search result breaks JS functionalities
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: critical
          Priority: P5 - low
         Component: Staff Client
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Caused by bug 20864, some JS functions defined in commons.js are called by
search.pl

The JS error is:
  ReferenceError: resetSearchContext is not defined

It breaks add to basket, list, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 19:57:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 17:57:05 +0000
Subject: [Koha-bugs] [Bug 20864] Only set bibs_selected cookie when
 BrowseResultSelection is activated
In-Reply-To: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20864-70-TeQPuS0YLi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |21024

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #8)
> Bad one, there is a JS error on the search result, which breaks all JS
> functionalities (add to basket, list, etc.)

See bug 20864.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024
[Bug 21024] JS error on search result breaks JS functionalities
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 19:57:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 17:57:05 +0000
Subject: [Koha-bugs] [Bug 21024] JS error on search result breaks JS
	functionalities
In-Reply-To: <bug-21024-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21024-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21024-70-2mvPr96tQy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20864


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864
[Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is
activated
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 20:04:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 18:04:20 +0000
Subject: [Koha-bugs] [Bug 21024] JS error on search result breaks JS
	functionalities
In-Reply-To: <bug-21024-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21024-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21024-70-7tQdYMQcKl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 20:04:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 18:04:24 +0000
Subject: [Koha-bugs] [Bug 21024] JS error on search result breaks JS
	functionalities
In-Reply-To: <bug-21024-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21024-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21024-70-do5HuZJCeC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76579
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76579&action=edit
Bug 21024: (bug 20864 follow-up) Only set bibs_selected cookie when
BrowseResultSelection is activated

This is an attempt to fix correctly the problem bug 20864 tried to
solve.

The cookie bibs_selected must only be defined if BrowseResultSelection
is set.
Bug 20864 removed the inclusion of commons.js, but some code from
results.tt

We should include it and take care of the pref in each function.

Test plan:
Retest 19290 and 20864

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 20:13:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 18:13:12 +0000
Subject: [Koha-bugs] [Bug 21024] JS error on search result breaks JS
	functionalities
In-Reply-To: <bug-21024-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21024-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21024-70-uukjSblZpm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 20:27:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 18:27:52 +0000
Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item
In-Reply-To: <bug-14272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14272-70-CcopQpCUgX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76307|0                           |1
        is obsolete|                            |

--- Comment #52 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 76580
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76580&action=edit
Bug 14272: (follow-up) only display news available for a particular opac lang
[alternative patch]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 20:30:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 18:30:11 +0000
Subject: [Koha-bugs] [Bug 20765] Search for items by acqdate does not work
	in label batch
In-Reply-To: <bug-20765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20765-70-LbQUaEe80P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20765

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 20:30:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 18:30:15 +0000
Subject: [Koha-bugs] [Bug 20765] Search for items by acqdate does not work
	in label batch
In-Reply-To: <bug-20765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20765-70-JOOXYo4H1I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20765

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75306|0                           |1
        is obsolete|                            |

--- Comment #2 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 76581
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76581&action=edit
Bug 20765: Fix search for items by acqdate in label batch

In Tools >  Label creator, when creating a batch you can add items using a
search.

This search has filters on acquisition date.
Actually those filters does not work.
The create a search using CCL syntaxe to query Zebra search engine.

The cause is that operator "ge" or "le" must be before "st-date-normalized" in
CCL query.
Looks like it is because of "st-date-normalized" uses "r=o" in ccl.properties.

Test plan :
1) Check in advance search you have indexed acquisition date
2) Go to Tools > Label creator
3) Click on New > Label batch
4) Click on Add item(s)
5) Enter a relevent date in "Added on or after date" and in "Added on or before
date"
6) Click on "Search"
=> Without patch you get no results
=> With patch you get expected results

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Followed the test plan and it works.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 20:33:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 18:33:06 +0000
Subject: [Koha-bugs] [Bug 20977] Javascript vars used in confirm_deletion in
 catalog.js do not match strings in catalog-strings.inc
In-Reply-To: <bug-20977-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20977-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20977-70-c3XAXV0lo1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977

Pierre-Luc Lapointe <pierre-luc.lapointe at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76238|0                           |1
        is obsolete|                            |

--- Comment #2 from Pierre-Luc Lapointe <pierre-luc.lapointe at inLibro.com> ---
Created attachment 76582
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76582&action=edit
Bug 20977: Javascript vars used in confirm_deletion in catalog.js do not match
strings in catalog-strings.inc

The naming mismatch can cause javascript errors.

Test Plan:
1) Confirm the string vars used in catalog.js match the ones in
   catalog-strings.inc

Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 20:34:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 18:34:04 +0000
Subject: [Koha-bugs] [Bug 20977] Javascript vars used in confirm_deletion in
 catalog.js do not match strings in catalog-strings.inc
In-Reply-To: <bug-20977-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20977-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20977-70-VPUSyU31AY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977

Pierre-Luc Lapointe <pierre-luc.lapointe at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pierre-luc.lapointe at inLibro
                   |                            |.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 20:40:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 18:40:03 +0000
Subject: [Koha-bugs] [Bug 21024] JS error on search result breaks JS
	functionalities
In-Reply-To: <bug-21024-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21024-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21024-70-jaw9wqodQu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 20:40:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 18:40:07 +0000
Subject: [Koha-bugs] [Bug 21024] JS error on search result breaks JS
	functionalities
In-Reply-To: <bug-21024-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21024-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21024-70-9CLz6dtTyp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76579|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76583
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76583&action=edit
Revert "Bug 20864: Only set bibs_selected cookie when BrowseResultSelection is
activated"

This reverts commit ce6ec1e7faef217950e3450788ea444dad26d7c0.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 20:41:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 18:41:03 +0000
Subject: [Koha-bugs] [Bug 21024] JS error on search result breaks JS
	functionalities
In-Reply-To: <bug-21024-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21024-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21024-70-xS7DnBAvXw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
It's too hard to get rid of the cookie. It is used for add to cart and list
selection. The safer is to keep and use it, even if the pref is turned off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 20:48:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 18:48:14 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-EqsdVHsTVb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #184 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
virtualshelfcontents entries are not deleted when a bibliographic record is
removed:
- Add 3 biblios to a list
- Remove one
- /virtualshelves/shelves.pl?op=list&category=1
says "3 item(s)"
- click on the list
=> There are only 2

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 21:01:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 19:01:49 +0000
Subject: [Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on
 Authorities "New from Z39.50" Button
In-Reply-To: <bug-15360-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15360-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15360-70-H9TlwS4h3T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75703|0                           |1
        is obsolete|                            |

--- Comment #15 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 76584
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76584&action=edit
Bug 15360: Incorrect or mislabeled behavior on Authorities "New from Z39.50"
Button

This patch makes a third stab at resolving this issue by reorganizing
the authorities toolbar buttons to more closely match the bibliographic
toolbar buttons:

 - "New from Z39.50" has been added to the "New authority" dropdown.
 - "Edit" is now a dropdown, like on the bibliographic detail page:
    - Edit record
    - Edit as new (duplicate)
    - Replace record via Z39.50/SRU
    - Delete record

To test, apply the patch and go to the authorities module. Testing with
existing Z39.50 authority sources configured:

  - On the authorities home page and the authorities search results
    page, the "New authority" menu should have a "New from Z39.50" link.
  - View the details for an authority record. The menus should appear as
    described above. Test each option.

Remove all Z39.50 authority servers and test again. The "New from
Z39.50" link should no longer appear.

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 21:01:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 19:01:45 +0000
Subject: [Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on
 Authorities "New from Z39.50" Button
In-Reply-To: <bug-15360-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15360-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15360-70-EON2cq7f53@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 21:28:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 19:28:00 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-NkvvLUpbiO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

--- Comment #16 from Nick Clemens <nick at bywatersolutions.com> ---
Question here: before this patch I can 'Write off all' to clear the credit too,
after I have no way to clear the credit, shuld that functionality wait on
another bug?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 21:35:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 19:35:57 +0000
Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be
 write as description, not code
In-Reply-To: <bug-20806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20806-70-DM1TstGrzS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 21:36:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 19:36:01 +0000
Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be
 write as description, not code
In-Reply-To: <bug-20806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20806-70-voaLoF8ynw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76370|0                           |1
        is obsolete|                            |

--- Comment #10 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 76585
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76585&action=edit
Bug 20806: Add item type description holds history page

Test plan:

0) Do not apply the patch
1) Set AllowHoldItemTypeSelection to Allow
2) Place some hold for a patron, some with specific item type and some
without item type
3) On holds history page you should see blank or item type code in item
type column
4) Apply the patch
5) Now you should see description in item type column
6) Set AllowHoldItemTypeSelection to Don't Allow
7) You shold not see the item type column, but column visibility
settings should continue working ;)

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Followed the test plan and it works.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 21:37:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 19:37:23 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-Fia95x3YcU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 21:39:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 19:39:49 +0000
Subject: [Koha-bugs] [Bug 20893] batchRebuildItemsTables.pl has incorrect
	parameter
In-Reply-To: <bug-20893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20893-70-6GzdOr5wEy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20893

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 21:46:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 19:46:57 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-7TF3w3GfEA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Quick code review:

1. I do not like "return ( $total, $lines );"
We are simplifying the call here, but maybe next ones will not need the total,
or the line. It seems that we are recreating wrong patterns from C4.


2.
  Koha::Account->new( { patron_id => $borrowernumber } )->outstanding_debits;
should be
  $patron->account->outstanding_debits


3. ->balance is used from several other places, do we need to update them as
well?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 21:48:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 19:48:30 +0000
Subject: [Koha-bugs] [Bug 20953] Discharge can be requested several times on
	OPAC
In-Reply-To: <bug-20953-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20953-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20953-70-bELQ9zRBNF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |charles.farmer at inlibro.com

--- Comment #5 from Charles Farmer <charles.farmer at inlibro.com> ---
Two things:

* This bug's dependency is now 'pushed to stable'. The patch in this bug can
now be applied alone.
* Oddly, there seems to be an issue with generate_as_pdf at the end of the test
plan. This is what I get on my system: Undefined subroutine
&C4::Letters::GetPreparedLetter called at /.../Koha/Patron/Discharge.pm line
113

Since the issue I mentionned is unrelated to the problem you're trying to
solve, I'll open another bug for it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 21:52:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 19:52:54 +0000
Subject: [Koha-bugs] [Bug 20953] Discharge can be requested several times on
	OPAC
In-Reply-To: <bug-20953-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20953-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20953-70-KZLuW1yMix@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 21:52:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 19:52:57 +0000
Subject: [Koha-bugs] [Bug 20953] Discharge can be requested several times on
	OPAC
In-Reply-To: <bug-20953-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20953-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20953-70-9CrxFctj7F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76117|0                           |1
        is obsolete|                            |

--- Comment #6 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 76586
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76586&action=edit
Bug 20953: Prevent several discharge requests on OPAC

On OPAC, a user can requested a discharge even if one is already pending.
This generates several pending discharges in staff interface that can not be
deleted.

This is because request operation leads to page 'opac-discharge.pl?op=request'
and user can refresh this page performing a new request.

Perl code must check that operation is allowed.

Patch reoganised the code so that the following FIXME is obsolete :
  'FIXME looks like $available is not needed'
Patch also replaces 'op' arg test to also check undef : input->param("op") //
''

Test plan :
1) Set system preference 'useDischarge' to 'Allow'
2) Choose a patron without checkouts nor fines nor restrictions
3) Log at OPAC and go to patron page /cgi-bin/koha/opac-user.pl
4) Click on 'ask for a discharge' tab
   => You see /cgi-bin/koha/opac-discharge.pl
      with text 'What is a discharge? ...'
5) Click on 'Ask for a discharge' link
   => You see /cgi-bin/koha/opac-discharge.pl?op=request
      with text 'Your discharge request has been sent ...'
6) In a new browser tab/page, go to intranet on
/cgi-bin/koha/members/discharges.pl
   => You see one discharge requets for the patron
7) Come back to OPAC and refresh page
   => You see /cgi-bin/koha/opac-discharge.pl
   with text 'Your discharge will be available on this page within a few days.'
8) Come back to intranet and refresh /cgi-bin/koha/opac-discharge.pl
   => There is still one requets for the patron
9) Come back to OPAC and enter URL /cgi-bin/koha/opac-discharge.pl?op=get
   => You see /cgi-bin/koha/opac-discharge.pl
      with text 'Your discharge will be available on this page within a few
days.'
10) Come back to intranet and refresh /cgi-bin/koha/opac-discharge.pl
   => There is still one requets for the patron
11) Click on 'allow' on patron discharge request
12) Come back to OPAC and refresh /cgi-bin/koha/opac-discharge.pl
    => You see link 'Get your discharge'
13) enter URL /cgi-bin/koha/opac-discharge.pl?op=request
    => You see same page and no new discharge requets is created
14) Come back to intranet on patron details page
15) Remove the discharge restriction
16) Come back to OPAC and refresh /cgi-bin/koha/opac-discharge.pl
    => You see text 'What is a discharge?...'
17) enter URL /cgi-bin/koha/opac-discharge.pl?op=get
    => You see same page and no new discharge requets is created

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 21:52:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 19:52:58 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-xEqNjsg8pM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

--- Comment #18 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #17)
> Quick code review:
> 
> 1. I do not like "return ( $total, $lines );"
> We are simplifying the call here, but maybe next ones will not need the
> total, or the line. It seems that we are recreating wrong patterns from C4.

Do you prefer a Koha::Account::OutstandingCredits objecT?
or
Koha::Account->oustanding_debits_total + outstanding_debit_lines ?

> 2.
>   Koha::Account->new( { patron_id => $borrowernumber } )->outstanding_debits;
> should be
>   $patron->account->outstanding_debits

I agree. This is an easy fix, though.

> 3. ->balance is used from several other places, do we need to update them as
> well?

Balance is another thing. Balance is a global value representing if the patron
owes or has credit. The point of having debits and credits separate is
replicating what other tools do (see any bank account balance, for example). So
in many places where ->balance is used, it is done in a correct way!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 22:03:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 20:03:38 +0000
Subject: [Koha-bugs] [Bug 21025] New: Koha::Patron::Discharge is missing use
	C4::Letters
Message-ID: <bug-21025-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21025

            Bug ID: 21025
           Summary: Koha::Patron::Discharge is missing use C4::Letters
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: charles.farmer at inlibro.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Tried to download a discharge slip from the OPAC, but received the following
message:

> An error occurs when generating the pdf file. Please contact the staff to resolve this problem.

>From the logs:

> [Fri Jun 29 15:34:45.758105 2018] [cgi:error] [pid 10573] [client 127.0.0.1:44946] AH01215: [Fri Jun 29 15:34:45 2018] opac-discharge.pl: Undefined subroutine &C4::Letters::GetPreparedLetter called at /meow/Koha/Patron/Discharge.pm line 113.: /meow/opac/opac-discharge.pl, referer: http://master/cgi-bin/koha/opac-discharge.pl

Will submit patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 22:10:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 20:10:46 +0000
Subject: [Koha-bugs] [Bug 20945] Report params not escaped when downloading
In-Reply-To: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20945-70-lVgKlsgzyp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 76587
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76587&action=edit
Bug 20945: (RM follow-up) Escape param_name too

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 22:11:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 20:11:54 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20946-70-krnEPaGoHg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Failed QA

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pmed with Tomas, we agreed that outstanding_debits should return
Koha::Account::Lines, then Koha::Account::Lines should have new methods to do
the sum calculation.
It will make the sum reusable and outstanding_debits return only what it needs
to return (a set of lines)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 22:22:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 20:22:49 +0000
Subject: [Koha-bugs] [Bug 21025] Koha::Patron::Discharge is missing use
	C4::Letters
In-Reply-To: <bug-21025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21025-70-6elqYiGECx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21025

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 22:22:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 20:22:51 +0000
Subject: [Koha-bugs] [Bug 21025] Koha::Patron::Discharge is missing use
	C4::Letters
In-Reply-To: <bug-21025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21025-70-9PKeEmqbos@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21025

--- Comment #1 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 76588
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76588&action=edit
Bug21025: Add GetPreparedLetter to Koha::Patron::Discharge

Test plan (shamelessly ripped from Bug20953):

1) Set system preference 'useDischarge' to 'Allow'
2) Choose a patron without checkouts nor fines nor restrictions
3) Log at OPAC and go to patron page /cgi-bin/koha/opac-user.pl
4) Click on 'ask for a discharge' tab
   => You see /cgi-bin/koha/opac-discharge.pl
      with text 'What is a discharge? ...'
5) Click on 'Ask for a discharge' link
   => You see /cgi-bin/koha/opac-discharge.pl?op=request
      with text 'Your discharge request has been sent ...'
6) In a new browser tab/page, go to intranet on
/cgi-bin/koha/members/discharges.pl
   => You see one discharge requets for the patron
   => Click on 'allow' on patron discharge request
7) Come back to OPAC and refresh /cgi-bin/koha/opac-discharge.pl
  => You see link 'Get your discharge'
8) Click on the link to get your generated PDF
  => An error message should appear informing you to contact your website's
admin
9) Apply this patch
10) Click again on the link to get your generated PDF
  => This time, a download prompt should appear

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 22:26:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 20:26:54 +0000
Subject: [Koha-bugs] [Bug 20920] Plack timeout because of missing
 CGI::Compile Perl dependency
In-Reply-To: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20920-70-AlNZfSd2vV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920

--- Comment #5 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 76589
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76589&action=edit
Bug 20920: Add missing dependency on CGI::Compile

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 22:27:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 20:27:09 +0000
Subject: [Koha-bugs] [Bug 20920] Plack timeout because of missing
 CGI::Compile Perl dependency
In-Reply-To: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20920-70-T70lj6E80V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920

--- Comment #6 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 76590
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76590&action=edit
Bug 20920: Followup: generated d/control

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 22:27:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 20:27:45 +0000
Subject: [Koha-bugs] [Bug 20920] Plack timeout because of missing
 CGI::Compile Perl dependency
In-Reply-To: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20920-70-2gR9BLoOse@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76217|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 22:28:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 20:28:07 +0000
Subject: [Koha-bugs] [Bug 20920] Plack timeout because of missing
 CGI::Compile Perl dependency
In-Reply-To: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20920-70-vtrPCyGSMr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 22:31:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 20:31:48 +0000
Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be
 write as description, not code
In-Reply-To: <bug-20806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20806-70-0xcbbCujz9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 22:31:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 20:31:55 +0000
Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be
 write as description, not code
In-Reply-To: <bug-20806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20806-70-iKkE789Uti@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76585|0                           |1
        is obsolete|                            |

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76591
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76591&action=edit
Bug 20806: Add item type description holds history page

Test plan:

0) Do not apply the patch
1) Set AllowHoldItemTypeSelection to Allow
2) Place some hold for a patron, some with specific item type and some
without item type
3) On holds history page you should see blank or item type code in item
type column
4) Apply the patch
5) Now you should see description in item type column
6) Set AllowHoldItemTypeSelection to Don't Allow
7) You shold not see the item type column, but column visibility
settings should continue working ;)

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Followed the test plan and it works.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 22:31:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 20:31:59 +0000
Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be
 write as description, not code
In-Reply-To: <bug-20806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20806-70-KHQzciEXjN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76592
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76592&action=edit
Bug 20806: Do not rely on column position

It is not the first time we have this splice call, it seems safer to
rely on the column's name instead of the column's position

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 22:37:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 20:37:14 +0000
Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be
 write as description, not code
In-Reply-To: <bug-20806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20806-70-HDrLnjtwTi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 76593
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76593&action=edit
Bug 20806: Surround string by span tag to help translation

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 22:41:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 20:41:41 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-1FoGd8Xx8n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #150 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 76594
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76594&action=edit
Bug 17015: Improved UI readability

* The calendar tool page no longer shows past holidays in the lists on the
right side of the page.
* Improved wording in the "Hints"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 22:46:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 20:46:00 +0000
Subject: [Koha-bugs] [Bug 20920] Plack timeout because of missing
 CGI::Compile Perl dependency
In-Reply-To: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20920-70-JT2D2R1AVR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |nick at bywatersolutions.com

--- Comment #7 from Mirko Tietgen <mirko at abunchofthings.net> ---
Jerome, thanks a lot for spotting the problem and your patch!
Minor QA change: first line of the commit message is supposed to be
Bug xxxxx: Your bug report title
I changed it and generated the new control file.

Nick, please push, I will do a 18.05.01-2 and probably 17.11.07-2 package with
this because it breaks fresh Koha with Plack on Stretch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 23:01:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 21:01:12 +0000
Subject: [Koha-bugs] [Bug 20998] Non superlibrarians cannot search for
 patrons using the quicksearch at the top
In-Reply-To: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20998-70-fVRNZT6tt1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 23:01:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 21:01:29 +0000
Subject: [Koha-bugs] [Bug 20903] Print payment receipt on child patron could
 end with server error
In-Reply-To: <bug-20903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20903-70-3p05SEjSQv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 23:01:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 21:01:44 +0000
Subject: [Koha-bugs] [Bug 16653] reports/cat_issues_top.pl does not export
 "Count of checkouts" column as CSV
In-Reply-To: <bug-16653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16653-70-JJDlpBaOM9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16653

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 23:01:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 21:01:59 +0000
Subject: [Koha-bugs] [Bug 20893] batchRebuildItemsTables.pl has incorrect
	parameter
In-Reply-To: <bug-20893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20893-70-Kbz16U1oAo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20893

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 23:02:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 21:02:14 +0000
Subject: [Koha-bugs] [Bug 17869] Don't show pick-up library for list of
 holds in OPAC account when there is only one branch
In-Reply-To: <bug-17869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17869-70-G86AA2AZMt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 23:02:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 21:02:31 +0000
Subject: [Koha-bugs] [Bug 20697] Remove some Host-Item-Number noise from
 zebra-output.log when EasyAnalyticalRecords is not used
In-Reply-To: <bug-20697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20697-70-F0qhqO6UiV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20697

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 23:02:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 21:02:47 +0000
Subject: [Koha-bugs] [Bug 20945] Report params not escaped when downloading
In-Reply-To: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20945-70-ahKoHuy44A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 23:03:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 21:03:16 +0000
Subject: [Koha-bugs] [Bug 17886] Don't show option to add to existing list
 if there are no lists in staff
In-Reply-To: <bug-17886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17886-70-39twcsgc65@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #15 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 23:03:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 21:03:02 +0000
Subject: [Koha-bugs] [Bug 14222] Sort holds in OPAC by priority
In-Reply-To: <bug-14222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14222-70-8nLai6toi2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14222

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 23:03:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 21:03:35 +0000
Subject: [Koha-bugs] [Bug 20991] Error will reset category when editing a
	patron
In-Reply-To: <bug-20991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20991-70-uJFSY8IFOd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20991

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 23:03:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 21:03:50 +0000
Subject: [Koha-bugs] [Bug 10348] Show number of items on tab headings in the
	staff client
In-Reply-To: <bug-10348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10348-70-q73eNNmjNt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10348

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 23:04:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 21:04:03 +0000
Subject: [Koha-bugs] [Bug 20520] Re-indent moremember.tt
In-Reply-To: <bug-20520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20520-70-K3hwi87ImK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |nick at bywatersolutions.com

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 23:04:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 21:04:16 +0000
Subject: [Koha-bugs] [Bug 20585] Label surname as name for organisation type
	patrons
In-Reply-To: <bug-20585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20585-70-kI02YROWcC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20585

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 23:04:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 21:04:33 +0000
Subject: [Koha-bugs] [Bug 20921] Expose borrowernumber and branch when user
 is logged in to OPAC
In-Reply-To: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20921-70-bxcpvt3A1a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 23:04:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 21:04:47 +0000
Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to
 account page instead of back to search results
In-Reply-To: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17153-70-XfTsJu6ZPI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Passed QA                   |Pushed to Master

--- Comment #22 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 23:11:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 21:11:08 +0000
Subject: [Koha-bugs] [Bug 20969] Use modal to add and edit notes from basket
In-Reply-To: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20969-70-ytCqCUw5qR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76422|0                           |1
        is obsolete|                            |

--- Comment #7 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 76595
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76595&action=edit
Bug 20969: Use modal to add and edit notes from basket

This patch modifies the acquisitions basket page so that links to add or
edit vendor or internal notes trigger a modal with the notes edit form
instead of redirecting to a different page. This is a markup change only
-- The form still submits to modordernotes.pl.

To test, apply the patch and view a basket in acquisitions which has
multiple orders. Test various note controls:  Add internal note, Add
vendor note, Edit internal note, edit vendor note.

Confirm that the operations work correctly with multiple orders in the
basket.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 23:11:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 21:11:29 +0000
Subject: [Koha-bugs] [Bug 20969] Use modal to add and edit notes from basket
In-Reply-To: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20969-70-RkHvepMF86@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76595|0                           |1
        is obsolete|                            |

--- Comment #8 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 76596
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76596&action=edit
Bug 20969: Use modal to add and edit notes from basket

This patch modifies the acquisitions basket page so that links to add or
edit vendor or internal notes trigger a modal with the notes edit form
instead of redirecting to a different page. This is a markup change only
-- The form still submits to modordernotes.pl.

To test, apply the patch and view a basket in acquisitions which has
multiple orders. Test various note controls:  Add internal note, Add
vendor note, Edit internal note, edit vendor note.

Confirm that the operations work correctly with multiple orders in the
basket.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 23:11:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 21:11:34 +0000
Subject: [Koha-bugs] [Bug 20969] Use modal to add and edit notes from basket
In-Reply-To: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20969-70-jvhxJL6M4Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76474|0                           |1
        is obsolete|                            |

--- Comment #9 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 76597
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76597&action=edit
Bug 20969: (follow-up) Move focus to textarea whe modal is shown

This follow-up adds code to move the mouse cursor to the modal window's
textarea when the modal is displayed.

To test, apply the patch and test the process of adding/editing notes on
an order. Confirm that the focus moves to the textarea when the note
editor modal window is shown.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 23:13:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 21:13:41 +0000
Subject: [Koha-bugs] [Bug 20969] Use modal to add and edit notes from basket
In-Reply-To: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20969-70-LaUuiP6XgE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |charles.farmer at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 23:23:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 21:23:43 +0000
Subject: [Koha-bugs] [Bug 20969] Use modal to add and edit notes from basket
In-Reply-To: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20969-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20969-70-PMkzJyqwn2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Reganing my QA token with Charles' additional sign-off - switching this to
PQA.off I

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 23:33:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 21:33:52 +0000
Subject: [Koha-bugs] [Bug 20999] Remove invalid 'style="block"' from OPAC
	templates
In-Reply-To: <bug-20999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20999-70-YRyLz87EbD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20999

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 23:33:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 21:33:55 +0000
Subject: [Koha-bugs] [Bug 20999] Remove invalid 'style="block"' from OPAC
	templates
In-Reply-To: <bug-20999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20999-70-8EriKOvfI5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20999

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76458|0                           |1
        is obsolete|                            |

--- Comment #2 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 76598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76598&action=edit
Bug 20999: Remove invalid 'style="block"' from OPAC templates

This patch removes an invalid attribute from OPAC template markup. There
should be no visible change to the OPAC.

To test, apply the patch and confirm that the following pages still look
correct when using various cover image sources: Coce, Amazon, Google:

 - Bibliographic detail page (opac-detail.pl)
   - The shelf browser
 - Catalog search results
 - Recent comments

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 23:58:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 21:58:17 +0000
Subject: [Koha-bugs] [Bug 20693] Plack fails,
 because 'libcgi-emulate-psgi-perl' package is not installed
In-Reply-To: <bug-20693-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20693-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20693-70-CU9ERtfjdl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20693

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #13 from Mirko Tietgen <mirko at abunchofthings.net> ---
Fridolin: Needs to go to 17.11. Is in 17.11.07-2 package, please push for
17.11.08! Minor rebase needed, I'll send a changed patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 30 00:01:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 22:01:35 +0000
Subject: [Koha-bugs] [Bug 20920] Plack timeout because of missing
 CGI::Compile Perl dependency
In-Reply-To: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20920-70-9WgmWC6dZG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920

--- Comment #8 from Mirko Tietgen <mirko at abunchofthings.net> ---
Martin: is in 18.05.01-2, please push to 18.05.02.

Fridolin: is in 17.11.07-2, please push to 17.11.08. Depends on 20693 for
17.11.x, please push the other one first.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 30 00:02:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 22:02:02 +0000
Subject: [Koha-bugs] [Bug 20920] Plack timeout because of missing
 CGI::Compile Perl dependency
In-Reply-To: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20920-70-BMUucxpeXX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 30 00:13:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 22:13:15 +0000
Subject: [Koha-bugs] [Bug 20693] Plack fails,
 because 'libcgi-emulate-psgi-perl' package is not installed
In-Reply-To: <bug-20693-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20693-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20693-70-OSaARWKdkk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20693

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75338|0                           |1
        is obsolete|                            |

--- Comment #14 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 76599
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76599&action=edit
Bug 20693: Plack fails, because 'libcgi-emulate-psgi-perl' package is not
installed

Add CGI::Emulate::PSGI to PerlDependencies.pm

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 30 01:01:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2018 23:01:17 +0000
Subject: [Koha-bugs] [Bug 20998] Non superlibrarians cannot search for
 patrons using the quicksearch at the top
In-Reply-To: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20998-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20998-70-R0GWMKOJwT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998

--- Comment #10 from Barton Chittenden <barton at bywatersolutions.com> ---
Request for back-port (issue first occurs in 17.11, I believe)

-- 
You are receiving this mail because:
You are watching all bug changes.