[Koha-bugs] [Bug 20760] Advanced Cataloging Editor - Rancor - AuthorisedValues are incorrectly fetched
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Mon Jun 4 21:51:25 CEST 2018
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20760
--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to M. Tompsett from comment #7)
> Comment on attachment 75779 [details] [review]
> [ALTERNATIVE PATCH] Bug 20760: Fill authorised values in svc framework
>
> Review of attachment 75779 [details] [review]:
> -----------------------------------------------------------------
>
> ::: svc/cataloguing/framework
> @@ +53,5 @@
> > }
> >
> > +my $avs = C4::Koha::GetAuthorisedValues();
> > +for my $av ( @$avs ) {
> > + push @{ $authorised_values->{$av->{category}} }, { value => $av->{authorised_value}, lib => $av->{lib} };
>
> The other version had order_by lib. This uses order by category first.
> Perhaps add a sort?
I do not think it is needed. We are pushing into @{$hash->{$category}}, and
template site we are using the keys of this hash separately. I will not help to
sort by category.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list