[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Jun 7 05:10:11 CEST 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75862|0                           |1
        is obsolete|                            |

--- Comment #9 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 75863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75863&action=edit
Bug 14866: [FOLLOW-UP]  Make high holds work with different item types

This patch fixes merge conflicts, fixes the indentation of the table in
smart-rules.tt and uses Koha::IssuingRules->get_effective_issuing_rule.

Keep in mind - I am sure that when the original patch for this was
written (before get_effective_issuing_rule was used), it all worked
fine. I had to add an extra line of code in my patch to get this method
to work because it was fetching the WRONG circulation rule - one that
did not have decreaseloanholds defined. I don't know if it was my patch
that is broken or the get_effective_issuing_rule method that is not
fetching the 'most specific/relevant' rule.

Sponsored-by: Region Halland

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list