[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

--- Comment #48 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Marcel de Rooy from comment #43)
> QA Comment:
> 
> Why do you add in catalogue/search.pl:
> +use String::Random;
> 
> + at results_per_page_options = do { my %seen; grep { !$seen{$_}++ }
> @results_per_page_options };
> Could you 'do' this without a do statement? Do you need uniq from List::More
> ?
> Is it really needed btw? Do you expect duplicate numbers in this pref..
> 

This is now gone in latest follow-up.

> results.tt
> Why are you changing the lines with respect to list counts? What is the
> relation with this patch?
> 

This seems unrelated to this patch but is no longer affected in the follow-up.

> opac-search.pl
> -$offset = ($page-1)*$results_per_page if $page>1;
> Why do you remove it ?
> 

Offset is dealt with later.

> -        ($error, $results_hashref, $facets) =
> C4::Search::pazGetRecords($query,$simple_query,\@sort_by,\@servers,
> $results_per_page,$offset,$expanded_facet,undef,$query_type,$scan);
> +        ($error, $results_hashref, $facets) =
> C4::Search::pazGetRecords($query,$simple_query,\@sort_by,\@servers,
> $results_per_page,$offset,$expanded_facet,$query_type,$scan);
> You remove a undef parameter.
> Why? Is this a bug on its own? What is the relation with this report?
> 
> Please clarify or adjust.

Have put undef param back. Not sure why this was removed initially.

Ready for testing.

-- 
You are receiving this mail because:
You are watching all bug changes.