[Koha-bugs] [Bug 20923] New: Merging backend status graph into main status graph incorrect use of grep

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20923

            Bug ID: 20923
           Summary: Merging backend status graph into main status graph
                    incorrect use of grep
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: ILL
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew.isherwood at ptfs-europe.com

When the Illrequest object is being constructed, it consults the status graphs
for enabled backends. These status graphs are then merged into the main graph
in order to provide the full workflow for a request.

As part of this process, the "next_actions" property is updated to reflect any
new statuses. During this, a check is performed to determine if the status
graph knows about the next status being declared by a backend status graph:

if ( grep $prev_action, @core_status_ids ) {

This is incorrect. According to http://perldoc.perl.org/functions/grep.html,
the first parameter should be a block or expression, here we are passing a
string. This malfunctions in so much as passing "REQ" with match twice in the
following array [ "REQ", "REQREV" ], this is not what we would expect.

The fix is to substitute the following line:

if ( grep /^$prev_action$/, @core_status_ids ) {

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.