[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #245 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
1. aqbasketgroups.closedate is set to NOW, maybe better to use basket.closedate
(the latest)?

2. ->bookseller should be ->vendor (not blocker as we already have both in
Koha::*...)

3. a. I would not "cache" ->baskets, we already deal with the context in
Koha::Objects->search
b. ->baskets_count - no need to have it, it should be replaced with
baskets->count
=> Maybe you want to keep them for performance purpose, but is it really a
performance improvement?

5. basketgroup.tt has a [% IF booksellerid %], it should not be useful now.
We may want to display a friendly message if called without a [valid] id

6. basketgroups.tt should have JS at the bottom

7. Some links still point to basketgroup.pl?booksellerid=X without the
basketgroupid, they should be replaced right?
i.e. code related to 'sub displaybasketgroups' in basketgroup.pl should be
removed (?)

8. Are you sure you need the changes done to C4::Acquisition?

9. acqui/basketgroup.pl
+ use List::MoreUtils qw/uniq/;
=> Not needed

10. "kohaDataTable": We already have KohaTable. You are adding a 3rd way to
init a table.

-- 
You are receiving this mail because:
You are watching all bug changes.