[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

--- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 74660
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74660
Bug 17385: Add custom export XSLT

Review of attachment 74660:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17385&attachment=74660)
-----------------------------------------------------------------

Generally looks good with a few minor code comments added for review.

::: C4/XSLT.pm
@@ +197,5 @@
>      $xslfilename ||= C4::Context->preference($xslsyspref);
>      $lang ||= C4::Languages::getlanguage();
>  
> +    if ($xslsyspref eq "XSLTCustomExport") {
> +        my $dir;

The code used to defined $dir in CustomXSLTExportList which does the same thing
is cleaner.. why not use that here too... or even factor it out and use the
same factored out routine for both to keep it DRY?

@@ +370,5 @@
>  }
>  
> +=head2 CustomXSLTExportList
> +
> + Returns list of file for custom xslt conversion

Please add accepted parameters (i.e. $opac) to the POD section and note their
required status and what they accept (string, int, etc)

-- 
You are receiving this mail because:
You are watching all bug changes.