[Koha-bugs] [Bug 5789] Fines don't work when items have null homebranch

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5789

--- Comment #10 from Pierre-Luc Lapointe <pierre-luc.lapointe at inLibro.com> ---
Created attachment 76109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76109&action=edit
Bug 5789 - Fines don't work when items have null homebranch

When the CircControl system preference is set to 'the library the item is from'
and items.homebranch is not set,
fines.pl will stop processing witha fatal error that looks something like this:

    Use of uninitialized value $branchcode in exists at
/home/koha/kohaclone/misc/cronjobs/fines.pl line 110
    No branchcode argument passed to Koha::Calendar->new at
/home/koha/kohaclone/misc/cronjobs/fines.pl line 169.

This patch will check the value of $branchcode before it is used. If
$branchcode is undefined, a warning will
be issued and, processing will be skipped for that item, and continue for the
next item.

To test:

1) Set CircControl to  'the library the item is from'
2) Check out items and back-date them to be overdue
3) Set homebranch of one of the items to NULL
4) Run misc/cronjobs/fines.pl, note that processing stops at that item.
5) Apply patch
6) Repeat step 4. not that processing completes.
7) Check logs, you should see a warning message for the item missing its
homebranch.
8) Sign off.

Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe at inLibro.com>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.