[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

--- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Jonathan

Pattern
=======
I'm not sure about the pattern you are using in ->store. Take a look here:

http://search.cpan.org/dist/DBIx-Class/lib/DBIx/Class/Storage.pm#txn_do

Basically, txn_do is encapsulating the exception you are raising, and so the
behaviour is not the expected one.

Failure in Object.t
===================
Regarding the failure in Object.t, I agree we should pick a more simple object
(I guess Koha::Patron was the first we introduced and was pretty simple until
this patchset).

Exceptions
==========
On bug 20590 we introduced Koha::Exceptions::Exception->full_message (which
should be moved into the implementing class (in the case you implemented,
Koha::Exceptions::Object) but the way it is implemented works for the use case
you wrote, but not for Koha::Object->store.

-- 
You are receiving this mail because:
You are watching all bug changes.