[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #37 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to paxed from comment #36)
> Unfortunately quite a lot of the messages are split in multiple parts,
> making translation very hard:
> 
> [% t('Warning: This file is version') %] [% message.upload_version %][% t(',
> but I only know how to import version') %] [% message.current_version %][%
> t('. I\'ll try my best.') %]
> 
> 
> Currently they're much better, with placeholders:
> 
> "Warning: This file is version %s, but I only know how to import version %s.
> "

I agree. There's still some manual work, the goal of this bug is to reduce it
to a minimum.

This particular example should be

[% tx('Warning: This file is version {upload_version} but I only know how to
import {current_version}. I\'ll try my best.', { upload_version =
upload_version, current_version = current_version) %]

I'm not sure we can accomplish that easily with an automated tool. It's
probably easier to run the tool and fix manually the problematic ones.

But please note that, unlike actual PO files, the one attached doesn't contain
strings like this:

"%s %s %s   %s %s - %s %s %s - %s%s %s- %s%s %s - %s%s %sEdition: %s%s "
"%s ; %s%s %s - %s%s %s ; %s%s %s "


Also, I attached all the changes to this one bug, but that doesn't mean we
should do it all at once. We can take the safer way of changing one template
file at a time (or one module at a time). It will certainly be easier to
rebase/test/review.

-- 
You are receiving this mail because:
You are watching all bug changes.