[Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945

--- Comment #7 from Alex Arnaud <alex.arnaud at biblibre.com> ---
(In reply to Nick Clemens from comment #6)
> I don't think the second patch is quite right - CanBookBeReserved calls
> CanItemBeReserved, but it might not be correct for a specific item
> 
> Set a rule for 'No Holds Allowed' for an itemtype
> Find a bib with no items or create on
> Add an item with the disallowed item type
> Attempt hold on item via ILSDI - Not allowed
> Add a second item with a holdable itemtype
> Attempt hold on the original unholdable item via ILSDI - Allowed?
> 
> I think the call in 'Hold Item' to CanBookBeReserved is the extraneous one
> unless I missed something
> 
> I also note that neither of the routines mentioned check for 'On shelf holds
> allowed' policy - filed as bug 20985

I agree. For further, it seems to me that HoldItem should call
CanItemBeReserved only, even though it may not be the point of this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.