[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
I see a few issues the shouldn't be hard to resolve:
1) Unit tests ( they are super simple, but should be there anyway )
2) Why test for the method intranet_catalog_biblio_enhancements, but then call
the method get_toolbar_button? A) You can check for the method
get_toolbar_button directly, and B) You are calling get_toolbar_button twice
per plugin, which seems like waste of cycles.
3) After resolving 1 and 2, could you also make pull request to the kitchen
sink plugin (https://github.com/bywatersolutions/koha-plugin-kitchen-sink) to
add an example to it? That plugin is basically out documentation for the plugin
system's functionality at this time.

-- 
You are receiving this mail because:
You are watching all bug changes.