[Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Quick code review:

1. I do not like "return ( $total, $lines );"
We are simplifying the call here, but maybe next ones will not need the total,
or the line. It seems that we are recreating wrong patterns from C4.


2.
  Koha::Account->new( { patron_id => $borrowernumber } )->outstanding_debits;
should be
  $patron->account->outstanding_debits


3. ->balance is used from several other places, do we need to update them as
well?

-- 
You are receiving this mail because:
You are watching all bug changes.