From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 00:19:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Feb 2018 23:19:43 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Roch D'Amour changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 00:19:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Feb 2018 23:19:47 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #58 from Roch D'Amour --- Created attachment 72295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72295&action=edit Bug 12446 - Enable an adult to have a guarantor I have rebased the patch and corrected some bugs. It should work now :) Here's the test plan: 1) Apply the patch 2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and canbeguarantee to categories. 3) Go to patron category administration, edit a category and change the value of Can Be Guarantee to yes (for Child and Professional mostly to set it by default) 4) See below to test various scenarios - Enable an adult to have a guarantor: 0.0) Create or edit a patron category of type 'A'. 0.1) Set the "Can be guarantee" field to "Yes" and save. 1) Select an adult patron -> details tab; 2) Click edit button; 3) validate "guarantor information" fieldset; - Shows guarantees' fines in the guarantor's page: 4) Click Set to patron button and select a guarantor; 5) Generate a fine; 6) Select guarantor patron -> details tab; 7) Validate guarantee's fine information. - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while creating a new patron 0) Select an adult patron; 1) Insert all information; 2) Add a new adult patron; 3) Click "Set to patron" button; 4) Select the adult patron from 0); 5) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer guarantor's alternate address/contact to the guarantee while creating a new patron: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 2) Select an adult patron; 3) Insert all information; 4) Add a new adult patron; 5) Click "Set to patron" button; 6) Select the adult patron from 0); 7) Validade Garantor information/Main address/Contact fieldsets filled; 8) Validade Garantor additional alternate address/contact filled; - Transfer guarantor's alternate address/contact to the guarantee while adding a guarantiee: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 3) Select an adult patron; 4) Insert all information; 5) Click Add guarantiee bouton; 6) Validade Garantor information/Main address/Contact fieldsets filled; 7) Validade Garantor additional alternate address/contact filled; Thanks for testing :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 00:25:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Feb 2018 23:25:16 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64794|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 00:25:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Feb 2018 23:25:30 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64828|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 00:32:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Feb 2018 23:32:37 +0000 Subject: [Koha-bugs] [Bug 20310] Article requests: Can we redirect article records without items to host record? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I think at the moment it's built so it's possible to order records without items - so not sure what you suggest would/should work in general. Some libraries might want to allow orders on articles without items. I think if we do that, we should try to fill the form in for the user. Having found the article, they might not like to be forced to enter the information into a form, that was obvious on the record before. But it would probably not be easy to split up $g correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 00:58:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Feb 2018 23:58:38 +0000 Subject: [Koha-bugs] [Bug 16357] Plack error logs are not time stamped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #13 from Mason James --- Created attachment 72296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72296&action=edit Bug 16357: (follow-up) Log and timestamp fatal errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 01:08:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 00:08:22 +0000 Subject: [Koha-bugs] [Bug 16357] Plack error logs are not time stamped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #14 from Mason James --- (In reply to Mason James from comment #13) > Created attachment 72296 [details] [review] > Bug 16357: (follow-up) Log and timestamp fatal errors interestingly... after applying this patch some previously hidden errors are now revealed in the plack-error.log file this new info looks useful for showing unidentified DBIx problems 2018/03/01 10:59:30 DBIx::Class::ResultSource::_minimal_valueset_satisfying_constraint(): Unable to satisfy requested constraint 'primary', missing values for column(s): 'borrowernumber' at /usr/share/koha/lib/Koha/Objects.pm line 92 2018/03/01 10:59:30 DBIx::Class::ResultSource::_minimal_valueset_satisfying_constraint(): Unable to satisfy requested constraint 'cardnumber', missing values for column(s): 'cardnumber' at /usr/share/koha/lib/Koha/Objects.pm line 92 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 01:09:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 00:09:09 +0000 Subject: [Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 01:09:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 00:09:14 +0000 Subject: [Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 --- Comment #11 from Aleisha Amohia --- Created attachment 72297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72297&action=edit Bug 20000: Removing Modern::Perl from old scripts as per Jonathan's comment 10 Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 01:09:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 00:09:26 +0000 Subject: [Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 02:03:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 01:03:26 +0000 Subject: [Koha-bugs] [Bug 17218] New list add attempt while logged in as dbadmin should be prevented pre-emptively In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17218 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68155|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia --- Created attachment 72298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72298&action=edit Bug 17218: Stop DB user from clicking 'New list' button To test: 1) Log in as DB user 2) Go to Lists -> New list 3) Attempt to create a new list 4) Notice that you are only stopped once you've submitted the form 5) Go back to lists, apply patch and refresh page 6) Notice the 'New list' button is now disabled 7) Click it and confirm alert shows up Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 02:03:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 01:03:32 +0000 Subject: [Koha-bugs] [Bug 17218] New list add attempt while logged in as dbadmin should be prevented pre-emptively In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17218 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68156|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia --- Created attachment 72299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72299&action=edit Bug 17218: [FOLLOW-UP] Stop DB user from adding list by forcing URL To test: 1) Go to the url /virtualshelves/shelves.pl?op=add_form&referer=add_form 2) Confirm an error message shows and the Save button cannot be clicked Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 02:04:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 01:04:41 +0000 Subject: [Koha-bugs] [Bug 17218] New list add attempt while logged in as dbadmin on staff side should be prevented pre-emptively In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17218 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|New list add attempt while |New list add attempt while |logged in as dbadmin should |logged in as dbadmin on |be prevented pre-emptively |staff side should be | |prevented pre-emptively Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 07:43:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 06:43:01 +0000 Subject: [Koha-bugs] [Bug 20298] Notices template uses same html id for each language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20298 --- Comment #2 from paxed --- Also: tools/letter.pl: my $is_html = $input->param("is_html_$mtt"); And I'd guess all of the id attributes in the template within the "FOREACH lang IN letters.keys" -loop need to be verified, not just the sms ones ... :/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 07:45:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 06:45:01 +0000 Subject: [Koha-bugs] [Bug 20298] Notices template uses same html id for each language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20298 --- Comment #3 from paxed --- (In reply to paxed from comment #2) > Also: > tools/letter.pl: my $is_html = $input->param("is_html_$mtt"); > Derp, nevermind, that's the name, not the id. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 09:53:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 08:53:14 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted/old tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #4 from Francesco Rivetti --- Created attachment 72300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72300&action=edit Bug 20271: merging delete biblio/items NOTE: deleteditems/biblio on OAI not sure how to test this, but the changes should be good enough -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 10:20:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 09:20:57 +0000 Subject: [Koha-bugs] [Bug 20313] New: Article requests: Can we do without the processing notice ? Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20313 Bug ID: 20313 Summary: Article requests: Can we do without the processing notice ? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com For each article request we switch to processing status, Koha sends a mail to the patron. It does not tell much. The patron already received a mail that acknowledges his request; so why not send a mail only when the request has been completed? In other words: can we remove AR_PROCESSING ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 10:22:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 09:22:38 +0000 Subject: [Koha-bugs] [Bug 20313] Article requests: Can we do without the processing notice ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20313 --- Comment #1 from Marcel de Rooy --- Just adding another syspref is not really what I prefer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 10:51:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 09:51:56 +0000 Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 11:04:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 10:04:48 +0000 Subject: [Koha-bugs] [Bug 20317] New: 122222 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20317 Bug ID: 20317 Summary: 122222 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: hackerislam404 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Created attachment 72303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72303&action=edit 122222 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 11:26:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 10:26:07 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/17.05.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.05 |17.11 --- Comment #39 from Mirko Tietgen --- Fridolin: This is a "standing" bug, it will get new patches whenever a dependency is pushed. So after push I set it back to assigned. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 11:26:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 10:26:38 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED --- Comment #23 from Mirko Tietgen --- Back to assigned for further dependency patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 11:27:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 10:27:01 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/17.05.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.11 |17.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 11:27:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 10:27:24 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED Version|16.05 |17.11 --- Comment #9 from Mirko Tietgen --- Back to assigned for future dependency patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 11:32:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 10:32:04 +0000 Subject: [Koha-bugs] [Bug 20317] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20317 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID Summary|122222 |SPAM CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 11:33:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 10:33:00 +0000 Subject: [Koha-bugs] [Bug 20313] Article requests: Can we do without the processing notice ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20313 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Have you tried just deleting it? That's how it works for unwanted notices for suggestions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 11:38:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 10:38:28 +0000 Subject: [Koha-bugs] [Bug 20313] Article requests: Can we do without the processing notice ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20313 --- Comment #3 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #2) > Have you tried just deleting it? That's how it works for unwanted notices > for suggestions. As a workaround with warns.. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 11:54:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 10:54:52 +0000 Subject: [Koha-bugs] [Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 --- Comment #10 from Kyle M Hall --- Created attachment 72305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72305&action=edit Bug 19469 - Add ability to split view of holds view on record by pickup library and/or itemtype It is possible to set up circulation rules to limit trapping of holds by pickup library and itemtype. To make it easier to understand which holds will be trapped in a given circumstance, it would be nice if we could optionally group holds by pickup library and/or itemtype. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable AllowHoldItemTypeSelection 4) Pick a record and create holds with various pickup libraries and itemtype combinations 5) Enable HoldsSplitQueueNumbering 6) Try the different combinations of HoldsSplitQueue 7) Ensure the hold "arrows" move the items correctly * Up and down arrows should move hold above or below the adjacent hold within a hold fieldset * Top and borrom arrows should move hold to the top or bottom within a hold fieldset Sponsored-by: Stockholm University Library Signed-off-by: Kyle M Hall Followed test plan, patch worked as described. Also passed QA test tool Signed-off-by: Alex Buckley Signed-off-by: Andreas Hedstr?m Mace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 11:54:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 10:54:44 +0000 Subject: [Koha-bugs] [Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68347|0 |1 is obsolete| | Attachment #68609|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 72304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72304&action=edit Bug 19469 - Clean up template whitespace Sponsored-by: Stockholm University Library Signed-off-by: Kyle M Hall Passed QA test tool Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 12:06:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 11:06:30 +0000 Subject: [Koha-bugs] [Bug 20313] Article requests: Can we do without the processing notice ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20313 --- Comment #4 from Katrin Fischer --- Maybe we should just fix the warns then - it seems the easiest option. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 12:15:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 11:15:40 +0000 Subject: [Koha-bugs] [Bug 20251] SIP checkout broken in master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20251 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 12:18:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 11:18:16 +0000 Subject: [Koha-bugs] [Bug 17098] Validation problems with form field type "number" (decimal separator) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17098 --- Comment #9 from Katrin Fischer --- I ended up patching it like that: -
  • Example: 5.00
    • +
  • Example: 5.00
    • -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 12:25:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 11:25:16 +0000 Subject: [Koha-bugs] [Bug 18186] Plack config: Amounts with decimal comma instead of decimal dot breaking payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18186 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Amounts with decimal comma |Plack config: Amounts with |instead of decimal dot |decimal comma instead of |breaking payments |decimal dot breaking | |payments -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 12:32:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 11:32:12 +0000 Subject: [Koha-bugs] [Bug 20318] New: Merge invoices can lead to an merged invoice without Invoice number Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20318 Bug ID: 20318 Summary: Merge invoices can lead to an merged invoice without Invoice number Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: christophe.croullebois at biblibre.com QA Contact: testopia at bugs.koha-community.org When you want to merge invoices you have a page with a non editable field 'Invoice number:' it shows the content of the first invoice to be merged. But if you validate by clicking the 'merge' button you arrive on the next page which says that 'Invoice has been modified' and if you quit this page without saving you have now a merged invoice without Invoice number. This tiny patch just prevents this issue to occur. Test plan : 1? go to the acqui/invoices.pl page and search invoices to merge. You must have at least 2 invoices on the same vendor 2? check boxes to select invoices to merge and click on 'merge selected invoices' button 3? next page you see the non editable field 'Invoice number:' 4? click on the 'merge' button 5? next page you see 'Invoice has been modified' 6? leave this page i.e click on the left link 'Invoices' 7? search invoices you'll see the merged invoice without invoice number. Apply the patch, replay the steps 1 to 3 4? on this page you can enter your invoice number and click on the 'merge' button. If you leave this field empty and click merge, a message informs you that it is required and you can not merge. Thx -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 12:44:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 11:44:25 +0000 Subject: [Koha-bugs] [Bug 20318] Merge invoices can lead to an merged invoice without Invoice number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20318 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |christophe.croullebois at bibl | |ibre.com Assignee|koha-bugs at lists.koha-commun |christophe.croullebois at bibl |ity.org |ibre.com --- Comment #1 from Christophe Croullebois --- Created attachment 72306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72306&action=edit Merge invoices can lead to an merged invoice without Invoice number thx to test -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 13:29:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 12:29:35 +0000 Subject: [Koha-bugs] [Bug 17098] Validation problems with form field type "number" (decimal separator) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17098 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 13:38:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 12:38:26 +0000 Subject: [Koha-bugs] [Bug 20114] Build better $query_cgi In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20114 --- Comment #2 from David Gustafsson --- Discoverd a double-encoding issue, and problem with sort_by being appended multiple times. So probably best to avoid reviewing this issue until this is fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 14:05:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 13:05:50 +0000 Subject: [Koha-bugs] [Bug 20278] Cancel Hold alert in OPAC provides confusing options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20278 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 14:16:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 13:16:15 +0000 Subject: [Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com | |, | |kelly at bywatersolutions.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 14:16:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 13:16:45 +0000 Subject: [Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 14:24:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 13:24:04 +0000 Subject: [Koha-bugs] [Bug 19873] Make it possible to search on value 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19873 --- Comment #6 from Alex Arnaud --- Created attachment 72307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72307&action=edit Bug 19873 - Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 14:25:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 13:25:49 +0000 Subject: [Koha-bugs] [Bug 20319] New: disable login for staff Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20319 Bug ID: 20319 Summary: disable login for staff Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: abdjh at yu.edu.jo QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com can you please add a disable option for staff login, to disable login without changing anything else, and keep all other option available I need only to stop staff from login when they transferred to other department. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 14:49:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 13:49:05 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 --- Comment #22 from Alex Arnaud --- (In reply to M. Tompsett from comment #20) > Why is this change so far away from the other? Which other? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 15:21:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 14:21:26 +0000 Subject: [Koha-bugs] [Bug 20320] Add a "Library CSS" parameter in the Library Admin page to allow site specific customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20320 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 15:21:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 14:21:20 +0000 Subject: [Koha-bugs] [Bug 20320] New: Add a "Library CSS" parameter in the Library Admin page to allow site specific customizations Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20320 Bug ID: 20320 Summary: Add a "Library CSS" parameter in the Library Admin page to allow site specific customizations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The parameter should allow specifying a URL to import css for a specific branch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 15:44:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 14:44:42 +0000 Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |m.de.rooy at rijksmuseum.nl Status|NEW |ASSIGNED --- Comment #4 from Marcel de Rooy --- Will provide an 'intelligent guess' at search results without the performance penalty of going through all items. Detail can be more precise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 15:44:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 14:44:24 +0000 Subject: [Koha-bugs] [Bug 20251] SIP checkout broken in master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20251 --- Comment #4 from Colin Campbell --- Created attachment 72308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72308&action=edit Patch with signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 15:45:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 14:45:39 +0000 Subject: [Koha-bugs] [Bug 20251] SIP checkout broken in master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20251 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Colin Campbell --- (In reply to Jonathan Druart from comment #3) > Hi Colin, thanks for catching that! > Does this patch make sense to you? Yes, I've ran tests doing issues and related operations and responses are ok -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 15:58:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 14:58:00 +0000 Subject: [Koha-bugs] [Bug 20268] CSS regression: white gap on the top of the staff pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20268 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 16:01:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 15:01:31 +0000 Subject: [Koha-bugs] [Bug 20261] No result in some page in authority search opac and pro (ES) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20261 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 16:04:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 15:04:48 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Roch D'Amour changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 16:04:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 15:04:52 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #120 from Roch D'Amour --- Created attachment 72309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72309&action=edit Bug 11317 - File with same name in different directories now has distinct hash + QA followup Testing: 0. Make sure the requirements from the last patches are met 1. Add 2 accessdir in your koha-conf, i.e. "/tmp/test" and "/tmp/moretest". 2. Add a file in both directories using the same name for the file: - echo "small file" > /tmp/test/log - echo "the size of this file is quite huge" > /tmp/moretest/log 3. Go to Home ? Tools ? Report/log files and you should see both files with different size. 4. Download (or open) both files. They should be different. Thanks for testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 16:05:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 15:05:19 +0000 Subject: [Koha-bugs] [Bug 20268] CSS regression: white gap on the top of the staff pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20268 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 16:05:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 15:05:22 +0000 Subject: [Koha-bugs] [Bug 20268] CSS regression: white gap on the top of the staff pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20268 --- Comment #3 from Owen Leonard --- Created attachment 72310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72310&action=edit Bug 20268: CSS regression: white gap on the top of the staff pages This patch makes template and CSS changes so that the staff client main page doesn't get an unwanted top margin from the Bootstrap-grid conversion. - The unused "main" class is removed from the login page - The "main" class on the staff client home page is changed to "intranet-main." - The CSS for the staff client home page has been modified accordingly. To test, apply the patch and clear your browser cache if necessary. - Open the staff client login page. It should look as it always does. - Log in and check the style of the main page. There should be no white margin at the top of the page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 16:06:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 15:06:17 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Roch D'Amour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72097|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 16:16:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 15:16:19 +0000 Subject: [Koha-bugs] [Bug 20280] Authorised value categories list in bibliographic frameworks has 2 empty entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20280 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 16:16:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 15:16:09 +0000 Subject: [Koha-bugs] [Bug 20280] Authorised value categories list in bibliographic frameworks has 2 empty entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20280 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- installer/data/mysql/mandatory/auth_val_cat.sql: 1 INSERT IGNORE INTO authorised_value_categories( category_name ) 2 VALUES 3 (''), but installer/data/mysql/updatedatabase.pl: 13164 INSERT IGNORE INTO authorised_value_categories( category_name ) 13165 VALUES 13166 ('Asort1'), "" is missing Moreover: commit 62aa3f4292d83bc9304e296de5f0830e28510492 Bug 17216: Use Koha::AVC from mss.pl Added this additional blank entry in the template: + Additional info, in admin/authorised_values.pl we have: 215 my @categories = Koha::AuthorisedValueCategories->search({ category_name => { -not_in => ['', 'branches', 'itemtypes', 'cn_source']}}, { order_by => ['category_name'] } ); So maybe a solution could be to: - remove all the additional entries in template (if there are others than in admin/marc_subfields_structure.tt) - the add the AV category "" to existing install (unless it already exists) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 16:25:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 15:25:44 +0000 Subject: [Koha-bugs] [Bug 20245] Wrong language code for Slovak In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Hola Petr, Can you provide a patch please? https://wiki.koha-community.org/wiki/Submitting_A_Patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 16:25:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 15:25:57 +0000 Subject: [Koha-bugs] [Bug 20245] Wrong language code for Slovak In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Version|16.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 16:26:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 15:26:50 +0000 Subject: [Koha-bugs] [Bug 15510] New professional cataloguing editor shows OPAC favicon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15510 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|REOPENED |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 16:43:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 15:43:36 +0000 Subject: [Koha-bugs] [Bug 19342] Show name private list on biblio when user is logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19342 --- Comment #1 from Marjorie Barry-Vila --- Hi, It would be fine to display too name of private list when logged in opac-search.pl and search.pl Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:00:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:00:12 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:00:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:00:15 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68569|0 |1 is obsolete| | Attachment #68572|0 |1 is obsolete| | Attachment #68644|0 |1 is obsolete| | Attachment #68645|0 |1 is obsolete| | Attachment #69873|0 |1 is obsolete| | Attachment #69874|0 |1 is obsolete| | Attachment #69875|0 |1 is obsolete| | Attachment #71574|0 |1 is obsolete| | Attachment #71575|0 |1 is obsolete| | Attachment #71576|0 |1 is obsolete| | Attachment #71577|0 |1 is obsolete| | Attachment #71578|0 |1 is obsolete| | Attachment #71579|0 |1 is obsolete| | Attachment #71580|0 |1 is obsolete| | Attachment #71581|0 |1 is obsolete| | Attachment #71582|0 |1 is obsolete| | Attachment #71583|0 |1 is obsolete| | Attachment #71584|0 |1 is obsolete| | Attachment #71585|0 |1 is obsolete| | Attachment #71586|0 |1 is obsolete| | Attachment #71587|0 |1 is obsolete| | Attachment #71588|0 |1 is obsolete| | Attachment #71589|0 |1 is obsolete| | Attachment #71590|0 |1 is obsolete| | Attachment #71592|0 |1 is obsolete| | Attachment #72244|0 |1 is obsolete| | --- Comment #96 from Nick Clemens --- Created attachment 72311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72311&action=edit Bug 19532: Database updates Adding the recalls table and the old_recalls table. Sponsored-by: Catalyst IT Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:00:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:00:19 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #97 from Nick Clemens --- Created attachment 72312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72312&action=edit Bug 19532: Module files for Recall and OldRecall Koha/Recall.pm Koha/Recalls.pm Koha/Old/Recall.pm Koha/Old/Recalls.pm and the schema files for Recall and OldRecall. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:00:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:00:25 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #98 from Nick Clemens --- Created attachment 72313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72313&action=edit Bug 19532: Some DB fixes Removing the old_recalls table, as suggested in Comment 5 Renaming 'found' column to 'status' Adding 'old' column Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:00:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:00:29 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #99 from Nick Clemens --- Created attachment 72314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72314&action=edit Bug 19532: Some module fixes Removing files related to OldRecall Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:00:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:00:37 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #101 from Nick Clemens --- Created attachment 72316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72316&action=edit Bug 19532: Recall an item in OPAC This patch: - adds the 'Recall' button to the item on it's detail page - adds ability to place a recall - the recall is stored in the recalls table - the due date for the checkout is updated to whatever has been set in the issuing rule under recall_due_date_interval - error messages for if the user isn't logged in, the user tries to place a recall on an item they have already recalled, or if storing the recall in the db fails for any reason Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:00:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:00:33 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #100 from Nick Clemens --- Created attachment 72315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72315&action=edit Bug 19532: Circulation rules Adding 3 new rules and columns to issuingrules - recall_due_date_interval - recall_overdue_fine - recall_shelf_time Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:00:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:00:42 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #102 from Nick Clemens --- Created attachment 72317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72317&action=edit Bug 19532: Cancel recall and see recalls in OPAC This patch adds ability for user to cancel a recall They can also see their recalls in the user summary Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:00:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:00:46 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #103 from Nick Clemens --- Created attachment 72318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72318&action=edit Bug 19532: Show recalls on intranet side This patch - adds Recall tab to the Check out section of member account, and to the Details section of member account - Functionality to cancel recalls on staff side - Fixing cancel on OPAC side (before I was deleting the whole recall instead of cancelling) - Fixing validation when checking whether a recall can be placed on an item that has been recalled by this borrower before. If the old recall is expired or cancelled then they can make a recall again. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:00:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:00:50 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #104 from Nick Clemens --- Created attachment 72319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72319&action=edit Bug 19532: Fixing broken OPAC recalls table Forgot to add Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:00:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:00:55 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #105 from Nick Clemens --- Created attachment 72320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72320&action=edit Bug 19532: recalls history this patch - adds recalls history (similar to holds history) to OPAC and intranet - edits the tables in opac-user.pl (OPAC), moremember.pl and circulation.pl (staff) so that it only shows active recalls (recalls that have been requested or are waiting) - some extra datatables fixes Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:00:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:00:59 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #106 from Nick Clemens --- Created attachment 72321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72321&action=edit Bug 19532: Recalls queue This patch adds a recalls queue page to the circulation reports You can see all recalls made in the system, who requested them, their status and other relevant info. you can cancel individual or multiple recalls. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:01:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:01:04 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #107 from Nick Clemens --- Created attachment 72322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72322&action=edit Bug 19532: Overdue recalls report Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:01:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:01:08 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #108 from Nick Clemens --- Created attachment 72323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72323&action=edit Bug 19532: Recalls awaiting pickup report this patch adds reports for all recalls awaiting pickup, and recalls that have been waiting more than X days. a syspref, RecallsMaxPickUpDelay, is added to give a general max shelf time for recalls Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:01:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:01:12 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #109 from Nick Clemens --- Created attachment 72324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72324&action=edit Bug 19532: Only recall items checked out by other users ... shouldn't be able to recall items that are currently checked out by yourself. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:01:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:01:17 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #110 from Nick Clemens --- Created attachment 72325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72325&action=edit Bug 19532: UseRecalls syspref This patch adds a syspref to control the usability of the recalls feature Test the following: Staff side /includes/circ-menu.inc /includes/circ-nav.inc /includes/members-menu.inc /admin/preferences/circulation.pref /circ/circulation-home.tt /circ/circulation.tt /circ/recalls_overdue.tt /circ/recalls_queue.tt /circ/recalls_waiting.tt /members/moremember.tt /members/recallshistory.tt OPAC /includes/usermenu.inc /opac-recall.tt /opac-recalls.tt /opac-user.tt /members/recallshistory.pl /opac/opac-detail.pl Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:01:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:01:21 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #111 from Nick Clemens --- Created attachment 72326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72326&action=edit Bug 19532: Recall pop up when checking in an item When checking in an item on the staff side, the staff member will see a pop up if there is a recall attached to that item. From here, they can confirm the recall, setting the status to 'Waiting' and updating the waitingdate. The item will still be checked in. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:01:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:01:25 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #112 from Nick Clemens --- Created attachment 72327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72327&action=edit Bug 19532: Send notice to user to return a recalled item When the recall is placed in the OPAC, a RETURN_RECALLED_ITEM notice is sent to the user who has the item checked out, with the updated due date. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:01:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:01:29 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #113 from Nick Clemens --- Created attachment 72328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72328&action=edit Bug 19532: Send notice to user to pickup recalled returned item Send a PICKUP_RECALLED_ITEM notice to the user who requested a recall when the item is checked in. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:01:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:01:33 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #114 from Nick Clemens --- Created attachment 72329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72329&action=edit Bug 19532: Flagging recall as 'old' when expired or cancelled Set 'old' flag to 1 if cancelling or expiring a recall Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:01:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:01:42 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #116 from Nick Clemens --- Created attachment 72331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72331&action=edit Bug 19532: Tests for Koha/Recalls Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:01:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:01:37 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #115 from Nick Clemens --- Created attachment 72330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72330&action=edit Bug 19532: Cronjob to check for overdue recalls This patch adds a check to the overdue_notices cronjob, so if any of the overdue issues are also recalls, the status will be set to O (overdue) Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:01:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:01:46 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #117 from Nick Clemens --- Created attachment 72332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72332&action=edit Bug 19532: Nice message if no recalls for opac recalls history https://bugs.koha-community.org/show_bug.cgi?id=19523 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:01:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:01:55 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #119 from Nick Clemens --- Created attachment 72334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72334&action=edit Bug 19532: Extra fixes This patch addresses some of Liz's comments in Comment 37 - shows new due date on opac-recall.pl when the recall is requested - shows new due date on opac-recalls.pl recalls history - shows new due date on circ/recalls_queue.pl - syspref is default off - recalls tab on catalogue/detail.pl - show that there is a recall on an item on catalogue/detail.pl Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:01:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:01:50 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #118 from Nick Clemens --- Created attachment 72333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72333&action=edit Bug 19532: POD fix, renaming methods Tomas's comments: - renaming 'Class methods' to 'internal methods' - renaming 'borrower' and 'branch' methods to 'patron' and 'library' other comments are out of date with current patches and do not need to be actioned when testing, confirm all data still shows as expected and nothing is broken Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:01:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:01:59 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #120 from Nick Clemens --- Created attachment 72335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72335&action=edit Bug 19532: Notices for recalls The notices: -RETURN_RECALLED_ITEM -PICKUP_RECALLED_ITEM have been created and added to sample_notices.sql Changed tools/letter.pl to use recalls table Added notices to translated installers https://bugs.koha-community.org/show_bug.cgi?id=19523 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:02:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:02:04 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #121 from Nick Clemens --- Created attachment 72336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72336&action=edit Bug 19532: Extra fixes from Comment 68 This patch fixes the following: The db uppdate tries to insert after 'notes' in issuing rules, but this doesn't exist When placing recall I always get a warning:

    Warning: Your library does not allow recalls for x item types.

    Cancelling recall from 'Recall history tab' doesn't work If patron has no recalls there is 'Patron has no current recalls' message at bottom of tabs on checkout and details tabs for patron When confirming a recall if the item is from another branch I get a transfer generated as well as confirming hold for recall Feature now checks if the recall branch is the same as the item holding branch when checking in item to determine if transfer is required On recalls awaiting pickup: need to update recall.borrower to recall.patron - causing internal server error When placing a recall - if I hit 'back' after confirming and confirm again I get a second recall on the same item Recalls queue should have waiting date information Recalls queue should have a way to hide cancelled, I would expect closed recalls to be hidden by default Recalls queue now hides old (cancelled/expired/finished) recalls by default and has a checkbox to toggle this When viewing a patrons account in the staff side we should see that a checkout has an active recall Checking out the recall doesn't seem to close the recall Added an 'F' status for finished/closed recalls Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:02:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:02:08 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #122 from Nick Clemens --- Created attachment 72337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72337&action=edit Bug 19532 (follow-up) Update characterset for recalls table Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:02:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:02:13 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #123 from Nick Clemens --- Created attachment 72338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72338&action=edit Bug 19532 - Improve and refine recalls functionality Only allow 1 recall per item When checking in only check for holds if no reserves found Add a T/transferring status for recalls, only confirm them once arrived Improve message when checking in recall Fix clashing ids on recall-history Check if patron can hold item before allowing recall Prevent multiple recalls when pressing back button Select/fill only active recall when issuing To test: 1 - Repeat major test plan - verify all points 2 - Attempt to place multiple recallsusing back button, should fail 3 - Set all item level holds to not allowed, should not be able to place recall 4 - Check-in recall at branch other than destination, should be in transit 5 - Confirm at correct branch, should send message and get expiration date etc. 6 - Return to another branch, should eb in transit again 7 - Play with circ rules and verify only allowed patrons can place recall Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:02:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:02:14 +0000 Subject: [Koha-bugs] [Bug 20268] CSS regression: white gap on the top of the staff pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20268 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:02:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:02:17 +0000 Subject: [Koha-bugs] [Bug 20268] CSS regression: white gap on the top of the staff pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20268 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72310|0 |1 is obsolete| | --- Comment #4 from Claire Gravely --- Created attachment 72339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72339&action=edit Bug 20268: CSS regression: white gap on the top of the staff pages This patch makes template and CSS changes so that the staff client main page doesn't get an unwanted top margin from the Bootstrap-grid conversion. - The unused "main" class is removed from the login page - The "main" class on the staff client home page is changed to "intranet-main." - The CSS for the staff client home page has been modified accordingly. To test, apply the patch and clear your browser cache if necessary. - Open the staff client login page. It should look as it always does. - Log in and check the style of the main page. There should be no white margin at the top of the page. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:05:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:05:13 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #124 from Nick Clemens --- Rebased, tested and added some follow-ups to refine the functionality here - Aleisha can you sign off on my patch? This implements basic recall functionality and leaves room for improvements, this is a good starting point and I think can be QAed with an eye toward building refinement and extending functionality in future patchsets. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:33:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:33:21 +0000 Subject: [Koha-bugs] [Bug 20321] New: C4:XISBN->get_biblionumber_from_isbn is not used Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20321 Bug ID: 20321 Summary: C4:XISBN->get_biblionumber_from_isbn is not used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Let remove it -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:33:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:33:27 +0000 Subject: [Koha-bugs] [Bug 20321] C4:XISBN->get_biblionumber_from_isbn is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20321 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:35:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:35:02 +0000 Subject: [Koha-bugs] [Bug 20321] C4:XISBN->get_biblionumber_from_isbn is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20321 --- Comment #1 from Nick Clemens --- Created attachment 72340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72340&action=edit Bug 20321 - Remove get_biblionumber_from_isbn To test: 1 - grep get_biblionumber_from_isbn 2 - verify all occurences are not actual calls (except for test) 3 - Apply patch 4 - grep get_biblionumber_from_isbn 5 - Verify it is removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:35:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:35:00 +0000 Subject: [Koha-bugs] [Bug 20321] C4:XISBN->get_biblionumber_from_isbn is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20321 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 17:43:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 16:43:44 +0000 Subject: [Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com Severity|enhancement |major --- Comment #2 from Barton Chittenden --- Marking as major, simply because this is going to cause a lot of confusion; I foresee many support tickets. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 18:15:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 17:15:26 +0000 Subject: [Koha-bugs] [Bug 20079] Display stack trace for development installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20079 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70862|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 72341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72341&action=edit Bug 20079: Display stack trace for development installations """The default value is development, which causes plackup to load the middleware components: AccessLog, StackTrace, and Lint unless --no-default-middleware is set.""" Test plan: Confirm that the stack trace is displayed when something is wrong (die somewhere to test) for dev installations (inside a devbox) The -E flag must remain deployment for non-dev installs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 18:22:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 17:22:44 +0000 Subject: [Koha-bugs] [Bug 19908] Password should not be mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Agnes Rivers-Moore changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm at hanover.ca --- Comment #17 from Agnes Rivers-Moore --- Our Koha as of 17.11.03 does not generate default username for any patron type. Josef said 'Other categories (than org) have username generated as "firstname.surname" if you leave it blank' - but that does not seem to be the case any more. Previous behaviour also assigned a default password, and that also does not happen any more. Result is staff have to add three fields, making them unique/matching, even if the patron does not want an online account. Looking forward to this being non-mandatory! Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 19:21:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 18:21:51 +0000 Subject: [Koha-bugs] [Bug 19866] Move template JavaScript to the footer: UNIMARC editor plugins, part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19866 --- Comment #2 from Owen Leonard --- Here's a more thorough description of how this patch can be tested even if you don't have a UNIMARC system: - Go to Administration -> MARC frameworks -> Default framework -> MARC structure - For any tag (I like to use 000 because it's the first one), choose Actions -> Subfields. - Edit any subfield you want to configure (choose one that isn't hidden). - Expand the "Other options" panel and select the plugin you want to test under "Plugin." - Save changes. - Open an existing or new MARC record for editing in the standard MARC editor. - Find the tag and subfield you just modified, and look for the small plugin trigger icon next to the form field. - Confirm that clicking this link triggers the correct plugin (the pop-up window should have a heading with the correct plugin name). - Make some changes to the options in the plugin window in a way that you will be able to confirm the changes are transferred to the field in the MARC editor. For instance, choose all the same codes for multiple fields. - Submit your changes in the plugin's pop-up window. The window should close. - Confirm that the values you submitted from the plugin window have been transferred to the correct field in the MARC editor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 20:06:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 19:06:44 +0000 Subject: [Koha-bugs] [Bug 19749] Report who show all the reservations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19749 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #3 from Magnus Enger --- Could this report do the job? https://wiki.koha-community.org/wiki/SQL_Reports_Library#Unfilled_Holds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 20:27:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 19:27:42 +0000 Subject: [Koha-bugs] [Bug 17218] New list add attempt while logged in as dbadmin on staff side should be prevented pre-emptively In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17218 --- Comment #9 from M. Tompsett --- Comment on attachment 72298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72298 Bug 17218: Stop DB user from clicking 'New list' button Review of attachment 72298: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17218&attachment=72298) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/includes/virtualshelves-toolbar.inc @@ +10,5 @@ > + }); > + [% END %] > +}); > + > +[% IF op == 'view' %] I don't understand this whole IF block's purpose. It seems like new unrelated code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 20:31:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 19:31:40 +0000 Subject: [Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 20:33:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 19:33:32 +0000 Subject: [Koha-bugs] [Bug 5463] limit to available shows on hold items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5463 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 20:49:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 19:49:45 +0000 Subject: [Koha-bugs] [Bug 17218] New list add attempt while logged in as dbadmin on staff side should be prevented pre-emptively In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17218 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset at hotmail.com --- Comment #10 from M. Tompsett --- http://localhost:8081/cgi-bin/koha/virtualshelves/addbybiblionumber.pl?newshelf=1&biblionumber=1 When you view the contents of an existing public list, there is a drop-down to add to cart or a new list. That creates a bunch of possible explosion points, like the kohadevbox link above. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 1 21:39:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Mar 2018 20:39:11 +0000 Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 03:37:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 02:37:56 +0000 Subject: [Koha-bugs] [Bug 20322] New: Circulation page layout and design update Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322 Bug ID: 20322 Summary: Circulation page layout and design update Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com I think maybe it's time we refreshed and improved the circulation home page, don't you? :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 03:48:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 02:48:22 +0000 Subject: [Koha-bugs] [Bug 20322] Circulation page layout and design update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322 --- Comment #1 from Liz Rea --- Created attachment 72342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72342&action=edit Bug 20322: design refresh for circulation page do note, I don't actually mind if these aren't the changes eventually accepted. I just know it needs doing and starting it will hopefully get some gears turning. To test: Click all the links and check they work. Do you like the styling? it's different. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 07:38:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 06:38:02 +0000 Subject: [Koha-bugs] [Bug 20251] SIP checkout broken in master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20251 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #6 from Marcel de Rooy --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 08:09:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 07:09:29 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted/old tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #5 from Josef Moravec --- Comment on attachment 72300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72300 Bug 20271: merging delete biblio/items Review of attachment 72300: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20271&attachment=72300) ----------------------------------------------------------------- Just a quick look: there is missing atomic database update also the test suite should be adjusted I am not sure about the changes in OAI, so need to investigate more later ::: C4/Biblio.pm @@ -3182,5 @@ > - my $bkup_sth = $dbh->prepare($query); > - $bkup_sth->execute(@bind); > - $bkup_sth->finish; > - > - _koha_delete_biblio_metadata( $biblionumber ); this is missing in your patch ::: C4/Items.pm @@ +1061,4 @@ > FROM items > LEFT JOIN branches AS holding ON items.holdingbranch = holding.branchcode > LEFT JOIN branches AS home ON items.homebranch=home.branchcode > + LEFT JOIN biblio ON biblio.biblionumber = items.biblionumber AND biblio.deleted_at IS NULL I don't think this will work, that's condition should be in where clause ::: misc/export_records.pl @@ +105,5 @@ > push @record_ids, $_->{biblionumber} for @{ > + $dbh->selectall_arrayref(q| > + SELECT biblionumber > + FROM biblioitems > + |, { Slice => {} }, ( $timestamp ) x 4 ); Please include the changes made by Bug 19730 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 08:19:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 07:19:56 +0000 Subject: [Koha-bugs] [Bug 20251] SIP checkout broken in master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20251 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72291|0 |1 is obsolete| | Attachment #72308|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 72343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72343&action=edit Bug 20251: (bug 19280 follow-up) FIX SIP checkout Signed-off-by: Colin Campbell Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 08:19:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 07:19:53 +0000 Subject: [Koha-bugs] [Bug 20251] SIP checkout broken in master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20251 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 08:38:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 07:38:24 +0000 Subject: [Koha-bugs] [Bug 20268] CSS regression: white gap on the top of the staff pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20268 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 08:38:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 07:38:27 +0000 Subject: [Koha-bugs] [Bug 20268] CSS regression: white gap on the top of the staff pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20268 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72339|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 72344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72344&action=edit Bug 20268: CSS regression: white gap on the top of the staff pages This patch makes template and CSS changes so that the staff client main page doesn't get an unwanted top margin from the Bootstrap-grid conversion. - The unused "main" class is removed from the login page - The "main" class on the staff client home page is changed to "intranet-main." - The CSS for the staff client home page has been modified accordingly. To test, apply the patch and clear your browser cache if necessary. - Open the staff client login page. It should look as it always does. - Log in and check the style of the main page. There should be no white margin at the top of the page. Signed-off-by: Claire Gravely Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 08:38:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 07:38:52 +0000 Subject: [Koha-bugs] [Bug 20268] CSS regression: white gap on the top of the staff pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20268 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 09:03:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 08:03:11 +0000 Subject: [Koha-bugs] [Bug 19547] Maria DB doesn't have a debian.cnf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19547 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 09:03:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 08:03:20 +0000 Subject: [Koha-bugs] [Bug 19547] Maria DB doesn't have a debian.cnf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19547 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72283|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy --- Created attachment 72346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72346&action=edit Bug 19547: Deal with --create-db missing debian.cnf issue Followed test plan. Patch functions as described and both commands execute. Signed-off-by: Dilan Johnpull? Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 09:03:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 08:03:31 +0000 Subject: [Koha-bugs] [Bug 19547] Maria DB doesn't have a debian.cnf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19547 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 09:03:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 08:03:15 +0000 Subject: [Koha-bugs] [Bug 19547] Maria DB doesn't have a debian.cnf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19547 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68850|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 72345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72345&action=edit Bug 19547: MariaDB install has no debian.cnf This attempts to handle issues arising when running koha-create on a system that never had MySQL installed. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 09:05:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 08:05:48 +0000 Subject: [Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 --- Comment #11 from Marcel de Rooy --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 10:00:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 09:00:05 +0000 Subject: [Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #12 from Marcel de Rooy --- Still working on it. Suspect that we are not ready yet.. Moving to BLOCKED temporarily -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 11:06:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 10:06:17 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #2 from Josef Moravec --- Hi Jonathan, I've read the code and added few comment to commits in gitlab, hope you've received a notice about that ;) Also, there are some issues reported by QA tools: FAIL C4/Members.pm FAIL pod *** ERROR: Spurious =cut command in file C4/Members.pm FAIL opac/opac-messaging.pl FAIL valid Global symbol "$borrower" requires explicit package name opac/opac-messaging.pl had compilation errors. FAIL opac/opac-registration-verify.pl FAIL valid "generate_password" is not exported by the Koha::AuthUtils module Can't continue after import errors FAIL tools/modborrowers.pl FAIL valid Global symbol "$success" requires explicit package name tools/modborrowers.pl had compilation errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 11:12:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 10:12:25 +0000 Subject: [Koha-bugs] [Bug 20323] New: Batch patron modification tool broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20323 Bug ID: 20323 Summary: Batch patron modification tool broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org >From tools/modborrowers.pl 341 if ( $patron ) { 342 $patron = $patron->unblessed; 343 $patron->{category_description} = $patron->category->description; This was added by bug 18403 and leads (obviosly) to error: Can't call method "category" on unblessed reference at /home/vagrant/kohaclone/tools/modborrowers.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 11:18:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 10:18:03 +0000 Subject: [Koha-bugs] [Bug 20323] Batch patron modification tool broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20323 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com |ity.org | Depends on| |18403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 [Bug 18403] Hide patron information if not part of the logged in user library group -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 11:18:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 10:18:03 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20323 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20323 [Bug 20323] Batch patron modification tool broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 11:18:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 10:18:27 +0000 Subject: [Koha-bugs] [Bug 20323] Batch patron modification tool broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20323 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 11:18:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 10:18:29 +0000 Subject: [Koha-bugs] [Bug 20323] Batch patron modification tool broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20323 --- Comment #1 from Josef Moravec --- Created attachment 72347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72347&action=edit Bug 20323: Fix batch patron modification tool Test plan: 1) Go to Tools -> Batch patrons modification 2) Select some patrons and try to change any field --> without patch - it exploads with log: Can't call method "category" on unblessed reference at /home/vagrant/kohaclone/tools/modborrowers.pl --> with patch - the modification is properly made -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 12:13:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 11:13:19 +0000 Subject: [Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 --- Comment #14 from Marcel de Rooy --- Created attachment 72349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72349&action=edit Bug 18958: (Follow-up) Pass patron to template for confirm hold Removing the FIXME. Trivial fix. Not sure where to put it; can be moved on its own. Test plan: Confirm a hold and verify that patron details are shown in popup. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 12:13:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 11:13:14 +0000 Subject: [Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72210|0 |1 is obsolete| | Attachment #72211|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy --- Created attachment 72348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72348&action=edit Bug 18958 - If patron has multiple record level holds on one record transferring first hold causes next hold to become item level Imagine you have a record with 3 items, each item is held by LibraryA, LibraryB and LibraryC respectively. Now, a patron places to record level holds for pickup at LibraryD. When any of the items are checked in, that item is trapped to fill the first hold, but a side affect is that the next open hold because item level for the item that was just checked in! This is clearly incorrect and prevents the patron from placing more record level holds on the record. Test Plan: 1. Create and use a patron that can place multiple record level holds per record 2. Create a record with X items, each at a different library 3. Place X 'Next available' holds on the record for the patron using the 'Holds to place' box 4. Rebuild the holds queue 5. Check in LibraryA's copy as LibraryA and confirm the hold 6. Revisit request.pl for the record, notice the next hold in line is now item-specific 7. Attempt to place another hold for your patron, notice that it requires an item-specific hold 8. Apply this patch 9. Repeat steps 1-4 10. Revisit request.pl for the record, notice the next hold in line has *not* become item-specific Signed-off-by: Kyle M Hall Signed-off-by: Jason Robb Signed-off-by: Josef Moravec Bug 18958 [QA Followup] - Bring back data needed for the diffbranch block of the template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 12:18:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 11:18:13 +0000 Subject: [Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 12:18:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 11:18:15 +0000 Subject: [Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72004|0 |1 is obsolete| | Attachment #72005|0 |1 is obsolete| | Attachment #72006|0 |1 is obsolete| | Attachment #72007|0 |1 is obsolete| | Attachment #72095|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall --- Created attachment 72350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72350&action=edit Bug 19933: Remove patronflags - unused vars oldamount/amountold in circulation.pl There is oldamound/amountold variable that is sent to the template but never used later. Let remove it now to avoid useless replacement. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 12:18:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 11:18:23 +0000 Subject: [Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 --- Comment #17 from Kyle M Hall --- Created attachment 72351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72351&action=edit Bug 19933: Remove patronflags - In CanBookBeIssued The change is trivial here, we only want to pass gonenoaddress, lost and is_debared to the template. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 12:18:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 11:18:26 +0000 Subject: [Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 --- Comment #18 from Kyle M Hall --- Created attachment 72352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72352&action=edit Bug 19933: Remove patronflags - easy ones This patch replaces the easy occurrences of patronflags. These calls only need the CHARGES->amount value, that is the non issues charges. Luckily we now have a Koha::Account->non_issues_charges that deal with that. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 12:18:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 11:18:29 +0000 Subject: [Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 --- Comment #19 from Kyle M Hall --- Created attachment 72353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72353&action=edit Bug 19933: Remove patronflags - tricky ones Here we are, patronflags is used in a couple of places where (almost) all flags were really useful: C4::SIP::ILS::Patron->new and circulation.pl This patch only deal with the circulation code as I am not convident enough with SIP code. The change does not seems trivial because of the complexity of the existing code, but the logic is the same. We send a variable to the template depending on the situation of the patron. I guess only code eyes ball could catch issue in this patch quickly. Maybe we need to find a good place in a Koha module to move this code and provide code coverage (especially when C4::SIP::ILS::Patron will reuse it). Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 12:18:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 11:18:32 +0000 Subject: [Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 --- Comment #20 from Kyle M Hall --- Created attachment 72354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72354&action=edit Bug 19933: (follow-up) Remove patronflags - easy ones Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 12:18:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 11:18:35 +0000 Subject: [Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 --- Comment #21 from Kyle M Hall --- Created attachment 72355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72355&action=edit Bug 19933: Move instantiation of in deletemem.pl Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 12:18:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 11:18:38 +0000 Subject: [Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 --- Comment #22 from Kyle M Hall --- Created attachment 72356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72356&action=edit Bug 19933: Fix typo in template plugin name Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 12:18:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 11:18:59 +0000 Subject: [Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #15 from Marcel de Rooy --- Squashed both patches. Follow-up may need to be moved. Tested this quite a bit. Hard to reproduce at first. (Alternative test plan in next comment.) Failing QA because this patch has side-effects when you cancel a hold from the confirm hold popup. Before we called GetOtherReserves and now we dont. This changes behavior. Also I am wondering if the passed patron etc. at lines 160/170 makes any sense. If you confirm the transfer or cancel, you come back to the default returns.pl form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 12:19:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 11:19:20 +0000 Subject: [Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|josef.moravec at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 12:21:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 11:21:00 +0000 Subject: [Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 --- Comment #16 from Marcel de Rooy --- [Without patch] Three items (CPL MPL RMA) 2 record level patron A and item level from patron B (CPL) Checkin CPL item at RMA Confirm Waiting OK Checkin this item again and Cancel Finally reproduced the error: Second patron A hold became Item level (Bug) Checkin again, confirm Checkin and cancel What happened? Priority last hold = 1. Transfer created. No message to staff. (Bug: transit should be a T hold?) [With patch] Three items 2 record level for patron A 1 item level for patron B on CPL item Goto RMA Checkin CPL item, confirm for patron A Waiting So far so good. Checkin again and cancel. Second record level hold at 1. This cancel created no transfer. No message. (Behavior change?) Checkin again, confirm. Waiting OK Checkin again, cancel. Last item level hold at 1. No transfer. No message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 12:44:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 11:44:09 +0000 Subject: [Koha-bugs] [Bug 20167] Item hold is set to bibliographic hold when changing pickup location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20167 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 13:48:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 12:48:29 +0000 Subject: [Koha-bugs] [Bug 18345] Add a more ES based query builder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18345 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #2 from Julian Maurice --- What is the status of this bug ? Waiting for sign-off ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 14:04:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 13:04:26 +0000 Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #7 from Julian Maurice --- Is the new option really necessary ? I can't imagine a use case where someone would like to not use this feature. And if users really want to repeat themselves they can just rename one of the parameters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 14:05:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 13:05:16 +0000 Subject: [Koha-bugs] [Bug 19546] Can't locate Mojolicious/Plugin/Koha/REST/Plugin/Pagination.pm breaks opac and staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED --- Comment #14 from Tom?s Cohen Arazi --- I managed to reproduce. This is the same issue introduced by Perl 5.18 we face with cronjobs. I'll provide a patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 14:08:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 13:08:05 +0000 Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 --- Comment #66 from Victor Grousset/tuxayo --- Created attachment 72357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72357&action=edit Bug 19522: Label creator: Batches: make "Export Labels" translatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 14:15:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 13:15:18 +0000 Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 --- Comment #67 from Victor Grousset/tuxayo --- Thanks paxed, I noticed this string but though that I wasn't translatable due to the Grey Box lib. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 14:37:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 13:37:06 +0000 Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 --- Comment #8 from Nick Clemens --- I added it only for old reports, if a library has been using a report with duplicated inputs this will be a change in behavior and may be unexpected/unwanted. Am happy to reconsider or explore alternate options, this seemed the simplest at the time -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 14:44:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 13:44:13 +0000 Subject: [Koha-bugs] [Bug 19160] CAS Single Log Out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 14:44:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 13:44:16 +0000 Subject: [Koha-bugs] [Bug 19160] CAS Single Log Out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71831|0 |1 is obsolete| | Attachment #71832|0 |1 is obsolete| | Attachment #71833|0 |1 is obsolete| | Attachment #71834|0 |1 is obsolete| | Attachment #71835|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall --- Created attachment 72358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72358&action=edit Bug 19160: CAS Single logout CAS supports single logout, where if you logout of one application it logs you out of all of them. This bug implements this You will need a CAS server (with single logout configure), and at least 2 applications (one being Koha) 1/ In Koha login via CAS 2/ Login to the other application via CAS 3/ Logout of the other application 4/ Notice you are still logged into Koha 5/ Log out of Koha 6/ Apply patch 7/ Login to Koha via CAS, login to other app via CAS 8/ Log out of other app 9/ Notice you are logged out of Koha If you dont have CAS, this patch should be a no op, you could test that 1/ Login and logout normally 2/ Apply patch 3/ Login and logout still work fine Signed-off-by: Katrin Fischer Patch works as described, local login still works correctly. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 14:44:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 13:44:24 +0000 Subject: [Koha-bugs] [Bug 19160] CAS Single Log Out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #25 from Kyle M Hall --- Created attachment 72359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72359&action=edit Bug 19160: Move duplicated code to its own private subroutine Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 14:44:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 13:44:27 +0000 Subject: [Koha-bugs] [Bug 19160] CAS Single Log Out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #26 from Kyle M Hall --- Created attachment 72360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72360&action=edit Bug 19160: Move the code from controller to C4::Auth_with_cas Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 14:44:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 13:44:31 +0000 Subject: [Koha-bugs] [Bug 19160] CAS Single Log Out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #27 from Kyle M Hall --- Created attachment 72361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72361&action=edit Bug 19160: Isolate CAS code into its own module Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 14:44:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 13:44:34 +0000 Subject: [Koha-bugs] [Bug 19160] CAS Single Log Out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #28 from Kyle M Hall --- Created attachment 72362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72362&action=edit Bug 19160: (follow-up) Fix problems introduced by renaming logout_required to logout_if_required Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 14:44:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 13:44:38 +0000 Subject: [Koha-bugs] [Bug 19160] CAS Single Log Out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #29 from Kyle M Hall --- Created attachment 72363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72363&action=edit Bug 19160: Remove tab characters causing qa script to fail Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 14:44:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 13:44:41 +0000 Subject: [Koha-bugs] [Bug 19160] CAS Single Log Out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #30 from Kyle M Hall --- Created attachment 72364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72364&action=edit Bug 19160: Add POD Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 14:47:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 13:47:40 +0000 Subject: [Koha-bugs] [Bug 18345] Add a more ES based query builder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18345 --- Comment #3 from Nick Clemens --- Currently this is just a placeholder for some code that was lost at some point, we should pursue in the future, but i think other issues are ahead of this. Currently we use the built in ES query parser for most things, but in the future it would be nice to leverage some of the specific ES search endpoints directly for more refined searches. Some of that is done here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604 Where we need to use more specific searching to mimic what we do in zebra -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 14:49:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 13:49:21 +0000 Subject: [Koha-bugs] [Bug 19546] Can't locate Mojolicious/Plugin/Koha/REST/Plugin/Pagination.pm breaks opac and staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 14:49:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 13:49:27 +0000 Subject: [Koha-bugs] [Bug 19546] Can't locate Mojolicious/Plugin/Koha/REST/Plugin/Pagination.pm breaks opac and staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 --- Comment #15 from Tom?s Cohen Arazi --- Created attachment 72365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72365&action=edit Bug 19546: Run starman from the instance's home dir This patch makes koha-plack jump into the instance's home directory to run. It is required because Perl 5.18 introduced a breaking change that makes perl die if @INC includes directories for which the user doesn't have read permission, and need to be traversed when querying for a lib. This is the case of '.', which is introduced automatically into @INC until Perl 5.26 (which removes the 'feature'). The Mojolicious::Plugins lib prefixes the plugin names with 'Mojolicious::Plugin' so it first looks (for example) for Mojolicious::Plugin::Koha::REST::Plugin::Pagination (Pagination is just the first one on the list). When it looks for it at '.' it dies (because of Perl's behaviour) so it doesn't query for the right namespace (the following to try). I only reproduced it in koha-testing-docker. To test, you just need to try this patched koha-plack and make sure it doesn't break due to this permissions issue. To test: - In your koha-testing-docker clone, run: $ docker-compose up -p test - Open a shell inside the container (on a separate terminal): $ docker exec -it test_koha_1 bash - From within the /root directory, restart plack: $ cd /root $ koha-plack --restart kohadev => FAIL: Logs show plack is broken due to permissions problems trying to find Mojolicious::Plugin::Koha::REST::Plugin::Pagination - Use the patched script from this patch: $ /kohadevbox/koha/debian/scripts/koha-plack --restart kohadev => SUCCESS: Plack runs fine, no error in the logs - Sign off :-D Note: people who has environments in which the problems is reproducible, please test this version of koha-plack and stamp your sign-off, PLEASE. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 14:50:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 13:50:45 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 14:55:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 13:55:10 +0000 Subject: [Koha-bugs] [Bug 18345] Add a more ES based query builder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18345 --- Comment #4 from Julian Maurice --- So, it does not really block bug 14567 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 15:03:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 14:03:02 +0000 Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 --- Comment #9 from Julian Maurice --- (In reply to Nick Clemens from comment #8) > I added it only for old reports, if a library has been using a report with > duplicated inputs this will be a change in behavior and may be > unexpected/unwanted. > > Am happy to reconsider or explore alternate options, this seemed the > simplest at the time I hadn't thought about old reports. It makes sense... but what do you think about renaming all parameters (appending a number for instance) of existing reports in an updatedatabase script ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 15:35:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 14:35:39 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #51 from Tom?s Cohen Arazi --- (In reply to Jonathan Druart from comment #50) > Can anyone take care of this one? I'm taking care of it. I'm working on the same approach as bug 19546. Adding a --chdir option switch to koha-foreach. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 15:36:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 14:36:17 +0000 Subject: [Koha-bugs] [Bug 20245] Wrong language code for Slovak In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 --- Comment #2 from Petr Havel --- (In reply to Jonathan Druart from comment #1) > Hola Petr, Can you provide a patch please? > > https://wiki.koha-community.org/wiki/Submitting_A_Patch Sorry, I can't make patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 15:36:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 14:36:57 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #52 from Tom?s Cohen Arazi --- (In reply to Marcel de Rooy from comment #48) > (In reply to Marco Moreno from comment #47) > > Understanding the problem is necessary to determine the best solution. > [...] > > 5. Change the current directory to one that is readable by modifying all > > code that performs a "sudo -u". This may be as simple as adding "cd /tmp" > > at the beginning of /usr/sbin/koha-foreach and /usr/sbin/koha-rebuild-zebra. > > Possibly the best solution for now. > > > > Option #5 seems like the best one for now. It is a clear, one-line solution > > that doesn't require modifying any crons. > > I would agree. Put cd /tmp very close to the sudo -u. Adding it in cron is > more confusing. > Clear argumentation imo! If there's a /tmp/Koha directory, without read permissions for the instance's user it will still fail. I think we should jump into the instance's home directory and I'm providing a patch to do so. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 16:04:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 15:04:53 +0000 Subject: [Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 16:04:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 15:04:56 +0000 Subject: [Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70471|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 72366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72366&action=edit Bug 19191: Add ability to email receipts for account payments and write-offs Some libraries are paperless and require all payment receipts to be emailed. Koha should give libraries the option to send email receipts if a patron has an email address. If a notice for the type of "credit" exists ( payment or writeoff ), then an email receipt will be sent. These notices only support Template Toolkit syntax. Test Plan: 1) Apply this patch and dependencies 2) Add the two new notices, you can find them in installer/data/mysql/en/mandatory/sample_notices.sql 3) Note two new notices exist in the notices editor, ACCOUNT_PAYMENT and ACCOUNT_WRITEOFF 4) Find or create a patron with an email address that owes some amount of money 5) Make a payment for one or more fees 6) Note a new email is queued for the patron 7) Make a writeoff for one or more fees 8) Note a new new email is queued for the patron Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 16:05:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 15:05:04 +0000 Subject: [Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 --- Comment #13 from Kyle M Hall --- Created attachment 72367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72367&action=edit Bug 19191: Remove need for bug 19966 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 16:07:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 15:07:27 +0000 Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #10 from Nick Clemens --- That works for me, Jonathan or Katrin, any input? If it sounds good I will try to work on that or you can feel free Julian -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 16:10:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 15:10:27 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|18345 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18345 [Bug 18345] Add a more ES based query builder -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 16:10:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 15:10:27 +0000 Subject: [Koha-bugs] [Bug 18345] Add a more ES based query builder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18345 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14567 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 [Bug 14567] Browse interface for OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 16:11:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 15:11:10 +0000 Subject: [Koha-bugs] [Bug 18345] Add a more ES based query builder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18345 --- Comment #5 from Nick Clemens --- No, it shouldn't -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 16:20:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 15:20:24 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63677|0 |1 is obsolete| | --- Comment #53 from Tom?s Cohen Arazi --- Created attachment 72368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72368&action=edit Bug 17717: Add a --chdir option switch for koha-foreach Until Perl 5.26, the current directory is added to @INC when running a Perl script [1]. Having the current directory in @INC means it can be tried to be traversed when performing a lib lookup. Since version 5.18, Perl dies when it finds an unreadable directory (permissions) in @INC that needs to be traversed. This behaviour won't change because Perl devs consider it an enhancement to security. [2] Because of this, we need to make sure our scripts are ran **from** a directory in which they have read permissions. Ths patch adds a --chdir option switch to the **koha-foreach** wrapper script, that makes the inner shells/scripts to be ran within the Koha instance's user home directory. The change is trivial and should be QAed easily. I tested this on a prod server: - Create a /tmp/test.pl file containing: use Modern::Perl; use Cwd; my $dir = getcwd; warn $dir; 1; A) then create a cronjob entry to run it using koha-foreach: (in /etc/cron.d/test): 1/* * * * * root koha-foreach perl /tmp/test.pl - Once I noticed the cronjob ran, I used mutt to read the emails in the root user. => FAIL: ... Subject: Cron koha-foreach --enabled perl /tmp/test.pl "/root" "/root" "/root" "/root" "/root" ... B) I then used the patched koha-foreach with different results: => SUCCESS: ... Subject: Cron /root/koha-foreach --chdir --enabled perl /tmp/test.pl "/var/lib/koha/acaderc" "/var/lib/koha/agro" "/var/lib/koha/anc" "/var/lib/koha/arico" "/var/lib/koha/artes" ... So this patch's approach works. But... C) master's koha-foreach seems to work just the same... I think it is because of my previous attempt to fix this by using sudo in koha-shell. So I think environmental conditions affect the behaviour (which shell is configured for cron, sudo configuration, etc). ==== In conclusion, I think we should go ahead with this patch as it will solve peoples issues, and it is a right solution (option #5 on the list) to this Perl behaviour change. It doesn't cover other commands, but followup patches could do. I avoided /tmp as it is writable by any user... so it is an easy path for both exploiting by replacing some lib, and also because the existence of an unreadable dir that the interpreter could try to traverse (unreadable /tmp/Authen or /tmp/Koha will trigger the same error, and I assume people know what they are putting on the instance's dir, at least it will be easier to track). A followup patch takes care of making the cronjobs use --chdir when calling koha-foreach [1] https://lists.debian.org/debian-devel-announce/2016/08/msg00013.html [2] https://rt.perl.org/Public/Bug/Display.html?id=123795 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 16:20:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 15:20:31 +0000 Subject: [Koha-bugs] [Bug 20324] New: Fund Warnings do not occur when importing records from a staged file Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20324 Bug ID: 20324 Summary: Fund Warnings do not occur when importing records from a staged file Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When using the Warning feature on funds (whether that is a $ amount of percentage) in the Acquisition module - these warnings do not display a warning when importing records from a staged file. Koha does warn the user when using other avenues upon adding items to an order, just not with staged files. /addorderiso -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 16:20:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 15:20:33 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #54 from Tom?s Cohen Arazi --- Created attachment 72369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72369&action=edit Bug 17717: Make cronjobs using koha-foreach use --chdir In order to patch production sites we need to adjust the shipped cronjobs so they are called with the --chdir option switch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 16:21:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 15:21:03 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 16:22:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 15:22:05 +0000 Subject: [Koha-bugs] [Bug 17717] Fix broken cronjobs due to permissions of the current directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|process_message_queue.pl: |Fix broken cronjobs due to |Can't locate |permissions of the current |Authen/CAS/Client/Response/ |directory |Failure.pm | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 16:23:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 15:23:24 +0000 Subject: [Koha-bugs] [Bug 19546] Make koha-plack run Starman from the instance's directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can't locate |Make koha-plack run Starman |Mojolicious/Plugin/Koha/RES |from the instance's |T/Plugin/Pagination.pm |directory |breaks opac and staff | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 16:30:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 15:30:37 +0000 Subject: [Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72367|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 72370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72370&action=edit Bug 19191: Remove need for bug 19966 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 16:39:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 15:39:39 +0000 Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72357|0 |1 is obsolete| | --- Comment #68 from Victor Grousset/tuxayo --- Created attachment 72371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72371&action=edit Bug 19522: Label creator: Batches: make "Export Labels" translatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 16:50:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 15:50:10 +0000 Subject: [Koha-bugs] [Bug 17717] Fix broken cronjobs due to permissions of the current directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 16:50:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 15:50:15 +0000 Subject: [Koha-bugs] [Bug 17717] Fix broken cronjobs due to permissions of the current directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72368|0 |1 is obsolete| | Attachment #72369|0 |1 is obsolete| | --- Comment #55 from Kyle M Hall --- Created attachment 72372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72372&action=edit Bug 17717: Add a --chdir option switch for koha-foreach Until Perl 5.26, the current directory is added to @INC when running a Perl script [1]. Having the current directory in @INC means it can be tried to be traversed when performing a lib lookup. Since version 5.18, Perl dies when it finds an unreadable directory (permissions) in @INC that needs to be traversed. This behaviour won't change because Perl devs consider it an enhancement to security. [2] Because of this, we need to make sure our scripts are ran **from** a directory in which they have read permissions. Ths patch adds a --chdir option switch to the **koha-foreach** wrapper script, that makes the inner shells/scripts to be ran within the Koha instance's user home directory. The change is trivial and should be QAed easily. I tested this on a prod server: - Create a /tmp/test.pl file containing: use Modern::Perl; use Cwd; my $dir = getcwd; warn $dir; 1; A) then create a cronjob entry to run it using koha-foreach: (in /etc/cron.d/test): 1/* * * * * root koha-foreach perl /tmp/test.pl - Once I noticed the cronjob ran, I used mutt to read the emails in the root user. => FAIL: ... Subject: Cron koha-foreach --enabled perl /tmp/test.pl "/root" "/root" "/root" "/root" "/root" ... B) I then used the patched koha-foreach with different results: => SUCCESS: ... Subject: Cron /root/koha-foreach --chdir --enabled perl /tmp/test.pl "/var/lib/koha/acaderc" "/var/lib/koha/agro" "/var/lib/koha/anc" "/var/lib/koha/arico" "/var/lib/koha/artes" ... So this patch's approach works. But... C) master's koha-foreach seems to work just the same... I think it is because of my previous attempt to fix this by using sudo in koha-shell. So I think environmental conditions affect the behaviour (which shell is configured for cron, sudo configuration, etc). ==== In conclusion, I think we should go ahead with this patch as it will solve peoples issues, and it is a right solution (option #5 on the list) to this Perl behaviour change. It doesn't cover other commands, but followup patches could do. I avoided /tmp as it is writable by any user... so it is an easy path for both exploiting by replacing some lib, and also because the existence of an unreadable dir that the interpreter could try to traverse (unreadable /tmp/Authen or /tmp/Koha will trigger the same error, and I assume people know what they are putting on the instance's dir, at least it will be easier to track). A followup patch takes care of making the cronjobs use --chdir when calling koha-foreach [1] https://lists.debian.org/debian-devel-announce/2016/08/msg00013.html [2] https://rt.perl.org/Public/Bug/Display.html?id=123795 Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 16:50:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 15:50:24 +0000 Subject: [Koha-bugs] [Bug 17717] Fix broken cronjobs due to permissions of the current directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #56 from Kyle M Hall --- Created attachment 72373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72373&action=edit Bug 17717: Make cronjobs using koha-foreach use --chdir In order to patch production sites we need to adjust the shipped cronjobs so they are called with the --chdir option switch. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 16:53:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 15:53:01 +0000 Subject: [Koha-bugs] [Bug 19546] Make koha-plack run Starman from the instance's directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 16:53:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 15:53:04 +0000 Subject: [Koha-bugs] [Bug 19546] Make koha-plack run Starman from the instance's directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72365|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall --- Created attachment 72374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72374&action=edit Bug 19546: Run starman from the instance's home dir This patch makes koha-plack jump into the instance's home directory to run. It is required because Perl 5.18 introduced a breaking change that makes perl die if @INC includes directories for which the user doesn't have read permission, and need to be traversed when querying for a lib. This is the case of '.', which is introduced automatically into @INC until Perl 5.26 (which removes the 'feature'). The Mojolicious::Plugins lib prefixes the plugin names with 'Mojolicious::Plugin' so it first looks (for example) for Mojolicious::Plugin::Koha::REST::Plugin::Pagination (Pagination is just the first one on the list). When it looks for it at '.' it dies (because of Perl's behaviour) so it doesn't query for the right namespace (the following to try). I only reproduced it in koha-testing-docker. To test, you just need to try this patched koha-plack and make sure it doesn't break due to this permissions issue. To test: - In your koha-testing-docker clone, run: $ docker-compose up -p test - Open a shell inside the container (on a separate terminal): $ docker exec -it test_koha_1 bash - From within the /root directory, restart plack: $ cd /root $ koha-plack --restart kohadev => FAIL: Logs show plack is broken due to permissions problems trying to find Mojolicious::Plugin::Koha::REST::Plugin::Pagination - Use the patched script from this patch: $ /kohadevbox/koha/debian/scripts/koha-plack --restart kohadev => SUCCESS: Plack runs fine, no error in the logs - Sign off :-D Note: people who has environments in which the problems is reproducible, please test this version of koha-plack and stamp your sign-off, PLEASE. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 16:54:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 15:54:59 +0000 Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72371|0 |1 is obsolete| | --- Comment #69 from Owen Leonard --- Created attachment 72375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72375&action=edit Bug 19522: Label creator: Batches: make "Export Labels" translatable Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 17:01:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 16:01:18 +0000 Subject: [Koha-bugs] [Bug 17717] Fix broken cronjobs due to permissions of the current directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #57 from Marco Moreno --- Hmmm...I'm now reconsidering this and wonder if option #3 is really the best solution by removing '.' from @INC. You made a good point about /tmp being a concern. This, plus the fact that they have removed '.' from @INC in recent versions of Perl, has convinced me that having '.' in @INC is generally a very bad idea and a major security concern. Therefore, I want to propose revisiting comment #40 which removes '.' from @INC in a common library early in the bootstrapping process. This effectively undoes the "feature" added in Perl 5.18 and removed in Perl 5.26. Additionally, this prevents exploits that attempt to insert '.' via PERL5LIB. It is a single line of code, does nothing if '.' doesn't exist in @INC, and doesn't require modifying crons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 17:13:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 16:13:18 +0000 Subject: [Koha-bugs] [Bug 17717] Fix broken cronjobs due to permissions of the current directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #58 from Tom?s Cohen Arazi --- (In reply to Marco Moreno from comment #57) > Hmmm...I'm now reconsidering this and wonder if option #3 is really the best > solution by removing '.' from @INC. > > You made a good point about /tmp being a concern. This, plus the fact that > they have removed '.' from @INC in recent versions of Perl, has convinced me > that having '.' in @INC is generally a very bad idea and a major security > concern. > > Therefore, I want to propose revisiting comment #40 which removes '.' from > @INC in a common library early in the bootstrapping process. This > effectively undoes the "feature" added in Perl 5.18 and removed in Perl > 5.26. Additionally, this prevents exploits that attempt to insert '.' via > PERL5LIB. I considered that option. But we would need to do it on every script, and we would also be changing the current behaviour. Someone might be using their own lib (or version of some lib) on purpose and we'd be breaking them. So, for the general user base, we should stick with the cleaner solution IMHO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 17:18:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 16:18:24 +0000 Subject: [Koha-bugs] [Bug 19620] Allow skipping of patrons with valid emails for Talking Tech In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19620 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 17:18:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 16:18:27 +0000 Subject: [Koha-bugs] [Bug 19620] Allow skipping of patrons with valid emails for Talking Tech In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19620 --- Comment #2 from Kyle M Hall --- Created attachment 72376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72376&action=edit Bug 19620: Allow skipping of patrons with valid emails for Talking Tech Some libraries want to be able to skip patrons with valid email addresses when generated outbound files for Talking Tech. Test Plan: 1) Apply this patch 2) Run TalkingTech_itiva_outbound.pl Overdue will be easiest to use for testing 3) Note one or more patrons show up that have email addresses 4) Run again with -s ( or --skip-patrons-with-email ) 5) Note the new file no longer has patrons with emails! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 17:18:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 16:18:43 +0000 Subject: [Koha-bugs] [Bug 19620] Allow skipping of patrons with valid emails for Talking Tech In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19620 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jesse at bywatersolutions.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 17:19:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 16:19:42 +0000 Subject: [Koha-bugs] [Bug 19620] Allow skipping of patrons with valid emails for Talking Tech In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19620 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72376|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 72377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72377&action=edit Bug 19620: Allow skipping of patrons with valid emails for Talking Tech Some libraries want to be able to skip patrons with valid email addresses when generated outbound files for Talking Tech. Test Plan: 1) Apply this patch 2) Run TalkingTech_itiva_outbound.pl Overdue will be easiest to use for testing 3) Note one or more patrons show up that have email addresses 4) Run again with -s ( or --skip-patrons-with-email ) 5) Note the new file no longer has patrons with emails! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 17:27:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 16:27:20 +0000 Subject: [Koha-bugs] [Bug 17717] Fix broken cronjobs due to permissions of the current directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #59 from Marco Moreno --- Couldn't it be done in once in a common library that is used everywhere, like /usr/share/koha/bin/kohalib.pl? Sorry, I really don't know much about Koha's architecture and I trust you've studied this more than I have. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 18:31:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 17:31:34 +0000 Subject: [Koha-bugs] [Bug 20324] Fund Warnings do not occur when importing records from a staged file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20324 Viccy Kemp changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victoria.kemp at flower-mound. | |com --- Comment #1 from Viccy Kemp --- This would seem to be a problem that would cause issues on many different levels. Anyone working on it? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 18:45:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 17:45:59 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71118|0 |1 is obsolete| | Attachment #71119|0 |1 is obsolete| | Attachment #71120|0 |1 is obsolete| | Attachment #71121|0 |1 is obsolete| | Attachment #71122|0 |1 is obsolete| | Attachment #71123|0 |1 is obsolete| | --- Comment #33 from Kyle M Hall --- Created attachment 72378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72378&action=edit Bug 4078: DBIC Schema changes Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 18:46:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 17:46:08 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #34 from Kyle M Hall --- Created attachment 72379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72379&action=edit Bug 4078: Update DB entry - add new column currency.p_sep_by_space Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 18:46:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 17:46:11 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #35 from Kyle M Hall --- Created attachment 72380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72380&action=edit Bug 4078: Add the checkbox to the UI Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 18:46:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 17:46:16 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #36 from Kyle M Hall --- Created attachment 72381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72381&action=edit Bug 4078: Pass with_symbol to module The template plugin did not pass the with_symbol flag to the module and so was not taken into account Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 18:45:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 17:45:56 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 18:46:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 17:46:19 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #37 from Kyle M Hall --- Created attachment 72382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72382&action=edit Bug 4078: Add the ability to display and configure the symbol for prices The symbol of currencies are not displayed (or not correctly) so far. This patch set adds the ability to configure the display of the symbol (with or without a whitespace between the symbol and the price). Test plan: 1. Execute the update DB entry, go to the currency admin page and tick the new "Space separation between symbol and value" checkbox 2. Add a fine to a patron and use their credentials to login at the OPAC 3. You should see the "$ 42 due fines and charges" info in the dashboard 4. Untick the new checkbox to remove the space and reload the OPAC main page. => The space should not be longer displayed ($42) Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 18:46:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 17:46:23 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #38 from Kyle M Hall --- Created attachment 72383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72383&action=edit Bug 4078: Add a new test Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 18:50:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 17:50:01 +0000 Subject: [Koha-bugs] [Bug 20324] Fund Warnings do not occur when importing records from a staged file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20324 Sandre Cunha changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cunha at monterey.org --- Comment #2 from Sandre Cunha --- This is a serious issue for Acquisitions, as one can easily go over budget quickly with out being aware of it. It makes no sense that the warning is not triggered when you save a group of orders as well as an individual item. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 19:12:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 18:12:26 +0000 Subject: [Koha-bugs] [Bug 20325] New: C4::Accounts::purge_zero_balance_fees does not check account_offsets. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325 Bug ID: 20325 Summary: C4::Accounts::purge_zero_balance_fees does not check account_offsets. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org purge_zero_balance_fees is used in cleanup_database.pl to determine which fees can be cleaned up. It uses a simple SQL query to determine which rows in accountlines need to be removed: 463 my $sth = $dbh->prepare( 464 q{ 465 DELETE FROM accountlines 466 WHERE date < date_sub(curdate(), INTERVAL ? DAY) 467 AND ( amountoutstanding = 0 or amountoutstanding IS NULL ); 468 } The function comes with the following warning: 451 B Because fines and payments are not linked in accountlines, it is 452 possible for a fine to be deleted without the accompanying payment, 453 or vise versa. This won't affect the account balance, but might be 454 confusing to staff. This was a reasonable solution prior to the addition of account_offsets in 17.11. The problem now is that rows in accountlines which are linked as credits in accountlines will *always* have amountoutstanding marked as 0. These are linked to debits via account_offsets. purge_zero_balance_fees will delete credits and leave rows in account_offsets which link to deleted credits. Sites using the --fees option cleanup_database.pl which upgrade to 17.11 may have all of their credits removed without warning. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 19:23:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 18:23:42 +0000 Subject: [Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does not check account_offsets. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325 --- Comment #1 from Barton Chittenden --- Here's data from a production system that I think would be adversely affected if cleanup_database.pl --fees 1 was run Query: SELECT a.*, credit.amount AS 'credit amount', credit.amountoutstanding 'credit outstanding', credit.description 'credit description', credit.accounttype AS 'credit type', debit.amount AS 'debit amount', debit.amountoutstanding 'debit outstanding', debit.description 'debit description', debit.accounttype AS 'debit type' FROM account_offsets a INNER JOIN accountlines credit on a.credit_id = credit.accountlines_id INNER JOIN accountlines debit on a.debit_id = debit.accountlines_id WHERE credit.amountoutstanding = 0 and debit.amountoutstanding > 0 ORDER BY a.id desc limit 1 *************************** 1. row *************************** id: 4214002 credit_id: 1708799 debit_id: 1708796 type: Payment amount: 0.000000 created_on: 2018-03-02 11:51:05 credit amount: -5.000000 credit outstanding: 0.000000 credit description: credit type: Pay debit amount: 0.500000 debit outstanding: 0.500000 debit description: I survived the eruption of Mount St. Helens, 1980 / 02/28/2018 23:59 debit type: F In this case, credit outstanding, i.e. accountlines.amountoutstanding where accountlines_id = 1708799 is 0, so that row would be deleted by purge_zero_balance_fees, even though it's still linked to by account_offsets, and debit outstanding is not 0. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 19:26:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 18:26:28 +0000 Subject: [Koha-bugs] [Bug 20167] Item hold is set to bibliographic hold when changing pickup location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20167 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 19:31:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 18:31:50 +0000 Subject: [Koha-bugs] [Bug 17717] Fix broken cronjobs due to permissions of the current directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #60 from Tom?s Cohen Arazi --- (In reply to Marco Moreno from comment #59) > Couldn't it be done in once in a common library that is used everywhere, > like /usr/share/koha/bin/kohalib.pl? > > Sorry, I really don't know much about Koha's architecture and I trust you've > studied this more than I have. I understand the kohalib.pl approach, but I think it is too hacky and I don't think we should use it at all. So a solution there I wouldn't agree. Also, not all CLI scripts written in perl use it... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 19:48:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 18:48:02 +0000 Subject: [Koha-bugs] [Bug 17717] Fix broken cronjobs due to permissions of the current directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #61 from Marco Moreno --- Fair enough - trust your judgment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 21:05:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 20:05:42 +0000 Subject: [Koha-bugs] [Bug 16976] Authorities searches with double quotes gives ZOOM error 20003 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- CC| |marjorie.barry-vila at collect | |o.ca Status|RESOLVED |REOPENED --- Comment #25 from Marjorie Barry-Vila --- Hi, In 17.05, i have same error message on koha/tools/manage-marc-import.pl Software error: ZOOM error 20003 "can't set prefix query" (addinfo: "@or @attr 7=1 @attr 4=109 @attr 1=Local-Number 0 @attr 1=Any @attr 4=1 @attr 5=100 @attr 6=3 "F298826" @attr 1=Any @attr 4=1 @attr 5=100 @attr 6=3 "(SQTD)191897"") from diag-set 'ZOOM' I understand that patch is just for search on authorities/authorities-home.pl ? Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 21:20:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 20:20:00 +0000 Subject: [Koha-bugs] [Bug 20097] marc2dcxml croaks on format dc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 Maksim Sen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maksim.sen at inlibro.com --- Comment #2 from Maksim Sen --- Hey Marcel, When I tried to get to the links you put out, I got to an Error 404 in Koha (after changing the server and bibnumbers of course), with and without the patch. I accessed the links directly, do I need to access your through another page? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 21:22:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 20:22:54 +0000 Subject: [Koha-bugs] [Bug 20305] Warnings in tools scripts need to be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20305 Roch D'Amour changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roch.damour at inlibro.com --- Comment #2 from Roch D'Amour --- Hi Jonathan Do you have a test plan for this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 21:39:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 20:39:10 +0000 Subject: [Koha-bugs] [Bug 20323] Batch patron modification tool broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20323 Roch D'Amour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72347|0 |1 is obsolete| | --- Comment #2 from Roch D'Amour --- Created attachment 72384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72384&action=edit Bug 20323: Fix batch patron modification tool Test plan: 1) Go to Tools -> Batch patrons modification 2) Select some patrons and try to change any field --> without patch - it exploads with log: Can't call method "category" on unblessed reference at /home/vagrant/kohaclone/tools/modborrowers.pl --> with patch - the modification is properly made Signed-off-by: Roch D'Amour -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 21:39:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 20:39:08 +0000 Subject: [Koha-bugs] [Bug 20323] Batch patron modification tool broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20323 Roch D'Amour changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 21:39:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 20:39:54 +0000 Subject: [Koha-bugs] [Bug 20323] Batch patron modification tool broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20323 Roch D'Amour changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roch.damour at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 21:46:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 20:46:43 +0000 Subject: [Koha-bugs] [Bug 20321] C4:XISBN->get_biblionumber_from_isbn is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20321 Roch D'Amour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72340|0 |1 is obsolete| | --- Comment #2 from Roch D'Amour --- Created attachment 72385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72385&action=edit Bug 20321 - Remove get_biblionumber_from_isbn To test: 1 - grep get_biblionumber_from_isbn 2 - verify all occurences are not actual calls (except for test) 3 - Apply patch 4 - grep get_biblionumber_from_isbn 5 - Verify it is removed Signed-off-by: Roch D'Amour -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 21:48:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 20:48:02 +0000 Subject: [Koha-bugs] [Bug 20321] C4:XISBN->get_biblionumber_from_isbn is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20321 Roch D'Amour changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |roch.damour at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 22:15:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 21:15:13 +0000 Subject: [Koha-bugs] [Bug 20052] Add Reports object class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20052 Maksim Sen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70845|0 |1 is obsolete| | --- Comment #3 from Maksim Sen --- Created attachment 72386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72386&action=edit Bug 20052 - Add Koha Reports object class To test: prove -v t/db_dependent/Koha/Reports.t Signed-off-by: Claire Gravely Signed-off-by: Maksim Sen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 22:22:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 21:22:32 +0000 Subject: [Koha-bugs] [Bug 20265] Add syspref to hide news published date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20265 Roch D'Amour changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roch.damour at inlibro.com --- Comment #3 from Roch D'Amour --- You patch's author field says "Your full Name ". You might want to check your git config and make sure it is configured properly :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 22:24:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 21:24:14 +0000 Subject: [Koha-bugs] [Bug 20265] Add syspref to hide news published date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20265 Roch D'Amour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72194|0 |1 is obsolete| | --- Comment #4 from Roch D'Amour --- Created attachment 72387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72387&action=edit This patch adds a system preference that allows a user to toggle the published date for OPAC news items on or off. Test plan: 1. Login to the staff client, navigate to Tools ? News and create some news articles that have their display location set to ?All?. 2. Navigate to the OPAC and notice that the news items you added have a line at the bottom reading ?(published on mm/dd/yyyy)?. 3. Apply the patch. 4. Enter the instance user session - $ sudo koha-shell kohadev 5. Change into your git directory - $ cd kohaclone 6. Update the database - $ perl installer/data/mysql/updatedatabase.pl 7. Exit the instance user session and restart Apache, Memcached and Plack - $ restart_all 8. Open the staff client and navigate to Koha administration? Global system preferences, click the ?OPAC? tab on the left and notice a new option ?OPACNoNewsDate? under the ?Features? heading. 9. Select ?Don?t show?, save and notice that the published date of news items on the OPAC is now suppressed. 10. Select ?Show? and notice that the published date of news items on the OPAC is visible once more. Signed-off-by: Roch D'Amour -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 22:24:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 21:24:11 +0000 Subject: [Koha-bugs] [Bug 20265] Add syspref to hide news published date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20265 Roch D'Amour changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 22:39:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 21:39:19 +0000 Subject: [Koha-bugs] [Bug 20219] t/smolder_smoke_signal is no longer used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20219 Roch D'Amour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71692|0 |1 is obsolete| | --- Comment #2 from Roch D'Amour --- Created attachment 72388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72388&action=edit Bug 20219: Remove t/smolder_smoke_signal The file is no longer used (is it?) and the project looks dead. Let remove that file. Signed-off-by: Roch D'Amour -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 22:39:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 21:39:40 +0000 Subject: [Koha-bugs] [Bug 20219] t/smolder_smoke_signal is no longer used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20219 Roch D'Amour changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |roch.damour at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 22:41:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 21:41:08 +0000 Subject: [Koha-bugs] [Bug 20267] Add basic .gitignore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267 --- Comment #5 from Maksim Sen --- Created attachment 72389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72389&action=edit Hi Maksim, here's a possible test plan: 1. Run `perl Makefile.PL` followed by `make` to generate the files MYMETA.json, MYMETA.yml, Makefile, pm_to_blib and directory blib/ 2. See that those files appear in the output of `git status` 3. Apply patch 4. Run `git status` again and see that they are no longer displayed. Signed-off-by: Maksim Sen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 22:42:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 21:42:12 +0000 Subject: [Koha-bugs] [Bug 20267] Add basic .gitignore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267 Maksim Sen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72389|0 |1 is obsolete| | Attachment #72389|1 |0 is patch| | --- Comment #6 from Maksim Sen --- Comment on attachment 72389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72389 Hi Maksim, >From 2b8905cb588a594d54843ec5ffeef578d92c8d3c Mon Sep 17 00:00:00 2001 >From: Julian Maurice >Date: Thu, 22 Feb 2018 10:51:27 +0100 >Subject: [PATCH] Bug 20267: Add basic .gitignore > >Ignore files generated by ExtUtils::MakeMaker > >NOTE: Limited scope does not affect files created > by translation utilities > >Signed-off-by: Mark Tompsett >Signed-off-by: Maksim Sen >--- > .gitignore | 4 ++++ > 1 file changed, 4 insertions(+) > create mode 100644 .gitignore > >diff --git a/.gitignore b/.gitignore >new file mode 100644 >index 0000000..7befa23 >--- /dev/null >+++ b/.gitignore >@@ -0,0 +1,4 @@ >+/MYMETA.* >+/blib/ >+/Makefile >+/pm_to_blib >-- >2.7.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 2 22:44:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Mar 2018 21:44:11 +0000 Subject: [Koha-bugs] [Bug 20267] Add basic .gitignore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267 --- Comment #7 from Maksim Sen --- Ignore comment 6, I accidentally submitted a patch when I tried to sign off your patch. Sorry about that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 3 13:59:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Mar 2018 12:59:01 +0000 Subject: [Koha-bugs] [Bug 20326] New: ngentod Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20326 Bug ID: 20326 Summary: ngentod Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: kazutekato at yahoo.com QA Contact: testopia at bugs.koha-community.org Created attachment 72390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72390&action=edit asdas Bugs or issues with bugzilla itself -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 3 13:59:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Mar 2018 12:59:55 +0000 Subject: [Koha-bugs] [Bug 20326] ngentod In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20326 --- Comment #1 from anyms12 --- Comment on attachment 72390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72390 asdas Knock Knock!?


    Hacked By ./Mr-Cr#00tz
    #Tauco Exploiter Crew#
    we in your system now
    we just help for find the bug ini your system

    Hello Admin, im a [!]CR00TZSECURITY[!]
    im here just for test your website
    i think your security is low,
    please up your system or i will come again!
    but. remember, "NO SYSTEM IS SAFE"
    it was like your website too

    Contact: kazutekato at yahoo.com


    ./Mr.Hichiko | ./NightBot_404 | ./Mr-Cr#00tz | Mrskreepkiller | 4rza3ck | SN4KE-404 | DIEM-01 | Mr.N4sh | Mr.clc4k | ./Mr.G | Bl4ckr053 | Mr.KingAssasins44x1 | MR.200[OK] | K4.Cr44zy | MR.BlackKnight404 | D4RK_CYB3R -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 3 14:00:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Mar 2018 13:00:20 +0000 Subject: [Koha-bugs] [Bug 20326] ngentod In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20326 --- Comment #2 from anyms12 --- Comment on attachment 72390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72390 asdas Knock Knock!?



    Hacked By ./Mr-Cr#00tz
    #Tauco Exploiter Crew#
    we in your system now
    we just help for find the bug ini your system

    Hello Admin, im a [!]CR00TZSECURITY[!]
    im here just for test your website
    i think your security is low,
    please up your system or i will come again!
    but. remember, "NO SYSTEM IS SAFE"
    it was like your website too

    Contact: kazutekato at yahoo.com


    ./Mr.Hichiko | ./NightBot_404 | ./Mr-Cr#00tz | Mrskreepkiller | 4rza3ck | SN4KE-404 | DIEM-01 | Mr.N4sh | Mr.clc4k | ./Mr.G | Bl4ckr053 | Mr.KingAssasins44x1 | MR.200[OK] | K4.Cr44zy | MR.BlackKnight404 | D4RK_CYB3R -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 3 14:01:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Mar 2018 13:01:56 +0000 Subject: [Koha-bugs] [Bug 20327] New: Koha's staff and patron authentication system Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20327 Bug ID: 20327 Summary: Koha's staff and patron authentication system Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: kazutekato at yahoo.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Created attachment 72391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72391&action=edit ngentod ea kimak :D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 3 14:02:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Mar 2018 13:02:20 +0000 Subject: [Koha-bugs] [Bug 20327] Koha's staff and patron authentication system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20327 --- Comment #1 from anyms12 --- Created attachment 72392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72392&action=edit Koha's staff and patron authentication system -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 3 17:17:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Mar 2018 16:17:19 +0000 Subject: [Koha-bugs] [Bug 19546] Make koha-plack run Starman from the instance's directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | --- Comment #17 from Marcel de Rooy --- Great. Solution sounds plausible. Will test and QA. Just wondering why perl would build @INC different sometimes (recall that the problem was not completely constant). Glad that I am not the author of this reverted perl feature ;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 3 18:58:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Mar 2018 17:58:18 +0000 Subject: [Koha-bugs] [Bug 20111] Patron card creator - some strings are not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #5 from Victor Grousset/tuxayo --- (In reply to Jonathan Druart from comment #4) > (please apply the fix to both .tt) There is one .tt in this bug. Did you mean bug 19522? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 4 04:38:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Mar 2018 03:38:37 +0000 Subject: [Koha-bugs] [Bug 20328] New: White margin at the top of the home page of the staff client Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20328 Bug ID: 20328 Summary: White margin at the top of the home page of the staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: alexbuckley at catalyst.net.nz Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com There is a 13px high white margin at the top of the home page of the Koha staff client. After doing a git bisect I found that this bug was introduced in the patch for bug 19981 with the following addition to staff-global.css: .main { margin-top: 1em; } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 4 04:49:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Mar 2018 03:49:08 +0000 Subject: [Koha-bugs] [Bug 20328] White margin at the top of the home page of the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20328 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 4 04:49:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Mar 2018 03:49:10 +0000 Subject: [Koha-bugs] [Bug 20328] White margin at the top of the home page of the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20328 --- Comment #1 from Alex Buckley --- Created attachment 72393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72393&action=edit Bug 20328 - Removed the white margin at the top of the homepage of the Koha staff client I identified the source of this bug from using a git bisect and have removed the addition of the margin from the staff-global.css Test plan: 1. Go to the home page of the staff client and notice that there is a white margin (line) at the top of the page 2. Apply patch 3. Refresh the page and notice that the white margin is no longer displayed Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 4 06:34:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Mar 2018 05:34:10 +0000 Subject: [Koha-bugs] [Bug 20329] New: Text input fields are wider than the fieldset class they are inside of Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 Bug ID: 20329 Summary: Text input fields are wider than the fieldset class they are inside of Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: alexbuckley at catalyst.net.nz Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The input text fields in the following pages of the Koha staff client are wider than the fieldset class elements they are contained within: acqui/invoices.tt members/member.tt circ/overdue.tt acqui/parcel.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 4 10:06:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Mar 2018 09:06:29 +0000 Subject: [Koha-bugs] [Bug 20329] Text input fields are wider than the fieldset class they are inside of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 --- Comment #1 from Alex Buckley --- Created attachment 72394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72394&action=edit Bug 20329 - Shortened the width of text input fields This makes the text input fields fit tidily within the border of the fieldset class elements they are within. Test plan: 1. Go to the acqui/invoices.pl, members/members-home.pl, circ/overdue.pl, acqui/parcel.pl and notice that the text input fields on the fieldset element on the left hand side of the screen for filtering search results are too wide and go over the border of the fieldset element 2. Apply patch 3. Refresh the aforementioned pages and notice the text inputs have a shortened width and now fit within the fielset class element Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 4 10:07:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Mar 2018 09:07:20 +0000 Subject: [Koha-bugs] [Bug 20329] Text input fields are wider than the fieldset class they are inside of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72394|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 4 10:08:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Mar 2018 09:08:26 +0000 Subject: [Koha-bugs] [Bug 20329] Text input fields are wider than the fieldset class they are inside of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 4 10:08:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Mar 2018 09:08:29 +0000 Subject: [Koha-bugs] [Bug 20329] Text input fields are wider than the fieldset class they are inside of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 --- Comment #2 from Alex Buckley --- Created attachment 72395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72395&action=edit Bug 20329 - Shortened the width of text input fields This makes the text input fields fit tidily within the border of the fieldset class elements they are within. Test plan: 1. Go to the acqui/invoices.pl, members/members-home.pl, circ/overdue.pl, acqui/parcel.pl and notice that the text input fields on the fieldset element on the left hand side of the screen for filtering search results are too wide and go over the border of the fieldset element 2. Apply patch 3. Refresh the aforementioned pages and notice the text inputs have a shortened width and now fit within the fielset class element Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 4 11:33:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Mar 2018 10:33:55 +0000 Subject: [Koha-bugs] [Bug 20320] Add a "Library CSS" parameter in the Library Admin page to allow site specific customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20320 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Nick, why a URL and not an input field? (or maybe have both?) The need of putting files on the server often adds some more difficulty to use such features. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 4 12:32:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Mar 2018 11:32:46 +0000 Subject: [Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does not check account_offsets. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |critical CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Not enh as Barton indicates possible unexpected data loss. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 4 12:33:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Mar 2018 11:33:42 +0000 Subject: [Koha-bugs] [Bug 20326] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20326 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ngentod |SPAM Status|NEW |RESOLVED Resolution|--- |INVALID CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 4 12:33:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Mar 2018 11:33:59 +0000 Subject: [Koha-bugs] [Bug 20326] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20326 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72390|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 4 12:35:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Mar 2018 11:35:12 +0000 Subject: [Koha-bugs] [Bug 20327] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20327 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Summary|Koha's staff and patron |SPAM |authentication system | CC| |katrin.fischer at bsz-bw.de Resolution|--- |INVALID --- Comment #2 from Katrin Fischer --- Nice try. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 4 12:35:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Mar 2018 11:35:41 +0000 Subject: [Koha-bugs] [Bug 20327] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20327 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72392|0 |1 is patch| | Attachment #72392|text/html |text/plain mime type| | Attachment #72392|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 4 13:18:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Mar 2018 12:18:25 +0000 Subject: [Koha-bugs] [Bug 19160] CAS Single Log Out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #31 from Katrin Fischer --- Sorry for missing the last 2 and thx for fixing them! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 4 21:54:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Mar 2018 20:54:20 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 01:01:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 00:01:36 +0000 Subject: [Koha-bugs] [Bug 20265] Add syspref to hide news published date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20265 --- Comment #5 from Dilan Johnpull? --- (In reply to Roch D'Amour from comment #3) > You patch's author field says "Your full Name ". You might want > to check your git config and make sure it is configured properly :) Oops cheers for the pickup Roch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 02:07:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 01:07:55 +0000 Subject: [Koha-bugs] [Bug 20264] Syspref checkdigit is no longer in used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20264 Dilan Johnpull? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 02:07:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 01:07:59 +0000 Subject: [Koha-bugs] [Bug 20264] Syspref checkdigit is no longer in used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20264 Dilan Johnpull? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72289|0 |1 is obsolete| | --- Comment #7 from Dilan Johnpull? --- Created attachment 72396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72396&action=edit Bug 20264: Remove syspref checkdigit According to http://irc.koha-community.org/koha/2013-06-26#i_1333289 http://irc.koha-community.org/koha/2013-06-26#i_1333589 and Hea data, this syspref is no longer in used and is always set to false. Signed-off-by: Dilan Johnpull? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 02:12:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 01:12:03 +0000 Subject: [Koha-bugs] [Bug 20264] Syspref checkdigit is no longer in used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20264 --- Comment #8 from Dilan Johnpull? --- (In reply to Dilan Johnpull? from comment #7) > Created attachment 72396 [details] [review] > Bug 20264: Remove syspref checkdigit > > According to > http://irc.koha-community.org/koha/2013-06-26#i_1333289 > http://irc.koha-community.org/koha/2013-06-26#i_1333589 > and Hea data, this syspref is no longer in used and is always set to > false. > Patch applies now and works as expected. > Signed-off-by: Dilan Johnpull? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 02:27:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 01:27:59 +0000 Subject: [Koha-bugs] [Bug 20328] White margin at the top of the home page of the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20328 Dilan Johnpull? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 02:28:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 01:28:03 +0000 Subject: [Koha-bugs] [Bug 20328] White margin at the top of the home page of the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20328 Dilan Johnpull? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72393|0 |1 is obsolete| | --- Comment #2 from Dilan Johnpull? --- Created attachment 72397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72397&action=edit Bug 20328 - Removed the white margin at the top of the homepage of the Koha staff client I identified the source of this bug from using a git bisect and have removed the addition of the margin from the staff-global.css Test plan: 1. Go to the home page of the staff client and notice that there is a white margin (line) at the top of the page 2. Apply patch 3. Refresh the page and notice that the white margin is no longer displayed Sponsored-By: Catalyst IT Patch applies and functions as expected. Signed-off-by: Dilan Johnpull? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 03:41:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 02:41:01 +0000 Subject: [Koha-bugs] [Bug 20115] Languages appear in a different order in the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 --- Comment #10 from Dilan Johnpull? --- Hi Jonathan I've tested the patch again and the OPAC appears to still be displaying language options completely randomly. I have attempted restarting plack and emptying my cache to no avail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 08:00:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 07:00:54 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 08:00:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 07:00:58 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71375|0 |1 is obsolete| | Attachment #71376|0 |1 is obsolete| | Attachment #71377|0 |1 is obsolete| | Attachment #71378|0 |1 is obsolete| | Attachment #71379|0 |1 is obsolete| | Attachment #71380|0 |1 is obsolete| | Attachment #71381|0 |1 is obsolete| | --- Comment #48 from Josef Moravec --- Created attachment 72398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72398&action=edit Bug 14769: Introduce Koha::Authority::ControlledIndicators This module reads its settings from pref AuthorityControlledIndicators. The get method allows you to retrieve indicator values for specific biblio fields. Test plan: Run t/Koha/Authority/ControlledIndicators.t Signed-off-by: Marcel de Rooy Signed-off-by: Julian Maurice Signed-off-by: Marcel de Rooy Amended: Added a test to show that "ind1:" returns empty string. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 08:01:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 07:01:03 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #49 from Josef Moravec --- Created attachment 72399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72399&action=edit Bug 14769: Biblio indicators based on authority's thesaurus code Original patch from Janusz Kaczmarek on November 24, 2017. Amended by Marcel de Rooy on February 6, 2018. Code moved from AuthoritiesMarc.pm to ControlledIndicators.pm. Special attention has been paid to the proper application of 008/11 while controlling 6XX in MARC 21, specially if 008/11 =~ /[rsz]/ (and if it is 'z' and 040 $f is defined). Test plan: See next patch. Signed-off-by: Marcel de Rooy The construction $thes_mapping{ $code } // $code // '4' will still get some attention on a follow-up. Signed-off-by: Julian Maurice Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 08:01:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 07:01:07 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #50 from Josef Moravec --- Created attachment 72400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72400&action=edit Bug 14769: Add tests for _thesaurus_info in ControlledIndicators.t Apart from adding tests for this sub, we make the following change too and support it with a test. The fallback to $code in the construction $thes_mapping{ $code } // $code // '4' is removed by this patch. When $code is not in $thes_mapping, we cannot assume that it is a valid code for a biblio indicator. In this case it is more safe to mark it as 4 (Source not specified). Test plan: Run t/Koha/Authority/ControlledIndicators.t Signed-off-by: Marcel de Rooy Signed-off-by: Julian Maurice Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 08:01:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 07:01:12 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #51 from Josef Moravec --- Created attachment 72401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72401&action=edit Bug 14769: Add preference AuthorityControlledIndicators Including: [1] Atomic update to add pref for existing installs [2] Add new pref to sysprefs.sql for new installs [3] Add description to authorities preference file. Test plan: [1] Run new install or upgrade to add pref. [2] Check value of pref via System preferences in staff interface. Signed-off-by: Marcel de Rooy Signed-off-by: Julian Maurice Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 08:01:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 07:01:16 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #52 from Josef Moravec --- Created attachment 72402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72402&action=edit Bug 14769: Put ControlledIndicators to work This patch does: [1] Adds Koha::Authority->controlled_indicators (with a test). [2] Adds a call to controlled_indicators in AuthoritiesMarc::merge. Unit test Merge.t is extended too. [3] Simplifies the code in authorities/blinddetail-biblio-search.pl by calling controlled_indicators. Test plan: [1] Run t/db_dependent/Koha/Authorities.t [2] Run t/db_dependent/Authority/Merge.t [3] Steps 3 to 7 for MARC21: Create a PERSO_NAME authority with 008/11=r and ind1=3 [4] Edit a biblio and add a 600 linked to the new authority. [5] Verify that the biblio has ind1==3 and ind2==7 and $2==aat. (If $2 is not visible, check the metadata in biblio_metadata.) [6] Edit the PERSO_NAME authority and change 008/11 to '|' (bar). [7] Verify that merge updated your biblio record: $ind2==4 and $2 gone. [8] UNIMARC: Follow the pattern from steps 3 to 7. Create authority, link it in a biblio, check indicators (they should be copied both). Edit authority, change indicators and verify the merge results in the biblio record. Signed-off-by: Marcel de Rooy Tested PERSO_NAME and UNIF_TITLE. For UNIF_TITLE the second authority indicator is copied to ind1 or ind2, depending on the biblio tag involved. Signed-off-by: Julian Maurice Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 08:01:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 07:01:21 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #53 from Josef Moravec --- Created attachment 72403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72403&action=edit Bug 14769: (Follow-up) Reduce number of preference parses In sub merge the Koha::Authority object was already created, so it was kind of silly to recreate it each time with new. In Koha::Authority, the ControlledIndicators object can be saved in the object too for reuse during its life time. Similarly, we prevent repeated lookups for the reporting tag (via authority type). Test plan: [1] Run t/db_dependent/Authority/Merge.t [2] Run t/db_dependent/Koha/Authorities.t Signed-off-by: Marcel de Rooy Limited benchmarking shows me a reduction of 11% on Merge.t and a reduction of 4% on Authorities.t when comparing with and without this last patch. The larger impact on Merge.t could be expected. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 08:01:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 07:01:26 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #54 from Josef Moravec --- Created attachment 72404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72404&action=edit Bug 14769: (Follow-up) Let blinddetail look at indicator values If the indicators are not controlled, blinddetail should not overwrite what the user already entered. Very strictly seen, we could say that it is outside the scope. But it is strongly related. Signed-off-by: Marcel de Rooy Tested with 100 and 600 in the cataloging editor. For 100 the second indicator should not be overwritten. For 600 it should. Also tested "ind2:" which should blank ind2. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 08:21:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 07:21:34 +0000 Subject: [Koha-bugs] [Bug 20330] New: Allow translating more of quote upload Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20330 Bug ID: 20330 Summary: Allow translating more of quote upload Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at joensuu.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr There are untranslatable error messages and table header texts in the quote upload page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 08:23:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 07:23:38 +0000 Subject: [Koha-bugs] [Bug 20330] Allow translating more of quote upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20330 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at joensuu.fi |ity.org | Status|NEW |Needs Signoff --- Comment #1 from paxed --- Created attachment 72405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72405&action=edit Bug 20330: Allow translating more of quote upload Translate the error messages, and the table headers. Test plan: 1) Go to Home -> Tools -> Quote editor -> Import quotes 2) Upload quotes from a file. Try to trigger the error messages 3) On successful import, check the table header texts 4) Apply patch, update & install a language 5) The error messages and the table header texts should show up in the xx-YY-staff-prog.po 6) Repeat 1,2,3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 08:28:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 07:28:02 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #55 from Marcel de Rooy --- (In reply to Josef Moravec from comment #54) > Signed-off-by: Josef Moravec Great. Thx Josef -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 08:28:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 07:28:25 +0000 Subject: [Koha-bugs] [Bug 20328] White margin at the top of the home page of the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20328 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely at hotmail.com Resolution|--- |DUPLICATE Status|Signed Off |RESOLVED --- Comment #3 from Claire Gravely --- I think this is a duplicate of bug 20268 *** This bug has been marked as a duplicate of bug 20268 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 08:28:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 07:28:25 +0000 Subject: [Koha-bugs] [Bug 20268] CSS regression: white gap on the top of the staff pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20268 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley at catalyst.net.nz --- Comment #6 from Claire Gravely --- *** Bug 20328 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 09:15:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 08:15:34 +0000 Subject: [Koha-bugs] [Bug 20264] Syspref checkdigit is no longer in used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20264 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 09:15:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 08:15:45 +0000 Subject: [Koha-bugs] [Bug 20264] Syspref checkdigit is no longer in used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20264 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 09:15:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 08:15:36 +0000 Subject: [Koha-bugs] [Bug 20264] Syspref checkdigit is no longer in used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20264 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72396|0 |1 is obsolete| | --- Comment #9 from Josef Moravec --- Created attachment 72406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72406&action=edit Bug 20264: Remove syspref checkdigit According to http://irc.koha-community.org/koha/2013-06-26#i_1333289 http://irc.koha-community.org/koha/2013-06-26#i_1333589 and Hea data, this syspref is no longer in used and is always set to false. Signed-off-by: Dilan Johnpull? Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 09:35:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 08:35:03 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted/old tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #6 from Francesco Rivetti --- (In reply to Josef Moravec from comment #5) > there is missing atomic database update It is on its way. (It's fairly easy to do something reasonable, but there are some corner cases which I would like to handle somehow better) I would left the deleted* tables there with any clashing rows and let the administrator deal with it in case there are problems. thoughts? > I am not sure about the changes in OAI, so need to investigate more later Thank you so much, I wish I knew more about OAI > ::: C4/Biblio.pm > @@ -3182,5 @@ > > - my $bkup_sth = $dbh->prepare($query); > > - $bkup_sth->execute(@bind); > > - $bkup_sth->finish; > > - > > - _koha_delete_biblio_metadata( $biblionumber ); > > this is missing in your patch I might be lagging behind master, because I can't find it. > ::: C4/Items.pm > @@ +1061,4 @@ > > FROM items > > LEFT JOIN branches AS holding ON items.holdingbranch = holding.branchcode > > LEFT JOIN branches AS home ON items.homebranch=home.branchcode > > + LEFT JOIN biblio ON biblio.biblionumber = items.biblionumber AND biblio.deleted_at IS NULL > > I don't think this will work, that's condition should be in where clause I actually think it will be irrelevant. The FKs should make sure that if there is an item, there must be the biblio which it refers. Or am I missing something? > ::: misc/export_records.pl > @@ +105,5 @@ > > push @record_ids, $_->{biblionumber} for @{ > > + $dbh->selectall_arrayref(q| > > + SELECT biblionumber > > + FROM biblioitems > > + |, { Slice => {} }, ( $timestamp ) x 4 ); > > Please include the changes made by Bug 19730 Is it in master, right? TIA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 09:54:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 08:54:25 +0000 Subject: [Koha-bugs] [Bug 20331] New: Patrons search results sorting and pagination does not work properly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20331 Bug ID: 20331 Summary: Patrons search results sorting and pagination does not work properly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Try this: Go to patrons module Search for patrons Try to paginate - you can do it once, second click does not work Try to sort - you can sort once on column, second click on same column heading does not work. Sorting on Expired on does not work. Caused by commit 744e9a03791f50be98cb5c43cb4223f31fa30ed4 Bug 20145: Do not insert 0000-00-00 in patron tests (and more) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 09:54:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 08:54:35 +0000 Subject: [Koha-bugs] [Bug 20331] Patrons search results sorting and pagination does not work properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20331 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20145 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20145 [Bug 20145] borrowers.datexpiry eq '0000-00-00' means expired? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 09:54:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 08:54:35 +0000 Subject: [Koha-bugs] [Bug 20145] borrowers.datexpiry eq '0000-00-00' means expired? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20145 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20331 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20331 [Bug 20331] Patrons search results sorting and pagination does not work properly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 10:31:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 09:31:21 +0000 Subject: [Koha-bugs] [Bug 19546] Make koha-plack run Starman from the instance's directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72374|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy --- Created attachment 72407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72407&action=edit Bug 19546: Run starman from the instance's home dir This patch makes koha-plack jump into the instance's home directory to run. It is required because Perl 5.18 introduced a breaking change that makes perl die if @INC includes directories for which the user doesn't have read permission, and need to be traversed when querying for a lib. This is the case of '.', which is introduced automatically into @INC until Perl 5.26 (which removes the 'feature'). The Mojolicious::Plugins lib prefixes the plugin names with 'Mojolicious::Plugin' so it first looks (for example) for Mojolicious::Plugin::Koha::REST::Plugin::Pagination (Pagination is just the first one on the list). When it looks for it at '.' it dies (because of Perl's behaviour) so it doesn't query for the right namespace (the following to try). I only reproduced it in koha-testing-docker. To test, you just need to try this patched koha-plack and make sure it doesn't break due to this permissions issue. To test: - In your koha-testing-docker clone, run: $ docker-compose up -p test - Open a shell inside the container (on a separate terminal): $ docker exec -it test_koha_1 bash - From within the /root directory, restart plack: $ cd /root $ koha-plack --restart kohadev => FAIL: Logs show plack is broken due to permissions problems trying to find Mojolicious::Plugin::Koha::REST::Plugin::Pagination - Use the patched script from this patch: $ /kohadevbox/koha/debian/scripts/koha-plack --restart kohadev => SUCCESS: Plack runs fine, no error in the logs - Sign off :-D Note: people who has environments in which the problems is reproducible, please test this version of koha-plack and stamp your sign-off, PLEASE. Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 10:31:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 09:31:27 +0000 Subject: [Koha-bugs] [Bug 19546] Make koha-plack run Starman from the instance's directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 --- Comment #19 from Marcel de Rooy --- Created attachment 72408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72408&action=edit Bug 19546: (QA follow-up) Make the returning cd more fool proof Trivial and hypothetical fix. If you create /root/AA B (space in dirname), the quotes added here will help you to get back where you came from. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 10:31:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 09:31:17 +0000 Subject: [Koha-bugs] [Bug 19546] Make koha-plack run Starman from the instance's directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 11:16:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 10:16:08 +0000 Subject: [Koha-bugs] [Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 Andreas Hedstr?m Mace changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.hedstrom.mace at sub.s | |u.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 11:27:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 10:27:14 +0000 Subject: [Koha-bugs] [Bug 20111] Patron card creator - some strings are not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 --- Comment #6 from Victor Grousset/tuxayo --- Created attachment 72409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72409&action=edit Bug 20111: i18n Patron card creator: wrap with To avoid pollution and duplication in the .po files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 11:27:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 10:27:48 +0000 Subject: [Koha-bugs] [Bug 17717] Fix broken cronjobs due to permissions of the current directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #62 from Marcel de Rooy --- Looking here. Something wrong still -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 11:30:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 10:30:44 +0000 Subject: [Koha-bugs] [Bug 20111] Patron card creator - some strings are not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71604|0 |1 is obsolete| | --- Comment #7 from Victor Grousset/tuxayo --- Created attachment 72410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72410&action=edit Bug 20111: i18nize units in Patron card creator Test plan: 1. install and switch to the fr_FR locale or another one and adapt the test plan accordingly 2. go to /cgi-bin/koha/patroncards/edit-template.pl?op=new 3. then you should see the "Unit?s" dropdown with english units 4. apply this patch 5. install the language 6. refresh the page 7. then you should see the "Unit?s" dropdown with french units -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 11:31:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 10:31:05 +0000 Subject: [Koha-bugs] [Bug 20111] Patron card creator - some strings are not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72409|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 11:32:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 10:32:57 +0000 Subject: [Koha-bugs] [Bug 20111] Patron card creator - some strings are not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #8 from Victor Grousset/tuxayo --- (In reply to Jonathan Druart from comment #4) > We should surround these strings with a HTML tag (span?) to avoid TT > directives in the po files (please apply the fix to both .tt) Done in this bug. Initially in a separate patch but then the two patches were squashed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 11:33:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 10:33:56 +0000 Subject: [Koha-bugs] [Bug 17717] Fix broken cronjobs due to permissions of the current directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19546 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 11:33:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 10:33:56 +0000 Subject: [Koha-bugs] [Bug 19546] Make koha-plack run Starman from the instance's directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17717 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 11:36:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 10:36:09 +0000 Subject: [Koha-bugs] [Bug 17717] Fix broken cronjobs due to permissions of the current directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 11:36:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 10:36:13 +0000 Subject: [Koha-bugs] [Bug 17717] Fix broken cronjobs due to permissions of the current directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72372|0 |1 is obsolete| | --- Comment #63 from Marcel de Rooy --- Created attachment 72411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72411&action=edit Bug 17717: Add a --chdir option switch for koha-foreach Until Perl 5.26, the current directory is added to @INC when running a Perl script [1]. Having the current directory in @INC means it can be tried to be traversed when performing a lib lookup. Since version 5.18, Perl dies when it finds an unreadable directory (permissions) in @INC that needs to be traversed. This behaviour won't change because Perl devs consider it an enhancement to security. [2] Because of this, we need to make sure our scripts are ran **from** a directory in which they have read permissions. Ths patch adds a --chdir option switch to the **koha-foreach** wrapper script, that makes the inner shells/scripts to be ran within the Koha instance's user home directory. The change is trivial and should be QAed easily. I tested this on a prod server: - Create a /tmp/test.pl file containing: use Modern::Perl; use Cwd; my $dir = getcwd; warn $dir; 1; A) then create a cronjob entry to run it using koha-foreach: (in /etc/cron.d/test): 1/* * * * * root koha-foreach perl /tmp/test.pl - Once I noticed the cronjob ran, I used mutt to read the emails in the root user. => FAIL: ... Subject: Cron koha-foreach --enabled perl /tmp/test.pl "/root" "/root" "/root" "/root" "/root" ... B) I then used the patched koha-foreach with different results: => SUCCESS: ... Subject: Cron /root/koha-foreach --chdir --enabled perl /tmp/test.pl "/var/lib/koha/acaderc" "/var/lib/koha/agro" "/var/lib/koha/anc" "/var/lib/koha/arico" "/var/lib/koha/artes" ... So this patch's approach works. But... C) master's koha-foreach seems to work just the same... I think it is because of my previous attempt to fix this by using sudo in koha-shell. So I think environmental conditions affect the behaviour (which shell is configured for cron, sudo configuration, etc). ==== In conclusion, I think we should go ahead with this patch as it will solve peoples issues, and it is a right solution (option #5 on the list) to this Perl behaviour change. It doesn't cover other commands, but followup patches could do. I avoided /tmp as it is writable by any user... so it is an easy path for both exploiting by replacing some lib, and also because the existence of an unreadable dir that the interpreter could try to traverse (unreadable /tmp/Authen or /tmp/Koha will trigger the same error, and I assume people know what they are putting on the instance's dir, at least it will be easier to track). A followup patch takes care of making the cronjobs use --chdir when calling koha-foreach [1] https://lists.debian.org/debian-devel-announce/2016/08/msg00013.html [2] https://rt.perl.org/Public/Bug/Display.html?id=123795 Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 11:36:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 10:36:20 +0000 Subject: [Koha-bugs] [Bug 17717] Fix broken cronjobs due to permissions of the current directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72373|0 |1 is obsolete| | --- Comment #64 from Marcel de Rooy --- Created attachment 72412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72412&action=edit Bug 17717: Make cronjobs using koha-foreach use --chdir In order to patch production sites we need to adjust the shipped cronjobs so they are called with the --chdir option switch. Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 11:36:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 10:36:26 +0000 Subject: [Koha-bugs] [Bug 17717] Fix broken cronjobs due to permissions of the current directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 --- Comment #65 from Marcel de Rooy --- Created attachment 72413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72413&action=edit Bug 17717: (QA follow-up) Fix typo chdir This test does obviously not achieve the desired result: [ "chdir" != "no" ] Trivial fix. Adding the same quotes around starting_dir (just as for Bug 19546). Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 11:36:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 10:36:38 +0000 Subject: [Koha-bugs] [Bug 17717] Fix broken cronjobs due to permissions of the current directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 11:40:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 10:40:27 +0000 Subject: [Koha-bugs] [Bug 20332] New: Untranslatable strings in grouped OPAC results Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20332 Bug ID: 20332 Summary: Untranslatable strings in grouped OPAC results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at joensuu.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr The grouped OPAC results page has several untranslatable javascript-added texts, including the selection modifiers "Clear all" and "Select all" links, and the entries in the shelves/lists dropdown. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 11:43:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 10:43:29 +0000 Subject: [Koha-bugs] [Bug 20332] Untranslatable strings in grouped OPAC results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20332 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at joensuu.fi |ity.org | --- Comment #1 from paxed --- Created attachment 72414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72414&action=edit Bug 20332: Allow translating some grouped opac results texts The grouped OPAC results page has several untranslatable javascript-added texts, including the selection modifiers "Clear all" and "Select all" links, and the entries in the shelves/lists dropdown. No test plan, as I can't test it - we don't use the grouped results, and I don't have pazpar2 installed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 11:49:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 10:49:09 +0000 Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 --- Comment #70 from Victor Grousset/tuxayo --- Created attachment 72415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72415&action=edit Bug 19522: i18n Label creator: wrap text with In a SWITCH CASE. To avoid pollution and duplication in the .po files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 12:02:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 11:02:28 +0000 Subject: [Koha-bugs] [Bug 20097] marc2dcxml croaks on format dc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 --- Comment #3 from Marcel de Rooy --- (In reply to Maksim Sen from comment #2) > Hey Marcel, > > When I tried to get to the links you put out, I got to an Error 404 in Koha > (after changing the server and bibnumbers of course), with and without the > patch. > > I accessed the links directly, do I need to access your through another page? Thx for testing, Maksim. Testing these links should be enough. They still work for me. Please paste the URL you tried. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 12:17:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 11:17:54 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69709|0 |1 is obsolete| | Attachment #69710|0 |1 is obsolete| | Attachment #69711|0 |1 is obsolete| | Attachment #69712|0 |1 is obsolete| | Attachment #69713|0 |1 is obsolete| | Attachment #69714|0 |1 is obsolete| | Attachment #69715|0 |1 is obsolete| | Attachment #69716|0 |1 is obsolete| | Attachment #69717|0 |1 is obsolete| | Attachment #69718|0 |1 is obsolete| | Attachment #69719|0 |1 is obsolete| | Attachment #69720|0 |1 is obsolete| | Attachment #69721|0 |1 is obsolete| | Attachment #69722|0 |1 is obsolete| | Attachment #69723|0 |1 is obsolete| | Attachment #69759|0 |1 is obsolete| | --- Comment #108 from Josef Moravec --- Created attachment 72416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72416&action=edit Bug 18606: Add RotationCollections object classes Test plan: 1) Apply the patch 2) Update database 3) Go to tools -> Rotating collections and play with trying to break it: 3a) Add some collections 3b) Edit them 3c) Add some items to collections 3d) Remove some items 3e) Transfer some collections 3f) Try to remove collection without items 3g) Try to remove collection with items 4) Go to returns and: 4a) Try to return item from untransferred collection 4b) Try to return item from transferred collection 5) prove t/db_dependent/Koha/RotatingCollections.t t/db_dependent/Koha/Items.t t/db_dependent/Circulation.t t/db_dependent/Circulation/Returns.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 12:17:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 11:17:58 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #109 from Josef Moravec --- Created attachment 72417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72417&action=edit Bug 18606: Easy ones - CRUD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 12:18:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 11:18:06 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #111 from Josef Moravec --- Created attachment 72419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72419&action=edit Bug 18606: Schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 12:18:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 11:18:02 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #110 from Josef Moravec --- Created attachment 72418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72418&action=edit Bug 18606: Database changes - Add foreign keys to collections_tracking -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 12:18:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 11:18:10 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #112 from Josef Moravec --- Created attachment 72420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72420&action=edit Bug 18606: Get rid of GetItemsInCollection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 12:18:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 11:18:19 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #114 from Josef Moravec --- Created attachment 72422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72422&action=edit Bug 18606: Get rid of AddItemToCollection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 12:18:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 11:18:14 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #113 from Josef Moravec --- Created attachment 72421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72421&action=edit Bug 18606: Get rid of GetCollectionItemBranches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 12:18:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 11:18:23 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #115 from Josef Moravec --- Created attachment 72423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72423&action=edit Bug 18606: Get rid of RemoveItemFromCollection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 12:18:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 11:18:27 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #116 from Josef Moravec --- Created attachment 72424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72424&action=edit Bug 18606: Get rid of TransferCollection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 12:18:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 11:18:31 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #117 from Josef Moravec --- Created attachment 72425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72425&action=edit Bug 18606: Get rid of isItemInThisCollection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 12:18:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 11:18:35 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #118 from Josef Moravec --- Created attachment 72426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72426&action=edit Bug 18606: Get rid of isItemInAnyCollection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 12:18:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 11:18:39 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #119 from Josef Moravec --- Created attachment 72427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72427&action=edit Bug 18606: Remove lefover of C4::RotatingCollections -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 12:18:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 11:18:43 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #120 from Josef Moravec --- Created attachment 72428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72428&action=edit Bug 18606: Rework tests for rotating collections -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 12:18:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 11:18:47 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #121 from Josef Moravec --- Created attachment 72429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72429&action=edit Bug 18606: Add test to t/db_dependent/Koha/Items.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 12:18:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 11:18:51 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #122 from Josef Moravec --- Created attachment 72430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72430&action=edit Bug 18606: Unify handling of success/error messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 12:18:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 11:18:55 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #123 from Josef Moravec --- Created attachment 72431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72431&action=edit Bug 18606: (Follow-up) Make QA tools happy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 12:35:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 11:35:06 +0000 Subject: [Koha-bugs] [Bug 20219] t/smolder_smoke_signal is no longer used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20219 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 12:35:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 11:35:09 +0000 Subject: [Koha-bugs] [Bug 20219] t/smolder_smoke_signal is no longer used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20219 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72388|0 |1 is obsolete| | --- Comment #3 from Josef Moravec --- Created attachment 72432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72432&action=edit Bug 20219: Remove t/smolder_smoke_signal The file is no longer used (is it?) and the project looks dead. Let remove that file. Signed-off-by: Roch D'Amour Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 12:35:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 11:35:18 +0000 Subject: [Koha-bugs] [Bug 20219] t/smolder_smoke_signal is no longer used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20219 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 12:36:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 11:36:41 +0000 Subject: [Koha-bugs] [Bug 20321] C4:XISBN->get_biblionumber_from_isbn is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20321 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 12:39:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 11:39:35 +0000 Subject: [Koha-bugs] [Bug 20321] C4:XISBN->get_biblionumber_from_isbn is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20321 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 12:39:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 11:39:38 +0000 Subject: [Koha-bugs] [Bug 20321] C4:XISBN->get_biblionumber_from_isbn is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20321 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72385|0 |1 is obsolete| | --- Comment #3 from Josef Moravec --- Created attachment 72433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72433&action=edit Bug 20321 - Remove get_biblionumber_from_isbn To test: 1 - grep get_biblionumber_from_isbn 2 - verify all occurences are not actual calls (except for test) 3 - Apply patch 4 - grep get_biblionumber_from_isbn 5 - Verify it is removed Signed-off-by: Roch D'Amour Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 12:55:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 11:55:19 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Needs Signoff |Failed QA --- Comment #35 from Josef Moravec --- I can't even add an item without collection code after last patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 12:56:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 11:56:44 +0000 Subject: [Koha-bugs] [Bug 20333] New: Show certain links just for registered users Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20333 Bug ID: 20333 Summary: Show certain links just for registered users Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: hagud at orex.es QA Contact: testopia at bugs.koha-community.org It should be great If Koha should be able to show certain llinks (856) if a certain logged users belong to one or more category codes Some libraries are requesting us the functionality of allow Koha to catalogue in the 856 link to restricted documents, that only will be showed if 1. the user is logged 2. if the category code match certain values These conditions are the same than ILL request. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 13:49:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 12:49:20 +0000 Subject: [Koha-bugs] [Bug 20334] New: Option for escaping slashes in search queries Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 Bug ID: 20334 Summary: Option for escaping slashes in search queries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: glasklas at gmail.com There are a number of reserved characters in the Elasticsearch query syntax (+ - = && || > < ! ( ) { } [ ] ^ " ~ * ? : \ /). Slash (/), which is used for regexps, is quite often used in searches with the intent as it should be interpreted as a literal sting. This causes the search to crash since Elasticsearch treats this as an unclosed regular expression (or a regexp if two slashes are used which can be even more confusing). To address this particular case here is a patch with an option to escape slashes (or require them to be escaped to count as a regular expression delimiter). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 14:10:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 13:10:38 +0000 Subject: [Koha-bugs] [Bug 20334] Option for escaping slashes in search queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 --- Comment #1 from David Gustafsson --- Created attachment 72434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72434&action=edit Bug 20334 - Option for escaping slashes in search queries Add "QueryRegexEscapeOption" system preference to provide option to escape Elasticsearch regexp delimiters (/) within queries, or alternativly to unescape escaped slashes (\/) while escaping unescaped slashes, in effect making "\/" the new regexp delimiter. How to test: 1) Run tests in ./t/Koha/SearchEngine/ElasticSearch/QueryBuilder.t 2) All tests should succeed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 14:19:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 13:19:11 +0000 Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #18 from Victor Grousset/tuxayo --- So no need to change anything functionally? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 14:20:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 13:20:52 +0000 Subject: [Koha-bugs] [Bug 20334] Option for escaping slashes in search queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72434|0 |1 is obsolete| | --- Comment #2 from David Gustafsson --- Created attachment 72435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72435&action=edit Bug 20334 - Option for escaping slashes in search queries Add "QueryRegexEscapeOption" system preference to provide option to escape Elasticsearch regexp delimiters (/) within queries, or alternativly to unescape escaped slashes (\/) while escaping unescaped slashes, in effect making "\/" the new regexp delimiter. How to test: 1) Run tests in ./t/Koha/SearchEngine/ElasticSearch/QueryBuilder.t 2) All tests should succeed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 14:28:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 13:28:42 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted/old tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #7 from Katrin Fischer --- I think we should try and provide at least a script to automate merging the two tables. You cannot assume that most admins know Koha well enough to fix the issues themselves. A problem might be the possible existence of duplicated rows. We could check that and then suggest a fix before continuing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 14:30:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 13:30:43 +0000 Subject: [Koha-bugs] [Bug 20333] Show certain links just for registered users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20333 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Hugo, I think just controlling the visibility is not a good way of protecting restricted resources. Links can be shared or keep working, if your account has been blocked or deleted. What you need to implement, I think, is a protection of the resource itself, that Koha can't provide unless it's stored within Koha itself. > These conditions are the same than ILL request. Can you explain? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 14:54:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 13:54:26 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted/old tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #8 from Francesco Rivetti --- (In reply to Katrin Fischer from comment #7) > I think we should try and provide at least a script to automate merging the > two tables. You cannot assume that most admins know Koha well enough to fix > the issues themselves. A problem might be the possible existence of > duplicated rows. We could check that and then suggest a fix before > continuing. My idea is to move all the rows properly. if any rows clash (for some unforeseen reason, i found a "orphaned" item referring to a non-existent biblio here, but can be anything!) then they won't be moved. at the end, if the table is empty, it gets removed, otherwise it stays there. does it sounds good? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 15:16:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 14:16:46 +0000 Subject: [Koha-bugs] [Bug 20333] Show certain links just for registered users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20333 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 15:31:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 14:31:18 +0000 Subject: [Koha-bugs] [Bug 20335] New: Stage MARC records for import does not work under Plack Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20335 Bug ID: 20335 Summary: Stage MARC records for import does not work under Plack Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: Linux Status: NEW Severity: major Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: koha-bugs at lists.koha-community.org Reporter: arouss1980 at gmail.com QA Contact: testopia at bugs.koha-community.org In a vanilla 17.11.03 installation with Plack enabled, attempting to stage a MARC record for import fails with a pop-up message that reads: "Failed to submit form: error". In intranet-error.log the following information appears: stage-marc-import.pl: /usr/share/koha/intranet/cgi-bin/tools/stage-marc-import.pl: cannot open input file /tmp/koha_hax_upload/3f11cee01b610984d5dbd6430106d173_koha.mrc: No such file or directory The permissions of the directory and file above are as follows: drwxr-xr-x 2 hax-koha hax-koha 4096 Mar 5 16:18 /tmp/koha_hax_upload -rw-r--r-- 1 hax-koha hax-koha 1058 Mar 5 16:18 /tmp/koha_hax_upload/3f11cee01b610984d5dbd6430106d173_koha.mrc To reproduce, simply enable Plack in a vanilla 17.11.03 installation, then go to Home -> Tools -> Stage MARC records for import, browse for a file, hit the "Upload file" button, and then click the "Stage for import" button. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 15:49:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 14:49:23 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Bug 15449 depends on bug 14828, which changed state. Bug 14828 Summary: Move the item types related code to Koha::ItemTypes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 15:49:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 14:49:23 +0000 Subject: [Koha-bugs] [Bug 19646] value_builder marc21_linking_section template is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646 Bug 19646 depends on bug 14828, which changed state. Bug 14828 Summary: Move the item types related code to Koha::ItemTypes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 15:49:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 14:49:24 +0000 Subject: [Koha-bugs] [Bug 15306] Don't show translate link for item types if only one language is installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 Bug 15306 depends on bug 14828, which changed state. Bug 14828 Summary: Move the item types related code to Koha::ItemTypes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 15:49:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 14:49:24 +0000 Subject: [Koha-bugs] [Bug 15730] 500 error on returns.pl if barcode doesn't exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15730 Bug 15730 depends on bug 14828, which changed state. Bug 14828 Summary: Move the item types related code to Koha::ItemTypes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 15:49:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 14:49:25 +0000 Subject: [Koha-bugs] [Bug 16114] Regression: Bug 14828 broke display of localized item type descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16114 Bug 16114 depends on bug 14828, which changed state. Bug 14828 Summary: Move the item types related code to Koha::ItemTypes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 15:49:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 14:49:23 +0000 Subject: [Koha-bugs] [Bug 14828] Move the item types related code to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 15:49:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 14:49:26 +0000 Subject: [Koha-bugs] [Bug 16671] Wrong itemtype picked in HoldsQueue.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16671 Bug 16671 depends on bug 14828, which changed state. Bug 14828 Summary: Move the item types related code to Koha::ItemTypes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 15:49:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 14:49:25 +0000 Subject: [Koha-bugs] [Bug 16449] unimarc_field_4XX raises a warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16449 Bug 16449 depends on bug 14828, which changed state. Bug 14828 Summary: Move the item types related code to Koha::ItemTypes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 15:49:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 14:49:26 +0000 Subject: [Koha-bugs] [Bug 17657] Item type's images could not be displayed correctly on the item types admin page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17657 Bug 17657 depends on bug 14828, which changed state. Bug 14828 Summary: Move the item types related code to Koha::ItemTypes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 15:49:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 14:49:27 +0000 Subject: [Koha-bugs] [Bug 18525] Can't create order line from accepted suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18525 Bug 18525 depends on bug 14828, which changed state. Bug 14828 Summary: Move the item types related code to Koha::ItemTypes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 16:05:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 15:05:10 +0000 Subject: [Koha-bugs] [Bug 19941] 'alt' and 'title' attributes of the item type image are not set when a hold is placed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19941 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED CC| |tomascohen at gmail.com --- Comment #2 from Tom?s Cohen Arazi --- Jonathan, it seems to me that you submitted the patch for bug 19440 here, and forgot about this specific bug you were trying to fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 16:05:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 15:05:21 +0000 Subject: [Koha-bugs] [Bug 19941] 'alt' and 'title' attributes of the item type image are not set when a hold is placed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19941 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70380|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 16:07:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 15:07:20 +0000 Subject: [Koha-bugs] [Bug 19940] Koha::Biblio - Remove GetBiblioItemInfosOf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19940 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19941 Depends on|19941 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19941 [Bug 19941] 'alt' and 'title' attributes of the item type image are not set when a hold is placed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 16:07:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 15:07:20 +0000 Subject: [Koha-bugs] [Bug 19941] 'alt' and 'title' attributes of the item type image are not set when a hold is placed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19941 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|19940 | Depends on| |19940 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19940 [Bug 19940] Koha::Biblio - Remove GetBiblioItemInfosOf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 16:43:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 15:43:57 +0000 Subject: [Koha-bugs] [Bug 20167] Item hold is set to bibliographic hold when changing pickup location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20167 --- Comment #1 from Tom?s Cohen Arazi --- (In reply to Stefan Berndtsson from comment #0) > If a patron has an item level hold with pickup location set to library A and > staff then (via the Holds tab in the patron view) changes pickup location to > library B, itemnumber is lost from the hold. This is a definite problem when > the items within a bibliographic record are different things (separate > volumes for example). > > This can be fixed by adding some code in Koha/REST/V1/Hold.pm > > This bit before the ModReserve call: > > if($hold->itemnumber()) { > $params->{itemnumber} = $hold->itemnumber(); > } > > > However, given the FIXME comment in C4/Reserves.pm for ModReserve, I'm > wondering if this is the desired fix: > "Note that the forgoing can have the effect of causing > item-level hold requests to turn into title-level requests. This > will be fixed once reserves has separate columns for requested > itemnumber and supplying itemnumber." > > > A different method of solving this issue could be to provide itemnumber as > part of the pickup-location-change call instead and keep the rest of the > REST-API and ModReserve the way it works now. I'm somewhat unfamiliar with > the how the Mojolicious system works, so I haven't looked into that method > yet. I think your proposed solution is the right onw. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 16:47:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 15:47:53 +0000 Subject: [Koha-bugs] [Bug 20333] Show certain links just for registered users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20333 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #2 from Tom?s Cohen Arazi --- (In reply to Katrin Fischer from comment #1) > Hi Hugo, > > I think just controlling the visibility is not a good way of protecting > restricted resources. Links can be shared or keep working, if your account > has been blocked or deleted. What you need to implement, I think, is a > protection of the resource itself, that Koha can't provide unless it's > stored within Koha itself. We could add that functionality to Koha uploads. Some sites work with the referer as a way to validate the request, so hiding the links could help. But that'd be certainly a separate featurre: optionally removing 856 fields based on some regexp and config. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 16:58:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 15:58:25 +0000 Subject: [Koha-bugs] [Bug 20333] Show certain links just for registered users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20333 --- Comment #3 from Katrin Fischer --- Another thought: woudn't it be better to show the link and ask for login before access? That way users can discover the existence of the resources, otherwise they might not even notice. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 17:04:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 16:04:57 +0000 Subject: [Koha-bugs] [Bug 20085] Better translatability of smart-rules.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20085 --- Comment #3 from Fridolin SOMERS --- (In reply to Jonathan Druart from comment #2) > (In reply to Fridolin SOMERS from comment #1) > > Also adds on "Unlimited" and "None defined" so that there are more > > visible > > and that there translation is more simple. > > Why do you want to make them more visible? I do not think it should be done > in this patch. Its because there are a special case, like All for Patron category or Item type. Otherwise we can use a simple span. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 17:07:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 16:07:46 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/17.05.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 --- Comment #40 from Fridolin SOMERS --- (In reply to Mirko Tietgen from comment #39) > Fridolin: This is a "standing" bug, it will get new patches whenever a > dependency is pushed. So after push I set it back to assigned. Ok thanks for the explanation ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 17:13:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 16:13:10 +0000 Subject: [Koha-bugs] [Bug 20164] Suspend Waiting Hold in OPAC loophole In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20164 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 17:13:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 16:13:31 +0000 Subject: [Koha-bugs] [Bug 20171] Item search should honor syspref 'delimiter' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20171 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 17:22:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 16:22:26 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #150 from M. Tompsett --- Currently does not apply, reworking. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 17:32:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 16:32:25 +0000 Subject: [Koha-bugs] [Bug 20334] Option for escaping slashes in search queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #3 from Josef Moravec --- David, is this ready for testing? If so, please change status to "Needs signoff" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 17:36:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 16:36:54 +0000 Subject: [Koha-bugs] [Bug 20320] Add a "Library CSS" parameter in the Library Admin page to allow site specific customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20320 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 17:41:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 16:41:49 +0000 Subject: [Koha-bugs] [Bug 20167] Item hold is set to bibliographic hold when changing pickup location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20167 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 72436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72436&action=edit Bug 20167: Regression test -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 17:41:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 16:41:55 +0000 Subject: [Koha-bugs] [Bug 20167] Item hold is set to bibliographic hold when changing pickup location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20167 --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 72437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72437&action=edit Bug 20167: Make changing a hold pass the itemnumber to ModReserve If you have an item-level hold, changing an attribute (like priority, pickup location or suspended until date) makes the hold a biblio-level hold, because ModReserve is not passed the current itemnumber. This patch uses the hold's itemnumber and passes it to the ModReserve call. To test: - Run the regression tests from the previous patch: $ kshell k$ prove t/db_dependent/api/v1/holds.t => FAIL: Tests fail - Apply this patch - Run the tests: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 17:42:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 16:42:08 +0000 Subject: [Koha-bugs] [Bug 20167] Item hold is set to bibliographic hold when changing pickup location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20167 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 17:42:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 16:42:14 +0000 Subject: [Koha-bugs] [Bug 20320] Add a "Library CSS" parameter in the Library Admin page to allow site specific customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20320 --- Comment #2 from Nick Clemens --- The idea was a way to replace OPAC_CSS_OVERRIDE, I would be happy with maybe both? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 17:42:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 16:42:15 +0000 Subject: [Koha-bugs] [Bug 20167] Item hold is set to bibliographic hold when changing pickup location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20167 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 17:49:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 16:49:45 +0000 Subject: [Koha-bugs] [Bug 20322] Circulation page layout and design update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 17:53:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 16:53:04 +0000 Subject: [Koha-bugs] [Bug 19940] Koha::Biblio - Remove GetBiblioItemInfosOf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19940 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 17:53:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 16:53:08 +0000 Subject: [Koha-bugs] [Bug 19940] Koha::Biblio - Remove GetBiblioItemInfosOf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19940 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70381|0 |1 is obsolete| | --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 72438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72438&action=edit Bug 19940: Koha::Biblio - Remove GetBiblioItemInfosOf This subroutine is only used once and can be replaced easily with a Koha::Biblioitems->search call Test plan: Test this on top of bug 19941 and confirm that the correct item types are displayed Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 17:58:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 16:58:32 +0000 Subject: [Koha-bugs] [Bug 20329] Text input fields are wider than the fieldset class they are inside of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 17:59:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 16:59:07 +0000 Subject: [Koha-bugs] [Bug 20305] Warnings in tools scripts need to be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20305 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 18:01:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 17:01:24 +0000 Subject: [Koha-bugs] [Bug 20312] Add a link towards the last consulted patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 18:06:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 17:06:37 +0000 Subject: [Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71557|0 |1 is obsolete| | --- Comment #9 from Owen Leonard --- Created attachment 72439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72439&action=edit Bug 19709 - Move template JavaScript to the footer: Labels This patch modifies the staff client label creator templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc. - Creating and managing layouts - Creating and managing batches - Creating and managing templates - Creating and managing printer profiles - Creating quick spine labels Edit: Fixed footer include error causing blank popup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 18:21:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 17:21:56 +0000 Subject: [Koha-bugs] [Bug 20320] Add a "Library CSS" parameter in the Library Admin page to allow site specific customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20320 --- Comment #3 from Katrin Fischer --- Ah yep, a URL would definitely work better than a setting in the Apache config :) A text input could be done later, I just wanted to put it out there :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 18:42:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 17:42:10 +0000 Subject: [Koha-bugs] [Bug 19959] Update popup window templates to use Bootstrap grid: Label creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19959 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71482|0 |1 is obsolete| | --- Comment #6 from Owen Leonard --- Created attachment 72440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72440&action=edit Bug 19959: Update popup window templates to use Bootstrap grid: Label creator This patch updates two label creator templates to use the Bootstrap grid instead of the YUI grid. To test, apply the patch and go to Label creator -> Manage -> Label batches. - Create a new or open an existing label batch. - Click "Add items." - The resulting pop-up window should look correct. - Perform a search - The search results screen should look correct. Signed-off-by: Charlotte Cordwell -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 19:40:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 18:40:40 +0000 Subject: [Koha-bugs] [Bug 20336] New: Add a generic way for Koha::Object(s) to call logaction as required Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20336 Bug ID: 20336 Summary: Add a generic way for Koha::Object(s) to call logaction as required Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 20:25:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 19:25:15 +0000 Subject: [Koha-bugs] [Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72304|0 |1 is obsolete| | --- Comment #11 from Tom?s Cohen Arazi --- Created attachment 72441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72441&action=edit Bug 19469: Clean up template whitespace Sponsored-by: Stockholm University Library Signed-off-by: Kyle M Hall Passed QA test tool Signed-off-by: Alex Buckley Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 20:25:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 19:25:34 +0000 Subject: [Koha-bugs] [Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 --- Comment #13 from Tom?s Cohen Arazi --- Created attachment 72443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72443&action=edit Bug 19469: (followup) Use patron-title.inc as proposed by bug 18403 This patch makes the new template include file use the patron-title.inc include to render the patron name. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 20:25:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 19:25:27 +0000 Subject: [Koha-bugs] [Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72305|0 |1 is obsolete| | --- Comment #12 from Tom?s Cohen Arazi --- Created attachment 72442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72442&action=edit Bug 19469: Add ability to split view of holds view on record by pickup library and/or itemtype It is possible to set up circulation rules to limit trapping of holds by pickup library and itemtype. To make it easier to understand which holds will be trapped in a given circumstance, it would be nice if we could optionally group holds by pickup library and/or itemtype. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable AllowHoldItemTypeSelection 4) Pick a record and create holds with various pickup libraries and itemtype combinations 5) Enable HoldsSplitQueueNumbering 6) Try the different combinations of HoldsSplitQueue 7) Ensure the hold "arrows" move the items correctly * Up and down arrows should move hold above or below the adjacent hold within a hold fieldset * Top and borrom arrows should move hold to the top or bottom within a hold fieldset Sponsored-by: Stockholm University Library Signed-off-by: Kyle M Hall Followed test plan, patch worked as described. Also passed QA test tool Signed-off-by: Alex Buckley Signed-off-by: Andreas Hedstr?m Mace Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 20:26:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 19:26:02 +0000 Subject: [Koha-bugs] [Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 20:38:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 19:38:01 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #36 from Owen Leonard --- Created attachment 72444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72444&action=edit Bug 19474 (follow-up) Catch up with changes to CSS from Bug 19981 This patch brings staff-global.scss up to date with changes made in Bug 19981. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 20:51:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 19:51:44 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #151 from M. Tompsett --- Comment on attachment 70259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70259 Bug 14385: A lot of patches Review of attachment 70259: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14385&attachment=70259) ----------------------------------------------------------------- ::: opac/opac-tags.pl @@ +310,5 @@ > + if (grep { $_->{term} eq $my_tag->{term} } @$results) { > + if (! $my_tag->{visible} ) { > + my $check_biblio = GetMarcBiblio({ > + biblionumber => $my_tag->{biblionumber}, > + embed_itesm => 1, Always good idea to re-check over and over. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 21:36:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 20:36:13 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #152 from M. Tompsett --- Created attachment 72445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72445&action=edit Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower categories Edit: Fixing merge conflicts in - t/db_dependent/Items.t - t/db_dependent/Search.t - C4/Search.pm Changes the API for calling GetHiddenItems and all the places in the code that call it. This is to allow borrower categories to be passed in. Adds an OpacHiddenItemsExceptions syspref to allow certain borrower categories to be able to see items, even if they are marked hidden by OpacHiddenItems To test: 1) Make two borrowers, one in a category that should see everything (ie Adult), and another in a category that should only see certain things (ie Adult - exceptions) 2) Add the borrower that can see everything (the Adult) to OpacHiddenItemsExceptions 3) To the OpacHiddenItems syspref, add an item type (ensure that you have some records that fall under this type in your library). 4) Log in as the borrower that should only see certain things (Adult - exception) 5) Do a search, filtered to show records which are the item type that you specified in the OpacHiddenItems syspref. No records should show for this borrower as this item type is hidden to them. 6) Log in as the borrower that should see everything (Adult) 7) Do the same search. There should be results from this search, as this borrower category has been specified as an exception to the hidden items Signed-off-by: Claire Gravely Signed-off-by: Mark Tompsett Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 21:36:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 20:36:18 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70257|0 |1 is obsolete| | --- Comment #153 from M. Tompsett --- Created attachment 72446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72446&action=edit Bug 14385 Followup: C4::Borrowers not found GetMember is in C4::Members, not C4::Borrowers Signed-off-by: Claire Gravely Signed-off-by: Mark Tompsett Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 21:36:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 20:36:23 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70258|0 |1 is obsolete| | --- Comment #154 from M. Tompsett --- Created attachment 72447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72447&action=edit Bug 14385: Followup: changes to sysprefs.sql and atomicupdate Run updatedatabase.pl when testing Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 21:36:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 20:36:29 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #155 from M. Tompsett --- Created attachment 72448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72448&action=edit Bug 14385: Squash of a lot of patches rebased - Added missing GetHiddenItems parameter change case Without this prove t had a failure. - Always use mocks, not set_preference - Tweaks so t/db_dependent/00-strict.t passes There was a typo botcat vs borcat and borrowernumber was never defined. Grabbing from userenv, like other code does. - Tweak t/db_dependent/Items.t to fully test changes This will test all the if structures fully in GetHiddenItemnumbers. prove t/db_dependent/Items.t - Tweak borrower category code $borrower->{categorycode} on a Koha::Patron is not the same as $borrower->categorycode. Fixed error. - Search was returning URLS for wrong interface There was one search context place wrong. Changed it to $is_opac as the logic for setting $is_opac was modified correctly. - Corrected issues with category code. When a user isn't logged in, $borrower is undef and causes error when determining category code. Added conditional check. - Properly trigger all changes in C4/Search.pm - Fix QA Test tool failures C4/Search.pm had some tabs. - Add some commenting to make sense of logic - Refactor EmbedItemsInMarcBiblio parameters to hashref - Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call. prove t/db_dependent/Items.t - Add missing test to trigger Koha/BiblioUtils/Iterator change - Add borrower category overrides These files generally add borcat parameter to GetMarcBiblio. Others might include correction of filtering of items (opac-basket), or a comment as to why no changes were done (opac-search). In the case of opac-search, correcting the first FIXME will likely correct the OpacHiddenItems issues on tags. As such, that is beyond this bugs scope. Some code had loop optimizations and fixes made, like a 'next unless $record' when the biblio shouldn't even be in the list. - Modify opac-ISBDdetail and opac-MARCdetail Both files had similar logic. They were rearranged and optimized, so that both files would have practically identical initial blocks of code. Optimizations were possible, because GetMarcBiblio returns a filtered record, so that there is no double call (once in the opac-### file and once in GetMarcBiblio) to GetHiddenItemnumbers. - Fix hiding in opac-tags opac/opac-tags.pl was not properly hiding. There is currently one known bug associated with tags left. If you have two biblios tagged by different people with the same tag, the opac-search will show the one you tagged that is supposed to be hidden, because tag searches work differently than regular searches. This is beyond the scope of this bug. See the FIXME's in opac/opac-search.pl - Trigger the C4::ILSDI::Services changes prove t/db_dependent/ILSDI_Services.t - Added missing 'my' - Test C4/Labels/Label.pm changes - Improve C4::Record::marcrecord2csv test cases - Corrected opac-details searchResult call - Fix breaking issues constraint in ITerator test - Fix ILSDI_Services test when clubs with branch exist - Rebased again! The test plan is in comment #112 last I checked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 21:37:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 20:37:11 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70257|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 5 21:37:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 20:37:30 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70258|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 00:20:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 23:20:19 +0000 Subject: [Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921 rkuiper at roundrocktexas.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuiper at roundrocktexas.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 00:20:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 23:20:00 +0000 Subject: [Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of 'Available' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505 rkuiper at roundrocktexas.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuiper at roundrocktexas.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 00:21:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 23:21:09 +0000 Subject: [Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921 rkuiper at roundrocktexas.gov changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10454 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 00:23:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Mar 2018 23:23:03 +0000 Subject: [Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921 rkuiper at roundrocktexas.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|rkuiper at roundrocktexas.gov | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 02:31:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 01:31:20 +0000 Subject: [Koha-bugs] [Bug 20337] New: Add modification templates to Batch item modification Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20337 Bug ID: 20337 Summary: Add modification templates to Batch item modification Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: verolencinas at yahoo.com.ar QA Contact: testopia at bugs.koha-community.org Batch item modification allows adding o deleting data, but not modification of existing data, for example change dashes to spaces in signatures. It should be possible to use also MARC Modification Template on items. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 02:52:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 01:52:35 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72448|0 |1 is obsolete| | --- Comment #156 from M. Tompsett --- Created attachment 72449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72449&action=edit Bug 14385: Squash of a lot of patches rebased - Added missing GetHiddenItems parameter change case Without this prove t had a failure. - Always use mocks, not set_preference - Tweaks so t/db_dependent/00-strict.t passes There was a typo botcat vs borcat and borrowernumber was never defined. Grabbing from userenv, like other code does. - Tweak t/db_dependent/Items.t to fully test changes This will test all the if structures fully in GetHiddenItemnumbers. prove t/db_dependent/Items.t - Tweak borrower category code $borrower->{categorycode} on a Koha::Patron is not the same as $borrower->categorycode. Fixed error. - Search was returning URLS for wrong interface There was one search context place wrong. Changed it to $is_opac as the logic for setting $is_opac was modified correctly. - Corrected issues with category code. When a user isn't logged in, $borrower is undef and causes error when determining category code. Added conditional check. - Properly trigger all changes in C4/Search.pm - Fix QA Test tool failures C4/Search.pm had some tabs. - Add some commenting to make sense of logic - Refactor EmbedItemsInMarcBiblio parameters to hashref - Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call. prove t/db_dependent/Items.t - Add missing test to trigger Koha/BiblioUtils/Iterator change - Add borrower category overrides These files generally add borcat parameter to GetMarcBiblio. Others might include correction of filtering of items (opac-basket), or a comment as to why no changes were done (opac-search). In the case of opac-search, correcting the first FIXME will likely correct the OpacHiddenItems issues on tags. As such, that is beyond this bugs scope. Some code had loop optimizations and fixes made, like a 'next unless $record' when the biblio shouldn't even be in the list. - Modify opac-ISBDdetail and opac-MARCdetail Both files had similar logic. They were rearranged and optimized, so that both files would have practically identical initial blocks of code. Optimizations were possible, because GetMarcBiblio returns a filtered record, so that there is no double call (once in the opac-### file and once in GetMarcBiblio) to GetHiddenItemnumbers. - Fix hiding in opac-tags opac/opac-tags.pl was not properly hiding. There is currently one known bug associated with tags left. If you have two biblios tagged by different people with the same tag, the opac-search will show the one you tagged that is supposed to be hidden, because tag searches work differently than regular searches. This is beyond the scope of this bug. See the FIXME's in opac/opac-search.pl - Trigger the C4::ILSDI::Services changes prove t/db_dependent/ILSDI_Services.t - Added missing 'my' - Test C4/Labels/Label.pm changes - Improve C4::Record::marcrecord2csv test cases - Corrected opac-details searchResult call - Fix breaking issues constraint in ITerator test - Fix ILSDI_Services test when clubs with branch exist - Rebased again! The test plan is in comment #112 last I checked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 02:55:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 01:55:50 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72449|0 |1 is obsolete| | --- Comment #157 from M. Tompsett --- Created attachment 72450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72450&action=edit Bug 14385: Squash of a lot of patches rebased - Added missing GetHiddenItems parameter change case Without this prove t had a failure. - Always use mocks, not set_preference - Tweaks so t/db_dependent/00-strict.t passes There was a typo botcat vs borcat and borrowernumber was never defined. Grabbing from userenv, like other code does. - Tweak t/db_dependent/Items.t to fully test changes This will test all the if structures fully in GetHiddenItemnumbers. prove t/db_dependent/Items.t - Tweak borrower category code $borrower->{categorycode} on a Koha::Patron is not the same as $borrower->categorycode. Fixed error. - Search was returning URLS for wrong interface There was one search context place wrong. Changed it to $is_opac as the logic for setting $is_opac was modified correctly. - Corrected issues with category code. When a user isn't logged in, $borrower is undef and causes error when determining category code. Added conditional check. - Properly trigger all changes in C4/Search.pm - Fix QA Test tool failures C4/Search.pm had some tabs. - Add some commenting to make sense of logic - Refactor EmbedItemsInMarcBiblio parameters to hashref - Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call. prove t/db_dependent/Items.t - Add missing test to trigger Koha/BiblioUtils/Iterator change - Add borrower category overrides These files generally add borcat parameter to GetMarcBiblio. Others might include correction of filtering of items (opac-basket), or a comment as to why no changes were done (opac-search). In the case of opac-search, correcting the first FIXME will likely correct the OpacHiddenItems issues on tags. As such, that is beyond this bugs scope. Some code had loop optimizations and fixes made, like a 'next unless $record' when the biblio shouldn't even be in the list. - Modify opac-ISBDdetail and opac-MARCdetail Both files had similar logic. They were rearranged and optimized, so that both files would have practically identical initial blocks of code. Optimizations were possible, because GetMarcBiblio returns a filtered record, so that there is no double call (once in the opac-### file and once in GetMarcBiblio) to GetHiddenItemnumbers. - Fix hiding in opac-tags opac/opac-tags.pl was not properly hiding. There is currently one known bug associated with tags left. If you have two biblios tagged by different people with the same tag, the opac-search will show the one you tagged that is supposed to be hidden, because tag searches work differently than regular searches. This is beyond the scope of this bug. See the FIXME's in opac/opac-search.pl - Trigger the C4::ILSDI::Services changes prove t/db_dependent/ILSDI_Services.t - Added missing 'my' - Test C4/Labels/Label.pm changes - Improve C4::Record::marcrecord2csv test cases - Corrected opac-details searchResult call - Fix breaking issues constraint in ITerator test - Fix ILSDI_Services test when clubs with branch exist - Rebased again! The test plan is in comment #112 last I checked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 02:58:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 01:58:08 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72450|0 |1 is obsolete| | --- Comment #158 from M. Tompsett --- Created attachment 72451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72451&action=edit Bug 14385: Squash of a lot of patches rebased - Added missing GetHiddenItems parameter change case Without this prove t had a failure. - Always use mocks, not set_preference - Tweaks so t/db_dependent/00-strict.t passes There was a typo botcat vs borcat and borrowernumber was never defined. Grabbing from userenv, like other code does. - Tweak t/db_dependent/Items.t to fully test changes This will test all the if structures fully in GetHiddenItemnumbers. prove t/db_dependent/Items.t - Tweak borrower category code $borrower->{categorycode} on a Koha::Patron is not the same as $borrower->categorycode. Fixed error. - Search was returning URLS for wrong interface There was one search context place wrong. Changed it to $is_opac as the logic for setting $is_opac was modified correctly. - Corrected issues with category code. When a user isn't logged in, $borrower is undef and causes error when determining category code. Added conditional check. - Properly trigger all changes in C4/Search.pm - Fix QA Test tool failures C4/Search.pm had some tabs. - Add some commenting to make sense of logic - Refactor EmbedItemsInMarcBiblio parameters to hashref - Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call. prove t/db_dependent/Items.t - Add missing test to trigger Koha/BiblioUtils/Iterator change - Add borrower category overrides These files generally add borcat parameter to GetMarcBiblio. Others might include correction of filtering of items (opac-basket), or a comment as to why no changes were done (opac-search). In the case of opac-search, correcting the first FIXME will likely correct the OpacHiddenItems issues on tags. As such, that is beyond this bugs scope. Some code had loop optimizations and fixes made, like a 'next unless $record' when the biblio shouldn't even be in the list. - Modify opac-ISBDdetail and opac-MARCdetail Both files had similar logic. They were rearranged and optimized, so that both files would have practically identical initial blocks of code. Optimizations were possible, because GetMarcBiblio returns a filtered record, so that there is no double call (once in the opac-### file and once in GetMarcBiblio) to GetHiddenItemnumbers. - Fix hiding in opac-tags opac/opac-tags.pl was not properly hiding. There is currently one known bug associated with tags left. If you have two biblios tagged by different people with the same tag, the opac-search will show the one you tagged that is supposed to be hidden, because tag searches work differently than regular searches. This is beyond the scope of this bug. See the FIXME's in opac/opac-search.pl - Trigger the C4::ILSDI::Services changes prove t/db_dependent/ILSDI_Services.t - Added missing 'my' - Test C4/Labels/Label.pm changes - Improve C4::Record::marcrecord2csv test cases - Corrected opac-details searchResult call - Fix breaking issues constraint in ITerator test - Fix ILSDI_Services test when clubs with branch exist - Rebased again! The test plan is in comment #112 last I checked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 03:01:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 02:01:51 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72451|0 |1 is obsolete| | --- Comment #159 from M. Tompsett --- Created attachment 72452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72452&action=edit Bug 14385: Squash of a lot of patches rebased - Added missing GetHiddenItems parameter change case Without this prove t had a failure. - Always use mocks, not set_preference - Tweaks so t/db_dependent/00-strict.t passes There was a typo botcat vs borcat and borrowernumber was never defined. Grabbing from userenv, like other code does. - Tweak t/db_dependent/Items.t to fully test changes This will test all the if structures fully in GetHiddenItemnumbers. prove t/db_dependent/Items.t - Tweak borrower category code $borrower->{categorycode} on a Koha::Patron is not the same as $borrower->categorycode. Fixed error. - Search was returning URLS for wrong interface There was one search context place wrong. Changed it to $is_opac as the logic for setting $is_opac was modified correctly. - Corrected issues with category code. When a user isn't logged in, $borrower is undef and causes error when determining category code. Added conditional check. - Properly trigger all changes in C4/Search.pm - Fix QA Test tool failures C4/Search.pm had some tabs. - Add some commenting to make sense of logic - Refactor EmbedItemsInMarcBiblio parameters to hashref - Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call. prove t/db_dependent/Items.t - Add missing test to trigger Koha/BiblioUtils/Iterator change - Add borrower category overrides These files generally add borcat parameter to GetMarcBiblio. Others might include correction of filtering of items (opac-basket), or a comment as to why no changes were done (opac-search). In the case of opac-search, correcting the first FIXME will likely correct the OpacHiddenItems issues on tags. As such, that is beyond this bugs scope. Some code had loop optimizations and fixes made, like a 'next unless $record' when the biblio shouldn't even be in the list. - Modify opac-ISBDdetail and opac-MARCdetail Both files had similar logic. They were rearranged and optimized, so that both files would have practically identical initial blocks of code. Optimizations were possible, because GetMarcBiblio returns a filtered record, so that there is no double call (once in the opac-### file and once in GetMarcBiblio) to GetHiddenItemnumbers. - Fix hiding in opac-tags opac/opac-tags.pl was not properly hiding. There is currently one known bug associated with tags left. If you have two biblios tagged by different people with the same tag, the opac-search will show the one you tagged that is supposed to be hidden, because tag searches work differently than regular searches. This is beyond the scope of this bug. See the FIXME's in opac/opac-search.pl - Trigger the C4::ILSDI::Services changes prove t/db_dependent/ILSDI_Services.t - Added missing 'my' - Test C4/Labels/Label.pm changes - Improve C4::Record::marcrecord2csv test cases - Corrected opac-details searchResult call - Fix breaking issues constraint in ITerator test - Fix ILSDI_Services test when clubs with branch exist - Rebased again! The test plan is in comment #112 last I checked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 03:17:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 02:17:15 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72452|0 |1 is obsolete| | --- Comment #160 from M. Tompsett --- Created attachment 72453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72453&action=edit Bug 14385: Squash of a lot of patches rebased - Added missing GetHiddenItems parameter change case Without this prove t had a failure. - Always use mocks, not set_preference - Tweaks so t/db_dependent/00-strict.t passes There was a typo botcat vs borcat and borrowernumber was never defined. Grabbing from userenv, like other code does. - Tweak t/db_dependent/Items.t to fully test changes This will test all the if structures fully in GetHiddenItemnumbers. prove t/db_dependent/Items.t - Tweak borrower category code $borrower->{categorycode} on a Koha::Patron is not the same as $borrower->categorycode. Fixed error. - Search was returning URLS for wrong interface There was one search context place wrong. Changed it to $is_opac as the logic for setting $is_opac was modified correctly. - Corrected issues with category code. When a user isn't logged in, $borrower is undef and causes error when determining category code. Added conditional check. - Properly trigger all changes in C4/Search.pm - Fix QA Test tool failures C4/Search.pm had some tabs. - Add some commenting to make sense of logic - Refactor EmbedItemsInMarcBiblio parameters to hashref - Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call. prove t/db_dependent/Items.t - Add missing test to trigger Koha/BiblioUtils/Iterator change - Add borrower category overrides These files generally add borcat parameter to GetMarcBiblio. Others might include correction of filtering of items (opac-basket), or a comment as to why no changes were done (opac-search). In the case of opac-search, correcting the first FIXME will likely correct the OpacHiddenItems issues on tags. As such, that is beyond this bugs scope. Some code had loop optimizations and fixes made, like a 'next unless $record' when the biblio shouldn't even be in the list. - Modify opac-ISBDdetail and opac-MARCdetail Both files had similar logic. They were rearranged and optimized, so that both files would have practically identical initial blocks of code. Optimizations were possible, because GetMarcBiblio returns a filtered record, so that there is no double call (once in the opac-### file and once in GetMarcBiblio) to GetHiddenItemnumbers. - Fix hiding in opac-tags opac/opac-tags.pl was not properly hiding. There is currently one known bug associated with tags left. If you have two biblios tagged by different people with the same tag, the opac-search will show the one you tagged that is supposed to be hidden, because tag searches work differently than regular searches. This is beyond the scope of this bug. See the FIXME's in opac/opac-search.pl - Trigger the C4::ILSDI::Services changes prove t/db_dependent/ILSDI_Services.t - Added missing 'my' - Test C4/Labels/Label.pm changes - Improve C4::Record::marcrecord2csv test cases - Corrected opac-details searchResult call - Fix breaking issues constraint in ITerator test - Fix ILSDI_Services test when clubs with branch exist - Rebased again! The test plan is in comment #112 last I checked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 03:19:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 02:19:59 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72453|0 |1 is obsolete| | --- Comment #161 from M. Tompsett --- Created attachment 72454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72454&action=edit Bug 14385: Squash of a lot of patches rebased - Added missing GetHiddenItems parameter change case Without this prove t had a failure. - Always use mocks, not set_preference - Tweaks so t/db_dependent/00-strict.t passes There was a typo botcat vs borcat and borrowernumber was never defined. Grabbing from userenv, like other code does. - Tweak t/db_dependent/Items.t to fully test changes This will test all the if structures fully in GetHiddenItemnumbers. prove t/db_dependent/Items.t - Tweak borrower category code $borrower->{categorycode} on a Koha::Patron is not the same as $borrower->categorycode. Fixed error. - Search was returning URLS for wrong interface There was one search context place wrong. Changed it to $is_opac as the logic for setting $is_opac was modified correctly. - Corrected issues with category code. When a user isn't logged in, $borrower is undef and causes error when determining category code. Added conditional check. - Properly trigger all changes in C4/Search.pm - Fix QA Test tool failures C4/Search.pm had some tabs. - Add some commenting to make sense of logic - Refactor EmbedItemsInMarcBiblio parameters to hashref - Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call. prove t/db_dependent/Items.t - Add missing test to trigger Koha/BiblioUtils/Iterator change - Add borrower category overrides These files generally add borcat parameter to GetMarcBiblio. Others might include correction of filtering of items (opac-basket), or a comment as to why no changes were done (opac-search). In the case of opac-search, correcting the first FIXME will likely correct the OpacHiddenItems issues on tags. As such, that is beyond this bugs scope. Some code had loop optimizations and fixes made, like a 'next unless $record' when the biblio shouldn't even be in the list. - Modify opac-ISBDdetail and opac-MARCdetail Both files had similar logic. They were rearranged and optimized, so that both files would have practically identical initial blocks of code. Optimizations were possible, because GetMarcBiblio returns a filtered record, so that there is no double call (once in the opac-### file and once in GetMarcBiblio) to GetHiddenItemnumbers. - Fix hiding in opac-tags opac/opac-tags.pl was not properly hiding. There is currently one known bug associated with tags left. If you have two biblios tagged by different people with the same tag, the opac-search will show the one you tagged that is supposed to be hidden, because tag searches work differently than regular searches. This is beyond the scope of this bug. See the FIXME's in opac/opac-search.pl - Trigger the C4::ILSDI::Services changes prove t/db_dependent/ILSDI_Services.t - Added missing 'my' - Test C4/Labels/Label.pm changes - Improve C4::Record::marcrecord2csv test cases - Corrected opac-details searchResult call - Fix breaking issues constraint in ITerator test - Fix ILSDI_Services test when clubs with branch exist - Rebased again! The test plan is in comment #112 last I checked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 03:26:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 02:26:09 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70256|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 03:26:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 02:26:39 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70258|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 03:26:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 02:26:24 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70257|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 03:26:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 02:26:56 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70259|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 03:28:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 02:28:03 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #162 from M. Tompsett --- Today was massive rebase, and confirm changes. Still to do: test and confirm that comment #112 is the exhaustive test plan. Sorry for the noise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 06:42:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 05:42:02 +0000 Subject: [Koha-bugs] [Bug 20085] Better translatability of smart-rules.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20085 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70877|0 |1 is obsolete| | --- Comment #4 from Fridolin SOMERS --- Created attachment 72455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72455&action=edit Bug 20085: Better translatability of smart-rules.tt Template smart-rules.tt in administration contains some if/elsif/else with translatable strings. For example : [% IF rule.onshelfholds == 1 %] Yes [% ELSIF rule.onshelfholds == 2 %] If all unavailable [% ELSE %] If any unavailable [% END %] Adding span to translatable strings will allow to have the same translation than : This is important to allow editing an existing circulation and fine rule. Actually for example in french some strings are translated differently : msgid "%s Yes %s If all unavailable %s If any unavailable %s" msgstr "%s Oui %s Si tous indisponibles %s Si aucun indisponible %s" msgid "If any unavailable" msgstr "Si au moins un exemplaire est indisponible" Test plan : 1) Look at PO files, for example fr-FR and see there is : msgid "%s Yes %s If all unavailable %s If any unavailable %s" msgid "If any unavailable" 2) Apply patch 3) update PO files 4) Look at PO files, for example fr-FR and see there is now only : msgid "If any unavailable" 5) Install translation 6) Go to Administration > Circulation and fine rule 7) Check that when editing an existing rule, edition comboboxes are set on the correct value 8) Create a default holds policy by item type and check that correct values are displayed in table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 06:43:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 05:43:27 +0000 Subject: [Koha-bugs] [Bug 20085] Better translatability of smart-rules.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20085 --- Comment #5 from Fridolin SOMERS --- (In reply to Fridolin SOMERS from comment #3) > (In reply to Jonathan Druart from comment #2) > > (In reply to Fridolin SOMERS from comment #1) > > > Also adds on "Unlimited" and "None defined" so that there are more > > > visible > > > and that there translation is more simple. > > > > Why do you want to make them more visible? I do not think it should be done > > in this patch. > > Its because there are a special case, like All for Patron category or Item > type. > > Otherwise we can use a simple span. Ok corrected, one step at the time indeed ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 07:30:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 06:30:08 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 08:13:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 07:13:46 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 08:13:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 07:13:51 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66094|0 |1 is obsolete| | Attachment #66095|0 |1 is obsolete| | Attachment #66096|0 |1 is obsolete| | Attachment #66097|0 |1 is obsolete| | Attachment #66098|0 |1 is obsolete| | Attachment #66099|0 |1 is obsolete| | Attachment #66100|0 |1 is obsolete| | Attachment #72309|0 |1 is obsolete| | --- Comment #121 from Josef Moravec --- Created attachment 72456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72456&action=edit Bug 11317: Adds a page to access log files on the server from the intranet. The directory used is defined by the "publiclogdir" preference in koha-conf.xml. Test case : Preparation : * Add the "publiclogdir" preference to your "koha-conf.xml" file. This * preference should be in the "config" section. For this test cas, we * will use the "/tmp/koha-public" directory : ... /tmp/koha-public ... * Create the log directory on your server. Make sure this directory * is readable by your web server : $ mkdir /tmp/koha-public * Add a test file in the log directory : $ cd /tmp/koha-public $ echo "Hello world!" > test.txt Test : * Go in the "Reports" section in the intranet and select "Report/log * files" * The "test.txt" should appear in the files list. * Click on the "test.txt" file, a download dialog should appear. * Download the file and verify its content. It should contain the * text "Hello world!". Sponsored by : CCSR Signed-off-by: Jonathan Druart Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 08:13:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 07:13:57 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #122 from Josef Moravec --- Created attachment 72457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72457&action=edit Bug 11317: Update ID to allow for permalinking This follow up modifies the id parameter to use a digest of the filename to enable permalinking to files even if the array order changes due to new files being created. Signed-off-by: Jonathan Druart Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 08:14:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 07:14:03 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #123 from Josef Moravec --- Created attachment 72458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72458&action=edit Bug 11317: Rename config to 'accessdir' and fix qa Also translate date with datetime format preference and move to Tools. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 08:14:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 07:14:09 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #124 from Josef Moravec --- Created attachment 72459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72459&action=edit Bug 11317: Allows for multiple directories to be accessible It is now possible to add as many SOMEDIR as needed to the config file. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 08:14:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 07:14:15 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #125 from Josef Moravec --- Created attachment 72460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72460&action=edit Bug 11317: Move file access under Tools and add specific permission - Moves the .pl and .tt under tools/ instead of reports/ and adds tools/access_files permission. - Remove datatables-strings.inc from .tt - Allow sorting on date column in file access tool. For some reason, the table was blocking sorting based on timestamp, even though most users would probably want that since the feature is used primarily to access generated (daily) reports i and finding the last ones is very important. Testing -1) Having done requirements of previous patches, like adding 'accessdir' to koha-conf... 0) apply patch, update database to add permission option. 1) Login as NON-superadmin. Go under tools, see no Report/Log under the third column 2) Go to add tools/access_file permission to user 3) See new entry under tools third column. 4) validate link is ok. Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 08:14:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 07:14:20 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #126 from Josef Moravec --- Created attachment 72461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72461&action=edit Bug 11317: Update the link under reports Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 08:14:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 07:14:25 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #127 from Josef Moravec --- Created attachment 72462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72462&action=edit Bug 11317: (Follow-up) Fixing merge error and cosmetic changes Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 08:14:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 07:14:31 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #128 from Josef Moravec --- Created attachment 72463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72463&action=edit Bug 11317: (Follow-up) File with same name in different directories now has distinct hash Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 08:14:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 07:14:36 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #129 from Josef Moravec --- Created attachment 72464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72464&action=edit Bug 11317: (Follow-up) Fix tab chars and move javascript to the footer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 08:14:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 07:14:42 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #130 from Josef Moravec --- Created attachment 72465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72465&action=edit Bug 11317: (QA follow-up) Fix datatable Fixes the link to datatables.css Fixes the footer javascript Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 08:15:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 07:15:09 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 08:18:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 07:18:35 +0000 Subject: [Koha-bugs] [Bug 20322] Circulation page layout and design update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322 --- Comment #2 from Josef Moravec --- Created attachment 72466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72466&action=edit Screenshot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 08:19:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 07:19:22 +0000 Subject: [Koha-bugs] [Bug 20322] Circulation page layout and design update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322 --- Comment #3 from Josef Moravec --- I just added a screenshot for easy review ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 08:59:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 07:59:36 +0000 Subject: [Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Signed Off |Failed QA --- Comment #27 from Josef Moravec --- Just tested now and have some issues/comments: 1) The indicators are not taken from authority to biblio, if this can add indicators, it'll take advantage of bug 14769 once it is pushed 2) cataloguing.js link in the template cataloguing/editor.tt should use [% theme %] instead of hadcoded "prog" in path. And should have attached _[% KOHA_VERSION %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 09:14:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 08:14:15 +0000 Subject: [Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 09:16:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 08:16:32 +0000 Subject: [Koha-bugs] [Bug 20322] Circulation page layout and design update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Comment on attachment 72466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72466 Screenshot I think this looks like a really good start! Really glad you took this on Liz! Some things I notice: - Maybe offline circulation would look a little nicer as some kind of box on the right? - Some icons could be added: Set library and Pending on-site checkouts. Maybe something like a house or building to indicate on-site? - Do we need the note for overdues with fines? Or could we move it to the page itself? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 10:22:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 09:22:07 +0000 Subject: [Koha-bugs] [Bug 20338] New: Preference noissuescharge should not be considered 5 when it is actually 0 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20338 Bug ID: 20338 Summary: Preference noissuescharge should not be considered 5 when it is actually 0 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When the noissuescharge is set to 0, then limit 5 is used, see FIXME comment in circ/circulation.pl after bug 19933 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 10:22:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 09:22:17 +0000 Subject: [Koha-bugs] [Bug 20338] Preference noissuescharge should not be considered 5 when it is actually 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20338 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19933 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 10:22:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 09:22:17 +0000 Subject: [Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20338 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20338 [Bug 20338] Preference noissuescharge should not be considered 5 when it is actually 0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 11:20:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 10:20:23 +0000 Subject: [Koha-bugs] [Bug 20339] New: Unify MARC21 ISBN/ISSN handling in XSL Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20339 Bug ID: 20339 Summary: Unify MARC21 ISBN/ISSN handling in XSL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at joensuu.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The code to show the ISBN and ISSN is repeated between the search results and the detail view. Create a function to show the ISBN/ISSN, and call that instead. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 11:23:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 10:23:52 +0000 Subject: [Koha-bugs] [Bug 20339] Unify MARC21 ISBN/ISSN handling in XSL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20339 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at joensuu.fi |ity.org | --- Comment #1 from paxed --- Created attachment 72467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72467&action=edit Bug 20339: Unify MARC21 ISBN/ISSN handling in XSL The code to show the ISBN and ISSN is repeated between the search results and the detail view. Create a function to show the ISBN/ISSN, and call that instead. Test plan: 1) Apply patch 2) Search for any records, check that the ISBN and ISSN are shown correctly 3) Go to biblio detail pages, check that the ISBN and ISSN are shown correctly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 11:25:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 10:25:34 +0000 Subject: [Koha-bugs] [Bug 20334] Option for escaping slashes in search queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #4 from David Gustafsson --- Ok! Yes, ready to signoff. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 11:27:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 10:27:57 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from David Gustafsson --- Just saw that a vim swap file was accidentally committed, marking as failed until I have fixed this (shortly). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 11:28:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 10:28:52 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #10 from David Gustafsson --- Wrong issue, sorry. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 11:29:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 10:29:50 +0000 Subject: [Koha-bugs] [Bug 20334] Option for escaping slashes in search queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from David Gustafsson --- Just saw that a swap file was accidentally committed, setting failed until this is fixed (later today). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 11:38:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 10:38:36 +0000 Subject: [Koha-bugs] [Bug 20340] New: Ability to use authentication plugin Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 Bug ID: 20340 Summary: Ability to use authentication plugin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: alex.arnaud at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org This enhancement intends to allow adding and use authentication plugins. A plugin can be enabled with a system preference (AuthenticationModule) and placed in the -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 11:42:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 10:42:11 +0000 Subject: [Koha-bugs] [Bug 7960] choice to not show the text labels for item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #12 from Fridolin SOMERS --- > add a class to make it easy to hide with css. +1 Not another system preference please :( Actually you may use a trick by painting text with background color : #holdings_table .itype { color: #F3F3F3; } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 11:44:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 10:44:37 +0000 Subject: [Koha-bugs] [Bug 7960] choice to not show the text labels for item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 --- Comment #13 from Fridolin SOMERS --- Or maybe one could change the existing preference noItemTypeImages to use choices : image and text, image only, text only. My2c -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 12:21:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 11:21:39 +0000 Subject: [Koha-bugs] [Bug 20341] New: Show authorized value description for withdrawn like damaged and lost Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20341 Bug ID: 20341 Summary: Show authorized value description for withdrawn like damaged and lost Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Actually catalog detail page shows for damaged and lost items the authorized value description if exists. We must do the same for withdrawn information. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 12:21:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 11:21:55 +0000 Subject: [Koha-bugs] [Bug 11280] Change Withdrawn toggle to drop down selection of authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11280 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20341 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20341 [Bug 20341] Show authorized value description for withdrawn like damaged and lost -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 12:22:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 11:22:05 +0000 Subject: [Koha-bugs] [Bug 20341] Show authorized value description for withdrawn like damaged and lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20341 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15922 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 12:22:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 11:22:05 +0000 Subject: [Koha-bugs] [Bug 15922] Show authorized value description in staff client search results for lost, withdrawn, and damaged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20341 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 12:21:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 11:21:55 +0000 Subject: [Koha-bugs] [Bug 20341] Show authorized value description for withdrawn like damaged and lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20341 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11280 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11280 [Bug 11280] Change Withdrawn toggle to drop down selection of authorized values -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 12:24:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 11:24:12 +0000 Subject: [Koha-bugs] [Bug 15922] Show authorized value description in staff client search results for lost, withdrawn, and damaged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #11 from Fridolin SOMERS --- (In reply to Owen Leonard from comment #6) > (In reply to Jonathan Druart from comment #5) > > I personally think we should fix all of them at the same time. > > I'd be happy to submit a follow-up for moredetail.tt and detail.tt. > > > Yes, but for these 3 ones I am pretty sure everybody keeps the default value. > > This bug exists because we use more than just the default value for lost, > and damaged and we want to see those locally-defined values. Bug 11280 shows > that there was a need for withdrawn to be the same. > > > catalogue/detail.tt > > 662 [% IF ( item.withdrawn ) %] > > 663 Withdrawn > > 664 [% END %] > > catalogue/detail.tt already shows the authorized value description for lost > and damaged. That it doesn't do so for withdrawn is a bug which should have > been fixed by Bug 11280. I propose Bug 20341 for that. The idea is to just implement for withdrawn the same behavior as lost and damaged. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 12:25:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 11:25:23 +0000 Subject: [Koha-bugs] [Bug 20341] Show authorized value description for withdrawn like damaged and lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20341 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 12:35:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 11:35:19 +0000 Subject: [Koha-bugs] [Bug 20341] Show authorized value description for withdrawn like damaged and lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20341 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 12:35:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 11:35:22 +0000 Subject: [Koha-bugs] [Bug 20341] Show authorized value description for withdrawn like damaged and lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20341 --- Comment #1 from Fridolin SOMERS --- Created attachment 72468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72468&action=edit Bug 20341: Show authorized value description for withdrawn like damaged and lost Actually catalog detail page shows for damaged and lost items the authorized value description if exists. We must do the same for withdrawn information. Test plan : 1) Set for items a subfield linked to items.withdrawn and using the authorized value category 'WITHDRAWN' 2) Edit the authorized value category to add value '2' and description 'Eaten by dog' 3) Edit an item to set this withdrawn value 4) Go to staff interface and look at items in record detail page /cgi-bin/koh/catalogue/detail.pl : => Without patch you see 'Withdrawn' and with patch you see 'Eaten by dog' 5) Go to OPAc and look at items in record detail page /cgi-bin/koha/opac-detail.pl : => Without patch you see 'Withdrawn' and with patch you see 'Eaten by dog' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 12:36:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 11:36:10 +0000 Subject: [Koha-bugs] [Bug 20341] Show authorized value description for withdrawn like damaged and lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20341 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 12:45:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 11:45:57 +0000 Subject: [Koha-bugs] [Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 --- Comment #14 from Josef Moravec --- Comment on attachment 72442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72442 Bug 19469: Add ability to split view of holds view on record by pickup library and/or itemtype Review of attachment 72442: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19469&attachment=72442) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ +1,1 @@ > +[% USE Dumper %] debug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 13:45:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 12:45:22 +0000 Subject: [Koha-bugs] [Bug 20322] Circulation page layout and design update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322 --- Comment #5 from Josef Moravec --- And I would stick with col-sm-4 to have 3 columns on small and larger displays -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 14:17:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 13:17:24 +0000 Subject: [Koha-bugs] [Bug 20340] Ability to use authentication plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 --- Comment #1 from Alex Arnaud --- Created attachment 72469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72469&action=edit Bug 20340 - Ability to add and use authentication plugins Plugins must be placed in and enabled with AuthenticationModule system preference. Test plan: - Apply this patch and update your database, - set UseKohaPlugins to enabled, - define a pluginsdir in your koha-conf.xml, - put a plugin in this directory. - I.e, take the one provided in tests directory: - t/Koha/Plugin/TestAuth.pm, - login/pass is test/test - You should have: /your/plugins/dir/Koha/Plugin/TestAuth.pm, - replace default by your plugin in AuthenticationModule system preference, - test authentication with and without the plugin. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 14:20:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 13:20:02 +0000 Subject: [Koha-bugs] [Bug 20340] Ability to use authentication plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 14:34:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 13:34:11 +0000 Subject: [Koha-bugs] [Bug 20341] Show authorized value description for withdrawn like damaged and lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20341 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at biblibre.com Status|Needs Signoff |Signed Off --- Comment #2 from sandboxes at biblibre.com --- Patch tested with a sandbox, by delaye -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 14:34:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 13:34:25 +0000 Subject: [Koha-bugs] [Bug 20341] Show authorized value description for withdrawn like damaged and lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20341 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72468|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 14:34:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 13:34:33 +0000 Subject: [Koha-bugs] [Bug 20341] Show authorized value description for withdrawn like damaged and lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20341 --- Comment #3 from sandboxes at biblibre.com --- Created attachment 72470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72470&action=edit Bug 20341: Show authorized value description for withdrawn like damaged and lost Actually catalog detail page shows for damaged and lost items the authorized value description if exists. We must do the same for withdrawn information. Test plan : 1) Set for items a subfield linked to items.withdrawn and using the authorized value category 'WITHDRAWN' 2) Edit the authorized value category to add value '2' and description 'Eaten by dog' 3) Edit an item to set this withdrawn value 4) Go to staff interface and look at items in record detail page /cgi-bin/koh/catalogue/detail.pl : => Without patch you see 'Withdrawn' and with patch you see 'Eaten by dog' 5) Go to OPAc and look at items in record detail page /cgi-bin/koha/opac-detail.pl : => Without patch you see 'Withdrawn' and with patch you see 'Eaten by dog' Signed-off-by: delaye -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 15:01:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 14:01:15 +0000 Subject: [Koha-bugs] [Bug 20334] Option for escaping slashes in search queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72435|0 |1 is obsolete| | --- Comment #6 from David Gustafsson --- Created attachment 72471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72471&action=edit Bug 20334 - Option for escaping slashes in search queries Add "QueryRegexEscapeOption" system preference to provide option to escape Elasticsearch regexp delimiters (/) within queries, or alternativly to unescape escaped slashes (\/) while escaping unescaped slashes, in effect making "\/" the new regexp delimiter. How to test: 1) Run tests in ./t/Koha/SearchEngine/ElasticSearch/QueryBuilder.t 2) All tests should succeed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 15:02:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 14:02:01 +0000 Subject: [Koha-bugs] [Bug 20334] Option for escaping slashes in search queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 15:06:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 14:06:32 +0000 Subject: [Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72350|0 |1 is obsolete| | Attachment #72351|0 |1 is obsolete| | Attachment #72352|0 |1 is obsolete| | Attachment #72353|0 |1 is obsolete| | Attachment #72354|0 |1 is obsolete| | Attachment #72355|0 |1 is obsolete| | Attachment #72356|0 |1 is obsolete| | --- Comment #23 from Josef Moravec --- Created attachment 72472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72472&action=edit Bug 19933: Remove patronflags - unused vars oldamount/amountold in circulation.pl There is oldamound/amountold variable that is sent to the template but never used later. Let remove it now to avoid useless replacement. Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 15:06:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 14:06:29 +0000 Subject: [Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 15:06:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 14:06:35 +0000 Subject: [Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 --- Comment #24 from Josef Moravec --- Created attachment 72473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72473&action=edit Bug 19933: Remove patronflags - In CanBookBeIssued The change is trivial here, we only want to pass gonenoaddress, lost and is_debared to the template. Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 15:06:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 14:06:41 +0000 Subject: [Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 --- Comment #26 from Josef Moravec --- Created attachment 72475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72475&action=edit Bug 19933: Remove patronflags - tricky ones Here we are, patronflags is used in a couple of places where (almost) all flags were really useful: C4::SIP::ILS::Patron->new and circulation.pl This patch only deal with the circulation code as I am not convident enough with SIP code. The change does not seems trivial because of the complexity of the existing code, but the logic is the same. We send a variable to the template depending on the situation of the patron. I guess only code eyes ball could catch issue in this patch quickly. Maybe we need to find a good place in a Koha module to move this code and provide code coverage (especially when C4::SIP::ILS::Patron will reuse it). Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 15:06:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 14:06:38 +0000 Subject: [Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 --- Comment #25 from Josef Moravec --- Created attachment 72474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72474&action=edit Bug 19933: Remove patronflags - easy ones This patch replaces the easy occurrences of patronflags. These calls only need the CHARGES->amount value, that is the non issues charges. Luckily we now have a Koha::Account->non_issues_charges that deal with that. Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 15:06:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 14:06:45 +0000 Subject: [Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 --- Comment #27 from Josef Moravec --- Created attachment 72476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72476&action=edit Bug 19933: (follow-up) Remove patronflags - easy ones Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 15:06:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 14:06:48 +0000 Subject: [Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 --- Comment #28 from Josef Moravec --- Created attachment 72477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72477&action=edit Bug 19933: Move instantiation of in deletemem.pl Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 15:06:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 14:06:51 +0000 Subject: [Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 --- Comment #29 from Josef Moravec --- Created attachment 72478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72478&action=edit Bug 19933: Fix typo in template plugin name Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 15:19:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 14:19:08 +0000 Subject: [Koha-bugs] [Bug 20167] Item hold is set to bibliographic hold when changing pickup location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20167 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 15:19:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 14:19:11 +0000 Subject: [Koha-bugs] [Bug 20167] Item hold is set to bibliographic hold when changing pickup location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20167 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72436|0 |1 is obsolete| | Attachment #72437|0 |1 is obsolete| | --- Comment #4 from Claire Gravely --- Created attachment 72479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72479&action=edit Bug 20167: Regression test Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 15:19:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 14:19:14 +0000 Subject: [Koha-bugs] [Bug 20167] Item hold is set to bibliographic hold when changing pickup location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20167 --- Comment #5 from Claire Gravely --- Created attachment 72480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72480&action=edit Bug 20167: Make changing a hold pass the itemnumber to ModReserve If you have an item-level hold, changing an attribute (like priority, pickup location or suspended until date) makes the hold a biblio-level hold, because ModReserve is not passed the current itemnumber. This patch uses the hold's itemnumber and passes it to the ModReserve call. To test: - Run the regression tests from the previous patch: $ kshell k$ prove t/db_dependent/api/v1/holds.t => FAIL: Tests fail - Apply this patch - Run the tests: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 15:37:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 14:37:52 +0000 Subject: [Koha-bugs] [Bug 20342] New: Fix table locking issue, progress bar not updating, and allow use of plack for Stage MARC Import Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20342 Bug ID: 20342 Summary: Fix table locking issue, progress bar not updating, and allow use of plack for Stage MARC Import Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Have you ever seen this error? DBD::mysql::st execute failed: Deadlock found when trying to get lock; try restarting transaction [for Statement "INSERT INTO import_record_matches (import_record_id, candidate_match_id, score), Have you ever noticed your progress bar during stage for import jumps from 0% to 100% with no updates in between? Would you like stage-marc-import.pl to work under plack? If you answered yes to any of the following questions, this bug is for you! During uploads of large records using matching rules, we were getting 'Failed to submit form' popups on the marc record importer. First, I noticed that the parent process of stage-marc-import.pl wasn't returning the job id via ajax until the child process had completed. This works fine for smaller files as they process fast. For large files ( and in particular when using matching rules ) the process takes *much* longer. It appears that $.ajax will resubmit the form if it doesn't get a response back in a given time ( I would estimate that to be about 30 seconds or so ). This causes a *second* instance of stage-marc-import.pl to be run. So now we have two processes both running transactions on the same table for the same batch id. I believe this is what is causing the Deadlock. So, the crux of the matter is that for whatever reason, the parent process will not output until the child process has gone away. Hours of research entailed. The final answer is that the child process must be detached from the parent process. I tried doing this via setsid() but it did not help. Finally, I found that using Net::Server::Daemonize did! After I had my solution, I decided to see if stage-marc-import.pl and background-job-progress.pl could now be run under plack, and it appears that they can! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 15:37:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 14:37:57 +0000 Subject: [Koha-bugs] [Bug 20342] Fix table locking issue, progress bar not updating, and allow use of plack for Stage MARC Import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20342 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 15:54:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 14:54:09 +0000 Subject: [Koha-bugs] [Bug 20342] Fix table locking issue, progress bar not updating, and allow use of plack for Stage MARC Import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20342 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 15:54:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 14:54:12 +0000 Subject: [Koha-bugs] [Bug 20342] Fix table locking issue, progress bar not updating, and allow use of plack for Stage MARC Import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20342 --- Comment #1 from Kyle M Hall --- Created attachment 72481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72481&action=edit Bug 20342: Fix table locking issue, progress bar not updating, and allow use of plack for Stage MARC Import Have you ever seen this error? DBD::mysql::st execute failed: Deadlock found when trying to get lock; try restarting transaction [for Statement "INSERT INTO import_record_matches (import_record_id, candidate_match_id, score), Have you ever noticed your progress bar during stage for import jumps from 0% to 100% with no updates in between? Would you like stage-marc-import.pl to work under plack? If you answered yes to any of the following questions, this bug is for you! During uploads of large records using matching rules, we were getting 'Failed to submit form' popups on the marc record importer. First, I noticed that the parent process of stage-marc-import.pl wasn't returning the job id via ajax until the child process had completed. This works fine for smaller files as they process fast. For large files ( and in particular when using matching rules ) the process takes *much* longer. It appears that $.ajax will resubmit the form if it doesn't get a response back in a given time ( I would estimate that to be about 30 seconds or so ). This causes a *second* instance of stage-marc-import.pl to be run. So now we have two processes both running transactions on the same table for the same batch id. I believe this is what is causing the Deadlock. So, the crux of the matter is that for whatever reason, the parent process will not output until the child process has gone away. Hours of research entailed. The final answer is that the child process must be detached from the parent process. I tried doing this via setsid() but it did not help. Finally, I found that using Net::Server::Daemonize did! After I had my solution, I decided to see if stage-marc-import.pl and background-job-progress.pl could now be run under plack, and it appears that they can! Test Plan: 1) Apply this patch 2) Update /etc/koha/apache-shared-intranet-plack.conf manually, comment out the lines for stage-marc-import.pl and background-job-progress.pl 3) Restart apache, plack and memcached 4) Stage a large record in stage-marc-import.pl, use a matching rule 5) Note it works! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 16:05:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 15:05:41 +0000 Subject: [Koha-bugs] [Bug 20343] New: Show number of checkouts by itemtype in circulation.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20343 Bug ID: 20343 Summary: Show number of checkouts by itemtype in circulation.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Circulation Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It is sometimes useful to have the number of checkouts grouped by itemtype (to see if we're approaching the maximum number of checkouts allowed for instance). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 16:06:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 15:06:25 +0000 Subject: [Koha-bugs] [Bug 20343] Show number of checkouts by itemtype in circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20343 --- Comment #1 from Julian Maurice --- Created attachment 72482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72482&action=edit Bug 20343: Show number of checkouts by itemtype in circulation.pl It is sometimes useful to have the number of checkouts grouped by itemtype (to see if we're approaching the maximum number of checkouts allowed for instance). This patch adds this information above the checkouts table, in circ/circulation.pl Test plan: 1. Check out some items with various item types to a patron 2. In circ/circulation.pl, click on 'Show checkouts' button to display the table 3. Notice the line "Number of checkouts by item type" above the table, click on it 4. See that the list of item types is displayed with a count in front of each one 5. Compare the numbers to the checkouts in the table and verify that the numbers are correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 16:06:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 15:06:34 +0000 Subject: [Koha-bugs] [Bug 20343] Show number of checkouts by itemtype in circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20343 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 16:43:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 15:43:47 +0000 Subject: [Koha-bugs] [Bug 20342] Fix table locking issue, progress bar not updating, and allow use of plack for Stage MARC Import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20342 --- Comment #2 from Kyle M Hall --- Created attachment 72483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72483&action=edit Bug 20342: Use File::Temp to get temp dir -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 16:46:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 15:46:57 +0000 Subject: [Koha-bugs] [Bug 14962] Temp Shelving Location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #9 from Christopher Brannon --- The biggest issue for us on items on display is handling. We can certainly define locations for displays. And Koha now has the ability to automatically update information (like reset a location) after a prescribed length of time. That was one of the troublesome areas that Koha has solved (thank you!). The problem still at hand is how to get staff to know where to shelve the item if it is supposed to be on display. When an item is checked in, unless there is some special marking on the book (which really defeats the purpose of Koha automatically updating locations so staff don?t have to), how do staff know to shelve it in the display rather than its normal location? The best answer would be to have a popup for items in specific locations on check in. This would alert staff, and they would either place the item in a special pile or place a bookmark in it or something at that time so they know to shelve it elsewhere. As long as we have to manually process the book in some way in order to keep it in a special location, it remains a chore that current automated processes that Koha has can?t handle quite yet. We are close, but there are still some minor kinks to work out. Ideally, it would be great if you had a display module to check items in on. It would ask where you want to display the item, and for how long. Then the module would temporarily move the item to the new location, setup a rule to change it back after the time is up, and would alert staff of the temporary location when checked in at the home location. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 16:58:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 15:58:34 +0000 Subject: [Koha-bugs] [Bug 20344] New: Transferring an item while on hold results in a transfer were the destination is the same as the source Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20344 Bug ID: 20344 Summary: Transferring an item while on hold results in a transfer were the destination is the same as the source Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: victor.grousset at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com 1. Check out an item 2. Place a hold on the specific item with a pickup at a different branch 3. Check in: Confirm hold and transfert 4. Check the branchtransfers table to ensure that the transfert is here SELECT * FROM branchtransfers order by datesent DESC LIMIT 10; 5. Home ? Circulation ? Transfers 6. Create a transfer identical as the existing one 7. You should see ?Item is already at destination library.? 8. Check the branchtransfers table 1. First one should have been canceled ?Canceled, new transfer from A to A created? 2. Another one should have been created from A to A 3. These 2 things are the issue. Because doing the same without a hold - doesn't create a new transfer - doesn't cancel the first one -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 17:01:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 16:01:51 +0000 Subject: [Koha-bugs] [Bug 14962] Temp Shelving Location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 17:05:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 16:05:14 +0000 Subject: [Koha-bugs] [Bug 14962] Temp Shelving Location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #10 from Owen Leonard --- See also: Bug 6615 - Add shelving location option to transfers page. I think it would be useful to be able to transfer books from one shelving location to another without granting staff batch item modification permission. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 18:10:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 17:10:28 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8822 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 18:10:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 17:10:28 +0000 Subject: [Koha-bugs] [Bug 8822] public calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8822 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17015 CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 18:14:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 17:14:15 +0000 Subject: [Koha-bugs] [Bug 16357] Plack error logs are not time stamped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #15 from Lari Taskula --- It seems that $SIG{__DIE__} catches dies inside eval blocks, thus generating a lot of useless "fatal" noise about missing modules inside some dependencies, such as Mojolicious. Perhaps another approach needs to be considered. I'm currently looking at Plack::Middleware::Log4perl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 18:21:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 17:21:47 +0000 Subject: [Koha-bugs] [Bug 20322] Circulation page layout and design update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322 --- Comment #6 from Owen Leonard --- Created attachment 72484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72484&action=edit Bug 20322 (follow-up) Circulation page layout and design update This follow-up makes some suggestions about how to push this further: - Put content in four columns which reduces to two on smaller screens - Adjust font size of large links - Move Offline Circulation links into its own column - Add image icons to the Firefox extension and Windows application download links - Improve indentation in template -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 18:22:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 17:22:05 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69903|0 |1 is obsolete| | --- Comment #66 from Benjamin Rokseth --- Created attachment 72486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72486&action=edit Bug 15516 - Holding first available item from x biblios only count 1 reserve Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 18:21:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 17:21:57 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69902|0 |1 is obsolete| | --- Comment #65 from Benjamin Rokseth --- Created attachment 72485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72485&action=edit Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library have the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. This patch is only for staff interface. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Enter a patron cardnumber and click Search 3. Check the box for 'Place a hold on the next available item' (it's usually hidden when placing a hold on multiple biblios) 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a reserve group)' in Details column. 6. Click on the "reserve group" link. A modal window should appear with the content of the reserve group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "reserve group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 18:22:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 17:22:13 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69904|0 |1 is obsolete| | --- Comment #67 from Benjamin Rokseth --- Created attachment 72487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72487&action=edit Bug 15516: Update old_reserves (reserve_group_id) Without it, deletion of reserves will fail Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 18:22:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 17:22:20 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69905|0 |1 is obsolete| | --- Comment #68 from Benjamin Rokseth --- Created attachment 72488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72488&action=edit Bug 15516: Set reserve-group.pl to be executable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 18:22:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 17:22:26 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69906|0 |1 is obsolete| | --- Comment #69 from Benjamin Rokseth --- Created attachment 72489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72489&action=edit Bug 15516: Reword 'reserve group' to 'hold group' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 18:23:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 17:23:21 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #70 from Benjamin Rokseth --- rebased against master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 18:23:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 17:23:43 +0000 Subject: [Koha-bugs] [Bug 20322] Circulation page layout and design update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322 --- Comment #7 from Owen Leonard --- Created attachment 72490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72490&action=edit Screenshot showing follow-up changes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 18:31:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 17:31:01 +0000 Subject: [Koha-bugs] [Bug 20344] Transferring an item while on hold results in a transfer were the destination is the same as the source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20344 --- Comment #1 from Victor Grousset/tuxayo --- Same behavior on 17.11.03 On 16.11.15, step 8: The first hold isn't cancelled, creating a duplicate transfert (without the same destinations). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 18:31:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 17:31:36 +0000 Subject: [Koha-bugs] [Bug 20344] Transferring an item while on hold results in a transfer were the destination is the same as the source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20344 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 18:51:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 17:51:14 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72489|0 |1 is obsolete| | --- Comment #71 from Benjamin Rokseth --- Created attachment 72491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72491&action=edit Bug 15516: Reword 'reserve group' to 'hold group' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 18:52:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 17:52:37 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #72 from Benjamin Rokseth --- added missing file hold-group-modal.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 19:12:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 18:12:33 +0000 Subject: [Koha-bugs] [Bug 17468] Remove koha-*-zebra scripts in favor of koha-zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 19:12:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 18:12:36 +0000 Subject: [Koha-bugs] [Bug 17468] Remove koha-*-zebra scripts in favor of koha-zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71885|0 |1 is obsolete| | Attachment #71886|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall --- Created attachment 72492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72492&action=edit Bug 17468: Remove koha-*-zebra scripts and its traces This patch removes traces from the (deprecated) koha-*-zebra scripts. To test: - Apply the patch - Verify no traces of koha-*-zebra remain on the codebase (besides Release Notes and the koha-zebra script): $ cd kohaclone $ git grep koha-start-zebra $ git grep koha-stop-zebra $ git grep koha-restart-zebra => SUCCESS: No traces! - Create the following symlinks: $ sudo ln -s /usr/sbin/koha-zebra /usr/sbin/koha-start-zebra $ sudo ln -s /usr/sbin/koha-zebra /usr/sbin/koha-stop-zebra $ sudo ln -s /usr/sbin/koha-zebra /usr/sbin/koha-restart-zebra - Try the koha-*-zebra commands: $ sudo koha-stop-zebra kohadev $ sudo koha-start-zebra kohadev $ sudo koha-restart-zebra kohadev => SUCCESS: They all work as expected! - Sign off :-D! Sponsored-by: Orex Digital Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 19:12:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 18:12:45 +0000 Subject: [Koha-bugs] [Bug 17468] Remove koha-*-zebra scripts in favor of koha-zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 19:29:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 18:29:39 +0000 Subject: [Koha-bugs] [Bug 20336] Add a generic way for Koha::Object(s) to call logaction as required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20336 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 19:30:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 18:30:24 +0000 Subject: [Koha-bugs] [Bug 18909] Enable the maximum zebra records size to be specified per instance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18909 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64915|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 72493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72493&action=edit Bug 18909 - Enable the maximum zebra records size to be specified per instance The default for Zebra is to not return results where the record size is greater than 1045 KB ( 1 MB ). Some libraries need to increase this ceiling, but it may come at a cost with z39.50 compatibility with other services. For that reason, we should make this setting configurable on a per-instance basis. Test Plan: 1) Apply this patch 2) Build a Debian package 3) Specify a zebra_max_record_size of 2048 in your koha_conf.xml 4) Restart zebra 5) Index a record greater than 1 MB but smaller than 2 MB 6) Note that it is searchable! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 19:31:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 18:31:02 +0000 Subject: [Koha-bugs] [Bug 20344] Transferring an item while on hold results in a transfer were the destination is the same as the source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20344 --- Comment #2 from Victor Grousset/tuxayo --- == Simpler test plan == On master. 1. Place a hold 2. Transfer the item twice (wherever, it can be the same transfer) 3. Check the branchtransfers table SELECT * FROM branchtransfers order by datesent DESC LIMIT 10; 4. First one should have been canceled ?Canceled, new transfer from A to A created? 5. Another one should have been created from A to A 6. These 2 things are the issue. Because doing the same without a hold - doesn't create a new transfer - doesn't cancel the first one -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 19:40:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 18:40:24 +0000 Subject: [Koha-bugs] [Bug 20345] New: Put saved report keyword search form on reports home Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20345 Bug ID: 20345 Summary: Put saved report keyword search form on reports home Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Reports Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org We have a quick search form for system preferences on the administration page. I think we should have the same on the reports home page for saved reports. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 19:43:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 18:43:24 +0000 Subject: [Koha-bugs] [Bug 20045] Switch single-column templates to Bootstrap grid: Various In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20045 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20345 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20345 [Bug 20345] Put saved report keyword search form on reports home -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 19:43:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 18:43:24 +0000 Subject: [Koha-bugs] [Bug 20345] Put saved report keyword search form on reports home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20345 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20045 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20045 [Bug 20045] Switch single-column templates to Bootstrap grid: Various -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 19:44:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 18:44:48 +0000 Subject: [Koha-bugs] [Bug 15277] Add Template Toolkit syntax for slips and notices to editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15277 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 19:52:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 18:52:54 +0000 Subject: [Koha-bugs] [Bug 20345] Put saved report keyword search form on reports home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20345 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 19:52:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 18:52:56 +0000 Subject: [Koha-bugs] [Bug 20345] Put saved report keyword search form on reports home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20345 --- Comment #1 from Owen Leonard --- Created attachment 72494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72494&action=edit Bug 20345: Put saved report keyword search form on reports home This patch makes cosmetic changes to the reports home page in the staff client following the pattern set on the Administration home page with the system preferences search box. A reports keyword search form is added, and reports actions have font-awesome icons. To test, apply the patch and view the reports home page. Confirm that all affected links work correctly and that the search form works correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 20:10:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 19:10:11 +0000 Subject: [Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because field is required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #21 from Barton Chittenden --- I would like to see this back-ported, if possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 23:41:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 22:41:52 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow to reserve first |Allow to place a hold on |available item from a group |first available item from a |of titles |group of titles -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 23:43:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 22:43:20 +0000 Subject: [Koha-bugs] [Bug 10047] Cataloguing search maybe useless? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10047 Agnes Rivers-Moore changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm at hanover.ca --- Comment #11 from Agnes Rivers-Moore --- Just in case anyone ever revisits this one... As a librarian, having the reservoir separate is a benefit to non-cataloguing staff. When cataloguers search they expect to find records that are not in library stock. For other staff it is confusing to read through multiple variations of a title, looking for the one that has a live item. For that reason reservoir records need to be filtered out from staff searches somehow. >From the technical standpoint, there may be advantages in not loading lots of records to Zebra/Elasticsearch and having system resources spent on fully indexing them, when they may never be added as stock. Z39.50 loads MARC records for all search hits to reservoir. Cataloguers pick one variant, but the rest live on in reservoir until cleaned out. From experience, the reservoir can become larger than the library stock database in as little as a year or so, depending on cataloguing practice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 6 23:51:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 22:51:19 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 00:01:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Mar 2018 23:01:14 +0000 Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756 Agnes Rivers-Moore changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm at hanover.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 04:07:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 03:07:46 +0000 Subject: [Koha-bugs] [Bug 17218] New list add attempt while logged in as dbadmin on staff side should be prevented pre-emptively In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17218 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 04:07:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 03:07:49 +0000 Subject: [Koha-bugs] [Bug 17218] New list add attempt while logged in as dbadmin on staff side should be prevented pre-emptively In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17218 --- Comment #11 from Aleisha Amohia --- Created attachment 72495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72495&action=edit Bug 17218: [FOLLOW-UP] Removing pointless code and putting checks in missed places To test: 1) Log in as admin 2) View contents of a public list 3) Click drop-down for 'Add to' - there should be no [New list] option 4) Click on an item in the list 5) Click drop-down for 'Add to' in nav bar, click List 6) There should be no option to add a new list in the pop-up window 7) Do a catalog search that will return multiple results 8) Click drop-down for 'Add to list' - there should be no New list option Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 05:54:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 04:54:40 +0000 Subject: [Koha-bugs] [Bug 20346] New: Patron filtering resulting in new search rather than filtering existing results Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20346 Bug ID: 20346 Summary: Patron filtering resulting in new search rather than filtering existing results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: alexbuckley at catalyst.net.nz Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com After getting a range of results from a patron search on the members/members-home.pl if you use the patron filtering a new search is performed rather than the existing results of the first search being filtered down. This makes finding a user in a institution with a large number of similarly named patrons very difficult. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 06:25:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 05:25:32 +0000 Subject: [Koha-bugs] [Bug 20346] Patron filtering resulting in new search rather than filtering existing results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20346 --- Comment #1 from Alex Buckley --- Created attachment 72496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72496&action=edit Bug 20346 - Server side patron filtering implemented Server side (in the svc/members/search file) perl logic for filtering results returned from patron searches checks all patron data fields for a match with the filter value. This filtering works in the following steps: when filtering is initiated the original search using the original search query is run again and then the filter value is used to filter the resulting data, thereby using both the search and filter values to easily find a patron. The submitted filter value is automatically checked against every patron value in every patron record returned from the search and so there is no need for a specific data value to be selected with the select dropdown box id=searchfieldstype_filter and so that select dropdown has been removed due to this redundancy. This filter works for both filtering based on finding a match containing the filter value and, filtering based on finding a match starting with the filter value. Test plan: 1. Go to /members/members-home.pl and create 4 users. Make them all have the same first and last name but vary the homebranch, email addresses and dates of birth 2. Perform a search by writing in the first and last name combination shared by the 4 users and you should get 4 results 3. Filter by writing in the email adrr Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 07:19:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 06:19:51 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at joensuu.fi --- Comment #73 from paxed --- Comment on attachment 72485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72485 Bug 15516: Allow to reserve first available item from a group of titles Couple tiny nitpicks: 1) the JS translation function should have the string in double quotes, so instead of _('Loading'), use _("Loading") 2) Having separate translatable strings for PART_OF_A and HOLD_GROUP isn't optimal, because those two always go together. It should perhaps be written as PART_OF_HOLD_GROUP = _("(part of a %shold group%s)") and then replace the placeholders with the html code. Even better would be to avoid the html in the middle of the sentence altogether, by making the whole sentence a link. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 08:08:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 07:08:32 +0000 Subject: [Koha-bugs] [Bug 12460] Search history: Combine to start a new search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Andreas Jonsson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.jonsson at kreablo.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 08:24:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 07:24:46 +0000 Subject: [Koha-bugs] [Bug 20340] Ability to use authentication plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17489 --- Comment #2 from Katrin Fischer --- I like the idea of this, but with more and more functionality being moved into plugins, I think we really need to make them translatable - bug 17489. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 08:24:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 07:24:46 +0000 Subject: [Koha-bugs] [Bug 17489] Allow Koha plugins to have translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17489 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20340 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 08:25:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 07:25:37 +0000 Subject: [Koha-bugs] [Bug 8822] Public calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8822 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|public calendar |Public calendar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 08:30:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 07:30:13 +0000 Subject: [Koha-bugs] [Bug 14319] Support for DuoSecurity 2FA Authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14319 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #2 from Magnus Enger --- Definitely +1 for 2 factor auth! If at all possible it would probably be nice to make it pluggable, to make it easy to add more two factor methods? Anyone want to crowdsource funding for this? I'd gladly chip in! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 08:39:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 07:39:39 +0000 Subject: [Koha-bugs] [Bug 20347] New: Add missing classes to search results elements Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20347 Bug ID: 20347 Summary: Add missing classes to search results elements Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at joensuu.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The MARC21 XSLT doesn't add html classes to distinguish between certain elements, and there's no way to rely on the element positioning, making it impossible to style the elements with CSS. Add the missing classes to distinguish the elements. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 08:41:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 07:41:23 +0000 Subject: [Koha-bugs] [Bug 20347] Add missing classes to search results elements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20347 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at joensuu.fi |ity.org | --- Comment #1 from paxed --- Created attachment 72497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72497&action=edit Bug 20347: Add missing classes to search results elements The MARC21 XSLT doesn't add html classes to distinguish between certain elements, and there's no way to rely on the element positioning, making it impossible to style the elements with CSS. Add the missing classes to distinguish the elements. Test plan: 1) Apply patch 2) Search for any biblios 3) Check the search result page table HTML to see that the "Publisher", "Edition", "Source", "Other title", and "Online access" are wrapped in a span with class of results_summary and one of "publisher", "edition", "source", "other_title", and "online_access" 4) Check that the search results of the elements above looks correct when compared to the other elements -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 09:20:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 08:20:10 +0000 Subject: [Koha-bugs] [Bug 20348] SIP2 patron identification fails to use userid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20348 Jose Martin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 09:19:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 08:19:46 +0000 Subject: [Koha-bugs] [Bug 20348] New: SIP2 patron identification fails to use userid Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20348 Bug ID: 20348 Summary: SIP2 patron identification fails to use userid Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: jose.i.martin.cuesta at gmail.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com The following code in C4/SIP/ILS/Patron.pm: $kp = Koha::Patrons->find( { cardnumber => $patron_id } ) or Koha::Patrons->find( { userid => $patron_id } ); should be (using || instead of or): $kp = Koha::Patrons->find( { cardnumber => $patron_id } ) || Koha::Patrons->find( { userid => $patron_id } ); It will never try to match a patron by userid. This is a bug according to Perl documentation here: https://perldoc.perl.org/perlop.html#Logical-or-and-Exclusive-Or -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 09:24:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 08:24:03 +0000 Subject: [Koha-bugs] [Bug 20348] SIP2 patron identification fails to use userid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20348 Jose Martin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 11:16:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 10:16:36 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64792|0 |1 is obsolete| | --- Comment #64 from David Gustafsson --- Created attachment 72498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72498&action=edit Bug 14957 - Rule based permission for MARC fields Add a rule based permission system for MARC field modifications. Test plan: 1. Apply this patch 2. Run updatedatabase.pl 3. Log in to staff client 4. Enable new syspref MARCPermissions 5. You should see a new link "MARC field permissions" in the "Catalog" section under "Koha administrtion". 6. Go to the "MARC field permissions" page 7. Next to the page heading ("Manage MARC field permissions") there is a button with a question mark, click this for more information about the rule system. 8. Add desired rules to the rule table, press the +-button to add. 9. Clicking the pen-icon (edit) should allow you to edit corresponding rule. 10. Clicking the x-icon should remove corresponding rule after confirmation. 11. Selecting one or more rules followed by clicking the trash-icon should remove all selected rules after confirmation. 12. To test your rules, import or in other way modify a record. 13. Check that the record was modified as defined by your rules. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 11:17:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 10:17:12 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 11:25:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 10:25:09 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at joensuu.fi --- Comment #65 from paxed --- Comment on attachment 72498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72498 Bug 14957 - Rule based permission for MARC fields $(this).attr('title', 'Invalid regular expression: ' + e.message); should be $(this).attr('title', _("Invalid regular expression: %s").format(e.message)); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 11:26:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 10:26:36 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #66 from David Gustafsson --- Attaching the patch with latest changes even though not yet ready for sign off to not block any further contributions by someone else. Since the model for how rules work has changed since the "old" version of the patch tests and help pages needs updating to reflect these changes, which has not been done. I will have time to work some more on this in about a month or so, but since the patch is functional for our library in it's current state it will not get much more love from us until then. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 11:59:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 10:59:41 +0000 Subject: [Koha-bugs] [Bug 20340] Ability to use authentication plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kyle at bywatersolutions.com --- Comment #3 from Kyle M Hall --- I think this is an excellent concept, but I don't think it is necessary to have a syspref and limit the auth pluggability to one at a time. In Koha we already essentially loop through all the enabled authentication systems ( ldap, cas, etc ). I would recommend the following: * Drop the system preference * Inside checkpw, loop through all plugins with a checkpw method, and return the first one that 'successfully' authenticates the user/password combo. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 12:02:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 11:02:20 +0000 Subject: [Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 mark.gavillet at ptfs-europe.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff Assignee|koha-bugs at lists.koha-commun |mark.gavillet at ptfs-europe.c |ity.org |om CC| |mark.gavillet at ptfs-europe.c | |om --- Comment #8 from mark.gavillet at ptfs-europe.com --- Created attachment 72499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72499&action=edit Patch for bug 18570 Adds a new subroutine to C4/Letters.pm which sends the password reset email to the borrower through the message queue immediately. To test, set the syspref "OpacResetPassword" to "allowed", create a patron with an email address in their record, then click the "Forgotten password" link on the login screen. The new subroutine will match on borrowernumber and letter_code='PASSWORD_RESET' in the message queue and process the single entry, marking it as sent. If your mail server is not enabled, check the mail server logs to see the attempted send (e.g. /var/log/exim4/mainlog) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 12:05:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 11:05:47 +0000 Subject: [Koha-bugs] [Bug 17489] Allow Koha plugins to have translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17489 --- Comment #2 from Kyle M Hall --- I think this might help us: https://github.com/gflohr/Template-Plugin-Gettext http://search.cpan.org/dist/Template-Plugin-Gettext/lib/Template/Plugin/Gettext.pod -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 12:39:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 11:39:09 +0000 Subject: [Koha-bugs] [Bug 20349] New: Software error: Can't use an undefined value as an ARRAY reference at /usr/local/lib64/perl5/DBI.pm line 2064. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20349 Bug ID: 20349 Summary: Software error: Can't use an undefined value as an ARRAY reference at /usr/local/lib64/perl5/DBI.pm line 2064. Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: Other Status: NEW Severity: critical Priority: P5 - low Component: Continuous Integration Assignee: tomascohen at gmail.com Reporter: ajmalkhan1984 at gmail.com Created attachment 72500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72500&action=edit Can't use an undefined value as an ARRAY reference at /usr/local/lib64/perl5/DBI.pm line 2064. Software error: Can't use an undefined value as an ARRAY reference at /usr/local/lib64/perl5/DBI.pm line 2064. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 12:41:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 11:41:23 +0000 Subject: [Koha-bugs] [Bug 20349] Software error: Can't use an undefined value as an ARRAY reference at /usr/local/lib64/perl5/DBI.pm line 2064. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20349 Aji changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #1 from Aji --- Have delete my backup .zip files after that have tried to login kohaadmin I can't. Please I hope any one help me. TR -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 13:04:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 12:04:49 +0000 Subject: [Koha-bugs] [Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 --- Comment #15 from Kyle M Hall --- (In reply to Josef Moravec from comment #14) > Comment on attachment 72442 [details] [review] > Bug 19469: Add ability to split view of holds view on record by pickup > library and/or itemtype > > Review of attachment 72442 [details] [review]: > ----------------------------------------------------------------- > > ::: koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt > @@ +1,1 @@ > > +[% USE Dumper %] > > debug? Yep! Followup coming! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 13:05:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 12:05:23 +0000 Subject: [Koha-bugs] [Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 --- Comment #16 from Kyle M Hall --- Created attachment 72501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72501&action=edit Bug 19469: Remove use of Dumper on request.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 13:17:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 12:17:31 +0000 Subject: [Koha-bugs] [Bug 19223] Problem with plugins and encodings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223 --- Comment #2 from Magnus Enger --- Still a problem, with Koha 17.05.06.000 and version 17.11 of the EDS plugin. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 13:27:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 12:27:10 +0000 Subject: [Koha-bugs] [Bug 20348] SIP2 patron identification fails to use userid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20348 Jose Martin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jose.i.martin.cuesta at gmail. |ity.org |com --- Comment #1 from Jose Martin --- Created attachment 72502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72502&action=edit Replaces "or" with "||" in variable assignment -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 13:37:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 12:37:37 +0000 Subject: [Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 --- Comment #9 from Tom?s Cohen Arazi --- (In reply to Kyle M Hall from comment #8) > (In reply to Jonathan Druart from comment #7) > > Yes I thought about that, but it may be problematic as we do not necessarily > > create the object for the notices only. So if we do it that way (when > > creating it) we may need to fetch it twice. > > I agree. I don't think we should have to fetch an object twice. I think the > fact that you can set read_only but not unset it is sufficient. Basically, > and object can be passed around the entire lifecycle of a script call, then > be marked read_only at the end and passed to the template. > > The *other* option would be a new_from_object method that close the passed > in object. Then you could have read_only be immutable and set on creation. I agree with either option, but we still need a way to tell which methods have/don't have side effects that should then be forbidden. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 13:53:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 12:53:00 +0000 Subject: [Koha-bugs] [Bug 20340] Ability to use authentication plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 --- Comment #4 from Alex Arnaud --- (In reply to Kyle M Hall from comment #3) > I think this is an excellent concept, but I don't think it is necessary to > have a syspref and limit the auth pluggability to one at a time. In Koha we > already essentially loop through all the enabled authentication systems ( > ldap, cas, etc ). Not sure Koha works like that. Reading the code, we switch (not loop) on the one that is enabled: Koha *or* LDAP *or* CAS with a fallback on Koha if LDAP or CAS return the code 0. > > I would recommend the following: > * Drop the system preference Anyway we need to enable/disable this module(s). So, in a dedicated administration page? In plugins-home.pl (but it is not realy built for that) ? > * Inside checkpw, loop through all plugins with a checkpw method, and return > the first one that 'successfully' authenticates the user/password combo. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 14:05:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 13:05:56 +0000 Subject: [Koha-bugs] [Bug 20340] Ability to use authentication plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 --- Comment #5 from Kyle M Hall --- (In reply to Alex Arnaud from comment #4) > (In reply to Kyle M Hall from comment #3) > > I think this is an excellent concept, but I don't think it is necessary to > > have a syspref and limit the auth pluggability to one at a time. In Koha we > > already essentially loop through all the enabled authentication systems ( > > ldap, cas, etc ). > Not sure Koha works like that. Reading the code, we switch (not loop) on the > one that is enabled: Koha *or* LDAP *or* CAS with a fallback on Koha if LDAP > or CAS return the code 0. You are correct! Not sure why I had thought that. Looks like the precedence is LDAP, CAS, Shib. I don't think that should affect my suggestion though. > > > > > I would recommend the following: > > * Drop the system preference > Anyway we need to enable/disable this module(s). So, in a dedicated > administration page? In plugins-home.pl (but it is not realy built for that) > ? > > > * Inside checkpw, loop through all plugins with a checkpw method, and return > > the first one that 'successfully' authenticates the user/password combo. I would say the plugin itself should be responsible for having controls to tell Koha if it is enabled or not. There is already precedence for this in Koha ( see bug 19173 ). For simplicity, the plugin could simply return values as if the authentication failed, for the sake of simplicity. What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 14:16:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 13:16:36 +0000 Subject: [Koha-bugs] [Bug 19223] Problem with plugins and encodings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|minor |major --- Comment #3 from Katrin Fischer --- Moving forward with plugins, I think we need to make sure that encodings are correctly handled. Upping severity. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 14:20:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 13:20:48 +0000 Subject: [Koha-bugs] [Bug 20350] New: Add column configuration to table of saved reports Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20350 Bug ID: 20350 Summary: Add column configuration to table of saved reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Reports Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org It should be possible to configure the display of columns in the saved reports table using the Colvis plugin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 14:20:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 13:20:20 +0000 Subject: [Koha-bugs] [Bug 20340] Ability to use authentication plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 --- Comment #6 from Katrin Fischer --- Hm, I think it's always possible to use local login and we have a library using both LDAP and Shibboleth... With Shibboleth you have a link to an external login page like with CAS - maybe that's where the confusion is? I think building it to support many plugins would be nice, similar to how we support multiple ILL backends, but maybe not a must. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 14:26:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 13:26:11 +0000 Subject: [Koha-bugs] [Bug 20340] Ability to use authentication plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 --- Comment #7 from Kyle M Hall --- (In reply to Katrin Fischer from comment #6) > Hm, I think it's always possible to use local login and we have a library > using both LDAP and Shibboleth... With Shibboleth you have a link to an > external login page like with CAS - maybe that's where the confusion is? I > think building it to support many plugins would be nice, similar to how we > support multiple ILL backends, but maybe not a must. You could be right. I based my reassessment on this code: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Auth.pm;h=c3ad351aa17ae73addb6612e7af2905b003647b4;hb=HEAD#l1778 That being said. We are starting to veer away from the topic of the bug ; ) If implemented the way I suggest, it would support multiple auth plugins, *and* be simpler architecturally. I think that's a win on all fronts : ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 14:27:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 13:27:32 +0000 Subject: [Koha-bugs] [Bug 19223] Problem with plugins and encodings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223 --- Comment #4 from Kyle M Hall --- (In reply to Katrin Fischer from comment #3) > Moving forward with plugins, I think we need to make sure that encodings are > correctly handled. Upping severity. The crux of the matter is the question of the bug being in Koha's plugin system, or is it a bug in the plugin? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 14:42:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 13:42:31 +0000 Subject: [Koha-bugs] [Bug 20348] SIP2 patron identification fails to use userid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20348 Jose Martin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 14:43:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 13:43:10 +0000 Subject: [Koha-bugs] [Bug 19223] Problem with plugins and encodings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223 --- Comment #5 from Magnus Enger --- (In reply to Kyle M Hall from comment #4) > The crux of the matter is the question of the bug being in Koha's plugin > system, or is it a bug in the plugin? I have seen it with more than one plugin. But those plugins might be based off each other (I know I have copied the KitchenSink plugin as a starter for my own plugins), so they might have the same bug... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 15:07:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 14:07:42 +0000 Subject: [Koha-bugs] [Bug 20349] Software error: Can't use an undefined value as an ARRAY reference at /usr/local/lib64/perl5/DBI.pm line 2064. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20349 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |INVALID --- Comment #2 from Tom?s Cohen Arazi --- Aji, please mention your issue in full detail on the users mailing list instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 15:28:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 14:28:47 +0000 Subject: [Koha-bugs] [Bug 20345] Put saved report keyword search form on reports home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20345 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 15:57:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 14:57:33 +0000 Subject: [Koha-bugs] [Bug 20322] Circulation page layout and design update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322 --- Comment #8 from Josef Moravec --- Great job Liz and Owen! I would add only one think - more left margin to links to desktop offline application and firefox add-on. It would better show that these links belong to offline circulation section IMO. What do you think? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 16:42:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 15:42:47 +0000 Subject: [Koha-bugs] [Bug 19908] Password should not be mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72189|0 |1 is obsolete| | Attachment #72190|0 |1 is obsolete| | --- Comment #18 from Josef Moravec --- Created attachment 72503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72503&action=edit Bug 19908: Password fields in edit/add patron form should respect BorrowerMandatoryField preference Test plan: 0) Do not apply the patch, note the password field is always required 1) Apply the patch 2) Try to add and edit patron with and without "password" in BorrowerMandatoryField, it should always respect this setting 3) Use "Change password" button in patron toolbar, the password field should be never required here - when leaved blank, the password is unchanged 4) Play with minPasswordLength and RequireStrongPassword preferences, to ensure they work as expected Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 16:43:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 15:43:14 +0000 Subject: [Koha-bugs] [Bug 19908] Password should not be mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 --- Comment #20 from Josef Moravec --- (In reply to Jonathan Druart from comment #16) > We should apply the same fix at the OPAC, right? > > Please fix bug number on the second patch. Bug number fixed. Where in OPAC do you think? On change password page it doesn't make sense for me and on self registration, the password field is not required a if leaved blanked, the password is generated, which is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 16:42:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 15:42:51 +0000 Subject: [Koha-bugs] [Bug 19908] Password should not be mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 --- Comment #19 from Josef Moravec --- Created attachment 72504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72504&action=edit Bug 19908: Do not use .optional in password match validation function Test plan: 0) Aplly only first patch 1) You will be able to submit a from on member-password.pl even if the passwords don't match 2) Apply this patch -> you can't be able to submit the form if the paswords don't match, but you'll be able to submit the form when password fields are blank Signed-off-by: Roch D'Amour Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 16:45:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 15:45:21 +0000 Subject: [Koha-bugs] [Bug 19908] Password should not be mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 --- Comment #21 from Josef Moravec --- (In reply to Agnes Rivers-Moore from comment #17) > Our Koha as of 17.11.03 does not generate default username for any patron > type. > Josef said 'Other categories (than org) have username generated as > "firstname.surname" if you leave it blank' - but that does not seem to be > the case any more. > Previous behaviour also assigned a default password, and that also does not > happen any more. > Result is staff have to add three fields, making them unique/matching, even > if the patron does not want an online account. > Looking forward to this being non-mandatory! Thanks. Hi Agnes, please fill a bug report about user names not generated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 16:49:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 15:49:24 +0000 Subject: [Koha-bugs] [Bug 20350] Add column configuration to table of saved reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20350 --- Comment #1 from Owen Leonard --- Created attachment 72505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72505&action=edit Bug 20350: Add column configuration to table of saved reports This patch makes changes to the saved reports template to enable a columns configuration button. Settings for the table have been added to columns_settings.yml. To test, apply the patch and go to Reports -> Use saved. - Confirm that there is a "Column visibility" button in the table's pagination toolbar. - Confirm that showing and hiding columns via the button is working correctly. - Confirm that the first, second, and last columns cannot be toggled. Go to Administration -> Columns settings. - Expand the "Reports" section. - Find "id=table_reports." - Make some selections to configure default settings of the reports table. - Return to reports and confirm that these defaults are applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 16:49:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 15:49:21 +0000 Subject: [Koha-bugs] [Bug 20350] Add column configuration to table of saved reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20350 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 16:57:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 15:57:13 +0000 Subject: [Koha-bugs] [Bug 17218] New list add attempt while logged in as dbadmin on staff side should be prevented pre-emptively In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17218 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72298|0 |1 is obsolete| | --- Comment #12 from M. Tompsett --- Created attachment 72506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72506&action=edit Bug 17218: Stop DB user from clicking 'New list' button To test: 1) Log in as DB user 2) Go to Lists -> New list 3) Attempt to create a new list 4) Notice that you are only stopped once you've submitted the form 5) Go back to lists, apply patch and refresh page 6) Notice the 'New list' button is now disabled 7) Click it and confirm alert shows up Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 16:57:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 15:57:16 +0000 Subject: [Koha-bugs] [Bug 17218] New list add attempt while logged in as dbadmin on staff side should be prevented pre-emptively In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17218 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72299|0 |1 is obsolete| | --- Comment #13 from M. Tompsett --- Created attachment 72507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72507&action=edit Bug 17218: [FOLLOW-UP] Stop DB user from adding list by forcing URL To test: 1) Go to the url /virtualshelves/shelves.pl?op=add_form&referer=add_form 2) Confirm an error message shows and the Save button cannot be clicked Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 16:57:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 15:57:18 +0000 Subject: [Koha-bugs] [Bug 17218] New list add attempt while logged in as dbadmin on staff side should be prevented pre-emptively In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17218 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72495|0 |1 is obsolete| | --- Comment #14 from M. Tompsett --- Created attachment 72508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72508&action=edit Bug 17218: [FOLLOW-UP] Removing pointless code and putting checks in missed places To test: 1) Log in as admin 2) View contents of a public list 3) Click drop-down for 'Add to' - there should be no [New list] option 4) Click on an item in the list 5) Click drop-down for 'Add to' in nav bar, click List 6) There should be no option to add a new list in the pop-up window 7) Do a catalog search that will return multiple results 8) Click drop-down for 'Add to list' - there should be no New list option Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 16:59:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 15:59:21 +0000 Subject: [Koha-bugs] [Bug 17218] New list add attempt while logged in as dbadmin on staff side should be prevented pre-emptively In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17218 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #15 from M. Tompsett --- NOTE: Javascript error, text/javascript in script tag not necessary for HTML5, and unless can get alert working I'll live with the disorienting click loading a page from a disabled button. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:13:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:13:49 +0000 Subject: [Koha-bugs] [Bug 20351] New: Subscription detail page with non-existent subscriptionid shows empty subscription Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20351 Bug ID: 20351 Summary: Subscription detail page with non-existent subscriptionid shows empty subscription Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: mbugz2 at yahoo.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com When you go to subscription details, like cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=108 and use a subscriptionid which is not in the subscriptions table you get an empty subscription item, but should get a page telling you the subscription doesn't exist. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:18:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:18:49 +0000 Subject: [Koha-bugs] [Bug 20045] Switch single-column templates to Bootstrap grid: Various In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20045 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70760|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 72509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72509&action=edit Bug 20045: Switch single-column templates to Bootstrap grid: Various This patch updates various unrelated templates to use the Bootstrap grid. - about.tt - The about page - auth.tt - The login page These pages should look correct. - reports/reports-home.tt - The reports home page - admin/admin-home.tt - The administration home page These pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. - serials/subscription-add.tt - Serials -> Add subscription. The entry form should look correct during each step of the add/edit process. - suggestion/suggestion.tt - Acquisitions -> Suggestions -> New suggestion. The page with the new suggestion form should look correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:27:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:27:34 +0000 Subject: [Koha-bugs] [Bug 19983] Switch single-column templates to Bootstrap grid: Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70693|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 72510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72510&action=edit Bug 19983: Switch single-column templates to Bootstrap grid: Authorities This patch updates several single-column Authorities module templates to use the Bootstrap grid. - authorities-home - The home page of the Authorities module. - authorities.tt - The authority add/edit page. - blinddetail-biblio-search.tt - Not really testable -- It's the small popup window which appears during the process of linking an authority to a MARC record. - detail.tt - The authority detail page. Search for an authority record and click on the "details" link in the search results. - merge.tt - From a list of authority search results, select "Merge" from the Actions menu of two authority records. Test both the initial selection screen and the source/destination merging view. - searchresultlist.tt - The authority search results page. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:29:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:29:08 +0000 Subject: [Koha-bugs] [Bug 19949] Update popup window templates to use Bootstrap grid: Cataloging authority search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19949 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:33:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:33:06 +0000 Subject: [Koha-bugs] [Bug 20340] Ability to use authentication plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 --- Comment #8 from Alex Arnaud --- (In reply to Kyle M Hall from comment #5) > (In reply to Alex Arnaud from comment #4) > > (In reply to Kyle M Hall from comment #3) > I would say the plugin itself should be responsible for having controls to > tell Koha if it is enabled or not. There is already precedence for this in > Koha ( see bug 19173 ). For simplicity, the plugin could simply return > values as if the authentication failed, for the sake of simplicity. > > What do you think? You mean: plugin exists (in the plugins directory) == plugin enabled ? That also means we need to delete it for make it disabled, right? If we assume that we want to loop on several plugins, it could be nice to be able to set an ordered stack of authentication modules. This could allow us to chose which one is used first etc... In this case we need a dedicated page in fact. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:34:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:34:26 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72378|0 |1 is obsolete| | Attachment #72379|0 |1 is obsolete| | Attachment #72380|0 |1 is obsolete| | Attachment #72381|0 |1 is obsolete| | Attachment #72382|0 |1 is obsolete| | Attachment #72383|0 |1 is obsolete| | --- Comment #39 from Josef Moravec --- Created attachment 72511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72511&action=edit Bug 4078: DBIC Schema changes Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:34:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:34:31 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #40 from Josef Moravec --- Created attachment 72512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72512&action=edit Bug 4078: Update DB entry - add new column currency.p_sep_by_space Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:34:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:34:35 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #41 from Josef Moravec --- Created attachment 72513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72513&action=edit Bug 4078: Add the checkbox to the UI Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:34:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:34:39 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #42 from Josef Moravec --- Created attachment 72514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72514&action=edit Bug 4078: Pass with_symbol to module The template plugin did not pass the with_symbol flag to the module and so was not taken into account Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:34:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:34:43 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #43 from Josef Moravec --- Created attachment 72515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72515&action=edit Bug 4078: Add the ability to display and configure the symbol for prices The symbol of currencies are not displayed (or not correctly) so far. This patch set adds the ability to configure the display of the symbol (with or without a whitespace between the symbol and the price). Test plan: 1. Execute the update DB entry, go to the currency admin page and tick the new "Space separation between symbol and value" checkbox 2. Add a fine to a patron and use their credentials to login at the OPAC 3. You should see the "$ 42 due fines and charges" info in the dashboard 4. Untick the new checkbox to remove the space and reload the OPAC main page. => The space should not be longer displayed ($42) Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:34:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:34:47 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #44 from Josef Moravec --- Created attachment 72516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72516&action=edit Bug 4078: Add a new test Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:36:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:36:02 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #45 from Josef Moravec --- Passed QA. This area really need more work, but it is out of the scope of this bug report I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:36:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:36:13 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:36:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:36:27 +0000 Subject: [Koha-bugs] [Bug 19223] Problem with plugins and encodings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223 --- Comment #6 from Katrin Fischer --- Maybe some best practice is needed or a fix, hard to tell - EDS plugin is hard to test, is there another we could take a look at more closely? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:37:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:37:29 +0000 Subject: [Koha-bugs] [Bug 20352] Add ability of currency/price to have a symbol after amount In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |4078 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 [Bug 4078] Add the ability to customize and display the symbol for a currency -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:37:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:37:23 +0000 Subject: [Koha-bugs] [Bug 20352] New: Add ability of currency/price to have a symbol after amount Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 Bug ID: 20352 Summary: Add ability of currency/price to have a symbol after amount Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:37:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:37:29 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20352 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352 [Bug 20352] Add ability of currency/price to have a symbol after amount -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:38:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:38:09 +0000 Subject: [Koha-bugs] [Bug 20340] Ability to use authentication plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 --- Comment #9 from Alex Arnaud --- (In reply to Alex Arnaud from comment #8) > (In reply to Kyle M Hall from comment #5) > > (In reply to Alex Arnaud from comment #4) > > > (In reply to Kyle M Hall from comment #3) > > > I would say the plugin itself should be responsible for having controls to > > tell Koha if it is enabled or not. There is already precedence for this in > > Koha ( see bug 19173 ). For simplicity, the plugin could simply return > > values as if the authentication failed, for the sake of simplicity. > > > > What do you think? > > You mean: plugin exists (in the plugins directory) == plugin enabled ? That > also means we need to delete it for make it disabled, right? > > > If we assume that we want to loop on several plugins, it could be nice to be > able to set an ordered stack of authentication modules. This could allow us > to chose which one is used first etc... In this case we need a dedicated > page in fact. Oh, think i see! We can configure plugins and so use the plugins_data. Also this could allow use to define a "weight" to set the execution order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:38:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:38:42 +0000 Subject: [Koha-bugs] [Bug 20344] Transferring an item while on hold results in a transfer where the destination is the same as the source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20344 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Transferring an item while |Transferring an item while |on hold results in a |on hold results in a |transfer were the |transfer where the |destination is the same as |destination is the same as |the source |the source CC| |sophie.meynieux at biblibre.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:40:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:40:08 +0000 Subject: [Koha-bugs] [Bug 20353] Get rid of CurrencyFormat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20353 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |4078 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 [Bug 4078] Add the ability to customize and display the symbol for a currency -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:40:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:40:08 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20353 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20353 [Bug 20353] Get rid of CurrencyFormat -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:39:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:39:59 +0000 Subject: [Koha-bugs] [Bug 20353] New: Get rid of CurrencyFormat Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20353 Bug ID: 20353 Summary: Get rid of CurrencyFormat Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org The syspref CurrencyFormat should be removed and the funcionality should be moved to administration -> currency management as discussed on bug 4078. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:40:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:40:26 +0000 Subject: [Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 --- Comment #9 from M. Tompsett --- Comment on attachment 72499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72499 Patch for bug 18570 Review of attachment 72499: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18570&attachment=72499) ----------------------------------------------------------------- ::: C4/Letters.pm @@ +1080,5 @@ > +Messages from the `message_queue` table are matched on borrowernumber and letter_code='PASSWORD_RESET' > + > +=cut > + > +sub SendPasswordEmailFromQueue { I believe this is the wrong way to do it. I think building a hash ref in SendQueuedMessages and using the built hashref on the _get_unsent_messages call would be better than introducing this, and this fails to handle how to send messages. After all, calling it with a borrower number and a letter code in the params hash ref should be easy enough to add, and then you could simply tweak the t/db_dependent/Letters.t test to test for the password reset case. @@ +1299,4 @@ > my @query_params = ('pending'); > if ( ref $params ) { > if ( $params->{'message_transport_type'} ) { > + $statement .= ' AND mq.message_transport_type = ? '; Not necessary, but okay. There is only one message_transport_type field. @@ +1303,4 @@ > push @query_params, $params->{'message_transport_type'}; > } > if ( $params->{'borrowernumber'} ) { > + $statement .= ' AND mq.borrowernumber = ? '; Not necessary, but okay. The LEFT JOIN makes sure the number is the same, and there is only one borrowernumber in the SELECT list of the SQL statement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:42:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:42:06 +0000 Subject: [Koha-bugs] [Bug 20354] New: Add ability for patrons to set theirs preferred currency Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20354 Bug ID: 20354 Summary: Add ability for patrons to set theirs preferred currency Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:42:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:42:14 +0000 Subject: [Koha-bugs] [Bug 20354] Add ability for patrons to set theirs preferred currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20354 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |4078 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 [Bug 4078] Add the ability to customize and display the symbol for a currency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:42:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:42:14 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20354 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20354 [Bug 20354] Add ability for patrons to set theirs preferred currency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:42:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:42:40 +0000 Subject: [Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset at hotmail.com --- Comment #10 from M. Tompsett --- Failed QA for one major reason: Missing test coverage. Do not modify C4 or Koha libraries without including tests. Also, because I think it is the wrong way to do it, but test coverage either way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:43:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:43:55 +0000 Subject: [Koha-bugs] [Bug 20355] New: Add example column to administration currency table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20355 Bug ID: 20355 Summary: Add example column to administration currency table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It would be nice to have this column to ensure you set the right settings for each currency defined. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:44:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:44:16 +0000 Subject: [Koha-bugs] [Bug 20355] Add example column to administration currency table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20355 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20353 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20353 [Bug 20353] Get rid of CurrencyFormat -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:44:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:44:16 +0000 Subject: [Koha-bugs] [Bug 20353] Get rid of CurrencyFormat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20353 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20355 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20355 [Bug 20355] Add example column to administration currency table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:58:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:58:40 +0000 Subject: [Koha-bugs] [Bug 20356] New: Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS send driver from address Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 Bug ID: 20356 Summary: Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS send driver from address Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: glasklas at gmail.com QA Contact: testopia at bugs.koha-community.org Our SMS gateway provider requires that only one specific email address is used in as sender for all emails. This patch adds a system preference for setting "from" address for all mails sent by the Email SMS send driver. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 17:59:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 16:59:37 +0000 Subject: [Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 --- Comment #11 from Katrin Fischer --- (In reply to M. Tompsett from comment #10) > Failed QA for one major reason: Missing test coverage. > > Do not modify C4 or Koha libraries without including tests. > Also, because I think it is the wrong way to do it, but test coverage either > way. Hi Mark, if you think it's the wrong way to do it, please explain. It makes no sense to write tests when the idea of the patch needs to be changed later on. I was thinking the routine might be better not so single purpose. I think there might be other use cases like the patron registration verification emails (I even think there is a bug about those already) that we will want to send immediately. I Maybe just needs the letter code as parameter and a more general name? Could there be a scenario where we have a race condition? Entry not yet written to message_queue and tryint to send it or similar? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 18:02:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 17:02:23 +0000 Subject: [Koha-bugs] [Bug 20356] Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS send driver from address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 --- Comment #1 from David Gustafsson --- Created attachment 72517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72517&action=edit Bug 20356 - Add EmailSMSSendDriverFromAddress system preference Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS send driver from address. How to test: 1. Run tests in t/db_dependent/Letters.t 2. All tests should pass -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 18:05:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 17:05:03 +0000 Subject: [Koha-bugs] [Bug 20356] Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS send driver from address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 --- Comment #2 from David Gustafsson --- Created attachment 72518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72518&action=edit Bug 20356: Add EmailSMSSendDriverFromAddress system preference Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS send driver from address. How to test: 1) Run tests in t/db_dependent/Letters.t 2) All tests should pass Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 18:07:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 17:07:49 +0000 Subject: [Koha-bugs] [Bug 20356] Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS send driver from address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 18:18:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 17:18:49 +0000 Subject: [Koha-bugs] [Bug 19929] Add Koha Objects for class_source and class_sort_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- The full word "Classification" makes the file name to DB file in the head without reading and without consulting schema harder. ClassSortRule and ClassSortRules would be nicer than ClassificationSort and ClassificationSorters, I think. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 18:41:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 17:41:47 +0000 Subject: [Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 --- Comment #12 from M. Tompsett --- (In reply to Katrin Fischer from comment #11) > Hi Mark, if you think it's the wrong way to do it, please explain. "I think building a hash ref in SendQueuedMessages and using the built hashref on the _get_unsent_messages call would be better than introducing this, and this fails to handle how to send messages." > It makes no sense to write tests when the idea of the patch > needs to be changed later on. In this case, the tests could have been easily tweaked and pushed into t/db_dependent/Letter.t, but I understand why you say that. > I was thinking the routine might be better not so single purpose. -- which is why I suggested re-working SendQueuedMessages just a little. > I think there might be other use cases like the patron > registration verification emails (I even think there is > a bug about those already) that we will want to send immediately. True, which is what this tweak suggesting would aid in setting up for. > Maybe just needs the letter code as parameter and a > more general name? No, because I was thinking... > Could there be a scenario where we have a race condition? Entry not yet > written to message_queue and trying to send it or similar? Of this. This is why I said borrowernumber too. You aren't likely to have the same borrower trying to send the same letter, except mid-upgrade when the borrower has gone all "reset, it's not here, reset, it's not here, reset, it's not here" and generated multiple resets. So the whole $pw->[0] doesn't work. Another reason to use SendQueuedMessages. "After all, calling it with a borrower number and a letter code in the params hash ref should be easy enough to add, and then you could simply tweak the t/db_dependent/Letters.t test to test for the password reset case." You'll notice I quoted what I said in comment #9, because I thought I was clear enough. Sorry that I wasn't. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 19:27:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 18:27:07 +0000 Subject: [Koha-bugs] [Bug 19929] Add Koha Objects for class_source and class_sort_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 --- Comment #3 from M. Tompsett --- Comment on attachment 70337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70337 Bug 19929 - Add Koha objects for class sources and sorters Review of attachment 70337: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19929&attachment=70337) ----------------------------------------------------------------- ::: Koha/ClassificationSorters.pm @@ +20,5 @@ > +use Carp; > + > +use Koha::Database; > + > +use Koha::ClassificationSorters; It uses itself? Don't think this is correct. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 19:39:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 18:39:47 +0000 Subject: [Koha-bugs] [Bug 20322] Circulation page layout and design update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 19:43:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 18:43:20 +0000 Subject: [Koha-bugs] [Bug 19164] Allow MARC modification templates to be used in staged MARC imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19164 --- Comment #22 from Jon Knight --- Been doing some more playing with this. On my kohadevbox, applying this patch to the latest master, making a MARC modification rule of: Copy field 960$q to 998$q and then applying it to the export_201710031044.mrc file doesn't give me any errors on the command line, and appears to copy the 960$q to 998$q in the staged records as expected. Then I tried going to the 16.11.x branch in git and applying the patch on top of that. The patches apply OK, but the import fails (test1.mrc is my copy of the uploaded MARC file): vagrant at kohadevbox:kohaclone(16.11.x)$ git checkout -b bug_19164_16_11 Switched to a new branch 'bug_19164_16_11' vagrant at kohadevbox:kohaclone(bug_19164_16_11)$ git bz apply 19164 Bug 19164 - Allow MARC modification templates to be used in staged MARC imports 68249 - Patch for misc/stage_file.pl script to provide for MARC modification template support. 68425 - Bug_19164: remove use strict/warn lines (were commented out anyway) Apply? [(y)es, (n)o, (i)nteractive] y Applying: Patch for misc/stage_file.pl script to provide for MARC modification template support. Applying: Bug_19164: remove use strict/warn lines (were commented out anyway) vagrant at kohadevbox:kohaclone(bug_19164_16_11)$ misc/stage_file.pl --file ~/test.mrc --add-items --marcmodtemplate "Test Bug 19164" --item-action replace --comment "testing MARC mod templates on batch staging" ... staging MARC records -- please wait Not a HASH reference at /home/vagrant/kohaclone/C4/Biblio.pm line 2786. Hmm, so it looks like something is broken for using this patch with the latest 16.11.x. The question now is, as this is an enhancement (ie adding a new feature to Koha), do we worry about that too much if its working in the master train? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 20:18:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 19:18:12 +0000 Subject: [Koha-bugs] [Bug 19908] Password should not be mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 --- Comment #22 from Agnes Rivers-Moore --- (In reply to Josef Moravec from comment #21) > (In reply to Agnes Rivers-Moore from comment #17) > > Our Koha as of 17.11.03 does not generate default username for any patron > > type. > > Josef said 'Other categories (than org) have username generated as > > "firstname.surname" if you leave it blank' - but that does not seem to be > > the case any more. > > Previous behaviour also assigned a default password, and that also does not > > happen any more. > > Result is staff have to add three fields, making them unique/matching, even > > if the patron does not want an online account. > > Looking forward to this being non-mandatory! Thanks. > > Hi Agnes, please fill a bug report about user names not generated. Will test further and submit a new bug for Koha not auto-generating username & password. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 20:27:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 19:27:00 +0000 Subject: [Koha-bugs] [Bug 20357] New: Pod Coverage checking for no public subs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20357 Bug ID: 20357 Summary: Pod Coverage checking for no public subs Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: QA tools Assignee: jonathan.druart at bugs.koha-community.org Reporter: mtompset at hotmail.com While testing bug 19929, the qa test tools complained of pod coverage. I believe this is in error. Reading the Reports.pm file, it makes no sense to complain about a changed rating when there is nothing in subs before and after. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 20:29:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 19:29:00 +0000 Subject: [Koha-bugs] [Bug 18428] move of holds to old_reserves is not handled correctly. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18428 jplevyak at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jplevyak at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 20:32:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 19:32:14 +0000 Subject: [Koha-bugs] [Bug 20357] Pod Coverage checking for no public subs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20357 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 20:32:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 19:32:17 +0000 Subject: [Koha-bugs] [Bug 20357] Pod Coverage checking for no public subs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20357 --- Comment #1 from M. Tompsett --- Created attachment 72519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72519&action=edit Bug 20357: Correct POD Coverage checking for zero sub case Currently, bug 19929 fails QA Test tools, but it makes no sense. TEST PLAN --------- 1) in kohaclone branch apply 19929 2) Run the following commands: kshell /home/vagrant/qa-test-tools/koha-qa.pl -v 2 -c 1 -- This will fail with POD coverage messages. exit 3) apply this patch to qa-test-tools 4) re do step 2 -- POD coverage messages will be cleared up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 20:34:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 19:34:36 +0000 Subject: [Koha-bugs] [Bug 20358] New: Add unitprice_tax_included on report spent.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20358 Bug ID: 20358 Summary: Add unitprice_tax_included on report spent.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: marjorie.barry-vila at collecto.ca QA Contact: testopia at bugs.koha-community.org Hi, On acqui/spent.pl, it would be nice to have a new column for unitprice_tax_included. Regards, Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 20:37:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 19:37:34 +0000 Subject: [Koha-bugs] [Bug 20357] Pod Coverage checking for no public subs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20357 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19929 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 [Bug 19929] Add Koha Objects for class_source and class_sort_rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 20:37:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 19:37:34 +0000 Subject: [Koha-bugs] [Bug 19929] Add Koha Objects for class_source and class_sort_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20357 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20357 [Bug 20357] Pod Coverage checking for no public subs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 20:42:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 19:42:55 +0000 Subject: [Koha-bugs] [Bug 20346] Patron filtering resulting in new search rather than filtering existing results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20346 --- Comment #2 from Alex Buckley --- Created attachment 72520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72520&action=edit New patron filter with the search field type dropdown box removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 21:12:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 20:12:26 +0000 Subject: [Koha-bugs] [Bug 20357] Pod Coverage checking for no public subs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20357 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72519|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 72521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72521&action=edit Bug 20357: Correct POD Coverage checking for zero sub case Currently, bug 19929 fails QA Test tools, but it makes no sense. TEST PLAN --------- 1) in kohaclone branch apply 19929 2) Run the following commands: kshell /home/vagrant/qa-test-tools/koha-qa.pl -v 2 -c 1 -- This will fail with POD coverage messages. exit 3) apply this patch to qa-test-tools 4) re do step 2 -- POD coverage messages will be cleared up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 21:36:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 20:36:32 +0000 Subject: [Koha-bugs] [Bug 20303] Receive order fails if no "authorised_by" value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20303 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 21:36:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 20:36:34 +0000 Subject: [Koha-bugs] [Bug 20303] Receive order fails if no "authorised_by" value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20303 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72281|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 72522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72522&action=edit Bug 20303: Do not explode when receiving an order if authorisedby not set Reproduced by deleting user and patron to notify before clicking Receive. Patch works. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 22:48:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 21:48:55 +0000 Subject: [Koha-bugs] [Bug 14182] Suspended holds should show in separate list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14182 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 22:59:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 21:59:02 +0000 Subject: [Koha-bugs] [Bug 20359] New: Auto-Renew notice not able to pull branch information Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20359 Bug ID: 20359 Summary: Auto-Renew notice not able to pull branch information Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Information from the branches table cannot be pulled into the AUTO_RENEW notice. This is an issue for libraries that want to include library contact information in their notices that will automatically update when values are changed in Koha or for multi-branch systems that want their notices to specify where the renewed item is from. To replicate: 1: Write an AUTO_RENEW notice including either <> or [% branch.branchname %] 2: Run the auto-renew cron with notices 3: Observe that branch info is not included in the notice -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 23:00:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 22:00:27 +0000 Subject: [Koha-bugs] [Bug 20359] Auto-Renew notice not able to pull branch information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20359 Andrew changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 23:02:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 22:02:39 +0000 Subject: [Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 --- Comment #13 from Katrin Fischer --- Sorry Mark, totally missed comment#9. :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 23:13:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 22:13:00 +0000 Subject: [Koha-bugs] [Bug 20360] New: Auto-Renew notices send in advance of No Renewal Before period Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20360 Bug ID: 20360 Summary: Auto-Renew notices send in advance of No Renewal Before period Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Koha sends auto-renew notices for failed renewals before the period defined by the No Renewal Before value in the circulation rule. This results in a confusing and premature notice. To replicate: 1: Set up a circulation rule that makes the item due more than 2 days in the future, allows auto-renewals, and has a No Renewal Before value of 1 2: Check out an item corresponding to the circ rule created 3: Run the auto-renew cron. The item will not renew and no notice will be generated because the issues table shows it is too soon to perform an auto-renew. 4: Plase a hold on the item for another patron 5: Run the auto-renew cron again. A notice will be generated that the item could not be renewed because there is a hold, even though the item due date is still multiple days off, meaning the item is outside of the No Renewal Before period -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 23:13:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 22:13:15 +0000 Subject: [Koha-bugs] [Bug 20360] Auto-Renew notices send in advance of No Renewal Before period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20360 Andrew changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 7 23:18:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 22:18:15 +0000 Subject: [Koha-bugs] [Bug 20360] Auto-Renew notices send in advance of No Renewal Before period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20360 --- Comment #1 from Andrew --- An auto-renewal notice is sent out if issues.auto_renew_error shows a new value other than "too soon." Values such as "too many" or "reserve" take precedence over "too soon." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 00:08:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 23:08:20 +0000 Subject: [Koha-bugs] [Bug 20346] Patron filtering resulting in new search rather than filtering existing results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20346 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72496|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 00:08:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Mar 2018 23:08:59 +0000 Subject: [Koha-bugs] [Bug 20346] Patron filtering resulting in new search rather than filtering existing results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20346 --- Comment #3 from Alex Buckley --- Created attachment 72523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72523&action=edit Bug 20346 - Server side patron filtering implemented Server side (in the svc/members/search file) perl logic for filtering results returned from patron searches checks all patron data fields for a match with the filter value. This filtering works in the following steps: when filtering is initiated the original search using the original search query is run again and then the filter value is used to filter the resulting data, thereby using both the search and filter values to easily find a patron. The submitted filter value is automatically checked against every patron value in every patron record returned from the search and so there is no need for a specific data value to be selected with the select dropdown box id=searchfieldstype_filter and so that select dropdown has been removed due to this redundancy. This filter works for both filtering based on finding a match containing the filter value and, filtering based on finding a match starting with the filter value. A tooltip is displayed on the searchmember_filter input box to inform the user what format they should enter date formats. The tooltip tells the user to follow the date format of the dateformat syspref, meaning if the Koha instance has the 'metric' dataformat syspref value set then the tooltip will tell the user to enter a date value in the format dd/mm/yyyy Test plan: 1. Go to /members/members-home.pl and create 4 users. Make 3 of them have the same first and last name (e.g. first name = 'Fred' and last name ='Jones') but vary the homebranch, email addresses (e.g. fred at gmail.com, fred at hotmail.com, fredj at gmail.com (make this user have a date of birth of 1st jan 1980)) and make the fourth user have the first and last name of "Fred" "Smith" 2. Perform a search by writing in the 'Jones' value and you should get 3 results 3. Filter by writing in the word "Fred", with the search field ="standard" and searchtype="Contains" and this will give you 4 results because a new search for all users containing "Fred" is performed rather than filtering the results of the "Jones" search for the term "Fred" 4. Apply patch 5. Restart plack, apache2 and memcached 6. Refresh the patron page 7. Notice the search field dropdown has been removed because the filtering now automatically checks all patron data fields. Also notice when you hover over the filter textbox a tooltip message is displayed informing you the appropriate format for you to input date values in. This date format recommended is based on the value of the dateformat syspref 8. Repeat step 2 and you should get 3 results 9. Repeat step 3 and notice you get 3 results because the filtering is happening on the results of search rather than performing a new search 10. Perform another filter of the search by inputting the date 1st jan 1980 in the appropriate format described in the tooltip and the patron page for the patron with the email address fredj at gmail.com should be displayed Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 01:18:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 00:18:28 +0000 Subject: [Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 --- Comment #14 from M. Tompsett --- Created attachment 72524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72524&action=edit Bug 18570: Tests to prove if email send was attempted kshell prove -v t/db_dependent/Passwordrecovery.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 01:18:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 00:18:32 +0000 Subject: [Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 --- Comment #15 from M. Tompsett --- Created attachment 72525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72525&action=edit Bug 18570: Prove that the letter code parameter tweaks work Run the following commands: kshell prove -v t/db_dependent/Letters.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 01:18:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 00:18:35 +0000 Subject: [Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 --- Comment #16 from M. Tompsett --- Created attachment 72526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72526&action=edit Bug 18570: Send Password Reset Emails immediately Run through the password reset process, and your server should send the message immediate, not waiting for the cronjob. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 01:22:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 00:22:35 +0000 Subject: [Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #17 from M. Tompsett --- If you think the first patch is worthy of sign off, then go ahead and obsolete my three counter patches. Otherwise, apply my first patch alone, and the test should fail. Apply all my patches, and all the tests should pass. And, attempt a password reset process, the email should be sent immediately (it won't be 'pending' in the DB for more than a few seconds). I believe this has sufficient test coverage, and is a better solution by using the existing function. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 03:10:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 02:10:51 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72338|0 |1 is obsolete| | --- Comment #125 from Aleisha Amohia --- Created attachment 72527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72527&action=edit Bug 19532 - Improve and refine recalls functionality Only allow 1 recall per item When checking in only check for holds if no reserves found Add a T/transferring status for recalls, only confirm them once arrived Improve message when checking in recall Fix clashing ids on recall-history Check if patron can hold item before allowing recall Prevent multiple recalls when pressing back button Select/fill only active recall when issuing To test: 1 - Repeat major test plan - verify all points 2 - Attempt to place multiple recallsusing back button, should fail 3 - Set all item level holds to not allowed, should not be able to place recall 4 - Check-in recall at branch other than destination, should be in transit 5 - Confirm at correct branch, should send message and get expiration date etc. 6 - Return to another branch, should eb in transit again 7 - Play with circ rules and verify only allowed patrons can place recall Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 03:12:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 02:12:28 +0000 Subject: [Koha-bugs] [Bug 20357] Pod Coverage checking for no public subs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20357 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at bugs.koha-c |mtompset at hotmail.com |ommunity.org | Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 03:20:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 02:20:07 +0000 Subject: [Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725 --- Comment #16 from M. Tompsett --- Oh, I just thought of one way to try to get it to fail as described: apparmor. Changing apparmor settings might all creation of records, and then crashing horribly on update attempts. But I have such an aversion to apparmor, that I am not even going to try. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 04:05:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 03:05:05 +0000 Subject: [Koha-bugs] [Bug 20097] marc2dcxml croaks on format dc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 --- Comment #4 from M. Tompsett --- Created attachment 72528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72528&action=edit Bug 20097: Follow-up with a unit test kshell prove -v t/db_dependent/Record.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 04:11:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 03:11:20 +0000 Subject: [Koha-bugs] [Bug 20097] marc2dcxml croaks on format dc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #5 from M. Tompsett --- I tested these on a reset_all, kohadevbox. localhost:8080/cgi-bin/koha/opac-export.pl?bib=1&op=export&format=dc localhost:8080/cgi-bin/koha/opac-export.pl?bib=1&op=export&format=oaidc localhost:8080/cgi-bin/koha/opac-export.pl?bib=1&op=export&format=srwdc localhost:8080/cgi-bin/koha/opac-export.pl?bib=1&op=export&format=rdfdc localhost:8080/cgi-bin/koha/opac-export.pl?bib=1&op=export&format=nodc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 04:13:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 03:13:07 +0000 Subject: [Koha-bugs] [Bug 20097] marc2dcxml croaks on format dc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71018|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Created attachment 72529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72529&action=edit Bug 20097: Use same regex in marc2dcxml and opac-export This regex allows: dc, oaidc, srwdc, and rdfdc. Test plan: [1] Check https://[yourserver]/cgi-bin/koha/opac-export.pl?bib=[some_biblionumber]&op=export&format=dc [2] Check https://[yourserver]/cgi-bin/koha/opac-export.pl?bib=[some_biblionumber]&op=export&format=oaidc [3] Check https://[yourserver]/cgi-bin/koha/opac-export.pl?bib=[some_biblionumber]&op=export&format=nodc. This one should trigger a not-supported message. Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 04:13:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 03:13:10 +0000 Subject: [Koha-bugs] [Bug 20097] marc2dcxml croaks on format dc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72528|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 72530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72530&action=edit Bug 20097: Follow-up with a unit test kshell prove -v t/db_dependent/Record.t Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 04:13:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 03:13:38 +0000 Subject: [Koha-bugs] [Bug 20097] marc2dcxml croaks on format dc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 07:48:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 06:48:22 +0000 Subject: [Koha-bugs] [Bug 20340] Ability to use authentication plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 --- Comment #10 from Katrin Fischer --- How does one work with plugins in a multi-instance setup? Do you need to store them separately (install multiple times) or can you use a shared plugin folder and turn them on/off with the settings? (sorry, hope not distracting again) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 07:52:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 06:52:43 +0000 Subject: [Koha-bugs] [Bug 20354] Add ability for patrons to set theirs preferred currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20354 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- How would a per patron setting work? Our currency rates can't be kept updated automatically, would this be reliable enough? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 09:42:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 08:42:38 +0000 Subject: [Koha-bugs] [Bug 19530] Prevent multiple transfers from existing for one item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20344 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 09:42:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 08:42:38 +0000 Subject: [Koha-bugs] [Bug 20344] Transferring an item while on hold results in a transfer where the destination is the same as the source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20344 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19530 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 10:40:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 09:40:52 +0000 Subject: [Koha-bugs] [Bug 19530] Prevent multiple transfers from existing for one item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #23 from Fridolin SOMERS --- Pushed to 17.05.x for v17.05.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 10:47:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 09:47:31 +0000 Subject: [Koha-bugs] [Bug 20354] Add ability for patrons to set theirs preferred currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20354 --- Comment #2 from Josef Moravec --- (In reply to Katrin Fischer from comment #1) > How would a per patron setting work? > > Our currency rates can't be kept updated automatically, would this be > reliable enough? It's just an idea, and should be more disscussed. It should be probably done only in OPAC. But there is always question if there is a use case for this - maybe international libraries? Or if there are any countries with more currencies used? Automatic rates update could be possible with Finance::Quote->currency http://search.cpan.org/~ecocode/Finance-Quote-1.47/lib/Finance/Quote.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 10:55:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 09:55:57 +0000 Subject: [Koha-bugs] [Bug 20354] Add ability for patrons to set theirs preferred currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20354 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=3758 --- Comment #3 from Katrin Fischer --- Linking bug 3758 :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 10:55:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 09:55:57 +0000 Subject: [Koha-bugs] [Bug 3758] Automatic Exchange Rates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3758 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20354 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 11:02:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 10:02:38 +0000 Subject: [Koha-bugs] [Bug 20354] Add ability for patrons to set theirs preferred currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20354 --- Comment #4 from Josef Moravec --- (In reply to Katrin Fischer from comment #3) > Linking bug 3758 :) Thanks, I didn't know it exists ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 11:03:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 10:03:32 +0000 Subject: [Koha-bugs] [Bug 3758] Automatic Exchange Rates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3758 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 11:14:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 10:14:00 +0000 Subject: [Koha-bugs] [Bug 20333] Show certain links just for registered users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20333 --- Comment #4 from Hugo Agud --- Hi Katrin.. yes it is a good issue!! thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 11:51:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 10:51:11 +0000 Subject: [Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 --- Comment #18 from mark.gavillet at ptfs-europe.com --- It's all very subjective so I'm happy either way. It would be good to come to a resolution on this one as we've got a couple of customers waiting on this who would be delighted to see it come through! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 12:01:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 11:01:35 +0000 Subject: [Koha-bugs] [Bug 20340] Ability to use authentication plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 --- Comment #11 from Kyle M Hall --- (In reply to Alex Arnaud from comment #9) > (In reply to Alex Arnaud from comment #8) > > (In reply to Kyle M Hall from comment #5) > > > (In reply to Alex Arnaud from comment #4) > > > > (In reply to Kyle M Hall from comment #3) > > > > > I would say the plugin itself should be responsible for having controls to > > > tell Koha if it is enabled or not. There is already precedence for this in > > > Koha ( see bug 19173 ). For simplicity, the plugin could simply return > > > values as if the authentication failed, for the sake of simplicity. > > > > > > What do you think? > > > > You mean: plugin exists (in the plugins directory) == plugin enabled ? That > > also means we need to delete it for make it disabled, right? > > > > > > If we assume that we want to loop on several plugins, it could be nice to be > > able to set an ordered stack of authentication modules. This could allow us > > to chose which one is used first etc... In this case we need a dedicated > > page in fact. > > Oh, think i see! We can configure plugins and so use the plugins_data. Also > this could allow use to define a "weight" to set the execution order No, just the plugin store it's on 'on/off' switch. If it is set to off, have the plugin always return 0 for checkauth. I personally don't find the ability to set the order to be necessary, but your idea would work. If each plugin stored a param call 'priority' in plugin_data table, it would be easy to do what you propose! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 12:37:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 11:37:56 +0000 Subject: [Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72525|0 |1 is obsolete| | --- Comment #20 from Josef Moravec --- Created attachment 72532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72532&action=edit Bug 18570: Prove that the letter code parameter tweaks work Run the following commands: kshell prove -v t/db_dependent/Letters.t Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 12:38:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 11:38:01 +0000 Subject: [Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72526|0 |1 is obsolete| | --- Comment #21 from Josef Moravec --- Created attachment 72533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72533&action=edit Bug 18570: Send Password Reset Emails immediately Run through the password reset process, and your server should send the message immediate, not waiting for the cronjob. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 12:37:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 11:37:52 +0000 Subject: [Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 --- Comment #19 from Josef Moravec --- Created attachment 72531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72531&action=edit Bug 18570: Tests to prove if email send was attempted kshell prove -v t/db_dependent/Passwordrecovery.t Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 12:38:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 11:38:43 +0000 Subject: [Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Attachment #72524|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 12:39:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 11:39:03 +0000 Subject: [Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72499|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 12:41:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 11:41:19 +0000 Subject: [Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #22 from Josef Moravec --- I signed of counter patch, as it is a bit more generall solution and also tested. But thanks you both all for good job done ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 13:07:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 12:07:42 +0000 Subject: [Koha-bugs] [Bug 18342] Set memcached as 'enabled' by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18342 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #7 from Josef Moravec --- Shouldn't be Cache::Memcached module marked as required in PerlDependencies then? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 13:42:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 12:42:17 +0000 Subject: [Koha-bugs] [Bug 20167] Item hold is set to bibliographic hold when changing pickup location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20167 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 13:45:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 12:45:00 +0000 Subject: [Koha-bugs] [Bug 20167] Item hold is set to bibliographic hold when changing pickup location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20167 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72479|0 |1 is obsolete| | Attachment #72480|0 |1 is obsolete| | --- Comment #6 from Josef Moravec --- Created attachment 72534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72534&action=edit Bug 20167: Regression test Signed-off-by: Claire Gravely Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 13:45:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 12:45:03 +0000 Subject: [Koha-bugs] [Bug 20167] Item hold is set to bibliographic hold when changing pickup location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20167 --- Comment #7 from Josef Moravec --- Created attachment 72535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72535&action=edit Bug 20167: Make changing a hold pass the itemnumber to ModReserve If you have an item-level hold, changing an attribute (like priority, pickup location or suspended until date) makes the hold a biblio-level hold, because ModReserve is not passed the current itemnumber. This patch uses the hold's itemnumber and passes it to the ModReserve call. To test: - Run the regression tests from the previous patch: $ kshell k$ prove t/db_dependent/api/v1/holds.t => FAIL: Tests fail - Apply this patch - Run the tests: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Claire Gravely Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 13:44:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 12:44:56 +0000 Subject: [Koha-bugs] [Bug 20167] Item hold is set to bibliographic hold when changing pickup location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20167 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 13:55:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 12:55:22 +0000 Subject: [Koha-bugs] [Bug 20303] Receive order fails if no "authorised_by" value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20303 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 13:55:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 12:55:45 +0000 Subject: [Koha-bugs] [Bug 20303] Receive order fails if no "authorised_by" value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20303 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 13:55:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 12:55:25 +0000 Subject: [Koha-bugs] [Bug 20303] Receive order fails if no "authorised_by" value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20303 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72522|0 |1 is obsolete| | --- Comment #6 from Josef Moravec --- Created attachment 72536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72536&action=edit Bug 20303: Do not explode when receiving an order if authorisedby not set Signed-off-by: Mark Tompsett Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 14:01:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 13:01:07 +0000 Subject: [Koha-bugs] [Bug 20097] marc2dcxml croaks on format dc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 14:04:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 13:04:49 +0000 Subject: [Koha-bugs] [Bug 20097] marc2dcxml croaks on format dc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72529|0 |1 is obsolete| | Attachment #72530|0 |1 is obsolete| | --- Comment #8 from Josef Moravec --- Created attachment 72537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72537&action=edit Bug 20097: Use same regex in marc2dcxml and opac-export This regex allows: dc, oaidc, srwdc, and rdfdc. Test plan: [1] Check https://[yourserver]/cgi-bin/koha/opac-export.pl?bib=[some_biblionumber]&op=export&format=dc [2] Check https://[yourserver]/cgi-bin/koha/opac-export.pl?bib=[some_biblionumber]&op=export&format=oaidc [3] Check https://[yourserver]/cgi-bin/koha/opac-export.pl?bib=[some_biblionumber]&op=export&format=nodc. This one should trigger a not-supported message. Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 14:04:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 13:04:46 +0000 Subject: [Koha-bugs] [Bug 20097] marc2dcxml croaks on format dc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 14:04:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 13:04:53 +0000 Subject: [Koha-bugs] [Bug 20097] marc2dcxml croaks on format dc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 --- Comment #9 from Josef Moravec --- Created attachment 72538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72538&action=edit Bug 20097: Follow-up with a unit test kshell prove -v t/db_dependent/Record.t Signed-off-by: Mark Tompsett Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 14:35:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 13:35:16 +0000 Subject: [Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 14:37:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 13:37:07 +0000 Subject: [Koha-bugs] [Bug 20340] Ability to use authentication plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 --- Comment #12 from Kyle M Hall --- (In reply to Katrin Fischer from comment #10) > How does one work with plugins in a multi-instance setup? Do you need to > store them separately (install multiple times) or can you use a shared > plugin folder and turn them on/off with the settings? (sorry, hope not > distracting again) By default, it's per-instance. You *could* also have a 'shared' plugins dir, as the kona-conf plugins dir setting can be set for multiple dirs. See bug 15879 for details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 14:56:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 13:56:54 +0000 Subject: [Koha-bugs] [Bug 19530] Prevent multiple transfers from existing for one item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m --- Comment #24 from Victor Grousset/tuxayo --- Maybe the root cause will be found with bug 20344. As the scenarios without the patches of this bug lead to the creation of duplicates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 16:04:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 15:04:26 +0000 Subject: [Koha-bugs] [Bug 20348] SIP2 patron identification fails to use userid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20348 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72502|0 |1 is obsolete| | --- Comment #2 from Colin Campbell --- Created attachment 72539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72539&action=edit Patch with signoff Signed off - added CR to commit message to avoid auto wrapping added a line to clarify what was being fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 16:05:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 15:05:38 +0000 Subject: [Koha-bugs] [Bug 15668] Add column configuration to the items table in staff detail pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668 --- Comment #1 from Nick Clemens --- Created attachment 72540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72540&action=edit Bug 15668 - Add columns configuraiton to intranet details page TODO: Make this account for otherholdings too - see bug 16759 To test: 1 - Apply patches 2 - View biblio details in staff client 3 - Should be able to toggle columns 4 - Go to admin columns settings 5 - Change some settings, verify they work 6 - Enable SeparateHoldings 7 - Don't works, Be sad, get motivated, finish the patchset, get a hug from kidclamp -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 16:10:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 15:10:26 +0000 Subject: [Koha-bugs] [Bug 20348] SIP2 patron identification fails to use userid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20348 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Colin Campbell --- Confirmed that lookup by userid was not being executed and that reverting the or to || does correct that and restores the code to a working lookup. People should beware of prettifying the code by replacing operators with operators that are not equivalent. Specially as in this case when the buggy change is hidden in a large commit which is not explicit about making the change -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 17:08:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 16:08:22 +0000 Subject: [Koha-bugs] [Bug 17684] add floating table header on acqui-home.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17684 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC|patrick.robitaille at collecto |marjorie.barry-vila at collect |.ca |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 17:08:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 16:08:42 +0000 Subject: [Koha-bugs] [Bug 17684] add floating table header on acqui-home.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17684 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 17:10:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 16:10:03 +0000 Subject: [Koha-bugs] [Bug 20005] Posibility to change the number of results shown by default in label creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20005 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 17:11:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 16:11:08 +0000 Subject: [Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|19966 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 [Bug 19966] Add ability to pass objects directly to slips and notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 17:11:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 16:11:08 +0000 Subject: [Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|19191 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 [Bug 19191] Add ability to email receipts for account payments and write-offs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 17:22:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 16:22:03 +0000 Subject: [Koha-bugs] [Bug 20005] Posibility to change the number of results shown by default in label creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20005 --- Comment #1 from Marjorie Barry-Vila --- In 17.05, a new system preference exist : NumSavedReports for table in /reports/guided_reports.pl. It would be fine to have same system preference for all tables or a new option in Column settings. Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 18:55:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 17:55:29 +0000 Subject: [Koha-bugs] [Bug 19955] Add ability to process only one 'type' of message ( sms, email, etc ) for a given run of process_message_queue.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19955 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 19:29:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 18:29:44 +0000 Subject: [Koha-bugs] [Bug 12460] Search history: Combine to start a new search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 --- Comment #23 from Andreas Jonsson --- The support for non-logged in users by getting the search history from the session was lost in the simplification patch (attachment 72092). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 22:10:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 21:10:25 +0000 Subject: [Koha-bugs] [Bug 20323] Batch patron modification tool broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20323 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 22:10:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 21:10:29 +0000 Subject: [Koha-bugs] [Bug 20323] Batch patron modification tool broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20323 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72384|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 72541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72541&action=edit Bug 20323: Fix batch patron modification tool Test plan: 1) Go to Tools -> Batch patrons modification 2) Select some patrons and try to change any field --> without patch - it exploads with log: Can't call method "category" on unblessed reference at /home/vagrant/kohaclone/tools/modborrowers.pl --> with patch - the modification is properly made Signed-off-by: Roch D'Amour Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 8 22:53:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Mar 2018 21:53:29 +0000 Subject: [Koha-bugs] [Bug 20245] Wrong language code for Slovak In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 --- Comment #3 from Radek ?iman (R-Bit Technology, s.r.o.) --- Created attachment 72542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72542&action=edit Bug 20245: Wrong language code for Slovak This patch only updates iso639_2_code value for Slovak language Test plan: 1) Obtain a biblio record having 'slo' value in its language code (marc field 041a) 2) Try to find it through Advanced search + more options with language set to Slovak 3) Nothing is found 4) Apply this patch 5) Repeat steps 1 and 2 6) Record is found now -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 06:53:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 05:53:02 +0000 Subject: [Koha-bugs] [Bug 20344] Transferring an item while on hold results in a transfer where the destination is the same as the source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20344 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 07:23:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 06:23:47 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_20361=5D_New=3A_New_York_Call_1_=28?= =?utf-8?b?yKPIo8ijKS4yNDctMTUzMSBBbWF6b24gUHJpbWUgQ3VzdG9tZXIgUy5lcnZp?= =?utf-8?q?ce_Phone_Number_USA?= Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20361 Bug ID: 20361 Summary: New York Call 1 (???).247-1531 Amazon Prime Customer S.ervice Phone Number USA Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: matriya at givmail.com QA Contact: testopia at bugs.koha-community.org http://mefiwiki.com/wiki/New_York_Call_1_(%C8%A3%C8%A3%C8%A3).247-1531_Amazon_Prime_Customer_S.ervice_Phone_Number https://forums.developer.amazon.com/questions/126597/new-york-call-1-%C8%A3%C8%A3%C8%A3247-1531-amazon-prime-customer.html New York Call 1 (???).247-1531 Amazon Prime Customer S.ervice Phone Number USA New York Call 1 (???).247-1531 Amazon Prime Customer S.ervice Phone Number USA New York Call 1 (???).247-1531 Amazon Prime Customer S.ervice Phone Number USA New York Call 1 (???).247-1531 Amazon Prime Customer S.ervice Phone Number USA New York Call 1 (???).247-1531 Amazon Prime Customer S.ervice Phone Number USA New York Call 1 (???).247-1531 Amazon Prime Customer S.ervice Phone Number USA New York Call 1 (???).247-1531 Amazon Prime Customer S.ervice Phone Number USA New York Call 1 (???).247-1531 Amazon Prime Customer S.ervice Phone Number USA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 07:36:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 06:36:29 +0000 Subject: [Koha-bugs] [Bug 20361] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20361 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED Summary|New York Call 1 |SPAM |(???).247-1531 Amazon Prime | |Customer S.ervice Phone | |Number USA | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 07:46:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 06:46:05 +0000 Subject: [Koha-bugs] [Bug 18908] Warning "Compatibility levels before 9 are deprecated" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18908 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 07:46:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 06:46:08 +0000 Subject: [Koha-bugs] [Bug 18908] Warning "Compatibility levels before 9 are deprecated" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18908 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64865|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 72543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72543&action=edit Bug 18908: Warning "Compatibility levels before 9 are deprecated" The following output: dh: Compatibility levels before 9 are deprecated (level 7 in use) dh_testdir -O--fail-missing dh_auto_clean -O--fail-missing dh_auto_clean: Compatibility levels before 9 are deprecated (level 7 in use) dh_clean -O--fail-missing is given when trying to following these instructions: https://wiki.koha-community.org/wiki/Building_Debian_Packages_-_The_Easy_Way This merely tweaks the debian/compat file from 7 to 9. The message goes away. Signed-off-by: Marcel de Rooy >From https://www.debian.org/doc/manuals/maint-guide/dother.en.html: You may use compat level v9 in certain circumstances for compatibility with older systems. However, using any level below v9 is not recommended and should be avoided for new packages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 07:46:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 06:46:41 +0000 Subject: [Koha-bugs] [Bug 18908] Warning "Compatibility levels before 9 are deprecated" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18908 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch --- Comment #4 from Marcel de Rooy --- Combining SO+QA/trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 07:52:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 06:52:27 +0000 Subject: [Koha-bugs] [Bug 12812] Longoverdue.pl --mark-returned doesn't return items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12812 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 07:52:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 06:52:31 +0000 Subject: [Koha-bugs] [Bug 12812] Longoverdue.pl --mark-returned doesn't return items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12812 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71336|0 |1 is obsolete| | --- Comment #3 from Josef Moravec --- Created attachment 72544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72544&action=edit Bug 12812: Longoverdue.pl --mark-returned doesn't return items The longoverdue.pl option --mark-returned doesn't work unless the --charge option is used as well. Test Plan: 1) Run long overdue with --mark-returned and not --charge, note your items are marked lost but not returned 2) Apply this patch 3) Repeat step 1, the items should now get returned! Tested with (for example): misc/cronjobs/longoverdue.pl --lost 10=1 --mark-returned --verbose --confirm Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 07:52:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 06:52:34 +0000 Subject: [Koha-bugs] [Bug 12812] Longoverdue.pl --mark-returned doesn't return items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12812 --- Comment #4 from Josef Moravec --- Created attachment 72545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72545&action=edit Bug 12812: (Follow-up) Fix use of C4::Circulation Fixes this error: Undefined subroutine &main::MarkIssueReturned called at misc/cronjobs/longoverdue.pl line 316. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 07:52:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 06:52:58 +0000 Subject: [Koha-bugs] [Bug 12812] Longoverdue.pl --mark-returned doesn't return items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12812 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 07:58:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 06:58:36 +0000 Subject: [Koha-bugs] [Bug 20103] Remove Readonly::XS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 07:58:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 06:58:39 +0000 Subject: [Koha-bugs] [Bug 20103] Remove Readonly::XS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71071|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy --- Created attachment 72546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72546&action=edit Bug 20103: Remove Readonly::XS from PerlDependencies While having Readonly::XS is a good thing on slower systems the CPAN page for Readonly says it isn't required to be used directly, so we don't need to check for it. Additionally, even reading /usr/share/perl5/Readonly.pm you see "# Modern perl doesn't need Readonly::XS" on an if statement checking for version 5.8! Koha requires 5.20 (see C4::Log::cronlogaction's use of caller). TEST PLAN --------- Can you run a fresh install? Does the about page list Readonly::XS? It shouldn't after the patch. Run koha qa test tools Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 07:59:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 06:59:08 +0000 Subject: [Koha-bugs] [Bug 20103] Remove Readonly::XS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #3 from Marcel de Rooy --- Combining SO+QA / trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 08:02:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 07:02:30 +0000 Subject: [Koha-bugs] [Bug 17978] Circ rules will not limit holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69927|0 |1 is obsolete| | --- Comment #13 from Josef Moravec --- Created attachment 72547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72547&action=edit Bug 17978 - Circ rules will not limit holds The crux of this issue is that all those holds are unfilled record level holds. The code that checks for the number of holds the user already has *always* uses a branchcode of some form. Because of this, any open record level holds are completely ignored for this purpose. Test Plan: 1) Set ReservesControlBranch to "item's home library" 2) Set an All libraries/All Patrons/All itemtypes rules limiting a patron to 2 holds 3) Place 3 record level holds, you can but you should not be able to! 4) Delete the holds 5) Apply this patch 6) Attempt to place 3 record level holds 7) Note that you cannot! Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 08:02:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 07:02:26 +0000 Subject: [Koha-bugs] [Bug 17978] Circ rules will not limit holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 08:02:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 07:02:52 +0000 Subject: [Koha-bugs] [Bug 17978] Circ rules will not limit holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 08:05:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 07:05:23 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #42 from Katrin Fischer --- Just some questions, but I don't feel any of this is a blocker: - In the breadcrumbs the link says "News item" - why not use the heading in the breadcrumbs? - The RSS feed remains visible - is that intended? - OpacMainUserBlock remains at the bottom - is that intended? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 08:06:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 07:06:07 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50557|0 |1 is obsolete| | --- Comment #43 from Katrin Fischer --- Created attachment 72548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72548&action=edit Bug 14272: Show single news item (tests) Updates tests to match the modified NewsChannels module. Sponsored-by: Halland County Library Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 08:06:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 07:06:11 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70728|0 |1 is obsolete| | --- Comment #44 from Katrin Fischer --- Created attachment 72549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72549&action=edit Bug 14272: Show single news item (backend) Updates: * Date formatting added to get_opac_new() * Proper filtering by way of GetNewsToDisplay Sponsored-by: Halland County Library Signed-off-by: Aleisha Fixing merge conflicts Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 08:06:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 07:06:15 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70729|0 |1 is obsolete| | --- Comment #45 from Katrin Fischer --- Created attachment 72550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72550&action=edit Bug 14272: Show single news item (OPAC) This change makes the news shown on opac-main-pl have clickable headings which shows just that news item in isolation. This is to allow further patches that adds commentary functions. Sponsored-By: Halland County Library Test plan: * Apply this patch. * Go to OPAC main, you should see multiple news items by default. * If you do not see any, go to Staff interface and add a few. * Each nees item heading should be clickable. * When clicked only that item should be shown. * When 'news_id' is present, only a single news item should show. * The breadcrumb should say 'News item' after 'Home'. Updates: * Renamed URL parameter and local variables with 'news_' prefix. * Fixed Search-And-Replace error; 'news_news_id' => 'news_id' * Added breadcrumb for viewing single news item. * Updated OPAC to use new GetNewsToDisplay parameters * Fixed template formatting and calling of GetNewsToDisplay Signed-off-by: Aleisha Fixing merge conflicts Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 08:06:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 07:06:20 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 --- Comment #46 from Katrin Fischer --- Created attachment 72551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72551&action=edit Bug 14272: (follow-up) Show single news item Patch applies successfully and behaves as expected. Sponsored-by: Catalyst IT Signed-off-by: Dilan Johnpull? Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 08:06:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 07:06:55 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 08:06:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 07:06:58 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72065|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 08:13:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 07:13:18 +0000 Subject: [Koha-bugs] [Bug 19907] Email validation on patron add/edit not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19907 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED CC| |m.de.rooy at rijksmuseum.nl --- Comment #4 from Marcel de Rooy --- Depends on a report that is in ASSIGNED Changing status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 08:14:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 07:14:27 +0000 Subject: [Koha-bugs] [Bug 20362] New: Direct link to authority records missing in staff detail view (1xx, 7xx) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 Bug ID: 20362 Summary: Direct link to authority records missing in staff detail view (1xx, 7xx) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Add a link to the authority record from the detail patch for authors and contributors (1xx, 7xx) like they exist in the staff page and like it's implemented for subjects on bug 16427. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 08:16:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 07:16:19 +0000 Subject: [Koha-bugs] [Bug 16427] Direct link to authority records missing in staff detail view (MARC21 6xx) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16427 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Direct link to authority |Direct link to authority |records missing in staff |records missing in staff |detail view |detail view (MARC21 6xx) See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20362 Component|Staff Client |MARC Bibliographic data | |support CC| |chris at bigballofwax.co.nz --- Comment #9 from Katrin Fischer --- This works perfectly for the subjects, but not for the authors and contributurs (1xx, 7xx), would it be possible to get another patch for the others to complete this? I have filed bug 20362 so this can move on. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 08:16:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 07:16:20 +0000 Subject: [Koha-bugs] [Bug 20362] Direct link to authority records missing in staff detail view (1xx, 7xx) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16427 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 08:17:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 07:17:32 +0000 Subject: [Koha-bugs] [Bug 16427] Direct link to authority records missing in staff detail view (MARC21 6xx) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16427 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70742|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 72552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72552&action=edit Bug 16427: Add direct link to authority records from staff detail view (MARC21 subjects) I added a magnigying glass icon in the staff detail view that links to the authority records. Test Plan: 1) On the Koha staff page, create a new authority. The type of authority will be: Topical Term. 2) When creating authority, in tab 1 under -HEADING--TOPICAL TERM enter the topical term or geographic name entry element and then save the new authority e.g. science. 3) In circulation, search the catalog for a random book. Click the title of the book and you will be taken to the book details. 4) Edit the record and in tab 6, scroll down the - SUBJECT ADDED ENTRY--TOPICAL TERM and repeat this tag (the icon next to the title). 5) Edit the Topical term or geographic name entry element by clicking the button on the right of the bar. 6) In the Search main heading ($a only) enter your topical term e.g. science. 7) Press search, and then in the table that pops up, click 'choose'. 8) Save your edits and the new topical term will be in the 'Subject(s)' list of the book details. 9) Notice that there is no magnifying glass icon. 10) Apply this patch 11) Notice that there is now a magnifying glass icon next to the topical term. 12) Click on the magnifying glass and it will take you directly to the authorities records Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 08:17:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 07:17:29 +0000 Subject: [Koha-bugs] [Bug 16427] Direct link to authority records missing in staff detail view (MARC21 6xx) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16427 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 08:18:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 07:18:25 +0000 Subject: [Koha-bugs] [Bug 19353] Make possible to have custom XSL template for marcxml and marc21 metadata prefixes in OAI server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 08:20:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 07:20:09 +0000 Subject: [Koha-bugs] [Bug 19908] Password should not be mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 --- Comment #23 from Katrin Fischer --- Should this be assigned or another status? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 08:20:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 07:20:09 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 08:21:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 07:21:30 +0000 Subject: [Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 08:22:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 07:22:28 +0000 Subject: [Koha-bugs] [Bug 16117] Log borrower cardnumbers and item barcodes which are not valid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16117 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #6 from Marcel de Rooy --- See last two comments -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 08:30:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 07:30:43 +0000 Subject: [Koha-bugs] [Bug 16825] Add API route for getting an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #36 from Marcel de Rooy --- Running the test fails with me. # Subtest: Confirm effectiveness of OpacHiddenItems 1..7 ok 1 - GET /api/v1/items/21 not ok 2 - 200 OK # Failed test '200 OK' # at t/db_dependent/api/v1/items.t line 85. # got: '500' # expected: '200' not ok 3 - exact match for JSON Pointer "/itemnumber" # Failed test 'exact match for JSON Pointer "/itemnumber"' # at t/db_dependent/api/v1/items.t line 85. # got: undef # expected: '21' not ok 4 - exact match for JSON Pointer "/biblionumber" # Failed test 'exact match for JSON Pointer "/biblionumber"' # at t/db_dependent/api/v1/items.t line 85. # got: undef # expected: '32' ok 5 - exact match for JSON Pointer "/itemnotes_nonpublic" ok 6 - GET /api/v1/items/21 ok 7 - 404 Not Found # Looks like you failed 3 tests of 7. not ok 3 - Confirm effectiveness of OpacHiddenItems # Failed test 'Confirm effectiveness of OpacHiddenItems' # at t/db_dependent/api/v1/items.t line 96. ok 4 - GET /api/v1/items/21 not ok 5 - 200 OK # Failed test '200 OK' # at t/db_dependent/api/v1/items.t line 100. # got: '500' # expected: '200' not ok 6 - exact match for JSON Pointer "/itemnumber" # Failed test 'exact match for JSON Pointer "/itemnumber"' # at t/db_dependent/api/v1/items.t line 100. # got: undef # expected: '21' not ok 7 - exact match for JSON Pointer "/biblionumber" # Failed test 'exact match for JSON Pointer "/biblionumber"' # at t/db_dependent/api/v1/items.t line 100. # got: undef # expected: '32' not ok 8 - exact match for JSON Pointer "/itemnotes_nonpublic" # Failed test 'exact match for JSON Pointer "/itemnotes_nonpublic"' # at t/db_dependent/api/v1/items.t line 100. # got: undef # expected: 'Wb_gNO' # Looks like you failed 5 tests of 8. not ok 2 - get() tests # Failed test 'get() tests' # at t/db_dependent/api/v1/items.t line 107. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 08:40:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 07:40:30 +0000 Subject: [Koha-bugs] [Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Marcel de Rooy --- Test fails. Seems to be reported before. Versioning/packaging ? Needs further attention.. # Subtest: Create and delete named graphs 1..3 not ok 1 - 2 statements in model (in default graph and a named graph) # Failed test '2 statements in model (in default graph and a named graph)' # at t/Koha/RDF.t line 65. # got: '1' # expected: '2' not ok 2 - 3 statements in model (1 in default graph and 2 in separate named graphs # Failed test '3 statements in model (1 in default graph and 2 in separate named graphs' # at t/Koha/RDF.t line 71. # got: '1' # expected: '3' not ok 3 - 2 statements in model (1 in default graph and 1 in a named graph) after 1 of the named graphs was deleted # Failed test '2 statements in model (1 in default graph and 1 in a named graph) after 1 of the named graphs was deleted' # at t/Koha/RDF.t line 77. # got: '1' # expected: '2' # Looks like you failed 3 tests of 3. not ok 4 - Create and delete named graphs # Failed test 'Create and delete named graphs' # at t/Koha/RDF.t line 78. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 08:42:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 07:42:22 +0000 Subject: [Koha-bugs] [Bug 19940] Koha::Biblio - Remove GetBiblioItemInfosOf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19940 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #3 from Marcel de Rooy --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 08:43:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 07:43:37 +0000 Subject: [Koha-bugs] [Bug 19353] Make possible to have custom XSL template for marcxml and marc21 metadata prefixes in OAI server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69530|0 |1 is obsolete| | Attachment #69531|0 |1 is obsolete| | --- Comment #4 from Josef Moravec --- Created attachment 72553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72553&action=edit Bug 19353: Add test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 08:43:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 07:43:40 +0000 Subject: [Koha-bugs] [Bug 19353] Make possible to have custom XSL template for marcxml and marc21 metadata prefixes in OAI server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 --- Comment #5 from Josef Moravec --- Created attachment 72554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72554&action=edit Bug 19353: Ability to use xsl template on marc21 and marcxml metadataprefixes in OAI provider Test plan: 0) apply the patchset 1) setup oai server with oaiconf file defining xsl_file for metadata format marcxml or marc21 2) play with your oai and confirm that records are transformed as expected 3) prove t/db_dependent/OAI/Server.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 08:43:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 07:43:34 +0000 Subject: [Koha-bugs] [Bug 19353] Make possible to have custom XSL template for marcxml and marc21 metadata prefixes in OAI server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 08:51:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 07:51:18 +0000 Subject: [Koha-bugs] [Bug 19940] Koha::Biblio - Remove GetBiblioItemInfosOf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19940 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 08:51:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 07:51:21 +0000 Subject: [Koha-bugs] [Bug 19940] Koha::Biblio - Remove GetBiblioItemInfosOf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19940 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72438|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 72555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72555&action=edit Bug 19940: Koha::Biblio - Remove GetBiblioItemInfosOf This subroutine is only used once and can be replaced easily with a Koha::Biblioitems->search call Test plan: Test this on top of bug 19941 and confirm that the correct item types are displayed Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 08:57:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 07:57:58 +0000 Subject: [Koha-bugs] [Bug 20363] New: Privacy management shows misleading "No reading history to delete" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20363 Bug ID: 20363 Summary: Privacy management shows misleading "No reading history to delete" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: pasi.kallinen at joensuu.fi QA Contact: testopia at bugs.koha-community.org (OPACPrivacy is on) User views the "Your privacy" -page, it shows "No reading history to delete", even when the user has history. This is highly misleading. Error caused by commit 286be46e8a8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 09:00:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 08:00:48 +0000 Subject: [Koha-bugs] [Bug 20348] SIP2 patron identification fails to use userid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20348 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 09:02:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 08:02:52 +0000 Subject: [Koha-bugs] [Bug 20348] SIP2 patron identification fails to use userid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20348 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72539|0 |1 is obsolete| | --- Comment #4 from Josef Moravec --- Created attachment 72556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72556&action=edit Bug 20348: SIP2 patron identification fails to use userid Replaces "or" with "||" in variable assignment second attempt to retrieve borrower was not being executed due to changed precedence Signed-off-by: Colin Campbell Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 09:03:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 08:03:03 +0000 Subject: [Koha-bugs] [Bug 20348] SIP2 patron identification fails to use userid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20348 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.11 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 09:02:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 08:02:50 +0000 Subject: [Koha-bugs] [Bug 20348] SIP2 patron identification fails to use userid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20348 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 10:18:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 09:18:37 +0000 Subject: [Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Signed Off |Failed QA --- Comment #23 from Julian Maurice --- Patch works as expected and tests pass, but: - POD of SendQueuedMessages need to be updated - Also, minimal POD for _get_unsent_messages would be a nice addition -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 10:19:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 09:19:03 +0000 Subject: [Koha-bugs] [Bug 18625] update borrower last seen from SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68650|0 |1 is obsolete| | --- Comment #14 from Colin Campbell --- Created attachment 72557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72557&action=edit Added pod to update_lastseen method Add a pod entry to update lastseen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 10:20:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 09:20:56 +0000 Subject: [Koha-bugs] [Bug 18625] update borrower last seen from SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68651|0 |1 is obsolete| | --- Comment #15 from Colin Campbell --- Created attachment 72558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72558&action=edit correct typo in commit message s/Simply/Simplify/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 10:22:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 09:22:50 +0000 Subject: [Koha-bugs] [Bug 18625] update borrower last seen from SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #16 from Colin Campbell --- Amended patch to add the required pod reset status to resubmit for QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 11:32:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 10:32:46 +0000 Subject: [Koha-bugs] [Bug 19908] Password should not be mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 11:32:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 10:32:56 +0000 Subject: [Koha-bugs] [Bug 19908] Password should not be mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 11:32:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 10:32:34 +0000 Subject: [Koha-bugs] [Bug 19908] Password should not be mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #24 from Josef Moravec --- Switching back to Passed QA, see comment 20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 11:36:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 10:36:28 +0000 Subject: [Koha-bugs] [Bug 20364] New: Show languages from MARC21 field 041 in intranet Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 Bug ID: 20364 Summary: Show languages from MARC21 field 041 in intranet Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at joensuu.fi QA Contact: testopia at bugs.koha-community.org The encoded languages from MARC21 field 041 are not shown anywhere. These are quite important for example DVD video material (subtitle languages). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 11:38:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 10:38:04 +0000 Subject: [Koha-bugs] [Bug 20364] Show languages from MARC21 field 041 in intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at joensuu.fi |ity.org | --- Comment #1 from paxed --- Created attachment 72559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72559&action=edit Bug 20364: Show languages from MARC21 field 041 in intranet Show the language names coded in field 041, in intranet search results and in detail view. Test plan: 1) Apply patch 2) Do a search, and check the results look correct 3) Check some biblio detail pages that they look correct 4) Add some 041 subfields (a, b, d, h, j) in any combinations 5) Repeat 2 and 3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 12:12:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 11:12:47 +0000 Subject: [Koha-bugs] [Bug 19819] C4::Context->dbh is unreasonably slow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19819 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Signed Off |Failed QA --- Comment #11 from Julian Maurice --- I can confirm that with this patch, if I restart mysql server, koha is no longer able to connect to mysql until I restart (or reload) starman. Looking at the test script and times, this seems to save ~40?s by call (~8s / 200000 calls). That's not much. Do we know how many times by page dbh get called ? Changing status to Failed QA. The patch introduces a regression and I think we need more precise profiling data before changing the implementation of dbh. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 12:20:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 11:20:44 +0000 Subject: [Koha-bugs] [Bug 20365] New: Allow several open orders on subscription Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20365 Bug ID: 20365 Summary: Allow several open orders on subscription Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: severine.queune at bulac.fr QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Because of our contracts with vendors, we create acquisition baskets on june to renew our serial subscriptions for the next year. Most of the time, subscriptions for present year have not been received, for invoices are send at the end of the year. This is quite a problem for people who create the renewal baskets for only one open order in allowed on the same subscription. As budget can be defined for a given period (most of the time for a full year I imagine), it would be great if we could have several open orders allowed on the same subscription if the funds used belong to different budgets. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 12:21:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 11:21:34 +0000 Subject: [Koha-bugs] [Bug 19716] Add option to send header line for CSV output with runreport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19716 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69460|0 |1 is obsolete| | --- Comment #3 from Julian Maurice --- Created attachment 72560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72560&action=edit Bug 19716 - Add option to send header line for CSV output Currently, if outputting a CSV file using runreport.pl, you need to look at the report used to know what each column means. It would be nice if we could include column headers. Test Plan: 1) Apply this patch 2) Try using runreport.pl with --format csv --csv-header Signed-off-by: David Bourgault Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 12:21:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 11:21:56 +0000 Subject: [Koha-bugs] [Bug 19716] Add option to send header line for CSV output with runreport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19716 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 12:43:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 11:43:41 +0000 Subject: [Koha-bugs] [Bug 20341] Show authorized value description for withdrawn like damaged and lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20341 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 12:43:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 11:43:44 +0000 Subject: [Koha-bugs] [Bug 20341] Show authorized value description for withdrawn like damaged and lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20341 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72470|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 72561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72561&action=edit Bug 20341: Show authorized value description for withdrawn like damaged and lost Actually catalog detail page shows for damaged and lost items the authorized value description if exists. We must do the same for withdrawn information. Test plan : 1) Set for items a subfield linked to items.withdrawn and using the authorized value category 'WITHDRAWN' 2) Edit the authorized value category to add value '2' and description 'Eaten by dog' 3) Edit an item to set this withdrawn value 4) Go to staff interface and look at items in record detail page /cgi-bin/koh/catalogue/detail.pl : => Without patch you see 'Withdrawn' and with patch you see 'Eaten by dog' 5) Go to OPAc and look at items in record detail page /cgi-bin/koha/opac-detail.pl : => Without patch you see 'Withdrawn' and with patch you see 'Eaten by dog' Signed-off-by: delaye Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 12:43:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 11:43:50 +0000 Subject: [Koha-bugs] [Bug 20341] Show authorized value description for withdrawn like damaged and lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20341 --- Comment #5 from Kyle M Hall --- Created attachment 72562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72562&action=edit Bug 20341: Use AuthorisedValues plugin on the staff side Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 12:45:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 11:45:27 +0000 Subject: [Koha-bugs] [Bug 20341] Show authorized value description for withdrawn like damaged and lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20341 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72562|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 72563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72563&action=edit Bug 20341: Use AuthorisedValues plugin on the staff side Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 12:45:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 11:45:54 +0000 Subject: [Koha-bugs] [Bug 20341] Show authorized value description for withdrawn like damaged and lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20341 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 12:47:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 11:47:40 +0000 Subject: [Koha-bugs] [Bug 18342] Set memcached as 'enabled' by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18342 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 13:00:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 12:00:59 +0000 Subject: [Koha-bugs] [Bug 20366] New: More information about orders linked to subscriptions on "Acquisition details" tab Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 Bug ID: 20366 Summary: More information about orders linked to subscriptions on "Acquisition details" tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: severine.queune at bulac.fr QA Contact: testopia at bugs.koha-community.org On the 'Acquisition detail' tab on bibliographic record, we cant' know if orders are placed on bibliographic or subscription level. It is quite complicated when several subscriptions are attached to this record to have a clear history of the acquisitions. It would be great for order managers if we could have 2 more columns on this tab, one with the 'aqorders.subsciptionid' and one with 'subscription.callnumber'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 13:14:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 12:14:40 +0000 Subject: [Koha-bugs] [Bug 12812] Longoverdue.pl --mark-returned doesn't return items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12812 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72545|0 |1 is obsolete| | --- Comment #6 from Julian Maurice --- Created attachment 72565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72565&action=edit Bug 12812: (Follow-up) Fix use of C4::Circulation Fixes this error: Undefined subroutine &main::MarkIssueReturned called at misc/cronjobs/longoverdue.pl line 316. Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 13:14:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 12:14:36 +0000 Subject: [Koha-bugs] [Bug 12812] Longoverdue.pl --mark-returned doesn't return items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12812 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72544|0 |1 is obsolete| | --- Comment #5 from Julian Maurice --- Created attachment 72564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72564&action=edit Bug 12812: Longoverdue.pl --mark-returned doesn't return items The longoverdue.pl option --mark-returned doesn't work unless the --charge option is used as well. Test Plan: 1) Run long overdue with --mark-returned and not --charge, note your items are marked lost but not returned 2) Apply this patch 3) Repeat step 1, the items should now get returned! Tested with (for example): misc/cronjobs/longoverdue.pl --lost 10=1 --mark-returned --verbose --confirm Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 13:14:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 12:14:54 +0000 Subject: [Koha-bugs] [Bug 12812] Longoverdue.pl --mark-returned doesn't return items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12812 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 13:34:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 12:34:11 +0000 Subject: [Koha-bugs] [Bug 19233] Add ability to send itemnumbers in report results to batch modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69920|0 |1 is obsolete| | --- Comment #14 from Julian Maurice --- Created attachment 72566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72566&action=edit Bug 19233 - Add ability to send itemnumbers in report results to batch modification To test: 1 - Apply patch 2 - Run a report with an itemnumber column 3 - Note there is a linked '^' after column title 4 - Hover over the '^' 5 - You should see a tooltip 'Send visible items to batch modification' 6 - Click the '^' 7 - You should be sent to batch item modification with itemnumbers that were visible in report Signed-off-by: George Signed-off-by: BWS Sandboxes Signed-off-by: Katrin Fischer Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 13:34:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 12:34:15 +0000 Subject: [Koha-bugs] [Bug 19233] Add ability to send itemnumbers in report results to batch modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69921|0 |1 is obsolete| | --- Comment #15 from Julian Maurice --- Created attachment 72567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72567&action=edit Bug 19233: (follow-up) Send itemnumbers in report results to batch modification This patch changes the obscure "^" symbol to a styled link with the text "Batch modify." I think the only disadvantage of this is that it takes up more space, but it is outweighed by the improved clarity. This patch also makes minor indentation corrections to new lines of HTML. Signed-off-by: Katrin Fischer Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 13:34:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 12:34:36 +0000 Subject: [Koha-bugs] [Bug 19233] Add ability to send itemnumbers in report results to batch modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 13:38:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 12:38:17 +0000 Subject: [Koha-bugs] [Bug 19943] Koha::Biblio - Remove GetBiblioItemData In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70384|0 |1 is obsolete| | Attachment #70385|0 |1 is obsolete| | Attachment #70386|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 72568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72568&action=edit Bug 19943: Remove itemtype vs itype confusion in CanBookBeIssued Just a preliminary step to clean the code a bit in CanBookBeIssued. The effective item type is already set from GetItem and we do not need to deal with that again. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 13:38:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 12:38:14 +0000 Subject: [Koha-bugs] [Bug 19943] Koha::Biblio - Remove GetBiblioItemData In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 13:39:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 12:39:15 +0000 Subject: [Koha-bugs] [Bug 19943] Koha::Biblio - Remove GetBiblioItemData In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943 --- Comment #7 from Kyle M Hall --- Created attachment 72569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72569&action=edit Bug 19943: Koha::GetBiblioItemData - Replace existing occurrences The biblioitem's info can be retrieved with Koha::Biblio->biblioitem Test plan: 1. Use the age restriction to restrict checkouts for a given patron 2. Check some items of a biblio out, go to "Items" tab, then "View item's checkout history" link. Compare views with and without patches Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 13:39:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 12:39:47 +0000 Subject: [Koha-bugs] [Bug 19943] Koha::Biblio - Remove GetBiblioItemData In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943 --- Comment #8 from Kyle M Hall --- Created attachment 72570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72570&action=edit Bug 19943: Remove C4::Biblio::GetBiblioItemData It is no longer used. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 13:43:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 12:43:12 +0000 Subject: [Koha-bugs] [Bug 18255] Koha::Biblio - Remove GetBiblioItemByBiblioNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18255 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70379|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 72571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72571&action=edit Bug 18255: Replace GetBiblioItemByBiblioNumber with Koha::Biblio->biblioitem The subroutine GetBiblioItemByBiblioNumber considers that we have a 1-N relation between biblio and biblioitems, which is wrong (it's 1-1). So the calls can be replaced with Koha::biblio->biblioitem, it will ease the read of the code. Test plan: 1. Use the ILSDI service to display info of a bibliographic record, biblioitems fields must be displayed 2. Search for items, biblioitems info must be displayed as well in the result table Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 13:45:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 12:45:11 +0000 Subject: [Koha-bugs] [Bug 18255] Koha::Biblio - Remove GetBiblioItemByBiblioNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18255 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:00:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:00:18 +0000 Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |julian.maurice at biblibre.com Status|Signed Off |ASSIGNED --- Comment #11 from Julian Maurice --- (In reply to Nick Clemens from comment #10) > That works for me, Jonathan or Katrin, any input? If it sounds good I will > try to work on that or you can feel free Julian Changing status to ASSIGNED. Feel free to change it back directly to Signed off once the patch is ready. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:02:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:02:21 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:02:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:02:26 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72416|0 |1 is obsolete| | Attachment #72417|0 |1 is obsolete| | Attachment #72418|0 |1 is obsolete| | Attachment #72419|0 |1 is obsolete| | Attachment #72420|0 |1 is obsolete| | Attachment #72421|0 |1 is obsolete| | Attachment #72422|0 |1 is obsolete| | Attachment #72423|0 |1 is obsolete| | Attachment #72424|0 |1 is obsolete| | Attachment #72425|0 |1 is obsolete| | Attachment #72426|0 |1 is obsolete| | Attachment #72427|0 |1 is obsolete| | Attachment #72428|0 |1 is obsolete| | Attachment #72429|0 |1 is obsolete| | Attachment #72430|0 |1 is obsolete| | Attachment #72431|0 |1 is obsolete| | --- Comment #124 from Kyle M Hall --- Created attachment 72572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72572&action=edit Bug 18606: Add RotationCollections object classes Test plan: 1) Apply the patch 2) Update database 3) Go to tools -> Rotating collections and play with trying to break it: 3a) Add some collections 3b) Edit them 3c) Add some items to collections 3d) Remove some items 3e) Transfer some collections 3f) Try to remove collection without items 3g) Try to remove collection with items 4) Go to returns and: 4a) Try to return item from untransferred collection 4b) Try to return item from transferred collection 5) prove t/db_dependent/Koha/RotatingCollections.t t/db_dependent/Koha/Items.t t/db_dependent/Circulation.t t/db_dependent/Circulation/Returns.t Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:02:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:02:36 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #125 from Kyle M Hall --- Created attachment 72573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72573&action=edit Bug 18606: Easy ones - CRUD Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:02:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:02:44 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #127 from Kyle M Hall --- Created attachment 72575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72575&action=edit Bug 18606: Schema changes Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:02:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:02:40 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #126 from Kyle M Hall --- Created attachment 72574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72574&action=edit Bug 18606: Database changes - Add foreign keys to collections_tracking Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:02:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:02:48 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #128 from Kyle M Hall --- Created attachment 72576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72576&action=edit Bug 18606: Get rid of GetItemsInCollection Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:02:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:02:53 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #129 from Kyle M Hall --- Created attachment 72577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72577&action=edit Bug 18606: Get rid of GetCollectionItemBranches Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:02:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:02:58 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #130 from Kyle M Hall --- Created attachment 72578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72578&action=edit Bug 18606: Get rid of AddItemToCollection Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:03:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:03:03 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #131 from Kyle M Hall --- Created attachment 72579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72579&action=edit Bug 18606: Get rid of RemoveItemFromCollection Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:03:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:03:07 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #132 from Kyle M Hall --- Created attachment 72580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72580&action=edit Bug 18606: Get rid of TransferCollection Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:03:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:03:11 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #133 from Kyle M Hall --- Created attachment 72581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72581&action=edit Bug 18606: Get rid of isItemInThisCollection Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:03:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:03:21 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #135 from Kyle M Hall --- Created attachment 72583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72583&action=edit Bug 18606: Remove lefover of C4::RotatingCollections Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:03:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:03:17 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #134 from Kyle M Hall --- Created attachment 72582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72582&action=edit Bug 18606: Get rid of isItemInAnyCollection Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:03:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:03:26 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #136 from Kyle M Hall --- Created attachment 72584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72584&action=edit Bug 18606: Rework tests for rotating collections Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:03:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:03:30 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #137 from Kyle M Hall --- Created attachment 72585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72585&action=edit Bug 18606: Add test to t/db_dependent/Koha/Items.t Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:03:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:03:34 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #138 from Kyle M Hall --- Created attachment 72586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72586&action=edit Bug 18606: Unify handling of success/error messages Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:03:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:03:38 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #139 from Kyle M Hall --- Created attachment 72587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72587&action=edit Bug 18606: (Follow-up) Make QA tools happy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:03:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:03:51 +0000 Subject: [Koha-bugs] [Bug 16825] Add API route for getting an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://wiki.koha-community | |.org/wiki/Items_endpoint_RF | |C Keywords| |needs_rfc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:04:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:04:56 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #140 from Kyle M Hall --- QA question, should you not delete 'orphaned' collections_tracking rows before adding the foreign key constraints? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:05:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:05:51 +0000 Subject: [Koha-bugs] [Bug 19955] Add ability to process only one 'type' of message ( sms, email, etc ) for a given run of process_message_queue.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19955 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70781|0 |1 is obsolete| | --- Comment #6 from Tom?s Cohen Arazi --- Created attachment 72588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72588&action=edit Bug 19955: Add ability to process only one 'type' of message ( sms, email, etc ) for a given run of process_message_queue.pl It would be nice to allow emails to be sent overnight, but limit the sending of SMS messages to hours when people are awake. Adding a type limit to process_message_queue.pl would allow this to be accomplished easily. Signed-off-by: Charles Farmer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:06:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:06:00 +0000 Subject: [Koha-bugs] [Bug 19955] Add ability to process only one 'type' of message ( sms, email, etc ) for a given run of process_message_queue.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19955 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70782|0 |1 is obsolete| | --- Comment #7 from Tom?s Cohen Arazi --- Created attachment 72589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72589&action=edit Bug 19955: Minor grammatical correction Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:06:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:06:34 +0000 Subject: [Koha-bugs] [Bug 19955] Add ability to process only one 'type' of message ( sms, email, etc ) for a given run of process_message_queue.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19955 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:15:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:15:58 +0000 Subject: [Koha-bugs] [Bug 20267] Add basic .gitignore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72203|0 |1 is obsolete| | --- Comment #8 from Tom?s Cohen Arazi --- Created attachment 72590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72590&action=edit Bug 20267: Add basic .gitignore Ignore files generated by ExtUtils::MakeMaker NOTE: Limited scope does not affect files created by translation utilities Signed-off-by: Mark Tompsett Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:16:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:16:07 +0000 Subject: [Koha-bugs] [Bug 20267] Add basic .gitignore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267 --- Comment #9 from Tom?s Cohen Arazi --- Created attachment 72591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72591&action=edit Bug 20267: Add more ignores This patch adds more known files that should be ignored: - Devel::Cover output - NTYProf output - Known used IDE files Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:16:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:16:49 +0000 Subject: [Koha-bugs] [Bug 20267] Add basic .gitignore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |tomascohen at gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:20:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:20:50 +0000 Subject: [Koha-bugs] [Bug 18342] Set memcached as 'enabled' by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18342 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:30:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:30:38 +0000 Subject: [Koha-bugs] [Bug 20267] Add basic .gitignore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267 --- Comment #10 from Julian Maurice --- I'm not sure the IDE's stuff should go in there. It's not related to Koha and is different for everyone (I use Vim, some use Emacs and some strange people even use Eclipse :)) I'd rather keep these "personal settings" in $HOME/.config/git/ignore or .git/info/exclude -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:35:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:35:56 +0000 Subject: [Koha-bugs] [Bug 19819] C4::Context->dbh is unreasonably slow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19819 --- Comment #12 from David Gustafsson --- It actually has an significant impact on indexing (about 5 - 10% of execution time I think), but I have not had the time to think of a proper fix. I probably will some time in the near future, but I won't protest if someone wants to close the issue. I can open a new one when have a proper fix in that case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:42:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:42:22 +0000 Subject: [Koha-bugs] [Bug 20367] New: userid resets to firstname.surname when BorrowerUnwantedField contains userid Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20367 Bug ID: 20367 Summary: userid resets to firstname.surname when BorrowerUnwantedField contains userid Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: lari.taskula at jns.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To replicate: 1. In staff client, set your username to firstname 2. Add userid to BorrowerUnwantedField system preference 3. Go to your patron modification screen (memberentry.pl) and click Save 4. Observe you get kicked out into login screen, saying: Error: You do not have permission to access this page. Log in as a different user -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:43:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:43:43 +0000 Subject: [Koha-bugs] [Bug 18384] Add syspref to show all subs attached to a biblio in serial collection by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18384 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Sponsored |Seeking developer CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:43:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:43:29 +0000 Subject: [Koha-bugs] [Bug 7910] Batch renewal of serials and order creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr --- Comment #8 from S?verine Queune --- The BULAC (http://www.bulac.fr/) would like to sponsor this development ! As long as ?Change sponsored?? is set on ?Seeking developer?, anyone wanting to quote us for the development of such a feature or just ask for more information is welcome to write to us: . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:44:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:44:23 +0000 Subject: [Koha-bugs] [Bug 7910] Batch renewal of serials and order creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Seeking developer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:48:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:48:19 +0000 Subject: [Koha-bugs] [Bug 17877] Show internal and vendor note in acquisition info on subscription detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17877 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr --- Comment #1 from S?verine Queune --- The BULAC (http://www.bulac.fr/) would like to sponsor this development ! As long as ?Change sponsored?? is set on ?Seeking developer?, anyone wanting to quote us for the development of such a feature or just ask for more information is welcome to write to us: . -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:48:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:48:41 +0000 Subject: [Koha-bugs] [Bug 17877] Show internal and vendor note in acquisition info on subscription detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17877 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Seeking developer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:48:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:48:55 +0000 Subject: [Koha-bugs] [Bug 9898] Show order/receive date in acquisition detail table on subscription summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9898 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Seeking developer CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:49:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:49:08 +0000 Subject: [Koha-bugs] [Bug 9898] Show order/receive date in acquisition detail table on subscription summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9898 --- Comment #1 from S?verine Queune --- The BULAC (http://www.bulac.fr/) would like to sponsor this development ! As long as ?Change sponsored?? is set on ?Seeking developer?, anyone wanting to quote us for the development of such a feature or just ask for more information is welcome to write to us: . -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:50:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:50:00 +0000 Subject: [Koha-bugs] [Bug 18327] Reception date when receiving multiple issues for a subscription is not the good one In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Seeking developer --- Comment #1 from S?verine Queune --- The BULAC (http://www.bulac.fr/) would like to sponsor this development ! As long as ?Change sponsored?? is set on ?Seeking developer?, anyone wanting to quote us for the development of such a feature or just ask for more information is welcome to write to us: . -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:50:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:50:17 +0000 Subject: [Koha-bugs] [Bug 12104] add print label to serials receive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12104 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Seeking developer CC| |severine.queune at bulac.fr --- Comment #1 from S?verine Queune --- The BULAC (http://www.bulac.fr/) would like to sponsor this development ! As long as ?Change sponsored?? is set on ?Seeking developer?, anyone wanting to quote us for the development of such a feature or just ask for more information is welcome to write to us: . -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:50:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:50:26 +0000 Subject: [Koha-bugs] [Bug 20365] Allow several open orders on subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20365 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Seeking developer --- Comment #1 from S?verine Queune --- The BULAC (http://www.bulac.fr/) would like to sponsor this development ! As long as ?Change sponsored?? is set on ?Seeking developer?, anyone wanting to quote us for the development of such a feature or just ask for more information is welcome to write to us: . -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:50:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:50:41 +0000 Subject: [Koha-bugs] [Bug 19030] We need to mantain the connection order <-> subscription that we create in basket creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19030 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr Change sponsored?|--- |Seeking developer --- Comment #3 from S?verine Queune --- The BULAC (http://www.bulac.fr/) would like to sponsor this development ! As long as ?Change sponsored?? is set on ?Seeking developer?, anyone wanting to quote us for the development of such a feature or just ask for more information is welcome to write to us: . -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:51:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:51:04 +0000 Subject: [Koha-bugs] [Bug 15184] Ability to duplicate an existing order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Seeking developer CC| |severine.queune at bulac.fr --- Comment #1 from S?verine Queune --- The BULAC (http://www.bulac.fr/) would like to sponsor this development ! As long as ?Change sponsored?? is set on ?Seeking developer?, anyone wanting to quote us for the development of such a feature or just ask for more information is welcome to write to us: . -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:51:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:51:16 +0000 Subject: [Koha-bugs] [Bug 17876] Show more invoice information in subscription details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17876 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Seeking developer --- Comment #2 from S?verine Queune --- The BULAC (http://www.bulac.fr/) would like to sponsor this development ! As long as ?Change sponsored?? is set on ?Seeking developer?, anyone wanting to quote us for the development of such a feature or just ask for more information is welcome to write to us: . -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:51:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:51:29 +0000 Subject: [Koha-bugs] [Bug 20366] More information about orders linked to subscriptions on "Acquisition details" tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Seeking developer --- Comment #1 from S?verine Queune --- The BULAC (http://www.bulac.fr/) would like to sponsor this development ! As long as ?Change sponsored?? is set on ?Seeking developer?, anyone wanting to quote us for the development of such a feature or just ask for more information is welcome to write to us: . -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:51:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:51:38 +0000 Subject: [Koha-bugs] [Bug 20367] userid resets to firstname.surname when BorrowerUnwantedField contains userid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20367 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lari.taskula at jns.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:51:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:51:46 +0000 Subject: [Koha-bugs] [Bug 20367] userid resets to firstname.surname when BorrowerUnwantedField contains userid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20367 --- Comment #1 from Lari Taskula --- Created attachment 72592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72592&action=edit Bug 20367: Avoid resetting userid when BorrowerUnwantedField contains userid To test: 1. In staff client, set your username to firstname 2. Add userid to BorrowerUnwantedField system preference 3. Go to your patron modification screen (memberentry.pl) and click Save 4. Observe you get kicked out into login screen, saying: Error: You do not have permission to access this page. Log in as a different user 5. Apply patch and restart plack 6. Set your username back to firstname 7. Repeat step 3 8. Observe you were not kicked out and your userid stays the same -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:52:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:52:02 +0000 Subject: [Koha-bugs] [Bug 19943] Koha::Biblio - Remove GetBiblioItemData In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:52:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:52:10 +0000 Subject: [Koha-bugs] [Bug 19943] Koha::Biblio - Remove GetBiblioItemData In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:53:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:53:18 +0000 Subject: [Koha-bugs] [Bug 20367] userid resets to firstname.surname when BorrowerUnwantedField contains userid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20367 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14867 Severity|enhancement |normal Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:53:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:53:18 +0000 Subject: [Koha-bugs] [Bug 14867] userid not generated when defined in BorrowerUnwantedField In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14867 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20367 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:54:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:54:38 +0000 Subject: [Koha-bugs] [Bug 18426] Subscriptions batch editing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr --- Comment #14 from S?verine Queune --- Hi everyone ! I'm interested to work on this one during next hackfest. If no solution can be found during the next week, the BULAC would like to sponsor this development. Thanks to all of you ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:57:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:57:27 +0000 Subject: [Koha-bugs] [Bug 19819] C4::Context->dbh is unreasonably slow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19819 --- Comment #13 from Julian Maurice --- (In reply to David Gustafsson from comment #12) > It actually has an significant impact on indexing (about 5 - 10% of > execution time I think), but I have not had the time to think of a proper > fix. I probably will some time in the near future, but I won't protest if > someone wants to close the issue. I can open a new one when have a proper > fix in that case. No one is going to close the bug report, but the current patch cannot be accepted as it is. The bug report will stay open until you (or someone else) can provide a proper fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:57:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:57:46 +0000 Subject: [Koha-bugs] [Bug 19943] Koha::Biblio - Remove GetBiblioItemData In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72568|0 |1 is obsolete| | --- Comment #9 from Tom?s Cohen Arazi --- Created attachment 72593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72593&action=edit Bug 19943: Remove itemtype vs itype confusion in CanBookBeIssued Just a preliminary step to clean the code a bit in CanBookBeIssued. The effective item type is already set from GetItem and we do not need to deal with that again. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:57:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:57:56 +0000 Subject: [Koha-bugs] [Bug 19943] Koha::Biblio - Remove GetBiblioItemData In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72569|0 |1 is obsolete| | --- Comment #10 from Tom?s Cohen Arazi --- Created attachment 72594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72594&action=edit Bug 19943: Koha::GetBiblioItemData - Replace existing occurrences The biblioitem's info can be retrieved with Koha::Biblio->biblioitem Test plan: 1. Use the age restriction to restrict checkouts for a given patron 2. Check some items of a biblio out, go to "Items" tab, then "View item's checkout history" link. Compare views with and without patches Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:58:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:58:03 +0000 Subject: [Koha-bugs] [Bug 19943] Koha::Biblio - Remove GetBiblioItemData In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72570|0 |1 is obsolete| | --- Comment #11 from Tom?s Cohen Arazi --- Created attachment 72595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72595&action=edit Bug 19943: Remove C4::Biblio::GetBiblioItemData It is no longer used. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:58:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:58:09 +0000 Subject: [Koha-bugs] [Bug 19943] Koha::Biblio - Remove GetBiblioItemData In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943 --- Comment #12 from Tom?s Cohen Arazi --- Created attachment 72596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72596&action=edit Bug 19943: Gentle error handling for bookcount.pl This patch tests the required parameters and redirects with a 400 HTTP code if parameters are invalid. It also removes the need for the passed biblioitemnumber which is not used at all. A (now) useless sub is removed too. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 14:58:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 13:58:32 +0000 Subject: [Koha-bugs] [Bug 19943] Koha::Biblio - Remove GetBiblioItemData In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 15:00:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 14:00:40 +0000 Subject: [Koha-bugs] [Bug 20267] Add basic .gitignore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267 --- Comment #11 from Tom?s Cohen Arazi --- (In reply to Julian Maurice from comment #10) > I'm not sure the IDE's stuff should go in there. It's not related to Koha > and is different for everyone (I use Vim, some use Emacs and some strange > people even use Eclipse :)) > I'd rather keep these "personal settings" in $HOME/.config/git/ignore or > .git/info/exclude We could add those too :-D Feel free to remove them if you wish. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 15:04:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 14:04:12 +0000 Subject: [Koha-bugs] [Bug 20367] userid resets to firstname.surname when BorrowerUnwantedField contains userid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20367 --- Comment #2 from Lari Taskula --- Additionally, make sure test plan provided in Bug 14867 still works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 15:14:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 14:14:07 +0000 Subject: [Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 --- Comment #24 from M. Tompsett --- Created attachment 72597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72597&action=edit Bug 18570: QA Followup - Improved POD This tweaks the perldoc for SendQueuedMessages and adds some for _get_unsent_messages. TEST PLAN --------- perldoc C4::Letters -- look at _add_attachments (ugly), _get_unsent_messages (non-existent), SendQueuedMessages (no reference to borrowernumber or letter_code). apply patch perldoc C4::Letters -- confirm that SendQueuedMessages and _get_unsent_messages have reasonable POD information. -- notice how _add_attachments' POD is now readable run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 15:16:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 14:16:14 +0000 Subject: [Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #25 from M. Tompsett --- Changing to signed off, as POD doesn't affect code, and the Failed QA reason in comment #23 is solely POD. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 15:20:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 14:20:57 +0000 Subject: [Koha-bugs] [Bug 20120] Writeoffs for individual fees allows an amount to be written off more than the amount of the fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 15:21:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 14:21:00 +0000 Subject: [Koha-bugs] [Bug 20120] Writeoffs for individual fees allows an amount to be written off more than the amount of the fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71177|0 |1 is obsolete| | Attachment #71358|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 72598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72598&action=edit Bug 20120: Writeoffs for individual fees allows an amount to be written off more than the amount of the fee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 15:21:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 14:21:22 +0000 Subject: [Koha-bugs] [Bug 20120] Writeoffs for individual fees allows an amount to be written off more than the amount of the fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 --- Comment #14 from Kyle M Hall --- This version prevents over-writeoffs completely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 15:23:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 14:23:02 +0000 Subject: [Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72531|0 |1 is obsolete| | --- Comment #26 from Julian Maurice --- Created attachment 72599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72599&action=edit Bug 18570: Tests to prove if email send was attempted kshell prove -v t/db_dependent/Passwordrecovery.t Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 15:23:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 14:23:07 +0000 Subject: [Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72532|0 |1 is obsolete| | --- Comment #27 from Julian Maurice --- Created attachment 72600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72600&action=edit Bug 18570: Prove that the letter code parameter tweaks work Run the following commands: kshell prove -v t/db_dependent/Letters.t Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 15:23:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 14:23:14 +0000 Subject: [Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72533|0 |1 is obsolete| | --- Comment #28 from Julian Maurice --- Created attachment 72601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72601&action=edit Bug 18570: Send Password Reset Emails immediately Run through the password reset process, and your server should send the message immediate, not waiting for the cronjob. Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 15:23:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 14:23:18 +0000 Subject: [Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72597|0 |1 is obsolete| | --- Comment #29 from Julian Maurice --- Created attachment 72602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72602&action=edit Bug 18570: QA Followup - Improved POD This tweaks the perldoc for SendQueuedMessages and adds some for _get_unsent_messages. TEST PLAN --------- perldoc C4::Letters -- look at _add_attachments (ugly), _get_unsent_messages (non-existent), SendQueuedMessages (no reference to borrowernumber or letter_code). apply patch perldoc C4::Letters -- confirm that SendQueuedMessages and _get_unsent_messages have reasonable POD information. -- notice how _add_attachments' POD is now readable run koha qa test tools Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 15:24:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 14:24:08 +0000 Subject: [Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #30 from Julian Maurice --- Thanks for the follow-up Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 15:26:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 14:26:29 +0000 Subject: [Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 --- Comment #26 from Kyle M Hall --- Created attachment 72603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72603&action=edit Bug 20123: Add commented out example to koha-conf.xml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 15:26:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 14:26:48 +0000 Subject: [Koha-bugs] [Bug 18255] Koha::Biblio - Remove GetBiblioItemByBiblioNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18255 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 15:26:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 14:26:53 +0000 Subject: [Koha-bugs] [Bug 18255] Koha::Biblio - Remove GetBiblioItemByBiblioNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18255 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72571|0 |1 is obsolete| | --- Comment #7 from Tom?s Cohen Arazi --- Created attachment 72604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72604&action=edit Bug 18255: Replace GetBiblioItemByBiblioNumber with Koha::Biblio->biblioitem The subroutine GetBiblioItemByBiblioNumber considers that we have a 1-N relation between biblio and biblioitems, which is wrong (it's 1-1). So the calls can be replaced with Koha::biblio->biblioitem, it will ease the read of the code. Test plan: 1. Use the ILSDI service to display info of a bibliographic record, biblioitems fields must be displayed 2. Search for items, biblioitems info must be displayed as well in the result table Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 15:29:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 14:29:21 +0000 Subject: [Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72603|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall --- Created attachment 72605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72605&action=edit Bug 20123: Add commented out example to koha-conf.xml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 15:30:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 14:30:04 +0000 Subject: [Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #28 from Kyle M Hall --- Added followup to document the feature in the koha conf. Is there anything else still needed for QA? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 15:46:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 14:46:46 +0000 Subject: [Koha-bugs] [Bug 3758] Automatic Exchange Rates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3758 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #4 from M. Tompsett --- (In reply to Paul Poulain from comment #1) > I prefer colin suggestion = having a batch that update rates. > It does not exist either, problem still relevant then. A patch anyone ? Here you go. :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 15:48:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 14:48:09 +0000 Subject: [Koha-bugs] [Bug 3758] Automatic Exchange Rates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3758 --- Comment #5 from M. Tompsett --- Created attachment 72606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72606&action=edit Automagically fill currency table. Yes, it isn't a friendly patch format, because I have no idea where to drop it. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 15:52:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 14:52:07 +0000 Subject: [Koha-bugs] [Bug 18626] Add ability to track cardnumber changes for patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18626 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 15:52:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 14:52:22 +0000 Subject: [Koha-bugs] [Bug 18626] Add ability to track cardnumber changes for patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18626 --- Comment #8 from Kyle M Hall --- Created attachment 72608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72608&action=edit Bug 18626: Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 15:52:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 14:52:34 +0000 Subject: [Koha-bugs] [Bug 18626] Add ability to track cardnumber changes for patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18626 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 15:52:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 14:52:11 +0000 Subject: [Koha-bugs] [Bug 18626] Add ability to track cardnumber changes for patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18626 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69467|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 72607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72607&action=edit Bug 18626 - Add ability to track cardnumber changes for patrons Some libraries want to keep a history of cardnumber changes for a patron. This is a feature that another ILS has. Test Plan: 1) Apply this patch 2) Enable the BorrowersLog 3) Modify a patron, update his or her cardnumber 4) Notice the entry in the action log containing the old and new cardnumbers 5) Edit a patron, leave the cardnumber the same 6) Note there is no cardnumber change entry in the action logs 7) Disable BorrowersLog, modify a patron cardnumber 8) Note there is no cardnumber change entry in teh action logs Followed test plan, works as expected Signed-off-by: Marc V?ron Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 15:54:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 14:54:06 +0000 Subject: [Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=3578 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 15:54:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 14:54:06 +0000 Subject: [Koha-bugs] [Bug 3578] different_IP auth is too strict for many services In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3578 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18888 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 15:54:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 14:54:16 +0000 Subject: [Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=4078 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 15:54:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 14:54:16 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18888 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 15:54:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 14:54:28 +0000 Subject: [Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community |https://bugs.koha-community |.org/bugzilla3/show_bug.cgi |.org/bugzilla3/show_bug.cgi |?id=3578 |?id=3758 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 15:54:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 14:54:28 +0000 Subject: [Koha-bugs] [Bug 3578] different_IP auth is too strict for many services In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3578 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18888 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 15:54:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 14:54:28 +0000 Subject: [Koha-bugs] [Bug 3758] Automatic Exchange Rates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3758 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18888 -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 16:02:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 15:02:41 +0000 Subject: [Koha-bugs] [Bug 18626] Add ability to track cardnumber changes for patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18626 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72608|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 72609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72609&action=edit Bug 18626: Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 16:07:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 15:07:48 +0000 Subject: [Koha-bugs] [Bug 18382] action_logs entry for module HOLDS, action SUSPEND is spammy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18382 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 16:07:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 15:07:51 +0000 Subject: [Koha-bugs] [Bug 18382] action_logs entry for module HOLDS, action SUSPEND is spammy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18382 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68363|0 |1 is obsolete| | Attachment #68364|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 72610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72610&action=edit Bug 18382: action_logs entry for module HOLDS, action SUSPEND is spammy When a hold is suspended, 'suspend_until' is represented as a DateTime object, complete with locale. All told, this is about 800 lines of text. Test Plan: 1) Enable the HoldsLog syspref 2) Add a hold on a record/item 3) Suspend the hold with a date to resume 4) Note the massive amount of date in the suspend_until field 5) Apply this patch 6) Suspend another hold with a date to resume 7) Note the log has an acutal date in the suspend_until field Check the logs using module 'Holds' and Action 'Suspend' Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 16:08:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 15:08:58 +0000 Subject: [Koha-bugs] [Bug 18382] action_logs entry for module HOLDS, action SUSPEND is spammy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18382 --- Comment #11 from Kyle M Hall --- (In reply to Marcel de Rooy from comment #9) > Your solution is not limited to action_logs. > You truncate, so to speak, already at the holds level. > Please add your fix at the hold unblessed level when sending it to the logs. > Squash the patches too. > Thanks. I'm not sure I understand your request. Can you give me a bit more detail? Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 16:15:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 15:15:09 +0000 Subject: [Koha-bugs] [Bug 20267] Add basic .gitignore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267 --- Comment #12 from Julian Maurice --- (In reply to Tom?s Cohen Arazi from comment #11) > (In reply to Julian Maurice from comment #10) > > I'm not sure the IDE's stuff should go in there. It's not related to Koha > > and is different for everyone (I use Vim, some use Emacs and some strange > > people even use Eclipse :)) > > I'd rather keep these "personal settings" in $HOME/.config/git/ignore or > > .git/info/exclude > > We could add those too :-D I don't need to, Vim temporary files are already ignored by my global git config > Feel free to remove them if you wish. I won't remove them (it won't affect me after all) and I'll let RM have the final word. But let me try to convince you :) - If anyone adds their personal preferences to this file, it can quickly become bloated (for instance I also use ctags, so I choose to ignore /.ctags and /TAGS, and I also have .proverc and .prove) - If you add these preferences to $HOME/.config/git/ignore instead, the rules work across all your git repositories, so you don't have add them again and again to all the repositories you are working on. So it's good for Koha (clean .gitignore) and good for you (your custom ignore rules all in one place) :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 16:44:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 15:44:02 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71165|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 72611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72611&action=edit Bug 15985 - Include transacting library in fines Some librarians would like to see the library an item was checked out from in the fines table on the fines payment page. Test Plan: 1) Apply this patch 2) Find a patron with overdue items that have fines 3) Browse to the pay fines page 4) Note the new "checked out from" column Signed-off-by: Jason Robb -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 16:43:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 15:43:59 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 16:44:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 15:44:10 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 --- Comment #9 from Kyle M Hall --- Created attachment 72612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72612&action=edit Bug 15985: Add new method Koha::Account::Line::checkout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 16:48:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 15:48:23 +0000 Subject: [Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 Maksim Sen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 16:48:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 15:48:26 +0000 Subject: [Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 Maksim Sen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69433|0 |1 is obsolete| | --- Comment #6 from Maksim Sen --- Created attachment 72613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72613&action=edit Bug 19708 - Remove useless code from opac-basket This removes a lot of useless code relating to the print function from opac-basket.tt, opac-basket.pl and opac/basket.js. It also fixes the CSS so that no extra blank page is printed. To test: 0) Add an item to your cart 1) Print your basket Note the appearance of the page. There will be an extra blank page. 2) Apply patch 3) Reload basket 4) Print your basket The appearce should be identical. The extra blank page is gone. This only affects the OPAC. Signed-off-by: Tom?s Cohen Arazi Signed-off-by: Tom?s Cohen Arazi Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 16:55:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 15:55:16 +0000 Subject: [Koha-bugs] [Bug 17826] Allow extended patron attributes to be sent in arbitrary SIP2 fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17826 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 16:54:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 15:54:51 +0000 Subject: [Koha-bugs] [Bug 20323] Batch patron modification tool broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20323 Chris Slone changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone at camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 16:55:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 15:55:19 +0000 Subject: [Koha-bugs] [Bug 17826] Allow extended patron attributes to be sent in arbitrary SIP2 fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17826 --- Comment #14 from Kyle M Hall --- Created attachment 72614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72614&action=edit Bug 17826 - Add POD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 16:56:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 15:56:18 +0000 Subject: [Koha-bugs] [Bug 17826] Allow extended patron attributes to be sent in arbitrary SIP2 fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17826 --- Comment #15 from Kyle M Hall --- For some reason I cannot get the qa script to believe this sub has POD. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 16:56:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 15:56:23 +0000 Subject: [Koha-bugs] [Bug 19955] Add ability to process only one 'type' of message ( sms, email, etc ) for a given run of process_message_queue.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19955 Chris Slone changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone at camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 16:56:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 15:56:50 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Chris Slone changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone at camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 17:22:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 16:22:27 +0000 Subject: [Koha-bugs] [Bug 18791] Add the ability for librarians to easily copy, download or print DataTables based tables in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18791 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 17:22:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 16:22:30 +0000 Subject: [Koha-bugs] [Bug 18791] Add the ability for librarians to easily copy, download or print DataTables based tables in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18791 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64233|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 72615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72615&action=edit Bug 18791 - Add the ability for librarians to easily copy, download or print DataTables based tables in Koha There are many tables in Koha where it would be useful for librarians to easily copy, download or print the table for various purposes. These functions are available via DataTables button plugins. Test Plan: 1) Clear your browser cache ( just in case ) 2) Apply this patch 3) Browse to boraccount.pl ( or another page using DataTabes ) 4) Note the new Excel, CSV, Copy and Print buttons 5) Test each button to ensure they work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 17:22:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 16:22:38 +0000 Subject: [Koha-bugs] [Bug 18791] Add the ability for librarians to easily copy, download or print DataTables based tables in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18791 --- Comment #7 from Kyle M Hall --- Created attachment 72616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72616&action=edit Bug 18791 - Make buttons translatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 17:24:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 16:24:41 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Roch D'Amour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72064|0 |1 is obsolete| | --- Comment #61 from Roch D'Amour --- Created attachment 72617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72617&action=edit Bug 12532 - Send emails to guarantee and guarantor Fixed patch didnt apply. Adds setting "RedirectGuaranteeEmail". When setting is enabled, emails to patron with a guarantor will be send to both guarantor and guarantee. Does this by amending the Koha::Patrons::notice_email_address sub. It does not affect values in the message_queue table. Test plan: Before applying 1) Select patron with guarantor 2) Enable checkout emails 3) Checkout item. Email will be sent only to guarantee 4) Apply patch 5) Run updatedatabase.pl 6) Enable 'RedirectGuaranteeEmail' in system preferences 7) Go through step 1) to 3). Email should now be sent to both. 8) Run t/db_dependant/Members.t Sponsored by: Ville de Victoriaville -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 18:53:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 17:53:02 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_20368=5D_New=3A_Home_=E2=80=BA_Repor?= =?utf-8?q?ts_=3E_Catalog_by_itemtype_triggers_Internal_Server_Error?= Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20368 Bug ID: 20368 Summary: Home ? Reports > Catalog by itemtype triggers Internal Server Error Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Steps to replicate. Navigate to reports page click on 'Catalog by itemtype'. This causes an Internal Server Error. Plack error logs show: Can't locate /usr/share/koha/intranet/cgi-bin/reports/itemtypes.plugin in @INC (@INC contains: /usr/share/koha/lib /usr/share/koha/installer /usr/share/koha/lib/installer /usr/share/koha/installer /usr/share/koha/lib/installer /usr/share/koha/installer /usr/share/koha/lib/installer /usr/share/koha/installer /usr/share/koha/lib/installer /usr/share/koha/installer /usr/share/koha/lib/installer /usr/share/koha/installer /usr/share/koha/lib/installer /usr/share/koha/installer /usr/share/koha/lib/installer /usr/share/koha/installer /usr/share/koha/lib/installer /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 /usr/local/lib/site_perl .) at /usr/share/koha/intranet/cgi-bin/reports/manager.pl line 50. Bug is not showing in 17.05.05 but does show in 17.05.08.000 & 17.11.02.000 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 20:03:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 19:03:35 +0000 Subject: [Koha-bugs] [Bug 20369] New: Analytics search is broken with QueryAutoTruncate set to 'only if * is added' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20369 Bug ID: 20369 Summary: Analytics search is broken with QueryAutoTruncate set to 'only if * is added' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: * Disable QueryAutoTruncate * Create an analytic record, add some host items to it * Browser to the analytics tab for the record * Click the link in the 'used in' column of the table * No search results * Enable QueryAutoTruncate * Reload the page, now you get the analytic record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 20:06:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 19:06:54 +0000 Subject: [Koha-bugs] [Bug 20369] Analytics search is broken with QueryAutoTruncate set to 'only if * is added' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20369 --- Comment #1 from Kyle M Hall --- I should note this is using EasyAnalytics -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 20:32:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 19:32:34 +0000 Subject: [Koha-bugs] [Bug 9701] Configure default indicators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 Maksim Sen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maksim.sen at inlibro.com --- Comment #32 from Maksim Sen --- Hey Josef, I tried doing this test: prove t/db_dependent/Biblio.t should be green Before applying the patches I had this: prove t/db_dependent/Biblio.t t/db_dependent/Biblio.t .. ok All tests successful. Files=1, Tests=9, 2 wallclock secs ( 0.05 usr 0.01 sys + 1.91 cusr 0.09 csys = 2.06 CPU) Result: PASS After applying the patches I had this: prove t/db_dependent/Biblio.t t/db_dependent/Biblio.t .. 7/9 DBD::mysql::st execute failed: Unknown column 'ind1_defaultvalue' in 'field list' [for Statement "SELECT tagfield,liblibrarian,libopac,mandatory,repeatable,ind1_defaultvalue,ind2_defaultvalue FROM marc_tag_structure WHERE frameworkcode=? ORDER BY tagfield" with ParamValues: 0=''] at /inlibro/git/koha-master-dev-inlibro/C4/Biblio.pm line 990. DBD::mysql::st fetchrow failed: fetch() without execute() [for Statement "SELECT tagfield,liblibrarian,libopac,mandatory,repeatable,ind1_defaultvalue,ind2_defaultvalue FROM marc_tag_structure WHERE frameworkcode=? ORDER BY tagfield" with ParamValues: 0=''] at /inlibro/git/koha-master-dev-inlibro/C4/Biblio.pm line 993. # Failed test 'expect 6 internals' # at t/db_dependent/Biblio.t line 436. # got: '0' # expected: '6' # Failed test 'check lib' # at t/db_dependent/Biblio.t line 437. # got: '0' # expected: '1' # Failed test 'check tab' # at t/db_dependent/Biblio.t line 438. # got: '0' # expected: '1' # Failed test 'check mandatory' # at t/db_dependent/Biblio.t line 439. # got: '0' # expected: '1' # Failed test 'check repeatable' # at t/db_dependent/Biblio.t line 440. # got: '0' # expected: '1' # Failed test 'check indicator 1 default value' # at t/db_dependent/Biblio.t line 442. # got: '0' # expected: '1' # Failed test 'check indicator 2 default value' # at t/db_dependent/Biblio.t line 443. # got: '0' # expected: '1' # Looks like you failed 7 tests of 8. # Failed test 'IsMarcStructureInternal' # at t/db_dependent/Biblio.t line 444. # Looks like you failed 1 test of 9. t/db_dependent/Biblio.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/9 subtests Test Summary Report ------------------- t/db_dependent/Biblio.t (Wstat: 256 Tests: 9 Failed: 1) Failed test: 8 Non-zero exit status: 1 Files=1, Tests=9, 3 wallclock secs ( 0.05 usr 0.00 sys + 2.01 cusr 0.10 csys = 2.16 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 20:35:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 19:35:48 +0000 Subject: [Koha-bugs] [Bug 18791] Add the ability for librarians to easily copy, download or print DataTables based tables in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18791 Roch D'Amour changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 20:35:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 19:35:51 +0000 Subject: [Koha-bugs] [Bug 18791] Add the ability for librarians to easily copy, download or print DataTables based tables in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18791 Roch D'Amour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72616|0 |1 is obsolete| | --- Comment #8 from Roch D'Amour --- Created attachment 72618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72618&action=edit Bug 18791 - Make buttons translatable Signed-off-by: Roch D'Amour -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 20:47:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 19:47:26 +0000 Subject: [Koha-bugs] [Bug 11936] Consistent log message for item insert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936 Maksim Sen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 20:47:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 19:47:28 +0000 Subject: [Koha-bugs] [Bug 11936] Consistent log message for item insert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936 Maksim Sen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72066|0 |1 is obsolete| | --- Comment #5 from Maksim Sen --- Created attachment 72619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72619&action=edit Bug 11936 - Consistent log message for item insert If you use bulkmarcimport.pl to import records with items it looks like the successfull insert of the record is reported multiple time, but the second and subsequent "ok" is really related to importing the item(s). This patch changes the log message on successfully inserting an item to match the log message given when inserting an item fails. To test, the easy way: - Look at lines 530 and 536 of bulkmarcimport.pl, and note that the "op" in those two lines are different - Apply the patch - Look at lines 530 and 536 again, and note that the "op" is now identical, and that this makes sense, since they are both related to the same operation, specifically inserting an item To test, the hard way - Have some records with items - Import the records with bulkmarcimport.pl, and make sure to specify the -l option, to create a log of the actions taken - Look at the log and verify it looks something like this: id;operation;status 1;insert;ok 1;insert;ok 2;insert;ok 2;insert;ok - Apply this patch and import some more records with items. The log should now be similar to this: id;operation;status 1;insert;ok 1;insertitem;ok 2;insert;ok 2;insertitem;ok Signed-off-by: Maksim Sen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 20:48:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 19:48:40 +0000 Subject: [Koha-bugs] [Bug 9701] Configure default indicators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 --- Comment #33 from Josef Moravec --- (In reply to Maksim Sen from comment #32) > > After applying the patches I had this: > prove t/db_dependent/Biblio.t > t/db_dependent/Biblio.t .. 7/9 DBD::mysql::st execute failed: Unknown column > 'ind1_defaultvalue' in 'field list' did you perform database update? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 21:16:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 20:16:54 +0000 Subject: [Koha-bugs] [Bug 20282] Wrong attribute in template calls to match holding branch when adding/editing a course reserve item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20282 Maksim Sen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 21:16:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 20:16:56 +0000 Subject: [Koha-bugs] [Bug 20282] Wrong attribute in template calls to match holding branch when adding/editing a course reserve item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20282 Maksim Sen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72112|0 |1 is obsolete| | --- Comment #2 from Maksim Sen --- Created attachment 72620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72620&action=edit Bug 20282: Match course reserve on holdingbranch To test: 1 - Add a course (Course Reserves) 2 - Add an item to the course 3 - Ensure to change the holding branch for the course reserve 4 - Modify the course item 5 - Note the dropdwn for holding branch is unset 6 - Apply patch 7 - Modify the course item 8 - Dropdown should be correctly populated Signed-off-by: Maksim Sen -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 21:18:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 20:18:13 +0000 Subject: [Koha-bugs] [Bug 20282] Wrong attribute in template calls to match holding branch when adding/editing a course reserve item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20282 Maksim Sen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maksim.sen at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 21:19:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 20:19:14 +0000 Subject: [Koha-bugs] [Bug 11936] Consistent log message for item insert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936 Maksim Sen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maksim.sen at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 22:13:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 21:13:15 +0000 Subject: [Koha-bugs] [Bug 19983] Switch single-column templates to Bootstrap grid: Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 Roch D'Amour changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roch.damour at inlibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Roch D'Amour --- Sorry, patch does not apply :( I get: fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 22:13:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 21:13:31 +0000 Subject: [Koha-bugs] [Bug 20045] Switch single-column templates to Bootstrap grid: Various In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20045 Roch D'Amour changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roch.damour at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 22:29:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 21:29:34 +0000 Subject: [Koha-bugs] [Bug 20305] Warnings in tools scripts need to be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20305 Maksim Sen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maksim.sen at inlibro.com --- Comment #3 from Maksim Sen --- +1 for test plan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 22:34:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 21:34:38 +0000 Subject: [Koha-bugs] [Bug 20045] Switch single-column templates to Bootstrap grid: Various In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20045 Roch D'Amour changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 22:34:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 21:34:41 +0000 Subject: [Koha-bugs] [Bug 20045] Switch single-column templates to Bootstrap grid: Various In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20045 Roch D'Amour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72509|0 |1 is obsolete| | --- Comment #4 from Roch D'Amour --- Created attachment 72621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72621&action=edit Bug 20045: Switch single-column templates to Bootstrap grid: Various This patch updates various unrelated templates to use the Bootstrap grid. - about.tt - The about page - auth.tt - The login page These pages should look correct. - reports/reports-home.tt - The reports home page - admin/admin-home.tt - The administration home page These pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. - serials/subscription-add.tt - Serials -> Add subscription. The entry form should look correct during each step of the add/edit process. - suggestion/suggestion.tt - Acquisitions -> Suggestions -> New suggestion. The page with the new suggestion form should look correct. Signed-off-by: Roch D'Amour -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 9 23:20:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Mar 2018 22:20:18 +0000 Subject: [Koha-bugs] [Bug 20360] Auto-Renew notices send in advance of No Renewal Before period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20360 Jess Tobin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lara005 at gmail.com --- Comment #2 from Jess Tobin --- This really is a problematic bug. Our patrons are used to seeing a notice telling them that they've reached the max number of renewals...once they've reached that limit, not the day after their final successful renewal. It's also an issue for us with holds--Patron A will receive a failed renewal notice the day after Patron B places a hold on a book checked out to Patron A, regardless of how many days remain before the actual due date of book for Patron A. We're a small library; I can only imagine the confusion that would result for patrons at a large public library, for example. Many thanks in advance to anyone who is able to put some effort toward fixing this bug!! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 10 01:06:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Mar 2018 00:06:57 +0000 Subject: [Koha-bugs] [Bug 20103] Remove Readonly::XS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 10 01:07:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Mar 2018 00:07:46 +0000 Subject: [Koha-bugs] [Bug 20267] Add basic .gitignore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20267 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 10 12:04:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Mar 2018 11:04:49 +0000 Subject: [Koha-bugs] [Bug 19983] Switch single-column templates to Bootstrap grid: Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 --- Comment #6 from Owen Leonard --- Using git-bz with automatic dependency resolution this applies without any trouble for me on master. Did you apply the patch for Bug 19786 first? Thanks for testing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 10 20:13:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Mar 2018 19:13:54 +0000 Subject: [Koha-bugs] [Bug 20371] New: modn Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20371 Bug ID: 20371 Summary: modn Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: dmoinisio at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 72622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72622&action=edit modnssd -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 10 21:29:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Mar 2018 20:29:59 +0000 Subject: [Koha-bugs] [Bug 20371] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20371 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID Summary|modn |SPAM CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 11 00:21:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Mar 2018 23:21:45 +0000 Subject: [Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 11 00:25:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Mar 2018 23:25:07 +0000 Subject: [Koha-bugs] [Bug 19173] Make OPAC online payments pluggable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19173 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 11 04:41:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Mar 2018 03:41:14 +0000 Subject: [Koha-bugs] [Bug 20346] Patron filtering resulting in new search rather than filtering existing results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20346 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72523|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 11 04:41:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Mar 2018 03:41:48 +0000 Subject: [Koha-bugs] [Bug 20346] Patron filtering resulting in new search rather than filtering existing results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20346 --- Comment #4 from Alex Buckley --- Created attachment 72623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72623&action=edit Bug 20346 - Server side patron filtering implemented - Amended Server side (in the svc/members/search file) perl logic for filtering results returned from patron searches checks all patron data fields for a match with the filter value. This filtering works in the following steps: when filtering is initiated the original search using the original search query is run again and then the filter value is used to filter the resulting data, thereby using both the search and filter values to easily find a patron. The submitted filter value is automatically checked against every patron value in every patron record returned from the search and so there is no need for a specific data value to be selected with the select dropdown box id=searchfieldstype_filter and so that select dropdown has been removed due to this redundancy. This filter works for both filtering based on finding a match containing the filter value and, filtering based on finding a match starting with the filter value. A tooltip is displayed on the searchmember_filter input box to inform the user what format they should enter date formats. The tooltip tells the user to follow the date format of the dateformat syspref, meaning if the Koha instance has the 'metric' dataformat syspref value set then the tooltip will tell the user to enter a date value in the format dd/mm/yyyy Test plan: 1. Go to /members/members-home.pl and create 4 users. Make 3 of them have the same first and last name (e.g. first name = 'Fred' and last name ='Jones') but vary the homebranch, email addresses (e.g. fred at gmail.com, fred at hotmail.com, fredj at gmail.com (make this user have a date of birth of 1st jan 1980)) and make the fourth user have the first and last name of "Fred" "Smith" 2. Perform a search by writing in the 'Jones' value and you should get 3 results 3. Filter by writing in the word "Fred", with the search field ="standard" and searchtype="Contains" and this will give you 4 results because a new search for all users containing "Fred" is performed rather than filtering the results of the "Jones" search for the term "Fred" 4. Apply patch 5. Restart plack, apache2 and memcached 6. Refresh the patron page 7. Notice the search field dropdown has been removed because the filtering now automatically checks all patron data fields. Also notice when you hover over the filter textbox a tooltip message is displayed informing you the appropriate format for you to input date values in. This date format recommended is based on the value of the dateformat syspref 8. Repeat step 2 and you should get 3 results 9. Repeat step 3 and notice you get 3 results because the filtering is happening on the results of search rather than performing a new search 10. Perform another filter of the search by inputting the date 1st jan 1980 in the appropriate format described in the tooltip and the patron page for the patron with the email address fredj at gmail.com should be displayed Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 11 04:56:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Mar 2018 03:56:54 +0000 Subject: [Koha-bugs] [Bug 20346] Patron filtering resulting in new search rather than filtering existing results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20346 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72523|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 11 05:21:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Mar 2018 04:21:38 +0000 Subject: [Koha-bugs] [Bug 20346] Patron filtering resulting in new search rather than filtering existing results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20346 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72623|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 11 05:21:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Mar 2018 04:21:59 +0000 Subject: [Koha-bugs] [Bug 20346] Patron filtering resulting in new search rather than filtering existing results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20346 --- Comment #5 from Alex Buckley --- Created attachment 72624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72624&action=edit Bug 20346 - Amended Server side patron filtering The number of results returned has been fixed so it is not affected by what the user sets for the number of records they want displayed on each page. In addition to ensuring all matching patrons are returned no matter what the numberof patrons to be displayed on each page is, filtering also takes place over all returned patrons and not just those displayed on the current page this ensures filtering finds all matching patrons. Test plan: The same as the previous bug 20346 patch Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 01:29:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 00:29:25 +0000 Subject: [Koha-bugs] [Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 --- Comment #15 from David Cook --- (In reply to Marcel de Rooy from comment #14) > Test fails. Seems to be reported before. Versioning/packaging ? Needs > further attention.. > What operating system are you using, Marcel, and what version of RDF::Trine? Mirko has the required version in the Koha unstable package repo and the particular bug in question making the test fail should be resolved in Debian stable (Stretch) now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 09:18:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 08:18:31 +0000 Subject: [Koha-bugs] [Bug 20319] disable login for staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20319 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #1 from Magnus Enger --- Staff logins need the catalogue permission to be able to log in to the staff client. If you remove this permission they will not be able to log in. Could that be enough to solve your use case? https://koha-community.org/manual/17.11/en/html/04_patrons.html#patron-permissions-defined -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 09:28:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 08:28:58 +0000 Subject: [Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 09:29:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 08:29:02 +0000 Subject: [Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72439|0 |1 is obsolete| | --- Comment #10 from Claire Gravely --- Created attachment 72625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72625&action=edit Bug 19709 - Move template JavaScript to the footer: Labels This patch modifies the staff client label creator templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc. - Creating and managing layouts - Creating and managing batches - Creating and managing templates - Creating and managing printer profiles - Creating quick spine labels Edit: Fixed footer include error causing blank popup Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 09:58:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 08:58:59 +0000 Subject: [Koha-bugs] [Bug 20319] disable login for staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20319 --- Comment #2 from Abd al-Qader al-Awwad --- (In reply to Magnus Enger from comment #1) > Staff logins need the catalogue permission to be able to log in to the staff > client. If you remove this permission they will not be able to log in. Could > that be enough to solve your use case? > > https://koha-community.org/manual/17.11/en/html/04_patrons.html#patron- > permissions-defined I do try to remove permission for staff, the user still able to login, is there away to disable user login but keep them able to loan books and other patron options, I just want to disable login to staff client only, thank you for your answer. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 10:08:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 09:08:34 +0000 Subject: [Koha-bugs] [Bug 19983] Switch single-column templates to Bootstrap grid: Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 10:08:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 09:08:37 +0000 Subject: [Koha-bugs] [Bug 19983] Switch single-column templates to Bootstrap grid: Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72510|0 |1 is obsolete| | --- Comment #7 from Claire Gravely --- Created attachment 72626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72626&action=edit Bug 19983: Switch single-column templates to Bootstrap grid: Authorities This patch updates several single-column Authorities module templates to use the Bootstrap grid. - authorities-home - The home page of the Authorities module. - authorities.tt - The authority add/edit page. - blinddetail-biblio-search.tt - Not really testable -- It's the small popup window which appears during the process of linking an authority to a MARC record. - detail.tt - The authority detail page. Search for an authority record and click on the "details" link in the search results. - merge.tt - From a list of authority search results, select "Merge" from the Actions menu of two authority records. Test both the initial selection screen and the source/destination merging view. - searchresultlist.tt - The authority search results page. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 10:12:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 09:12:39 +0000 Subject: [Koha-bugs] [Bug 20319] disable login for staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20319 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi Abd, Magnuse is right, removing the catalogue permission should keep the staff users out of the staff client. Maybe try to log out and log in again after removing them? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 10:15:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 09:15:30 +0000 Subject: [Koha-bugs] [Bug 20319] disable login for staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20319 --- Comment #4 from Abd al-Qader al-Awwad --- (In reply to Katrin Fischer from comment #3) > Hi Abd, Magnuse is right, removing the catalogue permission should keep the > staff users out of the staff client. Maybe try to log out and log in again > after removing them? Thank you I'll try it again. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 10:16:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 09:16:27 +0000 Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 10:16:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 09:16:33 +0000 Subject: [Koha-bugs] [Bug 20195] Untranslatable Show/Hide title attr replacement in opac detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20195 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 10:16:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 09:16:36 +0000 Subject: [Koha-bugs] [Bug 20195] Untranslatable Show/Hide title attr replacement in opac detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20195 --- Comment #3 from Brendan Gallagher --- Created attachment 72627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72627&action=edit Bug 20195: Untranslatable Show/Hide title attr replacement in opac detail There's javascript code in opac detail view that tries to replace the word "Show" with "Hide" (and vice versa) in a title attribute. In addition to those words being untranslatable, a word replacement like that would not work properly when using other languages. Replace the single title attribute with two translatable strings, one for the "Show" case and one "Hide", and use the whole string instead of trying to replace a single word. Test plan: 1) Make sure OpacBrowseResults is on 2) in OPAC, search the catalog and go to the detail view 3) Hover the mouse over the "Browse results" text in the grey box on the right side. The popup text should show something like "Show pagination list (1-5 / 5)" 4) Click on the "Browse results" 5) Hover the mouse again over the text. The popup should show "Hide pagination list (1-5 / 5)" 6) Update a language xx-YY, translate the new msgids "Show pagination list (%s-%s / %s)" and "Hide pagination list (%s-%s / %s)", and install the language 7) Repeat 2-5 with that language, making sure the popup texts show up correctly in that language Signed-off-by: Pasi Kallinen Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 10:16:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 09:16:59 +0000 Subject: [Koha-bugs] [Bug 20195] Untranslatable Show/Hide title attr replacement in opac detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20195 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Attachment #71606|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 10:18:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 09:18:12 +0000 Subject: [Koha-bugs] [Bug 20195] Untranslatable Show/Hide title attr replacement in opac detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20195 --- Comment #4 from Brendan Gallagher --- Just seeing Jonathan's comment - should be a consideration for QA team. Perhaps a generic title would work. (this patch works though) (In reply to Brendan Gallagher from comment #3) > Created attachment 72627 [details] [review] > Bug 20195: Untranslatable Show/Hide title attr replacement in opac detail > > There's javascript code in opac detail view that tries to replace > the word "Show" with "Hide" (and vice versa) in a title attribute. > In addition to those words being untranslatable, a word replacement > like that would not work properly when using other languages. > > Replace the single title attribute with two translatable strings, > one for the "Show" case and one "Hide", and use the whole > string instead of trying to replace a single word. > > Test plan: > > 1) Make sure OpacBrowseResults is on > 2) in OPAC, search the catalog and go to the detail view > 3) Hover the mouse over the "Browse results" text in the grey box on the > right side. The popup text should show something like > "Show pagination list (1-5 / 5)" > 4) Click on the "Browse results" > 5) Hover the mouse again over the text. The popup should show > "Hide pagination list (1-5 / 5)" > 6) Update a language xx-YY, translate the new msgids > "Show pagination list (%s-%s / %s)" and > "Hide pagination list (%s-%s / %s)", and install the language > 7) Repeat 2-5 with that language, making sure the popup > texts show up correctly in that language > > Signed-off-by: Pasi Kallinen > > Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 10:18:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 09:18:15 +0000 Subject: [Koha-bugs] [Bug 11936] Consistent log message for item insert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936 Radek ?iman (R-Bit Technology, s.r.o.) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rbit at rbit.cz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 10:19:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 09:19:11 +0000 Subject: [Koha-bugs] [Bug 19770] Add cardnumber to holds awaiting pickup screen and add classes to borrower info In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 10:19:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 09:19:40 +0000 Subject: [Koha-bugs] [Bug 20286] Subscribing to a search via rss goes to an empty page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20286 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m --- Comment #8 from Brendan Gallagher --- We have a Baker and Taylor we can test with. (I am on this patch) (In reply to Jonathan Druart from comment #7) > Can anyone test these patches with BakerTaylor* prefs set correctly? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 10:23:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 09:23:44 +0000 Subject: [Koha-bugs] [Bug 19770] Add cardnumber to holds awaiting pickup screen and add classes to borrower info In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply QA Contact|katrin.fischer at bsz-bw.de |testopia at bugs.koha-communit | |y.org --- Comment #4 from Katrin Fischer --- I am sorry, patch doesn't apply. Can you please rebase? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 10:26:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 09:26:15 +0000 Subject: [Koha-bugs] [Bug 18322] Add facets for ccode to zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 10:39:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 09:39:29 +0000 Subject: [Koha-bugs] [Bug 18236] Add classes to material type icons on result lists and detail pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |claire_gravely at hotmail.com --- Comment #6 from Claire Gravely --- Patch does not apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 10:49:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 09:49:51 +0000 Subject: [Koha-bugs] [Bug 20345] Put saved report keyword search form on reports home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20345 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72494|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 72628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72628&action=edit Bug 20345: Put saved report keyword search form on reports home This patch makes cosmetic changes to the reports home page in the staff client following the pattern set on the Administration home page with the system preferences search box. A reports keyword search form is added, and reports actions have font-awesome icons. To test, apply the patch and view the reports home page. Confirm that all affected links work correctly and that the search form works correctly. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 10:49:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 09:49:48 +0000 Subject: [Koha-bugs] [Bug 20345] Put saved report keyword search form on reports home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20345 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 10:50:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 09:50:35 +0000 Subject: [Koha-bugs] [Bug 11936] Consistent log message for item insert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #6 from Julian Maurice --- There is a similar error at lines 490/496. Should it be fixed too ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 10:56:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 09:56:03 +0000 Subject: [Koha-bugs] [Bug 20286] Subscribing to a search via rss goes to an empty page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20286 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 10:56:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 09:56:06 +0000 Subject: [Koha-bugs] [Bug 20286] Subscribing to a search via rss goes to an empty page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20286 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72245|0 |1 is obsolete| | --- Comment #9 from Brendan Gallagher --- Created attachment 72629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72629&action=edit Bug 20286: Correctly escape URI characters in OPAC RSS template Bug 19568 use the TT filter url whereas it must have escaped the URI characters with the uri filter. Test plan: Subscribe to an OPAC search => Without this patch you will get an empty page => With this patch applied you will see result list. Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 10:56:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 09:56:19 +0000 Subject: [Koha-bugs] [Bug 20286] Subscribing to a search via rss goes to an empty page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20286 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72280|0 |1 is obsolete| | --- Comment #10 from Brendan Gallagher --- Created attachment 72630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72630&action=edit Bug 20286: Fix filter for BakerTaylor* prefs Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:11:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:11:04 +0000 Subject: [Koha-bugs] [Bug 19866] Move template JavaScript to the footer: UNIMARC editor plugins, part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19866 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:11:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:11:07 +0000 Subject: [Koha-bugs] [Bug 19866] Move template JavaScript to the footer: UNIMARC editor plugins, part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19866 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70069|0 |1 is obsolete| | --- Comment #3 from Claire Gravely --- Created attachment 72631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72631&action=edit Bug 19866: Move template JavaScript to the footer: UNIMARC editor plugins, part 1 This patch updates several UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin. >From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor. - unimarc_field_100.tt - unimarc_field_100_authorities.tt - unimarc_field_105.tt - unimarc_field_106.tt - unimarc_field_110.tt - unimarc_field_115a.tt - unimarc_field_115b.tt Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:12:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:12:58 +0000 Subject: [Koha-bugs] [Bug 19360] Give items URL a link text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19360 --- Comment #25 from Alex Buckley --- Thanks very much Katrin! I started work on writing the value builder this evening, based on dateacccessioned.pl. Will hopefully have it ready to test by the end of the week. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:14:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:14:13 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #104 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Lucie Gay -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:14:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:14:44 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71955|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:14:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:14:52 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71956|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:14:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:14:59 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71957|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:15:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:15:07 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71958|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:15:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:15:24 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #106 from sandboxes at biblibre.com --- Created attachment 72633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72633&action=edit Bug 11879: Changes to Koha's schemas Signed-off-by: Lucie Gay -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:15:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:15:29 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #107 from sandboxes at biblibre.com --- Created attachment 72634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72634&action=edit Bug 11879: Follow-up - Streamline markup and make label corrections This patch makes minor markup corrections to the patron detail page template: - Simplify the SWITCH markup - Add "primary" to primary phone label - Correct case on label - Add IF statement to hide label if there is no primary contact method Signed-off-by: Lucie Gay -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:15:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:15:34 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #108 from sandboxes at biblibre.com --- Created attachment 72635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72635&action=edit Bug 11879: Follow-up - code review Signed-off-by: Lucie Gay -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:15:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:15:19 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #105 from sandboxes at biblibre.com --- Created attachment 72632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72632&action=edit Bug 11879: Add the "Main contact method" field in borrower informations. This patch adds the "Main Contact Method" field in the borrower modification form. This field is useful for reporting purposes, or to know which contact method to use first when trying to contact a borrower. Following Nicolas' fix, removed a $branch variable from patch, since it has been suppressed in Bug 17284. Test case : * Edit a borrower's informations. The "Main Contact Method" selectbox should appear in the form and its value should be saved correctly. Sponsored-by: CCSR Signed-off-by: Lucie Gay -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:22:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:22:57 +0000 Subject: [Koha-bugs] [Bug 19868] Move template JavaScript to the footer: UNIMARC editor plugins, part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19868 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:23:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:23:00 +0000 Subject: [Koha-bugs] [Bug 19868] Move template JavaScript to the footer: UNIMARC editor plugins, part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19868 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70078|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 72636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72636&action=edit Bug 19868: Move template JavaScript to the footer: UNIMARC editor plugins, part 2 This patch updates several more UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin. >From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor. - unimarc_field_116.tt - unimarc_field_117.tt - unimarc_field_120.tt - unimarc_field_121a.tt - unimarc_field_121b.tt - unimarc_field_122.tt Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:24:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:24:56 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #109 from Aur?lie --- Lucie et Aur?lie : first test during Hackfest 2018 for us! A new dropdown select to chose the main contact method = OK The selected field appears in the patron's detail page = OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:26:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:26:58 +0000 Subject: [Koha-bugs] [Bug 11936] Consistent log message for item insert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936 --- Comment #7 from Magnus Enger --- (In reply to Julian Maurice from comment #6) > There is a similar error at lines 490/496. Should it be fixed too ? Yes! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:32:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:32:14 +0000 Subject: [Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64768|0 |1 is obsolete| | --- Comment #9 from Nicolas Legrand --- Created attachment 72637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72637&action=edit Bug 18743 - Removed library filter in Acquisition suggestions when IndependentBranches enabled Also ensured that when a superlibrarian is logged in then suggestions from all branches are displayed with IndependentBranches being either on or off, as this syspref does not affect what suggestions superlibrarians can see. But when non-superlibrarian user with access to the acquisitions module visits it when IndependentBranches is enabled then only suggestions of the branch they are logged in with are displayed. If non-superlibrarian users log in when IndependentBranches is not enabled then suggestions from all branches are displayed. Note: The library filter in the 'Organize by' area (which is displayed when multiple branches suggestions are displayed according to the aforementioned logic) successfully splits the suggestions into different tabs with the correct number of suggestions for each branch displayed in each tab. Test plan: 1. Relicate the bug described in description comment 2. Apply patch 3. Create 2 suggestions a library branch (which I will refer to in this test plan as branch A) 4. Create 1 suggestion for a different branch (which I will refer to as branch B) 5. Log into staff client as superlibrarian with either branch and ensure the IndependentBranches syspref is set to 'yes' 6. Go to Acquisitions->Suggestions Management 7. Notice that suggestions from branch A and B are displayed 8. In the Organize by are click to filter by library and click go 9. Notice that one tab says (2) whilst the other tab says (1) with each tab containing the relevant suggestions to that branch 10. In the Acquisition information filter select branch A and then click 'Go' and notice that it successfully filters the results and shows 2 suggestions of branch A only 11. Now change the IndependentBranches syspref to 'no' 12. Repeat steps 6, 7, 8, 9, 10 noticing the same outcome in step 9 and 10 13. Log out and log back into staff client in branch A as a non-superlibrarian user who has access to the Acquisitions module 14. Currently IndependentBranches is set to 'no' so go to Acquisitions->Suggestions Management 15. Repeat steps 6, 7, 8, 9, 10 and notice the same outcome as step 9 and 10 16. Change IndependentBranches to 'yes' 17. Go to Acquisitions->Suggestions Management 18. Notice that only suggestions from branch A (the branch you are logged in with) are displayed. This is because when IndependentBranches is enabled non-superlibrarians do not need to see suggestions from other branches 19. Also notice that there is no 'library' option in the 'Organized by' area and there is no library filter in the acquisition information area. This is because only suggestions from the current branch are displayed and so organizing/filtering by library is redundant. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:33:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:33:03 +0000 Subject: [Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.legrand at bulac.fr --- Comment #10 from Nicolas Legrand --- just rebased the first one master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:34:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:34:11 +0000 Subject: [Koha-bugs] [Bug 20312] Add a link towards the last consulted patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #2 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Axelle -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:34:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:34:24 +0000 Subject: [Koha-bugs] [Bug 20312] Add a link towards the last consulted patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72294|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:34:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:34:32 +0000 Subject: [Koha-bugs] [Bug 20312] Add a link towards the last consulted patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 --- Comment #3 from sandboxes at biblibre.com --- Created attachment 72638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72638&action=edit Bug 20312 - Add a link to last consulted patron TEST PLAN 1 - apply patch 2 - Go to a patron record 3 - Go to a different module 4 - Click on "Last patron" (top-left) 5 - It should go the last patron record you consulted Signed-off-by: Axelle -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:37:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:37:12 +0000 Subject: [Koha-bugs] [Bug 7047] renewing serials note not visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #6 from sandboxes at biblibre.com --- Patch tested with a sandbox, by S?verine QUEUNE -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:37:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:37:35 +0000 Subject: [Koha-bugs] [Bug 7047] renewing serials note not visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 --- Comment #7 from sandboxes at biblibre.com --- Created attachment 72639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72639&action=edit Bug 7047 - Storing subscription renewal note in suggestion to be displayed on the suggestion page. Additionally I have added a library input field in case the librarian wants to set a library branch whilst renewing a subscription. With the use case being they may have ommitted to set the branchcode whilst creating the subscription. Test plan: 1. Create a subscription (if one does not already exist) 2. Set the RenewSerialAddsSuggestion syspref to 'Add' 3. Renew the item making sure to write in a value into the note field 3. Visit the suggestions page and notice that the note is not displayed for the newly created suggestion 4. Apply patch 5. Repeat step 3. Notice that there is now a new branchcode dropdown box. Select one of your libraries and write in the value into the note field 6. Visit suggestions and notice there is now a 'Suggestion note' column in the table containing the note. Also note that the suggestion has the correct branchcode associated with it Sponsored-By: Catalyst IT Signed-off-by: Maksim Sen Signed-off-by: S?verine QUEUNE Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:37:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:37:26 +0000 Subject: [Koha-bugs] [Bug 7047] renewing serials note not visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71168|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:41:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:41:02 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72444|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:43:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:43:12 +0000 Subject: [Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from sandboxes at biblibre.com --- Patch tested with a sandbox, by claude -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:43:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:43:27 +0000 Subject: [Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72613|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:43:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:43:37 +0000 Subject: [Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708 --- Comment #8 from sandboxes at biblibre.com --- Created attachment 72640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72640&action=edit Bug 19708 - Remove useless code from opac-basket This removes a lot of useless code relating to the print function from opac-basket.tt, opac-basket.pl and opac/basket.js. It also fixes the CSS so that no extra blank page is printed. To test: 0) Add an item to your cart 1) Print your basket Note the appearance of the page. There will be an extra blank page. 2) Apply patch 3) Reload basket 4) Print your basket The appearce should be identical. The extra blank page is gone. This only affects the OPAC. Signed-off-by: Tom?s Cohen Arazi Signed-off-by: Tom?s Cohen Arazi Signed-off-by: Tomas Cohen Arazi Signed-off-by: claude -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:51:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:51:14 +0000 Subject: [Koha-bugs] [Bug 20350] Add column configuration to table of saved reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20350 Axelle Aix-Marseille Universit? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |axelle.clarisse at univ-amu.fr --- Comment #2 from Axelle Aix-Marseille Universit? --- Tested on sandbox Biblibre n?1 Go to Reports -> Use saved. there is not a "Column visibility" button in the table's pagination toolbar and the report groups are not correctly displayed in tabs Go to Administration -> Columns settings. - Find "id=table_reports." : OK - Make some selections to configure default settings of the reports table : OK. We selected json_url and saved_results. - these defaults were not applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:53:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:53:17 +0000 Subject: [Koha-bugs] [Bug 11936] Consistent log message for item insert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936 --- Comment #9 from Julian Maurice --- Created attachment 72642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72642&action=edit Bug 11936: (QA follow-up) Consistent log message for item insert Fix the same error in another place Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:53:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:53:37 +0000 Subject: [Koha-bugs] [Bug 11936] Consistent log message for item insert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72619|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:53:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:53:13 +0000 Subject: [Koha-bugs] [Bug 11936] Consistent log message for item insert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936 --- Comment #8 from Julian Maurice --- Created attachment 72641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72641&action=edit Bug 11936: Consistent log message for item insert If you use bulkmarcimport.pl to import records with items it looks like the successfull insert of the record is reported multiple time, but the second and subsequent "ok" is really related to importing the item(s). This patch changes the log message on successfully inserting an item to match the log message given when inserting an item fails. To test, the easy way: - Look at lines 530 and 536 of bulkmarcimport.pl, and note that the "op" in those two lines are different - Apply the patch - Look at lines 530 and 536 again, and note that the "op" is now identical, and that this makes sense, since they are both related to the same operation, specifically inserting an item To test, the hard way - Have some records with items - Import the records with bulkmarcimport.pl, and make sure to specify the -l option, to create a log of the actions taken - Look at the log and verify it looks something like this: id;operation;status 1;insert;ok 1;insert;ok 2;insert;ok 2;insert;ok - Apply this patch and import some more records with items. The log should now be similar to this: id;operation;status 1;insert;ok 1;insertitem;ok 2;insert;ok 2;insertitem;ok Signed-off-by: Maksim Sen Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:53:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:53:48 +0000 Subject: [Koha-bugs] [Bug 11936] Consistent log message for item insert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:54:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:54:52 +0000 Subject: [Koha-bugs] [Bug 20098] Inventory: CSV export: itemlost column is always empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20098 Gwendal JONCOUR changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gwendal.joncour at univ-rennes | |2.fr --- Comment #7 from Gwendal JONCOUR --- Hi, we encounter this bug on our 16.11 instance. Is this patch will be pushed to 16.11 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:55:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:55:02 +0000 Subject: [Koha-bugs] [Bug 18969] Elasticsearch - _all field is deprecated - should use copy_to to prepare for ES6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nick at bywatersolutions.com |alex.arnaud at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 11:58:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 10:58:02 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #37 from Owen Leonard --- Created attachment 72643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72643&action=edit Bug 19474: (follow-up) Catch up with changes to CSS from Bug 19981 This patch brings staff-global.scss up to date with changes made in Bug 19981. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:01:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:01:08 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Lucie Gay changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucie.gay at ens-paris-saclay. | |fr Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:04:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:04:02 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71643|0 |1 is obsolete| | --- Comment #74 from Benjamin Rokseth --- Created attachment 72644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72644&action=edit Bug 15565 - Place multiple holds at once for the same record on staff and OPAC. Signed-off-by: S?verine QUEUNE Signed-off-by: Kyle M Hall Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:04:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:04:13 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71644|0 |1 is obsolete| | --- Comment #75 from Benjamin Rokseth --- Created attachment 72645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72645&action=edit Bug 15565 - CSS changes Signed-off-by: S?verine QUEUNE Signed-off-by: Kyle M Hall Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:04:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:04:23 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71645|0 |1 is obsolete| | --- Comment #76 from Benjamin Rokseth --- Created attachment 72646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72646&action=edit Bug 15565: Use item's biblionumber only on item-level request Signed-off-by: S?verine QUEUNE Signed-off-by: Kyle M Hall Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:04:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:04:31 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71646|0 |1 is obsolete| | --- Comment #77 from Benjamin Rokseth --- Created attachment 72647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72647&action=edit Bug 15565: Set 'found' parameter correctly when ReservesNeedReturns is off Signed-off-by: Danielle Elder Signed-off-by: S?verine QUEUNE Signed-off-by: Kyle M Hall Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:04:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:04:40 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m --- Comment #23 from Victor Grousset/tuxayo --- Conflicts: ~/d/koha ??? git bz apply 8137 Bug 8137 - Checkout limit by patron category for all libraries 64704 - Bug 8137 - Add Default checkout limit by patron category with priority. 64891 - Bug 8137 - Add default issuing rule for all branches. Apply? [(y)es, (n)o, (i)nteractive] y Application de Bug 8137 - Add Default checkout limit by patron category with priority. .git/rebase-apply/patch:20: trailing whitespace. $count_query .= " JOIN biblioitems USING (biblionumber) warning: 1 ligne a ajout? des erreurs d'espace. Utilisation de l'information de l'index pour reconstruire un arbre de base... M C4/Circulation.pm M admin/smart-rules.pl M koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt M t/db_dependent/Circulation/Branch.t .git/rebase-apply/patch:20: trailing whitespace. $count_query .= " JOIN biblioitems USING (biblionumber) warning: 1 ligne a ajout? des erreurs d'espace. Retour ? un patch de la base et fusion ? 3 points... Fusion automatique de t/db_dependent/Circulation/Branch.t Fusion automatique de koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt Fusion automatique de admin/smart-rules.pl CONFLIT (contenu) : Conflit de fusion dans admin/smart-rules.pl Fusion automatique de C4/Circulation.pm error: ?chec d'int?gration des modifications. le patch a ?chou? ? 0001 Bug 8137 - Add Default checkout limit by patron category with priority. La copie du patch qui a ?chou? se trouve dans : .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-8137---Add-Default-checkout-limit-by-patron-ca-NJzNl6.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:04:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:04:41 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71647|0 |1 is obsolete| | --- Comment #78 from Benjamin Rokseth --- Created attachment 72648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72648&action=edit Bug 15565: Alert librarian that maximum holds per record is reached Signed-off-by: Dani Elder Signed-off-by: Danielle Elder Signed-off-by: S?verine QUEUNE Signed-off-by: S?verine QUEUNE Signed-off-by: Kyle M Hall Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:04:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:04:51 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71648|0 |1 is obsolete| | --- Comment #79 from Benjamin Rokseth --- Created attachment 72649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72649&action=edit Bug 15565 - remove use of GetBiblionumberFromItemnumber Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:05:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:05:22 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:09:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:09:56 +0000 Subject: [Koha-bugs] [Bug 20286] Subscribing to a search via rss goes to an empty page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20286 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |julian.maurice at biblibre.com |y.org | CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:14:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:14:26 +0000 Subject: [Koha-bugs] [Bug 20286] Subscribing to a search via rss goes to an empty page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20286 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72629|0 |1 is obsolete| | --- Comment #11 from Julian Maurice --- Created attachment 72650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72650&action=edit Bug 20286: Correctly escape URI characters in OPAC RSS template Bug 19568 use the TT filter url whereas it must have escaped the URI characters with the uri filter. Test plan: Subscribe to an OPAC search => Without this patch you will get an empty page => With this patch applied you will see result list. Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:14:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:14:30 +0000 Subject: [Koha-bugs] [Bug 20286] Subscribing to a search via rss goes to an empty page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20286 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72630|0 |1 is obsolete| | --- Comment #12 from Julian Maurice --- Created attachment 72651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72651&action=edit Bug 20286: Fix filter for BakerTaylor* prefs Signed-off-by: Brendan Gallagher Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:15:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:15:08 +0000 Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Axelle Aix-Marseille Universit? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |axelle.clarisse at univ-amu.fr -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:14:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:14:42 +0000 Subject: [Koha-bugs] [Bug 20286] Subscribing to a search via rss goes to an empty page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20286 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:15:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:15:22 +0000 Subject: [Koha-bugs] [Bug 20350] Add column configuration to table of saved reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20350 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:15:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:15:24 +0000 Subject: [Koha-bugs] [Bug 20350] Add column configuration to table of saved reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20350 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72505|0 |1 is obsolete| | --- Comment #3 from Jesse Maseto --- Created attachment 72652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72652&action=edit Bug 20350: Add column configuration to table of saved reports This patch makes changes to the saved reports template to enable a columns configuration button. Settings for the table have been added to columns_settings.yml. To test, apply the patch and go to Reports -> Use saved. - Confirm that there is a "Column visibility" button in the table's pagination toolbar. - Confirm that showing and hiding columns via the button is working correctly. - Confirm that the first, second, and last columns cannot be toggled. Go to Administration -> Columns settings. - Expand the "Reports" section. - Find "id=table_reports." - Make some selections to configure default settings of the reports table. - Return to reports and confirm that these defaults are applied. Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:16:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:16:07 +0000 Subject: [Koha-bugs] [Bug 19909] Show attributes in patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19909 Axelle Aix-Marseille Universit? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |axelle.clarisse at univ-amu.fr --- Comment #2 from Axelle Aix-Marseille Universit? --- Patch doesn't apply on sandbox biblibre n?1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:17:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:17:02 +0000 Subject: [Koha-bugs] [Bug 20369] Analytics search is broken with QueryAutoTruncate set to 'only if * is added' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20369 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:17:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:17:04 +0000 Subject: [Koha-bugs] [Bug 20369] Analytics search is broken with QueryAutoTruncate set to 'only if * is added' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20369 --- Comment #2 from Kyle M Hall --- Created attachment 72653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72653&action=edit Bug 20369: Analytics search is broken with QueryAutoTruncate set to 'only if * is added' Test Plan: 1) Enable EasyAnalytics 2) Disable QueryAutoTruncate 3) Create an analytic record, add some host items to it 4) Browser to the analytics tab for the record 5) Click the link in the 'used in' column of the table 6) No search results 7) Apply this patch 8) Reload the page, now you get the analytic record! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:18:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:18:48 +0000 Subject: [Koha-bugs] [Bug 18969] Elasticsearch - _all field is deprecated - should use copy_to to prepare for ES6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:18:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:18:54 +0000 Subject: [Koha-bugs] [Bug 18969] Elasticsearch - _all field is deprecated - should use copy_to to prepare for ES6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71619|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 72654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72654&action=edit Bug 18969: ES6 - replace use of field include_in_all by copy_to Test plan: 1) apply this patch, 2) update your elasticsearch server to the version 6 (6.2?), 3) reinstall icu plugin, 4) reindex your authorities and biblios, 5) check that there is no error in /var/log/elasticsearch/elasticsearch.log, 6) try a search on biblios, 7) check that facet work, 8) try a search on authorities Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:18:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:18:47 +0000 Subject: [Koha-bugs] [Bug 20369] Analytics search is broken with QueryAutoTruncate set to 'only if * is added' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20369 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:22:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:22:11 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #33 from sandboxes at biblibre.com --- Patch tested with a sandbox, by S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:22:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:22:38 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72043|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:22:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:22:44 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72044|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:22:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:22:49 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72045|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:22:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:22:55 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72046|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:23:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:23:00 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72047|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:23:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:23:09 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #34 from sandboxes at biblibre.com --- Created attachment 72655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72655&action=edit Bug 19368 - Ignore words when sorting serial search This adds the 'SerialSortIgnoreWords' system preference. It is empty by default, since words to ignore are very much language-specific. The functionality is achieved by adding a hidden column to the table, and sorting by this column by default. The downfall of this solution is that if the user sorts by another column, they cannot go back to this sorting without refreshing the page. To test: 0) Apply patch 1) Run updatedatabase.pl 2) Add test subscriptions if you have none. Make sure to have subscriptions starting with "The An A" or similar 3) Go to system preferences and edit the SerialSortIgnoreWords pref Add the words "The An A" or the ones you used in your subscriptions 4) Go to Serials 5) Search serials (empty field will return all serials) 6) Result table should be sorted ignoring leading "The An A..." Followed test plan, patch works as described Signed-off-by: Alex Buckley Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:23:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:23:13 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #35 from sandboxes at biblibre.com --- Created attachment 72656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72656&action=edit Bug 19368 - Correction on QA feedback * I removed the IGNORE in the atomicupdate SQL. There is currently no other systempreference by that name in Master so that should work fine - Removed leftover test values from syspref.sql - Removed extra $ in serial-search.tt - Removed leftover warn in serial-search.pl Passes QA test tool Signed-off-by: Alex Buckley Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:23:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:23:16 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #36 from sandboxes at biblibre.com --- Created attachment 72657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72657&action=edit Bug 19368 - Syspref now "SortIgnoreArticles", used in datatables.inc Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:23:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:23:20 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #37 from sandboxes at biblibre.com --- Created attachment 72658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72658&action=edit Bug 19368 - Removed the old preference 'SerialSortIgnoreWords' that was left hanging in serials.pref Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:23:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:23:23 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #38 from sandboxes at biblibre.com --- Created attachment 72659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72659&action=edit Bug 19368 - clearly state, in the pref's desc, that the comparison is done against unaccented title Signed-off-by: S?verine QUEUNE Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:24:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:24:20 +0000 Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr --- Comment #39 from S?verine Queune --- This patch works perfectly ! A detail : the syspref is "SortIgnoreArticles" and not "SerialSortIgnoreWords". Thanks for this work ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:24:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:24:34 +0000 Subject: [Koha-bugs] [Bug 18816] Make CataloguingLog work in production by preventing circulation from spamming the log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18816 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #12 from Julian Maurice --- It might be useful to turn the last parameter of ModItem into a hashref of parameters. ModItem(\%item, $biblionumber, $itemnumber, {log_action => 0}); is more readable than ModItem(\%item, $biblionumber, $itemnumber, 0); What do you think ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:30:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:30:39 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70203|0 |1 is obsolete| | --- Comment #197 from Alex Arnaud --- Created attachment 72660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72660&action=edit Bug 17047 add Mana-KB syspref Add the system preference to enable or disable Mana-KB webservice on koha. Signed-off-by: Brendan A Gallagher Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:30:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:30:55 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70204|0 |1 is obsolete| | --- Comment #198 from Alex Arnaud --- Created attachment 72661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72661&action=edit Bug 17047 subscriptions management with Mana-KB - add a class SharedContent.pm to communicate with Mana-KB server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for Mana-KB - create datatable in mana-subscription-search-result.inc to show results from a research on Mana-KB - modify serials-search.pl to manage research on Mana-KB - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a Mana-KB subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to Mana-KB - modify subscription-add.tt and subscription.pl to manage a import from Mana-KB during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with Mana-KB server during a asubscription creation - add a function in Subscription.pm to have all the info for a Mana-KB research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from Mana-KB server and not already created on the koha database, and modify the tests of the said functions Signed-off-by: Brendan A Gallagher Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:31:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:31:16 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70205|0 |1 is obsolete| | --- Comment #199 from Alex Arnaud --- Created attachment 72662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72662&action=edit Bug 17047 SQL reports management with Mana-KB Includes: * code factorization Some code from subscription & Mana-KB has been factorized in order to speed-up next developments * SytemPreferences: Mana Activation: - add a value "no, let me think about it", that is the default value. - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) ) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default) * Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redesigned to improve the user experience * New Feature : report a mistake. - people can now report an invalid data (wrong, obsolete,...) - if a data is reported as invalid many time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists * API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) * New feature : SQL report sharing - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana-KB - New feature: search report in Mana-KB with keywords - New feature: load reports from Mana-KB ========= Test plan ========= (see BibLibre complete documentation, attached to this patch) 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => Koha shouldn't show you anything (except if the base hase been filled) - Share this serial on Mana-KB (on the subscription detail page there must be a Share button) - Try to create a new subscription for serial #1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - SQL Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it on Mana-KB => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can report a mistake & comment why you report: click on report mistake. You only can chose "other" because there's no comment in Mana-KB [if there are comments, you'll get other values]. - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. Signed-off-by: Brendan A Gallagher Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:31:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:31:32 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70206|0 |1 is obsolete| | --- Comment #200 from Alex Arnaud --- Created attachment 72663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72663&action=edit Bug 17047 security token agst flooding for Mana-KB Rework messages from Mana-KB. - Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after for example) https://mana-kb.koha-community.org 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. Signed-off-by: Brendan A Gallagher Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:31:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:31:50 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70208|0 |1 is obsolete| | --- Comment #201 from Alex Arnaud --- Created attachment 72664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72664&action=edit Bug 17047: Minor changes - search on reports module is now also validated by pressing enter. - AutoShare now initialized with nothing autmaticaly shared. - To create a report you now have to click on New report => New report from Mana. - Error messages are displayed in case of fail - Correct the display of sql reports containing "'" - Importing a report from Mana now opens the edit page - You don't get message after a successful import from mana (you simply get redirected) - Fix an error when cretaing subscription - Fix mana search - Correct encoding issues Signed-off-by: Brendan A Gallagher Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:32:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:32:05 +0000 Subject: [Koha-bugs] [Bug 18007] Interface updates to notices and notice previews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Signed Off |Patch doesn't apply --- Comment #7 from Julian Maurice --- Patch does not apply anymore. Can you rebase it please ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:32:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:32:06 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70209|0 |1 is obsolete| | --- Comment #202 from Alex Arnaud --- Created attachment 72665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72665&action=edit Bug 17047 [QA Followup] - Fix misc koha-qa.pl failures - Fix up database schema change, add to kohastructure.sql - Update schema files - Remove javascript debugger call Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:32:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:32:53 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70210|0 |1 is obsolete| | --- Comment #203 from Alex Arnaud --- Created attachment 72666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72666&action=edit Bug 17047 - [QA Followup] - Fix untranslatable strings - Remove onclick html attribute - Remove useless passing of mana_id variable in serials-toolbar.inc - Remove using CGI::param in list context - remove new subs from serials/subscription-add.pl - remov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:33:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:33:06 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70211|0 |1 is obsolete| | --- Comment #204 from Alex Arnaud --- Created attachment 72667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72667&action=edit Bug 17047 - Move ability to comment mana entities from search results table to report/subscription detail page + code refactoring -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:33:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:33:18 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70561|0 |1 is obsolete| | --- Comment #205 from Alex Arnaud --- Created attachment 72668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72668&action=edit Bug 17047 - Fix template code in subscription-add.js Fix errors when saving a serial Provide a more visible message when sharing a report without note Fix Internal server error when trying to share a new report Make update DB idempotent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:33:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:33:34 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70874|0 |1 is obsolete| | --- Comment #206 from Alex Arnaud --- Created attachment 72669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72669&action=edit Bug 17047 - Fix retrieving Mana token -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:33:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:33:44 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #207 from Alex Arnaud --- Created attachment 72670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72670&action=edit Bug 17047 - Remove changes on Koha/Schema/Result/SavedSql.pm and Subscription.pm - mana.inc included twice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:35:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:35:11 +0000 Subject: [Koha-bugs] [Bug 20343] Show number of checkouts by itemtype in circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20343 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at biblibre.com Status|Needs Signoff |Signed Off --- Comment #2 from sandboxes at biblibre.com --- Patch tested with a sandbox, by delaye -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:35:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:35:25 +0000 Subject: [Koha-bugs] [Bug 20343] Show number of checkouts by itemtype in circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20343 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72482|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:35:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:35:33 +0000 Subject: [Koha-bugs] [Bug 20343] Show number of checkouts by itemtype in circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20343 --- Comment #3 from sandboxes at biblibre.com --- Created attachment 72671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72671&action=edit Bug 20343: Show number of checkouts by itemtype in circulation.pl It is sometimes useful to have the number of checkouts grouped by itemtype (to see if we're approaching the maximum number of checkouts allowed for instance). This patch adds this information above the checkouts table, in circ/circulation.pl Test plan: 1. Check out some items with various item types to a patron 2. In circ/circulation.pl, click on 'Show checkouts' button to display the table 3. Notice the line "Number of checkouts by item type" above the table, click on it 4. See that the list of item types is displayed with a count in front of each one 5. Compare the numbers to the checkouts in the table and verify that the numbers are correct Signed-off-by: delaye -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:35:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:35:47 +0000 Subject: [Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 Lucie Gay changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucie.gay at ens-paris-saclay. | |fr --- Comment #3 from Lucie Gay --- We can't test because there is only one inventory filter notforloan but the values are from the authorized value "statut" and not "notforloan". There are no filter for "lost". Tested on unimarc sandbox. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:36:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:36:12 +0000 Subject: [Koha-bugs] [Bug 19909] Show attributes in patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19909 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m --- Comment #3 from Victor Grousset/tuxayo --- conflicts: ~/d/koha ??? git bz apply 19909 ? 141 Bug 19909 - Show attributes in patron search results 70243 - Bug 19909: Show attributes in patron search results Apply? [(y)es, (n)o, (i)nteractive] y Application de Bug 19909: Show attributes in patron search results Utilisation de l'information de l'index pour reconstruire un arbre de base... M C4/Utils/DataTables/Members.pm M admin/columns_settings.yml M koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt .git/rebase-apply/patch:182: new blank line at EOF. + warning: 1 ligne a ajout? des erreurs d'espace. Retour ? un patch de la base et fusion ? 3 points... Fusion automatique de koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt CONFLIT (contenu) : Conflit de fusion dans koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt Fusion automatique de admin/columns_settings.yml Fusion automatique de C4/Utils/DataTables/Members.pm error: ?chec d'int?gration des modifications. le patch a ?chou? ? 0001 Bug 19909: Show attributes in patron search results La copie du patch qui a ?chou? se trouve dans : .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-19909-Show-a -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:39:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:39:17 +0000 Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m --- Comment #9 from Victor Grousset/tuxayo --- conflicts: ~/d/koha ??? git bz apply 16787 Bug 16787 - 'Too many holds' message appears inappropriately and is missing data 68894 - Bug 16787: 'Too many holds' message appears inappropriately and is missing data 68895 - Bug 16787: Add tests Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 16787: 'Too many holds' message appears inappropriately and is missing data Using index info to reconstruct a base tree... M C4/Reserves.pm M koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt M reserve/request.pl Falling back to patching base and 3-way merge... Auto-merging reserve/request.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt Auto-merging C4/Reserves.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 16787: 'Too many holds' message appears inappropriately and is missing data The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-16787-Too-many-holds-message-appears-inappropr-CKsj5R.patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:39:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:39:38 +0000 Subject: [Koha-bugs] [Bug 18825] Elasticsearch - Update default authority mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18825 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17373 CC| |claire.hernandez at biblibre.c | |om Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17373 [Bug 17373] Elasticsearch - Authority mappings for UNIMARC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:39:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:39:38 +0000 Subject: [Koha-bugs] [Bug 17373] Elasticsearch - Authority mappings for UNIMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17373 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18825 [Bug 18825] Elasticsearch - Update default authority mappings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:39:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:39:59 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #208 from Alex Arnaud --- (In reply to Hugo Agud from comment #191) > Dear Alex > > thank you very much! we have added this line to Shared > > our $MANA_IP = "https://mana-test.koha-community.org"; > > and we have been able to work. > > REPORTS: > We have been able to download reports from MANA BUT they are not able to > execute because it dissapears spaces between orders.. we have got to review > and separate some statements in order to make it works. Yes, there is bad reports in Mana database. They came here when the share method was broken. We should clear them now. > > We have NOT been able to upload a report or a serial patter , the systema it > claims Can't call method "first_valid_email_address" on an undefined value > at /home/vagrant/kohaclone/Koha/SharedContent.pm line 108. Works for me. But i did some little changes today. Can you apply them and test again? > > We have checked that the user has primary and secondary email and the > library has also a library defined... (perhas it needs to be registered in > MANA? we have not been able to register in MANA using syspref. > > Orex Digital (XXXXX) > > Primary email:info at orex.es > Secondary email: info at orex.es > > SERIAL > We have added a serial with a issn that MANA manage and it never finds it > > No subscription found on Mana Knowledge Base :( > > Please feel free to share you pattern with all others librarians once you > are done > > > > > Reviewing logs... > > dozens of > Use of uninitialized value in concatenation (.) or string at > /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/includes/mana/mana- > subscription-search-result.inc line 53. > Use of uninitialized value in concatenation (.) or string at > /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/includes/mana/mana- > subscription-search-result.inc line 53. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:40:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:40:25 +0000 Subject: [Koha-bugs] [Bug 17373] Elasticsearch - Authority mappings for UNIMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17373 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20261 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20261 [Bug 20261] No result in some page in authority search opac and pro (ES) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:40:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:40:25 +0000 Subject: [Koha-bugs] [Bug 20261] No result in some page in authority search opac and pro (ES) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20261 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17373 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17373 [Bug 17373] Elasticsearch - Authority mappings for UNIMARC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:42:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:42:11 +0000 Subject: [Koha-bugs] [Bug 20343] Show number of checkouts by itemtype in circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20343 --- Comment #4 from sandboxes at biblibre.com --- Patch tested with a sandbox, by claude -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:42:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:42:24 +0000 Subject: [Koha-bugs] [Bug 20343] Show number of checkouts by itemtype in circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20343 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72671|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:42:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:42:32 +0000 Subject: [Koha-bugs] [Bug 20343] Show number of checkouts by itemtype in circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20343 --- Comment #5 from sandboxes at biblibre.com --- Created attachment 72672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72672&action=edit Bug 20343: Show number of checkouts by itemtype in circulation.pl It is sometimes useful to have the number of checkouts grouped by itemtype (to see if we're approaching the maximum number of checkouts allowed for instance). This patch adds this information above the checkouts table, in circ/circulation.pl Test plan: 1. Check out some items with various item types to a patron 2. In circ/circulation.pl, click on 'Show checkouts' button to display the table 3. Notice the line "Number of checkouts by item type" above the table, click on it 4. See that the list of item types is displayed with a count in front of each one 5. Compare the numbers to the checkouts in the table and verify that the numbers are correct Signed-off-by: claude -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:45:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:45:16 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71966|0 |1 is obsolete| | --- Comment #45 from Nick Clemens --- Created attachment 72673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72673&action=edit Bug 19575: Use canonical field names and resolve aliased fields Adjust elastic search mappings to more closely match Zebra equivalents resolving serveral issues with coded Zebra searches in templates and sorting of search results in UI. Also make field names in search strings case insensitive to accept case variations in template links and user input. Sponsored-by: Gothenburg University Library Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:45:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:45:12 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:47:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:47:08 +0000 Subject: [Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Victor Grousset/tuxayo --- @Fridolin can you test on a BibLibre's sandbox? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:47:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:47:24 +0000 Subject: [Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:52:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:52:20 +0000 Subject: [Koha-bugs] [Bug 19902] Add column configuration to bibliographic record checkouts history table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19902 jmbroust changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jean-manuel.broust at univ-lyo | |n2.fr Status|Needs Signoff |Failed QA --- Comment #2 from jmbroust --- I did not succeed in hiding any column of the table. I tried on other tables (example check in table) and it worked fine so I think it is trully a problem with this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:53:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:53:11 +0000 Subject: [Koha-bugs] [Bug 19856] Improve styling of reports sidebar to match tools sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #6 from sandboxes at biblibre.com --- Patch tested with a sandbox, by claude -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:53:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:53:33 +0000 Subject: [Koha-bugs] [Bug 19856] Improve styling of reports sidebar to match tools sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 --- Comment #7 from sandboxes at biblibre.com --- Created attachment 72674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72674&action=edit Bug 19856: Improve styling of reports sidebar Added divs to report-menu.inc as well. Should work on any reports page with sidebar now. Signed-off-by: claude -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:53:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:53:25 +0000 Subject: [Koha-bugs] [Bug 19856] Improve styling of reports sidebar to match tools sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70642|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:53:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:53:51 +0000 Subject: [Koha-bugs] [Bug 16581] ICU tokenization bug in idzebra-2.0 2.0.59-1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16581 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #10 from Fridolin SOMERS --- (In reply to David Cook from comment #9) > Overall, I'm in favour of using Indexdata's repository. > We at Biblibre are using this repo with Ubuntu Xenial since Koha 16.11. Its Zebra 2.1.3 now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 12:56:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 11:56:50 +0000 Subject: [Koha-bugs] [Bug 20343] Show number of checkouts by itemtype in circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20343 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72672|0 |1 is obsolete| | --- Comment #6 from Jesse Maseto --- Created attachment 72675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72675&action=edit Bug 20343: Show number of checkouts by itemtype in circulation.pl It is sometimes useful to have the number of checkouts grouped by itemtype (to see if we're approaching the maximum number of checkouts allowed for instance). This patch adds this information above the checkouts table, in circ/circulation.pl Test plan: 1. Check out some items with various item types to a patron 2. In circ/circulation.pl, click on 'Show checkouts' button to display the table 3. Notice the line "Number of checkouts by item type" above the table, click on it 4. See that the list of item types is displayed with a count in front of each one 5. Compare the numbers to the checkouts in the table and verify that the numbers are correct Signed-off-by: claude Signed-off-by: Jesse Maseto Works as described. Maybe remove one of the arrows from the display. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 13:11:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 12:11:10 +0000 Subject: [Koha-bugs] [Bug 19365] link_bibs_to_authorities.pl doesn't work with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71109|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 13:12:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 12:12:10 +0000 Subject: [Koha-bugs] [Bug 19365] link_bibs_to_authorities.pl doesn't work with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 --- Comment #5 from Nick Clemens --- Ere, this patch looks good at a first read through, can you provide a test plan for the linker? I am not so familiar with this tool. I un-obsoleted the first patch, squashing the followup would be good too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 13:28:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 12:28:10 +0000 Subject: [Koha-bugs] [Bug 19953] Record page: acquisition details: add column for invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at biblibre.com Status|Needs Signoff |Signed Off --- Comment #2 from sandboxes at biblibre.com --- Patch tested with a sandbox, by S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 13:28:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 12:28:27 +0000 Subject: [Koha-bugs] [Bug 19953] Record page: acquisition details: add column for invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70431|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 13:28:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 12:28:35 +0000 Subject: [Koha-bugs] [Bug 19953] Record page: acquisition details: add column for invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 --- Comment #3 from sandboxes at biblibre.com --- Created attachment 72676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72676&action=edit Bug 19953: Record page: acquisition details: add column for invoice Test plan: 1. create a vendor with minimal info 2. create a basket with minimal info 3. add a item to the basket 4. close the basket 5. receive a shipment 6. on the "receipt summary" click on "receive" for the wanted item (it should be the only one) 7. items ? receive? ? tick this checkbox 8. save 9. click on "finish receiving" 10. Go to the record ? Acquisition details 11. Apply this patch 12. Refresh the page 13. You should see the new column Signed-off-by: S?verine QUEUNE Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 13:31:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 12:31:07 +0000 Subject: [Koha-bugs] [Bug 15184] Ability to duplicate an existing order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 13:41:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 12:41:28 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC|victor.grousset at biblibre.co | |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 13:44:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 12:44:11 +0000 Subject: [Koha-bugs] [Bug 18007] Interface updates to notices and notice previews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- Hi Julian, did you notice the dependency? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 13:44:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 12:44:38 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72643|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 13:49:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 12:49:32 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #38 from Owen Leonard --- Created attachment 72677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72677&action=edit Bug 19474: (follow-up) Catch up with changes to CSS from Bug 19981 This patch brings staff-global.scss up to date with changes made in Bug 19981. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 13:51:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 12:51:42 +0000 Subject: [Koha-bugs] [Bug 20372] New: Correct toolbar markup on some pages Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20372 Bug ID: 20372 Summary: Correct toolbar markup on some pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org There are a few instances of div#toolbar which contain markup which isn't consistent with most other examples. This can cause problems with CSS styles. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 13:55:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 12:55:19 +0000 Subject: [Koha-bugs] [Bug 17561] ReserveSlip needs itemnumber for item level holds on same biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 13:55:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 12:55:05 +0000 Subject: [Koha-bugs] [Bug 17561] ReserveSlip needs itemnumber for item level holds on same biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57293|0 |1 is obsolete| | --- Comment #6 from Benjamin Rokseth --- Created attachment 72678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72678&action=edit Bug 17561 - ReserveSlip needs itemnumber for item level holds on same biblio This patch fixes a regression after bug 14695. This patch adds itemnumber and barcode as optional params in ReserveSlip used by hold-transfer-slip.pl to generate HOLD_SLIP. This is for ReserveSlip to be able to generate correct slips when items in multi-item holds are checked in. Test plan: 1) activate a circulation rule with multi-item holds 2) Place two holds on same biblio for patron 3) for debugging, either use browser console to observe POST request and responses or use info from reserves, e.g. reserve_id in the HOLD_SLIP 4) checkin two items from same biblio on pickup branch 5) note that both holds are effectuated, but reserve_id is the same on both slips 6) also note that there is no itemnumber or barcode in the requests from returns.pl 7) Apply this patch 8) repeat 2-4 9) note that reserve_id is now different on the two slips and/or: Run tests: t/db_dependent/Reserves/ReserveSlip.t should fail before patch and pass after -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:02:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:02:54 +0000 Subject: [Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:02:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:02:57 +0000 Subject: [Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71030|0 |1 is obsolete| | --- Comment #11 from S?verine Queune --- Created attachment 72679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72679&action=edit Bug 18743 - ALTERNATE: Take IndependantBranches syspref into account Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:05:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:05:55 +0000 Subject: [Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743 --- Comment #12 from S?verine Queune --- The first patch didn't apply as expected : no suggestion was visible. The alternative patch filters correctly suggestions on branches when logged as non-superlibrarian ; all sugegstions can be seen by a superlibrairian. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:08:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:08:29 +0000 Subject: [Koha-bugs] [Bug 20372] Correct toolbar markup on some pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20372 --- Comment #1 from Owen Leonard --- Created attachment 72680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72680&action=edit Bug 20372: Correct toolbar markup on some pages Differences in markup around some toolbars has the potential to create CSS styling problems. This patch changes the markup to be consistent with other instances of

    To test, apply the patch and view these pages: - Course reserves (main page) - Course reserves -> Course detail page - Reports -> Dictionary On each of these pages the toolbar should look correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:08:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:08:26 +0000 Subject: [Koha-bugs] [Bug 20372] Correct toolbar markup on some pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20372 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:08:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:08:37 +0000 Subject: [Koha-bugs] [Bug 18322] Add facets for ccode to zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #22 from Katrin Fischer --- I was staring at it for a quite a while to figure it out, but we are missing the generated .xsl files here. We have the .xml files, but not the ones generated by running the xsltproc process. Please complete the patch! xsltproc /etc/koha/zebradb/xsl/koha-indexdefs-to-zebra.xsl /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml >/etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:13:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:13:45 +0000 Subject: [Koha-bugs] [Bug 20372] Correct toolbar markup on some pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20372 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72680|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:13:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:13:55 +0000 Subject: [Koha-bugs] [Bug 20372] Correct toolbar markup on some pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20372 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:13:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:13:56 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:14:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:14:10 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer at bsz-bw.de | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:14:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:14:34 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Searching |Searching - Elasticsearch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:17:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:17:17 +0000 Subject: [Koha-bugs] [Bug 17282] Ability to create charts for SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #46 from Katrin Fischer --- Patch doesn't apply, can you please rebase? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:17:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:17:37 +0000 Subject: [Koha-bugs] [Bug 20047] Add Z3950Server Object and use it for getting server count In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20047 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:17:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:17:39 +0000 Subject: [Koha-bugs] [Bug 20047] Add Z3950Server Object and use it for getting server count In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20047 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70829|0 |1 is obsolete| | --- Comment #5 from Jesse Maseto --- Created attachment 72681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72681&action=edit Bug 20047 - Add Koha::Z3950Server Oject and use it to get server count To test: 1 - prove t/db_dependent/Koha/Z3950Servers.t 2 - Load cataloging and authority home pages 3 - Verify you can add form z395 on each page 4 - Delete all z3950 servers 5 - Viery option to add from Z3950 is removed on both pages Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:20:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:20:39 +0000 Subject: [Koha-bugs] [Bug 20372] Correct toolbar markup on some pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20372 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:20:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:20:42 +0000 Subject: [Koha-bugs] [Bug 20372] Correct toolbar markup on some pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20372 --- Comment #2 from Owen Leonard --- Created attachment 72682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72682&action=edit Bug 20372: Correct toolbar markup on some pages Differences in markup around some toolbars has the potential to create CSS styling problems. This patch changes the markup to be consistent with other instances of
    To test, apply the patch and view these pages: - Course reserves (main page) - Course reserves -> Course detail page - Reports -> Dictionary On each of these pages the toolbar should look correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:22:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:22:10 +0000 Subject: [Koha-bugs] [Bug 20339] Unify MARC21 ISBN/ISSN handling in XSL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20339 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #2 from sandboxes at biblibre.com --- Patch tested with a sandbox, by claude -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:22:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:22:32 +0000 Subject: [Koha-bugs] [Bug 20339] Unify MARC21 ISBN/ISSN handling in XSL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20339 --- Comment #3 from sandboxes at biblibre.com --- Created attachment 72683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72683&action=edit Bug 20339: Unify MARC21 ISBN/ISSN handling in XSL The code to show the ISBN and ISSN is repeated between the search results and the detail view. Create a function to show the ISBN/ISSN, and call that instead. Test plan: 1) Apply patch 2) Search for any records, check that the ISBN and ISSN are shown correctly 3) Go to biblio detail pages, check that the ISBN and ISSN are shown correctly Signed-off-by: Pasi Kallinen Signed-off-by: claude -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:22:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:22:24 +0000 Subject: [Koha-bugs] [Bug 20339] Unify MARC21 ISBN/ISSN handling in XSL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20339 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72467|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:26:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:26:56 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jschmidt at switchinc.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:28:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:28:22 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:28:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:28:26 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71616|0 |1 is obsolete| | Attachment #72677|0 |1 is obsolete| | --- Comment #39 from Claire Gravely --- Created attachment 72684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72684&action=edit Bug 19474: (follow-up) Catch up with changes to staff-global.css This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css: - Bug 15707: (QA follow-up) Fix UI issues - Bug 20135: Prevent staff client language choose pop-up from appearing off-screen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:28:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:28:30 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #40 from Claire Gravely --- Created attachment 72685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72685&action=edit Bug 19474: (follow-up) Catch up with changes to CSS from Bug 19981 This patch brings staff-global.scss up to date with changes made in Bug 19981. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:29:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:29:24 +0000 Subject: [Koha-bugs] [Bug 16117] Log borrower cardnumbers and item barcodes which are not valid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16117 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- Also: Patch doesn't apply! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:32:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:32:11 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72684|0 |1 is obsolete| | --- Comment #41 from Claire Gravely --- Created attachment 72686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72686&action=edit Bug 19474: (follow-up) Catch up with changes to staff-global.css This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css: - Bug 15707: (QA follow-up) Fix UI issues - Bug 20135: Prevent staff client language choose pop-up from appearing off-screen Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:34:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:34:02 +0000 Subject: [Koha-bugs] [Bug 20372] Correct toolbar markup on some pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20372 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:34:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:34:05 +0000 Subject: [Koha-bugs] [Bug 20372] Correct toolbar markup on some pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20372 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72682|0 |1 is obsolete| | --- Comment #3 from Claire Gravely --- Created attachment 72687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72687&action=edit Bug 20372: Correct toolbar markup on some pages Differences in markup around some toolbars has the potential to create CSS styling problems. This patch changes the markup to be consistent with other instances of
    To test, apply the patch and view these pages: - Course reserves (main page) - Course reserves -> Course detail page - Reports -> Dictionary On each of these pages the toolbar should look correct. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:37:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:37:32 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |severine.queune at bulac.fr --- Comment #192 from S?verine Queune --- TypeError: $(...).kohaDataTable is not a function -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:55:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:55:28 +0000 Subject: [Koha-bugs] [Bug 20217] Make header's catalog search menu into a split button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71674|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 72688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72688&action=edit Bug 20217: Make header's catalog search menu into a split button This patch modifies the markup for the staff client header's catalog search menu so that it mimics the behavior of a Bootstrap split button (As seen on the cataloging home page's 'New from Z39.50' button). To test, apply the patch, run 'yarn build' to regenerate the staff client's CSS, and clear your browser cache. - View any page in the staff client. - Hover your mouse over the "Search" link in the header. It should trigger a hover affect on the adjacent menu link. - Clicking the "Search" link should take you directly to the advanced search page. - Clicking the adjacent menu link should display a menu containing links to advanced search and item search. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:55:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:55:25 +0000 Subject: [Koha-bugs] [Bug 20217] Make header's catalog search menu into a split button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:58:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:58:27 +0000 Subject: [Koha-bugs] [Bug 15336] Script for merging vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #38 from Katrin Fischer --- The file doesn't have the right permissions (misisng +x). Can you pleas fix? Tests look good, will earn it a PQA most likely! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 14:59:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 13:59:36 +0000 Subject: [Koha-bugs] [Bug 19549] Reserve Slip prints first found hold when patron has multiple holds on a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |victor.grousset at biblibre.co | |m --- Comment #5 from Victor Grousset/tuxayo --- Conflicts: Bug 19549 - Reserve Slip prints first found hold when patron has multiple holds on a biblio 68855 - Bug 19549 - Reserve Slip prints first found hold when patron has multiple holds on a biblio Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 19549 - Reserve Slip prints first found hold when patron has multiple holds on a biblio Using index info to reconstruct a base tree... M C4/Reserves.pm M circ/circulation.pl M circ/hold-transfer-slip.pl M circ/returns.pl M koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt M koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt M t/db_dependent/Reserves.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Reserves.t Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging circ/returns.pl CONFLICT (content): Merge conflict in circ/returns.pl Auto-merging circ/hold-transfer-slip.pl Auto-merging circ/circulation.pl Auto-merging C4/Reserves.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 19549 - Reserve Slip prints first found hold when patron has multiple holds on a biblio The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-19549---Reserve-Slip-prints-first-found-hold-w-T4NFp1.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:06:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:06:32 +0000 Subject: [Koha-bugs] [Bug 10943] Impossible to manage fines without borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |victor.grousset at biblibre.co | |m --- Comment #15 from Victor Grousset/tuxayo --- ~/d/koha ??? git bz apply 10943 Bug 10943 - Impossible to manage fines without borrowers permission 35355 - [SIGNED OFF] Bug 10943 - Impossible to manage fines without borrowers permission Added check for borrowers permission as that is also required when accessing fines. 70597 - Bug 10943: Manage files without borrowers permission Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 10943 - Impossible to manage fines without borrowers permission Added check for borrowers permission as that is also required when accessing fines. Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 10943 - Impossible to manage fines without borrowers permission Added check for borrowers permission as that is also required when accessing fines. The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/SIGNED-OFF-Bug-10943---Impossible-to-manage-fines--VbHqCV.patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:07:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:07:51 +0000 Subject: [Koha-bugs] [Bug 18816] Make CataloguingLog work in production by preventing circulation from spamming the log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18816 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:14:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:14:51 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #193 from Julian Maurice --- Seen with S?verine, the error disappeared... Probably a browser cache problem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:16:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:16:22 +0000 Subject: [Koha-bugs] [Bug 11512] Forced holds that violate issuing rules will never be filled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11512 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:16:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:16:26 +0000 Subject: [Koha-bugs] [Bug 11512] Forced holds that violate issuing rules will never be filled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11512 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68595|0 |1 is obsolete| | --- Comment #6 from Jesse Maseto --- Created attachment 72689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72689&action=edit Bug 11512 - Forced holds that violate issuing rules will never be filled Currently in Koha, if you choose to force a hold from the staff side that would contravened the current issuing rules, that hold will never be filled, as it is always skipped over by CheckReserves. This patch disallows overrideing except for tooManyReserves which are the only overridden holds that will be trapped. Test Plan: 1) Apply this patch 2) Attempt to override hold placement, only placements where the patron has too many holds already should be allowed Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:18:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:18:11 +0000 Subject: [Koha-bugs] [Bug 18593] Suggestions aren't updated when one biblio is merged with another In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18593 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #6 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Lucie Gay -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:18:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:18:24 +0000 Subject: [Koha-bugs] [Bug 18593] Suggestions aren't updated when one biblio is merged with another In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18593 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70233|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:18:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:18:32 +0000 Subject: [Koha-bugs] [Bug 18593] Suggestions aren't updated when one biblio is merged with another In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18593 --- Comment #7 from sandboxes at biblibre.com --- Created attachment 72690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72690&action=edit Bug 18593: Move suggestions when bibliographic records are merged When bibliographic records are merged, the suggestions.biblionumber field should be replaced with the new record. Ideally we should have kept an history of the merges, to know what was the original record. Now we cannot fix the broken links. Test plan: 1) Create a suggestion in OPAC 2) Accept the suggestion in staff 3) Add order from this suggestion 4) Go to cataloguing search and search for the record and another 5) Merge the suggestion record with the catalog record - catalog record wins (should be the more common case when a patron suggests something that already exists) 6) Verify that after merging, the new title displays in the acquisition record 7) Verify that the suggestion info no longer displays in basket >From Katrin's test plan: 8) Verify that the new title doesn't display in suggestions. The old title will still show as suggested (not updated) => This is the title from suggestions.title, I think it makes sense to show this one. Maybe we should open a new bug report to improve the display of the suggestion, and link to the bibliographic record Signed-off-by: Lucie Gay -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:25:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:25:08 +0000 Subject: [Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:26:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:26:01 +0000 Subject: [Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- As 4078 is now PQA, I agree with Jonathan. Alex, can you please take a look? Sorry! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:27:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:27:05 +0000 Subject: [Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 --- Comment #5 from Katrin Fischer --- Please also check: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep6.tt FAIL forbidden patterns forbidden pattern: Include [% KOHA_VERSION %] in js paths (bug 12904) - May be false positive (line 12) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:27:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:27:18 +0000 Subject: [Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:28:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:28:00 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:28:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:28:04 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72069|0 |1 is obsolete| | --- Comment #194 from S?verine Queune --- Created attachment 72691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72691&action=edit Bug 11708: Add aqbasketgroups.closeddate Signed-off-by: juliette levast Signed-off-by: Paola Rossi Patch updated: Use atomic update Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:28:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:28:42 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72070|0 |1 is obsolete| | --- Comment #195 from S?verine Queune --- Created attachment 72692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72692&action=edit Bug 11708: Unit tests for aqbasketgroups.closeddate Signed-off-by: juliette levast Signed-off-by: Paola Rossi Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:28:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:28:51 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72071|0 |1 is obsolete| | --- Comment #196 from S?verine Queune --- Created attachment 72693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72693&action=edit Bug 11708: basketgroup.pl can now display basketgroups for all suppliers This happens when no booksellerid is given. This patch also adds 4 columns: - No. of ordered titles - No. of received titles - Ordered amount - Charged amount (amount of received orders) Add filters to basketgroup tables columns Show closed date in closed basketgroups tables Signed-off-by: juliette levast Signed-off-by: Paola Rossi Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:28:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:28:58 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72072|0 |1 is obsolete| | --- Comment #197 from S?verine Queune --- Created attachment 72694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72694&action=edit Bug 11708: Remove column aqbasketgroups.closed It is redundant with aqbasketgroups.closeddate Signed-off-by: Paola Rossi Patch updated: use atomic update Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:29:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:29:04 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72073|0 |1 is obsolete| | --- Comment #198 from S?verine Queune --- Created attachment 72695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72695&action=edit Bug 11708: Place "Basket groups" menu entry on top of the side navigation Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:29:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:29:12 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72074|0 |1 is obsolete| | --- Comment #199 from S?verine Queune --- Created attachment 72696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72696&action=edit Bug 11708: New page for basket groups This patch moves the code responsible for displaying a list of basket groups into its own Perl script (acqui/basketgroups.pl), making the code in basketgroup.pl and basketgroup.tt a little bit easier to read. basketgroups.pl displays all basket groups in a single table (as bug 13371 for vendors) where rows are grouped by bookseller. In the process, this patch adds 4 new "Koha::Object" modules: - Koha::Bookseller(s) - Koha::Basket(s) - Koha::Basketgroup(s) - Koha::Order(s) It also adds a wrapper around the new DataTable() constructor to be able to use it with the same defaults than the previous dataTable() constructor Test plan: 0. Create a bunch of booksellers and basketgroups 1. Go back to acquisitions home page and click on "Basket groups" link on the left 2. Play with the table (sort, filter) and try every possible actions (Edit, Close and export as PDF, View, Reopen, Export as CSV) 3. Go to a specific vendor page and click on "Basket groups" tab 4. Check that only the vendor's basket groups are displayed Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:29:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:29:19 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72075|0 |1 is obsolete| | --- Comment #200 from S?verine Queune --- Created attachment 72697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72697&action=edit Bug 11708: UT: Replace 'ok' by 'is' where appropriate Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:29:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:29:27 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72076|0 |1 is obsolete| | --- Comment #201 from S?verine Queune --- Created attachment 72698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72698&action=edit Bug 11708: UT: Use DateTime instead of localtime+sprintf Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:29:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:29:34 +0000 Subject: [Koha-bugs] [Bug 18593] Suggestions aren't updated when one biblio is merged with another In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18593 Lucie Gay changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucie.gay at ens-paris-saclay. | |fr --- Comment #8 from Lucie Gay --- It's ok : the new title displays in the acquisition record after merging, but not in suggestions. However the information "Available in library" displays in suggestions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:29:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:29:36 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72077|0 |1 is obsolete| | --- Comment #202 from S?verine Queune --- Created attachment 72699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72699&action=edit Bug 11708: Move acq related Koha::Objects to Koha::Acquisition namespace and fix Koha::Acquisition::Order usage everywhere Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:40:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:40:23 +0000 Subject: [Koha-bugs] [Bug 19549] Reserve Slip prints first found hold when patron has multiple holds on a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:40:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:40:26 +0000 Subject: [Koha-bugs] [Bug 19549] Reserve Slip prints first found hold when patron has multiple holds on a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68855|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 72700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72700&action=edit Bug 19549 - Reserve Slip prints first found hold when patron has multiple holds on a biblio In C4/Reserves.pm the ReserveSlip function uses this call to get the reserve: 1982 my $hold = Koha::Holds->search({biblionumber => $biblionumber, borrowernumber => $borrowernumber })->next; If a patron has multiple holds there is no way to know if we have the correct one. This function should be updated to take an itemnumber as well and all calls updated. Test Plan: 1) Apply this patch 2) Capture some holds, ensure the correct hold was caught and printed in the notice 3) prove t/db_dependent/Reserves.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:44:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:44:07 +0000 Subject: [Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Katrin Fischer --- Hi Marcel, 2 things I am afraid. 1) Question: I notice all other options are are -- and the new one is the only one - - is there a reason to use one or the other? 2) The example given doesn't work for me: kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ ./misc/maintenance/borrowers-force-messaging-defaults.pl --doit -category PT Since: 0000-00-00 DBD::mysql::st execute failed: Column 'categorycode' in where clause is ambiguous [for Statement "SELECT DISTINCT bo.borrowernumber, bo.categorycode FROM borrowers bo LEFT JOIN borrower_message_preferences mp USING (borrowernumber) WHERE bo.dateenrolled >= ? AND categorycode = ?" with ParamValues: 0='0000-00-00', 1='PT'] at ./misc/maintenance/borrowers-force-messaging-defaults.pl line 62. DBD::mysql::st fetchrow failed: fetch() without execute() [for Statement "SELECT DISTINCT bo.borrowernumber, bo.categorycode FROM borrowers bo LEFT JOIN borrower_message_preferences mp USING (borrowernumber) WHERE bo.dateenrolled >= ? AND categorycode = ?" with ParamValues: 0='0000-00-00', 1='PT'] at ./misc/maintenance/borrowers-force My database is using the test date, I made sure there are patrons with category PT. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:44:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:44:35 +0000 Subject: [Koha-bugs] [Bug 19549] Reserve Slip prints first found hold when patron has multiple holds on a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jschmidt at switchinc.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:47:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:47:33 +0000 Subject: [Koha-bugs] [Bug 17897] Koha::SearchMappingManager - Simplify search mapping modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17897 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |nick at bywatersolutions.com --- Comment #4 from Nick Clemens --- fatal: sha1 information is lacking or useless (Koha/SearchEngine/Elasticsearch.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:48:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:48:05 +0000 Subject: [Koha-bugs] [Bug 17885] Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #12 from Nick Clemens --- Should be QAed together with 17897 which contains the tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:48:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:48:20 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #57 from Katrin Fischer --- Patch doesn't apply, please rebase! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:51:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:51:13 +0000 Subject: [Koha-bugs] [Bug 17885] Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |BLOCKED --- Comment #13 from Katrin Fischer --- Thx Nick for taking a look. Moving to BLOCKED for now, move back to Signed off once dependency is resolved please. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:51:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:51:51 +0000 Subject: [Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 12 15:51:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Mar 2018 14:51:54 +0000 Subject: [Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 --- Comment #11 from Owen Leonard --- Created attachment 72701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72701&action=edit Bug 19709 (follow-up) Add KOHA_VERSION variables to js includes This follow-up adds the new [%i KOHA_VERSION %] variable to some