[Koha-bugs] [Bug 20318] New: Merge invoices can lead to an merged invoice without Invoice number

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20318

            Bug ID: 20318
           Summary: Merge invoices can lead to an merged invoice without
                    Invoice number
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: christophe.croullebois at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

When you want to merge invoices you have a page with a non editable field
'Invoice number:' it shows the content of the first invoice to be merged.
But if you validate by clicking the 'merge' button you arrive on the next page
which says that 'Invoice has been modified' and if you quit this page without
saving you have now a merged invoice without Invoice number.
This tiny patch just prevents this issue to occur.

Test plan :

1° go to the acqui/invoices.pl page and search invoices to merge.
You must have at least 2 invoices on the same vendor
2° check boxes to select invoices to merge and click on 'merge selected
invoices' button
3° next page you see the non editable field 'Invoice number:'
4° click on the 'merge' button
5° next page you see 'Invoice has been modified'
6° leave this page i.e click on the left link 'Invoices'
7° search invoices you'll see the merged invoice without invoice number.

Apply the patch, replay the steps 1 to 3
4° on this page you can enter your invoice number and click on the 'merge'
button.
If you leave this field empty and click merge, a message informs you that it is
required and you can not merge.
Thx

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.