[Koha-bugs] [Bug 20271] Merge deleted/old tables with their "alive" cousins
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Mon Mar 5 09:35:03 CET 2018
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #6 from Francesco Rivetti <oha at oha.it> ---
(In reply to Josef Moravec from comment #5)
> there is missing atomic database update
It is on its way.
(It's fairly easy to do something reasonable, but there are some corner cases
which I would like to handle somehow better)
I would left the deleted* tables there with any clashing rows and let the
administrator deal with it in case there are problems. thoughts?
> I am not sure about the changes in OAI, so need to investigate more later
Thank you so much, I wish I knew more about OAI
> ::: C4/Biblio.pm
> @@ -3182,5 @@
> > - my $bkup_sth = $dbh->prepare($query);
> > - $bkup_sth->execute(@bind);
> > - $bkup_sth->finish;
> > -
> > - _koha_delete_biblio_metadata( $biblionumber );
>
> this is missing in your patch
I might be lagging behind master, because I can't find it.
> ::: C4/Items.pm
> @@ +1061,4 @@
> > FROM items
> > LEFT JOIN branches AS holding ON items.holdingbranch = holding.branchcode
> > LEFT JOIN branches AS home ON items.homebranch=home.branchcode
> > + LEFT JOIN biblio ON biblio.biblionumber = items.biblionumber AND biblio.deleted_at IS NULL
>
> I don't think this will work, that's condition should be in where clause
I actually think it will be irrelevant. The FKs should make sure that if there
is an item, there must be the biblio which it refers.
Or am I missing something?
> ::: misc/export_records.pl
> @@ +105,5 @@
> > push @record_ids, $_->{biblionumber} for @{
> > + $dbh->selectall_arrayref(q|
> > + SELECT biblionumber
> > + FROM biblioitems
> > + |, { Slice => {} }, ( $timestamp ) x 4 );
>
> Please include the changes made by Bug 19730
Is it in master, right?
TIA
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list