[Koha-bugs] [Bug 20167] Item hold is set to bibliographic hold when changing pickup location

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20167

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Stefan Berndtsson from comment #0)
> If a patron has an item level hold with pickup location set to library A and
> staff then (via the Holds tab in the patron view) changes pickup location to
> library B, itemnumber is lost from the hold. This is a definite problem when
> the items within a bibliographic record are different things (separate
> volumes for example).
> 
> This can be fixed by adding some code in Koha/REST/V1/Hold.pm
> 
> This bit before the ModReserve call:
> 
>     if($hold->itemnumber()) {
>         $params->{itemnumber} = $hold->itemnumber();
>     }
> 
> 
> However, given the FIXME comment in C4/Reserves.pm for ModReserve, I'm
> wondering if this is the desired fix:
> "Note that the forgoing can have the effect of causing
> item-level hold requests to turn into title-level requests.  This
> will be fixed once reserves has separate columns for requested
> itemnumber and supplying itemnumber."
> 
> 
> A different method of solving this issue could be to provide itemnumber as
> part of the pickup-location-change call instead and keep the rest of the
> REST-API and ModReserve the way it works now. I'm somewhat unfamiliar with
> the how the Mojolicious system works, so I haven't looked into that method
> yet.

I think your proposed solution is the right onw.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.