[Koha-bugs] [Bug 19164] Allow MARC modification templates to be used in staged MARC imports

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19164

--- Comment #22 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Been doing some more playing with this.  On my kohadevbox, applying this patch
to the latest master, making a MARC modification rule of:

  Copy field 960$q to 998$q

and then applying it to the export_201710031044.mrc file doesn't give me any
errors on the command line, and appears to copy the 960$q to 998$q in the
staged records as expected.

Then I tried going to the 16.11.x branch in git and applying the patch on top
of that.  The patches apply OK, but the import fails (test1.mrc is my copy of
the uploaded MARC file):

vagrant at kohadevbox:kohaclone(16.11.x)$ git checkout -b bug_19164_16_11
Switched to a new branch 'bug_19164_16_11'
vagrant at kohadevbox:kohaclone(bug_19164_16_11)$ git bz apply 19164
Bug 19164 - Allow MARC modification templates to be used in staged MARC imports

68249 - Patch for misc/stage_file.pl script to provide for MARC modification
template support.
68425 - Bug_19164: remove use strict/warn lines (were commented out anyway)

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Patch for misc/stage_file.pl script to provide for MARC modification
template support.
Applying: Bug_19164: remove use strict/warn lines (were commented out anyway)
vagrant at kohadevbox:kohaclone(bug_19164_16_11)$ misc/stage_file.pl --file
~/test.mrc --add-items --marcmodtemplate "Test Bug 19164" --item-action replace
--comment "testing MARC mod templates on batch staging"
... staging MARC records -- please wait
Not a HASH reference at /home/vagrant/kohaclone/C4/Biblio.pm line 2786.


Hmm, so it looks like something is broken for using this patch with the latest
16.11.x. The question now is, as this is an enhancement (ie adding a new
feature to Koha), do we worry about that too much if its working in the master
train?

-- 
You are receiving this mail because:
You are watching all bug changes.