[Koha-bugs] [Bug 20340] Ability to use authentication plugin

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Alex Arnaud from comment #9)
> (In reply to Alex Arnaud from comment #8)
> > (In reply to Kyle M Hall from comment #5)
> > > (In reply to Alex Arnaud from comment #4)
> > > > (In reply to Kyle M Hall from comment #3)
> > 
> > > I would say the plugin itself should be responsible for having controls to
> > > tell Koha if it is enabled or not. There is already precedence for this in
> > > Koha ( see bug 19173 ). For simplicity, the plugin could simply return
> > > values as if the authentication failed, for the sake of simplicity.
> > > 
> > > What do you think?
> > 
> > You mean: plugin exists (in the plugins directory) == plugin enabled ? That
> > also means we need to delete it for make it disabled, right?
> > 
> > 
> > If we assume that we want to loop on several plugins, it could be nice to be
> > able to set an ordered stack of authentication modules. This could allow us
> > to chose which one is used first etc... In this case we need a dedicated
> > page in fact.
> 
> Oh, think i see! We can configure plugins and so use the plugins_data. Also
> this could allow use to define a "weight" to set the execution order

No, just the plugin store it's on 'on/off' switch. If it is set to off, have
the plugin always return 0 for checkauth.

I personally don't find the ability to set the order to be necessary, but your
idea would work. If each plugin stored a param call 'priority' in plugin_data
table, it would be easy to do what you propose!

-- 
You are receiving this mail because:
You are watching all bug changes.