[Koha-bugs] [Bug 19549] Reserve Slip prints first found hold when patron has multiple holds on a biblio

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Mar 12 15:40:26 CET 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68855|0                           |1
        is obsolete|                            |

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 72700
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72700&action=edit
Bug 19549 - Reserve Slip prints first found hold when patron has multiple holds
on a biblio

In C4/Reserves.pm the ReserveSlip function uses this call to get the reserve:
1982     my $hold = Koha::Holds->search({biblionumber => $biblionumber,
borrowernumber => $borrowernumber })->next;

If a patron has multiple holds there is no way to know if we have the correct
one.

This function should be updated to take an itemnumber as well and all calls
updated.

Test Plan:
1) Apply this patch
2) Capture some holds, ensure the correct hold was caught and printed in the
notice
3) prove t/db_dependent/Reserves.t

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list