[Koha-bugs] [Bug 19926] Add the Koha::Object->unblessed_all_relateds method

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Mar 13 11:11:19 CET 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19926

Benjamin Rokseth <benjamin.rokseth at deichman.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70327|0                           |1
        is obsolete|                            |

--- Comment #3 from Benjamin Rokseth <benjamin.rokseth at deichman.no> ---
Created attachment 72764
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72764&action=edit
Bug 19926: Add the Koha::Object->unblessed_all_relateds method

In order to refactor our legacy code step-by-step, we will need to
provide code with the exact same behaviors and then improve it.

The same idea appears for the TT syntax for notices: we will want to
deprecate the existing syntax in order to support only one syntax.
Currently we fetch all the values from the related tables, without
knowing which are actually used.

I am suggestion to introduce a Koha::Object->unblessed_all_relateds
method which will return a hash containing all the fields from the
related tables (with the problems we know: collision in column names).
It is the existing behavior of GetOverduesForPatron and GetPendingIssues
for instance, they are used to send notices and so we have to provide
all the data needed.

See dependent bugs to understand the context and test this patch.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at deichman.no>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list