[Koha-bugs] [Bug 20346] Patron filtering resulting in new search rather than filtering existing results

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Mar 14 10:58:52 CET 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20346

--- Comment #8 from paxed <pasi.kallinen at joensuu.fi> ---
Comment on attachment 72815
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72815
Bug 20346 - New wording above the patron table on the patron page

Untranslatable strings:

+                     filtered = " starting with ";
+               } else {
+                     filtered = " containing ";
+               }
+               filtered += "'" + $("#searchmember_filter").val() + "'";

These would also better written using _(" starting with '%s'").format(...)
instead of concatenation.

Same problems here:

+                    filtered += " begins with " + "'" +
$("#firstletter_filter").val() +"'";
+                 } else {
+                    filtered = " begins with " + "'" +
$("#firstletter_filter").val() +"'";

And here:

+                    filtered += " with category " + "'" +
$("#categorycode_filter").find("option:selected").text() + "'";
+                  } else {
+                    filtered = " with category " + "'" +
$("#categorycode_filter").find("option:selected").text() + "'";

And:

+                    filtered += " in library " +
$("#branchcode_filter").find("option:selected").text();
+                 } else {
+                    filtered = " in library " +
$("#branchcode_filter").find("option:selected").text();

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list