[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Mar 14 15:33:29 CET 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Lucie Gay <lucie.gay at ens-paris-saclay.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #27 from Lucie Gay <lucie.gay at ens-paris-saclay.fr> ---
Tested on Unimarc sandbox.

Patch applied but there are error messages : 

-----

The sandbox you've requested is now ready.
The patches attached to bugzilla 18887 have been applied, and the result is:

Updatedatabase:
Upgrade to 17.12.00.000 done (Tē tōia, tē haumatia)
Upgrade to 17.12.00.001 done (Bug 19724 - Add
[deleted]biblio_metadata.timestamp)
Upgrade to 17.12.00.002 done (Bug 19096 - Make Default authoritative for Koha
to MARC mappings)
Upgrade to 17.12.00.003 done (Bug 10021 - Drop notifys-related table and
columns)
Upgrade to 17.12.00.004 done (Bug 19278 - Add a configurable default page size
for REST endpoints)
Upgrade to 17.12.00.005 done (Bug 18915 - Correct CHECKOUT_NOTE notice
template)
Upgrade to 17.12.00.006 done (Bug 17682 - Update URL for Google Scholar in
OPACSearchForTitleIn)
Upgrade to 17.12.00.007 done (Bug 15707 - Add new table library_groups)
Upgrade to 17.12.00.008 done (Bug 16735 - Migrate library search groups into
the new hierarchical groups)
Upgrade to 17.12.00.009 done (Bug 18403 - Add the
view_borrower_infos_from_any_libraries permission )
Upgrade to 17.12.00.010 done (Bug 20133 - Add
library_groups.ft_hide_patron_info)
Upgrade to 17.12.00.011 done (Bug 20157 - Use group 'features' to decide which
groups to use for group searching functionality)
Upgrade to 17.12.00.012 done (Bug 15752 - Add system preference
AutoSwitchPatron)
Upgrade to 17.12.00.013 done (Bug 20175 - Set DEFAULT NULL value for
club_enrollments.date_created)
Upgrade to 17.12.00.014 done (Bug 19790 - Remove additionalauthors.author from
installer files)
Upgrade to 17.12.00.015 done (Bug 20144 - Adapt DB structure to work with new
SQL modes)
Upgrade to 17.12.00.016 done (Bug 18336 - Convert DB tables to utf8mb4 ��)
Upgrade to 17.12.00.017 done (Bug 17672 - Add damaged_on to items and
deleteditems tables)
Upgrade to 17.12.00.018 done (Bug 19290 - Add system preference
BrowseResultSelection)
Upgrade to 17.12.00.019 done (Bug 20074 - Auth_subfield_structure changes
hidden attribute)
Upgrade to 17.12.00.020 done (Bug 20082 - Update descriptions of Vietnamese
language)
Upgrade to 17.12.00.021 done (Bug 13287 - Add system preference
PurgeSuggestionsOlderThan)
DEV atomic update: bug_18887.perl
DBD::mysql::db do failed: Unknown column 'max_holds' in 'field list' [for
Statement "
        INSERT INTO circulation_rules ( branchcode, categorycode, itemtype,
rule_name, rule_value )
        SELECT branchcode, categorycode, NULL, 'max_holds', COALESCE(
max_holds, '' ) FROM branch_borrower_circ_rules
    "] at (eval 1179) line 21.
DBD::mysql::db do failed: Unknown column 'max_holds' in 'field list' [for
Statement "
        INSERT INTO circulation_rules ( branchcode, categorycode, itemtype,
rule_name, rule_value )
        SELECT NULL, categorycode, NULL, 'max_holds', COALESCE( max_holds, '' )
FROM default_borrower_circ_rules
    "] at (eval 1179) line 26.
DBD::mysql::db do failed: Can't DROP 'max_holds'; check that column/key exists
[for Statement "
        ALTER TABLE branch_borrower_circ_rules DROP COLUMN max_holds
    "] at (eval 1179) line 31.
DBD::mysql::db do failed: Can't DROP 'max_holds'; check that column/key exists
[for Statement "
        ALTER TABLE default_borrower_circ_rules DROP COLUMN max_holds
    "] at (eval 1179) line 35.
Upgrade to XXX done (Bug 18887 - Introduce new table 'circulation_rules', use
for 'max_holds' rules)

------

Staff interface works, but when I go in admin > Circulation and fines rules
(cgi-bin/koha/admin/smart-rules.pl), there are error messages :

Global symbol "$max_holds" requires explicit package name (did you forget to
declare "my $max_holds"?) at /home/koha/src/admin/smart-rules.pl line 283.
Global symbol "$max_holds" requires explicit package name (did you forget to
declare "my $max_holds"?) at /home/koha/src/admin/smart-rules.pl line 284.
Global symbol "$max_holds" requires explicit package name (did you forget to
declare "my $max_holds"?) at /home/koha/src/admin/smart-rules.pl line 284.
Global symbol "$max_holds" requires explicit package name (did you forget to
declare "my $max_holds"?) at /home/koha/src/admin/smart-rules.pl line 315.
Global symbol "$max_holds" requires explicit package name (did you forget to
declare "my $max_holds"?) at /home/koha/src/admin/smart-rules.pl line 347.
Global symbol "$max_holds" requires explicit package name (did you forget to
declare "my $max_holds"?) at /home/koha/src/admin/smart-rules.pl line 405.
Execution of /home/koha/src/admin/smart-rules.pl aborted due to compilation
errors.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list