[Koha-bugs] [Bug 19520] Show more information about rotating collections

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520

--- Comment #5 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 72819
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72819
Bug 19520: Update database

Review of attachment 72819:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19520&attachment=72819)
-----------------------------------------------------------------

:::
installer/data/mysql/atomicupdate/Bug19520_Add_more_information_to_rotating_collections.perl
@@ +5,5 @@
> +    $dbh->do( "ALTER TABLE collections ADD CONSTRAINT `collections_ibfk_2` FOREIGN KEY (`createdBy`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE CASCADE");
> +
> +    $dbh->do( "ALTER TABLE collections ADD COLUMN createdOn datetime default NULL AFTER createdBy" );
> +
> +    $dbh->do( "ALTER TABLE collections ADD COLUMN lastTransferredOn datetime default NULL AFTER createdOn" );

These 4 do's should be encapsulated by !column_exists checks.

@@ +10,5 @@
> +
> +    # or perform some test and warn
> +    # if( !column_exists( 'biblio', 'biblionumber' ) ) {
> +    #    warn "There is something wrong";
> +    # }

And you don't need comments. :)

-- 
You are receiving this mail because:
You are watching all bug changes.