[Koha-bugs] [Bug 20438] New: Allow uninstalling plugins not implementing the 'uninstall' method

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20438

            Bug ID: 20438
           Summary: Allow uninstalling plugins not implementing the
                    'uninstall' method
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

The plugins handling code expects plugins implementing an 'uninstall' method
for cleanup purposes. It executes this method, and then moves on with removing
the configuration entries in the storage, and the plugin itself.

But the 'plugins-home.tt' template makes the tool display the 'Uninstall' link
in the dropdown ONLY when the plugin has the 'uninstall' method.

This is incorrect!

To reproduce:
- Install the KitchenSink plugin [1]
=> SUCCESS: The 'actions' dropdown for KitchenSink shows an 'Uninstall' option
- Edit the code for the plugin:
  $ sudo vim
/var/lib/koha/kohadev/plugins/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm
- Remove the uninstall sub
- Restart everything:
  $ restart_all
- Reload the browser
=> FAIL: There's no 'Uninstall' option in the actions dropdown.


[1] https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.