[Koha-bugs] [Bug 20180] Remove GROUP BY clause in manage-marc-import.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180

--- Comment #4 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 71625
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71625
Bug 20180: [sql_modes] Remove GROUP BY clause in manage-marc-import.pl

Review of attachment 71625:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20180&attachment=71625)
-----------------------------------------------------------------

::: tools/manage-marc-import.pl
@@ +62,4 @@
>  our $sessionID = $cookies{'CGISESSID'}->value;
>  our $dbh = C4::Context->dbh;
>  
> +my $frameworks = Koha::BiblioFrameworks->search({ tagfield => { 'not' => undef } }, { join => 'marc_tag_structure', distinct => 'frameworkcode', order_by => ['frameworktext'] });

Ah! You need the join to confirm there are actually fields to be used for
importing. Otherwise, you do lots of work to import nothing.

-- 
You are receiving this mail because:
You are watching all bug changes.