[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Colin Campbell from comment #4)
> Where was the test when this code was introduced to break EDI?

A lack of a test does not obviate our responsibility to add regression tests
where possible and reasonable. Adding unit tests while fixing regressions in
Koha is a very common occurrence. I do understand the frustration as I've been
in this situation dozens of times ; )

I notice that there unit test files for invoices and orders, but not quotes. Is
there any reason quotes weren't unit tested when introduced?

I'll leave it to cait of mtompsett to decide if unit tests are necessary.

> Basically people cant run Edifact EDI with the addition of this code
> It undoes a change that should never have been made

Your patch seems to introduce a regression of its own. Baskets in Koha can now
override AcqCreateItem with their own alternative setting. The patch I've
submitted should take care of the issue and keep support for the new feature!

-- 
You are receiving this mail because:
You are watching all bug changes.