[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #9 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Colin Campbell from comment #7)
> Kyle your patch is illogical the baskets in question CANNOT override the
> syspreference, because we have just created them in accordance with that
> syspreference microseconmds before. 
> Baskets can override the systempreference if there is user interaction to
> make that choice, the whole point of electronic ordering is that there is no
> such interaction and the basket is generated from the QUOTES message
> directly with no user interaction.
> reinstanting the original patch

But his change allows for the case where there IS user interaction. And if it
was created microseconds before, the values should be identical. If it is user
interaction later, why should a system preference change after the order
creation change the behaviour? Once the order is created, should you not change
the behaviour on the order, not forcefully via system preference?

This is why tests are very much needed, because then we'd know how it is
supposed to behave, because the tests would demonstrate trigger cases. Marking
Failed QA until I see tests.

-- 
You are receiving this mail because:
You are watching all bug changes.