[Koha-bugs] [Bug 20452] Add HTML classes to search results availability data

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Mar 21 07:25:11 CET 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20452

--- Comment #3 from paxed <pasi.kallinen at joensuu.fi> ---
(In reply to M. Tompsett from comment #2)
> While the patch is good, I'm thinking that such short generic names is
> probably a bad thing. For example, look at the staff-global.css or the
> opac.less file. There are branchgrid things or #item things. Perhaps just
> adding the word list would be a good idea?

The patch doesn't add any branchgrid class, so I don't know why that would be a
problem? Also, staff-global.css doesn't have any selectors for #item? (And the
patch doesn't add any item class either - it has itemcn, which is not matched
by anything in staff-global.css - and certainly shouldn't be!

If there were any css selectors that match globally with a short, generic,
simple word commonly used in Koha (say, for example. "item"), then those
selectors should be written to be more specific - For example, a hypothetical:

#item { background: pink; }

should be written to match only at the place where we want that pink
background, say in the search results:

#searchresults #item { background: pink; }

Otherwise, the too widely matching selector would have side effects, for
example sometime later, people might add code that uses class item, but aren't
expecting it to show up with pink bg.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list