[Koha-bugs] [Bug 17978] Circ rules will not limit holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72547|0                           |1
        is obsolete|                            |

--- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 73161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73161&action=edit
Bug 17978 - Circ rules will not limit holds

The crux of this issue is that all those holds are unfilled record level holds.
The code that checks for the number of holds the user already has *always* uses
a branchcode of some form. Because of this, any open record level holds are
completely ignored for this purpose.

Test Plan:
1) Set ReservesControlBranch to "item's home library"
2) Set an All libraries/All Patrons/All itemtypes rules limiting a patron to 2
holds
3) Place 3 record level holds, you can but you should not be able to!
4) Delete the holds
5) Apply this patch
6) Attempt to place 3 record level holds
7) Note that you cannot!

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.