[Koha-bugs] [Bug 12310] Accept different monetary formats as input

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73055|0                           |1
        is obsolete|                            |

--- Comment #53 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Created attachment 73215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73215&action=edit
Bug 12310 : Decimal separators issues: some fixes in fines and acquisitions

The main aim is to prevent
- x100 or /100 of the amounts
- decimal part truncation

Fixes Bug 19521 - Partial fine payment is not working with comma decimal
separator
But not Bug 18723 - Dot not recognized as decimal separator (aquisitions)
  It will be done in a follow up patch. This one is already too huge to test.

Bonuses:
- get rid of the spaces, currency symbols, names (EUR)

It handles:
- by default comma and dot as decimal separators on the same instance
- dot or comma as thousands separators if choose to use only one of them
    as decimal separator. See DigitSeparator syspref.

== Test plan ==
1. In the manual invoice (cgi-bin/koha/members/maninvoice.pl)
2. Apply the annex 1 to the "Amount" field
3. When paying a fine (cgi-bin/koha/members/paycollect.pl)
4. Click on "Pay amount" to go to the page to pay all fines
5. Apply the annex 1 to the "Collect from patron" field
6. Click on "Pay" to go to the page to pay fine
7. Apply the annex 1 to the "Collect from patron" field
8. Go to "Create manual credit" (staff://cgi-bin/koha/members/mancredit.pl)
9. Apply the annex 1 to the "Amount" field
10. Go to the "Add budget" page
      staff://cgi-bin/koha/admin/aqbudgetperiods.pl?op=add_form
11. Apply the annex 1 to the "Total amount" field
12. Create an active budget
13. Go to the "Add Fund" page for this budget
14. Apply the annex 1 to the "Amount" field
15. Apply the annex 1 to the "Warning at (amount)" field
16. If you have ideas of stuff to try to find *regressions* from the
      previous versions, then try. You might spare librarian tears by
      finding something before it's released.
17. Express your happiness. This is important, otherwise the signoff
      spell won't work! The details of expressing your happinnes
      depends on your culture and habits.

=== Annex 1: Subpart for each concerned page ===
1. Set DigitSeparator syspref to ",."
2. Input "12,34"
3. Press the "Tab/Tabulation" key. It will unfocus the field and trigger
     the conversion. Validating the form does the same but it's a trick
     to test more quickly by not changing the page.
4. Ensure that it's converted to 12.34
5. Do the same with "12.34 EUR" and ensure that it's converted to "12.34"
6. Same with "EUR 12.34" → "12.34"
7. "123 456,7" → "123456.7"
8. "EUR 12.34 hi lyon3" → "12.34"
9. "2" → "2"
10. "2,0" → "2.0"
XX. TODO WIP thousands sep and other relevant cases
XX. Finally validate the form and check that the final value with the dot was
      well handled.
XX. Thinks about Koalas and smile.

-- 
You are receiving this mail because:
You are watching all bug changes.