From bugzilla-daemon at bugs.koha-community.org Tue May 1 00:31:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Apr 2018 22:31:24 +0000 Subject: [Koha-bugs] [Bug 20086] AddRenewal is not executed as a transaction and can results in partial success and doubled fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20086 Cheryl changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman at fargolibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 00:34:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Apr 2018 22:34:51 +0000 Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Edie Discher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |edischer at cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 00:40:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Apr 2018 22:40:18 +0000 Subject: [Koha-bugs] [Bug 16970] In OPAC Search results, hides a record if some of its items are available and others unavailable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16970 Edie Discher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |edischer at cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 00:40:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Apr 2018 22:40:42 +0000 Subject: [Koha-bugs] [Bug 16970] In OPAC Search results, hides a record if some of its items are available and others unavailable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16970 Cheryl changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman at fargolibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 00:48:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Apr 2018 22:48:02 +0000 Subject: [Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 Cheryl changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman at fargolibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 00:48:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Apr 2018 22:48:53 +0000 Subject: [Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 Edie Discher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |edischer at cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 03:19:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 01:19:45 +0000 Subject: [Koha-bugs] [Bug 20686] New: OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspref disabled Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20686 Bug ID: 20686 Summary: OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspref disabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org more info to come... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 03:36:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 01:36:18 +0000 Subject: [Koha-bugs] [Bug 20686] OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspref disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20686 --- Comment #1 from Mason James --- Created attachment 74943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74943&action=edit pic 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 03:39:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 01:39:16 +0000 Subject: [Koha-bugs] [Bug 20686] OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspref disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20686 --- Comment #2 from Mason James --- Created attachment 74944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74944&action=edit pic 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 03:43:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 01:43:11 +0000 Subject: [Koha-bugs] [Bug 20686] OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspref disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20686 --- Comment #3 from Mason James --- Created attachment 74945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74945&action=edit Bug 20686: OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspref disabled ps: you will need an active and working overdrive account to test this patch 1/ prepare a koha with overdrive sysprefs set and working (OverDriveLibraryID,OverDriveClientKey,OverDriveClientSecret) 2/ set OverDriveCirculation syspref to 'disable' 3/ do an opac search, note the 'Login to OverDrive account' message is incorrectly displayed see pic 1 4/ apply patch 5/ do an opac search, note the 'Login to OverDrive account' message is no longer displayed (good) see pic 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 03:43:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 01:43:09 +0000 Subject: [Koha-bugs] [Bug 20686] OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspref disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20686 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 03:44:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 01:44:18 +0000 Subject: [Koha-bugs] [Bug 20686] OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspref disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20686 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18172 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 03:44:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 01:44:18 +0000 Subject: [Koha-bugs] [Bug 18172] Logged in user page shows internal server error if OverDriveCirculation is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18172 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20686 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 04:04:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 02:04:23 +0000 Subject: [Koha-bugs] [Bug 20671] Adding "surname" to instructions. import_borrowers.pl / import_borrowers.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20671 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |In Discussion --- Comment #4 from M. Tompsett --- (In reply to Katrin Fischer from comment #3) > Have you checked which fields are mandatory in your configuration? Default kohadevbox has surname|cardnumber in BorrowerMandatoryField. Categories and branches are part of table constraints. I believe some derived logic and a rephrase with a list might be better. Switching to 'In Discussion', because perhaps other indexed fields might also be considered. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 04:11:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 02:11:55 +0000 Subject: [Koha-bugs] [Bug 18172] Logged in user page shows internal server error if OverDriveCirculation is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18172 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 04:32:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 02:32:57 +0000 Subject: [Koha-bugs] [Bug 20254] Forbid the download of duplicate EDI messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20254 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- While the code eyeballs well, is it possible to write a test to trigger this case? We have no tests which trigger ingest, as far as I can tell. And this is a Koha library. Failing QA for lack of test(s). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 04:46:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 02:46:07 +0000 Subject: [Koha-bugs] [Bug 19693] authtypefrom incorrectly set when updating auth recs from file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19693 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |Failed QA --- Comment #5 from M. Tompsett --- t/db_dependent/Authority/Merge.t triggers this code change fully. However, there is no new test that fails before this patch, and succeeds after. Marking Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 10:53:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 08:53:20 +0000 Subject: [Koha-bugs] [Bug 11512] Only allow to override maximum number of holds from staff as other overrides would never be filled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11512 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Forced holds that violate |Only allow to override |issuing rules will never be |maximum number of holds |filled |from staff as other | |overrides would never be | |filled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 10:53:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 08:53:43 +0000 Subject: [Koha-bugs] [Bug 11919] staff should be able to place (and capture) holds on items that cannot fill hold requests for patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11919 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11512 CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 10:53:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 08:53:43 +0000 Subject: [Koha-bugs] [Bug 11512] Only allow to override maximum number of holds from staff as other overrides would never be filled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11512 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11919 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 11:00:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 09:00:42 +0000 Subject: [Koha-bugs] [Bug 18791] Add the ability for librarians to easily copy, download or print DataTables based tables in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18791 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Templates |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 11:02:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 09:02:55 +0000 Subject: [Koha-bugs] [Bug 10306] Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 11:05:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 09:05:31 +0000 Subject: [Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 11:08:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 09:08:34 +0000 Subject: [Koha-bugs] [Bug 11674] Configuration for MARC field doc URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 11:10:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 09:10:13 +0000 Subject: [Koha-bugs] [Bug 11674] Configuration for MARC field doc URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 --- Comment #25 from Katrin Fischer --- Wonder if we should move this to Cataloguing for the release notes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 11:12:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 09:12:20 +0000 Subject: [Koha-bugs] [Bug 18071] Add new script update_authorities.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 11:12:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 09:12:49 +0000 Subject: [Koha-bugs] [Bug 18825] Elasticsearch - Update default authority mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18825 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit | |y.org | CC| |katrin.fischer at bsz-bw.de Component|MARC Authority data support |Searching - Elasticsearch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 11:14:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 09:14:56 +0000 Subject: [Koha-bugs] [Bug 11976] Add column settings + new column "Publication date" to the subscription table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 11:16:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 09:16:52 +0000 Subject: [Koha-bugs] [Bug 19338] Dates sorting incorrectly in opac-account.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 12:56:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 10:56:06 +0000 Subject: [Koha-bugs] [Bug 11976] Add column settings + new column "Publication date" to the subscription table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patchset adds a new release notes| |column to the subscriptions | |tab on the opac details | |page, 'publication date' so | |a user can see the date of | |issue rather than the date | |of receipt. | | | |Additionally, | |the patch brings the table | |under column settings in | |the administration side so | |that staff can determine | |which columns should be | |shown by default -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 12:58:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 10:58:28 +0000 Subject: [Koha-bugs] [Bug 18071] Add new script update_authorities.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds a script to release notes| |perform various authority | |related maintenance tasks. | |This version supports | |deleting an authority | |record and updating all | |linked biblio records. | |Furthermore it supports | |merging authority records | |with one reference record, | |and updating all linked | |biblio records. | |It also | |allows you to force a | |renumber, i.e. save the | |authid into field 001. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 13:00:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 11:00:10 +0000 Subject: [Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patchset adds the release notes| |ability to search for and | |link authorities in the | |advanced cataloging editor. | |When editing a record | |staff can press | |'Shift+Ctrl+L' to launch | |the authorities search. | |Choosing a recorrd will | |update the field and add a | |subfield 9 for linking. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 13:01:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 11:01:25 +0000 Subject: [Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patchset adds the |This patchset adds the release notes|ability to search for and |ability to search for and |link authorities in the |link authorities in the |advanced cataloging editor. |advanced cataloging editor. |When editing a record |When editing a record |staff can press |staff can press |'Shift+Ctrl+L' to launch |'Shift+Ctrl+L' to launch |the authorities search. |the authorities search. |Choosing a recorrd will |Choosing a record will |update the field and add a |update the field and add a |subfield 9 for linking. |subfield 9 for linking. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 13:03:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 11:03:26 +0000 Subject: [Koha-bugs] [Bug 10306] Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patchset adds the release notes| |ability to map several MARC | |fields to a single Koha | |field. The first existing | |mapped field will be saved | |into the database. This | |allows for flexibility in a | |system using RDA and AACR2 | |records where some store | |the publication data in the | |260 fields and others in | |the 264. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 13:06:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 11:06:43 +0000 Subject: [Koha-bugs] [Bug 16782] Display JSON report URL in staff client report interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Display report URL in staff |Display JSON report URL in |client report interface |staff client report | |interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 13:19:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 11:19:05 +0000 Subject: [Koha-bugs] [Bug 20687] New: Multiple invitations to share lists prevents some users from accepting Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20687 Bug ID: 20687 Summary: Multiple invitations to share lists prevents some users from accepting Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl To recreate: 1 - Create a private list in the opac 2 - Invite 2 patrons to the list 3 - Try to accept from the patron you first shared to 4 - You will get a failure message about expiration of the link It seems we only get the latest invitation when trying to accept: opac/opac-shareshelf.pl line 135: # We could have used ->find with the share id, but we don't want to change # the url sent to the patron my $shared_shelf = Koha::Virtualshelfshares->search( { shelfnumber => $param->{shelfnumber}, }, { order_by => { -desc => 'sharedate' }, limit => 1, } ); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 1 13:19:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 11:19:52 +0000 Subject: [Koha-bugs] [Bug 20687] Multiple invitations to share lists prevents some users from accepting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20687 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9032 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 [Bug 9032] Share a list -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 1 13:19:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 11:19:52 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20687 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20687 [Bug 20687] Multiple invitations to share lists prevents some users from accepting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 13:52:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 11:52:00 +0000 Subject: [Koha-bugs] [Bug 20667] Update two-column templates with Bootstrap grid: Acquisitions part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20667 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74891|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 1 15:28:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 May 2018 13:28:51 +0000 Subject: [Koha-bugs] [Bug 20053] Drop type attribute "text/javascript" for - Click "Submit modifications" - TEST: Observe, when the page reloads, only the following is preserved in the "Notes" textarea: Hello TESTING - As a staff user, naviate to the ILL requests table - Select "Manage request" for the request you created - TEST: Observe that the Notes field only contains: Hello TESTING - TEST: Observe that no Javascript alert is displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 17:06:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 15:06:36 +0000 Subject: [Koha-bugs] [Bug 20770] ILL loans OPAC form notes field allow arbitrary input In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20770 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 17:17:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 15:17:43 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #26 from Julian Maurice --- Created attachment 75336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75336&action=edit Bug 15774: Add POD and license notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 17:37:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 15:37:36 +0000 Subject: [Koha-bugs] [Bug 20706] Fix links to help files for changed file structure (removed numbering on files) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75323|0 |1 is obsolete| | --- Comment #14 from M. Tompsett --- Created attachment 75337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75337&action=edit Bug 20706: Add a help URL validator test TEST PLAN ---------- 1) apply patch 2) kshell 3) prove t/db_dependent/www/help.t -- Add tests should pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 17:41:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 15:41:51 +0000 Subject: [Koha-bugs] [Bug 20706] Fix links to help files for changed file structure (removed numbering on files) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75337|0 |1 is obsolete| | --- Comment #15 from M. Tompsett --- Comment on attachment 75337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75337 Bug 20706: Add a help URL validator test Currently revised version is broken, but I don't want to prevent anyone else from signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 18:05:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 16:05:55 +0000 Subject: [Koha-bugs] [Bug 20708] Withdrawn status should show when placing a request in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20708 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 18:06:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 16:06:45 +0000 Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 18:11:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 16:11:47 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 18:12:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 16:12:45 +0000 Subject: [Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 18:14:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 16:14:54 +0000 Subject: [Koha-bugs] [Bug 20710] Update MARC21 frameworks to Update 26 (April 2018) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20710 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 18:17:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 16:17:32 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 18:19:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 16:19:17 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 18:59:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 16:59:16 +0000 Subject: [Koha-bugs] [Bug 20693] Plack fails, because 'libcgi-emulate-psgi-perl' package is not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20693 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 18:59:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 16:59:54 +0000 Subject: [Koha-bugs] [Bug 20693] Plack fails, because 'libcgi-emulate-psgi-perl' package is not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20693 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75328|0 |1 is obsolete| | --- Comment #11 from Tom?s Cohen Arazi --- Created attachment 75339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75339&action=edit Bug 20693: Update control file Auto-generated file. Signed-off-by: Mirko Tietgen Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 18:59:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 16:59:47 +0000 Subject: [Koha-bugs] [Bug 20693] Plack fails, because 'libcgi-emulate-psgi-perl' package is not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20693 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75327|0 |1 is obsolete| | --- Comment #10 from Tom?s Cohen Arazi --- Created attachment 75338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75338&action=edit Bug 20693: Plack fails, because 'libcgi-emulate-psgi-perl' package is not installed Add CGI::Emulate::PSGI to PerlDependencies.pm Signed-off-by: Mirko Tietgen Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 19:00:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 17:00:26 +0000 Subject: [Koha-bugs] [Bug 20693] Plack fails, because 'libcgi-emulate-psgi-perl' package is not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20693 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 19:19:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 17:19:00 +0000 Subject: [Koha-bugs] [Bug 20437] Force requirement for HTTP::OAI 3.27 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20437 --- Comment #9 from Mirko Tietgen --- I have added libhttp-oai-perl 3.27~koha1-1 to the unstable repository. I rolled a package with Tom?s' patch, did a subsequent regeneration of debian/control and installed in a stretch VM. I had to manually tweak things to get 3.27 installed because the RC1 in the unstable repo interfered. Patch works as intended (needs update of control file). I did not encounter any dependency issues with the back- and forthport of libhttp-oai-perl 3.27 in Stretch. If a system already has libhttp-oai-perl 4.x installed, it will break things but give a clear message about the problem. If there is software installed on a system that needs 4.x, it is incompatible to Koha until 4.07 is released and packaged. This is expected and we can't do anything about it. 3.27~koha1 is in the unstable repository and can be copied to stable and oldstable any time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 19:26:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 17:26:16 +0000 Subject: [Koha-bugs] [Bug 20437] Force requirement for HTTP::OAI 3.27 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20437 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73160|0 |1 is obsolete| | --- Comment #10 from Mirko Tietgen --- Created attachment 75340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75340&action=edit Bug 20437: Force the dependency on HTTP::OAI < 4.0 Until HTTP::OAI is patched so it actually works, and bug 17704 fixes the API change Koha-side, we need to explicitly pull the right version. Otherwise people using Debian 9+ derived distros (Ubuntu 16.04+) are seeing production issues. This implies packaging our custom libhttp-oai-perl distribution in the meantime. This patch makes Koha require a version lower than 4.0. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 19:26:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 17:26:29 +0000 Subject: [Koha-bugs] [Bug 20437] Force requirement for HTTP::OAI 3.27 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20437 --- Comment #11 from Mirko Tietgen --- Created attachment 75341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75341&action=edit Bug 20437: Update debian/control Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 19:30:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 17:30:19 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 19:37:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 17:37:00 +0000 Subject: [Koha-bugs] [Bug 20706] Fix links to help files for changed file structure (removed numbering on files) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706 --- Comment #16 from M. Tompsett --- Created attachment 75342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75342&action=edit Bug 20706: Add a help URL validator test TEST PLAN ---------- 1) apply patch 2) kshell 3) prove t/db_dependent/www/help.t -- Add tests should pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 19:42:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 17:42:08 +0000 Subject: [Koha-bugs] [Bug 20706] Fix links to help files for changed file structure (removed numbering on files) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75041|0 |1 is obsolete| | --- Comment #17 from M. Tompsett --- Created attachment 75343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75343&action=edit Bug 20706: Fixes the links to the manual to reflect changed chapter file names The numbering in front of the chapter file names has been removed, so the links need to be adapted accordingly. Note: Testing this in master currently won't work for 2 reasons: - We are still using 17.11 as version variable, will be 18.05 later. - We are missing the lanugage code before /html and this leads to an outdated version of the 18.05 manual. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 19:42:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 17:42:14 +0000 Subject: [Koha-bugs] [Bug 20706] Fix links to help files for changed file structure (removed numbering on files) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75235|0 |1 is obsolete| | --- Comment #18 from M. Tompsett --- Created attachment 75344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75344&action=edit Bug 20706: Adds en language code to the links to the manual As we don't have a fix yet to link to the right translated manual, this adds /en to the links from the help files to the manual to make them work again. Check with both patches applied, that the links work. You will have to change 17.11 to 18.05. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 19:42:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 17:42:17 +0000 Subject: [Koha-bugs] [Bug 20706] Fix links to help files for changed file structure (removed numbering on files) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75324|0 |1 is obsolete| | --- Comment #19 from M. Tompsett --- Created attachment 75345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75345&action=edit Bug 20706: Fix bad HTML link to help file Before there is no href. After there is. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 19:42:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 17:42:19 +0000 Subject: [Koha-bugs] [Bug 20706] Fix links to help files for changed file structure (removed numbering on files) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75342|0 |1 is obsolete| | --- Comment #20 from M. Tompsett --- Created attachment 75346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75346&action=edit Bug 20706: Add a help URL validator test TEST PLAN ---------- 1) apply patch 2) kshell 3) prove t/db_dependent/www/help.t -- Add tests should pass Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 19:42:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 17:42:47 +0000 Subject: [Koha-bugs] [Bug 20706] Fix links to help files for changed file structure (removed numbering on files) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 20:04:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 18:04:17 +0000 Subject: [Koha-bugs] [Bug 20437] Force requirement for HTTP::OAI 3.27 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20437 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 20:04:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 18:04:22 +0000 Subject: [Koha-bugs] [Bug 20693] Plack fails, because 'libcgi-emulate-psgi-perl' package is not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20693 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 21:50:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 19:50:42 +0000 Subject: [Koha-bugs] [Bug 17561] ReserveSlip needs itemnumber for item level holds on same biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561 Martha Fuerst changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mfuerst at hmcpl.org --- Comment #14 from Martha Fuerst --- Not sure if this is related or not, but we have seen holds trapped and filled not roll off of a patron's hold list. As in, a specific item will show as both checked out to that person and on hold for them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 21:54:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 19:54:34 +0000 Subject: [Koha-bugs] [Bug 20771] New: Incorrect wording on branch-specific notice setup Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20771 Bug ID: 20771 Summary: Incorrect wording on branch-specific notice setup Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org On this page: https://koha-community.org/manual/17.11/html/03_tools.html, this statement is not true: "Important When working with the overdue notices you want each notice at each branch to have a unique code. Think about using the branch code in front of the notice code for each branch." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 23:39:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 21:39:30 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #89 from Benjamin Rokseth --- Created attachment 75347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75347&action=edit Bug 20271: (QA follow-up): rename to deleted_on and various fixes - renamed deleted_at => deleted_on - removed failing sql in t/db_dependent/OAI/Server.t - removed deprecated autoincrement checks in about.pl - fixed errors in catalogue_stats.tt and catalogue_stats.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 15 23:43:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 21:43:07 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #90 from Benjamin Rokseth --- Adjusted to all qa feedback, except: - left warn instead of die in atomicupdate - it would be removed by RM when moved to updatedatabase.pl anyways I suppose - qa tools: FAIL Koha/Patron.pm, FAIL pod, Spurious text after =cut I could not reproduce. Ran qa tools and it passed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 00:31:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 22:31:17 +0000 Subject: [Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #16 from Katrin Fischer --- could we recalculate the expiration date for waiting items using the timestamp and ReservesMaxPickupDelay value? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 00:43:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 22:43:49 +0000 Subject: [Koha-bugs] [Bug 10077] Pass extended patron attributes via Borrower SIP protocol In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10077 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|pass extended patron |Pass extended patron |attirbutes via Borrower SIP |attributes via Borrower SIP |protocals |protocol CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 16 00:51:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 22:51:24 +0000 Subject: [Koha-bugs] [Bug 19237] PERSO_NAME authority file ignores first indicator value of new headings saved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19237 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- I can't reproduce the error on master. Please reopen if you still encounter the problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 16 00:54:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 22:54:56 +0000 Subject: [Koha-bugs] [Bug 2280] Authorized value option for indicators doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2280 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|authorized value option for |Authorized value option for |indicators doesn't work |indicators doesn't work --- Comment #10 from Katrin Fischer --- This still appears to be valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 00:55:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 22:55:36 +0000 Subject: [Koha-bugs] [Bug 2310] Omnibus: Delete grayed out w/out explanation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2310 --- Comment #15 from Katrin Fischer --- No movement here for a long time, can this omnibus be closed? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 16 01:53:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 23:53:45 +0000 Subject: [Koha-bugs] [Bug 2426] Management Permissions Deprecated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 01:53:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 23:53:49 +0000 Subject: [Koha-bugs] [Bug 2426] Management Permissions Deprecated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426 --- Comment #7 from Katrin Fischer --- Created attachment 75348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75348&action=edit Bug 2426: Remove deprecated management permission After review of the code it turns out that the management permission that has been marked as deprecated a long time ago, does not have any function. The patch removes all remaining code related to it. To test: - Make sure you have a patron with the management permission - Apply patch - Run database update - Check everything still works as expected Bonus: borrowers.flags is recalculated for patrons with management permission. To check: - Create some 'permission twins' with and without management permission - Note the value in borrowers.flags - Apply patch, don't run database update - Save permissions from GUI for one of the twins - Note the newly calculated value - Run database update - Now both twins should have the same borrowers.flags value -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 16 01:55:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 23:55:20 +0000 Subject: [Koha-bugs] [Bug 2426] Management permissions is deprecated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Management Permissions |Management permissions is |Deprecated |deprecated Severity|major |normal Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 16 01:58:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 May 2018 23:58:18 +0000 Subject: [Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 --- Comment #13 from Katrin Fischer --- installer/data/mysql/update22to30.pl Mark, do you mean we should remove the use Modern::Perl from this old script? I'd like to unlock this one, as it's the last blocking bug 2505. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 02:04:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 00:04:15 +0000 Subject: [Koha-bugs] [Bug 2559] Language limit on Spanish returns Russian records or is it English ... In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2559 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #4 from Katrin Fischer --- I believe this to be fixed in current versions of Koha. I tested the ones listed in the description as broken: >The limit for Spanish is now working. However, there are also problems with the >following language limits: >Armenian - Koha is using the code "hy" instead of "arm" >English - Koha is using "en" instead of "eng" >French - Koha is using "fr" instead of "fre" In all 3 cases Koha uses the 3 letter code for search now. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 16 02:13:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 00:13:03 +0000 Subject: [Koha-bugs] [Bug 2619] Turning on XSLTResultsDisplay preference turns off item detail display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2619 --- Comment #5 from Katrin Fischer --- Hea gives very confusing results for this one as we only allow yes/no in the GUI and it lists 7 different values. I propose removing the code related to the this system preference in order to move forward with bug 12561 - deprecating/removing non-XSLT views. I've added this topic to the agenda: https://wiki.koha-community.org/wiki/Development_IRC_meeting_23_May_2018#Agenda -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 02:15:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 00:15:58 +0000 Subject: [Koha-bugs] [Bug 2635] Allow validation of item fields (price, dates) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2635 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Adding non-digit chars to |Allow validation of item |cost fields in items causes |fields (price, dates) |data corruption | --- Comment #5 from Katrin Fischer --- (In reply to Jesse Maseto from comment #4) > Wondering if this is part of this bug? > > > > We are seeing when we put a price in for the original purchase price it gets > saved as a 1 when the value has a comma in it. > > > > For example > > > > Edit an item, add 1,345.80 and click save. It gets saved as a 1. If you > enter 1345.80 it saves correctly. Hi Jesse, I think this is more related to bug 12310, bug 18723 and bug 19521. Koha doesn't always work well with commas. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 02:18:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 00:18:25 +0000 Subject: [Koha-bugs] [Bug 2688] Z39.50 should report connection failures even if some succeeded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2688 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- I confirm, current versions of Koha report if one or more connections have failed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 02:19:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 00:19:00 +0000 Subject: [Koha-bugs] [Bug 3007] UNIMARC value_builder templates to translate to English In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3007 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|four UNIMARC value_builder |UNIMARC value_builder |templates to translate to |templates to translate to |English |English -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 16 02:21:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 00:21:35 +0000 Subject: [Koha-bugs] [Bug 3007] UNIMARC value_builder templates to translate to English In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3007 --- Comment #5 from Katrin Fischer --- Still valid. Note: it would be nice to fix this as the untranslated strings end up in the po files of various languages and cause confusion there. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 02:29:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 00:29:53 +0000 Subject: [Koha-bugs] [Bug 3886] Can't print receipt w/out allowing "Add or modify borrowers" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3886 --- Comment #5 from Katrin Fischer --- We have a mismatch here between the templates and the perl script. The script asks for circulate_remaining_permissions and the template for edit_borrowers: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc;h=9b5524d4c16c15b81cc7ba9c8eaaad240cf51cf5;hb=9b31bc2d27c6e045a6e7ea079778c47674c135db#l27 I tend to follow the script here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 02:34:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 00:34:41 +0000 Subject: [Koha-bugs] [Bug 2426] Management permissions is deprecated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75348|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 75349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75349&action=edit Bug 2426: Remove deprecated management permission After review of the code it turns out that the management permission that has been marked as deprecated a long time ago, does not have any function. The patch removes all remaining code related to it. To test: - Make sure you have a patron with the management permission - Apply patch - Run database update - Check everything still works as expected Bonus: borrowers.flags is recalculated for patrons with management permission. To check: - Create some 'permission twins' with and without management permission - Note the value in borrowers.flags - Apply patch, don't run database update - Save permissions from GUI for one of the twins - Note the newly calculated value - Run database update - Now both twins should have the same borrowers.flags value -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 16 02:35:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 00:35:19 +0000 Subject: [Koha-bugs] [Bug 3886] Can't print receipt w/out allowing "Add or modify borrowers" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3886 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 02:36:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 00:36:40 +0000 Subject: [Koha-bugs] [Bug 3886] Can't print receipt w/out allowing "Add or modify borrowers" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3886 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4167|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 02:50:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 00:50:45 +0000 Subject: [Koha-bugs] [Bug 3886] Can't print receipt w/out allowing "Add or modify borrowers" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3886 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 02:50:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 00:50:48 +0000 Subject: [Koha-bugs] [Bug 3886] Can't print receipt w/out allowing "Add or modify borrowers" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3886 --- Comment #6 from Katrin Fischer --- Created attachment 75350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75350&action=edit Bug 3886: Fix mismatch of required permissions for printing slips - Print summary (summary-print.pl) - Print quick slip (printslip.pl) - Print slip (printslip.pl) - Print overdues (print_overdues.pl) Perl scripts all require circulate_remaining_permissions, while in the template we were checking for edit_borrowers. Now the print pull down will only be visible if the patron has circulate or circulate_remaining_permissions. To test: - Verify that printing the listed slips works for staff users with either circulate or circulate_remaining_permissions and without edit_borrowers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 02:51:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 00:51:53 +0000 Subject: [Koha-bugs] [Bug 3886] Can't print receipt w/out allowing "Add or modify borrowers" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3886 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|8535 | Priority|PATCH-Sent (DO NOT USE) |P3 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8535 [Bug 8535] Granular permission for viewing patron information -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 02:51:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 00:51:53 +0000 Subject: [Koha-bugs] [Bug 8535] Granular permission for viewing patron information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8535 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|3886 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3886 [Bug 3886] Can't print receipt w/out allowing "Add or modify borrowers" permission -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 02:53:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 00:53:38 +0000 Subject: [Koha-bugs] [Bug 3657] Editing MARC Authority Subfield Structure - Librarian Text is Mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3657 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Still valid. Can we not just mark the field as required the usual way? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 03:13:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 01:13:14 +0000 Subject: [Koha-bugs] [Bug 9968] Error when a search is done with Standard number option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9968 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 03:13:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 01:13:17 +0000 Subject: [Koha-bugs] [Bug 9968] Error when a search is done with Standard number option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9968 --- Comment #1 from Katrin Fischer --- Created attachment 75351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75351&action=edit Bug 9968: Fix wrong index for Standard number in advanced and label search 'Standard number' indicates that you can search ISBN, ISSN and other standard numbers, but we are using the wrong index and only get a very limited search for biblionumber instead. This patch changes the index from sn to ident. To test: - Check both staff and OPAC advanced search: - Search for Standard number = ISBN - Search for Standard number = ISSN Both should work. Toggle [Intranet|OPAC]NumbersPreferPhrase system preferences - Check the label creator - Add a new batch - Use 'add items' option and search for Standard number -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 03:13:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 01:13:45 +0000 Subject: [Koha-bugs] [Bug 9968] Fix Standard number search to use correct index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9968 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Error when a search is done |Fix Standard number search |with Standard number option |to use correct index Assignee|gmcharlt at gmail.com |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 03:50:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 01:50:20 +0000 Subject: [Koha-bugs] [Bug 10265] 830 needs spaces in XSLT display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 03:53:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 01:53:37 +0000 Subject: [Koha-bugs] [Bug 11016] Move SQL query from acqui/spent.pl to C4/Acquisitions.pm ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11016 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- spent and ordered can be seen as reports for which an exception has been made: https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL8:_SQL_code_in_.pl_scripts Maybe we will move it to Koha:* later, but marking this WONTFIX for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 03:56:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 01:56:41 +0000 Subject: [Koha-bugs] [Bug 11436] Default values in subfields are not passed on when cloning the field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11436 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Still valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 03:57:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 01:57:43 +0000 Subject: [Koha-bugs] [Bug 11514] Untranslatable "Uncertain" text in acq In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 --- Comment #6 from Katrin Fischer --- Still an issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 16 03:59:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 01:59:28 +0000 Subject: [Koha-bugs] [Bug 12008] hold notice can be deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12008 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #4 from Katrin Fischer --- Retested, it is fixed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 16 04:00:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 02:00:34 +0000 Subject: [Koha-bugs] [Bug 12321] indicators not editable after linking authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12321 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Marcel, is this fixed with the recent developments? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 04:01:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 02:01:56 +0000 Subject: [Koha-bugs] [Bug 12452] Check subscription expiration doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12452 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|check susbscription |Check subscription |expiration doesn't work |expiration doesn't work -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 16 04:02:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 02:02:53 +0000 Subject: [Koha-bugs] [Bug 12475] GetMemberDetails should return undef if borrowernumber doesn't exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12475 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- GetMemberDetails no longer exists in Koha. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 16 04:24:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 02:24:48 +0000 Subject: [Koha-bugs] [Bug 7136] Correct description of Grace period for subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7136 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|language inconsistency on |Correct description of |serials status |Grace period for | |subscriptions --- Comment #5 from Katrin Fischer --- I think it never worked the way it's described on the help page and the manual. The grace period is used with the serialsUpdate.pl cronjob. It will generate the next issue and set the one before to 'Late' with an optional note. Submitting a patch for the help file and the manual, OPAC appears to be fixed already. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 16 04:24:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 02:24:53 +0000 Subject: [Koha-bugs] [Bug 7136] Correct description of Grace period for subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7136 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 04:27:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 02:27:39 +0000 Subject: [Koha-bugs] [Bug 7136] Correct description of Grace period for subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7136 --- Comment #6 from Katrin Fischer --- Created attachment 75352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75352&action=edit Bug 7136: Correct description of Grace period for subscriptions The grace period is used with the serialsUpdate.pl cronjob. It will generate the next issue and set the one before to 'Late' with an optional note. There is on trace of a 'waiting' status for serials. To test: - check help file on the subscription edit form for the description of the 'Grace period'. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 16 04:27:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 02:27:36 +0000 Subject: [Koha-bugs] [Bug 7136] Correct description of Grace period for subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7136 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 04:35:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 02:35:49 +0000 Subject: [Koha-bugs] [Bug 13059] tab order on add/edit item isn't right In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13059 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 04:39:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 02:39:53 +0000 Subject: [Koha-bugs] [Bug 18336] Add support for Unicode supplementary characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 --- Comment #80 from Katrin Fischer --- *** Bug 13239 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 04:39:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 02:39:53 +0000 Subject: [Koha-bugs] [Bug 13239] MySQL Character encoding utf8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13239 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 18336 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 08:29:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 06:29:09 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75272|0 |1 is obsolete| | --- Comment #29 from Ere Maijala --- Created attachment 75353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75353&action=edit Bug 19893 - Alternative optimized indexing for Elasticsearch Add alternative optimized indexing for Elasticsearch How to test: 1) Time a full elasticsearch re-index by running the rebuild_elastic_search.pl with the -d flag: `koha-shell -c "time rebuild_elastic_search.pl -d"`. 2) Enable ExperimentalElasticSearchIndexing system preference (found under Global System preferences -> Administration -> Search Engine). 3) Time a full re-index again, it should be about twice at fast (for a couple of thousand biblios, with fewer biblios results may be more unpredictable). Sponsored-by: Gothenburg University Library Signed-off-by: Ere Maijala -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 08:32:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 06:32:03 +0000 Subject: [Koha-bugs] [Bug 20234] Make maintenance scripts use koha-zebra instead of koha-*-zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20234 --- Comment #11 from Fridolin SOMERS --- (In reply to Jonathan Druart from comment #10) > (In reply to Fridolin SOMERS from comment #9) > > Pushed to 17.05.x for v17.05.11 > > Why? You did not pick bug 17467. You should revert this from 17.05.x I'm very sorry, I missed the dependency. Revert pushed for v17.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 08:32:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 06:32:38 +0000 Subject: [Koha-bugs] [Bug 20234] Make maintenance scripts use koha-zebra instead of koha-*-zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20234 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 08:32:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 06:32:39 +0000 Subject: [Koha-bugs] [Bug 17468] Remove koha-*-zebra scripts in favor of koha-zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468 Bug 17468 depends on bug 20234, which changed state. Bug 20234 Summary: Make maintenance scripts use koha-zebra instead of koha-*-zebra https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20234 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 08:32:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 06:32:40 +0000 Subject: [Koha-bugs] [Bug 19610] Make koha-common.logrotate use copytruncate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19610 Bug 19610 depends on bug 20234, which changed state. Bug 20234 Summary: Make maintenance scripts use koha-zebra instead of koha-*-zebra https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20234 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 08:32:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 06:32:40 +0000 Subject: [Koha-bugs] [Bug 20745] indexing/searching not active at end of installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745 Bug 20745 depends on bug 20234, which changed state. Bug 20234 Summary: Make maintenance scripts use koha-zebra instead of koha-*-zebra https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20234 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 09:10:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 07:10:00 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #30 from Ere Maijala --- Tested once more with sandbox records from as well as with some real MARC 21 records. Looking good to me now. I still believe this should be the only indexing method, so maybe another patch to remove the Catmandu indexing and handle the deps? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 09:28:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 07:28:30 +0000 Subject: [Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #17 from Victor Grousset/tuxayo --- Same bug or followup? So the patch will be quickly released to at least avoid generating corrupted data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 09:32:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 07:32:28 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #27 from Julian Maurice --- Created attachment 75354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75354&action=edit Bug 15774: Show additional field values in edit form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 09:36:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 07:36:16 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72085|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 09:40:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 07:40:29 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Ray Delahunty changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patrons should not get a |Patrons should not get a |on_reserve notification if |on_reserve notification if |the checkout is due in the |the due date is far into |future |the future -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 09:54:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 07:54:17 +0000 Subject: [Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #18 from Katrin Fischer --- If it's just a little database update I'd put it here I think. I can sign off this afternoon if noone else is faster. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 09:56:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 07:56:56 +0000 Subject: [Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #19 from Katrin Fischer --- Hm, might be a little more complicated if you want the absolute correct date (with/without holidays). So we'd need to do what the code should have done? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 10:11:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 08:11:42 +0000 Subject: [Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #20 from Victor Grousset/tuxayo --- (In reply to Katrin Fischer from comment #18) > If it's just a little database update I'd put it here I think. +1 (In reply to Katrin Fischer from comment #19) > Hm, might be a little more complicated if you want the absolute correct date > (with/without holidays). So we'd need to do what the code should have done? Most of the existing corrupted data[1] should be in the past so it will be expired anyway. Is that correct? Is yes then no need to worry about making an accurate correction. [1] And there is not much considering that it hasn't been reported until now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 10:13:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 08:13:38 +0000 Subject: [Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #21 from Victor Grousset/tuxayo --- Posting the error here so someone searching for it will find this bug. Date::Calc::Date_to_Days(): not a valid date at /home/koha/src/circ/waitingreserves.pl line 122. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 10:38:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 08:38:39 +0000 Subject: [Koha-bugs] [Bug 9686] Sorting with independent branches returns results from all branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9686 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Katrin Fischer --- No reply here since 2013, I am closing INVALID. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 10:39:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 08:39:15 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #10 from Ray Delahunty --- We have a test system at 17.11.04 and are investigating whether this problem / dilemma can be solved with the code, which I understand will solve the problem in this bug and the one in 20360 (and which is a candidate for 18.05) can possibly be added to our 17.11 version. We have a workaround where we disabled AUTO_RENEWALS notices and use ODUE to notify of auto-renewal failure, and RENEWALS to notify of auto-renewal success. We are today undoing this workaround and if the code can work in 17.11 we plan to address Katrin?s concerns expressed above by a mix of changes to ?No renewal after?, ?No renewal before?, choice of time for the auto-renewal job to run, and generous use of a grace period. These Circulation & Fine Rules changes do not solve every problem, but if they work, they will offer some improvement. If the code does not work, I think we may have to reinstate the workaround, and wait for Koha 18.05. Test plan. We set ?No automatic renewal before? to 2 days. We set ?No automatic renewal after? to 1 day. We set the time of the auto-renewal job to 7am. We set the RenewalBasePeriod to ?old due date?. We set the Grace Period to 3 days. Assuming the new code solves both this bug and the one in 20360, this is what we would expect: Situation 1. Item is reserved / on hold and due date on Thursday. Auto-renewal job runs at 7am Wednesday, and AUTO_RENEWAL notice is sent advising of renewal failure. User has two remaining loan days and the three grace period days before fines start. If the reservation / hold is cancelled after the job has run or is fulfilled by another copy after 7am on Wednesday but before 7am Thursday, the second run of the auto-renewal job will result in the item being renewed, with the new date based on the old date (so the early renewal does not affect the loan period). Situation 2. Item is not reserved / on hold or otherwise blocked from renewal (say, due to max renewals count being reached) and it is due on Thursday. Auto-renewal job runs at 7am Wednesday, and AUTO_RENEWAL notice is sent advising of renewal success, with the new due date based on the old date. The early renewal does not badly affect the current holder- other than appearing to be an ?early renewal?. But it does mean that if someone else places a reservation / hold on the title on the Wednesday or Thursday they will have a long wait than if the renewal were close to the original due date. We can play about with the settings in Circulation & Fine Rules to get the ?best possible outcome? of minimal affect for maximum users (maybe set the ?No Auto renewal before? back to 3 days?) but whatever we do, it won?t be perfect as there are potentially problems with whatever settings we choose. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 10:40:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 08:40:12 +0000 Subject: [Koha-bugs] [Bug 9607] Pagination wrong if OPACShowUnusedAuthorities set to "don't show" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9607 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|pagination wrong if |Pagination wrong if |OPACShowUnusedAuthorities |OPACShowUnusedAuthorities |set to "don't show" |set to "don't show" Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 10:44:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 08:44:53 +0000 Subject: [Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #22 from Katrin Fischer --- I am not sure how big of a problem it is, but it probably depends on how long a library allows for items to be picked up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 11:00:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 09:00:26 +0000 Subject: [Koha-bugs] [Bug 11870] Add more informations to histsearch.pl results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25717|0 |1 is obsolete| | --- Comment #9 from Julian Maurice --- Created attachment 75355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75355&action=edit Bug 11870: Add more informations to histsearch.pl results - Basket group closed date and delivery place (in basketgroup column) - Additional order fields (one column for each additional field) Depends on bugs 11844 and 11708 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 11:00:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 09:00:45 +0000 Subject: [Koha-bugs] [Bug 11870] Add more informations to histsearch.pl results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff --- Comment #10 from Julian Maurice --- Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 11:04:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 09:04:10 +0000 Subject: [Koha-bugs] [Bug 11870] Add more informations to histsearch.pl results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75355|0 |1 is obsolete| | --- Comment #11 from Julian Maurice --- Created attachment 75356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75356&action=edit Bug 11870: Add more informations to histsearch.pl results - Basket group closed date and delivery place (in basketgroup column) - Additional order fields (one column for each additional field) Depends on bugs 11844 and 11708 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 11:04:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 09:04:39 +0000 Subject: [Koha-bugs] [Bug 9749] Placeholders in koha-conf.xml generated by the Debian packages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9749 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #4 from Magnus Enger --- Looking at one of my oldest instances, all the placeholders there are also in commented sections, so I guess we can close this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 16 11:22:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 09:22:05 +0000 Subject: [Koha-bugs] [Bug 9715] Various combinations of prefs QueryAutoTruncate, QueryFuzzy and QueryWeightFields conflict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9715 --- Comment #5 from Martin Renvoize --- +-------------------------------------+--------------------------------------------------------+-------------------+------------------------------------------------------------------------------------------------------------------------+ | Setting Combination | Search Terms | Number of Results | Notes | +-------------------------------------+--------------------------------------------------------+-------------------+------------------------------------------------------------------------------------------------------------------------+ | QueryAutoTruncate - Automatically | frogs toads | 8 | | | QueryFuzzy - Try/Don't try | frogs and toads | 7 | The missing record here contains 'toadstools' - truncation not working correctly? | | QueryStemming - Try/Don't try | frogs or toads | 29 | 'And' and 'or' treated as search operators. | | | Adv. Search: frogs and toads | 8 | Apostrophe search not working | +-------------------------------------+--------------------------------------------------------+-------------------+------------------------------------------------------------------------------------------------------------------------+ | QueryAutoTruncate - only if * added | frogs toads | 7 | | | QueryFuzzy - don't try | frogs and toads | 5 | And is treated as a search word | | QueryStemming - don't try | frogs or toads | 0 | | | | Adv. Search: frogs and toads | 7 | Apostrophe search not working | +-------------------------------------+--------------------------------------------------------+-------------------+------------------------------------------------------------------------------------------------------------------------+ | QueryAutoTruncate - only if *added | frogs toads | 10 | Includes records with 'frog' 'toad' - querystemming working as expected? | | QueryFuzzy - don't try | frogs and toads | 6 | And is treated as a search word | | QueryStemming - Try | frogs or toads | 2 | Or is treated as a search word (Orchid, Orangutan) | | | Adv. Search: frogs and toads | 10 | Apostrophe searching works (dr spock's). Or is the s or 's just being stripped out by Query Stemming? | | | | | This seems to be the best combination - apostrophe searching and query stemming appear to be working correctly, | | | | | BUT boolean operators used incorrectly. | +-------------------------------------+--------------------------------------------------------+-------------------+------------------------------------------------------------------------------------------------------------------------+ | QueryAutoTruncate - only if *added | frogs toads | 0 | No results for any search | | QueryFuzzy - Try | frogs and toads | 0 | | | QueryStemming - don't try/Try | frogs or toads | 0 | | | | Adv. Search: frogs and toads | 0 | | +-------------------------------------+--------------------------------------------------------+-------------------+------------------------------------------------------------------------------------------------------------------------+ | | | | Queryfuzzy can't be used with ICU in use? | +-------------------------------------+--------------------------------------------------------+-------------------+------------------------------------------------------------------------------------------------------------------------+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 11:24:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 09:24:41 +0000 Subject: [Koha-bugs] [Bug 9715] Various combinations of prefs QueryAutoTruncate, QueryFuzzy and QueryWeightFields conflict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9715 --- Comment #6 from Katrin Fischer --- Hi Martin, can you post your results elsewhere (wiki?), not easy to read here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 12:10:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 10:10:38 +0000 Subject: [Koha-bugs] [Bug 20706] Fix links to help files for changed file structure (removed numbering on files) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 12:11:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 10:11:24 +0000 Subject: [Koha-bugs] [Bug 20706] Fix links to help files for changed file structure (removed numbering on files) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 12:11:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 10:11:26 +0000 Subject: [Koha-bugs] [Bug 20706] Fix links to help files for changed file structure (removed numbering on files) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75343|0 |1 is obsolete| | Attachment #75344|0 |1 is obsolete| | Attachment #75345|0 |1 is obsolete| | Attachment #75346|0 |1 is obsolete| | --- Comment #21 from Nick Clemens --- Created attachment 75357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75357&action=edit Bug 20706: Fixes the links to the manual to reflect chanced chapter file names The numbering in front of the chapter file names has been removed, so the links need to be adapted accordingly. Note: Testing this in master currently won't work for 2 reasons: - We are still using 17.11 as version variable, will be 18.05 later. - We are missing the lanugage code before /html and this leads to an outdated version of the 18.05 manual. Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 12:11:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 10:11:30 +0000 Subject: [Koha-bugs] [Bug 20706] Fix links to help files for changed file structure (removed numbering on files) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706 --- Comment #22 from Nick Clemens --- Created attachment 75358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75358&action=edit Bug 20706: Adds en language code to the links to the manual As we don't have a fix yet to link to the right translated manual, this adds /en to the links from the help files to the manual to make them work again. Check with both patches applied, that the links work. You will have to change 17.11 to 18.05. Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 12:11:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 10:11:32 +0000 Subject: [Koha-bugs] [Bug 20706] Fix links to help files for changed file structure (removed numbering on files) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706 --- Comment #23 from Nick Clemens --- Created attachment 75359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75359&action=edit Bug 20706: Fix bad HTML link to help file Before there is no href. After there is. Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 12:11:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 10:11:35 +0000 Subject: [Koha-bugs] [Bug 20706] Fix links to help files for changed file structure (removed numbering on files) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706 --- Comment #24 from Nick Clemens --- Created attachment 75360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75360&action=edit Bug 20706: Add a help URL validator test TEST PLAN ---------- 1) apply patch 2) kshell 3) prove t/db_dependent/www/help.t -- Add tests should pass Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 12:15:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 10:15:37 +0000 Subject: [Koha-bugs] [Bug 19549] Reserve Slip prints first found hold when patron has multiple holds on a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #7 from Nick Clemens --- Upping severity, would be nice to get some attention on this -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 12:46:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 10:46:56 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75354|0 |1 is obsolete| | --- Comment #28 from Julian Maurice --- Created attachment 75361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75361&action=edit Bug 15774: Show additional field values in edit form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 13:15:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 11:15:40 +0000 Subject: [Koha-bugs] [Bug 20772] Bib metadata pertaining to an ILL request should be editable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ |ity.org |e.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 16 13:15:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 11:15:24 +0000 Subject: [Koha-bugs] [Bug 20772] New: Bib metadata pertaining to an ILL request should be editable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772 Bug ID: 20772 Summary: Bib metadata pertaining to an ILL request should be editable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.isherwood at ptfs-europe.com Currently, when an ILL request is created a variety of metadata is gathered pertaining to that request. 1) Request specific metadata : This is metadata that relates directly to the request, such as requested date, request status etc. 2) Record specific metadata : This is metadata that relates to the record being requested, with some backends, such as BLDSS, this metadata is supplied by the backend. With other backends, such as FreeForm, this metadata is supplied by the requester. 3) Additional record specific metadata : When a request is placed for a partial work, such as a book chapter, additional metadata is supplied detailing the partial work. This metadata may be supplied by the backend (for example, article request from the BLDSS), or by the requester (for example, a request for a chapter from a book record from the BLDSS). There is a requirement to be able to edit some of this metadata, according to these proposed rules: 1) This is already editable 2 & 3) *May* need to be editable, depending on it's origin. i.e. If the metadata has originated from a "canonical" source, such as BLDSS, it should not be editable. If, however, it has originated from the requester via, for example, the FreeForm backend, it *should* be editable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 13:17:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 11:17:17 +0000 Subject: [Koha-bugs] [Bug 12321] indicators not editable after linking authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12321 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #1) > Marcel, is this fixed with the recent developments? It is not a problem in current master. But the controlled indicators report did not touch this problem iirc. Closing this report. If anyone can still reproduce, reopen and provide the exact steps to do it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 13:19:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 11:19:59 +0000 Subject: [Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #23 from Marcel de Rooy --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 13:55:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 11:55:18 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #32 from Julian Maurice --- Created attachment 75362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75362&action=edit Bug 11844: Update kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 14:03:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 12:03:11 +0000 Subject: [Koha-bugs] [Bug 8149] Deleting Records/Biblios Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8149 Bug 8149 depends on bug 2310, which changed state. Bug 2310 Summary: Omnibus: Delete grayed out w/out explanation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2310 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 14:03:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 12:03:11 +0000 Subject: [Koha-bugs] [Bug 2310] Omnibus: Delete grayed out w/out explanation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2310 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|ASSIGNED |RESOLVED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 14:41:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 12:41:02 +0000 Subject: [Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #24 from Marcel de Rooy --- for ( my $i = 0 ; $i < $holds_to_place_count ; $i++ ) { AddReserve( $branch, $borrower->{'borrowernumber'}, $biblionumber, \@realbi, $rank[0], $startdate, $expirationdate, $notes, $title, $checkitem, $found, $itemtype ); } Horrible existing code with realbi and holds_to_place_count.. Also checkitem is passed to AddReserve each time in a for loop with biblionumbers. (It should be undef but you never know..) Note that the second patch removes $holds_to_place_count = 1. So lots of distraction here again with holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 14:46:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 12:46:25 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #31 from David Gustafsson --- Ok, nice! Are you referring to adding Search::Elasticsearch in PerlDependencies? It has already been added it seams, so don't need to handle that dependency. If it is deemed the best option I can refactor the patch to remove the preference and use this as the only indexing option, that would not take long. Would be nice with some more feedback regarding how to handle this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 14:55:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 12:55:09 +0000 Subject: [Koha-bugs] [Bug 20729] Update style of datepickers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 14:55:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 12:55:57 +0000 Subject: [Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #25 from Marcel de Rooy --- This might affect C4/ILSDI/Services.pm => One of the calls includes an itemnumber. Note that the code did not contain a reference to ReservesNeedsReturns. Koha/REST/V1/Hold.pm is also affected => Includes an itemnumber. Note that the code did not contain a reference to ReservesNeedsReturns. C4/SIP/ILS/Transaction/Hold.pm is NOT affected (no item number) serials/routing-preview.pl is not affected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 15:37:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 13:37:00 +0000 Subject: [Koha-bugs] [Bug 7465] Remove language specific permission files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7465 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- Resolved long ago - it's all managed in a template file now and one global .sql file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 15:45:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 13:45:35 +0000 Subject: [Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 15:45:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 13:45:39 +0000 Subject: [Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75307|0 |1 is obsolete| | --- Comment #26 from Marcel de Rooy --- Created attachment 75363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75363&action=edit Bug 20724: Correctly mark an hold as waiting - ReservesNeedReturns We need to call Koha::Hold->set_waiting to correctly calculate the expiration date. It fixes a regression introduced by commit 26634151dbce0bf39ff6c9eda5b58bb993996a2d Bug 12063 - Fix QA failures The expiration date has to be set for waiting holds == Test plan (time to execute: less than 4min) == 1. Set ReservesNeedReturns to "Don't automatically" 2. Place a hold on a specific item 3. Check it in and confirm hold 4. The hold should have an expiration date record page ? Hold ? "Expiration" column 5. It should be listed in staff:/cgi-bin/koha/circ/waitingreserves.pl 6. Set ReservesNeedReturns to "Automatically" 7. Place a hold on a specific item (which should also behave like we check the item in to keep it for the patron) 8. The hold should have an *empty* expiration date record page ? Hold ? "Expiration" column 9. Holds awaiting pickup page should crash staff:/cgi-bin/koha/circ/waitingreserves.pl 10. Cancel the hold to remove the corrupted data record page ? Hold ? the red X 11. Apply this patch 12. Place a hold on a specific item 13. The hold should have an expiration date (not empty) 14. It should be listed in staff:/cgi-bin/koha/circ/waitingreserves.pl 15. Celebrate! Signed-off-by: Victor Grousset Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 15:45:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 13:45:43 +0000 Subject: [Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75308|0 |1 is obsolete| | --- Comment #27 from Marcel de Rooy --- Created attachment 75364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75364&action=edit Bug 20724: Move the ReservesNeedReturns logic to AddReserve Signed-off-by: Victor Grousset Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 15:45:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 13:45:47 +0000 Subject: [Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75325|0 |1 is obsolete| | --- Comment #28 from Marcel de Rooy --- Created attachment 75365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75365&action=edit Bug 20724: Add tests for ReservesNeedReturns Signed-off-by: Victor Grousset Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 15:45:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 13:45:52 +0000 Subject: [Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #29 from Marcel de Rooy --- Created attachment 75366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75366&action=edit Bug 20724: (QA follow-up) Remove two obsolete comment lines No test plan :) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 15:45:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 13:45:56 +0000 Subject: [Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #30 from Marcel de Rooy --- Created attachment 75367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75367&action=edit Bug 20724: (QA follow-up) Add a simple db revision We should correct bad data too. This is a trivial, pragmatic approach. Instead of doing a complex calculation with holidays etc. (as was done on 12063), we just add MaxPickupDelay or 7 days to today probably resulting in a little bonus time. Only for waiting holds. When the ReservesNeedReturns pref was not Automatic, there should be no changes. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 15:47:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 13:47:24 +0000 Subject: [Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #31 from Marcel de Rooy --- With previous comments in mind, balance goes to Passed QA for this patch set. Added a simple db rev (we should imo). @RM: If you want to refine, please do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 15:47:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 13:47:36 +0000 Subject: [Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 15:56:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 13:56:12 +0000 Subject: [Koha-bugs] [Bug 20517] Use the "sort bin" field in SIP2 Checkin Response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 --- Comment #6 from Christophe Croullebois --- (In reply to Colin Campbell from comment #5) > Patch changes the path to the ILS modules - needs to not do that to apply to > master. Hi Colin, thx I will change that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:07:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:07:25 +0000 Subject: [Koha-bugs] [Bug 10190] notices based on item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:13:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:13:25 +0000 Subject: [Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 --- Comment #14 from Jonathan Druart --- We should not touch these scripts unless they have been tested with the changes (which is quite a lot of work for the gain it will bring). Ok for install.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:20:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:20:21 +0000 Subject: [Koha-bugs] [Bug 20773] New: bug 20724 follow-up - Database cleanup Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773 Bug ID: 20773 Summary: bug 20724 follow-up - Database cleanup Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 20724 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:20:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:20:21 +0000 Subject: [Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20773 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773 [Bug 20773] bug 20724 follow-up - Database cleanup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:20:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:20:52 +0000 Subject: [Koha-bugs] [Bug 20773] bug 20724 follow-up - Database cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773 --- Comment #1 from Jonathan Druart --- Created attachment 75368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75368&action=edit Bug 20773: (bug 20724 follow-up) Add a simple db revision We should correct bad data too. This is a trivial, pragmatic approach. Instead of doing a complex calculation with holidays etc. (as was done on 12063), we just add MaxPickupDelay or 7 days to today probably resulting in a little bonus time. Only for waiting holds. When the ReservesNeedReturns pref was not Automatic, there should be no changes. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:22:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:22:08 +0000 Subject: [Koha-bugs] [Bug 20773] bug 20724 follow-up - Database cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #2 from Jonathan Druart --- This change contains MySQLism (FQA) And maybe it would be better to display a warning and provide a script to fix the data (In Discussion). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:22:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:22:28 +0000 Subject: [Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75367|0 |1 is obsolete| | --- Comment #32 from Jonathan Druart --- Comment on attachment 75367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75367 Bug 20724: (QA follow-up) Add a simple db revision Moved to bug 20773. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:23:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:23:25 +0000 Subject: [Koha-bugs] [Bug 16149] Generate and send custom notices based on report output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:24:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:24:32 +0000 Subject: [Koha-bugs] [Bug 19031] Purchase Suggestion Submission Notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19031 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:27:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:27:29 +0000 Subject: [Koha-bugs] [Bug 11556] Send any notice to any patron (or all patrons) on demand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11556 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:28:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:28:46 +0000 Subject: [Koha-bugs] [Bug 18161] Option to completely disable advance notice on loans with auto renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18161 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:30:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:30:35 +0000 Subject: [Koha-bugs] [Bug 15448] OPACHiddenItems show in OPAC when patron places a hold on a specific item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:31:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:31:06 +0000 Subject: [Koha-bugs] [Bug 17921] Shelf Browser does not take OpacSuppression or OpacHiddenItems into consideration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17921 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:32:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:32:45 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:33:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:33:57 +0000 Subject: [Koha-bugs] [Bug 20517] Use the "sort bin" field in SIP2 Checkin Response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75126|0 |1 is obsolete| | --- Comment #7 from Christophe Croullebois --- Created attachment 75369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75369&action=edit Use of the "sort bin" field in SIP2 Checkin Response -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:34:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:34:29 +0000 Subject: [Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:35:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:35:52 +0000 Subject: [Koha-bugs] [Bug 16243] Add reference manager software (Mendeley and EasyBib) to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16243 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:37:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:37:18 +0000 Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:37:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:37:47 +0000 Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74644|0 |1 is obsolete| | Attachment #74645|0 |1 is obsolete| | Attachment #74646|0 |1 is obsolete| | Attachment #74647|0 |1 is obsolete| | Attachment #74648|0 |1 is obsolete| | Attachment #74649|0 |1 is obsolete| | Attachment #74650|0 |1 is obsolete| | Attachment #74651|0 |1 is obsolete| | --- Comment #60 from Jonathan Druart --- Created attachment 75370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75370&action=edit Bug 19817: Redirect to the online manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:37:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:37:58 +0000 Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #61 from Jonathan Druart --- Created attachment 75371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75371&action=edit Bug 19817: Remove local help files + edit help feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:38:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:38:06 +0000 Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #62 from Jonathan Druart --- Created attachment 75372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75372&action=edit Bug 19817: Make the location of the manual configurable - KohaManualBaseURL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:38:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:38:09 +0000 Subject: [Koha-bugs] [Bug 15500] Add FRBRized View to OPAC Results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15500 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:38:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:38:11 +0000 Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #63 from Jonathan Druart --- Created attachment 75373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75373&action=edit Bug 19817: Move code to Koha::Manual to make it testable and reusable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:38:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:38:17 +0000 Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #64 from Jonathan Druart --- Created attachment 75374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75374&action=edit Bug 19817: Add pref KohaManualLanguage -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:38:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:38:21 +0000 Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #65 from Jonathan Druart --- Created attachment 75375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75375&action=edit Bug 19817: Open the manual in a new window, not a popup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:38:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:38:31 +0000 Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #67 from Jonathan Druart --- Created attachment 75377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75377&action=edit Bug 19817: use https instead of http the https version was not working when I wrote the first patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:38:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:38:26 +0000 Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #66 from Jonathan Druart --- Created attachment 75376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75376&action=edit Bug 19817: Use the language from the interface if valid Use the UI language for the manual, if exists. Use the pref as a fallback. With the call to get_template_and_user the value of preferred_language switched from 'es' (spanish) to 'en' from one click to another (??) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:38:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:38:57 +0000 Subject: [Koha-bugs] [Bug 20706] Fix links to help files for changed file structure (removed numbering on files) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19817 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19817 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 [Bug 19817] Merge local and online documentations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:38:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:38:57 +0000 Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20706 | Depends on| |20706 --- Comment #68 from Jonathan Druart --- Rebased on top of bug 20706. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706 [Bug 20706] Fix links to help files for changed file structure (removed numbering on files) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:39:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:39:13 +0000 Subject: [Koha-bugs] [Bug 5594] Option to configure default sort order for items on bib records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5594 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:40:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:40:22 +0000 Subject: [Koha-bugs] [Bug 13376] Include a user-editable area/page for terms and conditions of use in the opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13376 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:42:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:42:31 +0000 Subject: [Koha-bugs] [Bug 19068] OPAC purchase suggestion doesn't allow users to enter quantity of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:44:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:44:23 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:44:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:44:37 +0000 Subject: [Koha-bugs] [Bug 20706] Fix links to help files for changed file structure (removed numbering on files) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Attachment #75360|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart --- Comment on attachment 75360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75360 Bug 20706: Add a help URL validator test These tests will slow down the test suite a lot and will conflict with bug 19817. Moreover the version is hardcoded. I do not think it makes sense to have it in the codebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:48:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:48:46 +0000 Subject: [Koha-bugs] [Bug 20706] Fix links to help files for changed file structure (removed numbering on files) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706 --- Comment #26 from Jonathan Druart --- (In reply to Jonathan Druart from comment #25) > Comment on attachment 75360 [details] [review] > Bug 20706: Add a help URL validator test > > These tests will slow down the test suite a lot 6min. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:56:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:56:53 +0000 Subject: [Koha-bugs] [Bug 20693] Plack fails, because 'libcgi-emulate-psgi-perl' package is not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20693 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_18_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 16:56:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 14:56:56 +0000 Subject: [Koha-bugs] [Bug 20437] Force requirement for HTTP::OAI 3.27 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20437 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_18_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 17:28:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 15:28:20 +0000 Subject: [Koha-bugs] [Bug 20706] Fix links to help files for changed file structure (removed numbering on files) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #27 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 17:28:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 15:28:26 +0000 Subject: [Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #33 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 17:37:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 15:37:35 +0000 Subject: [Koha-bugs] [Bug 20564] Error 500 displays when uploading patron images with a zipped file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 17:58:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 15:58:09 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #10 from Jonathan Druart --- The problem with the tests is that we are using Koha::Patron to test Koha::Object. We should use a more simple object for that, Koha::Patron->store does a lot of things now and so the behaviours changed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 18:08:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 16:08:13 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #413 from Lee Jamison --- Created attachment 75378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75378&action=edit Bug 7143: Update about page for documentation team -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 16 18:12:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 16:12:33 +0000 Subject: [Koha-bugs] [Bug 20455] Can't sort patron search on date expired In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20455 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 18:13:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 16:13:27 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 18:14:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 16:14:55 +0000 Subject: [Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 18:16:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 16:16:39 +0000 Subject: [Koha-bugs] [Bug 20380] Email consent patron opt-in tracking for anti-spam legislation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20380 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 18:17:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 16:17:39 +0000 Subject: [Koha-bugs] [Bug 20312] Add a link towards the last consulted patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 18:19:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 16:19:18 +0000 Subject: [Koha-bugs] [Bug 20028] Export all patron related personal data in one package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 18:19:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 16:19:53 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #414 from Jonathan Druart --- (In reply to Lee Jamison from comment #413) > Created attachment 75378 [details] [review] > Bug 7143: Update about page for documentation team Pushed to master for 18.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 16 18:21:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 16:21:20 +0000 Subject: [Koha-bugs] [Bug 14919] Holds history for patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 18:27:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 16:27:29 +0000 Subject: [Koha-bugs] [Bug 18342] Set memcached as 'enabled' by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18342 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Memcached is now required release notes| |and enabled by default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 18:29:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 16:29:20 +0000 Subject: [Koha-bugs] [Bug 20322] Circulation page layout and design update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322 --- Comment #50 from Jonathan Druart --- Anyone is willing to add a quick release note? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 18:31:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 16:31:27 +0000 Subject: [Koha-bugs] [Bug 20489] Prevent DB user login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |It is longer possible to release notes| |use the database user | |(defined in koha-conf.xml) | |to login into Koha. | |You | |should first create a | |superlibrarian patron and | |use it for logging in. | |See | |the script | |misc/devel/create_superlibr | |arian.pl Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 18:31:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 16:31:43 +0000 Subject: [Koha-bugs] [Bug 20489] Prevent DB user login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|It is longer possible to |It is no longer possible to release notes|use the database user |use the database user |(defined in koha-conf.xml) |(defined in koha-conf.xml) |to login into Koha. |to login into Koha. |You |You |should first create a |should first create a |superlibrarian patron and |superlibrarian patron and |use it for logging in. |use it for logging in. |See |See |the script |the script |misc/devel/create_superlibr |misc/devel/create_superlibr |arian.pl |arian.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 19:20:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 17:20:38 +0000 Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68335|0 |1 is obsolete| | Attachment #68336|0 |1 is obsolete| | --- Comment #9 from Charles Farmer --- Created attachment 75379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75379&action=edit Bug 19336: Add --maxfinesday option to fines.pl This is a functionality we have for some of our clients we want to push to the community. Adds the --maxfinesday argument to fines.pl which creates or updates a fine with the maximum amount set in the circulation rules after the delay has passed. e.g.: ./fines.pl --maxfinesdays 30 All item over 30 days late will have the maximal fine applied. Here is a test plan I followed based on above. Test plan: 1. Create circulation rule with Overdue fines cap set 2. Set finesMode systempreference to 'Calculate and charge' 3. Check out an item with the due date set 30 days ago 4. In Koha shell run ./fines.pl --maxfinesdays 30 5. There should now be a new fine in the accountlines table of the amount set in overdue fines cap Followed test plan, patch worked as intended Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 19:20:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 17:20:45 +0000 Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 --- Comment #10 from Charles Farmer --- Created attachment 75380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75380&action=edit Bug 19336: (follow-up) Correct DateTime and Koha calls This fixes the 'DateTime does not overload' error. It also fixes the next error, which was that C4::GetIssuingRules is deprecated. Finally it now handles no overduefinescap being define (does nothing). Passes QA test tool Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 19:20:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 17:20:50 +0000 Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 --- Comment #11 from Charles Farmer --- Created attachment 75381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75381&action=edit Bug 19336: (QA follow-up) Initialize $unitcounttotal in case a report is written -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 19:20:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 17:20:35 +0000 Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 19:23:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 17:23:51 +0000 Subject: [Koha-bugs] [Bug 15922] Show authorized value description in staff client search results for lost, withdrawn, and damaged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Show the library's release notes| |description for variations | |of "Lost," "Damaged," and | |"Withdrawn" statuses which | |have been defined in Koha's | |authorized values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 19:25:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 17:25:06 +0000 Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 --- Comment #12 from Charles Farmer --- Rewrote the patch titles to abide by the standardized notation. Provided a way out of the 'In discussion' status by initializing $unitcounttotal to 'n/a', the common abbreviation used in a report for a field that does not apply. Back in Needs Signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 19:27:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 17:27:32 +0000 Subject: [Koha-bugs] [Bug 20322] Circulation page layout and design update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |These patches give a release notes| |facelift to the circulation | |homepage. All functionality | |remains the same, however, | |things have been moved to | |make the interface little | |friendlier and more | |responsive on different | |screens. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 20:16:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 18:16:55 +0000 Subject: [Koha-bugs] [Bug 20706] Fix links to help files for changed file structure (removed numbering on files) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706 --- Comment #28 from M. Tompsett --- (In reply to Jonathan Druart from comment #25) > Comment on attachment 75360 [details] [review] > Bug 20706: Add a help URL validator test > > These tests will slow down the test suite a lot That is a valid reason to not push. > and will conflict with bug 19817. Okay. But conflicts can be resolved. But yes, I suppose it would become pointless if 19817 gets pushed through. > Moreover the version is hardcoded. No, the version isn't hard coded. The initial version is substituted. > I do not think it makes sense to have it in the codebase. Okay, but it certainly made testing easier. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 20:33:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 18:33:38 +0000 Subject: [Koha-bugs] [Bug 15922] Show authorized value description in staff client search results for lost, withdrawn, and damaged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 20:33:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 18:33:55 +0000 Subject: [Koha-bugs] [Bug 20322] Circulation page layout and design update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 22:34:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 20:34:28 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 --- Comment #13 from Jonathan Druart --- Created attachment 75383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75383&action=edit Bug 20116: Cache language list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 22:34:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 20:34:32 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 --- Comment #14 from Jonathan Druart --- Created attachment 75384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75384&action=edit Bug 20116: Flush the caches When languages are added or removed when need to flush the caches to keep the interface consistent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 22:34:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 20:34:22 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73619|0 |1 is obsolete| | Attachment #73620|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 75382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75382&action=edit Bug 20116: Prepare the ground Just refactoring to make the next patch more readable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 22:40:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 20:40:25 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75383|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 75385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75385&action=edit Bug 20116: Cache language list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 22:58:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 20:58:27 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 --- Comment #16 from Jonathan Druart --- Before the patches, C4::Languages::getTranslatedLanguages('intranet', 'prog') took between 0.002 and 0.003s Now it's 0.0015s (and I guess the difference can be much better when hundred of queries are made at the same time). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 23:00:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 21:00:20 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 --- Comment #17 from Jonathan Druart --- (Of course first hit is worse) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 23:11:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 21:11:45 +0000 Subject: [Koha-bugs] [Bug 20703] Add ability to void any credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20703 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 23:21:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 21:21:38 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://wiki.koha-community | |.org/wiki/Patrons_debits_an | |d_credits_endpoint_RFC --- Comment #63 from Tom?s Cohen Arazi --- I am writing an RFC for both credits and debits endpoints for the API. Please comment about it either on the wiki or on the mailing list. I've contacted some of you already about it. https://wiki.koha-community.org/wiki/Patrons_debits_and_credits_endpoint_RFC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 16 23:21:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 21:21:56 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |needs_rfc Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 00:23:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 22:23:38 +0000 Subject: [Koha-bugs] [Bug 11920] staff pages should default to requiring "catalogue" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11920 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Is this something we are still interested in doing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 00:23:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 22:23:48 +0000 Subject: [Koha-bugs] [Bug 11920] Staff pages should default to requiring "catalogue" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11920 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|staff pages should default |Staff pages should default |to requiring "catalogue" |to requiring "catalogue" |permission |permission -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 00:29:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 22:29:37 +0000 Subject: [Koha-bugs] [Bug 12786] Permission to allow everyone in staff client to see all patron lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12786 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|permission to allow |Permission to allow |everyone in staff client to |everyone in staff client to |see all patron lists |see all patron lists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 00:38:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 22:38:52 +0000 Subject: [Koha-bugs] [Bug 13058] Deleting reports should be a permission setting, not a default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13058 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- Deleting reports now has a separate permission: delete_reports Please open a new bug report if there are any remaining issues! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 00:52:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 22:52:58 +0000 Subject: [Koha-bugs] [Bug 13631] Permission description wrong for catalogue and staffaccess In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #4 from Katrin Fischer --- It looks like descriptions have been corrected in current versions of Koha: (catalogue) Required for staff login. Staff access, allows viewing of catalogue in staff client. (staffaccess) Allow staff members to modify permissions for other staff members -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 00:55:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 22:55:27 +0000 Subject: [Koha-bugs] [Bug 14713] remaining_permissions permission under the "updatecharges" permission not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14713 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 00:58:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 22:58:52 +0000 Subject: [Koha-bugs] [Bug 14741] Set permissions doesn't tick the top level check box and doesn't clear child check boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14741 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Still valid. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 01:01:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 23:01:16 +0000 Subject: [Koha-bugs] [Bug 15725] Separate permission for merging records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15725 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.22 |master Summary|Merge permission |Separate permission for | |merging records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 01:03:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 23:03:22 +0000 Subject: [Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Split borrowers permission |Split borrowers permission |into create/edit |into create/edit and delete -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 01:04:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 23:04:13 +0000 Subject: [Koha-bugs] [Bug 15789] New permission for fine overrides In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15789 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- The link to the funding page is broken. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 17 01:05:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 23:05:48 +0000 Subject: [Koha-bugs] [Bug 16526] Insufficient permissions to delete users with category type set to staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16526 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.20 |master Summary|Insufficient permissions to |Insufficient permissions to |delete users with category |delete users with category |type set to Staff. |type set to staff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 01:06:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 23:06:27 +0000 Subject: [Koha-bugs] [Bug 17272] Override permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17272 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 01:08:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 23:08:09 +0000 Subject: [Koha-bugs] [Bug 17473] Permission for voiding payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Reverse payment permission |Permission for voiding | |payments --- Comment #1 from Katrin Fischer --- With bug 20629 the option to reverse payments will be gone. I am changing this to be a permission for the replacement: voiding payments. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 17 01:09:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 23:09:38 +0000 Subject: [Koha-bugs] [Bug 20629] Remove ability to 'reverse' payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8055, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14062, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14140 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 01:09:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 23:09:38 +0000 Subject: [Koha-bugs] [Bug 8055] reversing fines wonky In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8055 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20629 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 17 01:09:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 23:09:38 +0000 Subject: [Koha-bugs] [Bug 14062] Payment note on reversed payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14062 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20629 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 17 01:09:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 23:09:38 +0000 Subject: [Koha-bugs] [Bug 14140] Reversed payments don't generate entry in statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14140 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20629 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 01:14:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 23:14:03 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_18190=5D_the_=22Delete=22_action_on_?= =?utf-8?q?Home_=E2=80=BA_Reports_=E2=80=BA_Guided_reports_wizard_?= =?utf-8?q?=E2=80=BA_Saved_reports_should_hide_reports_rather_than_deletin?= =?utf-8?q?g_them?= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18190 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Katrin Fischer --- I think the separate permission and the log both help to achieve this. Please reopen if you disagree. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 01:14:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 23:14:46 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 01:16:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 23:16:28 +0000 Subject: [Koha-bugs] [Bug 20128] Permission for advanced editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20128 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 01:30:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 23:30:03 +0000 Subject: [Koha-bugs] [Bug 7648] staff can make themselves superlibrarians In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7648 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 20100 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 01:30:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 23:30:03 +0000 Subject: [Koha-bugs] [Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #39 from Katrin Fischer --- *** Bug 7648 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 01:35:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 23:35:01 +0000 Subject: [Koha-bugs] [Bug 8535] Granular permission for viewing patron information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8535 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 15788 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 01:35:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 23:35:01 +0000 Subject: [Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #2 from Katrin Fischer --- *** Bug 8535 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 01:35:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 23:35:39 +0000 Subject: [Koha-bugs] [Bug 9305] Attach adults to each other In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9305 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 12446 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 01:35:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 23:35:39 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #62 from Katrin Fischer --- *** Bug 9305 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 01:37:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 23:37:10 +0000 Subject: [Koha-bugs] [Bug 10537] Limit ability to grant permissions based on user's own permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10537 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 20100 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 01:37:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 23:37:10 +0000 Subject: [Koha-bugs] [Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse at bywatersolutions.com --- Comment #40 from Katrin Fischer --- *** Bug 10537 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 01:55:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 May 2018 23:55:24 +0000 Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #7 from Katrin Fischer --- Hi Owen, are you still working on this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 02:01:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 00:01:27 +0000 Subject: [Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates 23-26 (Nov 2016, May and Apr 2018) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75044|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel --- Created attachment 75386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75386&action=edit Bug 20709: Update GERMAN MARC frameworks to Updates 23+24+25 (Nov 2016, May and Dec 2017) Translation of bibliographic and authority frameworks can be done using translate.koha-community.org. Updated and translated files will then be provided for download. See: http://lists.koha-community.org/pipermail/koha-translate/2018-April/002721.html To test: - Verify SQL is correct and frameworks load without problem Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 02:01:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 00:01:31 +0000 Subject: [Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates 23-26 (Nov 2016, May and Apr 2018) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75248|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel --- Created attachment 75387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75387&action=edit Bug 20709: (follow-up) Update GERMAN MARC frameworks to Update 26 (April 2018) A follow-up in line with bug 20710. Again, the files used here have been generated automatically from the po files on translate.koha-community.org. To test: - Make sure the de-DE installer can install all mandatory files cleanly. Signed-off-by: Bernardo Gonzalez Kriegel Tested using de-DE installer, all files load Ok No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 02:07:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 00:07:29 +0000 Subject: [Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates 23-26 (Nov 2016, May and Apr 2018) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Bernardo Gonzalez Kriegel --- I did a little change on marc21 bib framework file, line 4596 from INSERT IGNORE INTO biblio_framework VALUES( 'ACQ', 'Acquisition framework' ); to INSERT IGNORE INTO biblio_framework VALUES ( 'ACQ', 'Erwerbung' ); Original EN file need a little update to allow translation. The one used to translate is fixed now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 02:12:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 00:12:34 +0000 Subject: [Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates 23-26 (Nov 2016, May and Apr 2018) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 --- Comment #11 from Katrin Fischer --- Thx Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 02:36:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 00:36:53 +0000 Subject: [Koha-bugs] [Bug 11420] Patron preference to restrict staff from changing location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11420 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 05:43:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 03:43:41 +0000 Subject: [Koha-bugs] [Bug 20699] Implement functionality for junior cataloguing staff to practise cataloguing/saving their records to reservoir (import_records, import_biblios DB tables) as drafts which are administered from the Cataloging interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20699 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 05:43:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 03:43:32 +0000 Subject: [Koha-bugs] [Bug 20699] Implement functionality for junior cataloguing staff to practise cataloguing/saving their records to reservoir (import_records, import_biblios DB tables) as drafts which are administered from the Cataloging interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20699 --- Comment #10 from Alex Buckley --- Thanks Katrin Perhaps it is best for me to close this bug report and just keep bug 20678 open which provides the same functionality but applicable to master. How does that sound? Cheers, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 07:17:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 05:17:08 +0000 Subject: [Koha-bugs] [Bug 20774] New: Trivial HTML error in itemslost.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774 Bug ID: 20774 Summary: Trivial HTML error in itemslost.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: pasi.kallinen at joensuu.fi QA Contact: testopia at bugs.koha-community.org reports/itemslost.tt: [% item.itemlost_on | $KohaDates %] The first "" is wrong, it should be just ">" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 08:52:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 06:52:58 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #32 from Ere Maijala --- Yes, I didn't know it was already added. That's good then. I believe that at this point it doesn't make sense to keep two different indexing methods when it's obvious that the old one has performance issues in this use and the new one doesn't have any obvious downsides. Especially so since the Elasticsearch support hasn't been stable yet. I have some general indexing improvements that I'd be much happier to base on the new mechanism rather than the Catmandu one. That's just me, though, and I'm not sure how something like this is to be decided. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 09:40:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 07:40:11 +0000 Subject: [Koha-bugs] [Bug 20390] Elasticsearch - Biblio mappings for UNIMARC (updates existing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20390 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 09:40:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 07:40:14 +0000 Subject: [Koha-bugs] [Bug 20390] Elasticsearch - Biblio mappings for UNIMARC (updates existing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20390 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74429|0 |1 is obsolete| | --- Comment #7 from claire.hernandez at biblibre.com --- Created attachment 75388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75388&action=edit Bug 20390: UNIMARC biblio mappings This is a unimarc default mappings for Koha Elasticsearch implementation by Claudie Tr?gou?t and Gaetan Boisson. There will have updates because some discussions are in progress. To test: 1) Delete data from search_marc_map, search_marc_to_field search_field 2) Reset mappings with the url mappings.pl?op=reset&i_know_what_i_am_doing=1 3) Rebuild the whole index rebuild_elastic_search.pl -d -b 4) Have a look to the mappings interface 5) Check if the recorded information in elasticsearch are with the expected mappings. Rebased by : Claire Hernandez 2018/17/05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 09:46:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 07:46:52 +0000 Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala at helsinki.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 09:57:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 07:57:02 +0000 Subject: [Koha-bugs] [Bug 20610] Add BULAC to about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20610 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored --- Comment #8 from claire.hernandez at biblibre.com --- I think we should thanks more our libraries in patches probably. I thought I could do larger than just BULAC, but it was a first step I needed just at the moment. I could add "Sponsored-by" more in every patches too. It seems it is not in our habits (and it should). Tell me what is the best way to do it in a community way and I can do it. @cait: "We could make it a habit to add the libraries that used the "Sponsored-by" line to the about page." you talk about the commit message or I miss something ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 10:08:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 08:08:14 +0000 Subject: [Koha-bugs] [Bug 20390] Elasticsearch - Biblio mappings for UNIMARC (updates existing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20390 --- Comment #8 from claire.hernandez at biblibre.com --- Created attachment 75389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75389&action=edit Bug 20390: (follow-up) UNIMARC biblio mappings - Clean the title mapping for Unimarc: 464, 413 and 454 are kept. If you need more, it is better to add it at the installation than removing a lot. - Change type of 995w for unimarc Sponsored-by: BULAC (Biblioth?que universitaire des langues et civilisations) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 17 10:22:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 08:22:39 +0000 Subject: [Koha-bugs] [Bug 20390] Elasticsearch - Biblio mappings for UNIMARC (updates existing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20390 --- Comment #9 from claire.hernandez at biblibre.com --- Created attachment 75390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75390&action=edit Bug 20390: (follow-up) UNIMARC mappings - Fix a typo in unimarc mappings (for authorities mapping) See comment on Bug 17373 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 10:24:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 08:24:34 +0000 Subject: [Koha-bugs] [Bug 20390] Elasticsearch - Mappings for UNIMARC (updates existing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20390 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Elasticsearch - Biblio |Elasticsearch - Mappings |mappings for UNIMARC |for UNIMARC (updates |(updates existing) |existing) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 10:24:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 08:24:58 +0000 Subject: [Koha-bugs] [Bug 17373] Elasticsearch - Authority mappings for UNIMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17373 --- Comment #19 from claire.hernandez at biblibre.com --- I pushed a follow-up on the bug 20390. I thing it will be easier to follow the changes and managing 2 bz for the same topic at the same time seems not relevant to me (but I do maybe a wrong choice?). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 10:26:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 08:26:49 +0000 Subject: [Koha-bugs] [Bug 20775] New: Inventory should sort on Library and not on Seen Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20775 Bug ID: 20775 Summary: Inventory should sort on Library and not on Seen Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 17 10:43:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 08:43:28 +0000 Subject: [Koha-bugs] [Bug 20775] Inventory should sort on Library and not on Seen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20775 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Marcel de Rooy --- This is no longer valid on master. Closing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 17 10:43:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 08:43:36 +0000 Subject: [Koha-bugs] [Bug 20775] Inventory should sort on Library and not on Seen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20775 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 11:11:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 09:11:35 +0000 Subject: [Koha-bugs] [Bug 20773] bug 20724 follow-up - Database cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 11:52:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 09:52:33 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #33 from David Gustafsson --- Yes, you are probably right. Initially I provided it as a preference since was more uncertain if stable or not and did not want to cause regressions when the current indexing was working. But now I'm a lot more confident that at least all serious issues have been ironed out, and we have been running this in production with ~2 million biblios since the beginning of April. As you say as Elastic is not stable yet it's probably a good to replace indexing logic with this so that possible issues can be caught by more people (the possible unimarc issue for example). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 13:17:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 11:17:03 +0000 Subject: [Koha-bugs] [Bug 19862] RoutingListAddReserves must be disabled by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19862 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74288|0 |1 is obsolete| | --- Comment #2 from Julian Maurice --- Created attachment 75391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75391&action=edit Bug 19862: Turn off RoutingListAddReserves on new installations The RoutingListAddReserves feature currently doesn't work as expected (see bug 2894) and should be turned off for new installations until properly fixed. To test: - Run the web installer - Confirm that RoutingListAddReserves is set to "Don't place" Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 13:18:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 11:18:22 +0000 Subject: [Koha-bugs] [Bug 19862] RoutingListAddReserves must be disabled by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19862 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julian.maurice at biblibre.com --- Comment #3 from Julian Maurice --- Should we also fix updatedatabase.pl ? (For those upgrading from 3.00 ...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 13:25:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 11:25:07 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #34 from Nick Clemens --- Can you send something to the koha-dev mailing list and add this as a topic for the next Developers meeting David? In a situation like this we should check for differing opinions or see if there are concerns others might have, and then we can vote at the meeting to move ahead. I think this the way to go, one less dependency makes it easier to maintain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 13:38:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 11:38:28 +0000 Subject: [Koha-bugs] [Bug 20774] Trivial HTML error in itemslost.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 13:50:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 11:50:39 +0000 Subject: [Koha-bugs] [Bug 20774] Trivial HTML error in itemslost.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 13:50:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 11:50:42 +0000 Subject: [Koha-bugs] [Bug 20774] Trivial HTML error in itemslost.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774 --- Comment #1 from Owen Leonard --- Created attachment 75392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75392&action=edit Bug 20774: Trivial HTML error in itemslost.tt This patch makes a minor correction to the markup of the lost items report template. To test, apply the patch and run the lost items report with parameters which will return results. The report results should look correct, and the page should validate with no relevant errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 13:58:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 11:58:39 +0000 Subject: [Koha-bugs] [Bug 19862] RoutingListAddReserves must be disabled by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19862 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 13:58:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 11:58:42 +0000 Subject: [Koha-bugs] [Bug 19862] RoutingListAddReserves must be disabled by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19862 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75391|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 75393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75393&action=edit Bug 19862: Turn off RoutingListAddReserves on new installations The RoutingListAddReserves feature currently doesn't work as expected (see bug 2894) and should be turned off for new installations until properly fixed. To test: - Run the web installer - Confirm that RoutingListAddReserves is set to "Don't place" Signed-off-by: Julian Maurice Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 13:59:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 11:59:33 +0000 Subject: [Koha-bugs] [Bug 19862] RoutingListAddReserves must be disabled by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19862 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 13:59:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 11:59:20 +0000 Subject: [Koha-bugs] [Bug 19862] RoutingListAddReserves must be disabled by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19862 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #5 from Marcel de Rooy --- (In reply to Julian Maurice from comment #3) > Should we also fix updatedatabase.pl ? (For those upgrading from 3.00 ...) No high risk there :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 14:20:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 12:20:36 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #35 from David Gustafsson --- No problem, I can do that, what should that mail contain? In the first comment I described the main motivation behind the patch, should I write more about the technical details how the code works? Also, even with this patch Catmandu is still used for searching, but that part I think it will be easy to replace with Search::ElasticSearch client to be able to drop Catmandu-dependency completely. Since this patch in it's current state seams pretty stable, it would perhaps be better to do this in a separate issue later if this one gets merged. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 14:25:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 12:25:28 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #36 from Nick Clemens --- Indeed, lets leave other removal to a new bug and not disturb things here. The email should just highlight the proposed change, the performance boost, and future maintainability. You can point back to this bug for more details, just give an overview that lets other developers know the situation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 14:29:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 12:29:52 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 14:29:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 12:29:55 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70424|0 |1 is obsolete| | Attachment #70425|0 |1 is obsolete| | --- Comment #34 from Marcel de Rooy --- Created attachment 75394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75394&action=edit Bug 18856: Don't show cancel option for waiting holds in OPAC This is the alternative patch of Kyle's """ If a hold is 'waiting' for the patron to collect then the patron should be prevented from cancelling the hold via their account in the opac. If a patron tries to cancel the hold, Koha will give an 'are you sure' alert and when you click Yes the page just refreshes and the hold remains. Staff can cancel the hold from the staff interface but they can then action the waiting hold. I think therefore that it is correct behaviour that a patron cannot cancel a hold when it reaches waiting state via the opac but it would be useful to either have a warning to prevent the cancellation or a useful message when they attempt to do so. The template was using a method that tells Koha if *staff* can cancel a hold, instead of patron. Test Plan: 1) Set up a waiting hold 2) Try to cancel it from the opac 3) Note you cannot 4) Apply this patch 5) Reload the page 6) Note the cancel button has disappeared for found holds """ It sounds better to keep the ->is_cancelable method, for readability Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 14:30:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 12:30:01 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #35 from Marcel de Rooy --- Created attachment 75395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75395&action=edit Bug 18856: (QA follow-up) Rename method to avoid confusion Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy Hmm. I would have liked the opac parameter even better ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 14:31:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 12:31:48 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #36 from Marcel de Rooy --- This is a quick fix, the other point mentioned in earlier comments should go on a new enhancement. Why not add it to 18.05 still, Joubu ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 14:35:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 12:35:33 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #37 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #17) > is_found is also a bit confusing, because this also includes transit items. Yes, confirming it again. is_found_or_transit ? New report btw -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 14:35:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 12:35:57 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #38 from Marcel de Rooy --- is_waiting_or_transit ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 15:31:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 13:31:10 +0000 Subject: [Koha-bugs] [Bug 20776] Add Selenium::Remote::Driver to dependencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20776 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 15:31:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 13:31:15 +0000 Subject: [Koha-bugs] [Bug 20776] Add Selenium::Remote::Driver to dependencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20776 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 15:31:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 13:31:05 +0000 Subject: [Koha-bugs] [Bug 20776] New: Add Selenium::Remote::Driver to dependencies Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20776 Bug ID: 20776 Summary: Add Selenium::Remote::Driver to dependencies Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Selenium::Remote::Driver is an optional dependency, missing from PerlDependencies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 15:40:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 13:40:20 +0000 Subject: [Koha-bugs] [Bug 20776] Add Selenium::Remote::Driver to dependencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20776 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 15:40:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 13:40:23 +0000 Subject: [Koha-bugs] [Bug 20776] Add Selenium::Remote::Driver to dependencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20776 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 75396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75396&action=edit Bug 20776: Add Selenium::Remote::Driver to the dependency list This dependency is missing from the PerlDependencies.pm file. This patch adds it. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 15:47:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 13:47:27 +0000 Subject: [Koha-bugs] [Bug 20777] New: Remove unused field accountlines.dispute Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20777 Bug ID: 20777 Summary: Remove unused field accountlines.dispute Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org This field is not used on the code base. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 17 15:55:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 13:55:52 +0000 Subject: [Koha-bugs] [Bug 20777] Remove unused field accountlines.dispute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20777 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 75397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75397&action=edit Bug 20777: Remove unused accountlines.dispute field Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 15:55:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 13:55:50 +0000 Subject: [Koha-bugs] [Bug 20777] Remove unused field accountlines.dispute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20777 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 17 15:55:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 13:55:59 +0000 Subject: [Koha-bugs] [Bug 20777] Remove unused field accountlines.dispute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20777 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 75398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75398&action=edit Bug 20777: DBIC update Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 15:56:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 13:56:18 +0000 Subject: [Koha-bugs] [Bug 20777] Remove unused field accountlines.dispute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20777 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 15:59:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 13:59:02 +0000 Subject: [Koha-bugs] [Bug 14806] Action Log for Modifying message_transport_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806 --- Comment #6 from Lari Taskula --- Created attachment 75399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75399&action=edit Bug 14806 - (follow-up) Action Log for Modifying message_transport_types Introducing improvements: - Centralizing code into new Koha::Patron::Message::Preference(s) objects - Addings tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 16:00:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 14:00:23 +0000 Subject: [Koha-bugs] [Bug 14806] Action Log for Modifying message_transport_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula at jns.fi Depends on| |18595 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 [Bug 18595] Move C4::Members::Messaging to Koha namespace -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 17 16:00:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 14:00:23 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14806 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806 [Bug 14806] Action Log for Modifying message_transport_types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 16:03:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 14:03:20 +0000 Subject: [Koha-bugs] [Bug 20396] Omnibus: Cleanup Koha and fight feature creep In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20777 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20777 [Bug 20777] Remove unused field accountlines.dispute -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 16:03:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 14:03:20 +0000 Subject: [Koha-bugs] [Bug 20777] Remove unused field accountlines.dispute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20777 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 [Bug 20396] Omnibus: Cleanup Koha and fight feature creep -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 16:07:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 14:07:51 +0000 Subject: [Koha-bugs] [Bug 14806] Action Log for Modifying message_transport_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75399|0 |1 is obsolete| | --- Comment #7 from Lari Taskula --- Created attachment 75400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75400&action=edit Bug 14806 - (follow-up) Action Log for Modifying message_transport_types Introducing improvements: - Centralizing code into new Koha::Patron::Message::Preference(s) objects - Addings tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 17 16:15:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 14:15:29 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17561 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561 [Bug 17561] ReserveSlip needs itemnumber for item level holds on same biblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 16:15:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 14:15:29 +0000 Subject: [Koha-bugs] [Bug 17561] ReserveSlip needs itemnumber for item level holds on same biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14695 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 [Bug 14695] Add ability to place multiple item holds on a given record per patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 17:06:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 15:06:20 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://wiki.koha-community |https://wiki.koha-community |.org/wiki/Patrons_debits_an |.org/wiki/Patrons_account_l |d_credits_endpoint_RFC |ines_endpoint_RFC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 17:07:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 15:07:11 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 --- Comment #64 from Tom?s Cohen Arazi --- I'm writing a new RFC with alex_a, khall and other's help. Please feel free to add you 2 cents! https://wiki.koha-community.org/wiki/Patrons_account_lines_endpoint_RFC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 17:11:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 15:11:16 +0000 Subject: [Koha-bugs] [Bug 17561] ReserveSlip needs itemnumber for item level holds on same biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561 David Kuhn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |techservspec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 17:16:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 15:16:59 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #39 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 17:17:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 15:17:07 +0000 Subject: [Koha-bugs] [Bug 19862] RoutingListAddReserves must be disabled by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19862 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 17:30:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 15:30:04 +0000 Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 --- Comment #14 from Martin Renvoize --- Comment on attachment 74517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74517 Bug 20582: Turn Koha into a Mojolicious application Review of attachment 74517: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20582&attachment=74517) ----------------------------------------------------------------- ::: Koha/App/Koha.pm @@ +1,3 @@ > +package Koha::App::Koha; > + > +use Modern::Perl; This really isn't required as you're using Mojo::Base below which turns on pretty much all the useful stuff from Modern::Perl and is more stable in it's actions... use strict; use warnings; use utf8; use feature ':5.10'; use IO::Handle (); require Mojolicious; push @ISA, 'Mojolicious'; sub has { Mojo::Base::attr(__PACKAGE__, @_) } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 17:36:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 15:36:01 +0000 Subject: [Koha-bugs] [Bug 19549] Reserve Slip prints first found hold when patron has multiple holds on a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17561 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 17:36:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 15:36:01 +0000 Subject: [Koha-bugs] [Bug 17561] ReserveSlip needs itemnumber for item level holds on same biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19549 CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 17:36:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 15:36:46 +0000 Subject: [Koha-bugs] [Bug 17561] ReserveSlip needs itemnumber for item level holds on same biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561 --- Comment #15 from Nick Clemens --- Possible duplicate 19549? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 17:40:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 15:40:06 +0000 Subject: [Koha-bugs] [Bug 20476] Two factor authentication for the staff client - omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20476 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 17:40:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 15:40:44 +0000 Subject: [Koha-bugs] [Bug 20476] Two factor authentication for the staff client - omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20476 --- Comment #5 from George Williams (NEKLS) --- So long as the two factor authentication is optional, I think this is a great idea. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 17 18:17:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 16:17:20 +0000 Subject: [Koha-bugs] [Bug 18786] Add ability to create custom payment types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 --- Comment #55 from Jonathan Druart --- Created attachment 75401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75401&action=edit Bug 18786: Add PAYMENT_TYPE to the installer file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 18:38:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 16:38:12 +0000 Subject: [Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m --- Comment #2 from Victor Grousset/tuxayo --- (In reply to Jonathan Druart from comment #0) > When a method is not allowed yet (not covered by tests) Is this about automated tests? Then what does this has to do when executing the method? Is this a way to make people to write tests? It seems that there can be other causes to this error, is that correct? I also heard that this had to do with the mapping with de DB columns being done or not. So, I'm confused ^^" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 18:38:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 16:38:56 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_18_05_candidate | --- Comment #11 from Jonathan Druart --- I will not have time to get back to this before the release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 17 18:44:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 16:44:20 +0000 Subject: [Koha-bugs] [Bug 18786] Add ability to create custom payment types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 --- Comment #56 from Jonathan Druart --- (In reply to Jonathan Druart from comment #55) > Created attachment 75401 [details] [review] > Bug 18786: Add PAYMENT_TYPE to the installer file Pushed to master for 18.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 00:01:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 22:01:11 +0000 Subject: [Koha-bugs] [Bug 7536] New permission for deleting items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7536 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|delete permissions |New permission for deleting | |items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 00:08:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 22:08:14 +0000 Subject: [Koha-bugs] [Bug 7003] canned report to show patrons and permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7003 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 00:11:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 22:11:26 +0000 Subject: [Koha-bugs] [Bug 6960] staffaccess permission requires borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6960 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- I am not sure about moving it into the borrowers permission: staffaccess: Allow staff members to modify permissions for other staff members Could it make more sense to put it under permissions? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 18 00:13:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 22:13:08 +0000 Subject: [Koha-bugs] [Bug 6846] Don't allow staff to change their own permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6846 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Dont allow staff to change |Don't allow staff to change |own permissions |their own permissions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 00:17:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 22:17:09 +0000 Subject: [Koha-bugs] [Bug 6423] Permission for editing other library's stuff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6423 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|permission for editing |Permission for editing |other library's stuff |other library's stuff --- Comment #2 from Katrin Fischer --- We have several permissions that go into this direction right now: - budget_manage_all - order_manage_all - view_borrower_infos_from_any_libraries - superserials I think 'stuff' is too general, we should identify other missing preferences instead. Maybe we should close this in favor of other more specific bugs? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 00:20:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 22:20:02 +0000 Subject: [Koha-bugs] [Bug 3849] Descriptions of acquisition permissions are unclear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3849 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Acq Permissions unclear |Descriptions of acquisition | |permissions are unclear --- Comment #10 from Katrin Fischer --- We still need to fix the descriptions: group_manage Manage orders & basketgroups order_manage Manage orders & basket order_manage_all Manage all orders and baskets, regardless of restrictions on them order_receive Manage orders & basket It should not all say 'manage orders...', but be more specific. Are orders the same as baskets? Or does it means orders and order lines here? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 18 00:49:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 22:49:30 +0000 Subject: [Koha-bugs] [Bug 18787] Create permission profiles for staff users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18787 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |conan at lugmen.org.ar --- Comment #1 from Katrin Fischer --- *** Bug 6223 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 00:49:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 22:49:30 +0000 Subject: [Koha-bugs] [Bug 6223] Patron categories should have a default set of permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6223 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 18787 *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 18 00:51:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 22:51:43 +0000 Subject: [Koha-bugs] [Bug 5732] Adding permissions on viewlog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5732 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #3 from Katrin Fischer --- We have view_system_logs - closing WONTFIX as suggested in comment#1 -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 00:51:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 22:51:44 +0000 Subject: [Koha-bugs] [Bug 5575] 3.4 BibLibre circ & members omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5575 Bug 5575 depends on bug 5732, which changed state. Bug 5732 Summary: Adding permissions on viewlog https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5732 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 18 01:13:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 May 2018 23:13:52 +0000 Subject: [Koha-bugs] [Bug 18787] Create permission profiles for staff users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18787 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 05:27:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 03:27:40 +0000 Subject: [Koha-bugs] [Bug 20077] Patroncards are printed blank In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20077 Pikri Mohammad changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mpikri at gmail.com --- Comment #8 from Pikri Mohammad --- Hello all, I'm having the same problem too. After clicking on the PDF link in patron card, it never finish. On the server side, the CPU usage increased to 100% for /usr/share/koha/intranet/cgi-bin/patroncards/create-pdf.pl Koha version: 17.11.05.000 O/S: Ubuntu 16.04 x64 bit Thanks, Pikri Mohammad -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 07:35:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 05:35:40 +0000 Subject: [Koha-bugs] [Bug 20777] Remove unused field accountlines.dispute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20777 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 07:59:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 05:59:28 +0000 Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #28 from Marcel de Rooy --- Are we trusting on autoflush to save the session data? I saw that the date was updated a second time while being in the same session. Do we need a specific session flush (especially under Plack)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 08:00:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 06:00:07 +0000 Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 09:06:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 07:06:30 +0000 Subject: [Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #3 from Julian Maurice --- (In reply to Victor Grousset/tuxayo from comment #2) > (In reply to Jonathan Druart from comment #0) > > When a method is not allowed yet (not covered by tests) > > Is this about automated tests? Then what does this has to do when executing > the method? Is this a way to make people to write tests? > > It seems that there can be other causes to this error, is that correct? > > I also heard that this had to do with the mapping with de DB columns being > done or not. So, I'm confused ^^" We can get this error when we try to use a new column and Koha::Schema was not updated. So, the message should probably be "This method does not exist" rather than "not covered by tests". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 09:38:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 07:38:52 +0000 Subject: [Koha-bugs] [Bug 20696] Remove a few ugly "eq undef" comparisons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20696 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75224|0 |1 is obsolete| | --- Comment #3 from Julian Maurice --- Created attachment 75402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75402&action=edit Bug 20696: Fix a few ugly "eq undef" comparisons in Search.pm Comparisons like $a eq undef should normally raise a warning like: Use of uninitialized value in string eq at ... But unfortunately we still suppress warnings here and there. Test plan: [1] Just read this patch and confirm the small changes. [2] Git grep on "eq undef" and do not find other occurrences. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Passes test plan and QA tools. Searching works correctly. Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 09:39:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 07:39:02 +0000 Subject: [Koha-bugs] [Bug 20696] Remove a few ugly "eq undef" comparisons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20696 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 09:53:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 07:53:04 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #37 from Nicolas Legrand --- (In reply to David Gustafsson from comment #27) [...] > I had forgotten about this issue, I will try to look into it, it would be > easier if I had some test data which produced this error. So if you have a > marc file would be helpful to attach or mail it to glasklas at gmail.com. Hey David, my colleague S?verine Queune retested it, it worked well this time and it took 30% less time than usual! We're not well verse on how it should work, but so far, having something that works and works faster seems pretty convenient :). Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 10:43:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 08:43:29 +0000 Subject: [Koha-bugs] [Bug 20755] Allow separate email configuration for acq emails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20755 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 10:58:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 08:58:29 +0000 Subject: [Koha-bugs] [Bug 20365] Allow several open orders on subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20365 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 10:58:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 08:58:59 +0000 Subject: [Koha-bugs] [Bug 20365] Allow several open orders on subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20365 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 11:04:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 09:04:42 +0000 Subject: [Koha-bugs] [Bug 20366] More information about orders linked to subscriptions on "Acquisition details" tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 --- Comment #6 from S?verine Queune --- I was curious to see what it looks like, but can't apply patches. $ git bz apply 20366 Bug 20366 - More information about orders linked to subscriptions on "Acquisition details" tab 75174 - Bug 20366: Add new method Koha::Acquisition::Order->subscription 75175 - Bug 20366: Add new method Koha::Acquisition::Basket->basket_group 75176 - Bug 20366: Add subscription info to the acq tab on the biblio detail page Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20366: Add new method Koha::Acquisition::Order->subscription fatal: sha1 information is lacking or useless (Koha/Acquisition/Order.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 20366: Add new method Koha::Acquisition::Order->subscription -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 11:22:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 09:22:34 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alex.sassmannshausen at gmail. |martin.renvoize at ptfs-europe |com |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 11:37:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 09:37:11 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #38 from David Gustafsson --- Ok, good! I wrote in the first post that indexing is twice as fast. The reason it was faster in my benchmark is that we have added more mappings and have about 40% more than the Koha defaults. Catmandu will get slower the more mappings but with the patch the time will stay pretty constant, so the performance difference will be more apparent the more mappings are added. I'm also a little bit dissatisfied with the slow serialization performance with marc-xml, so will probably add an option for using base64 encoded binary marc as serialization format instead. This will probably increase performance significantly as serialization now probably is the largest performance hog. I'm also working on fixing the tests and will probably be able to complete that today. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 11:53:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 09:53:48 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #39 from Mirko Tietgen --- Could you please list the versions of catmandu modules you did the tests with? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 12:08:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 10:08:14 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70335|0 |1 is obsolete| | --- Comment #56 from Alex Arnaud --- Created attachment 75403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75403&action=edit Bug 17656 - Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for monthly, daily or weekly serials ( 1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 12:08:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 10:08:25 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70336|0 |1 is obsolete| | --- Comment #57 from Alex Arnaud --- Created attachment 75404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75404&action=edit Bug 17656 - Update irregularities on subscription renewals Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Renew subscription from 2017-10-16 - Check that you have the prediction pattern table on renwal page - Submit renewal - Check that irregularity and permanent_irregularity column have been updated. - Do the same for a monthly and weekly subscription -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 12:09:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 10:09:00 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70619|0 |1 is obsolete| | --- Comment #59 from Alex Arnaud --- Created attachment 75406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75406&action=edit Bug 17656 - [QA followup] Remove useless description in subscription_daily_choice.inc and subscription_monthly_choice.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 12:08:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 10:08:45 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70430|0 |1 is obsolete| | --- Comment #58 from Alex Arnaud --- Created attachment 75405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75405&action=edit Bug 17656 - Fix QA comments - Make day and month names translatable, - Update unit tests, - Fix a typo in C4/Serials.pm (GessEndDate), - rename subtype subroutine to lengthtype - DB Change: add changes in kohastructure.sql and Bug_17656-add-permanent-irre -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 12:09:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 10:09:12 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #60 from Alex Arnaud --- Created attachment 75407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75407&action=edit Bug 17656: Update irregularities on multi-renewals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 12:09:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 10:09:22 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #61 from Alex Arnaud --- Created attachment 75408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75408&action=edit Bug 17656: move GuessEnddate in Koha::Subscription::guess_enddate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 12:14:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 10:14:59 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #62 from Alex Arnaud --- I've rebased these patches. Particulary upon bug 7910 that has been pushed recently. SO, addition for the plan is: - create several subscription with permanent irregularities, - renew them using the multi-renew feature, - check that the new irregulaties are consistent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 12:15:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 10:15:08 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 12:46:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 10:46:06 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74459|0 |1 is obsolete| | --- Comment #233 from Martin Renvoize --- Created attachment 75409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75409&action=edit Bug 11897: Add Stock Rotation atomic update schema. * installer/data/mysql/atomicupdate/stockrot_tables.sql: New file. * installer/data/mysql/kohastructure.sql (stockrotationrotas) (stockrotationstages, stockrotationitems): New tables. * installer/data/mysql/sysprefs.sql: Add Stockrotation sysprefs. * installer/data/mysql/userflags.sql: Add Stockrotaiton userflag. * installer/data/mysql/userpermissions.sql: Add Stockrotation userpermissions. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref: Add Stockrotation menu. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 12:46:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 10:46:12 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74460|0 |1 is obsolete| | --- Comment #234 from Martin Renvoize --- Created attachment 75410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75410&action=edit Bug 11897: DO NOT PUSH: Add stock rotation schema files. * Koha/Schema/Result/Branch.pm: New file. * Koha/Schema/Result/Item.pm: New file. * Koha/Schema/Result/Stockrotationitem.pm: New file. * Koha/Schema/Result/Stockrotationrota.pm: New file. * Koha/Schema/Result/Stockrotationstage.pm: New file. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 12:46:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 10:46:18 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74461|0 |1 is obsolete| | --- Comment #235 from Martin Renvoize --- Created attachment 75411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75411&action=edit Bug 11897: DBIX::Class::Ordered in Stockrotationstage. * Koha/Schema/Result/Stockrotationstage.pm: Load `Ordered`, add grouping_column. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 12:46:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 10:46:24 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74462|0 |1 is obsolete| | --- Comment #236 from Martin Renvoize --- Created attachment 75412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75412&action=edit Bug 11897: Add bulk of Stockrotation module. This commit replaces a set of about 20 commits into one large commit. This makes working with the module way easier from bugzilla. As it stands the patches on this bug provide a fully functioning stock rotation feature set for Koha. All previous patches that added functionality were signed off, so I'm retaining that flag. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 12:46:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 10:46:30 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74463|0 |1 is obsolete| | --- Comment #237 from Martin Renvoize --- Created attachment 75413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75413&action=edit Bug 11897: (QA follow-up) Implement review feedback. - Update Table declarations - Add permissions checks - Remove unused code - Fix language & naming - Make templates translation friendly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 12:46:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 10:46:35 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74464|0 |1 is obsolete| | --- Comment #238 from Martin Renvoize --- Created attachment 75414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75414&action=edit Bug 11897: (follow-up) Fix rebasing issue with templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 12:46:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 10:46:41 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74465|0 |1 is obsolete| | --- Comment #239 from Martin Renvoize --- Created attachment 75415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75415&action=edit Bug 11897: (QA follow-up) Fix Koha/Libraries test - merge issues corrected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 12:46:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 10:46:46 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74466|0 |1 is obsolete| | --- Comment #240 from Martin Renvoize --- Created attachment 75416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75416&action=edit Bug 11897: (QA follow-up) Fix POD failures - add empty pod blocks for internal object_class methods -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 12:46:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 10:46:52 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74467|0 |1 is obsolete| | --- Comment #241 from Martin Renvoize --- Created attachment 75417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75417&action=edit Bug 11897: (QA follow-up) Convert cronscript to use notices The cronscript originally used Koha::Email directly, this patch converts it to us the C4::Letters routines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 12:46:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 10:46:58 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74468|0 |1 is obsolete| | --- Comment #242 from Martin Renvoize --- Created attachment 75418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75418&action=edit Bug 11897: (QA follow-up) Add default notice template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 12:47:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 10:47:04 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74469|0 |1 is obsolete| | --- Comment #243 from Martin Renvoize --- Created attachment 75419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75419&action=edit Bug 11897: DO NOT PUSH: (follow-up) Update stock rotation schema files. We we're missing a unique constraint on stockrationrota.title -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 12:47:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 10:47:09 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74470|0 |1 is obsolete| | --- Comment #244 from Martin Renvoize --- Created attachment 75420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75420&action=edit Bug 11897: (QA follow-up) - Add uses of Asset tt plugin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 13:49:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 11:49:30 +0000 Subject: [Koha-bugs] [Bug 20366] More information about orders linked to subscriptions on "Acquisition details" tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 14:02:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 12:02:53 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 14:12:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 12:12:22 +0000 Subject: [Koha-bugs] [Bug 17561] ReserveSlip needs itemnumber for item level holds on same biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 14:12:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 12:12:25 +0000 Subject: [Koha-bugs] [Bug 17561] ReserveSlip needs itemnumber for item level holds on same biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73064|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall --- Created attachment 75421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75421&action=edit Bug 17561: ReserveSlip needs itemnumber for item level holds on same biblio This patch fixes a regression after bug 14695. This patch adds itemnumber and barcode as optional params in ReserveSlip used by hold-transfer-slip.pl to generate HOLD_SLIP. This is for ReserveSlip to be able to generate correct slips when items in multi-item holds are checked in. Test plan: 1) activate a circulation rule with multi-item holds 2) Place two holds on same biblio for patron 3) for debugging, either use browser console to observe POST request and responses or use info from reserves, e.g. reserve_id in the HOLD_SLIP 4) checkin two items from same biblio on pickup branch 5) note that both holds are effectuated, but reserve_id is the same on both slips 6) also note that there is no itemnumber or barcode in the requests from returns.pl 7) Apply this patch 8) repeat 2-4 9) note that reserve_id is now different on the two slips and/or: Run tests: t/db_dependent/Reserves/ReserveSlip.t Signed-off-by: Brendan Gallagher Signed-off-by: Maksim Sen Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 14:12:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 12:12:32 +0000 Subject: [Koha-bugs] [Bug 17561] ReserveSlip needs itemnumber for item level holds on same biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561 --- Comment #17 from Kyle M Hall --- Created attachment 75422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75422&action=edit Bug 17561 [QA Followup]: Simplify new ReserveSlip code Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 14:12:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 12:12:36 +0000 Subject: [Koha-bugs] [Bug 17561] ReserveSlip needs itemnumber for item level holds on same biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561 --- Comment #18 from Kyle M Hall --- Created attachment 75423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75423&action=edit Bug 17561 [QA Followup]: Update existing unit tests Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 14:14:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 12:14:29 +0000 Subject: [Koha-bugs] [Bug 17561] ReserveSlip needs itemnumber for item level holds on same biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75421|0 |1 is obsolete| | Attachment #75422|0 |1 is obsolete| | Attachment #75423|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall --- Created attachment 75424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75424&action=edit Bug 17561: ReserveSlip needs itemnumber for item level holds on same biblio This patch fixes a regression after bug 14695. This patch adds itemnumber and barcode as optional params in ReserveSlip used by hold-transfer-slip.pl to generate HOLD_SLIP. This is for ReserveSlip to be able to generate correct slips when items in multi-item holds are checked in. Test plan: 1) activate a circulation rule with multi-item holds 2) Place two holds on same biblio for patron 3) for debugging, either use browser console to observe POST request and responses or use info from reserves, e.g. reserve_id in the HOLD_SLIP 4) checkin two items from same biblio on pickup branch 5) note that both holds are effectuated, but reserve_id is the same on both slips 6) also note that there is no itemnumber or barcode in the requests from returns.pl 7) Apply this patch 8) repeat 2-4 9) note that reserve_id is now different on the two slips and/or: Run tests: t/db_dependent/Reserves/ReserveSlip.t Signed-off-by: Brendan Gallagher Signed-off-by: Maksim Sen Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 14:14:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 12:14:37 +0000 Subject: [Koha-bugs] [Bug 17561] ReserveSlip needs itemnumber for item level holds on same biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561 --- Comment #20 from Kyle M Hall --- Created attachment 75425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75425&action=edit Bug 17561 [QA Followup]: Simplify new ReserveSlip code Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 14:14:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 12:14:40 +0000 Subject: [Koha-bugs] [Bug 17561] ReserveSlip needs itemnumber for item level holds on same biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561 --- Comment #21 from Kyle M Hall --- Created attachment 75426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75426&action=edit Bug 17561 [QA Followup]: Update existing unit tests Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 14:22:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 12:22:59 +0000 Subject: [Koha-bugs] [Bug 19549] Reserve Slip prints first found hold when patron has multiple holds on a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #8 from Kyle M Hall --- *** This bug has been marked as a duplicate of bug 17561 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 14:22:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 12:22:59 +0000 Subject: [Koha-bugs] [Bug 17561] ReserveSlip needs itemnumber for item level holds on same biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561 --- Comment #22 from Kyle M Hall --- *** Bug 19549 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 14:27:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 12:27:55 +0000 Subject: [Koha-bugs] [Bug 10209] The ability to order multiple copies of the same item, from different fund classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 14:37:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 12:37:25 +0000 Subject: [Koha-bugs] [Bug 20778] New: Unable to delete a subscription Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 Bug ID: 20778 Summary: Unable to delete a subscription Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: alex.arnaud at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com To reproduce: - go to a subscription detail page, - click on edit -> delete subscription, - confirm the pop, => subscription is still here -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 18 14:37:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 12:37:37 +0000 Subject: [Koha-bugs] [Bug 20778] Unable to delete a subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 14:40:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 12:40:47 +0000 Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 14:40:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 12:40:51 +0000 Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #29 from Kyle M Hall --- Created attachment 75427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75427&action=edit Bug 18821 - Flush session after setting tracked_for_session -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 14:44:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 12:44:10 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75353|0 |1 is obsolete| | --- Comment #40 from David Gustafsson --- Created attachment 75428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75428&action=edit Bug 19893 - Alternative optimized indexing for Elasticsearch Add alternative optimized indexing for Elasticsearch How to test: 1) Time a full elasticsearch re-index by running the rebuild_elastic_search.pl with the -d flag: `koha-shell -c "time rebuild_elastic_search.pl -d"`. 2) Enable ExperimentalElasticSearchIndexing system preference (found under Global System preferences -> Administration -> Search Engine). 3) Time a full re-index again, it should be about twice at fast (for a couple of thousand biblios, with fewer biblios results may be more unpredictable). Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 14:45:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 12:45:43 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #41 from David Gustafsson --- Tests are now rewritten, could be made more exhaustive but at least as good coverage as the ones replaced. @Mirko Tietgen Do you mean the version used when producing the benchmarks? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 14:46:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 12:46:46 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #42 from David Gustafsson --- Forget to mention that in the new version of the patch I removed the preference and the new indexing method instead replaces the old. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 14:47:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 12:47:55 +0000 Subject: [Koha-bugs] [Bug 20778] Unable to delete a subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 --- Comment #1 from Alex Arnaud --- Created attachment 75429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75429&action=edit Bug 20778: Fix subscription deletion. Also remove the first confirmation pop because we have another one. Test plan: - go to a subscription detail page, - click on edit -> delete subscription, - confirm deletion, - check that the subscription is no longer here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 14:48:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 12:48:21 +0000 Subject: [Koha-bugs] [Bug 3935] Schedule tasks periodically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3935 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 14:48:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 12:48:29 +0000 Subject: [Koha-bugs] [Bug 20778] Unable to delete a subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 14:48:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 12:48:44 +0000 Subject: [Koha-bugs] [Bug 20778] Unable to delete a subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 14:51:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 12:51:26 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #43 from Mirko Tietgen --- (In reply to David Gustafsson from comment #41) > @Mirko Tietgen Do you mean the version used > when producing the benchmarks? Yes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 14:51:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 12:51:27 +0000 Subject: [Koha-bugs] [Bug 19037] Circulation and fine rules test tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19037 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 14:59:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 12:59:53 +0000 Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74903|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 75430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75430&action=edit Bug 20640: Add backend migration support to ILL - Add core methods required to support the migration of ILL requests between backends. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 18 15:00:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 13:00:32 +0000 Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75430|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 75431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75431&action=edit Bug 20640: Add backend migration support to ILL - Add core methods required to support the migration of ILL requests between backends. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 18 15:05:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 13:05:59 +0000 Subject: [Koha-bugs] [Bug 20366] More information about orders linked to subscriptions on "Acquisition details" tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |In Discussion --- Comment #7 from Jonathan Druart --- You need to apply patches from bug 20365 first, and so the ones from bug 20726 too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 15:14:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 13:14:36 +0000 Subject: [Koha-bugs] [Bug 20520] Re-indent moremember.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 --- Comment #1 from Owen Leonard --- Created attachment 75432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75432&action=edit Bug 20520: Re-indent moremember.tt This patch reindents the template for the patron detail page, moremember.tt: - Trailing spaces removed - Indentation changed to a consistent 4 spaces - Markup indentation made more consistent To test, view the patron detail page. There should be no visible difference before and after the applying the patch. HTML validation before and after the patch should return the same results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 15:14:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 13:14:34 +0000 Subject: [Koha-bugs] [Bug 20520] Re-indent moremember.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 15:18:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 13:18:15 +0000 Subject: [Koha-bugs] [Bug 20077] Patroncards are printed blank In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20077 --- Comment #9 from Chris Nighswonger --- This bug addresses concerns about blank patron cards. Please open another bug to address concerns about 100% CPU usage when printing patron cards. Be sure to include exact steps to reproduce the issue as well as any relevant log entries, etc. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 18 15:22:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 13:22:04 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #44 from David Gustafsson --- Ok! I think these were the versions: libcatmandu-marc-perl 0.215-1 libcatmandu-perl 1.0304-2~kohadev1 libcatmandu-store-elasticsearch-perl 0.0507-1~kohadev1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 15:45:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 13:45:52 +0000 Subject: [Koha-bugs] [Bug 20520] Re-indent moremember.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20779 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 [Bug 20779] Style refresh for patron detail page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 15:45:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 13:45:52 +0000 Subject: [Koha-bugs] [Bug 20779] New: Style refresh for patron detail page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 Bug ID: 20779 Summary: Style refresh for patron detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 20520 I have some style updates for the patron detail page (moremember.tt) which I think will make the page more readable. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 [Bug 20520] Re-indent moremember.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 15:50:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 13:50:16 +0000 Subject: [Koha-bugs] [Bug 20780] New: EDI: Add support for 'AcqItemSetSubfieldsWhenRecieved' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780 Bug ID: 20780 Summary: EDI: Add support for 'AcqItemSetSubfieldsWhenRecieved' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org EDI, as it stands, does not respect the AcqItemSetSubfieldsWhenRecieved system preference.. it should ;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 18 15:50:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 13:50:44 +0000 Subject: [Koha-bugs] [Bug 8055] reversing fines wonky In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8055 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|ASSIGNED |RESOLVED --- Comment #11 from Kyle M Hall --- No need to keep this open now. Payment voiding has been added by bug 18790 and bug 20629 is a patch to move fine reversal altogether. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 18 15:51:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 13:51:02 +0000 Subject: [Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenRecieved' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 16:00:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 14:00:52 +0000 Subject: [Koha-bugs] [Bug 20781] New: 0 months is not a valid enrollment period and causes errors Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781 Bug ID: 20781 Summary: 0 months is not a valid enrollment period and causes errors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com To recreate: 1 - Browse to Admin->Patron Categories 2 - Click '+ New category' 3 - Enter data as required, however, enter 0 in 'Enrolment period' -> 'in months' 4 - Save 5 - View the list of categories, the new category has 'Enrolment period' = 'until' 6 - Create a patron in this category 7 - Search for them 8 - internal server error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 18 16:01:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 14:01:05 +0000 Subject: [Koha-bugs] [Bug 20781] 0 months is not a valid enrollment period and causes errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 18 16:04:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 14:04:19 +0000 Subject: [Koha-bugs] [Bug 20781] 0 months is not a valid enrollment period and causes errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 16:04:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 14:04:21 +0000 Subject: [Koha-bugs] [Bug 20781] 0 months is not a valid enrollment period and causes errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781 --- Comment #1 from Nick Clemens --- Created attachment 75433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75433&action=edit Bug 20781: Set a minimum enrollemnt period 'in months' of 1 To test: 1 - Browse to Admin->Patron Categories 2 - Click '+ New category' 3 - Enter data as required, however, enter 0 in 'Enrolment period' -> 'in months' 4 - Save 5 - View the list of categories, the new category has 'Enrolment period' = 'until' 6 - Create a patron in this category, note their dateexipry is '0000-00-00' 7 - Search for them 8 - internal server error 9 - Delete that patron 10 - Apply patch 11 - Edit the category, note you cannot save with 0 months 12 - Set 1 month and save 13 - Create a patron in this cateogry 14 - Note they have a valid dateexpiry 15 - Search for them 16 - All works 17 - Create a new category and verify you cannot add with 0 months -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 16:05:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 14:05:35 +0000 Subject: [Koha-bugs] [Bug 20779] Style refresh for patron detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 --- Comment #1 from Owen Leonard --- Created attachment 75434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75434&action=edit Screenshot of the patron detail page before the patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 16:05:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 14:05:51 +0000 Subject: [Koha-bugs] [Bug 20779] Style refresh for patron detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 --- Comment #2 from Owen Leonard --- Created attachment 75435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75435&action=edit Screenshot of the patron detail page after the patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 16:06:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 14:06:46 +0000 Subject: [Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenRecieved' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 16:18:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 14:18:47 +0000 Subject: [Koha-bugs] [Bug 20779] Style refresh for patron detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 --- Comment #3 from Owen Leonard --- Created attachment 75436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75436&action=edit Bug 20779 - Style refresh for patron detail page This patch makes style and markup changes to the patron detail page template in order to make the display of information somewhat more compact and to increase the visibility of the edit controls. To test you should enable the patronimages system preference. Apply the patch and view the detail page for a patron. - Check that the page looks correct and that sections like "Alternate address" and "Alternative contact" are empty when there is no data. - Check that the "Manage patron image" tool works correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 16:18:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 14:18:44 +0000 Subject: [Koha-bugs] [Bug 20779] Style refresh for patron detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 16:23:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 14:23:05 +0000 Subject: [Koha-bugs] [Bug 20781] 0 months is not a valid enrollment period and causes errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 16:23:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 14:23:07 +0000 Subject: [Koha-bugs] [Bug 20781] 0 months is not a valid enrollment period and causes errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75433|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 75437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75437&action=edit Bug 20781: Set a minimum enrollemnt period 'in months' of 1 To test: 1 - Browse to Admin->Patron Categories 2 - Click '+ New category' 3 - Enter data as required, however, enter 0 in 'Enrolment period' -> 'in months' 4 - Save 5 - View the list of categories, the new category has 'Enrolment period' = 'until' 6 - Create a patron in this category, note their dateexipry is '0000-00-00' 7 - Search for them 8 - internal server error 9 - Delete that patron 10 - Apply patch 11 - Edit the category, note you cannot save with 0 months 12 - Set 1 month and save 13 - Create a patron in this cateogry 14 - Note they have a valid dateexpiry 15 - Search for them 16 - All works 17 - Create a new category and verify you cannot add with 0 months Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 16:28:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 14:28:43 +0000 Subject: [Koha-bugs] [Bug 20756] OPAC "Share list" button should be styled with an icon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 16:30:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 14:30:36 +0000 Subject: [Koha-bugs] [Bug 20782] New: EDI: Clicking the 'Invoice' link on the 'EDI Messages' page does not take you directly to the corresponding invoice. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20782 Bug ID: 20782 Summary: EDI: Clicking the 'Invoice' link on the 'EDI Messages' page does not take you directly to the corresponding invoice. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org This link used to take you to the right place, but has broken in recent releases. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 16:31:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 14:31:10 +0000 Subject: [Koha-bugs] [Bug 20782] EDI: Clicking the 'Invoice' link on the 'EDI Messages' page does not take you directly to the corresponding invoice. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20782 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 18 16:44:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 14:44:19 +0000 Subject: [Koha-bugs] [Bug 20120] Prevent writeoffs of more than the amount owed for a fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #31 from Kyle M Hall --- (In reply to Jonathan Druart from comment #30) > (In reply to Kyle M Hall from comment #29) > > (In reply to Jonathan Druart from comment #27) > > > How do we get the redirect? Sounds like impossible as we have the JS check. > > > > Never rely on client side validation ; ) > > Yes you are right, the problem is that it does not work. > It's easy to get the redirect: > 98 $amount=999; > > Then you see: > https://screenshots.firefox.com/8sNfHqHqxHpnMt45/pro.kohadev.org I don't get why you are failing qa for something that has nothing to do with my code. Did you even test it? If you fake a larger amount, then try to overpay the real amount, my code will prevent the payment from going though as expected. I seriously don't understand how you can say it doesn't work. Please post a video demonstration. Your screenshot gives no useful information. Setting back to PQA for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 16:49:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 14:49:41 +0000 Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 --- Comment #36 from Jonathan Druart --- There is a blocker issue introduced by these patches. The installer process (using packages) explodes with: '/usr/share/koha/intranet/cgi-bin/etc/searchengine/elasticsearch/mappings.yaml' is empty or non-existent at /usr/lib/x86_64-linux-gnu/perl5/5.20/YAML/Syck.pm line 129. The concatenation is obviously wrong. the koha-conf entry is filled with: Which is wrong too. Please fix ASAP or it will be reverted before 18.05 is released. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 17:08:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 15:08:19 +0000 Subject: [Koha-bugs] [Bug 20120] Prevent writeoffs of more than the amount owed for a fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 --- Comment #32 from Jonathan Druart --- I was testing the redirect, to make sure it worked. Changing the line (as noted in the comment) to bypass the JS check and the "999" appears on the table, I guess it's a variable name conflict. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 17:17:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 15:17:01 +0000 Subject: [Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 17:41:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 15:41:04 +0000 Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 --- Comment #37 from Nick Clemens --- Created attachment 75438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75438&action=edit Bug 20073: (follow-up) Correct paths -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 17:57:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 15:57:17 +0000 Subject: [Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenRecieved' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780 --- Comment #1 from Martin Renvoize --- Created attachment 75439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75439&action=edit Bug 20780 - Add handling for AcqItemSetSubfieldsWhenRecieved in EDI -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 17:59:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 15:59:30 +0000 Subject: [Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenRecieved' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 18:15:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 16:15:26 +0000 Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 18:16:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 16:16:13 +0000 Subject: [Koha-bugs] [Bug 20562] issue_id is not stored in accountlines for rental fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20562 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 18:16:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 16:16:37 +0000 Subject: [Koha-bugs] [Bug 19581] Elasticsearch - Catmandu split option adds extra null fields to indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19581 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 18:16:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 16:16:44 +0000 Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION %] everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 18:34:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 16:34:18 +0000 Subject: [Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenRecieved' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75439|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 75440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75440&action=edit Bug 20780 - Add handling for AcqItemSetSubfieldsWhenRecieved in EDI -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 18 18:55:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 16:55:01 +0000 Subject: [Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenRecieved' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 18:56:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 16:56:53 +0000 Subject: [Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenRecieved' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 18:58:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 16:58:40 +0000 Subject: [Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262 rkuiper at roundrocktexas.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuiper at roundrocktexas.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 18:58:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 16:58:54 +0000 Subject: [Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenRecieved' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Edifact reciepting of items release notes| |should now respect the | |AcqItemSetSubfieldsWhenReci | |eved systempreference Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 20:18:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 18:18:51 +0000 Subject: [Koha-bugs] [Bug 20783] New: Cannot embed some YouTube videos due to 403 errors Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20783 Bug ID: 20783 Summary: Cannot embed some YouTube videos due to 403 errors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: juan.sieira at xercode.es QA Contact: testopia at bugs.koha-community.org Some YouTube videos cannot be played beacause of a 403 error of the videoplayback URL. Video for testing: https://www.youtube.com/watch?v=haT8g7oKnns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 20:26:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 18:26:20 +0000 Subject: [Koha-bugs] [Bug 20783] Cannot embed some YouTube videos due to 403 errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20783 --- Comment #1 from Juan Romay Sieira --- Created attachment 75441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75441&action=edit Patch to embed youtube videos -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 20:32:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 18:32:42 +0000 Subject: [Koha-bugs] [Bug 18674] Show timezone for Perl and MySQL on the About Koha page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 20:33:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 18:33:53 +0000 Subject: [Koha-bugs] [Bug 20783] Cannot embed some YouTube videos due to 403 errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20783 --- Comment #2 from Juan Romay Sieira --- To test the patch you have to: * install a new package: HTML::Video::Embed * overwrite your opac.css with the attached in the bug, or create your opac.css with this command from the opac-tmpl directory: lessc --clean-css="--s0 --advanced --compatibility=ie7" bootstrap/less/opac.less > bootstrap/css/opac.css * Enable the syspref HTML5MediaEnabled to some interface, and HTML5MediaYouTube to embed videos. * Edit a biblio and put some youtube video in a 856u field. * Check it in OPAC or INTRANET. The video https://www.youtube.com/watch?v=haT8g7oKnns can not be played before the patch, but after it has no problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 20:35:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 18:35:03 +0000 Subject: [Koha-bugs] [Bug 20783] Cannot embed some YouTube videos due to 403 errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20783 --- Comment #3 from Juan Romay Sieira --- Created attachment 75442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75442&action=edit OPAC css -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 20:37:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 18:37:48 +0000 Subject: [Koha-bugs] [Bug 20783] Cannot embed some YouTube videos due to 403 errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20783 Juan Romay Sieira changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 20:48:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 18:48:38 +0000 Subject: [Koha-bugs] [Bug 20783] Cannot embed some YouTube videos due to 403 errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20783 Juan Romay Sieira changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75441|0 |1 is obsolete| | --- Comment #4 from Juan Romay Sieira --- Created attachment 75443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75443&action=edit Patch to embed youtube videos This patch do not include the opac.css file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 18 21:20:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 19:20:25 +0000 Subject: [Koha-bugs] [Bug 20784] New: Capture more changes in Logs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20784 Bug ID: 20784 Summary: Capture more changes in Logs Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Transaction logs Assignee: koha-bugs at lists.koha-community.org Reporter: joy at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It would be nice to have an Administration Log. A log that tracks changes (add/modify/deletes) to branch information, itemtype information, circ rules, authorised_values (others areas). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 18 21:23:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 19:23:53 +0000 Subject: [Koha-bugs] [Bug 20784] Capture more changes in Logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20784 Andrew changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #1 from Andrew --- Logging changes to MARC Framework setup would also be really helpful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 18 22:39:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 20:39:49 +0000 Subject: [Koha-bugs] [Bug 20785] New: Advanced Editor does not honor MarcFieldDocURL Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20785 Bug ID: 20785 Summary: Advanced Editor does not honor MarcFieldDocURL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl If you change the value of MarcFieldDocURL, and you catalog using the advanced editor, the help still points to Library of Congress. To reproduce : 1) Leave MarcFieldDocURL at its default value (empty) 2) Enable EnableAdvancedCatalogingEditor 2) Go to the cataloguing module 3) Click on 'New record' and choose a framework 3.5) (If you are not in the basic editor, click on 'Settings' and choose 'Switch to basic editor') 4) Click on the question mark (?) next to any MARC field 5) Note that the default goes to www.loc.gov 6) Click on 'Settings' 7) Choose 'Switch to advanced editor' (click OK on the confirmation) 8) Put your cursor next to a MARC field 9) At the bottom of the page, click on the question mark ([?]) 10) Note that the default goes to www.loc.gov 11) Go to Administration > Global System Preferences 12) Search for EnableAdvancedCatalogingEditor and enter http://www.marc21.ca/MaJ/BIB/B{FIELD}.pdf in the box 13) Save the system preferences 14) Redo steps 2 to 4 15) Note that the help goes to www.marc21.ca 16) Redo steps 6 to 9 17) Note that the help still goes to www.loc.gov -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 18 23:04:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 May 2018 21:04:29 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 David Bourgault changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74866|0 |1 is obsolete| | --- Comment #148 from David Bourgault --- Created attachment 75444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75444&action=edit Bug 17015: Updated patch after bug 19204 Rebased ~ This is a small modification to bring the patch up-to-date with current master after the changes made in 19204. Tests in db_dependent/Circulation.thave been changed slightly since DiscreteCalendar strictly prevents changing holidays in the past. This patch requires 20660. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 19 09:30:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 May 2018 07:30:44 +0000 Subject: [Koha-bugs] [Bug 20564] Error 500 displays when uploading patron images with a zipped file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 Eugene Espinoza changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eugenegf at yahoo.com --- Comment #7 from Eugene Espinoza --- Hi all! Getting also the same error when batch uploading patron images. However, when I enabled plack in the server, the images were uploaded successfully. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat May 19 19:12:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 May 2018 17:12:45 +0000 Subject: [Koha-bugs] [Bug 20786] New: process_message_queue.pl - multiple subroutine redefined errors Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20786 Bug ID: 20786 Summary: process_message_queue.pl - multiple subroutine redefined errors Change sponsored?: --- Product: Koha Version: 17.11 Hardware: PC OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: mjnkml at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Probably related to bug 2505, in the cronjob email, this comes up: Subject: Cron cd /tmp && koha-foreach --enabled --email /usr/share/koha/bin/cronjobs/process_message_queue.pl Body: Subroutine _ATTRIBUTES redefined at /usr/share/perl5/Authen/CAS/Client/Response/Failure.pm line 13. Subroutine new redefined at /usr/share/perl5/Authen/CAS/Client/Response/Failure.pm line 15. Subroutine code redefined at /usr/share/perl5/Authen/CAS/Client/Response/Failure.pm line 17. Subroutine message redefined at /usr/share/perl5/Authen/CAS/Client/Response/Failure.pm line 18. Subroutine new redefined at /usr/share/perl5/Authen/CAS/Client/Response/Success.pm line 13. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 19 19:13:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 May 2018 17:13:35 +0000 Subject: [Koha-bugs] [Bug 20786] process_message_queue.pl and cron.hourly - multiple subroutine redefined errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20786 mjnkml at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|process_message_queue.pl - |process_message_queue.pl |multiple subroutine |and cron.hourly - multiple |redefined errors |subroutine redefined errors -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 19 19:15:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 May 2018 17:15:07 +0000 Subject: [Koha-bugs] [Bug 20786] process_message_queue.pl and cron.hourly - multiple subroutine redefined errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20786 --- Comment #1 from mjnkml at gmail.com --- For /etc/cron.hourly/koha-common, this email comes: Subject: Cron cd / && run-parts --report /etc/cron.hourly Body: /etc/cron.hourly/koha-common: Subroutine _ATTRIBUTES redefined at /usr/share/perl5/Authen/CAS/Client/Response/Failure.pm line 13. Subroutine new redefined at /usr/share/perl5/Authen/CAS/Client/Response/Failure.pm line 15. Subroutine code redefined at /usr/share/perl5/Authen/CAS/Client/Response/Failure.pm line 17. Subroutine message redefined at /usr/share/perl5/Authen/CAS/Client/Response/Failure.pm line 18. Subroutine new redefined at /usr/share/perl5/Authen/CAS/Client/Response/Success.pm line 13. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat May 19 19:15:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 May 2018 17:15:53 +0000 Subject: [Koha-bugs] [Bug 20786] process_message_queue.pl and cron.hourly - multiple subroutine redefined errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20786 mjnkml at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mjnkml at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 19 21:40:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 May 2018 19:40:54 +0000 Subject: [Koha-bugs] [Bug 20787] New: System preference missing from manual - UseACQFrameworkForBiblioRecords Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20787 Bug ID: 20787 Summary: System preference missing from manual - UseACQFrameworkForBiblioRecords Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org There are some reference, source/acquisitions.rst line 441, but it's not on source/systempreferences.rst -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat May 19 21:49:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 May 2018 19:49:22 +0000 Subject: [Koha-bugs] [Bug 20788] New: Duplicate system preference EnableAdvancedCatalogingEditor Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20788 Bug ID: 20788 Summary: Duplicate system preference EnableAdvancedCatalogingEditor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org There are duplicate entries of EnableAdvancedCatalogingEditor on source/systempreferences.rst, lines 2072 and 7690 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 19 21:50:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 May 2018 19:50:14 +0000 Subject: [Koha-bugs] [Bug 20788] Duplicate system preference EnableAdvancedCatalogingEditor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20788 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |ldjamison at marywood.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 19 21:50:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 May 2018 19:50:39 +0000 Subject: [Koha-bugs] [Bug 20787] System preference missing from manual - UseACQFrameworkForBiblioRecords In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20787 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |ldjamison at marywood.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 19 21:57:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 May 2018 19:57:04 +0000 Subject: [Koha-bugs] [Bug 20789] New: Remove manual reference to OPACShowBarcode Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20789 Bug ID: 20789 Summary: Remove manual reference to OPACShowBarcode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org There are some occurrences of OPACShowBarcode on manual, this syspref has been removed. source/images.rst:84:.. |image84| image:: images/admin/globalprefs/OPACShowBarcode-noshow.png source/images.rst:85:.. |image85| image:: images/admin/globalprefs/OPACShowBarcode-show.png source/opac.rst:48:- :ref:`OPACShowBarcode` = Don't show -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 19 22:19:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 May 2018 20:19:59 +0000 Subject: [Koha-bugs] [Bug 20789] Remove manual reference to OPACShowBarcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20789 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |ldjamison at marywood.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 19 22:30:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 May 2018 20:30:34 +0000 Subject: [Koha-bugs] [Bug 20790] New: Missing email samples for list and cart Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20790 Bug ID: 20790 Summary: Missing email samples for list and cart Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org They used to be in miscellaneous, e.g. http://translate.srv.unc.edu.ar/manual/17.11/en/html/17_miscellaneous.html#example-email-from-list-label There are now dangling refs source/lists.rst:118: sample List email `) source/lists.rst:174: sample Cart email `) source/opac.rst:391: Lists email `) source/opac.rst:491:sample Cart email `. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 19 22:31:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 May 2018 20:31:32 +0000 Subject: [Koha-bugs] [Bug 20790] Missing email samples for list and cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20790 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |ldjamison at marywood.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 19 23:21:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 May 2018 21:21:10 +0000 Subject: [Koha-bugs] [Bug 20790] Missing email samples for list and cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20790 --- Comment #1 from Katrin Fischer --- Ah, I removed them. Will take care of the refs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat May 19 23:25:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 May 2018 21:25:10 +0000 Subject: [Koha-bugs] [Bug 20790] Missing email samples for list and cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20790 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | --- Comment #2 from Katrin Fischer --- Patch coming. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 19 23:25:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 May 2018 21:25:56 +0000 Subject: [Koha-bugs] [Bug 20789] Remove manual reference to OPACShowBarcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20789 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 19 23:31:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 May 2018 21:31:12 +0000 Subject: [Koha-bugs] [Bug 20789] Remove manual reference to OPACShowBarcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20789 --- Comment #1 from Katrin Fischer --- Patch coming. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 19 23:33:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 May 2018 21:33:54 +0000 Subject: [Koha-bugs] [Bug 20788] Duplicate system preference EnableAdvancedCatalogingEditor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20788 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | --- Comment #1 from Katrin Fischer --- The labs tab has been removed, feature is no longer experimental. Patch coming. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 19 23:40:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 May 2018 21:40:31 +0000 Subject: [Koha-bugs] [Bug 20787] System preference missing from manual - UseACQFrameworkForBiblioRecords In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20787 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |ldjamison at marywood.edu |ity.org | --- Comment #1 from Katrin Fischer --- This has an Assigned Taiga task already: https://tree.taiga.io/project/ldjamison-kohadocs-1805/task/285 :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 20 00:43:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 May 2018 22:43:35 +0000 Subject: [Koha-bugs] [Bug 20791] New: Correct capitalization on 'Notices and slips' page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20791 Bug ID: 20791 Summary: Correct capitalization on 'Notices and slips' page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: katrin.fischer at bsz-bw.de Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 20 00:52:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 May 2018 22:52:07 +0000 Subject: [Koha-bugs] [Bug 20791] Correct capitalization on 'Notices and slips' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20791 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 20 00:52:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 May 2018 22:52:10 +0000 Subject: [Koha-bugs] [Bug 20791] Correct capitalization on 'Notices and slips' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20791 --- Comment #1 from Katrin Fischer --- Created attachment 75445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75445&action=edit Bug 20791: Correct capitalization on 'Notices & slips' page - Standardizes spelling to 'Notices & slips' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 20 01:24:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 May 2018 23:24:03 +0000 Subject: [Koha-bugs] [Bug 20792] New: Can't go to patron record with TranslateNotices active Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20792 Bug ID: 20792 Summary: Can't go to patron record with TranslateNotices active Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Hope this only happens for me, but if not, this has blocker potential: To test: - Activate TranslateNotices - Go to any patron record - Internal server errror >From Plack logs: Template process failed: undef error - The method translated_language is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 122. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 20 02:25:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 00:25:56 +0000 Subject: [Koha-bugs] [Bug 17765] Hide 'Holds' link in patron account in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Hide 'Holds' link in staff |Hide 'Holds' link in patron |result list when user has |account in staff |no permission to place | |holds | Status|Patch doesn't apply |In Discussion --- Comment #5 from Katrin Fischer --- I feel like the patches proposed here don't do the right thing. A staff patron without place_holds should still be able to see information about existing holds on the circ desk. If people disagree, we should discuss how to achieve this without causing a disruption for libraries, maybe using a new separate pref? Marking 'In discussion' for now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 20 02:41:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 00:41:21 +0000 Subject: [Koha-bugs] [Bug 20793] New: Don't show holds link in result list when staff user doesn't have place_holds permission Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20793 Bug ID: 20793 Summary: Don't show holds link in result list when staff user doesn't have place_holds permission Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When a user doens't have 'place_holds' permission, the link on the result list should not show as a link as it only leads to a permission error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 20 02:53:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 00:53:46 +0000 Subject: [Koha-bugs] [Bug 20793] Don't show holds link in result list when staff user doesn't have place_holds permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20793 --- Comment #1 from Katrin Fischer --- Created attachment 75446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75446&action=edit Bug 20793: Don't show a holds link in staff for users without permission On the results list in staff the 'Holds (x)' link always shows independent of the permissions of the staff user. This patch tightens the permission checks on the result page to explicitly check for the place_holds permission. To test: - Create a staff user with place_holds permission - Check the result list, you should see 2 links to the holds page: - 'Place holds' on top of the results list - 'Holds (x)' at the bottom of each entry in the results list - Verify both links work - Create a staff user without place_holds_permission - Without the patch you'll see the second link, but it will lead to a permission error - With the patch you'll still see the 'Holds (x)', but it will no longer be a link. - Go to the detail page of a record with an existing hold. - Repeat test with both staff users. - One time the Hold information in the bibliographic information should show as a link, the other time as a simple text. Displaying the information about existing holds still make sense as this is the current beheviour. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 20 02:53:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 00:53:42 +0000 Subject: [Koha-bugs] [Bug 20793] Don't show holds link in result list when staff user doesn't have place_holds permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20793 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 20 02:54:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 00:54:13 +0000 Subject: [Koha-bugs] [Bug 20793] Don't show holds link in result list when staff user doesn't have place_holds permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20793 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 20 03:29:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 01:29:55 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 --- Comment #3 from Katrin Fischer --- If the staff user only has 'place_holds' the holds tab in the patron account is broken and gives an error: DataTables warning: table id=holds-table - Ajax error. For more information about this error, please see http://datatables.net/tn/7 Investigating. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 20 04:23:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 02:23:17 +0000 Subject: [Koha-bugs] [Bug 20794] New: Don't show holds tab when user doesn't have circulate_remaining_permissions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20794 Bug ID: 20794 Summary: Don't show holds tab when user doesn't have circulate_remaining_permissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If a user doesn't have circulate_remaining permissions, but has borrowers: - checkouts tab is hidden - details tab is visible - holds tab on details is visible, but results in an error The problem is that the svc/holds script requires circulate_remaining_permissions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 20 04:27:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 02:27:15 +0000 Subject: [Koha-bugs] [Bug 20794] Don't show holds tab when user doesn't have circulate_remaining_permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20794 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 20 04:27:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 02:27:19 +0000 Subject: [Koha-bugs] [Bug 20794] Don't show holds tab when user doesn't have circulate_remaining_permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20794 --- Comment #1 from Katrin Fischer --- Created attachment 75447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75447&action=edit Bug 20794: Hide holds tab on details when user lacks circulate_remaining_permissions If a user doesn't have circulate_remaining permissions, but has borrowers: - checkouts tab is hidden - details tab is visible - holds tab on details is visible, but results in an error The problem is that the svc/holds script requires circulate_remaining_permissions. To test: - Create 2 staff users with and without circulate_remaining_permissions Both need borrowers permission - Go to the details tab in a patron's account who has holds - Verify that you get a datatables error for the staff patron without circulate_remaining_permissions - Apply patch - Verify that now the holds tab is no longer displayed for this patron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 20 04:28:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 02:28:07 +0000 Subject: [Koha-bugs] [Bug 20794] Don't show holds tab when user doesn't have circulate_remaining_permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20794 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 20 04:28:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 02:28:37 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 --- Comment #4 from Katrin Fischer --- (In reply to Katrin Fischer from comment #3) > If the staff user only has 'place_holds' the holds tab in the patron account > is broken and gives an error: > > DataTables warning: table id=holds-table - Ajax error. For more information > about this error, please see http://datatables.net/tn/7 > > Investigating. Forget above, the problem is the hols tab not working if staff only has borrowers, but not circulate_remaining_permissions. I opened a separate bug for this issue: bug 20794 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 20 04:43:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 02:43:47 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 --- Comment #5 from Katrin Fischer --- Tomas, could you take another look here? I am not sure how to solve this bug. I think the problem is that we require reserveforothers for updates to holds, but in some cases we only want circulate_remaining_permissions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 20 05:58:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 03:58:54 +0000 Subject: [Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 20 05:58:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 03:58:58 +0000 Subject: [Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 --- Comment #8 from Katrin Fischer --- Created attachment 75448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75448&action=edit Bug 11911: Add a separate permission for managing suggestions Without this patch only catalogue permission was required for managing suggestions. This patch adds a new permission in the acquisition module do manage suggestions and updates staff user permissions accordingly. To test: - Make sure there is a pending suggestion - Create a few users with different permission sets: - User 1: only catalogue - User 2: any acquisition permission - User 3: cataloguing permission - Check all of them can access: /cgi-bin/koha/suggestion/suggestion.pl - Apply the patch - Verify all of them now have the suggestions_manage permission - Verify everything displays correctly on: - intranet start page - patron account in staff - acquisition start page - suggestion page (try to access by URL too) - Remove suggestions_manage for a staff user - Repeat tests above, access should be denied/links not visible Bonus: - Fixes the link on the acquisition start page for late orders to mage the permissions of the page itself: order_receive -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 20 05:59:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 03:59:11 +0000 Subject: [Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|indradg at l2c2.co.in |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 20 16:43:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 14:43:14 +0000 Subject: [Koha-bugs] [Bug 20795] New: koha-rebuild-zebra should pass through increased verbosity Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20795 Bug ID: 20795 Summary: koha-rebuild-zebra should pass through increased verbosity Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 20 16:46:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 14:46:38 +0000 Subject: [Koha-bugs] [Bug 20795] koha-rebuild-zebra should pass through increased verbosity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20795 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 20 16:46:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 14:46:41 +0000 Subject: [Koha-bugs] [Bug 20795] koha-rebuild-zebra should pass through increased verbosity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20795 --- Comment #1 from Nick Clemens --- Created attachment 75449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75449&action=edit Bug 20795: Pass incrreased verbosity to zebra rebuild script To test: 1 - Run koha-rebuild-zebra with multiple '-v' 2 - Note no increased verbosity 3 - Apply patch 4 - Run the updated koha-rebuild-zebra script with multiple '-v' 5 - Note increased verbosity -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 20 20:08:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 18:08:14 +0000 Subject: [Koha-bugs] [Bug 20375] Add a new permission for managing invoices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20375 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 20 20:24:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 18:24:10 +0000 Subject: [Koha-bugs] [Bug 20375] Add a new permission for managing invoices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20375 --- Comment #1 from Katrin Fischer --- After giving it some more thought: As invoices are a part of the receive process, I think it makes sense to use order_receive both for managing shipments and invoices. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 20 20:51:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 18:51:45 +0000 Subject: [Koha-bugs] [Bug 3849] Descriptions of acquisition permissions are unclear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3849 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 20 21:09:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 19:09:35 +0000 Subject: [Koha-bugs] [Bug 3849] Descriptions of acquisition permissions are unclear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3849 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 20 21:09:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 19:09:38 +0000 Subject: [Koha-bugs] [Bug 3849] Descriptions of acquisition permissions are unclear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3849 --- Comment #11 from Katrin Fischer --- Created attachment 75450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75450&action=edit Bug 3849: Improve descriptions of granular acquisition permissions The permissions for acquisitions were not very clearly described. This patch changes the descriptions in the include file (GUI) and in the default SQL. To test: - Go to any patron account in staff - Go to more > permissions - Verify that the meaning of each acquisition permission is clear from the description -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 20 23:08:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 21:08:20 +0000 Subject: [Koha-bugs] [Bug 20678] Save draft records without committing them to the catalogue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20678 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 20 23:15:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 21:15:20 +0000 Subject: [Koha-bugs] [Bug 20375] Add a new permission for managing invoices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20375 --- Comment #2 from Katrin Fischer --- Needs some more thinking. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 20 23:57:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 21:57:17 +0000 Subject: [Koha-bugs] [Bug 7651] Add separate permission for managing currencies and exchange rates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |3849 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3849 [Bug 3849] Descriptions of acquisition permissions are unclear -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 20 23:57:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 21:57:17 +0000 Subject: [Koha-bugs] [Bug 3849] Descriptions of acquisition permissions are unclear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3849 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7651 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 [Bug 7651] Add separate permission for managing currencies and exchange rates -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 20 23:58:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 21:58:34 +0000 Subject: [Koha-bugs] [Bug 7651] Add separate permission for managing currencies and exchange rates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 20 23:58:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 21:58:37 +0000 Subject: [Koha-bugs] [Bug 7651] Add separate permission for managing currencies and exchange rates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 --- Comment #5 from Katrin Fischer --- Created attachment 75451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75451&action=edit Bug 7651: Add a new permission for managing currencies and exchange rates At the moment staff users need parameters or parameters_remaining_permissions in order to be able to change exchange rates for acquisition orders. This patch adds a new separate permission currencies_manage and updates staff users currently having those permissions to get the new permission as well. To test: - Create some staff users with different permission sets 1) superlibrarian 2) parameters 3) parameters_remaining_permissions 4) manage_circ_rules, but not parmeters_remaining_permissions 5) all acquisition permissions - Apply patch and run database update - Verify new permission has been added and staff users updated 1) remains the same 2) + 3) will have currencies_manage 4) remains unchanged, doesn't have new permission 5) remains the same, will have access now because of having the top level acquisition permission - Verify the changed pages work correctly: - navigation on admin home page NOTE: the acquisition parameters section will now honor all different related permissions (edi_manage, budget_manage,...) - navigation on acquisition home page - try to access currencies page directly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 00:11:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 22:11:42 +0000 Subject: [Koha-bugs] [Bug 7651] Add separate permission for managing currencies and exchange rates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14391 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391 [Bug 14391] Granular permissions for the administration module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 00:11:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 22:11:42 +0000 Subject: [Koha-bugs] [Bug 14391] Granular permissions for the administration module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | Depends on| |7651 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 [Bug 7651] Add separate permission for managing currencies and exchange rates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 00:12:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 22:12:19 +0000 Subject: [Koha-bugs] [Bug 14391] Granular permissions for the administration module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 00:19:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 May 2018 22:19:17 +0000 Subject: [Koha-bugs] [Bug 7651] Add separate permission for managing currencies and exchange rates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75451|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 75452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75452&action=edit Bug 7651: Add a new permission for managing currencies and exchange rates At the moment staff users need parameters or parameters_remaining_permissions in order to be able to change exchange rates for acquisition orders. This patch adds a new separate permission currencies_manage and updates staff users currently having those permissions to get the new permission as well. To test: - Create some staff users with different permission sets 1) superlibrarian 2) parameters 3) parameters_remaining_permissions 4) manage_circ_rules, but not parmeters_remaining_permissions 5) all acquisition permissions - Apply patch and run database update - Verify new permission has been added and staff users updated 1) remains the same 2) + 3) will have currencies_manage 4) remains unchanged, doesn't have new permission 5) remains the same, will have access now because of having the top level acquisition permission - Verify the changed pages work correctly: - navigation on admin home page NOTE: the acquisition parameters section will now honor all different related permissions (edi_manage, budget_manage,...) - navigation on acquisition home page - try to access currencies page directly https://bugs.koha-community.org/show_bug.cgi?id=3849 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 09:17:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 07:17:48 +0000 Subject: [Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #28 from Fridolin SOMERS --- Enhancement not pushed to 17.05.x Viva ElasticSearch ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 09:17:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 07:17:49 +0000 Subject: [Koha-bugs] [Bug 19604] Elasticsearch Fixes for build_authorities_query for auth searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604 Bug 19604 depends on bug 19582, which changed state. Bug 19582 Summary: Elasticsearch: Auth-finder.pl must use search_auth_compat https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 09:17:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 07:17:50 +0000 Subject: [Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 Bug 20273 depends on bug 19582, which changed state. Bug 19582 Summary: Elasticsearch: Auth-finder.pl must use search_auth_compat https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 09:19:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 07:19:14 +0000 Subject: [Koha-bugs] [Bug 19583] Report updater triggers on auth_header.marcxml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19583 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 21 09:21:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 07:21:14 +0000 Subject: [Koha-bugs] [Bug 19583] Report updater triggers on auth_header.marcxml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19583 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17196 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 [Bug 17196] Move marcxml out of the biblioitems table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 09:21:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 07:21:14 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19583 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19583 [Bug 19583] Report updater triggers on auth_header.marcxml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 09:22:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 07:22:31 +0000 Subject: [Koha-bugs] [Bug 19583] Report updater triggers on auth_header.marcxml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19583 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|fridolin.somers at biblibre.co |koha-bugs at lists.koha-commun |m |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 21 09:27:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 07:27:13 +0000 Subject: [Koha-bugs] [Bug 19583] Report updater triggers on auth_header.marcxml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19583 --- Comment #1 from Fridolin SOMERS --- Indeed, its not relevant. I think detecting correct reports is hard because column marcxml may be alone. Is there a way to manually cancel this message ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 09:29:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 07:29:05 +0000 Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 --- Comment #38 from Ere Maijala --- The original patch moved elasticsearch.yaml from admin/searchengine/elasticsearch to etc/searchengine/elasticsearch. I didn't realize this affects packaging. I think it's best to revert the move and put the other yaml files into admin/searchengine/elasticsearch too. I'll attach a patch ASAP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 09:53:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 07:53:13 +0000 Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75438|0 |1 is obsolete| | --- Comment #39 from Ere Maijala --- Created attachment 75453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75453&action=edit Bug 20073: Move Elasticsearch yaml files back to admin directory -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 09:55:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 07:55:48 +0000 Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 --- Comment #40 from Ere Maijala --- Attached a patch that moves the default yaml files back to admin directory. Tests pass but I don't know enough about packaging to test it. The koha-conf entry is a commented-out example, and I can't see anything wrong with it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 10:22:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 08:22:23 +0000 Subject: [Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582 --- Comment #29 from Fridolin SOMERS --- Oups in GIT last commit message has the wrong bug id : Bug 19583 http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=f60bff7aa0e3ca932f5572b7837d912b8681ca2a -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 10:23:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 08:23:16 +0000 Subject: [Koha-bugs] [Bug 20797] New: If an Ill request has an associated bib record, the detail view should contain a link to the record Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Bug ID: 20797 Summary: If an Ill request has an associated bib record, the detail view should contain a link to the record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com Currently, the ILL request detail view shows a plain biblionumber.. this should be a link through to the bib record view. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 21 10:23:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 08:23:49 +0000 Subject: [Koha-bugs] [Bug 19583] Report updater triggers on auth_header.marcxml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19583 --- Comment #2 from Fridolin SOMERS --- Oups in GIT last commit message of Bug 19582 has the wrong bug id : Bug 19583 http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=f60bff7aa0e3ca932f5572b7837d912b8681ca2a You may recreate this bug to have a new number. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 21 10:35:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 08:35:56 +0000 Subject: [Koha-bugs] [Bug 20797] If an Ill request has an associated bib record, the detail view should contain a link to the record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 --- Comment #1 from Martin Renvoize --- Created attachment 75454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75454&action=edit Bug 20797 - Add link to biblio detail view from ILL detail view -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 10:37:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 08:37:28 +0000 Subject: [Koha-bugs] [Bug 20797] If an Ill request has an associated bib record, the detail view should contain a link to the record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 21 10:37:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 08:37:28 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20797 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 [Bug 20797] If an Ill request has an associated bib record, the detail view should contain a link to the record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 10:38:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 08:38:38 +0000 Subject: [Koha-bugs] [Bug 20797] If an Ill request has an associated bib record, the detail view should contain a link to the record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 21 10:56:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 08:56:08 +0000 Subject: [Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenRecieved' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 10:57:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 08:57:11 +0000 Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 21 11:02:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 09:02:46 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75428|0 |1 is obsolete| | --- Comment #45 from David Gustafsson --- Created attachment 75455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75455&action=edit Bug 19893 - Alternative optimized indexing for Elasticsearch Add alternative optimized indexing for Elasticsearch How to test: 1) Time a full elasticsearch re-index by running the rebuild_elastic_search.pl with the -d flag: `koha-shell -c "time rebuild_elastic_search.pl -d"`. 2) Enable ExperimentalElasticSearchIndexing system preference (found under Global System preferences -> Administration -> Search Engine). 3) Time a full re-index again, it should be about twice at fast (for a couple of thousand biblios, with fewer biblios results may be more unpredictable). Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 11:04:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 09:04:58 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #46 from David Gustafsson --- Added preference to choose serialization format for records in index. Now providing also base64 encoded binary marc as a more performant but possibly less robust (will not support very large records) option. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 11:26:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 09:26:15 +0000 Subject: [Koha-bugs] [Bug 20647] When ILL is enabled the hover effect on the ILL requests button is wrong. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647 --- Comment #1 from Martin Renvoize --- Created attachment 75456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75456&action=edit Bug 20647: Correct hover effect for Ill module -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 21 11:26:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 09:26:43 +0000 Subject: [Koha-bugs] [Bug 20647] When ILL is enabled the hover effect on the ILL requests button is wrong. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 11:26:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 09:26:53 +0000 Subject: [Koha-bugs] [Bug 20647] When ILL is enabled the hover effect on the ILL requests button is wrong. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 21 11:27:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 09:27:20 +0000 Subject: [Koha-bugs] [Bug 20647] When ILL is enabled the hover effect on the ILL requests button is wrong. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 11:59:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 09:59:41 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #47 from Ere Maijala --- I'd leave the alternative serialization out for now and add a new bug about it. It might make sense to e.g. use the binary format as long as the record is small enough but switch to alternative format for large records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 12:14:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 10:14:03 +0000 Subject: [Koha-bugs] [Bug 19583] Report updater triggers on auth_header.marcxml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19583 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- I think there is not, would be nice to be able to remove the warning. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 13:16:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 11:16:38 +0000 Subject: [Koha-bugs] [Bug 20782] EDI: Clicking the 'Invoice' link on the 'EDI Messages' page does not take you directly to the corresponding invoice. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20782 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 13:16:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 11:16:20 +0000 Subject: [Koha-bugs] [Bug 20782] EDI: Clicking the 'Invoice' link on the 'EDI Messages' page does not take you directly to the corresponding invoice. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20782 --- Comment #1 from Martin Renvoize --- Created attachment 75457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75457&action=edit Bug 20782: Fix link from edifactmessages to invoices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 13:17:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 11:17:07 +0000 Subject: [Koha-bugs] [Bug 20782] EDI: Clicking the 'Invoice' link on the 'EDI Messages' page does not take you directly to the corresponding invoice. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20782 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com, | |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 13:22:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 11:22:49 +0000 Subject: [Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenReceived' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|EDI: Add support for |EDI: Add support for |'AcqItemSetSubfieldsWhenRec |'AcqItemSetSubfieldsWhenRec |ieved' |eived' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 13:23:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 11:23:07 +0000 Subject: [Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenReceived' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Edifact reciepting of items |Edifact reciepting of items release notes|should now respect the |should now respect the |AcqItemSetSubfieldsWhenReci |AcqItemSetSubfieldsWhenRece |eved systempreference |ived systempreference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 14:26:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 12:26:29 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #37 from David Gustafsson --- Created attachment 75458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75458&action=edit Change search field weight field to decimal and add column declaration to DBIx results source -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 14:32:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 12:32:57 +0000 Subject: [Koha-bugs] [Bug 11409] ungrouped baskets are not being displayed when creating a new basket group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11409 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |INVALID --- Comment #8 from Owen Leonard --- I'm closing this because the original bug stemmed from a misunderstanding and discussion of whether basket groups are worthwhile can take place elsewhere. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 15:03:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 13:03:15 +0000 Subject: [Koha-bugs] [Bug 19196] Add pagination helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196 --- Comment #41 from Tom?s Cohen Arazi --- (In reply to Marcel de Rooy from comment #40) > (In reply to Marcel de Rooy from comment #32) > > Error while loading /etc/koha/plack.psgi: Can't load application from file > > "api/v1/app.pl": Can't locate > > Mojolicious/Plugin/Koha/REST/Plugin/Pagination.pm: > > ./Mojolicious/Plugin/Koha/REST/Plugin/Pagination.pm: Permission denied at > > (eval 1295) line 1. > > What happened? No idea, but (suddenly) I cannot reproduce this error any > more. Glad to see that, but it is still intriguing. Hard to say what > resolved the problem after a few weeks of merging master and commenting the > plugin line in V1. If it comes up again, I will certainly tell you.. This was dealth with on bug 19546 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 15:04:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 13:04:53 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19638 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19638 [Bug 19638] False positives for 'Update SQL' button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 15:04:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 13:04:53 +0000 Subject: [Koha-bugs] [Bug 19638] False positives for 'Update SQL' button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19638 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17196 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 [Bug 17196] Move marcxml out of the biblioitems table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 15:05:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 13:05:30 +0000 Subject: [Koha-bugs] [Bug 19583] Report updater triggers on auth_header.marcxml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19583 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|--- |DUPLICATE --- Comment #4 from Jonathan Druart --- This should be fixed by bug 19638. *** This bug has been marked as a duplicate of bug 19638 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 21 15:05:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 13:05:30 +0000 Subject: [Koha-bugs] [Bug 19638] False positives for 'Update SQL' button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19638 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #7 from Jonathan Druart --- *** Bug 19583 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 15:38:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 13:38:49 +0000 Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20792 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20792 [Bug 20792] Can't go to patron record with TranslateNotices active -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 15:38:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 13:38:49 +0000 Subject: [Koha-bugs] [Bug 20792] Can't go to patron record with TranslateNotices active In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20792 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED Depends on| |18789 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Confirmed, caused by commit 0ab22e1c7c6b6e8d14a4fb7478ab2a3d42da347d Bug 18789: Send Koha::Patron object to the templates Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 [Bug 18789] Send a Koha::Patron object to the templates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 21 15:42:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 13:42:19 +0000 Subject: [Koha-bugs] [Bug 20792] Can't go to patron record with TranslateNotices active In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20792 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 15:42:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 13:42:23 +0000 Subject: [Koha-bugs] [Bug 20792] Can't go to patron record with TranslateNotices active In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20792 --- Comment #2 from Jonathan Druart --- Created attachment 75459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75459&action=edit Bug 20792: (bug 18789 follow-up) Fix patron edit page if TranslateNotices is set translated_language is not a Koha::Patron's method but a simple variable sent to the template. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 15:45:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 13:45:16 +0000 Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #41 from Jonathan Druart --- I am going to revert this patch from master, 18.05 is released tomorrow and I will not have time to retest this one. It seems safer to consolidate and push it later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 15:55:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 13:55:04 +0000 Subject: [Koha-bugs] [Bug 20792] Can't go to patron record with TranslateNotices active In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20792 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 15:55:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 13:55:07 +0000 Subject: [Koha-bugs] [Bug 20792] Can't go to patron record with TranslateNotices active In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20792 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75459|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 75460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75460&action=edit Bug 20792: (bug 18789 follow-up) Fix patron edit page if TranslateNotices is set translated_language is not a Koha::Patron's method but a simple variable sent to the template. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 15:56:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 13:56:42 +0000 Subject: [Koha-bugs] [Bug 20792] Can't go to patron record with TranslateNotices active In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20792 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Katrin Fischer --- Trivial obvious fix, skipping QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 16:04:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 14:04:01 +0000 Subject: [Koha-bugs] [Bug 20792] Can't go to patron record with TranslateNotices active In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20792 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Thank Katrin! Pushed to master for 18.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 16:04:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 14:04:58 +0000 Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED --- Comment #42 from Jonathan Druart --- Reverted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 16:05:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 14:05:05 +0000 Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 16:05:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 14:05:19 +0000 Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #43 from Jonathan Druart --- Sending back to QA queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 16:14:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 14:14:43 +0000 Subject: [Koha-bugs] [Bug 14907] Item search: Call Numbers in Item search results are ordered alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14907 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org Assignee|indradg at l2c2.co.in |koha-bugs at lists.koha-commun | |ity.org Version|3.20 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 21 16:23:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 14:23:03 +0000 Subject: [Koha-bugs] [Bug 16175] Amazon book covers should use https on public and private lists in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16175 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Owen Leonard --- This appears to have been fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 16:23:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 14:23:03 +0000 Subject: [Koha-bugs] [Bug 17137] Omnibus: Always use SSL when referencing external sources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17137 Bug 17137 depends on bug 16175, which changed state. Bug 16175 Summary: Amazon book covers should use https on public and private lists in the OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16175 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 16:45:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 14:45:30 +0000 Subject: [Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262 --- Comment #3 from Martha Fuerst --- Test Plan: 1) Apply this patch 2) Set your lost item refund on return policies to 'Only if unpaid' 3) Mark an item lost, charging the lost fee 4) Return the item, a full refund should ocurr 5) Mark another item lost, charging the lost fee 6) Make a partial payment on this lost fee 7) Return the item 8) The remaining balance of that fee should be 0, but the patron should not recieve a credit for the already paid balance 8) Mark another item lost, charging the lost fee 9) Fully pay the lost fee 10) Return the item. The paid lost fee should be unaffected. Notes: 4) If the patron has other fines, the lost item refund pays those first, as opposed to just paying the lost item charge. This could be confusing for staff, but IIRC, there's another bug related to how credits get applied? 8) Marked an item lost that created a 9.99 charge on patron's account. Paid 5.00 of it. Returned item. Patron's account was credited 9.99, creating a 5.00 credit. 9) Fully paid for item - credit still applied, resulting in a credit on the account. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 16:50:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 14:50:46 +0000 Subject: [Koha-bugs] [Bug 20407] Hide some fields from unauthorized users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20407 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize --- The slightly more accepted way of doing this to date that I have seen is to reduce the default response to only contain public fields and set the private fields to need explicitly requesting in the api call. This way, rather than sending back a 200 with varying content you send back either a 200 with what the consumer has asked for (or is expecting) or you send back a 401 Unauthorized and the client knows to authenticate). The principle of Least Surprise. I do like the x-public way of defining it in the spec though.. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 16:57:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 14:57:51 +0000 Subject: [Koha-bugs] [Bug 19850] Enhance invoicing functionality for each line item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19850 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #2 from Martin Renvoize --- I am working on a proposal for this and intend to submit it as an RFC.. I'll post here when complete. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 21 18:10:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 16:10:07 +0000 Subject: [Koha-bugs] [Bug 19583] Report updater triggers on auth_header.marcxml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19583 --- Comment #5 from Fridolin SOMERS --- (In reply to Jonathan Druart from comment #4) > This should be fixed by bug 19638. > > *** This bug has been marked as a duplicate of bug 19638 *** Ahhh super, I had forgotten this one ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 18:30:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 16:30:38 +0000 Subject: [Koha-bugs] [Bug 18480] Get rid of unwanted / distracting link in patron search for fund owner In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 21 18:30:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 16:30:41 +0000 Subject: [Koha-bugs] [Bug 18480] Get rid of unwanted / distracting link in patron search for fund owner In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480 --- Comment #2 from Owen Leonard --- Created attachment 75461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75461&action=edit Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner This patch modifies templates where a pop-up window is used to display patron search results. A link has been added to the patron name which triggers a modal window displaying more details about that patron. With each page in the test plan, check that clicking linked names in search results triggers a modal with the correct data. - Acquisitions -> Vendor -> View basket -> Add user - Acquisitions -> Vendor -> Add to basket -> From a new (empty) record -> Add user - Acquisitions -> Funds -> Edit fund -> Select owner - Tools -> Patron card creator -> Manage -> Card batches -> Edit -> Add patrons - Serials -> Subscription -> Edit routing list -> Add recipients -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 18:32:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 16:32:20 +0000 Subject: [Koha-bugs] [Bug 18480] Get rid of unwanted / distracting link in patron search for fund owner In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480 --- Comment #3 from Owen Leonard --- I'm proposing an alternate solution which affects not just the patron search for fund owner but other similar pop-up searches too. In my version the patron link triggers a modal windows with more patron details. This eliminates the unwanted redirection while still allowing the user to get more information. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 21 18:41:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 16:41:19 +0000 Subject: [Koha-bugs] [Bug 16124] Checking "is a url" box in MARC subfield does not turn it into a link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16124 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 19:36:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 17:36:07 +0000 Subject: [Koha-bugs] [Bug 20499] Checkout of bad barcode: Internal Server Error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20499 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |nick at bywatersolutions.com Status|Pushed to Master |RESOLVED --- Comment #15 from Nick Clemens --- Dependency not in stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 19:36:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 17:36:35 +0000 Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION %] everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #27 from Nick Clemens --- Enhancement, not backported for 17.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 19:38:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 17:38:13 +0000 Subject: [Koha-bugs] [Bug 19882] Add Novelist Select staff client profile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #16 from Nick Clemens --- Enhancement, not backported for 17.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 19:38:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 17:38:40 +0000 Subject: [Koha-bugs] [Bug 19282] Add the copy, print and export DataTables buttons on all koha tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19282 Bug 19282 depends on bug 18791, which changed state. Bug 18791 Summary: Add the ability for librarians to easily copy, download or print DataTables based tables in Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18791 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 21 19:38:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 17:38:39 +0000 Subject: [Koha-bugs] [Bug 18791] Add the ability for librarians to easily copy, download or print DataTables based tables in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18791 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |nick at bywatersolutions.com Resolution|--- |FIXED --- Comment #33 from Nick Clemens --- Ehancement, not backported for 17.11.X -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 19:38:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 17:38:40 +0000 Subject: [Koha-bugs] [Bug 20583] Make the export buttons configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20583 Bug 20583 depends on bug 18791, which changed state. Bug 18791 Summary: Add the ability for librarians to easily copy, download or print DataTables based tables in Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18791 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 21 19:42:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 17:42:50 +0000 Subject: [Koha-bugs] [Bug 20699] Implement functionality for junior cataloguing staff to practise cataloguing/saving their records to reservoir (import_records, import_biblios DB tables) as drafts which are administered from the Cataloging interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20699 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18823 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 19:42:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 17:42:50 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20699 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 20:56:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 18:56:31 +0000 Subject: [Koha-bugs] [Bug 19453] Client side validation broken for "Fund" select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19453 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20798 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20798 [Bug 20798] Client side validation for for fund selection prevents adding only some records to a basket -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 20:56:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 18:56:31 +0000 Subject: [Koha-bugs] [Bug 20798] New: Client side validation for for fund selection prevents adding only some records to a basket Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20798 Bug ID: 20798 Summary: Client side validation for for fund selection prevents adding only some records to a basket Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Depends on: 19453 Bug 19453 "fixed" the fund validation that never actually worked. This validation should be removed altogether instead. It is overly simplistic and simply checks to see if each record in the batch has a fund selected regardless of whether that record will be imported or not. In addition, the code completely ignores items generated by MarcItemFieldsToOrder such that even if items on that page have a fund selected, the javascript forces the librarian to make a selection from the left-hand fund pulldown even though it will not be used. Considering this bad validation is basically 'new' as it never worked before, the most sensible course of action would be to 'undo' the change and remove the validation. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19453 [Bug 19453] Client side validation broken for "Fund" select -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 21 20:57:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 18:57:12 +0000 Subject: [Koha-bugs] [Bug 20798] Client side validation for for fund selection prevents adding only some records to a basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20798 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 21 20:57:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 18:57:15 +0000 Subject: [Koha-bugs] [Bug 20798] Client side validation for for fund selection prevents adding only some records to a basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20798 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 20:57:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 18:57:58 +0000 Subject: [Koha-bugs] [Bug 20798] Client side validation for for fund selection prevents adding only some records to a basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20798 --- Comment #1 from Kyle M Hall --- Video demonstration: https://monosnap.com/file/M11N3U3TaJcGKwRnnMMxNTc07Ia6nK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 21:00:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 19:00:26 +0000 Subject: [Koha-bugs] [Bug 20798] Client side validation for for fund selection prevents adding only some records to a basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20798 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 21 21:00:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 May 2018 19:00:28 +0000 Subject: [Koha-bugs] [Bug 20798] Client side validation for for fund selection prevents adding only some records to a basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20798 --- Comment #2 from Kyle M Hall --- Created attachment 75462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75462&action=edit Bug 20798: Client side validation for for fund selection prevents adding only some records to a basket Bug 19453 "fixed" the fund validation that never actually worked. This validation should be removed altogether instead. It is overly simplistic and simply checks to see if each record in the batch has a fund selected regardless of whether that record will be imported or not. In addition, the code completely ignores items generated by MarcItemFieldsToOrder such that even if items on that page have a fund selected, the javascript forces the librarian to make a selection from the left-hand fund pulldown even though it will not be used. Considering this bad validation is basically 'new' as it never worked before, the most sensible course of action would be to 'undo' the change and remove the validation. Test Plan: 1) Add records to a basket from an import batch 2) Select only some of those items in the batch 3) Note Koha will not let you import them unless you set funds for *all* records in the batch 4) Apply this patch 5) Note Koha no longer forces a budget to be selected in the pulldown -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 02:28:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 00:28:41 +0000 Subject: [Koha-bugs] [Bug 20564] Error 500 displays when uploading patron images with a zipped file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at l2c2.co.in --- Comment #8 from Indranil Das Gupta --- Confirming that the problem persists on a package installed 17.11.05 (non-plack) with Apache 2.4.10. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 22 09:08:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 07:08:53 +0000 Subject: [Koha-bugs] [Bug 18996] SIP sets ok flag to true for refused checkin for data corruption In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18996 Anna changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |urstanlib at urs.edu.ph --- Comment #50 from Anna --- Can it be applied to 17.05.06? Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 09:28:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 07:28:12 +0000 Subject: [Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 --- Comment #14 from Magnus Enger --- >From looking at the code, it seems that the test plan only covers part of the functionality, that of keeping a record of the actual status of a request. It looks like the new code can also track changes to the other parts of the metadata. Is this correct, and would it be possible to enhance the Dummy or FreeForm backends in such a way that this other functionality could also be tested? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 09:31:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 07:31:45 +0000 Subject: [Koha-bugs] [Bug 20797] If an Ill request has an associated bib record, the detail view should contain a link to the record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |magnus at libriotech.no --- Comment #2 from Magnus Enger --- The "ILL requests" page (with the table of all the requests) also shows the biblionumber, could we not turn that into a link too? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 09:45:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 07:45:25 +0000 Subject: [Koha-bugs] [Bug 20799] New: Add a link from biblio detail view to ILL request detail view, if a biblio has an ILL request Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20799 Bug ID: 20799 Summary: Add a link from biblio detail view to ILL request detail view, if a biblio has an ILL request Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no Depends on: 7317 Bug 20797 adds a link from the ILL module to the biblio detail view of the record associated with an ILL request. A link in the other direction would also be useful: from the standard biblio detail view, to the ILL detail view for the ILL request connected to the biblio record (if there is one). This could take the form of a simple link, or it could be more elaborate, like another tab alongside Holdings, Descriptions and Acq details, to display some ILL data without the need for a click through to the ILL module. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 09:45:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 07:45:25 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20799 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20799 [Bug 20799] Add a link from biblio detail view to ILL request detail view, if a biblio has an ILL request -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 09:45:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 07:45:25 +0000 Subject: [Koha-bugs] [Bug 20797] If an Ill request has an associated bib record, the detail view should contain a link to the record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20799 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 22 09:46:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 07:46:59 +0000 Subject: [Koha-bugs] [Bug 20799] Add a link from biblio detail view to ILL request detail view, if a biblio has an ILL request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20799 --- Comment #1 from Magnus Enger --- *** Bug 18592 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 22 09:46:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 07:46:59 +0000 Subject: [Koha-bugs] [Bug 18592] Link from bib detail view to ILL module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18592 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Magnus Enger --- *** This bug has been marked as a duplicate of bug 20799 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 22 11:21:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 09:21:38 +0000 Subject: [Koha-bugs] [Bug 20386] Improve warning and error messages for Search Engine Configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20386 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS --- Not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 11:23:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 09:23:35 +0000 Subject: [Koha-bugs] [Bug 20455] Can't sort patron search on date expired In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20455 --- Comment #8 from Fridolin SOMERS --- Pushed to 17.05.x for v17.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 11:25:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 09:25:58 +0000 Subject: [Koha-bugs] [Bug 20330] Allow translating more of quote upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20330 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |fridolin.somers at biblibre.co | |m Resolution|--- |FIXED --- Comment #6 from Fridolin SOMERS --- I prefer not to push on 17.05.x since it depends on translation work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 11:28:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 09:28:57 +0000 Subject: [Koha-bugs] [Bug 19673] Patron batch modification tool cannot use authorised value "0" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19673 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin SOMERS --- Pushed to 17.05.x for v17.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 11:31:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 09:31:31 +0000 Subject: [Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Stable |RESOLVED --- Comment #19 from Fridolin SOMERS --- Not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 11:32:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 09:32:33 +0000 Subject: [Koha-bugs] [Bug 20490] Correct wrong bug number in comment in Circulation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20490 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin SOMERS --- Pushed to 17.05.x for v17.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 11:42:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 09:42:51 +0000 Subject: [Koha-bugs] [Bug 20503] Borrower_PrevCheckout.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20503 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #4 from Fridolin SOMERS --- Pushed to 17.05.x for v17.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 11:44:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 09:44:02 +0000 Subject: [Koha-bugs] [Bug 17373] Elasticsearch - Authority mappings for UNIMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17373 Bug 17373 depends on bug 20385, which changed state. Bug 20385 Summary: ElasticSearch authority search raises Software error https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20385 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 11:44:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 09:44:02 +0000 Subject: [Koha-bugs] [Bug 20385] ElasticSearch authority search raises Software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20385 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Stable |RESOLVED --- Comment #14 from Fridolin SOMERS --- Not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 11:44:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 09:44:03 +0000 Subject: [Koha-bugs] [Bug 20509] Data consistency - authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20509 Bug 20509 depends on bug 20385, which changed state. Bug 20385 Summary: ElasticSearch authority search raises Software error https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20385 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 22 11:48:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 09:48:56 +0000 Subject: [Koha-bugs] [Bug 18474] Placing multiple holds from results breaks when patron is searched for In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18474 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #14 from Fridolin SOMERS --- Pushed to 17.05.x for v17.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 11:55:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 09:55:08 +0000 Subject: [Koha-bugs] [Bug 20318] Merge invoices can lead to an merged invoice without Invoice number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20318 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #18 from Fridolin SOMERS --- Pushed to 17.05.x for v17.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 11:55:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 09:55:19 +0000 Subject: [Koha-bugs] [Bug 20318] Merge invoices can lead to an merged invoice without Invoice number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20318 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 11:56:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 09:56:59 +0000 Subject: [Koha-bugs] [Bug 20462] Duplicate barcodes in batch item deletion cause software error if deleting biblio records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20462 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 11:57:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 09:57:37 +0000 Subject: [Koha-bugs] [Bug 20462] Duplicate barcodes in batch item deletion cause software error if deleting biblio records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20462 --- Comment #6 from Fridolin SOMERS --- Pushed to 17.05.x for v17.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 11:58:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 09:58:38 +0000 Subject: [Koha-bugs] [Bug 19907] Email validation on patron add/edit not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19907 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #10 from Fridolin SOMERS --- Depending on Bug 19908 not in 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 12:01:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 10:01:00 +0000 Subject: [Koha-bugs] [Bug 20539] Warnings in catalogue/search.pl need to be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20539 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #5 from Nick Clemens --- Cannot recreate in 17.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 12:01:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 10:01:51 +0000 Subject: [Koha-bugs] [Bug 20369] Analytics search is broken with QueryAutoTruncate set to 'only if * is added' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20369 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin SOMERS --- Pushed to 17.05.x for v17.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 12:02:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 10:02:40 +0000 Subject: [Koha-bugs] [Bug 18007] Interface updates to notices and notice previews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #16 from Nick Clemens --- Enhancement, not backported for 17.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 12:03:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 10:03:10 +0000 Subject: [Koha-bugs] [Bug 11674] Configuration for MARC field doc URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #26 from Nick Clemens --- Enhancement, not backported for 17.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 12:03:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 10:03:32 +0000 Subject: [Koha-bugs] [Bug 20282] Wrong attribute in template calls to match holding branch when adding/editing a course reserve item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20282 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin SOMERS --- Pushed to 17.05.x for v17.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 12:04:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 10:04:55 +0000 Subject: [Koha-bugs] [Bug 19892] Replace numbersphr variable with Koha.Preference('OPACNumbersPreferPhrase') in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19892 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #13 from Fridolin SOMERS --- (In reply to Nick Clemens from comment #12) > Okay, I changed my mind and pushed, not sure how to get back to 'Pushed to > stable' Leave it resolved since I will not push to 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 12:20:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 10:20:46 +0000 Subject: [Koha-bugs] [Bug 19223] Avoid encoding issues in plugins by providing helper methods to output headers correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #20 from Fridolin SOMERS --- Is this for 17.05.x also ? t/db_dependent/Plugins.t is actually OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 12:38:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 10:38:17 +0000 Subject: [Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to pre-process DB fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #20 from Fridolin SOMERS --- Pushed to 17.05.x for v17.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 12:45:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 10:45:46 +0000 Subject: [Koha-bugs] [Bug 19812] Holds count in "Already received" table has confusing and unexpected values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #19 from Fridolin SOMERS --- I prefer not to push to 17.05.x, its minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 12:47:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 10:47:44 +0000 Subject: [Koha-bugs] [Bug 9156] itemcallnumber not pulling more than 2 subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 12:47:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 10:47:37 +0000 Subject: [Koha-bugs] [Bug 9156] itemcallnumber not pulling more than 2 subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC|marjorie.barry-vila at collect | |o.ca | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 12:48:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 10:48:12 +0000 Subject: [Koha-bugs] [Bug 19267] Advanced Editor - Rancor - Add warning before leaving page if there are unsaved modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19267 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #12 from Fridolin SOMERS --- Pushed to 17.05.x for v17.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 12:54:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 10:54:58 +0000 Subject: [Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does not check account_offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #15 from Fridolin SOMERS --- Can you confirm this depends on Bug 14826 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 12:59:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 10:59:05 +0000 Subject: [Koha-bugs] [Bug 20122] Empty and close link on cart page not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20122 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #16 from Fridolin SOMERS --- Pushed to 17.05.x for v17.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 12:59:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 10:59:58 +0000 Subject: [Koha-bugs] [Bug 19581] Elasticsearch - Catmandu split option adds extra null fields to indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19581 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers at biblibre.co | |m --- Comment #23 from Fridolin SOMERS --- Not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 13:02:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 11:02:27 +0000 Subject: [Koha-bugs] [Bug 3841] Add a Default ACQ framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3841 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Stable |RESOLVED --- Comment #17 from Fridolin SOMERS --- Not in 17.05.x -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 13:02:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 11:02:28 +0000 Subject: [Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Bug 19289 depends on bug 3841, which changed state. Bug 3841 Summary: Add a Default ACQ framework https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3841 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 13:04:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 11:04:24 +0000 Subject: [Koha-bugs] [Bug 20552] Fix HTML tag for search facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20552 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin SOMERS --- Pushed to 17.05.x for v17.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 13:05:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 11:05:38 +0000 Subject: [Koha-bugs] [Bug 20536] ILL: authnotrequired not explicitly unset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Stable |RESOLVED --- Comment #12 from Fridolin SOMERS --- Depends on Bug 7317 not in 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 13:05:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 11:05:48 +0000 Subject: [Koha-bugs] [Bug 19546] Make koha-plack run Starman from the instance's directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #25 from Nick Clemens --- Pushed to stable for 17.11.X - had to change the variable from $instance-user to $instancename-koha http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=7963834a937909c59060dec61f8bd930f50af6b0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 13:06:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 11:06:16 +0000 Subject: [Koha-bugs] [Bug 20584] Koha/Patron/Categories.t is on slow servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20584 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #3 from Nick Clemens --- Pushed to stable for 17.11.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 13:06:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 11:06:31 +0000 Subject: [Koha-bugs] [Bug 18725] process_message_queue.pl sends duplicate emails if message_queue is not writable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #34 from Nick Clemens --- Pushed to stable for 17.11.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 13:06:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 11:06:57 +0000 Subject: [Koha-bugs] [Bug 20562] issue_id is not stored in accountlines for rental fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20562 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #18 from Nick Clemens --- Pushed to stable for 17.11.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 13:07:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 11:07:13 +0000 Subject: [Koha-bugs] [Bug 20556] Marking ILL request as complete results in "Internal server error" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20556 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick at bywatersolutions.com --- Comment #8 from Nick Clemens --- Pushed to stable for 17.11.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 13:07:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 11:07:12 +0000 Subject: [Koha-bugs] [Bug 20426] Can't import all titles from a stage file with default values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #12 from Fridolin SOMERS --- Depends on Bug 19453 not in 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 13:07:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 11:07:25 +0000 Subject: [Koha-bugs] [Bug 19030] Link order <-> subscription is lost when an order is edited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19030 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick at bywatersolutions.com --- Comment #20 from Nick Clemens --- Pushed to stable for 17.11.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 13:10:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 11:10:16 +0000 Subject: [Koha-bugs] [Bug 20687] Multiple invitations to share lists prevents some users from accepting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20687 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Nick Clemens --- Pushed to stable for 17.11.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 13:10:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 11:10:29 +0000 Subject: [Koha-bugs] [Bug 11943] Koha::Virtualshelfshare duplicates rows for the same list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #26 from Nick Clemens --- Pushed to stable for 17.11.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 13:13:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 11:13:23 +0000 Subject: [Koha-bugs] [Bug 20721] Circulation.t keeps failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20721 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #4 from Fridolin SOMERS --- Pushed to 17.05.x for v17.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 13:23:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 11:23:25 +0000 Subject: [Koha-bugs] [Bug 20800] New: Keep Koha on Stretch from using broken libhttp-oai-perl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20800 Bug ID: 20800 Summary: Keep Koha on Stretch from using broken libhttp-oai-perl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org CC: mirko at abunchofthings.net libhttp-oai-perl in Stretch is 4.03 and broken. Koha depends on libhttp-oai-perl << 4 for that reason. To make the installation of Koha on Stretch as easy as possible, this patch adds the alternative libhttp-oai-3.27-perl which we provide in the Koha repository. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 22 13:23:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 11:23:45 +0000 Subject: [Koha-bugs] [Bug 20800] Keep Koha on Stretch from using broken libhttp-oai-perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20800 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |mirko at abunchofthings.net |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 13:26:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 11:26:32 +0000 Subject: [Koha-bugs] [Bug 20800] Keep Koha on Stretch from using broken libhttp-oai-perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20800 --- Comment #1 from Mirko Tietgen --- Created attachment 75463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75463&action=edit Bug 20800: Keep Koha on Stretch from using broken libhttp-oai-perl libhttp-oai-perl in Stretch is 4.03 and broken. Koha depends on libhttp-oai-perl << 4 for that reason. To make the installation of Koha on Stretch as easy as possible, this patch adds the alternative libhttp-oai-3.27-perl which we provide in the Koha repository. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 13:26:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 11:26:50 +0000 Subject: [Koha-bugs] [Bug 20800] Keep Koha on Stretch from using broken libhttp-oai-perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20800 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 13:29:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 11:29:06 +0000 Subject: [Koha-bugs] [Bug 20801] New: Make dependency on memcached mandatory Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20801 Bug ID: 20801 Summary: Make dependency on memcached mandatory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org CC: mirko at abunchofthings.net Set memcached as mandatory for package installations. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 22 13:29:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 11:29:40 +0000 Subject: [Koha-bugs] [Bug 20801] Make dependency on memcached mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20801 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |mirko at abunchofthings.net |ity.org | Severity|enhancement |normal See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18342 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 22 13:29:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 11:29:40 +0000 Subject: [Koha-bugs] [Bug 18342] Set memcached as 'enabled' by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18342 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20801 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 13:32:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 11:32:49 +0000 Subject: [Koha-bugs] [Bug 20800] Keep Koha on Stretch from using broken libhttp-oai-perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20800 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 13:49:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 11:49:22 +0000 Subject: [Koha-bugs] [Bug 20801] Make dependency on memcached mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20801 --- Comment #1 from Mirko Tietgen --- Created attachment 75464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75464&action=edit Bug 20801: Make dependency on memcached mandatory Move memcached from suggested to depends for Debian packages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 13:50:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 11:50:24 +0000 Subject: [Koha-bugs] [Bug 20801] Make dependency on memcached mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20801 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Mirko Tietgen --- This also has found another dependency not yet in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 14:50:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 12:50:48 +0000 Subject: [Koha-bugs] [Bug 20802] New: Routing lists versus patron notification emails for serial issues just received. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20802 Bug ID: 20802 Summary: Routing lists versus patron notification emails for serial issues just received. Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: r.delahunty at arts.ac.uk QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com If these are separate features and work independently of each other then I think the terminology relating to the two different functions is mixed up and confusing in Koha. We do not have routing lists enabled so we do not see any of that functionality in our serials module. We have most of the patron notification ?letter? flags in each subscription ticked, so users can (in theory) opt-in to receive email messages via the OPAC. A number of users here have, but zero emails are being sent. It appears that the Patron notification options we see when setting up a subscription refer to Routing List (Notices and Slips ?RLIST). We don?t use the feature? so no emails are sent. We have 900+ subscriptions with the ?opt-in tickbox enabled, but emails don?t get sent. Until we can unravel this problem we want to remove the misleading option- the suggested solution is to use jquery to hide the option on the OPAC for now. Has anyone actually got patron notification working separate from routing list functionality, and if so how? Is routing list functionality somehow intertwined with patron notification? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 14:53:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 12:53:54 +0000 Subject: [Koha-bugs] [Bug 19642] If autoMemberNum is enabled, we should just ignore cardnumber entry in BorrowerMandatoryField In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19642 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 15:03:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 13:03:49 +0000 Subject: [Koha-bugs] [Bug 20801] Make dependency on memcached mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20801 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |18342 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18342 [Bug 18342] Set memcached as 'enabled' by default -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 15:03:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 13:03:49 +0000 Subject: [Koha-bugs] [Bug 18342] Set memcached as 'enabled' by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18342 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20801 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20801 [Bug 20801] Make dependency on memcached mandatory -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 15:11:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 13:11:41 +0000 Subject: [Koha-bugs] [Bug 20757] Capture a screenshot on selenium errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20757 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75287|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 75465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75465&action=edit Bug 20757: Capture and upload screenshot on selenium errors It is a real pain to debug selenium errors, especially when it is not reproducible locally. This patch capture a screenshot when an error occurred and upload it using the excellent lut.im service provided by framasoft (We could host our own later). Test plan: Modify a selenium script to make it fails (search for find_element) You will see a stack trace followed by a link to framapic.org Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 15:11:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 13:11:38 +0000 Subject: [Koha-bugs] [Bug 20757] Capture a screenshot on selenium errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20757 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 15:19:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 13:19:46 +0000 Subject: [Koha-bugs] [Bug 20800] Keep Koha on Stretch from using broken libhttp-oai-perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20800 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 15:19:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 13:19:49 +0000 Subject: [Koha-bugs] [Bug 20800] Keep Koha on Stretch from using broken libhttp-oai-perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20800 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75463|0 |1 is obsolete| | --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 75466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75466&action=edit Bug 20800: Keep Koha on Stretch from using broken libhttp-oai-perl libhttp-oai-perl in Stretch is 4.03 and broken. Koha depends on libhttp-oai-perl << 4 for that reason. To make the installation of Koha on Stretch as easy as possible, this patch adds the alternative libhttp-oai-3.27-perl which we provide in the Koha repository. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 15:20:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 13:20:35 +0000 Subject: [Koha-bugs] [Bug 20801] Make dependency on memcached mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20801 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 15:20:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 13:20:38 +0000 Subject: [Koha-bugs] [Bug 20801] Make dependency on memcached mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20801 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75464|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 75467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75467&action=edit Bug 20801: Make dependency on memcached mandatory Move memcached from suggested to depends for Debian packages. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 15:21:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 13:21:20 +0000 Subject: [Koha-bugs] [Bug 15520] Add more granular permission for only editing own library's circ rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #12 from Nick Clemens --- (In reply to Josef Moravec from comment #10) > This is not the logged in user's home library, it is the library where the > user is logged in now - so when user change library, he/she could change > another's library rules! I (In reply to Katrin Fischer from comment #11) > But couldn't they change the home library in their records too? > I think in general we got a problem there, that you can get around the > limits, maybe the logged-in library is more helpful? I think this should be the user's logged in library - for extra protection I think the library would implement AutoLocation and limit logged in site by ip so this would require some extra steps but would also be a first level guard against accidentally altering other rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 15:26:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 13:26:38 +0000 Subject: [Koha-bugs] [Bug 18421] Make Coce cover images available for staff search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #17 from Owen Leonard --- The QA tool shows some issues with this: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt FAIL forbidden patterns forbidden pattern: Do not use line breaks inside template tags (bug 18675) (line 62) forbidden pattern: Do *not* include full path to js files, use the Asset TT plugin (bug 20538) (line 890) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt FAIL forbidden patterns forbidden pattern: Do not use line breaks inside template tags (bug 18675) (line 25) I notice in results.tt: [% Asset.js("prog/js/coce.js") %] should be [% Asset.js("js/coce.js") %] I'd also like to see this modified to use the term "staff client" instead of "intranet," according to our terminology guidelines: https://wiki.koha-community.org/wiki/Terminology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 15:43:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 13:43:57 +0000 Subject: [Koha-bugs] [Bug 20800] Keep Koha on Stretch from using broken libhttp-oai-perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20800 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 15:44:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 13:44:25 +0000 Subject: [Koha-bugs] [Bug 20801] Make dependency on memcached mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20801 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 16:04:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 14:04:17 +0000 Subject: [Koha-bugs] [Bug 20703] Add ability to void any credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20703 --- Comment #5 from Tom?s Cohen Arazi --- Kyle, the functionality is ok. Would you agree there could be a confirmation modal as we have in other places? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 16:05:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 14:05:33 +0000 Subject: [Koha-bugs] [Bug 20229] Remove problematic SQL modes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20229 --- Comment #7 from Jonathan Druart --- See https://wiki.koha-community.org/wiki/DBMS_configuration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 16:05:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 14:05:39 +0000 Subject: [Koha-bugs] [Bug 20703] Add ability to void any credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20703 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 16:05:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 14:05:44 +0000 Subject: [Koha-bugs] [Bug 20703] Add ability to void any credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20703 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75154|0 |1 is obsolete| | --- Comment #6 from Tom?s Cohen Arazi --- Created attachment 75468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75468&action=edit Bug 20703: Add ability to void any credit At this time, only payments may be voided. There is no reason to have this limitation. There are situations where a librarian may need to void an accidental writeoff, or perhaps void an automatic credit that was created by Koha. For illustration, this is directly from a partner library: "For example a lost book refund becomes a credit on account. Presently the credit may be applied to a fine for a different item charged to patron. We perform a write off to clear the remaining credit, then add the fine back to the account and give the patron a refund for the lost/refunded amount. Our accounting system ask that we keep the Lost funds/refunds separate from all fines." Test Plan: 1) Create a fine and write it off 2) Note there is no 'void' button for the writeoff 3) Apply this patch 4) Note the buttons now show 5) Test each button on a writeoff Signed-off-by: Mark Tompsett Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 16:06:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 14:06:51 +0000 Subject: [Koha-bugs] [Bug 20703] Add ability to void any credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20703 --- Comment #7 from Kyle M Hall --- (In reply to Tom?s Cohen Arazi from comment #5) > Kyle, the functionality is ok. Would you agree there could be a confirmation > modal as we have in other places? A confirmation modal would be a nice enhancement! Are you able to add that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 16:11:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 14:11:37 +0000 Subject: [Koha-bugs] [Bug 20800] Keep Koha on Stretch from using broken libhttp-oai-perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20800 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75466|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 75469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75469&action=edit Bug 20800: Keep Koha on Stretch from using broken libhttp-oai-perl libhttp-oai-perl in Stretch is 4.03 and broken. Koha depends on libhttp-oai-perl << 4 for that reason. To make the installation of Koha on Stretch as easy as possible, this patch adds the alternative libhttp-oai-3.27-perl which we provide in the Koha repository. Signed-off-by: Mark Tompsett Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 16:19:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 14:19:34 +0000 Subject: [Koha-bugs] [Bug 18342] Set memcached as 'enabled' by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18342 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20801 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 16:19:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 14:19:34 +0000 Subject: [Koha-bugs] [Bug 20801] Make dependency on memcached mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20801 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18342 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 16:20:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 14:20:31 +0000 Subject: [Koha-bugs] [Bug 20437] Force requirement for HTTP::OAI 3.27 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20437 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20800 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20800 [Bug 20800] Keep Koha on Stretch from using broken libhttp-oai-perl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 16:20:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 14:20:31 +0000 Subject: [Koha-bugs] [Bug 20800] Keep Koha on Stretch from using broken libhttp-oai-perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20800 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20437 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20437 [Bug 20437] Force requirement for HTTP::OAI 3.27 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 16:21:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 14:21:11 +0000 Subject: [Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72030|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 75470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75470&action=edit Bug 20262: Add ability to refund lost item fees without creating credits Some libraries handle refunding of paid lost fees at a financial office and not within Koha. To facilitate this, it would be good for Koha to have the option to not generate lost returned credits by skipping fully paid lost items, and only refunding the outstanding balance on partially paid lost fees. Test Plan: 1) Apply this patch 2) Set your lost item refund on return policies to 'Only if unpaid' 3) Mark an item lost, charging the lost fee 4) Return the item, a full refund should ocurr 5) Mark another item lost, charging the lost fee 6) Make a partial payment on this lost fee 7) Return the item 8) The remaining balance of that fee should be 0, but the patron should not recieve a credit for the already paid balance 8) Mark another item lost, charging the lost fee 9) Fully pay the lost fee 10) Return the item. The paid lost fee should be unaffected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 16:23:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 14:23:55 +0000 Subject: [Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262 --- Comment #5 from Kyle M Hall --- (In reply to Martha Fuerst from comment #3) > Test Plan: > Notes: > 4) If the patron has other fines, the lost item refund pays those first, as > opposed to just paying the lost item charge. This could be confusing for > staff, but IIRC, there's another bug related to how credits get applied? > 8) Marked an item lost that created a 9.99 charge on patron's account. Paid > 5.00 of it. Returned item. Patron's account was credited 9.99, creating a > 5.00 credit. > 9) Fully paid for item - credit still applied, resulting in a credit on the > account. Martha, it sounds like perhaps the circ rule with "Only if unpaid" did not get selected. Did you set *all* your rules to "Only if unpaid" to ensure you didn't accidentally change the wrong rule? The unit tests prove the functionality works so that's my best guess at what's happening for you. I've also added some more unit tests to prove partially paid lost fees don't cause a credit when the rule is applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 16:24:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 14:24:03 +0000 Subject: [Koha-bugs] [Bug 20800] Keep Koha on Stretch from using broken libhttp-oai-perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20800 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 18.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 16:24:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 14:24:11 +0000 Subject: [Koha-bugs] [Bug 20801] Make dependency on memcached mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20801 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 18.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 16:29:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 14:29:47 +0000 Subject: [Koha-bugs] [Bug 18996] SIP sets ok flag to true for refused checkin for data corruption In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18996 --- Comment #51 from Jonathan Druart --- (In reply to Anna from comment #50) > Can it be applied to 17.05.06? Thanks! It's part of 17.05.x since 17.05.04. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 16:36:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 14:36:25 +0000 Subject: [Koha-bugs] [Bug 20564] Error 500 displays when uploading patron images with a zipped file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 --- Comment #9 from Jonathan Druart --- Then install plack :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 22 16:36:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 14:36:16 +0000 Subject: [Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262 --- Comment #6 from Martha Fuerst --- (In reply to Kyle M Hall from comment #5) > (In reply to Martha Fuerst from comment #3) > > Test Plan: > > Notes: > > 4) If the patron has other fines, the lost item refund pays those first, as > > opposed to just paying the lost item charge. This could be confusing for > > staff, but IIRC, there's another bug related to how credits get applied? > > 8) Marked an item lost that created a 9.99 charge on patron's account. Paid > > 5.00 of it. Returned item. Patron's account was credited 9.99, creating a > > 5.00 credit. > > 9) Fully paid for item - credit still applied, resulting in a credit on the > > account. > > Martha, it sounds like perhaps the circ rule with "Only if unpaid" did not > get selected. Did you set *all* your rules to "Only if unpaid" to ensure you > didn't accidentally change the wrong rule? The unit tests prove the > functionality works so that's my best guess at what's happening for you. > I've also added some more unit tests to prove partially paid lost fees don't > cause a credit when the rule is applied. I have it set as the default rule in our bug-squashing sandbox's Circ Rules table, with no other library-specific rules set. Is there something in sysprefs that might be fouling it up? BlockReturnofLostItems: Don't block RetundLostOnReturnControl: check-in library WhenLostChargeReplacementFee: Charge WhenLostForgiveFine: Don't forgive -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 16:48:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 14:48:19 +0000 Subject: [Koha-bugs] [Bug 20703] Add ability to void any credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20703 --- Comment #8 from Tom?s Cohen Arazi --- Created attachment 75471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75471&action=edit Bug 20703: Add confirmation modal when making a credit void Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 16:50:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 14:50:11 +0000 Subject: [Koha-bugs] [Bug 20703] Add ability to void any credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20703 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 16:50:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 14:50:23 +0000 Subject: [Koha-bugs] [Bug 20703] Add ability to void any credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20703 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 16:50:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 14:50:26 +0000 Subject: [Koha-bugs] [Bug 20703] Add ability to void any credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20703 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75471|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 75472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75472&action=edit Bug 20703: Add confirmation modal when making a credit void Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 17:01:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 15:01:16 +0000 Subject: [Koha-bugs] [Bug 20802] Routing lists versus patron notification emails for serial issues just received. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20802 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Ray, it's a totally separate feature and the terminology mix-up will be resolved with 18.05 Bug 19794 - Rename RLIST - Routing list notice template as it's not related to routing lists For it not sending out emails I think this might be better as a separate bug. There was a problem in some versions a while ago, but not sure if you were affected. Is the type column in your alert table filled? select * from alert; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 22 17:18:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 15:18:49 +0000 Subject: [Koha-bugs] [Bug 3849] Descriptions of acquisition permissions are unclear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3849 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 17:18:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 15:18:51 +0000 Subject: [Koha-bugs] [Bug 3849] Descriptions of acquisition permissions are unclear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3849 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75450|0 |1 is obsolete| | --- Comment #12 from Owen Leonard --- Created attachment 75473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75473&action=edit Bug 3849: Improve descriptions of granular acquisition permissions The permissions for acquisitions were not very clearly described. This patch changes the descriptions in the include file (GUI) and in the default SQL. To test: - Go to any patron account in staff - Go to more > permissions - Verify that the meaning of each acquisition permission is clear from the description Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 17:27:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 15:27:20 +0000 Subject: [Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262 --- Comment #7 from Kyle M Hall --- (In reply to Martha Fuerst from comment #6) > Is there something in sysprefs that might be fouling it up? That looks pretty good, are you sure you are triggering the rule by utilizing the branch chosen from RetundLostOnReturnControl? Basically, if the other refund lost item fee rule options work, then you can switch those rules to "only if unpaid" and it should work. If they do not work it is an issue with your test data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 17:38:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 15:38:38 +0000 Subject: [Koha-bugs] [Bug 11130] Change pl Place-publication index for Marc21 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11130 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin SOMERS --- I note than in UNIMARC pl Place-publication is on 210$a. There is Country-publication on UNIMARC 102$a. Should it be on 008/15-17 ? I see 044$a that could also fit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 17:53:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 15:53:58 +0000 Subject: [Koha-bugs] [Bug 7651] Add separate permission for managing currencies and exchange rates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Owen Leonard --- > 2) parameters > 3) parameters_remaining_permissions > 4) manage_circ_rules, but not parmeters_remaining_permissions Testing these different users, I don't see the acquisitions-related links on the Adminstration home page but I do see them in the sidebar when I view an administration page which I have permission to view. (Not related to this patch, but I see that with only manage_circ_rules set, the user sees the same Administration home page links as the user above even though they only have access to circ rules). > 5) all acquisition permissions Testing with this user has a similar result: The administration sidebar menu shows links I don't have access to. On the other hand, I'm prevented from seeing the Administration home page altogether even though I should be able to reach Acquisitions preferences from there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 18:07:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 16:07:16 +0000 Subject: [Koha-bugs] [Bug 7651] Add separate permission for managing currencies and exchange rates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 --- Comment #8 from Katrin Fischer --- Ah yes, I will make administration start page and administration links in acq consistent! Thx for testing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 18:30:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 16:30:50 +0000 Subject: [Koha-bugs] [Bug 20793] Don't show holds link in result list when staff user doesn't have place_holds permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20793 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75446|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 75474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75474&action=edit Bug 20793: Don't show a holds link in staff for users without permission On the results list in staff the 'Holds (x)' link always shows independent of the permissions of the staff user. This patch tightens the permission checks on the result page to explicitly check for the place_holds permission. To test: - Create a staff user with place_holds permission - Check the result list, you should see 2 links to the holds page: - 'Place holds' on top of the results list - 'Holds (x)' at the bottom of each entry in the results list - Verify both links work - Create a staff user without place_holds_permission - Without the patch you'll see the second link, but it will lead to a permission error - With the patch you'll still see the 'Holds (x)', but it will no longer be a link. - Go to the detail page of a record with an existing hold. - Repeat test with both staff users. - One time the Hold information in the bibliographic information should show as a link, the other time as a simple text. Displaying the information about existing holds still make sense as this is the current beheviour. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 18:30:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 16:30:53 +0000 Subject: [Koha-bugs] [Bug 20793] Don't show holds link in result list when staff user doesn't have place_holds permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20793 --- Comment #3 from Owen Leonard --- Created attachment 75475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75475&action=edit Bug 20793: (follow-up) Add style to the non-link hold count on detail page This small follow-up changes the style on the bibliographic detail page of the hold count so that it looks similar whether it's a link to holds or not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 19:00:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 17:00:08 +0000 Subject: [Koha-bugs] [Bug 20784] Capture more changes in Logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20784 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 19:12:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 17:12:50 +0000 Subject: [Koha-bugs] [Bug 2426] Management permissions is deprecated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 22 19:12:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 17:12:53 +0000 Subject: [Koha-bugs] [Bug 2426] Management permissions is deprecated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75349|0 |1 is obsolete| | --- Comment #9 from Owen Leonard --- Created attachment 75476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75476&action=edit Bug 2426: Remove deprecated management permission After review of the code it turns out that the management permission that has been marked as deprecated a long time ago, does not have any function. The patch removes all remaining code related to it. To test: - Make sure you have a patron with the management permission - Apply patch - Run database update - Check everything still works as expected Bonus: borrowers.flags is recalculated for patrons with management permission. To check: - Create some 'permission twins' with and without management permission - Note the value in borrowers.flags - Apply patch, don't run database update - Save permissions from GUI for one of the twins - Note the newly calculated value - Run database update - Now both twins should have the same borrowers.flags value Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 22 19:20:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 17:20:31 +0000 Subject: [Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 --- Comment #2 from Owen Leonard --- > 6 - Note the column has a tooltip to indicate item vs. record holds I think it would be very helpful if we could have a tooltip on the table cells too: "0 item holds / 3 total holds" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 19:45:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 17:45:43 +0000 Subject: [Koha-bugs] [Bug 20803] New: Cannot search to hold or use print options from API keys interface Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20803 Bug ID: 20803 Summary: Cannot search to hold or use print options from API keys interface Change sponsored?: --- Product: Koha Version: unspecified Hardware: All URL: /cgi-bin/koha/members/apikeys.pl OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: ldjamison at marywood.edu QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Users cannot perform a search to hold or use any print options from the API keys screen. To reproduce: 1. Navigate to Manage API keys page from Patron record > More > Manage api keys 2. Attempt to click search to hold or use any print options -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 22 19:51:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 17:51:46 +0000 Subject: [Koha-bugs] [Bug 20803] Cannot search to hold or use print options from API keys interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20803 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 19:51:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 17:51:48 +0000 Subject: [Koha-bugs] [Bug 20803] Cannot search to hold or use print options from API keys interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20803 --- Comment #1 from Owen Leonard --- Created attachment 75477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75477&action=edit Bug 20803: Cannot search to hold or use print options from API keys interface This patch adds a required JS asset to the patron API key interface. Without it, JS-based functions in the toolbar do not work. To test you must have RESTOAuth2ClientCredentials enabled. - From a patron detail page, choose More -> Manage API keys. - Test the toolbar buttons on this page, especially "Search to hold" and the various print options. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 19:51:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 17:51:58 +0000 Subject: [Koha-bugs] [Bug 20803] Cannot search to hold or use print options from API keys interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20803 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 22 20:01:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 18:01:04 +0000 Subject: [Koha-bugs] [Bug 15520] Add more granular permission for only editing own library's circ rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 --- Comment #13 from Katrin Fischer --- > I (In reply to Katrin Fischer from comment #11) > > But couldn't they change the home library in their records too? > > I think in general we got a problem there, that you can get around the > > limits, maybe the logged-in library is more helpful? > > I think this should be the user's logged in library - for extra protection I > think the library would implement AutoLocation and limit logged in site by > ip so this would require some extra steps but would also be a first level > guard against accidentally altering other rules A lot of the public and smaller libraries here don't have static IP addresses, so AutoLocation is not good. But it's a problem we should solve on this bug report! I think the new permission adds an extra barrier as a good first step and it will prevent people from accidentally editing the wrong library's rules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 20:04:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 18:04:49 +0000 Subject: [Koha-bugs] [Bug 20803] Cannot search to hold or use print options from API keys interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20803 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 20:05:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 18:05:04 +0000 Subject: [Koha-bugs] [Bug 20803] Cannot search to hold or use print options from API keys interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20803 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 20:05:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 18:05:16 +0000 Subject: [Koha-bugs] [Bug 20803] Cannot search to hold or use print options from API keys interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20803 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 20:04:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 18:04:54 +0000 Subject: [Koha-bugs] [Bug 20803] Cannot search to hold or use print options from API keys interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20803 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75477|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 75478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75478&action=edit Bug 20803: Cannot search to hold or use print options from API keys interface This patch adds a required JS asset to the patron API key interface. Without it, JS-based functions in the toolbar do not work. To test you must have RESTOAuth2ClientCredentials enabled. - From a patron detail page, choose More -> Manage API keys. - Test the toolbar buttons on this page, especially "Search to hold" and the various print options. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 20:05:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 18:05:33 +0000 Subject: [Koha-bugs] [Bug 20803] Cannot search to hold or use print options from API keys interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20803 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20568 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 [Bug 20568] Add API key management interface for patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 20:05:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 18:05:33 +0000 Subject: [Koha-bugs] [Bug 20568] Add API key management interface for patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20803 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20803 [Bug 20803] Cannot search to hold or use print options from API keys interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 20:42:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 18:42:03 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #149 from David Bourgault --- Created attachment 75479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75479&action=edit Bug 17015: Improve stability for very old loans This patch fixes a crash when calculating fines for hourly loans created before the earliest date in the 'discrete_calendar' table. The SQL call has been altered to find the closest day (using DATEDIFF). QA Green. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 21:42:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 19:42:48 +0000 Subject: [Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 David Bourgault changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73353|0 |1 is obsolete| | Attachment #73354|0 |1 is obsolete| | Attachment #73355|0 |1 is obsolete| | --- Comment #22 from David Bourgault --- Created attachment 75480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75480&action=edit Bug 17983: Add minute loans Rebased patch: + Adds minute loans logic to DiscreteCalendar + Enables minutes loans in Koha code + Adds tests for minute loans -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 22 21:51:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 19:51:07 +0000 Subject: [Koha-bugs] [Bug 20685] Modify letter template does not render incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20685 --- Comment #5 from Barton Chittenden --- Can we get this backported? I'm editing the slip in question, and it's causing all sorts of inconvenience. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 00:04:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 22:04:35 +0000 Subject: [Koha-bugs] [Bug 20791] Correct capitalization on 'Notices and slips' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20791 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 00:04:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 22:04:38 +0000 Subject: [Koha-bugs] [Bug 20791] Correct capitalization on 'Notices and slips' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20791 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75445|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 75481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75481&action=edit Bug 20791: Correct capitalization on 'Notices & slips' page - Standardizes spelling to 'Notices & slips' Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 00:09:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 22:09:13 +0000 Subject: [Koha-bugs] [Bug 20795] koha-rebuild-zebra should pass through increased verbosity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20795 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- WOAH! That's massive. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 23 00:09:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 22:09:53 +0000 Subject: [Koha-bugs] [Bug 20795] koha-rebuild-zebra should pass through increased verbosity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20795 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 00:09:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 22:09:56 +0000 Subject: [Koha-bugs] [Bug 20795] koha-rebuild-zebra should pass through increased verbosity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20795 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75449|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 75482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75482&action=edit Bug 20795: Pass incrreased verbosity to zebra rebuild script To test: 1 - Run koha-rebuild-zebra with multiple '-v' 2 - Note no increased verbosity 3 - Apply patch 4 - Run the updated koha-rebuild-zebra script with multiple '-v' 5 - Note increased verbosity Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 23 00:22:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 22:22:31 +0000 Subject: [Koha-bugs] [Bug 20520] Re-indent moremember.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from M. Tompsett --- Conflicts. Please fix, and I'll retest. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 01:22:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 May 2018 23:22:43 +0000 Subject: [Koha-bugs] [Bug 20685] Modify letter template does not render correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20685 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Modify letter template does |Modify letter template does |not render incorrectly |not render correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 07:00:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 05:00:53 +0000 Subject: [Koha-bugs] [Bug 19546] Make koha-plack run Starman from the instance's directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #26 from Fridolin SOMERS --- I this also for 17.05.x ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 07:04:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 05:04:58 +0000 Subject: [Koha-bugs] [Bug 19176] Dates comparison fails on slow server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20584 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20584 [Bug 20584] Koha/Patron/Categories.t is on slow servers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 07:04:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 05:04:58 +0000 Subject: [Koha-bugs] [Bug 20584] Koha/Patron/Categories.t is on slow servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20584 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19176 CC| |fridolin.somers at biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 [Bug 19176] Dates comparison fails on slow server -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 07:05:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 05:05:34 +0000 Subject: [Koha-bugs] [Bug 19176] Dates comparison fails on slow server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 07:05:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 05:05:35 +0000 Subject: [Koha-bugs] [Bug 20584] Koha/Patron/Categories.t is on slow servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20584 Bug 20584 depends on bug 19176, which changed state. Bug 19176 Summary: Dates comparison fails on slow server https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 07:06:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 05:06:21 +0000 Subject: [Koha-bugs] [Bug 20584] Koha/Patron/Categories.t is on slow servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20584 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #4 from Fridolin SOMERS --- I prefer not to push to this one and Bug 19176 on 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 07:15:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 05:15:43 +0000 Subject: [Koha-bugs] [Bug 18725] process_message_queue.pl sends duplicate emails if message_queue is not writable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #35 from Fridolin SOMERS --- Pushed to 17.05.x for v17.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 07:19:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 05:19:58 +0000 Subject: [Koha-bugs] [Bug 20562] issue_id is not stored in accountlines for rental fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20562 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #19 from Fridolin SOMERS --- Patches does not apply on 17.05.x. Since its an important impact, I prefer not to rebase myself. Could you provide rebased patches ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 07:22:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 05:22:35 +0000 Subject: [Koha-bugs] [Bug 20556] Marking ILL request as complete results in "Internal server error" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20556 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin SOMERS --- Depends on Bug 7317 not in 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 07:22:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 05:22:43 +0000 Subject: [Koha-bugs] [Bug 20556] Marking ILL request as complete results in "Internal server error" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20556 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 07:26:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 05:26:01 +0000 Subject: [Koha-bugs] [Bug 19030] Link order <-> subscription is lost when an order is edited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19030 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #21 from Fridolin SOMERS --- Pushed to 17.05.x for v17.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 07:29:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 05:29:15 +0000 Subject: [Koha-bugs] [Bug 20687] Multiple invitations to share lists prevents some users from accepting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20687 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #13 from Fridolin SOMERS --- Pushed to 17.05.x for v17.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 07:31:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 05:31:19 +0000 Subject: [Koha-bugs] [Bug 11943] Koha::Virtualshelfshare duplicates rows for the same list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #27 from Fridolin SOMERS --- Pushed to 17.05.x for v17.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 07:54:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 05:54:55 +0000 Subject: [Koha-bugs] [Bug 20804] New: Sanitize input of timeout syspref Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20804 Bug ID: 20804 Summary: Sanitize input of timeout syspref Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: pablo.bianchi at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com I naively change timeout syspref from default "1d" to "2h". I get logout immediatly, and after login again, at the first clic I was logged out again, with any user, even with koha_instance. plack-error.log Use of uninitialized value $lasttime in numeric lt (<) at /usr/share/koha/lib/C4/Auth.pm line 1425. Argument "2h" isn't numeric in subtraction (-) at /usr/share/koha/lib/C4/Auth.pm line 1425. Argument "2h" isn't numeric in subtraction (-) at /usr/share/koha/lib/C4/Auth.pm line 862. I was back again with via sql update (value='1d') and flushing memcached. I suggest: - Don't been possible to input an invalid input on timeout (well, on any, but for the moment on this one). m/^[0-9]*[dD]?$/ - This syspref (maybe others also) shouldn't apply to koha_instance user (God shouldn't be able to microwave a burrito so hot he himself couldn't eat it). Would be great 30m and 2h for minutes and hours, but that should be other bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 23 11:16:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 09:16:35 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #38 from Alex Arnaud --- (In reply to David Gustafsson from comment #37) > Created attachment 75458 [details] [review] > Change search field weight field to decimal and add column declaration to > DBIx results source Hello David, You provide changes on Koha/Schema/Result/SearchField.pm. This should be done in a dedicated patch. RM will ignore it. Also, you replaced the input type number with a input text. This cause errors when typing non-numeric characters in. You can use a input number with step=0.1 to increment decimal numbers. Need to fail QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 12:33:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 10:33:18 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #39 from Katrin Fischer --- (In reply to Alex Arnaud from comment #38) > (In reply to David Gustafsson from comment #37) > > Created attachment 75458 [details] [review] [review] > > Change search field weight field to decimal and add column declaration to > > DBIx results source > > Hello David, > > You provide changes on Koha/Schema/Result/SearchField.pm. This should be > done in a dedicated patch. RM will ignore it. > > Also, you replaced the input type number with a input text. This cause > errors when typing non-numeric characters in. You can use a input number > with step=0.1 to increment decimal numbers. > > Need to fail QA Input number for decimals can be problematic for translations in my experience. Please test for example with de-DE if the value is correctly stored (it will force a decimal comma instead of . on input, which is inconsistent with our other input fields right now) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 13:07:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 11:07:53 +0000 Subject: [Koha-bugs] [Bug 20797] If an Ill request has an associated bib record, the detail view should contain a link to the record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 --- Comment #3 from Martin Renvoize --- Totally.. not sure how I missed it.. tunnel vision. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 13:31:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 11:31:28 +0000 Subject: [Koha-bugs] [Bug 20797] If an Ill request has an associated bib record, the detail view should contain a link to the record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75454|0 |1 is obsolete| | --- Comment #4 from Andrew Isherwood --- Created attachment 75485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75485&action=edit Bug 20797 - Add link to biblio detail view from ILL detail view -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 23 13:32:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 11:32:02 +0000 Subject: [Koha-bugs] [Bug 20797] If an Ill request has an associated bib record, the detail view should contain a link to the record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.isherwood at ptfs-europ | |e.com Status|Failed QA |Needs Signoff --- Comment #5 from Andrew Isherwood --- Hi Magus - Latest attachment addresses this. Thanks for the feedback :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 23 14:13:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 12:13:49 +0000 Subject: [Koha-bugs] [Bug 20805] New: Update child to adult patron process broken on several patron-related pages Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20805 Bug ID: 20805 Summary: Update child to adult patron process broken on several patron-related pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Because of code missing from templates and Perl scripts, the "Update child to adult patron" process is not working correctly on several pages: Broken altogether: - Batch check out If multiple adult patron categories are configured, the "update child" process should trigger a pop-up where the user can choose a category. On these pages the pop-up isn't being triggered, and the process results in an error. - Notices - Statistics - Files - Housebound -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 14:23:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 12:23:32 +0000 Subject: [Koha-bugs] [Bug 20797] If an Ill request has an associated bib record, the detail view should contain a link to the record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 23 14:23:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 12:23:35 +0000 Subject: [Koha-bugs] [Bug 20797] If an Ill request has an associated bib record, the detail view should contain a link to the record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75485|0 |1 is obsolete| | --- Comment #6 from Magnus Enger --- Created attachment 75486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75486&action=edit Bug 20797 - Add link to biblio detail view from ILL detail view Signed-off-by: Magnus Enger Tested thusly: - Make sure there are a couple of ILL requests with biblionumber - Apply the patch - Go to "List requests" page - Biblionumber is now a link, clicking on it leads to the detail view of the biblio - Go to "Manage request" - Biblionumber is a link here too, clicking on it leads to detail view -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 14:28:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 12:28:15 +0000 Subject: [Koha-bugs] [Bug 20607] Elasticsearch - ability to add a relevancy weight in mappings.yaml file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 14:31:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 12:31:31 +0000 Subject: [Koha-bugs] [Bug 20805] Update child to adult patron process broken on several patron-related pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20805 --- Comment #1 from Owen Leonard --- The latter issue is also present with the patron deletion confirmation page (deletemem.pl). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 14:41:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 12:41:24 +0000 Subject: [Koha-bugs] [Bug 15520] Add more granular permission for only editing own library's circ rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 --- Comment #14 from Katrin Fischer --- it's NOT a problem we should solve here... (sorry, typo) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 14:42:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 12:42:36 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #40 from David Gustafsson --- (In reply to Alex Arnaud from comment #38) > (In reply to David Gustafsson from comment #37) > > Created attachment 75458 [details] [review] [review] > > Change search field weight field to decimal and add column declaration to > > DBIx results source > > Hello David, > > You provide changes on Koha/Schema/Result/SearchField.pm. This should be > done in a dedicated patch. RM will ignore it. > > Also, you replaced the input type number with a input text. This cause > errors when typing non-numeric characters in. You can use a input number > with step=0.1 to increment decimal numbers. > > Need to fail QA Ok, I can fix this, though precision should be 0.01 in that case. There is server side validation, so everything that is not a number will be ignored regardless of input type. I was not aware that Koha/Schema/Result/* files should not be changed. How does that work for signing off, since without the change Koha will throw an error when trying to save weights in admin UI? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 14:42:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 12:42:18 +0000 Subject: [Koha-bugs] [Bug 19604] Elasticsearch Fixes for build_authorities_query for auth searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 14:45:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 12:45:23 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #41 from Nick Clemens --- (In reply to David Gustafsson from comment #40) > (In reply to Alex Arnaud from comment #38) > > (In reply to David Gustafsson from comment #37) > > > Created attachment 75458 [details] [review] [review] [review] > > > Change search field weight field to decimal and add column declaration to > > > DBIx results source > > > > Hello David, > > > > You provide changes on Koha/Schema/Result/SearchField.pm. This should be > > done in a dedicated patch. RM will ignore it. > > > > Also, you replaced the input type number with a input text. This cause > > errors when typing non-numeric characters in. You can use a input number > > with step=0.1 to increment decimal numbers. > > > > Need to fail QA > > Ok, I can fix this, though precision should be 0.01 in that case. There is > server side validation, so everything that is not a number will be ignored > regardless of input type. > > I was not aware that Koha/Schema/Result/* files should not be changed. How > does that work for signing off, since without the change Koha will throw an > error when trying to save weights in admin UI? Generally you make your code changes, commit the patches, then run: misc/devel/update_dbix_class_files.pl And commit those as their own patch - that way the changes are included for testers but can be regenerated when pushing to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 14:47:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 12:47:52 +0000 Subject: [Koha-bugs] [Bug 15520] Add more granular permission for only editing own library's circ rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 14:54:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 12:54:11 +0000 Subject: [Koha-bugs] [Bug 20805] Update child to adult patron process broken on several patron-related pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20805 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 14:54:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 12:54:14 +0000 Subject: [Koha-bugs] [Bug 20805] Update child to adult patron process broken on several patron-related pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20805 --- Comment #2 from Owen Leonard --- Created attachment 75487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75487&action=edit Bug 20805: Update child to adult patron process broken on several patron-related pages This patch fixes a problem with several patron-related pages, where the "Update child to adult patron" menu item doesn't work. With some pages, the right category information wasn't being passed from the script to the template. With some, the right JavaScript variable weren't being passed from the template to the included JavaScript file. To test, apply the patch locate some patrons with "child" type patron categories. With each patron, go to one of the following pages and test the "update child" process in the toolbar's "More" menu. - Circulation -> - Batch check out - Notices - Statistics - Files - Housebound - Delete (test from the deletion confirmation screen). All test should be performed on a system with multiple adult patron categories configured AND on a system with only a single adult patron category. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 15:12:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 13:12:09 +0000 Subject: [Koha-bugs] [Bug 20520] Re-indent moremember.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 15:12:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 13:12:12 +0000 Subject: [Koha-bugs] [Bug 20520] Re-indent moremember.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75432|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 75488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75488&action=edit Bug 20520: Re-indent moremember.tt This patch reindents the template for the patron detail page, moremember.tt: - Trailing spaces removed - Indentation changed to a consistent 4 spaces - Markup indentation made more consistent To test, view the patron detail page. There should be no visible difference before and after the applying the patch. HTML validation before and after the patch should return the same results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 15:24:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 13:24:48 +0000 Subject: [Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 --- Comment #15 from Andrew Isherwood --- Hi Magnus - Thanks for looking at this. Currently, all this code does is log status changes. I can see how you might have thought that other stuff was being logged as, in addition to logging during ->status calls, we also have potential logging during a ->store call. This was to catch the case where a status was being set directly in a ->store call, e.g. ->store({ status => 'REQ' }) Which obviously wouldn't have been caught by the logger in the status method. So, there is potential to log other "things" during the ->store call, but currently we don't. It is easily added by adding a new element to the Koha::ILLRequest::Logger $loggers class property: $self->{loggers} = { status => sub { $self->log_status_change(@_); } }; [...] sub log_maybe { my ($self, $req, $attrs) = @_; if (defined $req && defined $attrs) { foreach my $key (keys %{ $attrs }) { if (defined($self->{loggers}->{$key})) { $self->{loggers}->{$key}($req, $attrs->{$key}); } } } } [...] sub log_status_change { my ( $self, $req, $new_status ) = @_; $self->set_data({ actionname => 'STATUS_CHANGE', objectnumber => $req->id, infos => to_json({ log_origin => 'core', status_before => $req->{previous_status}, status_after => $new_status }) }); $self->log_something(); } As you can see, currently it says "if we get a call to $request->store and the thing we're storing contains a 'status' property, log the value of it" We also provide display templates for when it comes to displaying that stored "thing" back to the user. I *have* added a call to the logger in the BLDSS backend whenever an API request is sent to the BLDSS status check endpoint. It's a very simple addition and can be seen here: https://github.com/PTFS-Europe/BLDSS-backend/commit/40a4ccdce6e04293970258797d7a0c4fcb33ff32 I hope this helps :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 15:37:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 13:37:09 +0000 Subject: [Koha-bugs] [Bug 20584] Koha/Patron/Categories.t is failing on slow servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20584 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha/Patron/Categories.t is |Koha/Patron/Categories.t is |on slow servers |failing on slow servers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 15:38:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 13:38:12 +0000 Subject: [Koha-bugs] [Bug 20584] Koha/Patron/Categories.t is failing on slow servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20584 --- Comment #5 from Jonathan Druart --- (In reply to Fridolin SOMERS from comment #4) > I prefer not to push to this one and Bug 19176 on 17.05.x Why that? It only affects tests and will prevent random failures. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 15:42:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 13:42:47 +0000 Subject: [Koha-bugs] [Bug 20806] New: Column settings issues for holdshistory-table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Bug ID: 20806 Summary: Column settings issues for holdshistory-table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: severine.queune at bulac.fr QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com There is 2 display issues with the table "Holds history" tab : - no change when modifying "Column settings > Patrons > (id=holdshistory-table)". I don't know if it is linked, but the on the tab is "table_holdshistory". - column "Item type" is always empty -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 15:52:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 13:52:57 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #42 from Alex Arnaud --- (In reply to Katrin Fischer from comment #39) > Input number for decimals can be problematic for translations in my > experience. Please test for example with de-DE if the value is correctly > stored (it will force a decimal comma instead of . on input, which is > inconsistent with our other input fields right now) I just tried on a Koha translated into German. Sounds that there no problem with the values stored. Any test plan to reproduice issue you talked about? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 15:59:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 13:59:15 +0000 Subject: [Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 15:59:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 13:59:19 +0000 Subject: [Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75321|0 |1 is obsolete| | --- Comment #3 from S?verine Queune --- Created attachment 75489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75489&action=edit Bug 19490: Add a 'Holds' column to the items batchmodification tool To test: 1 - Add some items to bathc modification 2 - Note there is no indication fo holds 3 - Apply patch 4 - Reload and note you can see how many holds (or none) 5 - Note you can hide this column with css: #batchMod-edit .holds_count { display: none; } 6 - Note the column has a tooltip to indicate item vs. record holds Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 15:59:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 13:59:25 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #43 from David Gustafsson --- Created attachment 75490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75490&action=edit Update Koha/Schema/Result/SearchField.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:00:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:00:33 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #44 from David Gustafsson --- (In reply to Katrin Fischer from comment #39) > (In reply to Alex Arnaud from comment #38) > > (In reply to David Gustafsson from comment #37) > > > Created attachment 75458 [details] [review] [review] [review] > > > Change search field weight field to decimal and add column declaration to > > > DBIx results source > > > > Hello David, > > > > You provide changes on Koha/Schema/Result/SearchField.pm. This should be > > done in a dedicated patch. RM will ignore it. > > > > Also, you replaced the input type number with a input text. This cause > > errors when typing non-numeric characters in. You can use a input number > > with step=0.1 to increment decimal numbers. > > > > Need to fail QA > > Input number for decimals can be problematic for translations in my > experience. Please test for example with de-DE if the value is correctly > stored (it will force a decimal comma instead of . on input, which is > inconsistent with our other input fields right now) Now updated the patch with requested changes. Also tried with German translation and worked for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:01:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:01:04 +0000 Subject: [Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr --- Comment #4 from S?verine Queune --- That's interesting ! Works fine for me. A detail about css hiding : I had to use #tools_batchMod-edit .holds_count { display: none; } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:04:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:04:00 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #45 from David Gustafsson --- (In reply to Nick Clemens from comment #41) > Generally you make your code changes, commit the patches, then run: > misc/devel/update_dbix_class_files.pl > And commit those as their own patch - that way the changes are included for > testers but can be regenerated when pushing to master Thanks for clarifying this, now I understand how to go about it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:05:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:05:35 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:07:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:07:21 +0000 Subject: [Koha-bugs] [Bug 20772] Bib metadata pertaining to an ILL request should be editable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772 --- Comment #1 from Andrew Isherwood --- Created attachment 75491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75491&action=edit Bug 20772: Add 'illrequestattributes.readonly' This patch adds a 'readonly' column to illrequestattributes. On a DB upgrade it also populates all existing rows with 1, indicating 'read only' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:07:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:07:31 +0000 Subject: [Koha-bugs] [Bug 20772] Bib metadata pertaining to an ILL request should be editable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772 --- Comment #2 from Andrew Isherwood --- Created attachment 75492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75492&action=edit Bug 20772: Add 'illrequest.price_paid' This patch adds a 'price_paid' column to 'illrequests' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:07:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:07:41 +0000 Subject: [Koha-bugs] [Bug 20772] Bib metadata pertaining to an ILL request should be editable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772 --- Comment #3 from Andrew Isherwood --- Created attachment 75493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75493&action=edit Bug 20772: DO NOT PUSH - Schema update Schema update for illrequestattributes.readonly Schema update for illrequests.price_paid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:07:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:07:50 +0000 Subject: [Koha-bugs] [Bug 20772] Bib metadata pertaining to an ILL request should be editable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772 --- Comment #4 from Andrew Isherwood --- Created attachment 75494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75494&action=edit Bug 20772: Borrowernumber should be read only On the Manage Request page, borrowernumber should be read only, we do not want users modifying the destination user once a request is placed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:08:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:08:01 +0000 Subject: [Koha-bugs] [Bug 20772] Bib metadata pertaining to an ILL request should be editable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772 --- Comment #5 from Andrew Isherwood --- Created attachment 75495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75495&action=edit Bug 20772: Fix malformed class name Supplier metadata elements have a dynamically formed class name, part of the name is formed from the metadata key, this breaks if the key has a space, so we replace spaces -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:08:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:08:10 +0000 Subject: [Koha-bugs] [Bug 20772] Bib metadata pertaining to an ILL request should be editable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772 --- Comment #6 from Andrew Isherwood --- Created attachment 75496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75496&action=edit Bug 20772: Return cost & price_paid in API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:08:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:08:20 +0000 Subject: [Koha-bugs] [Bug 20772] Bib metadata pertaining to an ILL request should be editable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772 --- Comment #7 from Andrew Isherwood --- Created attachment 75497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75497&action=edit Bug 20772: Display and edit of price_paid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:10:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:10:21 +0000 Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:10:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:10:39 +0000 Subject: [Koha-bugs] [Bug 20756] OPAC "Share list" button should be styled with an icon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:10:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:10:42 +0000 Subject: [Koha-bugs] [Bug 20756] OPAC "Share list" button should be styled with an icon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75312|0 |1 is obsolete| | --- Comment #3 from S?verine Queune --- Created attachment 75498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75498&action=edit Bug 20756: OPAC "Share list" button should be styled with an icon This patch adds a new "share" icon to the sprite image used to style controls in the OPAC. The "share list" links now have a "sharelist" class which is used to style the links with the new icon. Also changed: Fixed the page structure markup of opac-shareshelf.tt. To test you must have the OpacAllowSharingPrivateLists system preference enabled. - Log in to the OPAC and go to Lists -> Your lists. - Create one or more private lists if necessary. - In the table of your lists there should be a "Share" link with the new icon. - View one of these lists and confirm that the "Share" link at the top of the table of list items. - Click through to the share list page and confirm that the page looks correct. Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:10:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:10:45 +0000 Subject: [Koha-bugs] [Bug 20756] OPAC "Share list" button should be styled with an icon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75313|0 |1 is obsolete| | --- Comment #4 from S?verine Queune --- Created attachment 75499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75499&action=edit Bug 20756: Compiled CSS This patch contains the compiled CSS file Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:12:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:12:04 +0000 Subject: [Koha-bugs] [Bug 20520] Re-indent moremember.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 --- Comment #4 from M. Tompsett --- Was there any real benefit to changing HTML comments to Template Toolkit comments? Nasty /div mismatches in some cases, as far as I could read. Also, layering issues with things not nested properly. Indentation really cleaned this up nicely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:11:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:11:46 +0000 Subject: [Koha-bugs] [Bug 20756] OPAC "Share list" button should be styled with an icon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr --- Comment #5 from S?verine Queune --- Seems good to me on all pages. Thanks Owen ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:16:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:16:29 +0000 Subject: [Koha-bugs] [Bug 20520] Re-indent moremember.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:16:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:16:32 +0000 Subject: [Koha-bugs] [Bug 20520] Re-indent moremember.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75488|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 75500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75500&action=edit Bug 20520: Re-indent moremember.tt This patch reindents the template for the patron detail page, moremember.tt: - Trailing spaces removed - Indentation changed to a consistent 4 spaces - Markup indentation made more consistent To test, view the patron detail page. There should be no visible difference before and after the applying the patch. HTML validation before and after the patch should return the same results. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:18:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:18:12 +0000 Subject: [Koha-bugs] [Bug 20520] Re-indent moremember.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 --- Comment #6 from Owen Leonard --- (In reply to M. Tompsett from comment #4) > Was there any real benefit to changing HTML comments to Template Toolkit > comments? The comments are for people editing the template, so there's not any reason to add to the file size of the generated HTML by outputting them there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:30:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:30:48 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #48 from David Gustafsson --- Ok! MARCXML is still the default format, so previous behaviour is maintained if preference is left as is. The performance difference was also as big as hoped on the whole, so the largest benefit might be smaller index. I could remove it though quite confident it does not introduces any new bugs. Also I accidentally removed you sign off, but since have changed some things since then perhaps best to sign off again in that case. What I should have done is add the new changes as new commits, but wanted a clean diff to make it easier to review as a single unit, but in this case new commits would probably have been better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:31:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:31:33 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #49 from David Gustafsson --- Missed a word, should be: "The performance difference was also _not_ as big" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:32:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:32:02 +0000 Subject: [Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75470|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 75503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75503&action=edit Bug 20262: Add ability to refund lost item fees without creating credits Some libraries handle refunding of paid lost fees at a financial office and not within Koha. To facilitate this, it would be good for Koha to have the option to not generate lost returned credits by skipping fully paid lost items, and only refunding the outstanding balance on partially paid lost fees. Test Plan: 1) Apply this patch 2) Set your lost item refund on return policies to 'Only if unpaid' 3) Mark an item lost, charging the lost fee 4) Return the item, a full refund should ocurr 5) Mark another item lost, charging the lost fee 6) Make a partial payment on this lost fee 7) Return the item 8) The remaining balance of that fee should be 0, but the patron should not recieve a credit for the already paid balance 8) Mark another item lost, charging the lost fee 9) Fully pay the lost fee 10) Return the item. The paid lost fee should be unaffected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:32:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:32:18 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:33:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:33:29 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #46 from Katrin Fischer --- (In reply to Alex Arnaud from comment #42) > (In reply to Katrin Fischer from comment #39) > > > Input number for decimals can be problematic for translations in my > > experience. Please test for example with de-DE if the value is correctly > > stored (it will force a decimal comma instead of . on input, which is > > inconsistent with our other input fields right now) > > I just tried on a Koha translated into German. Sounds that there no problem > with the values stored. Any test plan to reproduice issue you talked about? The problem we had was that it forced you to enter decimal values with comma but Koha didn't undertand them and then truncated the value. 1,1 = 1. This happened in fines in an older version, some more info here: Bug 17098 - Validation problems with form field type "number" (decimal separator) We are still using the patch described there. It might depend on the browser and version you use and will only appear if the template language is one that uses decimal commas. But what remains, I think, is a problem of consistency. Having some inputs ask for comma and others for . is confusing to libraries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:36:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:36:04 +0000 Subject: [Koha-bugs] [Bug 20779] Style refresh for patron detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:36:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:36:07 +0000 Subject: [Koha-bugs] [Bug 20779] Style refresh for patron detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75436|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 75504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75504&action=edit Bug 20779: Style refresh for patron detail page This patch makes style and markup changes to the patron detail page template in order to make the display of information somewhat more compact and to increase the visibility of the edit controls. To test you should enable the patronimages system preference. Apply the patch and view the detail page for a patron. - Check that the page looks correct and that sections like "Alternate address" and "Alternative contact" are empty when there is no data. - Check that the "Manage patron image" tool works correctly. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:45:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:45:28 +0000 Subject: [Koha-bugs] [Bug 20778] Unable to delete a subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #2 from sandboxes at biblibre.com --- Patch tested with a sandbox, by S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:45:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:45:42 +0000 Subject: [Koha-bugs] [Bug 20778] Unable to delete a subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75429|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:45:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:45:49 +0000 Subject: [Koha-bugs] [Bug 20778] Unable to delete a subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 --- Comment #3 from sandboxes at biblibre.com --- Created attachment 75505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75505&action=edit Bug 20778: Fix subscription deletion. Also remove the first confirmation pop because we have another one. Test plan: - go to a subscription detail page, - click on edit -> delete subscription, - confirm deletion, - check that the subscription is no longer here Signed-off-by: S?verine QUEUNE Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:47:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:47:33 +0000 Subject: [Koha-bugs] [Bug 20778] Unable to delete a subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr --- Comment #4 from S?verine Queune --- I never noticed that point before :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 16:54:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 14:54:38 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #50 from Ere Maijala --- I'll review as soon as possible. Regarding the format of the full record, there are some other options that might be worth considering: - Store as JSON making it possible to do advanced MARC queries - Don't store the full record but get it from the database. There are obvious downsides but also upsides to this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 18:07:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 16:07:20 +0000 Subject: [Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr --- Comment #9 from S?verine Queune --- All behaviours are correct (the bonus one too !). I just wondered about this setting : any acquisition permission except suggestions_manage : "Suggestions" link on acqui-home side menu is hidden, shouldn't it be the same for the "Manage suggestions" link on the "Pending suggestions" frame ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 18:30:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 16:30:58 +0000 Subject: [Koha-bugs] [Bug 20774] Trivial HTML error in itemslost.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774 --- Comment #2 from M. Tompsett --- Comment on attachment 75392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75392 Bug 20774: Trivial HTML error in itemslost.tt Review of attachment 75392: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20774&attachment=75392) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt @@ -87,4 @@ > > > Oh my! Good catch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 18:37:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 16:37:16 +0000 Subject: [Koha-bugs] [Bug 20774] Trivial HTML error in itemslost.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett ---
? | Select all |? Clear all? ? | Actions:? ? Export selected items? ? ?
? There's a stray /a in this section. Could you fix this too? I'll leave the text/javascripts for another bug. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 19:06:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 17:06:45 +0000 Subject: [Koha-bugs] [Bug 20774] Trivial HTML error in itemslost.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774 --- Comment #4 from Owen Leonard --- (In reply to M. Tompsett from comment #3) > There's a stray /a in this section. Could you fix this too? I'll leave the > text/javascripts for another bug. :) This seems to be a symptom of a larger problem with the export feature which I'll try to address in a separate bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 19:14:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 17:14:07 +0000 Subject: [Koha-bugs] [Bug 20774] Trivial HTML error in itemslost.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774 --- Comment #5 from M. Tompsett --- (In reply to Owen Leonard from comment #4) > (In reply to M. Tompsett from comment #3) > > There's a stray /a in this section. Could you fix this too? I'll leave the > > text/javascripts for another bug. :) > > This seems to be a symptom of a larger problem with the export feature which > I'll try to address in a separate bug. Having just retested with a CSV profile defined from Tools, and rechecking the page, I see what you are talking about. Another bug it is, no sense scope creeping. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 19:14:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 17:14:55 +0000 Subject: [Koha-bugs] [Bug 20774] Trivial HTML error in itemslost.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 19:14:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 17:14:57 +0000 Subject: [Koha-bugs] [Bug 20774] Trivial HTML error in itemslost.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75392|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Created attachment 75508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75508&action=edit Bug 20774: Trivial HTML error in itemslost.tt This patch makes a minor correction to the markup of the lost items report template. To test, apply the patch and run the lost items report with parameters which will return results. The report results should look correct, and the page should validate with no relevant errors. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 19:30:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 17:30:40 +0000 Subject: [Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262 --- Comment #9 from Martha Fuerst --- (In reply to Kyle M Hall from comment #7) > (In reply to Martha Fuerst from comment #6) > > Is there something in sysprefs that might be fouling it up? > > That looks pretty good, are you sure you are triggering the rule by > utilizing the branch chosen from RetundLostOnReturnControl? > > Basically, if the other refund lost item fee rule options work, then you can > switch those rules to "only if unpaid" and it should work. If they do not > work it is an issue with your test data. Gotcha. Tested again after you took a look at my settings (thanks Kyle!) - Test Plan: 1) Apply this patch 2) Set your lost item refund on return policies to 'Only if unpaid' 3) Mark an item lost, charging the lost fee 4) Return the item, a full refund should ocurr 5) Mark another item lost, charging the lost fee 6) Make a partial payment on this lost fee 7) Return the item 8) The remaining balance of that fee should be 0, but the patron should not recieve a credit for the already paid balance 8) Mark another item lost, charging the lost fee 9) Fully pay the lost fee 10) Return the item. The paid lost fee should be unaffected. Everything worked as it should - signing off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 19:39:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 17:39:49 +0000 Subject: [Koha-bugs] [Bug 20692] koha-plack doesn't check for Include *-plack.conf line in /etc/apache2/sites-available/$INSTANCE.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20692 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Summary|koha-plack doesn't check |koha-plack doesn't check |for Include *-plack.conf |for Include *-plack.conf |line in |line in |/etc/apache2/sites-availabl |/etc/apache2/sites-availabl |e/$ISNTANCE.conf |e/$INSTANCE.conf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 19:52:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 17:52:56 +0000 Subject: [Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66019|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 19:52:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 17:52:38 +0000 Subject: [Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113 --- Comment #6 from Blou --- Created attachment 75509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75509&action=edit Bug 19113: Barcode value builder not working with numeric branchcode The regexp for the value builder 'hbyymmincr' doesn't allow for numerics in the branchcode, so the nextnum found is always 0 and multiple Add always generate the same barcode. This simply allow for numerics within the regex. Test - It's a bit complicated. You need - all your branchcodes to be numerics (01,02,71...) - all barcodes to already be a bunch of numbers - Modify the syspref 'autobarcode' to hbyymmincr, the home branch + date one. - Find an item in the pro-search, - New -> New Item - Click on the 'p' to have the value builder create the next barcode. - Without the patch, the query won't have found anything, so it'll suggest xxxxxx0001 - Click Add. It reprensent the form to enter another one. - Click on the 'p' edit box, it'll offer you again xxxxxx0001 With the patch, it'll offer valid ones everytime. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 19:55:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 17:55:55 +0000 Subject: [Koha-bugs] [Bug 9573] Ability to download items lost report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20807 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 19:55:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 17:55:55 +0000 Subject: [Koha-bugs] [Bug 20807] New: Lost items report: Improve the display of CSV profile errors Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20807 Bug ID: 20807 Summary: Lost items report: Improve the display of CSV profile errors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Currently, if you don't have a "Export lost items in report" CSV profile, the lost items report results will show what looks like a disabled link to exporting selected items. Information about the missing CSV profile is hidden in a title attribute on that link. I propose that we instead display a message about the missing CSV profile and hide all selection tools and checkboxes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 19:57:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 17:57:00 +0000 Subject: [Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Blou --- Still don't understand why the patch had been replaced by Bug 15685. So setting back to need sign off. Not signed off yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 19:57:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 17:57:43 +0000 Subject: [Koha-bugs] [Bug 20807] Lost items report: Improve the display of CSV profile errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20807 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20774 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774 [Bug 20774] Trivial HTML error in itemslost.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 19:57:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 17:57:43 +0000 Subject: [Koha-bugs] [Bug 20774] Trivial HTML error in itemslost.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20807 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20807 [Bug 20807] Lost items report: Improve the display of CSV profile errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 20:06:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 18:06:46 +0000 Subject: [Koha-bugs] [Bug 20692] koha-plack doesn't check for Include *-plack.conf line in /etc/apache2/sites-available/$INSTANCE.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20692 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75040|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 75510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75510&action=edit Bug 20692: Return and display and error if koha-plack failed If koha-plack did not comment/uncomment the line it should fails and display an error instead of success. Useful for old apache config files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 20:08:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 18:08:45 +0000 Subject: [Koha-bugs] [Bug 20692] koha-plack doesn't check for Include *-plack.conf line in /etc/apache2/sites-available/$INSTANCE.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20692 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75510|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 75511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75511&action=edit Bug 20692: Return and display and error if koha-plack failed If koha-plack did not comment/uncomment the line it should fails and display an error instead of success. Useful for old apache config files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 20:09:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 18:09:31 +0000 Subject: [Koha-bugs] [Bug 20808] New: I cant install Koha on Ubuntu 18.04 LTS (Bionic Beaver) - Unmet dependences Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20808 Bug ID: 20808 Summary: I cant install Koha on Ubuntu 18.04 LTS (Bionic Beaver) - Unmet dependences Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: paul.messina at gmail.com QA Contact: testopia at bugs.koha-community.org Hello, I am installing Koha on Ubuntu 18.04 LTS Bionic Beaver (Fresh Installation). However, I have experienced the following error when I run "sudo apt-get install koha-common" The following packages have unmet dependencies: koha-common : Depends: libmarc-charset-perl but it is not installable Depends: libmarc-xml-perl but it is not installable E: Unable to correct problems, you have held broken packages. Workaround: sudo apt-get install libmarc-record-perl sudo apt-get install libxml-sax-perl wget http://ftp.br.debian.org/debian/pool/main/libm/libmarc-charset-perl/libmarc-charset-perl_1.35-2_amd64.deb wget http://ftp.br.debian.org/debian/pool/main/libm/libmarc-xml-perl/libmarc-xml-perl_1.0.3-1_all.deb sudo dpkg -i libmarc-charset-perl_1.35-2_amd64.deb libmarc-xml-perl_1.0.3-1_all.deb sudo apt-get install koha-common -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed May 23 20:16:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 18:16:15 +0000 Subject: [Koha-bugs] [Bug 20807] Lost items report: Improve the display of CSV profile errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20807 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 20:16:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 18:16:18 +0000 Subject: [Koha-bugs] [Bug 20807] Lost items report: Improve the display of CSV profile errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20807 --- Comment #1 from Owen Leonard --- Created attachment 75512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75512&action=edit Bug 20807: Lost items report: Improve the display of CSV profile errors This patch modifies the template for the lost items report to change the way it handles a missing CSV profile. Now, if there is a missing CSV profile, a message is displayed with details about the profile requirements. If the logged-in user has the right permission there is a link to the CSV profiles page. Since item selection is used only in conjunction with exporting results, item selection controls are all hidden when there is no valid CSV profile. To test, apply the patch go to Reports -> Lost items. - Run the report with parameters which will return results. - If your system has no CSV profile for exporting lost items: - If you are logged in as a user with manage_csv_profiles permission: - You should see a message dialog instructing you to create a CSV profile with a link to the CSV profiles page. - If you are not logged in as a user with manage_csv_profiles permission: - You should see a similar message but without a link to the CSV profiles page. - In both cases, with no CSV profile defined there should be no checkboxes in the table of results and no "select all/clear all" controls. - If your system has a valid CSV profile for exporting lost items: - Checking the checkbox for one or more items in the table should trigger the display of an "Export selected items" link. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 20:34:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 18:34:07 +0000 Subject: [Koha-bugs] [Bug 20807] Lost items report: Improve the display of CSV profile errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20807 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 20:34:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 18:34:10 +0000 Subject: [Koha-bugs] [Bug 20807] Lost items report: Improve the display of CSV profile errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20807 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75512|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 75513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75513&action=edit Bug 20807: Lost items report: Improve the display of CSV profile errors This patch modifies the template for the lost items report to change the way it handles a missing CSV profile. Now, if there is a missing CSV profile, a message is displayed with details about the profile requirements. If the logged-in user has the right permission there is a link to the CSV profiles page. Since item selection is used only in conjunction with exporting results, item selection controls are all hidden when there is no valid CSV profile. To test, apply the patch go to Reports -> Lost items. - Run the report with parameters which will return results. - If your system has no CSV profile for exporting lost items: - If you are logged in as a user with manage_csv_profiles permission: - You should see a message dialog instructing you to create a CSV profile with a link to the CSV profiles page. - If you are not logged in as a user with manage_csv_profiles permission: - You should see a similar message but without a link to the CSV profiles page. - In both cases, with no CSV profile defined there should be no checkboxes in the table of results and no "select all/clear all" controls. - If your system has a valid CSV profile for exporting lost items: - Checking the checkbox for one or more items in the table should trigger the display of an "Export selected items" link. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 20:47:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 18:47:37 +0000 Subject: [Koha-bugs] [Bug 20809] New: Link patron image to patron image add/edit form Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Bug ID: 20809 Summary: Link patron image to patron image add/edit form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Created attachment 75514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75514&action=edit Screen capture of the edit button interaction The structure of moremember.tt makes it possible to use AJAX to pull just the patron image add/edit form and display it in a modal. I'd like to add a link to the patron image so that the image can be edited from anywhere it displays. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 20:48:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 18:48:27 +0000 Subject: [Koha-bugs] [Bug 20692] koha-plack doesn't check for Include *-plack.conf line in /etc/apache2/sites-available/$INSTANCE.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20692 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from M. Tompsett --- The 'q' portion of the sed logic is faulty. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 20:54:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 18:54:05 +0000 Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #1 from Owen Leonard --- Created attachment 75515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75515&action=edit Screenshot of the modal window I'm not crazy about the duplication of the heading. Maybe it's better to have a blank (or nonexistent?) modal header. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 21:08:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 19:08:18 +0000 Subject: [Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 --- Comment #5 from Nick Clemens --- Created attachment 75516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75516&action=edit Bug 19490: (follow-up) Add tooltip to each row To test: 1 - Run batch modification on some items 2 - Hover over the holds column 3 - Note the tool tip 4 - PLace some holds to verify combinations of item/record level holds show appropriately -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 23:41:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 21:41:04 +0000 Subject: [Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |In Discussion --- Comment #8 from M. Tompsett --- (In reply to Blou from comment #6) > Test > - It's a bit complicated. You need > - all your branchcodes to be numerics (01,02,71...) Who sets their branch codes to purely numerical values?! > - all barcodes to already be a bunch of numbers > - Modify the syspref 'autobarcode' to hbyymmincr, the home branch + date one. Support for the hbyymm barcode methodology has been deprecated, as far as I know. Why even fix it for this bizarre case? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 23 23:50:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 May 2018 21:50:22 +0000 Subject: [Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113 --- Comment #9 from M. Tompsett --- Comment on attachment 75509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75509 Bug 19113: Barcode value builder not working with numeric branchcode Review of attachment 75509: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19113&attachment=75509) ----------------------------------------------------------------- ::: C4/Barcodes/ValueBuilder.pm @@ +49,4 @@ > my $month = $args->{mon}; > my $query = "SELECT MAX(CAST(SUBSTRING(barcode,-4) AS signed)) AS number FROM items WHERE barcode REGEXP ?"; > my $sth = C4::Context->dbh->prepare($query); > + $sth->execute("^[-a-zA-Z0-9]{1,}$year$month"); If this regexp is wrong, there are several other places it is wrong too. See C4/Barcodes/hbyymmincr.pm db_max for example. See also line 142: This format is deprecated and SHOULD NOT BE USED. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 07:57:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 05:57:34 +0000 Subject: [Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113 --- Comment #10 from Katrin Fischer --- We have branchcodes that are a mix of capitals and numbers, so I don't think it's an odd case. The problem with deprecating something just in the source code is that people will still use it - how would they know? The code comments have been there forever, maybe we need to fix it or remove it, but don't leave it like that? Least we could do is add a note to the GUI about it being problematic or deprecated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 08:19:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 06:19:26 +0000 Subject: [Koha-bugs] [Bug 7651] Add separate permission for managing currencies and exchange rates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 --- Comment #9 from Katrin Fischer --- Created attachment 75517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75517&action=edit Bug 7651: (follow-up) Correct visibility on admin sidebar This patch corrects visibility of links to the different acquisition pages from the admin sidebar. It also makes a correction to the links on the acq start page: - Budgets = period_manage - Funds = budget_manage To test: - Follow the test plan of the first patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 08:19:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 06:19:23 +0000 Subject: [Koha-bugs] [Bug 7651] Add separate permission for managing currencies and exchange rates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 09:12:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 07:12:56 +0000 Subject: [Koha-bugs] [Bug 20810] New: Add filters and links in basketgroups page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20810 Bug ID: 20810 Summary: Add filters and links in basketgroups page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org Depends on: 11708 - Open/Closed filtering - Per-column filtering - Links to basketgroups and booksellers Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 09:12:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 07:12:56 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20810 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20810 [Bug 20810] Add filters and links in basketgroups page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 09:13:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 07:13:57 +0000 Subject: [Koha-bugs] [Bug 20810] Add filters and links in basketgroups page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20810 --- Comment #1 from Julian Maurice --- Created attachment 75518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75518&action=edit Bug 20810: Add filters and links in basketgroups page - Open/Closed filtering - Per-column filtering - Add links to basketgroups and booksellers - Display basketgroup id next to basketgroup name Test plan: 1. Go to basketgroups page (/acqui/basketgroups.pl) 2. Verify that the "Open/Closed/All" buttons work correctly by showing respectively only open basketgroups, only closed basketgroups, and all basketgroups. The "date closed" column should be hidden when only open basketgroups are shown. A hidden "Closed" column containing only "1" or "0" was added for these buttons to work correctly. Verify that you do not see it. 3. Verify that the column filters are displayed under the column headers and that they filter using only the data in their respective column. Verify that there is no filter for "Action" column. 4. Verify that the bookseller names are now links to the bookseller pages 5. Verify that basketgroup names are now links to the basketgroup pages 6. Verify that basketgroup id is displayed in the 'Name' column, next to the basketgroup name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 09:22:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 07:22:04 +0000 Subject: [Koha-bugs] [Bug 20810] Add filters and links in basketgroups page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20810 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 09:46:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 07:46:07 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #47 from Alex Arnaud --- (In reply to David Gustafsson from comment #43) > Created attachment 75490 [details] [review] > Update Koha/Schema/Result/SearchField.pm Hello David, Your dedicated patch is ok. But, please, remove the changes on the schema file from the previous one: attachment 75458. And add the bug number at the start of your commit messages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 11:00:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 09:00:14 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #48 from David Gustafsson --- Created attachment 75519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75519&action=edit Bug 18316: Update Koha/Schema/Result/SearchField.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 11:04:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 09:04:16 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75073|0 |1 is obsolete| | Attachment #75074|0 |1 is obsolete| | Attachment #75075|0 |1 is obsolete| | Attachment #75076|0 |1 is obsolete| | Attachment #75458|0 |1 is obsolete| | Attachment #75490|0 |1 is obsolete| | Attachment #75519|0 |1 is obsolete| | --- Comment #49 from David Gustafsson --- Created attachment 75520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75520&action=edit Bug 18316: Update Koha/Schema/Result/SearchField.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 11:07:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 09:07:56 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75520|0 |1 is obsolete| | --- Comment #50 from David Gustafsson --- Created attachment 75521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75521&action=edit Bug 18316: Add weighting/relevancy options to ES query on simple search The idea is the following: if some search field(s) are weighted in search engine config page, Koha will query ES on these fields only and with the coresponding weights. Else, search is done on the entire record. Test plan (having Koha working with Elasticsearch): - apply this patch, - try searches with and without weight defined on search fields Signed-off-by: S?verine QUEUNE Signed-off-by: Nick Clemens Signed-off-by: S?verine QUEUNE Rebased-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 11:08:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 09:08:11 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #51 from David Gustafsson --- Created attachment 75522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75522&action=edit Bug 18316: String changes Signed-off-by: Nick Clemens Signed-off-by: S?verine QUEUNE Rebased-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 11:08:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 09:08:38 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #52 from David Gustafsson --- Created attachment 75523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75523&action=edit Bug 18316 - QA improvement - Koha::SearchField::search_marc_maps return a result set - code refactoring for gettings weighted fields - Koha::SearchFields::weighted_fields return a result set Signed-off-by: S?verine QUEUNE Rebased-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 11:08:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 09:08:44 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #53 from David Gustafsson --- Created attachment 75524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75524&action=edit Bug 18316: Change search field weight field to decimal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 11:08:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 09:08:50 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #54 from David Gustafsson --- Created attachment 75525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75525&action=edit Bug 18316: Update Koha/Schema/Result/SearchField.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 11:14:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 09:14:24 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #55 from David Gustafsson --- Created attachment 75526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75526&action=edit Bug 18316: Ability to weight search fields Weight can be defined between 1 and 99. only search fields mapped with biblios can be weighted Test plan: - apply this patch, - update schema file (perl misc/devel/update_dbix_class_files.pl), - go to Administration > Search engine configuration, - in search fields tab, define weights for some fields and save, - check weights has been saved, - reset some weights (empty) and save, - check weights has been reset Signed-off-by: S?verine QUEUNE Signed-off-by: Nick Clemens Signed-off-by: S?verine QUEUNE Rebased-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 11:14:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 09:14:28 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75521|0 |1 is obsolete| | --- Comment #56 from David Gustafsson --- Created attachment 75527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75527&action=edit Bug 18316: Add weighting/relevancy options to ES query on simple search The idea is the following: if some search field(s) are weighted in search engine config page, Koha will query ES on these fields only and with the coresponding weights. Else, search is done on the entire record. Test plan (having Koha working with Elasticsearch): - apply this patch, - try searches with and without weight defined on search fields Signed-off-by: S?verine QUEUNE Signed-off-by: Nick Clemens Signed-off-by: S?verine QUEUNE Rebased-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 11:14:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 09:14:32 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75522|0 |1 is obsolete| | --- Comment #57 from David Gustafsson --- Created attachment 75528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75528&action=edit Bug 18316: String changes Signed-off-by: Nick Clemens Signed-off-by: S?verine QUEUNE Rebased-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 11:14:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 09:14:35 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75523|0 |1 is obsolete| | --- Comment #58 from David Gustafsson --- Created attachment 75529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75529&action=edit Bug 18316 - QA improvement - Koha::SearchField::search_marc_maps return a result set - code refactoring for gettings weighted fields - Koha::SearchFields::weighted_fields return a result set Signed-off-by: S?verine QUEUNE Rebased-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 11:14:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 09:14:39 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75524|0 |1 is obsolete| | --- Comment #59 from David Gustafsson --- Created attachment 75530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75530&action=edit Bug 18316: Change search field weight field to decimal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 11:14:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 09:14:43 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75525|0 |1 is obsolete| | --- Comment #60 from David Gustafsson --- Created attachment 75531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75531&action=edit Bug 18316: Update Koha/Schema/Result/SearchField.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 11:18:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 09:18:20 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #61 from David Gustafsson --- Not used to working with multiple patches in git bz, so had removed the schema changes locally, but used git bz incorrectly so it did not get included. Later managed to screw things up even more, but now managed to restore the patches (which I accidentally obsoleted) and fix the two last ones. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 11:36:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 09:36:48 +0000 Subject: [Koha-bugs] [Bug 20811] New: Fix wrong usage of ModBiblio in bulkmarcimport.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Bug ID: 20811 Summary: Fix wrong usage of ModBiblio in bulkmarcimport.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz In misc/migration_tools/bulkmarcimport.pl, line 454, ModBiblio is called like so: eval { ( $biblionumber, $biblioitemnumber ) = ModBiblio( $record, $biblionumber, GetFrameworkCode($biblionumber) ) }; But the POD for ModBiblio says: "Returns 1 on success 0 on failure" So $biblionumber gets 1 or 0, and $biblioitemnumber never gets anything. This leads to problems when ModBiblioMarc is called on line 487: ModBiblioMarc( $clone_record, $biblionumber, $framework ); If the ModBiblio was successfull, this will try to updated the record with biblionumber = 1, which is most likely not what we want. (I probably won't have the time to fix this soon, so please beat me to it!) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 24 11:45:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 09:45:44 +0000 Subject: [Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 --- Comment #16 from Magnus Enger --- (In reply to Andrew Isherwood from comment #15) > Hi Magnus - Thanks for looking at this. Currently, all this code does is log > status changes. Ah, gotcha! I'll sign off, then. If you do find the time to add logging of any changes to the metadata I'll be happy to test and sign off on it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 11:53:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 09:53:42 +0000 Subject: [Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 --- Comment #17 from Magnus Enger --- Hm, the previous version of the patch was working as expected, but with the most recent version, when I go to "Manage request" i get an "Internal Server Error". The Plack error log says: Template process failed: undef error - The method logs is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 122 The code around line 122 looks like this: 120 my $data; 121 binmode( STDOUT, ":utf8" ); 122 $template->process( $self->filename, $vars, \$data ) 123 || die "Template process failed: ", $template->error(); 124 return $data; Not quite sure if there is a problem with the patch or if i screwed up my testing environment? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 12:14:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 10:14:12 +0000 Subject: [Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 12:14:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 10:14:14 +0000 Subject: [Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75503|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 75532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75532&action=edit Bug 20262: Add ability to refund lost item fees without creating credits Some libraries handle refunding of paid lost fees at a financial office and not within Koha. To facilitate this, it would be good for Koha to have the option to not generate lost returned credits by skipping fully paid lost items, and only refunding the outstanding balance on partially paid lost fees. Test Plan: 1) Apply this patch 2) Set your lost item refund on return policies to 'Only if unpaid' 3) Mark an item lost, charging the lost fee 4) Return the item, a full refund should ocurr 5) Mark another item lost, charging the lost fee 6) Make a partial payment on this lost fee 7) Return the item 8) The remaining balance of that fee should be 0, but the patron should not recieve a credit for the already paid balance 8) Mark another item lost, charging the lost fee 9) Fully pay the lost fee 10) Return the item. The paid lost fee should be unaffected. Signed-off-by: Kyle M Hall Signed-off-by: Martha Fuerst -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 13:27:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 11:27:26 +0000 Subject: [Koha-bugs] [Bug 18047] JavaScript error on item search form unless LOC defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18047 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19706 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 13:27:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 11:27:26 +0000 Subject: [Koha-bugs] [Bug 19706] Item search: Unsupported format html In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18047 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 14:12:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 12:12:26 +0000 Subject: [Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75489|0 |1 is obsolete| | --- Comment #6 from S?verine Queune --- Created attachment 75533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75533&action=edit Bug 19490: Add a 'Holds' column to the items batchmodification tool To test: 1 - Add some items to bathc modification 2 - Note there is no indication fo holds 3 - Apply patch 4 - Reload and note you can see how many holds (or none) 5 - Note you can hide this column with css: #batchMod-edit .holds_count { display: none; } 6 - Note the column has a tooltip to indicate item vs. record holds Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 14:12:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 12:12:28 +0000 Subject: [Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75516|0 |1 is obsolete| | --- Comment #7 from S?verine Queune --- Created attachment 75534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75534&action=edit Bug 19490: (follow-up) Add tooltip to each row To test: 1 - Run batch modification on some items 2 - Hover over the holds column 3 - Note the tool tip 4 - PLace some holds to verify combinations of item/record level holds show appropriately Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 14:14:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 12:14:01 +0000 Subject: [Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 --- Comment #8 from S?verine Queune --- Just tested once more with follow-up, tooltip on each row is clear for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 14:37:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 12:37:06 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #241 from S?verine Queune --- I tried to test bug 20810 but this dependency doesn't apply : Bug 11708 - Display all basketgroups on one page, and new column aqbasketgroups.closeddate 75003 - Bug 11708: Change aqbasketgroups.closed to closeddate 75004 - Bug 11708: New page for basket groups Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 11708: Change aqbasketgroups.closed to closeddate Applying: Bug 11708: New page for basket groups Using index info to reconstruct a base tree... M acqui/basketgroup.pl M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt Falling back to patching base and 3-way merge... error: The following untracked working tree files would be overwritten by merge: Koha/Acquisition/Basketgroup.pm Koha/Acquisition/Basketgroups.pm acqui/basketgroups.pl koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroups.tt Please move or remove them before you can merge. Aborting Also failed on Biblibre's sandbox #11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 14:45:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 12:45:24 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #62 from S?verine Queune --- The sandbox you've requested is not ready. Some problems occurred applying patches from bug 18316:

Something went wrong !

Applying: Bug 18316: Ability to weight search fields Using index info to reconstruct a base tree... M installer/data/mysql/kohastructure.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql error: Failed to merge in the changes. Patch failed at 0001 Bug 18316: Ability to weight search fields The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 18316 - Add weighting/relevancy options to ElasticSearch 75526 - Bug 18316: Ability to weight search fields 75527 - Bug 18316: Add weighting/relevancy options to ES query on simple search 75528 - Bug 18316: String changes 75529 - Bug 18316 - QA improvement - Koha::SearchField::search_marc_maps return a result set - code refactoring for gettings weighted fields - Koha::SearchFields::weighted_fields return a result set 75530 - Bug 18316: Change search field weight field to decimal 75531 - Bug 18316: Update Koha/Schema/Result/SearchField.pm Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-18316-Ability-to-weight-search-fields-MFIcJl.patch . Same result on my test instance :/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 15:03:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 13:03:00 +0000 Subject: [Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr --- Comment #4 from S?verine Queune --- I have a (good ?) example on my test instance : when I try to use the new syspref to mark an item lost and notify patron from holds to pull list, I get this software error : The method homebranch is not covered by tests!" Applying this patch, I get this one : The method Koha::Patron->homebranch is not covered by tests! Trace begun at /var/repositories/koha/Koha/Object.pm line 398 Koha::Object::AUTOLOAD('Koha::Patron=HASH(0x8d10e08)') called at /var/repositories/koha/ circ/pendingreserves.pl line 71 Is it the behaviour you were looking for ? As I don't know what you expect I prefer not signing it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 15:10:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 13:10:00 +0000 Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287 --- Comment #72 from Jonathan Druart --- Created attachment 75535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75535&action=edit Bug 19287: (follow-up) Use the notice defined for the library of the patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 15:11:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 13:11:07 +0000 Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287 --- Comment #73 from Jonathan Druart --- (In reply to Jonathan Druart from comment #72) > Created attachment 75535 [details] [review] > Bug 19287: (follow-up) Use the notice defined for the library of the patron Fix the bug caught by S?verine on bug 20767 comment 4. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 15:14:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 13:14:23 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #63 from David Gustafsson --- I think root cause of this is that the "Bug 18316: Ability to weight search fields" commit was created from a commit with the line: "type` ENUM('', 'string', 'date', 'number', 'boolean', 'sum', 'isbn', 'stdno') ..." in /data/mysql/kohastructure.sql when in current Koha master the line is: `type` ENUM('', 'string', 'date', 'number', 'boolean', 'sum') This is the reason why: https://github.com/Koha-Community/Koha/commit/cff62796ea9fc227c24fec8f8f3f153a715796ef I can rebase the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 15:15:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 13:15:03 +0000 Subject: [Koha-bugs] [Bug 20812] New: Tag "" is not a valid tag. at /usr/share/koha/lib/C4/Biblio.pm line 2615. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20812 Bug ID: 20812 Summary: Tag "" is not a valid tag. at /usr/share/koha/lib/C4/Biblio.pm line 2615. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: biblioteca at colprecentro.edu.co QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Tag "" is not a valid tag. at /usr/share/koha/lib/C4/Biblio.pm line 2615. For help, please send mail to the webmaster ([no address given]), giving this error message and the time and date of the error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 24 15:22:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 13:22:30 +0000 Subject: [Koha-bugs] [Bug 20812] Tag "" is not a valid tag. at /usr/share/koha/lib/C4/Biblio.pm line 2615. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20812 Diana Romero changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |16.11 OS|All |Linux Deadline| |2018-05-24 --- Comment #1 from Diana Romero --- El error se produce el 24/05/2018 hora 8:14 am -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 15:22:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 13:22:42 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75526|0 |1 is obsolete| | --- Comment #64 from David Gustafsson --- Created attachment 75536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75536&action=edit Bug 18316: Ability to weight search fields Weight can be defined between 1 and 99. only search fields mapped with biblios can be weighted Test plan: - apply this patch, - update schema file (perl misc/devel/update_dbix_class_files.pl), - go to Administration > Search engine configuration, - in search fields tab, define weights for some fields and save, - check weights has been saved, - reset some weights (empty) and save, - check weights has been reset Signed-off-by: S?verine QUEUNE Signed-off-by: Nick Clemens Signed-off-by: S?verine QUEUNE Rebased-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 15:22:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 13:22:46 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75527|0 |1 is obsolete| | --- Comment #65 from David Gustafsson --- Created attachment 75537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75537&action=edit Bug 18316: Add weighting/relevancy options to ES query on simple search The idea is the following: if some search field(s) are weighted in search engine config page, Koha will query ES on these fields only and with the coresponding weights. Else, search is done on the entire record. Test plan (having Koha working with Elasticsearch): - apply this patch, - try searches with and without weight defined on search fields Signed-off-by: S?verine QUEUNE Signed-off-by: Nick Clemens Signed-off-by: S?verine QUEUNE Rebased-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 15:22:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 13:22:50 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75528|0 |1 is obsolete| | --- Comment #66 from David Gustafsson --- Created attachment 75538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75538&action=edit Bug 18316: String changes Signed-off-by: Nick Clemens Signed-off-by: S?verine QUEUNE Rebased-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 15:22:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 13:22:54 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75529|0 |1 is obsolete| | --- Comment #67 from David Gustafsson --- Created attachment 75539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75539&action=edit Bug 18316 - QA improvement - Koha::SearchField::search_marc_maps return a result set - code refactoring for gettings weighted fields - Koha::SearchFields::weighted_fields return a result set Signed-off-by: S?verine QUEUNE Rebased-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 15:22:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 13:22:58 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75530|0 |1 is obsolete| | --- Comment #68 from David Gustafsson --- Created attachment 75540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75540&action=edit Bug 18316: Change search field weight field to decimal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 15:23:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 13:23:02 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75531|0 |1 is obsolete| | --- Comment #69 from David Gustafsson --- Created attachment 75541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75541&action=edit Bug 18316: Update Koha/Schema/Result/SearchField.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 15:24:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 13:24:08 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #70 from David Gustafsson --- Now patches should apply to latest master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 15:38:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 13:38:04 +0000 Subject: [Koha-bugs] [Bug 20813] New: Revamp user permissions system Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 Bug ID: 20813 Summary: Revamp user permissions system Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Koha's current user permissions system is a bit convoluted and limited due to it's legacy where the permissions system was a simple set of flags. A second layer of sub-permissions were later added complication and obfuscation to the system. We should revamp the permissions system to be a more modern system and open the path to having unlimited nesting of sub-permissions instead of shoe-horning sub-permissions into the limited system we have. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 15:45:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 13:45:22 +0000 Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 15:45:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 13:45:24 +0000 Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 --- Comment #1 from Kyle M Hall --- Created attachment 75542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75542&action=edit Bug 20813: Update db schema -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 15:45:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 13:45:31 +0000 Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 --- Comment #2 from Kyle M Hall --- Created attachment 75543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75543&action=edit Bug 20813: Revamp user permissions system Koha's current user permissions system is a bit convoluted and limited due to it's legacy where the permissions system was a simple set of flags. A second layer of sub-permissions were later added complication and obfuscation to the system. We should revamp the permissions system to be a more modern system and open the path to having unlimited nesting of sub-permissions instead of shoe-horning sub-permissions into the limited system we have. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Restart all the things! 4) Koha should still enforce user permissions as before -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 24 15:45:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 13:45:33 +0000 Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 --- Comment #3 from Kyle M Hall --- Created attachment 75544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75544&action=edit Bug 20813: Remove deleted table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 24 15:45:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 13:45:36 +0000 Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 --- Comment #4 from Kyle M Hall --- Created attachment 75545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75545&action=edit Bug 20813 [Do Not Push]: Update Schema Files -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 15:45:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 13:45:54 +0000 Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 24 15:46:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 13:46:05 +0000 Subject: [Koha-bugs] [Bug 20584] Koha/Patron/Categories.t is failing on slow servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20584 --- Comment #6 from Fridolin SOMERS --- (In reply to Jonathan Druart from comment #5) > (In reply to Fridolin SOMERS from comment #4) > > I prefer not to push to this one and Bug 19176 on 17.05.x > > Why that? It only affects tests and will prevent random failures. Bug 19176 is complex, I want to stabilize 17.05.x and focus on 17.11.x soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 15:46:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 13:46:17 +0000 Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 --- Comment #5 from Kyle M Hall --- Original pre-rebase code ( known to be working ): https://github.com/bywatersolutions/bywater-koha-devel/tree/user_permissions_revamp -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 15:46:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 13:46:31 +0000 Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/bywaters | |olutions/bywater-koha-devel | |/tree/bug_20813 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 16:03:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 14:03:03 +0000 Subject: [Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818 --- Comment #37 from Fridolin SOMERS --- (In reply to Jonathan Druart from comment #36) > 1. when adding/editing a patron category, "Display in quick add: " is a bit > meaningless, I would add a quick description, like we have for "Default > privacy:", "Block expired patrons:", etc. OK > > 2. There is a condition ([% IF Koha.Preference('PatronQuickAddFields') || > Koha.Preference('BorrowerMandatoryField') %]) template-side to display the > "Quick add new patron" button, should we do the same on the patron's > category form? Indeed > > > And a question: what is the use case here? It seems that it would have been > done in css or javascript easily... :) It is a request from Aix-Marseille University which has 10 patron categories. I think its more efficient for them to have only the most-used categories in quick-add. The actually have a JS customisation but it would be better to have it for everybody in code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 17:05:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 15:05:47 +0000 Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #8 from Owen Leonard --- (In reply to Katrin Fischer from comment #7) > Hi Owen, are you still working on this? Whoops, I missed this question when you first asked. I still have an up-to-date branch with this. I'm thinking about trying to get it in with Bug 20813 (unless that bug proves to be controversial?) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 18:08:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 16:08:06 +0000 Subject: [Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 18:08:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 16:08:08 +0000 Subject: [Koha-bugs] [Bug 20814] New: Display issue with 'Saved reports' tabs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Bug ID: 20814 Summary: Display issue with 'Saved reports' tabs Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: severine.queune at bulac.fr QA Contact: testopia at bugs.koha-community.org Created attachment 75546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75546&action=edit Saved report - bullet list instead of tabs Saved report tabs become a bullet list when using the search form on /cgi-bin/koha/reports/reports-home.pl Problem may doesn't appear on some instances, test with sandbox to reproduce (screenshot from Biblibre's sandbox #11). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 18:08:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 16:08:10 +0000 Subject: [Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75319|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 75547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75547&action=edit Bug 20767: Display a stack trace when a method is not covered by tests When a method is not allowed yet (not covered by tests), developers get an error the is not really useful: "The method XXX is not covered by tests!" It would be more useful to have a stack trace in order to know where this error come from. Test plan: Modify some code to display this stack trace and confirm it makes sense to have it, i.e. it will make debug easier Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 18:11:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 16:11:10 +0000 Subject: [Koha-bugs] [Bug 20814] Display issue with 'Saved reports' tabs when memcached is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Display issue with 'Saved |Display issue with 'Saved |reports' tabs |reports' tabs when | |memcached is off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 18:25:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 16:25:22 +0000 Subject: [Koha-bugs] [Bug 14907] Item search: Call Numbers in Item search results are ordered alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14907 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 18:43:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 16:43:07 +0000 Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287 --- Comment #74 from Jonathan Druart --- Last patch pushed to master for 18.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 18:45:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 16:45:22 +0000 Subject: [Koha-bugs] [Bug 20803] Cannot search to hold or use print options from API keys interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20803 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #3 from Jonathan Druart --- Pushed to master for 18.05, thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 18:54:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 16:54:48 +0000 Subject: [Koha-bugs] [Bug 20814] Display issue with 'Saved reports' tabs when memcached is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 --- Comment #1 from Owen Leonard --- The error happens when memcached is disabled. This eliminates the "Cache expiry" column and messes up the column count for DataTAbles. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 19:06:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 17:06:35 +0000 Subject: [Koha-bugs] [Bug 14907] Item search: Call Numbers in Item search results are ordered alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14907 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW --- Comment #2 from Owen Leonard --- The item search table is rendered server-side, so all sorting happens server-side. This eliminates some of our standard sorting methods, like embedding a sortable string in a title tag. Renaming the column "cn_sort" has the right effect for the purposes of sorting: The column name "cn_sort" is passed to the query and the rows are sorted correctly by call number. Unfortunately this breaks the column filter: "cn_sort" is an ambiguous column name for the purposes of the query because of biblioitems.cn_sort. I'm not sure if there is a good way to handle this besides adding some conditional code specific to these columns. Suggestions welcome! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 19:10:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 17:10:28 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Summary|Merge deletedbiblio* and |Merge deleted* tables with |deleteitems tables with |their "alive" cousins |their "alive" cousins | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 19:16:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 17:16:18 +0000 Subject: [Koha-bugs] [Bug 20815] New: Development FY18 New System Preference Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815 Bug ID: 20815 Summary: Development FY18 New System Preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: kyle at bywatersolutions.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org 1 - Add a enw system preference "Don'tForgiveLostAfter" which would allow specification of a range of time 2 - modify the check in routine to check the value of the itemlost_on field and only refund if before this time 3 - Add feedback for circulation staff to alert that item was lost but fee is not refunded -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 19:16:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 17:16:21 +0000 Subject: [Koha-bugs] [Bug 20816] New: add user expiration date to SIP2 message Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20816 Bug ID: 20816 Summary: add user expiration date to SIP2 message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: kyle at bywatersolutions.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org add a user's expiration date to the SIP2 message in its own field, at least Patron Information Response (64), and probably the Patron Status Response (24) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 19:16:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 17:16:23 +0000 Subject: [Koha-bugs] [Bug 20817] New: Acquisitions development - Ordering existing items Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Bug ID: 20817 Summary: Acquisitions development - Ordering existing items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: kyle at bywatersolutions.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Acquisitions: attaching orders to existing records while retaining 9xx information. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 19:58:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 17:58:02 +0000 Subject: [Koha-bugs] [Bug 20350] Add column configuration to table of saved reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20350 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20814 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 [Bug 20814] Display issue with 'Saved reports' tabs when memcached is off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 19:58:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 17:58:02 +0000 Subject: [Koha-bugs] [Bug 20814] Display issue with 'Saved reports' tabs when memcached is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20350 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20350 [Bug 20350] Add column configuration to table of saved reports -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 20:22:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 18:22:20 +0000 Subject: [Koha-bugs] [Bug 20350] Add column configuration to table of saved reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20350 --- Comment #11 from Jonathan Druart --- (In reply to Lucie Gay from comment #4) > Tested on sandbox Biblibre n?9 > > Go to Reports -> Use saved : > there is no button "Column visibility" in the table's pagination toolbar, > report groups are displayed like a list and not in tabs > > Go to Administration -> Columns settings : > The selection is not applied It was a real bug :) See bug 20814. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 20:24:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 18:24:46 +0000 Subject: [Koha-bugs] [Bug 15752] Automatically switch from circulation to new patron when a cardnumber is scanned during circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 20:26:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 18:26:15 +0000 Subject: [Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61337|0 |1 is obsolete| | --- Comment #22 from M. Tompsett --- Created attachment 75548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75548&action=edit Bug 12759: Use a list (shelf) for batch record modification and deletion To test: 1) Create a list, add a record to it by its barcode that you don't mind deleting 2) Go to Tools -> Batch record modification 3) Select the record type 'Authorities'. Confirm the dropdown to select a list disappears. Confirm selecting 'Biblios' makes the dropdown show again. 4) Select the list from the dropdown, select a modification template, Continue 5) Confirm all of the records in that list show on the page. Click Modify selected records. Confirm this is successful. 6) Go to Batch record deletion 7) Select the record type 'Authorities'. Confirm the dropdown to select a list disappears. Confirm selecting 'Biblios' makes the dropdown show again. 8) Select the list from the dropdown and click Continue 9) Confirm all of the records in that list show on the page. Click Delete selected records. Confirm this is successful. 10) Go back to your lists. The list should still exist but it will now be empty. Sponsored-by: Catalyst IT NOTE: Rebased to work -- Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 20:28:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 18:28:30 +0000 Subject: [Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 20:42:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 18:42:25 +0000 Subject: [Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428 Narcis Garcia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |informatica at actiu.net --- Comment #52 from Narcis Garcia --- PHP uses parameter "upload_tmp_dir", usually set at php.ini or webserver site profile. Doesn't Perl have some similar to not make necessary to check filesystem paths and permissions? I have a Koha 17.11 running in Debian 9 (Stretch) without problem about uploads. How does Koha 17.11 deal with this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 20:44:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 18:44:58 +0000 Subject: [Koha-bugs] [Bug 20814] Display issue with 'Saved reports' tabs when memcached is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 20:55:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 18:55:15 +0000 Subject: [Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428 --- Comment #53 from Jonathan Druart --- (In reply to Narcis Garcia from comment #52) > PHP uses parameter "upload_tmp_dir", usually set at php.ini or webserver > site profile. Doesn't Perl have some similar to not make necessary to check > filesystem paths and permissions? > > I have a Koha 17.11 running in Debian 9 (Stretch) without problem about > uploads. How does Koha 17.11 deal with this? Did you see comment 4? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 20:59:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 18:59:12 +0000 Subject: [Koha-bugs] [Bug 20814] Display issue with 'Saved reports' tabs when memcached is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 --- Comment #2 from Owen Leonard --- Created attachment 75549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75549&action=edit Bug 20814: Display issue with 'Saved reports' tabs when memcached is off This patch changes the configuration of the saved reports table so that columns which were previously excluded from the table altogether are now hidden. This prevents a JavaScript error when DataTables tries to reference a missing column. To test, apply the patch and go to Reports -> Use saved. You should have at least one report category configured and assigned to reports in order for the tabs display to be visible. Test the table of saved reports under a variety of these circumstances: - memcached disabled or enabled - reports exist or don't exist which require update from the old marcxml syntax - cache_expiry and/or update columns are configured in Administration -> Columns settings to be shown or hidden The report category tabs and the table should render correctly under all circumstances. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 20:59:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 18:59:08 +0000 Subject: [Koha-bugs] [Bug 20814] Display issue with 'Saved reports' tabs when memcached is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 21:33:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 19:33:00 +0000 Subject: [Koha-bugs] [Bug 20818] New: Missing QA manager entry in 18.05 release notes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20818 Bug ID: 20818 Summary: Missing QA manager entry in 18.05 release notes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: About Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Sorry Katrin! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 21:33:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 19:33:39 +0000 Subject: [Koha-bugs] [Bug 20818] Missing QA manager entry in 18.05 release notes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20818 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 21:33:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 19:33:44 +0000 Subject: [Koha-bugs] [Bug 20818] Missing QA manager entry in 18.05 release notes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20818 --- Comment #1 from Jonathan Druart --- Created attachment 75550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75550&action=edit Bug 20818: Add missing QA Manager entry in 18.05.00 release notes Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 21:34:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 19:34:04 +0000 Subject: [Koha-bugs] [Bug 20818] Missing QA manager entry in 18.05 release notes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20818 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 21:34:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 19:34:11 +0000 Subject: [Koha-bugs] [Bug 20818] Missing QA manager entry in 18.05 release notes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20818 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 21:34:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 19:34:39 +0000 Subject: [Koha-bugs] [Bug 20818] Missing QA manager entry in 18.05 release notes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20818 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com --- Comment #2 from Jonathan Druart --- Nick, Martin: This should be your first one ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 21:40:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 19:40:21 +0000 Subject: [Koha-bugs] [Bug 20818] Missing QA manager entry in 18.05 release notes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20818 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Thx for the super fast fix! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 21:41:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 19:41:15 +0000 Subject: [Koha-bugs] [Bug 20817] Acquisitions development - Ordering existing items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Kyle, can you explain this one a bit more? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 21:42:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 19:42:13 +0000 Subject: [Koha-bugs] [Bug 11126] Make the holds system optionally give precedence to local holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20747 CC| |lisetteslatah at gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 [Bug 20747] Allow LocalHoldsPriority to fill by hierarchical groups system rather than individual library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 21:42:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 19:42:13 +0000 Subject: [Koha-bugs] [Bug 20747] Allow LocalHoldsPriority to fill by hierarchical groups system rather than individual library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11126 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126 [Bug 11126] Make the holds system optionally give precedence to local holds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 21:43:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 19:43:14 +0000 Subject: [Koha-bugs] [Bug 20747] Allow LocalHoldsPriority to fill by hierarchical groups system rather than individual library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12004 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 24 21:43:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 19:43:14 +0000 Subject: [Koha-bugs] [Bug 12004] Regional preference on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12004 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20747 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu May 24 22:09:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 20:09:38 +0000 Subject: [Koha-bugs] [Bug 20814] Display issue with 'Saved reports' tabs when memcached is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 24 23:12:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 21:12:29 +0000 Subject: [Koha-bugs] [Bug 20815] Development FY18 New System Preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Kyle, can you explain what FY18 means? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 00:51:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 22:51:24 +0000 Subject: [Koha-bugs] [Bug 18521] Renew and search hotkeys are swapped on returns page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18521 --- Comment #2 from Alex Buckley --- Created attachment 75551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75551&action=edit Bug 18521 - Moving the if CAN_user_circulate_circulate_remaining_permissions conditional block Moving the conditional block [% IF (CAN_user_circulate_circulate_remaining_permissions ) %] block up the checkin-search.inc file above the CAN_user_catalogue IF conditional block fixes this bug. Test plan: 1. Go to the circ home page and confirm the following keyboard shortcuts work: Alt+q = goes to search catalog Alt+w = goes to renew 2. Go to returns.pl and confirm the following keyboard shortcuts work: Alt+q = goes to renew Alt+w = goes to search catalog 3. Apply patch 4. Restart apache2, memchached and plack 5. Confirm on the returns.pl the following keyboard shortcuts work: Alt+q = goes to search catalog Alt+w = goes to renew Sponsored-By: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 00:51:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 May 2018 22:51:51 +0000 Subject: [Koha-bugs] [Bug 18521] Renew and search hotkeys are swapped on returns page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18521 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |alexbuckley at catalyst.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 05:05:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 03:05:43 +0000 Subject: [Koha-bugs] [Bug 20514] Searching for a patron using the search field (street address) returns no results if inputting a address stored in multiple db fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20514 danield at brimbank.vic.gov.au changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danield at brimbank.vic.gov.au --- Comment #1 from danield at brimbank.vic.gov.au --- Is there any chance of this being patched in 18.05? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 25 09:13:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 07:13:45 +0000 Subject: [Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428 --- Comment #54 from Narcis Garcia --- Is "template_cache_dir" parameter affected by this issue? I have Koha 17.11 running on Debian 9 without this directive. Should I enable it when following performance recommendations? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 09:36:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 07:36:40 +0000 Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #30 from Marcel de Rooy --- This unfortunately is not enough. We have to deal here with the wonderous CGI::Session object ;) Test this: Remove all sessions. Login. Now check sessions again. You have 5 entries. 1 entry contains the info about the logged in user. You should expect the new track param here too. But it is not there. What happens? Somehow $session is already undef when you call track. If we need to call CGI::Session->new($sessionID) each time, we do not really benefit in terms of db access (well: 1 lookup in sessions instead of 1 in borrowers). Is there a different approach? What about using a cache key? (Do we want to pollute the cache with keys for every session..) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 09:36:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 07:36:51 +0000 Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 09:48:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 07:48:27 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #91 from Marcel de Rooy --- about.pl has compilation errors now. Look at this line: if ( @$patrons or @$biblios or @$items or @$checkouts or @$holds ) { You removed $biblios and $items.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 09:48:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 07:48:41 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 09:59:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 07:59:33 +0000 Subject: [Koha-bugs] [Bug 20814] Display issue with 'Saved reports' tabs when memcached is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- (In reply to Owen Leonard from comment #1) > The error happens when memcached is disabled. This eliminates the "Cache > expiry" column and messes up the column count for DataTAbles. But it should not be disabled now ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 10:06:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 08:06:29 +0000 Subject: [Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75547|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 75552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75552&action=edit Bug 20767: Display a stack trace when a method is not covered by tests When a method is not allowed yet (not covered by tests), developers get an error the is not really useful: "The method XXX is not covered by tests!" It would be more useful to have a stack trace in order to know where this error come from. Test plan: Modify some code to display this stack trace and confirm it makes sense to have it, i.e. it will make debug easier Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 10:06:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 08:06:45 +0000 Subject: [Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 10:06:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 08:06:25 +0000 Subject: [Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 10:09:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 08:09:34 +0000 Subject: [Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 --- Comment #7 from Julian Maurice --- (In reply to Julian Maurice from comment #3) > So, the message should probably be "This method does not exist" rather than > "not covered by tests". Any opinion on that ? Should I open a new bug ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 10:13:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 08:13:28 +0000 Subject: [Koha-bugs] [Bug 20768] Noisy test results when SearchEngine set to Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20768 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 19893 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 10:13:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 08:13:28 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #51 from Nick Clemens --- *** Bug 20768 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 10:26:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 08:26:46 +0000 Subject: [Koha-bugs] [Bug 20781] 0 months is not a valid enrollment period and causes errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 10:26:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 08:26:49 +0000 Subject: [Koha-bugs] [Bug 20781] 0 months is not a valid enrollment period and causes errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75437|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 75553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75553&action=edit Bug 20781: Set a minimum enrollemnt period 'in months' of 1 To test: 1 - Browse to Admin->Patron Categories 2 - Click '+ New category' 3 - Enter data as required, however, enter 0 in 'Enrolment period' -> 'in months' 4 - Save 5 - View the list of categories, the new category has 'Enrolment period' = 'until' 6 - Create a patron in this category, note their dateexipry is '0000-00-00' 7 - Search for them 8 - internal server error 9 - Delete that patron 10 - Apply patch 11 - Edit the category, note you cannot save with 0 months 12 - Set 1 month and save 13 - Create a patron in this cateogry 14 - Note they have a valid dateexpiry 15 - Search for them 16 - All works 17 - Create a new category and verify you cannot add with 0 months Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 10:26:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 08:26:53 +0000 Subject: [Koha-bugs] [Bug 20781] 0 months is not a valid enrollment period and causes errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781 --- Comment #4 from Marcel de Rooy --- Created attachment 75554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75554&action=edit Bug 20781: (QA follow-up) Remove unneeded rules These rules do not have any meaning. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 10:27:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 08:27:22 +0000 Subject: [Koha-bugs] [Bug 20781] 0 months is not a valid enrollment period and causes errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 10:36:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 08:36:32 +0000 Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 10:57:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 08:57:37 +0000 Subject: [Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 --- Comment #4 from Marcel de Rooy --- I would prefer a patron consent field as a datetime somewhere. This helps us to comply to the need to prove that a patron gave consent. It should be added to self registration too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 11:01:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 09:01:47 +0000 Subject: [Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 --- Comment #8 from Marcel de Rooy --- (In reply to Julian Maurice from comment #7) > (In reply to Julian Maurice from comment #3) > > So, the message should probably be "This method does not exist" rather than > > "not covered by tests". > > Any opinion on that ? Should I open a new bug ? This method is not supported ? If you only replace a few words, please add a QA follow-up? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 11:17:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 09:17:01 +0000 Subject: [Koha-bugs] [Bug 20774] Trivial HTML error in itemslost.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 11:17:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 09:17:04 +0000 Subject: [Koha-bugs] [Bug 20774] Trivial HTML error in itemslost.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75508|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 75555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75555&action=edit Bug 20774: Trivial HTML error in itemslost.tt This patch makes a minor correction to the markup of the lost items report template. To test, apply the patch and run the lost items report with parameters which will return results. The report results should look correct, and the page should validate with no relevant errors. Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 11:17:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 09:17:12 +0000 Subject: [Koha-bugs] [Bug 20774] Trivial HTML error in itemslost.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 11:22:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 09:22:45 +0000 Subject: [Koha-bugs] [Bug 20778] Unable to delete a subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #5 from Marcel de Rooy --- I think we are not adding consistency in this script by removing a confirm from one of the js functions in a row of similar ones. Should you remove the other confirmation perhaps ? If you have confirm_deletion as name, I would expect a confirm there too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 11:27:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 09:27:16 +0000 Subject: [Koha-bugs] [Bug 20752] Files tab in patron account is not properly capitalized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20752 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 11:27:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 09:27:19 +0000 Subject: [Koha-bugs] [Bug 20752] Files tab in patron account is not properly capitalized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20752 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75268|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 75557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75557&action=edit Bug 20752: Fix capitalization on the files tab for patron files - Activate EnableBorrowerFiles - Go to any patron account in staff - Go to the files tab - Check that strings on the page ar all properly capitalized - button - legend on section Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 11:27:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 09:27:37 +0000 Subject: [Koha-bugs] [Bug 20752] Files tab in patron account is not properly capitalized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20752 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 11:29:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 09:29:05 +0000 Subject: [Koha-bugs] [Bug 20791] Correct capitalization on 'Notices and slips' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20791 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 11:29:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 09:29:08 +0000 Subject: [Koha-bugs] [Bug 20791] Correct capitalization on 'Notices and slips' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20791 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75481|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 75558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75558&action=edit Bug 20791: Correct capitalization on 'Notices & slips' page - Standardizes spelling to 'Notices & slips' Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 11:29:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 09:29:23 +0000 Subject: [Koha-bugs] [Bug 20791] Correct capitalization on 'Notices and slips' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20791 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 11:33:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 09:33:24 +0000 Subject: [Koha-bugs] [Bug 20756] OPAC "Share list" button should be styled with an icon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75498|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 75559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75559&action=edit Bug 20756: OPAC "Share list" button should be styled with an icon This patch adds a new "share" icon to the sprite image used to style controls in the OPAC. The "share list" links now have a "sharelist" class which is used to style the links with the new icon. Also changed: Fixed the page structure markup of opac-shareshelf.tt. To test you must have the OpacAllowSharingPrivateLists system preference enabled. - Log in to the OPAC and go to Lists -> Your lists. - Create one or more private lists if necessary. - In the table of your lists there should be a "Share" link with the new icon. - View one of these lists and confirm that the "Share" link at the top of the table of list items. - Click through to the share list page and confirm that the page looks correct. Signed-off-by: S?verine QUEUNE Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 11:33:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 09:33:29 +0000 Subject: [Koha-bugs] [Bug 20756] OPAC "Share list" button should be styled with an icon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75499|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 75560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75560&action=edit Bug 20756: Compiled CSS This patch contains the compiled CSS file Signed-off-by: S?verine QUEUNE Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 11:33:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 09:33:42 +0000 Subject: [Koha-bugs] [Bug 20756] OPAC "Share list" button should be styled with an icon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 11:33:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 09:33:21 +0000 Subject: [Koha-bugs] [Bug 20756] OPAC "Share list" button should be styled with an icon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 11:38:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 09:38:11 +0000 Subject: [Koha-bugs] [Bug 18822] Advanced editor - Rancor - searching broken under Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 11:38:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 09:38:14 +0000 Subject: [Koha-bugs] [Bug 18822] Advanced editor - Rancor - searching broken under Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68803|0 |1 is obsolete| | --- Comment #14 from Nick Clemens --- Created attachment 75561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75561&action=edit Bug 18822: Check if we have MARC::Record and convert if not when using ES The new_record_from_zebra subroutine assumes that when using ES we always get MARC::Record objects when using ES, but sometimes we get them as xml via Z39 or internally. This adds a test to new_from_zebra to confirm we have a record object and to convert it if not To test: 1 - Perform an advanced search from the advanced editor, make sure to select 'Local catalog' and a remote source 2 - Error 'Internal search error [Object object]' 3 - Apply patch 4 - Repeat search, success! 5 - Select and deselect various servers, search should still work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 11:40:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 09:40:29 +0000 Subject: [Koha-bugs] [Bug 17739] Opac explodes when clicking on user tag when using elastic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17739 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |nick at bywatersolutions.com --- Comment #1 from Nick Clemens --- This is the same issue as in 18822 - we assume we got MARC::Record objects from zebra, but in this case we have raw xml fetched from the DB directly. Possibly in the future we should index the tags and search them using the search engine instead of a direct db call *** This bug has been marked as a duplicate of bug 18822 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 11:40:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 09:40:29 +0000 Subject: [Koha-bugs] [Bug 18822] Advanced editor - Rancor - searching broken under Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #15 from Nick Clemens --- *** Bug 17739 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 11:48:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 09:48:47 +0000 Subject: [Koha-bugs] [Bug 2426] Management permissions is deprecated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | CC| |m.de.rooy at rijksmuseum.nl --- Comment #10 from Marcel de Rooy --- > Bonus: > borrowers.flags is recalculated for patrons with management > permission. No bonus imo. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 11:49:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 09:49:40 +0000 Subject: [Koha-bugs] [Bug 2426] Management permissions is deprecated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 11:49:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 09:49:43 +0000 Subject: [Koha-bugs] [Bug 2426] Management permissions is deprecated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75476|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy --- Created attachment 75562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75562&action=edit Bug 2426: Remove deprecated management permission After review of the code it turns out that the management permission that has been marked as deprecated a long time ago, does not have any function. The patch removes all remaining code related to it. To test: - Make sure you have a patron with the management permission - Apply patch - Run database update - Check everything still works as expected Bonus: borrowers.flags is recalculated for patrons with management permission. To check: - Create some 'permission twins' with and without management permission - Note the value in borrowers.flags - Apply patch, don't run database update - Save permissions from GUI for one of the twins - Note the newly calculated value - Run database update - Now both twins should have the same borrowers.flags value Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 12:00:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 10:00:44 +0000 Subject: [Koha-bugs] [Bug 20819] New: GDPR: Add a consent field for processing personal data Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Bug ID: 20819 Summary: GDPR: Add a consent field for processing personal data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com See 18081 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 25 12:01:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 10:01:06 +0000 Subject: [Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20819 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 [Bug 20819] GDPR: Add a consent field for processing personal data -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 25 12:01:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 10:01:06 +0000 Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18081 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 13:04:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 11:04:06 +0000 Subject: [Koha-bugs] [Bug 11512] Only allow to override maximum number of holds from staff as other overrides would never be filled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11512 Stefan Berndtsson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stefan.berndtsson at ub.gu.se --- Comment #14 from Stefan Berndtsson --- (In reply to Marcel de Rooy from comment #11) > Currently in Koha, if you choose to force a hold from the staff side that > would contravened the current issuing rules, that hold will never be filled, > as it is always skipped over by CheckReserves. > > This patch disallows overrideing except for tooManyReserves which are the > only overridden holds that will be trapped. >From what I can see in the code, this isn't actually true. CheckReserves does not include neither LOST nor WITHDRAWN in its checks. In fact, we use the LOST part here. When longoverdue.pl marks a book as LOST, our staff adds a reserve to that item, so that they will be notified if it is returned. With the code prior to this patch, this works perfectly fine since we have the AllowHoldPolicyOverride set and returning a LOST item fills the hold. We've also used a similiar thing with withdrawn, but that's not as critical, so I won't argue against that one. The assumption that this is always skipped is not valid, unless I've missed something. We can patch things temporarily, but some sort of option for better override selectability would probably be useful here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 13:39:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 11:39:06 +0000 Subject: [Koha-bugs] [Bug 20820] New: koha fails to connect to memcached until restart after debian package upgrade 17.11.06-1 -> 18.05.00-1 on Ubuntu Xenial 16.04 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20820 Bug ID: 20820 Summary: koha fails to connect to memcached until restart after debian package upgrade 17.11.06-1 -> 18.05.00-1 on Ubuntu Xenial 16.04 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: helix84 at centrum.sk QA Contact: testopia at bugs.koha-community.org CC: mirko at abunchofthings.net On Ubuntu Xenial 16.04, after upgrading koha from 17.11.06-1 to 18.05.00-1 from official koha debian package, the following error is shown in the dpkg log and accessing koha opac and koha intranet shows an unstyled interface. ... Upgrade to 17.12.00.044 done (Bug 20624 - Disable OAuth2 client credentials grant by default) Upgrade to 18.05.00.000 done (Koha 18.05) Connection to the memcached servers '__MEMCACHED_SERVERS__' failed. Are the unix socket permissions set properly? Is the host reachable? If you ignore this warning, you will face performance issues Connection to the memcached servers '__MEMCACHED_SERVERS__' failed. Are the unix socket permissions set properly? Is the host reachable? If you ignore this warning, you will face performance issues Updated the cs-CZ translations. Setting up libhijk-perl (0.26-1) ... Setting up libtype-tiny-xs-perl (0.012-1build1) ... Use of uninitialized value $fn in exists at /usr/share/perl5/NeedRestart/Utils.pm line 100.========================================================================================================================= ] Use of uninitialized value $fn in stat at /usr/share/perl5/NeedRestart/Utils.pm line 102. Use of uninitialized value in list assignment at /usr/share/perl5/NeedRestart/Interp/Perl.pm line 132. Use of uninitialized value $fn in exists at /usr/share/perl5/NeedRestart/Utils.pm line 100.================================================================================================================================== ] Use of uninitialized value $fn in stat at /usr/share/perl5/NeedRestart/Utils.pm line 102. Use of uninitialized value in list assignment at /usr/share/perl5/NeedRestart/Interp/Perl.pm line 132. Scanning processes... Scanning candidates... Scanning linux images... Restarting services using systemd... No containers need to be restarted. $ lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 16.04.4 LTS Release: 16.04 Codename: xenial $ grep MEMCACHED_SERVERS /etc/koha/koha-sites.conf # MEMCACHED_SERVERS: comma separated list of memcached servers (ip:port) MEMCACHED_SERVERS="127.0.0.1:11211" $ sudo systemctl status memcached.service ? memcached.service - memcached daemon Loaded: loaded (/lib/systemd/system/memcached.service; enabled; vendor preset: enabled) Active: active (running) since Fri 2018-05-25 13:01:18 CEST; 32min ago Main PID: 1016 (memcached) Tasks: 6 Memory: 12.1M CPU: 110ms CGroup: /system.slice/memcached.service ??1016 /usr/bin/memcached -m 64 -p 11211 -u memcache -l 127.0.0.1 May 25 13:01:18 koha systemd[1]: Started memcached daemon. $ sudo netstat -tulpn | grep 11211 tcp 0 0 127.0.0.1:11211 0.0.0.0:* LISTEN 1016/memcached The problem is not alleviated even after restarting the koha-common service and the memcached service. It is resolved by restarting the host. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 25 13:41:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 11:41:02 +0000 Subject: [Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 --- Comment #9 from Tom?s Cohen Arazi --- (In reply to Julian Maurice from comment #7) > (In reply to Julian Maurice from comment #3) > > So, the message should probably be "This method does not exist" rather than > > "not covered by tests". > > Any opinion on that ? Should I open a new bug ? I agree. File a new one! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 14:16:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 12:16:01 +0000 Subject: [Koha-bugs] [Bug 20812] Tag "" is not a valid tag. at /usr/share/koha/lib/C4/Biblio.pm line 2615. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20812 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #2 from Tom?s Cohen Arazi --- Podr?as darnos mas informacion de contexto? Ese mensaje lo que dice es que se intent? crear un campo MARC con numero de campo vac?o. (por ejemplo, en vez de 020, vacio). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 14:34:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 12:34:35 +0000 Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 14:49:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 12:49:21 +0000 Subject: [Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |martin.renvoize at ptfs-europe | |.com CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 15:04:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 13:04:43 +0000 Subject: [Koha-bugs] [Bug 20772] Bib metadata pertaining to an ILL request should be editable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772 --- Comment #8 from Andrew Isherwood --- Created attachment 75563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75563&action=edit Bug 20772: Bug preventing backend JS execution We should be 'PROCESS'ing any backend JS, not 'INCLUDE'ing it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 15:07:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 13:07:27 +0000 Subject: [Koha-bugs] [Bug 20772] Bib metadata pertaining to an ILL request should be editable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 15:07:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 13:07:27 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20772 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772 [Bug 20772] Bib metadata pertaining to an ILL request should be editable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 15:11:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 13:11:30 +0000 Subject: [Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428 --- Comment #55 from Jonathan Druart --- (In reply to Narcis Garcia from comment #54) > Is "template_cache_dir" parameter affected by this issue? No > I have Koha 17.11 running on Debian 9 without this directive. Should I > enable it when following performance recommendations? Yes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 15:17:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 13:17:17 +0000 Subject: [Koha-bugs] [Bug 18163] Elasticsearch advanced search by item type not working with item-level_itypes turned off (biblio record) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 15:17:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 13:17:20 +0000 Subject: [Koha-bugs] [Bug 18163] Elasticsearch advanced search by item type not working with item-level_itypes turned off (biblio record) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163 --- Comment #4 from Nick Clemens --- Created attachment 75564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75564&action=edit Bug 18163: Unit tests prove -v t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 15:17:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 13:17:23 +0000 Subject: [Koha-bugs] [Bug 18163] Elasticsearch advanced search by item type not working with item-level_itypes turned off (biblio record) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163 --- Comment #5 from Nick Clemens --- Created attachment 75565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75565&action=edit Bug 18163: Pass through limits in ES Before these patches we only allow a small subset of indexes to be used as limits - if we are going to let users add new fields eventually we probably don't want to strip out terms we didn't plan for. To test: 1 - Enable ES 2 - Using sample kohadevbox data try a search like this (or adjust as necessary): http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=kw&idx=kw&idx=kw&limit=subject%2Cphr%3Astreet&sort_by=relevance&do=Search 3 - Note nothing is found 4 - Apply patches 5 - Repeat search 6 - It works! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 15:24:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 13:24:05 +0000 Subject: [Koha-bugs] [Bug 20772] Bib metadata pertaining to an ILL request should be editable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #9 from Andrew Isherwood --- Test plan: - Apply patches - Enable ILL - Ensure you have the FreeForm ILL backend available, a clone of the master branch here is required: https://github.com/PTFS-Europe/FreeForm - Create an request ILL using the FreeForm backend, populate as much metadata as possible, ensuring to also supply some custom fields - Save the request - On the "Manage ILL request" page for the newly created request, select the "Edit request metadata" - On the resulting edit page: => TEST: Ensure all entered metadata is displayed - Add new values, remove values, change values, including custom fields - Click "Update" - On the resulting "Manage ILL request": => TEST: Ensure all metadata fields reflect their changed values - Repeat the editing and updating process until you're happy it works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 15:27:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 13:27:49 +0000 Subject: [Koha-bugs] [Bug 20821] New: Elasticsearch - problems in using CQL in the search box directly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20821 Bug ID: 20821 Summary: Elasticsearch - problems in using CQL in the search box directly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com This was noted while testing bug 18163 In search box enter: ti:beckett samuel - works ti,phr: beckett samuel - same results title:beckett samuel - same results title,phr:becket samuel - no results ti:"beckett samuel" - no results title:"beckett samuel" - no results ti:"samuel beckett" - goes to record exactly title:"samuel beckett" - goes to record exactly ti,phr:"samuel beckett" - goes to record exactly title,phr:"samuel beckett" - no results -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 25 15:29:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 13:29:17 +0000 Subject: [Koha-bugs] [Bug 20821] Elasticsearch - problems in using CQL in the search box directly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20821 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com, | |claire.hernandez at biblibre.c | |om, | |ere.maijala at helsinki.fi, | |glasklas at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 16:29:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 14:29:10 +0000 Subject: [Koha-bugs] [Bug 20822] New: Can't find HOLD_SLIP template when printing. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20822 Bug ID: 20822 Summary: Can't find HOLD_SLIP template when printing. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: stefan.berndtsson at ub.gu.se QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Printing HOLD_SLIP from the Hold found modal can't find the template. In "returns.tt" the print action is sent "patron.borrowernumber", but the print-slip template parameters in "returns.pl" only include "borrowernumber" and "biblionumber", not "patron". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 25 16:31:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 14:31:34 +0000 Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #31 from Kyle M Hall --- > What happens? Somehow $session is already undef when you call track. If we > need to call CGI::Session->new($sessionID) each time, we do not really > benefit in terms of db access (well: 1 lookup in sessions instead of 1 in > borrowers). That would at least be changing from 1 write to 1 read, which is definitely an improvement, right? > Is there a different approach? What about using a cache key? (Do we want to > pollute the cache with keys for every session..) So you're suggesting storing something like -- my $cache = Koha::Caches->get_instance(); my $cache_key = "seen-for-session-$borrowernumber"; my $cached = $cache->get_from_cache($cache_key, { unsafe => 1}); unless ( $cached ) { $patron->track_login; $cache->set_in_cache($cache_key, 1); } -- If so, I think that works! Let me know and I'll submit a patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 16:33:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 14:33:50 +0000 Subject: [Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Development FY18 New System |Add ability to choose if |Preference |lost fee is refunded based | |on length of time item has | |been lost -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 16:34:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 14:34:30 +0000 Subject: [Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815 --- Comment #2 from Kyle M Hall --- (In reply to Katrin Fischer from comment #1) > Hi Kyle, can you explain what FY18 means? I have no idea, maybe JesseM does ; ) I have updated the title to actually describe the requires. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 16:47:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 14:47:11 +0000 Subject: [Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 16:50:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 14:50:42 +0000 Subject: [Koha-bugs] [Bug 20823] New: UNIMARC XSLT does not display 604$t Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 Bug ID: 20823 Summary: UNIMARC XSLT does not display 604$t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org In UNIMARC, 604 contains subfield t. Actual XSLT files use template tag_subject for 604, it does not use t subfield. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 25 16:50:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 14:50:54 +0000 Subject: [Koha-bugs] [Bug 20823] UNIMARC XSLT does not display 604$t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 17:05:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 15:05:54 +0000 Subject: [Koha-bugs] [Bug 20823] UNIMARC XSLT does not display 604$t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 --- Comment #1 from Fridolin SOMERS --- Created attachment 75566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75566&action=edit Bug 20823: UNIMARC XSLT add subfield t for subjects In UNIMARC, 604 contains subfield t, see http://multimedia.bnf.fr/unimarcb_trad/B604-6-2011.pdf. Actual XSLT files use template tag_subject for 604, it does not use t subfield. This patch adds subfield t to tag_subject and tag_onesubject templates in intranet and OPAC XSLT files. Test plan : 1) In UNIMARC catalog edit a biblio record to add 604$t 2) Use default XSLT files in sysprefs 2) Go to catalogue details page of this record using default XSLT files 3) Check $t is displayed at OPAC and intranet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 17:05:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 15:05:52 +0000 Subject: [Koha-bugs] [Bug 20823] UNIMARC XSLT does not display 604$t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 17:50:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 15:50:04 +0000 Subject: [Koha-bugs] [Bug 15296] MEMBER logging in action_logs does not give enough detail. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15296 --- Comment #3 from Caroline Cyr La Rose --- I agree that the info column doesn't give useful information. There is already a kind of diff in the cataloguing action_logs, which I find somewhat useful because it gives you the "biblio before" so you can compare and see what changed. It would be even better if there was the before / after but something similar would be a good first step for the patron file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 17:54:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 15:54:38 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #63 from Koha Team Lyon 3 --- Bonjour Alex, J'?tais parti, le coeur plein d'entrain, pour une nouvelle s?ance de test sur la nouvelle mouture de ton patch (tu as d? te r?galer..), mais apr?s mise ? jour d'une master de test que j'ai sur vbox (qu'avait pas servi depuis la derni?re fois), je me retrouve avec un affichage d?glingu? et je constate que koha cherche ? charger les css et js en leur ajoutant un suffixe 18.0500000 (?a ressemble ? la date de mise ? jour du patch ?!) : http://preprod:8080/intranet-tmpl/prog/css/staff-global_18.0500000.css Soit j'ai fait une grosse bourde, soit il y a quelque chose qui m'?chappe (voire m?me les deux d'ailleurs ). ?a te parle ? Olivier -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 19:15:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 17:15:12 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #71 from David Gustafsson --- Forgot to change status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 19:15:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 17:15:26 +0000 Subject: [Koha-bugs] [Bug 15276] Add documentation for Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15276 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 19:52:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 17:52:24 +0000 Subject: [Koha-bugs] [Bug 18250] koha-common should start after memcached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 --- Comment #15 from Mirko Tietgen --- Testplan does not work apply to systemd. However the patch still works, systemd generates a target file /run/systemd/generator.late/multi-user.target.wants/koha-common.service Without patches ># Automatically generated by systemd-sysv-generator > >[Unit] >Documentation=man:systemd-sysv-generator(8) >SourcePath=/etc/init.d/koha-common >Description=LSB: Start required services for each Koha instance >Before=multi-user.target >Before=multi-user.target >Before=multi-user.target >Before=graphical.target >After=remote-fs.target [?] With the patches applied I get ># Automatically generated by systemd-sysv-generator > >[Unit] >Documentation=man:systemd-sysv-generator(8) >SourcePath=/etc/init.d/koha-common >Description=LSB: Start required services for each Koha instance >Before=multi-user.target >Before=multi-user.target >Before=multi-user.target >Before=graphical.target >After=remote-fs.target >After=memcached.service [?] which means the patches do what they are supposed to do. I don't know if we have an official policy regarding SysVinit vs. systemd. As far as I can see we rely on the backwards compatibility provided by systemd in other places too. I'll send a signoff and consider to bundle it together with bug 17311 for a 18.05.00-2 release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 19:52:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 17:52:56 +0000 Subject: [Koha-bugs] [Bug 18250] koha-common should start after memcached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |helix84 at centrum.sk --- Comment #16 from Mirko Tietgen --- *** Bug 20820 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 19:52:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 17:52:56 +0000 Subject: [Koha-bugs] [Bug 20820] koha fails to connect to memcached until restart after debian package upgrade 17.11.06-1 -> 18.05.00-1 on Ubuntu Xenial 16.04 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20820 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Mirko Tietgen --- *** This bug has been marked as a duplicate of bug 18250 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri May 25 19:59:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 17:59:15 +0000 Subject: [Koha-bugs] [Bug 17311] koha-common service should be restarted on upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17311 --- Comment #3 from Mirko Tietgen --- I'll send a patch that stops koha-common in preinst and starts it at the end of postinst. I'd like to do a 18.05.00-2 together with bug 18250. Together that should take care of stopping, starting memcached, koha-common (incl. plack) and apache. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 20:51:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 18:51:09 +0000 Subject: [Koha-bugs] [Bug 20824] New: Display of cancelled Orders show up in Acquisitions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20824 Bug ID: 20824 Summary: Display of cancelled Orders show up in Acquisitions Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Currently, any orders that have been cancelled will show up in Acquisitions (basket.pl). It would be nice from a display side, to have this view (cancelled orders ) be collapsed so if needed, they are still viewable, but generally they do not appear on this screen. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 20:58:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 18:58:47 +0000 Subject: [Koha-bugs] [Bug 20763] AllowPurchaseSuggestionBranchChoice triggers error opac-suggestions.pl is visited without logging in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20763 pierre-luc.lapointe at inLibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75302|0 |1 is obsolete| | --- Comment #2 from pierre-luc.lapointe at inLibro.com --- Created attachment 75567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75567&action=edit Bug 20763: AllowPurchaseSuggestionBranchChoice triggers error opac-suggestions.pl is visited without logging in Some code executed in the script opac-suggestions.pl if the system preference AllowPurchaseSuggestionBranchChoice is enabled assumes there is a logged in user. If there is not, patrons will see the error "Internal Server Error". Test Plan: 1) Enable AllowPurchaseSuggestionBranchChoice 2) Enable AnonSuggestions 3) In the OPAC, perform a search that will have no results, click the "Make a purchase suggestion" link. 4) Note the error 5) Apply this patch 6) Reload the page 7) The page should load now! Signed-off-by: Pierre-Luc Lapointe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 21:08:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 19:08:45 +0000 Subject: [Koha-bugs] [Bug 3886] Can't print receipt w/out allowing "Add or modify borrowers" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3886 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |charles.farmer at inlibro.com --- Comment #7 from Charles Farmer --- Works as advertised, though I had to manually enter the print-summary URL in order to test, since my borrower only had the 'catalogue' and either 'circulate' or 'circulate_remaining_permissions' and couldn't directly visit moremember.pl. Are there any other pages available to a patron with such narrow permissions where the printslip button appears? Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 21:08:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 19:08:52 +0000 Subject: [Koha-bugs] [Bug 20763] AllowPurchaseSuggestionBranchChoice triggers error opac-suggestions.pl is visited without logging in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20763 Pierre-Luc Lapointe changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |pierre-luc.lapointe at inLibro | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 21:10:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 19:10:34 +0000 Subject: [Koha-bugs] [Bug 3886] Can't print receipt w/out allowing "Add or modify borrowers" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3886 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75350|0 |1 is obsolete| | --- Comment #8 from Charles Farmer --- Created attachment 75568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75568&action=edit Bug 3886: Fix mismatch of required permissions for printing slips - Print summary (summary-print.pl) - Print quick slip (printslip.pl) - Print slip (printslip.pl) - Print overdues (print_overdues.pl) Perl scripts all require circulate_remaining_permissions, while in the template we were checking for edit_borrowers. Now the print pull down will only be visible if the patron has circulate or circulate_remaining_permissions. To test: - Verify that printing the listed slips works for staff users with either circulate or circulate_remaining_permissions and without edit_borrowers. Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 21:30:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 19:30:40 +0000 Subject: [Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 21:30:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 19:30:44 +0000 Subject: [Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25672|0 |1 is obsolete| | Attachment #73617|0 |1 is obsolete| | --- Comment #65 from Charles Farmer --- Created attachment 75569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75569&action=edit Bug 8962: Changes to CCL.properties, bib1 for authorities, and templates This patch adds a new index Anywhere in ccl.properties in bib1 for authorities, and add "any word" option in intranet search for using this index. Default OPAC and intranet search in still using CCL "Any" index. Testing plan : In a Marc21 GRS-1 Koha : 1/ make some biblio searches without selecting any index (Koha will use "any" index) and note the results. Ex : search "fre", "eng", "book", "history", "history book" 2/ apply the 3 patches 3/ copy the 4 new record.abs files (Marc21 auth, Marc21 bib, Unimarc auth, Unimarc bib) from your sources to the directory used by Zebra configuration in your Koha instance 4/ launch rebuild_zebra.pl -b -r -x -v 5/ check that a new choice "Any word (all indexes)" is visible in advanced search. 6/ make the same searches as 1/ : you should see less results (detailed test plan in patchs 2 and 3) 7/ in Staff interface adavanced search, select "Any word (all indexes)" and make the same searches as 1/ : you should see the same results (maybe with a slight differences, because more notes fields are indexed in Marc21) In a UNIMARC GRS-1 Koha : same test Signed-off-by: Martin Renvoize Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 21:30:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 19:30:51 +0000 Subject: [Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73618|0 |1 is obsolete| | --- Comment #66 from Charles Farmer --- Created attachment 75570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75570&action=edit Bug 8962: Restore Any index behavior and add Anywhere index The "Any" index/register should contains all the data contained in all the other indexes/registers (e.g. Title, Author, Subject, etc). The "Anywhere" index/register should contain the entire record including fields/subfields that aren't indexed anywhere else. In GRS1 indexing the Any index was indeed only on fields defined as indexed. This has changed in DOM where all data in MARC is indexed with Any. This generates a lot of results when no index is defined in search. This patch changes the DOM xsl config generation to add Any to each indexed data and add Anywhere to keep a way of searching on all data. Test plan : - Add a data on a field that is not indexed : for example "toto" in 998$z - Add same data as the title of another record - Index the records - Search on toto without index (uses Any) => you get the 2 records - Search on toto with title index => you get the record with "toto" as title - Apply patch - Update DOM xsl config files - Reindex - Search on toto without index (uses Any) => you get the record with "toto" as title - Search on toto with title index => you get the record with "toto" as title - Search on toto with Anywhere index => you get the 2 records Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 21:31:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 19:31:22 +0000 Subject: [Koha-bugs] [Bug 20652] Sort After Item Type Search Fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20652 Pierre-Luc Lapointe changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74822|0 |1 is obsolete| | --- Comment #3 from Pierre-Luc Lapointe --- Created attachment 75571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75571&action=edit Bug 20652: Fix result sorting after search on limit only 1 chomp was missing, spaces were replaced with %20 This patch adds extra chomps, but it does not hurt Test plan: Advanced Search Choose an Item type (do not enter any other search limits) Search Click on Sort (it doesn't appear to matter what you sort on) Signed-off-by: Pierre-Luc Lapointe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 21:31:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 19:31:42 +0000 Subject: [Koha-bugs] [Bug 20652] Sort After Item Type Search Fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20652 Pierre-Luc Lapointe changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre-luc.lapointe at inLibro | |.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 21:33:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 19:33:35 +0000 Subject: [Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 --- Comment #67 from Charles Farmer --- Had to remove the firstmost patch named "[SIGNED OFF] Changes to CCL.properties ...". Nothing lost, however, since it looked like a patch that was rebased but not obsoleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 23:12:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 21:12:27 +0000 Subject: [Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 23:12:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 21:12:31 +0000 Subject: [Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75548|0 |1 is obsolete| | --- Comment #23 from Charles Farmer --- Created attachment 75572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75572&action=edit Bug 12759: Use a list (shelf) for batch record modification and deletion To test: 1) Create a list, add a record to it by its barcode that you don't mind deleting 2) Go to Tools -> Batch record modification 3) Select the record type 'Authorities'. Confirm the dropdown to select a list disappears. Confirm selecting 'Biblios' makes the dropdown show again. 4) Select the list from the dropdown, select a modification template, Continue 5) Confirm all of the records in that list show on the page. Click Modify selected records. Confirm this is successful. 6) Go to Batch record deletion 7) Select the record type 'Authorities'. Confirm the dropdown to select a list disappears. Confirm selecting 'Biblios' makes the dropdown show again. 8) Select the list from the dropdown and click Continue 9) Confirm all of the records in that list show on the page. Click Delete selected records. Confirm this is successful. 10) Go back to your lists. The list should still exist but it will now be empty. Sponsored-by: Catalyst IT NOTE: Rebased to work -- Mark Tompsett Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 23:48:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 21:48:33 +0000 Subject: [Koha-bugs] [Bug 13667] Provide script to regularly clean deletedborrowers table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 23:48:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 21:48:45 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 23:50:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 21:50:52 +0000 Subject: [Koha-bugs] [Bug 18003] Should deletedborrowers.borrowernumber be a primary key? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18003 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 23:51:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 21:51:41 +0000 Subject: [Koha-bugs] [Bug 20024] Backup files should be encrypted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20024 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 23:52:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 21:52:01 +0000 Subject: [Koha-bugs] [Bug 20026] Add new permission related to personal data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20026 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 23:52:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 21:52:39 +0000 Subject: [Koha-bugs] [Bug 20027] Generate password at patron detail edit page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20027 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 23:53:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 21:53:10 +0000 Subject: [Koha-bugs] [Bug 20028] Export all patron related personal data in one package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 23:53:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 21:53:41 +0000 Subject: [Koha-bugs] [Bug 20604] Provide a way to anonymise patron records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20604 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 23:53:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 21:53:50 +0000 Subject: [Koha-bugs] [Bug 7651] Add separate permission for managing currencies and exchange rates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 23:53:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 21:53:53 +0000 Subject: [Koha-bugs] [Bug 7651] Add separate permission for managing currencies and exchange rates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75452|0 |1 is obsolete| | --- Comment #10 from Charles Farmer --- Created attachment 75573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75573&action=edit Bug 7651: Add a new permission for managing currencies and exchange rates At the moment staff users need parameters or parameters_remaining_permissions in order to be able to change exchange rates for acquisition orders. This patch adds a new separate permission currencies_manage and updates staff users currently having those permissions to get the new permission as well. To test: - Create some staff users with different permission sets 1) superlibrarian 2) parameters 3) parameters_remaining_permissions 4) manage_circ_rules, but not parmeters_remaining_permissions 5) all acquisition permissions - Apply patch and run database update - Verify new permission has been added and staff users updated 1) remains the same 2) + 3) will have currencies_manage 4) remains unchanged, doesn't have new permission 5) remains the same, will have access now because of having the top level acquisition permission - Verify the changed pages work correctly: - navigation on admin home page NOTE: the acquisition parameters section will now honor all different related permissions (edi_manage, budget_manage,...) - navigation on acquisition home page - try to access currencies page directly https://bugs.koha-community.org/show_bug.cgi?id=3849 Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 23:53:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 21:53:58 +0000 Subject: [Koha-bugs] [Bug 20605] Make possible to set patron's privacy from staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20605 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 23:53:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 21:53:58 +0000 Subject: [Koha-bugs] [Bug 7651] Add separate permission for managing currencies and exchange rates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75517|0 |1 is obsolete| | --- Comment #11 from Charles Farmer --- Created attachment 75574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75574&action=edit Bug 7651: (follow-up) Correct visibility on admin sidebar This patch corrects visibility of links to the different acquisition pages from the admin sidebar. It also makes a correction to the links on the acq start page: - Budgets = period_manage - Funds = budget_manage To test: - Follow the test plan of the first patch Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 23:54:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 21:54:24 +0000 Subject: [Koha-bugs] [Bug 20606] Add the age column to statistics table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20606 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 23:54:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 21:54:46 +0000 Subject: [Koha-bugs] [Bug 20645] Print patrons before anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20645 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 23:55:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 21:55:18 +0000 Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 23:56:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 21:56:05 +0000 Subject: [Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 25 23:59:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 May 2018 21:59:07 +0000 Subject: [Koha-bugs] [Bug 7651] Add separate permission for managing currencies and exchange rates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer at inlibro.com --- Comment #12 from Charles Farmer --- Went through the test plan with all 5 users and their respective permissions. Only the fourth account, manage_circ_rules sans parmeters_remaining_permissions, couldn't access the 'currencies' page after update. Every other account gain access to 'Acquisitions' page, as described in the test plan. With the newest follow-up patch, I only saw two hyperlinks, 'Acqui home' and 'Currencies', when using accounts with restrictive permission sets. Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 26 04:00:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 May 2018 02:00:29 +0000 Subject: [Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428 Eugene Espinoza changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eugenegf at yahoo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 26 04:38:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 May 2018 02:38:22 +0000 Subject: [Koha-bugs] [Bug 17215] Cardnumbers of patrons created using LDAP Replication not using autoMemberNum if configured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 --- Comment #18 from Lee Jamison --- Can anyone confirm if this is still relevant? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 26 04:40:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 May 2018 02:40:01 +0000 Subject: [Koha-bugs] [Bug 20787] System preference missing from manual - UseACQFrameworkForBiblioRecords In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20787 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #2 from Lee Jamison --- This system preference has been added to the 18.05 documentation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 26 11:28:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 May 2018 09:28:10 +0000 Subject: [Koha-bugs] [Bug 20824] Display of cancelled Orders show up in Acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20824 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 26 13:38:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 May 2018 11:38:33 +0000 Subject: [Koha-bugs] [Bug 18250] koha-common should start after memcached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 26 23:11:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 May 2018 21:11:52 +0000 Subject: [Koha-bugs] [Bug 18973] Auto focus the ISBN field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18973 --- Comment #3 from Father Vlasie --- Is there something more I need to do to get this feature pushed to the release version? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 27 07:26:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 May 2018 05:26:02 +0000 Subject: [Koha-bugs] [Bug 9290] Restricting patron category for online purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9290 Suresh Kumar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tejoskumar at gmail.com --- Comment #10 from Suresh Kumar --- please ignore the comment if this is already worked - I thought this way - system Preference - Workflow or any one can suggest Any one can suggest - Already existing feature Workflow - Member logs into his account - clicks on suggestions System should check for supervisor details (like cardnumber or any other details like mail - if supervisor is not a member) Then after filling the details - the system will submit request to his supervisor for approval - once the supervisor approves the request, it should reach the library for procurement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 27 18:32:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 May 2018 16:32:13 +0000 Subject: [Koha-bugs] [Bug 20825] New: The method is not covered by tests! Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 Bug ID: 20825 Summary: The method is not covered by tests! Change sponsored?: --- Product: Koha Version: master Hardware: HP OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: sergeinik at tut.by QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 75575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75575&action=edit Message in browser When I try to issue an instance and enter a barcode, the program displays the following message: Software error: The method is not covered by tests! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 27 18:33:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 May 2018 16:33:12 +0000 Subject: [Koha-bugs] [Bug 20825] The method is not covered by tests! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 sergeinik changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://admin-lib.cxbe.by/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 27 18:34:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 May 2018 16:34:35 +0000 Subject: [Koha-bugs] [Bug 20825] The method is not covered by tests! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 sergeinik changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |critical -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 27 18:35:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 May 2018 16:35:37 +0000 Subject: [Koha-bugs] [Bug 20825] The method is not covered by tests! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 --- Comment #1 from sergeinik --- Created attachment 75576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75576&action=edit barcode input -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun May 27 23:34:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 May 2018 21:34:14 +0000 Subject: [Koha-bugs] [Bug 20826] New: Error during initial setup Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20826 Bug ID: 20826 Summary: Error during initial setup Change sponsored?: --- Product: Koha Version: master Hardware: PC OS: Linux Status: NEW Severity: blocker Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: mrushizha at outlook.com QA Contact: testopia at bugs.koha-community.org I am new to both Linux and Koha. I have been trying to install Koha on a new installation of Ubuntu Linux 16.04.4 LTS Desktop 32-bit. I ran the following preparation commands without any problem: sudo apt-get update sudo apt-get upgrade sudo echo deb http://debian.koha-community.org/koha stable main | sudo tee /etc/apt/sources.list.d/koha.list sudo wget -O- http://debian.koha-community.org/koha/gpg.asc | sudo apt-key add - sudo apt-get update sudo apt-get upgrade sudo apt-get clean I ran the install command and I never got passed it: sudo apt-get install koha-common All I am getting is the following: diasha at DIASHA-UBUNTU:~$ sudo apt-get install koha-common [sudo] password for diasha: Reading package lists... Done Building dependency tree Reading state information... Done Some packages could not be installed. This may mean that you have requested an impossible situation or if you are using the unstable distribution that some required packages have not yet been created or been moved out of Incoming. The following information may help to resolve the situation: The following packages have unmet dependencies: koha-common : Depends: libnet-oauth2-authorizationserver-perl but it is not going to be installed E: Unable to correct problems, you have held broken packages. I have Googled this and and I also did a clean re-installation of Ubuntu and tried to install Koha to no avail. I am looking forward to your response. Regards, Michael -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 28 04:38:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 02:38:11 +0000 Subject: [Koha-bugs] [Bug 20197] Missing rfc3339 in systempreference choices for dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20197 Dilan Johnpull? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71617|0 |1 is obsolete| | --- Comment #2 from Dilan Johnpull? --- Created attachment 75577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75577&action=edit Bug 20197: RFC3339 missing from options The output_pref in Koha::DateUtils has rfc3339 logic, but there is no way to set the system preference to rfc3339. This adds that option. TEST PLAN ---------- 0) back up your DB if you wish. 1) apply this patch. 2) Run the following commands: $ mysql -u koha_kohadev -p > use koha_kohadev; > SELECT options FROM systempreferences WHERE variable='dateformat'; -- no rfc3339 listed. 3) Run the following commands: > quit $ updatedatabase $ mysql -u koha_kohadev -p > use koha_kohadev; > SELECT options FROM systempreferences WHERE variable='dateformat'; -- rfc3339 now listed. 4) Run the following commands: > quit $ reset_all $ mysql -u koha_kohadev -p > use koha_kohadev; > SELECT options FROM systempreferences WHERE variable='dateformat'; -- rfc3339 still listed. 5) Log into the staff client 6) Home -> Administration -> Global System Preferences -> i18n/l10n -- rfc3339 should be listed in the dateformat syspref drop-down. 7) run koha qa test tools 8) restore DB if needed Followed test plan and everything checks out. Syspref appears as another yyy-mm-dd entry though. Signed-off-by: Dilan Johnpull? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 04:38:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 02:38:58 +0000 Subject: [Koha-bugs] [Bug 20197] Missing rfc3339 in systempreference choices for dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20197 Dilan Johnpull? changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dilan at calyx.net.au Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 07:56:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 05:56:26 +0000 Subject: [Koha-bugs] [Bug 20822] Can't find HOLD_SLIP template when printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20822 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Can't find HOLD_SLIP |Can't find HOLD_SLIP |template when printing. |template when printing Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 28 07:57:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 05:57:44 +0000 Subject: [Koha-bugs] [Bug 20825] The method is not covered by tests! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Can you please check your item has a valid itemtype, homebranch and what is set in the not for loan status? What is the exact version of Koha you are using? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 28 07:59:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 05:59:30 +0000 Subject: [Koha-bugs] [Bug 20808] I cant install Koha on Ubuntu 18.04 LTS (Bionic Beaver) - Unmet dependences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20808 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 08:00:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 06:00:32 +0000 Subject: [Koha-bugs] [Bug 20771] Incorrect wording on branch-specific notice setup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20771 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |ldjamison at marywood.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 08:01:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 06:01:04 +0000 Subject: [Koha-bugs] [Bug 20761] Advanced Cataloging Editor - Rancor - Some js files are not fetched using Asset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20761 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 08:04:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 06:04:17 +0000 Subject: [Koha-bugs] [Bug 20825] The method is not covered by tests! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 --- Comment #3 from sergeinik --- 18.05.00.000 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 08:04:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 06:04:59 +0000 Subject: [Koha-bugs] [Bug 20825] The method is not covered by tests! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 --- Comment #4 from sergeinik --- Created attachment 75578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75578&action=edit 18.05.00.000 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 08:07:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 06:07:14 +0000 Subject: [Koha-bugs] [Bug 20826] Error during initial setup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20826 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |mirko at abunchofthings.net --- Comment #1 from Katrin Fischer --- Hi Michael, bugzilla is used to report bugs and enhancement requests, I think your question might be more related to setup/installation. Can you please ask on the mailing list instead? A lot more people will read it there and will hopefully be able to help you. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 08:08:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 06:08:06 +0000 Subject: [Koha-bugs] [Bug 20825] The method is not covered by tests! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 --- Comment #5 from sergeinik --- This happened when the program was updated to the latest version. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 28 08:08:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 06:08:46 +0000 Subject: [Koha-bugs] [Bug 20825] The method is not covered by tests! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 --- Comment #6 from Katrin Fischer --- Can you also share a screenshot of your item please? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 08:13:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 06:13:57 +0000 Subject: [Koha-bugs] [Bug 20825] The method is not covered by tests! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 --- Comment #7 from sergeinik --- Created attachment 75579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75579&action=edit item -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 08:14:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 06:14:11 +0000 Subject: [Koha-bugs] [Bug 20825] The method is not covered by tests! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 --- Comment #8 from sergeinik --- Created attachment 75580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75580&action=edit item -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 28 08:17:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 06:17:24 +0000 Subject: [Koha-bugs] [Bug 20825] The method is not covered by tests! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 --- Comment #9 from sergeinik --- In version 17.11, the release works, but the return does not work, and in version 18.05 the output does not work, but the return works. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 28 08:19:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 06:19:35 +0000 Subject: [Koha-bugs] [Bug 20825] The method is not covered by tests! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 --- Comment #10 from sergeinik --- And literally three days ago everything worked. But when the latest updates came one by one, everything broke. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 09:57:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 07:57:25 +0000 Subject: [Koha-bugs] [Bug 18948] Reindexing should use aliases to avoid down time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18948 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala at helsinki.fi --- Comment #10 from Ere Maijala --- I'd like to see an option that uses the existing index also when reindexing all records. In my experience there are cases where you want to see the changes as soon as possible and not wait until the whole indexing process is complete. Testing indexing is just one of them but pretty important during development. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 10:29:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 08:29:25 +0000 Subject: [Koha-bugs] [Bug 20808] I cant install Koha on Ubuntu 18.04 LTS (Bionic Beaver) - Unmet dependences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20808 --- Comment #1 from Mirko Tietgen --- The files are missing in Ubuntu 18.04, but they are in the Koha community repository and should be pulled automatically during installation. Could you please give the output of apt-cache policy libmarc-charset-perl and apt-cache policy libmarc-xml-perl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 10:32:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 08:32:55 +0000 Subject: [Koha-bugs] [Bug 20826] Error during initial setup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20826 --- Comment #2 from Mirko Tietgen --- The file is in the Koha community repository and should be pulled automatically during installation. Could you please give the output of apt-cache policy libnet-oauth2-authorizationserver-perl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 10:36:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 08:36:26 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20073 --- Comment #52 from Ere Maijala --- I hope we can get bug 20073 sorted swiftly since this depends on it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 [Bug 20073] Move Elasticsearch settings to configuration files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 10:36:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 08:36:26 +0000 Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19893 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 [Bug 19893] Alternative optimized indexing for Elasticsearch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 10:37:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 08:37:12 +0000 Subject: [Koha-bugs] [Bug 20652] Sort After Item Type Search Fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20652 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 10:37:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 08:37:16 +0000 Subject: [Koha-bugs] [Bug 20652] Sort After Item Type Search Fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20652 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75571|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 75581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75581&action=edit Bug 20652: Fix result sorting after search on limit only 1 chomp was missing, spaces were replaced with %20 This patch adds extra chomps, but it does not hurt Test plan: Advanced Search Choose an Item type (do not enter any other search limits) Search Click on Sort (it doesn't appear to matter what you sort on) Signed-off-by: Pierre-Luc Lapointe Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 10:44:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 08:44:46 +0000 Subject: [Koha-bugs] [Bug 20808] I cant install Koha on Ubuntu 18.04 LTS (Bionic Beaver) - Unmet dependences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20808 --- Comment #2 from Mirko Tietgen --- Which version of Koha are you trying to install? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 10:47:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 08:47:32 +0000 Subject: [Koha-bugs] [Bug 20272] XSLT_Handler should use alphanumeric error codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20272 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72916|0 |1 is obsolete| | --- Comment #6 from Chris Cormack --- Created attachment 75582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75582&action=edit Bug 20272: Replace error numbers by codes in XSLT_Handler We remove the error numbers 1 to 7 by readable codes. And remove the errstr attribute (not used widely). Make XSLT_Handler a little bit less noisy by defaulting print_warns to false unless $ENV{DEBUG} is set. (See also bug 19018). The unit has been changed accordingly. (A few warnings are no longer tested.) Test plan: Run t/db_dependent/XSLT_Handler.t Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 10:47:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 08:47:53 +0000 Subject: [Koha-bugs] [Bug 20272] XSLT_Handler should use alphanumeric error codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20272 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 10:47:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 08:47:57 +0000 Subject: [Koha-bugs] [Bug 20272] XSLT_Handler should use alphanumeric error codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20272 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72917|0 |1 is obsolete| | --- Comment #7 from Chris Cormack --- Created attachment 75583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75583&action=edit Bug 20272: Changes for Breeding.pm and Record.pm In Breeding.pm we let Z3950Search return the xslt handler error codes back to the template. They are converted to text messages by using an new include file (added for opac and intranet now). The generic xslt_err code is now obsoleted. In Record.pm the errstr call is removed. The croak is done with the new error code in err. This seems sufficient. Test plan: [1] Run Breeding.t [2] Run Record.t [3] Add a nonexisting xslt file to one of your Z3950 targets. Search on that target and check if you see a error 'XSLT file not found'. The bonus is these error messages are now translatable as they are in the templates Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 10:59:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 08:59:22 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #64 from Alex Arnaud --- (In reply to Koha Team Lyon 3 from comment #63) > Bonjour Alex, > J'?tais parti, le coeur plein d'entrain, pour une nouvelle s?ance de test > sur la nouvelle mouture de ton patch (tu as d? te r?galer..), mais apr?s > mise ? jour d'une master de test que j'ai sur vbox (qu'avait pas servi > depuis la derni?re fois), je me retrouve avec un affichage d?glingu? et je > constate que koha cherche ? charger les css et js en leur ajoutant un suffixe > 18.0500000 (?a ressemble ? la date de mise ? jour du patch ?!) : > http://preprod:8080/intranet-tmpl/prog/css/staff-global_18.0500000.css > Soit j'ai fait une grosse bourde, soit il y a quelque chose qui m'?chappe > (voire m?me les deux d'ailleurs ). ?a te parle ? > > Olivier Hello Olivier, You have to update web server's rewrite rules. See bug 20187. For apache, it is: RewriteRule ^(.*)_[0-9][0-9]\.[0-9][0-9][0-9][0-9][0-9][0-9][0-9].js$ $1.js [L] RewriteRule ^(.*)_[0-9][0-9]\.[0-9][0-9][0-9][0-9][0-9][0-9][0-9].css$ $1.css [L] Nginx: rewrite "^(.*)_[0-9]{2}\.[0-9]{7}\.(js|css)$" $1.$2; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 11:08:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 09:08:07 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #53 from Ere Maijala --- David, $serialization_format needs a default value in the code, I think (but see below). Otherwise, unless you go and save the ElasticsearchMARCSerializationFormat pref once, the search results show up empty and you'll get a lot of "uninitialized value" warnings from the following line: if ($serialization_format eq 'base64ISO2709') { I also believe that "$record->as_usmarc()" will carp and set the record length to 99999 if the record ends up being too long. If you made reading the index autodetect between ISO2709 and MARCXML, you could use MARCXML as the fallback format when ->as_usmarc() carps. So the ISO2709 format would be used whenever possible and MARCXML would only be used for large records. And you could get rid of the ElasticsearchMARCSerializationFormat pref. This would be my preferred method at the moment, since ISO2709 saves time and space but large records need to be supported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 11:08:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 09:08:28 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 11:50:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 09:50:45 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #54 from David Gustafsson --- Thanks for the review and good suggestions. I agree the hybrid method seems the best, could also save a marc_format so format does not have to be detected. I have also considered the two option you mentioned, storing the whole marc record as json or skip storing it all together. The later could possibly be an option (for those wanting to keep index size small), the former would be really and would like to see implemented so could be the subject for a future bug. The catamandu json serialization format is pretty useless for querying and analysis, but it probably not take that much work to write a marc to json direct conversion which allowed you to make queries like 100.a:"Tolkien, J. R. R.". I would also like to use Kibana for analysis and for that to be useful you would have t have the marc data available as structured json. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 12:10:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 10:10:31 +0000 Subject: [Koha-bugs] [Bug 13560] Add an 'Add' option in MARC modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71115|0 |1 is obsolete| | --- Comment #20 from Chris Cormack --- Created attachment 75584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75584&action=edit Bug 13560 - Database changes Signed-off-by: Victor Grousset Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 12:10:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 10:10:51 +0000 Subject: [Koha-bugs] [Bug 13560] Add an 'Add' option in MARC modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71116|0 |1 is obsolete| | --- Comment #21 from Chris Cormack --- Created attachment 75585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75585&action=edit Bug 13560 - Unit tests To test: 1 - apply all patches 2 - update database 3 - prove t/db_dependent/MarcModificationTemplates.t Signed-off-by: Victor Grousset Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 12:11:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 10:11:13 +0000 Subject: [Koha-bugs] [Bug 13560] Add an 'Add' option in MARC modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 12:11:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 10:11:18 +0000 Subject: [Koha-bugs] [Bug 13560] Add an 'Add' option in MARC modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71117|0 |1 is obsolete| | --- Comment #22 from Chris Cormack --- Created attachment 75586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75586&action=edit Bug 13560: Add an 'Add' option for marc modification templates Add/Update would update a field or create new if it existed, but didn't allow for creating new if the field existed. This patchset splits the options to 'Add & Update' so that 'Add' will always add a field and 'Update' will operate as it always has To test: 1 - Have a record with a known existing field (make a copy) 2 - Define a marc modification template that 'Add/update' on that field 3 - Define an 'Add/Update' on a field that doesn't exist 4 - Batch modify the copy of record using the above template 5 - Verify the existing field was updated 6 - Verify the non-existing field was updated 7 - Apply patch and update database 8 - Make another copy 9 - Modify the copy with the same template as above 10 - Should match initial modification 11 - Add a new rule to add a new field 12 - Modify using the updated template 13 - Ensure your new field is created 14 - Test various options in the modification tool 15 - prove t/db_dependent/MarcModificationTemplates.t Signed-off-by: Victor Grousset Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 13:15:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 11:15:50 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #55 from Mirko Tietgen --- (In reply to David Gustafsson from comment #44) > Ok! I think these were the versions: > > libcatmandu-marc-perl 0.215-1 > libcatmandu-perl 1.0304-2~kohadev1 > libcatmandu-store-elasticsearch-perl 0.0507-1~kohadev1 The versions are rather old. So far nobody asked about newer versions or complained about their performance. The changelog for Catmandu lists performance improvements in later versions. I have packaged newer versions in a new 'experimental' repository. I hope it has all dependencies. deb http://debian.koha-community.org/koha experimental main I don't have time to run tests or try the patches at the moment, but maybe you could run your benchmarks with the newer versions to see if it makes a difference? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 13:17:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 11:17:55 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #56 from Mirko Tietgen --- (In reply to Nick Clemens from comment #34) > Can you send something to the koha-dev mailing list and add this as a topic > for the next Developers meeting David? > > In a situation like this we should check for differing opinions or see if > there are concerns others might have, and then we can vote at the meeting to > move ahead. > > I think this the way to go, one less dependency makes it easier to maintain I am not necessarily a fan of dropping dependencies. I think it is part of Perl to use other modules instead of reinventing everything. Regarding Catmandu, the developers are very dedicated and we will profit from future developments without investing Koha developer time, while a change to our own solution might help with performance now but might not be touched again for a long time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 13:32:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 11:32:57 +0000 Subject: [Koha-bugs] [Bug 20827] New: Can't add owner to a fund Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20827 Bug ID: 20827 Summary: Can't add owner to a fund Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When selecting a patron to add as an owner to a acquisition fund, nothing happens. To test. - Create a fund - Click 'select owner' - Search for a patron - Click 'select' -> nothing happens, the owner is not added to the fund. Adding users works as expected. Tested with 17.11.06. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 14:47:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 12:47:57 +0000 Subject: [Koha-bugs] [Bug 18948] Reindexing should use aliases to avoid down time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18948 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 14:49:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 12:49:55 +0000 Subject: [Koha-bugs] [Bug 20827] Can't add owner to a fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20827 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 14:50:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 12:50:19 +0000 Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #32 from Jonathan Druart --- Before continuing here I think we should first confirm that the code is the cause of the problem. I have talked with Nick last month and it seemed that it came from somewhere else: """ Errors in the logs "DBD::mysql::db begin_work failed: Already in a transaction" - it seemed to increase during heavy circ periods - DB was slowed by constant hits and then clashes """ It does not sound related to this code, but more to rebuild_zebra.pl that uses AutoCommit instead of a DBIC transaction. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 15:36:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 13:36:58 +0000 Subject: [Koha-bugs] [Bug 20808] I cant install Koha on Ubuntu 18.04 LTS (Bionic Beaver) - Unmet dependences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20808 --- Comment #3 from Paul --- I tried to install koha-common:all/stable 17.11.05-1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 28 15:49:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 13:49:21 +0000 Subject: [Koha-bugs] [Bug 20652] Sort after item type search fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20652 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Sort After Item Type Search |Sort after item type search |Fails |fails CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 15:52:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 13:52:36 +0000 Subject: [Koha-bugs] [Bug 20825] The method is not covered by tests! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 28 15:56:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 13:56:14 +0000 Subject: [Koha-bugs] [Bug 20825] The method is not covered by tests! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19943 --- Comment #11 from Jonathan Druart --- Caused by commit 6183c0e6a910663fec02bdba66d05f173310f562 Bug 19943: Koha::Biblio - Replace GetBiblioItemData with Koha::Biblio->biblioitem It happens when item types are defined at biblio level. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943 [Bug 19943] Koha::Biblio - Remove GetBiblioItemData -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 15:56:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 13:56:14 +0000 Subject: [Koha-bugs] [Bug 19943] Koha::Biblio - Remove GetBiblioItemData In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 [Bug 20825] The method is not covered by tests! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 16:09:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 14:09:04 +0000 Subject: [Koha-bugs] [Bug 18250] koha-common should start after memcached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61034|0 |1 is obsolete| | --- Comment #17 from Mirko Tietgen --- Created attachment 75587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75587&action=edit Bug 18250: Update LSB block of koha-common init script Currently koha-common may start before memcached. We should prevent that. If we add memcached to the LSB section of the koha-common init script, Debian's insserv will know about this requirement. Note: This patch is only a step in resolving the issue. Test plan: [1] Copy the updated koha-common script to /etc/init.d [2] Look for S..koha-common and S..memcached in /etc/rcX.d (say X=5) [3] Run sudo update-rc.d koha-common disable [4] Run sudo update-rc.d koha-common enable [5] Look again for S..koha-common in /etc/rcX.d (say X=5). The number for koha-common should now be higher than for memcached. Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 16:09:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 14:09:39 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #57 from David Gustafsson --- Created attachment 75588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75588&action=edit Bug 19893: Remove serialization format setting Default to base64 encoded binary MARC with MARCXML fallback if record exceeds maximum size -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 16:10:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 14:10:22 +0000 Subject: [Koha-bugs] [Bug 18250] koha-common should start after memcached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61035|0 |1 is obsolete| | --- Comment #18 from Mirko Tietgen --- Created attachment 75589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75589&action=edit Bug 18250: Force startup order in postinst script This is a workaround meant to correct upgrading installs. We force the order by disable/enable. Test plan: [1] When upgrading an existing install, check that the startup order after the upgrade has been corrected in /etc/rcX.d (say X=5). Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 16:10:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 14:10:50 +0000 Subject: [Koha-bugs] [Bug 18250] koha-common should start after memcached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 16:11:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 14:11:52 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 16:13:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 14:13:34 +0000 Subject: [Koha-bugs] [Bug 17311] koha-common service should be restarted on upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17311 --- Comment #4 from Mirko Tietgen --- Created attachment 75590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75590&action=edit Bug 17311: koha-common service should be restarted on upgrade This patch stops koha-common before upgrades and restarts memcached, koha-common and apache after upgrades Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 16:14:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 14:14:47 +0000 Subject: [Koha-bugs] [Bug 17311] koha-common service should be restarted on upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17311 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 16:16:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 14:16:56 +0000 Subject: [Koha-bugs] [Bug 18250] koha-common should start after memcached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17311 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17311 [Bug 17311] koha-common service should be restarted on upgrade -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 16:16:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 14:16:56 +0000 Subject: [Koha-bugs] [Bug 17311] koha-common service should be restarted on upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17311 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18250 --- Comment #5 from Mirko Tietgen --- Might depend on 18250, as it touches the same file and I made this patch on top of it. Setting it to be on the safe side. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 [Bug 18250] koha-common should start after memcached -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 16:24:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 14:24:31 +0000 Subject: [Koha-bugs] [Bug 20808] I cant install Koha on Ubuntu 18.04 LTS (Bionic Beaver) - Unmet dependences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20808 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #4 from Mirko Tietgen --- This is not a bug then but user error. Right now - Koha stable is 18.05.00 - Koha oldstable is 17.11.06 You have likely not done apt-get update before trying to upgrade. Your package sources are out of date. If you update the source list and apt config contains stable, you will get 18.05.00. If you wish to stay on 17.11 branch, check your apt configuration to use 'oldstable' or '17.11'. Closing this as it is not a bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 16:29:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 14:29:39 +0000 Subject: [Koha-bugs] [Bug 20825] The method is not covered by tests! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 16:29:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 14:29:42 +0000 Subject: [Koha-bugs] [Bug 20825] The method is not covered by tests! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 --- Comment #12 from Jonathan Druart --- Created attachment 75591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75591&action=edit Bug 20825: Add regression tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 16:29:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 14:29:47 +0000 Subject: [Koha-bugs] [Bug 20825] The method is not covered by tests! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 --- Comment #13 from Jonathan Druart --- Created attachment 75592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75592&action=edit Bug 20825: (bug 19943 follow-up) call notforloan on itemtype instead of biblioitem On bug 19943: - elsif ($biblioitem->{'notforloan'} == 1){ + elsif ($biblioitem->notforloan == 1){ The biblioitems table does not contain a notforloan column, this comes from the item type. This bug only appears when item type is defined at biblio level (item-level_itypes=0) Test plan: Set item-level_itypes = biblio Check an item out Without this patch it explodes with "The method notforloan is not covered by tests!" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 16:41:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 14:41:08 +0000 Subject: [Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with Koha::UploadedFile->temporary_directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #6 from Mirko Tietgen --- (In reply to Kyle M Hall from comment #5) > (In reply to Marcel de Rooy from comment #4) > > (In reply to Kyle M Hall from comment #3) > > > I had thought about that as well. Where would you want to move it? Koha.pm? > > > > Yeah. Definitely better.. Note that I commented too on 20428 that imo we > > need a general koha-conf variable for an alternative tmp directory.. > > I'll update this patch after bug 20428 has been pushed. Ping, 20428 has been pushed :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 16:42:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 14:42:55 +0000 Subject: [Koha-bugs] [Bug 20827] Can't add owner to a fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20827 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 28 16:42:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 14:42:58 +0000 Subject: [Koha-bugs] [Bug 20827] Can't add owner to a fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20827 --- Comment #1 from Jonathan Druart --- Created attachment 75593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75593&action=edit Bug 20827: Display Fund's owner name when selected When a fund is created or edited and does not have a owner yet, the name of the patron will not be displayed when selected. The HTML element the JS code expects is not present in the DOM. Test plan: - Create a fund, set a owner - remove the owner, edit, etc. - Save - Edit again Make sure it works as expected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 16:49:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 14:49:43 +0000 Subject: [Koha-bugs] [Bug 20825] The method is not covered by tests! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 16:57:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 14:57:00 +0000 Subject: [Koha-bugs] [Bug 20692] koha-plack doesn't check for Include *-plack.conf line in /etc/apache2/sites-available/$INSTANCE.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20692 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 16:57:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 14:57:03 +0000 Subject: [Koha-bugs] [Bug 20692] koha-plack doesn't check for Include *-plack.conf line in /etc/apache2/sites-available/$INSTANCE.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20692 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75511|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 75594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75594&action=edit Bug 20692: Return and display and error if koha-plack failed If koha-plack did not comment/uncomment the line it should fails and display an error instead of success. Useful for old apache config files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 16:57:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 14:57:52 +0000 Subject: [Koha-bugs] [Bug 20692] koha-plack doesn't check for Include *-plack.conf line in /etc/apache2/sites-available/$INSTANCE.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20692 --- Comment #8 from Jonathan Druart --- Well, this is really not error proof but should improve a bit the behavior (not the code!) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 17:01:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 15:01:52 +0000 Subject: [Koha-bugs] [Bug 20825] Cannot checkout if item types at biblio level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The method is not covered |Cannot checkout if item |by tests! |types at biblio level Severity|critical |blocker -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 17:05:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 15:05:07 +0000 Subject: [Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_18_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 17:05:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 15:05:09 +0000 Subject: [Koha-bugs] [Bug 20757] Capture a screenshot on selenium errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20757 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_18_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 17:05:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 15:05:30 +0000 Subject: [Koha-bugs] [Bug 20692] koha-plack doesn't check for Include *-plack.conf line in /etc/apache2/sites-available/$INSTANCE.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20692 --- Comment #9 from M. Tompsett --- (In reply to Jonathan Druart from comment #8) > Well, this is really not error proof but should improve a bit the behavior > (not the code!) Hmmm... it gives me an idea... I'll see if I can create a better counter patch, if not, I'll sign this off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 17:17:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 15:17:10 +0000 Subject: [Koha-bugs] [Bug 20825] Cannot checkout if item types at biblio level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75591|0 |1 is obsolete| | --- Comment #14 from Tom?s Cohen Arazi --- Created attachment 75595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75595&action=edit Bug 20825: Add regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 17:17:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 15:17:37 +0000 Subject: [Koha-bugs] [Bug 20825] Cannot checkout if item types at biblio level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 17:17:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 15:17:15 +0000 Subject: [Koha-bugs] [Bug 20825] Cannot checkout if item types at biblio level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75592|0 |1 is obsolete| | --- Comment #15 from Tom?s Cohen Arazi --- Created attachment 75596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75596&action=edit Bug 20825: (bug 19943 follow-up) call notforloan on itemtype instead of biblioitem On bug 19943: - elsif ($biblioitem->{'notforloan'} == 1){ + elsif ($biblioitem->notforloan == 1){ The biblioitems table does not contain a notforloan column, this comes from the item type. This bug only appears when item type is defined at biblio level (item-level_itypes=0) Test plan: Set item-level_itypes = biblio Check an item out Without this patch it explodes with "The method notforloan is not covered by tests!" Signed-off-by: Tomas Cohen Arazi I reproduced the error condition and verified the tests failed without this patch. After this patch is applied, tests pass and checkout succeeds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 17:39:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 15:39:02 +0000 Subject: [Koha-bugs] [Bug 20825] Cannot checkout if item types at biblio level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://admin-lib.cxbe.by/ | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 18:04:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 16:04:37 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #65 from Koha Team Lyon 3 --- Great ! that's much better with the js ans css rewriting rules ! I could did the test again for daily, weekly and monthly periodicities. Everything is working as expected, dates are correctly skipped, permanent irregularities are kept over the renewal. Just a little thing about ergonomy of "Week(s) not published" scrolldown list : when you tick/untick a checkbox at first time, the form jumps surprisingly. Could we avoid this ? Anyway, thank you Alex and I hope that it will be OK this time. Olivier -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 19:51:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 17:51:24 +0000 Subject: [Koha-bugs] [Bug 20692] koha-plack doesn't check for Include *-plack.conf line in /etc/apache2/sites-available/$INSTANCE.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20692 --- Comment #10 from M. Tompsett --- Created attachment 75597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75597&action=edit Bug 20692: Extreme toggle checking for plack TEST PLAN --------- sudo koha-plack --disable sudo koha-plack --disable sudo koha-plack --enable sudo koha-plack --disable echo $? sudo koha-plack --disable echo $? sudo koha-list --noplack echo $? sudo koha-plack --enable echo $? sudo koha-plack --enable echo $? sudo koha-list --plack echo $? git bz apply 20692 sudo perl ~/misc4dev/cp_debian_files.pl then repeat the test. It should also be noted, because the enable and disable are now split, if for some reason they become out of sync, an enable or disable should correct them. Because these are bash scripts, the test tool (/home/vagrant/qa-test-tools/koha-qa.pl) does not apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 20:11:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 18:11:06 +0000 Subject: [Koha-bugs] [Bug 20822] Can't find HOLD_SLIP template when printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20822 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED Depends on| |18789 --- Comment #1 from Jonathan Druart --- Caused by commit ab47e46ea0ade643b308a8b00708d57995c57050 Bug 18789: Pass a Koha::Patron object from returns.pl Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 [Bug 18789] Send a Koha::Patron object to the templates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 20:11:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 18:11:06 +0000 Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20822 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20822 [Bug 20822] Can't find HOLD_SLIP template when printing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 20:13:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 18:13:02 +0000 Subject: [Koha-bugs] [Bug 20822] Can't find HOLD_SLIP template when printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20822 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 20:13:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 18:13:06 +0000 Subject: [Koha-bugs] [Bug 20822] Can't find HOLD_SLIP template when printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20822 --- Comment #2 from Jonathan Druart --- Created attachment 75598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75598&action=edit Bug 20822: (bug 18789 follow-up) Fix HOLD_SLIP Caused by commit ab47e46ea0ade643b308a8b00708d57995c57050 Bug 18789: Pass a Koha::Patron object from returns.pl circ/returns.pl does not send a $patron Koha::Patron object to the template in case print_slip is set Test plan: Confirm a hold and print the slip -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 20:14:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 18:14:28 +0000 Subject: [Koha-bugs] [Bug 20804] Sanitize input of timeout syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20804 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.11 |master CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 20:16:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 18:16:18 +0000 Subject: [Koha-bugs] [Bug 20806] Column settings issues for holdshistory-table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14919 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 [Bug 14919] Holds history for patrons -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 20:16:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 18:16:18 +0000 Subject: [Koha-bugs] [Bug 14919] Holds history for patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20806 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 [Bug 20806] Column settings issues for holdshistory-table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 20:17:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 18:17:49 +0000 Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |5635 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5635 [Bug 5635] bulkmarcimport new parameters & features -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 28 20:17:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 18:17:49 +0000 Subject: [Koha-bugs] [Bug 5635] bulkmarcimport new parameters & features In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5635 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20811 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 20:18:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 18:18:00 +0000 Subject: [Koha-bugs] [Bug 15497] Limit Item Types by Branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC|marjorie.barry-vila at collect | |o.ca | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 20:18:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 18:18:09 +0000 Subject: [Koha-bugs] [Bug 15497] Limit Item Types by Branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 20:21:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 18:21:32 +0000 Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 20:21:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 18:21:35 +0000 Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 --- Comment #1 from Jonathan Druart --- Created attachment 75599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75599&action=edit Bug 20811: Fix wrong usage of ModBiblio Since commit cefa7c21e28b88351ee8ae0dfefb80a515323df9 Bug 5635: bulkmarcimport new parameters & features AddBiblio call has been replaced with ModBiblio, but the return values are different. We should not replace the value of $biblionumber with what returns this subroutine. Test plan: If you are familiar with bulkmarcimport.pl you should know what to test, I am not. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 28 20:23:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 18:23:13 +0000 Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 28 20:27:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 18:27:20 +0000 Subject: [Koha-bugs] [Bug 20827] Can't add owner to a fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20827 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 20:30:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 18:30:04 +0000 Subject: [Koha-bugs] [Bug 19502] Result sets limited to 10000 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Elasticsearch - result sets |Result sets limited to |limited to 10000 |10000 CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 20:30:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 18:30:10 +0000 Subject: [Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Elasticsearch - _all field |_all field is deprecated - |is deprecated - should use |should use copy_to to |copy_to to prepare for ES6 |prepare for ES6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 20:46:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 18:46:17 +0000 Subject: [Koha-bugs] [Bug 20651] Improve display of "Toggle full supplier metadata" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20651 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart --- Fix the indentation please. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 20:49:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 18:49:00 +0000 Subject: [Koha-bugs] [Bug 20676] svc/barcode should allow barcode to be printed without text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 20:49:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 18:49:04 +0000 Subject: [Koha-bugs] [Bug 20676] svc/barcode should allow barcode to be printed without text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74942|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 75600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75600&action=edit Bug 20676: svc/barcode should allow barcode to be printed without text Test plan: 1) Point web browser to /cgi-bin/koha/svc/barcode?barcode=*12345*¬ext=1 This will display a png image of the barcode *12345* with the text *12345* printed below the scannable barcode. 2) Apply patch 3) Refresh the browser. The human readable text no longer appears. Signed-off-by: Fr?d?ric Demians Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 20:57:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 18:57:09 +0000 Subject: [Koha-bugs] [Bug 20487] AddReturn should clear items.onloan for unissued items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #11 from Jonathan Druart --- What about local use? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 20:59:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 18:59:04 +0000 Subject: [Koha-bugs] [Bug 20827] Can't add owner to a fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20827 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 20:59:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 18:59:06 +0000 Subject: [Koha-bugs] [Bug 20827] Can't add owner to a fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20827 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75593|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 75601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75601&action=edit Bug 20827: Display Fund's owner name when selected When a fund is created or edited and does not have a owner yet, the name of the patron will not be displayed when selected. The HTML element the JS code expects is not present in the DOM. Test plan: - Create a fund, set a owner - remove the owner, edit, etc. - Save - Edit again Make sure it works as expected. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 20:59:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 18:59:40 +0000 Subject: [Koha-bugs] [Bug 20487] AddReturn should clear items.onloan for unissued items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 --- Comment #12 from Jonathan Druart --- Should not we provide an update DB entry? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 21:20:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 19:20:44 +0000 Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Keywords| |NeedsMoreQA --- Comment #23 from Jonathan Druart --- I have not tested it, just had a quick look. 1. This: Koha::Biblio->may_article_request shows that Koha::Biblio is not the right place to put it. Koha::Object class should not have class methods. 2. In Koha::IssuingRules, $class_or_self must be named $class 3. The cache is cleared in a very lazy way :) 4. Maybe we do not need may_article_request, but only guess_article_requestable_itemtypes? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 21:28:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 19:28:18 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #58 from David Gustafsson --- (In reply to Mirko Tietgen from comment #56) > I am not necessarily a fan of dropping dependencies. I think it is part of > Perl to use other modules instead of reinventing everything. Regarding > Catmandu, the developers are very dedicated and we will profit from future > developments without investing Koha developer time, while a change to our > own solution might help with performance now but might not be touched again > for a long time. Ok, I had some issues upgrading the packages, so I included the latest versions in a custom lib directory instead using the "use lib" pragma. I these are the timings I got: Old versions (catmandu 1.0304, catmandu-marc 0.215, catmandu-store-elasticsearch 0.0507) real 2m2.277s user 1m8.052s sys 0m3.084s New versions: catmandu 1.09, catmandu-marc 0.09, catmandu-store-elasticsearch 0.0507) real 1m56.413s user 1m5.020s sys 0m2.848s Patch: real 0m44.444s user 0m21.784s sys 0m2.400s -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 21:31:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 19:31:06 +0000 Subject: [Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20763 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20763 [Bug 20763] AllowPurchaseSuggestionBranchChoice triggers error opac-suggestions.pl is visited without logging in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 21:31:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 19:31:06 +0000 Subject: [Koha-bugs] [Bug 20763] AllowPurchaseSuggestionBranchChoice triggers error opac-suggestions.pl is visited without logging in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20763 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17829 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|normal |major --- Comment #3 from Jonathan Druart --- One more caused by commit 2b90ea2cb0e5e976de7ddef0151ae83d8ac578e6 Bug 17829: Move GetMember to Koha::Patron Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 [Bug 17829] Move GetMember to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 21:32:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 19:32:55 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #59 from David Gustafsson --- And with what this is the latest versions: (catmandu 1.09, catmandu-marc 1.231, catmandu-store-elasticsearch 0.0507) real 1m59.575s user 1m6.496s sys 0m3.252s Also a correction catmandu-marc 0.09 in the previous reply should of course be 1.09. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 21:36:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 19:36:48 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #60 from David Gustafsson --- (In reply to Nicolas Legrand from comment #37) > (In reply to David Gustafsson from comment #27) > [...] > > I had forgotten about this issue, I will try to look into it, it would be > > easier if I had some test data which produced this error. So if you have a > > marc file would be helpful to attach or mail it to glasklas at gmail.com. > > Hey David, > > my colleague S?verine Queune retested it, it worked well this time and it > took 30% less time than usual! > > We're not well verse on how it should work, but so far, having something > that works and works faster seems pretty convenient :). Thanks! Are you sure it only took 30% less? The last timings point more in the direction of a 2.5x speedup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 21:38:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 19:38:15 +0000 Subject: [Koha-bugs] [Bug 20763] AllowPurchaseSuggestionBranchChoice triggers error opac-suggestions.pl is visited without logging in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20763 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75567|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 75602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75602&action=edit Bug 20763: AllowPurchaseSuggestionBranchChoice triggers error opac-suggestions.pl is visited without logging in Some code executed in the script opac-suggestions.pl if the system preference AllowPurchaseSuggestionBranchChoice is enabled assumes there is a logged in user. If there is not, patrons will see the error "Internal Server Error". Test Plan: 1) Enable AllowPurchaseSuggestionBranchChoice 2) Enable AnonSuggestions 3) In the OPAC, perform a search that will have no results, click the "Make a purchase suggestion" link. 4) Note the error 5) Apply this patch 6) Reload the page 7) The page should load now! Signed-off-by: Pierre-Luc Lapointe Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 21:38:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 19:38:18 +0000 Subject: [Koha-bugs] [Bug 20763] AllowPurchaseSuggestionBranchChoice triggers error opac-suggestions.pl is visited without logging in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20763 --- Comment #5 from Jonathan Druart --- Created attachment 75603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75603&action=edit Bug 20763: Remove unecessary Koha::Patron fetch If $borrowernumber is not set, there is no userenv. So let's pick the library code set in the userenv instead of fetching the Koha::Patron->branchcode from DB Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 21:39:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 19:39:03 +0000 Subject: [Koha-bugs] [Bug 20763] AllowPurchaseSuggestionBranchChoice triggers error opac-suggestions.pl is visited without logging in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20763 --- Comment #6 from Jonathan Druart --- Kyle, I think the conditions can be simplified. Can you confirm I am not missing something with this follow-up? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 21:43:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 19:43:46 +0000 Subject: [Koha-bugs] [Bug 3849] Descriptions of acquisition permissions are unclear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3849 --- Comment #13 from Jonathan Druart --- Should not we add an update DB entry? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 28 21:44:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 19:44:25 +0000 Subject: [Koha-bugs] [Bug 3849] Descriptions of acquisition permissions are unclear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3849 --- Comment #14 from Jonathan Druart --- (In reply to Jonathan Druart from comment #13) > Should not we add an update DB entry? ... or remove the "description" column on a separate bug report? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 28 21:45:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 19:45:06 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #61 from David Gustafsson --- Forgot to mention that the timings where taking using about 5000 records and 277 maps. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 21:46:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 19:46:28 +0000 Subject: [Koha-bugs] [Bug 3849] Descriptions of acquisition permissions are unclear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3849 --- Comment #15 from Katrin Fischer --- I can add a db update and file a separate report for removing it - then you can pick :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 28 21:51:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 19:51:47 +0000 Subject: [Koha-bugs] [Bug 3886] Can't print receipt w/out allowing "Add or modify borrowers" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3886 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 21:51:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 19:51:51 +0000 Subject: [Koha-bugs] [Bug 3886] Can't print receipt w/out allowing "Add or modify borrowers" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3886 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75568|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 75604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75604&action=edit Bug 3886: Fix mismatch of required permissions for printing slips - Print summary (summary-print.pl) - Print quick slip (printslip.pl) - Print slip (printslip.pl) - Print overdues (print_overdues.pl) Perl scripts all require circulate_remaining_permissions, while in the template we were checking for edit_borrowers. Now the print pull down will only be visible if the patron has circulate or circulate_remaining_permissions. To test: - Verify that printing the listed slips works for staff users with either circulate or circulate_remaining_permissions and without edit_borrowers. Signed-off-by: Charles Farmer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 21:55:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 19:55:42 +0000 Subject: [Koha-bugs] [Bug 20393] Remove redundant 'koha.psgi' and 'plackup.sh' files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20393 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 28 21:55:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 19:55:59 +0000 Subject: [Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 21:56:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 19:56:11 +0000 Subject: [Koha-bugs] [Bug 20795] koha-rebuild-zebra should pass through increased verbosity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20795 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 28 21:56:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 19:56:25 +0000 Subject: [Koha-bugs] [Bug 20797] If an Ill request has an associated bib record, the detail view should contain a link to the record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 21:57:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 19:57:42 +0000 Subject: [Koha-bugs] [Bug 20797] If an Ill request has an associated bib record, the detail view should contain a link to the record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 --- Comment #7 from Jonathan Druart --- Please surround 'N/A' with tags (to help translators) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 21:57:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 19:57:55 +0000 Subject: [Koha-bugs] [Bug 18973] Auto focus the ISBN field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18973 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Hi, I think something went wrong here with the status. When attaching a patch the status should be changed to 'needs signoff'. Then after the sign-off happened, it should be 'Signed off' - this is still new so not showing up in any reports or lists. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 28 21:58:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 19:58:18 +0000 Subject: [Koha-bugs] [Bug 18973] Auto focus the ISBN field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18973 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 22:00:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 20:00:19 +0000 Subject: [Koha-bugs] [Bug 20825] Cannot checkout if item types at biblio level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 22:06:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 20:06:06 +0000 Subject: [Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Jonathan Druart --- +my $report_rec = Koha::Reports->find( $report_name ? { 'name' => $report_name } : { 'id' => $report_id } ); This is wrong: there is no saved_sql.name column, and saved_sql.report_name is not a uniq key (so you should ->search instead of find). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 22:06:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 20:06:16 +0000 Subject: [Koha-bugs] [Bug 20825] Cannot checkout if item types at biblio level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75595|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 75605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75605&action=edit Bug 20825: Add regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 22:06:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 20:06:22 +0000 Subject: [Koha-bugs] [Bug 20825] Cannot checkout if item types at biblio level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75596|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Created attachment 75606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75606&action=edit Bug 20825: (bug 19943 follow-up) call notforloan on itemtype instead of biblioitem On bug 19943: - elsif ($biblioitem->{'notforloan'} == 1){ + elsif ($biblioitem->notforloan == 1){ The biblioitems table does not contain a notforloan column, this comes from the item type. This bug only appears when item type is defined at biblio level (item-level_itypes=0) Test plan: Set item-level_itypes = biblio Check an item out Without this patch it explodes with "The method notforloan is not covered by tests!" Signed-off-by: Tomas Cohen Arazi I reproduced the error condition and verified the tests failed without this patch. After this patch is applied, tests pass and checkout succeeds. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 22:07:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 20:07:30 +0000 Subject: [Koha-bugs] [Bug 20825] Cannot checkout if item types at biblio level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 22:07:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 20:07:36 +0000 Subject: [Koha-bugs] [Bug 20825] Cannot checkout if item types at biblio level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75606|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 22:07:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 20:07:34 +0000 Subject: [Koha-bugs] [Bug 20825] Cannot checkout if item types at biblio level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75605|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 22:08:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 20:08:38 +0000 Subject: [Koha-bugs] [Bug 20825] Cannot checkout if item types at biblio level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 --- Comment #18 from Katrin Fischer --- Created attachment 75607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75607&action=edit Bug 20825: Add regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 22:08:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 20:08:43 +0000 Subject: [Koha-bugs] [Bug 20825] Cannot checkout if item types at biblio level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 --- Comment #19 from Katrin Fischer --- Created attachment 75608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75608&action=edit Bug 20825: (bug 19943 follow-up) call notforloan on itemtype instead of biblioitem On bug 19943: - elsif ($biblioitem->{'notforloan'} == 1){ + elsif ($biblioitem->notforloan == 1){ The biblioitems table does not contain a notforloan column, this comes from the item type. This bug only appears when item type is defined at biblio level (item-level_itypes=0) Test plan: Set item-level_itypes = biblio Check an item out Without this patch it explodes with "The method notforloan is not covered by tests!" Signed-off-by: Tomas Cohen Arazi I reproduced the error condition and verified the tests failed without this patch. After this patch is applied, tests pass and checkout succeeds. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 22:09:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 20:09:26 +0000 Subject: [Koha-bugs] [Bug 20393] Remove redundant 'koha.psgi' and 'plackup.sh' files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20393 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18377 CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 22:09:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 20:09:26 +0000 Subject: [Koha-bugs] [Bug 18377] Add Plack/PSGI file for dev install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20393 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 22:13:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 20:13:03 +0000 Subject: [Koha-bugs] [Bug 20827] Can't add owner to a fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20827 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75601|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 75609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75609&action=edit Bug 20827: Display Fund's owner name when selected When a fund is created or edited and does not have a owner yet, the name of the patron will not be displayed when selected. The HTML element the JS code expects is not present in the DOM. Test plan: - Create a fund, set a owner - remove the owner, edit, etc. - Save - Edit again Make sure it works as expected. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 22:12:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 20:12:59 +0000 Subject: [Koha-bugs] [Bug 20827] Can't add owner to a fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20827 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 22:14:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 20:14:54 +0000 Subject: [Koha-bugs] [Bug 20822] Can't find HOLD_SLIP template when printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20822 --- Comment #3 from Katrin Fischer --- Test plan: - Place a hold on an item or record - Return an item to fill the hold - Check the item in - Pick "print and confirm" - Instead of the notice, an error will display in the preview pop-up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 22:19:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 20:19:31 +0000 Subject: [Koha-bugs] [Bug 15520] Add more granular permission for only editing own library's circ rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 --- Comment #15 from Jonathan Druart --- Yes, that would work, but it smells a bit :) For instance a superlibrarian user will have CAN_manage_circ_rules_restricted set in templates. Why not simply do the reverse, like view_borrower_infos_from_any_libraries, and name it manage_circ_rules_from_any_libraries (will need to be set on update for patrons with manage_circ_rules). It would remove the new parameter and avoid a permission to restrict, which could add side-effects (maybe not now, but certainly later). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 22:23:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 20:23:21 +0000 Subject: [Koha-bugs] [Bug 20822] Can't find HOLD_SLIP template when printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20822 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75598|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 75610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75610&action=edit Bug 20822: (bug 18789 follow-up) Fix HOLD_SLIP Caused by commit ab47e46ea0ade643b308a8b00708d57995c57050 Bug 18789: Pass a Koha::Patron object from returns.pl circ/returns.pl does not send a $patron Koha::Patron object to the template in case print_slip is set Test plan: Confirm a hold and print the slip Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 22:23:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 20:23:18 +0000 Subject: [Koha-bugs] [Bug 20822] Can't find HOLD_SLIP template when printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20822 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 22:26:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 20:26:55 +0000 Subject: [Koha-bugs] [Bug 20744] Replace staff client header Koha logo gif with transparent png In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20744 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 22:26:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 20:26:58 +0000 Subject: [Koha-bugs] [Bug 20744] Replace staff client header Koha logo gif with transparent png In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20744 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75254|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 75611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75611&action=edit Bug 20744: Replace staff client header Koha logo gif with transparent png This patch replaces koha-logo-medium.gif with a fully-transparent png. This patch also adds a white version in case someone finds it useful. To test, apply the patch and clear your cache if necessary. - View any page in the staff client and confirm that the Koha logo in the header area looks correct. - Add the following to IntranetUserCSS: .gradient { background: #46B9EA none; } - Reload the page and confirm that the Koha logo doesn't have a white fringe around the edges. - Append this to the CSS you added to IntranetUserCSS above: h1#logo { background-image: url("/intranet-tmpl/prog/img/koha-logo-medium-white.png"); } - Reload the page and confirm that the new white logo appears Signed-off-by: Claire Gravely Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 22:39:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 20:39:50 +0000 Subject: [Koha-bugs] [Bug 20779] Style refresh for patron detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- That's a lot of buttons! Would not it be better to move the "edit" button on the same line as the header block ("Library use", "Alternate address", etc.)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 22:41:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 20:41:47 +0000 Subject: [Koha-bugs] [Bug 20828] New: Step 4 of moremember is used for Housebound and additional attributes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 Bug ID: 20828 Summary: Step 4 of moremember is used for Housebound and additional attributes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Enable the Housebound module and Additional attributes, hit cgi-bin/koha/members/memberentry.pl?op=modify&borrowernumber=51&step=4 You see: https://screenshots.firefox.com/kckI5solTzmkbPv4/pro.kohadev.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 28 22:43:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 20:43:30 +0000 Subject: [Koha-bugs] [Bug 20779] Style refresh for patron detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- I like Jonathan's idea I think. Also (if not done already) it would be nice if in the future it would be easier to hide the edit buttons together with the sections. Unwanted fields does not apply to this screen and the buttons always have to be hidden separately. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 22:46:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 20:46:43 +0000 Subject: [Koha-bugs] [Bug 20822] Can't find HOLD_SLIP template when printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20822 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 22:46:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 20:46:46 +0000 Subject: [Koha-bugs] [Bug 20822] Can't find HOLD_SLIP template when printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20822 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75610|0 |1 is obsolete| | --- Comment #5 from Chris Cormack --- Created attachment 75612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75612&action=edit Bug 20822: (bug 18789 follow-up) Fix HOLD_SLIP Caused by commit ab47e46ea0ade643b308a8b00708d57995c57050 Bug 18789: Pass a Koha::Patron object from returns.pl circ/returns.pl does not send a $patron Koha::Patron object to the template in case print_slip is set Test plan: Confirm a hold and print the slip Signed-off-by: Katrin Fischer Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 23:02:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 21:02:18 +0000 Subject: [Koha-bugs] [Bug 20829] New: 'Link to host item' gives internal server error for invalid item barcode Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20829 Bug ID: 20829 Summary: 'Link to host item' gives internal server error for invalid item barcode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl To test: - Turn on EasyAnalyticalRecords - Go to a detail page - Edit > Link to host item - Enter an invalid barcode (some additional whitespace around a copied one will do it) - Verify it explodes into an internal server error Error log: Use of uninitialized value in join or string at /usr/share/perl5/MARC/Field.pm line 696. problem with :392 : Field 942 must have at least one subfield at /usr/share/perl5/MARC/File/XML.pm line 481. 01023nam a2200301 4500 DAW28259733 140801s2011 enk 001 0 eng | 0198709463 (paperback) 9780198709466 (paperback) DAWSON rda KD2079 .C66 2011 346.42066 23 Blackstone's statutes on company law 2014-2015 / edited by Derek French. 18 edition. Oxford : Oxford University Press, 2014. 750 pages ; 25 cm. text rdacontent unmediated rdamedia volume rdacarrier Blackstone's statutes series Includes index. Corporation law England. Corporation law Wales. French, Derek, editor of compilation. Blackstones statutes. 392 392 69 150 Shetter, William Z. 8th ed. London : Routledge, 2002. 39999000002850 Dutch : (OSt)3555020 0415235014 : Can't call method "subfield" on an undefined value at /home/vagrant/kohaclone/cataloguing/linkitem.pl line 53. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 23:04:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 21:04:30 +0000 Subject: [Koha-bugs] [Bug 20829] 'Link to host item' gives internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20829 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|'Link to host item' gives |'Link to host item' gives |internal server error for |internal server error |invalid item barcode | --- Comment #1 from Katrin Fischer --- It seems to happen more often than not, I can't get it to work correctly right now. Someone else taking a look would be appreciated! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 23:05:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 21:05:29 +0000 Subject: [Koha-bugs] [Bug 20702] Bind results of GetHostItemsInfo to the EasyAnalyticalRecords pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20702 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- Hi Marcel, I have problems testing this on master, see bug 20829. Maybe you can take a look and confirm (or not) the problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 23:18:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 21:18:07 +0000 Subject: [Koha-bugs] [Bug 20761] Advanced Cataloging Editor - Rancor - Some js files are not fetched using Asset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20761 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 23:18:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 21:18:12 +0000 Subject: [Koha-bugs] [Bug 20761] Advanced Cataloging Editor - Rancor - Some js files are not fetched using Asset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20761 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75292|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 75613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75613&action=edit Bug 20761: Fix some js includes in rancor To test: 1 - Load the advanced cataloging editor 2 - Inspect the network tab in your browser (F12) 3 - Note failure to load 'cataloging_.js' 4 - Note some other scripts don't have versioning 5 - Apply patch 6 - Reload page 7 - Note cataloging.js loads with version number 8 - Note more js files have versioning Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 23:21:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 21:21:52 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at l2c2.co.in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 23:39:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 21:39:33 +0000 Subject: [Koha-bugs] [Bug 20830] New: Make sure a fund is selected when ordering from staged file Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Bug ID: 20830 Summary: Make sure a fund is selected when ordering from staged file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When selecting orders from a staged file, we should check that a fund is set. - We only want to check entries that have been selected for order (checkbox) - We only want to complain, when the fund entry on the selected entry is empty and there is also no default fund set on the accounting details tab -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 23:40:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 21:40:01 +0000 Subject: [Koha-bugs] [Bug 20798] Client side validation for for fund selection prevents adding only some records to a basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20798 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- I agree that this is a bug and the fix doesn't work correctly, but without any checking, it seems that an arbitrary fund is selected if you don't set one. I think it would probably be possible to improve this, so that only the entries checked are validated, but that leaves us with the problem that a default fund can be set on the third tab. I am signing off at this one, but I have filed bug 20830 to start discussion about proper validation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 23:41:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 21:41:07 +0000 Subject: [Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 --- Comment #1 from Katrin Fischer --- - MarcItemFieldsToOrder also needs to be taken into account -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon May 28 23:42:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 21:42:15 +0000 Subject: [Koha-bugs] [Bug 20789] Remove manual reference to OPACShowBarcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20789 --- Comment #2 from Katrin Fischer --- Created attachment 75614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75614&action=edit Bug 20798: Client side validation for for fund selection prevents adding only some records to a basket Bug 19453 "fixed" the fund validation that never actually worked. This validation should be removed altogether instead. It is overly simplistic and simply checks to see if each record in the batch has a fund selected regardless of whether that record will be imported or not. In addition, the code completely ignores items generated by MarcItemFieldsToOrder such that even if items on that page have a fund selected, the javascript forces the librarian to make a selection from the left-hand fund pulldown even though it will not be used. Considering this bad validation is basically 'new' as it never worked before, the most sensible course of action would be to 'undo' the change and remove the validation. Test Plan: 1) Add records to a basket from an import batch 2) Select only some of those items in the batch 3) Note Koha will not let you import them unless you set funds for *all* records in the batch 4) Apply this patch 5) Note Koha no longer forces a budget to be selected in the pulldown Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 23:42:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 21:42:11 +0000 Subject: [Koha-bugs] [Bug 20789] Remove manual reference to OPACShowBarcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20789 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 23:44:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 21:44:20 +0000 Subject: [Koha-bugs] [Bug 20789] Remove manual reference to OPACShowBarcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20789 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75614|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Comment on attachment 75614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75614 Bug 20798: Client side validation for for fund selection prevents adding only some records to a basket Wrong bug... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 23:44:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 21:44:59 +0000 Subject: [Koha-bugs] [Bug 20789] Remove manual reference to OPACShowBarcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20789 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED --- Comment #4 from Katrin Fischer --- Fixed in the manual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 23:45:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 21:45:46 +0000 Subject: [Koha-bugs] [Bug 20798] Client side validation for for fund selection prevents adding only some records to a basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20798 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 23:45:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 21:45:50 +0000 Subject: [Koha-bugs] [Bug 20798] Client side validation for for fund selection prevents adding only some records to a basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20798 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75462|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 75615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75615&action=edit Bug 20798: Client side validation for for fund selection prevents adding only some records to a basket Bug 19453 "fixed" the fund validation that never actually worked. This validation should be removed altogether instead. It is overly simplistic and simply checks to see if each record in the batch has a fund selected regardless of whether that record will be imported or not. In addition, the code completely ignores items generated by MarcItemFieldsToOrder such that even if items on that page have a fund selected, the javascript forces the librarian to make a selection from the left-hand fund pulldown even though it will not be used. Considering this bad validation is basically 'new' as it never worked before, the most sensible course of action would be to 'undo' the change and remove the validation. Test Plan: 1) Add records to a basket from an import batch 2) Select only some of those items in the batch 3) Note Koha will not let you import them unless you set funds for *all* records in the batch 4) Apply this patch 5) Note Koha no longer forces a budget to be selected in the pulldown Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=20789 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 23:46:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 21:46:04 +0000 Subject: [Koha-bugs] [Bug 20798] Client side validation for for fund selection prevents adding only some records to a basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20798 --- Comment #5 from Katrin Fischer --- Yeah there is also MarcFieldsToOrder... so something we won't fix quickly. But we need to fix this broken workflow now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 23:57:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 21:57:02 +0000 Subject: [Koha-bugs] [Bug 20761] Advanced Cataloging Editor - Rancor - Some js files are not fetched using Asset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20761 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20538 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- That's odd, how did we miss these ones?? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538 [Bug 20538] Remove the need of writing [% KOHA_VERSION %] everywhere -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 23:57:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 21:57:02 +0000 Subject: [Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION %] everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20761 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20761 [Bug 20761] Advanced Cataloging Editor - Rancor - Some js files are not fetched using Asset -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 23:58:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 21:58:25 +0000 Subject: [Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 --- Comment #10 from Katrin Fischer --- Created attachment 75616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75616&action=edit Bug 11911: (follow-up) Hide suggestion box on acq start page if no permission When the user is not superlibrarian or has the manage_suggestions permission, the suggestion box on the left of the acq start page needs to be hidden. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 28 23:59:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 21:59:17 +0000 Subject: [Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 --- Comment #11 from Katrin Fischer --- Hi Severine, thx for catching this! Could you maybe sign the follow-up too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 00:05:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 22:05:27 +0000 Subject: [Koha-bugs] [Bug 20793] Don't show holds link in result list when staff user doesn't have place_holds permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20793 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 00:05:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 22:05:30 +0000 Subject: [Koha-bugs] [Bug 20793] Don't show holds link in result list when staff user doesn't have place_holds permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20793 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75475|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 75617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75617&action=edit Bug 20793: (follow-up) Add style to the non-link hold count on detail page This small follow-up changes the style on the bibliographic detail page of the hold count so that it looks similar whether it's a link to holds or not. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 00:05:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 22:05:53 +0000 Subject: [Koha-bugs] [Bug 20793] Don't show holds link in result list when staff user doesn't have place_holds permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20793 --- Comment #5 from Katrin Fischer --- Thx a lot for the follow-up, Owen. Looks much better! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 00:18:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 22:18:36 +0000 Subject: [Koha-bugs] [Bug 3849] Descriptions of acquisition permissions are unclear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3849 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 29 00:18:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 22:18:39 +0000 Subject: [Koha-bugs] [Bug 3849] Descriptions of acquisition permissions are unclear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3849 --- Comment #16 from Katrin Fischer --- Created attachment 75618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75618&action=edit Bug 3849: (follow-up) Add database update to change descriptions -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 00:19:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 May 2018 22:19:12 +0000 Subject: [Koha-bugs] [Bug 3849] Descriptions of acquisition permissions are unclear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3849 --- Comment #17 from Katrin Fischer --- We still have the descriptions on system preferences too... chose the database update here for now. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 29 02:17:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 00:17:00 +0000 Subject: [Koha-bugs] [Bug 20829] 'Link to host item' gives internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20829 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- (In reply to Katrin Fischer from comment #0) > - Verify it explodes into an internal server error Not that I have tried, but without plack is easier to trigger internal server errors in an easily debuggable way. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 02:24:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 00:24:11 +0000 Subject: [Koha-bugs] [Bug 15277] Add Template Toolkit syntax for slips and notices to editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15277 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at l2c2.co.in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 02:25:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 00:25:15 +0000 Subject: [Koha-bugs] [Bug 15276] Add documentation for Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15276 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at l2c2.co.in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 02:27:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 00:27:43 +0000 Subject: [Koha-bugs] [Bug 16149] Generate and send custom notices based on report output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at l2c2.co.in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 03:05:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 01:05:53 +0000 Subject: [Koha-bugs] [Bug 18973] Auto focus the ISBN field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18973 --- Comment #5 from Father Vlasie --- Thank you Katrin! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 07:29:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 05:29:40 +0000 Subject: [Koha-bugs] [Bug 20825] Cannot checkout if item types at biblio level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 --- Comment #20 from sergeinik --- Thanks, it works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 08:09:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 06:09:40 +0000 Subject: [Koha-bugs] [Bug 18973] Auto focus the ISBN field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18973 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 08:21:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 06:21:56 +0000 Subject: [Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 10:22:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 08:22:02 +0000 Subject: [Koha-bugs] [Bug 20761] Advanced Cataloging Editor - Rancor - Some js files are not fetched using Asset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20761 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 10:22:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 08:22:06 +0000 Subject: [Koha-bugs] [Bug 20761] Advanced Cataloging Editor - Rancor - Some js files are not fetched using Asset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20761 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75613|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 75619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75619&action=edit Bug 20761: Fix some js includes in rancor To test: 1 - Load the advanced cataloging editor 2 - Inspect the network tab in your browser (F12) 3 - Note failure to load 'cataloging_.js' 4 - Note some other scripts don't have versioning 5 - Apply patch 6 - Reload page 7 - Note cataloging.js loads with version number 8 - Note more js files have versioning Signed-off-by: Katrin Fischer Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 10:29:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 08:29:41 +0000 Subject: [Koha-bugs] [Bug 20798] Client side validation for for fund selection prevents adding only some records to a basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20798 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 10:29:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 08:29:45 +0000 Subject: [Koha-bugs] [Bug 20798] Client side validation for for fund selection prevents adding only some records to a basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20798 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75615|0 |1 is obsolete| | --- Comment #6 from Chris Cormack --- Created attachment 75620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75620&action=edit Bug 20798: Client side validation for for fund selection prevents adding only some records to a basket Bug 19453 "fixed" the fund validation that never actually worked. This validation should be removed altogether instead. It is overly simplistic and simply checks to see if each record in the batch has a fund selected regardless of whether that record will be imported or not. In addition, the code completely ignores items generated by MarcItemFieldsToOrder such that even if items on that page have a fund selected, the javascript forces the librarian to make a selection from the left-hand fund pulldown even though it will not be used. Considering this bad validation is basically 'new' as it never worked before, the most sensible course of action would be to 'undo' the change and remove the validation. Test Plan: 1) Add records to a basket from an import batch 2) Select only some of those items in the batch 3) Note Koha will not let you import them unless you set funds for *all* records in the batch 4) Apply this patch 5) Note Koha no longer forces a budget to be selected in the pulldown Signed-off-by: Katrin Fischer Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 10:30:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 08:30:27 +0000 Subject: [Koha-bugs] [Bug 20761] Advanced Cataloging Editor - Rancor - Some js files are not fetched using Asset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20761 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 10:30:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 08:30:39 +0000 Subject: [Koha-bugs] [Bug 20761] Advanced Cataloging Editor - Rancor - Some js files are not fetched using Asset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20761 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|josef.moravec at gmail.com |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 10:41:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 08:41:49 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #62 from Ere Maijala --- (In reply to David Gustafsson from comment #57) > Created attachment 75588 [details] [review] > Bug 19893: Remove serialization format setting > > Default to base64 encoded binary MARC with MARCXML > fallback if record exceeds maximum size Looks good to me now. Now if we can just get 20073 pushed again.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 10:43:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 08:43:51 +0000 Subject: [Koha-bugs] [Bug 9573] Ability to download items lost report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20806 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 [Bug 20806] Column settings issues for holdshistory-table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 10:43:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 08:43:51 +0000 Subject: [Koha-bugs] [Bug 20806] Column settings issues for holdshistory-table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9573 Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com |ity.org | CC| |josef.moravec at gmail.com --- Comment #1 from Josef Moravec --- (In reply to S?verine Queune from comment #0) > There is 2 display issues with the table "Holds history" tab : > - no change when modifying "Column settings > Patrons > > (id=holdshistory-table)". I don't know if it is linked, but the
[% item.biblio.author %][% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.itemlost', authorised_value => item.itemlost ) %] > - [% item.itemlost_on | $KohaDates %]
> on the tab is "table_holdshistory". This is caused by bug 9573, where the first parameter of KohaTable function was changed from selector to id > - column "Item type" is always empty Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 [Bug 9573] Ability to download items lost report -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 29 10:47:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 08:47:00 +0000 Subject: [Koha-bugs] [Bug 20831] New: (Bug 9573 follow-up) Pass id as first parameter instead of selector Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20831 Bug ID: 20831 Summary: (Bug 9573 follow-up) Pass id as first parameter instead of selector Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org Bug 9573 (commit 771de35a2b297cc5058f83ed3e19e34927f95c36) changed the siganture of KohaTable to take id instead of selector. But not all calls were updated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 10:47:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 08:47:36 +0000 Subject: [Koha-bugs] [Bug 20831] (Bug 9573 follow-up) Pass id as first parameter instead of selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20831 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |josef.moravec at gmail.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20806 Severity|enhancement |normal Depends on| |9573 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 [Bug 9573] Ability to download items lost report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 10:47:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 08:47:36 +0000 Subject: [Koha-bugs] [Bug 20806] Column settings issues for holdshistory-table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20831 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 10:47:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 08:47:36 +0000 Subject: [Koha-bugs] [Bug 9573] Ability to download items lost report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20831 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20831 [Bug 20831] (Bug 9573 follow-up) Pass id as first parameter instead of selector -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 11:09:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 09:09:26 +0000 Subject: [Koha-bugs] [Bug 20806] Column settings issues for holdshistory-table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|9573 |20831 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 [Bug 9573] Ability to download items lost report https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20831 [Bug 20831] (Bug 9573 follow-up) Pass id as first parameter instead of selector -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 11:09:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 09:09:26 +0000 Subject: [Koha-bugs] [Bug 9573] Ability to download items lost report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|20806 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 [Bug 20806] Column settings issues for holdshistory-table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 11:09:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 09:09:26 +0000 Subject: [Koha-bugs] [Bug 20831] (Bug 9573 follow-up) Pass id as first parameter instead of selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20831 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20806 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 [Bug 20806] Column settings issues for holdshistory-table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 11:10:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 09:10:16 +0000 Subject: [Koha-bugs] [Bug 20831] (Bug 9573 follow-up) Pass id as first parameter instead of selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20831 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 11:10:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 09:10:18 +0000 Subject: [Koha-bugs] [Bug 20831] (Bug 9573 follow-up) Pass id as first parameter instead of selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20831 --- Comment #1 from Josef Moravec --- Created attachment 75621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75621&action=edit Bug 20831: Fix KohaTable calls after bug 9573 Test plan: 0) Do not apply the patch 1) Confirm not working datatable on patrons hold history page 2) Apply the patch 3) The table should be working now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 11:59:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 09:59:51 +0000 Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 12:06:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 10:06:49 +0000 Subject: [Koha-bugs] [Bug 20028] Export all patron related personal data in one package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 --- Comment #2 from Jon Knight --- Created attachment 75622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75622&action=edit Bug 20028: Export all patron related personal data in one package Add a system preference to determine whether patron data export is permitted, and if it is an extra option in the staff UI to initiate the export. At this stage the API for patron data isn't ready so as a placeholder it just goes to the readingrec.pl script. Testing plan: * Apply patch. * Turn the AllowGDPRPatronExport in the administration sysprefs * Search for a patron (eg Mabel in the standard test data) and then click on the "More" button on the right hand side of the button bar. You should see "Export patron's GDPR data" option. Selecting that will currently just go to the readingrec.pl page. * Turn off AllowGDPRPatronExport in the administration sysprefs * The "Export patron's GDPR data" option should no long be visible from the "More" button in the patron page. Full description of what the patch does -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 12:11:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 10:11:03 +0000 Subject: [Koha-bugs] [Bug 20028] Export all patron related personal data in one package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Jon Knight changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |J.P.Knight at lboro.ac.uk --- Comment #3 from Jon Knight --- Note that my patch above is just the scaffolding to support this - it needs the APIs to extract all the data to be available and then call those. The alternative is to write a new script to gather all the patron data in a single data structure and then return that as JSON. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 12:47:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 10:47:04 +0000 Subject: [Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #2 from Kyle M Hall --- So basically, we need to check, in order that a) All checked records with MarcItemFieldsToOrder have a fund selected, OR b) All checked records have a fund selected, OR c) The account tab has a fund selected We also know that C will cascade to B, but does C *or* B cascade to A? If not, I imagine it should! To do otherwise seems like it would be counter-intuitive to librarians. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 29 12:57:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 10:57:36 +0000 Subject: [Koha-bugs] [Bug 20763] AllowPurchaseSuggestionBranchChoice triggers error opac-suggestions.pl is visited without logging in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20763 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75603|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 75623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75623&action=edit Bug 20763: Remove unecessary Koha::Patron fetch If $borrowernumber is not set, there is no userenv. So let's pick the library code set in the userenv instead of fetching the Koha::Patron->branchcode from DB Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 13:46:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 11:46:08 +0000 Subject: [Koha-bugs] [Bug 20832] New: Opac user page crash when there is an overdue fine and not any rental charge for a patron Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20832 Bug ID: 20832 Summary: Opac user page crash when there is an overdue fine and not any rental charge for a patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org To reproduce: Have an overdue fine linked with specific item currently checked out to you Do not have any unpaid rental fees Go to your profile in opac : opac-user.pl -> the page crash and you can see in log: Can't call method "get_column" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-user.pl line 217 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 13:46:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 11:46:17 +0000 Subject: [Koha-bugs] [Bug 20832] Opac user page crash when there is an overdue fine and not any rental charge for a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20832 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 13:50:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 11:50:21 +0000 Subject: [Koha-bugs] [Bug 20832] Opac user page crash when there is an overdue fine and not any rental charge for a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20832 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 13:50:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 11:50:24 +0000 Subject: [Koha-bugs] [Bug 20832] Opac user page crash when there is an overdue fine and not any rental charge for a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20832 --- Comment #1 from Josef Moravec --- Created attachment 75624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75624&action=edit Bug 20832: Fix opac user profile page when there is overdue fine and no rental charge Test plan: 0) Do not apply the patch 1) Have an overdue fine linked with specific item currently checked out to your patron 2) Do not have any unpaid rental fees 3) Go to this patron profile in opac - page opac-user.pl 4) The page crashes with "Can't call method "get_column" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-user.pl line 217" in log 5) Apply the patch 6) Restart plack 7) The page should working and show the right amounts for fines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 13:50:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 11:50:33 +0000 Subject: [Koha-bugs] [Bug 20832] Opac user page crash when there is an overdue fine and not any rental charge for a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20832 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 13:52:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 11:52:23 +0000 Subject: [Koha-bugs] [Bug 20806] Column settings issues for holdshistory-table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 13:52:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 11:52:26 +0000 Subject: [Koha-bugs] [Bug 20806] Column settings issues for holdshistory-table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 --- Comment #2 from Josef Moravec --- Created attachment 75625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75625&action=edit Bug 20806: Add item type description holds history page Test plan: 0) Do not apply the patch 1) Set AllowHoldItemTypeSelection to Allow 2) Place some hold for a patron, some with specific item type and some without item typ 3) On holds history page you should see blank or item type code in item type column 4) Apply the patch 5) Now you should see description in item type column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 13:53:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 11:53:17 +0000 Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement Summary|Column settings issues for |Item type in holds history |holdshistory-table |table should be write as | |description, not code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 14:04:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 12:04:17 +0000 Subject: [Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with Koha::UploadedFile->temporary_directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727 --- Comment #7 from Kyle M Hall --- Created attachment 75626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75626&action=edit Bug 20727: Move temporary_directory() to C4::Context -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 14:04:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 12:04:56 +0000 Subject: [Koha-bugs] [Bug 20651] Improve display of "Toggle full supplier metadata" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20651 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 14:04:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 12:04:59 +0000 Subject: [Koha-bugs] [Bug 20651] Improve display of "Toggle full supplier metadata" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20651 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75277|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 75627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75627&action=edit Bug 20561: Improve full supplier metadata display This patch improves the display of the extra metadata that may be returned by an ILL supplier. The display of the metadata has been moved from the "Toggle full supplier metadata" link at the bottom of the page to a button on the right of the request toolbar, labelled "Display supplier metadata". Clicking this button opens a modal displaying the metadata. To test: 1) Ensure ILL is enabled and you have at least one request 2) From the "View ILL requests" page, click "Manage request" on a request 3) Click the "Display supplier metadata" button on the right of the toolbar 4) Observe that a modal opens containing the metadata Signed-off-by: Magnus Enger The modal looks good! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 14:09:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 12:09:17 +0000 Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #33 from Kyle M Hall --- (In reply to Jonathan Druart from comment #32) > Before continuing here I think we should first confirm that the code is the > cause of the problem. > > I have talked with Nick last month and it seemed that it came from somewhere > else: > > """ > Errors in the logs "DBD::mysql::db begin_work failed: Already in a > transaction" - it seemed to increase during heavy circ periods - DB was > slowed by constant hits and then clashes > """ > > It does not sound related to this code, but more to rebuild_zebra.pl that > uses AutoCommit instead of a DBIC transaction. While that may be true, it does not change the fact that this feature *is* a performance killer. We've seen multiple instances of slow servers that having a immediate speed improvement simply by disabling this feature! Nothing about transactions has been mentioned on this bug previously, are you sure you are commenting on the correct bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 14:12:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 12:12:17 +0000 Subject: [Koha-bugs] [Bug 20779] Style refresh for patron detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 --- Comment #7 from Owen Leonard --- (In reply to Jonathan Druart from comment #5) > That's a lot of buttons! I've gotten feedback from librarians that the edit links were not visible enough. It's clearly an opinion, so we'll need to use our best judgement. > Would not it be better to move the "edit" button on the same line as the > header block ("Library use", "Alternate address", etc.)? The way I have it the edit button appears on the same line as the header if there is no content in the section, and at the bottom if there is. This is my preference, but I'm happy to be outvoted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 14:12:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 12:12:41 +0000 Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #34 from Marcel de Rooy --- I think we should not use the cache here. We will just dump too much in memory. Should we change lastseen to a date and check if NOW> lastseen ? This would skip a lot of writes ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 14:13:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 12:13:24 +0000 Subject: [Koha-bugs] [Bug 20779] Style refresh for patron detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 --- Comment #8 from Owen Leonard --- Created attachment 75628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75628&action=edit Screenshot highlighting markup structure. > Also (if not done already) it would be nice if in the future it would be > easier to hide the edit buttons together with the sections. I think I've already done what you're talking about. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 14:13:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 12:13:29 +0000 Subject: [Koha-bugs] [Bug 20831] (Bug 9573 follow-up) Pass id as first parameter instead of selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20831 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 14:13:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 12:13:32 +0000 Subject: [Koha-bugs] [Bug 20831] (Bug 9573 follow-up) Pass id as first parameter instead of selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20831 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75621|0 |1 is obsolete| | --- Comment #2 from S?verine Queune --- Created attachment 75629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75629&action=edit Bug 20831: Fix KohaTable calls after bug 9573 Test plan: 0) Do not apply the patch 1) Confirm not working datatable on patrons hold history page 2) Apply the patch 3) The table should be working now Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 14:15:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 12:15:01 +0000 Subject: [Koha-bugs] [Bug 20831] (Bug 9573 follow-up) Pass id as first parameter instead of selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20831 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr --- Comment #3 from S?verine Queune --- Works perfectly now, thanks Josef ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 14:44:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 12:44:46 +0000 Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #3 from S?verine Queune --- I'm quite confused... If I understand correctly the patch, the (new) column "Request item type" is filled with the hold level. Personally, I though to see the 'items.itype' value. As we only authorised item level holds because of our local use, it would have been more useful because with this patch we will only have "Any item itype" displayed. Can you confirm this is the behaviour you were waiting for ? If so, as patch applies correctly, I will sign it. PS : sorting option for the table is a good idea ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 14:51:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 12:51:00 +0000 Subject: [Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 14:51:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 12:51:04 +0000 Subject: [Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75448|0 |1 is obsolete| | --- Comment #12 from S?verine Queune --- Created attachment 75630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75630&action=edit Bug 11911: Add a separate permission for managing suggestions Without this patch only catalogue permission was required for managing suggestions. This patch adds a new permission in the acquisition module do manage suggestions and updates staff user permissions accordingly. To test: - Make sure there is a pending suggestion - Create a few users with different permission sets: - User 1: only catalogue - User 2: any acquisition permission - User 3: cataloguing permission - Check all of them can access: /cgi-bin/koha/suggestion/suggestion.pl - Apply the patch - Verify all of them now have the suggestions_manage permission - Verify everything displays correctly on: - intranet start page - patron account in staff - acquisition start page - suggestion page (try to access by URL too) - Remove suggestions_manage for a staff user - Repeat tests above, access should be denied/links not visible Bonus: - Fixes the link on the acquisition start page for late orders to mage the permissions of the page itself: order_receive Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 14:51:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 12:51:07 +0000 Subject: [Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75616|0 |1 is obsolete| | --- Comment #13 from S?verine Queune --- Created attachment 75631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75631&action=edit Bug 11911: (follow-up) Hide suggestion box on acq start page if no permission When the user is not superlibrarian or has the manage_suggestions permission, the suggestion box on the left of the acq start page needs to be hidden. Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 14:52:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 12:52:15 +0000 Subject: [Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 --- Comment #14 from S?verine Queune --- Both patchs ok for me, thank you Katrin ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 15:56:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 13:56:35 +0000 Subject: [Koha-bugs] [Bug 20341] Show authorized value description for withdrawn like damaged and lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20341 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 15:58:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 13:58:59 +0000 Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #35 from Kyle M Hall --- (In reply to Marcel de Rooy from comment #34) > I think we should not use the cache here. We will just dump too much in > memory. > Should we change lastseen to a date and check if NOW> lastseen ? This would > skip a lot of writes ? I actually think a hybrid of your first and second suggestions is the best solution. We should use cache *and* test a date! Why do you think we will use too much memory? Let's assume we have 1000 simultaneous users. That's still a minuscule amount of memory compared to caching the marc frameworks, for example. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:01:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:01:43 +0000 Subject: [Koha-bugs] [Bug 20833] New: Feature request: Better copy/paste for system preferences Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20833 Bug ID: 20833 Summary: Feature request: Better copy/paste for system preferences Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Sometimes it is useful to be able to copy and paste system preferences as text rather than screenshot -- the nature of the system preferences screen makes this very difficult to do, because often the most important text is the system preference values, which are either in a text box or labels in a drop down. For instance the system preference 'AcqCreateItem' has the text Create an item when [*?] This is only the default behavior, and can be changed per-basket. Where [*] is a drop down containing one of the values. - placing an order. - receiving an order. - cataloging the record. A simple copy and paste of the 'Value' box gives "Create an item when ? This is only the default behavior, and can be changed per-basket."; there's no way to copy the values in the drop down. I would be nice to have a 'copy to clipboard' button that would copy the 'preference' and 'value' fields. For instance if AcqCreateItem was set to 'placing an order', the following text would be placed in the copy/paste buffer: AcqCreateItem: Create an item when [placing an order.?] This is only the default behavior, and can be changed per-basket. If multiple system preferences show up in the 'Preference' field, they would be comma separated, e.g. LocalHoldsPriority, LocalHoldsPriorityPatronControl, LocalHoldsPriorityItemControl: [Don't give] priority for filling holds to patrons whose [pickup library] matches the item's [holding library] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:03:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:03:28 +0000 Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #36 from Kyle M Hall --- I forgot to add that this will be the fastest variation as well, since it is guaranteed to be only in memory as opposed to both session and direct db which would read and write to database or filesystem for everything ( except session => memcached which would still be slower with its added abstraction ). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:03:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:03:31 +0000 Subject: [Koha-bugs] [Bug 20763] AllowPurchaseSuggestionBranchChoice triggers error opac-suggestions.pl is visited without logging in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20763 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Jonathan Druart --- (In reply to Kyle M Hall from comment #7) > Created attachment 75623 [details] [review] > Signed-off-by: Kyle M Hall Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:04:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:04:29 +0000 Subject: [Koha-bugs] [Bug 18583] Add the ability to merge multiple authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18583 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:06:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:06:57 +0000 Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:07:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:07:00 +0000 Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75288|0 |1 is obsolete| | Attachment #75289|0 |1 is obsolete| | Attachment #75427|0 |1 is obsolete| | --- Comment #37 from Kyle M Hall --- Created attachment 75632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75632&action=edit Bug 18821 - TrackLastPatronActivity is a performance killer Test Plan: 1) Apply this patch 2) Start a new session ( a private browser window works well ) 3) Note the lastseen column in the borrowers table is updated 4) Browse a few pages, not the lastseen column is not updated again 5) Close the browser window and repeat steps 2-4 6) prove t/db_dependent/Auth.t Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:07:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:07:10 +0000 Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #38 from Kyle M Hall --- Created attachment 75633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75633&action=edit Bug 18821: Convert to using cache with date checking -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:08:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:08:21 +0000 Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #40 from Kyle M Hall --- Created attachment 75635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75635&action=edit Bug 18821: Convert to using cache with date checking -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:08:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:08:13 +0000 Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75632|0 |1 is obsolete| | Attachment #75633|0 |1 is obsolete| | --- Comment #39 from Kyle M Hall --- Created attachment 75634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75634&action=edit Switched description from using dash to using a colon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:08:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:08:42 +0000 Subject: [Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75634|Switched description from |Bug 18821: description|using dash to using a colon |TrackLastPatronActivity is | |a performance killer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:09:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:09:07 +0000 Subject: [Koha-bugs] [Bug 20781] 0 months is not a valid enrollment period and causes errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781 --- Comment #5 from Nick Clemens --- (In reply to Marcel de Rooy from comment #4) > Created attachment 75554 [details] [review] > Bug 20781: (QA follow-up) Remove unneeded rules > > These rules do not have any meaning. > > Signed-off-by: Marcel de Rooy Hmm...without these rules we can enter a value in both fields - going to skip this patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:09:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:09:10 +0000 Subject: [Koha-bugs] [Bug 20779] Style refresh for patron detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 --- Comment #9 from Jonathan Druart --- Maybe we should ask on the list? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:20:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:20:36 +0000 Subject: [Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Keywords| |RM_priority Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:35:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:35:46 +0000 Subject: [Koha-bugs] [Bug 20831] (Bug 9573 follow-up) Pass id as first parameter instead of selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20831 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:35:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:35:49 +0000 Subject: [Koha-bugs] [Bug 20831] (Bug 9573 follow-up) Pass id as first parameter instead of selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20831 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75629|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 75636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75636&action=edit Bug 20831: Fix KohaTable calls after bug 9573 Test plan: 0) Do not apply the patch 1) Confirm not working datatable on patrons hold history page 2) Apply the patch 3) The table should be working now Signed-off-by: S?verine QUEUNE Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:36:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:36:41 +0000 Subject: [Koha-bugs] [Bug 20825] Cannot checkout if item types at biblio level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #21 from Nick Clemens --- Pushed to master for 18.11. Awesome work all, thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:36:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:36:58 +0000 Subject: [Koha-bugs] [Bug 20652] Sort after item type search fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20652 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens --- Pushed to master for 18.11. Awesome work all, thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:37:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:37:15 +0000 Subject: [Koha-bugs] [Bug 20827] Can't add owner to a fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20827 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #4 from Nick Clemens --- Pushed to master for 18.11. Awesome work all, thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:37:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:37:35 +0000 Subject: [Koha-bugs] [Bug 20791] Correct capitalization on 'Notices and slips' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20791 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #4 from Nick Clemens --- Pushed to master for 18.11. Awesome work all, thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:37:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:37:36 +0000 Subject: [Koha-bugs] [Bug 20831] (Bug 9573 follow-up) Pass id as first parameter instead of selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20831 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20806 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:37:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:37:36 +0000 Subject: [Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20831 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:37:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:37:50 +0000 Subject: [Koha-bugs] [Bug 20752] Files tab in patron account is not properly capitalized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20752 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Pushed to master for 18.11. Awesome work all, thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:38:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:38:04 +0000 Subject: [Koha-bugs] [Bug 20774] Trivial HTML error in itemslost.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #8 from Nick Clemens --- Pushed to master for 18.11. Awesome work all, thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:38:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:38:22 +0000 Subject: [Koha-bugs] [Bug 3886] Can't print receipt w/out allowing "Add or modify borrowers" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3886 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens --- Pushed to master for 18.11. Awesome work all, thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:38:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:38:37 +0000 Subject: [Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens --- Pushed to master for 18.11. Awesome work all, thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:39:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:39:41 +0000 Subject: [Koha-bugs] [Bug 20781] 0 months is not a valid enrollment period and causes errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20781 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens --- Pushed to master for 18.11. Awesome work all, thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:40:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:40:27 +0000 Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20779 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 [Bug 20779] Style refresh for patron detail page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:40:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:40:27 +0000 Subject: [Koha-bugs] [Bug 20779] Style refresh for patron detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20809 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 [Bug 20809] Link patron image to patron image add/edit form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:41:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:41:54 +0000 Subject: [Koha-bugs] [Bug 20818] Missing QA manager entry in 18.05 release notes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20818 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Pushed to master for 18.11. Awesome work all, thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:44:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:44:04 +0000 Subject: [Koha-bugs] [Bug 20761] Advanced Cataloging Editor - Rancor - Some js files are not fetched using Asset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20761 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master QA Contact|testopia at bugs.koha-communit |chris at bigballofwax.co.nz |y.org | --- Comment #5 from Nick Clemens --- Pushed to master for 18.11. Awesome work all, thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:43:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:43:35 +0000 Subject: [Koha-bugs] [Bug 20696] Remove a few ugly "eq undef" comparisons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20696 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Pushed to master for 18.11. Awesome work all, thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:46:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:46:48 +0000 Subject: [Koha-bugs] [Bug 20798] Client side validation for for fund selection prevents adding only some records to a basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20798 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens --- Pushed to master for 18.11. I marked the followup 20830 as priority - this patch restores some previous issues, but is needed to prevent bigger issues in not being able to place orders, should be considered for backport Awesome work all, thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:49:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:49:28 +0000 Subject: [Koha-bugs] [Bug 20822] Can't find HOLD_SLIP template when printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20822 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens --- Pushed to master for 18.11. Awesome work all, thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 16:51:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 14:51:43 +0000 Subject: [Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #2 from Owen Leonard --- Created attachment 75637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75637&action=edit Screenshot of the modal window with 20779 as a dependency Adding Bug 20779 as a dependency makes it easier to show a more refined form in the modal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 17:16:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 15:16:41 +0000 Subject: [Koha-bugs] [Bug 18899] Tests should skip instead of failing when dependency modules are not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18899 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Failed QA |RESOLVED --- Comment #4 from Lee Jamison --- As of the time of this comment the tests no longer fail but instead skip if modules are not installed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 17:17:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 15:17:31 +0000 Subject: [Koha-bugs] [Bug 17215] Cardnumbers of patrons created using LDAP Replication not using autoMemberNum if configured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 17:42:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 15:42:29 +0000 Subject: [Koha-bugs] [Bug 20779] Style refresh for patron detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 --- Comment #10 from Owen Leonard --- Created attachment 75638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75638&action=edit Screenshot showing buttons in line with headings Here is a screenshot of what it might look like with the edit buttons inline with headings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 17:55:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 15:55:59 +0000 Subject: [Koha-bugs] [Bug 20825] Cannot checkout if item types at biblio level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20825 --- Comment #22 from Nick Clemens --- Created attachment 75639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75639&action=edit Bug 20825: (QA follow-up) set biblioitemnumber with correct value Both biblionumber and biblioitemnumber for item were set to biblionumber, when they don't line up tests fail Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 18:16:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 16:16:12 +0000 Subject: [Koha-bugs] [Bug 17293] Checkout viewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17293 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 18:23:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 16:23:15 +0000 Subject: [Koha-bugs] [Bug 11377] Add a framework for files in NORMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11377 --- Comment #1 from Owen Leonard --- NORMARC bugs can now be considered obsolete. See Bug 18984. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 18:23:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 16:23:46 +0000 Subject: [Koha-bugs] [Bug 11379] Add framework for music recordings and printed music in NORMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11379 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|ASSIGNED |RESOLVED --- Comment #1 from Owen Leonard --- NORMARC bugs can now be considered obsolete. See Bug 18984. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 18:23:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 16:23:54 +0000 Subject: [Koha-bugs] [Bug 11378] Add framework for movies in NORMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11378 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |INVALID --- Comment #2 from Owen Leonard --- NORMARC bugs can now be considered obsolete. See Bug 18984. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 18:23:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 16:23:37 +0000 Subject: [Koha-bugs] [Bug 11377] Add a framework for files in NORMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11377 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 18:24:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 16:24:07 +0000 Subject: [Koha-bugs] [Bug 13916] NORMARC can have analytics with leader 07 = a, b or p In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13916 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |INVALID --- Comment #5 from Owen Leonard --- NORMARC bugs can now be considered obsolete. See Bug 18984. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 18:24:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 16:24:16 +0000 Subject: [Koha-bugs] [Bug 7208] NORMARCslim2OPACDetail.xsl does not display item type icon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7208 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |INVALID --- Comment #2 from Owen Leonard --- NORMARC bugs can now be considered obsolete. See Bug 18984. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 18:26:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 16:26:17 +0000 Subject: [Koha-bugs] [Bug 10826] Add schema.org microdata for NORMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10826 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Owen Leonard --- NORMARC bugs can now be considered obsolete. See Bug 18984. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 18:26:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 16:26:26 +0000 Subject: [Koha-bugs] [Bug 11376] Add a framework for maps in NORMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11376 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|ASSIGNED |RESOLVED --- Comment #1 from Owen Leonard --- NORMARC bugs can now be considered obsolete. See Bug 18984. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 18:26:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 16:26:07 +0000 Subject: [Koha-bugs] [Bug 7490] Add CSS classes/ids to OPAC and staff NORMARC XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7490 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #3 from Owen Leonard --- NORMARC bugs can now be considered obsolete. See Bug 18984. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 18:26:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 16:26:46 +0000 Subject: [Koha-bugs] [Bug 15169] Add for NORMARC transformation to new metadata formats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15169 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |INVALID --- Comment #8 from Owen Leonard --- NORMARC bugs can now be considered obsolete. See Bug 18984. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 18:26:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 16:26:47 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Bug 13642 depends on bug 15169, which changed state. Bug 15169 Summary: Add for NORMARC transformation to new metadata formats https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15169 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 18:26:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 16:26:58 +0000 Subject: [Koha-bugs] [Bug 16380] Indicate that a record is suppressed in staff - for NORMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16380 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Owen Leonard --- NORMARC bugs can now be considered obsolete. See Bug 18984. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 18:27:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 16:27:15 +0000 Subject: [Koha-bugs] [Bug 7543] Update NORMARC support to the 2012-01-19 revision In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7543 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #3 from Owen Leonard --- NORMARC bugs can now be considered obsolete. See Bug 18984. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 18:27:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 16:27:26 +0000 Subject: [Koha-bugs] [Bug 10930] Invalid reference to opac on staff NORMARC XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10930 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Owen Leonard --- NORMARC bugs can now be considered obsolete. See Bug 18984. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 18:27:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 16:27:06 +0000 Subject: [Koha-bugs] [Bug 10997] Modernize value_builders for NORMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10997 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Owen Leonard --- NORMARC bugs can now be considered obsolete. See Bug 18984. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 18:27:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 16:27:35 +0000 Subject: [Koha-bugs] [Bug 11380] Add a framework for Periodics in the NORMARC framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11380 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Owen Leonard --- NORMARC bugs can now be considered obsolete. See Bug 18984. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 19:39:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 17:39:24 +0000 Subject: [Koha-bugs] [Bug 17886] Don't show option to add to existing list if there are no lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61117|0 |1 is obsolete| | --- Comment #11 from Owen Leonard --- Created attachment 75640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75640&action=edit Bug 17886: Don't show option to add to existing list if there are no lists This patch modifies the page for adding a title to a list so that the "Add to existing list" option doesn't appear if there are no lists defined. TEST PLAN --------- 1) Make sure no lists exist at all. 2) Make there is at least one findable biblio record entered 3) Find that biblio record in the OPAC 4) Click 'Save to your lists' -- Notice that the whole save to list section is there. 5) Apply this patch 6) Click 'Cancel' 7) Click 'Save to your lists' -- Notice you can only add now, which makes sense. 8) Run koha qa test tools. Perform the same tests in the staff client. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 19:39:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 17:39:21 +0000 Subject: [Koha-bugs] [Bug 17886] Don't show option to add to existing list if there are no lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 19:52:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 17:52:59 +0000 Subject: [Koha-bugs] [Bug 19031] Purchase Suggestion Submission Notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19031 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Lee Jamison --- *** This bug has been marked as a duplicate of bug 13014 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 19:52:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 17:52:59 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to the fund owner when a suggestion can be treated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ldjamison at marywood.edu --- Comment #50 from Lee Jamison --- *** Bug 19031 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 20:07:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 18:07:57 +0000 Subject: [Koha-bugs] [Bug 10437] Greater flexibility on Marc Edit screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10437 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #1 from Tom?s Cohen Arazi --- I'm confused about this bug report. If it is about the MarcEdit tool (http://marcedit.reeset.net/) then it is INVALID. If it is proposing a new way to edit MARC records within Koha, then it is quite similar to Rancor (the expert cataloguing interface) and thus any bugs should be filed against it (included in mainline Koha). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 20:16:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 18:16:37 +0000 Subject: [Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 20:16:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 18:16:40 +0000 Subject: [Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 --- Comment #23 from Owen Leonard --- Created attachment 75641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75641&action=edit Bug 16939: (follow-up) Correction for orderreceive.tt This patch makes a change to orderreceive.tt which corresponds to the changes made in the previous patch. To test, apply the patch and set the AcqCreateItem system preference to "receiving an order." - Go to Acquisitions -> Vendor -> Receive shipment. - Submit the "Receive a new shipment" form. - Click "Receive" for an order line. - Fill out the item form and click "Add item." - The table of existing items should display correctly, with a single "Actions" column containing an "Edit" and "Delete" button. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 20:28:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 18:28:52 +0000 Subject: [Koha-bugs] [Bug 19902] Add column configuration to bibliographic record checkouts history table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19902 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 20:28:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 18:28:55 +0000 Subject: [Koha-bugs] [Bug 19902] Add column configuration to bibliographic record checkouts history table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19902 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70220|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 75642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75642&action=edit Bug 19902: Add column settings to bibliographic record checkouts history table Test plan: 0) Apply the patch 1) Go to administration -> Configure columns, note there is new checkoutshistory-table in Catalogue section 2) Make some configuration in this table settings 3) Go to detail of any record -> Checkout history 4) The columns should be visible according to your configuration from step 2 5) Play with Column visibility, to ensure it does work as it should Signed-off-by: Owen Leonard Fixed a minor typo during signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 20:40:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 18:40:20 +0000 Subject: [Koha-bugs] [Bug 8457] No results found on term/phrase click in scan index results list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8457 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ldjamison at marywood.edu --- Comment #10 from Lee Jamison --- I do not run into this problem on the current master (18.06.00.000). Test plan I followed: 1.) Verify the QueryAutoTruncate syspref is set to "automatically" 2.) Navigate to Advanced Search 3.) If not already toggled, click "More options" next to the search button 4.) Select Search for --> Title as phrase --> "ivory" (without quotes) 5.) Tick the box for "Scan indexes" 6.) Click Search 7.) Results should appear 8.) Set the QueryAutoTruncate syspref to "only if * is added" 9.) Repeat steps 2-7 10.) Results should still appear -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 20:52:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 18:52:41 +0000 Subject: [Koha-bugs] [Bug 18879] Sending notices via Facebook messenger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18879 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ldjamison at marywood.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 21:19:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 19:19:57 +0000 Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 David Bourgault changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73035|0 |1 is obsolete| | --- Comment #60 from David Bourgault --- Created attachment 75643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75643&action=edit Bug 17674: Allow UI to delete serials in batch This new feature allows for batch deletion of serials through the UI. The current usage is a one-by-one long game. Testing - Have at least three serials, with items - check the box to select two of them - Press the Remove selected issues button - Decide to delete their items as well or not - Validate. Sponsored by : CCSR Signed-off-by: Sonia BOUIS Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 21:20:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 19:20:17 +0000 Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 David Bourgault changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73036|0 |1 is obsolete| | --- Comment #61 from David Bourgault --- Created attachment 75644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75644&action=edit Bug 17674: Fix problem tabs Signed-off-by: Sonia BOUIS Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 21:20:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 19:20:25 +0000 Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 David Bourgault changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73037|0 |1 is obsolete| | --- Comment #62 from David Bourgault --- Created attachment 75645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75645&action=edit Bug 17674: Add unit tests https://bugs.koha-community.org/show_bug.cgi?id=17674 Signed-off-by: Sonia BOUIS Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 21:20:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 19:20:42 +0000 Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 David Bourgault changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73039|0 |1 is obsolete| | --- Comment #64 from David Bourgault --- Created attachment 75647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75647&action=edit Bug 17674: Adapting Serials.t to the namespace change Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 21:20:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 19:20:51 +0000 Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 David Bourgault changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73040|0 |1 is obsolete| | --- Comment #65 from David Bourgault --- Created attachment 75648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75648&action=edit Bug 17674: Renamed GetSerialItemsInformations to get_serial_items_count and use new OOP logic Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 21:20:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 19:20:34 +0000 Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 David Bourgault changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73038|0 |1 is obsolete| | --- Comment #63 from David Bourgault --- Created attachment 75646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75646&action=edit Bug 17674: Move subroutine GetSerialItemsInformations to Koha/Serials.pm Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 29 21:21:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 May 2018 19:21:01 +0000 Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 David Bourgault changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74359|0 |1 is obsolete| | Attachment #74472|0 |1 is obsolete| | --- Comment #66 from David Bourgault --- Created attachment 75649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75649&action=edit Bug 17674: (follow-up) Fix some HTML and JS inconsistencies This patch makes some HTML and JS changes to make the template more consistent with coding guidelines and other similar interfaces. - The confirmation dialog is now below the heading. Buttons are styled to match others like them. The layout of messages hopefully makes it a little more clear. - The "delete selected" event handler has been moved from an "onclick" attribute into the