[Koha-bugs] [Bug 20692] New: koha-plack doesn't check for Include *-plack.conf line in /etc/apache2/sites-available/$ISNTANCE.conf

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue May 1 22:26:39 CEST 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20692

            Bug ID: 20692
           Summary: koha-plack doesn't check for Include *-plack.conf line
                    in /etc/apache2/sites-available/$ISNTANCE.conf
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: ropuch at bagno.be
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

When enabling Plack, koha-plack uncomment plack related Include in instance's
apache conf. Little problem occurs when old pre-plack configs are used, without
required Include lines. In this case koha-plack still report success, with no
change done.

So in the end we have running Plack, but it's doing nothing. plack.log is
empty, but there is an entry in plack-error.log that can trick people into
thinking they have Plack properly configured and running:

2018/05/01-21:06:27 Starman::Server (type Net::Server::PreFork) starting!
pid(10257)
Binding to UNIX socket file "/var/run/koha/galway/plack.sock"
Setting gid to "1001 1001"
Setting uid to "1001"

koha-plack:enable_plack() should check if Plack lines exists before trying to
uncomment them and either fail with warn message, or add them.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list