[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #240 from Julian Maurice <julian.maurice at biblibre.com> ---
Katrin, thanks for the review !

I did a bit of cleanup here : I squashed all patches into only two patches and
removed all changes that were not related to (or needed by) this patchset. I
think it will be easier to read.
QA script is happy now and I think I fixed every problem you mentioned in
comment 237, except for the following:

> +            my $pdfformatfile = './' . ($pdfformat =~ s,::,/,gr) . '.pm';
> +            require $pdfformatfile;
> Seems to be an unrelated change? I remember that we hardcoded the valid template names once for added security. could only find one mention of it tho: bug 11459#c11
It's just part of the "basketgroup.pl cleanup" process. perlcritic complains
when we use the eval "string" construct. It shouldn't change anything.

> f) Changes to koha-tmpl/intranet-tmpl/prog/js/datatables.js
> Do you remember why those changes were needed or was it not intentional? Trying to figure out what needs to be tested with this patch and it turns out a lot of code is touched.
I don't remember why exactly, but I needed to use the 1.10+ API of DataTables.
These changes just map legacy API defaults to new API ones. This shouldn't
change anything for code using the legacy API.

-- 
You are receiving this mail because:
You are watching all bug changes.