[Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates 23+24+25 (Nov 2016, May and Dec 2017)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 75044
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75044
Bug 20709: Update GERMAN MARC frameworks to Updates 23+24+25 (Nov 2016, May and
Dec 2017)

Review of attachment 75044:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20709&attachment=75044)
-----------------------------------------------------------------

:::
installer/data/mysql/de-DE/marcflavour/marc21/optional/marc21_sample_fastadd_framework.sql
@@ +86,4 @@
>  UPDATE marc_subfield_structure SET hidden ='0' WHERE tagfield = '952' AND tagsubfield = 'r' AND frameworkcode = 'FA';
>  UPDATE marc_subfield_structure SET hidden ='0' WHERE tagfield = '952' AND tagsubfield = 's' AND frameworkcode = 'FA';
>  UPDATE marc_subfield_structure SET hidden ='0' WHERE tagfield = '952' AND tagsubfield = 'x' AND frameworkcode = 'FA';
> +

If a blank line is the only difference, perhaps it should not be part of the
patch?

:::
installer/data/mysql/de-DE/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql
@@ -520,5 @@
> -INSERT INTO marc_subfield_structure(tagfield, tagsubfield, liblibrarian, libopac, repeatable, mandatory, kohafield, tab, authorised_value, authtypecode, value_builder, isurl, hidden, frameworkcode, seealso, link, defaultvalue, maxlength)
> -SELECT tagfield, tagsubfield, liblibrarian, libopac, repeatable, mandatory, kohafield, tab, authorised_value, authtypecode, value_builder, isurl, hidden, 'ACQ', seealso, link, defaultvalue, maxlength
> -FROM marc_subfield_structure
> -WHERE frameworkcode=""
> -AND kohafield IN ("biblio.title", "biblio.author", "biblioitems.publishercode", "biblioitems.editionstatement", "biblio.copyrightdate", "biblioitems.isbn", "biblio.seriestitle" );

Why remove this?

-- 
You are receiving this mail because:
You are watching all bug changes.