[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri May 4 15:18:12 CEST 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #56 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
1. There is 'Account Writeoff' vs 'Account writeoff'

2. In Koha::Account->pay, why require C4::Letters; instead of use?

3. Koha/Account.pm:273
  lang    => Koha::Patrons->find( $self->{patron_id} )->lang,
No need to refetch the patron object, you did it already at the beginning of
the method.

4. Koha/Account.pm:280
  offsets => scalar Koha::Account::Offsets->search( { id => { -in => [ map {
$_->id } @account_offsets ] } } ),

I do not understand this line, we are refetching what we already have?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list