[Koha-bugs] [Bug 5789] Fines don't work when items have null homebranch

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sun May 6 15:45:53 CEST 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5789

Saiful Amin <saiful at semanticconsulting.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |saiful at semanticconsulting.c
                   |                            |om

--- Comment #4 from Saiful Amin <saiful at semanticconsulting.com> ---
This is not a data issue but a bug in the code. Here are the lines:

109     my $branchcode =
110         ( $control eq 'ItemHomeLibrary' ) ? $overdue->{homebranch}
111       : ( $control eq 'PatronLibrary' )   ? $borrower->{branchcode}
112       :                                     $overdue->{branchcode};
113

The variable $overdue->{homebranch} is bad because the 'issues' table has no
column called 'homebranch'. It should be 'branchcode' instead. I'm able to fix
the error by changing the line 110 to this:

110         ( $control eq 'ItemHomeLibrary' ) ? $overdue->{branchcode}

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.


More information about the Koha-bugs mailing list