[Koha-bugs] [Bug 5789] Fines don't work when items have null homebranch

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5789

Saiful Amin <saiful at semanticconsulting.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |Needs Signoff

--- Comment #7 from Saiful Amin <saiful at semanticconsulting.com> ---
I've done some more digging into this and found that it was indeed a data
issue, the item itself was missing. Single record caused the failure.

I feel that the error message does not do justice to the error. The script
should not crash on faulty data. The final fix that I would suggest is this (as
suggested in Comment #3):

  109     my $branchcode =
  110         ( $control eq 'ItemHomeLibrary' ) ? $overdue->{homebranch}
  111       : ( $control eq 'PatronLibrary' )   ? $borrower->{branchcode}
  112       :                                     $overdue->{branchcode};
+ 113     if (!defined $branchcode ) {
+ 114         carp "ERROR in getting branchcode. Skipping record.\n";
+ 115         next;
+ 116     }
  117
  118 # In final case, CircControl must be PickupLibrary. (branchcode comes
from issues table here).
  119     if ( !exists $is_holiday{$branchcode} ) {
  120         $is_holiday{$branchcode} = set_holiday( $branchcode, $today );

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.