[Koha-bugs] [Bug 20703] Add ability to void any credit

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20703

--- Comment #3 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 75013
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75013
Bug 20703: Add ability to void any credit

Review of attachment 75013:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20703&attachment=75013)
-----------------------------------------------------------------

::: Koha/Account/Line.pm
@@ +60,4 @@
>      my ($self) = @_;
>  
>      # Make sure it is a payment we are voiding
> +    return unless $self->amount < 0;

Much nicer to not be dependent on a particular text.

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
@@ +77,5 @@
> +                [% END %]
> +                [% IF account.amount < 0 %]
> +                    <a href="boraccount.pl?action=void&accountlines_id=[% account.accountlines_id %]&borrowernumber=[% account.borrowernumber %]" class="btn btn-default btn-xs"><i class="fa fa-ban"></i> Void</a>
> +                [% END %]
> +          [% ELSE %]

Nice catch on the footerjs already at the top of the file.

-- 
You are receiving this mail because:
You are watching all bug changes.