[Koha-bugs] [Bug 16739] generate edifact showing on basket groups

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16739

--- Comment #8 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
(In reply to Owen Leonard from comment #7)
> This looks like it's working correctly, but the QA tool has several
> complaints about tab indentation. Indentation should always be done with 4
> spaces.
> 
> There is one part of the template which I don't understand, starting at line
> 149:
> 
> [% IF (ediaccount) %]
>     <div class="btn-group"><a href="[% script_name
> %]?op=ediprint&basketgroupid=[% basketgroupid %]&booksellerid=[%
> booksellerid %]" class="btn btn-default btn-sm" id="printbutton"><i
> class="fa fa-download"></i> Generate EDIFACT order</a></div>
> [% ELSE %]
>     <div class="btn-group"><a href="[% script_name
> %]?op=ediprint&basketgroupid=[% basketgroupid %]&booksellerid=[%
> booksellerid %]" class="btn btn-default btn-sm" id="printbutton"></div>
> [% END %]
> 
> What is the purpose of the [% ELSE %] section? The <a> tag is incomplete, so
> I would expect this to break HTML rendering somehow.

Ah, good spot - I was putting in other text whilst testing the patch and left
the rump in there (but it didn't display on the browser so I didn't notice it).
 I'll get rid of the else clause (and see if I can munge the indentation into
something more acceptable!).

-- 
You are receiving this mail because:
You are watching all bug changes.