[Koha-bugs] [Bug 11943] Koha::Virtualshelfshare duplicates rows for the same list

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75120|0                           |1
        is obsolete|                            |
  Attachment #75121|0                           |1
        is obsolete|                            |
  Attachment #75122|0                           |1
        is obsolete|                            |

--- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 75246
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75246&action=edit
Bug 11943: Prevent duplicating rows in Koha::Virtualshelfshare

This 'bug' existed long enough now to finally remove it ;)

We do so by deleting the invitation if the borrower already has a share
on this list. The user does not notice that, since he is redirected to
the list view just as before.

We still need: a unit test and a db revision.

Test plan:
[1] Share a list. Let user B accept.
[2] Without this patch: Share again and let B accept again.
[3] Verify that you have two shares for this list in virtualshelfshares.
[4] With this patch: Share another list, let B accept.
[5] Share this other list again, let B accept again.
[6] Verify that virtualshelfshares does not contain double entries now.
    (Note: This pertains to the second list only.)

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.