[Koha-bugs] [Bug 20770] ILL loans OPAC form notes field allow arbitrary input

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20770

--- Comment #2 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 75335
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75335&action=edit
Bug 20770: ILL loans OPAC form notes field allow arbitrary input

This patch addresses the lack of sanitization of the "notes" field on
the OPAC "View Interlibrary loan request" page.

To test:

- Apply the patch
- As an OPAC user, create an ILL request
- Navigate to the request's "View Interlibrary loan request" page
- Add the following note:

  Hello
  <h1>TESTING</h1>
  <script>alert('pwned');</script>

- Click "Submit modifications"
- TEST: Observe, when the page reloads, only the following is preserved in the
"Notes" textarea:

    Hello
    TESTING

- As a staff user, naviate to the ILL requests table
- Select "Manage request" for the request you created
- TEST: Observe that the Notes field only contains:

    Hello
    TESTING

- TEST: Observe that no Javascript alert is displayed

-- 
You are receiving this mail because:
You are watching all bug changes.